| HEAD | b8c9a25 | Add AttributeGroupIterator to Stress Test (#12776) Summary: As title. Changes include the following - `Refresh()` moved from `Iterator` interface to `IteratorBase` so that `AttributeGroupIterator` can also have Refresh() API (implemention will be added in the future PR) - `TestIterate()`'s main logic refactored into `TestIterateImpl()` so that it can be shared with `TestIterateAttributeGroups()` - `VerifyIterator()` also changed so that verification code can be shared between `Iterator` and `AttributeGroupIterator` Pull Request resolved: https://github.com/facebook/rocksdb/pull/12776 Test Plan: Single CF Iterator ``` python3 tools/db_crashtest.py blackbox --simple --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=0 --use_put_entity_one_in=1 --use_multi_get=1 --use_multi_cf_iterator=0 --verify_iterator_with_expected_state_one_in=2 ``` CoalescingIterator ``` python3 tools/db_crashtest.py blackbox --simple --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=0 --use_put_entity_one_in=1 --use_multi_get=1 --use_multi_cf_iterator=1 --verify_iterator_with_expected_state_one_in=2 ``` AttributeGroupIterator ``` python3 tools/db_crashtest.py blackbox --simple --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=1 --use_put_entity_one_in=1 --use_multi_get=1 --use_multi_cf_iterator=1 --verify_iterator_with_expected_state_one_in=2 ``` Reviewed By: cbi42 Differential Revision: D58626165 Pulled By: jaykorean fbshipit-source-id: 3e0a6ff72e51ecef9e06b65acfa53605a24d742e | 17 June 2024, 18:25:30 UTC |
| refs/heads/2.2.fb.branch | fe63723 | [FB Internal] Point to the latest tool chain. | 31 October 2019, 21:10:18 UTC |
| refs/heads/2.3.fb.branch | 7fae451 | Fix two odd assertions. | 31 October 2019, 23:39:02 UTC |
| refs/heads/2.4.fb.branch | 1bd63cf | Fix two odd assertions. | 31 October 2019, 23:39:02 UTC |
| refs/heads/2.5.fb.branch | 0a50187 | Fix two odd assertions. | 31 October 2019, 23:39:02 UTC |
| refs/heads/2.6.fb.branch | 0c5d4f0 | Fix two odd assertions. | 31 October 2019, 23:39:02 UTC |
| refs/heads/2.7 | f8a42a7 | fb internal: Should also use GCC 4.8.1 for CentOS 7 | 12 October 2016, 22:47:53 UTC |
| refs/heads/2.7.fb.branch | 7eb9776 | An odd fix for GCC 7 | 31 October 2019, 22:06:10 UTC |
| refs/heads/2.8.1.fb | 7a8cee8 | Disable warning as error | 31 October 2019, 21:42:34 UTC |
| refs/heads/2.8.fb | 2c1ef06 | Flush before Fsync()/Sync() Summary: Calling Fsync()/Sync() on a file should give the guarantee that whatever you written to the file is now persisted. This is currently not the case, since we might have some data left in application cache as we do Fsync()/Sync(). For example, BuildTable() calls Fsync() without the flush, assuming all sst data is now persisted, but it's actually not. This may result in big inconsistencies. Test Plan: no test Reviewers: sdong, dhruba, haobo, ljin, yhchiang Reviewed By: sdong CC: leveldb Differential Revision: https://reviews.facebook.net/D18159 | 22 April 2014, 00:45:04 UTC |
| refs/heads/2.8.fb.trunk | fcfb666 | Make Huge Page TLB disabled by default in hash linked list memtable | 04 May 2014, 21:27:50 UTC |
| refs/heads/3.0.fb | a1a1f61 | Fix iOS compile | 08 May 2014, 00:49:23 UTC |
| refs/heads/3.0.fb.branch | a75ae66 | One extra include<functional> | 31 October 2019, 22:15:05 UTC |
| refs/heads/3.1.fb | 303193a | An odd fix for GCC 7 | 31 October 2019, 22:06:10 UTC |
| refs/heads/3.10.fb | ab33322 | Add one more #include<functional> | 05 November 2019, 17:25:25 UTC |
| refs/heads/3.11.fb | 7e50766 | Add one more #include<functional> | 05 November 2019, 17:25:25 UTC |
| refs/heads/3.12.fb | 7ec5bac | Add one more #include<functional> | 05 November 2019, 17:25:25 UTC |
| refs/heads/3.13.fb | 2b90ba0 | Add one more #include<functional> | 05 November 2019, 17:25:25 UTC |
| refs/heads/3.2.fb | 767c282 | An odd fix for GCC 7 | 31 October 2019, 22:06:10 UTC |
| refs/heads/3.3.fb | 92df749 | An odd fix for GCC 7 | 31 October 2019, 22:06:10 UTC |
| refs/heads/3.4.fb | 92a27e2 | Disable warning as error | 31 October 2019, 21:42:34 UTC |
| refs/heads/3.5.fb | ce87213 | An odd fix for GCC 7 | 31 October 2019, 22:06:10 UTC |
| refs/heads/3.6.fb | 67b897a | An odd fix for GCC 7 | 31 October 2019, 22:06:10 UTC |
| refs/heads/3.7.fb | 22c7a01 | One more include<functional> | 31 October 2019, 21:48:26 UTC |
| refs/heads/3.8.fb | 7e4a06c | One more include<functional> | 31 October 2019, 21:48:26 UTC |
| refs/heads/3.9.fb | cc0ba3d | One more include<functional> | 31 October 2019, 21:48:26 UTC |
| refs/heads/4.0.fb | a180b60 | Add one more #include<functional> | 05 November 2019, 17:25:25 UTC |
| refs/heads/4.1.fb | 18a3d83 | Add one more #include<functional> | 05 November 2019, 17:25:25 UTC |
| refs/heads/4.10.fb | d903241 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.11.fb | 32fda17 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.12.fb | 4844d69 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.13.fb | f2fc398 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.2.fb | e80a7f4 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.3.fb | 5b40c0c | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.4.fb | 1ad2267 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.5.fb | 75cde85 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.6.fb | b026bfd | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.7.fb | 4d6ba85 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.8.fb | 52a2cc5 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/4.9.fb | 1e92c36 | Disable error as warning | 05 November 2019, 18:57:56 UTC |
| refs/heads/5.0.fb | fe55e3e | remove warning as error. | 05 November 2019, 19:06:51 UTC |
| refs/heads/5.1.fb | 3500b72 | Disable warning as error | 05 November 2019, 19:08:10 UTC |
| refs/heads/5.10.fb | 5d5e811 | Fix GitHub issue #3716: gcc-8 warnings Summary: Fix the following gcc-8 warnings: - conflicting C language linkage declaration [-Werror] - writing to an object with no trivial copy-assignment [-Werror=class-memaccess] - array subscript -1 is below array bounds [-Werror=array-bounds] Solves https://github.com/facebook/rocksdb/issues/3716 Closes https://github.com/facebook/rocksdb/pull/3736 Differential Revision: D7684161 Pulled By: yiwu-arbug fbshipit-source-id: 47c0423d26b74add251f1d3595211eee1e41e54a | 20 April 2018, 20:28:05 UTC |
| refs/heads/5.11.fb | 201cf64 | Fix GitHub issue #3716: gcc-8 warnings Summary: Fix the following gcc-8 warnings: - conflicting C language linkage declaration [-Werror] - writing to an object with no trivial copy-assignment [-Werror=class-memaccess] - array subscript -1 is below array bounds [-Werror=array-bounds] Solves https://github.com/facebook/rocksdb/issues/3716 Closes https://github.com/facebook/rocksdb/pull/3736 Differential Revision: D7684161 Pulled By: yiwu-arbug fbshipit-source-id: 47c0423d26b74add251f1d3595211eee1e41e54a | 20 April 2018, 20:28:05 UTC |
| refs/heads/5.12.fb | 73fc71f | Fix GitHub issue #3716: gcc-8 warnings Summary: Fix the following gcc-8 warnings: - conflicting C language linkage declaration [-Werror] - writing to an object with no trivial copy-assignment [-Werror=class-memaccess] - array subscript -1 is below array bounds [-Werror=array-bounds] Solves https://github.com/facebook/rocksdb/issues/3716 Closes https://github.com/facebook/rocksdb/pull/3736 Differential Revision: D7684161 Pulled By: yiwu-arbug fbshipit-source-id: 47c0423d26b74add251f1d3595211eee1e41e54a | 20 April 2018, 20:28:05 UTC |
| refs/heads/5.13.fb | be955bf | Fix GitHub issue #3716: gcc-8 warnings Summary: Fix the following gcc-8 warnings: - conflicting C language linkage declaration [-Werror] - writing to an object with no trivial copy-assignment [-Werror=class-memaccess] - array subscript -1 is below array bounds [-Werror=array-bounds] Solves https://github.com/facebook/rocksdb/issues/3716 Closes https://github.com/facebook/rocksdb/pull/3736 Differential Revision: D7684161 Pulled By: yiwu-arbug fbshipit-source-id: 47c0423d26b74add251f1d3595211eee1e41e54a | 20 April 2018, 20:28:05 UTC |
| refs/heads/5.13.fb.myrocks | 7705123 | Reduce tail prefetching from 512KB to 4KB Summary: https://github.com/facebook/rocksdb/pull/4159 has a merging conflict so it can't be easily merged. To minimize the risk of merging, we just simply change 512KB to 4KB. It should be OK for MyRocks. Test Plan: Make all check | 20 July 2018, 22:55:48 UTC |
| refs/heads/5.14.fb | 04f6516 | Fix build errors related to util/status.cc Summary: This is related to the upgrade to gcc7. The code change itself is lifted from the following commits: https://github.com/facebook/rocksdb/commit/78ab11cd7154c683f9a44d3524ee9c7acea4ade6 https://github.com/facebook/rocksdb/commit/7bee48bdbd8582c84dba8ce8e7273c9b9b367d7c | 29 October 2019, 17:46:37 UTC |
| refs/heads/5.14.fb.myrocks | 8756a11 | WritePrepared: Fix bug in searching in non-cached snapshots (#4639) Summary: When evicting an entry form the commit_cache, it is verified against the list of old snapshots to see if it overlaps with any. The list of old snapshots is split into two lists: an efficient concurrent cache and an slow vector protected by a lock. The patch fixes a bug that would stop the search in the cache if it finds any and yet would not include the larger snapshots in the slower list. An extra info log entry is also removed. The condition to trigger that although very rare is still feasible and should not spam the LOG when that happens. Fixes #4621 Pull Request resolved: https://github.com/facebook/rocksdb/pull/4639 Differential Revision: D12934989 Pulled By: maysamyabandeh fbshipit-source-id: 4e0fe8147ba292b554ae78e94c21c2ef31e03e2d | 06 November 2018, 07:02:01 UTC |
| refs/heads/5.15.fb | b8d5f90 | Making platform 007 (gcc 7) default in build_detect_platform.sh (#5947) Summary: Making platform 007 (gcc 7) default in build_detect_platform.sh. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5947 Differential Revision: D18038837 Pulled By: vjnadimpalli fbshipit-source-id: 9ac2ddaa93bf328a416faec028970e039886378e | 21 October 2019, 19:07:58 UTC |
| refs/heads/5.16.fb | 0113c61 | Making platform 007 (gcc 7) default in build_detect_platform.sh (#5947) Summary: Making platform 007 (gcc 7) default in build_detect_platform.sh. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5947 Differential Revision: D18038837 Pulled By: vjnadimpalli fbshipit-source-id: 9ac2ddaa93bf328a416faec028970e039886378e | 21 October 2019, 19:07:58 UTC |
| refs/heads/5.17.fb | 764bfcd | Making platform 007 (gcc 7) default in build_detect_platform.sh (#5947) Summary: Making platform 007 (gcc 7) default in build_detect_platform.sh. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5947 Differential Revision: D18038837 Pulled By: vjnadimpalli fbshipit-source-id: 9ac2ddaa93bf328a416faec028970e039886378e | 21 October 2019, 19:07:58 UTC |
| refs/heads/5.17.fb.myrocks | 2b39d12 | WritePrepared: Fix bug in searching in non-cached snapshots (#4639) Summary: When evicting an entry form the commit_cache, it is verified against the list of old snapshots to see if it overlaps with any. The list of old snapshots is split into two lists: an efficient concurrent cache and an slow vector protected by a lock. The patch fixes a bug that would stop the search in the cache if it finds any and yet would not include the larger snapshots in the slower list. An extra info log entry is also removed. The condition to trigger that although very rare is still feasible and should not spam the LOG when that happens. Fixes #4621 Pull Request resolved: https://github.com/facebook/rocksdb/pull/4639 Differential Revision: D12934989 Pulled By: maysamyabandeh fbshipit-source-id: 4e0fe8147ba292b554ae78e94c21c2ef31e03e2d | 06 November 2018, 07:02:01 UTC |
| refs/heads/5.18.fb | b9a4a10 | Fix build on MSVC | 07 March 2020, 16:58:42 UTC |
| refs/heads/5.2.fb | 4be3b1c | Disable warning as error | 05 November 2019, 19:08:10 UTC |
| refs/heads/5.3.fb | 31b8bd9 | add <sys/sysmacros.h> to avoid warning with glibc 2.25 Summary: https://github.com/facebook/rocksdb/issues/2152 Closes https://github.com/facebook/rocksdb/pull/2208 Differential Revision: D4945577 Pulled By: lightmark fbshipit-source-id: 4e679150f2c9443d3be0b6008b26b65fabbda75a | 26 April 2017, 08:09:05 UTC |
| refs/heads/5.4.fb | 9adcef7 | add <sys/sysmacros.h> to avoid warning with glibc 2.25 Summary: https://github.com/facebook/rocksdb/issues/2152 Closes https://github.com/facebook/rocksdb/pull/2208 Differential Revision: D4945577 Pulled By: lightmark fbshipit-source-id: 4e679150f2c9443d3be0b6008b26b65fabbda75a | 26 April 2017, 08:09:05 UTC |
| refs/heads/5.5.fb | ca97834 | db_bench_tool: fix buffer size Summary: Found by gcc warning: x86_64-pc-linux-gnu-g++ --version x86_64-pc-linux-gnu-g++ (GCC) 7.1.1 20170710 tools/db_bench_tool.cc: In member function 'void rocksdb::Benchmark::RandomWithVerify(rocksdb::ThreadState*)': tools/db_bench_tool.cc:4430:8: error: '%lu' directive output may be truncated writing between 1 and 19 bytes into a region of size between 0 and 66 [-Werror=format-truncation=] void RandomWithVerify(ThreadState* thread) { ^~~~~~~~~~~~~~~~ tools/db_bench_tool.cc:4430:8: note: directive argument in the range [0, 9223372036854775807] tools/db_bench_tool.cc:4492:13: note: 'snprintf' output between 37 and 128 bytes into a destination of size 100 snprintf(msg, sizeof(msg), ~~~~~~~~^~~~~~~~~~~~~~~~~~ "( get:%" PRIu64 " put:%" PRIu64 " del:%" PRIu64 " total:%" \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PRIu64 " found:%" PRIu64 ")", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ gets_done, puts_done, deletes_done, readwrites_, found); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors Makefile:1707: recipe for target 'tools/db_bench_tool.o' failed Closes https://github.com/facebook/rocksdb/pull/2558 Differential Revision: D5398703 Pulled By: siying fbshipit-source-id: 6ffa552bbd8b59cfc2c36289f86ff9b9acca8ca6 | 11 July 2017, 17:28:18 UTC |
| refs/heads/5.6.fb | 739adf1 | db_bench_tool: fix buffer size Summary: Found by gcc warning: x86_64-pc-linux-gnu-g++ --version x86_64-pc-linux-gnu-g++ (GCC) 7.1.1 20170710 tools/db_bench_tool.cc: In member function 'void rocksdb::Benchmark::RandomWithVerify(rocksdb::ThreadState*)': tools/db_bench_tool.cc:4430:8: error: '%lu' directive output may be truncated writing between 1 and 19 bytes into a region of size between 0 and 66 [-Werror=format-truncation=] void RandomWithVerify(ThreadState* thread) { ^~~~~~~~~~~~~~~~ tools/db_bench_tool.cc:4430:8: note: directive argument in the range [0, 9223372036854775807] tools/db_bench_tool.cc:4492:13: note: 'snprintf' output between 37 and 128 bytes into a destination of size 100 snprintf(msg, sizeof(msg), ~~~~~~~~^~~~~~~~~~~~~~~~~~ "( get:%" PRIu64 " put:%" PRIu64 " del:%" PRIu64 " total:%" \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PRIu64 " found:%" PRIu64 ")", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ gets_done, puts_done, deletes_done, readwrites_, found); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors Makefile:1707: recipe for target 'tools/db_bench_tool.o' failed Closes https://github.com/facebook/rocksdb/pull/2558 Differential Revision: D5398703 Pulled By: siying fbshipit-source-id: 6ffa552bbd8b59cfc2c36289f86ff9b9acca8ca6 | 11 July 2017, 17:28:18 UTC |
| refs/heads/5.7.fb | ede73d6 | table/block.h: change memset Summary: In gcc-7 the following is an error identified by -Werror=class-memaccess In file included from ./table/get_context.h:14:0, from db/version_set.cc:43: ./table/block.h: In constructor ‘rocksdb::BlockReadAmpBitmap::BlockReadAmpBitmap(size_t, size_t, rocksdb::Statistics*)’: ./table/block.h:73:53: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct std::atomic<unsigned int>’ with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess] memset(bitmap_, 0, bitmap_size * kBytesPersEntry); ^ In file included from ./db/version_set.h:23:0, from db/version_set.cc:12: /toolchain/include/c++/8.0.0/atomic:684:12: note: ‘struct std::atomic<unsigned int>’ declared here struct atomic<unsigned int> : __atomic_base<unsigned int> ^~~~~~~~~~~~~~~~~~~~ As a solution the default initializer can be applied in list context. Signed-off-by: Daniel Black <daniel.black@au.ibm.com> Closes https://github.com/facebook/rocksdb/pull/2561 Differential Revision: D5398714 Pulled By: siying fbshipit-source-id: d883fb88ec7535eee60d551038fe91f14488be36 | 17 July 2017, 17:33:12 UTC |
| refs/heads/5.7.fb.myrocks | f759122 | Fix IOError on WAL write doesn't propagate to write group follower Summary: This is a simpler version of #3097 by removing all unrelated changes. Fixing the bug where concurrent writes may get Status::OK while it actually gets IOError on WAL write. This happens when multiple writes form a write batch group, and the leader get an IOError while writing to WAL. The leader failed to pass the error to followers in the group, and the followers end up returning Status::OK() while actually writing nothing. The bug only affect writes in a batch group. Future writes after the batch group will correctly return immediately with the IOError. Closes https://github.com/facebook/rocksdb/pull/3201 Differential Revision: D6421644 Pulled By: yiwu-arbug fbshipit-source-id: 1c2a455c5b73f6842423785eb8a9dbfbb191dc0e | 28 November 2017, 19:40:40 UTC |
| refs/heads/5.8.3 | def6a00 | Print out compression type of new SST files in logging Summary: Closes https://github.com/facebook/rocksdb/pull/3264 Differential Revision: D6552768 Pulled By: siying fbshipit-source-id: 6303110aff22f341d5cff41f8d2d4f138a53652d | 14 December 2017, 18:18:01 UTC |
| refs/heads/5.8.fb | 6ea4477 | Fix GitHub issue #3716: gcc-8 warnings Summary: Fix the following gcc-8 warnings: - conflicting C language linkage declaration [-Werror] - writing to an object with no trivial copy-assignment [-Werror=class-memaccess] - array subscript -1 is below array bounds [-Werror=array-bounds] Solves https://github.com/facebook/rocksdb/issues/3716 Closes https://github.com/facebook/rocksdb/pull/3736 Differential Revision: D7684161 Pulled By: yiwu-arbug fbshipit-source-id: 47c0423d26b74add251f1d3595211eee1e41e54a | 20 April 2018, 20:28:05 UTC |
| refs/heads/5.9.fb | 489d696 | Fix GitHub issue #3716: gcc-8 warnings Summary: Fix the following gcc-8 warnings: - conflicting C language linkage declaration [-Werror] - writing to an object with no trivial copy-assignment [-Werror=class-memaccess] - array subscript -1 is below array bounds [-Werror=array-bounds] Solves https://github.com/facebook/rocksdb/issues/3716 Closes https://github.com/facebook/rocksdb/pull/3736 Differential Revision: D7684161 Pulled By: yiwu-arbug fbshipit-source-id: 47c0423d26b74add251f1d3595211eee1e41e54a | 20 April 2018, 20:28:05 UTC |
| refs/heads/5.9.fb.myrocks | 4d7b0d5 | Fix DeleteScheduler::MarkAsTrash() handling existing trash Summary: DeleteScheduler::MarkAsTrash() don't handle existing .trash files correctly This cause rocksdb to not being able to delete existing .trash files on restart Closes https://github.com/facebook/rocksdb/pull/3261 Differential Revision: D6548003 Pulled By: IslamAbdelRahman fbshipit-source-id: c3800639412e587a690062c63076a5a08881e0e6 | 13 December 2017, 02:15:15 UTC |
| refs/heads/6.0.fb | ba02251 | Making platform 007 (gcc 7) default in build_detect_platform.sh (#5947) Summary: Making platform 007 (gcc 7) default in build_detect_platform.sh. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5947 Differential Revision: D18038837 Pulled By: vjnadimpalli fbshipit-source-id: 9ac2ddaa93bf328a416faec028970e039886378e | 21 October 2019, 19:07:58 UTC |
| refs/heads/6.0.fb.myrocks | 8fe6fd3 | Bump version to 6.0.3 | 01 May 2019, 02:50:18 UTC |
| refs/heads/6.1.fb | 4a67e2a | Making platform 007 (gcc 7) default in build_detect_platform.sh (#5947) Summary: Making platform 007 (gcc 7) default in build_detect_platform.sh. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5947 Differential Revision: D18038837 Pulled By: vjnadimpalli fbshipit-source-id: 9ac2ddaa93bf328a416faec028970e039886378e | 21 October 2019, 19:07:58 UTC |
| refs/heads/6.1.fb.myrocks | 5624396 | Bump version to 6.1.2 and update history | 02 May 2019, 18:56:11 UTC |
| refs/heads/6.1.fb.prod201905 | 8c9ac08 | Patch version number to 6.2.0 for downgrade compatibility S181200 | 19 June 2019, 01:47:35 UTC |
| refs/heads/6.10.fb | a21a78a | Fix the logic of setting read_amp_bytes_per_bit from OPTIONS file (#7680) Summary: Instead of using `EncodeFixed32` which always serialize a integer to little endian, we should use the local machine's endianness when populating a native data structure during options parsing. Without this fix, `read_amp_bytes_per_bit` may be populated incorrectly on big-endian machines. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7680 Test Plan: make check Reviewed By: pdillinger Differential Revision: D24999166 Pulled By: riversand963 fbshipit-source-id: dc603cff6e17f8fa32479ce6df93b93082e6b0c4 | 17 November 2020, 08:43:20 UTC |
| refs/heads/6.11.fb | c509dd3 | Fix the logic of setting read_amp_bytes_per_bit from OPTIONS file (#7680) Summary: Instead of using `EncodeFixed32` which always serialize a integer to little endian, we should use the local machine's endianness when populating a native data structure during options parsing. Without this fix, `read_amp_bytes_per_bit` may be populated incorrectly on big-endian machines. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7680 Test Plan: make check Reviewed By: pdillinger Differential Revision: D24999166 Pulled By: riversand963 fbshipit-source-id: dc603cff6e17f8fa32479ce6df93b93082e6b0c4 | 17 November 2020, 08:43:20 UTC |
| refs/heads/6.12.fb | 8ec8d12 | Fix the logic of setting read_amp_bytes_per_bit from OPTIONS file (#7680) Summary: Instead of using `EncodeFixed32` which always serialize a integer to little endian, we should use the local machine's endianness when populating a native data structure during options parsing. Without this fix, `read_amp_bytes_per_bit` may be populated incorrectly on big-endian machines. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7680 Test Plan: make check Reviewed By: pdillinger Differential Revision: D24999166 Pulled By: riversand963 fbshipit-source-id: dc603cff6e17f8fa32479ce6df93b93082e6b0c4 | 17 November 2020, 08:43:20 UTC |
| refs/heads/6.13.fb | 2df3e90 | Fix the logic of setting read_amp_bytes_per_bit from OPTIONS file (#7680) Summary: Instead of using `EncodeFixed32` which always serialize a integer to little endian, we should use the local machine's endianness when populating a native data structure during options parsing. Without this fix, `read_amp_bytes_per_bit` may be populated incorrectly on big-endian machines. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7680 Test Plan: make check Reviewed By: pdillinger Differential Revision: D24999166 Pulled By: riversand963 fbshipit-source-id: dc603cff6e17f8fa32479ce6df93b93082e6b0c4 | 17 November 2020, 08:43:20 UTC |
| refs/heads/6.13.fb.laser | 3f6b2d7 | Redesign block cache pinning API (#7520) Summary: The old flag-based APIs (`BlockBasedTableOptions::pin_l0_filter_and_index_blocks_in_cache` and `BlockBasedTableOptions::pin_top_level_index_and_filter`) were insufficient for our needs. For example, it was impossible to pin only unpartitioned meta-blocks, which could prevent block cache contention when turning on dictionary compression or during a migration to partitioned indexes/filters. It was also impossible to pin all meta-blocks in memory while having predictable memory usage via block cache. If we had continued adding flags to address these scenarios, they would have had significant overlap causing confusion. Instead, this PR deprecates the flags and starts a new API with non-overlapping options. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7520 Test Plan: - new unit test - added new options to stress/crash test and ran for a while: `$ python tools/db_crashtest.py blackbox --simple --max_key=1000000 -write_buffer_size=1048576 -target_file_size_base=1048576 -max_bytes_for_level_base=4194304 --interval=10 -value_size_mult=33 -column_families=1 -reopen=0` Reviewed By: pdillinger Differential Revision: D24200034 Pulled By: ajkr fbshipit-source-id: 3fa7cfc71e7960f7a867511dd6ae5834dd73b13e | 11 October 2020, 21:52:49 UTC |
| refs/heads/6.14.fb | ed43161 | fixup release note (track_and_verify_wals_in_manifest not available in 6.14) | 01 December 2020, 23:05:35 UTC |
| refs/heads/6.14.fb.laser | 51c8841 | Expand effect of dictionary settings in `ColumnFamilyOptions::compression_opts` (#7619) Summary: In dictionary compression's initial implementation, in order to save CPU overhead, we only enabled it for bottom level under the assumption that the vast majority of data is stored there. At that time, there was no such thing as `ColumnFamilyOptions::bottommost_compression_opts`, so we just hardcoded disabling dictionary compression in flush and compactions to non-bottommost level. Now, we have users who generate all their files through flush and are considering using dictionary compression. To support such a use case, this PR expands the scope of `ColumnFamilyOptions::compression_opts` to additionally include flushed files and files generated by compaction to a non-bottommost level. Users can still get the old behavior by moving their dictionary settings to `ColumnFamilyOptions::bottommost_compression_opts` and explicitly enabling both that and `ColumnFamilyOptions::bottommost_compression`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7619 Reviewed By: ltamasi Differential Revision: D24665610 Pulled By: ajkr fbshipit-source-id: 656b90bce1033fe21c71e09af931ef5bde3e464c | 03 November 2020, 03:20:15 UTC |
| refs/heads/6.15.fb | abd4b1f | bump version and update HISTORY.md for 6.15.5 | 06 February 2021, 01:01:51 UTC |
| refs/heads/6.16.fb | b705f80 | Update version and HISTORY for 6.16.5 | 08 September 2021, 19:34:59 UTC |
| refs/heads/6.17.fb | be84166 | Fix Windows strcmp for Unicode (#8190) Summary: The code for strcmp that was present does work when compiled for Windows unicode file paths. Needs backporting to: * 6.17.fb * 6.18.fb * 6.19.fb Pull Request resolved: https://github.com/facebook/rocksdb/pull/8190 Reviewed By: akankshamahajan15 Differential Revision: D27765588 Pulled By: jay-zhuang fbshipit-source-id: 89f8a5ac61fd7edc758340dfd335b0a5f96dae6e | 16 April 2021, 19:10:22 UTC |
| refs/heads/6.17.fb.laser | 58ec8cf | Backport https://github.com/facebook/rocksdb/pull/7970 | 17 February 2021, 18:42:56 UTC |
| refs/heads/6.18.fb | 169fce2 | Fix Windows strcmp for Unicode (#8190) Summary: The code for strcmp that was present does work when compiled for Windows unicode file paths. Needs backporting to: * 6.17.fb * 6.18.fb * 6.19.fb Pull Request resolved: https://github.com/facebook/rocksdb/pull/8190 Reviewed By: akankshamahajan15 Differential Revision: D27765588 Pulled By: jay-zhuang fbshipit-source-id: 89f8a5ac61fd7edc758340dfd335b0a5f96dae6e | 16 April 2021, 19:10:22 UTC |
| refs/heads/6.19.fb | fd8247b | update HISTORY.md and bump version for 6.19.4 | 23 April 2021, 22:42:04 UTC |
| refs/heads/6.2.fb | 3513d4e | Making platform 007 (gcc 7) default in build_detect_platform.sh (#5947) Summary: Making platform 007 (gcc 7) default in build_detect_platform.sh. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5947 Differential Revision: D18038837 Pulled By: vjnadimpalli fbshipit-source-id: 9ac2ddaa93bf328a416faec028970e039886378e | 21 October 2019, 19:07:58 UTC |
| refs/heads/6.20.fb | 822e08e | Update HISTORY.md and bump version to 6.20.4 | 19 May 2021, 19:22:55 UTC |
| refs/heads/6.21.fb | 623774b | Update version and HISTORY for 6.21.3 | 19 July 2021, 15:30:36 UTC |
| refs/heads/6.22-history.md-fixup | 1a2bb84 | Fixup HISTORY.md for 6.22 release `git diff origin/6.21.fb origin/6.22.fb -- HISTORY.md` looked odd. This PR fixes it up by moving items from 6.21.0 to 6.22.0 that were never in any 6.21 release. Also mentioned the background stat collection fix under 6.22 (previously it was mentioned under 6.21 patch releases only). | 22 June 2021, 17:01:48 UTC |
| refs/heads/6.22.fb | 3e0ff19 | Update version and HISTORY for 6.22.3 | 19 July 2021, 15:41:29 UTC |
| refs/heads/6.23.fb | e51db47 | Fix a race in LRUCacheShard::Promote (#8717) Summary: In ```LRUCacheShard::Promote```, a reference is released outside the LRU mutex. Fix the race condition. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8717 Reviewed By: zhichao-cao Differential Revision: D30649206 Pulled By: anand1976 fbshipit-source-id: 09c0af05b2294a7fe2c02876a61b0bad6e3ada61 | 31 August 2021, 02:09:43 UTC |
| refs/heads/6.24.fb | 5997ede | Add 6.24.2 | 17 September 2021, 21:16:18 UTC |
| refs/heads/6.25.fb | f55aab3 | Fix EnvLibrados and add to CI (#9088) Summary: This feature was not part of any common or CI build, so no surprise it broke. Now we can at least ensure compilation. I don't know how to run the test successfully (missing config file) so it is bypassed for now. Fixes https://github.com/facebook/rocksdb/issues/9078 Pull Request resolved: https://github.com/facebook/rocksdb/pull/9088 Test Plan: CI Reviewed By: mrambacher Differential Revision: D32009467 Pulled By: pdillinger fbshipit-source-id: 3e0d1e5fde7f0ece703d48a81479e1cc7392c25c | 29 October 2021, 15:17:24 UTC |
| refs/heads/6.26.fb | 4d57a39 | Improve HISTORY.md | 18 November 2021, 22:47:16 UTC |
| refs/heads/6.27.fb | fcf3d75 | Update HISTORY.md for PR 9273 (#9282) Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/9282 Reviewed By: akankshamahajan15 Differential Revision: D33027844 Pulled By: ltamasi fbshipit-source-id: 7540d36010414311bc39610fff92a6498be1570c | 10 December 2021, 22:48:55 UTC |
| refs/heads/6.28.fb | df4d3cf | Update version to 6.28.2 Summary: Update version to 6.28.2 for bug fix | 31 January 2022, 18:14:30 UTC |
| refs/heads/6.29.fb | 79f08d7 | Retrieve ZLib from the archive (#9782) | 05 April 2022, 01:09:07 UTC |
| refs/heads/6.3.fb | efb42cf | Making platform 007 (gcc 7) default in build_detect_platform.sh (#5947) Summary: Making platform 007 (gcc 7) default in build_detect_platform.sh. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5947 Differential Revision: D18038837 Pulled By: vjnadimpalli fbshipit-source-id: 9ac2ddaa93bf328a416faec028970e039886378e | 21 October 2019, 19:07:58 UTC |
| refs/heads/6.3.fb.myrocks | 0e348d7 | Revert "Merging iterator to avoid child iterator reseek for some cases (#5286)" This reverts commit 9fad3e21eb90d215b6719097baba417bc1eeca3c. | 01 October 2019, 23:48:35 UTC |
| refs/heads/6.3.fb.myrocks2 | 9c34cde | Fix data block upper bound checking for iterator reseek case (#5883) Summary: When an iterator reseek happens with the user specifying a new iterate_upper_bound in ReadOptions, and the new seek position is at the end of the same data block, the Seek() ends up using a stale value of data_block_within_upper_bound_ and may return incorrect results. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5883 Test Plan: Added a new test case DBIteratorTest.IterReseekNewUpperBound. Verified that it failed due to the assertion failure without the fix, and passes with the fix. Differential Revision: D17752740 Pulled By: anand1976 fbshipit-source-id: f9b635ff5d6aeb0e1bef102cf8b2f900efd378e3 | 04 October 2019, 03:52:17 UTC |
| refs/heads/6.3fb | abd1fdd | Fix asan_check failures Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/5589 Test Plan: TEST_TMPDIR=/dev/shm/rocksdb COMPILE_WITH_ASAN=1 OPT=-g make J=64 -j64 asan_check Differential Revision: D16361081 Pulled By: anand1976 fbshipit-source-id: 09474832b9cfb318a840d4b633e22dfad105d58c | 18 July 2019, 21:38:23 UTC |
| refs/heads/6.4.fb | e69ce10 | fix compile error: ‘FALLOC_FL_KEEP_SIZE’ undeclared (#5708) Summary: add "linux/falloc.h" in env/io_posix.cc to fix compile error: ‘FALLOC_FL_KEEP_SIZE’ undeclared Signed-off-by: sheng qiu <herbert1984106@gmail.com> Pull Request resolved: https://github.com/facebook/rocksdb/pull/5708 Differential Revision: D16832922 fbshipit-source-id: 30e787c4a1b5a9724a8acfd68962ff5ec5f27d3e | 16 August 2019, 20:55:37 UTC |
