| f7bb59d | Francois Cartegnie | 16 March 2023, 09:03:01 UTC | demux: mp4: always check and use next edit list directly skips empty edits and avoids stopping on last track sample (fixes loop playback) | 24 March 2023, 01:04:39 UTC |
| bde2098 | Francois Cartegnie | 28 February 2023, 17:13:33 UTC | demux: mp4: move edit list mapping to own functions | 24 March 2023, 01:04:39 UTC |
| 06ce45c | Francois Cartegnie | 01 March 2023, 08:38:52 UTC | demux: mp4: fix wrong edit list offset regression | 24 March 2023, 01:04:39 UTC |
| 3ef970a | Francois Cartegnie | 28 February 2023, 17:38:03 UTC | demux: libmp4: rework edit list storage | 24 March 2023, 01:04:39 UTC |
| 90811de | Francois Cartegnie | 22 March 2023, 09:41:37 UTC | demux: libmp4: restrict to known elst versions | 24 March 2023, 01:04:39 UTC |
| 413ffdd | Francois Cartegnie | 22 March 2023, 09:41:20 UTC | demux: libmp4: do not store elst version | 24 March 2023, 01:04:39 UTC |
| 7c94acd | Francois Cartegnie | 16 March 2023, 12:48:24 UTC | demux: mp4: return only last sample dts | 24 March 2023, 01:04:39 UTC |
| 199de05 | Pierre Lamot | 20 March 2023, 10:54:53 UTC | qt: report 0 size when the ml cache is loaded but empty 7d70397c7d976677bcf9989c99f636e7cfd383c9 doesn't work properly without this, model remains in loading state | 23 March 2023, 15:09:15 UTC |
| f7d4afc | Simon Latapie | 17 March 2023, 15:54:48 UTC | doc: QtPlayer: fix file opening on Windows Using a raw path from the QFileDialog can lead to wrong native separators in the provided string. Using URLs instead of paths should be more cross-platform compliant. | 23 March 2023, 14:36:25 UTC |
| f808bdd | Pierre Lamot | 21 March 2023, 08:42:25 UTC | interop_dxva2: fix flickering effect | 22 March 2023, 14:32:07 UTC |
| 3e83863 | Steve Lhomme | 16 March 2023, 12:30:33 UTC | interop_dxva2: use container_of instead of object cast | 21 March 2023, 15:35:57 UTC |
| 2e335eb | Steve Lhomme | 20 March 2023, 12:02:04 UTC | interop_dxva2: add comments about the processor output values The same code in direct3d9 uses an output format that can vary. | 21 March 2023, 15:35:57 UTC |
| dd8297d | Steve Lhomme | 16 March 2023, 12:39:15 UTC | d3d9: use the official typedef for DXVAHD_CreateDevice() It doesn't exist in mingw so we define it in that case. | 21 March 2023, 15:35:57 UTC |
| b86fbe2 | Steve Lhomme | 20 March 2023, 11:54:39 UTC | d3d9: explicitly set the processing input type We do the processing on video files, not "graphics" generated sources. | 21 March 2023, 15:35:57 UTC |
| 367b7e8 | Steve Lhomme | 20 March 2023, 11:52:30 UTC | d3d9: fully initialize DXVAHD_BLT_STATE_INPUT_COLOR_SPACE_DATA Although we set all known usable bits, it seems that leaving reserved bits "uninitialized" doesn't work in some case. In particular with LLVM builds, which results in bogus output. | 21 March 2023, 15:35:57 UTC |
| a7de762 | Steve Lhomme | 16 March 2023, 12:29:59 UTC | d3d9: fully initialize DXVAHD_BLT_STATE_OUTPUT_COLOR_SPACE_DATA Although we set all known usable bits, it seems that leaving reserved bits "uninitialized" doesn't work in some case. In particular with LLVM builds, which results in bogus output. Co-authored-by: Pierre Lamot <pierre@videolabs.io> | 21 March 2023, 15:35:57 UTC |
| 96a19e9 | Steve Lhomme | 20 March 2023, 10:38:45 UTC | contrib: mingw64: patch dxvahd.h before mingw-w64 11 The releases before 11 had bogus dxvahd DXVAHD_STREAM_STATE_xxx_COLOR_SPACE_DATA structures. This was confusing the initialization with LLVM. | 21 March 2023, 15:35:57 UTC |
| f9b271e | Khalid Masum | 18 March 2023, 08:33:46 UTC | es_out: remove unused variable Creation and initialization of p_sys in EsOutSetEsDelay is not necessary as it is performed in EsOutUpdateDelayJitter later anyway. | 21 March 2023, 09:51:57 UTC |
| f5d7953 | Prince Gupta | 10 March 2023, 05:29:23 UTC | qml: handle Navigation Cancel in MainViewLoader | 20 March 2023, 10:02:14 UTC |
| 62e94c6 | Prince Gupta | 16 March 2023, 15:10:20 UTC | qt: allow navigation functions to fallback to default behaviour | 20 March 2023, 10:02:14 UTC |
| 84a5bed | Prince Gupta | 09 March 2023, 10:39:17 UTC | qml: use MainViewLoader in MusicGenres component | 20 March 2023, 10:02:14 UTC |
| e3b13a6 | Prince Gupta | 09 March 2023, 09:51:10 UTC | qml: use MainViewLoader in MusicAlbums component | 20 March 2023, 10:02:14 UTC |
| 4643f55 | Prince Gupta | 09 March 2023, 09:06:03 UTC | qml: use MainViewLoader in MusicAllArtists component | 20 March 2023, 10:02:14 UTC |
| ea0eaff | Prince Gupta | 03 March 2023, 07:42:20 UTC | qml: use MainViewLoader for PlaylistMediaList | 20 March 2023, 10:02:14 UTC |
| a9e02b6 | Prince Gupta | 03 March 2023, 05:41:47 UTC | qml: use MainViewLoader in VideoAll | 20 March 2023, 10:02:14 UTC |
| b0ae61d | Prince Gupta | 09 March 2023, 08:48:23 UTC | qml: check nullability in Helpers.get | 20 March 2023, 10:02:14 UTC |
| ecf0c9c | Prince Gupta | 02 March 2023, 05:40:23 UTC | qml: implement MainViewLoader | 20 March 2023, 10:02:14 UTC |
| 869a034 | Steve Lhomme | 17 March 2023, 08:15:50 UTC | webservices/json: update the JSON parser to version 1.1.0 json_parse_ex() now requires the length of the JSON string to parse. The following changes are integrated: * 672dd79c402b5f88c469c92b64e8e382db4cab2e (int64 on Windows), * ecb7c847198dc1cd392e0beecb5ef63a37d3fa6c (proper include guards), * c8edcab8cd6c53d39264a59dacbcabe65b2b2c98 (null deref), * 894bab1c0a2dd6cca72629df7426afc1be102dfe (fallthrough warning) The (unused) json_relaxed_commas flag is gone. We may also use it as a contrib. | 20 March 2023, 08:19:23 UTC |
| 6f9b01e | Steve Lhomme | 17 March 2023, 08:29:33 UTC | json_helper: get the size of the read buffer | 20 March 2023, 08:19:23 UTC |
| 7d70397 | Fatih Uzunoglu | 06 March 2023, 15:48:42 UTC | qt: discontinue hasContent and use isReady property in MLBaseModel | 19 March 2023, 08:12:33 UTC |
| ff905bd | Pierre Lamot | 17 March 2023, 15:20:14 UTC | qml: add missing color in EmptyLabelHint | 18 March 2023, 16:04:39 UTC |
| 2aa07f5 | Pierre Lamot | 17 March 2023, 13:54:27 UTC | qml: add missing import for ColorContext | 18 March 2023, 16:04:39 UTC |
| 9d87d21 | Pierre Lamot | 17 March 2023, 11:38:38 UTC | qml: fix label not colorized properly in the ToolbarEditor it tries to use the colorContext of the WindowDialog which was not exposed | 18 March 2023, 16:04:39 UTC |
| 8b9293f | Pierre Lamot | 16 March 2023, 10:15:47 UTC | qt: update ColorContext colors when palette internally changes | 18 March 2023, 16:04:39 UTC |
| 4d5606c | Pierre Lamot | 16 March 2023, 09:08:12 UTC | qt: disable acrylic effect when high-contrast theme is used on windows | 17 March 2023, 21:06:26 UTC |
| 1a4eb72 | Pierre Lamot | 15 March 2023, 16:16:13 UTC | qt: use high-contrast colors on windows when the user enable the high-contrast mode on windows, we must comply to the system palette | 17 March 2023, 21:06:26 UTC |
| e476328 | Thomas Guillem | 14 March 2023, 16:01:17 UTC | audiotrack: use precise latency AudioTrack#getTimestamp, present since API 19, is the most precise, [-20ms;0ms] delay tested with the Sync-One2. | 17 March 2023, 20:44:54 UTC |
| 4bb250c | Thomas Guillem | 14 March 2023, 15:59:34 UTC | audiotrack: use TimingReport API Remove the smoothpos hack that was only needed for time_get. | 17 March 2023, 20:44:54 UTC |
| 8d0819f | Thomas Guillem | 14 March 2023, 14:44:59 UTC | audiotrack: remove unused cond Leftover from 582570aad10b0dda1a725039ab6c35dc3e9d51c3 | 17 March 2023, 20:44:54 UTC |
| 6202abd | Thomas Guillem | 14 March 2023, 14:29:38 UTC | audiotrack: reorder to avoid forward declaration No functional changes. | 17 March 2023, 20:44:54 UTC |
| cb8d593 | Benjamin Arnaud | 01 March 2023, 18:00:25 UTC | qml/Player: Add pin background opacity | 17 March 2023, 13:28:56 UTC |
| a965917 | Benjamin Arnaud | 22 February 2023, 10:43:57 UTC | qml/Player: Update the 'pinned' behavior When pinned in fullscreen, we want the controlbar to retain the default design and hide everything at the top. | 17 March 2023, 13:28:56 UTC |
| 45875b4 | Benjamin Arnaud | 10 March 2023, 10:48:06 UTC | qml/TopBar: Add the 'resumeVisible' property | 17 March 2023, 13:28:56 UTC |
| debe7ea | Benjamin Arnaud | 01 March 2023, 18:00:46 UTC | qt/mainctx: Add the 'pinOpacity' property | 17 March 2023, 13:28:56 UTC |
| a26e2ba | Alaric Senat | 14 March 2023, 12:49:10 UTC | taglib: wav: fix RIFF INFO tags parsing TagLib does not provide an union of both ID3v2 and INFO tags via the usual `File::tag()` method. Their justification lies in the code for now: ```cpp /*! * Returns the ID3v2 Tag for this file. * * \note This method does not return all the tags for this file for * backward compatibility. Will be fixed in TagLib 2.0. */ ID3v2::Tag *tag() const; ``` To support WAV files providing RIFF INFO tags, we must specifically parse them before TagLib 2.0 (not released yet). Fixes #25690 | 17 March 2023, 12:14:52 UTC |
| 294cbdb | Alaric Senat | 14 March 2023, 12:43:02 UTC | taglib: move default meta access to a function No functional changes. | 17 March 2023, 12:14:52 UTC |
| 90e98b0 | Thomas Guillem | 15 March 2023, 10:44:11 UTC | vlc_queue: fix restrict violation `restrict` tells the compiler that the tombstone pointer is the only way to access the variable pointed by it. This is not case with multi-threading. From the C11 specs: § 6.7.3 item 8 An object that is accessed through a restrict-qualified pointer has a special association with that pointer. This association, defined in 6.7.3.1 below, requires that all accesses to that object use, directly or indirectly, the value of that particular pointer. § 6.7.3.1 item 4 Every other lvalue used to access the value of X shall also have its address based on P. Also set the pointer to const. Fixes the following race condition when closing live555: Thread 80 (Thread 28393.4880): 0 0x0000007953dbebbc in syscall () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 1 0x0000007855d2c0ec in sys_futex (addr=0x89, op=137, val=0, to=0x0, addr2=0x0, val3=-1) at ../../src/linux/thread.c:82 2 vlc_futex_wait (addr=0x89, flags=0, val=0, to=0x0) at ../../src/linux/thread.c:93 3 vlc_atomic_wait (addr=0x89, val=0) at ../../src/linux/thread.c:109 4 0x0000007855d20e9c in vlc_cond_wait (cond=cond@entry=0x7829f26ce8, mutex=mutex@entry=0x7829f26cd8) at ../../src/misc/threads.c:298 5 0x0000007855d42244 in vlc_queue_Wait (q=0x7829f26cc0) at ../../include/vlc_queue.h:122 6 vlc_queue_DequeueKillable (q=0x7829f26cc0, tombstone=0x7829f26d00) at ../../include/vlc_queue.h:248 7 vlc_stream_fifo_Block (s=<optimized out>, eof=0x78709a8838) at ../../src/input/stream_fifo.c:75 8 0x0000007855cfa160 in vlc_stream_ReadRaw (s=s@entry=0x7819411360, buf=buf@entry=0x78c4393c80, len=len@entry=188) at ../../src/input/stream.c:466 9 0x0000007855cf9fe0 in vlc_stream_ReadPartial (s=s@entry=0x7819411360, buf=buf@entry=0x78c4393c80, len=len@entry=188) at ../../src/input/stream.c:489 10 0x0000007855cfad44 in vlc_stream_Read (s=<optimized out>, buf=0x78c4393c80, len=188) at ../../src/input/stream.c:504 11 vlc_stream_Block (s=0x7819411360, size=<optimized out>) at ../../src/input/stream.c:909 12 0x0000007855f1fe5c in ReadTSPacket (p_demux=p_demux@entry=0x78c42c0ce0) at ../../modules/demux/mpeg/ts.c:1808 13 0x0000007855f1de30 in Demux (p_demux=<optimized out>) at ../../modules/demux/mpeg/ts.c:649 4 0x0000007855d41e4c in vlc_demux_chained_Thread (data=0x7829f26c70) at ../../src/input/demux_chained.c:96 15 0x0000007855d2d5b8 in joinable_thread (data=0x7823341ea0) at ../../src/android/thread.c:96 16 0x0000007953e217c4 in __pthread_start(void*) () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 17 0x0000007953dc41ac in __start_thread () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so Thread 79 (Thread 28393.4875): 0 0x0000007953dbebbc in syscall () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 1 0x0000007953e21d98 in pthread_join () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 2 0x0000007855d2d204 in vlc_join (handle=0x7823341ea0, result=0x0) at ../../src/android/thread.c:147 3 0x0000007855d4202c in vlc_demux_chained_Delete (dc=0x7829f26c70) at ../../src/input/demux_chained.c:167 4 0x0000007855d3d92c in Close (p_this=<optimized out>) at ../../modules/access/live555.cpp:505 5 0x0000007855cb49dc in module_unneed (obj=obj@entry=0x78194110c0, module=0x78c83b0520) at ../../src/modules/modules.c:305 6 0x0000007855ceae78 in vlc_access_Destroy (access=0x78194110c0) at ../../src/input/access.c:54 7 0x0000007855cf958c in vlc_stream_Delete (s=0x78194110c0) at ../../src/input/stream.c:150 8 0x0000007855ce4954 in demux_Delete (demux=0x78709a8d60) at ../../include/vlc_demux.h:291 9 InputSourceDestroy (in=0x781a3aa780) at ../../src/input/input.c:2852 10 0x0000007855ce39f0 in End (p_input=p_input@entry=0x7863073c00) at ../../src/input/input.c:1413 11 0x0000007855ce0620 in Run (data=0x7863073c00) at ../../src/input/input.c:431 12 0x0000007855d2d5b8 in joinable_thread (data=0x78231b02c0) at ../../src/android/thread.c:96 13 0x0000007953e217c4 in __pthread_start(void*) () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 14 0x0000007953dc41ac in __start_thread () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so | 17 March 2023, 08:10:38 UTC |
| bdc6edb | Loïc | 13 March 2023, 09:28:27 UTC | demux: add more helper methods This commit adds more helper methods for demux_t. | 16 March 2023, 14:20:37 UTC |
| 2a4957c | Loïc | 09 March 2023, 14:06:56 UTC | demux: introduce typed operations for demux This commit introduce a typed virtual table for operations on demux, aiming at replacing the legacy pf_control() callback which is using va_list. As a counterpart to the typed virtual table, typed methods are also introduce. The operations can be implemented by the modules directly right now and will be used when possible. This is done to provide type safety at every level. When no operation is provided (ie, demux_t.ops is NULL) by a module implementation, the legacy pf_control will be used instead as a fallback. The commit doesn't migrate any of modules yet. | 16 March 2023, 14:20:37 UTC |
| 6baee5a | Loïc | 13 March 2023, 12:35:51 UTC | stream: move get_title typed control to stream specific section | 16 March 2023, 14:20:37 UTC |
| 21f9f38 | Loïc | 13 March 2023, 09:47:39 UTC | stream: move get_seekpoint typed control to specific stream section This is done because the type is different from stream and demux. | 16 March 2023, 14:20:37 UTC |
| 5f60396 | Thomas Guillem | 13 March 2023, 15:31:01 UTC | logger/json: change license to LGPL 2.1 The original GPL 2 license was an error, that I missed during the review process. Nicolas agreed with this license change by mail. | 16 March 2023, 08:37:18 UTC |
| 6d90eba | Pierre Lamot | 14 March 2023, 14:42:54 UTC | demux: adaptive: fix language parsing | 15 March 2023, 16:17:44 UTC |
| 38d1711 | Alexandre Janniaux | 27 January 2023, 14:31:57 UTC | audio_output: android: split DynamicsProcessing DynamicsProcessing is used by android/device.c, by audiotrack and by aaudio and a common vtable is needed as well as the matching JNI helpers to use the vtable. The vtable is currently stored in the audiotrack vtable, which is available in the other plugins in static build. But it leads to undefined reference errors when compiling a dynamic build of libvlc for android. Split the code handling this vtable in a separate convenience library to address this, which is then linked to every other targets. Since convenience libraries are playing a different role than static libraries, and are not linked but merged into the final objects that will be part of the library output (shared or archive), the symbols are then available to each of the plugins. Fixes #27726 | 15 March 2023, 14:30:09 UTC |
| 352a3cd | Thomas Guillem | 14 March 2023, 14:04:27 UTC | audio_output: android: add vlc_android_AudioFormat_FourCCToEncoding() Finish the transition to the new audioformat_jni helper. | 15 March 2023, 14:30:09 UTC |
| ec94c47 | Thomas Guillem | 14 March 2023, 13:50:24 UTC | audio_output: android: remove AudioTrack_HasEncoding() The encoding is previously checked in device.c | 15 March 2023, 14:30:09 UTC |
| 189d435 | Alexandre Janniaux | 25 January 2023, 13:47:54 UTC | audio_output: android: move AudioFormat vtable Move the AudioFormat vtable to a separate file and convenience library so as to use the AudioFormat vtable from device.c. The choice of a convenience library here is to compile the code only once but be able to use it from different locations, especially since it needs the vtable filled before using the associated function. The commit doesn't change audiotrack yet, as the goal is mostly to fix the dynamic build on Android, and thus duplicates part of the code from there. Some more changes would be needed to potentially supply the vtable as parameter and provides what's missing for audiotrack.c to use this convenience library instead. | 15 March 2023, 14:30:09 UTC |
| ddb540c | Alexandre Janniaux | 16 January 2023, 14:05:04 UTC | audio_output: android: link android_env The convenience library libandroid_env is needed in particular for the function android_GetEnv. There's no functional changes for the current way we distribute android, ie. in static builds, since link options are ignored, but it's needed to compile a dynamic build. | 15 March 2023, 14:30:09 UTC |
| c65493d | Alexandre Janniaux | 11 July 2021, 14:39:53 UTC | modules: split android_env from android_utils android_utils depends on GLES2_LIBS and EGL_LIBS, but it isn't forwarded correctly from the convenience library. In particlar, it contains mostly video-related code, and some helpers for the android environment state, which is why the non-video code is using the utils library. Move the code in a separate convenience library so that it can be imported without constraints. | 15 March 2023, 14:30:09 UTC |
| e6785a0 | Claudio Cambra | 12 March 2023, 13:46:33 UTC | macosx: Scroll to current playlist item when playlist controller detects current item change Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 15 March 2023, 10:58:56 UTC |
| 4b2b05c | Claudio Cambra | 12 March 2023, 13:45:06 UTC | macosx: Add method to VLCPlaylistDataSource to scroll to the current playlist item Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 15 March 2023, 10:58:56 UTC |
| 92dce52 | Claudio Cambra | 12 March 2023, 13:07:19 UTC | macosx: Don't update the playlist data source every time the current item changes Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 15 March 2023, 10:58:56 UTC |
| 79b837b | Steve Lhomme | 13 March 2023, 11:16:26 UTC | meson: remove forced _THREAD_SAFE optional define It's not set in the meson files and it's not done in autotools builds. | 15 March 2023, 09:50:57 UTC |
| 88ec5e9 | Steve Lhomme | 13 March 2023, 11:16:07 UTC | meson: remove forced _REENTRANT optional define It's not set in the meson files and it's not done in autotools builds. | 15 March 2023, 09:50:57 UTC |
| 3c67f74 | Steve Lhomme | 13 March 2023, 11:14:07 UTC | meson: remove unused HAVE_X11_XLIB_H It doesn't exist in autotools. | 15 March 2023, 09:50:57 UTC |
| c11e6bb | Steve Lhomme | 13 March 2023, 11:13:30 UTC | meson: remove unused HAVE_QSORT_R It doesn't exist in autotools. | 15 March 2023, 09:50:57 UTC |
| 39ff358 | Steve Lhomme | 13 March 2023, 11:11:37 UTC | meson: remove unused HAVE_INET_NTOP It doesn't exist in autotools. | 15 March 2023, 09:50:57 UTC |
| 7ccaed3 | Steve Lhomme | 13 March 2023, 11:10:19 UTC | meson: remove unused CAN_COMPILE_SSE4xxx They don't exist in autotools | 15 March 2023, 09:50:57 UTC |
| 442338a | Steve Lhomme | 13 March 2023, 11:09:07 UTC | meson: use comments from autotools in config.h.meson For better or worse. It helps comparing the files. | 15 March 2023, 09:50:57 UTC |
| ca7270f | Steve Lhomme | 13 March 2023, 11:03:25 UTC | meson: reorder config.h.meson to match autoconf config.h order This makes it easier to compare them, to find what is missing, what is extra. No functional changes. | 15 March 2023, 09:50:57 UTC |
| 1ccffc3 | Steve Lhomme | 14 March 2023, 08:17:50 UTC | control: remove unimotion motion handling This code is very old and seems to require the installation of another module. There's no trace online of this extra code. | 15 March 2023, 09:00:38 UTC |
| 586e1cb | Steve Lhomme | 07 December 2022, 10:10:46 UTC | libvlc: use the local includes in vlc.h Do not allow messing with the include path and end up using other includes. Any C compiler should respect the "" meaning including local files before looking in other pathes. | 14 March 2023, 09:53:54 UTC |
| 07d8bc7 | Alexandre Janniaux | 08 March 2023, 16:50:47 UTC | input: es_out: reset buffering on PCR discontinuity When PCR discontinuities happens, the whole pipeline is reset and it safely (though after a glitch) reset back to playback on what's visible after the PCR discontinuities, and restart buffering. However, this PCR discontinuity currently happens only when **not** in buffering. When it happens during buffering, then: - either the PCR value is much bigger than expected, and buffering will stop sooner than expected. | Buffer start Buffer end New PCR | v v v | |------.-------------------| | | ^ | Old PCR |----------------------| | Missing buffering +-- Resulting buffer after PCR jump to the future. - or the PCR value is much smaller than expected, and the buffering is completely borked, the computed stream buffer duration is negative and it would buffer for the time of the | New PCR Buffer start Buffer end | v v v | |---------------|------.-------------------| | ^ | Old PCR | | Total buffering: | | Buffering after the PCR jump | |------------------------------------------| | + | |------| | Previous additional buffering | +-- Resulting buffer after PCR jump to the past. The second behaviour can be visible when disabling the __MAX for the caching progress value, leading to logs like: [000055df326370e0] main input debug: Buffering 0% [000055df326370e0] main input debug: Buffering 1% [000055df326370e0] main input debug: Buffering 2% [000055df326370e0] main input debug: Buffering 3% [000055df326370e0] main input debug: Buffering 4% [000055df326370e0] main input debug: Buffering 5% [000055df326370e0] main input debug: Buffering 6% [000055df326370e0] main input debug: Buffering 7% [000055df326370e0] main input debug: Buffering -99% [000055df326370e0] main input debug: Buffering -98% ... Such scenario can be created by streaming a .ts file with the option --ts-trust-pcr on udp://127.0.0.1:1234 for instance, while running ffmpeg with: ffmpeg -re -i input_file.ts -f mpegts udp://127.0.0.1:1234 During buffering, interrupt and restart the ffmpeg streaming command. The value in --network-caching can also be increase to ensure easier reproduction of the scenario. Instead, if PCR is going back to the past, flush the pipeline and reset the buffering back to zero to avoid waiting for the stream to catch-up with the old reference, and avoid buffering more than what we requested, which would shift the playback more from the live. | - Step 1: | New PCR Buffer start Buffer end | v v v | |---------------|------.-------------------| | ^ | Old PCR | | - Step 2: | Previous buffering is dropped. | |------| | |--------------------------| | ^ ^ | New PCR New buffer end | | +-- New buffering behaviour when PCR jumps to the past. | 14 March 2023, 09:24:17 UTC |
| 3ccf6ae | Steve Lhomme | 06 September 2022, 11:17:49 UTC | decklink: fix fourcc string to enum conversion Before 9168091a46266f51e30e49045627b9d23ff75e0e htonl() was used to convert the values to/from enum to the string. But that commit broke the conversion on little endian machines. Now we don't use an intermediate string anymore. We just use GetDWBE() to do the endianness conversion of the char buffer if needed. | 14 March 2023, 08:12:04 UTC |
| 437d802 | Jean-Baptiste Kempf | 08 January 2023, 08:51:43 UTC | Win32: add tak to the installer | 12 March 2023, 13:00:08 UTC |
| 0f92f19 | Steve Lhomme | 10 March 2023, 08:57:42 UTC | avcodec/dxva: use DXVA_NoEncrypt It is always defined when we use the dxva.h GUIDs. | 12 March 2023, 10:01:41 UTC |
| 5319cf9 | Steve Lhomme | 03 February 2023, 15:06:54 UTC | directx_va: define missing DXVA_xxx GUIDs for the platform SDK and mingw Favor the DXVA_xxx variants which are the most common ones. Redirect missing DXVA_xxx variants to existing alternatives in mingw-w64. Some GUIDs do not exist in any SDK so we need to define them ourselves. The we share the redirections with dxva_blocklist. | 12 March 2023, 10:01:41 UTC |
| 4c35385 | Thomas Guillem | 10 March 2023, 14:06:01 UTC | aaudio: restart stream when flushing Since flush is not working. There are 2 main issues: - AAudioStream_getTimestamp() could fail from Flush(), resulting in the impossibility to report a correct timing. As the doc says: "TODO review Frame counters are not reset by a flush", and we need a point of comparison after a flush. - Some devices (seen on The Galaxy S22 Ultra API Level 31) can't report a timestamp once the stream is flushed, resulting in the impossibility to report a correct timing. Now, the whole Flush() function take between 10ms and 25ms (depending on the device). Fixes #27917 | 12 March 2023, 09:26:44 UTC |
| c956314 | Thomas Guillem | 10 March 2023, 14:26:12 UTC | aaudio: assert that "as" is valid after checking the state sys->as will be set to NULL in case of flush error in the next commit. | 12 March 2023, 09:26:44 UTC |
| 3fa5113 | Thomas Guillem | 10 March 2023, 13:52:23 UTC | aaudio: handle device_id In order to use the same decide_id when we restart the AAudio stream. | 12 March 2023, 09:26:44 UTC |
| 3aee173 | Thomas Guillem | 10 March 2023, 13:34:35 UTC | aaudio: split OpenAAudioStream() In order to be able to call it again, when flushing (cf. next commits). | 12 March 2023, 09:26:44 UTC |
| 9f6da29 | Thomas Guillem | 10 March 2023, 14:22:47 UTC | aaudio: close even in case of failure | 12 March 2023, 09:26:44 UTC |
| bb8f216 | Thomas Guillem | 10 March 2023, 13:22:25 UTC | aaudio: create CloseAAudioStream() function | 12 March 2023, 09:26:44 UTC |
| b41e227 | Thomas Guillem | 10 March 2023, 13:18:59 UTC | aaudio: move function up To avoid forward declaration in a next commit. No functional changes. | 12 March 2023, 09:26:44 UTC |
| a149122 | Thomas Guillem | 09 March 2023, 10:10:14 UTC | aaudio: report latency only in the STARTED state And not in the STARTING state. | 12 March 2023, 09:26:44 UTC |
| 65c3634 | Thomas Guillem | 10 March 2023, 13:25:35 UTC | aaudio: use LogAAudioError To convert the result to a string. | 12 March 2023, 09:26:44 UTC |
| 371e18c | Thomas Guillem | 10 March 2023, 15:21:33 UTC | android_device: add missing initialisation Fixes a crash when setting volume/device if no stream were started. | 12 March 2023, 09:11:38 UTC |
| f77921f | Loïc | 30 January 2023, 15:49:28 UTC | stream: introduce typed operations for stream This commit introduce a typed virtual table for operations on stream, aiming at replacing the legacy pf_control() callback which is using va_list. As a counterpart to the typed virtual table, typed methods are also introduce. The operations can be implemented by the modules directly right now and will be used when possible. This is done to provide type safety at every level. When no operation is provided (ie, stream_t.ops is NULL) by a module implementation, the legacy pf_control will be used instead as a fallback. The commit doesn't migrate any of access/stream_filter/… modules yet. The commit also doesn't introduce the demux specific callbacks yet. | 11 March 2023, 18:01:48 UTC |
| 63488e0 | Thomas Guillem | 09 March 2023, 15:13:36 UTC | decoder: update the state directly when creating an output Threading changed, it is now possible. This fixes the video or audio output that can render the first frames in the initial state, leading to audio/video glitches (if a delay is applied after). For example, audio with clock-master=input: [00007fc4a4311760] main decoder: vlc_input_decoder_ChangeDelay(): 000055ad16120e60] main audio output error: Play in 133193 [000055ad16120e60] main audio output error: Play in 156331 [000055ad16120e60] main audio output error: Play in 179508 [000055ad16120e60] main audio output error: Play in 202699 [000055ad16120e60] main audio output error: Play in 225891 [00007fc4a4311760] main decoder: changing delay(2): -2000000 [000055ad16120e60] main audio output error: Play in -1750921 Refs #27918 | 11 March 2023, 16:51:11 UTC |
| a89b5d6 | Thomas Guillem | 10 March 2023, 10:49:57 UTC | decoder: rename request_rate to rate Use the same naming that paused and delay. | 11 March 2023, 16:51:11 UTC |
| 74adb26 | Thomas Guillem | 09 March 2023, 14:42:35 UTC | decoder: rename some functions These functions can be called from any threads, if the lock is held. | 11 March 2023, 16:51:11 UTC |
| 378db75 | Thomas Guillem | 09 March 2023, 14:41:47 UTC | decoder: move code up To avoid forward declarations in next commits. | 11 March 2023, 16:51:11 UTC |
| 656e5eb | Steve Lhomme | 10 March 2023, 12:03:28 UTC | media_track: fix tracklist leak when no track found When count is 0 the list is still allocated. Either we should not allocate one, we free it locally, or we pass it on as it. The latter is similar to the code from 40c14fbee48975100aaa92b83a99ac33fa086933 in libvlc_media_tracklist_from_es_array(). Introduced in 057f3ef9e8b6bef1db79c1824daf667f4e777283. | 11 March 2023, 16:32:00 UTC |
| 4bc4577 | Steve Lhomme | 10 March 2023, 08:36:08 UTC | avcodec: don't use the console "quiet" parameter Just use --verbose=-1 which is strictly equivalent. This module should not depend on another module's option. And we don't really need that option anyway. | 11 March 2023, 11:37:41 UTC |
| d9e5c65 | Fatih Uzunoglu | 06 March 2023, 16:16:51 UTC | qt: classify qml errors for logging | 11 March 2023, 11:11:35 UTC |
| f162293 | Alaric Senat | 09 March 2023, 17:06:07 UTC | contrib: meson: always use meson `setup` "meson builddir" has been deprecated since 0.64.0. Please see 3c7ab542c0c4770241eae149b0d4cd8de329aee0 [1] upstream for the complete explanation. [1] https://github.com/mesonbuild/meson/commit/3c7ab542c0c4770241eae149b0d4cd8de329aee0 | 11 March 2023, 07:18:05 UTC |
| 26abe73 | Steve Lhomme | 09 March 2023, 13:14:17 UTC | vout/interlacing: don't inherit sout-deinterlace-mode We just release the inherited value and overwrite a new value. This also fixes a crash if the software deinterlacer module is not found. var_CreateGetString is just: ``` var_Create( p_obj, psz_name, VLC_VAR_STRING | VLC_VAR_DOINHERIT ); return var_GetString( p_obj, psz_name ); ``` | 11 March 2023, 06:47:27 UTC |
| 36dbf29 | Alexandre Janniaux | 09 March 2023, 12:10:26 UTC | access: concat: fix typo in shortcut | 10 March 2023, 14:18:48 UTC |
| dfabf7d | Steve Lhomme | 09 March 2023, 08:31:22 UTC | mp4/coreaudio: use CoreAudio_Layout enum for the layout Fixes a sign comparison warning. | 10 March 2023, 13:48:55 UTC |
| 5f49b61 | Steve Lhomme | 09 March 2023, 08:31:07 UTC | mp4/coreaudio: move enums up No functional changes. | 10 March 2023, 13:48:55 UTC |
