4448647 | Thomas Guillem | 16 September 2024, 12:39:38 UTC | player: timer: always send update when forced This fixes npt or length not being updated in time by timer clients since the input source is not likely the best_source. | 18 September 2024, 06:02:32 UTC |
53fbd40 | Thomas Guillem | 16 September 2024, 12:18:12 UTC | input: don't override NPT with invalid values After a seek, the demux module can fail to get the NPT. Don't fallback to TICK_0 in that case, but use the previous value. Fixes #25816 | 18 September 2024, 06:02:32 UTC |
b5e27ed | Thomas Guillem | 16 September 2024, 09:14:08 UTC | audiotrack: remove unused writeBufferV21 This could lead to the "write" method being NULL and used for API 22 and 21. Fixes regression from ccd3eaae3f34359fa58f0ab6527e5f12e63e2ffb | 17 September 2024, 09:25:43 UTC |
e4dcada | Steve Lhomme | 05 September 2024, 09:17:45 UTC | hxxx_helper: use a macro to match the written NAL list with its array size | 17 September 2024, 07:51:58 UTC |
7ff50cc | Steve Lhomme | 05 September 2024, 07:04:09 UTC | hxxx_helper: always match the size check with the AnnexB array we write into We don't need to know what is the actual size. | 17 September 2024, 07:51:58 UTC |
5b7bb83 | Steve Lhomme | 05 September 2024, 07:01:09 UTC | hxxx_helper: always match the size check with the array we write into We don't need to know what is the actual size. | 17 September 2024, 07:51:58 UTC |
a53f646 | Steve Lhomme | 05 September 2024, 06:59:32 UTC | mux: mp4: always match the size check with the array we write into We don't need to know what is the actual size. | 17 September 2024, 07:51:58 UTC |
cc63808 | Ayush Dey | 03 September 2024, 12:23:25 UTC | input: add offset during seek by time operation Add an offset of `priv->i_start` during the seek by time operation to correctly account for the start time of individual segmented tracks. Modify the initial value passed to `input_SetTime()` to 0, as the start offset (`priv->i_start`) has already been considered. These changes ensure accurate timing and seek behavior in media files containing segmented tracks, such as those defined by CUE files, by aligning the seek position with the actual timing of individual segments. | 16 September 2024, 13:56:19 UTC |
d143110 | Ayush Dey | 03 September 2024, 12:20:40 UTC | input: add offset during seek by position operation Calculate the updated position by adding offset according to the current track duration. | 16 September 2024, 13:56:19 UTC |
0cc2d8b | Ayush Dey | 03 September 2024, 12:16:56 UTC | player: pass `start_offset` to vlc_player_UpdateTimer() and store it in the player timer Update the callers of `vlc_player_UpdateTimer()` to pass an additional `start_offset` argument, representing the start time of the current input item (acting as an offset). Modify the `vlc_player_UpdateTimer()` function to store this start timing in the player timer, ensuring accurate tracking of the playback start position. This change helps maintain correct timing information, particularly when dealing with segmented tracks or CUE files, by ensuring the player's timer aligns with the actual start time of the input. | 16 September 2024, 13:56:19 UTC |
05c9191 | Ayush Dey | 03 September 2024, 12:05:47 UTC | player: add data member `start_offset` in struct vlc_player_timer This data member `start_offset` will be used in the next commit to store the start time(which will act as as offset) of the current track so that the current timestamp is adjusted accordingly. | 16 September 2024, 13:56:19 UTC |
20ca1dd | Ayush Dey | 03 September 2024, 11:51:28 UTC | input: add input_GetItemDuration function to calculate input thread item duration Reverts commit c86e464f and bf5b6d59 Add the input_GetItemDuration function, which calculates the duration of a track item based on the start and stop times stored in the input thread's private data. If the stop time is not set, the function considers the provided duration as the stop time; otherwise, it calculates the duration using the start and stop times. Call input_GetItemDuration for retrieving the updated duration of the current track item. The calculated duration is then used to set the player's length accurately. | 16 September 2024, 13:56:19 UTC |
161998d | Claudio Cambra | 15 September 2024, 10:06:10 UTC | macosx: Remove margins from playlist sidebar view scrollview Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 10:20:07 UTC |
b4c0be7 | Claudio Cambra | 15 September 2024, 08:15:32 UTC | macosx: Connect video menu button to relevant outlets and actions in main video view Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 08:31:21 UTC |
64a065a | Claudio Cambra | 15 September 2024, 08:15:05 UTC | macosx: Set up tooltip and accessibility string on video menu button in video view controls bar Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 08:31:21 UTC |
89fd240 | Claudio Cambra | 15 September 2024, 08:14:28 UTC | macosx: Add openVideoMenu method to video view controls bar Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 08:31:21 UTC |
7d0af1d | Claudio Cambra | 15 September 2024, 07:59:07 UTC | macosx: Add a video settings button to main video view XIB Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 08:31:21 UTC |
8e50335 | Thomas Guillem | 13 September 2024, 14:45:45 UTC | test: decoder: fix fmt_in leaks Regression from 08b24866dc443c30df8f9d5ee4f7e2045bf62956 ``` ==1851678==ERROR: LeakSanitizer: detected memory leaks Direct leak of 12 byte(s) in 1 object(s) allocated from: #0 0x55ab52726322 in malloc (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0xf5322) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #1 0x7fac6d4ed649 in es_format_Copy /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/misc/es_format.c:350:24 #2 0x7fac6d3c2fc9 in decoder_Init /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/input/decoder_helpers.c:49:5 #3 0x55ab52764362 in decoder_load /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/src/input/decoder.c:103:5 #4 0x55ab52764362 in test_decoder_create /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/src/input/decoder.c:196:9 #5 0x55ab52762fe5 in EsOutAdd /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/src/input/demux-run.c:86:19 #6 0x7fac59c9d0a4 in es_out_Add /home/tom/work/git/vlc/build-fuzzer-asan/modules/../../include/vlc_es_out.h:144:12 #7 0x7fac59c9d0a4 in avformat_OpenDemux /home/tom/work/git/vlc/build-fuzzer-asan/modules/../../modules/demux/avformat/demux.c:702:29 #8 0x7fac6d3c5d0a in demux_Probe /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/input/demux.c:112:15 #9 0x7fac6d368128 in vlc_module_load /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/modules/modules.c:230:15 #10 0x7fac6d3c5250 in demux_NewAdvanced /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/input/demux.c:196:20 #11 0x7fac6d3c48b3 in demux_New /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/input/demux.c:77:12 #12 0x55ab527620d9 in demux_process_stream /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/src/input/demux-run.c:294:22 #13 0x55ab52761c03 in LLVMFuzzerTestOneInput /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/vlc-demux-libfuzzer.c:54:5 #14 0x55ab52672134 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0x41134) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #15 0x55ab5265b083 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0x2a083) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #16 0x55ab52660ca6 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0x2fca6) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #17 0x55ab5268b796 in main (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0x5a796) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #18 0x7fac6cf2ddb9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 ``` | 16 September 2024, 07:51:16 UTC |
0001e85 | Tristan Matthews | 09 September 2024, 21:27:24 UTC | aom: make BGR matching stricter This is equivalent to the fix in ece317a245e8c32a5efc11d5e82dcd8a28a2f10b as the aom decoder had the same issue reported in #28776. | 16 September 2024, 07:05:27 UTC |
abea836 | Claudio Cambra | 14 September 2024, 06:45:40 UTC | macosx: Use connected property in abstract segment view controller subclasses to (not) reconnect data sources after long loads if that is applicable Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
19bffd8 | Claudio Cambra | 14 September 2024, 06:44:59 UTC | macosx: Add connected property to abstract segment view controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
5b6c3a4 | Claudio Cambra | 14 September 2024, 06:36:44 UTC | macosx: Override connect/disconnect in home view segment controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
c85242c | Claudio Cambra | 14 September 2024, 06:36:27 UTC | macosx: Use view controller connect/disconnect in library window Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
e3e8240 | Claudio Cambra | 14 September 2024, 06:36:12 UTC | macosx: Define connect/disconnect in abstract segment view controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
621ae1e | Claudio Cambra | 14 September 2024, 06:32:42 UTC | macosx: Remove embedded view presented/dismissed notifications and their use Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
1fd229d | Claudio Cambra | 13 September 2024, 16:09:41 UTC | macosx: Make placeholderImageViewSizeConstraints readonly in abstract segment view controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
53127e7 | Claudio Cambra | 08 September 2024, 17:33:48 UTC | macosx: Disconnect/reconnect containers when presenting or dismissing video playback view in library window Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
eb13e7b | Claudio Cambra | 08 September 2024, 17:23:17 UTC | macosx: Implement currentDataSource in library audio view controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
4edd175 | Claudio Cambra | 08 September 2024, 17:22:56 UTC | macosx: Implement currentDataSource in groups view controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
88c6543 | Claudio Cambra | 08 September 2024, 17:22:41 UTC | macosx: Implement currentDataSource in playlist view controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
e89f56a | Claudio Cambra | 08 September 2024, 17:22:14 UTC | macosx: Implement currentDataSource in library video view controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
5360293 | Claudio Cambra | 08 September 2024, 17:20:09 UTC | macosx: Disconnect/reconnect current data source upon receiving video view notifications from library window Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
94ebff9 | Claudio Cambra | 08 September 2024, 17:19:27 UTC | macosx: Add currentDataSource property to abstract segment view controller Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
413508c | Claudio Cambra | 08 September 2024, 16:54:41 UTC | macosx: Use library data source protocol in collection view/table view data source protocols Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
de04bbd | Claudio Cambra | 08 September 2024, 16:54:03 UTC | macosx: Add starter VLCLibraryDataSource Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
88d16a3 | Claudio Cambra | 07 September 2024, 17:03:47 UTC | macosx: Swap library target view notification for video view presented notification, handle correctly Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
a1bf5a7 | Claudio Cambra | 07 September 2024, 17:02:48 UTC | macosx: Remove handleLibraryTargetViewChanged from library window Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
9c509ce | Claudio Cambra | 07 September 2024, 11:15:28 UTC | macosx: Disconnect audio data source when current library target view is not audio library Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
4b7399c | Claudio Cambra | 07 September 2024, 11:14:15 UTC | macosx: Call target view change handler on all "show" type methods in library window Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
1d0c127 | Claudio Cambra | 07 September 2024, 11:13:45 UTC | macosx: Add method to emit notification about current library target view subviews changing Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
7452dde | Claudio Cambra | 07 September 2024, 11:13:24 UTC | macosx: Add target view changed notification name Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
2b0b486 | Claudio Cambra | 07 September 2024, 11:14:44 UTC | macosx: Connect/disconnect slave audio group data source within audio data source Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 16 September 2024, 06:21:55 UTC |
45b3652 | Fatih Uzunoglu | 30 August 2024, 15:16:24 UTC | qml: fix drag item no longer showing any image regression Since 72f086c9, `RoundImage` has been used in `DragItem`. However, it only works asynchronously and by the time the input items are resolved, `RoundImage` instance(s) are still in the progress of loading the image. I added an intermediate state to wait for images to be loaded. If the loading takes too much time, then the timer is going to start the drag, so this change does not make drag initalization synchronous. | 16 September 2024, 05:58:28 UTC |
01e229a | Prince Gupta | 06 August 2024, 17:34:59 UTC | qml: remove redundant property | 15 September 2024, 10:14:28 UTC |
d35922e | Prince Gupta | 06 August 2024, 17:32:24 UTC | qml: fix new indicator in video views correctly place contentItem of GridItem otherwise this affects adding new UI elements to it | 15 September 2024, 10:14:28 UTC |
1ddeb93 | Fatih Uzunoglu | 16 August 2024, 13:54:55 UTC | qt: provide MIME data in DragItem with type "text/uri-list" as per RFC-2483 | 15 September 2024, 10:01:15 UTC |
5d328a6 | Fatih Uzunoglu | 23 August 2024, 13:47:44 UTC | qt: add invokable `urlListToMimeData()` to MainCtx | 15 September 2024, 10:01:15 UTC |
86de5f7 | Fatih Uzunoglu | 19 August 2024, 10:20:27 UTC | qt: add `url` property to PlayerController | 15 September 2024, 10:01:15 UTC |
dcf54f4 | Fatih Uzunoglu | 16 August 2024, 13:51:17 UTC | qt: add "url" role to PlaylistListModel | 15 September 2024, 10:01:15 UTC |
e62abf0 | Fatih Uzunoglu | 19 August 2024, 10:27:09 UTC | qt: add "url" role to NetworkMediaModel | 15 September 2024, 10:01:15 UTC |
f788b1b | Fatih Uzunoglu | 16 August 2024, 13:51:33 UTC | qt: add "url" role to MLAlbumTrackModel | 15 September 2024, 10:01:15 UTC |
13c855a | Fatih Uzunoglu | 16 August 2024, 13:50:48 UTC | qt: add "url" role to MLFoldersBaseModel | 15 September 2024, 10:01:15 UTC |
9ffa52c | Claudio Cambra | 13 September 2024, 14:53:56 UTC | macosx: Change playlist icon to make it more media type-agnostic Can seem like playlists are for music and not general media Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 14 September 2024, 15:20:56 UTC |
eaa2a65 | Fatih Uzunoglu | 04 September 2024, 15:47:53 UTC | qml: provide the effective background color to the effect in TracksListPage If "transparent" color is provided, fading edge can not do sub-pixel font rendering. Translucent colors should be used only when absolutely necessary, such as when window background needs to be shown for the backdrop blur filter. In this case, it already has a solid background due to `stackViewParent` in `MainDisplay.qml`, that color should have been used instead. | 14 September 2024, 10:25:37 UTC |
53fe909 | Fatih Uzunoglu | 04 September 2024, 15:43:38 UTC | qml: fix artist list background exceeding view boundaries It is not clear why this item was placed in the hierarchy. Ideally, the view should be a pane and the `AcrylicBackground` should be its background item. But for now, placing it as its child with `z: -1` and anchoring to the parent (the view) seems to suffice. | 14 September 2024, 10:25:37 UTC |
c19d9d6 | Fatih Uzunoglu | 06 September 2024, 15:17:37 UTC | qml: do not override application cursor in playqueue button drop area | 14 September 2024, 09:34:06 UTC |
6a47377 | Fatih Uzunoglu | 06 September 2024, 15:15:38 UTC | qml: use busy cursor as soon as applicable in PlaylistMediaDisplay Although progress indicator is shown with a delay, the cursor should be rather changed to busy cursor as soon as possible. It is not really conventional to wait setting busy cursor when the view is already busy. | 14 September 2024, 09:34:06 UTC |
62a5a53 | Fatih Uzunoglu | 06 September 2024, 15:15:26 UTC | qml: use busy cursor as soon as applicable in PlaylistMediaList Although progress indicator is shown with a delay, the cursor should be rather changed to busy cursor as soon as possible. It is not really conventional to wait setting busy cursor when the view is already busy. | 14 September 2024, 09:34:06 UTC |
fc618f3 | Fatih Uzunoglu | 06 September 2024, 15:13:53 UTC | qml: do not override application cursor in DragItem Since drag is a native drag, cursor change is not no longer application's responsibility. | 14 September 2024, 09:34:06 UTC |
b95e567 | Prince Gupta | 09 September 2024, 13:27:42 UTC | qml: fix view change handling with size changes in ExpandGridView | 14 September 2024, 09:11:51 UTC |
d2582ac | Prince Gupta | 09 September 2024, 13:23:27 UTC | qml: fix possible race issue in ExpandGridView | 14 September 2024, 09:11:51 UTC |
16b31aa | Thomas Guillem | 11 September 2024, 06:16:36 UTC | packetizer: dts: check for frame_size for the first sync Only substreams are allowed to have a frame_size of 0. | 14 September 2024, 08:58:11 UTC |
b23f09b | Thomas Guillem | 11 September 2024, 06:15:52 UTC | dts_header: initialize SUBSTREAM_LBR size to 0 It's a substream and can't work alone, so a size of 0 is legitimate. Fixes #28773 (Use of uninitialised value) | 14 September 2024, 08:58:11 UTC |
4e64551 | Claudio Cambra | 12 September 2024, 16:17:24 UTC | macosx: Fix switch case and return warnings in VLCLibrarySegment Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 13 September 2024, 16:49:27 UTC |
c38e732 | Claudio Cambra | 12 September 2024, 16:01:50 UTC | macosx: Give library header segment an icon Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 13 September 2024, 16:49:27 UTC |
24064c1 | Claudio Cambra | 12 September 2024, 15:50:28 UTC | macosx: Remove defaults from segment switches Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 13 September 2024, 16:49:27 UTC |
5b0cf3e | Claudio Cambra | 12 September 2024, 15:50:08 UTC | macosx: Classify header segment types as group items Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 13 September 2024, 16:49:27 UTC |
feea59c | Claudio Cambra | 12 September 2024, 15:49:46 UTC | macosx: Properly handle new header segment types' selection Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 13 September 2024, 16:49:27 UTC |
c58b63b | Claudio Cambra | 12 September 2024, 15:49:13 UTC | macosx: Add VLCLibraryHeaderSegment Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 13 September 2024, 16:49:27 UTC |
6d93496 | Claudio Cambra | 11 September 2024, 17:24:32 UTC | macosx: Add vlc title segment type Signed-off-by: Claudio Cambra <developer@claudiocambra.com> | 13 September 2024, 16:49:27 UTC |
69ad323 | Fatih Uzunoglu | 13 August 2024, 14:59:02 UTC | qt: use `wl_surface_set_buffer_scale()` only when applicable | 13 September 2024, 14:39:26 UTC |
5d33c4e | Fatih Uzunoglu | 11 July 2024, 14:52:11 UTC | qt: support fractional scaling in wayland compositor | 13 September 2024, 14:39:26 UTC |
2f65308 | Fatih Uzunoglu | 11 July 2024, 14:47:51 UTC | qt: provide wayland protocol `viewporter` | 13 September 2024, 14:39:26 UTC |
f482c60 | Fatih Uzunoglu | 19 August 2024, 14:37:36 UTC | qml: factorize delegate vertical drop area layout in ListViewExt | 13 September 2024, 13:55:22 UTC |
0174b49 | Fatih Uzunoglu | 19 August 2024, 13:31:03 UTC | qml: consolidate `ListViewExt`'s drag and drop functionality over `TableViewExt` This makes it possible to not re-invent drop indicator positioning, and also allows rejecting the drag event when drop is not applicable. In order to reject drag event when not applicable, there needs to be two drop areas. This has been the case in `PlaylistListView/Delegate` but not in `TableViewExt/Delegate`. With this patch, I followed the same approach used in `PlaylistListView` which has a rather proven track record on drag and drop functionality. | 13 September 2024, 13:55:22 UTC |
43df33c | Fatih Uzunoglu | 19 August 2024, 12:33:27 UTC | qml: fix invalid property accession in PlaylistDelegate | 13 September 2024, 13:55:22 UTC |
81a50fa | Fatih Uzunoglu | 19 August 2024, 12:31:59 UTC | qml: enable ability to customize drop indicator in ListViewExt In some cases, drop indicator may need to be customized. This also allows disabling the indicator completely. The way it works is by instantiating the drop indicator from the component property once `itemContainsDrag`, which is an optional property, changes. | 13 September 2024, 13:55:22 UTC |
3855b46 | Pierre Lamot | 02 September 2024, 09:49:46 UTC | qt: make MLThreadRunner a disctinctive object from MediaLib this allows to handle the part that requires the deleteLater within the MediaLib class, this will allow us to handle the lifecycle of MediaLib like the other singletons | 13 September 2024, 13:17:01 UTC |
0cd4f24 | Pierre Lamot | 30 August 2024, 13:02:00 UTC | qt: don't store mlcustomcover instance in the medialibrary we don't need to store the image provider inside the medialibray as it's only useful to the QMLEngine. We only needed it fot crafting URL, but this can be done with a stateless function. | 13 September 2024, 13:17:01 UTC |
1b2afcd | Pierre Lamot | 06 August 2024, 11:58:09 UTC | qt: inject playlist controller as a depency in MediaLib | 13 September 2024, 13:17:01 UTC |
ffb7d09 | Pierre Lamot | 27 August 2024, 11:03:59 UTC | qt: remove unecessary includes from MainCtx | 13 September 2024, 13:17:01 UTC |
7185cd6 | Pierre Lamot | 26 August 2024, 13:53:15 UTC | qt: move art fetch callbacks to the cpp side | 13 September 2024, 13:17:01 UTC |
255f1c4 | Pierre Lamot | 26 August 2024, 12:53:17 UTC | qt: move isCurrentItemSynced to private API of PlayerController | 13 September 2024, 13:17:01 UTC |
92f71ae | Pierre Lamot | 14 August 2024, 11:24:49 UTC | qt: remove dependency on p_intf from ControlbarProfileModel | 13 September 2024, 13:17:01 UTC |
4db4c7a | Pierre Lamot | 13 August 2024, 10:01:45 UTC | qt: fix race condition on the Qml playlist instance initialisation when loading the interface we wait for the onPlaylistInitialized signal but this signal may be emitted before the interface is loaded, now we wait on a boolean state instead | 13 September 2024, 13:17:01 UTC |
592eab2 | Prince Gupta | 03 September 2024, 12:23:24 UTC | qml: rename MediaGroupDisplay to VideoGroupDisplay it's only suppose to handle videos | 13 September 2024, 13:02:32 UTC |
16645c5 | Prince Gupta | 03 September 2024, 12:17:13 UTC | qml: fix video group view loading add missing required property | 13 September 2024, 13:02:32 UTC |
e997e6a | Steve Lhomme | 09 September 2024, 07:33:00 UTC | video_output: fix Display Aspect Ratio initialization The read value is correct when GetAspectRatio() returns true. Bug introduced in 1a54ee461afda0126951ed568426f5577739815a. | 13 September 2024, 12:35:22 UTC |
d3e4f33 | Prince Gupta | 09 September 2024, 10:34:42 UTC | qml: fix header view alignment in BrowseView closes #28586 | 13 September 2024, 12:16:58 UTC |
0285de2 | Thomas Guillem | 09 September 2024, 10:57:24 UTC | test: decoder: refactor decoder creation | 13 September 2024, 09:49:49 UTC |
5f57257 | Thomas Guillem | 09 September 2024, 10:52:30 UTC | test: decoder: use an owner for the packetizer To access the fmt_in private member. Regression from 08b24866dc443c30df8f9d5ee4f7e2045bf62956 Fixes #28770 | 13 September 2024, 09:49:49 UTC |
0c0817f | Alaric Senat | 09 September 2024, 09:17:59 UTC | filters: proxy: keep track of the proxied vars state Since we now assume that the state of the filters parameters should be stored in the vout (cf. 0be3282eb6d9a04a86160a74b780b2774e0252fa), the state of the mapped variables should be kept between resets of the filter chain. The proxy functions used to create and destroy both the mappings and the bound callbacks. In a perfect world, the mapping of the variables and the binding of the callbacks should be decoupled. But for such a small utility function, we can just stop destroying the state of the variables between resets. This patch also reworks the documentation of the modified functions accordingly. Refs #28769 | 13 September 2024, 09:18:46 UTC |
1ca3319 | Alaric Senat | 09 September 2024, 09:32:10 UTC | qt: fix filter change regression This was forgotten by 0be3282eb6d9a04a86160a74b780b2774e0252fa. The filter options are now stored in the vout object instead of the interface. Fixes #28769 | 13 September 2024, 09:18:46 UTC |
551b1bd | Steve Lhomme | 09 September 2024, 08:42:34 UTC | video_window: use VLC_TICK_MIN to init last_left_press | 13 September 2024, 05:25:43 UTC |
4746ea5 | Alaric Senat | 10 September 2024, 08:20:45 UTC | mux: mpeg: check overflow in bit alignment Avoid an overflow when `bits_align` is called at the end of the available size. | 13 September 2024, 05:08:27 UTC |
dba9bb9 | Alaric Senat | 10 September 2024, 08:14:52 UTC | mux: mpeg: fix overflow handling Fixes regressions from 3856f9fce93471c1d36bc6fdc34ad92484d79be2. The previous barrier was using `i_count` as a **byte** count instead of a **bit** count leading to the function bailing for legitimate writes. This patches takes into account the remaining bits to write under the buffer cursor in its overflow check. | 13 September 2024, 05:08:27 UTC |
b132d09 | Alexandre Janniaux | 11 September 2024, 14:11:54 UTC | vpx_alpha: reindent after last changes | 13 September 2024, 04:41:03 UTC |
e3cad49 | Alexandre Janniaux | 10 September 2024, 11:30:12 UTC | vpx_alpha: early-return during merging Early return to avoid mixing the allocation path and the re-use path, making two level of indentation useless. Indentation is changed in the follow-up commit. | 13 September 2024, 04:41:03 UTC |
a3054e8 | Alexandre Janniaux | 10 September 2024, 11:30:12 UTC | vpx_alpha: use picture context to forward plane p_sys is used by the pool to forward the picture pool context. Pictures that are supporting copying should be using picture context instead, which the vpx_alpha decoder was already doing. This fixes a huge memory leak of picture data when playing VP9 videos. STACK OF 1242 INSTANCES OF 'ROOT LEAK: malloc[2097152]': 9 libsystem_pthread.dylib 0x185e89d34 thread_start + 8 8 libsystem_pthread.dylib 0x185e8ef94 _pthread_start + 136 7 libvlccore.9.dylib 0x1032606cc DecoderThread + 348 decoder.c:1869 6 libvlccore.9.dylib 0x103262c04 DecoderThread_DecodeBlock + 256 decoder.c:1627 5 ??? 0x107066034 0x7fffffffffffffff + 9223372041267601461 4 ??? 0x12a809674 0x7fffffffffffffff + 9223372041862813301 3 ??? 0x107065c70 0x7fffffffffffffff + 9223372041267600497 2 ??? 0x107066644 0x7fffffffffffffff + 9223372041267603013 1 ??? 0x1070662ec 0x7fffffffffffffff + 9223372041267602157 0 libsystem_malloc.dylib 0x185cc8a68 _malloc_zone_malloc_instrumented_or_legacy + 148 Instruments correctly indicates the following trace: CombinePicturesCPU SendMergedLocked QueuePic ecoder_QueueVideo ecodeBlock DecodeVideo Decode DecoderThread_DecodeBlock DecoderThread _pthread_start thread_start See ticket for details of the trace. Fixes #28792 | 13 September 2024, 04:41:03 UTC |
85a28e9 | Alexandre Janniaux | 11 September 2024, 13:49:55 UTC | vpx_alpha: add reference-counting to picture context The context is read-only and was currently copied for every picture, so switch to reference counting to avoid this. It will also help when moving planes stored in p_sys into the context, to determine when the allocated plane should be released, and to copy/share the pointer automatically. | 13 September 2024, 04:41:03 UTC |