| cc65bde | Danilo Piparo | 15 June 2024, 20:18:04 UTC | [ci] Solved issues harvesting: list projects | 15 June 2024, 20:18:04 UTC |
| 41b9bb4 | Danilo Piparo | 15 June 2024, 20:11:04 UTC | [ci] Improve diagnostic of solved issues harvester | 15 June 2024, 20:11:04 UTC |
| 90b0a5b | Mattias Ellert | 15 June 2024, 07:21:11 UTC | [core] Fix typo in comment | 15 June 2024, 10:19:31 UTC |
| 7e01f40 | will-cern | 15 June 2024, 06:52:10 UTC | [RF] Improve binBoundaries method of ParamHistFunc (#15650) ParamHistFunc currently does not adhere to the convention that if it is independent of the variable passed to binBoundaries method that it should return `nullptr`. This is fixed, along with more correct obtaining of the bin boundaries, from the RooDataHist itself. | 15 June 2024, 06:52:10 UTC |
| 916a0cb | will-cern | 15 June 2024, 06:49:58 UTC | [RF] xroofit update Updates to latest xRooFit version. | 15 June 2024, 06:49:58 UTC |
| e7d1add | Bertrand Bellenot | 14 June 2024, 13:38:17 UTC | [came][win32] Fix error with VS v17.10 Fixes https://github.com/root-project/root/issues/15336 Fix the following compilation errors with Visual Studio v17.10 on x86 ``` libCling.exp : error LNK2001: unresolved external symbol "char const * __cdecl __std_find_trivial<char const ,char>(char const *,char const *,char)" (??$__std_find_trivial@$$CBDD@@YAPBDPBD0D@Z) [C:\ root-dev\build\x86\release\core\metacling\src\Cling.vcxproj] libCling.exp : error LNK2001: unresolved external symbol "char * __cdecl __std_find_trivial<char,char>(char *,char *,char)" (??$__std_find_trivial@DD@@YAPADPAD0D@Z) [C:\root-dev\build\x86\release\co re\metacling\src\Cling.vcxproj] libCling.exp : error LNK2001: unresolved external symbol "int * __cdecl __std_find_trivial<int,int>(int *,int *,int)" (??$__std_find_trivial@HH@@YAPAHPAH0H@Z) [C:\root-dev\build\x86\release\core\met acling\src\Cling.vcxproj] libCling.exp : error LNK2001: unresolved external symbol "unsigned int * __cdecl __std_find_trivial<unsigned int,int>(unsigned int *,unsigned int *,int)" (??$__std_find_trivial@IH@@YAPAIPAI0H@Z) [C: \root-dev\build\x86\release\core\metacling\src\Cling.vcxproj] C:\root-dev\build\x86\release\bin\libCling.dll : fatal error LNK1120: 4 unresolved externals [C:\root-dev\build\x86\release\core\metacling\src\Cling.vcxproj] ``` | 14 June 2024, 16:42:21 UTC |
| a60f353 | Jonas Hahnfeld | 14 June 2024, 12:15:31 UTC | [ORC] Preserve order of constructors with same priority Constructors with the same priority should keep their relative order that was specified. This is important for clang-repl with many const variables after commit 05137ecfca ("[clang-repl] Emit const variables only once"). --- Fixes #15511 | 14 June 2024, 15:36:37 UTC |
| e87c429 | Vincenzo Eduardo Padulano | 14 June 2024, 08:58:33 UTC | [df] Improve semantics in df027 tutorial | 14 June 2024, 15:25:01 UTC |
| e63d246 | Vincenzo Eduardo Padulano | 14 June 2024, 07:46:46 UTC | [df] Remove recently introduced spurious comment in tutorial | 14 June 2024, 15:25:01 UTC |
| 5aa3b51 | Jakob Blomer | 10 June 2024, 09:35:10 UTC | [ntuple] several fixes to column representation of fields | 14 June 2024, 13:22:16 UTC |
| 3a59db4 | Jakob Blomer | 10 June 2024, 09:34:51 UTC | [NFC][ntuple] document column representations of fundamental types | 14 June 2024, 13:22:16 UTC |
| 99da614 | Jakob Blomer | 10 June 2024, 09:25:03 UTC | [ntuple] add double --> Real16 cast | 14 June 2024, 13:22:16 UTC |
| a89eabc | Jakob Blomer | 29 May 2024, 16:02:57 UTC | [ntuple] remove parameter from simple SealPage overload | 14 June 2024, 13:21:25 UTC |
| 0684e3d | Florine de Geus | 14 June 2024, 08:03:31 UTC | [ntuple] Change `VisitIntField` to `VisitInt32Field` This change makes the visitor consistent with the other integer visitors, which all use a fixed-width representation. | 14 June 2024, 12:19:15 UTC |
| 27def95 | Vincenzo Eduardo Padulano | 13 June 2024, 11:54:31 UTC | [cmake] Add asan options to ACLiC The compiler invokations run by ACLiC were not updated in case of a build with address sanitizer options enabled. This resulted in spurious warnings of the sort: ``` $: root -q -l -b test.C+ Processing test.C+... Info in <TUnixSystem::ACLiC>: creating shared library /tmp/./test_C.so /usr/bin/ld: /lib64/libasan.so.8: warning: the use of `tmpnam' is dangerous, better use `mkstemp' /usr/bin/ld: /lib64/libasan.so.8: warning: the use of `tempnam' is dangerous, better use `mkstemp' /usr/bin/ld: /lib64/libasan.so.8: warning: the use of `tmpnam_r' is dangerous, better use `mkstemp' /usr/bin/ld: /lib64/libasan.so.8: warning: the use of `tmpnam' is dangerous, better use `mkstemp' /usr/bin/ld: /lib64/libasan.so.8: warning: the use of `tempnam' is dangerous, better use `mkstemp' /usr/bin/ld: /lib64/libasan.so.8: warning: the use of `tmpnam_r' is dangerous, better use `mkstemp' ``` Co-authored-by: Giacomo Parolini <giacomo.parolini@cern.ch> | 14 June 2024, 08:19:51 UTC |
| 6d0a5da | Sergey Linev | 12 June 2024, 08:06:30 UTC | Improve df027 tutorial No need for vector of canvases - draw histograms on subpads Avoid usage of gStyle - stats and timeoffset can be configured for histogram Axis labels options now working with time display Draw all historgams after all created - avoid show of inactive and blocked canvas | 14 June 2024, 07:36:11 UTC |
| a79d6a0 | Sergey Linev | 10 June 2024, 10:23:12 UTC | Use log scale for df029 histogram Values range too big for normal scale Rename canvases | 14 June 2024, 07:36:11 UTC |
| da2c079 | Sergey Linev | 07 June 2024, 10:45:17 UTC | Improve df103_NanoAODHiggsAnalysis.py tutorial Clone histograms before configuring attributes and drawing them Directly draw TLegend with refs to these histograms Preserve canvas and histograms that they are usable at the end | 14 June 2024, 07:36:11 UTC |
| f7d274b | Sergey Linev | 06 June 2024, 11:59:36 UTC | Improve df103_NanoAODHiggsAnalysis.C tutorial Clone histograms before configuring attributes and drawing them Directly draw TLegend with refs to these histograms Call h_cmb->SetStats(kFALSE); instead gStyle->SetOptStat(0) Produced canvas can be stored in ROOT file | 14 June 2024, 07:36:11 UTC |
| 2077d18 | Jakob Blomer | 03 June 2024, 11:37:24 UTC | [ntuple] add test for std::set<std::array<...>> | 14 June 2024, 07:15:33 UTC |
| d87d3be | Sergey Linev | 13 June 2024, 14:12:56 UTC | Use TTimer in TGraphTime:Animate() Avoid potential leak beacuse of multiple call of TTimer::SingleShot() | 14 June 2024, 07:15:25 UTC |
| 2394133 | Sergey Linev | 13 June 2024, 13:45:08 UTC | Introduce TGrapthTime::Animate() method Let run endless animation of TGraphTime without blocking of main application loop - handling happens via timer | 14 June 2024, 07:15:25 UTC |
| ac318ef | Sergey Linev | 13 June 2024, 11:42:49 UTC | Do not implement TGraphTime::Paint method It is illigal usage of object which works differently as all other primitives One always has to use gr->Draw() method | 14 June 2024, 07:15:25 UTC |
| 3972dc5 | Sergey Linev | 13 June 2024, 11:10:45 UTC | Introduce TGraphTime::DrawStep method to draw single step Can be used in both drawing and creation of animated gif | 14 June 2024, 07:15:25 UTC |
| be46f04 | Sergey Linev | 13 June 2024, 10:43:25 UTC | Adjust TGraphTime tutorials | 14 June 2024, 07:15:25 UTC |
| 90eb776 | Sergey Linev | 13 June 2024, 10:26:09 UTC | Use new TPad::Add method in TGraphTime class Directly add objects to current pad Modernize syntax | 14 June 2024, 07:15:25 UTC |
| c680a12 | Sergey Linev | 13 June 2024, 09:13:15 UTC | No need sleep when creating animated gif TGraphTime | 14 June 2024, 07:15:25 UTC |
| 4c9f00a | Jakob Blomer | 05 June 2024, 14:37:30 UTC | [ntuple] simplification in RPageSource::UnzipClusterImpl() | 14 June 2024, 07:14:22 UTC |
| 80242e4 | Jakob Blomer | 05 June 2024, 14:28:24 UTC | [ntuple] move UnzipClusterImpl() in base class | 14 June 2024, 07:14:22 UTC |
| 208061d | Jakob Blomer | 07 June 2024, 19:24:02 UTC | [ntuple] fix unbuffered compression of large pages | 14 June 2024, 07:13:28 UTC |
| 4004fb5 | silverweed | 13 June 2024, 12:28:33 UTC | [core] clang-format RZip.h | 14 June 2024, 06:44:34 UTC |
| 84bce1f | silverweed | 11 June 2024, 09:33:47 UTC | [core] deprecate R__zip | 14 June 2024, 06:44:34 UTC |
| d6b623f | Danilo Piparo | 14 June 2024, 05:03:46 UTC | [ci] Restrict Numba versions to the ones prior to 0.60.0 | 14 June 2024, 05:03:46 UTC |
| 063ad51 | Danilo Piparo | 13 June 2024, 11:49:58 UTC | [ci] Add back the march=native build the preprocessor defines enabled by the march=native flag are made part of the string of options to be hashed to create the artifact tarball names, therewidth avoiding incompatible binaries. Moreover, the special builds preserve their overrides also for nightly builds. | 14 June 2024, 04:24:34 UTC |
| aa72126 | Jonas Rembser | 23 May 2024, 13:39:05 UTC | [RF] Enable RooCrystalBall test for AD Since this works now with Clad 1.5. | 13 June 2024, 19:51:45 UTC |
| 3b0da5e | Jonas Rembser | 13 June 2024, 15:31:44 UTC | [RF] Don't call `resetDataToken()` on RooRealVars in Evaluator d'tor It's not necessary because the data token is not set for `RooRealVar`s to begin with: https://github.com/root-project/root/blob/master/roofit/roofitcore/src/RooFit/Evaluator.cxx#L185 And by not doing this unnecessary resetting, we avoid potential crashes in case the `RooRealVar`s live not as long as the evaluator. | 13 June 2024, 19:51:33 UTC |
| 7c8bf28 | Jonas Rembser | 13 June 2024, 11:43:29 UTC | [RF][HS3] Add Workspace => JSON => Workspace => JSON check to tests Make sure that objects in a list are always exported to JOSN alphabeticall, so the JSON 1 vs. JSON 2 comparision doesn't fail. | 13 June 2024, 15:50:28 UTC |
| 7d2ca9a | Jonas Rembser | 12 June 2024, 21:59:28 UTC | [RF][HS3] Sort variables exported by RooGenericPdf and FooFormulaVar This makes the generated JSON more reproducible. | 13 June 2024, 15:50:28 UTC |
| 58ab095 | Jonas Rembser | 10 June 2024, 15:47:15 UTC | [RF][HS3] Clean roundtripping of RooExponential and RooLogNormal Make sure that when transforming workspaces with these classes, roundtripping from RooFit -> JSON -> RooFit -> JSON leaves both the RooFit workspace and the JSON unchanged. Closes #15756. | 13 June 2024, 15:50:28 UTC |
| 0d39472 | Sergey Linev | 13 June 2024, 08:55:09 UTC | change r owner | 13 June 2024, 13:45:27 UTC |
| d5d7d88 | Sergey Linev | 13 June 2024, 08:27:30 UTC | Typo in cmake | 13 June 2024, 13:45:27 UTC |
| 37e8ec7 | Sergey Linev | 13 June 2024, 08:26:36 UTC | Extend CODEOWNERS for all webgui components | 13 June 2024, 13:45:27 UTC |
| 1a2b519 | Mattias Ellert | 02 June 2024, 05:03:42 UTC | Fix test failure on ppc64le and s390x | 13 June 2024, 13:18:02 UTC |
| 9196cb5 | Mattias Ellert | 13 June 2024, 12:58:31 UTC | Adjust stressGraphics.ref (#15735) | 13 June 2024, 12:58:31 UTC |
| 834a618 | Mattias Ellert | 04 June 2024, 06:47:04 UTC | Correct format - warnings seen on 32 bit architectures | 13 June 2024, 12:53:02 UTC |
| 2df8f57 | mdessole | 07 June 2024, 08:55:20 UTC | [RVec] Handle zero momentum | 13 June 2024, 12:22:26 UTC |
| e30e1f0 | mdessole | 07 June 2024, 08:54:51 UTC | [RVec] Modify input values for testing | 13 June 2024, 12:22:26 UTC |
| f4e98a1 | mdessole | 06 June 2024, 08:23:23 UTC | [RVec] Add InvariantMasses_PxPyPzM tests | 13 June 2024, 12:22:26 UTC |
| ed078d8 | mdessole | 05 June 2024, 08:05:05 UTC | [RVec] Modify computation for numerical stability | 13 June 2024, 12:22:26 UTC |
| 5d47bf7 | Jakob Blomer | 13 June 2024, 10:00:25 UTC | [ntuple] remove unnecessary memory allocations | 13 June 2024, 12:02:52 UTC |
| 923678c | Jakob Blomer | 13 June 2024, 07:23:20 UTC | [ntuple] read header and footer in vector read Saves one round trip when opening an RNTuple. Also adds reading the header and the footer to the accounting. | 13 June 2024, 12:02:52 UTC |
| c946a73 | silverweed | 12 June 2024, 09:11:27 UTC | [rdf] remove useless ctor overload in RSnapshotOptions | 13 June 2024, 11:58:19 UTC |
| 3361eb1 | silverweed | 03 June 2024, 09:23:47 UTC | [core] Deprecate ECompressionAlgorithm | 13 June 2024, 11:58:19 UTC |
| b16e897 | Sergey Linev | 13 June 2024, 07:02:53 UTC | Always set kMustCleanup bit when object add to pad Set such bit in new `TPad::Add()` and `TPad::AddFirst()` methods. Bit was already set in `TObject::AppendPad()`, now it also will be set for other use cases where `TPad::Add()` is used | 13 June 2024, 08:48:43 UTC |
| d0a3d7d | Olivier Couet | 12 June 2024, 16:37:23 UTC | Use the new TPad shortcuts | 13 June 2024, 08:48:28 UTC |
| 45d08d4 | moneta | 12 June 2024, 12:41:26 UTC | [tmva][sofie] Use -1 as default for batch_size in RFunction_Update::GenerateModel The GenerateModel function called for the GNN classes was having a default =1 for the batch size used when generating the update models. We should use -1 to not force any specific batch size and use directly the given input shape | 13 June 2024, 06:34:40 UTC |
| 6feba92 | moneta | 12 June 2024, 09:50:14 UTC | [tmva][sofie] FIx setting batch size in Keras parsing Fix for setting t he batch size when parsing a Keras model where the input batch size is not defined Add extra optional parameter in the Parse function to specify the batch size | 13 June 2024, 06:34:40 UTC |
| dfdc2ba | lmoneta | 11 June 2024, 10:09:34 UTC | [tmva][sofie] Apply a fix when batch size is given by user When input shape is parametric, give possibility to fix the batch size if provided by user in RModel::Generate | 13 June 2024, 06:34:40 UTC |
| 4fe33d2 | Jonas Rembser | 12 June 2024, 16:22:23 UTC | [PyROOT] Register custom converters and executors via CPyCppyy API Synchronizes with this upstream commit and directly makes use of the new API to avoid a patch: https://github.com/wlav/CPyCppyy/commit/993b17bce2f43516a85931b40035ac7252e2ab7e | 12 June 2024, 16:22:23 UTC |
| e9f8149 | Mattias Ellert | 10 June 2024, 16:41:49 UTC | [core] Add comment about not calling bswapcpy with n == 0 | 12 June 2024, 15:09:33 UTC |
| 9f84771 | Mattias Ellert | 07 June 2024, 04:49:39 UTC | [io] WriteFastArray: return early if n == 0, to prevent crash in bswapcpy | 12 June 2024, 15:09:33 UTC |
| 66343dc | Sergey Linev | 12 June 2024, 10:34:09 UTC | [webgui] use new TPad::Add and TPad::Remove methods | 12 June 2024, 14:56:13 UTC |
| 541b6e4 | Sergey Linev | 12 June 2024, 09:29:33 UTC | Use new TPad methods in graf2d/gpad/ classes | 12 June 2024, 14:56:13 UTC |
| 58c2f8d | Sergey Linev | 12 June 2024, 08:41:06 UTC | Use TPad::Add method in TObject drawing No need to check primitives, pad is automatically modified | 12 June 2024, 14:56:13 UTC |
| d244c59 | Sergey Linev | 12 June 2024, 08:34:18 UTC | Introduce TPad::Add, TPad::AddFirst and TPad::Remove methods Let add or remove primitives from the pad directly. Provide simple interface to add or remove drawn objects without setting of gPad | 12 June 2024, 14:56:13 UTC |
| e9d734d | Vincenzo Eduardo Padulano | 12 June 2024, 11:30:01 UTC | [df] Shorten jitted expression in test The test previously build an expression with 4096 occurrences of the 'x' variable. This was causing a segfault with the address sanitizer that is independent of RDataFrame and tracked at https://github.com/root-project/root/issues/15818. Shorten the test expression to 100 occurences of 'x' which still represents a realistically long one-line expression and better decouples the clang-related asan issue from the rest of the RDataFrame testing infrastructure. | 12 June 2024, 14:50:48 UTC |
| 8c1cae2 | Sergey Linev | 12 June 2024, 11:44:28 UTC | [jsroot] dev 11/06/2024 1. Support gStyle.fLegendFillStyle 2. Fix - properly save zoomed ranges in drawingJSON() 3. Fix - always show all ticks for labeled axis 4. Fix - draw TProfile2D bins content as text, not entrie 5. Fix - interactive zooming on log color palette | 12 June 2024, 14:37:44 UTC |
| 539e1d8 | Sergey Linev | 12 June 2024, 10:52:29 UTC | [webgui] remove workaround for WaitPrimitive Primitives creation is not implemented in the web canvas and WaitPrimitive is returning for web canvas. Workaround was chaning selected pad and had side effect on TObject::DrawClone method | 12 June 2024, 14:37:44 UTC |
| 6a3b464 | Sergey Linev | 12 June 2024, 10:49:22 UTC | [webgui] do not support WaitPrimitive for web canvas Editor mode not yet implemented therefore one can simply return from the method | 12 June 2024, 14:37:44 UTC |
| da899df | Sergey Linev | 06 June 2024, 08:20:03 UTC | [webgui] Use TF1::HasSave to check if there are saved buffer | 12 June 2024, 14:37:44 UTC |
| aa6fcb7 | Sergey Linev | 05 June 2024, 13:02:23 UTC | [webgui] improve handling of TF1 saved buffer If function cannot be invoked - do not try to save it. Also do now overwrite saved buffer without need. | 12 June 2024, 14:37:44 UTC |
| e5b5b17 | Sergey Linev | 12 June 2024, 11:28:48 UTC | [webgui] ensure main thread id set when TWebCanvas is created Workaround for multi-threaded environment Ensure main thread id picked when canvas implementation is created otherwise it may be assigned in other thread and screw-up gPad access. Workaround may not work if main thread id was wrongly initialized before This resolves issue https://github.com/root-project/root/issues/15498 | 12 June 2024, 14:20:44 UTC |
| 6e1b846 | Danilo Piparo | 12 June 2024, 09:18:56 UTC | [ci] Remove the march-native special build since the hosts on which we run the containers do not all provide the same instruction sets. | 12 June 2024, 12:34:48 UTC |
| 9468425 | Jakob Blomer | 29 May 2024, 09:00:36 UTC | [ntuple] minor improvement in RDaos | 12 June 2024, 11:39:13 UTC |
| 2b7280b | silverweed | 12 June 2024, 08:54:45 UTC | [rdf] add RIO dependency for dataframe_splitcoll_arrayview | 12 June 2024, 11:09:50 UTC |
| bb60372 | Vincenzo Eduardo Padulano | 12 June 2024, 07:18:13 UTC | [tree] Prefer stack variables in BulkApiVarLength test | 12 June 2024, 08:57:08 UTC |
| b8d8109 | Vincenzo Eduardo Padulano | 12 June 2024, 07:14:50 UTC | [tree] Avoid heap-use-after-free in BulkApiVarLength test Ensure proper TFile memory management and avoid TTreeReader accessing the TFile after its destruction. ``` 479: ==2573107==ERROR: AddressSanitizer: heap-use-after-free on address 0x617000051b48 at pc 0x7f0fcf4e089e bp 0x7fff6e7e1fe0 sp 0x7fff6e7e1fd8 479: READ of size 8 at 0x617000051b48 thread T0 479: #0 0x7f0fcf4e089d in TTree::GetNotify() const /home/vpadulan/Programs/rootproject/rootsrc/tree/tree/inc/TTree.h:503 479: #1 0x7f0fcf4e089d in void TNotifyLinkBase::RemoveLink<TTree>(TTree&) /home/vpadulan/Programs/rootproject/rootsrc/core/base/inc/TNotifyLin k.h:104 479: #2 0x7f0fcf4e089d in TTreeReader::~TTreeReader() /home/vpadulan/Programs/rootproject/rootsrc/tree/treeplayer/src/TTreeReader.cxx:252 479: #3 0x4321ca in BulkApiVariableTest_stdRead_Test::TestBody() /home/vpadulan/Programs/rootproject/rootsrc/tree/tree/test/BulkApiVarLength.c xx:135 479: root-project#4 0x470c8c in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)() , char const*) (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/test/testBulkApiVarLength+0x470 c8c) (BuildId: aac947b72f02e5567382f0dadfefd1e97d058a56) 479: root-project#5 0x45a6d3 in testing::Test::Run() [clone .part.0] (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing- asan/tree/tree/test/testBulkApiVarLength+0x45a6d3) (BuildId: aac947b72f02e5567382f0dadfefd1e97d058a56) 479: root-project#6 0x45aa49 in testing::TestInfo::Run() (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tr ee/test/testBulkApiVarLength+0x45aa49) (BuildId: aac947b72f02e5567382f0dadfefd1e97d058a56) 479: root-project#7 0x45abf0 in testing::TestSuite::Run() [clone .part.0] (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-tes ting-asan/tree/tree/test/testBulkApiVarLength+0x45abf0) (BuildId: aac947b72f02e5567382f0dadfefd1e97d058a56) 479: root-project#8 0x46769e in testing::internal::UnitTestImpl::RunAllTests() (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-fre e-testing-asan/tree/tree/test/testBulkApiVarLength+0x46769e) (BuildId: aac947b72f02e5567382f0dadfefd1e97d058a56) 479: root-project#9 0x45b04c in testing::UnitTest::Run() (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tr ee/test/testBulkApiVarLength+0x45b04c) (BuildId: aac947b72f02e5567382f0dadfefd1e97d058a56) 479: root-project#10 0x424606 in main (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/test/testBulkApi VarLength+0x424606) (BuildId: aac947b72f02e5567382f0dadfefd1e97d058a56) 479: 0x617000051b48 is located 328 bytes inside of 712-byte region [0x617000051a00,0x617000051cc8) 479: freed by thread T0 here: 479: #0 0x7f0fcf8da878 in operator delete(void*) (/lib64/libasan.so.8+0xda878) (BuildId: 2e1c50524ff1a2e7e73c4565b46f3f51892353ea) 479: #1 0x7f0fcb9b4f25 in TCollection::GarbageCollect(TObject*) /home/vpadulan/Programs/rootproject/rootsrc/core/cont/src/TCollection.cxx:736 479: #2 0x7f0fcb9e8a27 in TList::Delete(char const*) /home/vpadulan/Programs/rootproject/rootsrc/core/cont/src/TList.cxx:535 479: #3 0x7f0fcb9c53d7 in THashList::Delete(char const*) /home/vpadulan/Programs/rootproject/rootsrc/core/cont/src/THashList.cxx:215 479: root-project#4 0x7f0fcc2d285d in TDirectoryFile::Close(char const*) /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TDirectoryFile.cxx:585 479: root-project#5 0x7f0fcc2d285d in TDirectoryFile::Close(char const*) /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TDirectoryFile.cxx:561 479: root-project#6 0x7f0fcc3468e4 in TFile::Close(char const*) /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TFile.cxx:989 479: root-project#7 0x7f0fcc3481fd in TFile::~TFile() /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TFile.cxx:566 479: root-project#8 0x7f0fcc348fd0 in TFile::~TFile() /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TFile.cxx:603 479: root-project#9 0x432ebf in BulkApiVariableTest_stdRead_Test::TestBody() /home/vpadulan/Programs/rootproject/rootsrc/tree/tree/test/BulkApiVarLength.c xx:130 479: root-project#10 0x470c8c in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)( ), char const*) (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/test/testBulkApiVarLength+0x47 0c8c) (BuildId: aac947b72f02e5567382f0dadfefd1e97d058a56) ``` | 12 June 2024, 08:57:08 UTC |
| bc1e20c | Vincenzo Eduardo Padulano | 12 June 2024, 07:11:10 UTC | [tree] Prefer stack variables in BulkApiSillyStruct test | 12 June 2024, 08:57:08 UTC |
| b73c036 | Vincenzo Eduardo Padulano | 12 June 2024, 07:09:02 UTC | [tree] Avoid heap-use-after-free in BulkApiSillyStruct test The destructor of TTreeReader was making use of the TFile after its destruction. ``` 480: ==2560128==ERROR: AddressSanitizer: heap-use-after-free on address 0x617000011648 at pc 0x7fb9d1ae089e bp 0x7ffd8e35b0a0 sp 0x7ffd8e35b098 480: READ of size 8 at 0x617000011648 thread T0 480: #0 0x7fb9d1ae089d in TTree::GetNotify() const /home/vpadulan/Programs/rootproject/rootsrc/tree/tree/inc/TTree.h:503 480: #1 0x7fb9d1ae089d in void TNotifyLinkBase::RemoveLink<TTree>(TTree&) /home/vpadulan/Programs/rootproject/rootsrc/core/base/inc/TNotifyLin k.h:104 480: #2 0x7fb9d1ae089d in TTreeReader::~TTreeReader() /home/vpadulan/Programs/rootproject/rootsrc/tree/treeplayer/src/TTreeReader.cxx:252 480: #3 0x433968 in BulkApiSillyStructTest_stdReadSplitBranch_Test::TestBody() /home/vpadulan/Programs/rootproject/rootsrc/tree/tree/test/Bulk ApiSillyStruct.cxx:104 480: root-project#4 0x470bac in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)() , char const*) (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/test/testBulkApiSillyStruct+0x4 70bac) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: root-project#5 0x45a5f3 in testing::Test::Run() [clone .part.0] (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing- asan/tree/tree/test/testBulkApiSillyStruct+0x45a5f3) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: root-project#6 0x45a969 in testing::TestInfo::Run() (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tr ee/test/testBulkApiSillyStruct+0x45a969) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: root-project#7 0x45ab10 in testing::TestSuite::Run() [clone .part.0] (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-tes ting-asan/tree/tree/test/testBulkApiSillyStruct+0x45ab10) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: root-project#8 0x4675be in testing::internal::UnitTestImpl::RunAllTests() (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-fre e-testing-asan/tree/tree/test/testBulkApiSillyStruct+0x4675be) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: root-project#9 0x45af6c in testing::UnitTest::Run() (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tr ee/test/testBulkApiSillyStruct+0x45af6c) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: root-project#10 0x425456 in main (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/test/testBulkApi SillyStruct+0x425456) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: root-project#11 0x7fb9cd446149 in __libc_start_call_main (/lib64/libc.so.6+0x28149) (BuildId: 0d710e9d9dc10c500b8119c85da75004183618e2) 480: root-project#12 0x7fb9cd44620a in __libc_start_main_impl (/lib64/libc.so.6+0x2820a) (BuildId: 0d710e9d9dc10c500b8119c85da75004183618e2) 480: root-project#13 0x4257b4 in _start (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/test/testBulkA piSillyStruct+0x4257b4) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: 0x617000011648 is located 328 bytes inside of 712-byte region [0x617000011500,0x6170000117c8) 480: freed by thread T0 here: 480: #0 0x7fb9d1eda878 in operator delete(void*) (/lib64/libasan.so.8+0xda878) (BuildId: 2e1c50524ff1a2e7e73c4565b46f3f51892353ea) 480: #1 0x7fb9cdfb4f25 in TCollection::GarbageCollect(TObject*) /home/vpadulan/Programs/rootproject/rootsrc/core/cont/src/TCollection.cxx:736 480: #2 0x7fb9cdfe8a27 in TList::Delete(char const*) /home/vpadulan/Programs/rootproject/rootsrc/core/cont/src/TList.cxx:535 480: #3 0x7fb9cdfc53d7 in THashList::Delete(char const*) /home/vpadulan/Programs/rootproject/rootsrc/core/cont/src/THashList.cxx:215 480: root-project#4 0x7fb9ce8d285d in TDirectoryFile::Close(char const*) /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TDirectoryFile.cxx:585 480: root-project#5 0x7fb9ce8d285d in TDirectoryFile::Close(char const*) /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TDirectoryFile.cxx:561 480: root-project#6 0x7fb9ce9468e4 in TFile::Close(char const*) /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TFile.cxx:989 480: root-project#7 0x7fb9ce9481fd in TFile::~TFile() /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TFile.cxx:566 480: root-project#8 0x7fb9ce948fd0 in TFile::~TFile() /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TFile.cxx:603 480: root-project#9 0x4338cd in BulkApiSillyStructTest_stdReadSplitBranch_Test::TestBody() /home/vpadulan/Programs/rootproject/rootsrc/tree/tree/test/Bulk ApiSillyStruct.cxx:103 480: root-project#10 0x470bac in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)( ), char const*) (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/test/testBulkApiSillyStruct+0x 470bac) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: previously allocated by thread T0 here: 480: #0 0x7fb9d1ed9e38 in operator new(unsigned long) (/lib64/libasan.so.8+0xd9e38) (BuildId: 2e1c50524ff1a2e7e73c4565b46f3f51892353ea) 480: #1 0x7fb9cdebbfd0 in TStorage::ObjectAlloc(unsigned long) /home/vpadulan/Programs/rootproject/rootsrc/core/base/src/TStorage.cxx:293 480: #2 0x7fb9d12cc209 in TObject::operator new(unsigned long) /home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-tes ting-asan/include/TObject.h:181 480: #3 0x7fb9d12cc209 in new_TTree /home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/G__Tree .cxx:4363 480: root-project#4 0x7fb9ce10a49c in TClass::NewObject(TClass::ENewType, bool) const /home/vpadulan/Programs/rootproject/rootsrc/core/meta/src/TClass.cxx :5003 480: root-project#5 0x7fb9ce113c7d in TClass::New(TClass::ENewType, bool) const /home/vpadulan/Programs/rootproject/rootsrc/core/meta/src/TClass.cxx:4980 480: root-project#6 0x7fb9ce9cda38 in TKey::ReadObjectAny(TClass const*) /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/TKey.cxx:1086 480: root-project#7 0x7fb9ce8d10a7 in TDirectoryFile::GetObjectChecked(char const*, TClass const*) /home/vpadulan/Programs/rootproject/rootsrc/io/io/src/T DirectoryFile.cxx:1111 480: root-project#8 0x7fb9d1ade1d1 in void TDirectory::GetObject<TTree>(char const*, TTree*&) /home/vpadulan/Programs/rootproject/rootsrc/core/base/inc/TD irectory.h:214 480: root-project#9 0x7fb9d1ade1d1 in TTreeReader::TTreeReader(char const*, TDirectory*, TEntryList*) /home/vpadulan/Programs/rootproject/rootsrc/tree/tre eplayer/src/TTreeReader.cxx:232 480: root-project#10 0x433332 in BulkApiSillyStructTest_stdReadSplitBranch_Test::TestBody() /home/vpadulan/Programs/rootproject/rootsrc/tree/tree/test/Bu$ kApiSillyStruct.cxx:87 480: root-project#11 0x470bac in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)( ), char const*) (/home/vpadulan/Programs/rootproject/rootbuild/bulksilly-heap-use-after-free-testing-asan/tree/tree/test/testBulkApiSillyStruct+0x 470bac) (BuildId: 45d8d15c24ba2aae252398ec00943aba7665b034) 480: 480: SUMMARY: AddressSanitizer: heap-use-after-free /home/vpadulan/Programs/rootproject/rootsrc/tree/tree/inc/TTree.h:503 in TTree::GetNotify() co nst ``` | 12 June 2024, 08:57:08 UTC |
| 7cc68bb | silverweed | 07 June 2024, 15:19:24 UTC | [skip-ci][RDF] clang-format some RDF tests | 12 June 2024, 08:00:37 UTC |
| 038054b | Vincenzo Eduardo Padulano | 11 June 2024, 07:10:28 UTC | [PyROOT][NFC] Relax memory test At least on Windows 4KB was sometimes triggering a failure, increase to 16KB threshold as it still should not represent an issue. | 12 June 2024, 07:44:45 UTC |
| 97ea6cf | Danilo Piparo | 11 June 2024, 13:22:16 UTC | [math] Use correct type when invoking the GSLIntegrator plugin, otherwise heavy checks in the PluginHandler take place that perform interpreter lookups. Fixes #15579 | 11 June 2024, 18:47:56 UTC |
| 2ae6678 | Florine de Geus | 07 June 2024, 09:16:20 UTC | [ntuple][NFC] Clarify deferred column documentation | 11 June 2024, 08:06:04 UTC |
| 1e0b7f9 | Florine de Geus | 07 June 2024, 09:15:34 UTC | [ntuple][NFC] Add late model extension documentation | 11 June 2024, 08:06:04 UTC |
| 0cc7d61 | Jonas Rembser | 10 June 2024, 10:32:42 UTC | [PyROOT] Implement TTree SetBranchAddress pythonization in Python The pythonization of `TTree::SetBranchAddress` was implemented in C++, hacking into CPyCppy by using implementation details like data member caches (this call: `((CPPInstance *)address)GetDatamemberCache()`). Not too surprising that it apparently breaks with the upcoming Python 3.13. It's better to implement the pythonizations in Python and also manage the lifetime of the necessary data in Python. This is done in this commit. The pythonization is extensively tested in `ttree_setbranchaddress.py`. Possible closes #15799. | 10 June 2024, 19:26:42 UTC |
| 6952dd5 | Sergey Linev | 10 June 2024, 07:19:47 UTC | [http] Allow to use any of openssl 3.x with civetweb civetweb was designed when only openssl 3.0 was existing. Therefore name of define is `OPENSSL_API_3_0` Meanwhile there is openssl 3.1 and 3.2. While seems to be there is no changes in API both can be used with civetweb. | 10 June 2024, 19:06:57 UTC |
| cde1073 | Vincenzo Eduardo Padulano | 03 June 2024, 10:31:12 UTC | [df] Improve syntax for column definition in df001 The tutorial uses a C++ lambda with increment of a shared local variable between two different nodes of the computation graph, without explaining it. This is a somewhat advanced usage of the API for an introductory tutorial and is also in a seemingly irrelevant part of the tutorial (used just for creating the toy data). RDataFrame already provides the `rdfentry_` magic column which does effectively the same, providing a sequentially increasing number. Also, it was already used in the Python tutorial so this commit is just aligning the two language versions. | 10 June 2024, 13:58:38 UTC |
| fe5c02d | Vincenzo Eduardo Padulano | 07 June 2024, 09:52:04 UTC | [PyROOT] Update patch with code changes | 10 June 2024, 13:15:11 UTC |
| 58e39a8 | Vincenzo Eduardo Padulano | 06 June 2024, 17:38:54 UTC | [PyROOT] Add regression test for #15703 | 10 June 2024, 13:15:11 UTC |
| 3d20650 | Vincenzo Eduardo Padulano | 06 June 2024, 17:37:22 UTC | [PyROOT] Destroy STL string objects in StringExecutor ::operator delete only frees the memory that was previously allocated in Cppyy::CallO, but does not call the destructor of the std::string. Make sure that is done using keyword delete. | 10 June 2024, 13:15:11 UTC |
| 78298a1 | Olivier Couet | 10 June 2024, 12:47:53 UTC | Update THStack documentation (#15766) * Update THStack documentation * Only issue a warning in case of negative histogram in a stack * Change the method name in the Warning call. | 10 June 2024, 12:47:53 UTC |
| 5cb7717 | Mattias Ellert | 08 June 2024, 15:08:48 UTC | [pyroot] Add __firstlineno__ and __static_attributes__ to blacklist For compatibility with Python 3.13 See: https://docs.python.org/3.13/whatsnew/3.13.html From the above page: * Classes have a new __firstlineno__ attribute, populated by the compiler, with the line number of the first line of the class definition. (Contributed by Serhiy Storchaka in gh-118465.) * Classes have a new __static_attributes__ attribute, populated by the compiler, with a tuple of names of attributes of this class which are accessed through self.X from any function in its body. (Contributed by Irit Katriel in gh-115775.) Without adding the new attributes to the blacklist there are errors: AttributeError: 'int' object attribute 'doc' is read-only from the __firstlineno__ attribute. AttributeError: 'tuple' object attribute 'doc' is read-only from the __static_attributes__ attribute. | 10 June 2024, 12:07:29 UTC |
| b293a9a | Florine de Geus | 06 June 2024, 13:00:05 UTC | [ntuple] Clarify `RColumnRange::kFirstElementIndex` doc | 10 June 2024, 11:16:26 UTC |
| 1f950bb | silverweed | 10 June 2024, 09:43:53 UTC | [skip-ci] clang-format ntuple_storage.cxx | 10 June 2024, 09:51:14 UTC |
| 916716b | Bertrand Bellenot | 07 June 2024, 12:09:28 UTC | Use default constructor instead of c style cast | 10 June 2024, 07:29:47 UTC |
| 711e426 | Bertrand Bellenot | 07 June 2024, 09:42:53 UTC | [windows] Fix compilation error with VS 2019 Fix the following error with Visual Studio 2019: error C2440: 'initializing': cannot convert from 'int' to 'std::byte' | 10 June 2024, 07:29:47 UTC |
| a4b4841 | silverweed | 06 June 2024, 12:19:57 UTC | [ntuple] add MaxKeySize to the RNTuple anchor doc | 10 June 2024, 07:02:07 UTC |
| 683c749 | silverweed | 06 May 2024, 16:05:41 UTC | [ntuple] add fMaxKeySize field to RNTuple Bump RNTuple class version to 6 | 10 June 2024, 07:02:07 UTC |
| 9cf390b | Danilo Piparo | 09 June 2024, 04:56:22 UTC | [ci] Display time per group when running GitHub actions. This is done in order to monitor how much time each individual step of the workflows is taking. | 09 June 2024, 12:31:25 UTC |
| c1b713c | Danilo Piparo | 09 June 2024, 04:24:01 UTC | [ci] Correctly parse Debian version to avoid malformed names in the string passed to CPack for the creation of the binary archive. | 09 June 2024, 04:44:19 UTC |
