Skip to main content

Browse the archive

https://github.com/angular/angular
01 September 2024, 02:13:37 UTC
sort by:
Revision Author Date Message Commit Date
a72ff8b Andrew Kushnir 20 July 2022, 17:30:38 UTC release: cut the v14.0.7 release 20 July 2022, 17:37:05 UTC
3c43d42 Doug Parker 20 July 2022, 01:03:33 UTC refactor(bazel): remove `experimental_extended_template_diagnostics` flag (#46898) Extended diagnostics are enabled by default now and this flag doesn't do anything anymore but I missed it in a previous cleanup. PR Close #46898 20 July 2022, 15:50:44 UTC
6aad6e4 dario-piotrowicz 23 May 2022, 21:48:02 UTC refactor(compiler-cli): improve error for non-exported non-standalone (#46114) improve the error message for non-standalone components which are not exported from their module, and that are also imported directly as if they were standalone this change simply adds the suggestion to the developer to import the ngModule instead resolves #46004 PR Close #46114 20 July 2022, 15:50:01 UTC
a13d752 Angular Robot 20 July 2022, 08:40:15 UTC build: update cross-repo angular dependencies to cdaaa15 (#46853) See associated pull request for more information. PR Close #46853 20 July 2022, 15:48:44 UTC
3e3f4fe Bob Watson 12 July 2022, 17:24:46 UTC docs: add info about request timeouts (#46882) * Adds a short note about how service workers report request timeouts * Updated heading levels to present a clearer hierarchy and cleaner local TOC * Removed documentation lint errors * Moves the service worker service timeout paragraph to a more logical topic in service-worker-devops * Removes line error from the more logical topic. * address feedback from PR review comments fixes #46445 PR Close #46882 20 July 2022, 15:47:59 UTC
d361eaa Paul Gschwendtner 19 July 2022, 11:18:28 UTC test: convert `source-map` core tests to use `async/await` instead of `fakeAsync` (#46888) The source map tests rely on asynchronous logic from the `source-map` package. The tests itself are written using `fakeAsync` but this unnecessarily complicates the interaction with the asynchronous source-map helpers/package. To fix this, we just make the tests use async/await as we don't intend to test fakeAsync in this `describe` block.. PR Close #46888 19 July 2022, 16:40:56 UTC
1545a86 Paul Gschwendtner 19 July 2022, 09:52:03 UTC build: disable jasminewd2 types for sourcemap playground test (#46888) The sourcemap test in the e2e playground is now using async/await code. This results in errors now with the Bazel TS compilation because it detects that `expect` is returning a promise and should be awaited. This happens due to the jasminewd2 types. We should just use the actual jasmine types and not rely on the deprecated selenium control flow, using explicit async/await in the whole test. This also solves the issue with the source-map types being async/await now. PR Close #46888 19 July 2022, 16:40:56 UTC
cc86c30 Paul Gschwendtner 19 July 2022, 08:20:11 UTC test: update source-map tests to account for `source-map` breaking change (#46888) The source-map package now requires the `SourceMapConsumer`/`SourceMapGenerator` classes to be instantiated asynchronously. This commit updates our tests to account for that. PR Close #46888 19 July 2022, 16:40:55 UTC
1264f02 Paul Gschwendtner 19 July 2022, 08:12:10 UTC build: remove `source-map` package from `compiler-cli` bundling external list (#46888) The source-map package is no longer explicitly used in the `compiler-cli` package and therefore can be removed from the ESBuild bundling, denoting it as external. This should be a noop. PR Close #46888 19 July 2022, 16:40:55 UTC
e82389a Paul Gschwendtner 19 July 2022, 08:10:45 UTC build: update source-map package to latest version (#46888) The source-map package is updated as part #46707, but the minor version bump introduced breaking changes. This commit extracts the update so that we can handle it separately accounting for the breaking changes. Also removing the caret since this package apparently makes breaking changes in minor segment bumps. PR Close #46888 19 July 2022, 16:40:55 UTC
f42e5db Angular Robot 19 July 2022, 05:46:41 UTC build: update github/codeql-action action to v2.1.16 (#46885) See associated pull request for more information. PR Close #46885 19 July 2022, 16:05:05 UTC
6d9d9f4 Angular Robot 19 July 2022, 05:46:37 UTC build: update eslint dependencies to v5.30.7 (#46884) See associated pull request for more information. PR Close #46884 19 July 2022, 16:04:37 UTC
7a2b4c1 Angular Robot 19 July 2022, 05:45:31 UTC build: update babel dependencies to v7.18.9 (#46883) See associated pull request for more information. PR Close #46883 19 July 2022, 16:04:09 UTC
91b3ad1 Andrew Scott 18 July 2022, 20:23:50 UTC refactor(router): Update TitleStrategy to useFactory (#46876) The implementation of the `DefaultTitleStrategy` was modeled after the existing strategy patterns in the Router. These patterns were developed before the `providedIn` syntax for injectables. We can simplify the model a lot by providing the default in the factory of the abstract class. Note that the other strategy patterns aren't touched in this PR due to how long they've existed. Because they have been there for such a long time, it's possible there will need to be some adjustments to code if/when they are refactored to do the same. PR Close #46876 18 July 2022, 22:02:18 UTC
5bdbb62 dario-piotrowicz 17 July 2022, 14:38:44 UTC fix(animations): make sure falsy values are added to _globalTimelineStyles (#46863) style values get added to the `_globalTimelineStyles` map in order to keep them so that they can be used across different timelines `_globalTimelineStyles` was previously a plain object but has been refactored to a map in #44482, as part of the update a check has been changed from a ternary operation to an or (||), causing falsy values (as 0) not to be added to the map anymore, apply the nullish coalescing operator (??) instead to make sure only `undefined` and `null` are filtered out also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves #46833 PR Close #46863 18 July 2022, 21:46:13 UTC
76badad Paul Gschwendtner 14 July 2022, 20:49:00 UTC test: update tests to not run jasmine `done` function in sync-test zone from `describe` block There are some ZoneJS tests that fork the zone from the `describe` block for testing the zone patching. This does cause the Jasmine `done` function later in `it` specs to be invoked in the sync-test zone from the original `describe` block. The `done` implementation now has changed with the Karma Jasmine update and breaks because it now causes tasks to be scheduled. It is conceptually incorrect/invalid to take the describe sync zone and run test logic with that sync zone. ``` An error was thrown in afterAll error properties: Object({ originalStack: 'Error: Cannot call jasmine.execute().forceTask from within a sync test (syncTestZone for jasmine.describe#FileReader). at new ZoneAwareError (packages/zone.js/test/browser_test_rollup.umd.js:98:37) at e.onScheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:158:196) at e.scheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:7529) at t.scheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:3539) at t.scheduleMicroTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:3791) at r.execute (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:166:4312) at queueRunnerFa ... at <Jasmine> ``` 18 July 2022, 17:20:38 UTC
08f31a5 Paul Gschwendtner 14 July 2022, 20:38:01 UTC feat(zone.js): include jasmine `describe` block name when raising unexpected task error As mentioned in the previous commit that ensured that the Zone name is included in errors raised by the `SyncTestZoneSpec`, we can now include the Jasmine describe block descriptions in such errors. Errors can often happen when users accidentally try to set up Angular tests without an `it` block. Resulting in errors where it's not clear at all which describe block (of potentially a large repository) is involved: ``` An error was thrown in afterAll error properties: Object({ originalStack: 'Error: Cannot call XX from within a sync test. at new ZoneAwareError (packages/zone.js/test/browser_test_rollup.umd.js:98:37) at e.onScheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:158:196) at e.scheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:7529) at t.scheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:3539) at t.scheduleMicroTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:3791) at r.execute (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:166:4372) at queueRunnerFa ... at <Jasmine> ``` We now include the describe block description in the error, so that it is easier to figure out the location of the culprit code. 18 July 2022, 17:20:38 UTC
bd61dc3 Paul Gschwendtner 14 July 2022, 20:34:21 UTC feat(zone.js): include zone name when sync-test zone reports tasks The sync-test zone is used in e.g. `describe` to raise an error when there is asynchronous code scheduled in describe blocks. This commit includes the zone name in such thrown errors to allow for us to include the jasmine describe name in the error. This will be wired up in the jasmine zonejs patches separately. 18 July 2022, 17:20:20 UTC
b6ca56a Paul Gschwendtner 02 July 2022, 08:31:23 UTC test: fix `fake-async-test` spec to properly test prefixed animation frame functions In the fake async test for `zone.js` there is some logic to test various prefixes of the request animation frame functions. This logic does not have any effect currently, except for generating the same test at maximum three times. This commit fixes the test to actually test what it meant to do initially. 18 July 2022, 17:20:20 UTC
fa308a6 Paul Gschwendtner 01 July 2022, 20:28:43 UTC test: update tests to account for `karma-jasmine` v5.0.0 Karma jasmine updated the `jasmine-core` dependency. Jasmine is now more strict when: * The done callback is invoked multiple times * The done callback is used, while a promise is also returned * The done callback is treated as error when e.g. a number is returned as first argument. This was the case with `requestAnimationFrame`. 18 July 2022, 17:20:20 UTC
4e77c7f Paul Gschwendtner 01 July 2022, 13:41:09 UTC fix(core): do not invoke jasmine `done` callback multiple times with `waitForAsync` Currently tests written using `waitForAsync` would be prone to Jasmine warnings or errors (depending on the version) for tests incorrectly invoking asynchronous jasmine `done` callbacks multiple times. This can happen because the async test zone logic schedules the `done` callback to be called using `setTimeout`, but this could be invoked multiple times, causing multiple `done` invocations to be scheduled. Most of the issues have been resolved with #45025, but it does not solve the case of multiple tasks finished and callbacks being scheduled. Technically, the current logic is built in way that _should_ result in `_finishCallbackIfDone` and eventually the `done` callback to be invoked at maximium once. This is unfortunately not the case in some rather advanced/unexpected scenarios (like our AngularJS upgrade tests) where the scenario is the following (and microtasks from before the actual `waitForAsync` spec are still completing -- which is valid): ``` 1. A test `beforeEach` schedules a microtask in the ProxyZone. 2. An actual empty `it` spec executes in the AsyncTestZone` (using e.g. `waitForAsync`). 3. The `onInvoke` invokes `_finishCallbackIfDone` because the spec runs synchronously. 4. We wait the scheduled timeout (see below) to account for unhandled promises. 5. The microtask from (1) finishes and `onHasTask` is invoked. --> We register a second `_finishCallbackIfDone` even though we have scheduled a timeout. --> we execute the `done` callback twice because the async zone spec state is "stable" ``` 18 July 2022, 17:20:20 UTC
7ea0c2a Angular Robot 29 June 2022, 17:49:08 UTC build: update dependency karma-jasmine to v5 | datasource | package | from | to | | ---------- | ------------- | ----- | ----- | | npm | karma-jasmine | 4.0.2 | 5.1.0 | 18 July 2022, 17:20:20 UTC
f1ca4ab George Kalpakas 18 July 2022, 16:01:06 UTC build(docs-infra): upgrade cli command docs sources to a6747c168 (#46870) Updating [angular#14.0.x](https://github.com/angular/angular/tree/14.0.x) from [cli-builds#14.1.x](https://github.com/angular/cli-builds/tree/14.1.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/2cb508ffa...a6747c168): **Modified** - help/completion.json - help/update.json PR Close #46870 18 July 2022, 17:06:50 UTC
c5c3cbc piyush132000 17 July 2022, 08:52:59 UTC docs: fix code style (#46862) PR Close #46862 18 July 2022, 16:44:21 UTC
031deb3 Cédric Exbrayat 15 July 2022, 07:08:24 UTC refactor(forms): simplify group builder function (#46844) Applies the same logic that we have in the `control` function. PR Close #46844 15 July 2022, 22:02:20 UTC
e76f9a1 Jessica Janiuk 15 July 2022, 18:24:58 UTC Revert "Revert "build: update cross-repo angular dependencies to 84dd092 (#46848)" (#46849)" (#46852) This reverts commit b2a74469de7b29f8700b1673fd5302c30fc99afc. PR Close #46852 15 July 2022, 21:41:59 UTC
97bff3c Jessica Janiuk 15 July 2022, 16:50:32 UTC Revert "build: update cross-repo angular dependencies to 84dd092 (#46848)" (#46849) This reverts commit 510f45957a4fa43fbdec10f62451ae4c4aa6fa23. PR Close #46849 15 July 2022, 17:52:46 UTC
e6bcdb9 Angular Robot 15 July 2022, 12:47:31 UTC build: update cross-repo angular dependencies to 84dd092 (#46848) See associated pull request for more information. PR Close #46848 15 July 2022, 16:00:33 UTC
d468402 jnizet 15 July 2022, 07:15:46 UTC docs(core): document that destroyAfterEach is true by default (#46845) PR Close #46845 15 July 2022, 15:50:36 UTC
98467fd Jessica Janiuk 14 July 2022, 22:26:26 UTC build: Add Jessica and Andrew K to docs-infra (#46843) This adds two people to the docs-infra pullapprove group. PR Close #46843 15 July 2022, 15:46:06 UTC
71062e1 Angular Robot 14 July 2022, 22:04:39 UTC build: update cross-repo angular dependencies (#46834) See associated pull request for more information. PR Close #46834 14 July 2022, 22:35:08 UTC
f8a25f7 Angular Robot 13 July 2022, 16:45:50 UTC build: lock file maintenance (#46691) (#46840) See associated pull request for more information. PR Close #46691 PR Close #46840 14 July 2022, 15:55:02 UTC
5579d96 Paul Gschwendtner 13 July 2022, 14:28:55 UTC refactor(docs-infra): update boilerplate to have proper `angular.js` types (#46840) With the recent lock file maintenance, the `@types/angular` dependency ended up being duplicated. This seems to happen because we locked our type dependency, but other Angular deps like `angular-route` had a looser dependency, resulting in e.g. `1.7` types and `1.8` types to be loaded. This ultimately ended up breaking TypeScript's auto-discovering of types and broke some example compilations e.g. ``` app/app.animations.ts(3,3): error TS2339: Property 'animation' does not exist on type 'IModule'. app/app.config.ts(5,45): error TS2694: Namespace 'angular' has no exported member 'route'. app/phone-detail/phone-detail.component.ajs.ts(10,37): error TS2694: Namespace 'angular' has no exported member 'route'. ``` We fix this by loosening the type dependency ranges, updating all of these. Also we update AngularJS itself to the final version. PR Close #46840 14 July 2022, 15:55:01 UTC
3a61ff6 Paul Gschwendtner 13 July 2022, 14:02:56 UTC test: update aio size golden to reflect reduction due to lock file maintenance (#46840) The AIO payload size has been reduced with lock file maintenance which resulted in updates of Angular framework and Angular devkit/CLI. The same reduction is already visible in the `aio-local` job because it was already using the latest FW packages (obviously -- given it being from HEAD). PR Close #46840 14 July 2022, 15:55:01 UTC
f344cbb Angular Robot 13 July 2022, 12:06:08 UTC build: lock file maintenance (#46840) See associated pull request for more information. PR Close #46840 14 July 2022, 15:55:01 UTC
676bf04 Bob Watson 13 July 2022, 22:24:35 UTC docs: correct debugging task step (#46832) Also remove lint errors. Fix: #42781 PR Close #46832 13 July 2022, 22:55:20 UTC
481dc8d Andrew Kushnir 13 July 2022, 19:31:37 UTC refactor(core): improve an error message when `ENVIRONMENT_INITIALIZER` is not a multi provider (#46829) Currently if the `ENVIRONMENT_INITIALIZER` token is not configured with `multi: true` flag, the code fails while trying to iterate over the value. This commit checks whether the `ENVIRONMENT_INITIALIZER` token value type is an array and throws a helpful error message. PR Close #46829 13 July 2022, 22:01:14 UTC
8e2fc3e George Kalpakas 13 July 2022, 14:37:45 UTC docs: redirect `/guide/ivy` to the v12 guide (#46820) Since Ivy is the default since v13, the Ivy guide (that used to live at https://angular.io/guide/ivy) has been removed (see #43860). However, there are certain error messages emitted by the CLI that still point to it. This commit address the problem by adding a redirect from https://angular.io/guide/ivy to https://v12.angular.io/guide/ivy (which is the last version that includes the guide). Fixes #46717 PR Close #46820 13 July 2022, 21:59:18 UTC
41253f9 Kristiyan Kostadinov 13 July 2022, 18:19:40 UTC fix(compiler): inputs/outputs incorrectly parsed in jit mode (#46813) The `Directive` and `Component` decorators support `inputs` and `outputs` fields which accept an array in the format of `"someInput"` or `"someInput: someAlias"`, however the parsing during JIT compilation was splitting on commas, not on colons, which resulted in incorrect parsing. E.g. `inputs: ["someInput: someAlias"]` was being parsed into `{"someInput: someAlias": "someInput: someAlias"}` instead of `{someInput: "someAlias"}`. The feature was working by accident, because there's some logic further down in the compiler pipeline that was splitting the strings again. PR Close #46813 13 July 2022, 21:26:50 UTC
89edfe7 acvi 13 July 2022, 06:55:10 UTC docs: describe smallest typo, "an" -> "a" (#46812) PR Close #46812 13 July 2022, 20:06:30 UTC
79aa8be Jessica Janiuk 13 July 2022, 19:06:25 UTC release: cut the v14.0.6 release (#46827) 13 July 2022, 19:06:25 UTC
dff82f2 Angular Robot 13 July 2022, 15:08:44 UTC build: update cross-repo angular dependencies to 294d737 (#46821) See associated pull request for more information. PR Close #46821 13 July 2022, 16:31:05 UTC
fd15744 Bob Watson 12 July 2022, 23:42:57 UTC docs: add warning about lack of testing used by TOH (#46811) Adds a short note about how the .spec.ts testing files aren't used or modified in this tutorial. Fixes #37652 PR Close #46811 13 July 2022, 00:03:49 UTC
101ada9 Angular Robot 12 July 2022, 19:33:25 UTC build: update cross-repo angular dependencies to e8da4c0 (#46809) See associated pull request for more information. PR Close #46809 12 July 2022, 23:53:52 UTC
862dd03 dario-piotrowicz 01 July 2022, 14:23:57 UTC refactor(animations): refactor non-animatable check to be timeline based (#46666) move the check for non-animatable properties from the animation building phase to the application of the animation's transition instead, in such a way we can check it against the keyframes of the transition's timeline in order to only provide warnings for properties which are being animated, thus not providing any warning for non-animatable properties being applied to elements via the style function this change has the benfit just mentioned above but it comes with two drawbacks: - the warning handling is not done in the building time so it is a bit inconsistent with other type of validations (such as the unsupported css properties one for example) - before the warning was being applied only when the animation's data was being parsed, so it happed only once but now since it is applied when the animation is actually being prepared to be played, it happens each time the animation runs resolves #46602 PR Close #46666 12 July 2022, 22:36:22 UTC
99697da JoostK 12 July 2022, 18:36:13 UTC fix(compiler-cli): only consider used pipes for inline type-check requirement (#46807) After a bugfix in #46096, the compiler is now better capable of detecting pipes which require an inline type constructor. However, there is an issue in how all pipes are considered when verifying the inline type-ctor requirement: it should only check actually used pipes. Fixes #46747 PR Close #46807 12 July 2022, 21:09:18 UTC
4a2c6e3 Paul Gschwendtner 06 July 2022, 09:05:21 UTC test: update payload size goldens for AIO after analytics change (#46801) Most of the increase comes from code being moved from `index.html` to the main bundle. A small increase comes from the additional `gtag.js` loading logic, but other than that the size is effectively increased due to the untracked code from `index.html` being moved into the `main.js` bundle. PR Close #46801 12 July 2022, 19:43:18 UTC
26ab368 Paul Gschwendtner 11 July 2022, 16:27:55 UTC refactor(docs-infra): enable ip anonymization for legacy universal analytics (#46801) In GA4 ip anonymization is enabled by default, but in universal analytics with `analytics.js`, this needs to be explicitly enabled. PR Close #46801 12 July 2022, 19:43:18 UTC
f2a1ea3 Paul Gschwendtner 06 July 2022, 11:01:37 UTC refactor: move error reporting for analytics to service (#46801) This is acceptable because `gtag.js` is also only loaded as part of the service, similary `ga` is only registered in the service (so the reporting was a noop if errors are thrown before -- no change here) We can benefit from downleveling etc. and do not need to be careful with the inline script in the `index.html` PR Close #46801 12 July 2022, 19:43:18 UTC
a786cf6 Paul Gschwendtner 05 July 2022, 17:57:00 UTC feat(docs-infra): set up Google Analytics 4 along with keeping legacy Universal Analytics (#46801) We currently use Universal Analytics. This is deprecated in favor of Google Analytics 4 and UA will stop processing hits in October 2023. This change intends to prepare us for this migration, and to already pre-populate our GA4 property (there is no way to migrate existing data /properties into a GA4 property -- a new one needs to be created). This will help us minimize the data gap so that we can: * Continue to look at the UA property with the full time span until October 2023 * Can start using the GA4 property long-term in the future, starting with data even before Universal Analytics stops processing new data. We need to keep the existing `analytics.js` setup. Initially we have considered using `gtag.js` for both the UA and GA4 properties, as it supports that, but that doesn't work with our strict trusted types enforcement because it results in multiple `gtag.js` scripts (specific versions for UA or GA4) that recreate the same trusted type policies. This causes runtime errors and breaks the setup. Instead, with continued use of `analytics.js` we have the benefit of a good separation of trusted types + events and configuration. There is some problematic with translation of Universal Analytics Events to GA4, or the other way around (even though we don't use custom events currenlty) We also do not need to send page views for our GA4 property because GA4 with gtag supports this automatically (respecting the history state -- using the `Enhanced measurement events` setting in the UI). For our UA legacy instance we continue to dispatch events manually. This logic can be removed in the future. More details can be found here: https://docs.google.com/document/d/1aK8u4ZlXbqQ2wMqmgSX7Ces8iLgamC13oCoG6VeBruA/edit?usp=sharing&resourcekey=0-EVe-Rhnme3bj_pkz2RcOmw. PR Close #46801 12 July 2022, 19:43:18 UTC
b5e411a Bob Watson 12 July 2022, 18:02:29 UTC docs: clarify how ng adds classes to form elements (#46805) * Clarify text described in #46424 * Remove lint errors * Fix #46424 PR Close #46805 12 July 2022, 19:09:04 UTC
349043d Paul Gschwendtner 12 July 2022, 13:32:34 UTC build: replace size-tracking test with rule from shared dev-infra (#46802) The JS size-tracking logic has been moved into the dev-infra repository and the rule has been updated to work better with Bazel labels. The Starlark target is updated accordingly in this commit. PR Close #46802 12 July 2022, 19:06:30 UTC
2985191 Ivaylo Kirov 12 July 2022, 13:56:09 UTC docs: Add missing period (#46799) This adds a missing period in one documentation sentence. PR Close #46799 12 July 2022, 19:04:28 UTC
4f469cb Uday Sony 29 June 2022, 10:13:47 UTC fix(forms): expose ControlConfig in public API (#46594) This commit exposes the ControlConfig as a public API, so that the symbol can be used in applications. PR Close #46594 12 July 2022, 17:45:38 UTC
785b098 Angular Robot 12 July 2022, 14:35:16 UTC build: update cross-repo angular dependencies to 6af9f6c (#46791) See associated pull request for more information. PR Close #46791 12 July 2022, 16:10:35 UTC
dfeb8d5 Lukas Matta 12 July 2022, 14:35:46 UTC docs: add missing space (#46800) PR Close #46800 12 July 2022, 15:56:10 UTC
59ae481 Paul Gschwendtner 12 July 2022, 12:37:07 UTC build: remove unused `inline-package-json-deps.js` script (#46798) This script was used back when dev-infra code was part of the Angular framework repository. The script is now unused and can be deleted. PR Close #46798 12 July 2022, 15:54:52 UTC
faba023 Paul Gschwendtner 12 July 2022, 12:35:30 UTC build: move jasmine seed generation logic to karma config (#46798) The jasmine seed generator is only used in a single karma configuration file. Used by the legacy build and the Saucelabs/ZoneJS Karma jobs. We should move the separate script code directly into the config to make it clear that the seed generation is not used elsewhere, and to simplify the Starlark code. PR Close #46798 12 July 2022, 15:54:52 UTC
4355b82 Angular Robot 12 July 2022, 05:20:25 UTC build: update eslint dependencies to v5.30.6 (#46794) See associated pull request for more information. PR Close #46794 12 July 2022, 15:54:12 UTC
98b41bf Nicolas Molina Monroy 01 July 2022, 16:10:40 UTC docs: add nicobytes to GDE resources and Platzi to Online Training (#46668) PR Close #46668 11 July 2022, 23:29:30 UTC
023c218 Bob Watson 08 July 2022, 01:42:05 UTC docs: update topics to include feedback from PR review (#46647) Fix #44662 PR Close #46647 11 July 2022, 22:32:36 UTC
8a0a7c4 Bob Watson 29 June 2022, 23:38:16 UTC docs: update references to HeroListComponent (#46647) Remove or reframe references to the obsolete HeroListComponent component that was taken from an old version of the Tour of Heroes tutorial. Incorporates review feedback. Fix #44662 PR Close #46647 11 July 2022, 22:32:35 UTC
9d2d92a Bob Watson 08 June 2022, 19:26:25 UTC docs: Remove content lint errors from tutorial topics (#46652) Contains revisions to the Tour of Heroes tutorial that remove the text and formatting errors identified by the content lint tool. PR Close #46652 11 July 2022, 21:44:58 UTC
963ef3d Angular Robot 11 July 2022, 20:03:45 UTC build: update dependency firebase-tools to v11 (#46779) See associated pull request for more information. PR Close #46779 11 July 2022, 21:42:08 UTC
9fc45a6 Paul Gschwendtner 11 July 2022, 19:04:08 UTC build: account for integration test rule change (#46778) The integration test rule now always executes tests in a directory outside of the execroot. This ensures a more hermetic test environment on platforms without a sandbox, or when tests are run with `tags: local`. As part of this change, an issue with Yarn 1.x. and `nodejs_binary` unveiled. Yarn 1.x. is resolved properly using the tool mapping but when Yarn inside Yarn is invoked (e.g. using `package.json` scripts), then the second nested Yarn invocation fails due to an unknown path. This happens because Yarn in the original invocation creates another directory in the `/tmp` directory and modifies the `PATH` so that the same `yarn` can be invoked again. This makes sense conceptually but breaks in our case because the Yarn Bash script put into the `/tmp` directory tries to resolve our vendored Yarn script relatively (which is the wrong spot here). It worked previously in the execroot because `nodejs_binary` invoked Yarn through `<external>/../node.sh <absolute-path-to-yarn-cjs-script>`, but outside the execroot it invoked Yarn using a relative path (which then ended up being preserved in the Yarn temporary directory). We can fix this by updating the Bazel NodeJS repository which seems to have coincidentally have a fix for the path resolution. See: https://github.com/bazelbuild/rules_nodejs/pull/3493#event-6870301735. PR Close #46778 11 July 2022, 20:55:31 UTC
91ab53e Angular Robot 11 July 2022, 17:41:51 UTC build: update cross-repo angular dependencies to 218be21 (#46778) See associated pull request for more information. PR Close #46778 11 July 2022, 20:55:31 UTC
d51e0f2 markostanimirovic 03 July 2022, 13:06:12 UTC docs(core): add full example of directive with typed context (#46689) This commit adds a complete example of a structural directive with strongly typed context. PR Close #46689 11 July 2022, 20:01:07 UTC
ec1ff66 Jessica Janiuk 11 July 2022, 19:04:53 UTC Revert "build: update dependency firebase-tools to v11" (#46777) This reverts commit 179523003d5b2e65041db25545da755d0b57e5e4. PR Close #46777 11 July 2022, 19:27:03 UTC
61c7e26 Jessica Janiuk 11 July 2022, 18:52:03 UTC Revert "refactor(router): Remove use of OutletInjector" (#46775) This reverts commit e288d87742e2c08ef798e9011fc9b11b6672d6cb. PR Close #46775 11 July 2022, 19:13:21 UTC
96eeb6b SoulsMark 10 July 2022, 12:21:35 UTC docs: link fix from google.developers to web.dev (#46768) PR Close #46768 11 July 2022, 18:15:00 UTC
22872e9 Angular Robot 29 June 2022, 18:07:49 UTC build: update dependency mocha to v10 (#46619) | datasource | package | from | to | | ---------- | ------- | ----- | ------ | | npm | mocha | 9.2.2 | 10.0.0 | PR Close #46619 11 July 2022, 18:13:37 UTC
268ea58 Angular Robot 06 July 2022, 23:03:48 UTC build: update dependency firebase-tools to v11 (#46614) See associated pull request for more information. PR Close #46614 11 July 2022, 18:12:43 UTC
9749199 Marcin Wosinek 29 June 2022, 16:09:40 UTC build(docs-infra): update versions of some docs examples dependencies (#46609) Update angular-in-memory-web-api and jasmine-marbles (used in doc examples) to latest versions. PR Close #46609 11 July 2022, 17:34:26 UTC
410b5e4 Angular Robot 09 July 2022, 19:37:39 UTC build: update dependency jasmine to v4 (#46617) | datasource | package | from | to | | ---------- | -------------- | ------ | ----- | | npm | jasmine | 3.10.0 | 4.2.1 | | npm | @types/jasmine | 3.5.14 | 4.0.3 | | npm | jasmine | 3.6.1 | 4.2.1 | PR Close #46617 11 July 2022, 17:33:55 UTC
40fbef2 Joshua VanAllen 08 July 2022, 20:16:44 UTC build: Fix Angular CLI issue template link (#46756) This fixes the issue template link to the Angular CLI repository instead of staying in the Angular repository. PR Close #46756 11 July 2022, 17:33:28 UTC
6c3f40e Angular Robot 10 July 2022, 23:03:43 UTC build: update bazel setup to v5.5.2 (#46770) See associated pull request for more information. PR Close #46770 11 July 2022, 17:32:50 UTC
ec267b4 Jessica Janiuk 08 July 2022, 22:51:59 UTC Revert "build: update router symbol golden file" (#46760) This reverts commit bb9ec76c7d1e86d9368da16aea6ad8f559c53c69. PR Close #46760 08 July 2022, 23:12:34 UTC
0549e4d Jessica Janiuk 08 July 2022, 22:07:52 UTC Revert "refactor(router): Simplify the prioritizeGuardValue logic" (#46759) This reverts commit f32fface4763d789a8b7cc4f4489f98be4e1073a. PR Close #46759 08 July 2022, 22:27:01 UTC
28bd6dd Angular Robot 05 July 2022, 05:08:19 UTC build: update eslint dependencies to v5.30.5 (#46705) | datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 5.30.0 | 5.30.5 | | npm | @typescript-eslint/parser | 5.30.0 | 5.30.5 | PR Close #46705 08 July 2022, 22:00:00 UTC
770f054 Andrew Scott 08 July 2022, 19:25:14 UTC refactor(router): Remove use of OutletInjector (#46755) OutletInjector doesn't do anything special. Injector.create can be used instead PR Close #46755 08 July 2022, 21:56:01 UTC
50126af Andrew Scott 08 July 2022, 20:54:33 UTC build: update router symbol golden file (#46757) File got out of date when merging a patch & main branch change PR Close #46757 08 July 2022, 21:14:57 UTC
b1b4891 Andrew Scott 08 July 2022, 04:28:59 UTC refactor(router): Simplify the prioritizeGuardValue logic (#46745) The existing logic does something similar but in a more roundabout way. It reads _the whole array_. If it encounters a pending value, it ignores the remaining ones. If it hasn't encountered a pending value by the time it hits false/UrlTree, it returns that result. The new logic is the same, but reverses what we're looking for. Instead of processing the whole array, we stop when we encounter an initial value. When we encounter one that isn't `true`, that gets returned. If we get to the end and everything was `true`, return `true`. PR Close #46745 08 July 2022, 20:03:47 UTC
b920d43 Angular Robot 08 July 2022, 18:03:52 UTC build: update dependency @octokit/graphql to v5 (#46753) See associated pull request for more information. PR Close #46753 08 July 2022, 19:59:36 UTC
8dabe80 Angular Robot 08 July 2022, 16:04:47 UTC build: update cross-repo angular dependencies to db87550 (#46736) See associated pull request for more information. PR Close #46736 08 July 2022, 19:59:12 UTC
8683e16 Angular Robot 08 July 2022, 09:37:36 UTC build: update babel dependencies (#46708) See associated pull request for more information. PR Close #46708 08 July 2022, 19:58:37 UTC
dfb6246 zhysky 08 July 2022, 16:28:03 UTC docs: fix packages\docs\di\di.md (#46704) ‘Provider11’ is unreasonable, according to the context, it should be ‘Provider1’ PR Close #46704 08 July 2022, 17:53:39 UTC
8ade3b7 Paul Gschwendtner 07 July 2022, 20:41:23 UTC fixup! ci: use actual main branch for components repo unit test job (#46743) Remove todo PR Close #46743 08 July 2022, 16:19:57 UTC
acdec44 Paul Gschwendtner 07 July 2022, 20:33:35 UTC ci: use actual `main` branch for components repo unit test job (#46743) For the branch rename migration we temporarily had to work from a forked-off branch. Now that all the migration and cleanup Is complete, we can switch to the actual new main branch. This is the last remaining cleanup in the organization as it seems. PR Close #46743 08 July 2022, 16:19:57 UTC
72d1aff dario-piotrowicz 07 July 2022, 15:32:50 UTC docs(animations): add section about animations and view encapsulation (#46738) Add a section regarding component view encapsulations in the complex animation sequences guide to let developers know how animations work in regard to view encapsulations. This section is used to both add information to the guide but also to take a stand on how the animations should behave in regard to the shadow dom view encapsulation. This relates to PR #46488 which by trying to make sure the query function works with shadow dom elements proved that having the animations implementation work with shadow dom would increase the complexity of the code and would have a negative impact on performance, such facts alongide the small adoption of shadow dom by users influenced the decision to keep the current functionalities and simply discourage the use of animations and shadow dom components. PR Close #46738 07 July 2022, 20:52:33 UTC
68b46e0 dario-piotrowicz 07 July 2022, 15:55:25 UTC Revert "fix(animations): enable shadowElements to leave when their parent does (#46459)" (#46739) This reverts commit b41737038377af480763226a904b67e7d8e283ae. The change applied is no longer appropriate since the use of animations and shadow dom components is discouraged (as of #46738) PR Close #46739 07 July 2022, 20:51:30 UTC
b1500ab George Kalpakas 07 July 2022, 16:53:03 UTC build(docs-infra): upgrade cli command docs sources to 2cb508ffa (#46741) Updating [angular#14.0.x](https://github.com/angular/angular/tree/14.0.x) from [cli-builds#14.0.x](https://github.com/angular/cli-builds/tree/14.0.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/847de3e7b...2cb508ffa): **Modified** - help/update.json PR Close #46741 07 July 2022, 20:34:19 UTC
686a5b4 Alan Agius 07 July 2022, 12:32:40 UTC docs: typo fix in destroy description (#46737) Typo in environment. PR Close #46737 07 July 2022, 20:33:10 UTC
ae1264b Angular Robot 06 July 2022, 17:40:03 UTC build: update cross-repo angular dependencies (#46607) | datasource | package | from | to | | ---------- | ----------------------------- | --------------- | --------------- | | npm | @angular-devkit/architect-cli | 0.1401.0-next.3 | 0.1401.0-next.4 | | npm | @angular-devkit/build-angular | 14.1.0-next.3 | 14.1.0-next.4 | | npm | @angular-devkit/core | 14.1.0-next.3 | 14.1.0-next.4 | | npm | @angular-devkit/schematics | 14.1.0-next.3 | 14.1.0-next.4 | | npm | @angular/cli | 14.1.0-next.3 | 14.1.0-next.4 | | npm | @schematics/angular | 14.1.0-next.3 | 14.1.0-next.4 | PR Close #46607 06 July 2022, 22:56:24 UTC
eb6a6a0 Angular Robot 05 July 2022, 05:08:24 UTC build: update scorecard action dependencies (#46706) | datasource | package | from | to | | ----------- | --------------------- | ------- | ------- | | github-tags | github/codeql-action | v2.1.13 | v2.1.15 | | github-tags | ossf/scorecard-action | v1.1.1 | v1.1.2 | PR Close #46706 06 July 2022, 22:49:38 UTC
14863ac Alan Agius 01 July 2022, 11:45:46 UTC fix(localize): add `--project` option to `ng-add` schematic (#46664) `--project` is unwritten standard to provide the project name. With this change we allow the project name to be provided using the `--project` command line argument and remove the ambiguity with other schematics. PR Close #46664 06 July 2022, 22:49:05 UTC
818928c Paul Gschwendtner 03 July 2022, 10:21:35 UTC ci: remove renovate changes group (#46676) Removes the Renovate changes group as the respective code-owners. i.e. dev-infra or docs-infra should be responsible for reviewing changes. The caretaker does not necessarily have context when e.g. Jasmine should be updated or not/ if this needs coordination with other parts of the organization etc. Also updates are not always trivial, see recent updates for Angular (involing size updates, CLI commands fixups etc.) and e.g. Karma-Jasmine requiring debugging of ZoneJS. The Renovate group is also not easy to keep now that we use a custom robot account that doesn't necessarily only do Renovate.. (we could check the branch name -- but I believe the group can just be removed) PR Close #46676 06 July 2022, 20:46:48 UTC
5bd6d4e Paul Gschwendtner 01 July 2022, 18:25:50 UTC ci: switch to explicit commit message body for renovate (#46676) The commit body table by Renovate is sometimes not generated e.g. when just dev-infra is being updated. In order to make our lint job happy for such dev-infra updates, we should use an explicit message that is at least 20 characters long. PR Close #46676 06 July 2022, 20:46:48 UTC
e8c8b69 Dylan Hunn 30 June 2022, 22:05:43 UTC fix(forms): Move all remaining errors in Forms to use RuntimeErrorCode. (#46654) RuntimeErrorCode allows for better tree-shaking, and unique codes for each error. PR Close #46654 06 July 2022, 16:49:39 UTC
ecd01f9 Alan Agius 06 July 2022, 13:36:52 UTC refactor(core): remove unused `tick` method (#46722) This method is unused and is not part of the public API. PR Close #46722 06 July 2022, 16:48:55 UTC
c2a5f4e Paul Gschwendtner 04 July 2022, 11:19:43 UTC ci: enable renovate dashboard issue (#46695) We want to enable the Renovate dashboard to be able to trigger updates which might be out of schedule, or to see if some updates are stuck/pending, or to be able to rebase/try previously closed PRs. PR Close #46695 06 July 2022, 16:48:01 UTC
back to top