Skip to main content

Browse the archive

https://github.com/angular/angular
01 September 2024, 02:13:37 UTC
sort by:
Revision Author Date Message Commit Date
9129112 George Kalpakas 22 December 2018, 20:45:49 UTC test(bazel): fix `bazel-workspace` schematics test The test was cherry-picked from #27719 into 7.1.x, where entry module path ended in `/main`, not `/main.dev`. It was changed to `/main.dev` in #27277, which was not backported to 7.1.x. 25 December 2018, 00:59:17 UTC
395f9cd Miško Hevery 18 December 2018, 23:32:47 UTC release: cut the v7.1.4 release 18 December 2018, 23:32:47 UTC
94e4589 Ben Lesh 18 December 2018, 18:07:08 UTC docs(bazel): Update VSCode config (#27733) What was there didn't work at all, and resulted in an error `Error processing "attach": Error: Both localRoot and remoteRoot must be specified` PR Close #27733 18 December 2018, 18:14:01 UTC
f43e29b Miško Hevery 18 December 2018, 18:09:46 UTC build: removed merge conflict markers from a bad merge 18 December 2018, 18:09:46 UTC
9ab35a1 Christian Oliff 14 December 2018, 01:39:37 UTC build: use https link to editorconfig.org in .editorconfig (#27664) PR Close #27664 18 December 2018, 17:30:09 UTC
d622558 Sharath George M 14 December 2018, 08:36:26 UTC docs: Fixed typo (#27669) PR Close #27669 18 December 2018, 17:29:48 UTC
2650149 Paul Gschwendtner 17 December 2018, 17:28:06 UTC build: load angular.js minified output in upgrade tests (#27711) * We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files. PR Close #27711 18 December 2018, 17:29:27 UTC
ad16025 Paul Gschwendtner 17 December 2018, 18:09:47 UTC build: update gulp-clang-format dependency (#27712) Currently rnning the gulp tasks to format code does not work because the `through2` version used by `gulp-clang-format` is very outdated and seems to cause exceptions like: ``` Error: no writecb in Transform class at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33) at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12) ``` Updating to the latest version of `gulp-clang-format` that comes with https://github.com/angular/gulp-clang-format/commit/10cbb7f9bf8d31836d702a24bc0a31ca6ffbeb4c, seems to fix this. **Note**: This issue seems to depend on the platform because I didn't run into it on MacOS, or Linux. Though I got the failure on Windows. I didn't spend time investigating, but updating to the latest version should just improve things. PR Close #27712 18 December 2018, 17:28:55 UTC
b108e9a Keen Yee Liau 18 December 2018, 01:56:35 UTC fix(bazel): devserver entry_module should have underscore name (#27719) This commit fixes a bug whereby the path of the entry_module is not consistent with the workspace name, which does not permit dashes in the name. PR Close #27719 18 December 2018, 17:28:06 UTC
be08611 Brandon Roberts 01 November 2018, 18:51:37 UTC docs(forms): update API reference for validator directives (#26926) PR Close #26926 18 December 2018, 00:45:35 UTC
6b5c151 Paul Gschwendtner 17 December 2018, 17:46:54 UTC build: improve error message for upgrade test helper (#27706) Currently whenever the upgrade test helper fails to load a given AngularJS version, the error that will be rejected is technically not an error because the `onerror` callback is not returning an error, but an "ErrorEvent". Since that `ErrorEvent` is basically just rejected, browsers will print the error as followed: ``` Failed: [object Event] ``` This is not helpful at all and also implies that there _might_ be more information hidden within the `Event` instance. Unfortunately that's not the case (at least on browsers we test against) and the logic to extract the data from the event would be not worth the effort, we just return a simple custom `Error` that won't imply that there is more information hidden. PR Close #27706 18 December 2018, 00:45:19 UTC
183f278 Keen Yee Liau 17 December 2018, 21:17:13 UTC fix(bazel): Set module_name and enable ng test (#27715) Relative imports in Typescript files only work when module_name is defined in ts_library (when run in Node.js). See issue https://github.com/bazelbuild/rules_typescript/issues/360 With that fixed, `ng test` now works. `ng build` requires `node_modules` to be available in the project directory, so it's not usable yet. Running `yarn` in project directory does not work because of postinstall version check. PR Close #27715 18 December 2018, 00:44:32 UTC
d1a14f6 Emilio Martinez 31 October 2018, 08:04:01 UTC docs: remove misplaced code in Universal guide (#26865) PR Close #26865 17 December 2018, 17:35:36 UTC
ce4cff6 bmarkov 06 December 2018, 16:12:38 UTC docs: Add Smart UI to UI Components section in resources (#27515) docs: add Smart UI to UI Components section in resources PR Close #27515 17 December 2018, 17:34:14 UTC
78bd3c7 cyraid 30 September 2018, 03:01:57 UTC docs(animations): rename animateChild() to animate() (#26184) Renamed "animateChild()" to "animate()" in the comments/usage. The docs state to use animateChild() but uses animate() in the examples. PR Close #26184 14 December 2018, 23:27:37 UTC
b224057 Ruslan Dzhabbarov 14 November 2018, 07:52:44 UTC docs(common): fix documentation for getLocaleCurrencyName (#27087) PR Close #27087 14 December 2018, 23:27:04 UTC
cd1e206 levgaas 12 June 2018, 22:37:18 UTC fix(animations): do not truncate decimals for delay (#24455) Do not truncate decimals for animation delay if specified in seconds PR Close #24455 14 December 2018, 23:20:23 UTC
453589f JoostK 29 September 2018, 13:32:44 UTC fix(animations): mark actual descendant node as disabled (#26180) PR Close #26180 14 December 2018, 23:19:56 UTC
fa3af8b Ingo Bürk 24 November 2018, 15:00:13 UTC fix(common): KeyValuePipe should return empty array for empty objects (#27258) This lets KeyValuePipe return an empty array (rather than undefined) when the input is empty. PR Close #27258 14 December 2018, 23:19:14 UTC
c220328 zackarychapple 14 December 2018, 02:54:10 UTC docs: adding ngAtlanta 2019 (#27522) PR Close #27522 14 December 2018, 23:18:55 UTC
0d8528b Igor Minar 14 December 2018, 15:54:22 UTC fix(bazel): emit full node stack traces when Angular compilation crashes (#27678) The default 10 items are often not enough to debug deeply nested compilation operations. This PR is based on @martinprobst's http://cl/225528216. PR Close #27678 14 December 2018, 22:58:21 UTC
9ac4a4d Christopher Dahm 03 December 2018, 13:41:36 UTC docs(common): update currencyPipe default digitsInfo values (#27417) Change the docs to reflect the actual default values Fixes #27414 PR Close #27417 14 December 2018, 18:26:57 UTC
fe8c6b0 cooljeffro 10 December 2018, 18:36:15 UTC docs(common): Fix typo in KeyValuePipe docs (#27580) PR Close #27580 14 December 2018, 18:21:47 UTC
63d395c Alex Eagle 12 December 2018, 00:53:42 UTC build: restrict visibility of npm_package targets (#27611) dependencies on these cause very long rebuilds which have to re-package angular. Such tests belong in the integration/ folder PR Close #27611 14 December 2018, 18:20:41 UTC
f5e7208 Paul Gschwendtner 13 December 2018, 19:13:24 UTC build: re-enable saucelabs non-verbose logging (#27657) Previously the logging to TravisCI has been disabled because the `print-logs.sh` file printed the Sauce-Connect logfile output that is `verbose` by default. See [for example](https://travis-ci.org/angular/angular/jobs/250578973). Since the default stdout/stderr of sauce-connect is pretty much concise and can alert us if we run into any issues (e.g. rate limit, outdated tunnel version), we should stop piping these to `/dev/null`. PR Close #27657 14 December 2018, 18:19:54 UTC
b3759fd Paul Gschwendtner 13 December 2018, 18:42:39 UTC build: disable failing optional travis jobs (#27657) * Disables the failing optional Travis jobs because those just acquire limited resources of Saucelabs and BrowserStack and cause API rate limit problems if the caretaker merges multiple PRs. The rate limit error will spread across multiple repositories because we use the same license in multiple Angular projects (e.g. Angular Material, angular.js etc.) PR Close #27657 14 December 2018, 18:19:54 UTC
ef056c5 Paul Gschwendtner 06 December 2018, 21:07:07 UTC fix(bazel): ng_package writes unrelevant definitions to bazel out (#27519) In order to keep the bazel bin directory as clean as possible, we should not write definition files that are not relevant to a `ng_package` to an undesired location in the bazel bin directory. This currently just happens because we only filter out external definition files while we also should filter out definitions that aren't just in the current package. The `packager.ts` file currently tries to write these files to the package, but fails because those are not inside of the current package. So the logic to create a relative path for the file fails, and the definition will be copied to a location like: ```js // Notice the double "bazel-out" here. C:\Users\Paul\_bazel_Paul\kn4tsvyh\execroot\angular_material\bazel-out\x64_windows-fastbuild\bin\src\bazel-out\x64_windows-fastbuild\bin\src\cdk ``` [See logic that causes this](https://github.com/angular/angular/blob/4f9374951d67c75f67a31c110bd61ab72563db7d/packages/bazel/src/ng_package/packager.ts#L105-L124) (nothing wrong with that logic because it assumes that only paths from within the package are passed to it) PR Close #27519 13 December 2018, 22:58:38 UTC
a808c7d Paul Gschwendtner 10 December 2018, 19:25:49 UTC build: ts-api-guardian tsconfig warning with bazel (#27583) * Suppresses the warning from the Bazel TypeScript rules about overwritten options from the `tools/tsconfig.json` file. This is the only remaining warning that makes our Bazel build on Angular Material "dirty" PR Close #27583 13 December 2018, 19:01:48 UTC
89ace1a Keen Yee Liau 12 December 2018, 00:44:17 UTC fix(bazel): Load http_archive and rules_nodejs dependencies (#27609) Bazel 0.20 requires loading http_archive explicitly. rules_nodejs dependencies must now be installed explicity as well. PR Close #27609 13 December 2018, 19:01:31 UTC
52fd4a2 Igor Minar 12 December 2018, 06:49:14 UTC build: disable postinstall-patch.js log output (#27619) currently we have no patches so the logging only adds noise to our dev environment. PR Close #27619 13 December 2018, 19:01:15 UTC
8c32a2e Esteban Marin 12 December 2018, 06:51:50 UTC fix(docs-infra): fix top menu item clickable area (#27633) the clickable region of the top menu item is expanded beyond the focused area, so the clickable area is spans the entire height of the navigation fixes #27618 PR Close #27633 13 December 2018, 19:00:34 UTC
3ed1e84 Greg Magolan 12 December 2018, 21:37:11 UTC fix(bazel): fix major/minor semver check between @angular/bazel npm packager version and angular bazel repo version (#27635) PR Close #27635 13 December 2018, 18:59:15 UTC
d53c421 Igor Minar 13 December 2018, 07:35:46 UTC ci: remove packages/bazel from compiler-cli group (#27641) it doesn't make sense require approvals from compiler-cli group for most @angular/bazel changes. PR Close #27641 13 December 2018, 18:58:59 UTC
01102cb Igor Minar 13 December 2018, 14:48:36 UTC ci: exclude unnedeed files and directories from angular-robot g3sync check (#27653) We are overincluding files, all of these are not necessary in google3 and should not be synced because it's only slowing us down. Related CL: http://cl/225197013 PR Close #27653 13 December 2018, 18:58:43 UTC
97eb858 Paul Gschwendtner 12 December 2018, 22:07:21 UTC build: update to latest karma-sauce-launcher version (#27634) PR Close #27634 13 December 2018, 18:58:18 UTC
1059789 Emmanuel DEMEY 21 November 2018, 19:06:19 UTC docs: add Zenika trainings in resources.json (#27216) PR Close #27216 12 December 2018, 19:03:09 UTC
0dba3ee Greg Magolan 12 December 2018, 01:02:09 UTC build: update to tsickle 0.33.1 (#27612) PR Close #27612 12 December 2018, 19:02:43 UTC
8081854 George Kalpakas 08 December 2018, 08:35:56 UTC build(docs-infra): upgrade cli command docs sources to 02524ab82 (#27556) Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/a176d127a...02524ab82): **Modified** - help/build.json - help/serve.json - help/test.json PR Close #27556 12 December 2018, 18:56:48 UTC
348c949 Esteban Marin 12 December 2018, 06:51:50 UTC fix(docs-infra): fix top menu item clickable area (#27620) the clickable region of the top menu item is reduced to the focused area, so no cursor pointer is shown outside the clickable area fixes #27618 PR Close #27620 12 December 2018, 18:55:28 UTC
26c79ef Greg Magolan 12 December 2018, 00:52:03 UTC build(bazel): fix postinstall-patches.js script run during yarn postinstall when running yarn_install (#27610) PR Close #27610 12 December 2018, 18:54:59 UTC
0b8db92 Igor Minar 11 December 2018, 23:41:28 UTC docs: update SAVED_REPLIES and CONTRIBUTING with new issue templates (#27608) When we launched the new issue templates (.github/ISSUE_TEMPLATE/*), we forgot to update these docs which got stale and needed a refresh. PR Close #27608 12 December 2018, 00:43:58 UTC
d0e6eeb Igor Minar 11 December 2018, 15:08:23 UTC build: bump @bazel/ibazel to 0.9.0 (#27601) This should fix the problem with ibazel crashing on bzl/BUILD file syntax errors. bazelbuild/bazel-watcher/issues/194 https://github.com/bazelbuild/bazel-watcher/blob/master/CHANGELOG.md#v090-2018-12-07 PR Close #27601 12 December 2018, 00:31:20 UTC
93078e3 Keen Yee Liau 06 December 2018, 23:46:36 UTC fix(bazel): Read latest versions from latest-versions.ts & use semver check (#27591) When @angular/bazel is installed, a postinstall script is run to make sure that the npm version is *exactly* the same as the Angular repository install by Bazel. This check is overly stringent. Instead, it should enforce that the version satisfies the range check instead. This is consistent with the range defined in angular-cli/packages/schematics/angular/utility/latest-versions.ts. This commit also fixes the Bazel workspace to use the same Rxjs version if it's already installed. PR Close #27591 12 December 2018, 00:30:52 UTC
29ab729 Lucas 10 December 2018, 15:01:39 UTC docs: fix ngModel typo in form validation guide (#27574) Fix typo PR Close #27574 12 December 2018, 00:22:58 UTC
5452889 Alex Rickabaugh 11 December 2018, 21:31:19 UTC release: cut the v7.1.3 release 11 December 2018, 21:31:19 UTC
590b84f Michał Jawulski 06 December 2018, 20:32:53 UTC docs: update npm scripts to support angular 7 (#27334) PR Close #27334 11 December 2018, 19:25:37 UTC
b6deb00 Igor Minar 06 December 2018, 22:47:42 UTC build: exclude ivy commit messages from the release notes (#27532) there is still too much churn to make this info useful in the release notes, advanced developers can use git log to find out what's going on with ivy. PR Close #27532 11 December 2018, 19:22:54 UTC
01114dc Alex Eagle 10 December 2018, 22:36:45 UTC build: fix type-check errors introduced during rules_ts 0.21 (#27586) (#27590) PR Close #27586 PR Close #27590 11 December 2018, 19:22:08 UTC
7b1f352 Alex Eagle 10 December 2018, 21:31:40 UTC build: update rules_typescript (#27586) (#27590) This release of rules_typescript fixes a critical bug: typescript code was not checked at all, including type-checking, tsetse, and strict deps fixes #27569 PR Close #27586 PR Close #27590 11 December 2018, 19:22:08 UTC
575ef9f Isaac Sunkes 01 November 2018, 15:04:48 UTC docs: add webucator to resources (#26895) Added Angular Training by Webucator to Workshops & Onsite Training section of resources. PR Close #26895 10 December 2018, 22:20:03 UTC
11996cd Igor Minar 07 December 2018, 18:25:49 UTC docs: remove AngularDart from the version picker (#27550) At this point it's only confusing people. PR Close #27550 10 December 2018, 18:29:40 UTC
8fc763d Alex Eagle 02 December 2018, 00:08:15 UTC build: update to Bazel 0.20 (#27394) refactor Bazel RBE configs PR Close #27394 07 December 2018, 22:29:03 UTC
7a5136b Igor Minar 07 December 2018, 08:20:32 UTC build: update source-map-support to get rid of Node's DeprecationWarning (#27538) Removes the following when bazel runs any of our jasmine_node_tests: (node:85494) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. I was able to find the source of the warning by running the target with the following tags: ``` bazel test packages/language-service/... --test_arg=--node_options=--throw-deprecation ``` PR Close #27538 07 December 2018, 19:53:21 UTC
a9f39a4 Paul Gschwendtner 02 December 2018, 19:06:56 UTC fix(bazel): tsickle dependency not working with typescript 3.1.x (#27402) `@angular/bazel` currently requires TypeScript 3.1.x as a peer dependency, but comes with `tsickle` as dependency. The current version of `tsickle` that is specified by `@angular/bazel` does not support TypeScript 3.1.x (which is a peer dependency) and therefore we need to make sure that `tsickle` works with the required TypeScript versions. This change updates `tsickle` to the latest version that comes with https://github.com/angular/tsickle/commit/b10fb6de0a86646e0f15c8551e77a0b4c5956f8b in order to work with TypeScript 3.1.x. PR Close #27402 07 December 2018, 18:51:37 UTC
35d0284 Christopher Dahm 02 December 2018, 14:33:08 UTC docs: file new issue needs to have opener choose type from template (#27400) The submission guidelines for submitting an issue directs issue reporters to a pre-filled unformatted issue form. Reporters need directed to choose from the issue templates. Fixes #27398 PR Close #27400 07 December 2018, 17:27:52 UTC
74346e9 Alex Eagle 06 December 2018, 22:46:51 UTC style: run latest buildifier binary (#27489) PR Close #27489 07 December 2018, 17:27:33 UTC
f221e90 Alex Eagle 05 December 2018, 20:16:14 UTC ci: use buildifier binary release (#27489) Switch from Skylint to buildifier --lint - this is required for the Bazel 0.20 upgrade since Bazel no longer lets us use the embedded JDK to build and run Java programs, and Skylint is a Java program PR Close #27489 07 December 2018, 17:27:33 UTC
90c273a Olivier Combe 06 December 2018, 14:55:42 UTC ci: update ngbot config to add merge linked labels (#27512) PR Close #27512 07 December 2018, 17:25:45 UTC
11d2a8c Igor Minar 06 December 2018, 23:08:57 UTC release: cut the v7.1.2 release 06 December 2018, 23:08:57 UTC
ad106ab Minko Gechev 28 November 2018, 23:34:27 UTC build: introduce remote bazel caching (#27358) This PR introduces: 1. Google Cloud Store bucket which contains build artifacts 2. Documentation on how to enable remote caching in development Each team member should download a service key. More convenient ways of authentication would be more obscure and prevent us from doing identity tracking of the produced artifacts. PR Close #27358 06 December 2018, 19:25:03 UTC
84f2928 Paul Gschwendtner 04 December 2018, 22:35:28 UTC fix(compiler-cli): ngtsc shim files not being generated on case-insensitive platforms (#27466) Common insensitive platforms are `win32/win64` (see: [here](https://github.com/Microsoft/TypeScript/blob/3e4c5c95abd515eb9713b881d27ab3a93cc00461/src/compiler/sys.ts#L681-L682)) Currently when running `bazel build packages/core --define=compile=aot`, the `compiler-cli` will throw because it cannot find the `index.ngfactory.ts` file in the compiler host. This is because the shim host wrapper is not properly generating the requested `ngfactory` file. This happens because we call `getCanonicalFileName` that returns a path that is different to the actual program filenames that are used to construct a map of generated files. Since the generators always use the paths which are not "canonical" and pases them internally like that, we can just stop manually calling `getCanonicalFileName`. PR Close #27466 06 December 2018, 17:24:53 UTC
610472b Igor Minar 06 December 2018, 16:27:25 UTC Revert "fix(router): change processing url tree children condition (#26243)" (#27516) This reverts commit ccc77ca441ae11d2b516806b4b1c1b7b3062b896. Breaks Pantheon see cl/224256517. PR Close #27516 06 December 2018, 17:17:21 UTC
7bed896 Igor Minar 06 December 2018, 16:27:20 UTC Revert "fix(router): process empty path segment when preceding a named outlet (#26243)" (#27516) This reverts commit 20cef5078dc86bc5d9831fafec076d912ad3521f. Breaks Pantheon see cl/224256517. PR Close #27516 06 December 2018, 17:17:21 UTC
d7c72fc Igor Minar 01 December 2018, 11:58:09 UTC build: remove obsolete gulp build task (#27386) PR Close #27386 06 December 2018, 04:55:33 UTC
3ca5de7 Igor Minar 01 December 2018, 11:47:06 UTC ci: don't run node unit tests on travis (#27386) we run all these tests on CircleCI with bazel. PR Close #27386 06 December 2018, 04:55:33 UTC
485e2a1 Igor Minar 01 December 2018, 11:32:59 UTC test(benchpress): make most of the tests run under bazel (#27386) PR Close #27386 06 December 2018, 04:55:33 UTC
b24f198 Igor Minar 01 December 2018, 10:18:44 UTC ci: remove validate-commit-message tests from travis (#27386) we alredy run them via bazel. I also removed a bunch of obsolete files that bazel doesn't need. PR Close #27386 06 December 2018, 04:55:33 UTC
f8846ef Igor Minar 01 December 2018, 10:16:57 UTC docs: remove obsolete packages/examples/web_workers/ts/.gitkeep (#27386) PR Close #27386 06 December 2018, 04:55:33 UTC
9a93259 Igor Minar 01 December 2018, 09:49:43 UTC test: correct bazel visibility for @angular/private/testing (#27386) we don't want anyone else to depened on this stuff. PR Close #27386 06 December 2018, 04:55:33 UTC
194f1f0 Igor Minar 01 December 2018, 01:57:39 UTC test(service-worker): run the remaining service-worker tests under bazel (#27386) PR Close #27386 06 December 2018, 04:55:33 UTC
fba9fa2 Igor Minar 01 December 2018, 00:56:23 UTC test(common): run @angular/common/http/testing tests under bazel (#27386) PR Close #27386 06 December 2018, 04:55:32 UTC
820e202 Igor Minar 01 December 2018, 00:16:22 UTC ci: don't run router tests on travis (#27386) we already run them on circle under bazel PR Close #27386 06 December 2018, 04:55:32 UTC
0508143 Kara Erickson 05 December 2018, 22:38:49 UTC build: add kara to more approval lists (#27493) PR Close #27493 05 December 2018, 22:41:50 UTC
a97fbfd George Kalpakas 27 November 2018, 17:36:53 UTC refactor(docs-infra): remove unused custom element (#27250) PR Close #27250 05 December 2018, 21:26:28 UTC
e552cad George Kalpakas 27 November 2018, 15:16:08 UTC fix(docs-infra): do not use an Angular element in hard-coded `FETCH_ERROR` document (#27250) The `FETCH_ERROR` document is used when we are unable to retrieve a document (except for 404 errors), which includes when there is no internet connection. Using the `<current-location>` element in the document's template to show the path of the page we failed to retrieve assumes that the element's bundle is available (e.g. cached by the SW) or can be fetched from the server. When none of these conditions is met, the `DocViewer` is unable to prepare the document and fails, never showing the `FETCH_ERROR` page to the user. Furthermore, the path we are looking to retrieve via `<current-location>` is essentially the document ID, which we already have. Thus, loading and instantiating a whole component just for that is overkill. This commit addresses both issues by getting rid of the `<current-location>` component and directly embedding the document ID into the `FETCH_ERROR` content. PR Close #27250 05 December 2018, 21:26:28 UTC
35ab809 George Kalpakas 27 November 2018, 14:41:24 UTC fix(docs-infra): fix sidenav positioning when notification is shown (#27250) _Before:_ ![sidenav-scrollbar-before](https://user-images.githubusercontent.com/8604205/49089078-62519d00-f263-11e8-8369-f39e73dcc239.png) _After:_ ![sidenav-scrollbar-after](https://user-images.githubusercontent.com/8604205/49089077-62519d00-f263-11e8-8a94-0c34044c4ba1.png) PR Close #27250 05 December 2018, 21:26:28 UTC
919ef66 George Kalpakas 27 November 2018, 14:26:24 UTC build(docs-infra): remove dependency on FontAwesome (#27250) We were only using two FontAwesome icons (`link` and `twitter`). The twitter icon is already available as an SVG (used in the topbar) and a similar link icon is available via 'Material Icons', which we are already brining in. This commit removes the dependency on FontAwesome and uses the available icons instead. _Before:_ ![contributor-info-before](https://user-images.githubusercontent.com/8604205/49089076-61b90680-f263-11e8-8c5f-c52d332e6e64.png) _After:_ ![contributor-info-after](https://user-images.githubusercontent.com/8604205/49089075-61b90680-f263-11e8-9785-b8df15aaacd3.png) PR Close #27250 05 December 2018, 21:26:28 UTC
a37c658 George Kalpakas 26 November 2018, 22:47:34 UTC fix(docs-infra): correctly cache footer image by the SW (#27250) When using relative paths for CSS resources (such as background images), `@angular/cli` will move them to the root `dist/` directory (and update the paths in CSS accordingly). This results in the SW being unable to cache the resource, because it is not where it expects it to be. This commit fixes this issue for the footer background image, by using an absolute path for the URL. (It also removes an unused style that would have been affected by the same issue.) PR Close #27250 05 December 2018, 21:26:28 UTC
1371cf6 George Kalpakas 26 November 2018, 22:20:32 UTC fix(docs-infra): ensure material icons are cached for offline access (#27250) In order for 'Material Icons' to work offline, their `.woff2` file needs to have been cached by the SW. This file is not requested by the browser, until an element needs to use the icon font. In order to speed up the initial page load and avoid FOUC, we use inlined SVGs for all icons in the app shell. As a result, the `.woff2` file may not be requested, when a user visits angular.io. If they go offline before visiting a page that does actually use 'Material Icons', then such icons will not work correctly (e.g. the `error_outline` icon used in the error page for failed requests due to network unanvailability). This commit fixes this, by adding a non-visible element that needs the 'Material Icons' font on the main component. Thids ensures that the `.woff2` file will always be loaded, even if the page does not use any material icons. (Note: The element is inserted lazily to avoid affecting the initial rendering.) PR Close #27250 05 December 2018, 21:26:28 UTC
e965572 George Kalpakas 27 November 2018, 12:35:16 UTC fix(docs-infra): remove hard-coded color from inlined SVG icons (#27250) This allows the icons to inherit the color of their HTMLElement parent. PR Close #27250 05 December 2018, 21:26:28 UTC
8512e34 George Kalpakas 26 November 2018, 20:56:35 UTC fix(docs-infra): inline SVG icons used in page load sensitive UI (#27250) These icons are part of the app shell and used on every load (on both desktop and mobile). Inlining them ensures they are rendered asap. PR Close #27250 05 December 2018, 21:26:28 UTC
21c9cff George Kalpakas 26 November 2018, 15:49:23 UTC fix(docs-infra): always fetch Roboto font (#27250) Previously, we did not load the Roboto font, instead relying on the user to have it available on their system and falling back to different fonts otherwise. This resulted in the page being styled slightly differently for those people that didn't have the font installed locally. PR Close #27250 05 December 2018, 21:26:28 UTC
e902f5e George Kalpakas 23 November 2018, 19:39:05 UTC fix(docs-infra): do not create an anchor for the `file-not-found` header (#27250) PR Close #27250 05 December 2018, 21:26:28 UTC
013a241 George Kalpakas 23 November 2018, 19:03:21 UTC refactor(docs-infra): move minified `lunr` script to the `generated` directory (#27250) PR Close #27250 05 December 2018, 21:26:27 UTC
0d0bc1f George Kalpakas 23 November 2018, 19:08:23 UTC build: error when files specified in payload size limits are missing (#27250) PR Close #27250 05 December 2018, 21:26:27 UTC
a655d28 Filipe Silva 15 November 2018, 11:07:30 UTC ci: test ts-api-guardian on windows (#27205) PR Close #27205 05 December 2018, 20:49:55 UTC
e55088a Igor Minar 05 December 2018, 18:10:58 UTC build: to fsevents@2.0.1 (#27469) the old version was failing to compile on MacOS Mojave 10.14.1. PR Close #27469 05 December 2018, 18:48:20 UTC
2e41631 Greg Magolan 05 December 2018, 00:28:58 UTC build(bazel): replace yarn_install(name = "npm") with @npm local_reporsitory() to speed up build (#27469) PR Close #27469 05 December 2018, 18:48:20 UTC
2bc85fb miginmrs 05 October 2018, 18:22:06 UTC fix(router): process empty path segment when preceding a named outlet (#26243) PR Close #10726 PR Close #26243 05 December 2018, 18:39:30 UTC
8167bfc miginmrs 04 October 2018, 07:31:41 UTC fix(router): change processing url tree children condition (#26243) stop adding next path of pathless activated route to the url PR Close #26224 PR Close #26243 05 December 2018, 18:39:30 UTC
711ef2d Alex Eagle 03 December 2018, 22:52:31 UTC build: update to newest ibazel (#27441) this supports the --define flag which we use for Ivy development PR Close #27441 05 December 2018, 04:00:06 UTC
5c57920 George Kalpakas 03 December 2018, 21:10:04 UTC fix(docs-infra): log the successful creation of previews (#27436) This can help with debugging issues, e.g. with the communication between the preview server and CI, as it gives a better idea of exactly when was the preview made available and how long it took. PR Close #27436 05 December 2018, 03:59:25 UTC
9b4d959 Paul Gschwendtner 02 December 2018, 18:22:09 UTC fix(bazel): do not throw if ts compile action does not create esm5 outputs (#27401) In some applications, developers define a `ts_library` that just consists of `d.ts` files (e.g. to type `module.id`; see: https://github.com/angular/material2/blob/master/src/module-typings.d.ts), and expect the `esm5.bzl` file to not throw an error like: ``` target.typescript.replay_params.outputs struct' object has no attribute 'outputs' ``` The "replay_parameters" property will exist in that case, but is set to "None" because there is no action that should be replayed in favor of producing ES5 outputs. See: https://github.com/bazelbuild/rules_typescript/pull/326. Notice that this right now breaks similarly because an empty `struct()` is returned that does not have a property called `outputs`. [#326](https://github.com/bazelbuild/rules_typescript/pull/326) fixes that by being explicit that there is no _action_ at all. PR Close #27401 05 December 2018, 03:58:36 UTC
8087b6b Paul Gschwendtner 04 December 2018, 11:23:49 UTC fix(compiler-cli): flatModuleIndex files not generated on windows with multiple input files (#27200) * Currently when building a `ng_module` with Bazel and having the flat module id option set, the flat module files are not being generated because `@angular/compiler-cli` does not properly determine the entry-point file. Note that this logic is not necessarily specific to Bazel and the same problem can happen without Bazel if multiple TypeScript input files are specified while the `flatModuleIndex` option has been enabled. PR Close #27200 04 December 2018, 22:01:25 UTC
1ca2923 Paul Gschwendtner 03 December 2018, 21:58:08 UTC fix(bazel): ng_package cannot be run multiple times without clean (#27200) Currently when building the `ng_package` multiple times, the old `ng_package` output will be copied over to the new `ng_package` content. Resulting in packages like `src/cdk/npm_package/npm_package/npm_package/AND_MORE`. This happens because currently all TypeScript definition files are resolved from within the `binDir`. This is just wrong because it could then take up the `d.ts` files from the previous `ng_package` output. All typescript definitions that belong to the target package, should be resolved through Bazel and copied based on that computation. Also fixes that `esm` files aren't written to the `ng_package` on Windows. This is because we try to flatten paths using the `path.delimiter` while the path is always using Posix delimiters (causing the paths to be incorrect) PR Close #27200 04 December 2018, 22:01:25 UTC
079c4b3 Paul Gschwendtner 21 November 2018, 18:49:33 UTC fix(bazel): do not throw error when writing tsickle externs (#27200) * Currently when building the ES5 and ES2015 output, `ngc_wrapped` will fail because it tries to write the `fs.openSync` the tsickle output file at the same time. This causes a runtime exception in Windows and can be fixed by just writing the externs for ES5 mode to the proper ES5 "output root". PR Close #27200 04 December 2018, 22:01:25 UTC
e476c38 Paul Gschwendtner 20 November 2018, 20:06:17 UTC fix(bazel): ng_package not generating UMD bundles on windows (#27200) * Fixes that `ng_package` does not work generate UMD bundles on Windows because the `esm5/` files are not written to the output directory. This is because `rootDirs` and `rootDir` are posix paths and cause invalid relative paths when mixed with Windows backslash paths. PR Close #27200 04 December 2018, 22:01:25 UTC
8799ea7 George Kalpakas 04 December 2018, 13:50:17 UTC ci(docs-infra): manually trigger the preview server webhook (#27458) With this change, we no longer depend on CircleCI to trigger the webhook (which it sometimes does with considerable delay or not at all). This has the added benefit that other jobs will not unnecessarily trigger webhooks and spam the preview server logs. It is only the `aio_preview` job's webhook that we care about. Related to #27352. PR Close #27458 04 December 2018, 21:59:54 UTC
0378792 volshibenik 03 December 2018, 06:35:05 UTC docs: fix typo in toh-pt6.md (#27403) PR Close #27403 03 December 2018, 16:24:19 UTC
1022db1 Christopher Dahm 30 November 2018, 03:47:40 UTC test(common): add PercentPipe round and trim tests (#27365) Add tests to cover the percent's decimal to be rounded and trimmed. PR Close #27365 03 December 2018, 16:22:25 UTC
back to top