| 6e30b83 | Pete Bacon Darwin | 02 November 2020, 17:54:24 UTC | build(docs-infra): ensure that deployment works on CI (#39542) The actual "main" part of the script that is executed was using an uninitialized variable. This is fixed and a test is added to check. PR Close #39542 | 02 November 2020, 20:29:26 UTC |
| 206f87a | George Kalpakas | 28 October 2020, 19:30:13 UTC | build(docs-infra): upgrade `firebase-tools` to v8.14.1 (#39479) This commit upgrades `firebase-tools` (used to deploy angular.io to Firebase hosting) to the latest version. This gives us access to the latest fixes/improvements and also new features, such as [version cloning][1]. [1]: https://firebase.google.com/docs/hosting/manage-hosting-resources#cli-commands-cloning PR Close #39479 | 02 November 2020, 15:55:46 UTC |
| bd016a2 | George Kalpakas | 28 October 2020, 18:51:08 UTC | build(docs-infra): deploy angular.io to new Firebase sites (#39479) Previously, the documentation for each major Angular version was hosted on each own Firebase project. This required creating a new project for each major release and increased the administrative/maintenance cost. Now that Firebase supports hosting [multiple websites][1] as part of the same project, we are switching to deploying all major versions to sites created on `angular-io` project. This is part of the work needed to prepare angular.io for our [new versioning/branching process][2] (also tracked in #39366). [1]: https://firebase.google.com/docs/hosting/multisites [2]: https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU PR Close #39479 | 02 November 2020, 15:55:46 UTC |
| 5293b3f | George Kalpakas | 28 October 2020, 10:23:58 UTC | refactor(docs-infra): break up `deploy-to-firebase.js` script into functions (#39479) This commit breaks up the code in `deploy-to-firebase.js` script, that we use for deploying angular.io to production, to smaller functions (instead of a monolithic block). This makes the script easier to maintain and also makes testing individual operations easier. The commit also updates the `deploy-to-firebase.spec.js` spec file to take advantage of the standalone functions to speed up testing by calling the corresponding function instead of having to spawn a new process and run the `deploy-to-firebase.js` script with the `--dry-run` flag. NOTE: Before updating the tests, I verified that the updated `deploy-to-firebase.js` script passed the old tests. PR Close #39479 | 02 November 2020, 15:55:46 UTC |
| 0565aee | George Kalpakas | 28 October 2020, 10:23:57 UTC | build(docs-infra): add support for RC deployments to deployment script (#39479) This commit updates the angular.io deployment script (`deploy-to-firebase.js`) to support deploying release-candidate versions. This is part of the work needed to prepare angular.io for our [new versioning/branching process][1] (also tracked in #39366). [1]: https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU PR Close #39479 | 02 November 2020, 15:55:46 UTC |
| 9fe8bbb | George Kalpakas | 28 October 2020, 10:23:56 UTC | build(docs-infra): add new angular.io build configuration for release-candidates (#39479) This commit adds a new build configuration/deployment mode (`rc`) for deploying release-candidate versions to angular.io. This is part of the work needed to prepare angular.io for our [new versioning/branching process][1] (also tracked in #39366). [1]: https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU PR Close #39479 | 02 November 2020, 15:55:46 UTC |
| bab2351 | George Kalpakas | 28 October 2020, 14:17:50 UTC | refactor(docs-infra): use Sass mixin to simplify the creation of deployment mode themes (#39479) Different deployment modes (such as `archive` and `next`) are identified by the different colors used in prominent elements of the page, such as the topbar and the footer. Previously, the necessary styles for creating such a deployment mode "theme" were duplicated for each mode. This commit simplifies the creation/modification of a deployment mode theme by introducing a Sass mixin that generates the necessary styles (when provided with necessary theme colors). PR Close #39479 | 02 November 2020, 15:55:46 UTC |
| a18e99b | George Kalpakas | 28 October 2020, 13:03:41 UTC | test(docs-infra): ensure `deploy-to-firebase` tests pass locally (#39479) Previously, the `deploy-to-firebase.js` script and the accompanying `deploy-to-firebase.spec.js` spec file were using the `origin` remote alias in certain commands. This works fine on CI, where `origin` points to the `angular/angular` GitHub repo, but might not work locally. This commit ensures that the correct remote is used by explicitly specifying it by the URL, thus ensuring that the tests will behave identically on CI and locally. PR Close #39479 | 02 November 2020, 15:55:46 UTC |
| 18c44de | George Kalpakas | 28 October 2020, 10:23:51 UTC | build(docs-infra): switch `deploy-to-firebase.sh` script to JS (#39479) This commit switches the `deploy-to-firebase.sh` script, that we use for deploying angular.io to production, from Bash to JavaScript. This makes the script easier to maintain. For the same reasons, it also switches the `deploy-to-firebase.test.sh` script, that we use for testing the `deploy-to-firebase` script, from Bash to JavaScript (using jasmine as the test runner). Finally, this commit also updates ShellJS to the latest version to get better error messages (including the actual error) when `exec()` fails. NOTE: Before switching the test script to JS, I verified that the new `deploy-to-firebase.js` script passed the tests with the old `deploy-to-firebase.test.sh` script. PR Close #39479 | 02 November 2020, 15:55:46 UTC |
| 72c3ebe | Stephen Fluin | 30 January 2020, 18:25:30 UTC | docs: remove the release schedule from docs (#34474) Removing for now, since the info is stale, and we need to determine how to adjust the schedule due to the unexpected and significant version 9 delay. PR Close #34474 | 06 February 2020, 22:32:13 UTC |
| 8b88269 | George Kalpakas | 29 January 2020, 19:36:57 UTC | docs: update events page Fixes #34971 | 29 January 2020, 19:36:57 UTC |
| fb5eb5f | frosty | 28 January 2020, 23:44:45 UTC | docs: ng-conf 2020 date change (#35019) Update the range of dates where ng-conf will appear on angular.io. PR Close #35019 | 29 January 2020, 19:25:57 UTC |
| afc8100 | owenmecham | 11 December 2019, 07:23:08 UTC | docs: ng-conf 2020 the musical (#34342) Added event and announcement info for ng-conf 2020 PR Close #34342 | 29 January 2020, 19:23:41 UTC |
| 015f833 | George Kalpakas | 28 January 2020, 13:32:03 UTC | ci(docs-infra): ignore node version in `aio_monitoring_stable` CI job In #34955, we switched to Node.js v12 on master and 9.0.x. This causes the `aio_monitoring_job` CI job (which checks out files from the stable branch; currently 8.2.x) to start failing yarn's engines check (since the 8.2.x branch expects Node.js version <11). Example failure: https://circleci.com/gh/angular/angular/602499 Since the job is expected to run with files from both the stable and the master branches (and since the version of Node.js is not important here), this commit uses the `--ignore-engines` option to prevent failures due to Node.js version mismatch. NOTE: Typically, the stable and master branch are on the same Node.js version, because related PRs land on both master and the patch branch. One exception is during RC periods, when the stable branch is different than the patch branch. These periods are usually short, but in the case of 9.0.0 the period has lasted several months causing the CI environments between master and the stable branch to get significantly out-of-sync. | 28 January 2020, 14:06:26 UTC |
| d2aad91 | George Kalpakas | 25 January 2020, 09:52:00 UTC | build: update `firebase-tools` to the latest version This is a backport of #34682 to the 8.2.x branch. It fixes `Server Error. certificate has expired` errors that cause AIO deployment to fail. (Example CI failure: https://circleci.com/gh/angular/angular/599109) | 25 January 2020, 09:52:00 UTC |
| e35d9ea | George Kalpakas | 24 January 2020, 17:43:13 UTC | build: vendor yarn using the .yarnrc yarn-path value This is a backport of #34902 to the 8.2.x branch (except that yarn v1.17.3 is used to satisfy the yarn version requirements of the 8.2.x branch). This will ensure that an appropriate yarn version will be used in the `aio_monitoring_stable` CI job, which checks out files from the git branch corresponding to the latest stable Angular version (currently the 8.2.x branch). (Example of the current failure: https://circleci.com/gh/angular/angular/598455) | 24 January 2020, 17:43:13 UTC |
| bbeac07 | Kara Erickson | 13 November 2019, 20:21:39 UTC | release: cut the v8.2.14 release | 13 November 2019, 20:21:39 UTC |
| 03b3a38 | Joey Perrott | 13 November 2019, 19:51:15 UTC | build: set up all packages to publish via wombot proxy | 13 November 2019, 20:15:30 UTC |
| 2c74996 | Judy Bogart | 11 November 2019, 21:24:50 UTC | docs: reorganize get-started to emphasize ready-made app | 11 November 2019, 22:46:57 UTC |
| 2840670 | Michael Prentice | 07 September 2019, 03:57:21 UTC | fix(service-worker): ensure initialization before handling messages (#32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes #25611 PR Close #32525 | 11 November 2019, 22:39:09 UTC |
| b43ae44 | Alan Agius | 31 October 2019, 17:21:52 UTC | fix(bazel): exclude @angular/cli from metadata build Closes #33502 | 31 October 2019, 17:35:16 UTC |
| 2174827 | Joey Perrott | 31 October 2019, 16:15:25 UTC | build: ensure that version stamping is applied when the npm_package publish action is called (#33512) PR Close #33512 | 31 October 2019, 17:21:43 UTC |
| 8bce694 | Andrew Kushnir | 30 October 2019, 21:03:06 UTC | release: cut the v8.2.13 release | 30 October 2019, 21:03:06 UTC |
| 38e9959 | thanhpd | 30 October 2019, 02:22:49 UTC | docs: remove redundant whitespaces and fix minor typos (#33483) PR Close #33483 | 30 October 2019, 17:42:37 UTC |
| 1fc7786 | Joey Perrott | 29 October 2019, 15:58:58 UTC | build: remove --nowatchfs flag as --watchfs is a noop on windows now (#33471) PR Close #33471 | 29 October 2019, 21:05:49 UTC |
| a08b181 | John Ralph Umandal | 22 October 2019, 12:28:02 UTC | docs: fixed cli ng update reference link (#33320) The automated link for ng update is currently going to the wrong page. Edit directs them to the correct page. PR Close #33320 | 29 October 2019, 21:03:53 UTC |
| f97c464 | Pete Bacon Darwin | 28 October 2019, 20:19:27 UTC | fix(compiler): i18n - ignore `alt-trans` tags in XLIFF 1.2 (#33464) The parser was accidentally reading the `target` tag below the `alt-trans` target and overriding the correct `target` tag. Fixes #33161 PR Close #33464 | 29 October 2019, 18:49:58 UTC |
| ac4353c | thanhpd | 26 October 2019, 17:00:38 UTC | docs: added missing whitespaces (#33424) PR Close #33424 | 29 October 2019, 18:40:50 UTC |
| 26a6db2 | George Kalpakas | 25 October 2019, 10:24:52 UTC | docs(docs-infra): document running docs examples in ivy mode (#33399) PR Close #33399 | 25 October 2019, 16:19:36 UTC |
| e0428fe | Geoff Bass | 24 October 2019, 15:21:27 UTC | docs: fix typo in getting started guide (#33372) Add a missing word to make the phrase grammatically correct PR Close #33372 | 24 October 2019, 16:51:37 UTC |
| 82df950 | Andrus Diaz | 24 October 2019, 00:39:26 UTC | docs: add example of a server in golang for deployment (#33092) PR Close #33092 | 24 October 2019, 16:51:06 UTC |
| 663aba5 | Andrew Kushnir | 23 October 2019, 22:00:08 UTC | release: cut the v8.2.12 release | 23 October 2019, 22:00:08 UTC |
| 2d465ee | Stefanie Fluin | 18 October 2019, 23:22:06 UTC | feat(docs-infra): implement figure styles (#33259) PR#28396 originally addressed an update via issue #23983 to make images more visible with a white background (implementation of gray "lightbox"). This PR implements those styles defined in PR#28396. PR Close #33259 | 23 October 2019, 19:59:35 UTC |
| 70238f7 | ODAVING | 02 October 2019, 18:28:12 UTC | docs: fix spelling error in angular component (#32971) change component class section of the docs Closes #32948 PR Close #32971 | 23 October 2019, 18:46:42 UTC |
| 704e354 | Keen Yee Liau | 22 October 2019, 20:26:07 UTC | docs: Fix appHighlightColor typo (#33331) In the example, there's no directive nor input that's named `appHighlightColor`. It should be `appHighlight`, referring to the input binding. PR Close #33331 | 23 October 2019, 18:08:19 UTC |
| 98e71d3 | George Kalpakas | 23 October 2019, 11:22:32 UTC | build(docs-infra): upgrade cli command docs sources to 5bf754195 (#33350) Updating [angular#8.2.x](https://github.com/angular/angular/tree/8.2.x) from [cli-builds#8.3.x](https://github.com/angular/cli-builds/tree/8.3.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/e21aeeecd...5bf754195): **Modified** - help/update.json ## PR Close #33350 | 23 October 2019, 16:59:37 UTC |
| 7478d0c | George Kalpakas | 23 October 2019, 16:26:04 UTC | test(docs-infra): disable es5 size tracking in aio tests (#33356) PR Close #33356 | 23 October 2019, 16:58:13 UTC |
| ef5c0da | Paul Gschwendtner | 23 October 2019, 10:49:49 UTC | build: fix gulp setup not working with node v12 (#33348) It looks like the gulp setup does not work with NodeJS v12. This is because we still use gulp for a few tasks, but gulp v3 is not compatible with NodeJS v12. We had a similar issue for NodeJS v12, but worked around it by updating the `natives` module version. To actually solve this in a more future-proof way, without updating or removing Gulp (for now), we just overwrite the `graceful-fs` version. The latest version of `graceful-fs` does no longer depend on the `natives` package and therefore works properly with NodeJS >= v10. PR Close #33348 | 23 October 2019, 16:16:21 UTC |
| 57c3a23 | George Kalpakas | 23 October 2019, 08:47:38 UTC | fix(docs-infra): scroll to top when navigating to new page via address bar (#33344) Previously, when navigating to a new page via a link, the scroll position was correctly restored to 0, but navigating to a new page via typing the URL in the browser address bar keeps the old scroll position. This commit ensures that the scroll position is restored to 0 whenever the `ScrollService` is instantiated anew (i.e. new page navigation). The old behavior of retaining the scroll position on reload is kept by storing the old URL when leaving a page and only applying the stored scroll position if the new URL matches the stored one. Fixes #33260 PR Close #33344 | 23 October 2019, 16:12:04 UTC |
| bb28406 | Joey Perrott | 21 October 2019, 20:04:46 UTC | build: update bazel remote build config and documentation (#33304) PR Close #33304 | 21 October 2019, 20:52:46 UTC |
| fc14728 | TinyMan | 28 September 2019, 16:07:05 UTC | docs: clarrify use of sw behind redirect (#32915) Closes #30684 PR Close #32915 | 21 October 2019, 20:50:52 UTC |
| 3f3e1bf | David Sánchez | 10 October 2019, 22:30:48 UTC | docs: clarify steps in Hosting on Firebase (#33089) PR Close #33089 | 21 October 2019, 20:07:05 UTC |
| 2b02e87 | Colum Ferry | 12 October 2019, 22:42:51 UTC | docs(forms): fix grammar and add clarification to setValue docs (#33126) Changed `setValue` documentation for throwing an error as it contained a grammar mistake and also may have caused ambiguity around when exactly the method would throw. PR Close #33126 | 21 October 2019, 19:58:39 UTC |
| 88869a2 | Diego Juliao | 19 October 2019, 06:39:33 UTC | docs: update deployers table with ngx-deploy-npm (#33269) ngx-deploy-npm is a custom deployer to publish Angular libraries to NPM PR Close #33269 | 21 October 2019, 15:28:21 UTC |
| 958aba9 | Judy Bogart | 16 October 2019, 19:40:55 UTC | docs: edit and organize language service doc (#33202) PR Close #33202 | 18 October 2019, 22:19:06 UTC |
| d9581bd | Paul Gschwendtner | 18 October 2019, 09:26:15 UTC | ci: fix dev-infra incorrectly matching all ".bzl" files as codeowner (#33249) The `dev-infra-framework` codeowners section is located after all the codeowner sections for the individual framework packages. This means that for certain wildcards, like `*.bzl` take precedence over the individual package sections (like of `/packages/bazel/**`). This can be observed in the following PR where `dev-infra` got requested for file changes to `@angular/bazel`. #32955. To fix this, we move the `dev-infra-framework` section before all individual framework package sections. This means that we only match files which are not matched by other patterns. Additionally a pattern for `*.BAZEL` has been added to the dev-infra section. This helps getting changes to `BUILD.bazel` files through easier as dev-infra can review those (Note: only for bazel files which are not matched by other patterns). PR Close #33249 | 18 October 2019, 20:27:30 UTC |
| 19ada81 | Matias Niemelä | 18 October 2019, 18:47:39 UTC | build: fix tslint issue with String instantiation | 18 October 2019, 18:47:39 UTC |
| 3d60f2c | Amadou Sall | 17 October 2019, 23:40:42 UTC | docs: clarify instructions on where to create the proxy.conf.json file (#33244) PR Close #33244 | 18 October 2019, 18:40:58 UTC |
| f13e40d | Sahan Serasinghe | 01 October 2019, 12:57:05 UTC | docs: change "patchMatch" to "pathMatch" (#32935) PR Close #32935 | 18 October 2019, 15:31:54 UTC |
| fab6ea0 | Danny Skoog | 15 October 2019, 22:04:05 UTC | docs: correct vscode clang-format setup instructions (#33190) PR Close #33190 | 17 October 2019, 18:17:56 UTC |
| 05a1ceb | Danny Skoog | 16 October 2019, 23:52:48 UTC | style: enforce disallowance of String, Number and Boolean constructors (#33210) The `no-construct` tslint rule partially enforces the style guide rule https://google.github.io/styleguide/jsguide.html#disallowed-features-wrapper-objects PR Close #33210 | 17 October 2019, 18:12:01 UTC |
| 1281bef | paulceli | 17 October 2019, 15:05:19 UTC | docs: fix code-example displayed path (#33228) PR Close #33228 | 17 October 2019, 18:06:41 UTC |
| 37cbcfa | Evan Martin | 04 October 2019, 17:44:11 UTC | fix(upgrade): remove unused version export (#33180) In some module systems (Closure), it's illegal to mutate an export. This mutated export isn't used anyway, so we can just remove it. PR Close #33180 | 16 October 2019, 20:39:12 UTC |
| ef0b8f4 | Mayur Barge | 15 October 2019, 19:10:54 UTC | docs: fix typo in getting started guide (#33185) Fixes #33181 PR Close #33185 | 16 October 2019, 14:23:03 UTC |
| 8bc2f06 | Miško Hevery | 15 October 2019, 22:15:08 UTC | release: cut the v8.2.11 release | 15 October 2019, 22:15:08 UTC |
| b71ccc2 | Jithil P Ponnan | 15 October 2019, 11:00:27 UTC | docs: fix JDK url (#33168) PR Close #33168 | 15 October 2019, 16:53:31 UTC |
| 2daa838 | Harinder Singh | 15 October 2019, 09:11:58 UTC | docs: Update link (#33166) Update multi-project workspace link weblink on the angular.io website was not working, therefore, updated the multi-project workspace link. PR Close #33166 | 15 October 2019, 16:52:31 UTC |
| a2716ac | Denis Omelkov | 14 October 2019, 14:41:35 UTC | fix(service-worker): continue serving api requests on cache failure (#33165) When responses are cached ok during sw initialization, but caching throws an error when handling api response, this response never gets to client. Fix response delivery by catching errors, add logging and 2 test cases. Same changes for master branch in PR #32996 Fixes #21412 PR Close #33165 | 15 October 2019, 16:51:16 UTC |
| 7a0cc53 | Denis Omelkov | 14 October 2019, 08:48:38 UTC | refactor(service-worker): make signatures of caching methods compatible (#32996) (#33165) Make safe caching and unsafe caching methods compatible so they can be swapped. Gives more flexibility when writing http response processing code. PR Close #32996 (cherry picked from commit 1353afc2b1155470a9402b48e9a8d185b7f6df5e) PR Close #33165 | 15 October 2019, 16:51:16 UTC |
| 5f52e63 | Alexander von Weiss | 14 October 2019, 15:28:57 UTC | docs: use neutral domain name in i18n example (#33146) PR Close #33146 | 15 October 2019, 16:50:02 UTC |
| 9409dce | Judy Bogart | 02 October 2019, 17:54:57 UTC | docs: correct matcher description (#32970) PR Close #32970 | 14 October 2019, 23:47:30 UTC |
| 2fa788c | Judy Bogart | 02 October 2019, 21:25:12 UTC | docs: clarify static router-outlet name attribute (#32973) PR Close #32973 | 14 October 2019, 23:47:02 UTC |
| 73e667f | Grigoriy Beziuk | 09 October 2019, 12:54:23 UTC | docs: a typo fixed in the upgrade guide (#33054) PR Close #33054 | 14 October 2019, 23:46:23 UTC |
| a7d5d33 | Judy Bogart | 08 October 2019, 16:49:33 UTC | docs: clarify http header api doc (#33038) PR Close #33038 | 14 October 2019, 23:45:46 UTC |
| 7e511e7 | Yulia Tsareva | 14 October 2019, 20:59:00 UTC | docs: fix typo in guide (#33155) PR Close #33155 | 14 October 2019, 23:43:30 UTC |
| 9e76a38 | Joey Perrott | 14 October 2019, 17:16:13 UTC | build: using the xlarge resource class for zonejs tests on CI (#33148) Fixes #33147 PR Close #33148 | 14 October 2019, 20:13:26 UTC |
| 2429819 | Harinder Singh | 22 September 2019, 04:48:08 UTC | docs: add command for creating angular workspace (#32804) Improved documentation Add command to create Angular workspace, it is required for executing `ng generate library <my-lib>` . PR Close #32804 | 14 October 2019, 16:32:47 UTC |
| 970df9e | Benjamin Liii | 14 June 2019, 05:19:28 UTC | docs: add note to build Angular locally (#31053) I got the compiled failed error when I followed the tutorial, which should be informed in advance as there are people who might not know the dependency in the package.json if they have no former relevant experience. PR Close #31053 | 14 October 2019, 16:31:53 UTC |
| 4c7e7fb | Ferdinand Malcher | 23 July 2019, 21:03:46 UTC | docs(router): Update description and example for Resolve interface (#31810) PR Close #31810 | 10 October 2019, 22:28:04 UTC |
| 5f78456 | FaustmannChr | 04 October 2019, 16:50:03 UTC | docs(common): Fixes typo (#33003) PR Close #33003 | 10 October 2019, 20:55:41 UTC |
| 36fd063 | Yulia Tsareva | 28 September 2019, 12:26:38 UTC | docs: fix typo in guide (#32893) PR Close #32893 | 10 October 2019, 20:54:59 UTC |
| c1b7f03 | John Ralph Umandal | 20 August 2019, 21:50:39 UTC | docs: changed 'function' word in to 'steps' (#32211) changed word for better method's interpretation. PR Close #32211 | 10 October 2019, 20:54:24 UTC |
| 882a9e3 | John Ralph Umandal | 20 August 2019, 10:34:54 UTC | docs: fixed a misleading sentence (#32211) Reading this sentence, make the reader think that the second argument strictly accepts one single animate, which is not PR Close #32211 | 10 October 2019, 20:54:24 UTC |
| 362b3e4 | Alex Rickabaugh | 09 October 2019, 20:55:51 UTC | release: cut the v8.2.10 release | 09 October 2019, 20:55:51 UTC |
| 2952ea5 | Danny Skoog | 06 October 2019, 21:09:45 UTC | docs: correct sentence in AoT compiler guide (#33020) PR Close #33020 | 07 October 2019, 20:13:58 UTC |
| 3541e59 | Koala | 13 September 2019, 12:45:13 UTC | docs: fix accessibility lint rules (#32661) Add and fix accessibility rules, bump codelyzer to support pseudo events for template-click-events-have-key-events rule. PR Close #32661 | 07 October 2019, 18:22:50 UTC |
| 8ef0ae3 | Santosh Yadav | 19 September 2019, 18:01:47 UTC | docs: add dotnettricks to training (#32771) PR Close #32771 | 07 October 2019, 18:03:04 UTC |
| c3ff66c | Atef Ben Ali | 14 June 2019, 06:35:09 UTC | docs: add missing parenthesis (#31041) PR Close #31041 | 07 October 2019, 18:02:34 UTC |
| a1d9848 | Santosh Yadav | 06 October 2019, 18:32:22 UTC | build(docs-infra): update in-memory-we-api and karma-jasmine-html-reporter version (#32892) The `karma-jasmine-html-reporter` update also includes a fix for taras42/karma-jasmine-html-reporter#31. Fixes #29802 PR Close #32892 | 07 October 2019, 17:51:20 UTC |
| a3482f7 | George Kalpakas | 02 October 2019, 13:10:42 UTC | refactor(forms): refactor `Validators.email()` regexp for easier comparison with WHATWG version (#32961) As mentioned in the previous commit, the regexp used by `Validators.email()` is a slightly enhanced version of the [WHATWG one](https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address). This commit refactors the regexp (without changing its behavior) to make it more closely match the format of WHATWG version, so that it is easier for people to compare it against the WHATWG one and understand the differences. The main changes were: - Changing the order of characters/character classes inside `[...]`; e.g. `[A-Za-z]` --> `[a-zA-Z]` - Mark all groups as non-capturing (since we do not use the captured values); e.g. `(foo)` --> `(?:foo)` (This could theoretically also have a positive performance impact, but I suspect JavaScript engines are already optimizing away capturing groups when they are not used.) PR Close #32961 | 07 October 2019, 17:51:01 UTC |
| 006af0b | George Kalpakas | 02 October 2019, 12:39:24 UTC | docs(forms): expand e-mail validation description (#32961) Previously, there was no documentation of what `Validators.email()` expects as a valid e-mail address, making it difficult for people to determine whether it covers their requirements or not. Even more so that the used pattern slightly deviates from the [WHATWG version](https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address). One's only option was to look at the source code and try to decipher the regexp pattern. This commit adds a high-level description of the validator and mentions its similarity to and differences from the WHATWG version. It also adds a brief explanation of the regexp's behavior and references for more information in the source code to provide more context to maintainers/users trying to understand the implementation in the future. Fixes #18985 Fixes #25186 Closes #32747 PR Close #32961 | 07 October 2019, 17:51:01 UTC |
| 9dc4815 | George Kalpakas | 04 October 2019, 13:02:04 UTC | ci: shorten the display name of `init_environment` steps that are shown in all jobs (#32998) The `init_environment` custom command is used in almost all other jobs. The this is implemented in CircleCI is that the steps of the command are inlined into the other jobs. Some of the `init_environment` commands are quite long and (since the default display name for a step is its command) they clutter the CircleCI UI. Additionally, multiple related commands are shown as separate steps, which makes it more difficult to get to the actual steps of a job. This commit improves this by: 1. Defining explicit, short names for steps with long commands. 2. Grouping multiple related steps into one. PR Close #32998 | 04 October 2019, 15:39:21 UTC |
| 4263d9e | Filipe Silva | 26 September 2019, 11:40:28 UTC | ci: refactor notification commands into a single parametrized one (#32745) (#32982) notify_caretaker_on_fail and notify_dev_infra_on_fail are the same, except for the url they notify. PR Close #32745 PR Close #32982 | 03 October 2019, 21:14:56 UTC |
| 30253a7 | Filipe Silva | 18 September 2019, 16:23:18 UTC | ci: use CircleCI parameterized jobs (#32745) (#32982) Parameterized jobs lets us reduce duplication of very similar jobs. See https://circleci.com/docs/2.0/reusing-config/#authoring-parameterized-jobs for more info. PR Close #32745 PR Close #32982 | 03 October 2019, 21:14:56 UTC |
| 16b83e8 | Filipe Silva | 18 September 2019, 15:22:50 UTC | ci: use CircleCI commands (#32745) (#32982) When we needed to run multiple commands in a reusable fashion, we needed to make a giant run block with multiple things inside. Using custom commands gives us a better way to do this. See https://circleci.com/docs/2.0/reusing-config/#authoring-reusable-commands for more info. PR Close #32745 PR Close #32982 | 03 October 2019, 21:14:55 UTC |
| e0c1063 | Filipe Silva | 18 September 2019, 14:25:23 UTC | ci: keep cache key fallback in a var (#32745) (#32982) This way it's right next to the original key and it's easier to keep them in sync. PR Close #32745 PR Close #32982 | 03 October 2019, 21:14:55 UTC |
| 686b621 | Filipe Silva | 18 September 2019, 14:23:29 UTC | ci: use CircleCI executors (#32745) (#32982) Executors let you define custom execution contexts for jobs. See https://circleci.com/docs/2.0/reusing-config/#authoring-reusable-executors for more information. PR Close #32745 PR Close #32982 | 03 October 2019, 21:14:55 UTC |
| dd2587d | Joey Perrott | 21 June 2019, 19:53:17 UTC | build: create script for setting up RBE in local dev environment (#31200) PR Close #31200 | 03 October 2019, 19:17:57 UTC |
| 2742649 | George Kalpakas | 03 October 2019, 16:28:56 UTC | docs(core): mark `EventEmitter#__isAsync` as internal to hide from API docs (#31378) The `__isAsync` property is not part of the public API and should not appear in the API docs. PR Close #31378 | 03 October 2019, 17:24:35 UTC |
| eb0461d | George Kalpakas | 01 July 2019, 22:02:56 UTC | fix(docs-infra): ignore `ng*Def` members in API docs (#31378) `ng*Def` properties (such as `ngInjectorDef`) are not considered part of the public API and should not appear in the API docs. This commit adds a filter to remove these properties from the docs metadata. PR Close #31378 | 03 October 2019, 17:24:35 UTC |
| e24393c | Alison Gale | 03 October 2019, 00:47:58 UTC | test(upgrade): add unit tests for AngularJSUrlCodec's parse method (#32976) Add unit test coverage for new logic added in #32874 and for existing logic that was untested. test(upgrade): add unit tests for AngularJSUrlCodec's parse method Add additional coverage and fix spacing test(upgrade): add unit tests for AngularJSUrlCodec's parse method Add unit test coverage for new logic added in #32874 and for existing logic that was untested. test(upgrade): add unit tests for AngularJSUrlCodec's parse method Add additional coverage and fix spacing test(upgrade): add unit tests for AngularJSUrlCodec's parse method Add unit test coverage for new logic added in #32874 and for existing logic that was untested. test(upgrade): add unit tests for AngularJSUrlCodec's parse method Add unit test coverage for new logic added in #32874 and for existing logic that was untested. test(upgrade): add unit tests for AngularJSUrlCodec's parse method Add additional coverage and fix spacing test(upgrade): add unit tests for AngularJSUrlCodec's parse method Add unit test coverage for new logic added in #32874 and for existing logic that was untested. PR Close #32976 | 03 October 2019, 16:55:27 UTC |
| 8237e95 | Showtim3 | 01 October 2019, 21:25:13 UTC | docs: fix typo in attribute-directives.md (#32943) Fixes #32924 PR Close #32943 | 02 October 2019, 21:30:51 UTC |
| 9ba898d | Kapunahele Wong | 02 October 2019, 19:41:09 UTC | docs: remove Renderer2 section (#32972) PR Close #32972 | 02 October 2019, 20:47:50 UTC |
| cd1b0c1 | Kapunahele Wong | 02 October 2019, 19:22:12 UTC | Revert "docs: move renderer2 deprecation guide into own file (#32626)" (#32972) This reverts commit 222af384629254b23937822fdb4214c4621f9ab8. PR Close #32972 | 02 October 2019, 20:47:50 UTC |
| 06072e0 | Kapunahele Wong | 02 October 2019, 19:21:59 UTC | Revert "docs: add undecorated classes migration faq (#32478)" (#32972) This reverts commit bd679581e2749dd9cfe26d44845002d125c9e4a5. PR Close #32972 | 02 October 2019, 20:47:49 UTC |
| 288e0ef | Kapunahele Wong | 02 October 2019, 19:21:08 UTC | Revert "docs: add dynamic queries flag migration documentation (#32582)" (#32972) This reverts commit 206fb8233045796fa16f16a2d6d82f368c2b0cfa. PR Close #32972 | 02 October 2019, 20:47:49 UTC |
| 88ad505 | Jakub Pawlot | 05 August 2019, 08:18:32 UTC | docs: add comment about newEvent utility function (#32001) PR Close #32001 | 02 October 2019, 20:28:39 UTC |
| 7e6644a | Kai Röder | 14 June 2019, 06:19:49 UTC | docs(docs-infra): use recommended type assertion (#31042) Angular uses tslint:recommended by default. The default for no-angle-bracket-type-assertion is true See https://github.com/palantir/tslint/blob/master/src/configs/recommended.ts#L69 PR Close #31042 | 02 October 2019, 20:25:40 UTC |
| d533d15 | Nikita Potapenko | 20 September 2019, 10:14:04 UTC | docs: add ngOnInit description (#32789) PR Close #32789 | 02 October 2019, 20:24:31 UTC |
| d0abf1b | Paul Gschwendtner | 02 October 2019, 10:26:55 UTC | refactor(bazel): ng_module action description should include compile mode (#32955) Similarly to `ts_library` compilation actions, the `ng_module` compile action should include the current compile mode in the action description. This makes it consistent with `ts_library` targets and also avoids confusion when both output flavors are requested. Currently when both output flavors are requested (e.g. in the `ng_package` rule), both devmode and prodmode compilations have the same action name. This is confusing and looks like the given target is built *twice* due to a bug (which is obviously not the case though) PR Close #32955 | 02 October 2019, 20:21:40 UTC |
