Skip to main content

Browse the archive

https://github.com/halide/Halide
19 April 2024, 08:20:39 UTC
sort by:
Revision Author Date Message Commit Date
c7cb4c4 Andrew Adams 12 March 2024, 19:44:58 UTC Add support for fcvtm/p, make scalars go through pattern matching too 12 March 2024, 19:44:58 UTC
210e5d7 Z Stern 06 March 2024, 00:29:14 UTC Don't try to run SVE2 code if vector_bits doesn't match host. 06 March 2024, 00:29:14 UTC
f84c764 Z Stern 06 March 2024, 00:22:58 UTC Merge branch 'arm_sve_redux' of https://github.com/halide/Halide into arm_sve_redux 06 March 2024, 00:22:58 UTC
a63439b Steven Johnson 05 March 2024, 19:32:02 UTC Remove try/catch block from simd-op-check-sve2 05 March 2024, 19:32:02 UTC
4324bc5 Steven Johnson 05 March 2024, 18:50:03 UTC Fix two clang-tidy warnings 05 March 2024, 18:50:03 UTC
2ac96c8 Steven Johnson 05 March 2024, 17:57:46 UTC Merge branch 'main' into arm_sve_redux 05 March 2024, 17:57:46 UTC
10e07e6 Zalman Stern 05 March 2024, 17:53:29 UTC Add class template type deduction guides to avoid CTAD warning. (#8135) * Add class template type dedeuction guides to avoid CTAD warning. * Formatting. 05 March 2024, 17:53:29 UTC
05ae15a Andrew Adams 05 March 2024, 17:50:19 UTC Make gpu thread and block for loop names opaque (#8133) This is one of our largest remaining type of magic name. These were explicitly constructed in lots of places and then explicitly checked for with ends_with in lots of places. This PR makes the names opaque. Only CanonicalizeGPUVars.cpp knows what they are, and they don't have to be a single fixed thing as long as they're consistent within a process. Also reduced the number of GPU dimensions to three more uniformly. We were already asserting this, but there was lots of dead code in lowering passes after gpu loop validation that allowed for four. Also fixed a bug I found in is_block_uniform. It didn't consider that the dependence on a gpu thread variable in a load index could be because a let variable encountered depends on a gpu thread variable. 05 March 2024, 17:50:19 UTC
d33ffa2 Andrew Adams 05 March 2024, 17:50:07 UTC Make realization order invariant to unique_name suffixes (#8124) * Make realization order invariant to unique_name suffixes * Add test * definition_order -> uint64 everywhere * Use visitation order instead of definition order --------- Co-authored-by: Steven Johnson <srj@google.com> 05 March 2024, 17:50:07 UTC
8b3312c Martijn Courteaux 05 March 2024, 16:16:06 UTC Add support for setting the default allocator and deallocator functions in Halide::Runtime::Buffer. (#8132) 05 March 2024, 16:16:06 UTC
eaed2ef Z Stern 05 March 2024, 02:15:45 UTC Merge branch 'arm_sve_redux' of https://github.com/halide/Halide into arm_sve_redux 05 March 2024, 02:15:45 UTC
7636c44 Andrew Adams 27 February 2024, 02:03:33 UTC Remove two dead vars from the Makefile (#8125) These appear to be unused 27 February 2024, 02:03:33 UTC
36d74a8 Andrew Adams 27 February 2024, 01:56:59 UTC Rewrite the skip stages lowering pass (#8115) * Avoid redundant scope lookups This pattern has been bugging me for a long time: ``` if (scope.contains(key)) { Foo f = scope.get(key); } ``` This redundantly looks up the key in the scope twice. I've finally gotten around to fixing it. I've introduced a find method that either returns a const pointer to the value, if it exists, or null. It also searches any containing scopes, which are held by const pointer, so the method has to return a const pointer. ``` if (const Foo *f = scope.find(key)) { } ``` For cases where you want to get and then mutate, I added shallow_find, which doesn't search enclosing scopes, but returns a mutable pointer. We were also doing redundant scope lookups in ScopedBinding. We stored the key in the helper object, and then did a pop on that key in the ScopedBinding destructor. This commit changes Scope so that Scope::push returns an opaque token that you can pass to Scope::pop to have it remove that element without doing a fresh lookup. ScopedBinding now uses this. Under the hood it's just an iterator on the underlying map (map iterators are not invalidated on inserting or removing other stuff). The net effect is to speed up local laplacian lowering by about 5% I also considered making it look more like an stl class, and having find return an iterator, but it doesn't really work. The iterator it returns might point to an entry in an enclosing scope, in which case you can't compare it to the .end() method of the scope you have. Scopes are different enough from maps that the interface really needs to be distinct. * Pacify clang-tidy * Fix unintentional mutation of interval in scope * Fix accidental Scope::get * Rewrite the skip stages lowering pass Skip stages was slow due to crappy computational complexity (quadratic?) I reworked it into a two-pass linear-time algorithm. The first part remembers which pieces of IR are actually relevant to the task, and the second pass performs the task using a bounds-inference-like algorithm. On main resnet50 spends 519 ms in this pass. This commit reduces it to 40 ms. Local laplacian with 100 pyramid levels spends 7.4 seconds in this pass. This commit reduces it to ~3 ms. This commit also moves the cache store for memoized Funcs into the produce node, instead of at the top of the consume node, because it naturally places it inside a condition you inject into the produce node. * clang-tidy fixes * Fix skip stages interaction with compute_with * Unify let visitors, and use fewer stack frames for them * Fix accidental leakage of .used into .loaded * Visit the bodies of uninteresting let chains * Another used -> loaded * Fix hoist_storage not handling condition correctly. --------- Co-authored-by: Steven Johnson <srj@google.com> 27 February 2024, 01:56:59 UTC
2b5beb3 Andrew Adams 27 February 2024, 01:11:47 UTC Fix hoist_storage not handling condition correctly. (#8123) The allocation condition wasn't getting relaxed over the scope and loop vars like the extents were. 27 February 2024, 01:11:47 UTC
aae84f6 Andrew Adams 26 February 2024, 17:56:17 UTC Use a caching version of stmt_uses_vars in TightenProducerConsumer nodes (#8102) We were making a very large number stmt_uses_vars queries that covered the same sub-stmts. I solved it by adding a cache. Speeds up local laplacian lowering by 10% by basically removing this pass from the profile. Also a drive-by typo fix in Lower.cpp 26 February 2024, 17:56:17 UTC
f8952c2 Andrew Adams 23 February 2024, 22:51:59 UTC Make a deep copy of each piece of test IR so that we can parallelize 23 February 2024, 22:51:59 UTC
b03b3c7 Steven Johnson 23 February 2024, 20:38:07 UTC Merge branch 'main' into arm_sve_redux 23 February 2024, 20:38:07 UTC
6afdcff Steven Johnson 23 February 2024, 20:36:59 UTC Update simd_op_check_sve2.cpp 23 February 2024, 20:36:59 UTC
4a269bd Z Stern 23 February 2024, 19:06:37 UTC Merge branch 'main' into arm_sve_redux 23 February 2024, 19:06:37 UTC
4399ed8 Zalman Stern 23 February 2024, 04:07:47 UTC Add Intel APX and AVX10 target flags and LLVM attribute setting. (#8052) * Add target flag and LLVM enables support for Intel AVX10. * Go ahead and add APX support as well. Correct spelling of APX target attributes. * Implement AVX10 and APX cpu feature detection. (As yet untested.) * Expand target feature flags for AVX10. --------- Co-authored-by: Steven Johnson <srj@google.com> 23 February 2024, 04:07:47 UTC
7627e0d Z Stern 22 February 2024, 21:19:25 UTC Merge branch 'main' into arm_sve_redux 22 February 2024, 21:19:25 UTC
57164df Andrew Adams 22 February 2024, 18:52:54 UTC Avoid redundant scope lookups (#8103) * Avoid redundant scope lookups This pattern has been bugging me for a long time: ``` if (scope.contains(key)) { Foo f = scope.get(key); } ``` This redundantly looks up the key in the scope twice. I've finally gotten around to fixing it. I've introduced a find method that either returns a const pointer to the value, if it exists, or null. It also searches any containing scopes, which are held by const pointer, so the method has to return a const pointer. ``` if (const Foo *f = scope.find(key)) { } ``` For cases where you want to get and then mutate, I added shallow_find, which doesn't search enclosing scopes, but returns a mutable pointer. We were also doing redundant scope lookups in ScopedBinding. We stored the key in the helper object, and then did a pop on that key in the ScopedBinding destructor. This commit changes Scope so that Scope::push returns an opaque token that you can pass to Scope::pop to have it remove that element without doing a fresh lookup. ScopedBinding now uses this. Under the hood it's just an iterator on the underlying map (map iterators are not invalidated on inserting or removing other stuff). The net effect is to speed up local laplacian lowering by about 5% I also considered making it look more like an stl class, and having find return an iterator, but it doesn't really work. The iterator it returns might point to an entry in an enclosing scope, in which case you can't compare it to the .end() method of the scope you have. Scopes are different enough from maps that the interface really needs to be distinct. 22 February 2024, 18:52:54 UTC
ef31bf9 Andrew Adams 22 February 2024, 17:13:43 UTC Do less redundant work in UnpackBuffers (#8104) We were redundantly creating a handle Variable every time we encountered something like foo.stride.0, instead of just the first time we encounter a Variable that refers to an input Parameter/Buffer. Speeds up this already-fast lowering pass by 10% or so. No measurable impact on total lowering time. 22 February 2024, 17:13:43 UTC
4613217 Andrew Adams 22 February 2024, 17:13:15 UTC Optionally print the time taken by each lowering pass (#8116) * Optionally print the time taken by each lowering pass I've been copy-pasting this from branch to branch, but I should just check it in. This is useful for performance optimization of the compiler itself. 22 February 2024, 17:13:15 UTC
dc3be8a Z Stern 22 February 2024, 02:03:10 UTC Add issues for TODOs. 22 February 2024, 02:03:10 UTC
fe30990 Z Stern 21 February 2024, 23:50:16 UTC Remove dubious looking FP to int code that was ifdef'ed out. Doesn't look like a TODO is needed anymore. 21 February 2024, 23:50:16 UTC
e25a947 Z Stern 21 February 2024, 01:57:10 UTC Merge branch 'main' into arm_sve_redux 21 February 2024, 01:57:10 UTC
c4d56c6 Tarushii Goel 19 February 2024, 22:46:15 UTC Small Tutorial Fix (#8111) * Update lesson_17_predicated_rdom.cpp * Update lesson_17_predicated_rdom.cpp 19 February 2024, 22:46:15 UTC
4fc1e57 Zalman Stern 16 February 2024, 21:58:23 UTC Fix an issue where the Halide compiler hits an internal error for bool types in widening intrinsics. (#8099) * Fix an issue where the Halide compiler hits an internal error when bool types are used with e.g. widening_mul. This situation did not arise from user code doing this directly, but rather through some chain o lowering with float16 types. The test cases added to correctness_intrinsics target the issue directly and do fail without the fix. I did not add broader coverage for bool types and intrinsics as it would require more thinking. Most of them overflow for the true/true case and thus are of questionable use, however widening operations cannot overflow... Certainly we could define the language to forbid this, but currently the frontend does not do so. As indicated above, the use case driving this was not using bool arithmetic to begin with. * Formatting. 16 February 2024, 21:58:23 UTC
d9668c5 Steven Johnson 15 February 2024, 17:57:16 UTC Fix clang-tidy error in runtime.printer.h (parameter shadows member) (#8074) 15 February 2024, 17:57:16 UTC
2855ca3 Andrew Adams 15 February 2024, 17:06:36 UTC Strip asserts right at the end of lowering (#8094) The simplifier exploits asserts to make simplification. When compiling with NoAsserts, certain assertions aren't ever introduced, which means that the simplifier can't exploit certain things that we know to be true. Mostly this has a negative effect on code size. E.g. tail cases get generated even though they are actually dead code. This PR keeps all the assertions right until the end of lowering, when it strips them in a dedicated pass. This reduces object file size for a large production blob of Halide code by ~10%, without measurably affecting runtime. 15 February 2024, 17:06:36 UTC
6e6e491 Z Stern 15 February 2024, 03:39:42 UTC Merge branch 'main' into arm_sve_redux 15 February 2024, 03:39:42 UTC
e6e1b6f Alex Reinking 15 February 2024, 01:58:55 UTC Ensure string(REPLACE) is called with the right number of arguments (#8097) 15 February 2024, 01:58:55 UTC
9a740b5 Derek Gerstmann 14 February 2024, 22:41:51 UTC [Vulkan] Region allocator fixes for memory requirements and allocations (#8087) * Add region allocator tests that check alignment, nearest_multiple and collect routines * Fix can_split() routine to use conformed sizes so that split allocation matches Fix region size accounting so that coalesce never has zero size regions to merge * Fix aligned_offset() routine to check for zero alignment (which means no constraint) * Fix ifdef for internal debugging * Clean up debug internal log messages * Use memory_requirements to determine nearest_multiple during initialization Query memory_requirements for each region, and reallocate if driver requires additional device memory * Formatting pass --------- Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com> 14 February 2024, 22:41:51 UTC
b582561 Andrew Adams 14 February 2024, 21:57:09 UTC Fix reduce_expr_modulo of vector in Solve.cpp (#8089) * Fix reduce_expr_modulo of vector in Solve.cpp * Fix test 14 February 2024, 21:57:09 UTC
f2d750f Roman Lebedev 14 February 2024, 20:35:52 UTC tests: correctness/float16_t: mark `__extendhfsf2` with default visibility (#8084) ``` [2336/4154] /usr/bin/clang++-17 -DHALIDE_ENABLE_RTTI -DHALIDE_VERSION_MAJOR=17 -DHALIDE_VERSION_MINOR=0 -DHALIDE_VERSION_PATCH=0 -DHALIDE_WITH_EXCEPTIONS -I/build/halide-17.0.0/test/common -I/build/halide-17.0.0/tools -I/build/halide-17.0.0/build/stage-1/halide/include -g -fdebug-default-version=4 -fprofile-use=/build/halide-17.0.0/build-profile/default.profdata -fcs-profile-generate -Xclang -mllvm -Xclang -vp-counters-per-site=100.0 -fuse-ld=lld-17 -Wl,--build-id=sha1 -std=c++17 -flto=thin -fPIE -fvisibility=hidden -fvisibility-inlines-hidden -Winvalid-pch -Xclang -include-pch -Xclang /build/halide-17.0.0/build/stage-1/halide/test/CMakeFiles/_test_internal.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /build/halide-17.0.0/build/stage-1/halide/test/CMakeFiles/_test_internal.dir/cmake_pch.hxx -MD -MT test/correctness/CMakeFiles/correctness_float16_t.dir/float16_t.cpp.o -MF test/correctness/CMakeFiles/correctness_float16_t.dir/float16_t.cpp.o.d -o test/correctness/CMakeFiles/correctness_float16_t.dir/float16_t.cpp.o -c /build/halide-17.0.0/test/correctness/float16_t.cpp <...> ld.lld-17: error: undefined hidden symbol: __extendhfsf2 >>> referenced by float16_t.cpp:391 (/build/halide-17.0.0/test/correctness/float16_t.cpp:391) >>> lto.tmp:(main) >>> did you mean: __extendbfsf2 >>> defined in: /lib/x86_64-linux-gnu/libgcc_s.so.1 clang++-17: error: linker command failed with exit code 1 (use -v to see invocation) ``` 14 February 2024, 20:35:52 UTC
40a622f Roman Lebedev 14 February 2024, 20:34:23 UTC clang does not support `_Float16` when targeting i386 (#8085) See https://github.com/halide/Halide/issues/7678 14 February 2024, 20:34:23 UTC
6edea16 Steven Johnson 14 February 2024, 20:26:27 UTC Allow disabling of mutlithreading in simd op check (#8096) simd_op_check_xtensa is not threadsafe at present 14 February 2024, 20:26:27 UTC
c8f43f3 Andrew Adams 13 February 2024, 21:47:19 UTC Parallelize some tests (#8078) * Parallelize some tests This reduces the time taken to run all correctness tests from 8:15 to 3:15 on my machine. * The FIXME is actually fine * Remove debug print * Fix when we're willing to run x86 code in simd_op_check * Use separate imageparams per task * Deep-copy the LoopLevels * Make float16_t neon op check test at least build * Revert accidental serialization * Throw return values from callable into the void We don't have a custom error handler in place, so they're always zero * Skip test under ASAN * Fix unintentional change to test 13 February 2024, 21:47:19 UTC
d8cfed6 Andrew Adams 13 February 2024, 21:47:09 UTC Forward the partition methods from generator outputs (#8090) 13 February 2024, 21:47:09 UTC
417d762 Z Stern 13 February 2024, 03:19:35 UTC Add issue for TODO. 13 February 2024, 03:19:35 UTC
b0e4f99 Z Stern 13 February 2024, 03:15:21 UTC Add issue for TODO. 13 February 2024, 03:15:21 UTC
c3ca689 Z Stern 13 February 2024, 03:14:19 UTC Remove TODOs that don't seem necessary. 13 February 2024, 03:14:19 UTC
79776e0 Z Stern 12 February 2024, 19:54:03 UTC Add issue to TODO comment. 12 February 2024, 19:54:03 UTC
ada6345 Andrew Adams 12 February 2024, 18:10:00 UTC Fix rfactor adding too many pure loops (#8086) When you rfactor an update definition, the new update definition must use all the pure vars of the Func, even though the one you're rfactoring may not have used them all. We also want to preserve any scheduling already done to the pure vars, so we want to preserve the dims list and splits list from the original definition. The code accounted for this by checking the dims list for any missing pure vars and adding them at the end (just before Var::outermost()), but this didn't account for the fact that they may no longer exist in the dims list due to splits that didn't reuse the outer name. In these circumstances we could end up with too many pure loops. E.g. if x has been split into xo and xi, then the code was adding a loop for x even though there were already loops for xo and xi, which of course produces garbage output. This PR instead just checks which pure vars are actually used in the update definition up front, and then uses that to tell which ones should be added. Fixes #7890 12 February 2024, 18:10:00 UTC
bc149bc Z Stern 12 February 2024, 17:50:04 UTC Add missed refactor change. 12 February 2024, 17:50:04 UTC
90186ad Z Stern 12 February 2024, 05:38:21 UTC Formatting. 12 February 2024, 05:38:21 UTC
42206a5 Z Stern 12 February 2024, 05:35:51 UTC Fix some TODOs in SVE code. Move utility function to Util.h and common code the other obvious use. 12 February 2024, 05:35:51 UTC
229bb60 Z Stern 11 February 2024, 23:02:32 UTC Fix missed conflict resolution. 11 February 2024, 23:02:32 UTC
00cb4ce Z Stern 11 February 2024, 23:02:01 UTC Merge branch 'main' into arm_sve_redux 11 February 2024, 23:02:01 UTC
9c3615b Andrew Adams 11 February 2024, 18:41:01 UTC Add checks to prevent people from using negative split factors (#8076) * Add checks to prevent people from using negative split factors Our analysis passes assume that loop maxes are greater than loop mins, so negative split factors cause sufficient havoc that not even output bounds queries are safe. These are therefore checked on pipeline entry. This is a new way for output bounds queries to throw errors (in addition to the buffer pointers themselves being null, and maybe some buffer constraints). Testing this, I realized these errors were getting thrown twice, because the output buffer bounds query in Pipeline::realize was built around two recursive calls to realize, and both were calling the custom error handler. In addition to reporting errors in this class twice, this implies several other inefficiencies, e.g. jit call args were being prepped twice. I reworked it to be built around two calls to call_jit_code instead. Fixes #7938 * Add test to cmakelists * Remove pointless target arg to call_jit_code It has to be the same as the cached target in the receiving object anyway 11 February 2024, 18:41:01 UTC
22581bf Steven Johnson 11 February 2024, 18:40:09 UTC Remove OpenGLCompute (#8077) * Remove OpenGLCompute This was supposed to be removed in Halide 17 (oops), removing for Halide 18 * Update dynamic_allocation_in_gpu_kernel.cpp * Update dynamic_allocation_in_gpu_kernel.cpp * Update halide_ir.fbs 11 February 2024, 18:40:09 UTC
ba934e9 Z Stern 11 February 2024, 07:13:47 UTC Address some review feedback. Mostly comment fixes. 11 February 2024, 07:13:47 UTC
93d7ba9 Z Stern 11 February 2024, 07:04:04 UTC REmove extraneous commented out line. 11 February 2024, 07:04:04 UTC
65fff76 Z Stern 11 February 2024, 06:28:07 UTC Merge branch 'arm_sve_redux' of https://github.com/halide/Halide into arm_sve_redux 11 February 2024, 06:28:07 UTC
bb73c00 Z Stern 11 February 2024, 06:27:04 UTC Fix confusion about Neon64/Neon128 and make it clear this is just the width multiplier applied to intrinsics. 11 February 2024, 06:27:04 UTC
a3baa5d James Price 09 February 2024, 18:39:21 UTC [WebGPU] Update to latest native headers (#8081) * [WebGPU] Update to latest native headers * Remove #ifdef for `requiredFeature[s]Count` * Pass nullptr to wgpuCreateInstance * Emscripten currently requires this * Dawn accepts it too * Use nullptr for another wgpuCreateInstance call 09 February 2024, 18:39:21 UTC
de8e39d Steven Johnson 09 February 2024, 16:55:00 UTC Bump serialization version to 18.0.0 (#8080) * Bump serialization version to 18.0.0 As a matter of policy, we should probably bump the version of the serialization format for every version of Halide -- even if changes are minimal-to-nonexistent -- to reinforce the fact that this isn't intended in any way as a long-term archival format. This PR suggests that we bump the major version to match the main Halide version, but I'm open for other suggestions. * Update halide_ir.fbs 09 February 2024, 16:55:00 UTC
c598c9d Z Stern 07 February 2024, 20:49:19 UTC Merge branch 'main' into arm_sve_redux 07 February 2024, 20:49:19 UTC
55dfa39 Zalman Stern 07 February 2024, 18:23:46 UTC Add an easy way to print vectors in debug output. (#8072) * Add helper to print containers, or at least vectors, in debug info. * Add documentation comments. * Formatting. * Name change. 07 February 2024, 18:23:46 UTC
39e5c08 Andrew Adams 07 February 2024, 17:49:06 UTC Better validation of gpu schedules (#8068) * Update makefile to use test/common/terminate_handler.cpp This means we actually print error messages when using exceptions and the makefile * Better validate of GPU schedules GPU loop constraints were checked in two different places. Checking them in ScheduleFunctions was incorrect because it didn't consider update definitions and specializations. Checking them in FuseGPUThreadLoops was too late, because the Var names have gone (they've been renamed to things like __thread_id_x). Furthermore, some problems were internal errors or runtime errors when they should have been user errors. We allowed 4d thread and block dimensions, but then hit an internal error. This PR centralizes checking of GPU loop structure in CanonicalizeGPUVars and adds more helpful error messages that print the problematic loop structure. E.g: ``` Error: GPU thread loop over f$8.s0.v0 is inside three other GPU thread loops. The maximum number of nested GPU thread loops is 3. The loop nest is: compute_at for g$8: for g$8.s0.v7: for g$8.s0.v6: for g$8.s0.v5: for g$8.s0.v4: gpu_block g$8.s0.v3: gpu_block g$8.s0.v2: gpu_thread g$8.s0.v1: gpu_thread g$8.s0.v0: store_at for f$8: compute_at for f$8: gpu_thread f$8.s0.v1: gpu_thread f$8.s0.v0: ``` Fixes the bug found in #7946 * Delete dead code * Actually clear the ostringstream 07 February 2024, 17:49:06 UTC
2bc10e3 Steven Johnson 07 February 2024, 17:44:57 UTC Merge branch 'main' into arm_sve_redux 07 February 2024, 17:44:57 UTC
37153a9 Derek Gerstmann 07 February 2024, 17:43:58 UTC Fix bool conversion bug in Vulkan code generator (#8067) * Fix bug in Vulkan code generator that was incorrectly passing the address of a byte vector, instead of its contents to builder.declare_constant() * Add bool_predicate_cast correctness test to verify bool conversion for Vulkan codegen works as expected --------- Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com> 07 February 2024, 17:43:58 UTC
78a0762 Prasoon Mishra 07 February 2024, 17:41:51 UTC Add hexagon_benchmarks app for CMake builds (#8069) * Add hexagon_benchmarks app for CMake builds * Removed unnecessary -lc++abi flag from GCC build 07 February 2024, 17:41:51 UTC
84fe565 Steven Johnson 07 February 2024, 17:41:21 UTC Outsmart the LLVM optimizer (#8073) The old definitions of bool_1, bool_2, bool_3 in simd_op_check_x86 (etc) all referred to the same entry in in_f32; as of https://github.com/llvm/llvm-project/pull/76367, the LLVM optimizer is smart enough to realize that (eg) bool1 != bool2 by construction, and optimizes away the code that tests their conditions, such as the one for andps and orps. Initing them from different locations is enough to outsmart the compiler. (bug was only noticed in the x86 test, but I updated the other tests to guard against future improvements there too.) 07 February 2024, 17:41:21 UTC
665804c Steven Johnson 06 February 2024, 23:34:29 UTC Don't require Halide_WebGPU when using wasm (#8063) (#8065) * Don't require Halide_WebGPU when using wasm (#8063) * trigger buildbots 06 February 2024, 23:34:29 UTC
93bff95 Teo 06 February 2024, 23:34:02 UTC add unsafe_promise_clamped (#8071) add unsafe_promise_clamp 06 February 2024, 23:34:02 UTC
9b2897c Z Stern 06 February 2024, 18:26:45 UTC Merge branch 'main' into arm_sve_redux 06 February 2024, 18:26:45 UTC
80e2081 Andrew Adams 05 February 2024, 22:25:05 UTC Update makefile to use test/common/terminate_handler.cpp (#8066) This means we actually print error messages when using exceptions and the makefile 05 February 2024, 22:25:05 UTC
e2448fe Andrew Adams 01 February 2024, 17:46:10 UTC Fix type error in VectorizeLoops (#8055) 01 February 2024, 17:46:10 UTC
de11e8f Z Stern 31 January 2024, 21:19:07 UTC Fix a degenerate case asking for zero sized vectors via a HAlide type with lanes of zero, which is not correct. 31 January 2024, 21:19:07 UTC
93fb752 Z Stern 30 January 2024, 21:44:37 UTC Limit SVE2 test to LLVM 19. Remove dead code. 30 January 2024, 21:44:37 UTC
1e8a540 Z Stern 29 January 2024, 22:47:53 UTC Formatting fix. 29 January 2024, 22:47:53 UTC
a069e6e Z Stern 29 January 2024, 22:45:12 UTC Formatting fixes. Replace internal_error with nop return for CodeGen_LLVM::match_vector_type_scalable called on scalar. 29 January 2024, 22:45:12 UTC
06fa66c Z Stern 29 January 2024, 22:23:03 UTC Merge branch 'main' into arm_sve_redux 29 January 2024, 22:23:03 UTC
da3c259 Z Stern 29 January 2024, 22:17:10 UTC Fix opcode recognition in test to handle some cases that show up. Change name of test class to avoid confusion. 29 January 2024, 22:17:10 UTC
47378ee Steven Johnson 29 January 2024, 01:28:13 UTC Enable `bugprone-switch-missing-default-case` (#8048) * Upgrade clang-format and clang-tidy to use LLVM 17 * trigger buildbots * trigger buildbots * trigger buildbots * trigger buildbots * Enable `bugprone-switch-missing-default-case` ...and fix existing warnings. * Update .clang-tidy * Update Parameter.cpp * Update .clang-tidy * Update .clang-tidy * Update .clang-tidy * Update .clang-tidy * Update CPlusPlusMangle.cpp 29 January 2024, 01:28:13 UTC
4b2d211 Steven Johnson 27 January 2024, 00:33:24 UTC Upgrade clang-format and clang-tidy to use LLVM 17 (#8042) * Upgrade clang-format and clang-tidy to use LLVM 17 * trigger buildbots * trigger buildbots * trigger buildbots * trigger buildbots 27 January 2024, 00:33:24 UTC
45d7850 Andrew Adams 26 January 2024, 20:01:41 UTC Track whether or not let expressions failed to solve in solver (#7982) * Track whether or not let expressions failed to solve in solver After mutating an expression, the solver needs to know two things: 1) Did the expression contain the variable we're solving for 2) Was the expression successfully "solved" for the variable. I.e. the variable only appears once in the leftmost position. We need to know this to know property 1 of any subexpressions (i.e. does the right child of the expression contain the variable). This drives what transformations we do in ways that are guaranteed to terminate and not take exponential time. We were tracking property 1 through lets but not property 2, and this meant we were doing unhelpful transformations in some cases. I found a case in the wild where this made a pipeline take > 1 hour to compile (I killed it after an hour). It may have been in an infinite transformation loop, or it might have just been exponential. Not sure. * Remove surplus comma * Fix use of uninitialized value that could cause bad transformation 26 January 2024, 20:01:41 UTC
f57f1d3 Z Stern 26 January 2024, 19:41:13 UTC Remove an unfavored implementation possibility. 26 January 2024, 19:41:13 UTC
5eeef77 Z Stern 26 January 2024, 19:38:55 UTC Checkpoint SVE2 work. Generally passes test, though using both NEON and SVE2 with simd_op_check_sve2 fails as both posibilities need to be allowed for 128-bit or smaller operations. 26 January 2024, 19:38:55 UTC
3657cf5 Andrew Adams 26 January 2024, 17:26:12 UTC Fix bounds_of_nested_lanes (#8039) * Fix bounds_of_nested_lanes bounds_of_nested_lanes assumed that one layer of nested vectorization could be removed at a time. When faced with the expression: min(ramp(x8(a), x8(b), 5), x40(27)) It panicked, because on the left hand side it reduced the bounds to x8(a) ... x8(a) + x8(b) * 4, and on the right hand side it reduced the bounds to 27. It then attempted to take a min of mismatched types. In general we can't assume that binary operators on nested vectors have the same nesting structure on both sides, so I just rewrote it to reduce directly to a scalar. Fixes #8038 26 January 2024, 17:26:12 UTC
4590a09 Andrew Adams 26 January 2024, 01:07:40 UTC Fix for llvm trunk: Force-include more runtime types (#8045) * Fix for llvm trunk: Force-include more runtime types * Include the force-include-types module first * Fix comment * Expand comment 26 January 2024, 01:07:40 UTC
c1923f3 Steven Johnson 24 January 2024, 23:53:28 UTC HALIDE_VERSION_MAJOR -> 18 (#8044) 24 January 2024, 23:53:28 UTC
6177e51 Steven Johnson 24 January 2024, 20:04:19 UTC Update Halide version to 18 (#8043) 24 January 2024, 20:04:19 UTC
9b9dfaf Andrew Adams 24 January 2024, 19:12:17 UTC Update Makefile for llvm 19 (#8040) 24 January 2024, 19:12:17 UTC
90e909d Steven Johnson 24 January 2024, 18:44:47 UTC Allow LLVM 19 in CMake (#8041) 24 January 2024, 18:44:47 UTC
e0e9f63 Steven Johnson 22 January 2024, 21:43:00 UTC Tweak the Printer code in runtime for smaller code (#8023) * Tweak the Printer code in runtime for smaller code TL;DR: template expansion meant that we had more replicated code than expected from the inline expansion of code in Printer and friends. Restructured and added NEVER_INLINE to try to make the call sites as small as possible. It's a modest code-size savings but nonzero... e.g., the linux-x86-64 .o output from correct_cross_compilation drops from 164280 bytes to 162936 bytes. * Update printer.h * debug * Update HalideTestHelpers.cmake * Update printer.h * fixes 22 January 2024, 21:43:00 UTC
1b8a75e Z Stern 19 January 2024, 20:50:02 UTC Ensure SVE intrinsics get vscale vectors and non-SVE ones get fixed vectors. Use proper prefix for neon intrinsics. Comment cleanups. 19 January 2024, 20:50:02 UTC
5f98675 Z Stern 18 January 2024, 17:33:05 UTC Remove an opportunity for RISC V codegen to change due to SVE2 support. 18 January 2024, 17:33:05 UTC
51c4568 Zalman Stern 18 January 2024, 02:29:55 UTC Merge branch 'main' into arm_sve_redux 18 January 2024, 02:29:55 UTC
deb5fbc Zalman Stern 18 January 2024, 02:19:47 UTC Checkpoint ARM SVE2 support. Passes correctness_simd_op_check_sve2 test at 128 and 256 bits. 18 January 2024, 02:19:47 UTC
22f9bb9 Steven Johnson 17 January 2024, 16:26:43 UTC Add test for #8029 (#8032) Tweak correctness_float16_t so that it uses one of the transcendal functions (sqrt) that were missing in Metal. 17 January 2024, 16:26:43 UTC
3a77204 Steven Johnson 17 January 2024, 15:35:07 UTC Require LLVM >= 16.0 (#8003) * Require LLVM >= 16.0 Per policy, we only support top-of-tree LLVM, plus two versions back; let's update to require LLVM >= 16, and drop workarounds for older versions. * LLVM_VERSION < 170 17 January 2024, 15:35:07 UTC
d2eed57 Steven Johnson 16 January 2024, 20:00:36 UTC Fix build breakage for wasm targets (#8031) Update HalideTestHelpers.cmake 16 January 2024, 20:00:36 UTC
8d3c12e Mike Woodworth 16 January 2024, 18:55:53 UTC adds mappings for f16 variants of halide float math (#8029) * adds mappings for f16 variants of halide float math * fix clang format errors * trigger buildbots --------- Co-authored-by: Steven Johnson <srj@google.com> 16 January 2024, 18:55:53 UTC
f40eeb5 Zalman Stern 09 January 2024, 06:50:46 UTC Merge branch 'main' into arm_sve_redux 09 January 2024, 06:50:46 UTC
91b063d Volodymyr Kysenko 09 January 2024, 04:57:15 UTC Stronger chain detection in LoopCarry pass (#8016) * Stronger chain detection in LoopCarry * Make sure that types are the same * Add a comment * Run CSE before calling can_prove * Test for loop carry * clang-tidy * Add missing override * Update comments 09 January 2024, 04:57:15 UTC
cdebeb8 Tom Westerhout 09 January 2024, 01:33:08 UTC Fix -Wstrict-prototype warnings in HalideRuntime.h (#8027) When HalideRuntime.h is included in a C file, funtions that are declared with `()` instead of `(void)` for their arguments change meaning. These may cause issues downstream because different code is generated. 09 January 2024, 01:33:08 UTC
21accad Steven Johnson 04 January 2024, 17:04:34 UTC Set warnings on tests as well as src (#8022) * Don't use variable-length arrays There was a rogue use of VLAs (an extension we don't want to use) in one of the runtime tests. Fixed the test. I'll follow up with a separate PR to ensure this warning is enabled everywhere to flush out other usages. * Set warnings on tests as well as src 04 January 2024, 17:04:34 UTC
back to top