Skip to main content

Browse the archive

https://github.com/apple/swift
06 April 2024, 01:41:40 UTC
sort by:
Revision Author Date Message Commit Date
267e463 Ben Langmuir 31 October 2019, 20:09:09 UTC [DO NOT MERGE] PR testing 31 October 2019, 20:09:09 UTC
64401ac Varun Gandhi 31 October 2019, 19:46:58 UTC [NFC] Replace StringMap<char, A> with StringSet<A> (#27986) 31 October 2019, 19:46:58 UTC
14107ac Nathan Hawes 31 October 2019, 19:34:36 UTC Merge pull request #27983 from nathawes/complete-self-dot-init-in-struct-initializer [code-completion] Suggest self.init in value type constructors 31 October 2019, 19:34:36 UTC
9794b70 Cyndy Ishida 31 October 2019, 19:25:06 UTC Merge pull request #27963 from cyndyishida/tapi_targets [TBDGen] support targets instead of arch&platform 31 October 2019, 19:25:06 UTC
82c2456 Pavel Yaskevich 31 October 2019, 18:57:03 UTC Merge pull request #27976 from xedin/extraneous-call [Diagnostics] Introduce extraneous call fix 31 October 2019, 18:57:03 UTC
16cff49 Hamish Knight 31 October 2019, 18:07:06 UTC [Sema] Requestify inheritsSuperclassInitializers (#27936) * [Sema] Factor out shouldAttemptInitializerSynthesis This makes sure we don't attempt to synthesize a memberwise or default initializer for an invalid decl, or one in a module interface. * [Sema] Requesify inheritsSuperclassInitializers This commit introduces a request for computing whether a class inherits both designated and convenience initializers from its superclass. The shared logic of finding initializers which the subclass hasn't overriden has been factored out into `collectNonOveriddenSuperclassInits`. * Cleanup addImplicitInheritedConstructorsToClass This commit removes some code that's no longer needed. In addition, now that we've requestified `inheritsSuperclassInitializers`, we can directly diagnose on non-inherited required convenience inits within the loop. * Inherited init synthesis no longer deals with clang decls Now that the computation of `inheritsSuperclassInitializers` has been split off into a request, we can avoid calling `addImplicitInheritedConstructorsToClass` for clang decls. * Address review feedback Continue to cache the InheritsSuperclassInits bit on the AST. 31 October 2019, 18:07:06 UTC
1a5a8dd Saleem Abdulrasool 31 October 2019, 17:46:15 UTC Merge pull request #27980 from drodriguez/windows-const-is-your-friend [Diagnostics] Use constant strings to avoid use after free. 31 October 2019, 17:46:15 UTC
d3461e1 Ben Langmuir 31 October 2019, 17:14:24 UTC Merge pull request #27966 from mikeash/fix-new-error-test-back-deployment [Test] Don't test _swift_willThrow on older runtimes. 31 October 2019, 17:14:24 UTC
6acf8db eeckstein 31 October 2019, 08:38:27 UTC Merge pull request #27956 from eeckstein/destroy-hoisting DestroyHoisting: support of abort_apply instruction. 31 October 2019, 08:38:27 UTC
406d03b David Smith 31 October 2019, 01:31:16 UTC Merge pull request #27974 from Catfish-Man/erroneous-errors Don't try to speculatively bridge tagged pointers to Errors 31 October 2019, 01:31:16 UTC
2696b96 swift-ci 31 October 2019, 01:09:37 UTC Merge pull request #27972 from gmittert/EndMySuffixing 31 October 2019, 01:09:37 UTC
1317db9 Nathan Hawes 31 October 2019, 00:41:34 UTC [code-completion] Suggest self.init(..) in value type constructors We missed these previously. 31 October 2019, 00:41:34 UTC
5e54eb1 Daniel Rodríguez Troitiño 31 October 2019, 00:03:21 UTC [Diagnostics] Use constant strings to avoid use after free. Using std::string in the function signature copies the constant string into a stack allocated copy, which is the one referenced by the StringRef that DiagnosticInfo stores. when the stack is abandoned, the string seems to be modificed in VC++, which makes the test fail in Windows. Using const char * in the signature avoids the std::string creation, and StringRef will refer to the static data instead. 31 October 2019, 00:03:21 UTC
d9ea4ec Robert Widmann 31 October 2019, 00:00:12 UTC Merge pull request #27969 from CodaFi/witless-witnesses [NFC] Strip Witness Matching of its TypeChecker 31 October 2019, 00:00:12 UTC
fb89229 Harlan Haskins 30 October 2019, 23:55:05 UTC Merge pull request #27970 from harlanhaskins/let-me-speak-to-your-mangler [TBDGen] Add the unmangled name to the IR-not-TBD diff list 30 October 2019, 23:55:05 UTC
1315207 Pavel Yaskevich 30 October 2019, 22:37:05 UTC [Diagnostics] Introduce extraneous call fix Detect and diagnose attempts to call variables and/or properties which don't have a function type, so can't really support invocation. 30 October 2019, 23:53:42 UTC
7b90628 Robert Widmann 30 October 2019, 23:31:26 UTC Merge pull request #27922 from CodaFi/bitflip isInvalid() Is Finally Semantic 30 October 2019, 23:31:26 UTC
acb5b57 David Smith 30 October 2019, 22:16:10 UTC Don't try to speculatively bridge tagged pointers to Errors 30 October 2019, 22:16:10 UTC
e3e4399 Robert Widmann 30 October 2019, 21:10:30 UTC [NFC] Strip witness checking of its type checker Push dependencies down to their use sites and downgrade the TypeCheckers in witness matching to ASTContexts. 30 October 2019, 22:10:34 UTC
3753a96 Robert Widmann 30 October 2019, 20:57:16 UTC Add CompareDeclSpecializationRequest 30 October 2019, 22:10:34 UTC
0267384 Robert Widmann 28 October 2019, 23:15:53 UTC Fixup SourceKit and Tests Patch up all the places that are making a syntactic judgement about the isInvalid() bit in a ValueDecl. They may continue to use that query, but most guard themselves on whether the interface type has been set. 30 October 2019, 22:09:14 UTC
efe877e Robert Widmann 28 October 2019, 18:41:13 UTC Remove unnecesary interface type resets Now that setInvalid() is a semantic property, drop the explicit calls to reset the interface type. It is already ErrorType. 30 October 2019, 22:09:14 UTC
db79d06 Robert Widmann 28 October 2019, 18:36:32 UTC Break a cycle 30 October 2019, 22:09:14 UTC
5a7040e Robert Widmann 22 October 2019, 01:11:54 UTC Remove PossiblyInvalidDecls 30 October 2019, 22:09:14 UTC
4996858 Robert Widmann 22 October 2019, 00:43:04 UTC Re-implement isInvalid for ValueDecls 30 October 2019, 22:09:14 UTC
41d099b Robert Widmann 21 October 2019, 22:55:55 UTC Remove the argument to setInvalid() 30 October 2019, 22:09:14 UTC
a5b8c64 Robert Widmann 30 October 2019, 22:08:45 UTC Merge pull request #27964 from CodaFi/is-this-a-dynamic-language [NFC] Squash Out Some More TypeChecker Dependencies 30 October 2019, 22:08:45 UTC
5c2185f Jordan Rose 30 October 2019, 21:49:11 UTC Merge pull request #27868 from owenv/diag-info-refactor [Diagnostics] Refactor DiagnosticConsumer interface to remove unnecessary params 30 October 2019, 21:49:11 UTC
c93146a Gwen Mittertreiner 30 October 2019, 21:49:03 UTC [cmake] Add executable suffix to test deps Windows tests were depending on bin\readelf instead of bin\readelf.exe causing ninja to fail the build. 30 October 2019, 21:49:03 UTC
7ca3876 Harlan Haskins 30 October 2019, 21:26:19 UTC [TBDGen] Add the unmangled name to the IR-not-TBD diff list In c94b952 I accidentally started adding StringRefs to an outer-scope vector from a local SmallString instead of the ones that lived in the IR module I was reading from. Instead, put the original symbol name from the IR instead of the "mangled" (leading _ variant) into the diff list. 30 October 2019, 21:26:19 UTC
4980bc7 Ben Langmuir 30 October 2019, 20:33:19 UTC Merge pull request #27948 from benlangmuir/racy-edit [edit] Fix racy access to SemanticInfo 30 October 2019, 20:33:19 UTC
3b8e7af Saleem Abdulrasool 30 October 2019, 20:20:17 UTC Merge pull request #27965 from drodriguez/trade-war Replace #import with #include to please VC++. 30 October 2019, 20:20:17 UTC
abc6db1 Robert Widmann 30 October 2019, 19:55:01 UTC Provide AST Context Getters To Protocol Inference 30 October 2019, 19:55:42 UTC
dd46c88 Robert Widmann 30 October 2019, 18:27:20 UTC Fixup calls to TypeChecker::checkGenericArguments 30 October 2019, 19:55:42 UTC
da95db4 Robert Widmann 30 October 2019, 18:23:26 UTC Make deriveProtocolRequirement a static utility 30 October 2019, 19:55:42 UTC
89b81a2 Robert Widmann 30 October 2019, 18:21:45 UTC Fixup calls to TypeChecker::lookupXXX 30 October 2019, 19:55:42 UTC
5ab6691 Robert Widmann 30 October 2019, 18:18:39 UTC Drop the TypeChecker in maybeDiagnoseClassWithoutInitializers 30 October 2019, 19:55:42 UTC
7993f2f Robert Widmann 30 October 2019, 18:15:59 UTC Downgrade the TypeChecker in DerivedConformance to an ASTContext 30 October 2019, 19:55:42 UTC
118f68b Robert Widmann 30 October 2019, 18:15:05 UTC Make getProtocol and getLiteralProtocol static utilities 30 October 2019, 19:55:42 UTC
929332e Robert Widmann 30 October 2019, 17:44:47 UTC Make isAvailabilitySafeForConformance a utility 30 October 2019, 19:55:42 UTC
972e755 Robert Widmann 30 October 2019, 17:28:55 UTC Give ConstraintSystem's outlet to the ASTContext Make it less tempting to ask for the type checker embedded into ConstraintSystem by using the accessor to the ASTContext. 30 October 2019, 19:55:42 UTC
da2b063 Robert Widmann 30 October 2019, 17:24:07 UTC Make calls to lookupMember actually look static 30 October 2019, 19:55:42 UTC
bcf03aa Robert Widmann 30 October 2019, 17:18:08 UTC Make getDeclTypeCheckingSemantics a utility 30 October 2019, 19:55:10 UTC
9742fef Saleem Abdulrasool 30 October 2019, 19:48:53 UTC Merge pull request #27957 from compnerd/build-is-not-path test: use `inferSwiftBinary` to find the reflection tool 30 October 2019, 19:48:53 UTC
2d73686 swift-ci 30 October 2019, 19:36:12 UTC Merge pull request #27962 from mikeash/isbackdeploying-fix 30 October 2019, 19:36:12 UTC
8afd60c Saleem Abdulrasool 30 October 2019, 19:20:12 UTC Merge pull request #27958 from apple/compnerd-windows-instructions Update WindowsBuild.md 30 October 2019, 19:20:12 UTC
07880d1 Dan Zheng 30 October 2019, 19:14:23 UTC [Docs] Differentiable programming manifesto. (#27034) 30 October 2019, 19:14:23 UTC
a2cf576 Mike Ash 30 October 2019, 19:07:37 UTC [Test] Don't test _swift_willThrow on older runtimes. rdar://problem/56752866 30 October 2019, 19:07:37 UTC
d9ca3be Hamish Knight 30 October 2019, 18:53:03 UTC Many Things Don't Need a TypeChecker Part 2 (#27946) Many Things Don't Need a TypeChecker Part 2 30 October 2019, 18:53:03 UTC
a5d3dda Mike Ash 30 October 2019, 18:51:54 UTC Merge pull request #27954 from mikeash/better-existential-metadata-dump [Runtime] Extend Metadata::dump for existential type metadata. 30 October 2019, 18:51:54 UTC
87da361 Daniel Rodríguez Troitiño 30 October 2019, 18:44:19 UTC Replace #import with #include to please VC++. VC++ chokes on the #import, and thinks we are trying to import libraries. Replace by #include, which should be more portable. 30 October 2019, 18:44:19 UTC
a6be16b Cyndy Ishida 30 October 2019, 18:05:51 UTC [TBDGen] support targets instead of arch&platform 30 October 2019, 18:05:51 UTC
ce11121 Mike Ash 30 October 2019, 17:41:57 UTC [Runtime] Fix guards around _swift_isBackDeploying call in SwiftObject.mm. This could fail to build due to BackDeployment.h not always being included in Config.h. Check an additional condition to ensure that this code is only active when BackDeployment.h is included. rdar://problem/56735154 30 October 2019, 17:48:30 UTC
33dfb94 Mishal Shah 30 October 2019, 16:34:11 UTC Merge pull request #27960 from apple/revert-27849-licm-load-store-hoisting Revert "LICM: add an optimization to move multiple loads and stores from/to the same memory location out of a loop." 30 October 2019, 16:34:11 UTC
7df5feb eeckstein 30 October 2019, 16:26:49 UTC Revert "LICM: add an optimization to move multiple loads and stores from/to the same memory location out of a loop." 30 October 2019, 16:26:49 UTC
5f50f67 Saleem Abdulrasool 30 October 2019, 16:04:13 UTC Update WindowsBuild.md - remove numbers on steps, they get out of sync and auto-numbering headers doesn't work - correct some header titles - re-render the tree to be ascii pretty - split out "one-time setup" from "getting started" - fix invocation of cmake for toolchain - fix libdispatch build rules - convert libdispatch build rules to be copy-paste friendly - add libdispatch test instructions 30 October 2019, 16:04:13 UTC
37bb356 Jordan Rose 30 October 2019, 16:02:12 UTC Merge pull request #27924 from jrose-apple/attribute-attribution [ClangImporter] Diagnose bad swift_name attributes better 30 October 2019, 16:02:12 UTC
6eb53a0 Saleem Abdulrasool 30 October 2019, 15:02:30 UTC test: use `inferSwiftBinary` to find the reflection tool We would previously search for it in the path rather than the build tree. This should identify where the tool is being used from, provide the just built tool, and still allow the user to change the tool path by an environment variable. 30 October 2019, 15:02:30 UTC
34ce9bd Hamish Knight 29 October 2019, 21:56:03 UTC checkReferencedGenericParams can be static 30 October 2019, 15:00:16 UTC
dd6847a Hamish Knight 29 October 2019, 21:51:08 UTC checkProtocolSelfRequirements can be static 30 October 2019, 15:00:16 UTC
7676eb0 Hamish Knight 29 October 2019, 21:47:29 UTC AttributeChecker doesn't need a TypeChecker 30 October 2019, 15:00:15 UTC
424112f Hamish Knight 29 October 2019, 21:02:23 UTC applyFunctionBuilderBodyTransform can be static 30 October 2019, 14:56:33 UTC
4fa8fb6 Hamish Knight 29 October 2019, 20:59:35 UTC substituteInputSugarTypeForResult can be static 30 October 2019, 14:56:32 UTC
642f58d Hamish Knight 29 October 2019, 20:53:05 UTC Make checkUnsupportedProtocolType a static member 30 October 2019, 14:56:32 UTC
5f3b1da Robert Widmann 30 October 2019, 14:47:17 UTC Merge pull request #27949 from CodaFi/protoplasmic-supine-jellies [NFC] Fold The Tri-State In Optional<ProtocolConformanceRef> 30 October 2019, 14:47:17 UTC
b5af722 Erik Eckstein 30 October 2019, 14:12:23 UTC DestroyHoisting: support of abort_apply instruction. This was missing from the previous commit. 30 October 2019, 14:12:23 UTC
7b650c5 Mike Ash 30 October 2019, 13:36:14 UTC [Runtime] Extend Metadata::dump for existential type metadata. Dump whether it's class bounded, the protocols it contains, and the superclass constraint if there is one. 30 October 2019, 13:36:14 UTC
eb8182b eeckstein 30 October 2019, 11:15:37 UTC Merge pull request #27849 from eeckstein/licm-load-store-hoisting LICM: add an optimization to move multiple loads and stores from/to the same memory location out of a loop. 30 October 2019, 11:15:37 UTC
61e1afd eeckstein 30 October 2019, 11:15:00 UTC Merge pull request #27926 from eeckstein/destroy-hoisting DestroyHoisting: support of begin_apply and end_apply instructions 30 October 2019, 11:15:00 UTC
dc716a2 David Zarzycki 30 October 2019, 10:34:51 UTC Merge pull request #27952 from davezarzycki/pr27952 Disable build system test that assumes standalone build 30 October 2019, 10:34:51 UTC
598a541 Michael Gottesman 30 October 2019, 06:01:55 UTC Merge pull request #27928 from gottesmm/pr-6389dd6f50f2b37f04a9b24d79436b133411accc [inlining] Fix two bugs around inlining of coroutines. 30 October 2019, 06:01:55 UTC
4097282 David Zarzycki 30 October 2019, 05:36:22 UTC Disable build system test that assumes standalone build 30 October 2019, 05:36:22 UTC
2534af7 swift-ci 30 October 2019, 04:48:50 UTC Merge pull request #27942 from ravikandhadai/oslog-append-interpolation-consteval-improved 30 October 2019, 04:48:50 UTC
861c0aa Ravi Kandhadai 29 October 2019, 02:11:55 UTC [OSLogOptimization][stdlib/private] Make string interpolation methods of OSLogMessage constant evaluable and remove @_transparent annotation from the methods. Also, improve diagnostics in the OSLogOptimization pass as now it rely on seeing the appendInterpolation/Literal calls. 30 October 2019, 02:35:37 UTC
312fefc Jordan Rose 29 October 2019, 23:58:49 UTC Merge pull request #27889 from jrose-apple/fire-water-air-metal-earth [docs] CToSwift: Add section on methods 29 October 2019, 23:58:49 UTC
e7006a9 Robert Widmann 29 October 2019, 23:37:39 UTC Clean up some trivially true condition clauses ProtocolConformanceRef::isConcrete checks the invalid bit for us. 29 October 2019, 23:56:22 UTC
4f84c2a Robert Widmann 29 October 2019, 23:35:10 UTC Use the default constructor to clean up some APIs Use ProtocolConformanceRef::forInvalid() in implementations only as a semantic signal. In one place, use the default constructor to drop the final use of Optional<ProtocolConformanceRef>. 29 October 2019, 23:56:22 UTC
b849e51 Robert Widmann 29 October 2019, 23:25:43 UTC Use operator bool to claw back some readability 29 October 2019, 23:56:21 UTC
37e82a6 Robert Widmann 29 October 2019, 22:57:42 UTC [NFC] getWitnessMethodConformanceOrNone -> getWitnessMethodConformanceOrInvalid 29 October 2019, 23:56:20 UTC
3e1a61f Robert Widmann 29 October 2019, 22:11:15 UTC [NFC] Fold The Tri-State In Optional<ProtocolConformanceRef> ProtocolConformanceRef already has an invalid state. Drop all of the uses of Optional<ProtocolConformanceRef> and just use ProtocolConformanceRef::forInvalid() to represent it. Mechanically translate all of the callers and callsites to use this new representation. 29 October 2019, 23:55:56 UTC
033be47 Varun Gandhi 29 October 2019, 23:50:45 UTC [NFC] Change ValueOwnershipKind::Any to ValueOwnershipKind::None in comments. (#27925) Follow-up to PR #27879. 29 October 2019, 23:50:45 UTC
c864eab Ben Langmuir 29 October 2019, 23:33:36 UTC [edit] Fix racy access to SemanticInfo Specifically, if the document was re-opened, we would drop the reference and the call to readSemanticInfo could use-after-free the array of diagnostics. This manifested as a very rare crash while testing sourcekit-lsp. 29 October 2019, 23:33:36 UTC
77135a9 Alex Hoppen 29 October 2019, 23:06:23 UTC Merge pull request #27934 from ahoppen/swiftsyntax-build-support Migrate building SwiftSyntax to swift_build_support 29 October 2019, 23:06:23 UTC
efa82fc Jordan Rose 29 October 2019, 22:54:28 UTC [test] Use new module cache; some diags only occur in module building 29 October 2019, 22:55:30 UTC
009b8f8 Jordan Rose 29 October 2019, 22:50:29 UTC [ClangImporter] "wrong args in swift_name" is also a framework bug ...so add the new note here too. 29 October 2019, 22:51:12 UTC
b7c4c51 Jordan Rose 29 October 2019, 22:38:53 UTC [ClangImporter] Simplify inferDefaultArgument by removing numParams (#27864) The only thing this was used for is to test if the total number of parameters was 1, in which case we did the same thing we did for a first parameter except in one very contrived case: a method with more than one parameter whose base name starts with "set" and whose first parameter is an NSZone. There are zero of these in the macOS or iOS SDKs, and probably even fewer in third-party code. 29 October 2019, 22:38:53 UTC
87eb38f Holly Borla 29 October 2019, 22:14:21 UTC Merge pull request #27938 from hborla/file-literal-test [Test] Add a regression test for invalid/empty file literals. 29 October 2019, 22:14:21 UTC
8a67117 Owen Voorhees 24 October 2019, 21:47:33 UTC [Diagnostics] Refactor DiagnosticConsumer interface DiagnosticInfo now holds all the information needed to consume a diagnostic, so remove unneeded parameters from handleDiagnostic. 29 October 2019, 20:52:12 UTC
55f9d2a Mike Ash 29 October 2019, 20:50:36 UTC Merge pull request #27863 from mikeash/will-throw-callback [Runtime] Add a function pointer for intercepting swift_willThrow calls. 29 October 2019, 20:50:36 UTC
13de788 Holly Borla 29 October 2019, 20:38:55 UTC [Test] Add a regression test for invalid/empty file literals. 29 October 2019, 20:38:55 UTC
dfd805f Saleem Abdulrasool 29 October 2019, 19:33:10 UTC Merge pull request #27931 from compnerd/vlant swift-stdlib-tool: avoid VLA usage 29 October 2019, 19:33:10 UTC
204829e swift-ci 29 October 2019, 18:46:32 UTC Merge pull request #27932 from CodaFi/a-designation-with-some-differences 29 October 2019, 18:46:32 UTC
8e56542 Saleem Abdulrasool 29 October 2019, 18:37:24 UTC Merge pull request #27927 from compnerd/swift-reflection-test-variant SwiftReflectionTest: enable builds on non-Apple targets 29 October 2019, 18:37:24 UTC
bc48004 Ravi Kandhadai 29 October 2019, 18:02:14 UTC Merge pull request #27876 from ravikandhadai/postdom-utility [SIL Optimization][CFGOptUtils.h] Remove completeJointPostDominanceSet utility function 29 October 2019, 18:02:14 UTC
932525d Alex Hoppen 25 October 2019, 18:57:37 UTC [gardening] Fix several python-lint warnings 29 October 2019, 17:40:20 UTC
fcd3457 Alex Hoppen 24 October 2019, 23:29:25 UTC [build-script] Migrate SwiftSyntax to swift_build_support 29 October 2019, 17:40:09 UTC
e95cc49 Robert Widmann 29 October 2019, 17:33:16 UTC Revert "Remove Some Users of -solver-enable-operator-designated-types" This reverts commit 46ae4757d255d6a0d924317cd6100689c62e3f0b. 29 October 2019, 17:33:16 UTC
15b8772 Saleem Abdulrasool 29 October 2019, 17:18:43 UTC swift-stdlib-tool: avoid VLA usage Replace the use of a VLA with a `std::vector`. This applies a RAII to the allocation, and the allocation is a single instance so the malloc traffic is not a concern. 29 October 2019, 17:18:43 UTC
ab72b99 Jordan Rose 29 October 2019, 16:58:16 UTC [docs] CToSwift: Tweak wording around "overrides" The previous wording referred to a method or property satisfying a protocol requirement as an "override", which both Clang and the Swift Clang Importer use internally sometimes. But most people who program Objective-C (or Swift) don't think of this as an override, so this document shouldn't use that language. (Thanks, Varun!) 29 October 2019, 16:58:16 UTC
5c05feb Mishal Shah 29 October 2019, 16:58:13 UTC Merge pull request #27930 from apple/revert-27871-swiftsyntax_build_support Revert "Migrate building SwiftSyntax to swift_build_support" 29 October 2019, 16:58:13 UTC
back to top