Skip to main content

Browse the archive

https://github.com/tendermint/tendermint
20 July 2024, 14:40:31 UTC
sort by:
Revision Author Date Message Commit Date
ccbeca7 Ethan Buchman 02 April 2019, 19:39:42 UTC scripts/txs/random.go 02 April 2019, 19:40:25 UTC
e4a03f2 Greg Szabo 01 April 2019, 18:18:18 UTC Release message changelog link fix (#3519) 01 April 2019, 18:18:18 UTC
56d8aa4 Ethan Buchman 01 April 2019, 18:17:58 UTC Merge pull request #3520 from tendermint/v0.31 Merge v0.31.2 release back to develop 01 April 2019, 18:17:58 UTC
79e9f20 Ismail Khoffi 01 April 2019, 15:58:28 UTC Merge pull request #3518 from tendermint/prepare-release-v0.31.2 Release v0.31.2 01 April 2019, 15:58:28 UTC
ab24925 Ismail Khoffi 01 April 2019, 10:32:37 UTC prepare changelog and bump versions to v0.31.2 01 April 2019, 15:49:34 UTC
0ae41cc Greg Szabo 01 April 2019, 15:47:00 UTC Fix for wrong version tag (#3517) * Fix for wrong version tag (tag on the release branch instead of master) 01 April 2019, 15:47:00 UTC
422d04c Ethan Buchman 31 March 2019, 11:14:18 UTC Bucky/mempool txsmap (#3512) * mempool: resCb -> globalCb * reqResCb takes an externalCb * failing test for #3509 * txsMap is sync.Map * update changelog 31 March 2019, 11:14:18 UTC
2233dd4 zjubfd 29 March 2019, 17:47:53 UTC libs: remove useless code in group (#3504) * lib: remove useless code in group * update change log * Update CHANGELOG_PENDING.md Co-Authored-By: guagualvcha <baifudong@lancai.cn> 29 March 2019, 17:47:53 UTC
9199f3f Greg Szabo 29 March 2019, 11:57:16 UTC Release management using CircleCI (#3498) * Release management using CircleCI * Changelog updated 29 March 2019, 11:57:16 UTC
6c1a4b5 Ismail Khoffi 28 March 2019, 16:39:09 UTC blockchain: comment out logger in test code that causes a race condition (#3500) 28 March 2019, 16:39:09 UTC
c7bb998 Ethan Buchman 28 March 2019, 12:07:59 UTC Merge pull request #3502 from tendermint/bucky/merge-master Bucky/merge master 28 March 2019, 12:07:59 UTC
7b72436 Ethan Buchman 28 March 2019, 12:12:05 UTC Merge branch 'master' into bucky/merge-master 28 March 2019, 12:12:05 UTC
a0234af Ethan Buchman 28 March 2019, 11:57:42 UTC Merge pull request #3489 from tendermint/release/v0.31.1 Release/v0.31.1 28 March 2019, 11:57:42 UTC
9390a81 Ethan Buchman 28 March 2019, 01:03:28 UTC minor changelog updates (#3499) 28 March 2019, 01:03:28 UTC
a49d80b Ismail Khoffi 27 March 2019, 18:12:01 UTC catch up with develop and rebase on current release to include #3482 27 March 2019, 22:14:57 UTC
ccfe75e Sean Braithwaite 27 March 2019, 17:51:57 UTC docs: Fix broken links (#3482) (#3488) * docs: fix broken links (#3482) A bunch of links were broken in the documentation s they included the `docs` prefix. * Update CHANGELOG_PENDING * docs: switch to relative links for github compatitibility (#3482) 27 March 2019, 22:14:57 UTC
d586945 Sean Braithwaite 27 March 2019, 17:51:57 UTC docs: Fix broken links (#3482) (#3488) * docs: fix broken links (#3482) A bunch of links were broken in the documentation s they included the `docs` prefix. * Update CHANGELOG_PENDING * docs: switch to relative links for github compatitibility (#3482) 27 March 2019, 17:51:57 UTC
ae88965 Ismail Khoffi 27 March 2019, 16:46:29 UTC changelog: add summary & fix link & add external contributor (#3490) 27 March 2019, 16:46:29 UTC
2338134 Ismail Khoffi 27 March 2019, 15:52:19 UTC bump versions 27 March 2019, 15:52:19 UTC
1b33a50 Ismail Khoffi 27 March 2019, 15:50:59 UTC Merge remote-tracking branch 'remotes/origin/develop' into release/v0.31.1 27 March 2019, 15:50:59 UTC
3c7bb6b Ismail Khoffi 27 March 2019, 15:48:00 UTC Add some numbers for #2778 27 March 2019, 15:50:42 UTC
5fa540b Anton Kaliaev 27 March 2019, 15:45:34 UTC mempool: add a safety check, write tests for mempoolIDs (#3487) * mempool: add a safety check, write tests for mempoolIDs and document 65536 limit in the mempool reactor spec follow-up to https://github.com/tendermint/tendermint/pull/2778 * rename the test * fixes after Ismail's review 27 March 2019, 15:45:34 UTC
5272786 Ismail Khoffi 27 March 2019, 15:07:03 UTC add external contributors 27 March 2019, 15:07:03 UTC
e3f840e Ismail Khoffi 27 March 2019, 15:04:43 UTC reset CHANGELOG_PENDING.md 27 March 2019, 15:04:43 UTC
ed63e1f Ismail Khoffi 27 March 2019, 15:03:25 UTC Add more entries to the Changelog, fix formatting, linkify 27 March 2019, 15:03:25 UTC
55b7118 Ismail Khoffi 27 March 2019, 14:35:32 UTC Prep changelog: copy from pending & update version 27 March 2019, 14:35:32 UTC
5a25b75 zjubfd 26 March 2019, 16:13:14 UTC p2p: refactor GetSelectionWithBias for addressbook (#3475) Why submit this pr: we have suffered from infinite loop in addrbook bug which takes us a long time to find out why process become a zombie peer. It have been fixed in #3232. But the ADDRS_LOOP is still there, risk of infinite loop is still exist. The algorithm that to random pick a bucket is not stable, which means the peer may unluckily always choose the wrong bucket for a long time, the time and cpu cost is meaningless. A simple improvement: shuffle bucketsNew and bucketsOld, and pick necessary number of address from them. A stable algorithm. 26 March 2019, 16:13:14 UTC
a4d9539 Anton Kaliaev 26 March 2019, 08:44:49 UTC rpc/client: include NetworkClient interface into Client interface (#3473) I think it's nice when the Client interface has all the methods. If someone does not need a particular method/set of methods, she can use individual interfaces (e.g. NetworkClient, MempoolClient) or write her own interface. technically breaking Fixes #3458 26 March 2019, 08:44:49 UTC
1bb8e02 HaoyangLiu 26 March 2019, 08:29:06 UTC mempool: fix broadcastTxRoutine leak (#3478) Refs #3306, irisnet@fdbb676 I ran an irishub validator. After the validator node ran several days, I dump the whole goroutine stack. I found that there were hundreds of broadcastTxRoutine. However, the connected peer quantity was less than 30. So I belive that there must be broadcastTxRoutine leakage issue. According to my analysis, I think the root cause of this issue locate in below code: select { case <-next.NextWaitChan(): // see the start of the for loop for nil check next = next.Next() case <-peer.Quit(): return case <-memR.Quit(): return } As we know, if multiple paths are avaliable in the same time, then a random path will be selected. Suppose that next.NextWaitChan() and peer.Quit() are both avaliable, and next.NextWaitChan() is chosen. // send memTx msg := &TxMessage{Tx: memTx.tx} success := peer.Send(MempoolChannel, cdc.MustMarshalBinaryBare(msg)) if !success { time.Sleep(peerCatchupSleepIntervalMS * time.Millisecond) continue } Then next will be non-empty and the peer send operation won't be success. As a result, this go routine will be track into infinite loop and won't be released. My proposal is to check peer.Quit() and memR.Quit() in every loop no matter whether next is nil. 26 March 2019, 08:29:06 UTC
6de7eff Dev Ojha 26 March 2019, 08:27:29 UTC mempool no gossip back (#2778) Closes #1798 This is done by making every mempool tx maintain a list of peers who its received the tx from. Instead of using the 20byte peer ID, it instead uses a local map from peerID to uint16 counter, so every peer adds 2 bytes. (Word aligned to probably make it 8 bytes) This also required resetting the callback function on every CheckTx. This likely has performance ramifications for instruction caching. The actual setting operation isn't costly with the removal of defers in this PR. * Make the mempool not gossip txs back to peers its received it from * Fix adversarial memleak * Don't break interface * Update changelog * Forgot to add a mtx * forgot a mutex * Update mempool/reactor.go Co-Authored-By: ValarDragon <ValarDragon@users.noreply.github.com> * Update mempool/mempool.go Co-Authored-By: ValarDragon <ValarDragon@users.noreply.github.com> * Use unknown peer ID Co-Authored-By: ValarDragon <ValarDragon@users.noreply.github.com> * fix compilation * use next wait chan logic when skipping * Minor fixes * Add TxInfo * Add reverse map * Make activeID's auto-reserve 0 * 0 -> UnknownPeerID Co-Authored-By: ValarDragon <ValarDragon@users.noreply.github.com> * Switch to making the normal case set a callback on the reqres object The recheck case is still done via the global callback, and stats are also set via global callback * fix merge conflict * Addres comments * Add cache tests * add cache tests * minor fixes * update metrics in reqResCb and reformat code * goimport -w mempool/reactor.go * mempool: update memTx senders I had to introduce txsMap for quick mempoolTx lookups. * change senders type from []uint16 to sync.Map Fixes DATA RACE: ``` Read at 0x00c0013fcd3a by goroutine 183: github.com/tendermint/tendermint/mempool.(*MempoolReactor).broadcastTxRoutine() /go/src/github.com/tendermint/tendermint/mempool/reactor.go:195 +0x3c7 Previous write at 0x00c0013fcd3a by D[2019-02-27|10:10:49.058] Read PacketMsg switch=3 peer=35bc1e3558c182927b31987eeff3feb3d58a0fc5@127.0.0.1 :46552 conn=MConn{pipe} packet="PacketMsg{30:2B06579D0A143EB78F3D3299DE8213A51D4E11FB05ACE4D6A14F T:1}" goroutine 190: github.com/tendermint/tendermint/mempool.(*Mempool).CheckTxWithInfo() /go/src/github.com/tendermint/tendermint/mempool/mempool.go:387 +0xdc1 github.com/tendermint/tendermint/mempool.(*MempoolReactor).Receive() /go/src/github.com/tendermint/tendermint/mempool/reactor.go:134 +0xb04 github.com/tendermint/tendermint/p2p.createMConnection.func1() /go/src/github.com/tendermint/tendermint/p2p/peer.go:374 +0x25b github.com/tendermint/tendermint/p2p/conn.(*MConnection).recvRoutine() /go/src/github.com/tendermint/tendermint/p2p/conn/connection.go:599 +0xcce Goroutine 183 (running) created at: D[2019-02-27|10:10:49.058] Send switch=2 peer=1efafad5443abeea4b7a8155218e4369525d987e@127.0.0.1:46193 channel=48 conn=MConn{pipe} m sgBytes=2B06579D0A146194480ADAE00C2836ED7125FEE65C1D9DD51049 github.com/tendermint/tendermint/mempool.(*MempoolReactor).AddPeer() /go/src/github.com/tendermint/tendermint/mempool/reactor.go:105 +0x1b1 github.com/tendermint/tendermint/p2p.(*Switch).startInitPeer() /go/src/github.com/tendermint/tendermint/p2p/switch.go:683 +0x13b github.com/tendermint/tendermint/p2p.(*Switch).addPeer() /go/src/github.com/tendermint/tendermint/p2p/switch.go:650 +0x585 github.com/tendermint/tendermint/p2p.(*Switch).addPeerWithConnection() /go/src/github.com/tendermint/tendermint/p2p/test_util.go:145 +0x939 github.com/tendermint/tendermint/p2p.Connect2Switches.func2() /go/src/github.com/tendermint/tendermint/p2p/test_util.go:109 +0x50 I[2019-02-27|10:10:49.058] Added good transaction validator=0 tx=43B4D1F0F03460BD262835C4AA560DB860CFBBE85BD02386D83DAC38C67B3AD7 res="&{CheckTx:gas_w anted:1 }" height=0 total=375 Goroutine 190 (running) created at: github.com/tendermint/tendermint/p2p/conn.(*MConnection).OnStart() /go/src/github.com/tendermint/tendermint/p2p/conn/connection.go:210 +0x313 github.com/tendermint/tendermint/libs/common.(*BaseService).Start() /go/src/github.com/tendermint/tendermint/libs/common/service.go:139 +0x4df github.com/tendermint/tendermint/p2p.(*peer).OnStart() /go/src/github.com/tendermint/tendermint/p2p/peer.go:179 +0x56 github.com/tendermint/tendermint/libs/common.(*BaseService).Start() /go/src/github.com/tendermint/tendermint/libs/common/service.go:139 +0x4df github.com/tendermint/tendermint/p2p.(*peer).Start() <autogenerated>:1 +0x43 github.com/tendermint/tendermint/p2p.(*Switch).startInitPeer() ``` * explain the choice of a map DS for senders * extract ids pool/mapper to a separate struct * fix literal copies lock value from senders: sync.Map contains sync.Mutex * use sync.Map#LoadOrStore instead of Load * fixes after Ismail's review * rename resCbNormal to resCbFirstTime 26 March 2019, 08:27:29 UTC
25a3c8b zjubfd 23 March 2019, 17:08:15 UTC rpc: support tls rpc (#3469) Refs #3419 23 March 2019, 17:08:15 UTC
85be2a5 Thane Thomson 22 March 2019, 13:16:38 UTC tools/tm-signer-harness: update height and round for test harness (#3466) In order to re-enable the test harness for the KMS (see tendermint/kms#227), we need some marginally more realistic proposals and votes. This is because the KMS does some additional sanity checks now to ensure the height and round are increasing over time. 22 March 2019, 13:16:38 UTC
1d4afb1 Anton Kaliaev 21 March 2019, 10:05:39 UTC replace PB2TM.ConsensusParams with a call to params#Update (#3448) Fixes #3444 21 March 2019, 10:05:39 UTC
660bd4a tracebundy 20 March 2019, 12:30:49 UTC fix comment (#3454) 20 March 2019, 12:30:49 UTC
81b9bdf Ethan Buchman 20 March 2019, 12:29:40 UTC comments on validator ordering (#3452) * comments on validator ordering * NextValidatorsHash 20 March 2019, 12:29:40 UTC
926127c Anton Kaliaev 20 March 2019, 00:59:33 UTC blockchain: update the maxHeight when a peer is removed (#3350) * blockchain: update the maxHeight when a peer is removed Refs #2699 * add a changelog entry * make linter pass 20 March 2019, 00:59:33 UTC
03085c2 zjubfd 20 March 2019, 00:18:18 UTC rpc: client disable compression (#3430) 20 March 2019, 00:18:18 UTC
7af4b50 Anton Kaliaev 20 March 2019, 00:10:54 UTC Remove RepeatTimer and refactor Switch#Broadcast (#3429) * p2p: refactor Switch#Broadcast func - call wg.Add only once - do not call peers.List twice! * bad for perfomance * peers list can change in between calls! Refs #3306 * p2p: use time.Ticker instead of RepeatTimer no need in RepeatTimer since we don't Reset them Refs #3306 * libs/common: remove RepeatTimer (also TimerMaker and Ticker interface) "ancient code that’s caused no end of trouble" Ethan I believe there's much simplier way to write a ticker than can be reset https://medium.com/@arpith/resetting-a-ticker-in-go-63858a2c17ec 20 March 2019, 00:10:54 UTC
60b2ae5 needkane 20 March 2019, 00:00:53 UTC crypto: delete unused code (#3426) 20 March 2019, 00:00:53 UTC
a6349f5 Anca Zamfir 19 March 2019, 23:56:13 UTC Formalize proposer election algorithm properties (#3140) * Update proposer-selection.md * Fixed typos * fixed typos * Attempt to address some comments * Update proposer-selection.md * Update proposer-selection.md * Update proposer-selection.md Added the normalization step. * Addressed review comments * New example for normalization section Added a new example to better show the need for normalization Added requirement for changing validator set Addressed review comments * Fixed problem with R2 * fixed the math for new validator * test * more small updates * Moved the centering above the round-robin election - the centering is now done before the actual round-robin block - updated examples - cleanup * change to reflect new implementation for new validator 19 March 2019, 23:56:13 UTC
22bcfca Ethan Buchman 19 March 2019, 23:54:09 UTC Merge pull request #3450 from tendermint/master Merge master back to develop 19 March 2019, 23:54:09 UTC
0d985ed Ethan Buchman 19 March 2019, 23:53:37 UTC Merge pull request #3417 from tendermint/release/v0.31.0 Release/v0.31.0 19 March 2019, 23:53:37 UTC
1e34697 Ismail Khoffi 19 March 2019, 23:45:51 UTC Ensure WriteTimeout > TimeoutBroadcastTxCommit (#3443) * Make sure config.TimeoutBroadcastTxCommit < rpcserver.WriteTimeout() * remove redundant comment * libs/rpc/http_server: move Read/WriteTimeout into Config * increase defaults for read/write timeouts Based on this article https://www.digitalocean.com/community/tutorials/how-to-optimize-nginx-configuration * WriteTimeout should be larger than TimeoutBroadcastTxCommit * set a deadline for subscribing to txs * extract duration into const * add two changelog entries * Update CHANGELOG_PENDING.md Co-Authored-By: melekes <anton.kalyaev@gmail.com> * Update CHANGELOG_PENDING.md Co-Authored-By: melekes <anton.kalyaev@gmail.com> * 12 -> 10 * changelog * changelog 19 March 2019, 23:45:51 UTC
5f68fba Ethan Buchman 19 March 2019, 23:25:26 UTC Merge pull request #3449 from tendermint/ismail/merge_develop_into_release/0.31.0 Merge develop into release/0.31.0 19 March 2019, 23:25:26 UTC
e276f35 Ismail Khoffi 19 March 2019, 13:36:42 UTC remove 3421 from changelog 19 March 2019, 13:36:42 UTC
8e62a3d Ismail Khoffi 19 March 2019, 11:19:02 UTC Add #3421 to changelog and reorder alphabetically 19 March 2019, 11:19:02 UTC
48aacca Ismail Khoffi 19 March 2019, 11:09:26 UTC Merge in develop and update CHANGELOG.md 19 March 2019, 11:09:26 UTC
4162ebe Anton Kaliaev 19 March 2019, 07:38:32 UTC types: refactor PB2TM.ConsensusParams to take BlockTimeIota as an arg (#3442) See https://github.com/tendermint/tendermint/pull/3403/files#r266208947 In #3403 we unexposed BlockTimeIota from the ABCI, but it's still part of the ConsensusParams struct, so we have to remember to add it back after calling PB2TM.ConsensusParams. Instead, PB2TM.ConsensusParams should take it as an argument Fixes #3432 19 March 2019, 07:38:32 UTC
551b632 Ethan Buchman 16 March 2019, 23:24:12 UTC Update v0.31.0 release notes (#3434) * changelog: fix formatting * update release notes * update changelog * linkify * update UPGRADING 16 March 2019, 23:24:12 UTC
52c4e15 Ismail Khoffi 14 March 2019, 15:07:06 UTC changelog: more review fixes/release/v0.31.0 (#3427) * Update release summary * Add pubsub config changes * Add link to issue for pubsub changes 14 March 2019, 15:07:06 UTC
5483ac6 Ismail Khoffi 14 March 2019, 11:17:49 UTC minor changes / fixes to release 0.31.0 (#3422) * bump ABCIVersion due to renaming BlockSizeParams -> BlockParams (https://github.com/tendermint/tendermint/pull/3417#discussion_r264974791) * Move changelog on consensus params entry to breaking * Add @melekes' suggestion for breaking change in pubsub into upgrading.md * Add changelog entry for #3351 * Add changelog entry for #3358 & #3359 * Add changelog entry for #3397 * remove changelog entry for #3397 (was already released in 0.30.2) * move 3351 to improvements * Update changelog comment 14 March 2019, 11:17:49 UTC
7457133 Anton Kaliaev 14 March 2019, 11:00:58 UTC grpcdb: close Iterator/ReverseIterator after use (#3424) Fixes #3402 14 March 2019, 11:00:58 UTC
a59930a Anton Kaliaev 13 March 2019, 12:09:05 UTC localnet: fix $LOG variable (#3423) Fixes #3421 Before: it was creating a file named ${LOG:-tendermint.log} in .build/nodeX After: it creates a file named tendermint.log 13 March 2019, 12:09:05 UTC
85c023d Ismail Khoffi 12 March 2019, 19:07:26 UTC Prep release v0.31.0: - update changelog, reset pending - bump versions - add external contributors (partly manually) 12 March 2019, 19:07:26 UTC
4cbd36f Anton Kaliaev 12 March 2019, 17:22:03 UTC Merge pull request #3415 from tendermint/master Merge master back to develop (do not squash) 12 March 2019, 17:22:03 UTC
e42f833 Anton Kaliaev 12 March 2019, 12:20:59 UTC Merge master back to develop (#3412) * libs/db: close batch (#3397) ClevelDB requires closing when WriteBatch is no longer needed, https://godoc.org/github.com/jmhodges/levigo#WriteBatch.Close Fixes the memory leak in https://github.com/cosmos/cosmos-sdk/issues/3842 * update changelog and bump version to 0.30.2 12 March 2019, 12:20:59 UTC
ad3e990 Anton Kaliaev 11 March 2019, 19:59:00 UTC fix GO_VERSION in installation scripts (#3411) there is no such file https://storage.googleapis.com/golang/go1.12.0.linux-amd64.tar.gz Fixes #3405 11 March 2019, 19:59:00 UTC
676212f srmo 11 March 2019, 19:06:03 UTC cmd: make sure to have 'testnet' create the data directory for nonvals (#3409) Fixes #3408 11 March 2019, 19:06:03 UTC
3035572 Anton Kaliaev 11 March 2019, 18:52:09 UTC cs: comment out log.Error to avoid TestReactorValidatorSetChanges timing out (#3401) 11 March 2019, 18:52:09 UTC
d741c7b Anton Kaliaev 11 March 2019, 18:45:58 UTC limit number of /subscribe clients and queries per client (#3269) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com> 11 March 2019, 18:45:58 UTC
15f6211 Anton Kaliaev 11 March 2019, 18:21:17 UTC remove TimeIotaMs from ABCI consensus params (#3403) Also - init substructures to avoid panic in pb2tm.ConsensusParams Before: if csp.Block is nil and we later try to access/write to it, we'll panic. After: if csp.Block is nil and we later try to access/write to it, there'll be no panic. 11 March 2019, 18:21:17 UTC
dc359bd Anca Zamfir 11 March 2019, 14:17:25 UTC types: remove check for priority order of existing validators (#3407) When scaling and averaging is invoked, it is possible to have validators with close priorities ending up with same priority. With the current code, this makes it impossible to verify the priority orders before and after updates. Fixes #3383 11 March 2019, 14:17:25 UTC
9768195 Ethan Buchman 11 March 2019, 12:17:14 UTC Merge pull request #3399 from tendermint/release/v0.30.2 Release/v0.30.2 11 March 2019, 12:17:14 UTC
100ff08 Anton Kaliaev 11 March 2019, 11:31:53 UTC p2p: do not panic when filter times out (#3384) Fixes #3369 11 March 2019, 11:31:53 UTC
f996b10 Anton Kaliaev 10 March 2019, 09:06:34 UTC update changelog and bump version to 0.30.2 10 March 2019, 09:06:34 UTC
36d7180 Yumin Xia 10 March 2019, 08:46:32 UTC libs/db: close batch (#3397) ClevelDB requires closing when WriteBatch is no longer needed, https://godoc.org/github.com/jmhodges/levigo#WriteBatch.Close Fixes the memory leak in https://github.com/cosmos/cosmos-sdk/issues/3842 10 March 2019, 08:56:04 UTC
b021f1e Yumin Xia 10 March 2019, 08:46:32 UTC libs/db: close batch (#3397) ClevelDB requires closing when WriteBatch is no longer needed, https://godoc.org/github.com/jmhodges/levigo#WriteBatch.Close Fixes the memory leak in https://github.com/cosmos/cosmos-sdk/issues/3842 10 March 2019, 08:46:32 UTC
9079426 mircea-c 09 March 2019, 15:13:36 UTC circleci: removed complexity from docs deployment job (#3396) 09 March 2019, 15:13:36 UTC
b6a510a Anton Kaliaev 08 March 2019, 05:46:09 UTC make ineffassign linter pass (#3386) Refs #3262 This fixes two small bugs: 1) lite/dbprovider: return `ok` instead of true in parse* functions. It's weird that we're ignoring `ok` value before. 2) consensus/state: previously because of the shadowing we almost never output "Error with msg". Now we declare both `added` and `err` in the beginning of the function, so there's no shadowing. 08 March 2019, 05:46:09 UTC
e415c32 Ismail Khoffi 08 March 2019, 05:40:59 UTC update golang.org/x/crypto (#3392) Update Gopkg.lock via dep ensure --update golang.org/x/crypto see #3391 (comment) (nothing to review here really). 08 March 2019, 05:40:59 UTC
28e9e9e Ismail Khoffi 07 March 2019, 16:03:57 UTC update levigo to 1.0.0 (#3389) Although the version we were pinning to is from Nov. 2016 there were no substantial changes: jmhodges/levigo@2b8c778 added go-modules support (no code changes) jmhodges/levigo@853d788 added a badge to the readme closes #3381 07 March 2019, 16:03:57 UTC
3ebfa99 Anton Kaliaev 07 March 2019, 15:35:04 UTC do not pin repos without releases to exact revisions (#3382) We're pinning repos without releases because it's very easy to upgrade all the dependencies by executing dep ensure --upgrade. Instead, we should just never run this command directly, only dep ensure --upgrade <some repo>. And we can defend that in PRs. Refs #3374 The problem with pinning to exact revisions: people who import Tendermint as a library (e.g. abci/types) are stuck with these revisions even though the code they import may not even use them. 07 March 2019, 15:35:04 UTC
91b488f YOSHIDA Masanori 07 March 2019, 13:02:13 UTC docs: fix the reverse of meaning in spec (#3387) https://tools.ietf.org/html/rfc6962#section-2.1 "The largest power of two less than the number of items" is actually correct! For n > 1, let k be the largest power of two smaller than n (i.e., k < n <= 2k). 07 March 2019, 13:02:13 UTC
f25d727 Anton Kaliaev 07 March 2019, 05:10:34 UTC make dupl linter pass (#3385) Refs #3262 07 March 2019, 05:10:34 UTC
411bc5e Anca Zamfir 06 March 2019, 08:54:49 UTC types: followup after validator set changes (#3301) * fix failure in TestProposerFrequency * Add test to check priority order after updates * Changed applyRemovals() and removed Remove() Changed applyRemovals() similar to applyUpdates() Removed function Remove() Updated comments * review comments * simplify applyRemovals and add more comments * small correction in comment * Fix check in test * Fix priority check for centering, address review comments * fix assert for priority centering * review comments * review comments * cleanup and review comments added upper limit check for validator voting power moved check for empty validator set earlier moved panic on potential negative set length in verifyRemovals added more tests * review comments 06 March 2019, 08:54:49 UTC
858875f Silas Davis 06 March 2019, 08:22:35 UTC Copy secp256k1 code from go-ethereum to avoid GPL vendoring issues in (#3371) downstream Signed-off-by: Silas Davis <silas@monax.io> 06 March 2019, 08:22:35 UTC
1eaa42c Ismail Khoffi 05 March 2019, 07:08:52 UTC golang 1.12.0 (#3376) - update docker image on circleci - remove GOCACHE=off from Makefile (see: https://tip.golang.org/doc/go1.12#gocache) - update badge in readme - update in scripts/install - update Vagrantfile - update in networks/remote/integration.sh - tools/build/Makefile 05 March 2019, 07:08:52 UTC
8c9df30 Jack Zampolin 05 March 2019, 06:56:46 UTC libs/db: Add cleveldb.Stats() (#3379) Fixes: #3378 * Add stats to cleveldb implementation * update changelog * remote TODO also - sort keys - preallocate memory * fix const initializer []string literal is not a constant * add test 05 March 2019, 06:56:46 UTC
52771e1 Anton Kaliaev 04 March 2019, 09:24:44 UTC make BlockTimeIota a consensus parameter, not a locally configurable … (#3048) * make BlockTimeIota a consensus parameter, not a locally configurable option Refs #2920 * make TimeIota int64 ms Refs #2920 * update Gopkg.toml * fixes after Ethan's review * fix TestRemoteSignerProposalSigningFailed * update changelog 04 March 2019, 09:24:44 UTC
f39138a Anton Kaliaev 04 March 2019, 08:18:32 UTC remove RoundState from EventDataRoundState (#3354) Before we're using it to get a round state in tests. Now it can be done by calling csX.GetRoundState. We will need to rewrite TestStateSlashingPrevotes and TestStateSlashingPrecommits, which are commented right now, to not rely on EventDataRoundState#RoundState field. Refs #1527 04 March 2019, 08:18:32 UTC
8a962ff Anton Kaliaev 04 March 2019, 08:17:38 UTC deps: update gogo/protobuf from 1.1.1 to 1.2.1 and golang/protobuf from 1.1.0 to 1.3.0 (#3357) * deps: update gogo/proto from 1.1.1 to 1.2.1 - verified changes manually git diff 636bf030~ ba06b47c --stat -- ':!*.pb.go' ':!test' * deps: update golang/protobuf from 1.1.0 to 1.3.0 - verified changes manually git diff b4deda0~ c823c79 -- ':!*.pb.go' ':!test' 04 March 2019, 08:17:38 UTC
3421e4d zjubfd 02 March 2019, 21:36:52 UTC make lightd availbe (#3364) 1."abci_query": rpcserver.NewRPCFunc(c.ABCIQuery, "path,data,prove") "validators": rpcserver.NewRPCFunc(c.Validators, "height"), the parameters and function do not match, cause index out of range error. 2. the prove of query is forced to be true, while default option is false. 3. fix the wrong key of merkle 02 March 2019, 21:36:52 UTC
976b1c2 zjubfd 02 March 2019, 20:21:21 UTC fix pool timer leak bug, resolve#3353 (#3358) When remove peer, block pool simple remove bpPeer, but do not stop timer, that cause stopError for recorrected peers. Stop timer when remove from pool. 02 March 2019, 20:21:21 UTC
d958941 zjubfd 02 March 2019, 20:17:37 UTC fix dirty data in peerset,resolve #3304 (#3359) * fix dirty data in peerset startInitPeer before PeerSet add the peer, once mconnection start and Receive of one Reactor faild, will try to remove it from PeerSet while PeerSet still not contain the peer. Fix this by change the order. * fix test FilterDuplicate * fix start/stop race * fix err 02 March 2019, 20:17:37 UTC
37a5484 Sven-Hendrik Haase 02 March 2019, 06:06:57 UTC docs: fix typo (#3373) 02 March 2019, 06:06:57 UTC
853dd34 Juan Leni 28 February 2019, 07:48:20 UTC privval: improve Remote Signer implementation (#3351) This issue is related to #3107 This is a first renaming/refactoring step before reworking and removing heartbeats. As discussed with @Liamsi , we preferred to go for a couple of independent and separate PRs to simplify review work. The changes: Help to clarify the relation between the validator and remote signer endpoints Differentiate between timeouts and deadlines Prepare to encapsulate networking related code behind RemoteSigner in the next PR My intention is to separate and encapsulate the "network related" code from the actual signer. SignerRemote ---(uses/contains)--> SignerValidatorEndpoint <--(connects to)--> SignerServiceEndpoint ---> SignerService (future.. not here yet but would like to decouple too) All reconnection/heartbeat/whatever code goes in the endpoints. Signer[Remote/Service] do not need to know about that. I agree Endpoint may not be the perfect name. I tried to find something "Go-ish" enough. It is a common name in go-kit, kubernetes, etc. Right now: SignerValidatorEndpoint: handles the listener contains SignerRemote Implements the PrivValidator interface connects and sets a connection object in a contained SignerRemote delegates PrivValidator some calls to SignerRemote which in turn uses the conn object that was set externally SignerRemote: Implements the PrivValidator interface read/writes from a connection object directly handles heartbeats SignerServiceEndpoint: Does most things in a single place delegates to a PrivValidator IIRC. * cleanup * Refactoring step 1 * Refactoring step 2 * move messages to another file * mark for future work / next steps * mark deprecated classes in docs * Fix linter problems * additional linter fixes 28 February 2019, 07:48:20 UTC
d6e2fb4 Anton Kaliaev 28 February 2019, 07:31:59 UTC update docs (#3349) * docs: explain create_empty_blocks configurations Closes #3307 * Vagrantfile: install nodejs for docs * update docs instructions npm install does not make sense since there's no packages.json file * explain broadcast_tx_* tx format Closes #536 * docs: explain how transaction ordering works Closes #2904 * bring in consensus parameters explained * example for create_empty_blocks_interval * bring in explanation from https://github.com/tendermint/tendermint/issues/2487#issuecomment-424899799 * link to formatting instead of duplicating info 28 February 2019, 07:31:59 UTC
ec9bff5 Anton Kaliaev 25 February 2019, 05:11:07 UTC rename WAL#Flush to WAL#FlushAndSync (#3345) * rename WAL#Flush to WAL#FlushAndSync - rename auto#Flush to auto#FlushAndSync - cleanup WAL interface to not leak implementation details! * remove Group() * add WALReader interface and return it in SearchForEndHeight() - add interface assertions Refs #3337 * replace WALReader with io.ReadCloser 25 February 2019, 05:11:07 UTC
6797d85 Ismail Khoffi 25 February 2019, 05:06:21 UTC p2p: fix comment in secret connection (#3348) Just a minor followup on the review if #3347: Fixes a comment. [#3347 (comment)](https://github.com/tendermint/tendermint/pull/3347#discussion_r259582330) 25 February 2019, 05:06:21 UTC
cdf3a74 Anton Kaliaev 23 February 2019, 15:48:28 UTC Unclean shutdown on SIGINT / SIGTERM (#3308) * libs/common: TrapSignal accepts logger as a first parameter and does not block anymore * previously it was dumping "captured ..." msg to os.Stdout * TrapSignal should not be responsible for blocking thread of execution Refs #3238 * exit with zero (0) code upon receiving SIGTERM/SIGINT Refs #3238 * fix formatting in docs/app-dev/abci-cli.md Co-Authored-By: melekes <anton.kalyaev@gmail.com> * fix formatting in docs/app-dev/abci-cli.md Co-Authored-By: melekes <anton.kalyaev@gmail.com> 23 February 2019, 15:48:28 UTC
41f9131 Anton Kaliaev 23 February 2019, 15:32:31 UTC bound mempool memory usage (#3248) * bound mempool memory usage Closes #3079 * rename SizeBytes to TxsTotalBytes and other small fixes after Zarko's review * rename MaxBytes to MaxTxsTotalBytes * make ErrMempoolIsFull more informative * expose mempool's txs_total_bytes via RPC * test full response * fixes after Ethan's review * config: rename mempool.size to mempool.max_txs https://github.com/tendermint/tendermint/pull/3248#discussion_r254034004 * test more cases https://github.com/tendermint/tendermint/pull/3248#discussion_r254036532 * simplify test * Revert "config: rename mempool.size to mempool.max_txs" This reverts commit 39bfa3696177aa46195000b90655419a975d6ff7. * rename count back to n_txs to make a change non-breaking * rename max_txs_total_bytes to max_txs_bytes * format code * fix TestWALPeriodicSync The test was sometimes failing due to processFlushTicks being called too early. The solution is to call wal#Start later in the test. * Apply suggestions from code review 23 February 2019, 15:32:31 UTC
e0adc5e Ismail Khoffi 23 February 2019, 15:25:57 UTC secret connection check all zeroes (#3347) * reject the shared secret if is all zeros in case the blacklist was not sufficient * Add test that verifies lower order pub-keys are rejected at the DH step * Update changelog * fix typo in test-comment 23 February 2019, 15:25:57 UTC
2137ecc Anton Kaliaev 23 February 2019, 04:11:27 UTC pubsub 2.0 (#3227) * green pubsub tests :OK: * get rid of clientToQueryMap * Subscribe and SubscribeUnbuffered * start adapting other pkgs to new pubsub * nope * rename MsgAndTags to Message * remove TagMap it does not bring any additional benefits * bring back EventSubscriber * fix test * fix data race in TestStartNextHeightCorrectly ``` Write at 0x00c0001c7418 by goroutine 796: github.com/tendermint/tendermint/consensus.TestStartNextHeightCorrectly() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:1296 +0xad testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Previous read at 0x00c0001c7418 by goroutine 858: github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1631 +0x1366 github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1476 +0x8f github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:667 +0xa1e github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:628 +0x794 Goroutine 796 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1119 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 testing.runTests() /usr/local/go/src/testing/testing.go:1117 +0x4ee testing.(*M).Run() /usr/local/go/src/testing/testing.go:1034 +0x2ee main.main() _testmain.go:214 +0x332 Goroutine 858 (running) created at: github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines() /go/src/github.com/tendermint/tendermint/consensus/state.go:334 +0x221 github.com/tendermint/tendermint/consensus.startTestRound() /go/src/github.com/tendermint/tendermint/consensus/common_test.go:122 +0x63 github.com/tendermint/tendermint/consensus.TestStateFullRound1() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:255 +0x397 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ``` * fixes after my own review * fix formatting * wait 100ms before kicking a subscriber out + a test for indexer_service * fixes after my second review * no timeout * add changelog entries * fix merge conflicts * fix typos after Thane's review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * reformat code * rewrite indexer service in the attempt to fix failing test https://github.com/tendermint/tendermint/pull/3227/#issuecomment-462316527 * Revert "rewrite indexer service in the attempt to fix failing test" This reverts commit 0d9107a098230de7138abb1c201877c246e89ed1. * another attempt to fix indexer * fixes after Ethan's review * use unbuffered channel when indexing transactions Refs https://github.com/tendermint/tendermint/pull/3227#discussion_r258786716 * add a comment for EventBus#SubscribeUnbuffered * format code 23 February 2019, 04:11:27 UTC
67fd428 Anton Kaliaev 22 February 2019, 07:49:08 UTC fix TestWALPeriodicSync (#3342) The test was sometimes failing due to processFlushTicks being called too early. The solution is to call wal#Start later in the test. 22 February 2019, 07:49:08 UTC
f22ada4 Anton Kaliaev 22 February 2019, 07:48:40 UTC refactor decideProposal in common_test (#3343) 22 February 2019, 07:48:40 UTC
ed1de13 Anton Kaliaev 21 February 2019, 14:28:02 UTC cs: update wal comments (#3334) * cs: update wal comments Follow-up to https://github.com/tendermint/tendermint/pull/3300 * Update consensus/wal.go Co-Authored-By: melekes <anton.kalyaev@gmail.com> 21 February 2019, 14:28:02 UTC
4f83eec Ethan Buchman 20 February 2019, 15:11:33 UTC Merge pull request #3339 from tendermint/master Merge master back to develop 20 February 2019, 15:11:33 UTC
e0f8936 Ethan Buchman 20 February 2019, 15:10:49 UTC Merge pull request #3326 from tendermint/release/v0.30.1 Release/v0.30.1 20 February 2019, 15:10:49 UTC
f2351dc Ethan Buchman 20 February 2019, 15:05:57 UTC update changelog 20 February 2019, 15:05:57 UTC
db5d760 Daniil Lashin 20 February 2019, 11:34:52 UTC docs: fix rpc Tx() method docs (#3331) 20 February 2019, 11:34:52 UTC
back to top