| 83e864b | moneta | 26 May 2020, 18:25:23 UTC | Clean up files as suggested in review by Stefan Fix an issue with defining Training stratgey introduced by previous commit Remove obsolete options in tutorials | 27 May 2020, 07:43:50 UTC |
| 2ed95e0 | moneta | 26 May 2020, 15:52:53 UTC | Remove obsolete options from MethodDL | 26 May 2020, 18:17:07 UTC |
| e736550 | Bertrand Bellenot | 26 May 2020, 14:46:19 UTC | Add Thibault Souquet for his work in the ROOT 7 Browser (#5700) * Add Thibault Souquet for his work in the ROOT 7 Browser * Update CREDITS | 26 May 2020, 14:46:19 UTC |
| c600414 | Lorenzo Moneta | 26 May 2020, 09:40:11 UTC | Deprecate MethodDNN in TMVA and improve handling of input layout string (#5665) * Add deprecation message for MethodDNN * Improve handling of parsing of inputshape layout. If size of input shape given is smaller than expected pad it with 1 values. In this case different inputShape con be supported easly in case of RNN and DNN Remove from the tutorial the usage of inputBatchLayout that is not needed anymore Remove also using InputShapeLayout in case of dense layer networks from the tutorial | 26 May 2020, 09:40:11 UTC |
| 1607a26 | Axel Naumann | 19 May 2020, 09:58:26 UTC | [cmake] Enable colored diagnostics also for Ninja, also for GCC: Ninja buffers compiler output, and compilers then think they should not use colored output (because no terminal). Force it on them. The same was already implemented for clang, a few lines above. And let cling survive: it's parsing compiler output, and the ANSI color escapes confuse the regexes. | 25 May 2020, 20:17:02 UTC |
| 5abc3c7 | Vassil Vassilev | 23 May 2020, 12:06:18 UTC | [ROOT-10791][dyld] Do not try to compare two realpaths. This conservative assert intended to capture future uses of the shouldPermanentlyIgnore routine and check if we have specified an absolute non-symlinked path. Turns out that when we scan for libraries we iterate a given folder which may move files around. Then the iterable (official) filename's real path might differ at the point of iteration and the point of the check. Some file systems use a temporary filename while copying/moving file and the rename it to the real filename preserving atomicity of the operations. It looks like this exactly happens in the description of ROOT-10791 -- the iterator gives the expected real path of the filename which is not yet available when we ask for the real path of that path we get something different (using the same inode) eg: `mathsymb.ps` vs `mathsymb.ps_tmp_4810`. Instead of asserting, let the file system handles this instead. Kudos to Philippe Canal for investigating this sporadic failure. | 25 May 2020, 16:16:36 UTC |
| 6248db0 | Vassil Vassilev | 25 May 2020, 14:16:09 UTC | Tell rootcling that we expect cuda.pcm in the context of TMVA | 25 May 2020, 15:44:29 UTC |
| dca4353 | Bertrand Bellenot | 25 May 2020, 07:08:29 UTC | Fix ntuple_types test on Windows | 25 May 2020, 15:22:39 UTC |
| e4f219c | Lorenzo Moneta | 25 May 2020, 13:08:18 UTC | Use MethodDL insterad of MethodDNN in stressTMVA (#5690) | 25 May 2020, 13:08:18 UTC |
| ef65b90 | chenxu | 25 May 2020, 13:03:26 UTC | using std::unique_ptr the right way (#5694) * Update FITS_tutorial1.C the std::unique_ptr should not be used when Drawing * Update FITS_tutorial3.C DrawClone cause problems | 25 May 2020, 13:03:26 UTC |
| 3a60fb1 | Enrico Guiraud | 24 May 2020, 21:34:36 UTC | [DF] Do not assume a certain entry order in MT tests | 25 May 2020, 11:38:59 UTC |
| 0be87b4 | Stefan Wunsch | 20 May 2020, 07:50:31 UTC | [PyROOT] Fallback to input hook for processing ROOT events on MacOS MacOS does not allow to run a second thread so fall back to the input hook because it's the best we can do. This is the same behaviour than in the old PyROOT. | 25 May 2020, 08:25:25 UTC |
| e831ba7 | Stefan Wunsch | 15 May 2020, 14:39:19 UTC | [PyROOT] Conditionally add thread to process ROOT events The PR spawns a separate thread to process ROOT events if we cannot attach the update mechanism to an exisiting hook such as existing in the interactive Python mode or for ipython/notebooks. Also adds backward compatibility for ROOT.PyROOT.StartGUIThread and shuts down the thread safely at teardown time. Related to ROOT-10774 | 25 May 2020, 08:25:25 UTC |
| 3404e2b | Axel Naumann | 25 May 2020, 06:05:47 UTC | [r] Rename R Users Guide file to have less spaces. (#5678) | 25 May 2020, 06:05:47 UTC |
| 63df84c | Vassil Vassilev | 17 May 2020, 18:09:39 UTC | [cling] Allow a Dyld per DynamicLibraryManager. This addresses the rest of the comments of root-project/root#4717 Patch by Alexander Penev and me. | 25 May 2020, 04:08:24 UTC |
| 4e104c5 | Vaibhav Garg | 23 May 2020, 07:39:26 UTC | [wincxxmodules] Fix Thread.pcm on Windows | 25 May 2020, 04:07:50 UTC |
| 8d55beb | Enrico Guiraud | 22 May 2020, 17:18:33 UTC | [DF] Write Snapshot output to its directory, not to gDirectory This way we don't need to rely on TContext to set gDirectory for us, which is slightly more efficient (and we clearly say what we mean). | 23 May 2020, 11:16:33 UTC |
| c2a27a2 | Enrico Guiraud | 22 May 2020, 17:17:56 UTC | [DF] Fix Snapshot output TTree ctor in case of sub-directory We need to pass the sub-directory, not the main file. This fixes ROOT-10790. | 23 May 2020, 11:16:33 UTC |
| aae7ec1 | Axel Naumann | 22 May 2020, 15:53:49 UTC | [r] Remove bogus file. | 22 May 2020, 15:53:49 UTC |
| 806900b | Axel Naumann | 22 May 2020, 15:47:44 UTC | [cling] Use `empty()` when we mean it (NFC). | 22 May 2020, 15:47:49 UTC |
| 00c615f | Axel Naumann | 19 May 2020, 09:57:19 UTC | [core] Remove unused (and old-style deprecated, in 2008) TROOT::fReadingObject. | 22 May 2020, 14:37:08 UTC |
| c35d3ff | Axel Naumann | 20 May 2020, 09:15:45 UTC | [hist] Prevent "Replacing existing TH1" in THn test. | 22 May 2020, 14:36:00 UTC |
| 31f55ff | Stephan Hageboeck | 22 May 2020, 10:43:34 UTC | [HF] Remove unnecessary member from HistFactory::Channel. Although 35105feb3d7cb fixes a problem in HistFactory, it has the disadvantage that the assignment operator of Channel gets deactivated. By passing the list of open TFiles as argument instead of making it a member, the class can stay as it was. | 22 May 2020, 14:11:11 UTC |
| f53628d | chenxu | 21 May 2020, 13:54:31 UTC | Update df003_profiles.C This is an error title! py vs px, not pz vs px | 22 May 2020, 13:20:50 UTC |
| 5b2b0f8 | Stephan Hageboeck | 14 May 2020, 08:48:20 UTC | [IO] Completely remove all uses of TDirectory::kCloseDirectory. RooFit was paying attention to a status bit that's not used in ROOT, any more. Since it is never set, remove its use entirely. Left the bit in place in case external code might use it. | 22 May 2020, 12:13:06 UTC |
| 084d6a9 | Stephan Hageboeck | 14 May 2020, 08:46:18 UTC | [RF] Implement TH1::AddDirectory()-like interface for RooPlot. RooPlots add themselves to gDirectory. Users probably expect that this behaviour can be switched off globally with RooPlot::AddDirectory(), so now RooPlot pays attention to that. | 22 May 2020, 12:13:06 UTC |
| 1980d17 | Stephan Hageboeck | 12 May 2020, 15:32:35 UTC | [RF] Make sure that ROOT-3579 is fixed. RooTreeDataStore::loadValues was creating unnecessary copies of data to ship around a supposed bug in TTree / TChain. This couldn't be reproduced. The copying has been removed, a test for importing data from trees added, and it has been verified that the example from ROOT-3579 works. | 22 May 2020, 12:13:06 UTC |
| f61713a | Olivier Couet | 22 May 2020, 10:12:29 UTC | Fix TTree::Draw with option A (#5629) | 22 May 2020, 10:12:29 UTC |
| 2505a5b | Stephan Hageboeck | 20 May 2020, 17:52:06 UTC | [RF][Docs] Fix documentation of RooDataHist. [ROOT-10784] The set() functions of RDH all had copy-pasted documentation that was completely wrong. | 22 May 2020, 08:47:43 UTC |
| ad215b5 | Stephan Hageboeck | 19 May 2020, 17:31:21 UTC | [RF] Fix RooCategory read test. Fix the reference file for the v6.22 read test of RooCategory now that v6.22 has been tagged. The previous file was using an outdated class structure, and was therefore triggering warnings. | 22 May 2020, 08:37:06 UTC |
| 9b61dca | Alja Mrak-Tadel | 21 May 2020, 22:45:15 UTC | Remove merge conflict. | 22 May 2020, 07:42:16 UTC |
| 0eb93f1 | Alja Mrak-Tadel | 21 May 2020, 22:39:43 UTC | Canges in table sort. | 22 May 2020, 07:42:16 UTC |
| d89596d | Alja Mrak-Tadel | 21 May 2020, 22:37:18 UTC | resolve merge conflict. | 22 May 2020, 07:42:16 UTC |
| dab8c17 | Alja Mrak-Tadel | 21 May 2020, 21:00:54 UTC | Store Filtered value in items as a filter passed value. | 22 May 2020, 07:42:16 UTC |
| 71d918c | Alja Mrak-Tadel | 21 May 2020, 21:00:54 UTC | Store Filtered value in items as a filter passed value. | 22 May 2020, 07:42:16 UTC |
| 0b95e6c | Alja Mrak-Tadel | 21 May 2020, 20:55:03 UTC | Handle two special cases - name and filtered sort property. | 22 May 2020, 07:42:16 UTC |
| 9cf5fb3 | Alja Mrak-Tadel | 21 May 2020, 20:30:34 UTC | Use two level sort and shade entries in cell table that do not pass filter. | 22 May 2020, 07:42:16 UTC |
| 7e10a67 | Alja Mrak-Tadel | 21 May 2020, 20:30:34 UTC | Use two level sort and shade entries in cell table that do not pass filter. | 22 May 2020, 07:42:16 UTC |
| 40d170e | Vaibhav | 16 May 2020, 09:52:37 UTC | [wincxxmodules] Fix Core.pcm on Windows | 21 May 2020, 17:17:13 UTC |
| c9e7f72 | Philippe Canal | 20 May 2020, 23:13:14 UTC | Actually use a name unique to the tutorials. mp101_singleCore.root was (of course) also use by mp101_fillNtuples.C | 21 May 2020, 15:26:50 UTC |
| 68e0f54 | Enric Tejedor Saavedra | 20 May 2020, 15:51:06 UTC | [Exp PyROOT] Install Python sources and bytecodes together in the right directory It was observed that, when running make package, neither the Python sources neither their bytecodes were copied in the CPack lib directory. The changes in this commit allow both "make install" and "make package" to work by properly selecting the directory where the Python sources and bytecodes will be installed. Moreover, the sources and the bytecodes are installed together. | 21 May 2020, 09:38:22 UTC |
| 9052697 | Enric Tejedor Saavedra | 20 May 2020, 15:26:18 UTC | [Exp PyROOT] Use same options as ROOT_LINKER_LIBRARY With the previous install command, the cppyy libraries were not copied into the CPack lib directory (inside the build dir) when running make package. | 21 May 2020, 09:38:22 UTC |
| 175c98c | Enric Tejedor Saavedra | 20 May 2020, 15:15:32 UTC | [Exp PyROOT] Exclude unnecessary cppyy-backend directories | 21 May 2020, 09:38:22 UTC |
| 3411476 | Enric Tejedor Saavedra | 20 May 2020, 08:59:20 UTC | [Exp PyROOT] Prepend CMAKE_INSTALL_PREFIX if runtimedir is not absolute When running "make package", it was observed that copying the Python source files to runtimedir was incorrect, and the generation of the bytecodes was failing later too as a consequence. This change ensures that the Python sources are installed correctly. | 20 May 2020, 14:00:53 UTC |
| c5682f4 | Simeon Ehrig | 27 January 2020, 14:00:10 UTC | Backport bugfix in the ptx generator - now the ptx code should be aligned correctly | 20 May 2020, 13:11:23 UTC |
| 1e58f6e | Enrico Guiraud | 20 May 2020, 07:43:37 UTC | [DF] Adapt LinkDef to change in namespace for RRootDS | 20 May 2020, 13:04:47 UTC |
| 4dcdbcb | Axel Naumann | 18 May 2020, 08:35:58 UTC | Also capture SFINAE error counts (ROOT-10754, ROOT-10777): When doing lookup on templates, instantiation can fail. This can be triggered during template instantiation somewhere in clang, autoloading, cling-lookup - and SFINAE errors that occur in cling-lookup must not bubble up to clang, or else clang will think that there was a problem (where there was none - just e.g. ROOT trying to autoload a bogus template). In this concrete case, a template specialized with a lambda was not found by clang, was tried to be autoloaded, TMetaUtils produced a broken normalized type name, lookup on the broken type name failed with a SFINAE error - and that ended up being swallowed by a clang SFINAETrap by the topmost lookup. Instead, keep SFINAE errors to ourselves. This is an improved version of 40673e583fceda8b362a0902c6aba371ddd0cfd8 which lowers the SFINAE-reset to Lookup, as AutoParse can still see partial template specialization scopes. It fixes ROOT-10777. | 20 May 2020, 10:47:45 UTC |
| db574c3 | Axel Naumann | 18 May 2020, 08:32:25 UTC | Revert "Also capture SFINAE error counts (ROOT-10754):" This reverts commit 40673e583fceda8b362a0902c6aba371ddd0cfd8. Autoparsing can trigger parsing of partial specializations, and as such is not a SFINAE context. Lookup is, OTOH. | 20 May 2020, 10:47:45 UTC |
| add0000 | Axel Naumann | 18 May 2020, 08:34:47 UTC | [cling] Make use of shared_ptr operators instead of get() (NFC). | 20 May 2020, 10:47:45 UTC |
| 25a6438 | Stefan Wunsch | 19 May 2020, 14:05:58 UTC | [RF] Whitespace fixes | 20 May 2020, 08:57:07 UTC |
| 271ecdd | Stefan Wunsch | 19 May 2020, 14:04:35 UTC | [RF] Add missing include of stdexcept Starting with gcc10 stdexcept is not anymore implicitly included by other STL headers | 20 May 2020, 08:57:07 UTC |
| 4ee93a2 | Vassil Vassilev | 13 May 2020, 19:58:03 UTC | [rootcling] Allow users to specify byproduct modules. When building the foundation of frameworks often the dictionary modules require third party modules such as clhep, boost and tinyxml. Those modules do not require I/O information and it is permissible to be built as a part of another dictionary module build. This patch relaxes the eager check for implicit module builds by adding a flag -mByproduct which turns of the diagnostic disallowing implicit module builds. | 20 May 2020, 08:17:10 UTC |
| 653bcbf | Sergey Linev | 07 May 2020, 12:42:09 UTC | [cmake] simplify include dirs handling in ROOT_GENERATE_DICTIONARY Keep list with plain directories names, only for rootcling executable provide list with prefixed -I | 20 May 2020, 08:13:27 UTC |
| d06eca1 | Lorenzo Moneta | 20 May 2020, 07:16:30 UTC | Fix TMVARegression.C for MethodDL (#5644) * Set correct options for Deep Learning method in TMVARegression.C * remove an uneeded printout statement | 20 May 2020, 07:16:30 UTC |
| 60a3898 | Stephan Hageboeck | 19 May 2020, 08:39:40 UTC | [RF][Docs] Properly close group in doxygen documentation of RooAbsArg. | 20 May 2020, 07:09:54 UTC |
| f63bdcb | Stephan Hageboeck | 19 May 2020, 08:37:35 UTC | [hist][Docs] Improve documentation of TProfile(2D). There was a ^2 missing in the documentation of TProfile(2D), and the formulae have been typeset using mathjax. | 20 May 2020, 07:09:54 UTC |
| 03c210a | Stephan Hageboeck | 19 May 2020, 07:30:30 UTC | [Core][Docs] Add doxygen documentation for TDirectory::Get etc. | 20 May 2020, 07:09:54 UTC |
| 210b7c9 | Stephan Hageboeck | 18 May 2020, 08:47:36 UTC | [RF][Docs] Fix doxygen of RooAddModel. | 20 May 2020, 07:09:54 UTC |
| 35105fe | Stephan Hageboeck | 20 May 2020, 06:28:41 UTC | [HF] Fix ROOT-10779, cannot update model with new histograms. When wrinting a histfactory model to a file and retrieving it, histograms are deserialised. If in the mean time new instances of those histograms have been written to the file, the new instances cannot be picked up. This is because Channel::GetHistogram() was `Get()`-ting histograms from the directory. This may return a memory-resident histograms. Since histograms are always read when deserialising, there is always a memory-resident histograms. The problem has been fixed by reading from file using TKey. Co-authored-by: Philippe Canal <pcanal@fnal.gov> | 20 May 2020, 06:28:41 UTC |
| f4a38ec | Axel Naumann | 19 May 2020, 16:11:27 UTC | [core] Provide definition of TThreadedObject<T>::fgMaxSlots. | 19 May 2020, 16:11:27 UTC |
| ba19df5 | Axel Naumann | 19 May 2020, 12:44:47 UTC | [core] Adjust test to match new type of fgMaxSlots. | 19 May 2020, 12:44:47 UTC |
| bd12ae9 | Axel Naumann | 19 May 2020, 09:53:17 UTC | [rdf] Move RRootDS to Internal:: as announced by deprecation. | 19 May 2020, 09:53:17 UTC |
| 4b49fbd | Axel Naumann | 19 May 2020, 09:52:39 UTC | [core] Remove previously deprecated interfaces. | 19 May 2020, 09:52:39 UTC |
| a7a1917 | Axel Naumann | 19 May 2020, 08:46:28 UTC | [relnotes] Add Oksana + Jakob to template. | 19 May 2020, 08:46:28 UTC |
| d40d197 | Axel Naumann | 19 May 2020, 08:24:38 UTC | [relnotes] Start release notes for future v6.24. | 19 May 2020, 08:45:38 UTC |
| 5a1d381 | Axel Naumann | 19 May 2020, 08:23:43 UTC | "Update ROOT version files to v6.23/01." | 19 May 2020, 08:23:43 UTC |
| 13109fc | Axel Naumann | 19 May 2020, 08:06:52 UTC | "Update ROOT version files to v6.21/02." | 19 May 2020, 08:06:52 UTC |
| 78a5026 | Axel Naumann | 19 May 2020, 07:55:49 UTC | [relnotes] Update date. | 19 May 2020, 07:55:49 UTC |
| 97c62d4 | Axel Naumann | 18 May 2020, 10:20:44 UTC | [io] Protect out-of-bounds access in R__WriteDestructorBody: Fixes assert in roottest/root/meta/MakeProject/runcms310.C ``` /builddir/build/BUILD/gcc-8.3.1-20190223/obj-x86_64-redhat-linux/x86_64-redhat-linux/libstdc++-v3/include/bits/basic_string.h:1067: std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator[](std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference = char&; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type = long unsigned int]: Assertion '__pos <= size()' failed. at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3531 subClasses=0x7fffffff8db0, top=true) at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3772 subClasses=0x7fffffff8db0, extrainfos=0x7fffffff9210) at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3976 at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TFile.cxx:2843 ``` where ``` (gdb) p inside $1 = std::vector of length 3, capacity 4 = {"std::vector", "std::pair<edm::BranchKey,edm::BranchDescription>", ""} ``` | 18 May 2020, 16:00:37 UTC |
| 46303d6 | Philippe Canal | 18 May 2020, 15:08:10 UTC | Revert "Load dependent libraries as part of AutoLoading." This reverts commit 3845f8a06df8f90e1e5a6efa40969f9074210c4e. | 18 May 2020, 15:08:10 UTC |
| 07d2316 | Philippe Canal | 18 May 2020, 15:07:31 UTC | NFC: white space | 18 May 2020, 15:07:31 UTC |
| 3845f8a | Philippe Canal | 29 April 2020, 00:07:00 UTC | Load dependent libraries as part of AutoLoading. Since the proper creation of the TClass will require the dictionary for all its component let load all the dependent library too. Note that even with explicit linking, the dictionary may not be loaded as part of the 'main' library when the dictionary is a library separate from the classes' code (see ATLAS setup for example) This solves ROOT-10663. | 18 May 2020, 15:05:29 UTC |
| 9709188 | Bertrand Bellenot | 15 May 2020, 11:32:41 UTC | Fix potential startup error messages on Windows Fix the following error messages displayed when starting ROOT compiled with a different version of Visual Studio than the one installed on the system: ``` In file included from input_line_3:38: In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:142:12: error: redefinition of '_CrtEnableIf<true, _Ty>' struct _CrtEnableIf<true, _Ty> ^~~~~~~~~~~~~~~~~~~~~~~ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:142:12: note: previous definition is here struct _CrtEnableIf<true, _Ty> ^ In file included from input_line_3:38: In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:517:16: error: redefinition of '__crt_locale_data_public' typedef struct __crt_locale_data_public ^ C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\crtdefs.h:10:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ In file included from input_line_3:38: In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:524:16: error: redefinition of '__crt_locale_pointers' typedef struct __crt_locale_pointers ^ C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\crtdefs.h:10:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ In file included from input_line_3:38: In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:532:16: error: redefinition of '_Mbstatet' typedef struct _Mbstatet ^ C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\crtdefs.h:10:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ ``` | 18 May 2020, 15:01:04 UTC |
| 78c4989 | Bertrand Bellenot | 15 May 2020, 19:44:10 UTC | Filter out non existing library name (there is only a dll) This fixes an issue with ACLiC trying to link against `msvcp140.lib` which doesn't exist (there is only `msvcp140.dll`) | 18 May 2020, 14:58:14 UTC |
| 83502c8 | Lorenzo Moneta | 18 May 2020, 08:23:44 UTC | Add RConfigure preprocessor flag for pymva and rmva (R__HAS_PYMVA) and (R__HAS_RMVA) (#5630) * Add preprocessor flag in RConfigure.h for pymva and rmva * Enable RMVA when R is found and tmva is on * Update CNN and RNN tutorial to work also when ROOT is built without Pymva | 18 May 2020, 08:23:44 UTC |
| 9daf978 | Lorenzo Moneta | 18 May 2020, 08:22:20 UTC | Fix multithread fitting in case of ThnSparse and bin integral fits (#5626) * Fix case when ROOT is running with MT and TVIrtualFitter pointer to last fitter is not present * Fix multithread fitting when computing a bin intengral or re-normalizing by the bin volume (case of Thnsparse fit). The fix is applied for both least-square and binned likelihood fit Improve stressHistoFit test. Add option "-t" to run in multi-thread mode. Add the option X for fitting to make sure chi2 method is run Now all stresshistofit tests pass in multi-thread mode. Note that when computing integral in multi-thread only the GuassIntegrator of mathcore is thread safe for 1D. Also the AdaptiveIntegratorMultiDim, used in the multi-dim case, is thread safe. * Remove non-thread safe access to BinData::BinEdge also in other fitting functions and replace them with the thread safe version | 18 May 2020, 08:22:20 UTC |
| f6d0739 | Philippe Canal | 17 May 2020, 12:50:23 UTC | Merge pull request #5597 from pcanal/ROOT-9535 Avoid streaming a copy of the TPaveStats parent during the TH1 cloning process. | 17 May 2020, 12:50:23 UTC |
| 2bdae46 | Vaibhav | 14 May 2020, 19:36:44 UTC | Make xtimec.h and xthreads.h textual in std_msvc.modulemap | 16 May 2020, 10:45:57 UTC |
| ba383e2 | Massimiliano Galli | 15 May 2020, 12:41:11 UTC | [CMake][Exp PyROOT] Remove cached Python related variables This is needed because doesn't allow incremental builds to work correctly. In the case of multiple python, the second time we would wrongly enter the if(PYTHON_EXECUTABLE) case because PYTHON_EXECUTABLE is cached, but in this case PyROOT would be built only for one version. | 15 May 2020, 20:17:09 UTC |
| a284738 | Massimiliano Galli | 15 May 2020, 10:08:07 UTC | [CMake][Exp PyROOT] Define PYTHON_VERSION_MAJOR_Development_Main and PYTHON_VERSION_MINOR_Development_Main everywhere | 15 May 2020, 20:17:09 UTC |
| cb9628e | Massimiliano Galli | 15 May 2020, 09:49:57 UTC | [CMake][Exp PyROOT] Change PYTHON_VERSION to PYTHON_VERSION_STRING for old CMake | 15 May 2020, 20:17:09 UTC |
| 0cfcbd6 | Massimiliano Galli | 15 May 2020, 08:25:15 UTC | [JupyROOT] Fix CMake Python variables for ROOT C++ kernel | 15 May 2020, 20:17:09 UTC |
| cf769cc | Massimiliano Galli | 15 May 2020, 08:18:05 UTC | [CMake][Exp PyROOT] Fix PYTHON_EXECUTABLE for cmdLineUtils | 15 May 2020, 20:17:09 UTC |
| 3f5ccf2 | Massimiliano Galli | 15 May 2020, 08:03:46 UTC | [CMake][PyROOT] Fix Python varables for old PyROOT | 15 May 2020, 20:17:09 UTC |
| 3598c5f | Massimiliano Galli | 15 May 2020, 07:54:36 UTC | [CMake][Exp PyROOT] Fix PYTHON_EXECUTABLE for pyunittests | 15 May 2020, 20:17:09 UTC |
| d3a6c4a | Massimiliano Galli | 15 May 2020, 07:45:37 UTC | [CMake][Exp PyROOT] Fix Python variables for tutorials | 15 May 2020, 20:17:09 UTC |
| bbaba38 | Massimiliano Galli | 15 May 2020, 07:43:01 UTC | [CMake][Exp PyROOT] Rename variable in info messages | 15 May 2020, 20:17:09 UTC |
| 4baf68e | Omar Zapata | 15 May 2020, 15:03:19 UTC | [ROOT-10755] fixed X11 thread initialization (#5608) | 15 May 2020, 15:03:19 UTC |
| 33007b7 | Jakob Blomer | 14 May 2020, 21:25:01 UTC | [ntuple] fix building of inner field type names | 15 May 2020, 12:07:07 UTC |
| 877c8bf | Jakob Blomer | 14 May 2020, 21:24:36 UTC | [ntuple] minor unit test improvement | 15 May 2020, 12:07:07 UTC |
| 0af445a | Jakob Blomer | 14 May 2020, 13:46:44 UTC | [ntuple] fix parsing of type names with spaces | 15 May 2020, 12:07:07 UTC |
| 7daf36e | Sergey Linev | 15 May 2020, 08:46:37 UTC | [cmake] remove unused windows part in ROOT_LINKER_LIBRARY | 15 May 2020, 10:07:15 UTC |
| 302b5e8 | Bertrand Bellenot | 27 April 2020, 18:45:26 UTC | Fix redirection (`.> blah.txt`) on Windows Fix output redirection (`.> blah.txt`) which is curently freezing the console input on Windows When a file (or console) has been created without the `FILE_SHARE_READ | FILE_SHARE_WRITE` flags, there is no way to change this, but by closing it and re-opening it (or a new one) . And I suspect that a standard console doesn't have those flags, so when redirecting the output to a file with `.> blah.txt`, all the output is going to the file, without any echo on the console, and when typing `.>` to suppress the redirection, the file contains this kind of errors: ``` Error 6 in textinput::TerminalDisplayWin attaching to console output: The handle is invalid. Error 6 in textinput::TerminalDisplayWin attaching / getting console info: The handle is invalid. Error 6 in textinput::TerminalDisplayWin writing to output: The handle is invalid. ``` This patch solves those issues, even if I'm not sure if it is the root of the problem (it might be something else deep in the `MetaSema::actOnRedirectCommand` function). NB I don't know if this can have any side effect, but I didn't see any so far... And for info, one could Enable Console Virtual Terminal Sequences (ANSI escape code) that can control cursor movement, color/font mode, and other operations when written to the output stream by adding the ENABLE_VIRTUAL_TERMINAL_PROCESSING flag, but then it breaks the WRAP_AT_EOL_OUTPUT. With this feature, the escape sequences like `\033[39m` would work in the Windows 10 command prompt as well. This is a known issue, see https://github.com/microsoft/terminal/issues/349 | 15 May 2020, 07:31:59 UTC |
| 673e19b | Axel Naumann | 15 May 2020, 07:24:21 UTC | [githubaction] Switch to Outlook as from/smtp server. | 15 May 2020, 07:24:21 UTC |
| e3f88b3 | Bertrand Bellenot | 14 May 2020, 18:58:05 UTC | Fix potential crash at startup on Windows When starting root.exe on Windows with a version of Visual Studio different than the one used to build ROOT, it mighty crash with the following error: Assertion failed: !isNull() && "Cannot retrieve a NULL type pointer", file C:\build\ws\BUILDTYPE\Debug\LABEL\windows10\V\6-20\root\interpreter\llvm\src\tools\clang\include\clang/AST/Type.h, line 630 This patch fixes the issue. | 15 May 2020, 06:21:13 UTC |
| 05029da | Massimiliano Galli | 13 May 2020, 11:18:13 UTC | [CMake][Exp PyROOT] Split CMake Python variables in ROOT and PyROOT/PyMVA related These changes address the case in which Python 3 has only Interpreter while Python 2 has both Interpreter and Development. In this case, the Python used to build ROOT (which requires only Interpreter) will be 3, but PyROOT (which requires also Development) will be built only for 2. To achieve this, ROOT and PyROOT/PyMVA use now two different sets of variables. Documentation for the whole machinery is also added. It is also worth pointing out that the entire machinery could be much simplified by just requiring the following as a prerequisite for ROOT: - CMake >= 3.12.4 - Python-Development package | 14 May 2020, 18:16:55 UTC |
| fa76d33 | Bertrand Bellenot | 14 May 2020, 12:27:58 UTC | Fix (disable) roofit tests failing on Windows | 14 May 2020, 15:35:30 UTC |
| 6e3cb15 | Vaibhav Garg | 14 May 2020, 14:12:00 UTC | [wincxxmodules] Fix std and libc modules on Windows (#5610) [wincxxmodules] Fix std and libc modules on Windows | 14 May 2020, 14:12:00 UTC |
| f9a3d33 | Mattias Ellert | 14 May 2020, 14:05:11 UTC | Correct broken assert statements (#5159) | 14 May 2020, 14:05:11 UTC |
| 768d598 | Bertrand Bellenot | 14 May 2020, 07:31:12 UTC | Fix dataframe_interface test on Windows (#5612) * Fix dataframe_interface test on Windows * Reduce the amount of ifdef'd code (thanks Enrico for the review) * Fix warning: declaration of type shadows a global declaration | 14 May 2020, 07:31:12 UTC |
