https://github.com/lmoneta/root

sort by:
Revision Author Date Message Commit Date
96748fd [tmva][sofie] Fix issue with RModel streamer Fix a problem when reading an RModel from a ROOT file 06 April 2024, 09:45:02 UTC
9950a44 [llvm-project] Bump to tag ROOT-llvm16-20240402-01 02 April 2024, 11:11:39 UTC
07021ea [clang] Reuse ContextRAII for ContextAndScopeRAII 02 April 2024, 11:11:39 UTC
b702391 [clang] Correctly RAII reset two "new" Sema fields FunctionScopesStart and InventedParameterInfosStart were introduced by upstream commit https://github.com/llvm/llvm-project/commit/5c845c1c50ac89a6f12557d1571678f3d1432478 and are handled in ContextRAII, but not our ContextAndScopeRAII. 02 April 2024, 11:11:39 UTC
8227e95 [RF] Fixup work around deleted move constructor in `std::span` backport This is a followup to #15089, where I missed a second change. Closes #15087. 01 April 2024, 12:07:40 UTC
62a7ea3 [df] Correctly clone AsNumpyResult in distributed execution 28 March 2024, 23:06:59 UTC
1edca86 [df] Enable cloning of AsNumpyResult 28 March 2024, 23:06:59 UTC
dcebd46 [RF] Work around deleted move constructor in `std::span` backport Closes #15087. 28 March 2024, 16:51:10 UTC
a27e60a [RF] Improve parameter management in `RooEvaluatorWrapper` Only register actual observables as value servers in the `RooEvaluatorWrapper` this avoids that spurious variables appear in user code, which were only meant to be used internally by the new CPU evaluation backend. To make the management of the parameter easier, impose the new reasonable constraint that when resetting the data via `setData()`, the new dataset needs to have the same structure as the old one. It was confirmed with an ATLAS model provided by Will that this commit is fixing the problem of spurious variables. 28 March 2024, 16:49:58 UTC
f4f6467 [PyROOT] Replace `TDirectory.__getattr__` with `__getitem__` The new recommended way to get objects from a `TFile` or any `TDirectory` in general is now via `__getitem__`: ```python tree = my_file["my_tree"] # instead of my_file.my_tree ``` This is more consistent with other Python collections (like dictionaries), makes sure that member functions can't be confused with branch names, and easily allows you to use string variables as keys. The old pythonization with the `__getattr__` syntax still works, but emits a deprecation warning and will be removed from ROOT 6.34. 28 March 2024, 16:48:54 UTC
211d1e5 [tree] Add regression test for writing long strings 28 March 2024, 15:22:05 UTC
638593e Fix writing long strings. In TBufferFile::WriteFastArrayString, we had ``` if (n < 255) { *this << (UChar_t)n; } else { *this << (UChar_t)255; *this << n; } ``` A recent commit changed the type of the n parameter from Int_t to Long64_t. This is effectively an incompatible change in the on-disk format, but only for strings which are at least 255 characters long. Further, ReadFastArrayString is still reading an Int_t, so this version of ROOT cannot read files that it writes. Resolve by changing WriteFastArrayString to explicitly write an Int_t. Also move the bounds check on the length to before writing anything into the buffer. Fixes a failure seen in the unit tests of the ATLAS EventInfo package in the dev3LCG build. 28 March 2024, 15:22:05 UTC
ac73d30 [ntuple] speed-up temperatures tutorial 28 March 2024, 12:53:32 UTC
727181e [cppyy] Fix `missing-field-initializers` with Python 3.12 28 March 2024, 10:04:57 UTC
d8330ab [hadd] avoid large RAM in hadd with multiple subdirs Fixes https://github.com/root-project/root/issues/13531 28 March 2024, 00:12:48 UTC
7a4b12f [RF] Fix dirty state propagation for offsetting with new CPU backend The logic that determined the offset hiding of not was coded inside the `RooNLLVarNew` evaluation function so far. This caused trouble, because a change in the global `RooAbsReal::hideOffset()` state did not mark the NLL as dirty. Therefore, it was unpredictable if the offset was actually hidden or not. This commit suggests an improved logic: * Reducer nodes like the NLL always register a value and an offset to the `EvalContext` * The evaluator decides whether to subtract the offset or not * A change in `hideOffset()` makes the evaluator wrapper set all reducer nodes to dirty A new unit test to cover this was also implemented 27 March 2024, 17:18:52 UTC
7365f92 [RF] Improve the signature of vectorized evaluation function So far, the signature for the function that is called for the vectorized evaluation was this one: ```c++ void RooAbsReal::computeBatch(double* output, size_t nEvents, RooFit::Detail::DataMap const& dataMap) const ``` This commit is suggesting a new signature: ```c++ void doEval(RooFit::EvalContext & ctx) const; ``` The idea is to make the signature as short as possible, so it doesn't have to be changed anymore if more information needs to be passed. That's why the only parameter is now an `EvalContext` object, reminicint of the old `RunContext` object that fulfilled this task in the very first implementation of the BatchMode by Stephan. The name is now simply `doEval`, because the overloaded term "Batch" should be dropped. It needed to be something with "evaluate", because there is also `RooAbsReal::evaluate()` and we are talking about "evaluation backends". The motivation to change this interface now is because I want to write a documentation for developers (like CMS combine mainteiners) on how to use these new interfaces. And if they start to use it, the interfaces should not change anymore. Than's why I'm doing this change now, which I had in mind already for some time. 27 March 2024, 15:24:58 UTC
7a4af49 [cmake][tests] Fix and re-enable tests on Windows - Export a couple of missing symbols (x86) - Re-enable several tests working now with LLVM 16 and VS 2022 - Reorganize `llvm13_broken_tests` and `win_broken_tests` for clarity 27 March 2024, 12:05:12 UTC
60f7275 [NFC][ntuple] clarify in spec that encoding is page-wise * [RNTuple] describe how exactly `Index` columns are "relative to the cluster" page-by-page follow up of #14949 * mention encoding is page-wise 26 March 2024, 07:26:53 UTC
d93a89a [RF] Also veto Python version of TestNonCentral when `mathmore=OFF` 26 March 2024, 07:06:44 UTC
2a82db0 [RF] Always reference data in workspace in `rs101_limitexample` Otherwise, there is no clear ownership model, which might result in PyROOT crashes at cleanup. 25 March 2024, 23:14:11 UTC
dfff4b1 [RF] No manual `del` in RooFit/RooStats tutorials The new cppyy has improved memory management with lifelines, so the manual calls to `del` to get the right deletion order are not necessary anymore. Closes #10891. 25 March 2024, 23:14:11 UTC
4dcc0fd [RF] Convert 4 RooStat tutorials to PyROOT Contributes to https://github.com/root-project/root/issues/8758 Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch> 25 March 2024, 20:40:52 UTC
bbd5eb9 [ntuple] forbid user classes with virtual inheritance 25 March 2024, 20:40:17 UTC
4998acf [ntuple] add unit test for virtual inheritance 25 March 2024, 20:40:17 UTC
8823081 Add note of the link between TObject and k630forwardCompatibility. 25 March 2024, 19:19:14 UTC
d7281c0 [io] Add rootrc key TFile.v630forwardCompatibility The default is no. 25 March 2024, 19:19:14 UTC
6045f02 Allow producing forward compatible file for fBits value. Calling `file->SetBit(TFile::k630forwardCompatibility);` will request to file to store the current value of the bit kIsOnHeap and kNotDeleted for reading in older version that were not setting their value based on the actual state of the read into object 25 March 2024, 19:19:14 UTC
f3668d9 [RF] Re-implement `MakeNumpyDataFrame` with no interpreter calls Re-implement `MakeNumpyDataFrame` with no interpreter calls, and avoid a explicit lifetime management of Python objects in the RDNumpyDS helper. Like this, the former `RNumpyDS.hxx` helper could be moved to `tree/dataframe`, as it doesn't import `Python.h` anymore. The `RNumpyDS` also got renamed to `RVecDS`, because it takes RVecs and not NumPy arrays directly. 25 March 2024, 17:02:37 UTC
00cd9fc [ci] Contextualize cmake warning about builtin_afterimage=OFF since the warning is not needed in case the graphics system, cocoa or x11, is OFF. Fixes #15027 25 March 2024, 14:23:23 UTC
6e3f5d3 [runtime_cxxmodules] Allow for changing the modulemap name to match the overlay. Fixes #14964 25 March 2024, 13:49:15 UTC
ac661a8 [DF][NFC] Mention AsRNode in the progress bar documentation fixes #15040 25 March 2024, 11:10:45 UTC
239cafe Clarify wording Thanks vepadulano! Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> 23 March 2024, 07:22:48 UTC
5db7764 [hist] explain better what computeIntegral does Fixes https://its.cern.ch/jira/browse/ROOT-8274 23 March 2024, 07:22:48 UTC
a29e81c [skip-ci] brief is for file, not for namespace In https://root.cern.ch/doc/master/namespaces.html the description of the ROOT namespace was picked form this file brief. Try to fix it this way. 22 March 2024, 13:17:25 UTC
6b6ef47 fix while 22 March 2024, 13:16:28 UTC
63dbab1 improve error messages and simplify for loop vepadulanos suggestions 22 March 2024, 13:16:28 UTC
6f894da fix include 22 March 2024, 13:16:28 UTC
2cd4d03 fix return 22 March 2024, 13:16:28 UTC
6633504 missing includes 22 March 2024, 13:16:28 UTC
2c18c48 Update THnBase.cxx 22 March 2024, 13:16:28 UTC
bcedb79 [hist] thnbase copy bin labels Fixes https://its.cern.ch/jira/browse/ROOT-8051 And adds some security to function arguments 22 March 2024, 13:16:28 UTC
bf2d1ac New methods (#15029) * New methods * Add protection 22 March 2024, 09:00:56 UTC
4eb61b1 [RF] Rename RooMomentMorph::getVal to RooMomentMorph::getValV The RooAbsReal::getVal function should not be overloaded. It is the getValV function that is a virtual function which might be overloaded in derived classes. Otherwise, virtual calls don't work. 21 March 2024, 14:56:06 UTC
2706217 [cling] Backport jitlink ppc64 (#13850) * Backport JITLink ppc64 backend to LLVM-16 * Backport ELF part * Backport PCREL relocations * Use jitlink::Section::blocks::empty instead * Backport TLS PCREL relocation * [llvm-project] Synchronize with LLVM monorepo fork --------- Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> 21 March 2024, 14:55:16 UTC
7d1dfdd [runtime_cxxmodules] Do not overlay on top of the unix modulemaps. We should have separate cases for unix and apple, otherwise the modulemaps go on top of each other. 21 March 2024, 12:49:39 UTC
05906f5 [rdf] Restrict distributed initialization to executors only A user calling distributed initialize may only want to see the effects of the input function on the executors and not on the driver of the distributed application. 21 March 2024, 12:30:24 UTC
45dec44 [PyROOT] Move `AsRVec` and `AsRTensor` to Python 21 March 2024, 11:01:57 UTC
4ac9b23 [PyROOT] Migrate `RDataFramePyz` to Python Like this, we are using fewer CPyCppyy implementation details in the pythonizations. 21 March 2024, 11:01:57 UTC
70d87e3 [PyROOT] Format Python code of some pythonization sources with `black` 21 March 2024, 11:01:57 UTC
7ae611b [ntuple] improve return type of RFieldBase::Check() 21 March 2024, 08:26:23 UTC
ffccb87 [ntuple] add RFieldBase::Check() test for 'long double' 21 March 2024, 08:26:23 UTC
27c3f18 [ntuple] fix method spelling 21 March 2024, 08:26:23 UTC
c2443b2 [NFC][ntuple] fix method comment Co-authored-by: Philippe Canal <pcanal@fnal.gov> 21 March 2024, 08:26:23 UTC
7e02a70 [ntuple] fix compiler warning in unit test 21 March 2024, 08:26:23 UTC
40cef62 [ntuple] add RFieldBase::Check() 21 March 2024, 08:26:23 UTC
c88365c [ntuple] add continue-on-error option to RFieldBase::Create() 21 March 2024, 08:26:23 UTC
455127d [ntuple] add class RInvalidField 21 March 2024, 08:26:23 UTC
d24222b [RF] Use `RooFit::Evaluator` for nominal evaluation in RooFuncWrapper Use the regular RooFit computation graph evaluation for the nominal function instead of the generated code. The generated code is now only used for the gradient. This is to make sure that RooFits caching is still used when evaluating numerical Hessians. 20 March 2024, 21:27:02 UTC
d00b6a0 [RF] Read const arrays from const input in code generation Like this, constant values like bin indices don't have to be recomputed in the likelihood function. 20 March 2024, 21:27:02 UTC
4a0d668 [RF] Modify PiecewiseInterpolation to use loops instead This means the loop doesn't need to be unrolled in the generated code. 20 March 2024, 21:27:02 UTC
f388cde [RF] Several code generation optimizations These are done to reduce the size of the generated code. 20 March 2024, 21:27:02 UTC
8a25fa0 [RF][Windows] Re-enable `testRooFuncWrapper` Re-enable `testRooFuncWrapper` with recent versions of Visual Studio 20 March 2024, 21:10:21 UTC
d1e4a10 Very long text string generated a wrong SVG file (#14590) 20 March 2024, 15:02:40 UTC
b13d527 [RF] Avoid deprecated `createIterator()` function in RooStats tutorials 20 March 2024, 14:46:20 UTC
c4aa595 [ntuple] improve error message when writing fails (#15007) * If RNTupleWriter::Write() fails throw exception with error description * Interpret rc=True as error (duh) * Delete .asetup.save Random external file sneaked into the source area * [ntuple] code style fixes --------- Co-authored-by: Marcin Nowak <Marcin.Nowak@cern.ch> Co-authored-by: Marcin Nowak <89531362+Nowakus@users.noreply.github.com> 20 March 2024, 13:14:19 UTC
112bc65 [http] provide full path to html files in tutorials While macro may be run not from the same dir, use path to the macro to load HTML file via such path 20 March 2024, 12:17:39 UTC
f413b08 [http] adjust syntax Use `while(auto obj = next())` together with TIter Simplify const char* scanning Format some parts 20 March 2024, 12:17:39 UTC
436422d [http] do not use ProcessLine to create sniffer To avoid potential memory leak from interpreter, call cl->New() for full sniffer class. 20 March 2024, 12:17:39 UTC
d11e407 [http] do not use plain Form() macro Replace by TString::Format 20 March 2024, 12:17:39 UTC
2baa643 [skip-ci][ci] Enable master-like workflow dispatch 20 March 2024, 10:15:41 UTC
7123cbe [RF] Disable RooFit AD tests on Windows They need to be temporarily disabled until a fix is available in clad. 20 March 2024, 09:46:49 UTC
36edc8f [PyROOT] Use Python standard function to get system endianness As per the doc at https://docs.python.org/3/library/sys.html#sys.byteorder 19 March 2024, 17:34:28 UTC
bd1943b [skip-ci] Fix TColor inline code (#15017) * [skip-ci] Fix TColor inline code * more fixes * more auto 19 March 2024, 17:26:49 UTC
452df70 [DF][Windows] Disable df035_RDFFromPandas Disable `df035_RDFFromPandas.py` test until a proper fix is found 19 March 2024, 17:01:13 UTC
7b8e293 [relnotes] Mention cppyy upgrade in release notes 19 March 2024, 16:42:37 UTC
5fb5b46 [PyROOT] Adopt to no conversion from `char[]` to Python `str` 19 March 2024, 16:42:37 UTC
6d35352 [PyROOT] Update reference counter reference value for Numba tests The reference count in Python is usually quite fragile to implementation changes, so it's not too surprising that some counts change with the `CPyCppyy` upgrade. 19 March 2024, 16:42:37 UTC
d86a31b [cppyy-backend] Minimal updates to use the most recent CPyCppyy Other than the `cppyy` Python library and the `CPyCppyy` CPython extension, the `cppyy-backend` can't easily be synchronized with upstream. The reason is that it depends both on patches to cling and to ROOT meta. There is no bookkeeping on the patches to ROOT meta which is complicating things, and the patches might also interfere with other ROOT functionality. A possible synchronization of ROOT meta is also not worth the effor for another reason: it will be replaced by libInterOp in the future in the context of cppyy and PyROOT. Furthermore, synchronizing the backend would not result in fixing any further reported ROOT issues. Therefore, only minimal changes were made to the `cppyy-backend` in the cppyy upgrade. 19 March 2024, 16:42:37 UTC
760b6cc [PyROOT] Update to a patched version of current cppyy `master` This was done with the `sync-upstream` script, introduced in the last commit. 19 March 2024, 16:42:37 UTC
67ea533 [PyROOT] Add cppyy synchronization script and update patches The added script will be used to synchronize `cppyy` and `CPyCppyy`, applying some patches that are necessary for ROOT. 19 March 2024, 16:42:37 UTC
f447ec6 Revert "[PyROOT] Forward compatibility of pretty printing with CPyCppyy" This reverts commit d5efd703aa846ed07fa469b8cc09dbe18239655a. We are patching the automatic conversion to Python strings back in, so it's not necessary to Pythonize a `__str__` funciton implementing it in C++. Also, the `hasattr(foo, "___cpp__str")` caused a *huge* performance it in some cases, because looking up a non-existing attribute in cppyy can be quite expensive. All base classes are crawled too, and that invokes the interpreter and string manipulation. 19 March 2024, 16:42:37 UTC
1929ea5 Avoid memory leak in TROOT::GetFunction() (#14969) If function call multiple times with non-existing function name, each call causes invocation of interpreter. If repeated many times, it may crash ROOT Simple reproducer: ``` for (int n=0;n<1000000;++n) gROOT->GetFunction("any"); ``` Remove usage of global ROOT mutex Use atomic boolean to control loading of standard functions Call interpreter from lambda to ensure correct initialization in case of multi-threading 19 March 2024, 16:11:10 UTC
bbe66f3 [ci] Re-enable builds on pushes without this, the artifacts are not created and PR builds can become very slow This reverts commit 22045379140ff4673f05ddae96193e606b6bc5d5. 19 March 2024, 14:59:18 UTC
16e51c9 [PyROOT] Avoid the interpreter to query info for array pythonizations Substitute the C++ functions GetSizeOfType and GetDataPointer in our CPython extension library for the equivalent cppyy functions. 19 March 2024, 14:46:30 UTC
46e5350 [RF] Factor out common code of RooNLLVarNew implementation Co-authored-by: Abhigyan Acherjee <abhiacherjee@Abhigyans-MacBook-Air.local> 19 March 2024, 13:32:25 UTC
f834428 [webgui] set selected pad in TWebCanvas In TPad::WaitPrimitive method selected pad is used to check which mouse button or key was pressed While key events already delivered to the ROOT application, only selected oad was missing to make WaitPrimitive working. Now it will block TWebCanvas until double-click in the frame. Editor mode will be implemented separately only in the ROOT master. 19 March 2024, 12:33:10 UTC
282c72d Fix error in TGaxis::ChangeLabelByValue docu macro Use proper arguments, make similar output as with TGaxis::ChangeLabel 19 March 2024, 09:04:43 UTC
d41a009 Make links to json spec files (#14959) 19 March 2024, 08:50:57 UTC
d85c49a [jsroot] better TH2Poly support Handle line and fill attribute from individual bins Support "p" and "*" for markers drawing Switch off color draw optimization Now JSROOT should be very close to ROOT graphis 18 March 2024, 12:56:29 UTC
988dc07 [skip-ci] fix the doc namespaces clean up (#14980) 18 March 2024, 12:28:10 UTC
4b75e2a [RF] Support for RooEfficiency in the RooFit code generation backend 17 March 2024, 11:31:33 UTC
3c1fa5d [ci] Remove unused file 16 March 2024, 16:56:09 UTC
ef731b6 [ci] Modify scheduled build time for old branches namely to 1 build/day for 6.26 and 2 builds/day for 6.28. 16 March 2024, 14:47:02 UTC
702c563 [PyROOT] Correct typo in the name of a helper function 16 March 2024, 13:47:52 UTC
00c87cb [roofit] missed some: do not use whole std namespace, just what's needed 16 March 2024, 12:31:22 UTC
f103627 [tutorials] do not use whole std namespace, only what's needed This has no impact, it's just to align with Clang's coding standard https://opensource.apple.com/source/lldb/lldb-112/llvm/docs/CodingStandards.html#ll_ns_std and to enforce good practices in students reading the tests 16 March 2024, 12:31:22 UTC
ebf094d [test] do not use whole std namespace, only what's needed This has no impact, it's just to align with Clang's coding standard https://opensource.apple.com/source/lldb/lldb-112/llvm/docs/CodingStandards.html#ll_ns_std and to enforce good practices in students reading the tests 16 March 2024, 12:31:22 UTC
ffc89fa Import a Pandas data frame to RDataFrame 16 March 2024, 11:13:46 UTC
47b1d3f [ci] Schedule only once per day 16 March 2024, 05:28:24 UTC
back to top