| 544d84f | moneta | 06 December 2023, 16:54:50 UTC | [tmva][sofie] Fix failing GNN Python tutorial and dependency Fix the dependency of the GNN C++ Application tutorial from the Python parser tutorial. Add Parser tutorial directly by hand since previous way of secifying the dependency did not work in this case. Need to specify the cling include pathin TMVA_SOFIE_GNN_Application.C to be sure that the generated headers are found whne running from ctest | 07 December 2023, 09:41:01 UTC |
| 59dee69 | moneta | 04 December 2023, 10:08:35 UTC | [tmva][sofie] Modify sofie_gnn.py test for changes in the GNN_Data for edge indices | 04 December 2023, 10:08:35 UTC |
| 418302d | moneta | 28 November 2023, 16:41:21 UTC | [tmva][sofie] Use RTensor<int> for the GNN edge index data Instead of a vector of receivers and senders use a common tensor of shape (2, number of edges) for the edge index conections (receivers senders). This is in line with pytorch geomoetric data structure Improve tutorial for parsing the model and for run the model Fix also tutorial dependency | 28 November 2023, 17:08:03 UTC |
| 3221e65 | moneta | 13 November 2023, 14:12:33 UTC | [tmva][sofie] Add support for variable number of nodes and edges | 24 November 2023, 11:12:07 UTC |
| 6f3169e | Jonas Hahnfeld | 09 November 2023, 14:33:52 UTC | Remove queuing mechanism from TBufferMerger At least according to my limited tests, this is equally fast because it avoids the overhead of preparing a TBufferFile for queuing, and uses less memory. | 24 November 2023, 09:14:41 UTC |
| 3d59a5b | Jonas Hahnfeld | 09 November 2023, 12:54:12 UTC | Limit memory usage of TBufferMerger Instead of letting the buffer queue grow without bound, limit it to at most one buffer per attached file. | 24 November 2023, 09:14:41 UTC |
| 6ff6266 | Jonas Rembser | 23 November 2023, 15:50:56 UTC | [CMake] Always build Minuit2 In the discussion thread to JIRA ticket ROOT-10864, Axel suggested the removal of the option to disable minuit2 as a possible solution. I think this is a very good idea good idea, because: * Minuit2 only depends on `Hist` and `MathCore` anyway. * Now that Minuit2 is the default for *all* minimization in ROOT, building ROOT without Minuit2 changes the behavior of ROOT way too much, in a ways that people that set `minuit2=OFF` probably are not intending or aware of. This closes the following JIRA ticket: https://sft.its.cern.ch/jira/browse/ROOT-10864 | 23 November 2023, 19:34:41 UTC |
| 46642ca | Jonas Rembser | 12 May 2023, 20:15:56 UTC | [math] Use `EXPECT_DOUBLE_EQ` in test_tprofile2poly.cxx As seen in #9601, using `EXCEPT_NEAR` with an absolute error is not so good, because if the numbers are large the hardcoded absolute error can be smaller than the double precision. In these cases, `EXPECT_DOUBLE_EQ` is recommended instead. | 23 November 2023, 14:51:47 UTC |
| 2d3ce86 | Sergey Linev | 22 November 2023, 08:58:52 UTC | Use rootgeom.C in demos.C Show in central demo tutorial new geometry classes | 23 November 2023, 08:59:05 UTC |
| a075da4 | Sergey Linev | 21 November 2023, 11:32:41 UTC | [webgui] improve handling of embed widgets In RBrowser different widgets are embed. Add dummy pending connection handle to get possibility for widget wait for such connection been established | 23 November 2023, 08:59:05 UTC |
| 386cc18 | Florine de Geus | 22 November 2023, 09:42:54 UTC | [ntuple] Add support for `std::unordered_map` fields | 23 November 2023, 07:34:59 UTC |
| cd55619 | Jonas Rembser | 21 November 2023, 22:54:07 UTC | [RF] Implement more `clang-tidy` suggestions in RooFit | 22 November 2023, 13:17:55 UTC |
| 0956039 | Jonas Rembser | 21 November 2023, 16:59:45 UTC | [RF] RooFit documentation improvements Most importantly, specify what "RooFit" should link to in some cases: the main RooFit documentation instead of the namespace documentation. | 22 November 2023, 13:17:55 UTC |
| 1dc43a6 | Jonas Rembser | 21 November 2023, 14:34:45 UTC | [RF] Move `RooUnitTest` out of public interface The `RooUnitTest` is not meant to be part of the public user inferface, it is only used for internal tests. | 22 November 2023, 13:17:55 UTC |
| 39cfecb | QuillPusher | 04 November 2023, 17:59:45 UTC | [RF] Address change requests by Jonas in the RooFit AD support document These changes are on top of the first draft that I submitted, that was merged as part of [PR13929}(https://github.com/root-project/root/pull/13929). The requested changes can be tracked in my personal drafts repo [here](https://github.com/QuillPusher/QP_Drafts/pull/3). Changes: - RooFit intro before AD support -> already covered in "Overview on RooFit implementation details..." section by @guitargeek - **Extracting free functions** to a separate header file is **optional**, re-wrote it as one of the two currently recommended approaches - changed to "Support **Code Generation**" instead of "AD Support" in most places - minor formatting and spelling errors changed - added fully qualified function names in some places for better Doxygen rendering - Removed random commit IDs and added branch name to repo links | 22 November 2023, 13:17:55 UTC |
| 6e2b804 | Sergey Linev | 21 November 2023, 17:31:46 UTC | [jsroot] dev 21/11/2023 Support custom fonts in TWebCanvas Support in-browser PDF generation Respect IsEditable flag of canvas Several fixes in TLatex processing | 22 November 2023, 12:35:13 UTC |
| 513c6ec | Sergey Linev | 20 November 2023, 12:53:27 UTC | [webcanvas] add support for custom fonts Let add font to the web canvas and use it for any kind of objects. Custom font index only will work with web canvas | 22 November 2023, 12:35:13 UTC |
| 952dbf6 | Jakob Blomer | 21 November 2023, 21:57:44 UTC | [ntuple] simplify expression in RDF DS | 22 November 2023, 11:56:58 UTC |
| dc110b3 | Jakob Blomer | 21 November 2023, 14:11:46 UTC | [ntuple] improve clarity of unit test Co-authored-by: Florine de Geus <git@fwdg.nl> | 22 November 2023, 11:56:58 UTC |
| 5602ead | Jakob Blomer | 13 November 2023, 21:07:01 UTC | [ntuple] use cluster boundaries in RDF iteration - Respect cluster boundaries when assigning entry ranges to slots - Add RPageSource::SetEntryRange to avoid cluster read-ahead into other slots entry range | 22 November 2023, 11:56:58 UTC |
| 1844e61 | Florine de Geus | 21 November 2023, 14:25:27 UTC | [ntuple] Move includes to correct header file | 22 November 2023, 11:55:44 UTC |
| 2549c34 | Florine de Geus | 22 November 2023, 09:47:46 UTC | [NFC][ntuple] Add `std::unordered_set` to specification | 22 November 2023, 10:31:43 UTC |
| ceea794 | Jan Musinsky | 22 November 2023, 07:17:35 UTC | small improvements in sqlite3_prepare * [sqlite] sqlite3_prepare with tail info * [sqlite] tail nullptr | 22 November 2023, 07:17:35 UTC |
| 7d500ff | Sergey Linev | 21 November 2023, 07:32:09 UTC | [webgui] use loopback by default Default value is on in C++ code, but was remained off in system.rootrc and over-rulling C++ | 21 November 2023, 17:03:59 UTC |
| 1dbb353 | Alexander Neumann | 24 April 2023, 21:47:53 UTC | Don't check CMAKE_GENERATOR use MSVC instead | 21 November 2023, 13:07:54 UTC |
| a1f51ac | Olivier Couet | 21 November 2023, 13:00:44 UTC | [skip-ci] Update fonts' documentation (CMS request) (#14049) * Update fonts' documentation (CMS request) * Revisit the font description * Small rephrasing * Update the font table in TTF.cxx to be compatible with the one in TAttText.cxx | 21 November 2023, 13:00:44 UTC |
| 32b80ad | Florine de Geus | 20 November 2023, 11:29:18 UTC | [ntuple] Add inner field type check for `std::map` fields Inner fields *must* be of type `RPairField`. Ideally this should be done at compile time through the constructor argument type, but this is still causing issues and needs further investigation. Thus, this runtime check is added as a temporary solution. | 21 November 2023, 12:47:18 UTC |
| b1057b5 | Florine de Geus | 16 November 2023, 11:37:27 UTC | [ntuple] Add missing include and dictionary entries Necessary for builds without runtime modules enabled. | 21 November 2023, 12:47:18 UTC |
| d21d888 | Florine de Geus | 25 October 2023, 12:09:00 UTC | [ntuple] Remove use of `offsetof` macro for `std::pair` fields This macro is conditionally supported and with the addition of `std::map` fields, compilation warnings will be thrown for nested maps. To prevent these warnings, the offsets are determined in a similar way to `std::tuple` fields. | 21 November 2023, 12:47:18 UTC |
| 336d6dc | Florine de Geus | 20 October 2023, 14:49:48 UTC | [ntuple][NFC] Add specification for `std::map` fields | 21 November 2023, 12:47:18 UTC |
| 1e0e023 | Florine de Geus | 20 October 2023, 10:16:36 UTC | [ntuple] Add support for `std::map` fields | 21 November 2023, 12:47:18 UTC |
| 032358f | Florine de Geus | 17 November 2023, 12:57:48 UTC | [ntuple] Move STL dictionary entries to separate file | 21 November 2023, 08:03:39 UTC |
| 69a324d | Florine de Geus | 10 November 2023, 11:02:20 UTC | [NFC][readspeed] Improve usage text formatting | 20 November 2023, 11:46:58 UTC |
| 1f3b75d | Florine de Geus | 16 November 2023, 12:44:16 UTC | [ntuple] Add support for `std::unordered_set` fields | 20 November 2023, 09:58:19 UTC |
| cddecc1 | Jonas Rembser | 18 November 2023, 00:01:52 UTC | Improve vetoing of HistFactory and RooStats tutorials * Make Python versions of RooStats tutorials depend on test data * Veto all RooStats tutorials if XML is not found, for simplicity | 20 November 2023, 08:49:11 UTC |
| b9edc47 | Jonas Rembser | 15 November 2023, 13:02:49 UTC | [RF] Use RooGenericPdf instead of custom code in RooStats tutorials This reduces the complexity of the tutorials a bit. I checked that tutorial results and runtime were unaffected. | 20 November 2023, 08:49:11 UTC |
| df75305 | Jonas Rembser | 18 November 2023, 00:36:17 UTC | [RF] Add initial `.clang-tidy` config to RooFit inspired by CMSSW Only two checks were removed from the config, because the replace copies with `const` references using the too loose heuristic of assuming only calling `const` functions on them is okay: * performance-for-range-copy * performance-unnecessary-copy-initialization | 20 November 2023, 08:44:18 UTC |
| 8c5e888 | Jonas Rembser | 18 November 2023, 00:35:44 UTC | [RF] Apply remaining `clang-tidy` suggestions from CMSSW style | 20 November 2023, 08:44:18 UTC |
| 58c4066 | Jonas Rembser | 17 November 2023, 21:33:52 UTC | [RF] Replace usage of `RooAbsCollection::getSize()` with `size()` This is done to be more aligned with the STL style. In particular, that helps code analysis tools like `clang-tidy`. | 20 November 2023, 08:44:18 UTC |
| 30e1516 | Jonas Rembser | 17 November 2023, 02:33:04 UTC | [RF] Replace all C-style casts with C++ casts Again, thanks to clang-tidy with a bit of manual intervention. This makes it much easier to reason about the code, with the correct distinction between `static_cast`, `const_cast`, and `reinterpret_cast`. | 20 November 2023, 08:44:18 UTC |
| 2d5977f | Jonas Rembser | 16 November 2023, 16:43:26 UTC | [RF] Deprecate RooFit legacy iterators The STL-compatible alternatives are now around long enough (since ROOT 6.18, 4 years ago) so after this grace period it is time to deprecate and eventually remove the old iterators. | 19 November 2023, 21:53:10 UTC |
| bce6451 | Jonas Rembser | 13 November 2023, 23:16:24 UTC | [hist] Avoid `try-catch` in TH1 Using exceptions to handle the cases where a regular check for consistency like `TH1::CheckConsistency()` fails is not great for code readability, performance, debugging, etc. Exceptions should only happen in *unexpected* cases. These expected inconsistency check results should better be encoded in the return value. | 17 November 2023, 15:27:05 UTC |
| 19ed1bc | Jonas Rembser | 16 November 2023, 20:06:41 UTC | [RF] Prefer member initializers and default member initialization Apply the suggestions by the following two checks: * `cppcoreguidelines-prefer-member-initializer` * `modernize-use-default-member-init` This makes the code much less verbose and avoids possible mistakes in the initialization. I carefully went over the changes manually to make sure that they are correct. | 17 November 2023, 13:30:27 UTC |
| 18b789c | Jakob Blomer | 14 November 2023, 14:48:06 UTC | [io] adjust RRawFile/XRootD unit test to new target | 16 November 2023, 15:44:30 UTC |
| 1b8c060 | Olivier Couet | 16 November 2023, 15:01:29 UTC | Avoid CDT doc in ROOT doc (#14066) | 16 November 2023, 15:01:29 UTC |
| 479d383 | Sergey Linev | 15 November 2023, 16:50:24 UTC | [webgui] try to convince Firefox close window | 16 November 2023, 09:39:41 UTC |
| bb42361 | Sergey Linev | 15 November 2023, 15:27:52 UTC | [webgui] improve handling of $profile argument Avoid double slash, Correctly replace it in exec string Catch other singals in trap command of runfirefox.sh | 16 November 2023, 09:39:41 UTC |
| 8827e11 | Sergey Linev | 15 November 2023, 12:10:52 UTC | [webgui] prevent firefox ask questions about upload Was already disabled for headless mode, but also should be done for interactive mode | 16 November 2023, 09:39:41 UTC |
| cee1000 | Sergey Linev | 14 November 2023, 16:55:49 UTC | [webgui] introduce runfirefox.sh script It is required to correctly cleanup temporary directory with custom profile after exit of firefox | 16 November 2023, 09:39:41 UTC |
| 12aaeda | Sergey Linev | 14 November 2023, 15:36:38 UTC | [webgui] imrpove Firefox handling There are no command line options for firefox for many settings. Therefore one have to create custom profile and put such custom settings there. These are: visibility of URL string and visibility of tabs widget. Also custom profile allows to provide wiidget width and height. The only drawback for now - after deletion of such custom profile firefox still writes some modified files back. | 16 November 2023, 09:39:41 UTC |
| fb71268 | Jonas Hahnfeld | 15 November 2023, 13:08:51 UTC | [core] Allow deprecations for 6.34 | 16 November 2023, 08:47:12 UTC |
| b3c7568 | Jonas Hahnfeld | 15 November 2023, 13:06:47 UTC | [core] Remove RGitCommit.h Its contents were deprecated with 6.30 and it was supposed to be removed after branching, ie master becoming 6.31. | 16 November 2023, 08:47:12 UTC |
| 9040490 | Jonas Hahnfeld | 15 November 2023, 13:00:58 UTC | [mathcore] Remove long deprecated interfaces | 16 November 2023, 08:47:12 UTC |
| d369148 | Jonas Hahnfeld | 15 November 2023, 12:59:52 UTC | [core] Fix R__NO_DEPRECATION on Windows | 16 November 2023, 08:47:12 UTC |
| 38edd36 | Sergey Linev | 15 November 2023, 15:14:30 UTC | Change default TColor resolution TColor::GetColor(r,g,b) uses 5bit threshold by default to create new colors. This differs from normal X11 with 8bit colors. As a result, images produced in batch and in interactive session may differ - see greyscale.C macro. Make default 8bit resolution for colors, and reduce it only if detecting such display. | 16 November 2023, 07:26:52 UTC |
| 449f50b | Jonas Rembser | 28 January 2023, 22:04:58 UTC | [RF] Comment out unreachable code in `RooDstD0BG` | 15 November 2023, 16:31:13 UTC |
| 8197026 | Jonas Rembser | 28 January 2023, 21:58:17 UTC | [RF] Code format `RooDstD0GB.h/.cxx` files The next commit will change many lines in theses files, so they are formatted now. | 15 November 2023, 16:31:13 UTC |
| 8d5f49a | Jonas Rembser | 31 May 2023, 19:34:01 UTC | [RF] Avoid manual memory management via `takeOwnership()` | 15 November 2023, 16:31:13 UTC |
| 5989d5d | Jonas Rembser | 13 November 2023, 17:21:41 UTC | [RF] Replace final use of legacy iterators | 15 November 2023, 16:31:13 UTC |
| 7762699 | Jonas Rembser | 07 November 2023, 17:39:32 UTC | [RF] Code modernization of `roofitcore` In particular, remove explicitly declared default destructors and constructors. | 15 November 2023, 16:31:13 UTC |
| dacbb2a | Jonas Rembser | 15 November 2023, 14:12:47 UTC | [TMVA] Remove workaround from the CINT era Since cling can deal with `dynamic_cast` correctly, the `TMVA::Reader::FindCutsMVA()` workaround is not needed anymore. That's one of the changes necessary to address #10058. | 15 November 2023, 16:31:00 UTC |
| 19b6e6e | Olivier Couet | 15 November 2023, 15:33:07 UTC | Replace triangle.c by CDT (#14036) * Replace triangle.c by CDT * Fix warnings and test * Remove old code * Make sure local variables do not shadow CDT ones * Fix warnings in CDT * Update release notes | 15 November 2023, 15:33:07 UTC |
| db6ff45 | ferdymercury | 15 November 2023, 12:25:51 UTC | [TGNumberEntry] add centisecond display option Adds support for centiseconds in TGNumberentry. | 15 November 2023, 12:25:51 UTC |
| a10884c | ferdymercury | 15 November 2023, 10:18:40 UTC | [TMVA] fix some inconsistencies and warnings found by doxygen Fixes several doxygen warnings in TMVA. | 15 November 2023, 10:18:40 UTC |
| c6c1599 | Jonas Rembser | 14 November 2023, 17:17:54 UTC | Some improvements to RooStats tutorials, in particular Python versions * Get rid of checks if files or objects in the file were found. It's ROOTs responsability to error out nicely if something is not found, not the responsability of the tutorials * Use f-formatting in Python to be more concise * Use Python iteration patters * Use pythonic `len()` instead of `GetSize()` * Use native Python string instead of `TString` * In Python, one can retrieve objects in the `RooWorkspace with `workspace[obj_name]` independent of the type, which is preferred because it's more Pythonic | 14 November 2023, 22:28:41 UTC |
| bad90a5 | Jonas Rembser | 14 November 2023, 17:15:50 UTC | [RelNotes] Add Akeem Hart to the list of contributors For his translations of RooStats tutorials | 14 November 2023, 22:28:41 UTC |
| df2aaa7 | Jonas Rembser | 14 November 2023, 16:44:04 UTC | Fix typos in `math` and `histfactory` tutorials and others | 14 November 2023, 22:28:41 UTC |
| 030f599 | Akeem L Hart | 29 August 2023, 02:31:43 UTC | Translated StandardProfileInspectorDemo and StandardProfileLikelihoodDemo to pyROOT | 14 November 2023, 22:28:41 UTC |
| 84b5b3a | Sergey Linev | 13 November 2023, 15:23:58 UTC | Update stressgraphics reference for TLatex | 14 November 2023, 16:57:45 UTC |
| 3a53ad6 | Sergey Linev | 13 November 2023, 14:54:26 UTC | Format code around `#tilde` processing | 14 November 2023, 16:57:45 UTC |
| 14b0887 | Sergey Linev | 13 November 2023, 10:23:11 UTC | Scale line width when draw #check and #slash symbols Adjust a bit #slah symbol position | 14 November 2023, 16:57:45 UTC |
| e0ed96a | Sergey Linev | 13 November 2023, 10:07:28 UTC | Fix position of #grave and #acute latex symbols Use line width scaling | 14 November 2023, 16:57:45 UTC |
| c3da092 | Sergey Linev | 13 November 2023, 09:47:04 UTC | Draw #dot and ##dot in latex as small filled rectangle With previous implementation dot with large scale was transformed into short line. Now minimal dot size is 2 pixels - aka default line width in TLatex | 14 November 2023, 16:57:45 UTC |
| a8133b9 | Sergey Linev | 13 November 2023, 09:12:07 UTC | Use scalable line width in #bar and #vec latex symbols Simplify logic how vertical position is defined for #hat Use at least line width configured before | 14 November 2023, 16:57:45 UTC |
| 6dc6044 | Sergey Linev | 13 November 2023, 08:38:47 UTC | Use const reference on TextSpec_t in TLatex method No need to copy members for TextSpec_t object which should not be changed | 14 November 2023, 16:57:45 UTC |
| a1bdb59 | Mattias Ellert | 03 July 2022, 06:18:57 UTC | Increase test timeout | 13 November 2023, 23:57:28 UTC |
| f1b7008 | Mattias Ellert | 23 February 2023, 21:10:46 UTC | Use consistent wording of the comments in the different TMVA classification tests to avoid confusion. | 13 November 2023, 18:36:22 UTC |
| 25ce7f5 | Mattias Ellert | 14 October 2023, 13:51:16 UTC | src/RBDT.cxx is a source file of libTMVAUtils and should not also be a source file of libTMVA. Remove it. Adjust test using symbols defined in this source file to link to libTMVAUtils instead of libTMVA. | 13 November 2023, 18:12:49 UTC |
| 27082fb | Jonas Rembser | 07 November 2023, 12:36:23 UTC | [math][minuit2] Don't try to copy non-existing file in standalone build Follows up on 8ce465cc41c. That commit introduced two months ago a copying of the `ROOTConfig-version.cmake` file to the Minuit 2 standalone build dir. However, this file is only available after building ROOT, as it's generated from the `ROOTConfig-version.cmake.in` template. A ROOT build should not be required for Minuit 2 standalone. Therefore, this commit suggests a different way to get the ROOT version number: by inspecting the header files from the ROOT source. | 13 November 2023, 14:32:28 UTC |
| dfe59e2 | Jonas Rembser | 07 November 2023, 12:16:35 UTC | [math] Remove again the `R__HAS_MINUIT2` macro I recently introduced a `R__HAS_MINUIT2` macro when moving to Minuit 2 as the default. Introducing this macro broke the standalone build of `mathcore`, because `RConfig.h` was now required. This commit is avoiding that by using cmake definitions instead. Follows up on 6866a574597. | 13 November 2023, 14:32:28 UTC |
| b3a0a0b | Jonas Rembser | 12 November 2023, 13:08:10 UTC | [DF] Avoid unused parameter warning in RDF ActionHelpers This avoids the following warning when building `rootbench` (gcc 13.2.1): ```txt In file included from /home/rembserj/spaces/master/root/src/build/include/ROOT/RDF/RInterface.hxx:15, from /home/rembserj/spaces/master/root/src/build/include/ROOT/RDataFrame.hxx:21, from /home/rembserj/spaces/master/root/src/root/rootbench/root/tree/dataframe/RDataFrameBenchmarks.cxx:1: /home/rembserj/spaces/master/root/src/build/include/ROOT/RDF/ActionHelpers.hxx: In instantiation of ‘void ROOT::Internal::RDF::SnapshotHelperMT<ColTypes>::UpdateCArraysPtrs(unsigned int, ColTypes& ..., std::index_sequence<S ...>) [with long unsigned int ...S = {}; ColTypes = {}; std::index_sequence<S ...> = std::integer_sequence<long unsigned int>]’: /home/rembserj/spaces/master/root/src/build/include/ROOT/RDF/ActionHelpers.hxx:1747:27: required from ‘void ROOT::Internal::RDF::SnapshotHelperMT<ColTypes>::Exec(unsigned int, ColTypes& ...) [with ColTypes = {}]’ /home/rembserj/spaces/master/root/src/build/include/ROOT/RDF/RAction.hxx:104:19: required from ‘void ROOT::Internal::RDF::RAction<Helper, PrevNode, ColumnTypes_t>::CallExec(unsigned int, Long64_t, ROOT::TypeTraits::TypeList<ColTypes ...>, std::index_sequence<_Ind ...>) [with ColTypes = {}; long unsigned int ...S = {}; Helper = ROOT::Internal::RDF::SnapshotHelperMT<>; PrevNode = ROOT::Detail::RDF::RLoopManager; ColumnTypes_t = ROOT::TypeTraits::TypeList<>; Long64_t = long long int; std::index_sequence<_Ind ...> = std::integer_sequence<long unsigned int>]’ /home/rembserj/spaces/master/root/src/build/include/ROOT/RDF/RAction.hxx:112:18: required from ‘void ROOT::Internal::RDF::RAction<Helper, PrevNode, ColumnTypes_t>::Run(unsigned int, Long64_t) [with Helper = ROOT::Internal::RDF::SnapshotHelperMT<>; PrevNode = ROOT::Detail::RDF::RLoopManager; ColumnTypes_t = ROOT::TypeTraits::TypeList<>; Long64_t = long long int]’ /home/rembserj/spaces/master/root/src/build/include/ROOT/RDF/RAction.hxx:108:9: required from here /home/rembserj/spaces/master/root/src/build/include/ROOT/RDF/ActionHelpers.hxx:1760:40: error: parameter ‘slot’ set but not used [-Werror=unused-but-set-parameter] 1760 | void UpdateCArraysPtrs(unsigned int slot, ColTypes &... values, std::index_sequence<S...> /*dummy*/) ``` I'm sure similar warnings also pop up in other places, but I just happened to notice them in `rootbench`. | 13 November 2023, 13:23:06 UTC |
| 9d7aa4a | Jonas Rembser | 11 November 2023, 12:14:02 UTC | [DF] Avoid public dependency of RDataFrame on `nlohmann::json` It's better if the RDataFrame doesn't depend on `nlohmann::json` for this reason: If you build ROOT **without** the builtin nlohmannjson, it finds the json header with `find_package(nlohmann_json)`, which is fine. However, if the `nlohmann/json.hpp` header is not in the default include path, one is now forced to also do `find_package(nlohmann_json)` in every compiled project that uses RDataFrame! This happened to one of our students recently, which is why I got aware of the problem. On most Linux systems, this is not a problem because `json.hpp` is in a standard location, but for macOS this doesn't seem to be the case necessarily. | 13 November 2023, 13:22:56 UTC |
| 52bf59d | ferdymercury | 13 November 2023, 13:13:51 UTC | [core] Counterpart of Pythons `str.join` function in C++ This complements the existing `ROOT::Split()` function. | 13 November 2023, 13:13:51 UTC |
| 04ec405 | Sergey Linev | 13 November 2023, 08:23:10 UTC | Adjust stressGraphics reference for changed TLatex | 13 November 2023, 12:31:53 UTC |
| 048f20b | Sergey Linev | 10 November 2023, 16:26:11 UTC | Improve latex drawing for `#hat{f}` Several letters like f are taller than normal x or a and not match to the remaining space. Therefore for such letters lift it higher Also scale line width used to draw hat. For large letter it looked not very nice. | 13 November 2023, 12:31:53 UTC |
| b62ce9d | Stephan Lachnit | 02 August 2023, 09:10:01 UTC | [cmake] Bump minimum CMake version to 3.10 CMake v3.10 is the version included in Ubunut 18.04 LTS. | 13 November 2023, 09:13:10 UTC |
| eeb564e | DanteNiewenhuis | 24 July 2023, 15:33:28 UTC | Changed filters used by RBatchGenerator to a single string Changed the internal handeling of filters in RBatchGenerator. Instead of adding a new filter for each filter, the filters are concatenated to a string and applied as a single filter Note: The Python interface of the RBatchGenerator does not change. | 13 November 2023, 09:12:46 UTC |
| eca07cf | Jonas Hahnfeld | 09 November 2023, 14:43:16 UTC | [ntuple] Update comment in ntpl004_dimuon.C Commit cf78f40d60 made it use the RVec collection type. | 12 November 2023, 12:42:43 UTC |
| 21290a4 | Florine de Geus | 10 November 2023, 16:19:48 UTC | [ntuple] Add packing tests for half-precision floats | 12 November 2023, 12:39:07 UTC |
| ff74d44 | Florine de Geus | 11 October 2023, 17:01:23 UTC | [ntuple] Add support for half-precision floats | 12 November 2023, 12:39:07 UTC |
| ceef4a2 | Florine de Geus | 16 October 2023, 16:09:29 UTC | [v7] Add conversion to and from half-precision floats | 12 November 2023, 12:39:07 UTC |
| c5048fa | Jonas Rembser | 02 November 2023, 21:20:14 UTC | Apply suggestions from clang-tidy to `dataframe` and `rntuple` Applies the clang-tidy suggestions from the following checks, which are the same as in the CMSSW `.clang-tidy`, only that the checks that replace copies with `const` references are removed: ``` ,boost-use-to-string, ,misc-definitions-in-headers, ,misc-string-compare, ,misc-uniqueptr-reset-release, ,modernize-deprecated-headers, ,modernize-make-shared, ,modernize-make-unique, ,modernize-use-bool-literals, ,modernize-use-equals-delete, ,modernize-use-nullptr, ,modernize-use-override, ,performance-inefficient-algorithm, ,performance-inefficient-vector-operation, ,performance-faster-string-find, ,performance-move-const-arg, ,readability-container-size-empty, ,readability-redundant-string-cstr, ,readability-static-definition-in-anonymous-namespace, ,readability-uniqueptr-delete-release ``` | 10 November 2023, 15:10:40 UTC |
| 8e460c3 | Sergey Linev | 10 November 2023, 11:47:01 UTC | [jsroot] dev 10/11/2023 with TWebCanvas adjustments Use new object referencing in TWebCanvas. Now functions, sub-histograms and sub-graphs are referenced as secondary objects via id of master object plus extra string specifier like <tstack_object_id>#hist or <tmultigraph_object_id>#graphs_10. And now such compose objects do not disantagled on server side. Many small fixes: 1. Fix - do not add `THStack` and `TMultiGraph` to legend 2. Fix - correctly use margin in `TPaveText` class 3. Fix - correctly draw endcaps in legend errors 4. Fix - custom color palette usage | 10 November 2023, 14:51:50 UTC |
| a2511a2 | Sergey Linev | 10 November 2023, 10:27:35 UTC | Fix typo in tutorials/graphics/earth.C | 10 November 2023, 14:51:50 UTC |
| 8a6e76e | Sergey Linev | 10 November 2023, 10:27:11 UTC | [webcanvas] correctly handle graphs in TScatter | 10 November 2023, 14:51:50 UTC |
| 1a12ce5 | Sergey Linev | 09 November 2023, 13:38:16 UTC | [webcanvas] "hide" pads primitives when producing canvas json While primitives handled separately, one not need to stream them together with the pad itself. Therefore just set pad->fPrimitives to nullptr before streaming and restore immediately after. This is less disruptive method than before when TLists were cleaned and then rebuild again. | 10 November 2023, 14:51:50 UTC |
| d86bd45 | Sergey Linev | 09 November 2023, 13:18:29 UTC | [webcanvas] handle scatter plot functions same as in other classes Do not try to make flat primitives list but rather use smart referencing on client side. | 10 November 2023, 14:51:50 UTC |
| 0f32f36 | Sergey Linev | 09 November 2023, 09:00:20 UTC | Adjust tutorials/graphs/multigraph.C to show reasonable fit | 10 November 2023, 14:51:50 UTC |
| 01a5392 | Sergey Linev | 08 November 2023, 16:53:34 UTC | [webcanvas] let search for histogram in the pad again One has to scan all primitives. Use special internal string constant | 10 November 2023, 14:51:50 UTC |
| ee66015 | Sergey Linev | 08 November 2023, 13:54:06 UTC | [webcanvas] provide stats and handle functions in TGraph and TMultiGraph In the case when TGraph has function in list of functions, it has to draw stats box. Therefore stats object should be created for TGraph and for all graphs in TMultiGraph. | 10 November 2023, 14:51:50 UTC |
