https://github.com/lmoneta/root

sort by:
Revision Author Date Message Commit Date
6d5013a [tmva][pymva] Changes for new version (1.4) of scikit-learn With new version of scikit-learn the bool parameters must be passed as bool and not anymore as integers. In addition in AdaBoost base_estimator was renamed to estimator 15 March 2024, 09:43:18 UTC
c7200b1 [graphics] Save memory when obtaining TImageDump instance by using TClass instead of the interpreter. As a side effect, the whole process is much faster. fixes an incarnation of #14156, mitigating the overall effect of the highlighted behaviour 14 March 2024, 22:47:39 UTC
88cbe8a [ci] Also publish test results for scheduled builds Like this, we should get a nice test summary also for the nightlies. 14 March 2024, 17:57:47 UTC
13b50d6 [roofit] do not use whole std namespace, only what's needed This has no impact, it's just to align with Clang's coding standard https://opensource.apple.com/source/lldb/lldb-112/llvm/docs/CodingStandards.html#ll_ns_std and to enforce good practices in students reading the tests 14 March 2024, 14:58:03 UTC
3037562 [webgui] assert if key cannot be generated 14 March 2024, 14:45:24 UTC
7116971 [webgui] use gSystem->GetCryptoRandom() to generate keys Used keys length will be 32 bytes or 256 bits. Use hex for string representation. Add in produced string "-" symbols as separator between every 4 bytes Keys string representation will be 32*2 + 7 = 71 characters. Like: fca45856-41bee066-ff74cc96-9154d405-df85aa28-9a0a4794-ae70243f-1ac560f4 14 March 2024, 14:45:24 UTC
23f0ab8 [non-core] do not use whole std namespace, only what's needed This has no impact, it's just to align with Clang's coding standard https://opensource.apple.com/source/lldb/lldb-112/llvm/docs/CodingStandards.html#ll_ns_std and to enforce good practices in students reading the tests 14 March 2024, 14:29:50 UTC
1034db6 [cling] Add deprecation warning for declarations without `auto` (#14645) * [cling] Add deprecation warning for declarations without `auto` Declarations without the auto keyword are not part of standard C++. Even though it is a nice feature to have, it requires a patch on top of clang and is one of the hurdles preventing us from using the upstream clang. Implicit auto injection is currently only supported at the prompt (and only in the top-most function-level scope). So it should ideally not break other features. There are a few GitHub and JIRA issues related to this feature that can also be closed if we completely remove it. * Set severity for diag::warn_deprecated_message manually 14 March 2024, 12:26:10 UTC
74a1027 [hist] provide default values for all TSpline members Ensure that all pointers are initialized 14 March 2024, 08:34:02 UTC
7ed3b03 [hist] fix memory leak in TSpline5 assignment operator 14 March 2024, 08:34:02 UTC
170f793 [hist] not forget to reset pointer after delete If no new memory will be assigned - it will crash in the destructor 14 March 2024, 08:34:02 UTC
a14984f [math] Detach TEventList instances from gDirectory fixes ROOT-8501 14 March 2024, 08:20:06 UTC
2168762 Deprecation of TGeoBBox::AreOverlapping (#14954) 13 March 2024, 16:38:59 UTC
365c48d [Math] Fix typo in generated code fixes ROOT-7801 13 March 2024, 16:22:33 UTC
0823995 [RF] Update xroofit - Bug fix to plotting datasets horizontal error bars - Bug fix to obtaining datasets of reduced pdfs (i.e. get the corresponding reduced dataset) - Beginning to add some documentation for xRooNode - Adds a cling interpreter method for xRooNode to print the names of the child nodes 13 March 2024, 15:01:00 UTC
4279cb9 Fix strict-aliasing compilation warning 13 March 2024, 13:13:06 UTC
8b03359 Provide default argumetns in AllowMultipleRemoteConnections which prevent accidental remote and multiple connectios 13 March 2024, 13:13:06 UTC
ae96dd0 Update RenderCore version with implementation of optimized digit visualization 13 March 2024, 13:13:06 UTC
5fb502b Add function that enables multipple remote connections. 13 March 2024, 13:13:06 UTC
a80e96c Add palette as eve eve-element remove debug print 13 March 2024, 13:13:06 UTC
7dd485f Add palette editor Fix typo in makeFreeBoxSet func name 13 March 2024, 13:13:06 UTC
5439938 Implement REveBoxSet to display any digit shape with instancing. Support different types of per digit transformation. 13 March 2024, 13:13:06 UTC
00e3be7 [ski[-ci][math] Improve documentation of cumulative distributions in TMath Fixes ROOT-7289 13 March 2024, 11:06:29 UTC
04e6b70 [hist] Remove memory leak in TSpline3 copy ctor fixes ROOT-9000. 13 March 2024, 09:30:53 UTC
15d623b [Math] Do not modify dbg message if never printed fixes ROOT_8259. Code by Bastian Beischer. 13 March 2024, 09:27:11 UTC
fad4fb6 [jsroot] dev 12/03/2024 with X/Y range selection 1. Correctly choose X/Y range when painting TH1 2. Take into acount TF1 if it appears in list of TH1 functios 3. Use pad ranges only when first histogram drawn with "SAME" 4. Make scales very close to ROOT logic 5. Correct X range handling for TH1 E3/E4 drawings 13 March 2024, 08:26:24 UTC
1abc8a2 [webcanv] correctly set gPad By interactive actions on the client side gPad may be changed. But when canvas->Update is invoked, gPad is not set by reply. This allows to use macros which changing gPad and calling Update many times - like tutorials/hist/transpad.C 13 March 2024, 08:26:24 UTC
1ff8578 [cmake] Fix version detection for old TBB Even if not supported anymore, we must be able to determine the old TBB versions to *not* pick it up. Add back the check for the previous header that was removed in commit a1d969d8ca. 12 March 2024, 16:45:30 UTC
8bbf9cc [PyROOT] Forward compatibility of user pythonizations with newer cppyy In older cppyy, template instanciations are cached by fully-qualified name directly in the namespace. Therefore, no extra code is required to cover template instances in the pythonization code. With the new cppyy, this is not the case anymore, and instances are instead cached in the `_instatiations` attribute of the template class. This commit considers this, in a way that is backwards compatible also with the older cppyy version that ROOT currently uses. 12 March 2024, 15:39:32 UTC
8352fb7 [PyROOT] Simplify pythonization code 12 March 2024, 15:39:32 UTC
0a521d1 [core] add testing for TSystem::GetCryptoRandom 12 March 2024, 14:36:41 UTC
528017a Implement TUnixSystem::GetCryptoRandom First test which function available on the system. And then use detected one 12 March 2024, 14:36:41 UTC
c2eb6fa Implement TWinNTSystem::GetCryptoRandom Requires usage of Bcrypt.lib 12 March 2024, 14:36:41 UTC
b495268 [core] introduce TSystem::GetCryptoRandom method It should fill provided buffer with cryptographic-strong random values 12 March 2024, 14:36:41 UTC
f134061 [skip-ci][ci] consider only ARM for mac-beta 12 March 2024, 13:04:02 UTC
ce45ae9 [skip-ci] fix typo docu stray braces 12 March 2024, 09:53:53 UTC
06846ee Update core/clingutils/CMakeLists.txt Co-authored-by: Giulio Eulisse <10544+ktf@users.noreply.github.com> 12 March 2024, 09:45:14 UTC
440c730 [runtime_cxxmodules] Fix libcxx on osx15.3 12 March 2024, 09:45:14 UTC
d5efd70 [PyROOT] Forward compatibility of pretty printing with CPyCppyy The pretty-print pythonization should sxclude classes which have the method `__str__` already defined in C++ Since version 1.12.11, CPyCppyy is internally renaming any direct C++ `__str__` attribute to `__cpp_str` and replaces `__str__` with a pythonic wrapper [1]. Therefore, the "CPPOverload" name check below doesn't work anymore with that version. Fortunately, we can just check if the `__cpp_str` attribute exists instead. Still, this code does both checks for maximum compatibility. [1] https://github.com/wlav/CPyCppyy/commit/10b15d8a5950125b8e1f2fbf289b1fc4398a6df6 12 March 2024, 09:29:06 UTC
c76b8f7 Remove __MAKECINT__ 11 March 2024, 20:14:48 UTC
8a96572 Remove the __CINT__ workarounds when parsing. We helped CINT parse complex code and that is not needed anymore. This will help further simpliciations when parsing dictionaries with rootcling. 11 March 2024, 20:14:48 UTC
54bb998 [core] do not use whole std namespace, only what's needed Aligning a bit more with Clang's coding standard https://opensource.apple.com/source/lldb/lldb-112/llvm/docs/CodingStandards.html#ll_ns_std 11 March 2024, 18:47:53 UTC
4ddc2f6 [TTaskGroup] Use global task arena The user expects ROOT to honor their number of threads provided as argument to ROOT::EnableImplicitMT(), yet facilities using TTaskGroup (for example RNTuple) were not using the created task arena and therefore as many resources as they could get. This reverts commit af25fb986 ("[TTaskGroup] Isolate work with tbb::arena::isolate and not task_arena") and adds changes to use ROOT::Internal::GetGlobalTaskArena(). 11 March 2024, 18:32:22 UTC
5e5ab22 [TTaskGroup] Use isolated_task_group if available An isolated_task_group (available as preview since TBB 2020) guarantees that a wait doesn't pick up other tasks that don't belong to the group. This is important for experiment frameworks. 11 March 2024, 18:32:22 UTC
29118d5 [ntuple] Remove unzipping thread from RClusterPool Submitting ImplicitMT tasks from a thread outside of the TBB pool is quite fragile and can cause deadlocks when, for example, all threads have their own RNTupleReader and there would be no executor left for the tasks submitted by the background thread. 11 March 2024, 18:32:22 UTC
7523915 [ntuple] Remove RTaskScheduler::Reset The RNTupleImtTaskScheduler can just reuse the same TTaskGroup. 11 March 2024, 18:32:22 UTC
fd3f670 [ntuple] Add two tests for IMT interaction 11 March 2024, 18:32:22 UTC
ff22215 [ntuple] Disable ImplicitMT after every test 11 March 2024, 18:32:22 UTC
11f7417 [TTaskGroup] Remove fCanRun This makes it possible now to use Wait() as a yield mechanism to run tasks that may have been submitted by a different thread. 11 March 2024, 18:32:22 UTC
b01ae42 [ntuple] Return cluster size from RPageNullSink Even if not writing anything, return the cluster size in bytes from RPageNullSink::CommitCluster because it is used by RNTupleFillContext to estimate the compression ratio. Returning zero resulted in severely oversized clusters which made it hard to evaluate overhead with it. 11 March 2024, 13:21:57 UTC
9f81958 [cppyy] Remove unused Python modules Port of https://github.com/wlav/cppyy/pull/207. 10 March 2024, 11:19:32 UTC
2a77d49 [PyROOT] Improve output of CPPMethod::GetPrototype Given the following function declared to ROOT and accessed via a Python proxy: ``` int foo(int x); ``` Currently accessing its `func_doc`, which in turn calls `CPPMethod::GetPrototype`, gives: 'int ::foo(int x)' The extra set of '::' can be avoided by checking that the function is not declared inside a namespace. 10 March 2024, 10:40:42 UTC
2827c02 [df] Ensure proper RNTuple data is processed by distributed tasks 09 March 2024, 19:35:08 UTC
0e72372 Update unit test to detect the undetected issue 09 March 2024, 07:15:18 UTC
6113629 Fix boundary check for VecOps::Take fixing issue https://github.com/root-project/root/issues/14914 09 March 2024, 07:15:18 UTC
083e16b [skip ci][ci] Enable v6-26-00-patches builds in the new CI 08 March 2024, 20:38:48 UTC
919bb1b [RF] Reduce runtime of some RooStats tutorials by using less toys The number of toys can be reduced with the tutorials still working fine, and the output looking reasonably good. This reduces the runtime by a few minutes in debug mode. The number of toys is now a parameter to the tutorial macro, so users can try the study with more toys if they want. 08 March 2024, 17:10:19 UTC
4f5ae62 [RF] Make sure RooFit legacy backend is still tested I noticed that `roofit_legacy_eval_backend` variable in CMake was not cached, and therefore it didn't propagate to the RooFit test subdirectories. This meant several unit tests were not executed. This commit is fixing that. 08 March 2024, 17:10:19 UTC
b5551b2 [math][unuran] Change default method for sampling multi-dim distributions The default method for chaning multi-dim distributions is now `vnrou` instead of the Markov CHain based method hitro, which generates (being a MC MC) correlated values and not iid. Update also documentation and tutorial This fixes ROOT #10222 08 March 2024, 12:48:22 UTC
2a2825f [CI] Remove `minuit2` option from CI configuration The `minuit2` option was removed from the ROOT build options, and using it will result in a configuration falure. 08 March 2024, 11:54:59 UTC
80f366e [cmake] Fix invalid use of `minuit2` flag The `minuit2` build option was removed, so it should not be checked. Minuit2 is always enabled now. 08 March 2024, 11:54:59 UTC
ed867f5 [math] Fix copy-paste error in `math/mathmore/test/CMakeLists.txt` The Minuit2 fitting test is actually in `mathcore/test`, not in `mathmore`. This was probably a remnant of copy-pasting the CMakeLists.txt from the MathCore tests. 08 March 2024, 11:54:59 UTC
560e4e8 [cmake] Remove deprecated `minuit2` build option The `minuit2` build option was deprecated in ROOT 6.30 and should be removed for ROOT 6.32. Minuit 2 is now always built. 08 March 2024, 11:54:59 UTC
bc27184 [core] Use ExpandPathName(TString&) to prevent mem leaks (ROOT-7280): Some of these cases forgot to delete the returned char[]; the TString overload takes care of that. 08 March 2024, 08:10:25 UTC
09b53b7 [tree] Add test for TTreeIndex::Clone 08 March 2024, 00:10:27 UTC
549043e [tree] Allow bypassing I/O when copying TTreeIndex The current logic for processing TTree/TChain datasets with IMT and when a TTreeIndex is involved requires a copy of each index in each thread, since their state depends on the TTree/TChain they are attached to. Previously, the copy was done via `TObject::Clone` which inevitably makes use of I/O functions, i.e. serialising/deserialising the TTreeIndex/TChainIndex, thus making the copy more costly than necessary. This commit introduces overloads of `Clone` for TTreeIndex and TChainIndex enabling their copy in memory. 08 March 2024, 00:10:27 UTC
443dc5a [ntuple] fix exception handling when adding fields The model keeps track of field names to avoid creating the same top-level field multiple times. Fix this mechanism under exceptions, so that the used field name is not registered as taken. 07 March 2024, 21:34:16 UTC
9e125a5 [RF] Avoid floating point exception in RooBatchCompute with IMT This avoids a floating point exception that would otherwise happen in the calculation of the number of events per thread. This fixes the crash seen in: https://github.com/cms-sw/cmsdist/pull/9047 07 March 2024, 20:30:56 UTC
d02a360 [RF] Don't consider implicit MT in RooBatchCompute In the original implementation of the RooBatchCompute library, the evaluation was done multi-threaded in implicit multi-threading was enabled in ROOT with `ROOT::EnableImplicitMT()`. This commit removes this feature now, because it was never really validated, overlapped with other parallelization capabilities of RooFit, and keeping it will have many unforeseen consequences on users now that the new CPU evaluation backend is the default in RooFit. See also: https://github.com/cms-sw/cmsdist/pull/9047 07 March 2024, 20:30:56 UTC
41a259c [jsroot] dev 7/03/2024 with new TRatioPlot support Now TRatioPlot appears as first object in list of primitives and one assign interactive handlers after all other pad primitives are drawn. Keep support of older files with TRatioPlot as well Better support of optdate, optfile options Use localStorage for JSROOT settings storage - no cookies 07 March 2024, 12:55:07 UTC
c033c8a Remove the Python tutorials form the list of Namespaces (#14883) * Remove the Python tutorials form the list of Namespaces * Move the clean up just after the doxygen command * Address clang-format issue 07 March 2024, 12:02:22 UTC
bbd0dc2 [df] Force only one RNTuple name in distributed scheduling 07 March 2024, 09:43:29 UTC
fa550ec [ntuple] fail gracefully on attempt to create cyclic class 07 March 2024, 09:03:45 UTC
7a0031a [ratioplot] keep default Browse() implementation Also check allowed range in SetSplitFraction 07 March 2024, 08:30:57 UTC
4d49cd2 [ratioplot] update image sizes in stressGraphics There are no more dummy/invisible primitives caused by TRatioPlot painting before therefore PS/PDF are smaller 07 March 2024, 08:30:57 UTC
9f7b5d6 [ratioplot] use central fIsUpdate flag, make it transient No need to class change version - it was changed before IsDrawn() method is useless - handling of signals can be possible only when they are connected - after drawing Format a bit header file 07 March 2024, 08:30:57 UTC
ac89e57 [ratioplot] put as first primitive Make ratio plot as first object in list of primitives. When painting - one can modify axes attributes before they really painted 07 March 2024, 08:30:57 UTC
f016922 [ratioplot] use static_cast Also no need to use TClass methods via IsA(). 07 March 2024, 08:30:57 UTC
ea50d37 [ratioplot] call pads modified once when range is changed No need to call several update methods once 07 March 2024, 08:30:57 UTC
7a4bffd [ratioplot] check and connect signals handles also in Paint If ratio plot load from the file, connections to the signals are not automatically restored. Therefore check if connections are there - and re-establish them if they are missing 07 March 2024, 08:30:57 UTC
0200a62 [ratioplot] use vectors and better cpp syntax 07 March 2024, 08:30:57 UTC
87127cc [ratioplot] only update axis attributes when painting Same as grid lines - one should not recreate TGaxis objects but just change their attributes when painting is performed 07 March 2024, 08:30:57 UTC
90a8c60 [ratioplot] only update gridlines in ratio plot painting It is not good idea to add or remove objects from pad list of primitives when TRatioPlot::Paint is called Therefore create TLine objects once and just update position If lines are not visible - make them as point in the frame corner 07 March 2024, 08:30:57 UTC
d59d4df [ci] Add buildconfig for mac-beta For now a copy of mac12.txt: we want tmva-cpu which is OFF in mac14, but not tmva-sofie because there is no Protobuf. 07 March 2024, 07:43:14 UTC
d009622 Make argument adjustment in SetArg if the function signature is available. This patch optimizes performance by moving the argument adjustments in SetArg and not in exec. Exec can be called many times and in hot loops. We also report errors rather than asserting. 07 March 2024, 06:37:26 UTC
6808d67 Readjust the representation of CallFunc arguments to match the callee signature. TClingCallFunc provides an interface between compiled and interpreted code. That is, we can create at compile time a function to be called by the interpreter and get back its result into compiled code. To do that we require connecting to a function declaration available in the interpreter and calling it by setting input arguments. However, the input arguments are set with the SetArg which can resolve to a type and argument representation different from the signature of the interpreter function we will call. This is practically not a problem integral types because their representation is mostly the same. The problem becomes visible when we call SetArg with a `double` and the function signature expects a `float`. That works out of the box when the compiler can see both ends and insert proper representation casts. Unfortunately, when crossing the compiler/interpreter boundary we use `void*` and that information is lost. This patch adds some representation adjustments so that the compiled code (SetArg) and the interpreted code (CallFunc) can agree on the memory representation before calling. Fixes #14405 07 March 2024, 06:37:26 UTC
0d95bb2 [io] Prevent potential leaks from ExpandPathName (ROOT-7280): Use the TString& overload. To do that (and not jump over a variable initialization), remove `goto` in favor of a lambda. 06 March 2024, 23:56:45 UTC
3ecb224 [ntuple] forbid RNTuple I/O of unsplittable classes 06 March 2024, 22:25:15 UTC
ce7f33d [thstack] simplify THStack::Print() No need to cast histograms to call Print() methods 06 March 2024, 15:37:36 UTC
1233705 [thstack] fix copy constructor One have to register THStack in list of cleanups 06 March 2024, 15:37:36 UTC
b551f97 [thstack] delete in destructor all objects Even when fHists is nullptr some other objects may be there 06 March 2024, 15:37:36 UTC
e37a7ec [thstack] use correct type in cast Histograms in stack not necessary TH1F. 06 March 2024, 15:37:36 UTC
bbfda3d [hstack] simplify Get[X/Y/Z]axis methods No need to check gPad - it is already done in GetHistogram 06 March 2024, 15:37:36 UTC
6f54f79 [hstack] fix THStack::GetZaxis() Check dimension after check if histogram exists 06 March 2024, 15:37:36 UTC
dcb7a8f [skip ci][ci] Use correct indentation in workflow yml file 06 March 2024, 15:00:24 UTC
c8436bc [ci] Add mac-beta runner 06 March 2024, 14:51:25 UTC
bc440b4 [cmake] Remove `cmake_policy(SET CMP0071 NEW)` Since we require a minimum CMake version greater or equal to 3.10, manually setting the CMP0071 poicy to `NEW` is redundant. See: https://cmake.org/cmake/help/latest/policy/CMP0071.html 06 March 2024, 14:27:44 UTC
1c5ddde [cmake] Always fail when CUDA is required but not found The `cuda` option is always `OFF` by default, and if it is set to `ON`, this is because the user had the clear intention of building ROOT with CUDA features. Disabling CUDA features at configuration step without erroring out is therefore not a good solution if CUDA is not found, as it clearly acts against the intention of the user. 06 March 2024, 14:27:44 UTC
d95841e [cmake] Remove warning for old `pyroot_experimental` flag The flag has long been removed, so it is not necessary to carry around this warning at this point. 06 March 2024, 14:27:44 UTC
e3cd074 [clad] Fix Clad debug build on Windows 06 March 2024, 13:01:42 UTC
back to top