| 8012030 | moneta | 17 February 2023, 10:44:00 UTC | [math][minuit] Improvements coming from Rene studies | 17 February 2023, 10:44:00 UTC |
| 94b3064 | Jonas Rembser | 09 February 2023, 22:46:01 UTC | [RF] Further refactor RooJSONFactoryWSTool | 17 February 2023, 09:19:31 UTC |
| 204b347 | Jonas Rembser | 09 February 2023, 22:00:25 UTC | [RF][HS3] Avoid catching without re-throwing This should not be done, it makes debugging very hard. | 17 February 2023, 09:19:31 UTC |
| 7c710eb | Jonas Rembser | 09 February 2023, 21:54:56 UTC | [RF][HS3] Write out bin counts as `int` and other small improvements | 17 February 2023, 09:19:31 UTC |
| 1cfe15b | Jonas Rembser | 09 February 2023, 21:12:04 UTC | [RF] Correctly support constants in RooFit JSON IO | 17 February 2023, 09:19:31 UTC |
| 885b597 | Jonas Rembser | 09 February 2023, 20:54:30 UTC | [RF] Add test for a simultaneous model written and read from JSON | 17 February 2023, 09:19:31 UTC |
| 79afa36 | Jonas Rembser | 09 February 2023, 20:40:20 UTC | [RF] Skip the RooSimultaneous in JSON IO | 17 February 2023, 09:19:31 UTC |
| 825498a | Jonas Rembser | 09 February 2023, 16:03:33 UTC | [RF] Don't export `factory_tag` in JSON | 17 February 2023, 09:19:31 UTC |
| 8500e79 | Jonas Rembser | 09 February 2023, 15:52:58 UTC | [RF][HS3] Move the default variable values to the estimates section | 17 February 2023, 09:19:31 UTC |
| 8e817e1 | Jonas Rembser | 09 February 2023, 11:21:23 UTC | [RF] RooFit JSON: no need to tag variables, just export them | 17 February 2023, 09:19:31 UTC |
| 19cce71 | Jonas Rembser | 03 February 2023, 02:32:40 UTC | [RF] Rename fields in JSON file to match new standard | 17 February 2023, 09:19:31 UTC |
| efbe62a | Jonas Rembser | 03 February 2023, 02:19:51 UTC | [RF] Complete also the reading of likelihoods and analysis fields | 17 February 2023, 09:19:31 UTC |
| 8f74da1 | Jonas Rembser | 02 February 2023, 23:11:23 UTC | [RF] Add likelihoods and analyses fields for HS3 v2 | 17 February 2023, 09:19:31 UTC |
| d605ce6 | Jonas Rembser | 02 February 2023, 00:20:41 UTC | [RF] Decouple `RooDataHist` reading from rest of workspace in RooFitHS3 RooDataHists are self-contained entities in RooFit, and writing and reading of their representation in RooFitHS3 should also not depend on the rest of the RooWorkspace context. This also makes the code easier to understand and work with. | 17 February 2023, 09:19:31 UTC |
| 6536766 | Jonas Rembser | 01 February 2023, 16:55:48 UTC | [RF] Some refactoring of RooFit HS3 Some refactoring, mainly to reduce the number of lines of code. | 17 February 2023, 09:19:31 UTC |
| 49faf74 | Jonas Rembser | 01 February 2023, 14:39:55 UTC | [RF] New `domains` section in JSON to store variable ranges This is the first step towards implementing the HS3 standard version 2. Variable ranges are now stored in the dedicated `"domains"` field. To make the reading and writing of this field easier, a new class `Domains` is added in the implementation details to store the domain information in an intermediate data structure that can be efficiently written to JSON in the end. | 17 February 2023, 09:19:31 UTC |
| 7332499 | Enrico Guiraud | 09 February 2023, 13:52:16 UTC | [tree] Propagate TTreeIndex info through GetFriendInfo/MakeFriends This in turn fixes a problem with TTreeProcessorMT and multi-thread RDataFrame "forgetting" about the TTreeIndexes associated with input friend trees. Fixes https://github.com/root-project/root/issues/12260, "[DF] Bogus data read from indexed friend trees in multi-thread runs". | 17 February 2023, 09:12:46 UTC |
| 2bcb9f5 | Enrico Guiraud | 08 February 2023, 18:52:38 UTC | [DF] Add test for indexed friends in MT mode | 17 February 2023, 09:12:46 UTC |
| 535d776 | Enrico Guiraud | 14 February 2023, 17:14:44 UTC | [tree] Fix ~TChainIndex in case of null fTree fTree can be null e.g. after a chainIndex->Clone(). Co-authored-by: Philippe Canal <pcanal@fnal.gov> | 17 February 2023, 09:12:46 UTC |
| bfd8fbe | Enrico Guiraud | 14 February 2023, 17:13:13 UTC | [tree] Actually set tree in TChainIndex::SetTree | 17 February 2023, 09:12:46 UTC |
| 599d769 | Enrico Guiraud | 14 February 2023, 17:11:55 UTC | [tree] The argument to TVirtualIndex::SetTree cannot be const We need to assign the pointer to const to a pointer to non-const right inside the setter, and that currently requires a const_cast. This commit remove the const_cast by changing the signature of TVirtualIndex::SetTree to accept a pointer to _non-const_ TTree. | 17 February 2023, 09:12:46 UTC |
| ac30be3 | Vassil Vassilev | 16 February 2023, 07:04:17 UTC | Remove the problematic uses_allocator_args.h It is not present on some versions of libstdc++ which makes the compilation of Core.pcm fail. | 17 February 2023, 09:12:24 UTC |
| 2ce11e2 | Vassil Vassilev | 09 February 2023, 17:47:16 UTC | [cxxmodules] Add a module for experimental/string_view Recent gcc updates somehow make experimental/string_view available through module string_view. Then it wrongly decides it needs to include "bits/ranges_base.h" which is a c++14 header and breaks the compilation in case of c++11. This patch adds a proper experimental/string_view to disallow such shadowing. | 17 February 2023, 09:12:24 UTC |
| 3d42abf | Enrico Guiraud | 15 February 2023, 13:38:32 UTC | [DF][NFC] Use char instead of char* when it's just 1 character | 17 February 2023, 09:11:32 UTC |
| b0cf5d0 | Enrico Guiraud | 14 February 2023, 21:59:32 UTC | [DF] Prefer `file?#tree` to `file/tree` Now that #11483 is fixed we can use the more general notation everywhere (`file/tree` is problematic in case the filename does not end with .root, see https://github.com/root-project/root/pull/8820). | 17 February 2023, 09:11:32 UTC |
| ffeba34 | olemorud | 16 February 2023, 10:54:56 UTC | [CI] skip root-ci on forks | 17 February 2023, 08:47:44 UTC |
| f05f24c | moneta | 17 February 2023, 08:22:36 UTC | [math][minuit] Add missing SetErrorDef for the gradient function interface SetErrorDef was not implemented for the FCNGradAdapter used to wrap the user functions in the Minuit interface. This causes that the current set ErrorDef was not used when minimizing but the one set when constructed the function. This fixes issue #12338 | 17 February 2023, 08:44:26 UTC |
| e518cce | moneta | 10 February 2023, 10:27:17 UTC | [tmva] Fix Numpy->RTensor conversion plus add a test Include also comments from Vincenzo review | 17 February 2023, 08:16:25 UTC |
| 9f6e92e | moneta | 09 February 2023, 18:52:48 UTC | [tmva] Add RTensor constructor from a numpy array | 17 February 2023, 08:16:25 UTC |
| e928f01 | Jakob Blomer | 15 February 2023, 21:34:07 UTC | [ntuple] fix code style | 17 February 2023, 08:04:13 UTC |
| aa6cbc2 | Jakob Blomer | 15 February 2023, 13:23:28 UTC | [ntuple] Rename EColumnTypes::kIndex --> EColumnTypes::kIndex32 | 17 February 2023, 08:04:13 UTC |
| 847a0c1 | Jakob Blomer | 15 February 2023, 13:18:15 UTC | [ntuple] make RClusterSize_t 64bit | 17 February 2023, 08:04:13 UTC |
| 3869282 | Bertrand Bellenot | 17 February 2023, 07:38:55 UTC | Fix modules and modules.idx generation on Windows and disable a few more modules causing potential crashes (#12252) * Fix modules and modules.idx generation on Windows and disable a few more modules causing potential crashes * Introduce a new TROOT::GetSharedLibDir() method to reduce the need of #ifdef R__WIN32 * Use the value of ROOT_GET_LIBRARY_OUTPUT_DIR instead of CMAKE_RUNTIME_OUTPUT_DIRECTORY (which is the same anyway) * cleanup the code * Remove unnecessary check | 17 February 2023, 07:38:55 UTC |
| 254bac6 | Jonas Hahnfeld | 16 February 2023, 19:32:44 UTC | [cling] Set DataLayout from our TargetMachine (#12335) Otherwise LLJIT's constructor will ask the LLJITBuilder's JTMB to create a DataLayout. As we don't propagate the JTMB (yet -- we probably should!), this will be wrong if target features influence the DataLayout. This should fix #12293. | 16 February 2023, 19:32:44 UTC |
| 3ffadca | Axel Naumann | 21 December 2022, 08:37:56 UTC | [cling] Revert "Disable GlobalISel on AArch64": This reverts fcab0add4a79379b5087fe786261f4ab0cc9776a which is not needed anymore since llvm13 / ORCv2 / JITLink. | 16 February 2023, 15:59:02 UTC |
| a36c1d8 | Olivier Couet | 16 February 2023, 15:18:38 UTC | Implement reversed graphs for error bars and log scale. (#12235) * Implement reversed graphs for error bars and log scale. * Proper tests * Move variables declaration in more logic places. | 16 February 2023, 15:18:38 UTC |
| 74b8f23 | Axel Naumann | 15 February 2023, 16:29:27 UTC | [cmake] macOS: export DYLD_LIBRARY_PATH, not LD_LIBRARY_PATH. Co-authored-by: sa35 | 16 February 2023, 14:41:39 UTC |
| 0b6a747 | Jonas Rembser | 15 February 2023, 20:55:42 UTC | [RF] Clearly mark `RooFit::CloneData()` as deprecated Marking the `CloneData()` argument for createNLL explicitly as deprecated and noting in the docs that it is ignored. There is no reason to support it now. The new BatchMode doesn't clone the data anyway, the new test statistics with multiprocessing need to clone the data for each process anyway, and the old test statistics classes will be deprecated at some point. Closes the following Jira ticket: https://sft.its.cern.ch/jira/browse/ROOT-10372 | 16 February 2023, 10:59:01 UTC |
| 3637982 | Jonas Rembser | 15 February 2023, 19:18:04 UTC | [RF] Again code-format RooMinimizer In the latest multiprocessing PR, it was forgotten to code-format the RooMinimizer. To avoid having a diverging code style again, this commit suggests to reformat it. | 16 February 2023, 09:22:05 UTC |
| e604c9e | Jonas Rembser | 15 February 2023, 19:05:03 UTC | [RF] Avoid overhead of tracking evaluation error msgs when not needed For the minimization, the RooMinimizer sets the error logging mode temporarily to `CollectErrors`, which collects all error messages in strings. This results in a HUGE overhead, which is completely unnecessary if evaluation error printing is disabled. In that case, the error evaluation mode should be set to counting only, which is what this commit implements. This speeds up fits with frequent evaluation errors a lot, for example the `testNaNPacker` tests are sped up by 25x. | 16 February 2023, 09:22:05 UTC |
| 9f45e3f | Jonas Rembser | 15 February 2023, 18:56:31 UTC | [RF] Implement safe way to set eval error logging in RooMinimizer | 16 February 2023, 09:22:05 UTC |
| 5241c37 | Sergey Linev | 15 February 2023, 12:46:59 UTC | [jsroot] dev 15/02/2023 with candle gStyle changes Supports new gStyle attributes for configuring candle and violin plots | 16 February 2023, 07:41:39 UTC |
| bb1c02d | Sergey Linev | 15 February 2023, 12:42:19 UTC | Fix candlescaled.C tutorial Call TCandle::SetScaledViolin(false) as stated in the histogram titles Tutorial demonstrates non-default scaling behavior for candle and violin plots | 16 February 2023, 07:41:39 UTC |
| 966c786 | Sergey Linev | 15 February 2023, 12:40:24 UTC | Use gStlye values for TCandle configuration Keep old static functions to preserve interface | 16 February 2023, 07:41:39 UTC |
| 1a694d5 | Sergey Linev | 15 February 2023, 12:00:04 UTC | Introduce candle settings in TStyle These values should be used in TCandle | 16 February 2023, 07:41:39 UTC |
| 02d18ce | Sergey Linev | 15 February 2023, 11:45:02 UTC | [candle] Use TString to store draw options for TCandle | 16 February 2023, 07:41:39 UTC |
| 426ff90 | Sergey Linev | 15 February 2023, 15:02:21 UTC | Add missing TH1K::RetrieveBinContent | 16 February 2023, 07:24:56 UTC |
| 07e2f5c | Andrei Gheata | 14 February 2023, 16:34:57 UTC | [geom] Extended TGeoVGShape with extra solids Added support for tesselated, ellipsoid, hyperboloid and cut tube. Added the macro tutorials/geom/tessellatedNav.C importing and raytracing a tessellated solid. | 15 February 2023, 19:54:30 UTC |
| 5982340 | Jonas Rembser | 01 February 2023, 11:50:26 UTC | [RF] Use proper infinity checks in RooFit HS3 | 15 February 2023, 19:10:17 UTC |
| a60c983 | Jonas Rembser | 02 February 2023, 13:24:55 UTC | [relnotes] Note change of infinity definition in RooFit Also mention the change of behavior in `TMath::AreEqualAbs()`. | 15 February 2023, 19:10:17 UTC |
| 6b0ec85 | Jonas Rembser | 02 February 2023, 12:54:03 UTC | [RF] Avoid `sin` or `cos` of infinity in RooTruthModel integral code | 15 February 2023, 19:10:17 UTC |
| 12c0997 | Jonas Rembser | 02 February 2023, 12:34:13 UTC | [RF] RooTruthModel: local `xmin` and `xmax` to make code more readable | 15 February 2023, 19:10:17 UTC |
| 55bc2c0 | Jonas Rembser | 12 January 2023, 12:24:19 UTC | [RF] Define infinity as `std::numeric_limits<double>::infinity()` | 15 February 2023, 19:10:17 UTC |
| a4a5077 | Jonas Rembser | 12 January 2023, 12:06:12 UTC | [math] Make `TMath::AreEqualAbs()` return `true` when comparing `inf` | 15 February 2023, 19:10:17 UTC |
| 72cbe46 | Jonas Rembser | 12 January 2023, 10:25:19 UTC | [RF] Inline infinity constant and checks in `RooNumber` Also, the `RooNumber` class does not need a `ClassDef` or `LinkDef` entry. | 15 February 2023, 19:10:17 UTC |
| eddb686 | Jonas Rembser | 12 January 2023, 12:09:25 UTC | [RF] Code-format RooNumber.h and RooNumber.cxx These source files are code formatted now because they will be changed a lot in the next commits. | 15 February 2023, 19:10:17 UTC |
| f2598e9 | Vincenzo Eduardo Padulano | 08 February 2023, 20:26:00 UTC | [DF] Simplify friend trees creation in RLoopManager | 15 February 2023, 17:48:14 UTC |
| fda2d63 | Vincenzo Eduardo Padulano | 09 February 2023, 17:05:52 UTC | [tree][NFC] Add tests for GetFriendInfo and MakeFriends | 15 February 2023, 17:48:14 UTC |
| e878555 | Vincenzo Eduardo Padulano | 09 February 2023, 10:18:27 UTC | [tree] Always include number of entries in RFriendInfo creation Whether it is done via `Internal::TreeUtils::GetFriendInfo` or an `RFriendInfo::AddFriend` overload, the `fNEntriesPerTreePerFriend` data member will have the same cardinality as the `fFriendFileNames` data member. This makes the status of the created struct more easily usable, for example it simplifies the logic in `MakeFriends`. | 15 February 2023, 17:48:14 UTC |
| b12227f | Jakob Blomer | 15 February 2023, 15:33:52 UTC | [ntuple] remove unused method from RFieldBase | 15 February 2023, 16:53:31 UTC |
| 71f9c8f | Jakob Blomer | 15 February 2023, 09:51:24 UTC | [ntuple] avoid fixup of field representative in storage layer | 15 February 2023, 16:53:31 UTC |
| 863cd0b | Jakob Blomer | 14 February 2023, 21:58:11 UTC | [ntuple] fix typos in RColumnElementBase::GetTypeName() Co-authored-by: Javier Lopez-Gomez <javier.lopez.gomez@cern.ch> | 15 February 2023, 16:53:31 UTC |
| 3a1befc | Jakob Blomer | 03 February 2023, 13:50:32 UTC | [ntuple] use non-split default encoding on uncompressed ntuples | 15 February 2023, 16:53:31 UTC |
| d25a8b3 | Jakob Blomer | 03 February 2023, 12:56:16 UTC | [ntuple] add kSplitInt32 --> int64_t (un)packing | 15 February 2023, 16:53:31 UTC |
| d2722f5 | Jakob Blomer | 03 February 2023, 10:26:51 UTC | [ntuple] make split encoding the default for ints, floats | 15 February 2023, 16:53:31 UTC |
| f1872a7 | Jakob Blomer | 03 February 2023, 09:27:58 UTC | [ntuple] add support for SplitInt16 column type | 15 February 2023, 16:53:31 UTC |
| ded0609 | Jakob Blomer | 03 February 2023, 08:53:19 UTC | [ntuple] add support for SplitInt32 column type | 15 February 2023, 16:53:31 UTC |
| 77ee108 | Jakob Blomer | 02 February 2023, 15:53:52 UTC | [ntuple] add support for SplitInt64 column type | 15 February 2023, 16:53:31 UTC |
| 80dcd88 | Jakob Blomer | 02 February 2023, 14:43:42 UTC | [ntuple] Add support for SplitReal32 column type | 15 February 2023, 16:53:31 UTC |
| b922be6 | Philippe Canal | 10 February 2023, 18:59:30 UTC | Add missing dictionary | 15 February 2023, 16:29:10 UTC |
| 9433a89 | Philippe Canal | 30 January 2023, 20:54:15 UTC | Warn about compiled compiled proxy containing emulated objects | 15 February 2023, 16:29:10 UTC |
| 7c81a10 | Sergey Linev | 15 February 2023, 10:10:53 UTC | [jsroot] dev 15/02/2023 with browser resize Support RWebWindow size and position - already when connecting to server In TWebCanvas tries to preserve canvas size, when changed - inform server with RESIZE message | 15 February 2023, 12:49:23 UTC |
| 40f0518 | Sergey Linev | 15 February 2023, 10:06:12 UTC | [webcanvas] enforce canvas size when toggling status line or editor Available area for canvas changes and therefore one need to resize browser window to keep it the same. Consistently work only with chrome browser | 15 February 2023, 12:49:23 UTC |
| 9ebc26f | Sergey Linev | 14 February 2023, 16:34:48 UTC | [rcanvas] process reszied message from client Produced when canvas reszied via context menu | 15 February 2023, 12:49:23 UTC |
| ef2f9fd | Sergey Linev | 14 February 2023, 16:11:18 UTC | [webcanvas] handle resized message from client Set actual browser window size back to the canvas | 15 February 2023, 12:49:23 UTC |
| 0ea7cf2 | Sergey Linev | 14 February 2023, 15:59:41 UTC | [webcanvas] add Resize menu with several predefined sizes Let change canvas to exact size - when browser allows to modify window size with window.resizeTo() function | 15 February 2023, 12:49:23 UTC |
| 70ac19c | Sergey Linev | 14 February 2023, 15:08:50 UTC | [webwindow] introduce X and Y coordinates for the RWebWdinow Will be handled in supported web browsers | 15 February 2023, 12:49:23 UTC |
| abf3e3c | Sergey Linev | 14 February 2023, 15:00:35 UTC | [webwindow] use window.resizeTo method to ensure browser window size Solves problem with chrome browser, which does not apply window size when second or third window is opened | 15 February 2023, 12:49:23 UTC |
| 0122c1f | Olivier Couet | 15 February 2023, 11:53:29 UTC | Improve example (#12318) | 15 February 2023, 11:53:29 UTC |
| 2815a2e | will-cern | 15 February 2023, 09:55:49 UTC | [RF] Where appropriate, take titles from input objects in HistFactory It would be nice if HistFactory propagated some additional information from the input objects to the workspace. For starters, the titles of observables could be taken from the axis of the input histograms, and channel and sample names from the titles of histograms. It would be good to think about how to best port over additional info (like histogram styling) once we have settled on a convention for that! | 15 February 2023, 09:55:49 UTC |
| 9588a87 | YuryYury | 13 February 2023, 14:53:25 UTC | Fixing a typo in the documentation: `SetOptStats --> SetOptStat` | 15 February 2023, 09:50:41 UTC |
| 000d367 | Vincenzo Eduardo Padulano | 10 February 2023, 09:39:23 UTC | [tree] Support globbing with ?# treename token in TChain::Add In case the input name contains both globbing and the '?#' token for the tree name, the call to `ParseTreeFileName` will produce a wrong suffix of the form '#treename', which in turn will create a bogus file name in `TChain::AddFile`. In such cases, do not pass the suffix but pass the tree name explicitly. Fixes #11483 Co-authored-by: Enrico Guiraud <enrico.guiraud@cern.ch> | 14 February 2023, 19:53:56 UTC |
| 14c51d1 | ACA4DFA4 | 14 February 2023, 06:27:39 UTC | fix a line in PyMethodBase.cxx which make it fail to build | 14 February 2023, 17:56:06 UTC |
| c2d5a17 | Sergey Linev | 14 February 2023, 13:27:58 UTC | [jsroot] dev 14/02/2023 with different log scales support Via context menu ln, log4 and many others can be selected Also TWebCanvas will benefit from this changes | 14 February 2023, 16:35:48 UTC |
| a8ecefe | Sergey Linev | 14 February 2023, 13:19:42 UTC | [rbrowser] use TWebCanvas by default Main debugging and development will be done with TWebCanvas, therefore use it by default with RBrowser | 14 February 2023, 16:35:48 UTC |
| 450de03 | Sergey Linev | 14 February 2023, 13:18:03 UTC | [rbrowser] fix TTree::Draw() expression creation For special branches like "@size" one should always place "@" symbol. | 14 February 2023, 16:35:48 UTC |
| 54a05a9 | moneta | 14 February 2023, 10:00:44 UTC | [tmva] Speed up TMVA CNN and RNN tutorials Run tutorials with a amximum of 4 threads to avoid MT problems on some machines. Disable also OpenMP when running in MT in ROOT Reduce also by a factor of 5 the number of input events | 14 February 2023, 14:41:39 UTC |
| dbe5768 | olemorud | 14 February 2023, 08:49:39 UTC | [ci] Disable buffering for python output again | 14 February 2023, 14:27:05 UTC |
| a02b792 | olemorud | 13 February 2023, 15:34:11 UTC | [ci] Rename CI files | 14 February 2023, 14:27:05 UTC |
| 09f7815 | Javier Lopez-Gomez | 13 February 2023, 14:05:39 UTC | [ntuple] RPageSinkBuf: add missing call to ReleasePage() | 14 February 2023, 12:56:38 UTC |
| f2a41f4 | Jonas Rembser | 10 February 2023, 12:39:28 UTC | [RF] Correctly normalize max possible val in generation with proto data The code branch without a proto data in `RooGenContext` already did this, and now it's also done when using proto dataset generation. Closes #12286. | 14 February 2023, 12:49:49 UTC |
| 8c7de00 | Jonas Rembser | 13 February 2023, 20:21:53 UTC | [RF] Less manual memory management with `new` and `delete` Also, use `nullptr` instead of `0` literal in `getBinningPtr()`. | 14 February 2023, 11:38:59 UTC |
| fc10e43 | Jonas Rembser | 13 February 2023, 19:12:45 UTC | [RF] Some code modernization is category classes In particular, use less TString. | 14 February 2023, 11:38:59 UTC |
| 363c495 | Jonas Rembser | 13 February 2023, 18:46:46 UTC | [RF] Support `RooAbsCategoryLValue::setBin()` for non-existing ranges In `RooAbsCategoryLValue::setBin()`, there is a check for passing a named binning, because the function doesn't support named binnings. However, if a binning with that name doesn't exist, it is fine to not error out, because the default range is used. | 14 February 2023, 11:38:59 UTC |
| 3ebfbf0 | Jonas Rembser | 06 February 2023, 11:41:00 UTC | [RF] Fill weight errors when importing RooDataHists to RooDataSet The weight errors in the RooDataSet encode the `weightSquared()`, so when importing a RooDataHist into a RooDataSet it is important to always declare that the weight will have and error and fill it with `sqrt(weightSquared())` from the original RooDataHist. A unit test that verifies the `weightSqared()` doesn't get corrupted upon import is now implemented. | 14 February 2023, 11:38:01 UTC |
| 4e972d9 | Jonas Rembser | 05 February 2023, 13:19:45 UTC | [RF] Make it possible to directly import RooDataHist to RooDataSet | 14 February 2023, 11:38:01 UTC |
| 483803a | Jonas Rembser | 05 February 2023, 00:26:05 UTC | [RF] Reduce code duplication in RooDataSet constructor The same code was copy-pasted almost exactly three times when importing RooDataSets to a new RooDataSet: 1. For the case there the cut was given as a string 2. For the case where there was a RooRealVar for the cut 3. For the case where there was no cut This commit reduces the three cases to one code branch. | 14 February 2023, 11:38:01 UTC |
| 9da3aee | Jonas Rembser | 04 February 2023, 23:48:07 UTC | [RF] Always create weight var in RooDataSet when importing weighted data If one imports at least one weighted dataset, a weight variable should be created automatically. Closes #11487. | 14 February 2023, 11:38:01 UTC |
| 0f1f698 | Jonas Rembser | 04 February 2023, 17:48:21 UTC | [RF] Implicitly create `WeightVar` for RooDataSet if it doesn't exist When constructing RooDataSets, you can specify which column is the weight variable with the `WeightVar()` command argument that takes the name of the weight variable. However, it is not convenient that often one has to create a weight RooRealVar just to create a weighted dataset. This commit suggests to create the weight variable implicitly if it is not available yet and the `WeightVar()` was specified by name. Also, the `WeightVar()` is now called `"weight"` by default. | 14 February 2023, 11:38:01 UTC |
| 51ad38c | Jonas Rembser | 04 February 2023, 16:37:22 UTC | [RF] Support also importing `RooDataHists` into RooDataSets For simultaneous fits, it is necessary to create a combined `RooDataSet` with the `Import()` keyword argument, passing a map of datasets. If one of the component datasets is a `RooDataHist`, it first needs to be converted to a `RooDataSet` by the user, with one weighted entry for each bin center. This is done for example in the JSON importer tool. However, it would be more practical if the `Import()` argument can also accept RooDataHists and do the necessary conversion for you, which is suggested in this commit. This not only simplifies the code of the JSON import a bit, but should come in handy for all RooFit users that want to do binned simultaneous fits. | 14 February 2023, 11:38:01 UTC |
