| c8c457f | Sidian Wu | 18 April 2016, 19:56:32 UTC | Releasing Voldemort 1.10.15 | 18 April 2016, 19:56:32 UTC |
| 43f344a | Felix GV | 15 April 2016, 18:32:40 UTC | The AdminClient's verifyOrAddStore is vulnerable to connectivity issues. This commit makes the following changes: - verifyOrAddStore() is now more resilient to various kinds of exceptions. - VoldemortBuildAndPushJob now logs verifyOrAddStore's exceptions. - ExceptionUtils.recursiveClassEquals() can now look for many exception types. - Added ExceptionUtilsTest. | 16 April 2016, 00:00:32 UTC |
| 64eaff0 | Gareth Davis | 23 November 2015, 11:42:10 UTC | Multi module gradle build for voldemort Each contrib directory now becomes a separate project (although the no new build.gradle files have been created). This makes the import into Intellij better as it can setup the contrib source roots correctly. It also opens the door to refactoring the project to be more conventional in it's layout and artifact publishing. gradle 2.9 + fixing the eclipse project generation Had to rework the eclipse project generation configuration as it seems to disagree with the multi module project structure. The upgrade to gradle 2.9 fixes as issue with the eclipse generator where the JDK would be inserted twice into the .classpath file. Note that you can use the eclipse import gradle project feature, the only gotcha is that it defaults the output directory to /bin, which is means the script directory gets nuke'd by eclipse on rebuild. As a work around this config can be changed manually and then the bin dir restored from git if anybody prefers to use the native gradle support in eclipse. Have also added defaults for the test resource directory, this prevents IDEA from creating src/test/resources which is a little confusing. Note this will only happen if you use 'Create empty content roots' option in IDEA. Javadoc generation is disabled by default. The javadoc can be reenabled using -Pjavadoc.enabled=true The fix for zip & tar is picked from https://github.com/arunthirupathi/voldemort/commit/2e0e9cf58a5fd9dd386dcbed5f1af2e497290e2c | 09 April 2016, 12:50:43 UTC |
| 464a348 | Arunachalam Thirupathi | 25 March 2016, 21:27:25 UTC | Set-Metadata null Version error Set Metadata might result in the following error as listFiles can return null java.lang.NullPointerException at voldemort.store.configuration.ConfigurationStorageEngine.put(ConfigurationStorageEngine.java:146) at voldemort.store.configuration.ConfigurationStorageEngine.put(ConfigurationStorageEngine.java:50) at voldemort.store.metadata.MetadataStore.put(MetadataStore.java:355) | 30 March 2016, 23:57:27 UTC |
| 6809fce | Sidian Wu | 30 March 2016, 00:12:13 UTC | Releasing Voldemort 1.10.14 | 30 March 2016, 00:29:17 UTC |
| 74b2c09 | gaojieliu | 30 March 2016, 00:02:55 UTC | Merge pull request #396 from gaojieliu/FileFetcher_Stats Expose data points in FileFetcher and create autometrics sensors for them | 30 March 2016, 00:02:55 UTC |
| 0820122 | Gaojie Liu | 29 March 2016, 23:20:26 UTC | This change is mostly to expose more aggregated metrics for HDFS data pushes: 1. totalBytesFetched : the total bytes transferred from HDFS so far; 2. totalFetchRetries : the total fetch retry number so far; 3. totalCheckSumFailures : the total data file checksum failures happened so far; 4. totalAuthenticationFailures : the total authentication failures happened so far; 5. totalFileNotFoundFailures : the total file-not-found failures happened so far; 6. totalFileReadFailures : the total HDFS file read failures happened so far; 7. totalQuotaExceedFailures : the total quota exceed failures happened so far; 8. totalUnauthorizedStoreFailures : the total unauthorized store push failures happened so far; 9. parallelFetches : the total number of active fetches right now; 10. totalFetches : the total HDFS fetch number so far; 11. totalIncompleteFetches : the total incomplete fetch number so far; 12. totalDataFetchRate : the total data fetch rate right now; | 29 March 2016, 23:41:58 UTC |
| 64726a9 | Sidian Wu | 28 March 2016, 19:10:19 UTC | update checkout from disk instead of memory buffer. | 29 March 2016, 02:02:50 UTC |
| 46651fa | Arunachalam Thirupathi | 19 March 2016, 02:14:19 UTC | Update version after updating the data Currently the version is updated before the data and it makes the client to read the wrong values. Update the Version after updating the data, so when the client reads they have the correct value. | 25 March 2016, 20:15:10 UTC |
| d0364a3 | Sidian Wu | 25 March 2016, 00:37:25 UTC | minor change in StoreSwapperTest#testConcurrencyPush | 25 March 2016, 00:51:25 UTC |
| 66bfe3b | Arunachalam Thirupathi | 22 March 2016, 18:19:37 UTC | Hdfs FileSystem handles are leaked in Fetch Issue : After the HadoopFileSystem object is created, the validity of the fileSystem is verified by doing a sample operation. If the operation fails the Hadoop FileSystem object is leaked. This object should be cleaned up by the Garbage collection, but all the FileSystem objects are cached, so this is leaked. When voldemort server is used with secure webhdfs (swebhdfs) file system it leaks enough memory to kill the servers eventually. Previously in voldemort webhdfs file system handles were leaked. Apparently webhdfs file system handles are very cheap. But in SwebHdfs they have the security certificate embedded in them. This causes them to be very big. Heap Dump analysis WebHdfsFileSystem - 3768 Objects - 80 MB SWebHdfsFileSystem - 1748 Objects - 3 GB Solution : 1) Disable the caching for the following reason Hadoop FileSystem class caches the FileSystem objects based on the scheme , authority and UserGroupInformation. The default config was to generate new UserGroupInformation for each call, so the cache will be never hit. In the case where the FileSystem is not closed correctly, it will leak handles. But if the UserGroupInformation is re-used, it will cause the FileSystem object to be shared between HdfsFetcher / HdfsFailedFetchLock. Each Voldemort HdfsFetcher/HAFailedFetchLock lock closes the fileSystem object at the end, though others might still be using it. This causes random failures. Since it does not work in both the cases, the Caching is disabled. The caching should be only enabled if the UserGroupInformation is to be re-used and the close bug is fixed. 2) Clean up the file handles on the error cases. Traced down all the handles and cleaned them up on the error path. | 24 March 2016, 18:29:35 UTC |
| af3d605 | Sidian Wu | 22 March 2016, 01:51:10 UTC | Check server state when bring nodes back Fixed the issue when starting up Voldemort in offilne state, it actually goes online and keeps listening client requests. | 23 March 2016, 21:36:12 UTC |
| 7f6ff63 | Gareth Davis | 01 December 2015, 15:46:47 UTC | fixing a NPE thrown by the StorageEngineService on startup with views Result of the getCapability() implementation returning a null instead of throwing the required NoSuchCapabilityException. Example of the exception: Exception in thread "main" java.lang.NullPointerException at voldemort.server.storage.StorageService.startInner(StorageService.java:424) at voldemort.common.service.AbstractService.start(AbstractService.java:62) at voldemort.server.VoldemortServer.startInner(VoldemortServer.java:374) at voldemort.common.service.AbstractService.start(AbstractService.java:62) at voldemort.server.VoldemortServer.main(VoldemortServer.java:437) | 18 March 2016, 20:37:59 UTC |
| 394898e | Gaojie Liu | 11 March 2016, 23:36:37 UTC | This update includes two parts: 1. build.gradle change is to fix 'Wrong package statement' error when import voldemort to IntelliJ; 2. VoldemortBuildAndPushJob.java change is to make log message clearer when delete the temp files in grid generated by b&p job; | 12 March 2016, 01:07:06 UTC |
| 114e88a | Sidian Wu | 11 March 2016, 00:56:55 UTC | Disable store creation on the BnP side Refactored Admin.storeMgmtOps#verifyOrAddStore. It now takes a new boolean argument "creationStore" to decide whether or not adds new stores into the cluster if they are not found. Add a boolean value eableStoreCreation in VoldemortBuildAndPushJob. | 11 March 2016, 00:56:55 UTC |
| 3cfec9e | Sidian Wu | 02 March 2016, 21:23:56 UTC | Resolved concurrency push conflict and add unit test, refactor quirky AdmintClient used in HdfsFetcher, and add hyperlink in README.md 1. It was very likely to cause content conflict when multiply jobs try to push to the same store simultaneously. We add a hashmap in AdminRequestHandler to check whether a store is currently fetching or not. And if so, we block the rest of fetching request and throw an exception. 2. Added a unit test case under StoreSwapperTest. 3. The HdfsFetcher used to create an admintClient instance and asked itself "diskQuotaSizeInKB". This was a quirky used adminClient. We removed it and passed quota size directly from AdminRequestHandler. 4. Add a hyperlink in README.md to "A quick git guild for people who want to make contributions to Voldemort". | 10 March 2016, 19:51:21 UTC |
| 17f0def | Sidian Wu | 28 February 2016, 11:11:42 UTC | Better error message when pushing to a store with storage quota 0 Modidied AdminStoreSwapper#nvokeFetch() to throw originial sub-thread execption and changed InvalidBostrapURLException to make it more clear. | 02 March 2016, 01:16:28 UTC |
| 179347a | Arunachalam Thirupathi | 01 March 2016, 01:06:21 UTC | Report metrics for Scheduler and Async Service Scheduler Service reports tasks currently running and number of tasks in the queue Async Service reports cumulative Wait time and number of tasks waiting in the queue. | 01 March 2016, 01:06:21 UTC |
| 9f37c86 | Arunachalam Thirupathi | 09 February 2016, 02:18:58 UTC | Releasing Voldemort 1.10.13 | 09 February 2016, 02:18:58 UTC |
| abcf36a | Arunachalam Thirupathi | 08 February 2016, 21:50:03 UTC | Gradle Protobuf shadowed jar Gradle Protobuf shadowed jar | 09 February 2016, 02:11:05 UTC |
| ca2c427 | Sidian Wu | 22 January 2016, 19:40:37 UTC | ClientRequestExecutor Pool test unit test failure Previously by mistake it was assumed that JDK changed the exception behavior. But the problem was host/domain unknown.host was registered which caused the code to fail. Now since the host is changed to unknown.invalid the test is returned to the previous stage. | 22 January 2016, 19:40:37 UTC |
| 7e104c1 | Felix GV | 19 January 2016, 19:14:06 UTC | Better exception handling in HdfsFetcher#fetchFromSource(). Previously, a FileSystem#close() operation was guarded by a try/catch looking for IOExceptions only. It turns out this close() function can sometimes throw NPEs as well. This commit expands the catch clause to any exception type, and updates the logged message accordingly. | 19 January 2016, 19:59:09 UTC |
| 8da3c67 | Felix GV | 12 January 2016, 06:59:04 UTC | Releasing Voldemort 1.10.12 | 12 January 2016, 06:59:21 UTC |
| 5ee62b6 | Felix GV | 12 January 2016, 03:08:56 UTC | Changed HDFS directory size measurement in HdfsFetcher. This fixes two issues in 'build.primary.replicas.only': 1. The progress report in the AsyncTask was wrong, which also resulted in erroneous logs in the BnP job. 2. The previous implementation was DDOSing the NameNode with a furious amount of ListStatus operation, most of which it did not even need to get the result of. Also added retry with random back off when the ListStatus operations fail, and cleaned up HdfsFetcherAdvancedTest a little bit. | 12 January 2016, 06:56:22 UTC |
| 1fd44c9 | Felix GV | 09 January 2016, 02:18:04 UTC | Cleaned up the HadoopStoreWriterTest. It now leverages the BuildAndPushMapper code in order to generate files with the appropriate Read-Only formats. The tests in this class were broken since the more stringent sanity checks introduced in 421ada5e52c4db9330776beb2d3c4e7dbf720e2b. | 09 January 2016, 02:48:44 UTC |
| 490d2a1 | Arunachalam Thirupathi | 08 January 2016, 19:35:41 UTC | Releasing Voldemort 1.10.11 | 08 January 2016, 19:35:41 UTC |
| b46c97f | Gareth Davis | 08 January 2016, 14:43:28 UTC | fixing the 'unknown.host' test in ClientRequestExecutorPoolTest it turns out that somebody has registered 'unknown.host': $ host unknown.host unknown.host has address 188.68.51.215 unknown.host mail is handled by 10 serpens.uberspace.de. which is kinda of annoying. Have switched to using unknown.invalid as this is reserved and should never resolve. | 08 January 2016, 19:16:37 UTC |
| 421ada5 | Felix GV | 08 January 2016, 10:22:07 UTC | Bug fixes and improvements for Build and Push. - HadoopStoreWriter did not handle multiple chunks correctly which caused reduce tasks to step on each others' toes. Fixed. - Changed default 'reducer.per.bucket' config to true. - AbstractStoreBuilderConfigurable.getPartition() was broken when 'build.primary.replicas.only' was enabled. Fixed it and added a lot more comments. - Added defensive code in HadoopStoreWriter to catch future regressions in the partitioning (shuffling) code. - Improved logging in Props and HadoopStoreBuilder. | 08 January 2016, 18:55:27 UTC |
| b8d4f03 | Felix GV | 08 January 2016, 06:56:06 UTC | Fixed a bug where the Read-Only data directory config is not honored properly. This fixes a regression introduced in a7061474f905fe60a9581dbf4e14431d00b130a2. | 08 January 2016, 07:03:50 UTC |
| 6aec0c1 | Arunachalam Thirupathi | 07 January 2016, 02:25:21 UTC | Releasing Voldemort 1.10.10 | 07 January 2016, 02:25:21 UTC |
| 2b65a88 | ARUNACHALAM THIRUPATHI | 06 January 2016, 08:24:51 UTC | AdminClient does not obey the Client Timeout 1) For BuildAndPush If the Voldemort Cluster is far away from the Hadoop Cluster, the connection timeout causes the Job to fail. Increased the connection timeout in Azkaban.* files for this issue. 2) ClientConfig timeout is ignored by the AdminClient bootstrap methods and it constructs an arbitary ClientConfig. Fixed that. 3) AdminClient passes in empty AdminClientConfig and ClientConfig at multiple places. Removed that. | 07 January 2016, 02:07:48 UTC |
| 47e62bb | Felix GV | 06 January 2016, 06:01:19 UTC | Releasing Voldemort 1.10.9 | 06 January 2016, 06:01:19 UTC |
| c6f689e | Felix GV | 06 January 2016, 00:45:03 UTC | Fix for a regression introduced in a7061474f905fe60a9581dbf4e14431d00b130a2. Under certain partition assignment configurations, servers would skip the initialization of some partitions, which would then result in NPEs getting thrown during get requests. This issue is now fixed. In addition to that, the following changes are also included in this commit: - More comprehensive tests in ReadOnlyStorageEngineTest to catch the edge case. - Skipped the canGetGoodCompressedKeys() test in ReadOnlyStorageEngineTest since key compression is not supported in Read-Only / Build and Push. - Better error reporting in ChunkedFileSet.getChunkForKey(byte[] key). | 06 January 2016, 05:42:53 UTC |
| fa5bf0e | ARUNACHALAM THIRUPATHI | 05 January 2016, 22:51:24 UTC | UnknownHostException is different between JDK 1.6 and JDK 1.8 http://docs.oracle.com/javase/7/docs/api/java/nio/channels/UnresolvedAddressException.html has bad class hiearchy in JDK 1.6 seems like corrected in JDK 1.8 It is not instance of IO or Connect Exceptions. This broke the test, now the test looks for one of the other exception. The intention of the test is to keep the catastrophic errors up to date so it is hacky, but OK. | 05 January 2016, 22:51:24 UTC |
| 75fb6c8 | Felix GV | 17 December 2015, 02:39:45 UTC | Made vadmin.sh more resilient to node failures. | 05 January 2016, 19:32:06 UTC |
| bbb7e99 | Arunachalam Thirupathi | 05 January 2016, 01:35:43 UTC | Releasing Voldemort 1.10.8 | 05 January 2016, 01:35:43 UTC |
| 412614d | Arunachalam Thirupathi | 23 December 2015, 00:41:05 UTC | BnP job corrupts store when compression mismatches BnP job does not compare compression when making the schema check. One store was created with compression enabled on the first run and the next run removed it. The store silently corrupted the data. Now compression is compared and if compression does not match, it errors out instead of corrupting the data. | 05 January 2016, 01:01:00 UTC |
| 445b240 | Arunachalam Thirupathi | 18 December 2015, 22:27:06 UTC | Disabling Fetch Fails BnP HA When a node is in offline mode, it responds with fetch disabled error. Currently the error is not treated as a soft error and this fails the HA BnP. With this code change, FetchDisabled is considered as a soft error and the fetch will continue as normal. | 05 January 2016, 00:58:09 UTC |
| 8159584 | Arunachalam Thirupathi | 18 December 2015, 02:38:10 UTC | Add File List and Length based check for RO 1) Currently Stores are validated only for the definition and by doing a random get against any of the partition. Now for RO stores, the files are validated by their replication factor. If RF=1, a line will appear that this store consistency can't be validated. Store xyz has replication factor of 1, skipping consistency check across nodes If RF > 1, a file should have exactly the number of copies as RF. If the file lengths does not match, a warning is printed. Store abc File ReadOnlyFile [name=97_0_0.data, size=0] is expected in 2 nodes, but present only in [Node localhost:6666 [id 0]] Store abc File ReadOnlyFile [name=97_1_0.data, size=408351] is expected in 2 nodes, but present only in [Node localhost:6669 [id 1]] If the file is missing the following warning will appear but only once. The error reporting is very noisy, this is to alert for the presence of error. So thrown together quickly without considering the ease of use. Verified backward and forward compatibility of the change. | 05 January 2016, 00:51:28 UTC |
| 50f8eed | Arunachalam Thirupathi | 16 December 2015, 08:14:46 UTC | Adding file Length to GetROFileListRepsonse This will let build validators for the RO files being fetched. | 05 January 2016, 00:49:20 UTC |
| c4d65a8 | Arunachalam Thirupathi | 23 December 2015, 23:33:47 UTC | Fix the testNodeDownReplacement intermittent failure SchedulerService is not waiting for the scheduled jobs to shutdown and it proceeds with killing the BDB which causes a cursos exception being thrown. This will fix the test. | 23 December 2015, 23:33:47 UTC |
| cd3b9e0 | Arunachalam Thirupathi | 23 December 2015, 20:14:54 UTC | Fix RO JMX register/Unregister 1) Stores JMX are registered by JmxService class. 2) Previously ReadOnlyStorageConfiguration registered the same metrics by prepending the NodeId. As Part of the commit https://github.com/voldemort/voldemort/commit/2aec46a1edfbb6ab1eac4529d59ceb13f51e9fec#diff-005b79e324515c9e1045a61d0aee6d07 I fixed it and removed the NodeId. But I did not realize that this caused the name collission and overwriting. [18:50:45,445 voldemort.server.jmx.JmxService] WARN Overwriting mbean voldemort.store.readonly:type=test2 [main] [18:50:45,447 voldemort.server.jmx.JmxService] WARN Overwriting mbean voldemort.store.readonly:type=test1 [main] Now ReadOnlyStorageConfiguration does not register any JMX Metric at all. Used the JConsole to verify that it is the same object registered under two different names. Now the duplicate one is gone and the warnings on the shutdown of Read Only server will be gone as well. | 23 December 2015, 20:14:54 UTC |
| bc38518 | Felix GV | 16 December 2015, 02:29:11 UTC | Fixed regression introduced in fe5b01d71f85dac7bb431f12c4ccef3d26aaee47. | 16 December 2015, 02:29:11 UTC |
| 3dfcc66 | Felix GV | 16 December 2015, 01:05:13 UTC | Releasing Voldemort 1.10.7 | 16 December 2015, 01:05:13 UTC |
| fe5b01d | Felix GV | 16 December 2015, 00:26:42 UTC | Read-Only fetches now abort immediately when killed. Also improved vadmin.sh's output format and error handling. | 16 December 2015, 00:59:35 UTC |
| fc97f04 | Arunachalam Thirupathi | 15 December 2015, 21:15:45 UTC | Enhanced Admin Meta Check 1) When no parameter is passed in, it silently ignores all the checks. Now the default is changed to check all. 2) Random key is generated to probe the store. Previously it always passed in byte 0, which failed with InvalidMetadataException. | 15 December 2015, 21:17:13 UTC |
| 5a7ae63 | ARUNACHALAM THIRUPATHI | 14 December 2015, 18:45:58 UTC | BouncyCastle jar is required even when not enabled BouncyCastle jar is referenced from VoldemortServer and when VoldemortServer class is loaded, all its references are resolved which causes it to fail with ClassLoader error. Added one more level of indirection to avoid the direct reference and hence BouncyCastle is not required to be available in the class path when not enabled. | 15 December 2015, 03:13:10 UTC |
| ca1d52c | Jiaan | 08 November 2015, 03:13:19 UTC | add a customized workload that supports key size distribution and value size distribution from external files | 15 December 2015, 03:08:41 UTC |
| a706147 | Felix GV | 12 December 2015, 01:26:55 UTC | Introduced 'build.primary.replicas.only' mode in BnP. Summary: This new mode provides the capability of pushing to multiple clusters with different number of nodes and different partition assignments. Compatibility: Although this new mode only works if both the BnP job and the Voldemort servers are upgraded, the change can be rolled out gradually without breaking anything. There is a negotiation phase at the beginning of the BnP job which determines if all servers of all clusters are capable and willing (i.e.: configured) of using the new mode. If not all servers are upgraded and enabled, then the BnP job falls back to its old behavior. Likewise, if a server gets a fetch request from a non-upgraded BnP job, it will work just like before. By default, servers answer the negotiation by saying they support the new mode. The old behavior can be forced with the following server-side configuration: readonly.build.primary.replicas.only=false Running in this new mode has several implications: 1. When running in the new mode, store files are stored in the BnP output directory under nested partition directories, rather than in nested node directories. 2. The MR job uses half as many reducers and half as much shuffle bandwidth compared to before. 3. The meta checksum is now done per partition, rather than per node. 4. Instead of having one .metadata file per partition, there is now only a single full-store.metadata file at the root of the output directory. 5. The server-side HdfsFetcher code inspects the metadata file and determines if it should operate in 'build.primary.replicas.only' mode or not. If yes, then the server determines which partitions it needs to fetch on its own, rather than relying on what the BnP job placed in a node-specific directory. 6. The replica type number contained in Read-Only V2 file names is now useless, but we are keeping it in there just to avoid unnecessary changes. 7. When initializing a Read-Only V2 store directory, the server now looks for files named with the incorrect replica type, and if it finds any, it renames them to the replica type expected by this server. Other changes: 1. Added socket port to Node's toString functions. Also made the output of the Node's toString(), briefToString() and getStateString() functions more consistent. 2. Introduced new Protobuf message for the GetConfig admin request. This new message is intended to be a generic way to retrieve any of server config. 3. Refactored VoldemortConfig to provide access to any config by its string key. Also cleaned up a lot of hard-coded strings, which are constants now. 4. Various minor refactorings in BnP code. | 15 December 2015, 02:45:06 UTC |
| 69fcd3f | Felix GV | 06 November 2015, 02:52:03 UTC | Lots of BnP code clean up. - Refactored common Mapper and Collector code via the new BuildAndPushMapper and AbstractCollectorWrapper classes. - Refactored common 'reducer.per.bucket' code. HadoopStoreWriterPerBucket offers a superset of the HadoopStoreWriter's functionality, so it's not worth keeping the latter at all. - Changed some hard-coded strings to constants. - Deleted the following classes completely, which were either dead code, duplicate code, or useless abstractions: contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/AvroStoreBuilderReducerPerBucket.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/HadoopStoreBuilderReducerPerBucket.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/IdentityJsonMapper.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/IdentityJsonReducer.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/JobState.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/VoldemortStoreBuilderMapper.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/azkaban/VoldemortStoreBuilderJob.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/serialization/JsonConfigurable.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/serialization/JsonDeserializerComparator.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/serialization/JsonMapper.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/serialization/JsonOutputCollector.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/serialization/JsonReducer.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/serialization/JsonSequenceFileOutputFormat.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/utils/EmailMessage.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/utils/KeyValuePartitioner.java contrib/hadoop-store-builder/src/java/voldemort/store/readonly/mr/utils/MapperKeyValueWriter.java | 12 December 2015, 01:25:37 UTC |
| 0e583be | Felix GV | 11 December 2015, 17:48:27 UTC | Better error message for an unknown admin operations. Previously, the AdminServiceRequestHandler returned an error message which said "Metadata Key passed '' is not handled yet" whenever attempting to parse VProtoAdmin messages serialized by an AdminClient with more/newer capabilities than the server's. | 12 December 2015, 00:24:21 UTC |
| 22be8bc | Arunachalam Thirupathi | 09 December 2015, 03:21:01 UTC | Releasing Voldemort 1.10.6 | 09 December 2015, 03:21:01 UTC |
| 36d3655 | Arunachalam Thirupathi | 08 December 2015, 22:32:12 UTC | Swap Only on IOException,UnreachableStoreException Currently Swap is attempted for any failure. Now the swap will be attempted only if the failure is an IO or UnreachableStoreException. Other exceptions will cause the push to fail. | 08 December 2015, 23:36:33 UTC |
| 33f48ed | ARUNACHALAM THIRUPATHI | 08 December 2015, 07:51:08 UTC | Create JMX mbeans for tracking multiple server states Following states are tracked Server 0->normal, 1->offline, 2->rebalancing SlopStreaming 0->enabled,1->disabled PartitionStreaming 0->enabled,1->disabled ReadOnlyFetching 0->enabled,1->disabled QuotaEnforcing 0->enabled,1->disabled | 08 December 2015, 07:51:08 UTC |
| aa11fd1 | Yan | 08 December 2015, 02:05:18 UTC | Merge pull request #352 from squarY/bouncycastle Let read only server use bouncy castle as JCE provider. | 08 December 2015, 02:05:18 UTC |
| 695ae80 | Yan Yan(Data Infrastructure) | 03 December 2015, 19:42:00 UTC | Let read only server use bouncy castle as JCE provider. Initialize BouncyCastleProvider in VoldemortServer constructor if it's enabled. Fix minor format issue. Fix unessary format changing. Fix unessary format issue. Remove useless parameter. | 05 December 2015, 00:17:47 UTC |
| c927688 | Felix GV | 04 December 2015, 01:24:36 UTC | BnP logging improvements: - BnP job now emits config properties in one entry per line. - Bumped up some useful logs to INFO level in the HttpHook. | 04 December 2015, 19:08:41 UTC |
| 5b09c8e | Yan | 25 November 2015, 23:14:16 UTC | Merge pull request #350 from squarY/master Releasing Voldemort 1.10.5 | 25 November 2015, 23:14:16 UTC |
| fb23553 | Yan Yan(Data Infrastructure) | 25 November 2015, 02:39:22 UTC | Releasing Voldemort 1.10.5 Fix typos. | 25 November 2015, 23:12:37 UTC |
| d53d534 | Yan | 23 November 2015, 22:32:48 UTC | Merge pull request #349 from squarY/sslbnpmerged Squash commits. Let Voldemort node can modify URL before fetching file. | 23 November 2015, 22:32:48 UTC |
| f88adc4 | Yan Yan | 19 November 2015, 07:47:05 UTC | Add 3 properties in Voldemort configuration. Let voldemort node can turn on or turn off SSL when fetching file from HDFS. Fix the issue when url dose not contain protocl(Eg. local file path), parsing url will cause String index out of range exception. Rollback the format change to original codes. Make modify URL feature more generic and use java.net.URL instead of parsing URL mannually. Move modify URL feature to Utils class. And let VoldemortSwapJob to invode this method to replace url. Let voldemort node modify URL separately before fetching file. | 21 November 2015, 01:03:33 UTC |
| 71cc55c | Arunachalam Thirupathi | 17 November 2015, 02:57:09 UTC | Update metadata version cluster, stores At times metadata version on a cluster.xml and stores.xml drifts The next metadata update instead of consolidating these versions updates at few places and ignores at few other places. This causes the client to not re-bootstrap correctly when the cluster.xml or stores.xml is changed. Now when a cluster.xml is changed, the version is synchronized across the cluster to let the clients auto rebootstrap. This fix merges the VectorClock on all the nodes to be updated so that the Stores version will be updated correctly. The old methods which does not take nodes as parameters are removed and the public method exposes the nodes as parameters. | 18 November 2015, 02:50:45 UTC |
| b30fdfe | Greg Banks | 17 November 2015, 06:27:25 UTC | Merge pull request #345 from gnb/VOLDENG-2171bis Extend shell "preflist" command to show partitions, v2 | 17 November 2015, 06:27:25 UTC |
| 24c8290 | Greg Banks | 17 November 2015, 01:07:51 UTC | Extend shell "preflist" command to show partitions, v2 After valuable feedback from athirupthi | 17 November 2015, 01:07:51 UTC |
| 64c90eb | Greg Banks | 16 November 2015, 22:10:09 UTC | Merge pull request #343 from gnb/VOLDENG-2170 Fix shell "preflist" command key parsing | 16 November 2015, 22:10:09 UTC |
| 7970985 | Greg Banks | 16 November 2015, 19:40:45 UTC | Fix shell "preflist" command key parsing | 16 November 2015, 19:40:45 UTC |
| d8068f3 | Greg Banks | 13 November 2015, 04:24:00 UTC | Merge pull request #339 from stotch/generate_cluster_xml_fixes Small fixes to generate_cluster_xml.py | 13 November 2015, 04:24:00 UTC |
| d1926e5 | Greg Banks | 13 November 2015, 02:49:19 UTC | Merge pull request #342 from gnb/rorep2 ReadOnlyReplicationHelperCLI: do not rely on down node | 13 November 2015, 02:49:19 UTC |
| bc679b7 | Greg Banks | 13 November 2015, 01:46:17 UTC | ReadOnlyReplicationHelperCLI: do not rely on down node When building a list of partitions to be copied between nodes to restore a down node, don't expect to be able to fetch any useful metadata from the down node. v2: better method naming per feedback from athirupathi | 13 November 2015, 02:46:22 UTC |
| 91b1f09 | Brendan Harris | 12 November 2015, 02:49:15 UTC | Removed trailing whitespace, made list of partitions sorted by integer value and marked file as executable | 12 November 2015, 02:49:19 UTC |
| c3a8360 | Felix GV | 12 November 2015, 00:12:32 UTC | Releasing Voldemort 1.10.4 | 12 November 2015, 00:12:32 UTC |
| 9c66806 | singhsiddharth | 11 November 2015, 22:10:15 UTC | Merge pull request #338 from FelixGV/ro_fix_handleDisableStoreVersion Bug fix for BnP HA | 11 November 2015, 22:10:15 UTC |
| 975459c | Felix GV | 11 November 2015, 21:57:05 UTC | Bug fix for BnP HA: - StoreVersionManager.getDisabledMarkerFile() did not look for the right file name. - Also added unit tests and better log messages for this. Debuggability improvements in AdminServiceRequestHandler: - More exceptions now logged with their full stacktrace on the server-side. - The request info is now printed in a more readable format. BnP job will now fail properly when clusters are inconsistent, rather than just exiting. | 11 November 2015, 22:01:14 UTC |
| 640fbc7 | Felix GV | 09 November 2015, 23:04:14 UTC | HadoopUtils clean up: - Clarified JSON-specific error messages. - Removed dead code. | 09 November 2015, 23:04:14 UTC |
| 678ba81 | singhsiddharth | 06 November 2015, 07:33:48 UTC | Merge pull request #335 from stotch/voldemort-shell-properties-squashed Make VoldemortClientShell adminClient use user-defined properties file | 06 November 2015, 07:33:48 UTC |
| 6ebecb0 | Brendan Harris | 06 November 2015, 05:20:59 UTC | adminClient now uses the same ClientConfig as the SocketStoreClient so that it too can get the overrides passed in by a user defined config file | 06 November 2015, 05:22:27 UTC |
| 9fa20d4 | Felix GV | 04 November 2015, 18:47:40 UTC | Releasing Voldemort 1.10.3 | 04 November 2015, 18:47:40 UTC |
| a0e19c6 | James Lent | 16 October 2015, 21:07:53 UTC | Implement the truncate function in the RocksDB storage engine. This functionality is required by the delete store command. It is implemented using a non default Column Family named after the store. This approach could be extended to allow multiple stores to be supported by a single RocksDB database. It is, however, not backwards compatible with the existing code. A data migration would be required to support existing stores. | 04 November 2015, 18:28:32 UTC |
| 2b6015e | Felix GV | 03 November 2015, 01:25:21 UTC | Moved BnP's verifyOrAddStore() to the AdminClient. This makes it easier to leverage this more resilient/idempotent Add Store operation from other processes. Also included minor refactorings. | 03 November 2015, 21:23:20 UTC |
| 6faa899 | singhsiddharth | 03 November 2015, 19:54:19 UTC | Merge pull request #333 from stotch/voldemort-shell-properties-squashed voldemort-shell support for properties file overrides | 03 November 2015, 19:54:19 UTC |
| 8c6dcf8 | Brendan Harris | 03 November 2015, 01:43:27 UTC | Removing the redundant argument check so that the VoldemortClientShell.java option parser can be used to query help Removing the redundant argument check so that the VoldemortClientShell.java option parser can be used to query help Augmented help and added an option for passing in a properties file The shell now passes in an option that tells VoldemortClientShell that it is being called from voldemort-shell.sh so that it can properly format the help output The shell now passes in an option that tells VoldemortClientShell that it is being called from voldemort-shell.sh so that it can properly format the help output Made help for --voldemort-shell option more 'helpful' Mistakenly bumped up a greaterthan check on the positional arguments ... Rolling that back Rewording --help helper text to be more helpful | 03 November 2015, 06:52:41 UTC |
| 1ac3a94 | Arunachalam Thirupathi | 03 November 2015, 00:36:26 UTC | Forklift tool schema comparison 1) ignore-schema-check was handled but not exposed as a parameter. Seems like joptSimpleParser will error out, if the parameters are not set up correctly. 2) Serializers are compared using string which resulted in lot more error. Using the Schema comparison based on Avro and JSON now. Most of the code here is auto generated (except for AVroGenericVersioned) where I modified some code by hand. 3) Fixed invalid stores xml. | 03 November 2015, 02:32:46 UTC |
| 0311bc6 | Felix GV | 30 October 2015, 22:54:20 UTC | Releasing Voldemort 1.10.2 | 30 October 2015, 22:56:18 UTC |
| bc10986 | singhsiddharth | 30 October 2015, 22:47:50 UTC | Merge pull request #329 from FelixGV/bnp_rename_fix Fixed rename operation in HdfsFailedFetchLock | 30 October 2015, 22:47:50 UTC |
| c7bce4d | Felix GV | 30 October 2015, 22:31:42 UTC | Fixed rename operation in HdfsFailedFetchLock Regression introduced in 831b80955ed609b7012bb85e8ce50d119170f635. | 30 October 2015, 22:31:42 UTC |
| 5f51537 | Felix GV | 29 October 2015, 01:51:20 UTC | Added a validator for Read-Only files. Given a data directory, the ReadOnlyFileValidator class checks a few things: - Index files are well formed: - Well sorted - No negative offset - Data files are well formed: - Number of records for a given key hash is > 0 - Key and value sizes are > 0 - Index and data files match together: - No gaps in data files, when traversing them with the offsets from index files - Raw keys in data files match the hashes found in their index files It then prints a summary of the amount and kinds of problems found. Disclaimers: - This tool only works with Voldemort Read-Only V2 formatted files. - This tool does NOT rely on the checksum in the .metadata file. - This tool only inspects the structural integrity of index and data files, and whether they match together. - If a problem is detected, you're in trouble for sure, but if no problems are detected, that doesn't mean an unsupported problem didn't slip through undetected (i.e.: false negatives are possible but false positives are not). Also added a bash run script in bin/read-only-file-validator.sh | 29 October 2015, 23:35:10 UTC |
| ec50a64 | Felix GV | 27 October 2015, 22:40:39 UTC | Releasing Voldemort 1.10.1 | 27 October 2015, 22:40:39 UTC |
| abf6353 | Felix GV | 27 October 2015, 01:23:37 UTC | Fixed regression introduced in d25d169862cc12e599bb1c916d684d89b5b4bfd4. The Read-Only servers used to percolate exception messages back to Build and Push jobs, for easy debugging of Hadoop-related exceptions (i.e.: AccessControlException). As part of the commit above, the server begun swallowing the underlying exceptions' message, which makes debugging BnP jobs harder. This commit fixes the regression. Also included some minor clean ups, such as JavaDoc improvements and @Deprecated annotations for the test-only functions. | 27 October 2015, 22:34:04 UTC |
| 10d94a3 | Arunachalam Thirupathi | 27 October 2015, 21:46:30 UTC | CopyStats Regression MessageDigest.digest() is read once, after it is read the contents of the digest are reset. Without knowing this, now started outputting checksum to stats file which broke the normal flow. Passing Around MessageDigest is dangerous because of this, so modified the method to return byte arrays which are then passed around. | 27 October 2015, 22:03:37 UTC |
| f83442d | Arunachalam Thirupathi | 24 October 2015, 01:55:18 UTC | Client do not remove dead connections When Server grace fully closes a connection, client ignores the connection close. After this an operation that gets this connection fails with EOFException as read/write returns -1 which causes the operation to fail. Mostly this is fine as the backup operation generaly succeeds, but when a cluster is bounced due to upgrade or other reasons, and if a client ends up caching all dead connections, it causes the operation to fail. After a client operation is done, previously the socket is registered with the selector for no-intention. For the next operation we start with write. With this change, the socket will be left in read mode. So FIN packet from the server will be processed and the socket will be closed. Any connection checkout from the pool needs to validate the connection. There is a race condition as the returned connection from the cache could still be killed later, that is handled as well. Stream processors must be closed after the socket is closed. Client will not be able to handle these close messages correctly. Added more comments to the Client Request Executor. Tests for dead connection clearing | 27 October 2015, 21:56:42 UTC |
| 9c87ad8 | ARUNACHALAM THIRUPATHI | 27 October 2015, 01:19:29 UTC | Merge pull request #325 from arunthirupathi/checkSumToStatsFile Output Checksum to Stats File | 27 October 2015, 01:19:29 UTC |
| 1e08ab1 | Arunachalam Thirupathi | 26 October 2015, 19:24:26 UTC | Output Checksum to Stats File 1) Output Checksum to stats file, can be used for individual file validation 2) Open the stats file in append only mode, so when a version is pushed deleted and re-pushed we have some history in the stats file. 3) Add a version to the stats file. So now the stats file will have the suffix -v<Version_number> which can be used by the script for parsing of the columns | 27 October 2015, 01:17:29 UTC |
| 95f60e8 | Felix GV | 22 October 2015, 04:09:24 UTC | Removed the set quota admin op from BnP. The default quota for new stores is now controlled by a server-side config, so this is redundant (and harmful to users who do not wish to use quotas in this manner). | 26 October 2015, 18:26:05 UTC |
| 49beabb | Felix GV | 22 October 2015, 21:25:39 UTC | Read-Only server now avoids needlessly recreating symlinks. There are cases (i.e.: emergency situations) where we may want to chmod -w a data directory and recreating the symlinks systematically then prevents the server from being able to start up. This change inspects the symlink which is already present and avoids recreating it if it's already pointing at the right destination. | 22 October 2015, 21:25:39 UTC |
| d780f55 | Felix GV | 19 October 2015, 19:58:17 UTC | Releasing Voldemort 1.10.0 | 19 October 2015, 19:58:17 UTC |
| f7303df | Felix GV | 16 October 2015, 22:47:38 UTC | Protection against data corruption. If index or data files are somehow corrupted, or mismatched (meaning that the index file from one store/version gets used in combination with a data file for another store/version), then the server gets into bad buffer allocation problems, causing IllegalArgumentExceptions and potentially OOMing in the process. This commit makes it easier to debug the issues and protect against the OOMs. Changes include: - Disallow allocation of negative size buffers. - Disallow allocation of excessively large value buffers (configurable, max 25 MB by default). - Disallow allocation of a buffer which would go past the data file's length. - Server-side logs now print out the file name and key (in hex) which triggered the problem. - Server-side logs now print out the socket name and stacktrace when SelectorManagerWorker catches a Throwable. - Client-side will report an "internal server error" when any of the bad allocation scenarios described above happen. - Slight optimization in the allocation strategy while reading the key/values in a data file. | 19 October 2015, 19:23:46 UTC |
| d4e27d9 | Arunachalam Thirupathi | 17 October 2015, 02:01:42 UTC | Test for ChunkedFileSet Collission Test for ChunkedFileSet collission case. | 17 October 2015, 02:02:22 UTC |
| 8b7b4cc | James Lent | 24 September 2015, 16:33:40 UTC | Make some modifications to how the benchmarking tool works in local mode as part of an evaluation of the RocksDB strorage engine: 1) Ensure that all the warm up records requested are created to eliminate some random errors. 2) Modify the mixed operation in local mode to increment the VectorClock to prevent all iterations from failing due to ObsoleteVersion exceptions. 3) Modify the mixed operation to perform the write even if the read returns nothing rather than silently passing without performing a write (I considered making this an error, but, preferred this approach). 4) Add a new Warning count similar to the ReturnCode count to report how often a mixed operation reads nothing (could be used for other situations). 5) Move the RecordCode report outside the summaryOnly check so that the error counts are always reported. 6) Make it possible to configure the storage engine in local mode. 7) Make several of the RocksDB parameters configurable. | 16 October 2015, 02:08:09 UTC |
| 13d055a | Bhavani Sudha Saktheeswaran | 08 October 2015, 18:04:02 UTC | Releasing Voldemort 1.9.22 | 08 October 2015, 18:04:02 UTC |
| d708069 | Bhavani Sudha Saktheeswaran | 06 October 2015, 23:31:44 UTC | fix tests | 06 October 2015, 23:31:44 UTC |
