https://github.com/coreos/etcd

sort by:
Revision Author Date Message Commit Date
e13c894 Merge pull request #10795 from jingyih/automated-cherry-pick-of-#10788-origin-release-3.1 Automated cherry pick of #10788 on release-3.1 05 June 2019, 22:30:40 UTC
f330a48 ctlv3: add missing newline in EndpointHealth To make the output consistent with the output before #9540. 05 June 2019, 21:39:02 UTC
317ff58 Merge pull request #10784 from jingyih/cherrypick_9540_to_release3p1 ctlv3: cherry pick of #9540 to release 3.1 04 June 2019, 16:51:59 UTC
3b02c60 ctlv3: support "write-out" for "endpoint health" command Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 04 June 2019, 01:12:15 UTC
2210462 Add 3.1 branch metadata (#10696) Signed-off-by: lucperkins <lucperkins@gmail.com> 30 April 2019, 21:02:52 UTC
5eaa1e9 Merge pull request #10658 from jpbetz/automated-cherry-pick-of-#10646-release-3.1 Automated cherry pick of #10646 18 April 2019, 21:10:09 UTC
1364ca2 mvcc: fix db_compaction_total_duration_milliseconds 17 April 2019, 23:33:50 UTC
45d616a Merge pull request #10451 from jpbetz/automated-cherry-pick-of-#10443-origin-release-3.1 Automated cherry pick of #10443 to release 3.1 06 February 2019, 17:59:14 UTC
19e9417 etcdctl: fix strings.HasPrefix args order Signed-off-by: Iskander Sharipov <quasilyte@gmail.com> 05 February 2019, 21:13:01 UTC
45adad4 version: bump up to 3.1.20+git 10 October 2018, 18:13:01 UTC
992dbd4 version: bump up to 3.1.20 10 October 2018, 18:02:11 UTC
b39c0f9 etcdserver: add "etcd_server_read_indexes_failed_total" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 01:21:06 UTC
3381ef1 rafthttp: probe all raft transports This PR adds another probing routine to monitor the connection for Raft message transports. Previously, we only monitored snapshot transports. In our production cluster, we found one TCP connection had >8-sec latencies to a remote peer, but "etcd_network_peer_round_trip_time_seconds" metrics shows <1-sec latency distribution, which means etcd server was not sampling enough while such latency spikes happen outside of snapshot pipeline connection. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 01:16:08 UTC
c096dc2 etcdserver: add "etcd_server_health_success/failures" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 01:06:37 UTC
3e99b42 Merge pull request #10163 from jingyih/automated-cherry-pick-of-#10153-origin-release-3.1 clientv3: automated cherry pick of #10153 to release 3.1 09 October 2018, 01:46:55 UTC
cf7be48 clientv3: concurrency.Mutex.Lock() - preserve invariant Convenient invariant: - if werr == nil then lock is supposed to be locked at the moment. While we could not be confident in stronger invariant ('is exactly locked'), it were inconvenient that previous code could return `werr == nil` after Mutex.Unlock. It could happen when ctx is canceled/timeouted exactly after waitDeletes successfully returned werr == nil and before `<-ctx.Done()` checked. While such situation is very rare, it is still possible. fixes #10111 08 October 2018, 23:53:39 UTC
65fff06 Merge pull request #10124 from jingyih/cherry-pick-of-#10109-origin-release-3.1 etcdctl: cherry pick of #10109 to release-3.1 26 September 2018, 02:55:23 UTC
87b4e08 etcdctl: cherry pick of #10109 to release-3.1 Add snapshot file integrity verification when querying snapshot status. 26 September 2018, 00:51:12 UTC
216be8b etcdserver: add "etcd_server_id" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:49:01 UTC
dfcf82b etcdserver: clarify read index wait timeout warnings Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:38:22 UTC
9197907 rafthttp: clarify "became inactive" warning Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:33:17 UTC
14883ca Merge pull request #10043 from wenjiaswe/automated-cherry-pick-of-#9997-upstream-release-3.1 Automated cherry pick of #9997 29 August 2018, 19:42:05 UTC
4e7691d remove automatic added imports 28 August 2018, 22:00:44 UTC
8a68ae9 etcdserver/api/rafthttp: add v3 snapshot send/receive metrics Distribution would be: 0.1 second or more ... 25.6 seconds or more 51.2 seconds or more etcd_network_snapshot_send_success etcd_network_snapshot_send_failures etcd_network_snapshot_send_total_duration_seconds etcd_network_snapshot_receive_success etcd_network_snapshot_receive_failures etcd_network_snapshot_receive_total_duration_seconds Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 28 August 2018, 21:34:21 UTC
ef1d332 etcdserver/api/snap: add v3 snapshot fsync metrics etcd_snap_db_fsync_duration_seconds_count etcd_snap_db_save_total_duration_seconds_bucket Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 28 August 2018, 21:16:05 UTC
116c442 Merge pull request #10034 from gyuho/init-metrics-3.1 etcdserver/api/v3rpc: display all registered gRPC metrics at start (v3.1) 25 August 2018, 01:52:40 UTC
e07fb41 etcdserver/api/v3rpc: display all registered gRPC metrics at start Previously, only display the one that has been requested at least once. Now it shows all metrics, as we do in v3.3 and v3.4+. grpc_server_started_total{grpc_method="Alarm",grpc_service="etcdserverpb.Maintenance",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="AuthDisable",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="AuthEnable",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Authenticate",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Compact",grpc_service="etcdserverpb.KV",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Defragment",grpc_service="etcdserverpb.Maintenance",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="DeleteRange",grpc_service="etcdserverpb.KV",grpc_type="unary"} 0 Should help document metrics. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 23 August 2018, 02:14:58 UTC
2c616b0 Merge pull request #10030 from jingyih/cherry-pick-of-#9990-origin-release-3.1 etcdserver: cherry pick of #9990 to release 3.1 20 August 2018, 22:33:27 UTC
dd2803c etcdserver: add grpc interceptor to log info on incoming request to etcdserver To improve debuggability of etcd v3.1. Added a grpc interceptor to log info on incoming requests to etcd server. The log output includes remote client info, request content (with value field redacted), request handling latency, response size, etc. Dependency on zap logger and grpc_middleware is removed during backporting. Added checking in logging interceptor. If debug level is disabled, skip logUnaryRequestStats() to avoid potential performance degradation. (PR #10021) 20 August 2018, 21:32:48 UTC
4855ca6 etcdserver: add grpc interceptor to log info on incoming request to etcdserver. To improve debuggability of etcd v3. Added a grpc interceptor to log info on incoming requests to etcd server. The log output includes remote client info, request content (with value field redacted), request handling latency, response size, etc. Dependency on zap logger and grpc_middleware is removed during backporting. Added checking in logging interceptor. If debug level is disabled, skip logUnaryRequestStats() to avoid potential performance degradation. (PR #10021) 20 August 2018, 20:54:24 UTC
bb205ca version: bump up to 3.1.19+git 24 July 2018, 17:07:31 UTC
a1d6802 version: bump up to 3.1.19 24 July 2018, 17:04:37 UTC
79d80bd etcdserver: add "etcd_server_go_version" metric Currently, one has to look at server logs manually, to see what Go version was used to build etcd server. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 July 2018, 23:38:10 UTC
081519c clientv3: fix keepalive send interval when response queue is full client should update next keepalive send time even when lease keepalive response queue becomes full. Otherwise, client sends keepalive request every 500ms regardless of TTL when the send is only expected to happen with the interval of TTL / 3 at minimum. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 July 2018, 15:50:07 UTC
e0d5a02 Merge pull request #9944 from wenjiaswe/automated-cherry-pick-of-#9761-upstream-release-3.1 Automated cherry pick of #9761 20 July 2018, 21:51:20 UTC
a421a60 remove hashRevDurations 20 July 2018, 20:49:58 UTC
0fbf49d etcdserver: rename to "heartbeat_send_failures_total" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 18:40:37 UTC
fb5080b mvcc: add "etcd_mvcc_hash_(rev)_duration_seconds" etcd_mvcc_hash_duration_seconds etcd_mvcc_hash_rev_duration_seconds Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 18:37:06 UTC
cac6ce7 mvcc/backend: fix defrag duration scale Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 17:53:26 UTC
9f58e57 mvcc/backend: add "etcd_disk_backend_defrag_duration_seconds" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 17:53:26 UTC
22c25dd mvcc/backend: document metrics ExponentialBuckets Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 17:44:52 UTC
92a7b5d mvcc/backend: clean up mutex, logging Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 17:35:39 UTC
3f1fe61 etcdserver: add "etcd_server_slow_apply_total" {"level":"warn","ts":1527101858.6985068,"caller":"etcdserver/util.go:115","msg":"apply request took too long","took":0.114101529,"expected-duration":0.1,"prefix":"","request":"header:<ID:1029181977902852337> put:<key:\"\\000\\000... Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 17:25:16 UTC
b854773 etcdserver: add "etcd_server_heartbeat_failures_total" {"level":"warn","ts":1527101858.4149103,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.025771662} {"level":"warn","ts":1527101858.4149644,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.034015766} Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 17:24:40 UTC
78a13e6 mvcc/backend: avoid unnecessary metrics update https://github.com/coreos/etcd/pull/9300 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:53:20 UTC
84d11a5 mvcc: use "t.tx.DB()" to fetch DB Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:34:20 UTC
a9c4b98 mvcc: add "etcd_mvcc_db_total_size_in_use_in_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:21:11 UTC
5531e3b mvcc: add "etcd_mvcc_db_total_size_in_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 20:51:06 UTC
c2623bb etcdserver: add "etcd_server_quota_backend_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 20:30:10 UTC
f46b467 etcdserver: add "etcd_server_slow_read_indexes_total" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 19:58:29 UTC
09843d5 etcdserver: clarify read index warnings Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 19:55:31 UTC
be3e6f6 tests: update test scripts Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 18 June 2018, 21:15:52 UTC
d84dd18 version: bump up to 3.1.18+git 15 June 2018, 16:51:30 UTC
b7ff47f version: bump up to 3.1.18 15 June 2018, 16:47:04 UTC
fab24fb Merge pull request #9848 from wenjiaswe/automated-cherry-pick-of-#8960-upstream-release-3.1 Automated cherry pick of #8960 13 June 2018, 23:49:48 UTC
b3ee996 metrics: Add server_version metric 13 June 2018, 23:31:18 UTC
06da6cf tests/semaphore.test.bash: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 June 2018, 21:42:45 UTC
9c00100 Makefile: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 June 2018, 21:42:10 UTC
1d7a2ca Merge pull request #9838 from jpbetz/automated-cherry-pick-of-#9821-origin-release-3.1-1528833932 etcdserver: Automated cherry pick of detailed "took too long" warnings to release-3.1 12 June 2018, 20:54:40 UTC
e90934e etcdserver: Fix txn request 'took too long' warnings to use loggable request stringer 12 June 2018, 20:22:45 UTC
23c5c71 etcdserver: Add response byte size and range response count to took too long warning 12 June 2018, 20:22:45 UTC
72a2483 etcdserver: Replace value contents with value_size in request took too long warning 12 June 2018, 20:15:19 UTC
53eae78 etcdserver: not print password in the warning message of expensive request Fix https://github.com/coreos/etcd/issues/9635 12 June 2018, 20:15:18 UTC
7b1b7de etcdserver: Fix to backport of #9288 for pre-RequestV2 code 12 June 2018, 20:13:46 UTC
df000fd etcdserver: improve request took too long warning 12 June 2018, 20:13:46 UTC
fd61be4 version: bump up to 3.1.17+git 06 June 2018, 17:36:22 UTC
781cc0b version: bump up to 3.1.17 06 June 2018, 16:54:59 UTC
ebe351e Merge pull request #9808 from jpbetz/snapshot-recover-3.1 etcdserver: Backport snapshot recovery from #7917 to 3.1 branch 05 June 2018, 23:13:40 UTC
e315109 etcdserver: Backport snapshot recovery from #7917 to 3.1 branch 05 June 2018, 04:52:26 UTC
43b0caf version: bump up to 3.1.16+git 31 May 2018, 19:54:30 UTC
169af44 version: bump up to 3.1.16 31 May 2018, 19:51:28 UTC
c4c487e mvcc: fix panic by allowing future revision watcher from restore operation This also happens without gRPC proxy. Fix panic when gRPC proxy leader watcher is restored: ``` go test -v -tags cluster_proxy -cpu 4 -race -run TestV3WatchRestoreSnapshotUnsync === RUN TestV3WatchRestoreSnapshotUnsync panic: watcher minimum revision 9223372036854775805 should not exceed current revision 16 goroutine 156 [running]: github.com/coreos/etcd/mvcc.(*watcherGroup).chooseAll(0xc4202b8720, 0x10, 0xffffffffffffffff, 0x1) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:242 +0x3b5 github.com/coreos/etcd/mvcc.(*watcherGroup).choose(0xc4202b8720, 0x200, 0x10, 0xffffffffffffffff, 0xc420253378, 0xc420253378) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:225 +0x289 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchers(0xc4202b86e0, 0x0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:340 +0x237 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchersLoop(0xc4202b86e0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:214 +0x280 created by github.com/coreos/etcd/mvcc.newWatchableStore /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:90 +0x477 exit status 2 FAIL github.com/coreos/etcd/integration 2.551s ``` gRPC proxy spawns a watcher with a key "proxy-namespace__lostleader" and watch revision "int64(math.MaxInt64 - 2)" to detect leader loss. But, when the partitioned node restores, this watcher triggers panic with "watcher minimum revision ... should not exceed current ...". This check was added a long time ago, by my PR, when there was no gRPC proxy: https://github.com/coreos/etcd/pull/4043#discussion_r48457145 > we can remove this checking actually. it is impossible for a unsynced watching to have a future rev. or we should just panic here. However, now it's possible that a unsynced watcher has a future revision, when it was moved from a synced watcher group through restore operation. This PR adds "restore" flag to indicate that a watcher was moved from the synced watcher group with restore operation. Otherwise, the watcher with future revision in an unsynced watcher group would still panic. Example logs with future revision watcher from restore operation: ``` {"level":"info","ts":1527196358.9057755,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} {"level":"info","ts":1527196358.910349,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} ``` Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 31 May 2018, 18:42:25 UTC
6bb88b9 version: bump up to 3.1.15+git 09 May 2018, 17:26:18 UTC
380b833 version: bump up to 3.1.15 09 May 2018, 17:21:07 UTC
01d9b36 Merge pull request #9693 from mohitsoni/release-3.1 Cherry-picking PR 7967 to release-3.1 04 May 2018, 19:16:27 UTC
ea82927 etcdserver: purge old snap.db files Lots of garbage db files in #7957. Should purge. 04 May 2018, 17:29:26 UTC
d2f6065 version: bump up to 3.1.14+git 24 April 2018, 20:45:40 UTC
2373ddb version: bump up to 3.1.14 24 April 2018, 20:23:45 UTC
5da3a72 Merge pull request #9606 from jpbetz/automated-cherry-pick-of-#9587-release-3.1 Automated cherry pick of #9587 23 April 2018, 19:48:23 UTC
3865d69 etcdserver: add is_leader prometheus metric that is 1 on the leader. Before this change, we had now way to find a leader using /metrics endpoint. This commit adds a metric to do that. 23 April 2018, 18:10:12 UTC
c764878 etcdmain: fix "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 18:09:07 UTC
e66af56 etcdserver: log skipping initial election tick Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 18:07:51 UTC
097a653 etcdmain: add "--initial-election-tick-advance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 18:07:36 UTC
d2673ce embed: add "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 18:06:36 UTC
4e63906 integration: set InitialElectionTickAdvance to true by default Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 18:05:15 UTC
0c0bf3f etcdserver: add "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 18:03:16 UTC
1648739 test: simplify CI tests Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 April 2018, 02:05:34 UTC
c6ae68d travis.yml: update, remove go tip tests Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 18:15:37 UTC
3b6bd6e tests: move Semaphore script Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 09 April 2018, 18:36:23 UTC
b5ae9b6 version: bump up to 3.1.13+git 29 March 2018, 17:56:52 UTC
1558170 version: bump up to 3.1.13 29 March 2018, 17:28:55 UTC
c3a14a2 semaphore: run release test with v3.1.12 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 29 March 2018, 16:23:15 UTC
6f75c56 etcdserver: Manually backport etcdserver/raft.go tickMu fix to 3.1 28 March 2018, 19:40:07 UTC
908c0f4 rafthttp: add missing "peer_sent_failures_total" metrics call Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 28 March 2018, 19:39:59 UTC
35c6ea7 Documentation/upgrades: backport all upgrade guides Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 28 March 2018, 19:39:59 UTC
8eeab58 etcdserver: adjust election ticks on restart Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 28 March 2018, 17:17:30 UTC
c536205 etcdserver: make "advanceTicks" method Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 28 March 2018, 17:05:02 UTC
2e57d99 rafthttp: add "ActivePeers" to "Transport" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 28 March 2018, 17:02:13 UTC
2fdc4aa version: bump up to 3.1.12+git 08 March 2018, 22:17:36 UTC
918698a version: bump up to 3.1.12 08 March 2018, 21:01:30 UTC
back to top