| 8dff0e2 | Steven Johnson | 30 November 2023, 18:01:28 UTC | Merge branch 'srj/intrinsics-bounds' into srj/test-intrinsics-bounds | 30 November 2023, 18:01:28 UTC |
| 2bcb879 | Steven Johnson | 29 November 2023, 22:46:55 UTC | trigger buildbots | 29 November 2023, 22:46:55 UTC |
| 7d958f6 | Steven Johnson | 29 November 2023, 22:36:52 UTC | Merge branch 'main' into srj/intrinsics-bounds | 29 November 2023, 22:36:52 UTC |
| ad5dd20 | antonysigma | 29 November 2023, 17:31:12 UTC | Update instructions to include generated schedules (#7928) The generated schedule from the auto-scheduler can no longer be copy-n-pasted to the Generater source code. Update the tutorial to show how the generated schedules can be appled and included into Generator. Use case: version control and fine tuning of schedules. Resolves: #7148 See also: #7900 Co-authored-by: Steven Johnson <srj@google.com> | 29 November 2023, 17:31:12 UTC |
| fadcbeb | Misha Gutman | 29 November 2023, 17:30:15 UTC | [xtensa] Clean up (#7961) | 29 November 2023, 17:30:15 UTC |
| bf5f206 | Steven Johnson | 29 November 2023, 17:19:03 UTC | Remove inadvertently added generated file (#7966) | 29 November 2023, 17:19:03 UTC |
| fc4ff80 | Steven Johnson | 29 November 2023, 17:07:09 UTC | Merge branch 'main' into xtensa-codegen | 29 November 2023, 17:07:09 UTC |
| 68f2bbd | Steven Johnson | 29 November 2023, 17:06:51 UTC | Revise Flatbuffers codegen style (#7964) * Rename the generated Flatbuffer headers The Blaze/Bazel rules for Flatbuffers are inflexible and require this naming pattern :-/ * Also update the flags to flatc * Fix lots of stuff * exclude from clang-format * ignore again | 29 November 2023, 17:06:51 UTC |
| b7468af | Andrew Adams | 29 November 2023, 16:39:41 UTC | Attempt to fix nested vectorization gemm performance on new build bot (#7959) * Better (simpler) schedules for nested vectorization gemm * Remove early return * Empty-Commit --------- Co-authored-by: Steven Johnson <srj@google.com> | 29 November 2023, 16:39:41 UTC |
| 80e8daa | Steven Johnson | 28 November 2023, 23:31:28 UTC | Merge branch 'main' into xtensa-codegen | 28 November 2023, 23:31:28 UTC |
| 5175d16 | Andrew Adams | 28 November 2023, 21:59:21 UTC | Make the fast inverse test throughput-limited rather than latency-limited (#7958) Co-authored-by: Steven Johnson <srj@google.com> | 28 November 2023, 21:59:21 UTC |
| 2b23e07 | Steven Johnson | 28 November 2023, 16:05:52 UTC | Return values from stub functions in Deserialization (#7963) Needed to prevent "error: non-void function does not return a value" | 28 November 2023, 16:05:52 UTC |
| 68a6652 | Steven Johnson | 28 November 2023, 15:29:28 UTC | Merge branch 'main' into xtensa-codegen | 28 November 2023, 15:29:28 UTC |
| 1888074 | Steven Johnson | 28 November 2023, 15:21:00 UTC | Merge branch 'main' into srj/intrinsics-bounds | 28 November 2023, 15:21:00 UTC |
| 9ce5fd6 | James Price | 28 November 2023, 14:54:03 UTC | [WebGPU] Update to latest native headers (#7932) * [WebGPU] Update to latest native headers * Update mini_webgpu.h with latest version from Dawn * Document this process * Remove an argument from wgpuQueueOnSubmittedWorkDone Fixes #7581 * [WebGPU] Note that wgpu is not yet supported * [WebGPU] Add https:// to external links in README * update to commit b5d38fc7dc2a20081312c95e379c4a918df8b7d4 * Update mini_webgpu.h --------- Co-authored-by: Steven Johnson <srj@google.com> | 28 November 2023, 14:54:03 UTC |
| 71e2728 | Steven Johnson | 28 November 2023, 01:19:04 UTC | Merge branch 'main' into xtensa-codegen | 28 November 2023, 01:19:04 UTC |
| 976ea0b | Derek Gerstmann | 28 November 2023, 00:55:41 UTC | [serialization] Serialize stub definitions of external parameters. (#7926) * Serialize stub definitions of external parameters. Add deserialize_parameter methods to allow the user to only deserialize the mapping of external parameters (and remap them to their own user parameters) prior to deserializing the full pipeline definition. * Clang tidy/format pass --------- Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com> | 28 November 2023, 00:55:41 UTC |
| 8c28a73 | Andrew Adams | 21 November 2023, 23:27:21 UTC | Improve code size and compile time for local laplacian app (#7927) Improve code size and compile time for local laplacian and interpolate apps This reduces compile time for the manual local laplacian schedule from 4.9s to 2.2s, and reduces code size from 126k to 82k Most of the reduction comes from avoiding a pointless boundary condition in the output Func. A smaller amount comes from avoiding loop partitioning using RoundUp and Partition::Never. The Partition::Never calls are responsible for a 3% reduction in code size and compile times by themselves. This has basically no effect on runtime. It seems to reduce it very slightly, but it's in the noise. | 21 November 2023, 23:27:21 UTC |
| 46ef7ac | Volodymyr Kysenko | 21 November 2023, 21:59:07 UTC | Merge branch 'main' into xtensa-codegen | 21 November 2023, 21:59:07 UTC |
| 04c21bf | Volodymyr Kysenko | 21 November 2023, 21:56:45 UTC | Always call lower_round_to_nearest_ties_to_even on arm32 (#7957) | 21 November 2023, 21:56:45 UTC |
| f5a4e49 | Andrew Adams | 21 November 2023, 19:23:44 UTC | Add missing condition to if renesting rule (#7952) * Add missing condition to if renesting rule * Add test * clang-format | 21 November 2023, 19:23:44 UTC |
| d6b0816 | Misha Gutman | 20 November 2023, 17:47:38 UTC | [xtensa] Clean up (#7953) | 20 November 2023, 17:47:38 UTC |
| ad0f24e | Andrew Adams | 16 November 2023, 00:49:35 UTC | Track likely values through lets in loop partitioning (#7930) * Track likely values through lets in loop partitioning Fixes #7929 Improves runtime of lens_blur app by ~20% * Add uncaptured likely tags to selects in boundary condition helpers Now that we look through lets, we end up in more situations where both sides have a captured likely. * Better comments | 16 November 2023, 00:49:35 UTC |
| 0f65435 | Andrew Adams | 14 November 2023, 19:48:34 UTC | More targeted fix for gather instructions being slow on intel processors (#7945) See https://github.com/llvm/llvm-project/issues/70259 | 14 November 2023, 19:48:34 UTC |
| f0cdd50 | Andrew Adams | 14 November 2023, 18:23:14 UTC | Delete unused function (#7925) | 14 November 2023, 18:23:14 UTC |
| afa7feb | Andrew Adams | 11 November 2023, 17:17:03 UTC | Merge remote-tracking branch 'origin/main' into srj/intrinsics-bounds | 11 November 2023, 17:17:03 UTC |
| 804f37b | Misha Gutman | 10 November 2023, 19:25:07 UTC | [xtensa] Improved load_predicated for float (#7943) | 10 November 2023, 19:25:07 UTC |
| e9d0319 | Volodymyr Kysenko | 10 November 2023, 19:15:01 UTC | Add missing override | 10 November 2023, 19:15:01 UTC |
| 4fa8f86 | Volodymyr Kysenko | 09 November 2023, 17:27:53 UTC | Merge branch 'main' into xtensa-codegen | 09 November 2023, 17:27:53 UTC |
| f25af7f | Haojian Wu | 09 November 2023, 05:27:20 UTC | Remove the deprecated API `llvm::Type::getInt8PtrTy` usage. (#7937) This API is removed in LLVM trunk now https://github.com/llvm/llvm-project/commit/7b9d73c2f90c0ed8497339a16fc39785349d9610. | 09 November 2023, 05:27:20 UTC |
| 3b4dc33 | Zalman Stern | 07 November 2023, 21:23:31 UTC | Make sure all Halide arithmetic scalar types can be named from the Generator interface. (#7934) * Make sure all Halide arithmetic scalar types can be named from the Generator interface. Specifically adding 64-bit signed and unsigned integers and making sure float16 and bfloat16 are fully supported and documented. Add a simple test for all the type names. (Don't use float16 and bfloat16 in the arithmetic as they do not compile with the C++ backend. The name mapping should still be tested but the types passed do not seem to be checked as the values are not used.) | 07 November 2023, 21:23:31 UTC |
| 256c2f2 | Xuanda Yang | 07 November 2023, 17:57:21 UTC | Add missing serialization of Dim::partition_policy (#7935) add missing serialization of Dim::partition_policy | 07 November 2023, 17:57:21 UTC |
| e5bf7ab | Xuanda Yang | 06 November 2023, 23:36:56 UTC | Add special build for testing serialization via a serialization roundtrip in JIT compilation and fix serialization leaks (#7763) * add back JIT testing, enclosed in #ifdef blocks * fix typo * nits * WITH_SERIALIZATION_JIT->WITH_SERIALIZATION_JIT_ROUNDTRIP_TESTING * fix self-reference leaks: now uses weak function ptr in reverse function mappings * Move clang-tidy checks back to Linux Recent changes in the GHA runners for macOS don't play well with clang-tidy; rather than sink any more time into debugging it, I'm going to revert the relevant parts of #7746 so that it runs on the less-finicky Linux runners instead. * bogus * Update Generator.cpp * Update Generator.cpp * call copy_to_host before serializing buffers * throw an error if we serialize on-device buffer * Skip specialize_to_gpu * Update Pipeline.cpp * Skip two more tests * use serialize to memory during jit testing * makefile update * makefile fix * skip the tutorial if flatc is not there * fix * fix signature * fix makefile * trigger buildbot --------- Co-authored-by: Steven Johnson <srj@google.com> | 06 November 2023, 23:36:56 UTC |
| 01f3132 | Volodymyr Kysenko | 06 November 2023, 18:56:43 UTC | Pre-convert indices for gather | 06 November 2023, 18:56:43 UTC |
| 0f4a488 | Volodymyr Kysenko | 06 November 2023, 18:25:13 UTC | Format | 06 November 2023, 18:25:13 UTC |
| dcfa415 | Volodymyr Kysenko | 06 November 2023, 18:24:47 UTC | Shuffles for fp16 and support all of the immediate shuffles | 06 November 2023, 18:24:47 UTC |
| 7486c0c | Volodymyr Kysenko | 06 November 2023, 17:40:32 UTC | Merge branch 'main' into xtensa-codegen | 06 November 2023, 17:40:32 UTC |
| e5ee753 | Zalman Stern | 03 November 2023, 00:27:03 UTC | Remove use of dynamic_cast. (#7931) Remove use of dynamic_cast to preserve compiling the Halide compiler without RTTI. | 03 November 2023, 00:27:03 UTC |
| 5439f01 | Volodymyr Kysenko | 31 October 2023, 18:11:07 UTC | Merge branch 'main' into xtensa-codegen | 31 October 2023, 18:11:07 UTC |
| 1865101 | Martijn Courteaux | 31 October 2023, 17:38:55 UTC | Loop Partitioning Policy through Stage::partition(VarOrRVar, LoopPartitionPolicy) (#7914) * Loop Partitioning Policy through Stage::partition(VarOrRVar, LoopPartitionPolicy) * Renamed LoopPartitionPolicy to Partition. Added tests in boundary_conditions to verify correctness of the code with and without loop partitioning. Added tests that validates that disabling loop partitioning works. * Include error-test for when partitioning is always requested, but none was performed. | 31 October 2023, 17:38:55 UTC |
| 0134c40 | Volodymyr Kysenko | 30 October 2023, 21:39:17 UTC | Improve the error message if you store_at without a compute_at (#7923) * Improve an error message * Clean up * Update messages | 30 October 2023, 21:39:17 UTC |
| 97573c6 | Volodymyr Kysenko | 27 October 2023, 21:21:26 UTC | Scheduling directive to hoist the storage of the function (#7915) * Minimal hoist_storage plumbing * HoistedStorage placeholder IR node * Basic hoist_storage test * Fully plumb through the HoistedStorage node * IRPrinter for HoistedStorage * Insert hoisted storage at the correct loop level * Progress * Formatted * Move out common code for creating Allocate node * Format * Emit Allocate at the HoistedStorage site * Collect all dependant vars * Basic test working * Progress * Substitute lets into allocation extents instead of lifting stuff * Infer bounds for the extends dependant on loop variables * Update tests * Remove old code * Remove old code * Better tests * More tests * Validate schedules with hoist_storage * Error test * Fix stupid mistake * More tests * Remove debug prints * Better errors * Add missing handler for inlined functions * Format * Comments * Format * Add some missing visit handlers * New line * Fix comment * Luckily we only have two build systems * Adds hoist_storage_root * Comment for IR node * Serialization support for HoistedStorage * Handle hoist_storage fo tuples * Handle multiple realize nodes * Move assert up * Better error message * Better loop bounds * Format * Updated error message * Happy clang-tidy happy me * An error message when compute is inlined, but store is not inlined * Only mutate lets which are needed * Update apps to use hoist_storage Some very minor performance gains, but mostly in the noise. Also switched the apps makefiles to emit stmt html by default instead of stmt, to take advantage of the new and improved stmt html. * Switch to stack of hoisted storages * Limit scope of lets for expansion * Break early * Skip substitute_in_all_lets * Re-use expanded min/extents * WebAssembly JIT does not support custom allocators * Change debug level to get more info about segfault * More debugging prints * Let's try aligned malloc * Revert "Change debug level to get more info about segfault" This reverts commit a5a689be8c6ad351674f3ced3bbf542335f91d75. * Revert "More debugging prints" This reverts commit bb6b8c1313cbdb9f355df20fd203ee02d485042e. --------- Co-authored-by: Andrew Adams <andrew.b.adams@gmail.com> | 27 October 2023, 21:21:26 UTC |
| ed357c2 | Martijn Courteaux | 27 October 2023, 17:23:42 UTC | Fix bug mentioned by @antonysigma. (#7916) | 27 October 2023, 17:23:42 UTC |
| cf01e97 | Andrew Adams | 27 October 2023, 17:22:31 UTC | Turn off SLP vectorization for avx512 only (#7918) Fixes #7917 | 27 October 2023, 17:22:31 UTC |
| fffb8bd | Andrew Adams | 24 October 2023, 17:23:49 UTC | Fix read-after-write hazard analysis in storage folding (#7910) Explicitly mark which loops get loop-carry-dependencies inserted by sliding window to assist storage folding. Storage folding needs to know about this so it doesn't try to fold in a way that invalidates these read-after-write dependencies. It currently tries to prove the absence of hazards with box_contains(box_provided, box_required), but this is sometimes incorrect because box_provided could be conservatively large, and the code it analyses might not actually provide (store to) all the required (loaded from) values. It's simpler for sliding window to just tell storage folding when it inserts loop-carry-dependencies, and this is most simply done directly in the IR itself. Fixes #7909 | 24 October 2023, 17:23:49 UTC |
| b8a4523 | Volodymyr Kysenko | 23 October 2023, 18:24:58 UTC | Fix a test and disable two | 23 October 2023, 18:24:58 UTC |
| e1eb59f | Volodymyr Kysenko | 23 October 2023, 17:19:21 UTC | Merge branch 'main' into xtensa-codegen | 23 October 2023, 17:19:21 UTC |
| d023065 | Martijn Courteaux | 22 October 2023, 19:20:47 UTC | Hotfix reinterpret HTML (#7912) Hotfix reinterpret | 22 October 2023, 19:20:47 UTC |
| 739053d | Volodymyr Kysenko | 22 October 2023, 19:11:00 UTC | Check returned result in the test (#7911) * Check returned result of Callable * Format | 22 October 2023, 19:11:00 UTC |
| 872264c | Marcos Slomp | 20 October 2023, 21:33:13 UTC | Static analysis (MSVC) fixes for device_buffer_utils.h (#7904) * Static analysis (MSVC) fixes for device_buffer_utils.h * clang-format happiness * signed integer cast | 20 October 2023, 21:33:13 UTC |
| 057050a | Misha Gutman | 20 October 2023, 21:26:29 UTC | [xtensa] improved conversion ops and covered them with tests (#7859) * [xtensa] improved conversion ops and covered them with tests * Removed dead function | 20 October 2023, 21:26:29 UTC |
| 2918854 | Martijn Courteaux | 20 October 2023, 17:37:38 UTC | Highlight groups for the HTML Stmt file and tooltips to reveal types. (#7887) * Highlight groups for the HTML Stmt file and tooltips to reveal types. * Cleaned up JS using eslint. * Remove commented code. | 20 October 2023, 17:37:38 UTC |
| bd1d4df | Andrew Adams | 20 October 2023, 17:21:50 UTC | Stop interleaver from expanding the scope of letstmts (#7908) In the following code: let a = b in X let a = c in Y If Stmt X successfully had stores interleaved, it was re-nesting it like so: let a = b in X let a = c in Y This introduces a shadowed variable 'a', which is illegal at this stage of lowering. Fixes #7906 Also some drive-by fixes to earlier tests that had debugging code left in. | 20 October 2023, 17:21:50 UTC |
| 26c036b | Volodymyr Kysenko | 19 October 2023, 18:13:32 UTC | Merge branch 'main' into xtensa-codegen | 19 October 2023, 18:13:32 UTC |
| eb66c06 | Andrew Adams | 18 October 2023, 21:45:47 UTC | Don't lift loop vars outside of their loops in sliding window (#7896) Sliding window, when operating in the mode that shifts the consumer's loop min backwards a few iterations to cover the warmup, was capable of inappropriately lifting for loop vars inside that loop but outside the produce node of the slid Func. Fixes #7891 | 18 October 2023, 21:45:47 UTC |
| 5c97c3c | Andrew Adams | 17 October 2023, 16:17:58 UTC | Assignment is not associative (#7894) * Assignment is not associative * Fix internal tests | 17 October 2023, 16:17:58 UTC |
| f9b90cb | Andrew Adams | 17 October 2023, 16:17:20 UTC | Disable warning for mismatched new/delete (#7897) | 17 October 2023, 16:17:20 UTC |
| db207b9 | Andrew Adams | 17 October 2023, 16:16:33 UTC | Mutating if branches in isolation can break reachability analysis (#7895) Fixes #7892 | 17 October 2023, 16:16:33 UTC |
| 667d6ed | Andrew Adams | 16 October 2023, 17:12:50 UTC | Check for overflow in Type constructor (#7889) * Check for overflow in Type constructor * Don't try to construct illegal types | 16 October 2023, 17:12:50 UTC |
| 7e35494 | Andrew Adams | 14 October 2023, 11:29:33 UTC | Generate simpler LLVM IR for shuffles that recursively become broadcasts (#7902) * Generate simpler LLVM IR for shuffles that recursively become broadcasts * Don't re-codegen arg | 14 October 2023, 11:29:33 UTC |
| 51ad730 | Andrew Adams | 13 October 2023, 21:32:01 UTC | Attempted fixed datalayouts for llvm trunk (#7898) * Attempted fixed datalayouts for llvm trunk * Missed a few i128:128s | 13 October 2023, 21:32:01 UTC |
| a3911bb | Martijn Courteaux | 12 October 2023, 18:38:44 UTC | Explicitly name the allocgroups on GPU schedules "allocgroup__..." (#7883) * 50cents readibility improvement to allocgroups on GPU schedules. * Improve allocation group prefix: only if the alloc group cluster contains more than 1 allocation prepend the prefix. | 12 October 2023, 18:38:44 UTC |
| 509140a | antonysigma | 09 October 2023, 19:08:06 UTC | Implement elementwise complex value division (#7848) Implement the logic: (a + bj) / (c + dj) as an inline operator/() function. Use case: direct FFT method to solve linear least square problem, namely: ```math \begin{align} f(x) &=\Vert F^T D F x - b \Vert_2^2 \\ \arg \min_{x \in \mathbb{R}} f(x) &= F^T \left[ D^{-1} F b \right] \end{align} ``` where `D` is a diagonal complex-valued matrix representing image blur kernel, `b` is an ordinary image in vectorized form. | 09 October 2023, 19:08:06 UTC |
| 9293655 | Andrew Adams | 09 October 2023, 19:07:28 UTC | Update README.md to include RISCV in llvm build instructions (#7878) | 09 October 2023, 19:07:28 UTC |
| b607129 | Martijn Courteaux | 06 October 2023, 19:40:35 UTC | HTML Stmt IR with conceptual code and device code. (#7843) * WIP: Conceptual Stmt IR and HTML cleanup. * WIP: Lots of progress on Stmt HTML. Cleanup almost complete. * Support scrolling to device code. * Resizing works decent enough for me. Fix cost-model allocate block costs. * Print better vector_reduce calls. * Optionally enable VizTree through an env variable. * Fix the device code tab for non-PTX. * StmtHTML: Tabs renamed to panes. Fix linter warnings. Cut trailing 0 byte from device code buffers. * Fix clang-format. * Fixed typos and copy paste error. * Fix HL_EXTRA_OUTPUTS behaviour to respect the defaults. * Nuked VizTree * Finalize StmtToViz nuke and rename StmtToHTML. * Improved HTML correctness by running output through an online validator. Quite some bugs fixed. * Cost model visualization improvement. Fix button not being allowed in the checkbox/label combination. * Fix collapsing being triggered by jump-to-xxx buttons. * How did this work? * Process Andrew's feedback. * Process Andrew's feedback. * Process Andrew's feedback, part 3. * Improve color palette. Few minor improvements. * Clang-format... | 06 October 2023, 19:40:35 UTC |
| 24a64f8 | Andrew Adams | 06 October 2023, 18:40:46 UTC | Update onnx app to work with newer versions of protobuf (#7879) and to work on mac | 06 October 2023, 18:40:46 UTC |
| 120e5fd | Andrew Adams | 05 October 2023, 23:52:58 UTC | Consider all dimensions before deciding to slide over a new dimension (#7875) * Don't deduce unreachability from predicated out of bounds stores Fixes #7873 * Consider all dimensions before deciding to slide over a new dimension Even ones we've already slid over. The previous version of this code could try to slide over a loop where multiple dimensions depend on the loop var, because it ignored dimensions that had already been slid over. Moving a check resolves the issue. Fixes #7872 | 05 October 2023, 23:52:58 UTC |
| 51ab364 | Andrew Adams | 05 October 2023, 17:42:23 UTC | Validate for types when fusing Vars with RVars (#7877) * Fix for llvm trunk * Validate for types when fusing Vars with RVars Fixes #7871 * Commit test | 05 October 2023, 17:42:23 UTC |
| 39f12a7 | Andrew Adams | 05 October 2023, 16:15:09 UTC | Fix for llvm trunk (#7876) | 05 October 2023, 16:15:09 UTC |
| c31e8f7 | Andrew Adams | 04 October 2023, 18:12:09 UTC | Don't deduce unreachability from predicated out of bounds stores (#7874) Fixes #7873 | 04 October 2023, 18:12:09 UTC |
| a24071c | Derek Gerstmann | 28 September 2023, 21:30:44 UTC | [serialization] Add support to serialize to memory, and a basic serialization tutorial (#7760) * Add in-memory buffer serialize/deserialize support. * Add basic serialization tutorial * Clang format pass * Update doc strings to use Doxygen formatted args * Clear out data buffer during serialization * Update serialization tutorial to use simple blur example with ImageParam * Make parameter map optional for serialize #7849 Add error messages to deserializer for missing params Update tutorial * Clang format pass --------- Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com> Co-authored-by: Steven Johnson <srj@google.com> | 28 September 2023, 21:30:44 UTC |
| 76ac233 | Andrew Adams | 27 September 2023, 16:42:07 UTC | Handle unreachable code in bounds inference (#7866) * Handle unreachable code in bounds inference * Avoid ambiguous constructor * IRVisitor -> IRGraphVisitor * Add success print | 27 September 2023, 16:42:07 UTC |
| 9f96b25 | Steven Johnson | 27 September 2023, 01:55:12 UTC | Prevent use of uninitialized scalar Parameters in JIT code (#7847, partial) (#7853) * Prevent use of uninitialized scalar Parameters in JIT code (#7847, partial) * Fix broken tests * Update Parameter.h * Update func_clone.cpp * Fix Generators too * Fixes * Update InferArguments.cpp * Fixes * pacify clang-tidy * fixes | 27 September 2023, 01:55:12 UTC |
| 3926b02 | Andrew Adams | 26 September 2023, 01:58:20 UTC | Respect input buffer constraints in root-level bounds inference exprs (#7865) * Respect input buffer constraints in bounds inference lets Fixes #7761 * Add test | 26 September 2023, 01:58:20 UTC |
| 05d5efa | Andrew Adams | 25 September 2023, 19:14:25 UTC | Handle nested vectorization in store predicates (#7864) Fix #7851 In one place in PartitionLoops and in another place in the simplifier we were neglecting to consider nested vectorization. I added the fuzzer output as a new test, because I have no idea how I'd generate this error with human-readable code. It stems from an interaction of several tail strategies. | 25 September 2023, 19:14:25 UTC |
| 9f044b5 | Volodymyr Kysenko | 19 September 2023, 21:58:30 UTC | Build rules for Xtensa tests with cstub library (#7852) * Build rules for Xtensa tests with cstub library * Adds references to issues | 19 September 2023, 21:58:30 UTC |
| 26619d2 | Pranav Bhandarkar | 18 September 2023, 19:48:34 UTC | [Hexagon] - Fix 8-bit unsigned saturating downcasts for HVX (Fixes #7806) (#7825) * Dump the IR more frequently in HexagonOptimize.cpp * Fix 8bit unsigned saturating downcasts for HVX We do not have a way of reliably lowering the following expression to LLVM bitcode for HVX. u8_sat(uint16x) where uint16x is a vector (preferably a HVX double vector) with element type uint16. Since there is no native HVX instruction to do this, this patch introduces two helper functions in hvx_128.ll to perform this operation. One function interleaves its input (trunc_satub.vuh) and the other does not (pack_satub.vuh) This patch also removes declaration of some intrinsics not use any longer in hvx_128.ll * Make IR dump messages in HexagonOptimize.cpp consistent with those in CodeGen_Hexagon.cpp * fix clang-format complaints --------- Co-authored-by: Steven Johnson <srj@google.com> | 18 September 2023, 19:48:34 UTC |
| 92ff9bb | Volodymyr Kysenko | 18 September 2023, 18:18:18 UTC | Improve handling of bool vectors | 18 September 2023, 18:18:18 UTC |
| 68a0341 | Derek Gerstmann | 18 September 2023, 17:09:11 UTC | [api] Promote Internal::Parameter to Halide::Parameter (#7829) * Promote Internal::Parameter to Halide::Parameter (to support Serialization API refactoring) * Make raw_buffer(), scalar_address(), and scalar_raw_value() methods protected. Make Pipeline and Serializer protected friend classes. * Add Parameter public interface to python bindings. Remove old stub internal interface from PyParam. * Remove blank line at start of function --------- Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com> Co-authored-by: Steven Johnson <srj@google.com> | 18 September 2023, 17:09:11 UTC |
| ab4067f | Steven Johnson | 15 September 2023, 19:45:10 UTC | Fixes for top-of-tree Halide (#7850) * Fixes for top-of-tree Halide * I am a bonehead | 15 September 2023, 19:45:10 UTC |
| d7760f5 | Derek Gerstmann | 15 September 2023, 01:05:12 UTC | [tutorials] Add tutorial on JIT compile/execute performance (#7838) * Add tutorial on JIT compile/execute performance * Addressing comments from review. Fix punctuation and comment nits. Add timing estimates as comments. Add std::function example. Enable advanced scheduling directives. * Addressing comments from review. Added cases that match real usage patterns: 1. Defining and compiling the whole pipeline every time you want to run it (i.e. in the benchmarking loop) 2. Defining the pipeline outside the benchmarking loop, and realizing it repeatedly. 3. (optional) Same as 2), but calling compile_jit() outside the loop, saying what it does, and saying why the time isn't actually different to case 2 (benchmark() runs multiple times and takes a min, and realize only compiiles on the first run) 4. Compiling to a callable outside the benchmarking loop and showing that it has lower overhead than case 3 (if indeed it does. If not we may need to change the example so that it does, e.g. by adding a real input buffer.) * Addressing comments from review for style nits, and typos in comments. --------- Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com> Co-authored-by: Steven Johnson <srj@google.com> | 15 September 2023, 01:05:12 UTC |
| 39e3a78 | Volodymyr Kysenko | 13 September 2023, 17:18:19 UTC | Merge branch 'main' into xtensa-codegen | 13 September 2023, 17:18:19 UTC |
| 996482b | Volodymyr Kysenko | 13 September 2023, 17:13:46 UTC | Codegen fixes so it can compile with cstubs | 13 September 2023, 17:13:46 UTC |
| 8797287 | Volodymyr Kysenko | 12 September 2023, 20:35:23 UTC | Update arguments in driver.cpp to match what correctness/simd_op_check has (#7842) | 12 September 2023, 20:35:23 UTC |
| 6569a83 | Andrew Adams | 11 September 2023, 17:40:29 UTC | Zen4 support (#7840) * Enable emission of float16/32 casts on x86 Fixes #7836 Fixes #4166 * Add support for zen4 * Add avx512_Zen4 target flag It's a superset of cannon lake, and a subset of sapphire rapids * Fix runtime detection, sapphire rapids CPUID bits * Fix comment * Don't catch bfloat casts * Fix Zen4 model number * Use llvm BFloat type for bfloat intrinsics * Give up on native bfloat16 conversion for now * Don't use llvm's bfloat type at all * Add missing enum * Fix constant in comment * clang-format | 11 September 2023, 17:40:29 UTC |
| b704abd | Volodymyr Kysenko | 06 September 2023, 21:32:44 UTC | Iterate over lets in the correct order in VectorizeLoops (#7830) * Iterate over lets in correct order * Comments * Comments * Comments | 06 September 2023, 21:32:44 UTC |
| 836879e | Andrew Adams | 06 September 2023, 21:29:27 UTC | Enable emission of float16/32 casts on x86 (#7837) * Enable emission of float16/32 casts on x86 Fixes #7836 Fixes #4166 * Fix comment * Don't catch bfloat casts * Fix missing word in comment | 06 September 2023, 21:29:27 UTC |
| 02865e2 | Xuanda Yang | 05 September 2023, 20:28:11 UTC | Add a check that PredicateLoads must be used in the outermost split of a dimension (#7788) * add a check that PredicateLoads must be used in the outermost split of a dimension * newline * use the repro example * fix * avoid check for every other tail strategy * update error message to point out what's not allowed --------- Co-authored-by: Steven Johnson <srj@google.com> | 05 September 2023, 20:28:11 UTC |
| 8188b42 | Andrew Adams | 01 September 2023, 17:38:19 UTC | Avoid generating name collisions in CSE (#7821) * Avoid generating name collisions in CSE Alternative to #7801 (See the discussion there) Fixes #4124 * Add missing test * Minor cleanup * clang-format | 01 September 2023, 17:38:19 UTC |
| ddfb1dc | Andrew Adams | 01 September 2023, 17:37:50 UTC | Don't return an undefined Stmt() from IfThenElse visitor (#7816) Fixes #7815 | 01 September 2023, 17:37:50 UTC |
| c788294 | Steven Johnson | 31 August 2023, 18:38:14 UTC | Fixes? | 31 August 2023, 18:38:14 UTC |
| 32eb37d | Steven Johnson | 31 August 2023, 16:47:27 UTC | Merge branch 'main' into srj/intrinsics-bounds | 31 August 2023, 16:47:27 UTC |
| 24d846c | Steven Johnson | 30 August 2023, 23:54:48 UTC | Remove dead `auto-schedule` label in CMake (#7818) These were replaced by more granular labels. Also, drive-by fix to comment that needed plurals. | 30 August 2023, 23:54:48 UTC |
| afc61b2 | Steven Johnson | 30 August 2023, 23:54:09 UTC | Update 'Check CMake file lists' action (#7809) * Update 'Check CMake file lists' action Several subcategories were missing -- let's add them and see if they should be there or not * bogus change * Add missing comments * Revert "bogus change" This reverts commit 80454b1313e1c06b5432d15287fa1f51185f70b6. | 30 August 2023, 23:54:09 UTC |
| 0d5b3e4 | Steven Johnson | 30 August 2023, 01:33:03 UTC | Update Bounds.cpp | 30 August 2023, 01:33:03 UTC |
| fd0b475 | Steven Johnson | 30 August 2023, 00:12:48 UTC | Fix round() and strict_float() handling | 30 August 2023, 00:12:48 UTC |
| 0e64045 | Steven Johnson | 29 August 2023, 23:43:34 UTC | Handle many more intrinsics in Bounds.cpp This addresses many (but not all) of the `signed integer overflow` issues we're seeing in Google due to https://github.com/halide/Halide/pull/7814 -- a lot of the issues seems to be in code that uses intrinsics that had no handling in value bounds checking, so the bounds were naively large and overflowed. - Most of the intrinsics from FindIntrinsics.h weren't handled; now they all are (most by lowering to other IR, though the halving_add variants were modeled directly because the bitwise ops don't mesh well) - strict_float() is just a pass-through - round() is a best guess (basically, if bounds exist, expand by one as a worst-case) There are definitely others we should handle here... trunc/floor/ceil probably? | 29 August 2023, 23:43:34 UTC |
| 3a1dffe | Steven Johnson | 29 August 2023, 16:23:44 UTC | Move clang-tidy checks back to Linux (#7817) * Move clang-tidy checks back to Linux Recent changes in the GHA runners for macOS don't play well with clang-tidy; rather than sink any more time into debugging it, I'm going to revert the relevant parts of #7746 so that it runs on the less-finicky Linux runners instead. * bogus * Update Generator.cpp * Update Generator.cpp | 29 August 2023, 16:23:44 UTC |
| fa136cb | Steven Johnson | 29 August 2023, 16:21:59 UTC | Ensure that multitarget AOT builds have consistent random sequence (#7717) * Fix CMake test for generator_aot_multitarget * Ensure that multitarget AOT builds have consistent random numbers If a Generator uses random_float() (or the int or uint versions), and is used in a multitarget build, we weren't resetting the counters for random generation between each subtarget... meaning that each subtarget would get a different random sequence, leading to some ery hard-to-debug test failures when running on different hardware variants. This PR ensures that the relevant counters are all reset before each subtarget is generated, so that each should see the same sequence of random number generation. * Update CMakeLists.txt * Update multitarget_aottest.cpp * Combine float/uint counters | 29 August 2023, 16:21:59 UTC |
| fe9f0b7 | Derek Gerstmann | 28 August 2023, 18:13:53 UTC | [serialization] Add serialization support to generator interface (#7792) * Add serialization support to Generator interface * Clang format pass * Make target required when emitting a serialized pipeline (since schedule may be target dependent). Apply auto-scheduler before serialization so that schedules can be serialized. * Fix enum ordering for hlpipe. Fix hlpipe comments. Add missing hlpipe enum to pyenums. * Remove unused Serialization build_mode * Fix formatting * Remove unused serializable flag. Remove redundant cpp_stub check. Fix comments. * Safeguard emit_hlpipe calls with #ifdef WITH_SERIALIZATION --------- Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com> Co-authored-by: Steven Johnson <srj@google.com> | 28 August 2023, 18:13:53 UTC |
