https://github.com/lmoneta/root

sort by:
Revision Author Date Message Commit Date
568ada2 Add axis labels in the painted graph (1D case) or histogram (2d) representing TEfficiency when the label exists in the given histograms. This fixes ROOT-10493 15 January 2020, 09:33:43 UTC
1af677a [rbrowsable] split RHolder classes 15 January 2020, 09:05:57 UTC
381c4c3 [rbrowsable] use multimap for registry of browse functions Same key value (nullptr or TObject::Class()) may appear many times 15 January 2020, 09:05:57 UTC
3e5c606 [rbrowsable] split item and element for SysFile and TObject 15 January 2020, 09:05:57 UTC
63ddf11 [rbrowsable] rename files according to class names 15 January 2020, 09:05:57 UTC
e1d1bef [rbrowsable] move remaining classes in Browsable namespace All relevant includes will be in ROOT/Browsable/ include dir 15 January 2020, 09:05:57 UTC
f2bcd74 [browsable] rename RBrowserItem.hxx -> Browsable/RItem.hxx 15 January 2020, 09:05:57 UTC
6146605 [rbrowsable] move RBrowsable to browser lib Keep request/reply classes together with RBrowser 15 January 2020, 09:05:57 UTC
4f91c24 [browsable] do not collect all includes in RBrowsable.hxx Use appropriate includes as required 15 January 2020, 09:05:57 UTC
be3e4f7 [browsable] extract RWrapper, RGroup, RProvider from RBrowsable.hxx 15 January 2020, 09:05:57 UTC
3a7013a [rbrowser] split RBrowsable.hxx on several files introduce ROOT/Browsable/ include subfolder 15 January 2020, 09:05:57 UTC
97e62a0 Update comment for NO_CXXMODULE *_rdict.pcm installation case Co-Authored-By: Vassil Vassilev <v.g.vassilev@gmail.com> 14 January 2020, 22:14:35 UTC
b97be6f Restore installation of _rdict.pcms in case if NO_CXXMODULE in ROOT_GENERATE_DICTIONARY() was enabled 14 January 2020, 22:14:35 UTC
173e5da Remove malicious cleanup of CMAKE_INSTALL_PREFIX/lib/python* 14 January 2020, 22:14:35 UTC
61c363e Revert "[CMake] Install pcms with file(GLOB ...) + install(FILES ...) instead of install(DIRECTORY)" This reverts commit 14366b9186e2e9d4a81fbcce5b7c420dbd61c005. Currently we are not ready for this cleanup, since special PCMS are generated via rootcling call for Core as extra PCMS, leaving no trace in ROOT build system. We need urgently move generation of special PCMs to use proper CMake targets (it will be enabled after 6.20). 14 January 2020, 22:14:35 UTC
f26c383 [graf2d] Unified the drawing of marker styles 3, 5 and 31 between TVirtualX and TVirtualPS based implementations. (#4762) 14 January 2020, 16:30:58 UTC
8680f50 [hist] Formatted the files realted to TGraphMultiErrors (#4777) * [hist] Formatted the files realted to TGraphMultiErrors accoding to ROOTs formatting rules * [hist] Corrected extremly unlikely memory leak Travis-CI warned about. Corrected extremly unlikely memory leak Travis-CI warned about in the drawing method of TGraphMultiErrors. 14 January 2020, 15:46:48 UTC
9422f10 [rbrowser] load drawing libs only when required RDrawableProvider harcoded now several libs names, one need to provide more flexible way to load necessary libs 14 January 2020, 10:18:15 UTC
e470265 [rbrowsable] avoid direct dependency from libHist When using obj->Clone() check inheritance from TH1 and remove directory, using ProcessLine 14 January 2020, 10:18:15 UTC
412848f [rbrowsable] move TObject browsable classes to main library There is only dependency from libCore, which is anyway there. Therefore there is no special reason to split this code 14 January 2020, 10:18:15 UTC
f530bbf [rbrowsable] introduce ROOTObjectDrawProvider library for TObject Implements generic methods for any TObject-derived classed for drawing on TCanvas/RCanvas 14 January 2020, 10:18:15 UTC
db4799e [rbrowsable] introduce draw provider for TTree For the moment only simple drawing of TLeaf object is implemented. No special browsing functionality yet 14 January 2020, 10:18:15 UTC
083f985 [rbrowsable] register more RHist classes in draw provider 14 January 2020, 10:18:15 UTC
14e4280 [rbrowsable] extract RHist drawing provider to separate library 14 January 2020, 10:18:15 UTC
adae3a0 [rbrowsable] add draw provider to main lib, no dependency from gui 14 January 2020, 10:18:15 UTC
2aeba2a [rbrowser] extract RBrowsable library from the browserv7 14 January 2020, 10:18:15 UTC
8ac5721 [RF] Add mean parameter to RooGExpModel. Contrary to the RooFit manual, the RooGExpModel doesn't have a parameter for the mean of the Gaussian. This was therefore added. 14 January 2020, 08:45:51 UTC
8adf9ea [cxxmodules] Improve ROOT startup time by not merging identifier tables Each module has a set of identifier tables which aid lookup. Based on this information clang decides if it needs a declaration to be deserialized. Namespace partitions and other C++ entities may have semantically the same identifier lookup tables across multiple modules. Since lookup is a heavily used operation in compilers clang tries to optimize it as much as possible. In case it sees more than 4 such lookup tables it merges them together into a single table aiming to keep the lookup algorithmic complexity of O(1). This logic approach has several assumptions: * The progam will use only a small superset of the modules it needs; * The program will be compiled in multiple TUs and merging of tables will not be called often; In the interpreter context where we make all module available the merging of such tables becomes CPU intense operation at runtime which produces a lot of temporary reallocations. Moreover, we have seen a lot of profiles where the merging operation dominates (by around 18%). This patch tries to make the merging far less often. On some short benchmarks ran locally we get (70-80%) runtime improvement and ~10% reduction in memory. 13 January 2020, 18:09:37 UTC
643098b [RF] Fix filled plotting of RooCurve. [RF-8932] When a RooCurve is plotted as a filled polygon, one point has to be added at the lower left of the plot to close the polygon. A few lines of code have been cleaned up and simplified. 13 January 2020, 16:44:46 UTC
d3fbc75 [Exp PyROOT] Py_ssize_t is represented with %zd Fix warnings: https://github.com/root-project/root/pull/4753#issuecomment-573096484 13 January 2020, 16:32:13 UTC
04cd5c0 [Exp PyROOT] Respect signature of PyCFunction Fix warning: https://github.com/root-project/root/pull/4753#issuecomment-573092954 13 January 2020, 16:32:13 UTC
84e729c [Exp PyROOT] Prevent comparison between signed and unsigned types Fix warnings: https://github.com/root-project/root/pull/4753#issuecomment-573096484 13 January 2020, 16:32:13 UTC
4fbf316 [Exp PyROOT] CreateConverter expects dims_t Fix warning: https://github.com/root-project/root/pull/4753#issuecomment-573096484 13 January 2020, 16:32:13 UTC
9af19f0 correct for Logx when drawing histogram errors (#4755) 13 January 2020, 12:13:41 UTC
03da71c grammar fix: to -> too, other (#4740) 13 January 2020, 11:26:03 UTC
30b783c Fix inconsistent use of tabs and spaces in writer.py 13 January 2020, 10:51:27 UTC
dffafb9 Fix compiling tutorials with Python 3 13 January 2020, 10:51:27 UTC
a8631ec [Exp PyROOT] Fix memory leak in setitem of TClonesArray In the previous implementation, a new C++ object was created for the item being set and later registered together with the Python proxy of the original item, but the original C++ object was never destructed since the proxy was made non-owner. This fix assigns the new C++ object to the proxy and registers the new pair in the memory regulator, but it also unregisters the old pair and deletes the old C++ object. 13 January 2020, 10:48:41 UTC
afc0cc0 [ROOT-10469] Port to exp PyROOT the two teardown modes They were previously introduced in old PyROOT by 7e47c42. 13 January 2020, 10:48:41 UTC
677b5cd [Exp PyROOT] Add pythonisation for RooAbsPdf::chi2FitTo / createChi2. [ROOT-10503] Because of a using declaration in C++, PyROOT didn't find overloads of chi2FitTo and createChi2. 13 January 2020, 08:19:14 UTC
12c6bdd [PyROOT] Add pythonisation for RooAbsPdf::chi2FitTo / createChi2. [ROOT-10503] Because of a using declaration in C++, PyROOT didn't find overloads of chi2FitTo and createChi2. 13 January 2020, 08:19:14 UTC
14366b9 [CMake] Install pcms with file(GLOB ...) + install(FILES ...) instead of install(DIRECTORY) Due to the default behavior of CMake https://gitlab.kitware.com/cmake/cmake/issues/17122 when using install(DIRECTORY ... PATTERN), if there are some folders that don't contain the given PATTERN they are also created as empty folders. This was causing the problem already addressed in 1d2e76. As suggested in https://stackoverflow.com/questions/55451084/cmake-files-matching-pattern-copies-empty-directories/55722518#55722518 we apply the workaround consisting in addressing the '*pcm' files with file(GLOB ...) and then install them with install(FILES ...). 10 January 2020, 16:35:00 UTC
b60a8ce [Exp PyROOT] Add patch for TROOT::Initialize in clingwrapper The following PR introduced some changes in the TCling shutdown logic: https://github.com/root-project/root/pull/4675 One of these changes affects clingwrapper.cxx in Cppyy, but the functionality it relies on (TROOT::Initialize) is not yet in the mini-ROOT of Cppyy, which is at the moment working with ROOT 6.18, so we cannot push the clingwrapper change to upstream Cppyy now. For that reason, until Cppyy updates its ROOT to 6.20, we need to keep this patch to modify our copy of Cppyy to invoke TROOT::Initialize in the constructor of ApplicationStarter. 09 January 2020, 16:08:52 UTC
8630a93 [RF] Modernise loops in RooChangeTracker. 09 January 2020, 15:29:49 UTC
2db7648 [RF] Enable serialisation of RooNDKeysPdf. [ROOT-10341] To enable serialisation, several members of RooNDKeysPdf had to be removed or their type had to be changed. A few members cannot be serialised and therefore have to be recomputed when necessary. Some first cleaning up was also done. 09 January 2020, 15:29:49 UTC
e062269 [PyROOT] Protect iteration for RVec<bool> Since RVec<bool> falls back to vector<bool>, both share the same issues for iterating over the container. 09 January 2020, 14:48:57 UTC
3be096c [ROOT-10491] Don't set tp_iter for vector<bool> tp_iter is used to implement an iterator protocol for Python using the "data" member function of std::vector. However, the specialization vector<bool> is not required to have this member function, which breaks the iterator. Removing the tp_iter field does not break iterating vector<bool> in Python, it falls back to the old iterator mechanism via the get/setitem special functions. 09 January 2020, 14:48:57 UTC
2fd6114 [ROOT-10491] Add RDataFrame.AsNumpy test for reading boolean 09 January 2020, 14:48:57 UTC
976e833 [rbrowser] use std::multimap for drawable provider registry While nullptr entry may appear several times 09 January 2020, 13:53:23 UTC
ebf3b2e [RF] Improve documentation and robustness of RooStats tools. - Add error message in ToyMCSampler when trying to generate events for a simultaneous PDF that is not extended. (Lead to crash before) - Prevent crash in RooAbsTestStatistic when dataset cannot be split into categories. - Prevent nans in HypoTestInverter when scanning with logarithmic step sizes. - Improve documentation and error messages of ToyMCSampler, RooSimultaneous, RooSimSplitGenContext. 09 January 2020, 12:31:53 UTC
ce8b9c3 [RF] Stabilise RooJeffreysPrior. Since it is running an internal fit, RooJeffreysPrior is unstable when a parameter is close to its boundary. To fix this, the prior PDF is now cloned, and the ranges of its parameters are extended to make fits converge even at the boundary. The JeffreysPrior tutorial has been renamed and cleaned up. 09 January 2020, 12:31:53 UTC
c4014ce [RF] Add BuildLegend function to RooPlot. 09 January 2020, 12:31:53 UTC
e5a9e9a [RF] Fix formatting and documentation, rename MakeVerbose helper. - Fix the formatting of RooCache* comments and replace old loops. - Replace the 'MakeVerbose' helper by 'LocalChangeMsgLvl'. Instead of just making a section verbose, this RAII object allows to temporarily select any message level. - Fix formatting and replace old loops in RooAbsReal. 09 January 2020, 12:31:53 UTC
1a9de54 [RF] Convert RooRealProxy into a template class. RooRealProxy can only take RooAbsReal* as payloads. Using the payload almost always requires casting. Therefore, the proxy was converted into a template class such that different types can be stored and retrieved without the need to cast. Typedefs for the most frequent use cases anticipated have been added: RooRealProxy (= RooTemplateProxy<RooAbsReal>), RooPdfProxy, RooLVarProxy, RooRealVarProxy. A simple test for reading a legacy RooExponential was added, which relies on correctly converting an old RooRealProxy to a RooTemplateProxy<RooAbsReal>. Removed the RooRealProxy.cxx implementation and create a legacy header that just includes RooTemplateProxy.h RooRealProxy further had functions that assume that the proxied object is a RooAbsRealLValue or a more-derived type. That's generally unsafe, so the functions have been deprecated (visible after #define R__SUGGEST_NEW_INTERFACE). Where appropriate, RooRealProxy instances should be replaced with a RooTemplateProxy and choosing the proper type for the template argument. This e.g. was done in RooPullVar. 09 January 2020, 12:31:53 UTC
fdee445 [RF] Prevent infinite loop in RooIntegrator1D. RooIntegrator1D could get stuck in an infinite loop if the integration range was exactly zero. Now, it immediately return zero if this happens. Further, the code was cleaned up and formatted. 09 January 2020, 12:31:53 UTC
9a540f3 [PyROOT exp] Disable warnings -Wmissing-field-initializers for py3.8 Warnings appear due to PEP 590 adding the tp_vectorcall field to some structs which remain uninitialized in CPyCppyy Following the conventions upstream, because the standard ensures a zero-initialization, it's safe the leave them uninitialized such as also done in the Python codebase itself. See discussion here: https://bitbucket.org/wlav/cppyy/issues/186/warnings-with-python-38-due-to-vectorcall 09 January 2020, 10:47:16 UTC
34fe0a9 [cxxmodules] Fix the error in std::complex on OSX. libc++ defines a macro which we need to hide from the modules system. 09 January 2020, 10:42:30 UTC
3a6172c Simplify ratio-plot examples. 09 January 2020, 10:29:52 UTC
55e6019 [ntuple] avoid windows warning 09 January 2020, 10:17:05 UTC
32b215d [win32gdk] cast char* to unsigned to use in printf Avoid warnings 09 January 2020, 10:17:05 UTC
2383ee8 [win32gdk] use explicit type casting to avoid warnings 09 January 2020, 10:17:05 UTC
cd7114d [treeplayer] exclude TMPWorkerTree from dictionary on Windows Class excluded from compilation on Windows Supress warning on Windows 09 January 2020, 10:17:05 UTC
65c346d [rbrowser] use binary mode to read image files 09 January 2020, 10:03:51 UTC
4aaeaa8 [rbrowser] let configure file filters in dialog from client side 09 January 2020, 10:03:51 UTC
a7cd8bb [rbrowser] implement filters in FileDialog Now one can condigure different name filters Regexp is used for file name matching, therefore more complex rules can be later applied 09 January 2020, 10:03:51 UTC
edb1d39 [rbrowser] better support of windows drivers in browser 09 January 2020, 10:03:51 UTC
38d90a1 [rbrowser] use gSystem->GetVolumes to list all volumes 09 January 2020, 10:03:51 UTC
412536f [rbrowser] ignore upper/lower case on Windows for file names 09 January 2020, 10:03:51 UTC
30c18f0 [rbrowser] provide method to fill files top folder for RBrowsable Such entries used in RBrowser and RFileDialog to navigate through file system 09 January 2020, 10:03:51 UTC
2f0e997 [rbrowser] correctly initialize RFileDialog on Windows Require special set of existing drive letters. For now limit by working dir. 09 January 2020, 10:03:51 UTC
e4bb25b [rbrowser] use gSystem->GetVolumes to list all volumes 09 January 2020, 10:03:51 UTC
c280d65 [rbrowser] provide method to fill files top folder for RBrowsable Such entries used in RBrowser and RFileDialog to navigate through file system 09 January 2020, 10:03:51 UTC
d3c12cd [rbrowser] fix bug in file dialog initialization 09 January 2020, 10:03:51 UTC
d3a3fcb [http] handle symbolic links on Windows when sending file 09 January 2020, 10:03:51 UTC
e42570d [rbrowser] correctly initialize RFileDialog on Windows Require special set of existing drive letters. For now limit by working dir. 09 January 2020, 10:03:51 UTC
a62024f [rbrowser] handle situation when initial message appears before dialog initialized 09 January 2020, 10:03:51 UTC
47f2b4e [rbrowser] introduce filetype selection in RFileDialog 09 January 2020, 10:03:51 UTC
9eb4491 [rbrowser] add Browsable namespace to LinkDef 09 January 2020, 10:03:51 UTC
1d2e767 [Exp PyROOT] Remove directory wrongly created in installation directory For reasons that we need to clarify, when cmake install is run, all the directories inside {CMAKE_LIBRARY_OUTPUT_DIRECTORY} are copied inside ${CMAKE_INSTALL_LIBDIR}. This affects also lib/pythonX.Y, which in the case of installation directory should not exist at all. Here we manually remove them after installation. This commit can be removed once we figure out why this happens. 09 January 2020, 10:02:45 UTC
52d8ff8 [Exp PyROOT/thisroot.sh] EXP_PYROOT variable passed by command line that covers the case of instalallation N.B.: will go away once experimental will become the default 09 January 2020, 10:02:45 UTC
996762c [Exp PyROOT] Create the eggs only in a dummy way for simplicity 09 January 2020, 10:02:45 UTC
6ddc793 [Exp PyROOT/thisroot.sh] Conditional silencing of ZSH nomatch option Due to the way in commit 4700 we changed how clean_environment works (we get rid of $pyroot_dir and all the cases for lib/python*), we got back to the ZSH problem solved in commit 4693. In order to solve it once and for all, we proceed like the following: at the beginning of the clean_environment function we check whether we are using ZSH; if so, we check if nonomatch is enabled; if it is already enabled (behavior that we want), we don't do anything; if it's not enabled, we enable it and set a variable that reminds us to disable at the end. 09 January 2020, 10:02:45 UTC
60913d2 [Exp PyROOT/thisroot.sh] Correctly update environment variables in installation with and without customized CMAKE_INSTALL_PYROOTDIR 09 January 2020, 10:02:45 UTC
ba153a7 [Exp PyROOT/thisroot.sh] build_dir/lib not needed anymore in PYTHONPATH 09 January 2020, 10:02:45 UTC
895f496 simplify ratioplot2.C tutorial 09 January 2020, 09:54:39 UTC
0da9695 [cxxmodules] Teach ACLiC to work when not all dependent libs are resolved. The non-modules system iterates over all available rootmap files and adds their libraries as potential dependencies to the library which ACLiC builds. The built library relies on the explicit linking to load its dependencies when it is dlopened. This is necessary because we have no other way to resolve symbols. Fortunately, the modules dynamic linker has superior symbol resolution. We can rely on it when loading a shared library. This patch fixes failing tests on OSX when runtime_cxxmodules are on. 09 January 2020, 08:39:08 UTC
64c431e [core] Hide libNew from symbol resolution. libNew is a custom memory allocator used in ROOT to output more information about memory pressure and used for interprocess communication in TMapFile. It essentially overrides the new and delete operators. We discovered that dlopening libNew at random time can trigger earthquakes because it allows the dynamic linker to sometimes resolve new and delete to the symbols from libNew and libc++. Patch by Alexander Penev and me! 09 January 2020, 05:32:22 UTC
9f5e828 Fix "Deprecation of -r flag from rootcling" This fixes the deprecation taken root-project/root#4716. We print the deprecation message but we still do what's intended. 08 January 2020, 18:15:17 UTC
9e67441 [RF] Added asymptotically correct parameter uncertainties * Added asymptotically correct approach to determine parameter uncertainties in weighted unbinned maximum likelihood fits (for details and a comparison of different approaches see https://arxiv.org/abs/1911.01303). This method can be used when specifying Asymptotic(true) and SumW2Error(false) as arguments to the RooAbsPdf::fitTo method. A short tutorial comparing different approaches to parameter uncertainties in the presence of event weights is available under tutorials/roofit/rf611_weightedfits.C. * Performance improvements of Asymptotic method for weighted unbinned maximum likelihood fits. Numerically equivalent. 08 January 2020, 17:18:43 UTC
321562a [PyROOT] Manually increase count, since PyTuple_SET_ITEM steals the reference 08 January 2020, 16:25:23 UTC
96d7376 [PyROOT] Add one more case to square bracket template instantiation Also support the case when the template has not been previously instantiated. This mimics the behaviour of the instantiation with parenthesis, which tries first the non-instantiating strategy and second the instantiating one. 08 January 2020, 16:25:23 UTC
d2a71ac [PyROOT] Issue a deprecation warning when instantiating with parenthesis 08 January 2020, 16:25:23 UTC
1e5c791 Fix potential crash at exit on Windows Deleting the interpreter makes things crash at exit in some cases 08 January 2020, 16:14:20 UTC
5fa18c9 Header formatting was wrong 08 January 2020, 14:48:23 UTC
82fa9ec Modify the example to make it modern C++ 08 January 2020, 14:48:02 UTC
919def3 When variance is negative (e.g. when having negative weights) return stddev=0 in TH1::GetStdDev (ROOT-8412) 08 January 2020, 08:54:37 UTC
669545f - Revert previous changes. Keep forward declaration of PyObject. PyArrayObject does not need to be defined in PyMethodBase, the data members can be removed , so no forward declaration is needed 07 January 2020, 16:04:26 UTC
febc708 include also Python.h in PyMethodBase.h 07 January 2020, 16:04:26 UTC
8fdeb26 Fix re-definition of PyArrayObject (ROOT-10495) 07 January 2020, 16:04:26 UTC
9f9bc00 [PyROOT exp] Fix syntax warning with py3.8 - Warning: SyntaxWarning: "is not" with a literal. Did you mean "!="? - See here for full discussion: https://bugs.python.org/issue34850 07 January 2020, 15:43:48 UTC
back to top