https://github.com/lmoneta/root

sort by:
Revision Author Date Message Commit Date
de0f2da more debug of generation 13 August 2020, 15:56:38 UTC
ba0807c fix getSeed in Trandom3 13 August 2020, 15:56:02 UTC
fae63a5 debug stressroostats test=34 with Minuit2 12 August 2020, 08:59:14 UTC
5fc686e add test of stressRooStats with Minuit2 minimizer option 21 July 2020, 16:07:46 UTC
8388238 Enable again the usage of ROOT error messages (TError) in Minuit2 FOr some reasons using TError in Minuit2 was disabled. It should be enabled when compiling Minuit2 within ROOT. This is done by setting the preprocessor macro USE_ROOT_ERROR 21 July 2020, 15:32:40 UTC
d4916ed Fix a bug in computation of Minos errors when a parameter is bounded (#5899) * Fix computation of Minos errrors in Minuit2 when parameters are bounded. A bug was introduced when the conditions "new minimum found" was added in Minos. (ROOT-10854) Add some fixes also the message reporting in Minuit2. Restore usage of ROOT message reporting system when MInuit2 is built within ROOT * Add a protection in TMinuit to avoid a 0/0 division. Fix ROOT-10835 This can happen when parameter limit is 0 and parameter value at minimum is 0 and a Minos error analysis is performed for that parameter. * Fix running Minos error when a new minimum is found. Fix the handling of the situation of Minos error in Minuit2 when a new minimum is found. Add a function in the Minimizer to get the status code of Minos to flag when a new minimum is found Fix function returning minimum values in Minuit2Minimizer in case of multiple runs. The minimum values are now copied in the Mininuit2Minimizer local vector when the minimization is run * Update Fitter::CalculateMinosError when a new minimum is found in Minos Recompute the minos error for the previous run parameter in case a new minimum was found * Use fabs instead of abs. Fix problem reported by CI builds * small fixes in documentation as suggested by Stephan's review * Revert changes in the Minuit2 CMAKE file for enabling Minuit2 error and warning messages. These changes will be done in a separate commit and a new PR. 21 July 2020, 15:30:40 UTC
f0e9eb4 [ntuple] use error-forwarding facilities of #6039 21 July 2020, 14:23:22 UTC
2cdaf5a [ntuple] move to plain Unwrap calls on RResults 21 July 2020, 14:23:22 UTC
ea077bb [ntuple] remove redundant default inits for RFieldDescriptor members 21 July 2020, 14:23:22 UTC
d9eadf7 [ntuple] reuse field name validity check introduced in #5967 21 July 2020, 14:23:22 UTC
78d4ee8 [ntuple] use new RResult::Unwrap function for descriptor builders 21 July 2020, 14:23:22 UTC
7ebbbbe [ntuple] fix pessimizing moves for RDanglingFieldDescriptor 21 July 2020, 14:23:22 UTC
fb49ec5 [ntuple] reintroduce move-only RFieldDescriptor with explicit Clones 21 July 2020, 14:23:22 UTC
9a0b555 [ntuple] test dangling descriptor construction errors 21 July 2020, 14:23:22 UTC
168b7b7 [ntuple] (NFC) remove unncessary header from src/RField.cxx 21 July 2020, 14:23:22 UTC
ec8c12b [ntuple] add error semantics to making a descriptor from a dangling one 21 July 2020, 14:23:22 UTC
2c7bede [ntuple] rework dangling field to more explicity sever field links 21 July 2020, 14:23:22 UTC
0802da1 [ntuple] move from field builder to dangling fields The builder abstraction doesn't clearly convey that field relationships need to be severed when they're being moved around. We'll try instead making a "dangling field" type RDanglingFieldDescriptor that is also a field builder but with a clearer distinction between field data in isolation and the links to other fields. 21 July 2020, 14:23:22 UTC
6e2f71e [ntuple] add RFieldDescriptor view interface for RFieldBase 21 July 2020, 14:23:22 UTC
19c7c22 [ntuple] add field descriptor builder class This builder class, while verbose to set up, makes descriptor construction more readable. It is also less error-prone because it relies on the FieldDescriptor to provide sensible defaults, and can handle API changes a little better (more likely that old code can continue to compile). 21 July 2020, 14:23:22 UTC
cec23e2 [ntuple] remove move-only restriction on RFieldDescriptor Field descriptors only hold plain data, so allowing copies doesn't break correctness. As part of a merge operation, we will need an easy way to make (near-)duplicate field descriptors. An earlier version of this commit implemented Clone for field descriptors, but that approach was abandoned because of verbosity and difficulty implementing an ergonomic builder pattern for fields. Fundamentally, field descriptors are not resources, only information about resources. Each member is cheaply copyable, especially considering Return Value Optimization. 21 July 2020, 14:23:22 UTC
c3de651 [ntuple] intialize all RFieldDescriptor members with natural default values 21 July 2020, 14:23:22 UTC
4d26b86 [cmake] Append to include directories, do not overwrite them This fixes what was probably a typo in ROOT_GENERATE_DICTIONARY. 21 July 2020, 09:10:51 UTC
b1a20ae [RF] Properly close polygons when drawing PDFs as surfaces. [ROOT-10931] Due to an unstable sorting algorithm, polygons sometimes won't close, since the order of the outermost points is not preserved. By moving those points by 1/1000 of the distance between points, they now always close. 20 July 2020, 17:12:39 UTC
f0bccc4 Fix the RNTuple.LargeFile test on 32bit Linux (i386 and armv7hf) 20 July 2020, 14:14:24 UTC
dba06a6 Remove definition of unused cmake variable 20 July 2020, 12:42:32 UTC
6aa62b9 Move TError from core to foundation 20 July 2020, 12:19:11 UTC
75f0fd8 [v7, exceptions] Add R__FORWARD_ERROR macro For call chains where an inner function returns an RResult of a different template than the outer RResult return type, we cannot use R__FORWARD_RESULT. Instead we need to test the inner type for an error state and can, in case of an error, use `return R__FORWARD_ERROR`. 20 July 2020, 12:13:52 UTC
0dd4cdb Simplify RResult::Forward() and R__FORWARD_RESULT 20 July 2020, 12:13:52 UTC
9053ef6 Fix libary path of modules for Windows This commit fixes the library path of modules in Windows by adding the Bin directory in the list of paths. Previously, ROOT by default assumes that modules are present in the Lib directory which is not the case for Windows. 18 July 2020, 21:17:55 UTC
703ae32 Make the modulemap more maintainable. Reduce the headers and adapt it to boost 1.72 18 July 2020, 11:27:42 UTC
c1702d8 [To be reverted] Fix the data of RDF tutorial df105 The datasets are suboptimally created and trigger the loading of the full dataset with reading the metadata. This results in reading 150GB of data even if we run nominally only on 1% of the events. 17 July 2020, 17:18:54 UTC
0705f16 Revert commit https://github.com/root-project/root/commit/0c1e5e6160fc816c3bbbe26e9b06aaf2c9a51f80 (#6001) and remove the protections for entries outside range in TMath::ASin and TMath::ACos and let std::asin and std::acos returning a NaN 17 July 2020, 16:26:41 UTC
ebd1b90 [PyROOT][ROOT-10870] Fix corruption of CPPExcInstance object 17 July 2020, 15:26:40 UTC
e4b8362 [PyROOT][ROOT-10870] Add boolean semantics to CPPExcInstance 17 July 2020, 15:26:40 UTC
f54d081 [RF][NFC] Fix docstrings in RooAbsBinning. 17 July 2020, 12:20:02 UTC
210eb85 [RF] Add two tests for RooRealVar. Add two tests for sharing of binnings, once in memory, once across TFiles. These ensure that existing, currently untested functionality doesn't break when moving from RooLinkedList to unordered_map for storing shared binnings. 17 July 2020, 12:20:02 UTC
3afcbbd [RF] Replace RooLinkedList by hash map for RooRealVar binnings. [ROOT-10781] When a lot of binnings are defined for a RooRealVar, traversing the RooLinkedList is slow. This replaces those lists with std::unordered_map. 17 July 2020, 12:20:02 UTC
9c60349 Add missing header TEveVector.h in Eve module 17 July 2020, 05:50:22 UTC
3fcf875 Merge pull request #6047 from lmoneta/fix_asymptotic_poisson_constraint Fix handling the asymptotic single poisson constraint in the AsymptoticCalculator (ROOT-10920) 16 July 2020, 15:52:18 UTC
d27d103 [PyROOT] Fix test veto if ROOTTEST_IGNORE_NUMBA_PY[23] set. 16 July 2020, 11:04:55 UTC
be0dea9 In TClass::GetListOfBaseClasses, correct conditional. It looks like without ROOT pcm but with a ClassInfo/Decl available but not loaded then the base class would not be properly setup. 15 July 2020, 17:14:11 UTC
d8b1cce Fix potential issue with dictionary generation on Windows (#5993) * Fix potential issue with dictionary generation on Windows In some cases, the dictionary generation fails on Windows with character missing in the header file names, or in the path when there is a long list of headers. For example, with TMVA, the dictionary generation was failing with the weird missing characters errors, like for example: Generating G__TMVA.cxx, ../../bin/libTMVA_rdict.pcm, ../../bin/libTMVA.rootmap <<< cling interactive line includer >>>:164:10: fatal error: 'TMVA/Volume.' file not found #include "TMVA/Volume." ^~~~~~~~~~~~~~ Or: Generating G__TMVA.cxx, ../../bin/libTMVA_rdict.pcm, ../../bin/libTMVA.rootmap input_line_12:168:10: fatal error: 'TMV/Version.h' file not found #include "TMV/Version.h" ^~~~~~~~~~~~~~~ Or again: Generating G__TMVA.cxx, ../../bin/libTMVA_rdict.pcm, ../../bin/libTMVA.rootmap input_line_12:170:10: fatal error: 'TMVA/TreInference/Objectives.hxx' file not found #include "TMVA/TreInference/Objectives.hxx" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This is coming from a recent change in include path, when it moved from the unique `root/include` directory to the multiple source `module/inc` directories, making a long list of (for example) `-IC:/Users/bellenot/git/master/core/winnt/inc`, with many duplicates, making a command of more than 8000 characters Removing the (many) duplicates is enough to fix the issue. So on Windows, we now require CMake vesrion 3.16 for the following reasons: - 3.15: Added $<REMOVE_DUPLICATES:list> generator expression - 3.16: Bug fix with CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS: the auto-generated exports are now updated only when the object files providing the symbols are updated, fixing the incremental build (it's easy to update CMake on Windows) * Check the CMake version instead of platfform This allows to remove duplicates for all platforms with newer cmake * Adjust the CMake minimum required version for Windows * Indentation 15 July 2020, 15:40:11 UTC
e510b54 [To be reverted] Disable df026 because it requires pandas. [ROOT-10921] Until pandas is installed on the CI nodes, df026 needs to stay disabled. 15 July 2020, 12:11:26 UTC
7195ca3 [CMake] List python runtime dependencies for tutorials and pyunittests. Add numpy and xgboost. 15 July 2020, 12:11:26 UTC
2917c6e [CMake] Add PYTHON_DEPS argument to ROOT_ADD_TEST/ROOT_ADD_PYUNITTTEST. If a test requires a specific python packge, this can now (and should!) be communicated using the argument PYTHON_DEPS when registering the test. This will trigger the addition of a test fixture, which checks for this package. This fixture is a simple ctest that tries to import the requested package. If the fixture passes, all dependent tests run. If the fixture fails, the dependent test don't run, but are all marked as failed because of the missing package. This makes tests faster and failures easier to diagnose, because it becomes obvious that those tests failed because of the missing package, and not because there's another problem in the test. Further, the tests that have python runtime dependencies will automatically be labelled with "python_runtime_deps". 15 July 2020, 12:11:26 UTC
0c384bb [Tutorials] Fix vetos of python tutorials for ctest. - python tutorials were only globbed using tutorials/*/*py, so some missed. Now recursive globbing is applied. - Vetoing tutorials, e.g. when components are not active, was done in two places, one for C++ and one for python. Now, blocks such as if(NOT dataframe) .. endif() take care of both the python and C++ vetos in a single location. This reduces the chance of forgetting to veto/enable some tutorials. - CMake now correctly reports how many tutorials have been activated, both for python and C++. - For an unknown reason, tmva was vetoing both tmva and dataframe python tutorials if xgboost was not found. In this commit, this is fixed, and the veto code becomes more readable. - Since keras is not a "required" dependency, the keras tutorials remain deactivated if it's not found. Previously, they were never run, anyway. 15 July 2020, 12:11:26 UTC
e014246 [ntuple] try avoiding "unused function" warning for printing RTFNTuple 15 July 2020, 10:33:10 UTC
5f040a4 [ntuple] move RNTuple debug output to Internals 15 July 2020, 10:33:10 UTC
84b130a [ntuple] add debug output for low-level RNTuple structs 15 July 2020, 10:33:10 UTC
1683cc9 Fix Jira issue #ROOT-10925 Can not compile ROOT macro on Windows (#6028) * Fix Jira issue #ROOT-10925 Can not compile ROOT macro on Windows Filter out internal DLLs, not supposed to be linked when using ACLiC * Adjust libray names to be excluded * Remove a DLL from the filtered ones 15 July 2020, 06:26:06 UTC
09a6343 Reduce TBasket high water mark use. Fix ROOT-10927. In commit 79f2e3b0e5, TBranch::GetFreshBasket was effectively switch from always reallocating the TBuffer (i.e. minimal memory use but maximal number of memory allocation) to always keeping the TBuffer (i.e. maximal memory use but minimal number of memory allocations). This causes a problem in a use CMS use case where: - files were kept open - TTree were kept in memory - has (at least) one branch with one unusually large basket (257Mb) This accumulated to increase the memory use from 1.8Gb to 2.9Gb. For now (quick fix), we use TBasket::Reset (tuned for writing) also for reading. (This leads to spurrious large reallocation in case of a consecutive series of large baskets). 14 July 2020, 19:16:44 UTC
968e688 Use C++11 thread_local in TError.cxx 14 July 2020, 13:44:06 UTC
abeeeaa [ntuple] add merger files skeleton to be filled in 14 July 2020, 13:28:22 UTC
4475d58 [DF][NFC] Fix error in user guide image 14 July 2020, 12:51:28 UTC
13bf85a Update release notes for the new definitions of physical constants 13 July 2020, 09:21:37 UTC
9e80d2f Fix the cgs value of the gravitational constant (TMath::Gcgs() ) Fix ROOT-10890\ Update also new values of gravitational constant according to latest values from NIST (https://physics.nist.gov/cuu/Constants/index.html) with better uncertainty (22ppm) Use the new SI definition for physical constants, see https://en.wikipedia.org/wiki/2019_redefinition_of_the_SI_base_units and now the Planck , Boltzmann and Avogado number are exact constants in the new definition. 13 July 2020, 09:21:37 UTC
fd26eda Fix compilation warnings 13 July 2020, 04:02:54 UTC
63375c0 [jsroot] fix TStyle handling when drawing TCanvas 10 July 2020, 18:57:26 UTC
8918a8f [v7, exceptions] add Unwrap method to move result value 10 July 2020, 13:51:48 UTC
6b4ef8a [v7, ntuple] allow RResult to work with move-only types Without being able to move from the inner field, we cannot use RResult to hold move-only types. RResult::Get() conceptually transfers ownership of the inner value out from the RResult, so it makes sense to extract the value after a Get call. The Result is left in an invalid state, but this also makes sense in the context of ownership. By calling Get(), we "open the box" to see if the operation succeeded. If it didn't, we throw an exception but if it succeeded, then there's no need for the Result to stick around because the inner value was what we wanted anyways. 10 July 2020, 13:51:48 UTC
ded7c03 Add tabcompletion test similar to the one in JupyROOT/helpers/cppcompleter.py 10 July 2020, 13:46:52 UTC
14d9bbf Mark not impleneted methods with = delete 10 July 2020, 12:21:39 UTC
24c5716 Import of calorimenters from eve to eve-7 10 July 2020, 12:21:39 UTC
6c0fcf5 In DoRedraw3D stream first orinary scene changes and then selection. This change of order is needed when EveElement carries additional higlight/selection changes before selection is appled on client 10 July 2020, 12:21:39 UTC
1838768 Pass selection type to EveElemControl.drawForSelection. 10 July 2020, 12:21:39 UTC
1c021a5 Store idx buffer from render data as Int32Array instead of Uint32Array 10 July 2020, 12:21:39 UTC
91fc407 [Tutorials] Fix missing \file tag in rf514. 10 July 2020, 07:40:05 UTC
1ca0207 [Tutorials] Add the longtest label to long-running tutorials. 10 July 2020, 07:40:05 UTC
f0ff31f [Tutorials] Ensure that df103 can be compiled. 10 July 2020, 07:40:05 UTC
30e0bff [Tutorials] Fix argv in python launcher. In tutorials/launcher.py, other tutorials are launched. It, however, needs a launch argument, but this argument confuses tutorials that also depend on sys.argv. Therefore, the first argument of the launcher is removed now before the actual tutorials are launched. 10 July 2020, 07:40:05 UTC
f42944d [RF][NFC] Fix doxygen tags in rf204b tutorial. 10 July 2020, 07:37:10 UTC
7273b38 Add support for toplevel tuple in GetMissingDictionary 10 July 2020, 00:48:22 UTC
2f0d33a Add support for toplevel array and unique_ptr in GetMissingDictionary 10 July 2020, 00:48:22 UTC
4c3c0e4 Add THashTable::Empty 10 July 2020, 00:48:22 UTC
ffc7c58 [RF] Convert static member to static function. Makes life easier on windows. 09 July 2020, 18:43:41 UTC
cb30caa [RF] Fix computation of current label in RooAbsCategory. [ROOT-10913] When the current label was requested, the category ignored whether the state has to be recomputed or not. 09 July 2020, 18:43:41 UTC
7f7aa5e [RF] Prevent invalid state in RooCategory. If users overwrite state numbers, RooCategory must fall back to a valid state instead of keeping the invalid state number. 09 July 2020, 18:43:41 UTC
378cb96 [RF][NFC] Pull computation inside branch for better locality. 09 July 2020, 18:43:41 UTC
fdb0fbc [RF] Replace strtoks by range-based for loops in RooSimPdfBuilder. 09 July 2020, 18:43:41 UTC
d113172 [RF][NFC] Modernise loops in RooSimPdfBuilder. 09 July 2020, 18:43:41 UTC
bd28f43 [RF][NFC] Fix indentation in SimPdfBuilder. 09 July 2020, 18:43:41 UTC
7987937 [ROOT-10872][PyROOT] Update Dispatcher to prevent use of deleted copy constructor 09 July 2020, 15:22:00 UTC
5111ecd [DF][NFC] Improve RDF tutorial description 09 July 2020, 15:11:10 UTC
163c2ec [DF][NFC] Separate \brief description from the rest in tutorials 09 July 2020, 15:11:10 UTC
3af07db Fix `rf204b_extendedLikelihood_rangedFit.C` error on Windows Fix the following error on Windows: In file included from input_line_10:1: C:\Users\sftnight\git\master\tutorials\roofit\rf204b_extendedLikelihood_rangedFit.C:71:13: error: call to constructor of 'RooRealVar' is ambiguous RooRealVar alpha("alpha", "alpha", -0.04, -0.1, -0); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C:/Users/sftnight/build/release\include\RooRealVar.h:41:3: note: candidate constructor RooRealVar(const char *name, const char *title, Double_t minValue, ^ C:/Users/sftnight/build/release\include\RooRealVar.h:43:3: note: candidate constructor RooRealVar(const char *name, const char *title, Double_t value, ^ CMake Error at C:/Users/sftnight/build/release/RootTestDriver.cmake:237 (message): error code: 1 09 July 2020, 08:36:57 UTC
4374860 Avoid double delete by registering to TGeoManager reflected shape assemblies, owned by TGeoVolumeAssemby. 09 July 2020, 07:09:36 UTC
4bd2f85 Add images to geom tutorials displayed using OpenGL (#6004) 09 July 2020, 05:44:03 UTC
5384ace Fix clang-10 warnings (#5987) 08 July 2020, 14:42:08 UTC
cf34916 [DF][NFC] Add \briefs to all tutorials 08 July 2020, 14:35:28 UTC
284359e [PyROOT] Install additional PyROOT headers 08 July 2020, 12:35:25 UTC
1a2b1f7 ROOT-10812: Fix building clad with external clang (#5945) ROOT-10812: Fix building clad with external clang 08 July 2020, 11:23:42 UTC
59c513c update links to the new web site (#5994) 08 July 2020, 11:03:15 UTC
db217a6 [DF] Add tests for IsDataContainer + RVecs 08 July 2020, 08:12:10 UTC
6499443 [DF][NFC] Fix typos in docs and comments Co-authored-by: Stefan Wunsch <stefan.wunsch@cern.ch> 08 July 2020, 08:12:10 UTC
004fe75 [DF] Fix IsDataContainer to classify RVec<bool> as container To be consistent with our treatment of vector<bool>. 08 July 2020, 08:12:10 UTC
77ef3e7 [DF] Treat RVec<bool> as a collection in Display This fixes the report in ROOT-10889. 08 July 2020, 08:12:10 UTC
617a2cf [NFC][DF] Fix docs 08 July 2020, 08:12:10 UTC
366d946 [Python] Add numpy to requirements.txt 07 July 2020, 19:11:08 UTC
4904ba5 [Python] Respect vetoed features in the dependency tests 07 July 2020, 19:11:08 UTC
back to top