| cc41723 | Dan LaRocque | 09 September 2015, 01:37:09 UTC | Merge branch 'issue_1142' into titan05 | 09 September 2015, 01:37:09 UTC |
| 97f8431 | deiflaender | 04 September 2015, 14:40:41 UTC | Added missing break in ElasticSearchIndex, that now not all fields are stored analysed and not_analysed | 04 September 2015, 14:40:41 UTC |
| 8646206 | Dan LaRocque | 03 September 2015, 20:15:39 UTC | Avoid 'new Stopwatch' in test code Use createStarted instead of 'new Stopwatch'. Same reasoning as in the message for 4b6296ed4379bde7088a0135fb29262ac6f46c5d, except considering test code instead of just src/main. | 03 September 2015, 20:15:39 UTC |
| 4b6296e | Dan LaRocque | 03 September 2015, 20:08:15 UTC | Avoid 'new Stopwatch' Stopwatch.createStarted is the forward-compatible way to instantiate a new Guava Stopwatch (as of 18). I would normally consider the converse problem -- backwards compat -- but StandardIDPool is already using Stopwatch.createStarted on another line. So, while it's true that createStarted is only 15.0 and up, we already require 15 as a minimum anyway in this file and probably others. | 03 September 2015, 20:08:15 UTC |
| a3d2a20 | Dan LaRocque | 27 August 2015, 19:15:52 UTC | Add classname to ES's "Unsupported type" exception For #1086 (not a fix, just a related improvement) This is the titan05 equivalent of 37491a904e67614fbac185f651adbc0e9d405b4b | 27 August 2015, 19:15:52 UTC |
| 47e9b35 | Bryn Cooke | 06 May 2015, 10:22:13 UTC | Merge pull request #1002 from randomstatistic/titan05 Update solr configuration | 06 May 2015, 10:22:13 UTC |
| 2df43da | Jeff Wartes | 21 April 2015, 14:34:37 UTC | Explain required solr configuration | 21 April 2015, 14:34:37 UTC |
| 6524a71 | Bryn Cooke | 21 April 2015, 09:37:44 UTC | Merge pull request #1028 from BrynCooke/TITAN_1022 Add a new config option for waitSearcher that defaults to false. | 21 April 2015, 09:37:44 UTC |
| 2e709f4 | Bryn Cooke | 21 April 2015, 09:35:19 UTC | Add a new config option for waitSearcher that defaults to false. Allows unit tests to run without race conditions and other users to run a maximum performance. https://github.com/thinkaurelius/titan/issues/1022 | 21 April 2015, 09:36:28 UTC |
| 7a3d796 | Dan LaRocque | 20 April 2015, 21:47:53 UTC | Modify StandardIDPool to allow failure recovery Prior to this commit, an IDAuthority.getIDBlock call that threw an exception or timed out would leave its StandardIDPool unable to progress for the rest of its lifetime. After the first timeout/exception, StandardIDPool would never attempt another call to IDAuthority.getIDBlock. This commit changes StandardIDPool to let it start a new call to IDAuthority.getIDBlock following an exception/timeout. This also fixes the test just introduced in 2e637dd69812a4a7eb879e9f34ae03a1cfbfbaac. There is no backoff logic introduced in this commit. The assumption is that the IDAuthority implementation will contain a reasonable amount of backoff logic (e.g. BackendOperation.execute). For #992 | 20 April 2015, 21:47:53 UTC |
| 2e637dd | Dan LaRocque | 20 April 2015, 20:33:50 UTC | Add test of StandardIDPool's error recovery This test shows that StandardIDPool suffers sticky failure when its underlying IDAuthority times out; after the timeout, StandardIDPool just throws IllegalArgumentException even if the IDAuthority has since recovered and is ready to return new blocks. For #992 | 20 April 2015, 20:33:50 UTC |
| 81cfbdb | Matthias Broecheler | 20 April 2015, 18:04:12 UTC | Fixes #1025 with additional test coverage | 20 April 2015, 18:04:12 UTC |
| 3c14dbb | Dan LaRocque | 18 April 2015, 06:27:43 UTC | Add hack to trick IDEA into using Kryo IDEA doesn't understand Maven's shade plugin. titan-core uses the shade plugin on Kryo. When IDEA tries to build titan-core, it seems to just ignore the shade bits, and then we get linkage errors related to Kryo when IDEA tries to execute tests using that bogus artifact that it just built. This profile reenables the unshaded Kryo dependency. Not convinced this is going to be tenable, since widening the existing gap between the Maven and IDEA test execution environments can't be a good thing in the long run. The profile is disabled by default. | 18 April 2015, 06:31:04 UTC |
| 9ee8aca | Matthias Broecheler | 18 April 2015, 02:17:30 UTC | Update TitanGraphTest.java get size of iterable | 18 April 2015, 02:17:30 UTC |
| dbae2d6 | Matthias Broecheler | 18 April 2015, 01:58:14 UTC | Fixes #988. Fixes #973. | 18 April 2015, 01:58:14 UTC |
| 82d629f | Matthias Broecheler | 18 April 2015, 01:53:19 UTC | Add test case for #988 and #973. | 18 April 2015, 01:53:19 UTC |
| 1aa3b2c | Jeff Wartes | 10 April 2015, 23:30:45 UTC | Cleaned up solr.xml a bit. Copied it into the dist artifacts | 10 April 2015, 23:30:45 UTC |
| ceef3e3 | Jeff Wartes | 10 April 2015, 23:23:27 UTC | Updated distribution artifacts for solr config | 10 April 2015, 23:23:27 UTC |
| 2ab9136 | Jeff Wartes | 10 April 2015, 23:00:40 UTC | Cleaned and modernized the solr config template | 10 April 2015, 23:00:40 UTC |
| 4b6c20b | Dan LaRocque | 31 March 2015, 17:29:32 UTC | Merge branch 'bellingard-remove-hardcoded-sq-version' into titan05 | 31 March 2015, 17:29:32 UTC |
| 71a4262 | Dan LaRocque | 31 March 2015, 17:29:18 UTC | Merge branch 'remove-hardcoded-sq-version' of https://github.com/bellingard/titan into bellingard-remove-hardcoded-sq-version | 31 March 2015, 17:29:18 UTC |
| 3246f05 | Fabrice Bellingard | 31 March 2015, 07:26:55 UTC | Remove reference to the SQ Maven plugin This should remove the warning at the beginning of Maven build. | 31 March 2015, 07:26:55 UTC |
| 0c9bc72 | Dan LaRocque | 25 March 2015, 23:33:57 UTC | Merge branch 'titan05-shaded-kryo' into titan05 | 25 March 2015, 23:33:57 UTC |
| ab3aa4b | Dan LaRocque | 25 March 2015, 23:33:36 UTC | Merge branch 'titan05' of github.com:thinkaurelius/titan into titan05 | 25 March 2015, 23:33:36 UTC |
| e6e2dac | Dan LaRocque | 25 March 2015, 22:22:51 UTC | Extend Kryo shading to its dependencies This commit follows onto c736cf7dba4b72ba00c9cf8dbe2941be6e9c66a9. That commit shaded com.esotericsoftware.kryo into a com.thinkaurelius subpackage. com.esotericsoftware.kryo contains classfiles of Kryo proper. However, Kryo depends on minlog, reflectasm, and objenesis. Classfiles for each of these three deps ships inside the Kryo 2.22 jar. Their classfiles live in different subpackages under com.esotericsoftware (but outside com.esotericsoftware.kryo). This commit expands the shading config for titan-core to also shade these dependencies into com.thinkaurelius subpackages. The idea is to shade both Kryo and its dependency tree. This commit also excludes the MANIFEST.MF that comes with Kryo, defining a Kryo bundle, and the copies of Kryo's dependency jars (kryo-2.22.jar includes both the shaded classfiles of its dependencies and a copy of each dependencies jars; the jars are referenced by the bundle definition in MANIFEST.MF). Finally, this commit turns off dependency-reduced pom generation. | 25 March 2015, 22:47:20 UTC |
| 15c8e0a | Matthias Broecheler | 19 March 2015, 23:22:20 UTC | Merge pull request #883 from graben1437/docupdates1 doc updates - suggested clarifications for index documentations | 19 March 2015, 23:22:20 UTC |
| 1023822 | Matthias Broecheler | 19 March 2015, 23:20:28 UTC | Merge pull request #885 from graben1437/docupdate3 doc update - clarifiy scheme name changes doc | 19 March 2015, 23:20:28 UTC |
| e1bc1cf | Matthias Broecheler | 19 March 2015, 23:19:37 UTC | Merge pull request #886 from graben1437/docupdates4 doc update - add scoping for multiplicity to make it the same as the cardinality example | 19 March 2015, 23:19:37 UTC |
| 4f49987 | Matthias Broecheler | 19 March 2015, 23:18:53 UTC | Merge pull request #901 from graben1437/readmeupd1 add solr to readme.textile | 19 March 2015, 23:18:53 UTC |
| 7d27025 | Dan LaRocque | 17 March 2015, 20:50:23 UTC | Merge branch 'remove-hardcoded-sq-version' of https://github.com/bellingard/titan into bellingard-remove-hardcoded-sq-version | 17 March 2015, 20:50:23 UTC |
| 3d193fb | Fabrice Bellingard | 13 March 2015, 09:46:33 UTC | Remove hardcoded version of the SQ Maven plugin Hardcoding versions of the SQ Maven plugin prevents to analyse the project on future releases of SonarQube. For instance, the analysis of Titan on Nemo (http://nemo.sonarqube.org/dashboard/index?id=com.thinkaurelius.titan%3Atitan) is broken because of this. | 13 March 2015, 09:46:33 UTC |
| c736cf7 | Dan LaRocque | 04 March 2015, 10:58:59 UTC | Shade Kryo Kryo now comes with titan-core under the package com.thinkaurelius.shaded.kryo2_22. The kryo dependency is marked optional in the titan-core pom and no longer part of the distribution zipfiles (or included in $REPO_ROOT/lib when building out of a git clone). For #821 (at last?) | 04 March 2015, 11:00:02 UTC |
| 0da0f68 | Dan LaRocque | 14 February 2015, 00:38:35 UTC | Add pom.xml snippets to changelogs for 0.5.{3,4} | 14 February 2015, 00:38:35 UTC |
| b51942e | Dan LaRocque | 14 February 2015, 00:37:44 UTC | Fix a changelog bullet under 0.5.4 | 14 February 2015, 00:37:44 UTC |
| 31d1320 | Dan LaRocque | 13 February 2015, 21:25:30 UTC | Add 0.5.4 to compat manifest | 13 February 2015, 21:25:30 UTC |
| fb74209 | Dan LaRocque | 13 February 2015, 21:25:29 UTC | [maven-release-plugin] prepare for next development iteration | 13 February 2015, 21:25:29 UTC |
| 141cd4c | Dan LaRocque | 13 February 2015, 21:25:29 UTC | [maven-release-plugin] prepare release 0.5.4 | 13 February 2015, 21:25:29 UTC |
| 6c5d25d | Dan LaRocque | 13 February 2015, 21:24:24 UTC | Updating titan.compatible.versions prop | 13 February 2015, 21:24:24 UTC |
| d78a080 | Dan LaRocque | 13 February 2015, 20:35:46 UTC | Fix HBase + TTL + Metrics 278d8b988058183ed032b03959771864f6b37a0c introduced an exception during graph startup when configured to use HBase with Metrics. This causes setup errors in HBaseOperationCountingTest, but it's not just an issue of updating some outdated expectation numbers as in ee8f75a604071db919f0a18a11a1bc72cc1c883f. This is actually a problem with Titan proper. The commit that introduced this regression wraps the backend with MetricsInstrumentedStoreManager early in startup, before wrapping with TTLKCVSManager. TTLKCVSManager expects `instanceof CustomizeKCVSManager` on its encapsulated backend to be true unless it implements cell-level TTL; this is true of HBaseSM, but not of MetricsInstrumentedSM. Doing instanceof <some manager-extension interface> in wrappers is generally problematic since we have so many manager/store wrapper classes. The typecasts prevent the compiler from helping us catch this stuff. However, this is (hopefully) the last commit before the next bugfix release, so I don't want to go overboard with hurried refactoring and break something else. I made TTLKCVSManager implement CustomizeStoreKCVSManager and check that its wrapped backend is instanceof same when the openDatabase(name, ttl) method is invoked. | 13 February 2015, 20:51:20 UTC |
| 5f2a016 | Dan LaRocque | 13 February 2015, 10:31:20 UTC | Set tentative release date for 0.5.4 | 13 February 2015, 10:31:20 UTC |
| ee8f75a | Dan LaRocque | 13 February 2015, 09:34:03 UTC | Update TitanOperationCountingTest magic numbers This commit fixes expected method invocation counts for getSlice and acquireLock in TitanOperationCountingTest assertions broken by 278d8b988058183ed032b03959771864f6b37a0c. That commit moved the code that increments counters for KCVS.* or StoreManager.mutateMany method calls such that BDB still passes, but stores that use the consistent key locker (Cassandra + HBase) fail. The counting now seems to happen after ExpectedValueCheckingStore/Manager method is invoked, but before the HBaseKCVS/Manager or Cassandra*KCVS/Manager method is invoked. Hence acquireLock is apparently never invoked, and getSlice is subject to additional invocations as the ExpectedValue classes verify that the actual stored values match those required by lock requests. | 13 February 2015, 09:34:03 UTC |
| 4976d93 | Dan LaRocque | 11 February 2015, 21:02:42 UTC | Increase a TTL-sensitive test timeout The assertion following the sleep tweak in this commit would periodically fail as though TTL expiration had not yet been processed. Doubled the sleep. | 11 February 2015, 21:23:42 UTC |
| 194bd33 | Dan LaRocque | 11 February 2015, 20:54:06 UTC | Avoid stopwords in testContainsWithMultipleValues 2a99d97913d8c05c7a53ceca77af944452fcde4c brought a new test method, testContainsWithMultipleValues, for #909. This passed on solr, but I failed to notice that it failed on lucene. The test ran a CONTAINS query on "was here". On Solr, the query matches the expected property, but on Lucene, it doesn't match even though the data are the same. If I'm reading the Solr and Lucene docs and test configs correctly, then I think "was" is configured as a stopword for both of them. I think I've also ruled out dynamic field mapping as a potential culprit -- the field in the test is getting named 1|1_t, and there's a dynamic mapping for *_t in the schema file. The FieldType also looks right; it's got to stopwords.txt. I also see stopwords.txt pushed into the Solr server config when I turn org.apache.solr logging up to DEBUG. Really not sure where the discrepancy is. Reconciling this difference was consuming a bunch of time for unclear gains, so I eventually tapped out and just changed the query string from "was here" to "here hercules". The code exercised is the same as when searching for "was here", but this avoids common stopwords. For #965 | 11 February 2015, 21:23:42 UTC |
| 71bd1d7 | Dan LaRocque | 11 February 2015, 10:15:08 UTC | Use Groovysh `set` builtin for result peek sizes When a gremlin.sh command evaluates to an iterable, the number of initial elements in the iterable printed to the console is now controlled by a pair of Groovysh settings: * `set tp-olap-result-peek <int>` (default 50) * `set tp-oltp-result-peek <int>` (default 500) The OLAP setting controls the number of initial lines read out of result files produced by executing a HadoopPipeline (i.e. a titan-hadoop/Faunus job). The OLTP setting controls the number of initial elements read out of any other iterable result. Negative ints are treated as if Integer.MAX_VALUE were specified. Zero has slightly special interpretation; it completely disables iterator peeking. Zero means that the shell will not even call hasNext to decide whether to print "...". Positive ints are used exactly as specified. Settings are persistent across gremlin.sh sessions. They're stored in the Java user Preferences system under the node "/org/codehaus/groovy/tools/shell". On *NIX systems, this is usually in ~/.java/.userPrefs/org/codehaus/groovy/tools/shell/prefs.xml. You may notice that the implementation in this commit does not actually call Preferences.flush anywhere to guarantee persistence. It relies instead on this guarantee from the Preferences javadoc: "Normal termination of the Java Virtual Machine will not result in the loss of pending updates -- an explicit flush invocation is not required upon termination to ensure that pending updates are made persistent." For #924 | 11 February 2015, 11:18:03 UTC |
| dcf2924 | Dan LaRocque | 11 February 2015, 08:49:57 UTC | Revert "Optionify the # of result elems shown in the shell" This reverts commit 5298f5d923fd2fbf276b40d7c20d4d56fd2f0621. Reverting per recent discussion in #924. | 11 February 2015, 08:49:57 UTC |
| 86a142e | Dan LaRocque | 10 February 2015, 05:53:30 UTC | Updating READMEish files for 0.5.4 | 10 February 2015, 19:39:54 UTC |
| 5298f5d | Dan LaRocque | 10 February 2015, 05:38:41 UTC | Optionify the # of result elems shown in the shell Since 645b406468f06c043b810375d6203618b505b241 made the Console.LINES limit apply non-hadoop result collections for what appears to be the first time, it's possible that the 15 element limit may surprise some people and prove annoyingly low. This commit retains the 15 element limit default, but it makes the actual number of elements configurable on the gremlin.sh command line via the -w <number> option, e.g. bin/gremlin.sh -w 50 will print up to fifty elements from a result collection before truncating any remaining elements (and if at least one element remains after those initial fifty, printing a set of ellipses). It may be annoying, but at least it's no longer hardcoded. I don't think this breaks compatibility with existing scripts, unless there's someone out there naming their Groovy script files "-w". We don't have a "--" option to disambiguate. | 10 February 2015, 05:43:17 UTC |
| 3736b37 | Dan LaRocque | 10 February 2015, 01:59:26 UTC | Keep vertices together with Cassandra widerows This commit adds a new TitanCassandraWideRecordReader class that gets instantiated when titan-hadoop's configuration includes cassandra.input.widerows=true. This RR attempts to make as many calls to the underlying widerows iterator as necessary to collect all (column,value) entries before considering a FaunusVertex complete and passing it up to the MapReduce task. For #963 | 10 February 2015, 03:05:43 UTC |
| 3c776d4 | Dan LaRocque | 10 February 2015, 01:50:02 UTC | Adding test of titan-hadoop w/ Cassandra widerows This commit adds a test method to TitanCassandraOutputFormatTest that counts vertices with cassandra.input.widerows=true in the titan-hadoop configuration. The test fails as of this commit due to a preexisting bug (fix incoming). For #963 | 10 February 2015, 03:05:43 UTC |
| 4f7647e | Dan LaRocque | 09 February 2015, 17:19:10 UTC | Fix maven assembly->gpg plugin ordering in release For #940 | 10 February 2015, 03:05:42 UTC |
| 645b406 | Dan LaRocque | 09 February 2015, 17:10:53 UTC | Fix gremlin.sh result set ellipses Prior to this commit: * Ellipses were printed whenever a result set iterator printed exactly 15 elements. * Iterators over result files generated by titan-hadoop jobs were hard limited to 15 elements, but non-Hadoop result iterators had no limit, resulting in odd ellipses behavior and no effective limit for non-Hadoop results After this commit: * All result set iterators are subject to the 15 line limit * Iterators over result files generated by titan-hadoop jobs have their internal hard limit set to 16, so that exactly-15 and 15+ are distinguishable for ellipses For #924 | 10 February 2015, 03:05:42 UTC |
| 79a942a | Dan LaRocque | 09 February 2015, 16:07:58 UTC | Stop returning unidir edges as properties titan-hadoop iterates over unidirected edges as if they were properties; this produces an exception as reported in #941. This commit makes FaunusElement.getPropertyKeysDirect stop returning unidirected edges. This avoids the exception in #941. However, dumping edges from Cassandra to GraphSON omits unidirected edges. titan-hadoop could probably use more tweaking to resolve the tension between unidirected edges being represented as relations with a type that extends edge but which use the setProperty interface. The existing TitanOutputFormatTest.testUnidirectionEdges still passes, but given my track record of unintended collateral breakage caused by faunus schema changes during titan05 development, I'm hesitant to declare victory. There may be unintended consequences that I'm missing. | 10 February 2015, 03:03:31 UTC |
| 879c9a1 | Matthias Broecheler | 24 January 2015, 02:13:09 UTC | Updated repetition counter to ensure success | 24 January 2015, 02:13:09 UTC |
| 84138c6 | Matthias Broecheler | 24 January 2015, 01:27:53 UTC | Fixes #939 and bug in previous fix to how we skip constraint verification. | 24 January 2015, 01:27:53 UTC |
| 418944c | Matthias Broecheler | 24 January 2015, 01:12:25 UTC | Merge branch 'titan05' of https://github.com/thinkaurelius/titan into titan05 | 24 January 2015, 01:12:25 UTC |
| 4962db3 | Matthias Broecheler | 24 January 2015, 01:12:06 UTC | Fixes #931 | 24 January 2015, 01:12:06 UTC |
| 41fa561 | Matthias Broecheler | 23 January 2015, 02:02:42 UTC | Added test case for #931 | 23 January 2015, 02:02:42 UTC |
| 278d8b9 | Matthias Broecheler | 23 January 2015, 01:54:37 UTC | Added metrics instrumentation around manager to account for mutateMany calls. Refactored metrics initialization. | 23 January 2015, 01:54:37 UTC |
| 7156dcb | Matthias Broecheler | 23 January 2015, 00:07:53 UTC | Fixes #937 with extra test coverage. | 23 January 2015, 00:07:53 UTC |
| 69b0788 | Dan LaRocque | 15 January 2015, 15:44:07 UTC | Merge branch 'issue_909' into titan05 | 15 January 2015, 15:44:07 UTC |
| 2a99d97 | Pavel Yaskevich | 13 January 2015, 06:12:27 UTC | (Solr) only add + when AND query has more than one condition | 13 January 2015, 06:12:27 UTC |
| 9d650c3 | Dan LaRocque | 09 January 2015, 02:54:44 UTC | Add 0.5.3 to compat manifest | 10 January 2015, 00:21:14 UTC |
| e099458 | Dan LaRocque | 09 January 2015, 02:54:44 UTC | [maven-release-plugin] prepare for next development iteration | 10 January 2015, 00:21:14 UTC |
| 4fad7ce | Dan LaRocque | 09 January 2015, 02:54:43 UTC | [maven-release-plugin] prepare release 0.5.3 | 10 January 2015, 00:21:14 UTC |
| e3f9ce7 | Dan LaRocque | 09 January 2015, 02:53:37 UTC | Updating titan.compatible.versions prop | 10 January 2015, 00:21:14 UTC |
| 6cc7081 | Dan LaRocque | 09 January 2015, 02:52:17 UTC | Updating READMEish files for 0.5.3 | 10 January 2015, 00:21:09 UTC |
| 190d42c | Dan LaRocque | 08 January 2015, 23:07:35 UTC | Changing query fit expectations in tests e538117710d373b4b8690f4c0a32f40206f41890 changed some queries that used to be fitted into unfitted queries. This caused failures in test expectations around fitted-ness. This commit changes several fitted=true expectations to fitted=false in an attempt to match the new implementation behavior. | 08 January 2015, 23:09:15 UTC |
| e538117 | Matthias Broecheler | 08 January 2015, 20:29:09 UTC | Fixes #890 | 08 January 2015, 20:29:09 UTC |
| af0dd8a | Matthias Broecheler | 08 January 2015, 19:48:20 UTC | Fixes #853 | 08 January 2015, 19:48:20 UTC |
| f4291c7 | Matthias Broecheler | 08 January 2015, 19:28:20 UTC | Merge branch 'titan05' of https://github.com/thinkaurelius/titan into titan05 | 08 January 2015, 19:28:20 UTC |
| 4a63653 | Matthias Broecheler | 08 January 2015, 19:25:16 UTC | Fixes #868 | 08 January 2015, 19:25:16 UTC |
| 4ffb0e9 | Matthias Broecheler | 08 January 2015, 18:45:56 UTC | Make index.hostname Maskable so that the hostname can be updated when the external index cluster changes. Fixes #880. | 08 January 2015, 18:45:56 UTC |
| af784bd | Dan LaRocque | 07 January 2015, 13:21:18 UTC | Only apply cache.tx-cache-size min on r/w tx This iterates on a3ea0e5c3cc566984f652619f71b0e058d716909. Read-only transactions can go under the minimum tx-cache-size setting now. Only write-capable transactions are still subject to the minimum. | 07 January 2015, 13:22:45 UTC |
| a3ea0e5 | Dan LaRocque | 07 January 2015, 10:12:30 UTC | Put a min of 100 on cache.tx-cache-size This is a workaround for #893 that's likely to avoid race conditions related to small tx-cache-size values in practice, though it does not technically eliminate the underlying problem. Prior to this commit, I investigated an alternative approach involving WeakReference and a consuming ReferenceQueue drained from the same thread that touches GuavaVertexCache, and that passed Titan's tests appeared to log all the right things via slf4j, but it's still too scary right to introduce so close to a release milestone. The assumption required to make that WeakReference approach work is that dirty vertices are at all times reachable via at least one strong reference *outside* GVC (on any GC root), but it's not completely trivial to prove this for all of Titan's internals. It's also impossible to write a watertight test for the WeakReference approach since its behavior is inextricably linked with GC. | 07 January 2015, 10:13:57 UTC |
| 612ea2d | Dan LaRocque | 07 January 2015, 09:24:12 UTC | Add "args" binding back into ScriptExecutor The Titan ScriptExecutor used to set an "args" variable in the Groovy Binding that pointed to the command-line argument list. The Faunus ScriptExecutor didn't do this. I'm modifying the Faunus ScriptExecutor to set "args" (in addition to the "a1", "a2", ... that it already sets) for backwards-compatibility. This could break existing scripts that explicitly rely on "args" being absent from the variable binding when the script starts, but that seems like an extremely narrow class of scripts. Scripts that first assign to "args" and then do stuff with it should be unaffected. | 07 January 2015, 09:27:15 UTC |
| 4f9ceb0 | Dan LaRocque | 07 January 2015, 09:15:20 UTC | Move argument shift in gremlin.sh This bit of logic has been touched in 018827a538979a93c0b1cd9b4de240e72a235f72 and again in 1b23ce606090eb7e9407e63e26bf8e4e2418ac42, with unintentional regressions in both cases. These options are calling out for automated regression tests. For #903 | 07 January 2015, 09:15:56 UTC |
| 7578354 | Dan LaRocque | 07 January 2015, 07:43:11 UTC | Fix whitespace in graph.set-vertex-id description | 07 January 2015, 07:43:11 UTC |
| da15f29 | Dan LaRocque | 07 January 2015, 07:41:15 UTC | Update links to manual in javadoc comments For #905. This updates the specific outdated URL pointed out by @jaceklaskowski. It also updates several other old wiki URLs turned up by a recursive grep for 'github.*titan/wiki'. | 07 January 2015, 07:41:15 UTC |
| 71325b7 | Stephen Mallette | 05 January 2015, 20:42:32 UTC | Add a note to the docs around Rexster configuration for cassandra to address #908 | 05 January 2015, 20:42:32 UTC |
| 4e38eca | Dan LaRocque | 27 December 2014, 18:43:38 UTC | Removing outdated query precondition This precondition check no longer applies with Contain.IN support, and the underlying invariant it expresses isn't valid anymore. Removing it following discussion with Matthias. For #882 | 27 December 2014, 18:43:38 UTC |
| 5c81611 | Dan LaRocque | 23 December 2014, 16:35:43 UTC | Add failing test with vlabel and Contain.IN conds This is based on #882 | 23 December 2014, 16:36:36 UTC |
| 29491f3 | Dan LaRocque | 22 December 2014, 19:10:45 UTC | Add basic test of ES index creation options This commit adds a test of the new functionality introduced by 6569f8b060a86a6291326e76f5dbe612732b2f7f. For #840 | 22 December 2014, 19:10:45 UTC |
| 9b76d73 | David Robinson | 20 December 2014, 17:19:42 UTC | add solr to readme.textile | 20 December 2014, 17:19:42 UTC |
| b08be31 | Dan LaRocque | 19 December 2014, 23:01:04 UTC | Tweak TitanOperationCountingTest expectations This test was broken by de177b9e59b02cd865fb9e49aa4d1a120353ced8 and 03a4c5fb8919d2ff5c0a00c705f0a43818751a95. Updating it to reflect the changes to the way Titan reads schema elements following those changes. | 19 December 2014, 23:03:47 UTC |
| a83e463 | Dan LaRocque | 19 December 2014, 21:18:18 UTC | Add helper method for exception/null-safe rollback This commit introduces a TXUtils.rollbackQuietly which is roughly similar to IOUtils.closeQuietly. This might become obsolete in Titan 0.9 where we can assume try-with-resources and txs are AutoCloseable. First used as part of #881's implementation, but not specifically related to that issue | 19 December 2014, 23:03:47 UTC |
| 9977456 | Dan LaRocque | 19 December 2014, 21:15:40 UTC | Removing tx from SchemaCache method params Now that the SchemaCache.StoreRetrieval implementation constructs a new, cache-disabled transaction for each schema read method invocation, it no longer uses the tx param to its various methods. This lets us remove the tx param from both SchemaCache.StoreRetrieval's methods and SchemaCache's methods. For #881 | 19 December 2014, 23:03:47 UTC |
| e00073c | Dan LaRocque | 19 December 2014, 20:36:09 UTC | Disable cache on correct tx for schema reads de177b9e59b02cd865fb9e49aa4d1a120353ced8 modified StandardTitanGraph.typeCacheRetrieval's retrieveSchemaByName and retrieveSchemaRelations methods to each instantiate a new StandardTitanTx using a key-consistent backend config (i.e. Cassandra QUORUM) inside each retrieve method to perform schema reads. Those methods also disabled cache on a transaction just before the schema reads. However, they disabled cache on the wrong tx -- when I introduced a a new key-consistent tx to these methods for schema reads, I failed to move the disableCache invocation from the old tx to the new key-consistent one. Now cache is disabled on the actual StandardTitanTx used for the schema schema vertex/relation read For #881 | 19 December 2014, 23:03:15 UTC |
| bc88a45 | Dan LaRocque | 18 December 2014, 22:14:32 UTC | Use consistent tx for schema retrieval Experimenting with opening a new transaction with a reference held on the stack solely for the purpose of reading schema vertices and schema relations. For #881 | 19 December 2014, 23:02:25 UTC |
| 24f93bb | Dan LaRocque | 18 December 2014, 14:57:22 UTC | Throw new ExpiredLockException when applicable This commit modifies ConsistentKeyLocker and its superclass to implement the new behavior expected in 6ea5ebf8d0b13c025d08a4734037fb725d0e089c. Previously, a lock that expired while a transaction was holding it would throw a cryptic TemporaryLockingException with the message "No lock columns found for KeyColumn [k=foo, c=bar]". This is not a helpful exception in most cases; the log for ConsistentKeyLocker emits a WARN about the expired lock shortly before this is thrown, but it would be better to have a specific exception type and message to make it clearer about what's happening in this case. Now we have ExpiredLockException. This is a a subclass of TemporaryLockingException. The message string used with it is something like "Expired lock on KeyColumn [k=foo, c=bar]: raw lock timestamp 1418915175000000 MICROSECONDS is older than Duration[300000 ms]". | 18 December 2014, 15:08:16 UTC |
| 6ea5ebf | Dan LaRocque | 18 December 2014, 14:50:15 UTC | Tweak ConsistentKeyLockerTest's expired lock tests This introduces a pair of tests around expired lock behavior: * Check that our own expired locks throw a new ExpiredLockException class when checked * Check that expired locks left behind by other instances, or by the current instance but with a different-than-expected write time, do not necessarily throw an exception in check (unless they prevent the transaction from verifying one or more of its own locks) Previously, only the latter case was implemented and tested. The former case is essentially a special case for #892, wherein we want to provide a more meaningful exception type and message in the event that a transaction's locks expire while held. | 18 December 2014, 14:57:11 UTC |
| bb6a358 | Dan LaRocque | 18 December 2014, 13:54:59 UTC | Minor javadoc improvement on lock status class | 18 December 2014, 13:54:59 UTC |
| 902e80b | Dan LaRocque | 18 December 2014, 13:09:24 UTC | Modify LuceneIndex to support REGEX on STRINGs Lucene (at least at our present version) does not seem to provide a Filter implementation that does regex matching. It does provide a Query implementation for regex matching. LuceneIndex was only built to generate Filters; it always used MatchAllDocsQuery. This change modifies LuceneIndex to allow the convertQuery method to build both a Filter and an accompanying Query. The Lucene REGEX tests introduced in 8f712e70d767313fa4ad401bd295e9bff9fd97bf pass at the moment. For #879 | 18 December 2014, 13:49:31 UTC |
| c298297 | Dan LaRocque | 18 December 2014, 11:22:37 UTC | Enable REGEX tests on Lucene Added a test of Text.REGEX that explicitly specifies Mapping.STRING so that it will activate on Lucene. This commit also makes LuceneIndex report that it supports REGEX, though the implementation just throws an exception right now. The tests are failing. Implementation is up next. For #879 | 18 December 2014, 13:49:31 UTC |
| e306728 | Dan LaRocque | 18 December 2014, 10:55:09 UTC | Deduplicate common ES & Lucene support tests LuceneIndexTest and ElasticSearchIndexTest both implement a testSupport() method that runs assertions on index.supports(...) with a variety of datatypes, mappings, and predicates. Most (but not all) of these testSupport() method bodies were identical between the two test classes. The common segment has been extracted to the shared parent class IndexProviderTest as a new method named testCommonSupport(). This change is intended to simplify upcoming REGEX-related test changes in LuceneIndexTest for #879 | 18 December 2014, 13:49:04 UTC |
| 9d38c24 | Dan LaRocque | 18 December 2014, 08:49:59 UTC | Make Multiplicity/Cardinality explicit in examples For #869 | 18 December 2014, 08:49:59 UTC |
| 50c0998 | Dan LaRocque | 17 December 2014, 17:37:20 UTC | Make Cmp.EQUAL array-aware Array values are now compared with Apache Commons ArrayUtils.isEquals, which is essentially Arrays.equals, but safe for multidimensional arrays. | 17 December 2014, 17:37:20 UTC |
| 2bf1ca3 | Dan LaRocque | 17 December 2014, 17:36:49 UTC | Add test of Cmp.EQUAL with array value This test fails currently For #878 | 17 December 2014, 17:36:49 UTC |
| e911195 | Dan LaRocque | 17 December 2014, 15:37:41 UTC | Add Cardinality & Multiplicity enum shell imports The Cardinality.* and Multiplicity.* enum names are now imported automatically in gremlin.sh and rexster-console.sh as distributed with Titan. For #869 | 17 December 2014, 15:37:41 UTC |
| 1f6f950 | Dan LaRocque | 17 December 2014, 14:24:38 UTC | Support ThreadLocal and CHM for Kryo caching This commit adds the `graph.kryo-instance-cache` option. It takes either the value THREAD_LOCAL (default) or CONCURRENT_HASH_MAP. This commit effectively restores the old Kryo caching behavior of KryoSerializer, where it stored Kryos in a ThreadLocal, and where those ThreadLocals are not necessarily removed when Titan shuts down. The CHM setting provides an alternative that, unlike ThreadLocal, is exposed to synchronization overhead when retrieving cached Kryos, but which also releases all of its cached Kryo references when the graph is shutdown. For #840 | 17 December 2014, 14:24:38 UTC |
| 8d4cb4c | Dan LaRocque | 16 December 2014, 19:49:48 UTC | Tweaking ThreadLocal comment | 16 December 2014, 19:52:08 UTC |
