dc69f6b | moneta | 07 November 2023, 15:28:43 UTC | Update release notes for 6.30 for new contributors | 07 November 2023, 16:32:42 UTC |
93ae731 | Jonas Rembser | 06 November 2023, 14:19:56 UTC | [RF] RooTruthModel analytical integrals for general integration ranges The analytical integral code of the `RooTruthModel` was making the wrong assumption that if one uses the single-sided bases, the minimum x value is always at zero (or the maximum value at zero, for the case of the flipped bases). This resulted in wrong integral values when integrating over a subrange, as reported here on the forum: https://root-forum.cern.ch/t/possible-bug-in-integration-of-roobdecay-and-rooabsanaconvpdf/56968 This commit rewrites the RooTruthModel analytical integral code to also consider these cases. To avoid that with the additional code branches the code becomes too verbose, the code was refactored to use a helper function for evaluating indefinite integrals of symmetric or asymmetric basis functions. The refactored code is tested by the integration tests in `stressRooFit`, and the problem that was reported on the forum is covered by a new unit test. | 06 November 2023, 17:18:20 UTC |
7b82399 | Igor Kakorin | 02 December 2022, 15:28:12 UTC | delete obscure conditions | 06 November 2023, 16:57:57 UTC |
7a0632e | Sanjiban Sengupta | 05 November 2023, 00:22:43 UTC | feat: update release notes with SOFIE changes and implementations | 06 November 2023, 14:48:01 UTC |
2d17eab | Sergey Linev | 31 October 2023, 13:24:03 UTC | Mark none-implemented copy/assign operators as deleted in RGL | 03 November 2023, 16:08:36 UTC |
88f9c03 | Jonas Rembser | 31 October 2023, 13:29:30 UTC | [graf3d] Apply clang-tidy suggestions This is applying most of the suggestions from the CMSSW clang-tidy configuration: https://github.com/cms-sw/cmssw/blob/master/.clang-tidy Two checks are excluded though, because they can make wrong suggestions about replacing copies with const references: * `performance-for-range-copy` * `performance-unnecessary-copy-initialization` | 03 November 2023, 13:26:08 UTC |
18149b5 | Jonas Rembser | 31 October 2023, 14:11:37 UTC | [graf3d] Apply suggestions by clang-tidy `modernize-use-nullptr` | 03 November 2023, 13:26:08 UTC |
86ff254 | Sergey Linev | 03 November 2023, 12:47:38 UTC | [jsroot] dev 3/11/2023 with ZSTD and LZMA support 1. Add LZMA support 2. Include compact ZSTD decoder, which is much smaller than used before 3. Let draw TH3 glcol with TranferFunc as from glvox2.C tutorial | 03 November 2023, 13:03:38 UTC |
cd02187 | Sergey Linev | 03 November 2023, 09:36:53 UTC | Adjust glvox2 tutorial Provide transparency for all bin values - no gaps at 0 or 0.5. Set function range to be able transfer such function to web browser | 03 November 2023, 13:03:38 UTC |
3fe75b1 | Sergey Linev | 02 November 2023, 17:03:22 UTC | Use correct method when adding color to list of colors | 03 November 2023, 09:26:17 UTC |
1754c1c | Sergey Linev | 02 November 2023, 16:42:00 UTC | Adjust gviz3d tutorial | 03 November 2023, 09:26:17 UTC |
60738d3 | Sergey Linev | 02 November 2023, 16:38:02 UTC | Add several protections in TStructViewerGUI::Update Otherwise ROOT crashes when running gviz3d.C tutorial | 03 November 2023, 09:26:17 UTC |
23d09ff | Sergey Linev | 02 November 2023, 16:33:30 UTC | Adjust TPad::GetViewer3D() method Avoid crash when fCanvas pointer not set Use better C++ syntax | 03 November 2023, 09:26:17 UTC |
7b4d1ba | Sergey Linev | 02 November 2023, 15:32:12 UTC | Correctly restore colors when reading TCanvas One should set name and alpha parameter as well. And for gradient colors one need to add them as is | 03 November 2023, 09:26:17 UTC |
1433013 | Sergey Linev | 02 November 2023, 15:15:15 UTC | Provide default constructors for color gradient classes Avoid warnings when gradients stored in I/O | 03 November 2023, 09:26:17 UTC |
0acdbd5 | Sergey Linev | 02 November 2023, 14:38:13 UTC | Extend TColor::DefinedColors() functionality If called once with argument TColor::DefinedColors(1), all saved canvas will include color and palette. One can reset flag with TColor::DefinedColors(-1) | 03 November 2023, 09:26:17 UTC |
b8d6ee3 | Jonas Rembser | 02 November 2023, 10:28:26 UTC | [tree] Apply `modernize-use-nullptr` suggestions from clang-tidy | 02 November 2023, 19:33:46 UTC |
61cce0b | Jonas Rembser | 01 November 2023, 22:23:48 UTC | [RF] Some code modernization and documentation improvements * Remove explicit empty constructors * Remove placeholder comments from the `RooClassFactory` * Shorten class descriptions * Move initial class member values to class declaration * Reduce includes * etc. | 02 November 2023, 13:54:16 UTC |
3687113 | Abhigyan Acherjee | 26 October 2023, 02:04:30 UTC | [RF] Implement `RooRatio::translate()` to enable AD support | 02 November 2023, 13:54:16 UTC |
50b242b | Jonas Rembser | 01 November 2023, 21:23:26 UTC | [RF] Remove redundant checks in `RooRatio::evaluate()` It's not necessary to explicitly handle the cases where the denominator is zero. The default division in C++ behaves just the same. | 02 November 2023, 13:54:16 UTC |
7fdd223 | Jonas Rembser | 01 November 2023, 21:19:11 UTC | [RF] Format `RooRatio` code This code will be changed a bit in the next commits, so now is a good time to format it. | 02 November 2023, 13:54:16 UTC |
1913652 | Jonas Rembser | 01 November 2023, 21:17:10 UTC | [RF] Add semicolon after `TRACE` macros to not confuse `clang-format` | 02 November 2023, 13:54:16 UTC |
a48cd2c | Sergey Linev | 01 November 2023, 17:00:26 UTC | [jsroot] dev 1/11/2023 with gradients and TF3 support Also includes fix for drawing of empty TGraph | 02 November 2023, 11:22:15 UTC |
c76c567 | Sergey Linev | 01 November 2023, 16:58:26 UTC | Adjust GL tutorials using transparent colors Now these tutorials can be used with web-based canvas or even with normal graphics - with created gradient colors. In normal graphics gradient and alpha are ignored. Remove customcolorgl.h utility while now colors can be created much-much easily with TColor::GetColor method | 02 November 2023, 11:22:15 UTC |
029ed65 | Sergey Linev | 01 November 2023, 16:53:22 UTC | Use inherited constructor in gradient classes Was already prepared by Timur, now can be enabled Add extra method to manipulate alpha values in colors list Small cleanup of code | 02 November 2023, 11:22:15 UTC |
f475e9e | Sergey Linev | 01 November 2023, 16:37:24 UTC | No need alphas parameter in TColor methods for gradients While now one can create color with alpha parameter very easy, it should be no problem to create any custom transparent colors | 02 November 2023, 11:22:15 UTC |
8c9e343 | Sergey Linev | 01 November 2023, 15:53:17 UTC | Add alpha parameter to TColor::GetColor method Ease creation and management of (semi-)transparent colors, which can be used in web canvas and in GL | 02 November 2023, 11:22:15 UTC |
ad37e51 | Sergey Linev | 01 November 2023, 14:35:48 UTC | Introduce TColor::GetRadialGradient method Allows to create radial gradient object or returns existing one. Adjust TColor::GetLinearGradient to work with angle | 02 November 2023, 11:22:15 UTC |
c466ddc | Sergey Linev | 01 November 2023, 12:34:18 UTC | Set RGB value of gradient color to mean values Let use gradient color also in normal ROOT graphics - at least showing mean color value instead of empty color. In Web and GL case gradient remains as before | 02 November 2023, 11:22:15 UTC |
0fa712b | Sergey Linev | 01 November 2023, 12:11:58 UTC | Introduce TColor::GetLinearGradient() static method Simplifies creation of linear gradient color for simple gradients of several colors. | 02 November 2023, 11:22:15 UTC |
51af5ea | Sergey Linev | 01 November 2023, 09:26:00 UTC | [webcanv] Store color gradients in web painting TWebCanvas compress colors in string to reduce amount of transferred data. Therefore one need to provide compression also for gradient colors. Use JSON array for that | 02 November 2023, 11:22:15 UTC |
7b2466c | Sergey Linev | 31 October 2023, 14:02:27 UTC | Make colors gradients persistent Allows to store them in the file and reuse in the JSROOT | 02 November 2023, 11:22:15 UTC |
af29f32 | Mattias Ellert | 01 November 2023, 09:04:03 UTC | Fix cmake/modules/FindZeroMQ.cmake It now finds ZeroMQ in Fedora 40. | 02 November 2023, 10:27:10 UTC |
f6f4014 | Vincenzo Eduardo Padulano | 01 November 2023, 17:06:10 UTC | [tmva][NFC] Add RBatchGenerator to release notes | 01 November 2023, 23:11:58 UTC |
e73e2d2 | Vincenzo Eduardo Padulano | 01 November 2023, 16:59:39 UTC | [tmva][NFC] Make RBatchGenerator tutorials visible on website | 01 November 2023, 23:11:58 UTC |
8cad9b2 | Axel Naumann | 01 November 2023, 15:26:58 UTC | [ci] Print exception connecting to S3. | 01 November 2023, 20:53:46 UTC |
a7ba167 | Jonas Rembser | 09 October 2023, 09:50:11 UTC | [graf2d] Apply `clang-tidy` suggestions This is applying most of the suggestions from the CMSSW clang-tidy configuration: https://github.com/cms-sw/cmssw/blob/master/.clang-tidy Two checks are excluded though, because they can make wrong suggestions about replacing copies with const references: * `performance-for-range-copy` * `performance-unnecessary-copy-initialization` | 01 November 2023, 17:48:34 UTC |
bb33e9c | Jonas Rembser | 01 November 2023, 07:13:37 UTC | [core] Replace usage of `ROOT/RStringView.hxx` header inside ROOT Since C++17 is now the minimum standard, we can use `<string_view>`. | 01 November 2023, 16:30:20 UTC |
ee35142 | Jonas Rembser | 01 November 2023, 02:24:15 UTC | [cmake] Remove unused checks for C++ features | 01 November 2023, 16:30:20 UTC |
f373fd3 | Jonas Rembser | 01 November 2023, 02:22:10 UTC | [core] Remove `std::apply` backport | 01 November 2023, 16:30:20 UTC |
3b72cb5 | Jonas Rembser | 01 November 2023, 02:02:17 UTC | [core] Remove `std::string_view` backport Remove the `std::string_view` backport, because it's not necessary anymore since the minimum C++ standard is now C++17. | 01 November 2023, 16:30:20 UTC |
ca0c8d0 | moneta | 01 November 2023, 12:52:25 UTC | [tmva][sofie] Fix the issue with GNN receivers/senders different for every event The SOFIE GNN must support having different senders and receivers (adjacent matrix) for every event as it is the case in the GraphNet library This is now achieved by including the list(vector) of sender/receivers in the GNN data structure which is passed to the generated infer function. Before the list was used as a static data member of the generated GNN secton class | 01 November 2023, 15:19:53 UTC |
031e983 | Jonas Rembser | 31 October 2023, 23:40:23 UTC | [tmva] Move `stressTMVA` inside tmva subdirectory This is done so that it is built in the same cmake project as ROOT itself, so that we can query the `tmva-gpu` and `tmva-cpu` flags. | 01 November 2023, 13:30:32 UTC |
c700d84 | Jonas Rembser | 31 October 2023, 23:27:49 UTC | [cmake] Look for `CUDAToolkit` when building with `tmva-gpu` This is a follow-up to 15a14ae6b4c. The `FindCUDA` module is deprecated since CMake 3.10 and the mentioned commit therefore removed the usage of it. This was fine for RooFit, but TMVA not only compiles sources with the NVidia compiler but also uses the CUDA toolkit in regular C++. Therefore, that commit broke the TMVA GPU features. Unfortunately, I didn't notice before, because of this check in `cmake/modules/SearchInstalledSoftware.cmake`: ```cmake if(tmva-gpu AND NOT CUDA_FOUND) set(tmva-gpu OFF CACHE BOOL "Disabled because cuda not found" FORCE) endif() ``` The `CUDA_FOUND` variable is not set anymore now that `FindCUDA` is not used. That means that `tmva-gpu` was silently disabled, and not building successfully (which I had wrongly concluded because of the absence of errors). This check needs to be replaced with `if( NOT CMAKE_CUDA_COMPILER)`. As recommended in the CMake docs, this should be done with the `FindCUDAToolkit` module, which is what this PR suggests. The `CUDA_ADD_EXECUTABLE` command is also replaced with the regular `add_executable`, because `CUDA_ADD_EXECUTABLE` was also deprecated with `FindCUDA`. Furthermore, all `cuda AND tmva-gpu` checks were replaced with only `tmva-gpu`, because `tmva-gpu` implies `cuda`. See also: * https://cmake.org/cmake/help/latest/module/FindCUDA.html * https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html | 01 November 2023, 13:30:32 UTC |
8ca15c0 | Marta Czurylo | 01 November 2023, 08:27:43 UTC | [DF] Avoid usage of Mathmore/gsl in df106 tutorials (#13989) | 01 November 2023, 08:27:43 UTC |
5c20895 | Jonas Rembser | 31 October 2023, 12:48:43 UTC | [RF] Yet another fix to bin-by-bin offsetting In simultaneous fits with more than one channel, the NLL variable adds by default a normalization term so that the probability is normalized over the full measurement including all channels. In case of bin-by-bin offsetting, this should not be done because the same term appears in the likelihood in the denominator and cancels out. Also, fixes a problem where the name of the `_offsetPdf` was not correctly reset (previously, only the name of the proxy was changed, not the name of the pdf). | 31 October 2023, 22:27:21 UTC |
576614c | Bertrand Bellenot | 31 October 2023, 12:22:22 UTC | [cmake] set the `exceptions` flag to `IGNORE` to silent deprecation warning (thanks Jonas for the hint) | 31 October 2023, 14:39:18 UTC |
1a59567 | Jonas Hahnfeld | 03 April 2023, 13:08:02 UTC | [cmake] Add support for partially enabled modules On Windows, we currently cannot generate all modules due to crashes, so some dictionaries are generated with the option NO_CXXMODULE. This information needs to be propagated and taken into account when those dictionaries are, in turn, specified as dependencies. This re-implements the logic reverted in commit 2d7373d47e (see the message for details) and closes #12591. | 31 October 2023, 13:40:52 UTC |
17674f3 | Bertrand Bellenot | 31 October 2023, 10:03:30 UTC | [skip-ci] Remove the deprecated `exceptions` option from the CI | 31 October 2023, 12:04:10 UTC |
bcb012f | Sergey Linev | 30 October 2023, 14:05:50 UTC | [jsroot] dev 30/10/2023 Several more fixes in TFormula processing Histogram drawing build from TGraph2D using Delaunay interpolation Better TPave shadowing Use interpolation for values stored in `TF1` save buffers | 30 October 2023, 17:37:26 UTC |
6e836d3 | Sergey Linev | 30 October 2023, 12:31:29 UTC | [http] allow recursion in THttpServer::ProcessRequests() When inside requests processing gSystem->ProcessEvents called again, let properly process these events - if they called from the same thread. | 30 October 2023, 17:37:26 UTC |
39042b6 | Sergey Linev | 30 October 2023, 09:23:27 UTC | [webcanvas] always store TF1 values One cannot detect if stored values are wrong or if function cannot be evaluated on client side. Therefore always store in the fSave buffer. | 30 October 2023, 17:37:26 UTC |
a13bff9 | Sergey Linev | 26 October 2023, 14:15:34 UTC | [webcanvas] fill content for TGraph2D histogram If none of valid TGraph2D options are specified, ROOT creates histogram and draw it with content taken from Delunay approximation. This mode is now supported by web canvas | 30 October 2023, 17:37:26 UTC |
c5b4095 | Sergey Linev | 26 October 2023, 11:43:24 UTC | [webcanvas] also search for objects in TMultiGraph list functions Create title when TMultiGraph draw axes | 30 October 2023, 17:37:26 UTC |
ddc04cd | Sergey Linev | 26 October 2023, 11:29:26 UTC | [webcanvas] support functions drawing from TMultiGraph One need to call TF1::Save() to be able use it properly | 30 October 2023, 17:37:26 UTC |
60406fc | Sergey Linev | 30 October 2023, 13:38:41 UTC | Rename fNsave -> nsave local variable in TF1::GetSave Avoid confusion with old data member which was present in TF1 class until ROOT6 | 30 October 2023, 13:46:38 UTC |
0111894 | Sergey Linev | 27 October 2023, 11:59:18 UTC | Fix TF1/TF2/TF3 GetSave methods When right boundary bins was used, fSave array index was out of range while (xbin+1, ybin+1, zbin+1) are used for approximation. Therefore always use at maximum npx-1 as bin index. | 30 October 2023, 13:46:38 UTC |
6ea7187 | Sergey Linev | 26 October 2023, 15:43:29 UTC | Add testing for TF3::Save | 30 October 2023, 13:46:38 UTC |
a650504 | Sergey Linev | 26 October 2023, 15:38:47 UTC | Add testing of TF2::Save | 30 October 2023, 13:46:38 UTC |
f170638 | Sergey Linev | 26 October 2023, 15:32:10 UTC | Add testing of TF1::Save Both default and explicit range should provide proper approximation and handle boundaries | 30 October 2023, 13:46:38 UTC |
d8cab78 | Sergey Linev | 27 October 2023, 10:54:28 UTC | Fix TF3::Save with default args Same as for TF1 reduce number of saved bins. In such case position will be exactly at the center of histogram bins | 30 October 2023, 13:46:38 UTC |
c5bd417 | Sergey Linev | 27 October 2023, 10:43:18 UTC | Fix TF2::Save with default args Same as for TF1 reduce number of saved bins. In such case position will be exactly at the center of histogram bins | 30 October 2023, 13:46:38 UTC |
8b6a4ba | Sergey Linev | 27 October 2023, 09:24:15 UTC | Fix TF1::Save with default args One should reduce size of saved buffer to get proper dx out of it | 30 October 2023, 13:46:38 UTC |
e4b15c1 | Axel Naumann | 28 October 2023, 13:16:25 UTC | [cocoa] Fix wrong boundary of cocoa to-bitmap: From Timur! Fixes black area on top of canvas region in non-batch (i.e. interactive) GUI save-as. I.e. fixes issue #13964. | 28 October 2023, 19:10:01 UTC |
78c3db8 | Jonas Rembser | 28 October 2023, 13:02:10 UTC | [PyROOT] Fix typo in recent PyROOT commit `Metho_` -> `Method_` | 28 October 2023, 14:44:41 UTC |
0bbefa7 | Jonas Rembser | 08 October 2023, 08:25:01 UTC | [geom] Apply `clang-tidy` suggestions This is applying most of the suggestions from the CMSSW clang-tidy configuration: https://github.com/cms-sw/cmssw/blob/master/.clang-tidy Two checks are excluded though, because they can make wrong suggestions about replacing copies with const references: * `performance-for-range-copy` * `performance-unnecessary-copy-initialization` | 28 October 2023, 13:34:10 UTC |
3cdb2ec | Axel Naumann | 27 October 2023, 12:51:54 UTC | [eve7] Silence "unused par" warning on Mac release builds: parameter 'size' set but not used [-Wunused-but-set-parameter] | 27 October 2023, 17:01:34 UTC |
90fcd0f | Marta Czurylo | 27 October 2023, 14:08:58 UTC | [relnotes] [DF] Relnotes update Marta - df106 tutorials | 27 October 2023, 14:08:58 UTC |
a6195ba | Florine de Geus | 26 October 2023, 16:02:06 UTC | [ntuple][NFC] Update importer documentation Remove the usage of `RResult`-related function as the returned importer object is not wrapped in it anymore. Also point to the tutorial, and mention the specification for type compatibility. | 27 October 2023, 13:48:53 UTC |
ba64765 | Axel Naumann | 12 October 2023, 09:05:22 UTC | [matrix] Fix TMatrixTSparse::SetMatrixArray for RowLwb!=0: Addresses https://github.com/root-project/root/issues/13848 Thanks, Eddy! | 27 October 2023, 11:07:42 UTC |
1c74d59 | Axel Naumann | 13 October 2023, 14:13:40 UTC | [cmake] Deprecate exceptions oracle pythia6 pythia6_nolink pyroot-python2: they should be removed in 6.32. | 27 October 2023, 09:08:00 UTC |
e5b0335 | Axel Naumann | 13 October 2023, 14:03:27 UTC | [cmake] Remove build options already deprecated for 6.28. Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com> | 27 October 2023, 09:08:00 UTC |
b29e00e | Vincenzo Eduardo Padulano | 26 October 2023, 15:28:49 UTC | [relnotes] Specify Vincenzo's full name in release notes | 27 October 2023, 07:40:29 UTC |
794aca2 | Vincenzo Eduardo Padulano | 26 October 2023, 15:27:49 UTC | [relnotes] Add 6.30 contributions by Vincenzo | 27 October 2023, 07:40:29 UTC |
b0fd025 | moneta | 24 October 2023, 16:11:19 UTC | [mathcore] Fix creating the ParameterSetting when calling SetFCN This fixes using the fit2dHist.C when using the global fit (user defined FCN) This PR fixes #13906 | 26 October 2023, 15:13:23 UTC |
f2e46e3 | Pere Mato | 26 October 2023, 09:11:27 UTC | Make FindMySQL.cmake more tolerant | 26 October 2023, 15:04:24 UTC |
1ed5e39 | Sergey Linev | 26 October 2023, 09:05:33 UTC | [jsroot] dev 26/10/2023 with proper stats box size | 26 October 2023, 13:34:10 UTC |
f84f24e | Sergey Linev | 26 October 2023, 07:19:53 UTC | [tbrowser] ensure that TCanvas created when web mode is not active In "classical" TBrowser one want to use normal TCanvas - even if rootrc configured differently. Therefore change gEnv values for the time when canvas is created | 26 October 2023, 13:34:10 UTC |
5e2b806 | Olivier Couet | 26 October 2023, 06:59:40 UTC | Fixes for DF tutorials (#13938) | 26 October 2023, 06:59:40 UTC |
c816e55 | Sergey Linev | 25 October 2023, 14:46:27 UTC | [jsroot] dev 25/10/2023 1. Fix - several bugs in TFormula parsing 2. Fix - correctly use saved buffer in TF1/TF2 3. Correctly update TGraph2D object 4. Correctly fill context menus for TF1/TF2 | 26 October 2023, 06:49:50 UTC |
c0af294 | Sergey Linev | 24 October 2023, 15:26:23 UTC | [webcanvas] specify real range(s) for TF1::Save calls Otherwise TF1::Save store wrong values, which difficult to use | 26 October 2023, 06:49:50 UTC |
155b38d | Sergey Linev | 24 October 2023, 11:36:41 UTC | [tutorials] simplify drawing in fitElipseTGraph macros Like in hsimple.C, just create canvas of name "c1". Old canvas of same name will be recreated. No need cast of nullptr | 26 October 2023, 06:49:50 UTC |
216e04f | Sergey Linev | 24 October 2023, 11:19:54 UTC | [tutorials] Adjust fitConvolution[.C/.py] macros Do not need draw histogram again after fitting It happens automatically | 26 October 2023, 06:49:50 UTC |
f67deeb | Sergey Linev | 24 October 2023, 09:24:22 UTC | [tutorials] remove TF2 drawing from fit2.C macro Function already drawn when `h2->Fit("f2")` is called. | 26 October 2023, 06:49:50 UTC |
e9c9bb6 | Sergey Linev | 23 October 2023, 14:13:00 UTC | [webcanvas] Support histogram creation for TGraph2D While histogram not stored with TGraph2D, it should be append to the pad list of primitives and drawn independently | 26 October 2023, 06:49:50 UTC |
4010a9b | Sergey Linev | 23 October 2023, 08:28:34 UTC | [tutorials] use cont3 option in fit2dHist.C Such draw option is more prominent than cont1 which makes different colors, which not seen on the top of default color plot | 26 October 2023, 06:49:50 UTC |
d1d1641 | Sergey Linev | 23 October 2023, 08:23:24 UTC | [webcanvas] handle TF1::Save also in hist list of functions | 26 October 2023, 06:49:50 UTC |
ab4e496 | Sergey Linev | 25 October 2023, 12:29:04 UTC | Paint TF1 with default "lf" draw option also when "sames" was provided In some old examples "same" and "sames" draw options for TF1 was used. Currently if "sames" used for TF1 - plain histogram painting is performed which is wrong for the function. Also improve PMC/PLC/PFC handling | 26 October 2023, 06:48:25 UTC |
8b0fae3 | Jonas Rembser | 25 October 2023, 16:07:26 UTC | [RelNote] Added QuillPusher to the release notes For his work on the RooFit Developer Documentation. | 25 October 2023, 22:39:47 UTC |
3be7c14 | Jonas Rembser | 25 October 2023, 15:59:47 UTC | [RF] Some improvements to docs In particular, make sure that the brief class description is not too verbose and does not repeat the class name. | 25 October 2023, 22:39:47 UTC |
0e0fce7 | Jonas Rembser | 24 October 2023, 20:51:55 UTC | [RF] Improve developer documentation * Correct code highlighting in doxygen * Fix some references to other functions and classes in the reference guide * Add a section that summarizes the relevent implementation details for RooFit AD | 25 October 2023, 22:39:47 UTC |
91105a6 | Jonas Rembser | 24 October 2023, 17:34:11 UTC | [RF] Introduce RooFit Developer Documentation | 25 October 2023, 22:39:47 UTC |
a139a69 | Christian Tacke | 24 October 2023, 18:25:40 UTC | fix: Use TKey::ReadObject<T> instead of ReadObj ReadObj returns an owning pointer. Using dynamic_cast and ignoring the "not castable" case can leak memory. See: https://root-forum.cern.ch/t/possible-leak-with-dynamic-cast-and-tkey-readobj/56799 | 25 October 2023, 14:05:07 UTC |
615eaf6 | moneta | 24 October 2023, 21:18:53 UTC | [minuit2] Use a lower tolerance for deciding if using 1./g2 in the seed covariance Use precision.Eps() instead of precision.Eps2() for threshold for the lower values for the initial seed covariance matrix | 25 October 2023, 09:45:37 UTC |
c65cff6 | moneta | 24 October 2023, 15:18:18 UTC | [roofit][tutorials] Do not force using Minuit for contour tutorial After previous commits finding the contour works now in Minuit2 | 25 October 2023, 09:45:37 UTC |
1d19833 | moneta | 24 October 2023, 15:13:02 UTC | [minuit2] Fix in Minos Error for limits needs to take care when limits are not present In this case the limit value is zero, so a special treatment is needed to check if a limit is present or not Add also suggestion by Jonas review | 25 October 2023, 09:45:37 UTC |
ed86303 | moneta | 21 October 2023, 17:45:51 UTC | [minuit2] Use an value of 1 for the covariance estimated in MnSeed when g2 is zero When g2 is zero better using an arbitrary value of 1 in the covariance then a very large one, which can be problematic. This commit restores what is so far used in the legacy TMinuit | 25 October 2023, 09:45:37 UTC |
7a0411e | moneta | 20 October 2023, 18:18:46 UTC | [minuit2] Fix a bug in computing Minos error when close to the limit The computed value of the Minos error was WRONG when parameter+error is over the limit, but the minos point is before the limit. Thsi can happen for example when computing a limit on a fraction parameter that is bound to be less than 1. | 25 October 2023, 09:45:37 UTC |
47e8c71 | moneta | 20 October 2023, 18:00:17 UTC | [minuit2] Fix searching of a new point in MnContour When searching for a new point between p1 and p2, if MnCross fails, retry using a position closer to p1 instead of the middle. Thsi is what is done in old TMinuit. Minuit2 was trying to switch direction of the search and this was causing finding points in the opposite side of contour and messing up the order. Improve also debugging of MnContour | 25 October 2023, 09:45:37 UTC |
03bfb76 | Sergey Linev | 23 October 2023, 11:06:36 UTC | Update TGraph2D properties before painting TGraph2DPainter keep pointers on TGraph2D data, but was not checking if these values were changed. Fixes problem reported https://root-forum.cern.ch/t/56816/ | 25 October 2023, 09:16:55 UTC |