https://github.com/root-project/root

sort by:
Revision Author Date Message Commit Date
4556bb6 Fix handling of ':' character in a TDirectory name 24 October 2019, 15:57:56 UTC
7447d2b Update release notes (hadd speed) 24 October 2019, 14:15:40 UTC
5dcbabf [hadd] Delay reset of kMustCleanup to avoid recording the change 24 October 2019, 14:15:01 UTC
7d52f3f [hadd] Delete the directory from the input file as soon as done with it. So far only the directory for the _first_ input file were delete immmediately, all the other were kept in memory until the files were close. This reduces memory consumption and speedup file closing (tear down) speed. 24 October 2019, 14:14:54 UTC
6e186c2 [hadd] Mark all read objects as do-not-cleanup 24 October 2019, 14:14:48 UTC
683d09d TMessage: do not access not-allocated buffer ROOT-10340 When wrong-formatted TMessage is received, length of buffer may be 0. As result, buffer may not be allocated at all. One should avoid that in such case memory is accessed 15 October 2019, 17:49:28 UTC
0d63bbe Fix handling of inline namespace std::__cxx11 in TClassEdit::GetSplit This fixes ROOT-8396 The issues was the normalization of "std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >" into vector<string> due to the inline namespace (__cxx11). Prior to this commit, it would work but only if the name for normalized twice. This because the order of operation was 1. check if the name is std::basic_string or basic_string 2. do more stuff 3. remove std and std::[any-inlined-namespace-name] now we extended 1 to also search for std::[any-inlined-namespace-name]::basic_string 25 September 2019, 11:47:51 UTC
b652ab6 Remove unnecessary search in GetMissingDictionariesForMembers. If TDataMember has a TDataType then the member has a basic type. TDataType::Class 'just' returns the TClass representing TDataType itself. 28 August 2017, 20:50:09 UTC
72154be Actually activate GetMissingDictionariesForBaseClasses. It was inadvertently useless as TBaseClass::Class() returns the TClass describing TBaseClass itself while TBaseClass::GetClassPointer returns the TClass describing the base class. 28 August 2017, 20:50:06 UTC
91a166a White space 28 August 2017, 20:50:03 UTC
56f58a7 Update release notes 24 February 2017, 20:41:14 UTC
1019e80 Allow the use of 1st gen Collection Proxy for bitset and vector<bool> Because the address of the element of a bitset and vector<bool> can not be taken, we need to use a temporary storage to implement the interface that requires the address of the element. So far this had only been implemented in the specialized collection proxy (TGenBitsetProxy and TGenVectorBoolProxy). Those are obtained only when cloning a generic collection proxy. Consequently using the result TClass::GetCollectionProxy for those two directly did not work in all cases/interfaces. However since TTree is making a copy of the collection proxy, it was correctly in all cases. This patch resolves all the issues seen in ROOT-8574 including - the bitset proxy's iterator did not record it started but still recorded its advance - the genertic proxy At function in case of bitset or vector<bool> was not return the right address We also simplified TGenVectorBoolProxy since we know the actual container type at compilation time. 24 February 2017, 20:40:29 UTC
e8c3e97 Remove kBOOL_t and thus remove inconsistencies. In 2004 kBool_t was the same value as kUChar_t (both 11). So when the collection proxy were introduced to distinguished the two, a new one was introduced kBOOL_t (value 21) to be used internally by the collection proxies. However this value is returned by TVirtualCollectionProxy::GetType and lead to incorrect behaviors, for example: std::cerr << TDataType::GetDataType(proxy->GetType())->AsString(proxy->At(i)) << "\n"; as the value 21 is in TDataTypes.h the value of kDataTypeAliasUnsigned_t In 2005 (eab7cae079e), kBool_t was updated in TDataTypes.h (to the value 18) to be distinct from kUChar_t as (at the time) sizeof(bool) on MacOS was 4. However the code in collection proxy was never modernize to leverage this new distinction. Since the value is only recorded in the CollectionProxy objects and those are never persisted, we can safetly switch from kBOOL_t to kBool_t. 24 February 2017, 20:40:13 UTC
a5ae770 Update release notes 05 December 2016, 16:24:04 UTC
f27ea52 Revert "Prompt error while building StreamerInfo if element is vector<T> and has no dictionary" This reverts commit 88e213d7d3bea80332cfc33ccf194b3e1d1f25b7. 05 December 2016, 16:18:49 UTC
cc13785 Remove the (incorrect) forced alignment of the content of vector. This was the 'right' thing to do for Emulated class (due to a deficiency in TStreamerInfo::ComputeSize) but wrong from loaded classes (where TClass::Size() is authoritative for use in vector). Which this change we should be back to the emulated vector and a compiled vector being bitwise identical. Note the forced alginment was introduced in 9968d0f0301776294f361752ff7b914e7c181f58 to more properly support emulated class (which is more comprehensively done by fixing TStreamerInfo::ComputeSize) 05 December 2016, 16:16:30 UTC
25cbc7f Use constexpr and mark variable name as const. Avoid code duplication 05 December 2016, 16:16:29 UTC
99fa418 Align the 'sizeof' emulated classes. This avoid user of this size (like the emulation of std::vector) to have to align it (and having to filter this alignment on just the emulated case) 05 December 2016, 16:16:29 UTC
064b930 Add more code comment 05 December 2016, 16:16:29 UTC
a58dd6c Use constexpr and mark variable name as const 05 December 2016, 16:16:28 UTC
fcc18da Fix ROOT-8490, avoid nullptr point to std::string. Also improve handling of the case of ~invaliduser by leaving the filename as is and allow TFile::Open to print the original filename in the error message. 05 December 2016, 16:16:28 UTC
f7cddab Release notes 29 November 2016, 09:20:26 UTC
88e213d Prompt error while building StreamerInfo if element is vector<T> and has no dictionary This fixes ROOT-8478. 29 November 2016, 08:53:36 UTC
a36aa27 Missing init of UnsupportedFriend (ROOT-8289). (cherry picked from commit 39d95673979f53ed837cebdf26ddf50068cc6e65) 22 November 2016, 09:22:22 UTC
7c45c0d Fix invalid python in error message printing 20 October 2016, 08:15:35 UTC
cb614b3 Avoid access gROOT after its teardown in destructors (Fix ROOT-8395) 13 October 2016, 19:36:33 UTC
a837365 Fix for ROOT-8393 - Python 3 syntax errors in ROOTaaS (easy to fix) 12 October 2016, 13:59:51 UTC
a047c84 Publish List of method arguments only when it is complete/ready to avoid using it too early in another thread. Thanks Dan Riley for finding this. 11 October 2016, 01:18:43 UTC
1005f7a update release notes 15 September 2016, 15:29:14 UTC
1ddc1e0 Avoid spurrious error about duplicated STL dictionary 15 September 2016, 14:07:49 UTC
f5ede14 Remove R headers from PCH 15 September 2016, 07:50:42 UTC
2e55e30 Avoid misusing the existence of ROOTSYS to decide the type of installation. Make use of 'root-config'. 14 September 2016, 19:12:06 UTC
f08ff84 Fix for ROOT-8356 - xrootd just disabled when not found and -Dfail-on-missing=ON 12 September 2016, 12:34:29 UTC
a509884 Fix to force builtin jpeg and png libraries for libafterimage when not found. 12 September 2016, 07:15:36 UTC
e114df4 In ResolveTypedefImpl add missing end of loop condition. With the instrumentation below, this resulted in TClassEdit::ResolveTypedef("unsigned long const",false); printing: DAVIDLTDEBUG: tname: 'unsigned long const' DAVIDLTDEBUG: strlen(tname): 19 DAVIDLTDEBUG: next: 20 DAVIDLTDEBUG: strlen(tname+next): 17 DAVIDLTDEBUG: tname+next: '15TApplicationImp' i.e. Looking pass the end of the result because next+5 == 20+5 > 19 ! diff --git a/core/metautils/src/TClassEdit.cxx b/core/metautils/src/TClassEdit.cxx index 4e8c3ad..3f96922 100644 --- a/core/metautils/src/TClassEdit.cxx +++ b/core/metautils/src/TClassEdit.cxx @@ -1413,6 +1413,9 @@ static void ResolveTypedefImpl(const char *tname, // where E might be replace by N<O,P> // and G::H<I,J>::K or G might be a typedef. + std::cout << "DAVIDLTDEBUG: tname: '" << tname << "'" << std::endl << std::flush; + std::cout << "DAVIDLTDEBUG: strlen(tname): " << strlen(tname) << std::endl << std::flush; + bool constprefix = false; if (tname[cursor]==' ') { @@ -1590,6 +1593,9 @@ static void ResolveTypedefImpl(const char *tname, if (tname[cursor] != ' ') end_of_type = cursor; // check and skip const (followed by *,&, ,) ... what about followed by ':','['? auto next = cursor+1; + std::cout << "DAVIDLTDEBUG: next: " << next << std::endl << std::flush; + std::cout << "DAVIDLTDEBUG: strlen(tname+next): " << strlen(tname+next) << std::endl << std::flush; + std::cout << "DAVIDLTDEBUG: tname+next: '" << static_cast<const char *>(tname+next) << "'" << std::endl << std::flush; if (strncmp(tname+next,"const",5) == 0) { if ((next+5)==len || tname[next+5] == ' ' || tname[next+5] == '*' || tname[next+5] == '&' || tname[next+5] == ',' || tname[next+5] == '>' || tname[next+5] == '[') { next += 5; 05 September 2016, 23:10:02 UTC
46ce3df Add some masking to stressGUI in case option 'asimage' is disabled. 01 September 2016, 16:32:22 UTC
38da76d Update ROOT version files to v6.06/09. 01 September 2016, 12:54:33 UTC
3a32363 Update ROOT version files to v6.06/08. 01 September 2016, 12:35:07 UTC
e2a3709 More release notes 01 September 2016, 12:28:39 UTC
3bae07b Update release notes 01 September 2016, 12:22:36 UTC
3077a57 Fix algorithm to handle paths with spaces. 29 August 2016, 06:38:24 UTC
0114a89 Do not try to link library names with a space at the end 29 August 2016, 06:38:24 UTC
92ce55f Improve heuristics to identify paths with spaces in aclic. 29 August 2016, 06:38:23 UTC
81ad91d Fix ROOT-8332: support linked libraries paths with spaces in aclic 29 August 2016, 06:38:23 UTC
6fd7b78 Fix test35, by defining the correct number of parameters for the functions to test 26 August 2016, 16:23:05 UTC
63af0e7 Copy from master commit which implement bigaus as a new TFormula pre-defined function 18 August 2016, 08:50:17 UTC
b63f514 Publish ListOfBases only when it is complete 17 August 2016, 18:02:23 UTC
d6aa2c7 Fix ROOT-8307: Crash when leaving ROOT from GUI menu item. Opening any menu item after clicking 'Quit ROOT' but before the windows is actually closed (there is a non-negligeable time window where you can), will lead to a crash (or at least the reuse of a delete object). This is because open the menu item was registering the pop menu with the TGClient but the canvas destructor was deleting the C++ object representing the pop menu without unregistering it from the TGClient. This is fixed by forcing the unregistration from the TGPopupMenu destructor. 11 August 2016, 16:32:37 UTC
4823030 Use ROOT error logger. In addition having #include <iostream> in header files is 'somewhat' costly as it induces static variables in each compilation unit containing it. 09 August 2016, 16:31:28 UTC
2e70925 Fix for ROOT-8105 and similar bugs caused by parsing for pre-defined functions. Add new tests showing cases which were failing before (test34,35,36) 09 August 2016, 16:28:45 UTC
f87d854 Update release notes (ROOT-8105) 08 August 2016, 20:12:12 UTC
e10f496 Fix for ROOT-8105 and similar bugs caused by parsing for pre-defined functions. Add new tests showing cases which were failing before (test34,35,36) 08 August 2016, 19:19:40 UTC
b87a4aa BidirMMapPipe: undo inadvertent change in unit test code 07 August 2016, 12:05:22 UTC
abc427f BidirMMapPipe: silence message about mmapping strategy by default Since this class has been used for quite some time now without major trouble, it doesn't seem imprudent to hide the status messages about the mmapping strategy by default. Since I have had requests to that end, this is what I do with this commit. BidirMMapPipe gets two static methods which allow toggling the message back on if the user so wishes. 05 August 2016, 12:16:48 UTC
34c331d RooMappedCategory: speed up evaluation This patch introduces a cache for index codes into RooMappedCategory. The previous implementation had to do a regex match on the different category labels, leading to slow evaluation. We now keep a cache indexed by the input category's index code, leading to a significant speedup. The persistent data format of the class remains unchanged, therefore the class version number was not changed. Backports to the various ROOT 6 and ROOT 5 bugfix branches may be in order. 04 August 2016, 15:56:55 UTC
57a5402 RooDataSet: avoid crash with ImportFromFile("path/to/file.root","treename") In the RooDataSet constructor, the wrong TTree pointer was picked up when the code is supposed to read from an external ROOT file, causing a crash. This code fixes the null pointer deference by picking up the right TTree pointer. Backports to the ROOT 6 and ROOT 5 bugfix branches may be in order. 04 August 2016, 15:52:33 UTC
5d055aa Don't internally rely on global state changes to prevent TF1 add to global list. Doing so (without putting a lock around the whole section that update back and forth the global state or using thread local global state) will result in randomly wrong behavior if the code is used from multiple thread. Instead, add a direct parameter to the TF1 constructor (similar to the one in TFormula) that explicit the wanted behavior. 27 July 2016, 20:08:44 UTC
be067b5 Fix for ROOT-8293 - CMake does not find Castor libraries 26 July 2016, 06:38:50 UTC
6832343 Fix for ROOT-8239 - "python: free(): invalid next size (fast)" in PyROOT 6.06.02 and patches 25 July 2016, 21:12:30 UTC
f5bc345 Make the TFormula::kIsNotGlobal bit public. Fix method TF1::AddToGlobalList and add also a default method TF1::DefaultAddToGlobalList. Use TF1::DefaultAddToGlobalList in TLinearMinimizer::SetFunction This fixes ROOT-8089 25 July 2016, 20:06:35 UTC
bc56c41 Fix for memory leaks in TLInearMinimizer-TVirtualFitter. When calling SetBasisFunction the function list must be owner, while in case of SetFormula the list should not be owner 25 July 2016, 20:04:59 UTC
01425d6 Remove leak in function fitting See https://root.cern.ch/phpBB3/viewtopic.php?f=3&t=21466 25 July 2016, 20:04:44 UTC
726d939 Match malloc with free (rather than delete) 25 July 2016, 20:04:31 UTC
3e3caaf Fix roottest/root/multicore/exectsinclude.C failure. 15 July 2016, 18:55:19 UTC
93e1f65 Adjust dictionary size downward for small baskets LZMA by default creates very large hash tables for its dictionaries, e.g., at compression level 4, the hash table is 4Mi 4 byte entries, 16 MiB total. The hash table has to be zeroed before use so it is allocated via calloc(), which means all the pages have to be allocated, mapped and written. ROOT baskets are often much smaller than the default LZMA dictionaries; for small baskets, the large dictionary has very little compression benefit, while zeroing the hash table can be more expensive than the actual compression operation. Since R__zipLZMA() is actually being used to compress a buffer of known size, not a stream, we can use the size of the buffer to estimate an appropriate size for the dictionary. This PR uses a slightly more advanced part of the LZMA API to set the dictionary size to 1/4 the size of the input buffer, if that is smaller than the default size from the selected preset compression level. In tests with CMS data, this results in less than 1% increase in the output size and (in one test job) a 25% reduction in job total run time, with LZMA compression time reduced by 80% (all of that time that was being spent in memset() zeroing the hash table). I also tested this with the "Event" test program with Brian's changes from #59. With the same test parameters as Brian ("./Event 4000 6 99 1 1000 2"), I get ZLIB level-6: 14.4 MB/s Original LZMA level-6: 2.3 MB/s Modified LZMA level-6: 3.0 MB/s With 100 tracks per event (and hence smaller baskets) the improvement is from 2.2 MB/s to 3.9 MB/s. This change should be fully transparent and backwards compatible. 15 July 2016, 14:52:12 UTC
19083e5 Fix for ROOT-8270 - C++14 15 July 2016, 06:39:45 UTC
2bb2f80 Further fixes for ROOT-8226 - CMake 3.5.2: circular dependency libMathMore 07 July 2016, 15:07:51 UTC
6b7c425 Better formatting of release notes 07 July 2016, 08:25:34 UTC
48e867a Update ROOT version files to v6.06/07. 06 July 2016, 17:08:44 UTC
f7d9d49 Update ROOT version files to v6.06/06. 06 July 2016, 16:36:49 UTC
b9c1d82 Updated the release notes. 06 July 2016, 16:21:03 UTC
eef786f Update release notes. 02 July 2016, 21:08:39 UTC
51e8158 Avoid autoparse looking for default constructor. 02 July 2016, 20:42:39 UTC
bdd08ad Do not insert macro definition of __ROOTCLING__ into the pch. 02 July 2016, 20:41:47 UTC
8e198a1 Check for new-style empty pcm with key named "EMPTY" created since commit 90047b0cba6fd295f5c5722749a0d043fbc11ea5. 02 July 2016, 20:40:18 UTC
35f6544 Avoid autoparse on IsForeign() if possible. 02 July 2016, 20:38:51 UTC
d26502f Do not autoparse headers for classes in the pch. 02 July 2016, 20:37:23 UTC
b26812b Fix for ROOT-8226 - CMake 3.5.2: circular dependency libMathMore. Including libraries is an idiom for CINT only. 26 June 2016, 02:14:11 UTC
0f2650e PyMVA: added support for python3 22 June 2016, 16:12:09 UTC
017b62b PyMVA: fixed warning from scikit-learn in data shape validation.py:386: DeprecationWarning: Passing 1d arrays as data is deprecated in 0.17 and willraise ValueError in 0.19. Reshape your data either using X.reshape(-1, 1) if your data has a single feature or X.reshape(1, -1) if it contains a single sample. 22 June 2016, 16:12:09 UTC
5fb3771 PyMVA:working in serialization to support python3 22 June 2016, 16:12:09 UTC
545e5a7 PyMVA: working in serialization 22 June 2016, 16:12:09 UTC
f0b4af2 Fix fatal typo 21 June 2016, 20:47:38 UTC
165fc69 Suppress warning about misleading indentation 21 June 2016, 20:35:00 UTC
cc28308 Suppress warning about misleading indentation 21 June 2016, 20:34:56 UTC
2c179cc Suppress warning about misleading indentation (and gain a tiny bit of run-time) 21 June 2016, 20:34:51 UTC
e6abd05 Fix wrong 'fixing' of misleading indentation 21 June 2016, 20:34:47 UTC
b2bec8b Suppress warning about misleading indentation 21 June 2016, 20:34:42 UTC
89d6441 Suppress warning about misleading indentation 21 June 2016, 20:34:36 UTC
4867ccb Suppress warning about misleading indentation 21 June 2016, 20:34:04 UTC
28c2edc Suppress warning about misleading indentation 21 June 2016, 20:33:46 UTC
de9c5bf Suppress warning about misleading indentation 21 June 2016, 20:33:35 UTC
24d32e1 Suppress warning about misleading indentation 21 June 2016, 20:33:31 UTC
d389662 Suppress warning about misleading indentation 21 June 2016, 20:33:17 UTC
d536eb8 Suppress warning about misleading indentation (and gain a tiny bit of run-time) 21 June 2016, 20:33:12 UTC
1fae2eb Avoid confusing/misleading code layout (were triggering misleading indentation warning) 21 June 2016, 20:33:07 UTC
4d4952b Fix incorrect indentation (revealed by 'misleading indentation warning') 21 June 2016, 20:33:02 UTC
c7bb1a6 Suppress warning about misleading indentation (and gain a tiny bit of run-time) 21 June 2016, 20:32:56 UTC
09f0e6b Fix misleading indentation. This was discovered by gcc 6's warning: .../root/math/matrix/src/TMatrixTBase.cxx: In member function ‘void TMatrixTBase<Element>::Print(Option_t*) const’: .../root/math/matrix/src/TMatrixTBase.cxx:877:10: error: this ‘for’ clause does not guard... [-Werror=misleading-indentation] for (Int_t j = sheet_counter; j < sheet_counter+cols_per_sheet && j <= ncols; j++) ^~~ .../root/math/matrix/src/TMatrixTBase.cxx:879:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’ printf("\n"); ^~~~~~ 21 June 2016, 20:32:35 UTC
69bcba3 Suppress warning about misleading indentation 21 June 2016, 20:28:10 UTC
back to top