Revision history - refs/heads/vksnk/c-print-type - origin: https://github.com/halide/Halide

visit type:

Newer
Older

Revision	Author	Date	Message	Commit Date
27ee253	Volodymyr Kysenko	17 March 2021, 21:24:04 UTC	Use print_type function when printing vector type definitions, which can be overridden in derived classes if needed.	17 March 2021, 21:24:04 UTC
b549d18	Steven Johnson	16 March 2021, 21:05:33 UTC	Grab-bag of minor fixes (#5813) * All TraceViz scripts should set pipefail (at least) * Use ".ldscript" for linker version scripts * More TraceViz fixes	16 March 2021, 21:05:33 UTC
e1c0fd3	Alex Reinking	16 March 2021, 20:19:05 UTC	Conform to CMP0116 when using CMake 3.20+ (#5810)	16 March 2021, 20:19:05 UTC
5aa1a65	Steven Johnson	16 March 2021, 03:16:33 UTC	Add Halide_CCACHE_BUILD option for CMake (#5804) * Add Halide_CCACHE_BUILD option for CMake This replicates the approach LLVM already has of baking a use-cache option directly into the CMake options, without having to futz with changing CC/CXX/etc. * Update CMakeLists.txt * Add CCACHE_SLOPPINESS=pch_defines,time_macros * Update CMakeLists.txt	16 March 2021, 03:16:33 UTC
b061a32	Dillon Sharlet	15 March 2021, 21:58:31 UTC	Avoid printing the statement when it is unchanged (#5809) * Only print statement if it changed. * Move simplification after unroll from lower to after unrolling a loop. * Avoid making new IR when not necessary. * Use a small helper class instead. * clang-format. Co-authored-by: Steven Johnson <srj@google.com>	15 March 2021, 21:58:31 UTC
c49b4af	Mike Woodworth	15 March 2021, 20:12:57 UTC	support building for m1 with only AARCH target (#5802) move test for ARM + metal to AARCH64 Co-authored-by: Steven Johnson <srj@google.com>	15 March 2021, 20:12:57 UTC
28c742f	Steven Johnson	15 March 2021, 19:21:36 UTC	Set CMAKE_CROSSCOMPILING_EMULATOR in toolchain.linux-arm32.cmake (#5808) Also add comments	15 March 2021, 19:21:36 UTC
d523b83	Steven Johnson	13 March 2021, 00:54:23 UTC	Fix deprecation warnings for trunk LLVM (#5803) (1) Both the 'deprecated' and new, non-deprecated variants existed back to at least LLVM10, and the deprecated variant was commented as deprecated at that point as well; the change in LLVM13 is that they are now annotated with LLVM_ATTRIBUTE_DEPRECATED so we get compiler warnings (and thus errors). (2) The fixes are simply replicating what the old, deprecated methods did internally.	13 March 2021, 00:54:23 UTC
c3882a5	Dillon Sharlet	11 March 2021, 23:14:36 UTC	Change warmup strategy for sliding window (#5755) * Implement sliding window warmups by backing up the loop min. * Fix indirect sliding windows. * Improve is_monotonic. * Small cleanups. * Avoid generating vector valued bounds. * Fix build error on some compilers. * Fix loop bounds. * Don't try to slide things that should just be compute_at the store_at location. * Print condition when printing boxes. * Less things broken. * Add/fix comments. * Comments * Fix async by moving if inside consume (and so inside acquires). * Fix division. * This doesn't work on master either. * Add TODO * Acquire is not a no-op. * Add comment about unfortunate simplification. * Remove debug(0) * Add simplification of for { acquire { noop } } * Fix folding factors finally! * Update storage_folding test. * Fix bug when cloning a semaphore used more than once. * Disable failing test. * Work around bad complexity in is_monotonic. * Fix sub bug * Significantly faster schedule for blur. * Update tracing test. * New simplifications that help with upsampled and downsampled sliding windows. * This doesn't need explicit folding any more. * Fix new simplifier rules. * Fix simplifier div rule * Remove ancient brittle test. * Fix simplify rule again * More LT -> EQ rules for mod * Fix nested sliding windows with upsamples. * Replace hack with better solution. * Add missing override * Don't rewrite loop variable if the min doesn't change. * Refactor sliding window lowering. * Fixed bounds growing redundantly for independent producers. * Don't take the union unless possibly needed. * Respect conditional provide/required. * Add missing overrides * Much better schedule. * Use a smaller image for blur benchmarking so that different schedules have different perf * Replace Interval with ConstantInterval for is_monotonic. * Don't try to handle unsigned deltas. * Add failing test. * Remove unused new code. * Remove weird debugging code. * Avoid expanding bounds of split producers * Remove stray likely_if_innermost. * Remove old autotune tests. * Update test for guarded producers. * Reenable test. * Update trace for guarding producers. * Don't overwrite required.used * Handle LE/LT in bounds of lanes in vectorize * Fix acquire and release of warmups * Earlier fix for multiply cloned acquires was wrong. * Handle nested vectorization. * clang-format * Remove autotune_bug_* tests * Fix shadowing error on some compilers. * Appease overzealous clang-tidy warning. * clang-format * Don't use silly hack. * clang-tidy... * It's no longer safe to assume monotonic means bounds_of_expr_in_scope is exact * Address review comments * Add comment * Add missing override. * Fix constant interval issues. * Revert and remove empty interval * Fix multiply!? * Reduce need for simplifications. * Simplifications from dsharletg/sliding-window branch * Don't learn likely(x) and x. * Add comment * Add some min/max rules. * Also substitute facts from asserts * Remove is_empty from header too. * More rules * Add double stairstep rule. * Disable rule that uncovers bugs. * Consider anded expressions as if they were independent nested ifs. * Add promise_clamped to producer guards. * Revert "Consider anded expressions as if they were independent nested ifs." This reverts commit 03efb3f784b3078b64961c98edde383f4de04fb4. * Don't combine ifs, split them instead. * Update trace * clang-tidy/clang-format * Remove splitting of ifs, it breaks brittle tests. * Safer check on old conditions. * Fix producer guard condition. * Interval fixes. * Handle sliding backwards * Handle transitive dependencies. * Backport abadams' fix from abadams/slide_over_split_loop * Fix select visitor. * More simplifier rules. * Bring back old logic as a fallback. * Avoid specializations corrupting sliding * Fix boneheaded rule errors. * Fix slightly conservative bounds at the max for split case. * This pattern is too sensitive to the simplifier. In a real use case, it's just a sum, and the result can be subtracted after doing a reduction. * Add missing clamp rule * Don't count unlikely loops as inner loops for likely_if_innermost * Use <= instead of == to solve for the new loop min Useful when the warmup is a partial vector or something * Verify simplifier changes and add variants as suggested by synthesizer * Make implicit assumption explicit, for clarity * Use find_constant_bounds * Guard against expanded bounds more effectively. * Update tracing test * Small cleanup. * Don't simplify/prove using lets that might change value. * Stronger solving without expanding lets. * New simplifier rule for alignment * Fix case where no warmup needed * Add some useful rules. * Add safety check on when we can use the new loop min. * Better proof to avoid hacky condition that is hard to prove. * Small cleanup and use the nice new folding factors. * Bring back unrolled producer test. * clang-format * Expand comment. * Fix sliding backwards condition. * min(new_loop_min, loop_min) isn't needed any more. * We need that min, but we can be more conservative about it. * Stronger handling of previous loop mins. * Remove unused is_monotonic_strong. * Remove ConstantInterval::make_intersection. * Avoid need to handle uint specially. * Add cache for depends_on. * Reduce unnecessarily large cache scope * The first part of the key is always the same Co-authored-by: Andrew Adams <andrew.b.adams@gmail.com>	11 March 2021, 23:14:36 UTC
c2a0db1	Steven Johnson	10 March 2021, 23:39:27 UTC	Fix correctness_memoize on arm32 (#5799) Conversion from a pointer to an integer is "implementation defined"; in general, conversion to `uintptr_t` is reliable, but other conversions aren't. It turns out that for our arm32 compiler, casting a pointer to a `uint64_t` sign-extends, rather than zero-extends, causing unexpected behavior in memoize cache eviction if the pointer is in the top half of memory. The fix here is simple (cast to `uintptr_t` directly), but it brings up the question of where else in our codebase we might be doing direct conversions elsewhere in our code without noticing the potential UB.	10 March 2021, 23:39:27 UTC
7a8c771	Steven Johnson	10 March 2021, 22:53:40 UTC	Fix wasm-interp ucon error (#5797) This is a subtle error that only shows up in builds with assertions enabled in wabt; the issue is that we ask for an int64 value from a wabt `Value` struct, but that struct only has an int32, so an assertion can fail. (Note that there is always storage for both, and the values are constrained and unused inside the JIT anyway, so this is mostly just a cosmetic fix.) Also added a .gitignore entry.	10 March 2021, 22:53:40 UTC
34c402f	Dillon Sharlet	10 March 2021, 21:54:51 UTC	Fix bug found by asan from #5784 (#5798)	10 March 2021, 21:54:51 UTC
c67f486	John Lawson	10 March 2021, 18:51:33 UTC	Move where intrinsic function attributes are set (#5795) * Make declare_intrin_overload return LLVM function * Make names same as elsewhere * Remove unneeded enum name * Set moved attributes in Hexagon backend * Use declare_intrin_overload for ARM vabdl * Fix ARM vabdl intrinsic types * Format and clang-tidy * Rename intrinsic to widening_absd	10 March 2021, 18:51:33 UTC
78ff307	Lars	10 March 2021, 18:35:50 UTC	Display the GPU device code as a string in the C/C++ backend (#5757) * Added support for a OpenCL backend through the C backend No correctly handles assert of kernel call Fixed clang-formatter Clang-tidy fixes * Remove references to alternative OpenclHost code * Only initialize GPU context once (removes name conflicts) squash commit * (Pretty) Print the kernels in the C backend clang formatting remove virtual * Fixes after review fixes after review 2.0 fixes	10 March 2021, 18:35:50 UTC
e75d9fb	Dillon Sharlet	09 March 2021, 22:16:21 UTC	Fix out of bounds reads in strided ARM loads (#5784) * Safer version of vldN code generation. * Only be more conservative with alignment for external buffers. * Add tolerance to allocation size tests. * Remove old comments. * Improve ARM alignment and vldN code generation. * Remove merge straggler * Fix alignment condition (again). * Fix alignment. * Avoid divide by zero. * Move CodeGen_ARM's logic for strided loads to CodeGen_LLVM. * Fix comment. * clang-format. * Remove sketchy alignment check.	09 March 2021, 22:16:21 UTC
a83ab23	Dillon Sharlet	08 March 2021, 19:24:07 UTC	Simplifier rules for nested broadcasts (#5794) * Handle some reassociation when simplifying nested broadcasts. * clang-format.	08 March 2021, 19:24:07 UTC
89f5ee7	Andrew Adams	05 March 2021, 20:00:57 UTC	Add missing min/max/+/- rules (#5788) These are almost all of the rules in <= four in terms of min/max/add/sub ops leaves that simplify to something with <= three leaves. I left out things of the form: max(max(x, -x), 0) -> max(x - x) While correct, that transformation actually hurts our ability to analyze that expression.	05 March 2021, 20:00:57 UTC
199b873	Steven Johnson	05 March 2021, 17:45:48 UTC	Upgrade WABT version to 1.0.21 (#5782)	05 March 2021, 17:45:48 UTC
06b208f	Dillon Sharlet	04 March 2021, 18:11:57 UTC	Move codegen backends into anonymous namespaces in source files and don't build them if not enabled (#5776) * Remove unused vertex buffer parameters. * Offload GPU code in a lowering pass instead of via CodeGen_GPU_Host. Fixes #5650, fixes #2797, fixes #2084, now #1971 is more relevant. * clang-format. * clang-format sorting is case sensitive!? * clang-tidy * Move codegen backends into anonymous namespaces in source files. * clang-format * Pass type arguments correctly. * Update OffloadGPULoops.cpp * trigger buildbots * trigger buildbots * Hack around tests that rely on the IR for offloaded GPU loops. * Fix missing include. * Remove unused include. * clang-tidy * Use custom lowering pass to see code before GPU offloading * Speculative fix for segfault * Fix const correctness * Fix error on unused variables in generated code. Co-authored-by: Steven Johnson <srj@google.com>	04 March 2021, 18:11:57 UTC
abf0f69	cimes-isi	04 March 2021, 08:16:21 UTC	cmake: respect find_package QUIET option (#5785) Co-authored-by: Steven Johnson <srj@google.com>	04 March 2021, 08:16:21 UTC
a0c5380	Andrew Adams	04 March 2021, 06:29:04 UTC	Fixes for macos on arm (#5787) * Remove type checking on ARM-64 instructions in simd op check * Makefile fixes for M1 * Don't assume OSX is x86 * Change xml2 linking flag * M1 has a really fast div instruction	04 March 2021, 06:29:04 UTC
74f40fd	Andrew Adams	03 March 2021, 20:26:03 UTC	Track time spent in malloc/free when profiling (#5763) * Track time spent in malloc/free when profiling * Appease clang tidy * Remove unnecessary asserts	03 March 2021, 20:26:03 UTC
acebd50	Dillon Sharlet	03 March 2021, 20:14:29 UTC	Various simplifier improvements from dsharletg/sliding-window (#5771) * Pull simplifier changes from dsharletg/sliding-window * Bring over test changes too. * Fix typo * Remove done TODO. * trigger buildbots * This pattern is too sensitive to the simplifier. In a real use case, it's just a sum, and the result can be subtracted after doing a reduction. Co-authored-by: Steven Johnson <srj@google.com>	03 March 2021, 20:14:29 UTC
5da8044	Dillon Sharlet	03 March 2021, 20:14:11 UTC	Various bug fixes and improvements from dsharletg/sliding-window (#5772) * Fix bug when a semaphore is cloned more than once. * (Originally by abadams) Don't count unlikely loops as inner loops for likely_if_innermost. * Ignore promise_clamped when solving. * Acquires are not no-ops. * Fix test name * Handle nested vectors in bounds_of_lanes and (by abadams) Handle LE/LT in bounds of lanes in vectorize * Fix test name. * Allow any level of nested vectorization. * trigger buildbots * Grammar Co-authored-by: Steven Johnson <srj@google.com>	03 March 2021, 20:14:11 UTC
7493c09	Dillon Sharlet	02 March 2021, 21:07:14 UTC	Move CodeGen_GPU_Host to a lowering pass (#5775) * Remove unused vertex buffer parameters. * Offload GPU code in a lowering pass instead of via CodeGen_GPU_Host. Fixes #5650, fixes #2797, fixes #2084, now #1971 is more relevant. * clang-format. * clang-format sorting is case sensitive!? * clang-tidy * Pass type arguments correctly. * Update OffloadGPULoops.cpp * trigger buildbots * Hack around tests that rely on the IR for offloaded GPU loops. * clang-tidy * Use custom lowering pass to see code before GPU offloading * Speculative fix for segfault * Fix const correctness * Fix error on unused variables in generated code. * Remove unnecessary space * Use helper. Co-authored-by: Steven Johnson <srj@google.com>	02 March 2021, 21:07:14 UTC
01f5e73	Steven Johnson	02 March 2021, 18:06:11 UTC	Update simd_op_check for the final wasm simd128 spec (#5779) The final revision of the wasm simd128 spec (https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md) added some ops and tweaked some others. This just augments the wasm section of simd_op_check so that all the ops are referenced, with the new (or still-unimplemented) ops commented out with TODOs. Most of the new ops will likely be implemented via pattern matching in Codegen_WebAssembly, but before that can happen in any efficient way, WABT needs to be updated to recognize all the ops in the final spec (it doesn't currently, and so we can't even load code with those ops without cratering). See https://github.com/WebAssembly/wabt/issues/1617 for tracking bug. (Also: drive-by fix in CodegenLLVM to fix prettyprinting of some debug output)	02 March 2021, 18:06:11 UTC
47d0594	Steven Johnson	28 February 2021, 19:35:27 UTC	Fix for trunk LLVM (#5778)	28 February 2021, 19:35:27 UTC
fdfb393	Steven Johnson	26 February 2021, 18:05:34 UTC	Fix for trunk LLVM (#5774)	26 February 2021, 18:05:34 UTC
d48fbde	Steven Johnson	25 February 2021, 00:35:34 UTC	Fix for top-of-tree LLVM (#5768) * Fix for top-of-tree LLVM * oops	25 February 2021, 00:35:34 UTC
6bf0c0a	Steven Johnson	25 February 2021, 00:35:15 UTC	Fix autoscheduler breakage from #5766 (Fix #5769) (#5770)	25 February 2021, 00:35:15 UTC
14bab78	Steven Johnson	24 February 2021, 19:14:54 UTC	Constrain calling convention for PyStub (#5761) There are two calling conventions that are sensible when calling a Generator from Python: - Inputs are specified via keyword arguments (verbose but more readable) - Inputs are specified via positional arguments (terse but more like C++) However, the current PyStub implementation also allows for mixing positional and keyword forms of input (as long as no input is specified multiple times). This change removes that possibility (requiring either all-keyword or all-positional for inputs). I'm not sure why I thought this was a good option originally, but upon reflection (and examination of existing code), calls written in this way tend to be a confusing mess that require too much care when reading, and I think we'd be better off just forbidding this entirely. Note that this technically is a breaking API change; any user code that used this technique previously would now throw an exception and need a (trivial) update. That said, this is (AFAIK) a very rarely used API, and I rather suspect that existing code that relies on being able to mix positional and keyword inputs in this way is likely to be doing so inadvertently rather than deliberately.	24 February 2021, 19:14:54 UTC
1be92c2	Steven Johnson	23 February 2021, 00:27:18 UTC	Grab-bag of minor Generator-related cleanups (#5766) * Grab-bag of minor Generator-related cleanups * Appease clang-tidy; rename local 'cerr' * Update PyStubImpl.cpp * Update PyStub.cpp * appease clang-tidy	23 February 2021, 00:27:18 UTC
a6ba311	Steven Johnson	22 February 2021, 23:26:13 UTC	Ensure that PyStub handles dynamically-added inputs and outputs, and add test for it (#5760)	22 February 2021, 23:26:13 UTC
b7da2df	ShihPo Hung	22 February 2021, 18:20:38 UTC	Fix misspelling of an ABI name (#5764) named ABIs are defined in https://github.com/riscv/riscv-elf-psabi-doc/blob/master/riscv-elf.md#named-abis	22 February 2021, 18:20:38 UTC
4394fa2	Andrew Adams	21 February 2021, 20:19:05 UTC	Fix a few warnings from lgtm.com (#5765)	21 February 2021, 20:19:05 UTC
5545e61	ShihPo Hung	19 February 2021, 18:03:40 UTC	Add initial support for RISCV RVV features (#5758) 1. `mabi` is introduced because target triple doesn't encode ABI info. 2. Use "+m,+a,+f,+d,+c" as default RISCV mattrs if it is not explicitly speicified. It is equivalent to "rv[32\|64]gc" configuration. 3. HL_LLVM_ARGS="-riscv-v-vector-bits-min 128" is required to enable fixed-length vectors to RVV codegen.	19 February 2021, 18:03:40 UTC
a0fde42	Steven Johnson	17 February 2021, 22:48:03 UTC	Eradicate reinterpret() from runtime_internal.h (#5748) * Eradicate reinterpret() from runtime_internal.h The reinterpret<>() function in runtime_internal.h is dangerous and should not be allowed to exist: it copies from one type to another, copying the minimum of the two sizes, but with no allowance for ensuring that any "extra" bits in the destination are filled in with, well, anything. I have no evidence of a bug specifically caused by this, but a usage such as `reinterpret<uint64>t>(some_ptr)` on a 32-bit runtime will leave the upper 32 bits of the result undefined. Maybe they'll never get used, but this function is a bug waiting to happen. Fortunately, the only usages of this evil thing are all in hexagon_host.cpp, and all are used to convert between a uint64_t and an ion_device_handle* (which is sometimes represented as a void*). Replacing the handful of usages with bespoke functions to do these conversions seems much safer.	17 February 2021, 22:48:03 UTC
be8c727	Steven Johnson	17 February 2021, 22:16:39 UTC	Enable bugprone-macro-parentheses in clang-tidy, adding parens or annotating exceptions with NOLINT where necessary. (#5749)	17 February 2021, 22:16:39 UTC
75f2da2	Steven Johnson	17 February 2021, 22:16:31 UTC	Enable bugprone-incorrect-roundings for clang-tidy (#5750) * Enable bugprone-incorrect-roundings for clang-tidy, and fix the offending code. * Fix * lround -> llround in a couple of places	17 February 2021, 22:16:31 UTC
df28da9	Andrew Adams	17 February 2021, 18:58:29 UTC	Allow device copies inside a loop (#5741) Enable schedules that do device copies inside loops inside the compute_at location, for example due to sliding windows.	17 February 2021, 18:58:29 UTC