Skip to main content

Browse the archive

https://github.com/tendermint/tendermint
14 June 2024, 18:32:29 UTC
sort by:
Revision Author Date Message Commit Date
3c3089f William Banfield 07 January 2022, 19:16:42 UTC fixups from retrying 07 January 2022, 19:16:42 UTC
f629b61 William Banfield 07 January 2022, 18:40:00 UTC add crash description 07 January 2022, 18:40:00 UTC
5b51d8a William Banfield 07 January 2022, 18:21:36 UTC Merge remote-tracking branch 'origin/wb/builtin-tutorial-fixup' into wb/builtin-tutorial-fixup 07 January 2022, 18:21:36 UTC
822ea05 William Banfield 07 January 2022, 18:19:39 UTC add documentation link 07 January 2022, 18:19:39 UTC
47edfbe William Banfield 07 January 2022, 18:14:41 UTC Apply suggestions from code review Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 07 January 2022, 18:14:41 UTC
0d44fc4 William Banfield 07 January 2022, 00:00:19 UTC fix copy+paste mistakes 07 January 2022, 00:00:19 UTC
5f93bd4 William Banfield 06 January 2022, 23:50:02 UTC check db close error 06 January 2022, 23:50:02 UTC
13f7af1 William Banfield 06 January 2022, 23:47:13 UTC link fix 06 January 2022, 23:47:13 UTC
425c6a0 William Banfield 06 January 2022, 23:45:47 UTC language fix 06 January 2022, 23:45:47 UTC
bf147c2 William Banfield 06 January 2022, 23:40:42 UTC add intuitin about checktx -> delivertx validity 06 January 2022, 23:40:42 UTC
3854f3b William Banfield 06 January 2022, 23:35:58 UTC more explanation to checktx per review feedback 06 January 2022, 23:35:58 UTC
28cf6fc William Banfield 06 January 2022, 23:33:43 UTC remove superfluous 0 check and add bytes to import 06 January 2022, 23:33:43 UTC
bdc3ea2 William Banfield 06 January 2022, 23:21:31 UTC finalize code description 06 January 2022, 23:21:31 UTC
c52de25 William Banfield 06 January 2022, 21:17:35 UTC wip 06 January 2022, 21:17:35 UTC
f78acf2 William Banfield 06 January 2022, 20:37:53 UTC pr feedback 06 January 2022, 20:37:53 UTC
557b860 William Banfield 06 January 2022, 20:36:47 UTC pr feedback 06 January 2022, 20:36:47 UTC
4845044 William Banfield 06 January 2022, 14:38:24 UTC cr feedback 06 January 2022, 14:38:24 UTC
17a214b William Banfield 06 January 2022, 00:05:27 UTC Apply suggestions from code review Co-authored-by: M. J. Fromberger <fromberger@interchain.io> Co-authored-by: Sergio Mena <sergio@informal.systems> 06 January 2022, 00:05:27 UTC
7241c2c William Banfield 05 January 2022, 23:35:53 UTC Update docs/tutorials/go-built-in.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 05 January 2022, 23:35:53 UTC
d081283 William Banfield 22 December 2021, 23:27:15 UTC builtin-tutorial-fixup 22 December 2021, 23:27:15 UTC
d3abe15 dependabot[bot] 17 December 2021, 17:15:46 UTC build(deps): Bump github.com/spf13/viper from 1.10.0 to 1.10.1 (#7468) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.10.0 to 1.10.1. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](https://github.com/spf13/viper/compare/v1.10.0...v1.10.1) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 17 December 2021, 17:15:46 UTC
44afb4f dependabot[bot] 17 December 2021, 13:25:10 UTC build(deps): Bump github.com/rs/zerolog from 1.26.0 to 1.26.1 (#7467) Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.26.0 to 1.26.1. - [Release notes](https://github.com/rs/zerolog/releases) - [Commits](https://github.com/rs/zerolog/compare/v1.26.0...v1.26.1) --- updated-dependencies: - dependency-name: github.com/rs/zerolog dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 17 December 2021, 13:25:10 UTC
ca85780 dependabot[bot] 15 December 2021, 17:25:19 UTC build(deps): Bump github.com/spf13/cobra from 1.2.1 to 1.3.0 (#7457) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.2.1 to 1.3.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](https://github.com/spf13/cobra/compare/v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 15 December 2021, 17:25:19 UTC
08bf5db dependabot[bot] 15 December 2021, 16:07:49 UTC build(deps): Bump google.golang.org/grpc from 1.42.0 to 1.43.0 (#7458) * build(deps): Bump google.golang.org/grpc from 1.42.0 to 1.43.0 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.42.0 to 1.43.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.42.0...v1.43.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fix deprecated usage. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 15 December 2021, 16:07:49 UTC
8bbec93 mergify[bot] 14 December 2021, 08:30:32 UTC Fix broken documentation link. (#7439) (#7440) A follow-up to #7416 and #7412. (cherry picked from commit a872dd75b7d77ccba02a885f77bd4fc123200bd4) Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 14 December 2021, 08:30:32 UTC
8bcec21 dependabot[bot] 13 December 2021, 14:23:50 UTC build(deps): Bump github.com/adlio/schema from 1.2.2 to 1.2.3 (#7436) Bumps [github.com/adlio/schema](https://github.com/adlio/schema) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/adlio/schema/releases) - [Commits](https://github.com/adlio/schema/compare/v1.2.2...v1.2.3) --- updated-dependencies: - dependency-name: github.com/adlio/schema dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 13 December 2021, 14:23:50 UTC
540aea1 dependabot[bot] 13 December 2021, 13:47:22 UTC build(deps): Bump github.com/spf13/viper from 1.9.0 to 1.10.0 (#7435) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](https://github.com/spf13/viper/compare/v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 13 December 2021, 13:47:22 UTC
22b0b67 dependabot[bot] 10 December 2021, 19:34:26 UTC build(deps): Bump github.com/adlio/schema from 1.1.15 to 1.2.2 (#7422) * build(deps): Bump github.com/adlio/schema from 1.1.15 to 1.2.2 Bumps [github.com/adlio/schema](https://github.com/adlio/schema) from 1.1.15 to 1.2.2. - [Release notes](https://github.com/adlio/schema/releases) - [Commits](https://github.com/adlio/schema/compare/v1.1.15...v1.2.2) --- updated-dependencies: - dependency-name: github.com/adlio/schema dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Work around API changes in the migrator package. A recent update inadvertently broke the API by changing the receiver types of the methods without updating the constructor. See: https://github.com/adlio/schema/issues/13 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 10 December 2021, 19:34:26 UTC
1919a93 mergify[bot] 10 December 2021, 18:05:26 UTC internal/libs/protoio: optimize MarshalDelimited by plain byteslice allocations+sync.Pool (#7325) (#7426) Noticed in profiles that invoking *VoteSignBytes always created a bytes.Buffer, then discarded it inside protoio.MarshalDelimited. I dug further and examined the call paths and noticed that we unconditionally create the bytes.Buffer, even though we might have proto messages (in the common case) that implement MarshalTo([]byte), and invoked varintWriter. Instead by inlining this case, we skip a bunch of allocations and CPU cycles, which then reflects properly on all calling functions. Here are the benchmark results: ```shell $ benchstat before.txt after.txt name old time/op new time/op delta types.VoteSignBytes-8 705ns ± 3% 573ns ± 6% -18.74% (p=0.000 n=18+20) types.CommitVoteSignBytes-8 8.15µs ± 9% 6.81µs ± 4% -16.51% (p=0.000 n=20+19) protoio.MarshalDelimitedWithMarshalTo-8 788ns ± 8% 772ns ± 3% -2.01% (p=0.050 n=20+20) protoio.MarshalDelimitedNoMarshalTo-8 989ns ± 4% 845ns ± 2% -14.51% (p=0.000 n=20+18) name old alloc/op new alloc/op delta types.VoteSignBytes-8 792B ± 0% 600B ± 0% -24.24% (p=0.000 n=20+20) types.CommitVoteSignBytes-8 9.52kB ± 0% 7.60kB ± 0% -20.17% (p=0.000 n=20+20) protoio.MarshalDelimitedNoMarshalTo-8 808B ± 0% 440B ± 0% -45.54% (p=0.000 n=20+20) name old allocs/op new allocs/op delta types.VoteSignBytes-8 13.0 ± 0% 10.0 ± 0% -23.08% (p=0.000 n=20+20) types.CommitVoteSignBytes-8 140 ± 0% 110 ± 0% -21.43% (p=0.000 n=20+20) protoio.MarshalDelimitedNoMarshalTo-8 10.0 ± 0% 7.0 ± 0% -30.00% (p=0.000 n=20+20) ``` Thanks to Tharsis who tasked me to help them increase TPS and who are keen on improving Tendermint and efficiency. (cherry picked from commit 3e92899bd917a624fa0d3aca5c1fe7109fe5adab) Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> 10 December 2021, 18:05:26 UTC
ed164e4 mergify[bot] 09 December 2021, 16:21:58 UTC Fix links to Terraform/Ansible documentation. (backport #7416) (#7417) * Fix link to Terraform/Ansible documentation. (#7416) (cherry picked from commit f79b77036f6da66db06a866e4e01e17ce749808e) 09 December 2021, 16:21:58 UTC
cd7d91c dependabot[bot] 08 December 2021, 14:03:24 UTC build(deps): Bump github.com/adlio/schema from 1.1.14 to 1.1.15 (#7406) Bumps [github.com/adlio/schema](https://github.com/adlio/schema) from 1.1.14 to 1.1.15. - [Release notes](https://github.com/adlio/schema/releases) - [Commits](https://github.com/adlio/schema/compare/v1.1.14...v1.1.15) --- updated-dependencies: - dependency-name: github.com/adlio/schema dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 08 December 2021, 14:03:24 UTC
c6fadc1 mergify[bot] 08 December 2021, 11:09:47 UTC cmd: cosmetic changes for errors and print statements (#7377) (#7408) 08 December 2021, 11:09:47 UTC
0b3764e mergify[bot] 07 December 2021, 15:57:58 UTC ci: skip docker image builds during PRs (#7397) (#7398) (cherry picked from commit 0b3e00a6b574db95b5e0f7c93ad3516d3eea42ee) Co-authored-by: Sam Kleinman <garen@tychoish.com> 07 December 2021, 15:57:58 UTC
ab7de40 mergify[bot] 07 December 2021, 15:39:52 UTC ci: cleanup build/test targets (backport #7393) (#7395) 07 December 2021, 15:39:52 UTC
df47c41 mergify[bot] 06 December 2021, 21:34:05 UTC Update Mergify configuration. (backport #7388) (#7390) Per https://docs.mergify.com/actions/merge/#commit-message, the commit_message option is deprecated and will be removed in 2022. Replace it with the template suggested here: https://docs.mergify.com/actions/queue/ (cherry picked from commit 02d456b8b8274088e8d3c6e1714263a47ffe13ac) 06 December 2021, 21:34:05 UTC
ec2361e mergify[bot] 06 December 2021, 20:42:33 UTC Update mergify configuration. (backport #7385) (#7387) Per https://blog.mergify.com/strict-mode-deprecation/, the strict mode has been deprecated and will be turned off on 10-Jan-2022. This updates the config to use the new, approved thing instead of the old thing. (cherry picked from commit 2d4844f97f804149aa6dd47bcf957c1de9eaf6ea) 06 December 2021, 20:42:33 UTC
9978a3c Sam Kleinman 02 December 2021, 22:25:13 UTC ci: move test execution to makefile (#7372) (#7374) (cherry picked from commit b3be1d7d7a1e5c8fef96e964c52aa1a3b502f734) 02 December 2021, 22:25:13 UTC
b4396d7 mergify[bot] 02 December 2021, 13:13:48 UTC rpc: implement header and header_by_hash queries (backport #7270) (#7367) 02 December 2021, 13:13:48 UTC
a3021be Sam Kleinman 01 December 2021, 21:22:17 UTC e2e: limit legacyp2p and statesyncp2p (#7361) 01 December 2021, 21:22:17 UTC
657afc7 mergify[bot] 30 November 2021, 22:01:51 UTC Remove now-unused nolint:lll directives. (backport #7356) (#7358) (cherry picked from commit 76dea94a015d02e507538e8314b3b983d6adf3b0) Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 30 November 2021, 22:01:51 UTC
4bc36c8 Sam Kleinman 30 November 2021, 21:42:01 UTC e2e: app hash test cleanup (0.35 backport) (#7350) 30 November 2021, 21:42:01 UTC
260f425 mergify[bot] 30 November 2021, 21:39:07 UTC Fix incorrect tests using the PSQL sink. (backport #7349) (#7355) Some of our tests were creating a psql event sink and expecting it to report (or not report) certain kinds of errors. These tests were ill-founded in a couple of ways: 1. Tests that required the Postgres driver were not loading it. This led to spurious successes on tests that wanted "some error" from the sink constructor, but didn't exercise the right path. 2. Tests that wanted a Postgres sink to succeed without a database. These tests "passed" because they weren't actually establishing a connection to the database, but if they had would have failed for the lack of one. To fix this: - Load the postgres driver in tests that need it. - Verify connectivity before reporting successful creation of a PSQL event sink. - Remove tests that wanted a psql sink without a database, since that case is already tested elsewhere. (cherry picked from commit ab1788b922e9909a0fbc4a7680c7e73b8c6ed5b0) 30 November 2021, 21:39:07 UTC
44c8b41 mergify[bot] 30 November 2021, 21:36:56 UTC lint: remove lll check (#7346) (#7357) (cherry picked from commit 502f92bb97c9dd4475f732f28ae9c9afe9145d48) Co-authored-by: Sam Kleinman <garen@tychoish.com> 30 November 2021, 21:36:56 UTC
bd5a742 mergify[bot] 30 November 2021, 20:52:42 UTC e2e: generate keys for more stable load (#7344) (#7353) (cherry picked from commit babd3acb7018e12c2e10a3b69eb6ac712ce1bf28) Co-authored-by: Sam Kleinman <garen@tychoish.com> 30 November 2021, 20:52:42 UTC
1511030 mergify[bot] 30 November 2021, 20:16:38 UTC e2e: clarify apphash reporting (#7348) (#7352) (cherry picked from commit 24dcba923046bbc7fb558bee5920fcb02f3c457b) Co-authored-by: Sam Kleinman <garen@tychoish.com> 30 November 2021, 20:16:38 UTC
ebe5796 mergify[bot] 30 November 2021, 19:53:40 UTC e2e: stabilize validator update form (#7340) (#7351) This might be a source of non-determinism in the e2e test. (cherry picked from commit c4033f95c168094c6af0667465f58a2f5d367407) Co-authored-by: Sam Kleinman <garen@tychoish.com> 30 November 2021, 19:53:40 UTC
7bf7ff6 William Banfield 30 November 2021, 15:48:07 UTC internal/proxy: add initial set of abci metrics backport (#7342) * internal/proxy: add initial set of abci metrics (#7115) This PR adds an initial set of metrics for use ABCI. The initial metrics enable the calculation of timing histograms and call counts for each of the ABCI methods. The metrics are also labeled as either 'sync' or 'async' to determine if the method call was performed using ABCI's `*Async` methods. An example of these metrics is included here for reference: ``` tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.0001"} 0 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.0004"} 5 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.002"} 12 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.009"} 13 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.02"} 13 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.1"} 13 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.65"} 13 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="2"} 13 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="6"} 13 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="25"} 13 tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="+Inf"} 13 tendermint_abci_connection_method_timing_sum{chain_id="ci",method="commit",type="sync"} 0.007802058000000001 tendermint_abci_connection_method_timing_count{chain_id="ci",method="commit",type="sync"} 13 ``` These metrics can easily be graphed using prometheus's `histogram_quantile(...)` method to pick out a particular quantile to graph or examine. I chose buckets that were somewhat of an estimate of expected range of times for ABCI operations. They start at .0001 seconds and range to 25 seconds. The hope is that this range captures enough possible times to be useful for us and operators. * lint++ * docs: add abci timing metrics to the metrics docs (#7311) * cherry-pick fixup 30 November 2021, 15:48:07 UTC
1c1ce83 M. J. Fromberger 30 November 2021, 14:23:27 UTC Performance improvements for the event query API (#7338) A manual backport of #7319 and #7336. 30 November 2021, 14:23:27 UTC
3e41def mergify[bot] 27 November 2021, 17:27:16 UTC docs: go tutorial fixed for 0.35.0 version (#7329) (#7330) (#7331) (cherry picked from commit a36dd49eae474e2b07b8c982e2a2ee28c152f126) Co-authored-by: Piotr Pędziwiatr <84311757+ppedziwiatr@users.noreply.github.com> 27 November 2021, 17:27:16 UTC
333d7f7 mergify[bot] 25 November 2021, 16:33:07 UTC Update example code in OpenAPI docs. (#7318) (#7322) The event examples for the query filter language were not updated after the change of key and value types from []byte to string. Also, the attributes need to be a slice not a bare value. (cherry picked from commit da3449599f1306e2d36a6d4f5e0c9eaad01e4e44) Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 25 November 2021, 16:33:07 UTC
778be06 M. J. Fromberger 23 November 2021, 20:26:22 UTC pubsub: Report a non-nil error when shutting down. (#7310) If a subscriber arrives while the pubsub service is shutting down, the existing code will return a nil subscription without error. With unlucky timing, this may lead to a nil indirection panic in the RPC service. To avoid that problem, make sure that when a subscription fails for this reason, we report a non-nil error so that the client will detect it and give up gracefully. 23 November 2021, 20:26:22 UTC
a97b081 M. J. Fromberger 22 November 2021, 20:03:24 UTC Partial backport of protobuf generation changes. (#7302) This is a manual backport of the changes to how we build and run the protobuf toolchain images in Docker. The main effect here is to point to the new image from ghcr.io/tendermint/docker-proto-builder, but to make that work it is also necessary to update some of the branch pointers. This change does NOT include the changes from #7269 and #7291 to point to the proto files in the spec repo. To do that, we will need to create a branch or tag on the spec that has the released version, which does not exist in the spec history as it currently stands. 22 November 2021, 20:03:24 UTC
b506801 dependabot[bot] 16 November 2021, 16:29:09 UTC build(deps): Bump github.com/tendermint/tm-db from 0.6.4 to 0.6.6 (#7285) 16 November 2021, 16:29:09 UTC
97f888e mergify[bot] 15 November 2021, 04:46:18 UTC Add v0.35 to the configs for building the docs website. (#7055) (#7278) (cherry picked from commit b3b1279d1f4ce2a5e47bf175d30e2800b2ef07af) Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 15 November 2021, 04:46:18 UTC
035da42 Thane Thomson 13 November 2021, 21:48:45 UTC rpc: backport experimental buffer size control parameters from #7230 (tm v0.35.x) (#7276) * Update error message to correspond to changes in v0.34.x * Add buffer size and client-close config parameters Signed-off-by: Thane Thomson <connect@thanethomson.com> 13 November 2021, 21:48:45 UTC
37e0779 mergify[bot] 10 November 2021, 16:10:06 UTC p2p: reduce peer score for dial failures (backport #7265) (#7271) * p2p: reduce peer score for dial failures (#7265) When dialing fails to succeed we should reduce the score of the peer, which puts the peer at (potentially) greater chances of being removed from the peer manager, and reduces the chance of the peer being gossiped by the PEX reactor. (cherry picked from commit 27560cf7a4dc5c8a1fed98f6bbe86898c1ca790f) Co-authored-by: Sam Kleinman <garen@tychoish.com> 10 November 2021, 16:10:06 UTC
38f9078 mergify[bot] 09 November 2021, 21:36:00 UTC evidence: remove source of non-determinism from test (#7266) (#7268) The evidence test produces a set of mock evidence in the evidence pool of the 'Primary' node. The test then fills the evidence pools of secondaries with half of this mock evidence. Finally, the test waits until the secondary has an evidence pool as full as the primary. The assertions that are removed here were checking that the primary and secondaries' evidence channels were empty. However, nothing in the test actually ensures that the channels are empty. The test only waits for the secondaries to have received the complete set of evidence, and the secondaries already received half of the evidence at the beginning. It's more than possible that the secondaries can receive the complete set of evidence and not finish reading the duplicate evidence off the channels. (cherry picked from commit 4acd117b5e28cf39709e87cf802dbee8e928d8b9) Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> 09 November 2021, 21:36:00 UTC
052b081 mergify[bot] 09 November 2021, 18:53:44 UTC Set a cap on the length of subscription queries. (backport #7263) (#7264) As a safety measure, don't allow a query string to be unreasonably long. The query filter is not especially efficient, so a query that needs more than basic detail should filter coarsely in the subscriber and refine on the client side. This affects Subscribe and TxSearch queries. (cherry picked from commit 9dc3d7f9a26f2e395311b2f1d705aa950bb25c7a) 09 November 2021, 18:53:44 UTC
4a66493 mergify[bot] 09 November 2021, 15:47:38 UTC consensus: add some more checks to vote counting (#7253) (#7262) (cherry picked from commit b3b90f820cd2001e3504142b9b22bb723129ed1b) Co-authored-by: Callum Waters <cmwaters19@gmail.com> 09 November 2021, 15:47:38 UTC
cf018ba dependabot[bot] 09 November 2021, 13:09:35 UTC build(deps): Bump github.com/lib/pq from 1.10.3 to 1.10.4 (#7260) Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.10.3 to 1.10.4. - [Release notes](https://github.com/lib/pq/releases) - [Commits](https://github.com/lib/pq/compare/v1.10.3...v1.10.4) --- updated-dependencies: - dependency-name: github.com/lib/pq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 09 November 2021, 13:09:35 UTC
643a3f5 M. J. Fromberger 08 November 2021, 14:48:38 UTC backport: Add basic metrics to the indexer package. (#7250) (#7252) 08 November 2021, 14:48:38 UTC
1c5bb6e dependabot[bot] 06 November 2021, 02:11:09 UTC build(deps): Bump google.golang.org/grpc from 1.41.0 to 1.42.0 (#7218) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.41.0...v1.42.0) This required a patch to Unix-domain socket addresses. Per https://github.com/grpc/grpc/blob/master/doc/naming.md, the socket path using the unix://... address format must be absolute. This recently started being enforced in the library. That change was not documented. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 06 November 2021, 02:11:09 UTC
97a3e44 M. J. Fromberger 04 November 2021, 15:22:39 UTC Prepare CHANGELOG and config settings for v0.35.0 release. (#7228) 04 November 2021, 15:22:39 UTC
d021d06 mergify[bot] 04 November 2021, 14:10:15 UTC docs: add upgrading info about node service (#7241) (#7242) 04 November 2021, 14:10:15 UTC
d59565d Sam Kleinman 04 November 2021, 11:58:26 UTC pex: avoid starting reactor twice (#7239) 04 November 2021, 11:58:26 UTC
003d15f Sam Kleinman 04 November 2021, 11:44:13 UTC lint: cleanup branch lint errors (#7238) 04 November 2021, 11:44:13 UTC
8629d31 dependabot[bot] 03 November 2021, 16:28:52 UTC build(deps): Bump github.com/rs/zerolog from 1.25.0 to 1.26.0 (#7222) Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/rs/zerolog/releases) - [Commits](https://github.com/rs/zerolog/compare/v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: github.com/rs/zerolog dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 03 November 2021, 16:28:52 UTC
113bebb dependabot[bot] 03 November 2021, 15:19:06 UTC build(deps): Bump github.com/golangci/golangci-lint (#7224) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.42.1 to 1.43.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](https://github.com/golangci/golangci-lint/compare/v1.42.1...v1.43.0) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 03 November 2021, 15:19:06 UTC
5591d08 Sam Kleinman 03 November 2021, 14:41:41 UTC ci: backport lint configuration changes (#7226) (cherry picked from commit 6f66c60397d7057b7f55994da3c528e25d8b10ce) 03 November 2021, 14:41:41 UTC
56607d4 dependabot[bot] 03 November 2021, 14:22:33 UTC build(deps): Bump github.com/adlio/schema from 1.1.13 to 1.1.14 (#7217) Bumps [github.com/adlio/schema](https://github.com/adlio/schema) from 1.1.13 to 1.1.14. - [Release notes](https://github.com/adlio/schema/releases) - [Commits](https://github.com/adlio/schema/compare/v1.1.13...v1.1.14) --- updated-dependencies: - dependency-name: github.com/adlio/schema dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 03 November 2021, 14:22:33 UTC
5fca090 mergify[bot] 03 November 2021, 13:41:11 UTC pex: allow disabled pex reactor (backport #7198) (#7201) This ensures the implementation respects disabling the pex reactor. (cherry picked from commit ffcd347ef61e7dc1b38da886d1695804beeed2f6) Co-authored-by: Sam Kleinman <garen@tychoish.com> 03 November 2021, 13:41:11 UTC
3e9ecd8 M. J. Fromberger 29 October 2021, 16:57:23 UTC Prepare changelog for v0.35.0-rc4. (#7181) 29 October 2021, 16:57:23 UTC
e40a846 Sam Kleinman 29 October 2021, 10:38:52 UTC config: backport file writing changes (#7182) 29 October 2021, 10:38:52 UTC
85086d7 M. J. Fromberger 28 October 2021, 22:29:53 UTC Fix metric cardinality left over from backport (#7180) One of the patched uses in #7161 missed the message type field, triggering panic failures from Prometheus. 28 October 2021, 22:29:53 UTC
8314f24 mergify[bot] 28 October 2021, 09:59:39 UTC pubsub: Use distinct client IDs for test subscriptions. (#7178) (#7179) Fixes #7176. Some of the benchmarks create a bunch of different subscriptions all sharing the same query. These were all using the same client ID, which violates one of the subscriber rules. Ensure each subscriber gets a unique ID. This has been broken as long as this library has been in the repo—I tracked it back to bb9aa85d and it was already failing there, so I think this never really worked. I'm not sure these test anything useful, but at least now they run. (cherry picked from commit 1fd706054227950190710e9b38f6f978a7c42274) Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 28 October 2021, 09:59:39 UTC
dd1471d mergify[bot] 27 October 2021, 11:34:24 UTC p2p: add message type into the send/recv bytes metrics (backport #7155) (#7161) * p2p: add message type into the send/recv bytes metrics (#7155) This pull request adds a new "mesage_type" label to the send/recv bytes metrics calculated in the p2p code. Below is a snippet of the updated metrics that includes the updated label: ``` tendermint_p2p_peer_receive_bytes_total{chID="32",chain_id="ci",message_type="consensus_HasVote",peer_id="2551a13ed720101b271a5df4816d1e4b3d3bd133"} 652 tendermint_p2p_peer_receive_bytes_total{chID="32",chain_id="ci",message_type="consensus_HasVote",peer_id="4b1068420ef739db63377250553562b9a978708a"} 631 tendermint_p2p_peer_receive_bytes_total{chID="32",chain_id="ci",message_type="consensus_HasVote",peer_id="927c50a5e508c747830ce3ba64a3f70fdda58ef2"} 631 tendermint_p2p_peer_receive_bytes_total{chID="32",chain_id="ci",message_type="consensus_NewRoundStep",peer_id="2551a13ed720101b271a5df4816d1e4b3d3bd133"} 393 tendermint_p2p_peer_receive_bytes_total{chID="32",chain_id="ci",message_type="consensus_NewRoundStep",peer_id="4b1068420ef739db63377250553562b9a978708a"} 357 tendermint_p2p_peer_receive_bytes_total{chID="32",chain_id="ci",message_type="consensus_NewRoundStep",peer_id="927c50a5e508c747830ce3ba64a3f70fdda58ef2"} 386 ``` (cherry picked from commit b4bc6bb4e884aca1e3a19ef9aba5aacd6325159a) 27 October 2021, 11:34:24 UTC
c6d62cc mergify[bot] 27 October 2021, 09:14:35 UTC docs: fix broken links and layout (#7154) (#7163) This PR does a few minor touch ups to the docs (cherry picked from commit ce89292712288be9b7baa57e7d84ca4bd79025a1) Co-authored-by: Callum Waters <cmwaters19@gmail.com> 27 October 2021, 09:14:35 UTC
ce6014d mergify[bot] 22 October 2021, 16:29:33 UTC docs: add reactor sections (backport #6510) (#7151) 22 October 2021, 16:29:33 UTC
e62a75b mergify[bot] 21 October 2021, 16:07:51 UTC state: add height assertion to rollback function (#7143) (#7148) (cherry picked from commit a8ff617773542b815136f63f5e8c01b221fe0ff6) Co-authored-by: Callum Waters <cmwaters19@gmail.com> 21 October 2021, 16:07:51 UTC
dbc72e0 mergify[bot] 19 October 2021, 14:21:47 UTC mempool: remove panic when recheck-tx was not sent to ABCI application (#7134) (#7142) This pull request fixes a panic that exists in both mempools. The panic occurs when the ABCI client misses a response from the ABCI application. This happen when the ABCI client drops the request as a result of a full client queue. The fix here was to loop through the ordered list of recheck-tx in the callback until one matches the currently observed recheck request. (cherry picked from commit b0130c88fb1aa26242b1aa5d19421bd1f5e51988) Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> 19 October 2021, 14:21:47 UTC
57e4e18 mergify[bot] 12 October 2021, 23:50:34 UTC build: Fix build-docker to include the full context. (#7114) (#7116) Fixes #7068. The build-docker rule relies on being able to run make build-linux, but did not pull the Makefile into the build context. There are various ways to fix this, but this was probably the smallest. (cherry picked from commit 6538776e6a5c9b9a378fd1424062bf854b8e2f3d) Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 12 October 2021, 23:50:34 UTC
b7fe214 mergify[bot] 12 October 2021, 16:03:00 UTC Revert "abci: change client to use multi-reader mutexes (#6306)" (backport #7106) (#7110) * Revert "abci: change client to use multi-reader mutexes (#6306)" (#7106) This reverts commit 1c4dbe30d40bb4c1dc59a2247d5113b78702a014. (cherry picked from commit 34a3fcd8fcfef1118b2f12113fb04e6d50d34f15) 12 October 2021, 16:03:00 UTC
66e8eec mergify[bot] 12 October 2021, 02:49:25 UTC light: Update links in package docs. (#7099) (#7101) Fixes #7098. The light client documentation moved to the spec repository. I was not able to figure out what happened to light-client-protocol.md, it was removed in #5252 but no corresponding file exists in the spec repository. Since the spec also discusses the protocol, this change simply links to the spec and removes the non-functional reference. Alternatively we could link to the top-level [light client doc](https://docs.tendermint.com/master/tendermint-core/light-client.html) if you think that's better. (cherry picked from commit 48295955edfd50b24fef42f1e96f7c54333c1ca8) Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 12 October 2021, 02:49:25 UTC
22e33ab mergify[bot] 09 October 2021, 04:32:53 UTC e2e: light nodes should use builtin abci app (#7095) (#7097) (cherry picked from commit befd669794af282733ecccabb50d3f18de154c61) Co-authored-by: Sam Kleinman <garen@tychoish.com> 09 October 2021, 04:32:53 UTC
af85f7e mergify[bot] 08 October 2021, 14:15:15 UTC e2e: abci protocol should be consistent across networks (#7078) (#7086) It seems weird in retrospect that we allow networks to contain applications that use different ABCI protocols. (cherry picked from commit f2a8f5e054cf99ebe246818bb6d71f41f9a30faa) Co-authored-by: Sam Kleinman <garen@tychoish.com> 08 October 2021, 14:15:15 UTC
f0cd548 mergify[bot] 08 October 2021, 07:56:18 UTC cli: allow node operator to rollback last state (backport #7033) (#7081) 08 October 2021, 07:56:18 UTC
98bc4f0 M. J. Fromberger 06 October 2021, 18:19:26 UTC Update changelog for v0.35.0-rc3. (#7074) 06 October 2021, 18:19:26 UTC
bff85fc mergify[bot] 05 October 2021, 20:36:21 UTC mempool,rpc: add removetx rpc method (#7047) (#7065) Addresses one of the concerns with #7041. Provides a mechanism (via the RPC interface) to delete a single transaction, described by its hash, from the mempool. The method returns an error if the transaction cannot be found. Once the transaction is removed it remains in the cache and cannot be resubmitted until the cache is cleared or it expires from the cache. (cherry picked from commit 851d2e3bdeb4d5a508a67cd42b36cb0328a3f817) Co-authored-by: Sam Kleinman <garen@tychoish.com> 05 October 2021, 20:36:21 UTC
4a95288 mergify[bot] 05 October 2021, 19:26:08 UTC e2e: automatically prune old app snapshots (#7034) (#7063) This PR tackles the case of using the e2e application in a long lived testnet. The application continually saves snapshots (usually every 100 blocks) which after a while bloats the size of the application. This PR prunes older snapshots so that only the most recent 10 snapshots remain. (cherry picked from commit 5703ae2fb3dc1aede7af118f8becfbb1ad392368) Co-authored-by: Callum Waters <cmwaters19@gmail.com> 05 October 2021, 19:26:08 UTC
42ed5d7 William Banfield 05 October 2021, 14:49:26 UTC consensus: wait until peerUpdates channel is closed to close remaining peers (#7058) (#7060) The race occurred as a result of a goroutine launched by `processPeerUpdate` racing with the `OnStop` method. The `processPeerUpdates` goroutine deletes from the map as `OnStop` is reading from it. This change updates the `OnStop` method to wait for the peer updates channel to be done before closing the peers. It also copies the map contents to a new map so that it will not conflict with the view of the map that the goroutine created in `processPeerUpdate` sees. 05 October 2021, 14:49:26 UTC
be68409 M. J. Fromberger 05 October 2021, 13:38:23 UTC Revert "Consolidate related changelog entries. (#7056)" (#7061) This reverts commits: c16cd72c0a6ae9fe85ff7305c72aca4bcdb2b209 6ef847fdfe3af6c661622936810667f26c1771e3 We decided on another release candidate to sort out SDK merge issues. 05 October 2021, 13:38:23 UTC
c16cd72 M. J. Fromberger 04 October 2021, 21:05:25 UTC Consolidate related changelog entries. (#7056) 04 October 2021, 21:05:25 UTC
6ef847f M. J. Fromberger 04 October 2021, 19:22:32 UTC Consolidate release candidate changelogs for v0.35. (#7052) 04 October 2021, 19:22:32 UTC
f361ce0 M. J. Fromberger 04 October 2021, 15:40:50 UTC Update Go toolchains to 1.17 in Actions workflows. (#7049) 04 October 2021, 15:40:50 UTC
243c62c William Banfield 01 October 2021, 20:33:12 UTC statesync: improve rare p2p race condition (#7042) This is intended to fix a test failure that occurs in the p2p state provider. The issue presents as the state provider timing out waiting for the consensus params response. The reason that this can occur is because the statesync reactor has the possibility of attempting to respond to the params request before the state provider is ready to read it. This results in the reactor hitting the `default` case seen here and then never sending on the channel. The stateprovider will then block waiting for a response and never receive one because the reactor opted not to send it. 01 October 2021, 20:33:12 UTC
177850a William Banfield 30 September 2021, 19:19:10 UTC statesync: remove deadlock on init fail (#7029) When statesync is stopped during shutdown, it has the possibility of deadlocking. A dump of goroutines reveals that this is related to the peerUpdates channel not returning anything on its `Done()` channel when `OnStop` is called. As this is occuring, `processPeerUpdate` is attempting to acquire the reactor lock. It appears that this lock can never be acquired. I looked for the places where the lock may remain locked accidentally and cleaned them up in hopes to eradicate the issue. Dumps of the relevant goroutines may be found below. Note that the line numbers below are relative to the code in the `v0.35.0-rc1` tag. ``` goroutine 36 [chan receive]: github.com/tendermint/tendermint/internal/statesync.(*Reactor).OnStop(0xc00058f200) github.com/tendermint/tendermint/internal/statesync/reactor.go:243 +0x117 github.com/tendermint/tendermint/libs/service.(*BaseService).Stop(0xc00058f200, 0x0, 0x0) github.com/tendermint/tendermint/libs/service/service.go:171 +0x323 github.com/tendermint/tendermint/node.(*nodeImpl).OnStop(0xc0001ea240) github.com/tendermint/tendermint/node/node.go:769 +0x132 github.com/tendermint/tendermint/libs/service.(*BaseService).Stop(0xc0001ea240, 0x0, 0x0) github.com/tendermint/tendermint/libs/service/service.go:171 +0x323 github.com/tendermint/tendermint/cmd/tendermint/commands.NewRunNodeCmd.func1.1() github.com/tendermint/tendermint/cmd/tendermint/commands/run_node.go:143 +0x62 github.com/tendermint/tendermint/libs/os.TrapSignal.func1(0xc000629500, 0x7fdb52f96358, 0xc0002b5030, 0xc00000daa0) github.com/tendermint/tendermint/libs/os/os.go:26 +0x102 created by github.com/tendermint/tendermint/libs/os.TrapSignal github.com/tendermint/tendermint/libs/os/os.go:22 +0xe6 goroutine 188 [semacquire]: sync.runtime_SemacquireMutex(0xc00026b1cc, 0x0, 0x1) runtime/sema.go:71 +0x47 sync.(*Mutex).lockSlow(0xc00026b1c8) sync/mutex.go:138 +0x105 sync.(*Mutex).Lock(...) sync/mutex.go:81 sync.(*RWMutex).Lock(0xc00026b1c8) sync/rwmutex.go:111 +0x90 github.com/tendermint/tendermint/internal/statesync.(*Reactor).processPeerUpdate(0xc00026b080, 0xc000650008, 0x28, 0x124de90, 0x4) github.com/tendermint/tendermint/internal/statesync/reactor.go:849 +0x1a5 github.com/tendermint/tendermint/internal/statesync.(*Reactor).processPeerUpdates(0xc00026b080) github.com/tendermint/tendermint/internal/statesync/reactor.go:883 +0xab created by github.com/tendermint/tendermint/internal/statesync.(*Reactor.OnStart github.com/tendermint/tendermint/internal/statesync/reactor.go:219 +0xcd) ``` 30 September 2021, 19:19:10 UTC
bdd815e M. J. Fromberger 30 September 2021, 17:53:05 UTC Align atomic struct field for compatibility in 32-bit ABIs. (#7037) The layout of struct fields means that interior fields may not be properly aligned for 64-bit access. Fixes #7000. 30 September 2021, 17:53:05 UTC
7705237 M. J. Fromberger 30 September 2021, 17:13:32 UTC Update default config template to match mapstructure keys. (#7036) Fix a couple of cases where we updated the keys in the config reader, but forgot to update some of their uses in the default template. Fixes #7031. 30 September 2021, 17:13:32 UTC
6a0d9c8 William Banfield 30 September 2021, 16:19:18 UTC blocksync: fix shutdown deadlock issue (#7030) When shutting down blocksync, it is observed that the process can hang completely. A dump of running goroutines reveals that this is due to goroutines not listening on the correct shutdown signal. Namely, the `poolRoutine` goroutine does not wait on `pool.Quit`. The `poolRoutine` does not receive any other shutdown signal during `OnStop` becuase it must stop before the `r.closeCh` is closed. Currently the `poolRoutine` listens in the `closeCh` which will not close until the `poolRoutine` stops and calls `poolWG.Done()`. This change also puts the `requestRoutine()` in the `OnStart` method to make it more visible since it does not rely on anything that is spawned in the `poolRoutine`. ``` goroutine 183 [semacquire]: sync.runtime_Semacquire(0xc0000d3bd8) runtime/sema.go:56 +0x45 sync.(*WaitGroup).Wait(0xc0000d3bd0) sync/waitgroup.go:130 +0x65 github.com/tendermint/tendermint/internal/blocksync/v0.(*Reactor).OnStop(0xc0000d3a00) github.com/tendermint/tendermint/internal/blocksync/v0/reactor.go:193 +0x47 github.com/tendermint/tendermint/libs/service.(*BaseService).Stop(0xc0000d3a00, 0x0, 0x0) github.com/tendermint/tendermint/libs/service/service.go:171 +0x323 github.com/tendermint/tendermint/node.(*nodeImpl).OnStop(0xc00052c000) github.com/tendermint/tendermint/node/node.go:758 +0xc62 github.com/tendermint/tendermint/libs/service.(*BaseService).Stop(0xc00052c000, 0x0, 0x0) github.com/tendermint/tendermint/libs/service/service.go:171 +0x323 github.com/tendermint/tendermint/cmd/tendermint/commands.NewRunNodeCmd.func1.1() github.com/tendermint/tendermint/cmd/tendermint/commands/run_node.go:143 +0x62 github.com/tendermint/tendermint/libs/os.TrapSignal.func1(0xc000df6d20, 0x7f04a68da900, 0xc0004a8930, 0xc0005a72d8) github.com/tendermint/tendermint/libs/os/os.go:26 +0x102 created by github.com/tendermint/tendermint/libs/os.TrapSignal github.com/tendermint/tendermint/libs/os/os.go:22 +0xe6 goroutine 161 [select]: github.com/tendermint/tendermint/internal/blocksync/v0.(*Reactor).poolRoutine(0xc0000d3a00, 0x0) github.com/tendermint/tendermint/internal/blocksync/v0/reactor.go:464 +0x2b3 created by github.com/tendermint/tendermint/internal/blocksync/v0.(*Reactor).OnStart github.com/tendermint/tendermint/internal/blocksync/v0/reactor.go:174 +0xf1 goroutine 162 [select]: github.com/tendermint/tendermint/internal/blocksync/v0.(*Reactor).processBlockSyncCh(0xc0000d3a00) github.com/tendermint/tendermint/internal/blocksync/v0/reactor.go:310 +0x151 created by github.com/tendermint/tendermint/internal/blocksync/v0.(*Reactor).OnStart github.com/tendermint/tendermint/internal/blocksync/v0/reactor.go:177 +0x54 goroutine 163 [select]: github.com/tendermint/tendermint/internal/blocksync/v0.(*Reactor).processPeerUpdates(0xc0000d3a00) github.com/tendermint/tendermint/internal/blocksync/v0/reactor.go:363 +0x12b created by github.com/tendermint/tendermint/internal/blocksync/v0.(*Reactor).OnStart github.com/tendermint/tendermint/internal/blocksync/v0/reactor.go:178 +0x76 ``` 30 September 2021, 16:19:18 UTC
c9d92f5 Tess Rinearson 29 September 2021, 20:02:28 UTC .github: remove tessr and bez from codeowners (#7028) 29 September 2021, 20:02:28 UTC
back to top