https://github.com/GNOME/glib

sort by:
Revision Author Date Message Commit Date
6f39eef gio: Work-around GIO bug in memory monitor tests Start a session bus in the memory monitor tests, as something in GIO, or python-dbusmock waits on one appearing, blocking the system bus and stopping us from being able to receive signals. 18 January 2023, 10:47:23 UTC
e80d952 gio: Better debug in memory-monitor tests 18 January 2023, 09:48:13 UTC
4e3aba5 XXX ci: Allow gio/socket test to fail 17 January 2023, 22:40:19 UTC
cb67c65 XXX always enable installed-tests in CI 17 January 2023, 16:21:33 UTC
4380068 Merge branch 'document-gtask-brokenness' into 'main' GTask: Document issues See merge request GNOME/glib!3203 16 January 2023, 14:43:20 UTC
dabb650 Merge branch 'settings-action-per-desktop-default' into 'main' gsettings: Support per-desktop overrides in GSettingsAction See merge request GNOME/glib!3193 16 January 2023, 13:30:53 UTC
f999481 GTask: Document issues We may not be able to fix GTasks broken design, but at least we should document it and not let users stumble into this bear trap without warning. Helps: #1346 16 January 2023, 13:19:23 UTC
f7a02ef Merge branch 'issue_2883b' into 'main' Use 'write' with 'count' <= max value of its return type Closes #2883 See merge request GNOME/glib!3200 16 January 2023, 13:08:43 UTC
e9e4d52 gfileutils: Use 'write' with 'count' <= max value of its return type Limit `count` so that `write` can properly report the number of written bytes. Limits: - POSIX: `SSIZE_MAX` - Windows: `INT_MAX` Fixes: #2883 16 January 2023, 13:08:42 UTC
26728b4 Merge branch 'gstring-optimizations' into 'main' Some GString optimizations See merge request GNOME/glib!3199 16 January 2023, 12:38:54 UTC
908bd08 Try to make gtk-doc happy 14 January 2023, 17:55:25 UTC
0a26b1c markup: Use g_string_truncate We don't need a private inline helper for this anymore. 14 January 2023, 15:08:42 UTC
6bb9fdd markup: Replace a g_string_insert_len call This lets us use the optimized inline call. 14 January 2023, 14:44:22 UTC
d102a4d Improve the g_string_truncate test Test the inline version too. 14 January 2023, 14:44:22 UTC
c191c99 string: Add an inline g_string_truncate too This is another very commonly used GString function. 14 January 2023, 14:44:22 UTC
8478053 Improve the g_string_append test Test the inline versions too, and test passing -1 for len. 14 January 2023, 14:09:19 UTC
57de9af Improve the g_string_append_c test We should check the resulting string too. 14 January 2023, 14:09:19 UTC
9810803 string: Optimize g_string_append(_len) Add static inline versions of these functions that boil down to just an memcpy. ag_string_append_len is used quite a bit in GMarkup and GTK's css parser. 14 January 2023, 14:09:19 UTC
0cc74d5 string: Add a G_LIKELY This is the case we optimize for. 14 January 2023, 14:09:15 UTC
5d0db7f Merge branch 'fix-closure-annotations' into 'main' Fix a couple of `closure` annotations See merge request GNOME/glib!3198 14 January 2023, 08:58:28 UTC
34b7992 string: Split g_string_maybe_expand Split off g_string_expand, and inline just the size check. 14 January 2023, 05:05:34 UTC
45ec0aa tests/gsettings: Check that per-desktop settings are used by GAction's 14 January 2023, 03:17:51 UTC
6e91e80 Merge branch 'banjiuqingshan-main-patch-03761' into 'main' gio/tests/file.c:Fix expectations when running as root See merge request GNOME/glib!3196 13 January 2023, 23:35:51 UTC
d9a1d75 gio/tests/file.c: Fix expectations when running as root Includes tweaks by Philip Withnall. 13 January 2023, 22:21:07 UTC
f85e4e3 gsettings: Slightly simplify g_settings_action_get_state() This introduces no functional changes. Suggested by Christian Persch. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 13 January 2023, 22:14:56 UTC
79fd6fd Fix a couple of `closure` annotations 13 January 2023, 16:06:23 UTC
d839282 Merge branch 'regex-invalid-memory-access' into 'main' gregex: Prevent invalid memory access for unmatched subpatterns Closes #2881 See merge request GNOME/glib!3194 12 January 2023, 15:22:57 UTC
e9fc915 Merge branch 'badcel/revert-update-closure-annotations' into 'main' Revert "Rename user data parameters to user_data" Closes #2827 See merge request GNOME/glib!3111 11 January 2023, 14:58:31 UTC
fdd2d70 gregex: Prevent invalid memory access for unmatched subpatterns Based on a test by Emmanuel Pacaud. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #2881 11 January 2023, 12:14:04 UTC
b494b83 gsettings: Support per-desktop overrides in GSettingsAction Due to an oversight (I guess), per-desktop default values (which come from override files such as this one: https://github.com/endlessm/gnome-shell/blob/master/data/00_org.gnome.shell.gschema.override) were not checked when getting a GSettings value via a `GSettingsAction`. Per-desktop default values are correctly returned via all other GSettings query paths (see calls to `g_settings_schema_key_get_translated_default()`). Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 10 January 2023, 20:57:03 UTC
1955497 Merge branch 'wip/smcv/gptrarray-null-term' into 'main' garray: Update NULL termination after copying array content Closes #2877 See merge request GNOME/glib!3190 10 January 2023, 19:51:57 UTC
71f0b3b Merge branch 'wip/smcv/rlimit-nproc-error' into 'main' tests: Improve error message if setting max processes to 1 fails See merge request GNOME/glib!3191 10 January 2023, 19:28:07 UTC
d3356bd Merge branch 'wip/smcv/gptrarray-memcpy-nothing' into 'main' garray: Avoid calling memcpy with no items See merge request GNOME/glib!3192 10 January 2023, 19:27:31 UTC
952b071 garray: Avoid calling memcpy with no items `memcpy(NULL, ., n)` and `memcpy(., NULL, n)` are undefined behaviour, even if *n* is zero. When len is 0 here, callers are allowed to pass in null data, and GPtrArray also does not guarantee to have allocated rarray->pdata yet. Signed-off-by: Simon McVittie <smcv@collabora.com> 10 January 2023, 13:40:24 UTC
68b9fd5 garray: Update NULL termination after copying array content ptr_array_new(len, ., TRUE) ensures that there are at least len+1 elements in pdata, and that pdata[0] is null, but leaves the rest of pdata uninitialized. After copying the array data into pdata[1] to pdata[len-1] inclusive, we still need to make sure pdata[len] is a null terminator. Note that if len is 0, then pdata is not guaranteed to be non-null. If it's null, then we can't add null-termination to it until its size is updated. Resolves: https://gitlab.gnome.org/GNOME/glib/-/issues/2877 Signed-off-by: Simon McVittie <smcv@collabora.com> 10 January 2023, 13:35:22 UTC
6d2705e Merge branch 'gnumdk/cmpint_typo' into 'main' docs: Fix return type in cmpint See merge request GNOME/glib!3189 10 January 2023, 12:49:42 UTC
f42316c tests: Improve error message if setting max processes to 1 fails This has historically failed on Debian autobuilders, and as a result we have had a patch for a long time that turned a failure here into a g_test_skip(). It's not clear whether this still happens, so I'm now assessing whether the patch can be dropped; but if the prlimit() call can fail for whatever reason, it would be useful for the error message to say what limit we were trying to set. Signed-off-by: Simon McVittie <smcv@collabora.com> 10 January 2023, 12:48:32 UTC
cf5d807 docs: Fix return type in cmpint example 10 January 2023, 11:31:25 UTC
cabe137 Merge branch 'fix-glib-compile-schemas-typo' into 'main' glib-compile-schemas: Fix typo in comparison function See merge request GNOME/glib!3188 09 January 2023, 17:12:12 UTC
fc70f2c Do not name callback parameters "user_data" Calling a callback parameter "user_data" implicitly adds the "closure" attribute in the documentation which is wrong for callbacks. 09 January 2023, 13:12:16 UTC
8cddffd Merge branch 'ebassi/visibility-build-vars' into 'main' build: Don't overwrite build variables See merge request GNOME/glib!3184 09 January 2023, 12:37:00 UTC
8d86ae6 Merge branch 'ebassi/glib-types-visibility' into 'main' Include gobject-visibility.h in glib-types.h See merge request GNOME/glib!3185 09 January 2023, 12:29:07 UTC
b24f6ca Revert "Rename all user datas in callbacks to user_data" This reverts commit 1422e5f81241650c634413911e92d23495692545. The renaming of parameters implicitly introduced "closure" annotations in the documentation which are wrong on callbacks. 09 January 2023, 12:23:32 UTC
9d5bcc9 glib-compile-schemas: Fix typo in comparison function This caused schemas and override files to be sorted incorrectly. Fixes a regression introduced in commit 861e82efbc. Spotted by John Wudrick in https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3155#note_1635044. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 09 January 2023, 12:20:10 UTC
19a02d7 Revert "Rename user data parameters to user_data" This reverts commit da7a31a052614edd2cc87518585ff371cbb0f204. The renaming of parameters implicitly introduced "closure" annotations in the documentation which are wrong on callbacks. 09 January 2023, 12:09:26 UTC
79fd62c Include GObject's visibility header The gobject-introspection build goes through the GLib types when generating the introspection data for GLib, but it does not include glib-object.h, otherwise all GObject symbols would end up inside the GLib namespace. This means we need to import the gobject-visibility.h header inside glib-types.h. Since the header is guarded by a once pragma, it doesn't really affect any legitimate user of the C API. 08 January 2023, 00:33:47 UTC
684d9aa build: Don't overwrite build variables We cannot use `gvisibility_h` for different visibility header files; you never know when you're going to refer to the variable again, and projects might end up needing to retrieve the variable contents—like, for instance, gobject-introspection using glib as a subproject. 08 January 2023, 00:33:14 UTC
ec3b1bf 2.75.2 Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 06 January 2023, 12:49:52 UTC
206cbf4 Merge branch '2871-find-program-for-path-leak' into 'main' gutils: Avoid possible leaks in g_find_program_for_path() Closes #2871 See merge request GNOME/glib!3183 06 January 2023, 12:33:08 UTC
73fa684 Merge branch 'ptr-array-sort-values' into 'main' garray: Add g_ptr_array_sort_values[_with_data]() wrappers See merge request GNOME/glib!3155 06 January 2023, 12:09:37 UTC
861e82e gio: Use g_ptr_array_sort_values() Cleanup some code using GPtrArray sorting with functions that were taking pointer to pointers arguments. 06 January 2023, 11:46:01 UTC
0ffd23c garray: Add g_ptr_array_sort_values[_with_data]() wrappers Historically GPtrArray made possible to compare pointers of pointers values that it holds, however this is inconvenient in most cases as it requires wrapper functions and not friendly castings. So, add two functions that allow to perform the comparisons between the pointer values that a GPtrArray holds following the same syntax that we share everywhere in the codebase. 06 January 2023, 11:46:01 UTC
892deb8 Merge branch 'coverity-iface-null' into 'main' gobject: Add a missing NULL check for the return from lookup_type_node_I() See merge request GNOME/glib!3162 05 January 2023, 18:57:21 UTC
d333b06 Merge branch 'g-win32-app-info-enhancements' into 'main' GWin32AppInfo: Fixes for UWP (packaged) apps activation See merge request GNOME/glib!3167 05 January 2023, 17:51:06 UTC
db23810 gutils: Avoid possible leaks in g_find_program_for_path() Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #2871 05 January 2023, 17:13:35 UTC
86fccfc GWin32AppInfo: Prefer file activation over URI activation for file URI's (...unless file:// URI's are actually supported by the target app) References: [1] - https://learn.microsoft.com/en-us/windows/uwp/launch-resume/handle-uri-activation [2] - https://learn.microsoft.com/en-us/windows/uwp/launch-resume/handle-file-activation 05 January 2023, 16:50:15 UTC
02417db GWin32AppInfo: Pass only one item to ActivateForProtocol() IApplicationActivationManager::ActivateForProtocol() only uses the first item from the IShellItemArray. When we have to activate multiple URI's, call ActivateForProtocol() repeatedly in a loop, each time with one URI. References: [1] - IApplicationActivationManager::ActivateForProtocol method [MSDN] https://learn.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-iapplicationactivationmanager-activateforprotocol 05 January 2023, 16:46:50 UTC
7bbbb1e GWin32AppInfo: Create IShellItemArray object inside launch_uwp_internal() The IShellItemArray object is only used in launch_uwp_internal(), so do not make callers bother with that. 05 January 2023, 16:42:03 UTC
92f9c67 Merge branch 'nirbheek/meson-subproject-usage-fixes' into 'main' Various fixes for how we interact with subproject dependencies See merge request GNOME/glib!3177 05 January 2023, 16:02:50 UTC
637b495 Merge branch 'actualize-links' into 'main' INSTALL.md,README.win32.md: Actualize links See merge request GNOME/glib!3181 05 January 2023, 15:05:04 UTC
a7d523c Merge branch 'mtime-fix' into 'main' glocalfileinfo: Don't reset mtime tv_sec when setting tv_usec See merge request GNOME/glib!3178 05 January 2023, 14:40:15 UTC
35d3528 Merge branch '2857-stpcpy-doc' into 'main' gstrfuncs: Fix grammar in documentation of stpcpy Closes #2857 See merge request GNOME/glib!3179 05 January 2023, 14:21:04 UTC
e422bbb INSTALL.md,README.win32.md: Actualize links 04 January 2023, 09:52:07 UTC
49ec4d5 gstrfuncs: Fix grammar in documentation of stpcpy Fixes https://gitlab.gnome.org/GNOME/glib/-/issues/2857 02 January 2023, 18:27:26 UTC
b6270f1 Update Turkish translation 02 January 2023, 13:41:13 UTC
a56bc06 glocalfileinfo: Don't reset mtime tv_sec when setting tv_usec Fix a regression that appeared after adding support for nanosecond timestamps to set_mtime_atime(). User-visible effect: when copying a file from a gvfs MTP mountpoint to the local filesystem, the file's mtime is set to 0. This behavior happens when setting G_FILE_ATTRIBUTE_TIME_MODIFIED first, then G_FILE_ATTRIBUTE_TIME_MODIFIED_USEC. Setting the second attribute ends up in set_mtime_atime() with mtime_usec_value set, and mtime_value == NULL. When mtime_value is NULL, the tv_sec part of the timestamp should be fetched by lazy_stat(), but set_mtime_atime() fails to assign it properly, and tv_sec stays at 0, leading to losing the main part of the timestamp. Fix the issue by setting times_n[1].tv_sec to the value fetched from lazy_stat(). Fixes: b33ef610deef ("Add functionality to preserve nanosecond timestamps") Fixes: 15cb123c824c ("glocalfileinfo: don't call both utimes and utimensat") Signed-off-by: Maxim Mikityanskiy <maxtram95@gmail.com> 02 January 2023, 01:55:43 UTC
45c2f8c ci: Update images to cache wrap downloads We aren't allowed to download wraps in the build, and we need them on Android and MinGW 30 December 2022, 23:43:10 UTC
fc6843b ci: Fix podman support in run-docker.sh In newer Fedora versions, `docker` doesn't exist. You have to use `podman`. 30 December 2022, 23:43:10 UTC
a587212 ci: Update docker image generation README 30 December 2022, 23:43:10 UTC
71438c4 meson: Don't accidentally pick up intl fallback in the first test If proxy-libintl has already been configured before we get to glib, we will pick that up in dependency('intl'), which then does compiler checks on it. This was written to assume that the first check will not find a subproject for libintl, so force it with allow_fallback: false. Also update the proxy-libintl wrap file and get rid of the explicit subproject() call. Reported by Benjamin Gilbert at https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3172 30 December 2022, 23:43:10 UTC
6abafd6 meson: Fix pcre static flag usage with a subproject 30 December 2022, 23:43:10 UTC
a395a7a meson: Don't use outdated 'fallback:' kwarg to dependency() The mapping is done using the wrap file now. Also update the libffi and pcre2 subprojects at the same time. Reported by Benjamin Gilbert at https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3172 30 December 2022, 23:43:10 UTC
2d5d990 Merge branch 'add-null-check-codegen' into 'main' codegen: Check parameter before calling its interface method See merge request GNOME/glib!3175 30 December 2022, 13:44:20 UTC
b162013 codegen: Check parameter before calling its interface method 30 December 2022, 13:44:20 UTC
609d58b meson: Don't accidentally pick up pcre2 fallback in the first test This test assumes that pcre2 is not provided by a subproject, so force it to be that. Explicitly allow fallback in the next check (although it's implied already). 30 December 2022, 11:31:27 UTC
6d9bff2 Merge branch 'coverity-fixes2' into 'main' garray: Add some additional length assertions See merge request GNOME/glib!3174 30 December 2022, 11:17:39 UTC
8a3b16a Merge branch 'coverity-fixes' into 'main' gdesktopappinfo: Drop an unnecessary NULL check See merge request GNOME/glib!3173 30 December 2022, 11:15:29 UTC
41b6de6 garray: Add some additional length assertions This should shut Coverity up. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Coverity CID: #1502194 29 December 2022, 16:09:20 UTC
8463155 gdesktopappinfo: Drop an unnecessary NULL check `search_token` cannot be `NULL` at this point (guaranteed by all the current call sites of `desktop_file_dir_unindexed_search()`), so remove an unnecessary `NULL` check. Add an assertion to make the nullability clear. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Coverity CID: #1502196, #1502193 29 December 2022, 15:57:53 UTC
0c640cf Merge branch 'md' into 'main' codegen: Support markdown suitable for gi-docgen See merge request GNOME/glib!3171 29 December 2022, 12:42:12 UTC
4cb945d codegen: Support markdown suitable for gi-docgen 29 December 2022, 12:42:12 UTC
46d3a01 Merge branch 'write_info_file_fail' into 'main' GLocalFile: add error handle for trash info file writing See merge request GNOME/glib!3170 29 December 2022, 12:33:55 UTC
95c4312 GLocalFile: add error handle for trash info file writing 29 December 2022, 12:33:55 UTC
955ee5c Merge branch 'del_errsv' into 'main' GLocalFile: Delete redundant error saving statement See merge request GNOME/glib!3169 29 December 2022, 12:29:40 UTC
333e9fc GLocalFile: Delete redundant error saving statement 29 December 2022, 12:29:39 UTC
f0bc060 Merge branch 'revert-eb12afed' into 'main' Revert "gsimpleproxyresolver: Make explicit that a port is needed for HTTP/HTTPS" Closes #2832 See merge request GNOME/glib!3110 22 December 2022, 21:57:39 UTC
d246d09 gproxyresolver: allow implicit ports in URIs If the port is not specified, then a default port should be assumed. This is how everybody expects URIs to work and it's how GProxyResolver should work too. We already have lots of tests to ensure this works as expected; however, the documentation currently does not allow it. Change the documentation to match reality. Fixes #2832 22 December 2022, 21:37:27 UTC
1c3f992 Revert "gsimpleproxyresolver: Make explicit that a port is needed for HTTP/HTTPS" This reverts commit eb12afed6f36db6212228b1e1fbaf87ed5606173 Instead, let's allow use of URIs without ports specified, which indicates that a default port should be used. 22 December 2022, 21:37:27 UTC
a0ea1d7 Merge branch 'g-win32-app-info-enhancements' into 'main' GWin32AppInfo: Check for local file path first Closes #2843 See merge request GNOME/glib!3160 22 December 2022, 15:02:42 UTC
3c2b15f GWin32AppInfo: Fix use-after-free 22 December 2022, 14:14:29 UTC
b0b16cf GWin32AppInfo: Check for local file path first When launching a registered handler we compose the command-line string using the registered command-line template. Applications expect files in their command-line as local paths rather than complete URI strings. For example, "Program.exe" "%1" Should expand to "Program.exe" "C:\file.dat" Rather than "Program.exe" "file:///C:\file.dat" Fixes https://gitlab.gnome.org/GNOME/glib/-/issues/2843 22 December 2022, 14:13:10 UTC
b1057f3 2.75.1 Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 21 December 2022, 21:26:54 UTC
ac459f1 Merge branch '2840-2841-variant-more-fixes' into 'main' gvariant: Check offset table doesn’t fall outside variant bounds and speed up text parsing Closes #2840 and #2841 See merge request GNOME/glib!3163 21 December 2022, 21:25:20 UTC
21a2041 gvariant: Propagate trust when getting a child of a serialised variant If a variant is trusted, that means all its children are trusted, so ensure that their checked offsets are set as such. This allows a lot of the offset table checks to be avoided when getting children from trusted serialised tuples, which speeds things up. No unit test is included because this is just a performance fix. If there are other slownesses, or regressions, in serialised `GVariant` performance, the fuzzing setup will catch them like it did this one. This change does reduce the time to run the oss-fuzz reproducer from 80s to about 0.7s on my machine. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #2841 oss-fuzz#54314 21 December 2022, 19:50:26 UTC
78da5fa gvariant: Check offset table doesn’t fall outside variant bounds When dereferencing the first entry in the offset table for a tuple, check that it doesn’t fall outside the bounds of the variant first. This prevents an out-of-bounds read from some non-normal tuples. This bug was introduced in commit 73d0aa81c2575a5c9ae77d. Includes a unit test, although the test will likely only catch the original bug if run with asan enabled. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #2840 oss-fuzz#54302 21 December 2022, 19:50:19 UTC
251bab3 gobject: Add a missing NULL check for the return from lookup_type_node_I() This can cause a `NULL` dereference on the next line if there is no `TypeNode` for `iface_type`, for example if `iface_type == G_TYPE_INVALID`. Unlikely, but possible since this API is public. Spotted by Coverity. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Coverity CID: #1501602 21 December 2022, 19:16:10 UTC
5e378c7 Merge branch 'ptr-array-new-take' into 'main' garray: Add more G(Ptr)Array constructors to take or copy C arrays See merge request GNOME/glib!3128 21 December 2022, 18:34:13 UTC
f64fc32 Merge branch 'disable-assert-warning-fix' into 'main' gmenuexporter: Fix warning of unused n_items when building with G_DISABLE_ASSERT See merge request GNOME/glib!3159 21 December 2022, 18:30:26 UTC
9174af5 Merge branch '2852-musl-siginfo-t' into 'main' gmain: Define fallback values for siginfo_t constants for musl Closes #2852 See merge request GNOME/glib!3158 21 December 2022, 13:13:10 UTC
8f21352 Merge branch 'gobject-value-set-cleanups' into 'main' gobject: Some GValue setting code cleanups See merge request GNOME/glib!3156 21 December 2022, 13:12:54 UTC
back to top