Skip to main content

Browse the archive

https://github.com/GNOME/glib
05 April 2024, 22:37:37 UTC
sort by:
Revision Author Date Message Commit Date
08e9484 Ting-Wei Lan 01 May 2022, 10:38:01 UTC 01 May 2022, 10:38:01 UTC
b1f56dc Ting-Wei Lan 17 October 2021, 04:46:09 UTC 01 May 2022, 09:55:14 UTC
0c6a1af Sebastian Dröge 29 April 2022, 08:05:52 UTC Merge branch 'gdbus-threading-test-fix-maybe' into 'main' tests: Reduce wakeup interval in gdbus-threading See merge request GNOME/glib!2604 29 April 2022, 08:05:52 UTC
ef8e003 Sebastian Dröge 29 April 2022, 08:04:33 UTC Merge branch 'fix-gdbus-peer-object-manager-test' into 'main' tests: Use G_TEST_OPTION_ISOLATE_DIRS in gdbus-peer-object-manager See merge request GNOME/glib!2603 29 April 2022, 08:04:33 UTC
56531a7 Sebastian Dröge 29 April 2022, 08:03:49 UTC Merge branch 'combine-ci-jobs' into 'main' ci: Combine style-check-diff and check-todos jobs into one See merge request GNOME/glib!2598 29 April 2022, 08:03:49 UTC
4ea412c Sebastian Dröge 29 April 2022, 08:02:56 UTC Merge branch 'unicode-normalise-leak' into 'main' tests: Fix a minor leak in the unicode-normalize test See merge request GNOME/glib!2606 29 April 2022, 08:02:56 UTC
42da5c4 Sebastian Dröge 29 April 2022, 08:01:15 UTC Merge branch 'move-lcovrc' into 'main' build: Move lcovrc file to root so it’s picked up by Meson See merge request GNOME/glib!2630 29 April 2022, 08:01:15 UTC
cf86353 Sebastian Dröge 29 April 2022, 08:00:50 UTC Merge branch 'fix-unicode-normalize-installed-test' into 'main' tests: Ensure NormalizationTest.txt is installed for installed-tests See merge request GNOME/glib!2602 29 April 2022, 08:00:50 UTC
53016ef Sebastian Dröge 29 April 2022, 08:00:31 UTC Merge branch 'revert-stat-abi-break' into 'main' Revert "glib/gstdio: simplify GStatBuf macro condition for win64" Closes #2633 See merge request GNOME/glib!2618 29 April 2022, 08:00:31 UTC
4f48d4e Sebastian Dröge 28 April 2022, 11:07:34 UTC Merge branch 'scan-build-fixes' into 'main' Fix various scan-build warnings See merge request GNOME/glib!2628 28 April 2022, 11:07:34 UTC
8e295e2 Philip Withnall 28 April 2022, 10:57:45 UTC build: Move lcovrc file to root so it’s picked up by Meson Move the lcovrc file to the root of the project, so that it’s picked up by Meson when running `ninja coverage` locally. See https://github.com/mesonbuild/meson/issues/4628 This won’t affect the code coverage run on the CI, since that explicitly used the lcovrc file already. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 28 April 2022, 10:57:45 UTC
a0aff54 Sebastian Dröge 28 April 2022, 10:44:57 UTC Merge branch 'scan-build-leak-fix' into 'main' gopenuriportal: Fix a use-after-free on an error path See merge request GNOME/glib!2627 28 April 2022, 10:44:57 UTC
a17a27b Philip Withnall 28 April 2022, 10:20:11 UTC glocalfileinfo: Remove a redundant store This fixes a scan-build warning: ``` ../../../../source/glib/gio/glocalfileinfo.c:1661:28: warning: Although the value stored to 'mydirname' is used in the enclosing expression, the value is never actually read from 'mydirname' [deadcode.DeadStores] mydirname = g_strdup (dirname), ^ ~~~~~~~~~~~~~~~~~~ ``` Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 10:22:53 UTC
b509e59 Philip Withnall 28 April 2022, 10:18:34 UTC tests: Remove some redundant writes `ret` was never read. This fixes scan-build warnings: ``` ../../../../source/glib/glib/tests/thread.c:148:8: warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [deadcode.DeadStores] if ((ret = prlimit (getpid (), RLIMIT_NPROC, &nl, &ol)) != 0) ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../../source/glib/glib/tests/thread.c:174:8: warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [deadcode.DeadStores] if ((ret = prlimit (getpid (), RLIMIT_NPROC, &ol, NULL)) != 0) ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 10:22:53 UTC
de5b30d Philip Withnall 28 April 2022, 10:16:25 UTC tests: Add a missing assertion This fixes a warning about a dead store to `newpath` from scan-build. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 10:22:53 UTC
1d6c46a Philip Withnall 28 April 2022, 10:14:18 UTC gdatetime: Rework array indexing to satisfy scan-build This introduces no functional changes, but reworks the array indexing so that scan-build has a better idea about the array bounds. This squashes the scan-build warning: ``` ../../../../source/glib/glib/gdatetime.c:2292:20: warning: The left operand of '>=' is a garbage value [core.UndefinedBinaryOperatorResult] if (days [i] >= day_of_year) ~~~~~~~~ ^ ``` Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 10:22:53 UTC
969eb83 Philip Withnall 28 April 2022, 09:56:10 UTC gopenuriportal: Fix a use-after-free on an error path `path` was used in building the error message after it had been freed. Spotted by scan-build. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 10:22:33 UTC
7f83151 Philip Withnall 28 April 2022, 09:50:08 UTC gsocket: Clear address before filling it This will probably make no functional difference, but will squash two warnings from scan-build: ``` ../../../../source/glib/gio/gsocket.c:503:14: warning: Assigned value is garbage or undefined [core.uninitialized.Assign] family = address.storage.ss_family; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../../source/glib/gio/gsocket.c:527:29: warning: Assigned value is garbage or undefined [core.uninitialized.Assign] socket->priv->family = address.storage.ss_family; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ ``` It seems like a reasonable thing to warn about. Initialising the full union to zero should avoid any possibility of undefined behaviour like that. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 09:50:08 UTC
c028906 Philip Withnall 28 April 2022, 09:43:13 UTC tests: Drop redundant store This fixes a scan-build warning: ``` ../../../../source/glib/gio/tests/gdbus-tests.c:146:3: warning: Value stored to 'watch_id' is never read [deadcode.DeadStores] watch_id = 0; ^ ``` Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 09:43:13 UTC
86b8891 Philip Withnall 28 April 2022, 09:40:38 UTC gmain: Initialise a variable This fixes a scan-build warning: ``` ../../../../source/glib/glib/gmain.c:4193:18: warning: 2nd function call argument is an uninitialized value [core.CallAndMessage] while ((nfds = g_main_context_query (context, max_priority, &timeout, fds, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` This is a valid situation which can occur if the preceding `g_main_context_prepare()` call returns `FALSE` and doesn’t set `max_priority`. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 09:40:38 UTC
7a1a925 Philip Withnall 28 April 2022, 09:36:37 UTC gmessages: Clear address before passing it to getpeername() This will probably make no functional difference, but will squash a warning from scan-build: ``` ../../../../source/glib/glib/gmessages.c:2243:42: warning: The left operand of '==' is a garbage value [core.UndefinedBinaryOperatorResult] if (err == 0 && addr.storage.ss_family == AF_UNIX) ~~~~~~~~~~~~~~~~~~~~~~ ^ ``` It seems like a reasonable thing to warn about. Initialising the full union to zero should avoid any possibility of undefined behaviour like that. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #1767 28 April 2022, 09:36:37 UTC
0c1b7b2 Sebastian Dröge 27 April 2022, 14:32:16 UTC Merge branch 'multicast-memcpy-size' into 'main' gsocket: Add assertions about socket address sizes for memcpy() See merge request GNOME/glib!2625 27 April 2022, 14:32:16 UTC
4a1ffd1 Sebastian Dröge 27 April 2022, 14:32:13 UTC Merge branch 'gio-tool-set-leak' into 'main' gio-tool: Fix a minor memory leak when using gio-set with bytestrings See merge request GNOME/glib!2626 27 April 2022, 14:32:13 UTC
49cc9b9 Philip Withnall 27 April 2022, 14:01:08 UTC gio-tool: Fix a minor memory leak when using gio-set with bytestrings Tested using: ```sh touch ~/foo gio set ~/foo -t bytestring user::test "\x00\x00" ``` (it doesn’t matter that this fails; the bytestring is still decoded) Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Coverity CID: #1474407 27 April 2022, 14:01:08 UTC
ff94477 Philip Withnall 27 April 2022, 13:47:35 UTC gsocket: Add assertions about socket address sizes for memcpy() These `memcpy()` calls only happen if `g_inet_address_get_family(group) == G_SOCKET_FAMILY_IPV4`, so the assertions should never fail. It’s helpful for understanding the code, and for static analysis, to add the assertions though. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Coverity CID: #1486858 27 April 2022, 13:47:35 UTC
1dfea6b Philip Withnall 27 April 2022, 11:47:30 UTC Merge branch 'timeloop_test' into 'main' Remove tests/timeloop.c and tests/timeloopbasic.c See merge request GNOME/glib!2609 27 April 2022, 11:47:30 UTC
fd8424a Emmanuel Fleury 25 April 2022, 19:16:50 UTC Removing unused tests/timeloop.c and tests/timeloop-basic.c Remove unused tests/timelooop.c and tests/timeloop-basic.c because these programs are manual performance tests which are no more relevant for glib. They were used for the writing of GMainLoop but since then they haven't not much been used in 22 years, it is safe to remove them. Helps issue #1434 26 April 2022, 18:20:03 UTC
606bdcd Philip Withnall 26 April 2022, 10:23:27 UTC Merge branch 'main' into 'main' Fix the annotation of g_utf8_strncpy() See merge request GNOME/glib!2621 26 April 2022, 10:23:27 UTC
797bcf3 Hodong 26 April 2022, 09:54:57 UTC Fix the annotation of g_utf8_strncpy() 26 April 2022, 09:54:57 UTC
fa55f37 Sebastian Dröge 26 April 2022, 07:41:56 UTC Merge branch 'log-writer-checks' into 'main' gmessages: Error if g_log_set_writer_func() is called multiple times See merge request GNOME/glib!2617 26 April 2022, 07:41:56 UTC
862e250 Philip Withnall 25 April 2022, 17:30:54 UTC Merge branch 'fixes_in_tests' into 'main' Fixes in tests See merge request GNOME/glib!2608 25 April 2022, 17:30:54 UTC
b56f10c Philip Withnall 25 April 2022, 13:27:43 UTC Revert "glib/gstdio: simplify GStatBuf macro condition for win64" This reverts commit ae1cccaa0ae08ac6ced3bb1fb225065fc71bf65b. It broke ABI on 64-bit builds with MSVC, as discussed here: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2449#note_1430571. Fixes: #2633 25 April 2022, 16:58:04 UTC
6dc7b10 Philip Withnall 25 April 2022, 13:37:43 UTC Merge branch 'gbookmarkfile_tests' into 'main' Expand tests on gbookmark file API See merge request GNOME/glib!2610 25 April 2022, 13:37:43 UTC
dfb3517 Philip Withnall 25 April 2022, 11:23:45 UTC gmessages: Error if g_log_set_writer_func() is called multiple times Inspired by https://gitlab.gnome.org/GNOME/glib/-/issues/2638. This requires moving the tests to subprocesses, so that `g_log_set_writer_func()` is only called once per process. It also adds a test for the new error. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 25 April 2022, 11:38:59 UTC
a44a0c0 Philip Withnall 25 April 2022, 10:39:27 UTC Merge branch 'gtype-boxed-type-macro' into 'main' docs: Expand G_DEFINE_BOXED_TYPE docs with more detailed example See merge request GNOME/glib!2612 25 April 2022, 10:39:27 UTC
3a4f074 Logan Rathbone 25 April 2022, 10:39:27 UTC docs: Expand G_DEFINE_BOXED_TYPE docs with more detailed example 25 April 2022, 10:39:27 UTC
cc99d6e Philip Withnall 25 April 2022, 10:30:11 UTC Merge branch 'gio-windows' into 'main' Meson: Fix gio-windows-2.0 override name See merge request GNOME/glib!2615 25 April 2022, 10:30:11 UTC
231a4bb Philip Withnall 25 April 2022, 10:28:39 UTC Merge branch 'update-inout-annotations' into 'main' Add inout annotations for g_iconv See merge request GNOME/glib!2614 25 April 2022, 10:28:39 UTC
7ab50b9 Philip Withnall 25 April 2022, 10:27:15 UTC Merge branch 'gtestutils-add-stdlib' into 'main' gtestutils: Include stdlib.h for exit function See merge request GNOME/glib!2613 25 April 2022, 10:27:15 UTC
199ff2a Xavier Claessens 25 April 2022, 01:29:26 UTC Meson: Fix gio-windows-2.0 override name The override name must match the pkgconfig name. 25 April 2022, 01:29:26 UTC
39378b2 TestingPlant 24 April 2022, 19:15:53 UTC Add inout annotations for g_iconv 24 April 2022, 19:15:53 UTC
444fc6c Bruce Cowan 24 April 2022, 10:30:51 UTC Update British English translation (cherry picked from commit 82feda1ccf6cc1e9af0102629b6e7aee06282335) 24 April 2022, 10:31:01 UTC
3c841f1 Biswapriyo Nath 23 April 2022, 08:32:10 UTC gtestutils: Include stdlib.h for exit function This fixes warning: implicit declaration of function 'exit' 23 April 2022, 08:32:10 UTC
497aba9 Milo Ivir 20 April 2022, 17:46:52 UTC Update Croatian translation 20 April 2022, 17:46:52 UTC
6eddfef Emmanuel Fleury 18 April 2022, 23:31:29 UTC Expand tests on gbookmark file API 19 April 2022, 14:38:41 UTC
d147c36 Ask Hjorth Larsen 18 April 2022, 17:25:00 UTC Updated Danish translation 18 April 2022, 17:25:00 UTC
b5c1626 Emmanuel Fleury 16 April 2022, 13:37:40 UTC Fix spelling mistake in filename when unlinking it after the test. 17 April 2022, 06:08:30 UTC
9ed0dc5 Emmanuel Fleury 16 April 2022, 13:31:21 UTC Clean the file "iochannel-test-outfile" after the test test_small_writes() 17 April 2022, 06:08:30 UTC
8901898 Emmanuel Fleury 16 April 2022, 13:20:34 UTC Cleaning file 'filename' after the test in glib/tests/fileutils.c 17 April 2022, 06:08:23 UTC
15d6558 Enrico Nicoletto 15 April 2022, 17:07:22 UTC Update Brazilian Portuguese translation 15 April 2022, 17:07:22 UTC
41fcb33 Philip Withnall 14 April 2022, 12:26:25 UTC tests: Fix a minor leak in the unicode-normalize test Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Coverity CID: #1487904 14 April 2022, 12:26:25 UTC
d987146 Philip Withnall 14 April 2022, 12:16:19 UTC Merge branch 'w32-tests' into 'main' Fix test suite on Windows See merge request GNOME/glib!2449 14 April 2022, 12:16:19 UTC
e9f46d3 Marc-André Lureau 23 March 2022, 15:12:59 UTC gio/tests: fix socket /socket/credentials/unix_socketpair on win32 When I enabled unix socketpair test on win32, I left the existing g_close(fds[1]), but _g_win32_socketpair() returns native sockets descriptors that must be closed with closesocket() on win32. Let GSocket handle the socket pair cleanup. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> 14 April 2022, 11:38:47 UTC
89539d9 Marc-André Lureau 23 January 2022, 21:49:28 UTC gio/tests: GStatBuf.st_size is 64 bits on win64 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> 14 April 2022, 11:38:47 UTC
ae1ccca Marc-André Lureau 04 February 2022, 10:54:02 UTC glib/gstdio: simplify GStatBuf macro condition for win64 As noted by Charlie Barto: "both mingw64 and msvc define _WIN64 in 64-bit mode, and both are LLP64, and both have struct _stat64 defined the same way." https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2449#note_1372190 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> 14 April 2022, 11:38:47 UTC
f82f477 Marc-André Lureau 21 January 2022, 17:41:28 UTC tests: fix protocol test on win32 The pipe must be closed, or the child PID watch doesn't get triggered. We should remove the message callback source on EOF, as EOF during main loop run will reach a bad assert in the callback. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> 14 April 2022, 11:38:47 UTC
a072c84 Philip Withnall 13 April 2022, 21:12:46 UTC Merge branch 'gdate-no-dst' into 'main' GDate: Fix tests on Windows on certain locales See merge request GNOME/glib!2600 13 April 2022, 21:12:46 UTC
a8f1058 Chun-wei Fan 11 April 2022, 07:18:30 UTC glib/tests/date.c: Fix 2-digit year test ...for certain Windows locales, since the formats accepted for g_date_set_parse() will vary depending on the current system locale. For instance, g_date_set_parse(gdate, "dd/mm/yy") is accepted on locales such as zh-HK (Chinese (Hong Kong SAR)) but is rejected on zh-TW (Chinese (Taiwan)). One can tell from the "date format" settings in the Windows system control panel whether there is a "dd/MM/YYYY" or "dd/MM/YY" option from the drop-down list of date formats to display for the locale, which will indicate whether g_date_set_parse(gdate, "dd/mm/yy") is accepted, which is true for zh-HK but is not true for zh-TW. If g_date_set_parse(gdate, "dd/mm/yy") is not accepted, try again with g_date_set_parse(gdate, "yy/mm/dd") thereafter for the 2-digit-year tests. 12 April 2022, 16:02:57 UTC
697d311 Chun-wei Fan 11 April 2022, 04:17:25 UTC gdate.c: Use standard name if no daylight saving exists We should normally have a standard name for the time zone even if we don't have daylight saving in the time zone, so use the standard name also when GetTimeZoneInformation() returns TIME_ZONE_ID_UNKNOWN[1][2]. [1]: https://docs.microsoft.com/en-us/windows/win32/api/timezoneapi/nf-timezoneapi-gettimezoneinformation [2]: https://docs.microsoft.com/zh-tw/windows/win32/api/timezoneapi/nf-timezoneapi-settimezoneinformation 12 April 2022, 15:43:16 UTC
58f54e8 Philip Withnall 12 April 2022, 13:39:43 UTC tests: Reduce wakeup interval in gdbus-threading When checking that the connection has the expected number of refs, the test would block on a `GMainContext` iteration for up to 3s before waking up and failing (if the refcount was still not as expected). This check was written in the expectation that changing the refcount of the connection would only happen due to dispatching a source on `GMainContext` — hence the `GMainContext` would wake up as the refcount changed. That’s probably not actually true though. It might be the case that the connection’s refcount is changed on from the GDBus worker thread, which would not cause any wakeups on the main thread’s `GMainContext`. In this case, the `GMainContext` iteration in `assert_connection_has_one_ref()` would block for the full 3s, and then wake up and notice the refcount is correct (then the test would proceed). That’s fine, apart from the fact that `test_threaded_singleton()` does this 1000 times. If the slow case is hit on a significant number of those test runs, the test will take around 3000s to complete, which is significantly more than meson’s test timeout of 360s. So the test fails with something like: ``` 220/266 glib:gio+slow / gdbus-threading TIMEOUT 360.07 s --- command --- G_TEST_SRCDIR='/builds/GNOME/glib/gio/tests' GIO_MODULE_DIR='' G_TEST_BUILDDIR='/builds/GNOME/glib/_build/gio/tests' /builds/GNOME/glib/_build/gio/tests/gdbus-threading --- stdout --- \# random seed: R02S83fe8de22db4d4f376e6d179e2bdd601 1..3 \# Start of gdbus tests ok 1 /gdbus/delivery-in-thread ok 2 /gdbus/method-calls-in-thread \# GLib-GIO-DEBUG: refcount of 0x5602de913660 is not right (3 rather than 1) in test_threaded_singleton(), sleeping \# GLib-GIO-DEBUG: refcount of 0x5602de913660 is not right (3 rather than 1) in test_threaded_singleton(), sleeping \# GLib-GIO-DEBUG: refcount of 0x5602de913c60 is not right (3 rather than 1) in test_threaded_singleton(), sleeping \# GLib-GIO-DEBUG: refcount of 0x5602de913c60 is not right (3 rather than 1) in test_threaded_singleton(), sleeping \# GLib-GIO-DEBUG: refcount of 0x5602de913260 is not right (3 rather than 1) in test_threaded_singleton(), sleeping \# GLib-GIO-DEBUG: refcount of 0x5602de913260 is not right (3 rather than 1) in test_threaded_singleton(), sleeping ``` From this log, it can be seen that the sleep is happening on a different `GMainContext` every other time, so the test *is* making progress. Assuming this is a correct diagnosis (it’s a lot of guessing), this commit tries to fix the test by adding a wakeup timeout to the `GMainContext` in `assert_connection_has_one_ref()`, which will wake it up every 50ms to re-check the exit condition. This polling approach has been taken because it doesn’t seem feasible to make sure that every `g_object_ref()`/`g_object_unref()` call on a `GDBusConnection` causes the main context to wake up. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 12 April 2022, 13:39:43 UTC
77416fc Philip Withnall 12 April 2022, 12:28:47 UTC tests: Use g_assert_*() rather than g_assert() in gdbus-peer-object-manager It won’t get compiled out with `G_DISABLE_ASSERT`. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 12 April 2022, 12:29:19 UTC
20c3ab9 Philip Withnall 12 April 2022, 12:27:33 UTC tests: Use G_TEST_OPTION_ISOLATE_DIRS in gdbus-peer-object-manager This might fix a recent test failure: https://gitlab.gnome.org/GNOME/glib/-/jobs/1929015. Unfortunately there’s not much debug information in the logs to go on, and I can’t reproduce it locally. All I have is: ``` 192/272 glib:gio / gdbus-peer-object-manager FAIL 0.43 s (killed by signal 11 SIGSEGV) --- command --- GIO_MODULE_DIR='' G_TEST_BUILDDIR='/builds/GNOME/glib/_build/gio/tests' G_TEST_SRCDIR='/builds/GNOME/glib/gio/tests' /builds/GNOME/glib/_build/gio/tests/gdbus-peer-object-manager --- stdout --- \# random seed: R02Seee9b7325ecd7c19249a3412397aed9b 1..2 \# Start of gdbus tests \# Start of peer-object-manager tests ``` Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 12 April 2022, 12:29:19 UTC
df80a22 Philip Withnall 12 April 2022, 12:21:29 UTC tests: Use g_test_message() rather than fprintf() This ensures that the output is redirected properly, and prefixed with `#` when outputting in TAP mode, so that it doesn’t confuse the TAP format parser. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 12 April 2022, 12:21:29 UTC
ba9620f Philip Withnall 12 April 2022, 12:20:48 UTC tests: Ensure NormalizationTest.txt is installed for installed-tests This should fix the installed-tests CI failure: https://gitlab.gnome.org/GNOME/glib/-/jobs/1946794 Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 12 April 2022, 12:20:48 UTC
fd79c87 Philip Withnall 12 April 2022, 12:00:27 UTC Merge branch 'onceinit_test' into 'main' Move tests/onceinit.c to glib/tests/onceinit.c See merge request GNOME/glib!2601 12 April 2022, 12:00:27 UTC
bb04fdc Simon McVittie 11 April 2022, 15:16:20 UTC Merge branch 'wip/pwithnall/fix-bsd-spawn-test' into 'main' tests: Make a string comparison on an error string more relaxed See merge request GNOME/glib!2597 11 April 2022, 15:16:20 UTC
49ecdd1 Emmanuel Fleury 11 April 2022, 11:35:19 UTC Move tests/onceinit.c to glib/tests/onceinit.c Related to issue #1434 11 April 2022, 13:26:40 UTC
91dddb0 Emmanuel Fleury 11 April 2022, 10:06:54 UTC Convert onceinit.c to glib test framework 11 April 2022, 13:26:33 UTC
3822446 Aleksandr Melman 09 April 2022, 15:34:12 UTC Update Russian translation 09 April 2022, 15:34:12 UTC
51c7215 Yuri Chornoivan 08 April 2022, 11:43:26 UTC Update Ukrainian translation 08 April 2022, 11:43:26 UTC
403edad Philip Withnall 08 April 2022, 11:37:08 UTC ci: Combine style-check-diff and check-todos jobs into one They are functionally quite similar, and combining them saves around 1 minute of CI runner time per pipeline, which is a nice saving for very little downside. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 08 April 2022, 11:37:08 UTC
3515170 Philip Withnall 08 April 2022, 11:25:59 UTC tests: Make a string comparison on an error string more relaxed It currently fails on FreeBSD with: ``` Bail out! GLib:ERROR:../glib/tests/spawn-test.c:111:test_spawn_basics: assertion failed (erroutput == "sort: cannot read: non-existing-file.txt: No such file or directory\n"): ("sort: No such file or directory\n" == "sort: cannot read: non-existing-file.txt: No such file or directory\n") ``` Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 08 April 2022, 11:25:59 UTC
690e64a Philip Withnall 08 April 2022, 10:54:57 UTC Merge branch 'unicode-normalize-test' into 'main' Move test tests/unicode-normalize.c to glib/tests/ See merge request GNOME/glib!2586 08 April 2022, 10:54:57 UTC
be96ea9 Philip Withnall 08 April 2022, 10:54:45 UTC Merge branch 'wip/format_size_value_units' into 'main' gutils: Add flags to g_format_size_full() to return only value or only units See merge request GNOME/glib!2545 08 April 2022, 10:54:45 UTC
900b945 Philip Withnall 08 April 2022, 10:38:36 UTC Merge branch 'spawn_test' into 'main' Move tests/spawn-test.c -> glib/tests/spawn-test.c See merge request GNOME/glib!2575 08 April 2022, 10:38:36 UTC
05a8ef6 Milan Crha 08 March 2022, 17:04:07 UTC gutils: Add flags to g_format_size_full() to return only value or only units This allows to split the formatted size into the value and into the units, when can be shown differently in the UI. Relate to https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1391 08 April 2022, 10:36:03 UTC
b9cbb61 Charles Monzat 08 April 2022, 10:21:58 UTC Update French translation 08 April 2022, 10:21:58 UTC
b25eb38 Emmanuel Fleury 08 April 2022, 09:27:13 UTC Move unicode-normalize test from tests/ to glib/tests/ Helps issue #1434 08 April 2022, 09:27:13 UTC
2c37b92 Emmanuel Fleury 08 April 2022, 09:24:43 UTC Enable and convert tests/unicode-normalize.c to glib test framework 08 April 2022, 09:24:43 UTC
8e5c729 Fran Dieguez 07 April 2022, 21:36:07 UTC Update Galician translation 07 April 2022, 21:36:07 UTC
762ed2e Emmanuel Fleury 29 March 2022, 08:16:05 UTC Move tests/spawn-test.c -> glib/tests/spawn-test.c Related to issue #1434 07 April 2022, 16:36:45 UTC
5a7a69b Emmanuel Fleury 28 March 2022, 22:22:49 UTC Convert tests/spawn-test.c to glib test framework 07 April 2022, 16:36:14 UTC
a7aa029 Philip Withnall 07 April 2022, 11:22:55 UTC Merge branch 'dup-socket' into 'main' gio/tests: DuplicateHandle() is inappropriate for SOCKET See merge request GNOME/glib!2592 07 April 2022, 11:22:55 UTC
2a925f2 Marc-André Lureau 07 April 2022, 11:22:55 UTC gio/tests: DuplicateHandle() is inappropriate for SOCKET 07 April 2022, 11:22:55 UTC
3e9a5d4 Sebastian Dröge 07 April 2022, 10:12:55 UTC Merge branch 'ci-expire-artifacts' into 'main' ci: Expire CI artifacts after 1 week See merge request GNOME/glib!2594 07 April 2022, 10:12:55 UTC
86a24bb Sebastian Dröge 06 April 2022, 13:15:01 UTC Merge branch 'wip/pwithnall/converter-stream-debugging' into 'main' tests: Remove an incorrect assertion in converter-stream See merge request GNOME/glib!2591 06 April 2022, 13:15:01 UTC
f68943d Philip Withnall 06 April 2022, 11:54:54 UTC ci: Expire CI artifacts after 1 week The default is 30 days, but we don’t need them around that long. This should free up some disk space on the GitLab/CI runner systems. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 06 April 2022, 11:54:54 UTC
c80ff24 Sebastian Dröge 06 April 2022, 10:08:35 UTC Merge branch 'wip/pwithnall/2625-clang-cxx' into 'main' gatomic: Add a C++ variant of g_atomic_int_compare_and_exchange() Closes #2625 See merge request GNOME/glib!2578 06 April 2022, 10:08:35 UTC
be555e2 Daniel Mustieles 06 April 2022, 06:21:56 UTC Updated Spanish translation 06 April 2022, 06:21:56 UTC
e2426dd Philip Withnall 05 April 2022, 18:02:15 UTC Merge branch 'list-store-equal-full' into 'main' gio: Add g_list_store_find_with_equal_func_full() Closes #2447 See merge request GNOME/glib!2549 05 April 2022, 18:02:15 UTC
a85246a Jason Francis 13 March 2022, 03:09:29 UTC gio: Add g_list_store_find_with_equal_func_full() Fixes: #2447 05 April 2022, 17:34:39 UTC
aec5d17 Philip Withnall 05 April 2022, 17:19:23 UTC tests: Remove an incorrect assertion in converter-stream While the assertion always turned out to be true on Linux, it frequently caused spurious test failures on FreeBSD. After some remote debugging, I *think* the cause is as written up in the comment in the code in this commit. However, I cannot be certain, as the more debugging messages I added, the harder the failure was to reproduce; and I don’t have access to a FreeBSD machine. This fixes failures like: ``` Bail out! GLib-GIO:ERROR:../gio/tests/converter-stream.c:1043:test_converter_pollable: assertion failed (error == NULL): Resource temporarily unavailable (g-io-error-quark, 27) ``` It’s succeeded 1000 times in a row on the FreeBSD CI now; previously it was failing one time in three: https://gitlab.gnome.org/GNOME/glib/-/jobs/1936395. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 05 April 2022, 17:19:23 UTC
59751e8 Philip Withnall 05 April 2022, 16:32:12 UTC Merge branch 'signal-group-connect-object' into 'main' gobject: Add g_signal_group_connect_closure See merge request GNOME/glib!2521 05 April 2022, 16:32:12 UTC
2a842b1 Jason Francis 22 February 2022, 19:51:37 UTC gobject: Add g_signal_group_connect_closure 05 April 2022, 14:32:20 UTC
28add9a Simon McVittie 05 April 2022, 14:23:53 UTC Merge branch 'test-dbus-exit-on-close' into 'main' tests: Don’t exit gdbus-method-invocation test early on connection close See merge request GNOME/glib!2589 05 April 2022, 14:23:53 UTC
04e5f93 Simon McVittie 05 April 2022, 14:20:14 UTC Merge branch 'version-bump' into 'main' build: Post-release version bump to 2.73.0 See merge request GNOME/glib!2577 05 April 2022, 14:20:14 UTC
82ad051 Philip Withnall 05 April 2022, 13:43:16 UTC tests: Don’t exit gdbus-method-invocation test early on connection close There’s (deliberately) a bit of race in implementing/handling `CloseBeforeReturning()` in `gdbus-method-invocation.c`. If the server closes the D-Bus connection early, the client may exit with `SIGTERM` if `GDBusConnection:exit-on-close` is set. We don’t want that, as the test is trying to check that the default handling of a D-Bus method return after a connection has closed works. See https://gnome.pages.gitlab.gnome.org/-/glib/-/jobs/1935191/artifacts/_build/meson-logs/testlog.txt Signed-off-by: Philip Withnall <pwithnall@endlessos.org> 05 April 2022, 13:43:16 UTC
c9ef0bf Philip Withnall 05 April 2022, 12:49:22 UTC Merge branch 'group-msvc-flags-together' into 'main' Move msvc warnings in meson.build file See merge request GNOME/glib!2584 05 April 2022, 12:49:22 UTC
e5316bb Philip Withnall 05 April 2022, 12:13:03 UTC Merge branch 'issue-2628' into 'main' glib/win32: fix spawn from GUI regression See merge request GNOME/glib!2582 05 April 2022, 12:13:03 UTC
bae0a3c Philip Withnall 05 April 2022, 12:12:19 UTC Merge branch 'badcel/gunixfdlist-only-unix' into 'main' GUnixFDList: Include only in unix build See merge request GNOME/glib!2585 05 April 2022, 12:12:19 UTC
back to top