https://github.com/GNOME/glib

sort by:
Revision Author Date Message Commit Date
074a3f7 xdgmime: Prevent infinite loops from badly-formed MIME registrations Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1875 02 September 2019, 17:02:05 UTC
3e6fe8c Merge branch 'fix-sizeof-check' into 'master' garray: Fix reference to GLIB_SIZEOF_INT See merge request GNOME/glib!1084 02 September 2019, 15:17:23 UTC
4f5a2c1 garray: Fix reference to GLIB_SIZEOF_INT This doesn't ever get set. SIZEOF_INT is set though, so use that instead. 02 September 2019, 14:05:07 UTC
daa308d Merge branch '487-ci-memcheck' into 'master' Add CI job for running tests under Valgrind Closes #487 See merge request GNOME/glib!169 02 September 2019, 13:52:35 UTC
39052a1 tests: Fix some minor memory leaks in tests Signed-off-by: Philip Withnall <withnall@endlessm.com> 02 September 2019, 13:16:33 UTC
8ae07a7 glib.supp: Add some fundamental type suppressions Signed-off-by: Philip Withnall <withnall@endlessm.com> 02 September 2019, 13:16:33 UTC
c8c75dc glib.supp: Fix some indentation Signed-off-by: Philip Withnall <withnall@endlessm.com> 02 September 2019, 13:16:33 UTC
adb9264 glib.supp: Add leak types Mark all the memcheck leaks as ‘reachable’, so the suppressions will not apply if that memory is no longer reachable on exit(). This feature was introduced in Valgrind 3.9, and is documented here: http://valgrind.org/docs/manual/mc-manual.html#mc-manual.suppfiles Signed-off-by: Philip Withnall <withnall@endlessm.com> 02 September 2019, 13:16:33 UTC
a6ecfee tests: Don’t run Python tests under Valgrind The Python runtime is not amenable to Valgrind, and leak checking is a lot less relevant in Python compared to C. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #487 02 September 2019, 13:16:33 UTC
0cc745f ci: Include stderr output in JUnit XML report When running tests under valgrind, the valgrind summary is printed in stderr, and the TAP output is printed in stdout. The valgrind summary is useful to include in the GitLab test report, so append it to the textual failure information for failed tests. I can’t find a better XML element in the [JUnit schema](https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd) for representing it. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #487 02 September 2019, 13:16:33 UTC
197eff3 ci: Add valgrind memcheck support on Fedora Add a separate CI job which runs memcheck on the unit tests. This is done as a separate job from the main build, since we don’t want it to interact with code coverage at all. Currently, failure of this job is ignored. Issue #333 will eventually fix that. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #487 02 September 2019, 13:16:33 UTC
8d19b95 ci: Add valgrind to fedora Docker image It will be used in an upcoming commit. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #487 02 September 2019, 13:16:33 UTC
e8ea2ae gerror: Add a docs paragraph about not displaying errors verbatim in UI It’s confusing and often doesn’t help the user. Match the error code and come up with a more UI-appropriate error message. Signed-off-by: Philip Withnall <withnall@endlessm.com> 02 September 2019, 13:16:33 UTC
cf990fa 2.61.3 Signed-off-by: Philip Withnall <withnall@endlessm.com> 02 September 2019, 12:58:31 UTC
4a089f9 Merge branch 'ossfuzz-16101-iso8601-parsing' into 'master' Improve ISO 8601 parsing by GDateTime See merge request GNOME/glib!1017 02 September 2019, 11:19:04 UTC
a0cbb32 Merge branch '1309-delayed-settings-changed' into 'master' gsettings: Add missing changed() call to delayed settings backend Closes #1309 See merge request GNOME/glib!1046 02 September 2019, 11:14:59 UTC
b3b6830 Merge branch 'wip/lantw/gthread-set-thread-name-on-bsd' into 'master' gthread: Set thread name on *BSD Closes #1761 See merge request GNOME/glib!1072 02 September 2019, 11:10:16 UTC
eca386c Updated Czech translation 02 September 2019, 00:49:46 UTC
7b26d42 Updated Lithuanian translation 01 September 2019, 19:33:58 UTC
199bb53 Update Korean translation 01 September 2019, 09:00:32 UTC
ffef6cf Update Hungarian translation 01 September 2019, 05:39:54 UTC
201c9de Merge branch 'patch-1' into 'master' Adjust README formatting See merge request GNOME/glib!1074 30 August 2019, 07:16:26 UTC
9c8c1c4 Merge branch 'gtype-leak-suppression' into 'master' glib.supp: add suppression for g_type_class_ref() See merge request GNOME/glib!1075 30 August 2019, 06:55:39 UTC
202c07e Merge branch 'goption_add_sanity_checks_to_inputs' into 'master' goption: add sanity check to input parameters Closes #1057 See merge request GNOME/glib!1073 30 August 2019, 06:50:45 UTC
6e4a02b glib.supp: add suppression for g_type_class_ref() This suppression is not caught by glib.supp, so add it: ==21145== 32 bytes in 1 blocks are possibly lost in loss record 1,456 of 2,584 ==21145== at 0x4837B65: calloc (vg_replace_malloc.c:762) ==21145== by 0x495825E: g_malloc0 (gmem.c:129) ==21145== by 0x4A6B6EB: type_class_init_Wm (gtype.c:2134) ==21145== by 0x4A6D22A: g_type_class_ref (gtype.c:2950) ==21145== by 0x4A6D1DD: g_type_class_ref (gtype.c:2942) ==21145== by 0x4A5C9C6: g_param_spec_enum (gparamspecs.c:2085) 30 August 2019, 06:27:31 UTC
13c115e adjust formatting 30 August 2019, 04:58:28 UTC
f178d1b goption: add sanity check to input parameters To avoid dereferencing bad pointers. Closes issue #1057 29 August 2019, 23:07:58 UTC
9456cec Merge branch 'wip/lantw/meson-move-libdl_dep-to-the-top-level' into 'master' meson: Move libdl_dep to the top level See merge request GNOME/glib!1071 29 August 2019, 18:45:36 UTC
f489b6f gthread: Set thread name on *BSD Add support for setting thread name on FreeBSD, DragonFlyBSD, OpenBSD, and NetBSD. Fixes https://gitlab.gnome.org/GNOME/glib/issues/1761 29 August 2019, 17:29:04 UTC
fe3c166 meson: Move libdl_dep to the top level Instead of letting each directory to find its way to link with libdl, it is easier to put the check in the top level, so its result can be used by all directories. It is a follow-up of https://gitlab.gnome.org/GNOME/glib/merge_requests/810. 29 August 2019, 15:25:40 UTC
db66bc7 Merge branch 'bugfix/install-gnativesocketaddress' into 'master' Install header files for GNativeSocketAddress and bump version requirement. Closes #1854 See merge request GNOME/glib!1022 29 August 2019, 13:05:27 UTC
bd4c16b gio: actually install and reference gnativesocketaddress.h. The header file was installed when building using autotools, but was inadvertently omitted in the meson targets. Luckily, ABI is not impacted, since gnativesocketaddress.c was always compiled and linked into libgio. Fixes: #1854 29 August 2019, 12:32:55 UTC
5e18888 gio: Housekeeping: sync up and sort gio_{sources,headers} lists 29 August 2019, 12:32:55 UTC
fea0163 Merge branch 'fix_documentation' into 'master' gsubprocesslauncher.c: fix documentation See merge request GNOME/glib!1068 29 August 2019, 07:18:40 UTC
09e094a gsubprocesslauncher.c: fix documentation The gobject introspection comments have a reference to an incorrect class: they have, as 'self', the GSubprocess class instead of GSubprocessLauncher. This patch fixes this. 28 August 2019, 22:15:03 UTC
bae5173 Merge branch 'update-libffi-wrap-location' into 'master' libffi.wrap: Meson port has moved to FDO gitlab See merge request GNOME/glib!1066 28 August 2019, 08:41:34 UTC
e0e4968 Merge branch 'allow_NULL_argument_to_parse_strv' into 'master' GOption: Allow NULL arguments to parse_strv Closes #873 See merge request GNOME/glib!1064 27 August 2019, 13:17:39 UTC
9d513be GOption: Allow NULL arguments to parse_strv Close issue #873 27 August 2019, 12:44:29 UTC
a521fbd libffi.wrap: Meson port has moved to FDO gitlab 27 August 2019, 12:43:11 UTC
68b4dfd Merge branch 'gsettingsbackend-thread-safe-watches' into 'master' GSettingsBackend - Fix thread-safety during destruction of GSettings instances... Closes #1870 See merge request GNOME/glib!1040 27 August 2019, 09:35:21 UTC
7092b11 Merge branch 'upate-win32-readme' into 'master' Update win32 readme, add myself to codeowners See merge request GNOME/glib!1059 27 August 2019, 08:49:00 UTC
d3ae4b1 GSettingsBackend - Fix thread-safety during destruction of GSettings instances while notifications are emitted g_settings_backend_watch() uses a weak notify for keeping track of the target. There's an explanation why this is supposed to be safe but that explanation is wrong. The following could happen before: 1. We have the target stored in the watch list 2. The last reference to the target is dropped in thread A and we end up in g_settings_backend_watch_weak_notify() right before the mutex 3. g_settings_backend_dispatch_signal() is called from another thread B and gets the mutex before 2. 4. g_weak_ref_init() is called on the target from thread B, which at this point has a reference count of exactly one (see g_object_unref() where it calls the weak notifies) 5. Thread A continues at 3. and drops the last reference and destroys the object. Now the GWeakRef from 4. points to a destroyed object. Note that GWeakRefs would be cleared before the weak notifies are called 6. At some later point another thread g_weak_ref_get() is called by g_settings_backend_invoke_closure() and accesses an already destroyed object with refcount 0 from the GWeakRef created in 4. by thread B (or worse, already freed memory that was reused). Solve this by actually storing a GWeakRef of the target in the watch list and only access the target behind it via the GWeakRef API, and then pass a strong reference to the notification dispatch code. The weak notify is only used to remove the (potentially with empty GWeakRef) target from the list of watches and the only place that compares the target by pointer instead of going through the GWeakRef API. Fixes https://gitlab.gnome.org/GNOME/glib/issues/1870 27 August 2019, 08:09:08 UTC
7952a74 CODEOWNERS: Add myself as co-owner of Windows stuff because I am a sucker for punishment. 27 August 2019, 07:27:32 UTC
184cbbc README.win32: Update and convert to markdown 27 August 2019, 07:27:32 UTC
1c41e34 Merge branch '1819-file-for-uri-null' into 'master' Resolve "Invalid characters in Open Location dialog crashes GIMP" Closes #1819 See merge request GNOME/glib!966 27 August 2019, 05:41:24 UTC
562ac9d gwinhttpvfs: Fall back to wrapped VFS if creating a HTTP file fails If we fail to create a GWinhttpFile for a URI (for example, because it’s an invalid URI or is badly encoded), don’t just return NULL. Instead, fall back to the wrapped VFS which might be able to handle it instead. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1819 27 August 2019, 05:21:26 UTC
4b0421a gwinhttpfile: Document constructor as potentially returning NULL It can return NULL if the URI was badly encoded or couldn’t be handled by Windows’ API. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1819 27 August 2019, 05:21:26 UTC
e24503a gvfs: Add an assertion to check that get_file_for_uri() is never NULL It cannot return a NULL value, as none of its callers have error handlng. Add an assertion to check the values returned by the VFS implementations. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1819 27 August 2019, 05:21:25 UTC
2938847 Merge branch 'easy-uwp-patches' into 'master' Some (probably) easy uwp patches See merge request GNOME/glib!1057 26 August 2019, 20:18:45 UTC
db3e0c2 glib: Don't call MessageBox() when building for UWP However, it's fine to call it when building for the debug target (which uses the debug CRT and hence sets -D_DEBUG), so let's keep that around. The Windows App Certification Kit only runs on apps built in release mode. 26 August 2019, 18:47:29 UTC
2e2558b gmodule: Don't try to use toolhelp for symbol searching on UWP This is not allowed under UWP. 26 August 2019, 18:47:29 UTC
f84ef02 windows: Move G_WINAPI_ONLY_APP to config.h Also set the Windows version to be 10 or newer when targeting UWP, since the Windows 8 SDK does not have many of the APIs we need, such as _beginthreadex. 26 August 2019, 18:47:29 UTC
5998851 Merge branch '1860-macros-available-in' into 'master' glib: Mark various macros as available in certain versions of GLib Closes #1860 See merge request GNOME/glib!1058 26 August 2019, 18:36:33 UTC
d196bfa glib: Mark various macros as available in certain versions of GLib These macros wrap functions which were only introduced in certain versions of GLib. The functions are correctly marked as introduced in those versions, but the macros aren’t, which can result in not getting appropriate deprecation warnings if you’re using those APIs when you have said you’re targeting older GLib versions using `GLIB_VERSION_MAX_ALLOWED`. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1860 26 August 2019, 15:50:16 UTC
fe01e81 gutils: Remove dead code used for Windows SDK versions We require a newer SDK version now, so this is not needed. Specifically, we set _WIN32_WINNT to 0x0601, which sets our SDK requirement to Windows 7+, and this code is only needed for MSVC 5.0, which is ancient. 26 August 2019, 14:16:59 UTC
9c34be6 Merge branch 'error-docs' into 'master' gerror: Add a docs paragraph about not displaying errors verbatim in UI See merge request GNOME/glib!1054 26 August 2019, 13:47:58 UTC
4387f7b Merge branch '1803-gio-open-docs' into 'master' docs: Mention environment variables in `gio open` documentation Closes #1803 See merge request GNOME/glib!1051 26 August 2019, 12:22:06 UTC
1a0ba64 Merge branch '1879-leak-suppressions' into 'master' glib.supp: Add some missing suppressions for one-time allocations Closes #1879 See merge request GNOME/glib!1052 26 August 2019, 12:04:08 UTC
23f405d Merge branch '1881-fix-gio-use-volume-monitor' into 'master' gvolumemonitor: Use GIOModule methods for getting default type Closes #1881 See merge request GNOME/glib!1056 26 August 2019, 11:47:08 UTC
fba54ea gerror: Add a docs paragraph about not displaying errors verbatim in UI It’s confusing and often doesn’t help the user. Match the error code and come up with a more UI-appropriate error message. Signed-off-by: Philip Withnall <withnall@endlessm.com> 26 August 2019, 11:46:55 UTC
0fba8f6 Merge branch 'meson-printf-cleanup' into 'master' meson: small printf check cleanups See merge request GNOME/glib!1032 26 August 2019, 11:08:07 UTC
0d54f00 Merge branch 'gbacktrace_dup2_proper_handling' into 'master' glib/gbacktrace.c: Handling properly the dup(stderr) call Closes #1880 See merge request GNOME/glib!1055 26 August 2019, 11:05:28 UTC
833c24f gvolumemonitor: Use GIOModule methods for getting default type This fixes use of `GIO_USE_VOLUME_MONITOR=help`, and simplifies the code. The reason this wasn’t used already seems to just be because it was missed when `_g_io_module_get_default_type()` was introduced in 2013. The previous `get_default_native_class()` code in `gunionvolumemonitor.c` was introduced in 2007. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1881 26 August 2019, 10:41:26 UTC
1d26d57 Update French translation 26 August 2019, 09:21:54 UTC
4dfb747 Update British English translation 26 August 2019, 09:08:11 UTC
1e3b1eb glib/gbacktrace.c: Handling properly the dup(stderr) call If the dup(stderr) returns '-1' (an error occured), then the program shouldn't call a 'close(stderr); dup(old_err);' after the exec() failed. Fix issue #1880 26 August 2019, 08:49:58 UTC
c21892e Merge branch 'optimize_g_nearest_pow' into 'master' Optimize g_nearest_pow() function in glib/garray.c Closes #83 See merge request GNOME/glib!1030 26 August 2019, 06:21:53 UTC
51c7bad Update Catalan translation 26 August 2019, 06:20:39 UTC
12bd86a Merge branch 'G_SIGNAL_RUN_CLEANUP_do_not_call_accumulate' into 'master' Run the accumulator function for RUN_CLEANUP object handlers too Closes #512 See merge request GNOME/glib!1053 26 August 2019, 06:19:07 UTC
153ac4c Run the accumulator function for RUN_CLEANUP object handlers too Closes issue #512 25 August 2019, 17:31:48 UTC
2f8c613 Optimize g_nearest_pow() function in glib/garray.c Closes issue #83 25 August 2019, 16:37:02 UTC
36a9b2f Update Galician translation 25 August 2019, 16:22:45 UTC
26934c6 glib.supp: Add some missing suppressions for one-time allocations Various memory allocations are still reachable when a process exits, as they contain type system information which can’t be unloaded. Suppress those using `glib.supp`. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1879 25 August 2019, 11:35:27 UTC
d485704 Merge branch 'diagnostic-pragma-fix' into 'master' tests: Fix a pragma warning on FreeBSD See merge request GNOME/glib!1050 25 August 2019, 09:07:48 UTC
73b925b Merge branch 'typos-doc' into 'master' minor typos in the documentation See merge request GNOME/glib!1049 25 August 2019, 08:08:42 UTC
b2eb0a6 docs: Mention environment variables in `gio open` documentation Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1803 25 August 2019, 08:05:07 UTC
512655a minor typos in the documentation (a/an) 24 August 2019, 19:14:05 UTC
c178c97 Merge branch 'static_analysis_2_40_patches' into 'master' Static analysis 2 40 patches Closes #905 See merge request GNOME/glib!1042 24 August 2019, 14:22:38 UTC
651e3b0 glib/goption.c: Replace precondition with assertion A static analysis run noted that we weren't freeing the cmdline in the error path here. We can just make this an assertion instead; I just checked the kernel code, and it just usees a seq_printf() here which will NUL terminate. 24 August 2019, 13:55:49 UTC
649faee gio/gnetworkmonitornetlink.c: Add NULL check on dest before using it 24 August 2019, 13:55:49 UTC
7b0139b gobject/gobject.c: Tweak conditional to pacify static analysis It can't easily see that value is always non-NULL here; this equivalent tweak will show that it is. 24 August 2019, 13:55:49 UTC
f731dd3 gio/glib-compile-resources.c: Unref objects in error path 24 August 2019, 13:44:59 UTC
f9a24ce tests: Fix a pragma warning on FreeBSD This fixes the following warning, by making the compiler checks for the `pop` match those for the `push`: ``` [221/1124] Compiling C object 'glib/tests/d796b50@@mem-overflow@exe/mem-overflow.c.o'. ../glib/tests/mem-overflow.c:204:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas] #pragma GCC diagnostic pop ``` Signed-off-by: Philip Withnall <withnall@endlessm.com> 24 August 2019, 12:49:48 UTC
b46f8ff Update Catalan translation 24 August 2019, 03:31:48 UTC
3c9ff27 Merge branch 'override' into 'master' Meson: Override glib-compile-resources/schemas See merge request GNOME/glib!1037 23 August 2019, 11:30:46 UTC
3beaadc Update Basque translation 23 August 2019, 07:24:59 UTC
a088baf Update German translation 22 August 2019, 18:51:18 UTC
79dd753 Updated Spanish translation 22 August 2019, 13:06:13 UTC
beac955 Update Indonesian translation 22 August 2019, 12:23:57 UTC
8f5111d Update Swedish translation 22 August 2019, 09:54:10 UTC
07beaa6 Merge branch 'wip/smcv/mips-sigaction' into 'master' cond test: Don't make assumptions about struct sigaction member order See merge request GNOME/glib!1036 22 August 2019, 08:42:45 UTC
9564c65 tests: Add ISO 8601 parsing tests for g_date_time_new_from_iso8601() These are copies of the existing tests for `g_time_val_from_iso8601()`, with the test strings which fail for `GDateTime` commented out. This is OK, as it’s documented as only accepting a subset of ISO 8601 (and for some of the test vectors, it’s debatable whether they’re actually valid ISO 8601, depending on how you interpret the valid bounds of timezone offsets — some interpretations of the available documentation would say that timezone offsets should never be ≥24 hours or ≥60 minutes). There is one test string which is not accepted by `g_time_val_from_iso8601()` but which is accepted by `GDateTime`, as `g_date_time_new_from_iso8601()` actually accepts RFC 3339, which is a little more liberal than ISO 8601. Fun times. See https://tools.ietf.org/html/rfc3339#section-5.6. Signed-off-by: Philip Withnall <withnall@endlessm.com> 21 August 2019, 20:36:48 UTC
4ddabfc gdatetime: Avoid an assertion failure when parsing some ISO 8601 dates Some malformed ISO 8601 date/time strings were causing an assertion failure when passed to `g_date_time_new_from_iso8601()`, due to a mismatch between the bounds checking of timezone offsets in `GDateTime` and `GTimeZone`. Fix that and add a unit test for it. oss-fuzz#16101 Signed-off-by: Philip Withnall <withnall@endlessm.com> 21 August 2019, 20:36:48 UTC
415a665 Update Romanian translation 21 August 2019, 20:20:47 UTC
415c0e0 Update Polish translation 21 August 2019, 18:12:21 UTC
13e947d Merge branch '1867-en-gb-isms' into 'master' glib-compile-schemas: Fix some minor en_GB-isms in translatable strings Closes #1867 See merge request GNOME/glib!1038 21 August 2019, 17:53:43 UTC
84cabe9 Merge branch '1620-dbus-proxy-tests' into 'master' Add unit tests for !554 (D-Bus peer to peer usage with bus names) Closes #1620 See merge request GNOME/glib!1045 21 August 2019, 17:25:27 UTC
5f5f98f Merge branch 'test-bug-base' into 'master' Relax use of g_test_bug() to not require g_test_bug_base() to be called first See merge request GNOME/glib!1044 21 August 2019, 17:21:52 UTC
63abca2 gsettings: Add missing changed() call to delayed settings backend When resetting a key in the delayed settings backend, g_settings_backend_changed() was not called to notify the backend of the change. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1309 21 August 2019, 17:08:04 UTC
87a71fe tests: Add a test for peer-to-peer GDBusProxy usage with a bus name This is a regression test for the fix in !554. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1620 21 August 2019, 16:49:06 UTC
back to top