https://github.com/GNOME/glib

sort by:
Revision Author Date Message Commit Date
09e094a gsubprocesslauncher.c: fix documentation The gobject introspection comments have a reference to an incorrect class: they have, as 'self', the GSubprocess class instead of GSubprocessLauncher. This patch fixes this. 28 August 2019, 22:15:03 UTC
bae5173 Merge branch 'update-libffi-wrap-location' into 'master' libffi.wrap: Meson port has moved to FDO gitlab See merge request GNOME/glib!1066 28 August 2019, 08:41:34 UTC
e0e4968 Merge branch 'allow_NULL_argument_to_parse_strv' into 'master' GOption: Allow NULL arguments to parse_strv Closes #873 See merge request GNOME/glib!1064 27 August 2019, 13:17:39 UTC
9d513be GOption: Allow NULL arguments to parse_strv Close issue #873 27 August 2019, 12:44:29 UTC
a521fbd libffi.wrap: Meson port has moved to FDO gitlab 27 August 2019, 12:43:11 UTC
68b4dfd Merge branch 'gsettingsbackend-thread-safe-watches' into 'master' GSettingsBackend - Fix thread-safety during destruction of GSettings instances... Closes #1870 See merge request GNOME/glib!1040 27 August 2019, 09:35:21 UTC
7092b11 Merge branch 'upate-win32-readme' into 'master' Update win32 readme, add myself to codeowners See merge request GNOME/glib!1059 27 August 2019, 08:49:00 UTC
d3ae4b1 GSettingsBackend - Fix thread-safety during destruction of GSettings instances while notifications are emitted g_settings_backend_watch() uses a weak notify for keeping track of the target. There's an explanation why this is supposed to be safe but that explanation is wrong. The following could happen before: 1. We have the target stored in the watch list 2. The last reference to the target is dropped in thread A and we end up in g_settings_backend_watch_weak_notify() right before the mutex 3. g_settings_backend_dispatch_signal() is called from another thread B and gets the mutex before 2. 4. g_weak_ref_init() is called on the target from thread B, which at this point has a reference count of exactly one (see g_object_unref() where it calls the weak notifies) 5. Thread A continues at 3. and drops the last reference and destroys the object. Now the GWeakRef from 4. points to a destroyed object. Note that GWeakRefs would be cleared before the weak notifies are called 6. At some later point another thread g_weak_ref_get() is called by g_settings_backend_invoke_closure() and accesses an already destroyed object with refcount 0 from the GWeakRef created in 4. by thread B (or worse, already freed memory that was reused). Solve this by actually storing a GWeakRef of the target in the watch list and only access the target behind it via the GWeakRef API, and then pass a strong reference to the notification dispatch code. The weak notify is only used to remove the (potentially with empty GWeakRef) target from the list of watches and the only place that compares the target by pointer instead of going through the GWeakRef API. Fixes https://gitlab.gnome.org/GNOME/glib/issues/1870 27 August 2019, 08:09:08 UTC
7952a74 CODEOWNERS: Add myself as co-owner of Windows stuff because I am a sucker for punishment. 27 August 2019, 07:27:32 UTC
184cbbc README.win32: Update and convert to markdown 27 August 2019, 07:27:32 UTC
1c41e34 Merge branch '1819-file-for-uri-null' into 'master' Resolve "Invalid characters in Open Location dialog crashes GIMP" Closes #1819 See merge request GNOME/glib!966 27 August 2019, 05:41:24 UTC
562ac9d gwinhttpvfs: Fall back to wrapped VFS if creating a HTTP file fails If we fail to create a GWinhttpFile for a URI (for example, because it’s an invalid URI or is badly encoded), don’t just return NULL. Instead, fall back to the wrapped VFS which might be able to handle it instead. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1819 27 August 2019, 05:21:26 UTC
4b0421a gwinhttpfile: Document constructor as potentially returning NULL It can return NULL if the URI was badly encoded or couldn’t be handled by Windows’ API. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1819 27 August 2019, 05:21:26 UTC
e24503a gvfs: Add an assertion to check that get_file_for_uri() is never NULL It cannot return a NULL value, as none of its callers have error handlng. Add an assertion to check the values returned by the VFS implementations. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1819 27 August 2019, 05:21:25 UTC
2938847 Merge branch 'easy-uwp-patches' into 'master' Some (probably) easy uwp patches See merge request GNOME/glib!1057 26 August 2019, 20:18:45 UTC
db3e0c2 glib: Don't call MessageBox() when building for UWP However, it's fine to call it when building for the debug target (which uses the debug CRT and hence sets -D_DEBUG), so let's keep that around. The Windows App Certification Kit only runs on apps built in release mode. 26 August 2019, 18:47:29 UTC
2e2558b gmodule: Don't try to use toolhelp for symbol searching on UWP This is not allowed under UWP. 26 August 2019, 18:47:29 UTC
f84ef02 windows: Move G_WINAPI_ONLY_APP to config.h Also set the Windows version to be 10 or newer when targeting UWP, since the Windows 8 SDK does not have many of the APIs we need, such as _beginthreadex. 26 August 2019, 18:47:29 UTC
5998851 Merge branch '1860-macros-available-in' into 'master' glib: Mark various macros as available in certain versions of GLib Closes #1860 See merge request GNOME/glib!1058 26 August 2019, 18:36:33 UTC
d196bfa glib: Mark various macros as available in certain versions of GLib These macros wrap functions which were only introduced in certain versions of GLib. The functions are correctly marked as introduced in those versions, but the macros aren’t, which can result in not getting appropriate deprecation warnings if you’re using those APIs when you have said you’re targeting older GLib versions using `GLIB_VERSION_MAX_ALLOWED`. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1860 26 August 2019, 15:50:16 UTC
fe01e81 gutils: Remove dead code used for Windows SDK versions We require a newer SDK version now, so this is not needed. Specifically, we set _WIN32_WINNT to 0x0601, which sets our SDK requirement to Windows 7+, and this code is only needed for MSVC 5.0, which is ancient. 26 August 2019, 14:16:59 UTC
9c34be6 Merge branch 'error-docs' into 'master' gerror: Add a docs paragraph about not displaying errors verbatim in UI See merge request GNOME/glib!1054 26 August 2019, 13:47:58 UTC
4387f7b Merge branch '1803-gio-open-docs' into 'master' docs: Mention environment variables in `gio open` documentation Closes #1803 See merge request GNOME/glib!1051 26 August 2019, 12:22:06 UTC
1a0ba64 Merge branch '1879-leak-suppressions' into 'master' glib.supp: Add some missing suppressions for one-time allocations Closes #1879 See merge request GNOME/glib!1052 26 August 2019, 12:04:08 UTC
23f405d Merge branch '1881-fix-gio-use-volume-monitor' into 'master' gvolumemonitor: Use GIOModule methods for getting default type Closes #1881 See merge request GNOME/glib!1056 26 August 2019, 11:47:08 UTC
fba54ea gerror: Add a docs paragraph about not displaying errors verbatim in UI It’s confusing and often doesn’t help the user. Match the error code and come up with a more UI-appropriate error message. Signed-off-by: Philip Withnall <withnall@endlessm.com> 26 August 2019, 11:46:55 UTC
0fba8f6 Merge branch 'meson-printf-cleanup' into 'master' meson: small printf check cleanups See merge request GNOME/glib!1032 26 August 2019, 11:08:07 UTC
0d54f00 Merge branch 'gbacktrace_dup2_proper_handling' into 'master' glib/gbacktrace.c: Handling properly the dup(stderr) call Closes #1880 See merge request GNOME/glib!1055 26 August 2019, 11:05:28 UTC
833c24f gvolumemonitor: Use GIOModule methods for getting default type This fixes use of `GIO_USE_VOLUME_MONITOR=help`, and simplifies the code. The reason this wasn’t used already seems to just be because it was missed when `_g_io_module_get_default_type()` was introduced in 2013. The previous `get_default_native_class()` code in `gunionvolumemonitor.c` was introduced in 2007. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1881 26 August 2019, 10:41:26 UTC
1d26d57 Update French translation 26 August 2019, 09:21:54 UTC
4dfb747 Update British English translation 26 August 2019, 09:08:11 UTC
1e3b1eb glib/gbacktrace.c: Handling properly the dup(stderr) call If the dup(stderr) returns '-1' (an error occured), then the program shouldn't call a 'close(stderr); dup(old_err);' after the exec() failed. Fix issue #1880 26 August 2019, 08:49:58 UTC
c21892e Merge branch 'optimize_g_nearest_pow' into 'master' Optimize g_nearest_pow() function in glib/garray.c Closes #83 See merge request GNOME/glib!1030 26 August 2019, 06:21:53 UTC
51c7bad Update Catalan translation 26 August 2019, 06:20:39 UTC
12bd86a Merge branch 'G_SIGNAL_RUN_CLEANUP_do_not_call_accumulate' into 'master' Run the accumulator function for RUN_CLEANUP object handlers too Closes #512 See merge request GNOME/glib!1053 26 August 2019, 06:19:07 UTC
153ac4c Run the accumulator function for RUN_CLEANUP object handlers too Closes issue #512 25 August 2019, 17:31:48 UTC
2f8c613 Optimize g_nearest_pow() function in glib/garray.c Closes issue #83 25 August 2019, 16:37:02 UTC
36a9b2f Update Galician translation 25 August 2019, 16:22:45 UTC
26934c6 glib.supp: Add some missing suppressions for one-time allocations Various memory allocations are still reachable when a process exits, as they contain type system information which can’t be unloaded. Suppress those using `glib.supp`. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1879 25 August 2019, 11:35:27 UTC
d485704 Merge branch 'diagnostic-pragma-fix' into 'master' tests: Fix a pragma warning on FreeBSD See merge request GNOME/glib!1050 25 August 2019, 09:07:48 UTC
73b925b Merge branch 'typos-doc' into 'master' minor typos in the documentation See merge request GNOME/glib!1049 25 August 2019, 08:08:42 UTC
b2eb0a6 docs: Mention environment variables in `gio open` documentation Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1803 25 August 2019, 08:05:07 UTC
512655a minor typos in the documentation (a/an) 24 August 2019, 19:14:05 UTC
c178c97 Merge branch 'static_analysis_2_40_patches' into 'master' Static analysis 2 40 patches Closes #905 See merge request GNOME/glib!1042 24 August 2019, 14:22:38 UTC
651e3b0 glib/goption.c: Replace precondition with assertion A static analysis run noted that we weren't freeing the cmdline in the error path here. We can just make this an assertion instead; I just checked the kernel code, and it just usees a seq_printf() here which will NUL terminate. 24 August 2019, 13:55:49 UTC
649faee gio/gnetworkmonitornetlink.c: Add NULL check on dest before using it 24 August 2019, 13:55:49 UTC
7b0139b gobject/gobject.c: Tweak conditional to pacify static analysis It can't easily see that value is always non-NULL here; this equivalent tweak will show that it is. 24 August 2019, 13:55:49 UTC
f731dd3 gio/glib-compile-resources.c: Unref objects in error path 24 August 2019, 13:44:59 UTC
f9a24ce tests: Fix a pragma warning on FreeBSD This fixes the following warning, by making the compiler checks for the `pop` match those for the `push`: ``` [221/1124] Compiling C object 'glib/tests/d796b50@@mem-overflow@exe/mem-overflow.c.o'. ../glib/tests/mem-overflow.c:204:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas] #pragma GCC diagnostic pop ``` Signed-off-by: Philip Withnall <withnall@endlessm.com> 24 August 2019, 12:49:48 UTC
b46f8ff Update Catalan translation 24 August 2019, 03:31:48 UTC
3c9ff27 Merge branch 'override' into 'master' Meson: Override glib-compile-resources/schemas See merge request GNOME/glib!1037 23 August 2019, 11:30:46 UTC
3beaadc Update Basque translation 23 August 2019, 07:24:59 UTC
a088baf Update German translation 22 August 2019, 18:51:18 UTC
79dd753 Updated Spanish translation 22 August 2019, 13:06:13 UTC
beac955 Update Indonesian translation 22 August 2019, 12:23:57 UTC
8f5111d Update Swedish translation 22 August 2019, 09:54:10 UTC
07beaa6 Merge branch 'wip/smcv/mips-sigaction' into 'master' cond test: Don't make assumptions about struct sigaction member order See merge request GNOME/glib!1036 22 August 2019, 08:42:45 UTC
415a665 Update Romanian translation 21 August 2019, 20:20:47 UTC
415c0e0 Update Polish translation 21 August 2019, 18:12:21 UTC
13e947d Merge branch '1867-en-gb-isms' into 'master' glib-compile-schemas: Fix some minor en_GB-isms in translatable strings Closes #1867 See merge request GNOME/glib!1038 21 August 2019, 17:53:43 UTC
84cabe9 Merge branch '1620-dbus-proxy-tests' into 'master' Add unit tests for !554 (D-Bus peer to peer usage with bus names) Closes #1620 See merge request GNOME/glib!1045 21 August 2019, 17:25:27 UTC
5f5f98f Merge branch 'test-bug-base' into 'master' Relax use of g_test_bug() to not require g_test_bug_base() to be called first See merge request GNOME/glib!1044 21 August 2019, 17:21:52 UTC
87a71fe tests: Add a test for peer-to-peer GDBusProxy usage with a bus name This is a regression test for the fix in !554. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1620 21 August 2019, 16:49:06 UTC
a01983f tests: Add a test for g_dbus_connection_get_flags() It was added in !554 but never had a unit test. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1620 21 August 2019, 16:49:06 UTC
9fc745d tests: Drop unnecessary usage of g_test_bug_base("") See the previous commit. Signed-off-by: Philip Withnall <withnall@endlessm.com> 21 August 2019, 16:42:27 UTC
e7b857a gtestutils: Allow g_test_bug() to be used without g_test_bug_base() Since we transitioned from Bugzilla to GitLab, we have two forms of bug references in the GLib source code: old (but still relevant) Bugzilla links, and newer GitLab links. We can’t use a single base for the two, so have to either build incorrect URIs, or provide the full URI in g_test_bug(). It’s always seemed a bit of an over-optimisation to provide the bug base separately from the bug ID, so relax the assertions and documentation around g_test_bug_base() so that g_test_bug() can be used on its own. The old usage patterns are still supported unchanged. Signed-off-by: Philip Withnall <withnall@endlessm.com> 21 August 2019, 16:41:05 UTC
5558c66 Update Polish translation 21 August 2019, 15:59:03 UTC
26f7104 meson: small cleanup for printf checks Instead of duplicating checks add a use_system_printf meson variable and macro and use them everywhere. 20 August 2019, 15:19:26 UTC
271e283 meson: Remove an outdated todo re HAVE_UNIX98_PRINTF We have checks for HAVE_UNIX98_PRINTF now. The macro is unused, but we need the checks to decide if the printf is good enough as is. 20 August 2019, 15:19:26 UTC
a5f0e64 Merge branch 'win32-no-sys-printf' into 'master' win32: don't assume the format specifier for the stdlib printf/scanf like functions See merge request GNOME/glib!1033 20 August 2019, 14:08:58 UTC
6ea818f Merge branch 'meson-good-printf-fixes' into 'master' meson: build gnulib if printf isn't good enough See merge request GNOME/glib!1031 19 August 2019, 21:22:47 UTC
248e30e Updated Lithuanian translation 18 August 2019, 19:14:44 UTC
c2f8267 Update Swedish translation 17 August 2019, 13:00:29 UTC
798b996 Update Basque translation 14 August 2019, 14:24:19 UTC
389b182 glib-compile-schemas: Fix some minor en_GB-isms in translatable strings Spotted by Bruce Cowan. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1867 14 August 2019, 08:38:23 UTC
10be2c1 Update Catalan translation 14 August 2019, 05:57:18 UTC
0984b54 Merge branch 'wip/smcv/reproducer-for-1852' into 'master' glib/tests/fileutils: Add a reproducer for #1852 See merge request GNOME/glib!1034 13 August 2019, 15:23:22 UTC
fdcdd5c Meson: Override glib-compile-resources/schemas This fix build error for projects that use gnome.compile_resources() when glib is built as a subproject and not installed on the build machine. Note that this is not working for cross compilation cases, because it would require to compile everything twice (for host and build machines). A better solution would be to rewrite those tools in python. See #1859. 13 August 2019, 12:52:50 UTC
09b3bf2 Merge branch 'post-release-version-bump' into 'master' Post-release version bump See merge request GNOME/glib!1015 13 August 2019, 09:04:01 UTC
18ae2b3 cond test: Don't make assumptions about struct sigaction member order On x86 (and apparently most other Linux architectures), the union with the signal handler is the first member, but on MIPS Linux, the first struct member is sa_flags (possibly done to be compatible with IRIX). Zero out the struct and fill in the field we want by name. Signed-off-by: Simon McVittie <smcv@collabora.com> 13 August 2019, 07:41:09 UTC
941c0bd glib/tests/fileutils: Add a reproducer for #1852 This test passes on the glib-2-60 branch, and failed before merging !1027. Signed-off-by: Simon McVittie <smcv@collabora.com> 13 August 2019, 07:37:40 UTC
6d7143e Merge branch 'wip/carlosg/utf8-strreverse-invalid-writes' into 'master' gutf8: Assert that written memory stays in bounds See merge request GNOME/glib!1026 12 August 2019, 10:39:11 UTC
870b30b Merge branch 'wip/carlosg/fix-mkdir-with-parents-errors' into 'master' gfileutils: Fix error propagation for other than ENOENT See merge request GNOME/glib!1027 12 August 2019, 08:01:59 UTC
0ae99bf Update Indonesian translation 12 August 2019, 06:03:05 UTC
6095b9b win32: don't assume the format specifier for the stdlib printf/scanf like functions When using the mingw printf shims for C99 compat the msvc format specifiers don't work and the build fails. Ideally we would use glib functions which abstract this away, but in the error handler context we shouldn't call back into glib. And for scanf we don't have a glib wrapper. Instead call the "secure" versions provided by the win32 API (_snprintf_s/fprintf_s/sscanf_s) which mingw doesn't replace. 10 August 2019, 19:56:33 UTC
6e1ceb1 meson: build gnulib if printf isn't good enough We currently check in multiple places if vsnprintf/snprintf/printf are good and if not use gnulib. This case was not checking for printf which made the build fail with recent mingw-w64 where snprintf was improved to pass all glib checks but printf still doesn't. 10 August 2019, 14:03:44 UTC
3a4a665 gfileutils: Fix error propagation for other than ENOENT Commit 6f55306e04e5 unintendedly broke error handling for other error conditions than ENOENT along the path, like EPERM. It wanted to ignore ENOENT on all elements except the last in the path, but in doing that it ignored any other error that might happen on the last element. https://gitlab.gnome.org/GNOME/glib/issues/1852 08 August 2019, 00:32:46 UTC
154f6ca gutf8: Assert that written memory stays in bounds You may expect funny effects from passing invalid UTF-8, but not that funny. The assert will probably be a better and more immediate confirmation of an error than invalid writes under the address of the string copy. https://gitlab.gnome.org/GNOME/glib/issues/1863 07 August 2019, 21:33:46 UTC
179fdc5 Update Romanian translation 05 August 2019, 14:03:50 UTC
37b2093 Merge branch 'contributing-fixes' into 'master' Remove mentions of mailing lists from the documentation See merge request GNOME/glib!1002 05 August 2019, 10:20:40 UTC
57b6b4b Merge branch 'g-object-get-property-zero-init' into 'master' g_object_get_property: Improve documentation for use of G_VALUE_INIT See merge request GNOME/glib!1023 01 August 2019, 09:47:56 UTC
41d31cd g_object_get_property: Document accepting G_VALUE_INIT as new API Code intended to be portable to older versions of GLib cannot rely on this being considered valid. Signed-off-by: Simon McVittie <smcv@collabora.com> 01 August 2019, 08:29:52 UTC
bf8b669 g_object_get_property: Clarify meaning of G_TYPE_INVALID "Uninitialized value" is partially correct, since it has not been initialized with a type, but it's more precise to say "zero-initialized value". It is still a programming error to pass a pointer to uninitialized memory with arbitrary contents as the value. Signed-off-by: Simon McVittie <smcv@collabora.com> 01 August 2019, 08:29:52 UTC
1f79c7f Updated Spanish translation 30 July 2019, 07:38:18 UTC
84738f7 Merge branch 'wip/hadess/gnetworkmonitor-nm-fixups' into 'master' gnetworkmonitornm fixups See merge request GNOME/glib!1016 29 July 2019, 15:47:55 UTC
b80fcc6 tests: Remove unneeded ";" in G_DEFINE_INTERFACE_WITH_CODE 29 July 2019, 15:28:01 UTC
f299886 gnetworkmonitornm: Remove double-space 29 July 2019, 15:28:01 UTC
109f247 gnetworkmonitornm: Arguments to g-signal's callback are const 29 July 2019, 15:28:01 UTC
7d3ecce gnetworkmonitornm: Disconnect g-signal from proxy So that we're sure never to receive a signal if something is keeping the proxy alive. 29 July 2019, 15:28:01 UTC
ef1d5b5 gnetworkmonitornm: Remove unneeded ";" in G_DEFINE_INTERFACE_WITH_CODE 29 July 2019, 15:28:01 UTC
back to top