Skip to main content

Browse the archive

https://github.com/GNOME/glib
05 April 2024, 22:37:37 UTC
sort by:
Revision Author Date Message Commit Date
0d94ee3 Philip Withnall 08 October 2019, 10:33:40 UTC Merge branch 'master' into 'master' Erase GI annotation: skip g_cancellable_source_new Closes #1877 See merge request GNOME/glib!1048 08 October 2019, 10:33:40 UTC
45c91d7 Philip Withnall 08 October 2019, 10:30:24 UTC Merge branch 'g-os-info' into 'master' gutils: Add g_get_os_info() See merge request GNOME/glib!1063 08 October 2019, 10:30:24 UTC
ab613ae Philip Withnall 08 October 2019, 10:26:45 UTC Merge branch '1726-gdbus-codegen-h' into 'master' Resolve "Warn when method/signal uses type 'h' but lacks GDBus.C.UnixFD annotation" Closes #1726 See merge request GNOME/glib!1079 08 October 2019, 10:26:45 UTC
b229eed Philip Withnall 07 October 2019, 17:21:32 UTC Merge branch 'str-printf-abort-oom' into 'master' Ensure that g_vasprintf will always abort on OOM and some docs fixes Closes #1622 See merge request GNOME/glib!1145 07 October 2019, 17:21:32 UTC
109be1e Daniel P. Berrangé 04 October 2019, 14:04:01 UTC glib: add parameter annotations for g_vasprintf and callers Document that g_vasprintf and g_strdup_printf are guaranteed to return a non-NULL string, unless the format string contains the locale sensitive conversions %lc or %ls. Further annotate that the output parameter for g_vasprintf and the format string for all functions must be non-NULL. Fixes #1622 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> 07 October 2019, 16:29:34 UTC
1403501 Daniel P. Berrangé 04 October 2019, 12:52:39 UTC glib: ensure consistent abort-on-OOM with g_vasprintf & its callers The g_vasprintf method is called by g_strdup_vprintf, g_strdup_printf, g_string_append_vprintf and more. It has three different implementations depending on what the build target platform supports: 1. The gnulib impl appears to use the system malloc, but a '#define malloc g_malloc' causes it to use GLib's wrapper and thus abort on OOM. This mostly gets used on Windows platforms or UNIX platforms with broken printf formatting. 2. The main impl mostly used on modern Linux/UNIX calls the system vasprintf which uses the system malloc and does not abort on OOM. 3. The final impl used on remaining platforms calls system vsprintf on a buffer allocated by g_new, and thus always aborts on OOM. Of note is that impl 2 (using vasprintf) historically could abort on OOM, if the application had installed a non-system malloc impl with GLib. This was because the code would g_strndup the result from vasprintf() in that scenario. This was removed in: commit a3660532535f92cfac136435579ed4f23231f48c Author: Dan Winship <danw@gnome.org> Date: Fri Aug 7 09:46:49 2015 -0400 glib: remove deprecated g_mem_is_system_malloc() check in gprintf.c Having inconsistent OOM behaviour for the three impls is undesirable and aborting on OOM is normal pratice for GLib APIs. Thus we must thus ensure this happens in all impls of g_vasprintf. Fixes #1622 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> 07 October 2019, 16:29:29 UTC
4e12e7e Philip Withnall 07 October 2019, 13:22:30 UTC Merge branch 'th/main-context-default-no-mutex' into 'master' gmain: use atomic operation instead of GMutex to access g_main_context_default() See merge request GNOME/glib!1135 07 October 2019, 13:22:30 UTC
39dd2be Thomas Haller 07 October 2019, 13:22:30 UTC gmain: use atomic operation instead of GMutex to access g_main_context_default() I think it is wasteful to use a mutex every time the default main context is accessed. Especially, as the default main context is used all the time. 07 October 2019, 13:22:30 UTC
038ec3d Philip Withnall 07 October 2019, 13:07:56 UTC Merge branch 'add_array_steal_function' into 'master' Add g_array_steal(), g_ptr_array_steal() and g_byte_array_steal() Closes #285 See merge request GNOME/glib!1019 07 October 2019, 13:07:56 UTC
7bada83 Paolo Bonzini 30 July 2019, 17:22:05 UTC Add g_array_steal(), g_ptr_array_steal() and g_byte_array_steal() Closes issue #285 07 October 2019, 12:38:24 UTC
c88f106 Philip Withnall 07 October 2019, 09:23:41 UTC Merge branch 'wip/oholy/gio-completion' into 'master' Several gio-tool bash completion fixes and improvements See merge request GNOME/glib!1153 07 October 2019, 09:23:41 UTC
a350fa5 Philip Withnall 07 October 2019, 09:04:06 UTC Merge branch 'winhttp-handle-null-prgname' into 'master' gwinhttpvfs: Handle g_get_prgname() returning NULL See merge request GNOME/glib!1152 07 October 2019, 09:04:06 UTC
419b7d0 Philip Withnall 07 October 2019, 08:53:01 UTC Merge branch 'glib-g_ptr_array_sort_api_doc_example' 07 October 2019, 08:53:01 UTC
52c130f Lee Bigelow 01 August 2019, 08:30:01 UTC Add full examples to g_ptr_array_sort() and g_ptr_array_sort_with_data() With changes by Emmanuel Fleury and Philip Withnall. Closes issue #9 07 October 2019, 08:50:51 UTC
acf55ad Philip Withnall 07 October 2019, 08:44:39 UTC Merge branch 'solaris-build-fixes' into 'master' Solaris build fixes See merge request GNOME/glib!1146 07 October 2019, 08:44:39 UTC
b3bf1e2 Ondrej Holy 03 October 2019, 13:09:56 UTC gio: Always include mounts in the results Mounts are currently completed only if the prefix looks like scheme, however, this doesn't work well if the mounts have also path component. Let's always include them to fix this issue. The mounts are cached by the volume monitors, so it should not significantly affect the performance. 07 October 2019, 07:21:19 UTC
8bc5210 Ondrej Holy 03 October 2019, 12:58:52 UTC gio: Complete also activation roots of volumes Currently, "gio mount google-drive<tab>" isn't completed even though that volume exists for google-drive://oholy@redhat.com/. Let's use "gio mount -li" output to complete also activation roots of volumes. 07 October 2019, 07:21:19 UTC
3a1492e Ondrej Holy 03 October 2019, 12:44:57 UTC gio: Fix completion of URIs without hostname part Currently, "gio list file:///h<tab>" doesn't complete "file:///home" because the result of "dirname file:///h" is not "file:///" but "file:/", which breaks the consequent logic. Let's subtract basename from the path in order to workaround this issue. 07 October 2019, 07:21:09 UTC
bf2a102 Christoph Reiter 06 October 2019, 18:05:44 UTC gwinhttpvfs: Handle g_get_prgname() returning NULL When prgname wasn't set NULL would be passed to g_utf8_to_utf16() resulting in "g_utf8_to_utf16: assertion 'str != NULL' failed" 06 October 2019, 18:05:44 UTC
dd27d2b Simon McVittie 06 October 2019, 13:18:44 UTC Merge branch 'patch-1' into 'master' gio/gfile: fix parameter reference for value_p See merge request GNOME/glib!1149 06 October 2019, 13:18:44 UTC
cb97f0e Simon McVittie 06 October 2019, 13:17:59 UTC Merge branch 'dlech-master-patch-99473' into 'master' gio/gfileinfo: fix parameter references See merge request GNOME/glib!1148 06 October 2019, 13:17:59 UTC
5ac73a0 Simon McVittie 06 October 2019, 13:17:17 UTC Merge branch 'patch-2' into 'master' gio/gfile: fix parameter references to @contents See merge request GNOME/glib!1150 06 October 2019, 13:17:17 UTC
c46c31d Simon McVittie 06 October 2019, 13:16:23 UTC Merge branch 'patch-3' into 'master' gio/gfile: fix typo in doc comment See merge request GNOME/glib!1151 06 October 2019, 13:16:23 UTC
4723bf5 David Lechner 06 October 2019, 02:01:48 UTC gio/gfile: fix typo in doc comment This fixes a typo in g_file_has_prefix() do comments. 06 October 2019, 02:01:48 UTC
f71eca1 David Lechner 06 October 2019, 01:55:40 UTC gio/gfile: fix parameter references to @contents Fix a number of occurrences where the parameter reference was missing the trailing 's' 06 October 2019, 01:55:40 UTC
5120f92 David Lechner 06 October 2019, 01:48:15 UTC gio/gfile: fix parameter reference for value_p This fixes a parameter reference to @value_p in g_file_set_attribute() 06 October 2019, 01:48:15 UTC
5dee526 David Lechner 05 October 2019, 22:36:19 UTC gio/gfileinfo: fix parameter references This fixes a couple of parameter references for @info in the doc comments. 05 October 2019, 22:36:19 UTC
25ed7d4 Sebastian Dröge 05 October 2019, 06:56:01 UTC Merge branch 'gmodule-typo' into 'master' gmodule: fix typo in doc comment See merge request GNOME/glib!1147 05 October 2019, 06:56:01 UTC
5a57bdb David Lechner 05 October 2019, 01:45:22 UTC gmodule: fix typo in doc comment s/opended/opened/ 05 October 2019, 01:45:22 UTC
2b34f52 Alan Coopersmith 04 October 2019, 20:23:25 UTC build: no --export-dynamic ldflags for Solaris Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> 04 October 2019, 20:23:25 UTC
e5e1490 Alan Coopersmith 04 October 2019, 19:55:14 UTC gunixmounts: Handle Solaris name of mnt_mntopts in place of mnt_opts Fixes build failure: ../gio/gunixmounts.c: In function ‘_g_get_unix_mounts’: ../gio/gunixmounts.c:742:53: error: ‘struct mnttab’ has no member named ‘mnt_opts’; did you mean ‘mnt_mntopts’? 742 | mntent.mnt_opts, | ^~~~~~~~ | mnt_mntopts Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> 04 October 2019, 19:55:17 UTC
c08e7b9 Emmanuele Bassi 04 October 2019, 14:51:10 UTC Merge branch 'switch_to_gnu99' into 'master' Switching from C gnu89 to C gnu99 standard See merge request GNOME/glib!1035 04 October 2019, 14:51:10 UTC
66da7be Philip Withnall 04 October 2019, 13:55:44 UTC 2.63.0 Signed-off-by: Philip Withnall <withnall@endlessm.com> 04 October 2019, 13:55:44 UTC
d207e19 Philip Withnall 03 October 2019, 12:12:16 UTC Merge branch 'wip/tingping/pkcs11' into 'master' gtlscertificate: Add pkcs11-uri property and constructor Closes #1809 See merge request GNOME/glib!933 03 October 2019, 12:12:16 UTC
b6d8efb Patrick Griffis 19 June 2019, 16:10:52 UTC gtlscertificate: Add support for PKCS #11 backed certificates This adds properties to allow backends to expose PKCS #11 support. 02 October 2019, 17:12:40 UTC
0c40f3f Philip Withnall 02 October 2019, 15:54:19 UTC Merge branch 'cross-installed-tests' into 'master' Always build tests if we enabled installed-tests See merge request GNOME/glib!1138 02 October 2019, 15:54:19 UTC
406c8b0 Philip Withnall 02 October 2019, 15:40:09 UTC Merge branch 'file-permissions-redux' into 'master' Fix handling of G_FILE_COPY_TARGET_DEFAULT_PERMISSIONS in g_file_copy() Closes #174 See merge request GNOME/glib!1134 02 October 2019, 15:40:09 UTC
9a5a5c8 Sebastian Dröge 02 October 2019, 08:52:40 UTC Merge branch 'exact-mtime' into 'master' g_file_info_get_modification_date_time: Calculate in integer domain See merge request GNOME/glib!1139 02 October 2019, 08:52:40 UTC
14609b0 Simon McVittie 01 October 2019, 22:27:53 UTC g_file_info_get_modification_date_time: Calculate in integer domain g_date_time_add_seconds() and g_date_time_add_full() use floating-point seconds, which can result in the value varying slightly from what's actually on disk. This causes intermittent test failures in gio/tests/g-file-info.c on Debian i386, where we set a file's mtime to be 50µs later, then read it back and sometimes find that it is only 49µs later than the previous value. I've only seen this happen on i386, which means it might be to do with different floating-point rounding when a value is stored in the 80-bit legacy floating point registers rather than in double precision. g_date_time_add() takes a GTimeSpan, which is in microseconds; conveniently, that's exactly what we get from the GFileInfo. Bug-Debian: https://bugs.debian.org/941547 Signed-off-by: Simon McVittie <smcv@collabora.com> 02 October 2019, 07:30:35 UTC
788c01d Ask Hjorth Larsen 02 October 2019, 03:54:08 UTC Updated Danish translation 02 October 2019, 03:54:08 UTC
42d8e17 Simon McVittie 01 October 2019, 18:51:48 UTC Always build tests if we enabled installed-tests If we're cross-compiling, the installed-tests are useful even if we can't run them on the build machine: we can copy them to the host machine (possibly via a distro package like Debian's libglib2.0-tests) and run them there. While I'm changing the build-tests condition anyway, deduplicate it. Based on a patch by Helmut Grohne. Bug-Debian: https://bugs.debian.org/941509 Signed-off-by: Simon McVittie <smcv@collabora.com> 01 October 2019, 19:12:16 UTC
90bdc2f Ignacio Casal Quinteiro 01 October 2019, 13:03:28 UTC Merge branch 'gregistry-key-name-len' into 'master' gregistrysettings: bump key name length to 2048 See merge request GNOME/glib!1137 01 October 2019, 13:03:28 UTC
9239f26 Ignacio Casal Quinteiro 30 September 2019, 16:13:17 UTC gregistrysettings: bump key name length to 128 32 is just too low for key names, specially since the registry has a limit of 16,383 chars. Giving that, 128 is a good bump for now. 01 October 2019, 12:35:43 UTC
eb21257 Philip Withnall 30 September 2019, 13:23:51 UTC tests: Expand g_file_copy() tests to test DEFAULT_PERMS flag Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:40:55 UTC
67772b6 Philip Withnall 27 September 2019, 16:43:29 UTC tests: Unconditionally enable the file permissions test Skip it on systems which don’t support it, rather than compiling it out. That gives us more information from test runs about which tests are being run on which architectures. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:40:55 UTC
bfdc5fc Philip Withnall 27 September 2019, 16:42:03 UTC glocalfileinfo: Only return file mode, not type, as UNIX_MODE attribute As with the previous commit, `st_mode` contains both the file type (regular file, directory, symlink, special, etc.) and the file mode. For `G_FILE_ATTRIBUTE_ID_UNIX_MODE`, we only want the file mode — so mask `st_mode` with `~S_IFMT`. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:40:55 UTC
5dd5269 Philip Withnall 27 September 2019, 16:33:01 UTC glocalfileoutputstream: Only pass file mode, not type, to chmod() chmod() technically only accepts file modes, not the file type and mode as returned by stat(). Filter by `S_IFMT` to avoid sending the file type (regular file, directory, symbolic link, etc.). In practice, chmod() ignores anything except the file mode, but we might as well comply with the specification. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:40:55 UTC
674ba78 Philip Withnall 27 September 2019, 16:31:42 UTC gfile: Document a few nullable vfuncs `GFile` always checks whether these vfuncs are `NULL` before calling them, so document that it’s safe for implementations of `GFile` to not implement them. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:40:55 UTC
7d2bce8 Philip Withnall 27 September 2019, 16:28:40 UTC glocalfile: Don’t define unsupported copy vfunc The caller assumes that an unimplemented vfunc means that copying is unsupported (and falls back to its internal copy implementation), so there’s no point in implementing the vfunc just to unconditionally return `G_IO_ERROR_NOT_SUPPORTED`. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:40:55 UTC
1b7ab81 Philip Withnall 27 September 2019, 16:27:24 UTC glocalfile: Don’t define symlink vfunc if it’s unsupported Rather than defining a vfunc which only ever returns `G_IO_ERROR_NOT_SUPPORTED`, just don’t define the vfunc at all. The caller in `GFile` interprets this as symlinks not being supported — so we get the same behaviour, but without spending a vfunc call on it. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:40:55 UTC
775014d Philip Withnall 27 September 2019, 16:25:56 UTC gfile: Use a more specific error message if symlinks are not supported The string is already translated in `GLocalFile`, so this doesn’t introduce a new translatable string. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:40:55 UTC
2268f36 Philip Withnall 27 September 2019, 16:24:36 UTC gio-tool: Add a --default-permissions argument to `gio copy` This sets the `G_FILE_COPY_DEFAULT_PERMS` flag on the operation, creating the copied file with default permissions rather than the same permissions as the source file. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #174 30 September 2019, 13:40:50 UTC
53f6ede Philip Withnall 27 September 2019, 14:02:32 UTC gfile: Don’t copy files as private if using default permissions If a copy operation is started with `G_FILE_COPY_TARGET_DEFAULT_PERMS`, don’t create the destination file as private. Instead, create it with the process’ current umask (i.e. ‘default permissions’). This is a partial re-work of commit d8f8f4d637ce43f8699ba94c9b, with input from Ondrej Holy. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #174 30 September 2019, 13:40:43 UTC
51d73ef Philip Withnall 27 September 2019, 13:46:18 UTC gfile: Factor out flags when copying files This introduces no functional changes; just reduces duplication in the code a little. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 13:24:38 UTC
c27be68 Sebastian Dröge 30 September 2019, 11:53:52 UTC Merge branch '1897-cmpmem-null-handling' into 'master' gtestutils: Allow cmpmem() arguments to be NULL iff lengths are zero Closes #1897 See merge request GNOME/glib!1133 30 September 2019, 11:53:52 UTC
55997a0 Philip Withnall 30 September 2019, 11:00:30 UTC gtestutils: Allow cmpmem() arguments to be NULL iff lengths are zero Document this and add a test. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1897 30 September 2019, 11:05:55 UTC
61509ea Sebastian Dröge 30 September 2019, 11:05:15 UTC Merge branch 'python-version' into 'master' build: Bump Python requirement to ≥ 3.5 See merge request GNOME/glib!1132 30 September 2019, 11:05:15 UTC
bbbdc27 Philip Withnall 30 September 2019, 10:23:20 UTC build: Bump Python requirement to ≥ 3.5 We already depend on Meson 0.49.2, which depends on Python 3.5, so we’ve actually implicitly had this requirement for a while. Might as well make it explicit. Signed-off-by: Philip Withnall <withnall@endlessm.com> 30 September 2019, 10:23:20 UTC
3ede078 Sebastian Dröge 30 September 2019, 06:09:48 UTC Merge branch 'patch-1' into 'master' gio/gfileinfo: fix param reference in doc comment See merge request GNOME/glib!1131 30 September 2019, 06:09:48 UTC
2a4b9eb David Lechner 29 September 2019, 01:03:22 UTC gio/gfileinfo: fix param reference in doc comment The actual parameter name in g_file_attribute_matcher_new() attributes, so change the param reference to match. This way, doc tools can create a proper link. 29 September 2019, 01:03:22 UTC
349318e Robert Ancell 27 August 2019, 07:50:35 UTC gutils: Add g_get_os_info() Add a new function that gets OS information for /etc/os-release. 27 September 2019, 03:47:03 UTC
6192fd4 Philip Withnall 26 September 2019, 14:01:06 UTC Merge branch 'gspawn' into 'master' gspawn: Optimize fd closing on AIX and BSDs Closes #1638 See merge request GNOME/glib!574 26 September 2019, 14:01:06 UTC
1097b50 Philip Withnall 26 September 2019, 13:13:01 UTC gspawn: Retry on EBUSY errors from dup2() `man dup2` says that on Linux, dup2() can return `EBUSY` if the operation needs to be retried (in addition to returning `EINTR` in other cases where it needs to be retried). Signed-off-by: Philip Withnall <withnall@endlessm.com> 26 September 2019, 13:13:01 UTC
eae72c3 Philip Withnall 26 September 2019, 13:10:36 UTC gspawn: Rewrite some retry loops to use `while` rather than `goto` This introduces no functional changes, but does make the code easier to understand. Signed-off-by: Philip Withnall <withnall@endlessm.com> 26 September 2019, 13:10:36 UTC
8af823c Ting-Wei Lan 20 September 2019, 14:36:30 UTC gspawn: Use fdwalk provided by system only when it is known to be safe All uses of fdwalk in gspawn are between fork and exec, which means only async-signal safe functions can be called if the parent process has multiple threads. Since fdwalk is not a standard API, we should not assume it is safe to use unless the manual of the system explicitly says it is async-signal safe. Fixes: #1638 26 September 2019, 13:07:32 UTC
8af0ba9 Sebastian Dröge 26 September 2019, 08:01:15 UTC Merge branch 'diagnosticfix' into 'master' Improve GLIB_DEPRECATED_MACRO_FOR output See merge request GNOME/glib!1130 26 September 2019, 08:01:15 UTC
64cd20d Sebastian Dröge 26 September 2019, 07:59:19 UTC Merge branch 'android-warning-fix' into 'master' gdate: Fix tautological comparison warnings on Android See merge request GNOME/glib!1129 26 September 2019, 07:59:19 UTC
91cb171 Stephan Bergmann 26 September 2019, 06:42:30 UTC Improve GLIB_DEPRECATED_MACRO_FOR output See the mailing list thread <https://lists.fedoraproject.org/archives/list/ devel@lists.fedoraproject.org/thread/SZ676IHHSLOQD6UN2I5J5VKXJ5P5SOVO/> "glib-2.0 G_CONST_RETURN causing GCC 'warning: const' on F31", where the GCC diagnostic > test.c:2:13: warning: const > 2 | G_CONST_RETURN char * f(); > | ^~~~~~~ had confused me, and "Deprecated pre-processor symbol, repace with const" is probably a better warning message than just "const". (That recent GCC only prints "Deprecated pre-processor symbol, repace with " appears to be a bug in GCC that GLIB_UNAVAILABLE_MACRO already suffers from, too. Recent Clang correctly prints "Deprecated pre-processor symbol, repace with const".) 26 September 2019, 07:06:30 UTC
00c04fd Philip Withnall 25 September 2019, 14:17:37 UTC gdate: Fix tautological comparison warnings on Android Android is emitting `-Wtautological-constant-out-of-range-compare` warnings when compiling the validation functions for the enum types for `GDate`. Fix that by comparing as integers. Signed-off-by: Philip Withnall <withnall@endlessm.com> 25 September 2019, 14:17:37 UTC
02a7af7 Philip Withnall 25 September 2019, 13:43:51 UTC Merge branch 'fileinfo-mention-attr-usecs' into 'master' fileinfo: Mention that usec mtimes are set See merge request GNOME/glib!1126 25 September 2019, 13:43:51 UTC
1015bfb Matthew Leeds 25 September 2019, 13:43:51 UTC fileinfo: Mention that usec mtimes are set g_file_info_set_modification_time() and g_file_info_set_modification_date_time() set the G_FILE_ATTRIBUTE_TIME_MODIFIED_USEC attribute in addition to G_FILE_ATTRIBUTE_TIME_MODIFIED, so microsecond precision is available when provided by the caller, so mention both attributes in the docs. 25 September 2019, 13:43:51 UTC
03e3a03 Sebastian Dröge 24 September 2019, 17:52:15 UTC Merge branch 'ossfuzz-17648-date-uninit-variable' into 'master' gdatetime: Fix error handling in g_date_time_new_week() See merge request GNOME/glib!1125 24 September 2019, 17:52:15 UTC
a96c449 Sebastian Dröge 24 September 2019, 17:01:50 UTC Merge branch '1865-variant-get-child-serialisation' into 'master' gvariant: Handle empty serialisations in get_child_value() Closes #1865 See merge request GNOME/glib!1043 24 September 2019, 17:01:50 UTC
f4dd856 Philip Withnall 24 September 2019, 17:00:53 UTC gdatetime: Fix error handling in g_date_time_new_week() It was possible to pass in (for example) an invalid year to g_date_time_new_week(), which would be passed on to g_date_time_new(), which would (correctly) return `NULL` — but then g_date_time_get_week_number() would try to dereference that. Includes a test case. oss-fuzz#17648 Signed-off-by: Philip Withnall <withnall@endlessm.com> 24 September 2019, 17:00:53 UTC
a902add Philip Withnall 24 September 2019, 13:19:35 UTC Merge branch 'ossfuzz-12960-markup-attribute-limit' into 'master' gmarkup: Add a limit on the number of attributes in an element See merge request GNOME/glib!1116 24 September 2019, 13:19:35 UTC
4170528 Sebastian Dröge 24 September 2019, 12:50:14 UTC Merge branch '1449-atomic-fallback-safety' into 'master' gatomic: Reorder memory barriers in fallback atomic operations Closes #1449 See merge request GNOME/glib!1122 24 September 2019, 12:50:14 UTC
22aed45 Sebastian Dröge 24 September 2019, 12:40:48 UTC Merge branch 'docs-heading-typo' into 'master' docs: Fix typo in GConverter{Input,Output}Stream section titles See merge request GNOME/glib!1124 24 September 2019, 12:40:48 UTC
d0964b7 Philip Withnall 24 September 2019, 11:25:10 UTC docs: Fix typo in GConverter{Input,Output}Stream section titles Signed-off-by: Philip Withnall <withnall@endlessm.com> 24 September 2019, 11:25:10 UTC
1f8d345 Nirbheek Chauhan 23 September 2019, 14:20:58 UTC Merge branch '1565-atomic-signs' into 'master' Fix sign conversion warnings with g_atomic_int_*() calls in GLib Closes #1565 See merge request GNOME/glib!1121 23 September 2019, 14:20:58 UTC
e3b87b6 Nirbheek Chauhan 23 September 2019, 11:22:25 UTC Merge branch 'add_g_fsync_function' into 'master' Add a wrapper for fsync() function Closes #35 See merge request GNOME/glib!1104 23 September 2019, 11:22:25 UTC
9a16f26 Philip Withnall 21 September 2019, 14:09:41 UTC gatomic: Reorder memory barriers in fallback atomic operations If the compiler doesn’t provide modern (C++11) atomic builtins (which is now quite unlikely), we implement our own using the `__sync_synchronize()` memory barrier. As Behdad and others have pointed out, though, the implementation didn’t follow the same semantics as we use with the C++11 builtins — `__ATOMIC_SEQ_CST`. Fix the use of memory barriers to provide `__ATOMIC_SEQ_CST` semantics. In particular, this fixes the following common pattern: ``` GObject *obj = my_object_new (); g_atomic_pointer_set (&shared_ptr, obj); ``` Previously this would have expanded to: ``` GObject *obj = my_object_new (); *shared_ptr = obj; __sync_synchronize (); ``` While the compiler would not have reordered the stores to `obj` and `shared_ptr` within the code on one thread (due to the dependency between them), the memory system might have made the write to `shared_ptr` visible to other threads before the write to `obj` — if they then dereferenced `shared_ptr` before seeing the write to `obj`, that would be a bug. Instead, the expansion is now: ``` GObject *obj = my_object_new (); __sync_synchronize (); *shared_ptr = obj; ``` This ensures that the write to `obj` is visible to all threads before any write to `shared_ptr` is visible to any threads. For completeness, `__sync_synchronize()` is augmented with a compiler barrier to ensure that no loads/stores can be reordered locally before or after it. Tested by disabling the C++11 atomic implementation and running: ``` meson test --repeat 1000 atomic atomic-test ``` Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1449 21 September 2019, 14:16:21 UTC
ec848cb Philip Withnall 21 September 2019, 08:54:52 UTC tests: Use g_assert_*() in atomic tests rather than g_assert() `g_assert_*()` provide more useful failure messages, and aren’t compiled out when building with `G_DISABLE_ASSERT`, unlike `g_assert()`. Signed-off-by: Philip Withnall <withnall@endlessm.com> 21 September 2019, 08:54:52 UTC
55f9c6d Philip Withnall 21 September 2019, 08:45:36 UTC gatomic: Add various casts to use of g_atomic_*()s to fix warnings When compiling GLib with `-Wsign-conversion`, we get various warnings about the atomic calls. A lot of these were fixed by 3ad375a629c91a27d0165a31f0ed298fd553de0a, but some remain. Fix them by adding appropriate casts at the call sites. Note that `g_atomic_int_{and,or,xor}()` actually all operate on `guint`s rather than `gint`s (which is what the rest of the `g_atomic_int_*()` functions operate on). I can’t find any written reasoning for this, but assume that it’s because signedness is irrelevant when you’re using an integer as a bit field. It’s unfortunate that they’re named a `g_atomic_int_*()` rather than `g_atomic_uint_*()` functions. Tested by compiling GLib as: ``` CFLAGS=-Wsign-conversion jhbuild make -ac |& grep atomic ``` I’m not going to add `-Wsign-conversion` to the set of default warnings for building GLib, because it mostly produces false positives throughout the rest of GLib. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1565 21 September 2019, 08:48:23 UTC
3ad375a Philip Withnall 21 September 2019, 07:56:28 UTC Merge branch '1843-tsan-atomic-clang-fix' into 'master' gatomic: Fix false positive with Clang+TSAN Closes #1843 See merge request GNOME/glib!1006 21 September 2019, 07:56:28 UTC
2d37239 Sebastian Schwarz 15 September 2019, 04:53:38 UTC gspawn: Optimize fd closing on AIX and BSDs Instead of calling close or fcntl on all possible file descriptors, which is slow on systems with very high limit or even no limit on open file descriptors, we can use closefrom or fcntl with F_CLOSEM to close all unwanted file descriptors with a single system call. This change only improves the performance when GSpawnChildSetupFunc is NULL because there are applications known to abuse GSpawnChildSetupFunc to unset FD_CLOEXEC on file descriptors. Since the change mentioned above requires closing file descriptors directly, it cannot be used when the caller may want to keep some of them open. This patch was written by Sebastian Schwarz <seschwar@gmail.com> and uploaded to https://gitlab.gnome.org/GNOME/glib/merge_requests/574. It was later modified by Ting-Wei Lan <lantw@src.gnome.org> to address code review issues. Fixes: https://gitlab.gnome.org/GNOME/glib/issues/1638 20 September 2019, 14:28:29 UTC
c8bad68 Philip Withnall 20 September 2019, 12:13:00 UTC Merge branch 'utils-doc-annotations' into 'master' Annotate the return value of various utility functions See merge request GNOME/glib!1119 20 September 2019, 12:13:00 UTC
273049a Emmanuele Bassi 20 September 2019, 11:32:24 UTC Annotate the return value of various utility functions While the introspection scanner can glean the transfer rule for the return values by looking at their constness, adding an explicit annotation has the advantage of gtk-doc writing out the transfer rule as an additional bit of documentation, making the life of the documentation reader easier. 20 September 2019, 11:35:24 UTC
744f5c4 Sebastian Dröge 20 September 2019, 11:14:56 UTC Merge branch '767-signal-class-refs' into 'master' gsignal: Document class init before signals can be looked up Closes #767 See merge request GNOME/glib!1118 20 September 2019, 11:14:56 UTC
66a5704 Philip Withnall 20 September 2019, 09:54:01 UTC Merge branch 'gobject-tutorial-no-priv' into 'master' docs: Remove priv pointers from the tutorial example See merge request GNOME/glib!1020 20 September 2019, 09:54:01 UTC
b96e318 Emmanuele Bassi 31 July 2019, 14:27:06 UTC docs: Remove priv pointers from the tutorial example We define `ViewerFile` as a final type with fields directly in the instance structure. This means we don't have a `priv` pointer to dereference. 20 September 2019, 09:38:47 UTC
9ca97b8 Philip Withnall 20 September 2019, 09:23:08 UTC gsignal: Document class init before signals can be looked up Fixes: #767 Signed-off-by: Philip Withnall <withnall@endlessm.com> 20 September 2019, 09:23:08 UTC
c4ec302 Philip Withnall 19 September 2019, 21:18:57 UTC Merge branch 'ossfuzz-16103-ordinal-dates' into 'master' gdatetime: Fix error handling in g_date_time_new_ordinal() See merge request GNOME/glib!1115 19 September 2019, 21:18:57 UTC
57fc0be Philip Withnall 18 September 2019, 16:06:20 UTC gmarkup: Add a limit on the number of attributes in an element While the XML specification doesn’t prescribe a limit, no reasonable bit of XML is going to have more than 1000 attributes in a single XML element. Adding a limit reduces the changes of a runaway allocation loop caused by dodgy input. oss-fuzz#12960 Signed-off-by: Philip Withnall <withnall@endlessm.com> 18 September 2019, 16:06:20 UTC
5c6030e Philip Withnall 18 September 2019, 11:42:39 UTC gdatetime: Fix error handling in g_date_time_new_ordinal() It was possible to pass in (for example) an invalid hour to g_date_time_new_ordinal(), which would be passed on to g_date_time_new(), which would (correctly) return `NULL` — but then g_date_time_new_ordinal() would try to dereference that. Includes some test cases. oss-fuzz#16103 oss-fuzz#17183 Signed-off-by: Philip Withnall <withnall@endlessm.com> 18 September 2019, 11:44:28 UTC
3636bb5 Todd Goyen 13 September 2019, 17:53:15 UTC Add a wrapper for fsync() function Closes issue #35 18 September 2019, 08:47:23 UTC
2f9c9e2 Emmanuel Fleury 13 August 2019, 16:34:04 UTC Switching from C gnu89 to C gnu99 standard 17 September 2019, 17:48:56 UTC
59882fb Emmanuel Fleury 13 August 2019, 16:32:03 UTC Fixing inlining bug in gnulib/xsize.h See: https://lists.gnu.org/archive/html/bug-gettext/2013-01/msg00011.html Courtesy to chrisawi (Chris William) 17 September 2019, 17:48:56 UTC
96c25ce Emmanuele Bassi 17 September 2019, 16:06:33 UTC Merge branch 'since-2-64' into 'master' Add version macros for GLib 2.64 See merge request GNOME/glib!1112 17 September 2019, 16:06:33 UTC
3b1e301 Philip Withnall 17 September 2019, 11:24:16 UTC gversionmacros: Add version macros for GLib 2.64 Signed-off-by: Philip Withnall <withnall@endlessm.com> 17 September 2019, 11:24:16 UTC
bbccd2c Philip Withnall 17 September 2019, 11:23:06 UTC build: Post-release version bump to 2.63.0 Ready for the new unstable release series. Signed-off-by: Philip Withnall <withnall@endlessm.com> 17 September 2019, 11:23:06 UTC
back to top