Skip to main content

Browse the archive

https://github.com/GNOME/glib
05 April 2024, 22:37:37 UTC
sort by:
Revision Author Date Message Commit Date
113f303 Emmanuel Fleury 23 February 2019, 08:56:57 UTC Fixing signedness warning in glib/gslice.c In file included from glib/glibconfig.h:9, from glib/gslice.c:20: glib/gslice.c: In function ‘magazine_cache_trim’: glib/gmacros.h:354:25: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] #define ABS(a) (((a) < 0) ? -(a) : (a)) ^ glib/gslice.c:643:10: note: in expansion of macro ‘ABS’ while (ABS (stamp - magazine_chain_uint_stamp (current)) >= allocator->config.working_set_msecs) ^~~ 25 February 2019, 14:18:02 UTC
f9c22e5 Emmanuel Fleury 22 February 2019, 09:49:32 UTC Fix various signedness warnings in glib/ghash.c To conform to a better signedness schema, this patch change GHashTable.size field from gint to gsize (and change accordingly the tests with it). 25 February 2019, 14:18:02 UTC
3993fbb Emmanuel Fleury 14 February 2019, 09:56:21 UTC Fixing various warnings in glib/gvariant-parser.c glib/gvariant-parser.c: In function ‘number_get_value’: glib/gvariant-parser.c:1924:46: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] return g_variant_new_int16 (negative ? -((gint16) abs_val) : abs_val); ^~~~~~~~~~~~~~~~~~~ glib/gvariant-parser.c:1934:46: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] return g_variant_new_int32 (negative ? -((gint32) abs_val) : abs_val); ^~~~~~~~~~~~~~~~~~~ glib/gvariant-parser.c:1944:46: error: operand of ?: changes signedness from ‘long int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] return g_variant_new_int64 (negative ? -((gint64) abs_val) : abs_val); ^~~~~~~~~~~~~~~~~~~ glib/gvariant-parser.c:1954:47: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] return g_variant_new_handle (negative ? -((gint32) abs_val) : abs_val); ^~~~~~~~~~~~~~~~~~~ glib/gvariant-parser.c: In function ‘g_variant_parse_error_print_context’: glib/gvariant-parser.c:2785:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (point >= strlen (source_str)) ^~ 25 February 2019, 14:18:02 UTC
be398a6 Emmanuel Fleury 04 February 2019, 14:40:37 UTC Fixing various warning in glib/gvarianttypeinfo.c glib/gvarianttypeinfo.c:115:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'b' */ { fixed_aligned(1) }, /* boolean */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:117:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'd' */ { fixed_aligned(8) }, /* double */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:120:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'g' */ { unaligned }, /* signature string */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:121:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'h' */ { fixed_aligned(4) }, /* file handle (int32) */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:122:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'i' */ { fixed_aligned(4) }, /* int32 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:127:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'n' */ { fixed_aligned(2) }, /* int16 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:128:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'o' */ { unaligned }, /* object path string */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:130:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'q' */ { fixed_aligned(2) }, /* uint16 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:132:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 's' */ { unaligned }, /* string */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:133:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 't' */ { fixed_aligned(8) }, /* uint64 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:134:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'u' */ { fixed_aligned(4) }, /* uint32 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:135:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'v' */ { aligned(8) }, /* variant */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:137:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'x' */ { fixed_aligned(8) }, /* int64 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:138:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'y' */ { fixed_aligned(1) }, /* byte */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c: In function ‘tuple_info_free’: glib/gvarianttypeinfo.c:368:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] for (i = 0; i < tuple_info->n_members; i++) ^ glib/gvarianttypeinfo.c: In function ‘tuple_set_base_info’: glib/gvarianttypeinfo.c:641:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare] if (m->i == -1 && m->type_info->fixed_size) ^~ 25 February 2019, 14:18:02 UTC
ddfe989 Emmanuel Fleury 04 February 2019, 12:45:41 UTC Fixing signedness in glib/gvariant.c glib/gvariant.c: In function ‘g_variant_new_strv’: glib/gvariant.c:1563:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] for (i = 0; i < length; i++) ^ glib/gvariant.c: In function ‘g_variant_new_objv’: glib/gvariant.c:1699:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] for (i = 0; i < length; i++) ^ glib/gvariant.c: In function ‘g_variant_new_bytestring_array’: glib/gvariant.c:1939:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] for (i = 0; i < length; i++) ^ 25 February 2019, 14:18:02 UTC
1fa1d02 Emmanuel Fleury 04 February 2019, 12:41:54 UTC Fixing signedness in glib/gvariant-core.c glib/gvariant-core.c: In function ‘g_variant_ensure_size’: glib/gvariant-core.c:339:19: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare] if (value->size == (gssize) -1) ^~ 25 February 2019, 14:18:02 UTC
5251f53 Emmanuel Fleury 04 February 2019, 15:40:21 UTC Fixing missing initializer in glib/giounix.c ^~~ glib/giounix.c:111:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers] }; ^ In file included from glib/giochannel.h:33, from glib/glib.h:54, from glib/gprintf.h:21, from glib/gstdio.h:22, from glib/giounix.c:43: glib/gmain.h:262:19: note: ‘closure_callback’ declared here GSourceFunc closure_callback; ^~~~~~~~~~~~~~~~ 25 February 2019, 14:18:02 UTC
ccd0174 Emmanuel Fleury 04 February 2019, 15:36:11 UTC Fixing signedness in glib/gthread-posix.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gatomic.h:27, from glib/gthread.h:32, from glib/gthread-posix.c:42: glib/gthread-posix.c: In function ‘g_system_thread_new’: glib/gmacros.h:348:26: error: comparison of integer expressions of different signedness: ‘long int’ and ‘gulong’ {aka ‘long unsigned int’} [-Werror=sign-compare] #define MAX(a, b) (((a) > (b)) ? (a) : (b)) ^ glib/gthread-posix.c:1169:22: note: in expansion of macro ‘MAX’ stack_size = MAX (min_stack_size, stack_size); ^~~ glib/gmacros.h:348:35: error: operand of ?: changes signedness from ‘long int’ to ‘gulong’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] #define MAX(a, b) (((a) > (b)) ? (a) : (b)) ^~~ glib/gthread-posix.c:1169:22: note: in expansion of macro ‘MAX’ stack_size = MAX (min_stack_size, stack_size); ^~~ 25 February 2019, 14:18:02 UTC
6e92ed9 Emmanuel Fleury 04 February 2019, 15:25:30 UTC Fixing signedness in glib/gtester.c glib/gtester.c: In function ‘main’: glib/gtester.c:705:19: error: comparison of integer expressions of different signedness: ‘guint’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare] for (ui = 1; ui < argc; ui++) ^ 25 February 2019, 14:18:02 UTC
753a4ab Emmanuel Fleury 04 February 2019, 14:46:24 UTC Fixing missing initializer in glib-unix.c glib/glib-unix.c:314:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers] }; ^ In file included from glib/giochannel.h:33, from glib/glib.h:54, from glib/glib-unix.h:33, from glib/glib-unix.c:29: glib/gmain.h:262:19: note: ‘closure_callback’ declared here GSourceFunc closure_callback; ^~~~~~~~~~~~~~~~ 25 February 2019, 14:18:02 UTC
f86e8e7 Emmanuel Fleury 04 February 2019, 12:31:28 UTC Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^ 25 February 2019, 14:18:02 UTC
88974c9 Emmanuel Fleury 04 February 2019, 12:15:12 UTC Fixing various warnings in glib/gtimezone.c glib/gtimezone.c: In function ‘g_time_zone_unref’: glib/gtimezone.c:241:29: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare] for (idx = 0; idx < tz->t_info->len; idx++) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gtimezone.h:27, from glib/gtimezone.c:24: glib/gtimezone.c: In function ‘init_zone_from_iana_info’: glib/gtimezone.c:578:34: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare] g_assert (trans.info_index < gtz->t_info->len); ^ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gtimezone.c:578:7: note: in expansion of macro ‘g_assert’ g_assert (trans.info_index < gtz->t_info->len); ^~~~~~~~ glib/gtimezone.c: In function ‘find_relative_date’: glib/gtimezone.c:859:22: error: comparison of integer expressions of different signedness: ‘GDateWeekday’ {aka ‘enum <anonymous>’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare] if (first_wday > wday) ^ glib/gtimezone.c: In function ‘init_zone_from_rules’: glib/gtimezone.c:938:19: error: comparison of integer expressions of different signedness: ‘guint’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare] for (ri = 0; ri < rules_num - 1; ri++) ^ glib/gtimezone.c:958:19: error: comparison of integer expressions of different signedness: ‘guint’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare] for (ri = 0; ri < rules_num - 1; ri++) ^ glib/gtimezone.c: In function ‘g_time_zone_adjust_time’: glib/gtimezone.c:1792:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare] for (i = 0; i <= intervals; i++) ^~ glib/gtimezone.c:1825:39: error: comparison of integer expressions of different signedness: ‘gboolean’ {aka ‘int’} and ‘GTimeType’ {aka ‘enum <anonymous>’} [-Werror=sign-compare] else if (interval_isdst (tz, i) != type) ^~ glib/gtimezone.c:1832:22: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare] else if (i < intervals && ^ glib/gtimezone.c: In function ‘g_time_zone_find_interval’: glib/gtimezone.c:1881:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare] for (i = 0; i <= intervals; i++) ^~ glib/gtimezone.c:1900:35: error: comparison of integer expressions of different signedness: ‘gboolean’ {aka ‘int’} and ‘GTimeType’ {aka ‘enum <anonymous>’} [-Werror=sign-compare] else if (interval_isdst (tz, i) != type) ^~ glib/gtimezone.c:1905:18: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare] else if (i < intervals && time_ >= interval_local_start (tz, i + 1)) ^ 25 February 2019, 14:18:02 UTC
951b928 Emmanuel Fleury 04 February 2019, 09:36:11 UTC Fixing signedness in glib/gtestutils.c glib/gtestutils.c: In function ‘g_test_build_filename_va’: glib/gtestutils.c:3865:49: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘long unsigned int’ [-Werror=sign-compare] for (num_path_segments = 2; num_path_segments < G_N_ELEMENTS (pathv); num_path_segments++) ^ 25 February 2019, 14:18:02 UTC
19629d4 Emmanuel Fleury 04 February 2019, 09:34:13 UTC Fixing signedness in glib/gthreadpool.c glib/gthreadpool.c: In function ‘g_thread_pool_wait_for_new_pool’: glib/gthreadpool.c:157:46: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare] if (g_atomic_int_get (&unused_threads) >= local_max_unused_threads) ^~ glib/gthreadpool.c: In function ‘g_thread_pool_wakeup_and_stop_all’: glib/gthreadpool.c:836:17: error: comparison of integer expressions of different signedness: ‘guint’ {aka ‘unsigned int’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare] for (i = 0; i < pool->num_threads; i++) ^ 25 February 2019, 14:18:02 UTC
96b0167 Emmanuel Fleury 04 February 2019, 08:49:35 UTC Fixing signedness problem in glib/gstrfuncs.c glib/gstrfuncs.c: In function ‘g_strstr_len’: glib/gstrfuncs.c:2709:24: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (haystack_len < needle_len) ^ 25 February 2019, 14:18:02 UTC
f56de97 Emmanuel Fleury 04 February 2019, 08:30:38 UTC Fixing various warnings in glib/gmain.c glib/gmain.c:480:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers] }; ^ In file included from glib/giochannel.h:33, from glib/glib.h:54, from glib/glib-unix.h:33, from glib/gmain.c:50: glib/gmain.h:262:19: note: ‘closure_callback’ declared here GSourceFunc closure_callback; ^~~~~~~~~~~~~~~~ glib/gmain.c:491:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers] }; ^ In file included from glib/giochannel.h:33, from glib/glib.h:54, from glib/glib-unix.h:33, from glib/gmain.c:50: glib/gmain.h:262:19: note: ‘closure_callback’ declared here GSourceFunc closure_callback; ^~~~~~~~~~~~~~~~ glib/gmain.c:499:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers] }; ^ In file included from glib/giochannel.h:33, from glib/glib.h:54, from glib/glib-unix.h:33, from glib/gmain.c:50: glib/gmain.h:262:19: note: ‘closure_callback’ declared here GSourceFunc closure_callback; ^~~~~~~~~~~~~~~~ glib/gmain.c:507:1: error: missing initializer for field ‘closure_callback’ of ‘GSourceFuncs’ {aka ‘struct _GSourceFuncs’} [-Werror=missing-field-initializers] }; ^ In file included from glib/giochannel.h:33, from glib/glib.h:54, from glib/glib-unix.h:33, from glib/gmain.c:50: glib/gmain.h:262:19: note: ‘closure_callback’ declared here GSourceFunc closure_callback; ^~~~~~~~~~~~~~~~ glib/gmain.c: In function ‘g_source_set_callback_indirect’: glib/gmain.c:1615:68: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body] callback_funcs->get)); ^ 25 February 2019, 14:18:02 UTC
5fe4d23 Emmanuel Fleury 03 February 2019, 19:00:42 UTC Fixing missing initializer for field in gscanner.c glib/gscanner.c:344:1: error: missing initializer for field ‘padding_dummy’ of ‘GScannerConfig’ {aka ‘const struct _GScannerConfig’} [-Werror=missing-field-initializers] }; ^ In file included from glib/gscanner.c:40: glib/gscanner.h:166:10: note: ‘padding_dummy’ declared here guint padding_dummy; ^~~~~~~~~~~~~ 25 February 2019, 14:18:02 UTC
e39e753 Emmanuel Fleury 03 February 2019, 18:36:46 UTC Fixing signedness in glib/goptions.c glib/goption.c: In function ‘context_has_h_entry’: glib/goption.c:785:21: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare] for (i = 0; i < context->main_group->n_entries; i++) ^ glib/goption.c:797:21: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare] for (i = 0; i < group->n_entries; i++) ^ 25 February 2019, 14:18:02 UTC
56f6e15 Emmanuel Fleury 03 February 2019, 18:29:48 UTC Fixing signedness in glib/gmarkup.c In file included from glib/glibconfig.h:9, from ../glib.git/glib/gtypes.h:32, from ../glib.git/glib/gquark.h:32, from ../glib.git/glib/gerror.h:28, from ../glib.git/glib/gmarkup.h:28, from ../glib.git/glib/gmarkup.c:28: ../glib.git/glib/gmarkup.c: In function ‘unescape_gstring_inplace’: ../glib.git/glib/gmarkup.c:789:30: error: comparison of integer expressions of different signedness: ‘long int’ and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_assert (to - string->str <= string->len); ^~ ../glib.git/glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ ../glib.git/glib/gmarkup.c:789:3: note: in expansion of macro ‘g_assert’ g_assert (to - string->str <= string->len); ^~~~~~~~ ../glib.git/glib/gmarkup.c:790:24: error: comparison of integer expressions of different signedness: ‘long int’ and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (to - string->str != string->len) ^~ ../glib.git/glib/gmarkup.c: In function ‘g_markup_parse_boolean’: ../glib.git/glib/gmarkup.c:2634:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare] for (i = 0; i < G_N_ELEMENTS (falses); i++) ^ ../glib.git/glib/gmarkup.c:2645:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare] for (i = 0; i < G_N_ELEMENTS (trues); i++) ^ 25 February 2019, 14:18:02 UTC
8a30f94 Emmanuel Fleury 03 February 2019, 18:24:29 UTC Fixing signedness in glib/gquark.c glib/gquark.c: In function ‘g_quark_to_string’: glib/gquark.c:268:13: error: comparison of integer expressions of different signedness: ‘GQuark’ {aka ‘unsigned int’} and ‘gint’ {aka ‘int’} [-Werror=sign-compare] if (quark < seq_id) ^ 25 February 2019, 14:18:02 UTC
2e3906b Emmanuel Fleury 03 February 2019, 18:09:18 UTC Fixing signedness in glib/gprimes.c glib/gprimes.c: In function ‘g_spaced_primes_closest’: glib/gprimes.c:91:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘long unsigned int’ [-Werror=sign-compare] for (i = 0; i < G_N_ELEMENTS (g_primes); i++) ^ 25 February 2019, 14:18:02 UTC
6e946a9 Emmanuel Fleury 01 February 2019, 19:46:10 UTC Fix signedness in glib/gmappedfile.c glib/gmappedfile.c: In function ‘mapped_file_new_from_fd’: glib/gmappedfile.c:153:18: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] if (st.st_size > G_MAXSIZE) ^ 25 February 2019, 14:18:02 UTC
02cc1b0 Emmanuel Fleury 31 January 2019, 17:43:59 UTC Fixing signedness in glib/giochannel.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gquark.h:32, from glib/gerror.h:28, from glib/gconvert.h:32, from glib/giochannel.h:32, from glib/giochannel.c:37: glib/giochannel.c: In function ‘g_io_channel_write_chars’: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/giochannel.c:2285:31: note: in expansion of macro ‘MIN’ gssize write_this = MIN (space_in_buf, count - wrote_bytes); ^~~ glib/gmacros.h:351:41: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘gsize’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/giochannel.c:2285:31: note: in expansion of macro ‘MIN’ gssize write_this = MIN (space_in_buf, count - wrote_bytes); ^~~ glib/giochannel.c:2415:41: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_assert (count == from_buf_len - from_buf_old_len); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/giochannel.c:2415:25: note: in expansion of macro ‘g_assert’ g_assert (count == from_buf_len - from_buf_old_len); ^~~~~~~~ 25 February 2019, 14:18:02 UTC
b0ec543 Emmanuel Fleury 07 February 2019, 12:01:16 UTC Silenting unused parameter warnings due to deprecated code 25 February 2019, 14:18:02 UTC
dc6b5f8 Philip Withnall 25 February 2019, 13:04:08 UTC Merge branch 'update-gvdb' into 'master' Update gvdb submodule See merge request GNOME/glib!674 25 February 2019, 13:04:08 UTC
2b1bcbc Philip Withnall 25 February 2019, 12:40:10 UTC Merge remote-tracking branch 'gvdb/master' into update-gvdb 25 February 2019, 12:40:10 UTC
25942f0 Philip Withnall 25 February 2019, 12:39:06 UTC Merge branch 'array-size' into 'master' Fix size of preallocated array See merge request GNOME/gvdb!3 25 February 2019, 12:39:06 UTC
7bf49c8 Philip Withnall 25 February 2019, 12:36:43 UTC Fix size of preallocated array Commit 084e1d868 added a preallocation to an array to avoid reallocations later on, but neglected the fact that after N insertions into the array, there’s always a NULL terminator added to the end. Fix the preallocation to include that NULL terminator. This doesn’t change the correctness of the code, but should eliminate one reallocation. Spotted by Sebastian Dröge. See https://gitlab.gnome.org/GNOME/glib/merge_requests/674. Signed-off-by: Philip Withnall <withnall@endlessm.com> 25 February 2019, 12:38:08 UTC
78a2dd9 Emmanuele Bassi 25 February 2019, 11:47:56 UTC Merge branch 'threaded-resolver-freebsd' into 'master' gthreadedresolver: Fix initialisation on FreeBSD Closes #1697 See merge request GNOME/glib!693 25 February 2019, 11:47:56 UTC
d7c93e3 Philip Withnall 25 February 2019, 11:42:12 UTC Merge branch 'tsan-gtask' into 'master' gtask: Separate GTask fields memory locations to avoid data races See merge request GNOME/glib!691 25 February 2019, 11:42:12 UTC
6e7e5ff Philip Withnall 25 February 2019, 11:22:45 UTC gthreadedresolver: Fix initialisation on FreeBSD res_ninit() requires the __res_state struct passed to it to be zero-filled on FreeBSD. Spotted and analysed by Ashish SHUKLA. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes #1697 25 February 2019, 11:22:45 UTC
04528e6 Philip Withnall 25 February 2019, 11:09:57 UTC Merge branch 'valgrind-suppressions' into 'master' glib.supp: Add more variations of existing suppressions See merge request GNOME/glib!692 25 February 2019, 11:09:57 UTC
e06fe74 Philip Chimento 25 February 2019, 06:10:36 UTC glib.supp: Add more variations of existing suppressions There are some cases where valgrind turns up leaks that are already suppressed in the file, but with a slight difference at the top of the stack. Add suppressions for these cases as well. 25 February 2019, 06:10:36 UTC
fef1ce3 Tomasz Miąsko 22 February 2019, 00:00:00 UTC gtask: Separate GTask fields memory locations to avoid data races Ensure that fields that might be accessed in two different threads, through conflicting actions are stored in seprate memory locations. 22 February 2019, 21:22:07 UTC
5eb9f9f Sebastian Dröge 22 February 2019, 15:04:59 UTC Merge branch 'glib-compile-resources-leak' into 'master' glib-compile-resources: Fix a minor leak See merge request GNOME/glib!689 22 February 2019, 15:04:59 UTC
7321f24 Philip Withnall 22 February 2019, 14:47:46 UTC glib-compile-resources: Fix a minor leak Spotted by oss-fuzz using asan. oss-fuzz#13271 Signed-off-by: Philip Withnall <withnall@endlessm.com> 22 February 2019, 14:48:25 UTC
779448e Milo Casagrande 22 February 2019, 11:08:24 UTC Update Italian translation 22 February 2019, 11:08:24 UTC
4d12174 Michael Catanzaro 22 February 2019, 01:33:50 UTC Merge branch '1679-socket-service-flaky' into 'master' Resolve "socket-service test is flaky" Closes #1679 See merge request GNOME/glib!687 22 February 2019, 01:33:50 UTC
8620198 Philip Withnall 21 February 2019, 19:21:09 UTC Merge branch 'code-owners' into 'master' docs: Populate CODEOWNERS file Closes #1668 See merge request GNOME/glib!684 21 February 2019, 19:21:09 UTC
f703bed Philip Withnall 20 February 2019, 11:05:19 UTC docs: Populate CODEOWNERS file Rename it from CODE-OWNERS and make it follow the documented syntax supported by GitLab: https://docs.gitlab.com/ee/user/project/code_owners.html. Currently our version of GitLab doesn’t support it, but it may do in future. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://gitlab.gnome.org/GNOME/glib/issues/1668 21 February 2019, 18:53:47 UTC
07414e1 Philip Withnall 21 February 2019, 18:13:47 UTC tests: Unmark socket-service test as flaky This essentially reverts commit cffed587371027a1ecc7eba5ad66cb814941785e. The preceding two commits have fixed the test so it’s no longer flaky. The following command gives 5000 passes in a row for me: meson test -C /opt/gnome/build/glib/ socket-service --repeat 5000 Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1679 21 February 2019, 18:15:49 UTC
f25c3f2 Philip Withnall 21 February 2019, 17:45:40 UTC tests: Fix unlikely race in socket-service test It’s occasionally possible for the cancellation of the service to happen before connection_cb() gets scheduled in the other thread. The locking/unlocking order of mutex_712570 requires: • test_threaded_712570(): lock mutex • test_threaded_712570(): start wait loop • connection_cb(): lock mutex • test_threaded_socket_service_finalize(): unlock mutex • test_threaded_712570(): end wait loop • test_threaded_712570(): unlock mutex Fix that by quitting the main loop once connection_cb() has been called (i.e. once the server thread has received the incoming connection request), rather than just after the client thread (main thread) has sent a connection request. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1679 21 February 2019, 18:15:49 UTC
2aea9c8 Philip Withnall 21 February 2019, 17:31:17 UTC tests: Fix flaky socket-service test caused by GTask scheduling On about 1 in 3 test runs, the socket-service would fail with the ref_count assertion in connection_cb() failing (the ref_count would be 3 rather than the expected 2). This was happening because the GTask from g_socket_listener_accept_socket_async() now always takes at least one main context iteration to return a result (whereas before 6f3d57d2ee271017f37ebdceb1e15efa7ce0ac49 it might have taken zero), but the ref_count can drop below 3 before the process of returning a result starts. During the process of returning a result, the ref_count temporarily increases again, which is what was breaking the test. Fix this by waiting for one more main context iteration. This is a bit of a hack, but the real fix would be to expose the outstanding_accept boolean from GSocketService as public API (which the test can interrogate), and that seems too much like exposing internal state. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1679 21 February 2019, 18:14:56 UTC
b1033dd Jordi Mas 21 February 2019, 16:39:21 UTC Update Catalan translation 21 February 2019, 16:39:21 UTC
ffe5cda Sebastian Dröge 20 February 2019, 21:14:46 UTC Merge branch 'fix-gio-modules-msvc' into 'master' gio: Also support modules built with MSVC See merge request GNOME/glib!686 20 February 2019, 21:14:46 UTC
2d6c4b2 Nirbheek Chauhan 20 February 2019, 17:07:56 UTC meson: Add gobjectenumtypes.h to gioenumtypes_dep Almost everything that needs gioenumtypes.h also needs gobjectenumtypes.h. Fixes: ccache cc @gio/win32/gio@win32@@giowin32@sta/gwin32filemonitor.c.obj.rsp In file included from ../gio/win32/gwin32filemonitor.h:25:0, from ../gio/win32/gwin32filemonitor.c:26: ../glib/glib-object.h:37:10: fatal error: gobject/gobjectenumtypes.h: No such file or directory #include <gobject/gobjectenumtypes.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 20 February 2019, 17:07:56 UTC
8e3fc7d Nirbheek Chauhan 20 February 2019, 15:18:33 UTC gio: Also support modules built with MSVC GIO modules built with MSVC do not begin with 'lib', but they can begin with 'gio'. Without this, you can only load GIO modules built with MSVC that are `name.dll`, not `gioname.dll`. 20 February 2019, 15:56:36 UTC
9aab306 Philip Withnall 20 February 2019, 10:38:29 UTC Merge branch 'fix_cname' into 'master' glib-compile-resources: Fixes #1675 Closes #1675 See merge request GNOME/glib!633 20 February 2019, 10:38:29 UTC
45655b8 Felix Potthast 20 February 2019, 10:38:29 UTC glib-compile-resources: Fixes #1675 20 February 2019, 10:38:29 UTC
aa6aa8b Sebastian Dröge 18 February 2019, 14:13:33 UTC Merge branch 'gerror-docs-omission' into 'master' gerror: Add a missing precondition assertion in documentation See merge request GNOME/glib!677 18 February 2019, 14:13:33 UTC
321f914 Philip Withnall 18 February 2019, 13:23:13 UTC gerror: Add a missing precondition assertion in documentation Inspired by !673. Signed-off-by: Philip Withnall <withnall@endlessm.com> 18 February 2019, 13:23:13 UTC
b72b4e2 Philip Withnall 18 February 2019, 12:54:45 UTC Merge branch 'w32-testsuite-fixes-socket' into 'master' Socket fixes to W32 test suite See merge request GNOME/glib!666 18 February 2019, 12:54:45 UTC
9530883 Emmanuele Bassi 18 February 2019, 10:15:30 UTC Merge branch 'unused-warning' into 'master' Initialize a variable See merge request GNOME/glib!676 18 February 2019, 10:15:30 UTC
f011be9 Emmanuele Bassi 18 February 2019, 09:50:26 UTC Initialize a variable Compilers get confused when variables are initialized by a function by taking them as reference in an out argument; this, coupled with the fact that C does not initialize variables by default, most commonly results in a "maybe uninitialized" compiler warning. 18 February 2019, 09:50:26 UTC
8423e59 Philip Withnall 18 February 2019, 08:55:54 UTC 2.59.3 Signed-off-by: Philip Withnall <withnall@endlessm.com> 18 February 2019, 08:55:54 UTC
f4effa3 Alan Mortensen 16 February 2019, 19:55:31 UTC Updated Danish translation 16 February 2019, 19:55:31 UTC
055526b Baurzhan Muftakhidinov 16 February 2019, 12:16:13 UTC Update Kazakh translation 16 February 2019, 12:16:13 UTC
eac2b1a Michael Catanzaro 14 February 2019, 18:26:17 UTC Merge branch 'wip/tingping/socket-cancellation' into 'master' gsocketclient: Ensure task is always returned on cancel Closes libsoup#132 See merge request GNOME/glib!647 14 February 2019, 18:26:17 UTC
0a2d4f6 Matej Urbančič 14 February 2019, 17:39:17 UTC Updated Slovenian translation 14 February 2019, 17:39:17 UTC
032c76e Kukuh Syafaat 14 February 2019, 15:07:12 UTC Update Indonesian translation 14 February 2019, 15:07:12 UTC
37f9b61 Christoph Reiter 14 February 2019, 13:36:15 UTC Merge branch 'gdbus-fix-use-after-free' into 'master' gdbus: Fix a potential use-after-free on connection close. Fixes #1686 Closes #1686 See merge request GNOME/glib!671 14 February 2019, 13:36:15 UTC
cca7ab2 Philip Withnall 14 February 2019, 13:23:28 UTC Merge remote-tracking branch 'gvdb/master' into update-gvdb 14 February 2019, 13:23:28 UTC
11309b7 Christoph Reiter 14 February 2019, 13:20:16 UTC Revert "tests: Mark gdbus-peer test as flaky". See #1686 This reverts commit 983a40bf34063c90a2d916de82a5580d2c8f9ed5. 14 February 2019, 13:20:32 UTC
067992f Christoph Reiter 14 February 2019, 03:16:18 UTC gdbus: Fix a potential use-after-free on connection close. Fixes #1686 512e9b3b34d added a call to schedule_pending_close() in the read callback after the reference to the worker is already gone. In case this was the last reference to the worker this resulted in a use-after-free. 6f3d57d2ee2 made this more likely to happen because on connection close the worker cancel action is now async while the reference to the worker gets dropped right away. Move the call to schedule_pending_close() before the unref. Fixes #1686 14 February 2019, 13:19:55 UTC
4cf8fd0 Philip Withnall 14 February 2019, 13:17:45 UTC Merge branch 'tests-as-root' into 'master' Fix some tests when running as root See merge request GNOME/glib!672 14 February 2019, 13:17:45 UTC
786753a Dan Nicholson 11 May 2014, 21:38:27 UTC tests: keyfile writability not affected by file mode for root When testing as root, changing the permissions of the keyfile will have no effect on the writability since root bypasses these permissions. See path_resolution(7). Skip the test in this case. 14 February 2019, 11:35:26 UTC
888aa4c Philip Withnall 13 February 2019, 20:42:35 UTC tests: Use g_assert_*() rather than g_assert() in GSettings tests g_assert_*() give more informative error messages, and aren’t compiled out when building with G_DISABLE_ASSERT. Signed-off-by: Philip Withnall <withnall@endlessm.com> 14 February 2019, 11:35:26 UTC
c00724d Руслан Ижбулатов 11 February 2019, 23:45:53 UTC socket test: Use loopback for connecting, not 0.0.0.0 getsockname() returns the address that the socket was bound to. If it was bound to INADDR_ANY, getsockname() will stubbornly return INADDR_ANY (and someport - that one is valid). Subsequent connection attempts to INADDR_ANY:someport will fail with winsock. Actually, it doesn't make even sense to connect to INADDR_ANY at all (where is the socket connecting to? To a random interface of the host?), so this is just a straight-up change, without platform-specific ifdefing. Use loopback instead of INADDR_ANY. To ensure that binding and creation of INADDR_ANY is still tested, use two addresses: bind to INADDR_ANY, but connect to loopback, with the port number that we got from the bound address. 13 February 2019, 18:22:10 UTC
fbb97b4 Philip Withnall 13 February 2019, 16:53:32 UTC Merge branch 'gdbus-peer-flaky' into 'master' tests: Mark gdbus-peer test as flaky See merge request GNOME/glib!668 13 February 2019, 16:53:32 UTC
843a042 Philip Withnall 13 February 2019, 16:41:14 UTC Merge branch 'w32-mount-sort' into 'master' GWin32VolumeMonitor: Sort the volumes correctly See merge request GNOME/glib!669 13 February 2019, 16:41:14 UTC
29bde32 Philip Withnall 13 February 2019, 16:39:52 UTC Merge branch 'ossfuzz-12686-variant-parse-negative-ints' into 'master' gvariant-parser: Fix parsing of G_MININT* values in GVariant text format See merge request GNOME/glib!638 13 February 2019, 16:39:52 UTC
7c7bd56 Sebastian Dröge 13 February 2019, 16:15:19 UTC Merge branch 'alatiera/pollable-typo' into 'master' gpollableoutputstream: Fix the description of the interface See merge request GNOME/glib!670 13 February 2019, 16:15:19 UTC
3e77699 Jordan Petridis 13 February 2019, 15:47:34 UTC gpollableoutputstream: Fix the description of the interface Looks like this was a copy-paste typo from the Input interface. 13 February 2019, 15:52:21 UTC
0c16230 Руслан Ижбулатов 13 February 2019, 13:55:11 UTC GWin32VolumeMonitor: Sort the volumes correctly Use a static GQueue to form the GList of mounts by appending (which is fast, because GQueue tracks the tail pointer of its internal GList), then return that GList. This way we don't need to form the list by prepending, which would have made it necessary to reverse it before returning. If the list is not ordered correctly, local drives in GTK places sidebar are shown in reverse order. 13 February 2019, 15:27:29 UTC
ea1235c Rafael Fontenelle 13 February 2019, 13:21:05 UTC Update Brazilian Portuguese translation 13 February 2019, 13:21:05 UTC
983a40b Philip Withnall 13 February 2019, 12:04:26 UTC tests: Mark gdbus-peer test as flaky It is occasionally deadlocking. See #1686. Signed-off-by: Philip Withnall <withnall@endlessm.com> 13 February 2019, 12:04:26 UTC
c5c9b29 Philip Withnall 13 February 2019, 10:40:11 UTC Merge branch 'w32-testsuite-fixes-general' into 'master' General fixes to W32 test suite Closes #875 See merge request GNOME/glib!665 13 February 2019, 10:40:11 UTC
0f26836 Philip Withnall 13 February 2019, 10:37:22 UTC Merge branch 'w32-testsuite-fixes-gsubprocess' into 'master' GSubprocess fixes for W32 test suite See merge request GNOME/glib!667 13 February 2019, 10:37:22 UTC
95899c1 Iain Lane 13 February 2019, 10:00:13 UTC Merge branch 'socketclient-slow-install-preload-library' into 'master' tests: Install the slow-connect-preload.so library and use it See merge request GNOME/glib!651 13 February 2019, 10:00:13 UTC
1ecaae6 Iain Lane 12 February 2019, 11:36:05 UTC installed-tests: Install the slow-connect-preload.so library and use it The gsocketclient-slow test needs this, otherwise connect() succeeds immeidately and the test fails, because it is checking that cancellation works. We weren't installing it for installed tests. 13 February 2019, 09:45:08 UTC
07a1a80 Iain Lane 12 February 2019, 11:29:10 UTC installed tests: Allow tests to set environment variables It's necessary sometimes for installed tests to be able to run with a custom environment. For example, the gsocketclient-slow test requires an LD_PRELOADed library to provide a slow connect() (this is to be added in a followup commit). Introduce a variable `@env@` into the installed test template, which we can override as necessary when generating `.test` files, to run tests prefixed with `/usr/bin/env <LIST OF VARIABLES>`. As the only test that requires this currently lives in `gio/tests/`, we are only hooking this up for that directory right now. If other tests in future require this treatment, then the support can be extended at that point. 13 February 2019, 09:43:49 UTC
1cc78bf Руслан Ижбулатов 11 February 2019, 23:55:08 UTC GSubprocess test: Adjust the cwd test to pass on Windows There's no /tmp directory on Windows. Use g_get_tmp_dir(), and adjust the test to work with that. The test *still* checks the basename of the new CWD, it just doesn't need to be "tmp" anymore. 13 February 2019, 08:52:59 UTC
4bc1aa2 Руслан Ижбулатов 11 February 2019, 23:53:38 UTC GSubprocess test: Add PATH to the envtable that is passed to child envp in spawn() functions is the *whole* environment table for the child process. Including PATH. Thus, unless PATH is explicitly put into that table, the process will be spawned without PATH. Since on Windows binaries are found via PATH instead of LD_LIBRARY_PATH or whatever, almost no program (unless installed in WINDIR, maybe) can run without a PATH. Certainly not test programs - meson adds bld subdirs to the PATH to make sure that test programs use uninstalled glib at runtime. So make sure that PATH is passed along. 13 February 2019, 08:52:58 UTC
01642d6 Руслан Ижбулатов 11 February 2019, 23:51:53 UTC GSubprocess test: Use LINEEND more Windows \r\n EOLs strike again. The test already knows about LINEEND, so make it use LINEEND more (instead of swithcing pipes to binary mode). This also applies to counting the bytes read. 13 February 2019, 08:52:58 UTC
f150de2 Руслан Ижбулатов 11 February 2019, 23:44:55 UTC socket test: Bind Windows UDP sockets before calling recv() Winsock can't recv() on unbound UDP sockets. Bind the socket to loopback before trying to receive data on it. 13 February 2019, 08:51:31 UTC
1f5d7ee Руслан Ижбулатов 11 February 2019, 23:43:14 UTC socket test: Adjust for Windows-specific sendto() error With winsock sending messages to NULL results in G_IO_ERROR_NOT_CONNECTED instead of G_IO_ERROR_FAILED. MSDN says: WSAENOTCONN 10057 Socket is not connected. A request to send or receive data was disallowed because the socket is not connected and (when sending on a datagram socket using sendto) no address was supplied. So this is a direct mapping of the implementation error. Covering it up in the wrapper (by converting it to G_IO_ERROR_FAILED) doesn't seem feasible or needed (no one, except for the testsuite, really cares which unrecoverable error is returned by sendto()). 13 February 2019, 08:51:31 UTC
1e74b58 Руслан Ижбулатов 08 February 2019, 20:59:23 UTC GLib test: Adjust to follow the implementation Canonicalization converts slashes to backslashes on Windows (most of the time). This is a horrible design decision, but that's what it does, and it's too late to change that. The test shouldn't expect anything else. 13 February 2019, 08:49:42 UTC
3ffa7ed Руслан Ижбулатов 08 February 2019, 20:54:50 UTC GDate test: Disable Julian epoch test on Windows Windows uses FILETIME, which starts counting from 1st Jan of year 1601 and, unlike time_t, can't be negative, so Windows simply has no way to do timestamp-math for dates before then. SYSTEMTIME (an equivalent of struct tm) can, obviously, represent almost arbitrary date starting from 1st Jan of year 0 (it's unsigned...), but GetDateFormatW() converts it to FILETIME at some point in its implementation, and fails. Unless the whole strftime() implementation of GDate is replaced by something that doesn't rely on WinAPI, this part of the test will never pass. 13 February 2019, 08:49:42 UTC
00908bc Руслан Ижбулатов 08 February 2019, 20:31:21 UTC network-address test: Disable scope ID tests on Windows getaddrinfo() in winsock can't understand scope IDs. There's no obvious way to fix that, short of re-implementing that function, so disable that part of the test on Windows. 13 February 2019, 08:49:42 UTC
14aae26 Руслан Ижбулатов 08 February 2019, 20:30:20 UTC autoptr test: Use OS-dependent path separator Since GFile canonicalizes the path it is given, expect the '\\' separator on Windows. 13 February 2019, 08:49:42 UTC
294d818 Руслан Ижбулатов 08 February 2019, 20:27:23 UTC Use OS-dependent separator for G_RESOURCE_OVERLAYS G_RESOURCE_OVERLAYS is a list of resource-path and filesystem-path pairs. Since on Windows filesystem paths use ':', this list can't be ':'-separated there. Fix that by making it ';'-separated on Windows. Make the parser error clearer (we're not looking for a slash, we're looking for an absolute path). 13 February 2019, 08:49:42 UTC
ccbadcf Руслан Ижбулатов 08 February 2019, 20:20:22 UTC GWinHTTPVfs: use URI parser for parsing URIs If a URI can't be handled by by WinHTTPVfs, it should pass that URI along to the URI parser of the wrapped Vfs, not to its generic parser. Theoretically, generic parser should also be able to handle URIs, but this is subject to Vfs semantics. In case of Windows, the wrapped Vfs is GLocalVfs, which is *local* and treats any generic names as either file:// URIs or as filesystem paths. It only ever treats URIs as URIs when they are passed to its URI parser. This breaks the testsuite when g-icon GIO test passes unhandleable sftp:// URI, and expects it to come through unmolested, yet GLocalVfs, getting that URI as a generic parse name, treats it as a filesystem path, and then "canonicalizes" it by prepending CWD. Fix this by making WinHTTPVfs pass any URIs it gets to the URI parser of the wrapped Vfs. This way unknown URIs remain URI-ish. This seems like a reasonable things to do, since the URI parser should not be given anything other than URIs, so there's no reason to try generic parsing with these strings. Closes: #875 13 February 2019, 08:49:42 UTC
fb37239 Руслан Ижбулатов 08 February 2019, 20:15:19 UTC testsuite: use binary mode for stdout on Windows It's much easier than adjusting the test logic to account for the extra \r. 13 February 2019, 08:49:42 UTC
16dc979 Emin Tufan Çetin 12 February 2019, 14:26:16 UTC Update Turkish translation 12 February 2019, 14:26:16 UTC
8a5228b Serdar Sağlam 12 February 2019, 14:20:41 UTC Update Turkish translation 12 February 2019, 14:20:41 UTC
b841c9a Philip Withnall 12 February 2019, 12:01:46 UTC Merge branch 'gstring-docs' into 'master' gstring: fully document semantics of @len for g_string_insert_len See merge request GNOME/glib!650 12 February 2019, 12:01:46 UTC
df5592f Michael Catanzaro 11 February 2019, 14:22:05 UTC Merge branch 'wip/tingping/network-address-fixes' into 'master' gnetworkaddress: Never end enumeration before resolving completes Closes #1680 See merge request GNOME/glib!646 11 February 2019, 14:22:05 UTC
9a6ec14 Daniel P. Berrangé 11 February 2019, 13:30:12 UTC gstring: fully document semantics of @len for g_string_insert_len The g_string_insert_len method accepts '-1' for its len parameter, as a shorthand for strlen(val). Likewise the various convenience wrappers around it also accept -1. This was not documented, leaving developers to wonder why len is a gssize, instead of gsize. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> 11 February 2019, 14:08:40 UTC
085081e Patrick Griffis 11 February 2019, 13:53:23 UTC gnetworkaddress: Never end enumeration before resolving completes Previously once the end of addresses was reached it would return NULL even if it was waiting on a dns response. Now it will keep waiting so all addresses are received. Fixes #1680 11 February 2019, 13:59:33 UTC
c832910 Patrick Griffis 11 February 2019, 13:51:47 UTC gnetworkaddress: Factor out initializing address list into function 11 February 2019, 13:59:31 UTC
back to top