https://github.com/GNOME/glib

sort by:
Revision Author Date Message Commit Date
1273fa3 Update Basque translation 28 April 2019, 09:21:55 UTC
63af8ed Merge branch 'mate-xfce4-term' into 'master' gdesktopappinfo: Add support for MATE and Xfce4 terminals See merge request GNOME/glib!795 26 April 2019, 11:27:19 UTC
0b56229 Merge branch 'master-terminology' into 'master' general: Remove a few unhelpful references to ‘master’ See merge request GNOME/glib!792 25 April 2019, 15:26:06 UTC
292cb2c gdesktopappinfo: Add support for MATE and Xfce4 terminals Add support for mate-terminal and xfce4-terminal with higher precedence over xterm as it's likely people that have those want to use them. They both use the gnome-terminal `-x` switch instead of xterm's `-e`. 25 April 2019, 14:10:49 UTC
aba0b64 Merge branch 'issue-1751' into 'master' cocoanotificationbackend: do not release readonly property Closes #1751 See merge request GNOME/glib!786 25 April 2019, 09:11:44 UTC
8b1d763 Update Indonesian translation 25 April 2019, 08:48:15 UTC
192bf09 general: Remove a few unhelpful references to ‘master’ Some of these have a negative master/slave connotation, and they add no value. Change or drop them. Signed-off-by: Philip Withnall <withnall@endlessm.com> 25 April 2019, 08:25:49 UTC
0bf5a8c Merge branch 'wip/tingping/rtld-check-fix' into 'master' build: Fix check for RTLD_NEXT See merge request GNOME/glib!782 23 April 2019, 16:09:38 UTC
a6a8017 Merge branch '1753-resolver-test-leaks' into 'master' tests: Fix some minor tests in the GResolver tests in manual mode Closes #1753 See merge request GNOME/glib!788 23 April 2019, 15:13:59 UTC
c4493d2 cocoanotificationbackend: do not release readonly property Fixes a crash when releasing a property that was not retained before. Helps: https://gitlab.gnome.org/GNOME/glib/issues/1751 23 April 2019, 15:10:12 UTC
9144aa2 tests: Fix some minor tests in the GResolver tests in manual mode Signed-off-by: Philip Withnall <withnall@endlessm.com> https://gitlab.gnome.org/GNOME/glib/issues/1753 23 April 2019, 10:31:04 UTC
334c77d Merge branch 'wip/mjog/gitignore' into 'master' build: Remove */.gitignore files See merge request GNOME/glib!787 23 April 2019, 09:45:34 UTC
9a2691a Updated Spanish translation 23 April 2019, 08:23:19 UTC
6b61395 build: Remove */.gitignore files Since out-of-source-tree builds are now used after switching to meson, we don't need .gitignore files in the source directories to ignore build artifacts. This fixes build errors when doing a meson build after an autotools build, because generated files such as gio/xdp-dbus.c won't show up in a `git status`, or be removed by a `git clean -f`, and so it won't be obvious that such files need to be removed for the meson build to succeed. 22 April 2019, 12:17:43 UTC
ce961e2 Update Catalan translation (cherry picked from commit ab1cc89209cb556193fdffcf5d40259bc45ff13d) 17 April 2019, 16:53:39 UTC
641966c build: Fix check for RTLD_NEXT 16 April 2019, 16:24:06 UTC
0cdbdb3 Merge branch 'report-license' into 'master' Add copyright and licensing terms to test report generator See merge request GNOME/glib!780 16 April 2019, 11:44:43 UTC
02f18de Add copyright and licensing terms to test report generator So that other projects can use it. 16 April 2019, 10:45:43 UTC
e6f1b36 Merge branch 'optional_tests' into 'master' Only build tests if certain conditions are met. See merge request GNOME/glib!774 16 April 2019, 10:19:41 UTC
e7b0d89 Only build tests if certain conditions are met. Currently, there is no way to prevent tests from building using meson. When cross-compiling, building the tests isn't necessary. Instead, only build the tests on the following conditions: 1) If not cross-compiling. 2) If cross-compiling, and there is an exe wrapper. 16 April 2019, 10:19:41 UTC
422e5fb Merge branch 'w32-argv0' into 'master' W32: swap special g_get_prgname() for platform_get_argv0() See merge request GNOME/glib!766 16 April 2019, 08:40:55 UTC
cf39fbd W32: swap special g_get_prgname() for platform_get_argv0() Commit 398008da added a W32-only code (from commit 7e0e251a) to g_get_prgname() that makes this function never return NULL. This is inconsistent with the other platforms. Revert the change, and add an implementation for platform_get_argv0(), which is used by GOption when g_get_prgname() == NULL. The W32 platform_get_argv0() code is different from the one that was in g_get_prgname(), because it should be getting argv0, not the name of the executable that is being run (although most of the time they are one and the same). Adjust thest option-argv0 test to expect it to pass on W32. 16 April 2019, 08:40:55 UTC
c95e2ae 2.61.0 Signed-off-by: Philip Withnall <withnall@endlessm.com> 15 April 2019, 11:45:02 UTC
3174e62 Merge branch 'docs-symbols' into 'master' Fix 2.62 documentation symbols See merge request GNOME/glib!779 15 April 2019, 11:26:09 UTC
a00d6b0 docs: Add GLib 2.62 version macros to glib-sections.txt Signed-off-by: Philip Withnall <withnall@endlessm.com> 15 April 2019, 11:09:33 UTC
4ac7d2d docs: Add GLib 2.62 symbols to glib-docs.xml Signed-off-by: Philip Withnall <withnall@endlessm.com> 15 April 2019, 11:09:16 UTC
cd04cf7 Merge branch '1614-freebsd-threading-flaky' into 'master' tests: Unmark several gdbus-* tests as flaky Closes #1614 See merge request GNOME/glib!777 15 April 2019, 09:11:13 UTC
14e90e3 Merge branch '1709-resource-llvm' into 'master' tests: Only run --external-data test on GNU ld/objcopy Closes #1711 and #1709 See merge request GNOME/glib!776 12 April 2019, 18:30:55 UTC
b11f323 tests: Only run --external-data test on GNU ld/objcopy Other GCC-like implementations of ld/objcopy (like LLVM) don’t yet support the right command line arguments, so can’t compile the test. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://gitlab.gnome.org/GNOME/glib/issues/1709 12 April 2019, 17:00:12 UTC
ea8e650 build: Refactor resources test build instructions This introduces no functional changes, but combines two duplicated lists and makes the meson.build file a little easier to follow. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1711 12 April 2019, 17:00:12 UTC
a06d7cc build: Fix some whitespace problems in gio/tests/meson.build Signed-off-by: Philip Withnall <withnall@endlessm.com> 12 April 2019, 17:00:12 UTC
bc81b2c tests: Unmark several gdbus-* tests as flaky After repeated local testing, I can’t reproduce failures with them: meson test --repeat 5000 gdbus-auth meson test --repeat 5000 gdbus-bz627724 meson test --repeat 5000 gdbus-connection The FreeBSD failures from pthread calls mentioned in #1614 should probably manifest as use-after-free for GMutex or pthread_mutex_t on Linux. Failing that, I haven’t seen any relevant FreeBSD failures on CI for at least a month, so if it’s not fixed, the chances of debugging are very low. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://gitlab.gnome.org/GNOME/glib/issues/1614 12 April 2019, 16:08:22 UTC
1fbf82b gdbusprivate: Clarify GDBusMessage ownership transfers Add g_steal_pointer() and g_clear_object() calls in various places to clarify the ownership transfers for GDBusMessage instances, in a bid to understand what’s going on in this code and to try to find a use-after-finalize problem. This introduces no functional changes, but hopefully makes the code a little clearer. Signed-off-by: Philip Withnall <withnall@endlessm.com> 12 April 2019, 15:56:04 UTC
96aa2e3 gdbusdaemon: Fix error handling for filtering outgoing messages If the filter function for an outgoing message fails to copy the GDBusMessage, that failure was previously ignored, and GDBusMessage methods could be called on a NULL instance. Avoid that. Signed-off-by: Philip Withnall <withnall@endlessm.com> 12 April 2019, 15:55:17 UTC
2dac148 gthreadedsocketservice: Handle thread pool push failure This was previously silently ignored, and would result in a leak. Signed-off-by: Philip Withnall <withnall@endlessm.com> 12 April 2019, 14:24:05 UTC
035c5d0 gthreadedsocketservice: Move obj reference to per-job data Rather than keeping a reference to the GThreadedSocketService as the user_data for every thread pool job, add it to a member of the per-job data struct (GThreadedSocketServiceData). This should make no difference overall, as it’s just moving the refcounting around, but it does seem to fix an occasional double-unref crash on shutdown where the GThreadedSocketService is unreffed during finalisation. In any case, it makes the object ownership clearer. Signed-off-by: Philip Withnall <withnall@endlessm.com> 12 April 2019, 14:22:19 UTC
63823ae gthreadedsocketservice: Abstract out a free function This introduces no functional changes. Signed-off-by: Philip Withnall <withnall@endlessm.com> 12 April 2019, 14:21:33 UTC
ec569ff gthreadedsocketservice: Tidy up property declarations This introduces no functional changes. Signed-off-by: Philip Withnall <withnall@endlessm.com> 12 April 2019, 14:18:48 UTC
61c4531 Merge branch 'autodetect-iconv-impl' into 'master' meson: Add autodetection to the iconv combo option Closes #1557 See merge request GNOME/glib!759 12 April 2019, 06:02:45 UTC
17823fa ci: The iconv combo option values have changed 12 April 2019, 05:42:28 UTC
ace32cd gconvert: Don't differentiate between GNU iconv and macOS iconv Both provide iconv_open, and in fact, we weren't using the difference anywhere in glib at all. 12 April 2019, 05:42:28 UTC
2f066ae meson: Add autodetection to the iconv combo option Instead of requiring the user to specify which option to use, which they will not really know, nor should they need to know. Search for each type of iconv (in the C library, as a separate native library, as the GNU implementation) by default. Fixes https://gitlab.gnome.org/GNOME/glib/issues/1557 12 April 2019, 05:42:28 UTC
eefe435 Merge branch 'wip/nielsdg/gdbus-colorized-output' into 'master' RFC: gdbus-tool: Add --color option for introspect See merge request GNOME/glib!761 11 April 2019, 22:39:53 UTC
7c58426 Merge branch 'gnulib.msvc.fixes' into 'master' Fix gnulib build on older Visual Studio builds See merge request GNOME/glib!757 11 April 2019, 16:51:14 UTC
65b6aac Merge branch 'linux-argv0' into 'master' tests: Check that option-argv0 test succeeds on Linux See merge request GNOME/glib!772 11 April 2019, 16:46:17 UTC
6287f64 gdbus-tool: Colorize the output of "introspect" When available on stdout, the `gdbus introspect` command will now add colors to make it easier for humans to visually parse the output. https://gitlab.gnome.org/GNOME/glib/merge_requests/761 11 April 2019, 16:03:50 UTC
6b8c9c7 Merge branch 'gslice-use-G_APPROX_VALUE-macro' into 'master' gslice: Use a convenience macro See merge request GNOME/glib!765 09 April 2019, 08:57:09 UTC
de5761d glib/gnulib: Include gnulib_math.h in place of math.h For the new gnulib modules that were added, include gnulib_math.h in place of math.h, so that the replacement functions can be properly referenced. 08 April 2019, 09:51:00 UTC
35de287 Update glib/gnulib/README List the added gnulib modules that need to be updated. 08 April 2019, 09:51:00 UTC
b532b9c build: Check for more math.h functions in gnulib There are now C99 functions that the printf items want to use that may not be necessarily supported by the math.h that is shipped by the compiler, such as signbit(), isinf(), isnan() and isfinite() and their double, long and float counterparts. This checks for whether these functions are provided by the math.h shipped by the compiler, and builds the gnulib implementations of them if they cannot be found. Currently no attempt is made to check whether these, if available from the compiler's math.h, are compliant with the specs. 08 April 2019, 09:50:59 UTC
a1fbeb3 build: Improve tests for frexpl() and ldexpl() The test programs for those in the Meson build files will not work for Visual Studio prior to 2013 (whereas the rest of the code does). Improve the tests for these by: -Adding a test to see whether we can re-define a prototype for these functions, using cc.compiles(). If so, set HAVE_DECL_xxxx to be 0, otherwise set HAVE_DECL_xxxx to be 1. Also, for glib/gnulib/frexpl.c, don't undefine frexpl on Visual Studio, otherwise we will not be able to compile/link it on Visual Studio compilers. 08 April 2019, 09:50:59 UTC
2ed56cc Merge branch 'wip/ebassi/test-report' into 'master' ci: Generate a cover report for the test suite See merge request GNOME/glib!769 08 April 2019, 09:43:04 UTC
3e54a34 CI: Run test coverage for Visual Studio builds Ensure that we do run it and upload the results. 08 April 2019, 08:51:47 UTC
b1e6e7f .gitlab-ci/test-msvc.bat: Generate cover report for tests ...for Visual Studio builds in the CI. 08 April 2019, 06:06:22 UTC
7a399e8 Fix the "/proc/self/cmdline" test Add a missing ifdef from gfileutils.c that is needed for O_BINARY. The other option was to remove O_BINARY, but i left it there for the sake of completeness, as this is what g_file_get_contents() uses. 07 April 2019, 18:41:39 UTC
7db35ec tests: Check that option-argv0 test succeeds on Linux To avoid potential regression in feature check that configures `HAVE_PROC_SELF_CMDLINE` treat test failures on Linux as fatal. This restores behaviour from before 4c038a27ff14170141f62f3ab61a6fa7c4747f09. 07 April 2019, 00:00:00 UTC
95b7a8a ci: Run test coverage for MSYS2 job 06 April 2019, 14:31:41 UTC
ed65996 ci: Generate a cover report for the test suite GitLab can show the results of a CI pipeline if the pipeline generates a report using the JUnit XML format. Since Meson provides a machine parseable output for `meson test`, we can take that and turn it into XML soup. 06 April 2019, 13:19:20 UTC
45a3598 gslice: Use a convenience macro In magazine_cache_trim(), use the recent G_APPROX_VALUE macro to decide when to trim the magazine chain. See <URL:https://gitlab.gnome.org/GNOME/glib/commit/fad04d2e18832106ecb4b9f04ae3bfdbcacc9053#note_471824>. 03 April 2019, 16:46:20 UTC
9d43bfc Merge branch 'cygwin-visibility' into 'master' Use W32 visibility for Cygwin See merge request GNOME/glib!752 03 April 2019, 16:03:16 UTC
430d584 Merge branch 'cygwin-proc-self-cmdline' into 'master' Check for /proc/self/cmdline See merge request GNOME/glib!754 03 April 2019, 15:38:06 UTC
4c038a2 Check for /proc/self/cmdline Instead of hardcoding /proc/self/cmdline use for __linux__ only, do a configure-time test for it. Specifically, this enables /proc/self/cmdline use on Cygwin. The configure-time test is very primitive (just tests that the file exists and that it's possible to read more than one byte from it), relying on the testsuite for more extensive checks. The test in the testsuite is modified to always run, even on platforms where it isn't supposed to pass. If it fails there, the testing framework skips it. If the test unexpectedly passes, that is reported too. 03 April 2019, 15:17:34 UTC
cf54fc3 Merge branch '1737-gdbus-tool-wait' into 'master' gdbus-tool: Fix units for `gdbus-tool wait` timeout Closes #1737 See merge request GNOME/glib!753 03 April 2019, 12:36:54 UTC
8098814 Merge branch 'g_get_prgname-annotations' into 'master' gutils: Add (nullable) annotation to g_get_prgname() See merge request GNOME/glib!762 03 April 2019, 12:32:42 UTC
abde3ef Merge branch 'wip/oholy/trash-autofs' into 'master' gunixmounts: Return the last matching mount for same mount path Closes #1727 See merge request GNOME/glib!740 03 April 2019, 12:23:10 UTC
8349cee Merge branch 'use_after_free' into 'master' Fix use-after-free triggered by gnome-session-binary See merge request GNOME/glib!741 03 April 2019, 12:01:04 UTC
c1c2644 gutils: Add (nullable) annotation to g_get_prgname() It can return NULL if no program name has been set yet (i.e. g_set_prgname() has not been called from somewhere). Signed-off-by: Philip Withnall <withnall@endlessm.com> 03 April 2019, 11:31:44 UTC
9976418 Merge branch 'fix-cocoa-backend-loading' into 'master' Properly ensure the cocoa notification backend type See merge request GNOME/glib!760 01 April 2019, 09:34:44 UTC
55870d4 Properly ensure the cocoa notification backend type 29 March 2019, 14:52:38 UTC
d86146d gdbus-tool: Fix units for `gdbus-tool wait` timeout They were documented as being in seconds, but implemented as milliseconds. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1737 27 March 2019, 17:04:58 UTC
ad614fc Merge branch 'cygwin-rtld_next' into 'master' Check for RTLD_NEXT See merge request GNOME/glib!750 27 March 2019, 16:25:48 UTC
a53ff74 Check for RTLD_NEXT Check for RTLD_NEXT being present, and disable the gsocketclient-slow test if it's absent, since the shlib dependency of that test requires RTLD_NEXT to function. This allows the testsuite to be built on Cygwin, which behaves exactly like UNIX, but doesn't have RTLD_NEXT. 27 March 2019, 16:10:17 UTC
d264001 Merge branch 'cygwin-macro' into 'master' Set G_WITH_CYGWIN again See merge request GNOME/glib!736 26 March 2019, 22:55:56 UTC
ad19bb8 Merge branch '1258-input-stream-annotations' into 'master' ginputstream: Add missing (out) annotations to read() functions Closes #1258 See merge request GNOME/glib!738 26 March 2019, 22:53:27 UTC
f84d107 Merge branch 'wip/jtojnar/gsettings-cleanup' into 'master' gio: Add missing autocleanup definition for GSettingsSchema{Key,Source} See merge request GNOME/glib!749 26 March 2019, 22:50:05 UTC
c940816 gio: Add missing autocleanup definition for GSettingsSchemaKey 26 March 2019, 15:40:28 UTC
edaae61 gio: Add missing autocleanup definition for GSettingsSchemaSource 26 March 2019, 15:38:06 UTC
01d9741 Merge branch 'cocoa-notification-backend-default' into 'master' gcocoanotificationbackend: give more priority than the gtk one See merge request GNOME/glib!745 26 March 2019, 14:30:45 UTC
1e1759d gcocoanotificationbackend: give more priority than the gtk one On OSX both backends are built. Generally we want to use the cocoa backend by default and in case it is not supported, i.e because the application is not using a bundle then we should fallback to the gtk one. 26 March 2019, 09:20:25 UTC
052ad60 Fix use-after-free triggered by gnome-session-binary ostream_flush_cb() was calling flush_data_list_complete() with a single element list with an item that had already been freed. This was observed on OpenBSD where memory is overwritten with 0xdf during free(): error=0x0) at ../glib-2.58.3/gio/gdbusprivate.c:1156 1156 g_mutex_lock (&f->mutex); (gdb) p /x *f $74 = {mutex = {p = 0xdfdfdfdfdfdfdfdf, i = {0xdfdfdfdf, 0xdfdfdfdf}}, cond = { p = 0xdfdfdfdfdfdfdfdf, i = {0xdfdfdfdf, 0xdfdfdfdf}}, number_to_wait_for = 0xdfdfdfdfdfdfdfdf, error = 0x0} This happened because the thread freeing the element didn't properly wait for the asynchronous flush operation to finish. Gnome's developer docs say: "g_cond_wait() must always be used in a loop" https://developer.gnome.org/glib/stable/glib-Threads.html#g-cond-wait 25 March 2019, 06:44:13 UTC
9ca7ac7 Set G_WITH_CYGWIN again This macro was lost during meson migration. Set it again. Also explain that Cygwin maintainers applied patches[0] to glib that simply marked all G_PLATFORM_WIN32-protected code as !defined(G_WITH_CYGWIN), i.e. they did not want that code to compile. Instead of altering ifdef guards all over the place, we'll just not define G_PLATFORM_WIN32 for Cygwin anymore. [0]: https://github.com/cygwinports/glib2.0/blob/3a873fdd1b9a9e649563fe8e6b8ae6951b0dd3be/2.36.3-not-win32.patch 22 March 2019, 14:44:53 UTC
ecad5cd Merge branch '1732-gai_strerror-locale' into 'master' gresolver: Convert encoding of gai_strerror() return value Closes #1732 See merge request GNOME/glib!739 22 March 2019, 13:57:39 UTC
89416de gresolver: Convert encoding of gai_strerror() return value It returns a string in the libc locale, which is not necessarily UTF-8. Convert that to UTF-8 before returning it to the caller. Spotted by Tomasz Miąsko. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1732 22 March 2019, 13:32:14 UTC
3a32c75 ginputstream: Add missing (out) annotations to read() functions This is a reversion of the reversion of commit c19259526825a7eaf1a3faf64df1690e53a4b5cd, after more discussion on the issue. Fixes: #1258 22 March 2019, 13:20:41 UTC
bc52235 gunixmounts: Return the last matching mount for same mount path More mounts can have same mount path, but only the last one is accessible. Thus we should always return the last matching mount from g_unix_mount_at() and g_unix_mount_for(). This should also solve problems with g_file_trash() on automounted filesystems, which are caused by the recently added mount checks. Closes: https://gitlab.gnome.org/GNOME/glib/issues/1727 22 March 2019, 11:41:47 UTC
abeac84 Merge branch 'gai_strerror-thread-safety' into 'master' gresolver: Don’t use gai_strerror() on Windows, as it isn’t threadsafe See merge request GNOME/glib!737 21 March 2019, 14:37:18 UTC
3a11213 gresolver: Don’t use gai_strerror() on Windows, as it isn’t threadsafe Instead, use WSAGetLastError(). Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1732 21 March 2019, 11:51:37 UTC
8758604 Use W32 visibility for Cygwin Cygwin is still subject to W32 visibility mechanics. 20 March 2019, 21:10:58 UTC
ff47bb0 Merge branch 'wip/tintou/autoptr-right-function' into 'master' docs: Use the right g_autoptr function when using an auxiliary function See merge request GNOME/glib!735 20 March 2019, 14:39:44 UTC
5350f12 docs: Use the right g_autoptr function when using an auxiliary function 20 March 2019, 14:39:44 UTC
c8692ff Merge branch 'fix-warnings-glib' into 'master' Fix warnings glib See merge request GNOME/glib!680 19 March 2019, 11:02:38 UTC
10278fd Merge branch 'meson' into 'master' meson: do a build-time check for strlcpy before attempting runtime check See merge request GNOME/glib!724 19 March 2019, 10:57:58 UTC
114921c Merge branch 'dbus-address-tests' into 'master' Improve gdbus-address parsing tests See merge request GNOME/glib!730 19 March 2019, 10:53:44 UTC
fcbfa0c Merge branch 'enotsock' into 'master' GIO: Convert ENOTSOCK to G_IO_ERROR_INVALID_ARGUMENT Closes #1728 See merge request GNOME/glib!731 19 March 2019, 09:03:13 UTC
fad04d2 Fixing signedness warning in glib/gslice.c In file included from glib/glibconfig.h:9, from glib/gslice.c:20: glib/gslice.c: In function ‘magazine_cache_trim’: glib/gmacros.h:354:25: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] #define ABS(a) (((a) < 0) ? -(a) : (a)) ^ glib/gslice.c:643:10: note: in expansion of macro ‘ABS’ while (ABS (stamp - magazine_chain_uint_stamp (current)) >= allocator->config.working_set_msecs) ^~~ 17 March 2019, 18:05:35 UTC
e9f5749 Fix various signedness warnings in glib/ghash.c To conform to a better signedness schema, this patch change GHashTable.size field from gint to gsize (and change accordingly the tests with it). 17 March 2019, 18:05:35 UTC
a7aac03 Fixing various warnings in glib/gvariant-parser.c glib/gvariant-parser.c: In function ‘number_get_value’: glib/gvariant-parser.c:1924:46: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] return g_variant_new_int16 (negative ? -((gint16) abs_val) : abs_val); ^~~~~~~~~~~~~~~~~~~ glib/gvariant-parser.c:1934:46: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] return g_variant_new_int32 (negative ? -((gint32) abs_val) : abs_val); ^~~~~~~~~~~~~~~~~~~ glib/gvariant-parser.c:1944:46: error: operand of ?: changes signedness from ‘long int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] return g_variant_new_int64 (negative ? -((gint64) abs_val) : abs_val); ^~~~~~~~~~~~~~~~~~~ glib/gvariant-parser.c:1954:47: error: operand of ?: changes signedness from ‘int’ to ‘guint64’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Werror=sign-compare] return g_variant_new_handle (negative ? -((gint32) abs_val) : abs_val); ^~~~~~~~~~~~~~~~~~~ glib/gvariant-parser.c: In function ‘g_variant_parse_error_print_context’: glib/gvariant-parser.c:2785:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (point >= strlen (source_str)) ^~ 17 March 2019, 18:05:35 UTC
357c3db Fixing various warning in glib/gvarianttypeinfo.c glib/gvarianttypeinfo.c:115:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'b' */ { fixed_aligned(1) }, /* boolean */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:117:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'd' */ { fixed_aligned(8) }, /* double */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:120:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'g' */ { unaligned }, /* signature string */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:121:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'h' */ { fixed_aligned(4) }, /* file handle (int32) */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:122:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'i' */ { fixed_aligned(4) }, /* int32 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:127:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'n' */ { fixed_aligned(2) }, /* int16 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:128:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'o' */ { unaligned }, /* object path string */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:130:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'q' */ { fixed_aligned(2) }, /* uint16 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:132:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 's' */ { unaligned }, /* string */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:133:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 't' */ { fixed_aligned(8) }, /* uint64 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:134:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'u' */ { fixed_aligned(4) }, /* uint32 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:135:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'v' */ { aligned(8) }, /* variant */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:137:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'x' */ { fixed_aligned(8) }, /* int64 */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c:138:13: error: missing initializer for field ‘container_class’ of ‘GVariantTypeInfo’ {aka ‘const struct _GVariantTypeInfo’} [-Werror=missing-field-initializers] /* 'y' */ { fixed_aligned(1) }, /* byte */ ^ glib/gvarianttypeinfo.c:69:10: note: ‘container_class’ declared here guchar container_class; ^~~~~~~~~~~~~~~ glib/gvarianttypeinfo.c: In function ‘tuple_info_free’: glib/gvarianttypeinfo.c:368:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] for (i = 0; i < tuple_info->n_members; i++) ^ glib/gvarianttypeinfo.c: In function ‘tuple_set_base_info’: glib/gvarianttypeinfo.c:641:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare] if (m->i == -1 && m->type_info->fixed_size) ^~ 17 March 2019, 18:05:34 UTC
3f3a747 Fixing signedness in glib/gvariant.c glib/gvariant.c: In function ‘g_variant_new_strv’: glib/gvariant.c:1563:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] for (i = 0; i < length; i++) ^ glib/gvariant.c: In function ‘g_variant_new_objv’: glib/gvariant.c:1699:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] for (i = 0; i < length; i++) ^ glib/gvariant.c: In function ‘g_variant_new_bytestring_array’: glib/gvariant.c:1939:17: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] for (i = 0; i < length; i++) ^ 17 March 2019, 18:05:34 UTC
9023483 Fixing signedness in glib/gvariant-core.c glib/gvariant-core.c: In function ‘g_variant_ensure_size’: glib/gvariant-core.c:339:19: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare] if (value->size == (gssize) -1) ^~ 17 March 2019, 18:05:34 UTC
back to top