Skip to main content

Browse the archive

https://github.com/JuliaLang/julia
19 April 2024, 06:28:37 UTC
sort by:
Revision Author Date Message Commit Date
e618369 Kristoffer Carlsson 08 March 2024, 16:02:54 UTC precompilepkgs: package in boths deps and weakdeps are in fact only weak (#53649) Missed when porting from Pkg. Fixes https://github.com/JuliaLang/Pkg.jl/issues/3834. 08 March 2024, 16:02:54 UTC
78351b5 Ian Butterworth 08 March 2024, 15:21:33 UTC Use Base parallel precompilation to build stdlibs (#53598) Follow-on from https://github.com/JuliaLang/julia/pull/53403 This extends `Base.Precompilation.precompilepkgs` to take a list of configurations to precompile each package with, while parallelizing across all packages and configurations, and uses it to build the stdlib pkgimages. It simplifies the stdlib pkgimage build process but is (currently) dependent on having an accurately resolved Manifest.toml (Project.toml included to make the manifest easier to make). Any new/removed stdlibs or changes their dependencies will require updating the Manifest.toml. It's a bit chicken and egg, but should be manageable with manual editing of the Manifest.toml. In terms of speed improvement: MacOS aarch64 CI runner 6m19s before, 5m19 with this Note that CI builds will show the basic print with timing of each package, whereas local build will be the tidier fancy print without timings. Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com> 08 March 2024, 15:21:33 UTC
a998082 DilumAluthgeBot 08 March 2024, 15:11:22 UTC 🤖 [master] Bump the Pkg stdlib from 56c379045 to e0821116e (#53654) Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: 56c379045 New commit: e0821116e Julia version: 1.12.0-DEV Pkg version: 1.12.0 Bump invoked by: @IanButterworth Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: https://github.com/JuliaLang/Pkg.jl/compare/56c379045c8cf876b365c284a5b442f2dc9fc8af...e0821116e9f4364a2b37a77183e93d055a111f4d ``` $ git log --oneline 56c379045..e0821116e e0821116e re-enable Pkg precompilation (#3835) a2b8729ea Update version on master to 1.12 (#3832) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com> 08 March 2024, 15:11:22 UTC
4dcf357 Keno Fischer 08 March 2024, 06:26:43 UTC inference: Don't confuse frames in different interpreters (#53627) Diffractor's abstract interpreter sometimes needs to do side queries using the native interpreter. These are pushed onto the regular inference callstack in anticipation of a future where compiler plugins may want to recurse from the native interpreter back into the Diffractor abstract interpreter. However, this introduced a subtle challenge: When the native interpreter is looking at a frame that is currently on the inference stack, it would treat them as the same, incorrectly merging inference across the two abstract interpreters (which have different semantics and may not be confused). The caches for the two abstract interpreters were already different, so once things are inferred, there's no problem (likely because things were already inferred on the native interpreter), but if not, this could cause subtle and hard to debug problems. 08 March 2024, 06:26:43 UTC
321fb2c Keno Fischer 08 March 2024, 06:26:10 UTC sroa: Fix incorrect scope counting (#53630) Sroa was incorrectly assuming that every :leave leaves exactly one scope. In reality, it leaves as many scopes as the corresponding :leave references. Fix that to fix #53521. 08 March 2024, 06:26:10 UTC
fa90883 DilumAluthgeBot 08 March 2024, 03:31:27 UTC 🤖 [master] Bump the Pkg stdlib from e7d740ac8 to 56c379045 (#53637) Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: e7d740ac8 New commit: 56c379045 Julia version: 1.12.0-DEV Pkg version: 1.11.0(Does not match) Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: https://github.com/JuliaLang/Pkg.jl/compare/e7d740ac82fa4c289bb58f9acb6e60eebb6d8a8e...56c379045c8cf876b365c284a5b442f2dc9fc8af ``` $ git log --oneline e7d740ac8..56c379045 56c379045 make `delayed_delete_dir` usage a bit more backwards compatible (#3830) 5a68d7953 restore unwrap UnstableIO in precompile (#3831) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com> 08 March 2024, 03:31:27 UTC
f6504e4 Shuhei Kadowaki 08 March 2024, 00:42:49 UTC add `construct_[post]domtree(::[IRCode|CFG])` interfaces (#53638) We currently have `construct_[post]domtree(::Vector{BasicBlock})` only. The higher level interfaces are often convenient. 08 March 2024, 00:42:49 UTC
d45581c Shuhei Kadowaki 07 March 2024, 16:15:35 UTC inlining: use method match signature for union-spliting (#53600) In cases where the results of constant inference, like concrete-eval, are used for union-split inlining, `isa`-blocks are generated using the `result.edge.specTypes` stored within each `result`. However, it's been found that the `edge` returned by abstract interpretation may have been widened by the new `@nospecializeinfer`, which can result in invalid union-splitting. To address this problem, this commit tweaks the inlining algorithm so that it performs union-split inlining using the original signatures that abstract interpretation used for union-split inference, by using `match::MethodMatch`. - fixes #53590 07 March 2024, 16:15:35 UTC
a182880 Frames White 07 March 2024, 15:09:12 UTC use isempty in tests (#53617) This was not being used as it didn't have fancy printing when it failed. But that was fixed in https://github.com/JuliaLang/julia/pull/30721 so we can do this now 07 March 2024, 15:09:12 UTC
cf5f163 Phillip Alday 07 March 2024, 15:07:59 UTC typo fix in scoped values docs (#53629) 07 March 2024, 15:07:59 UTC
56f1c8a N5N3 06 March 2024, 21:55:49 UTC typeintersect: fix `UnionAll` unaliasing bug caused by innervars. (#53553) typeintersect: fix `UnionAll` unaliasing bug caused by innervars. 06 March 2024, 21:55:49 UTC
6335386 Valentin Churavy 06 March 2024, 15:04:22 UTC Unexport with, at_with, and ScopedValue from Base (#53004) fixes #52535 --------- Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> 06 March 2024, 15:04:22 UTC
02f27c2 N5N3 02 March 2024, 07:29:18 UTC typeintersect: more organized innervar wrapping 06 March 2024, 14:11:04 UTC
a556af2 N5N3 02 March 2024, 05:27:21 UTC typeintersect: fuse `unalias_unionall` And ensures all innervar get checked. 06 March 2024, 11:59:14 UTC
90d84d4 Shuhei Kadowaki 06 March 2024, 00:32:31 UTC cleanups on `src_inlining_policy` (#53599) - fixed the check with `src_inlining_policy` in typeinfer.jl - removed the `SemiConcreteResult` handling, which is no longer needed 06 March 2024, 00:32:31 UTC
fb71a5d DilumAluthgeBot 05 March 2024, 21:32:17 UTC 🤖 [master] Bump the Pkg stdlib from 48eea8dbd to e7d740ac8 (#53610) Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: 48eea8dbd New commit: e7d740ac8 Julia version: 1.12.0-DEV Pkg version: 1.11.0(Does not match) Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: https://github.com/JuliaLang/Pkg.jl/compare/48eea8dbd7b651cdc932b909c1b718bb9c3f94f4...e7d740ac82fa4c289bb58f9acb6e60eebb6d8a8e ``` $ git log --oneline 48eea8dbd..e7d740ac8 e7d740ac8 move to using Base parallel precompile (#3820) d1f91fd37 fix relative paths in test project for `[sources]` (#3825) 5c73d7f3c Support a `[sources]` section in Project.toml for specifying paths and repo locations for dependencies (#3783) 0d9aa51a9 do not use UnstableIO for subprocess (in e.g. Pkg.test) (#3823) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com> 05 March 2024, 21:32:17 UTC
427da5c Kristoffer Carlsson 05 March 2024, 17:23:08 UTC fix error path in `precompilepkgs` (#53606) this was accidentally left when porting this from Pkg.jl 05 March 2024, 17:23:08 UTC
58291db Jameson Nash 05 March 2024, 15:00:15 UTC codegen: optimize const fields of mutable objects (#53484) For example, we seek to eliminate the gc frame from this function, as observed here: ```julia julia> code_llvm((BitSet,), raw=true) do x; r = x.bits; GC.safepoint(); @inbounds r[1]; end ; Function Signature: var"https://github.com/JuliaLang/julia/issues/3"(Base.BitSet) ; @ REPL[1]:1 within `https://github.com/JuliaLang/julia/issues/3` define swiftcc i64 @"julia_#3_494"(ptr nonnull swiftself %pgcstack, ptr noundef nonnull align 8 dereferenceable(16) %"x::BitSet") #0 !dbg !5 { top: call void @llvm.dbg.declare(metadata ptr %"x::BitSet", metadata !21, metadata !DIExpression()), !dbg !22 %ptls_field = getelementptr inbounds ptr, ptr %pgcstack, i64 2 %ptls_load = load ptr, ptr %ptls_field, align 8, !tbaa !23 %0 = getelementptr inbounds ptr, ptr %ptls_load, i64 2 %safepoint = load ptr, ptr %0, align 8, !tbaa !27 fence syncscope("singlethread") seq_cst %1 = load volatile i64, ptr %safepoint, align 8, !dbg !22 fence syncscope("singlethread") seq_cst ; ┌ @ Base.jl:49 within `getproperty` %"x::BitSet.bits" = load atomic ptr, ptr %"x::BitSet" unordered, align 8, !dbg !29, !tbaa !27, !alias.scope !33, !noalias !36, !nonnull !11, !dereferenceable !41, !align !42 ; └ ; ┌ @ gcutils.jl:253 within `safepoint` %ptls_load4 = load ptr, ptr %ptls_field, align 8, !dbg !43, !tbaa !23 %2 = getelementptr inbounds ptr, ptr %ptls_load4, i64 2, !dbg !43 %safepoint5 = load ptr, ptr %2, align 8, !dbg !43, !tbaa !27 fence syncscope("singlethread") seq_cst, !dbg !43 %3 = load volatile i64, ptr %safepoint5, align 8, !dbg !43 fence syncscope("singlethread") seq_cst, !dbg !43 ; └ ; ┌ @ essentials.jl:892 within `getindex` %4 = load ptr, ptr %"x::BitSet.bits", align 8, !dbg !46, !tbaa !49, !alias.scope !52, !noalias !53 %5 = load i64, ptr %4, align 8, !dbg !46, !tbaa !54, !alias.scope !57, !noalias !58 ret i64 %5, !dbg !46 ; └ } ``` 05 March 2024, 15:00:15 UTC
3df016d Eric Hanson 05 March 2024, 13:49:02 UTC Semver: specify VersionNumber's follow v2-rc2 specifically (#53538) Since v2 has changed from v2-rc2 by saying build numbers MUST not be taken into account in precedence. I don't think changing VersionNumber's ordering in a minor release of Julia is acceptable, but since the semver landing page is now v2 rather than v2-rc2, we should update the link. closes https://github.com/JuliaLang/julia/issues/53502 05 March 2024, 13:49:02 UTC
b50344f inky 05 March 2024, 10:00:14 UTC build: remove extra .a file (#53596) fix #53569 05 March 2024, 10:00:14 UTC
d3ee213 Kristoffer Carlsson 05 March 2024, 09:59:32 UTC add back `unsafe_convert` to pointer for arrays (#53589) This caused a pretty big breakage in the ecosystem (~50 packages) and is according to Jameson "Too breaking for no necessary reason". So let's add it back. --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com> 05 March 2024, 09:59:32 UTC
892c491 Dilum Aluthge 05 March 2024, 04:00:26 UTC Docs: change "Package naming guidelines" to "Package naming rules" (#53566) I think that "guidelines" implies that these are just optional suggestions. But in practice, I think we usually insist that these are followed. So I think it might be worth changing "guidelines" to "rules", to clarify that we enforce these. 05 March 2024, 04:00:26 UTC
6745160 Kristoffer Carlsson 05 March 2024, 01:07:34 UTC Move parallel precompilation to Base (#53403) Parallel precompilation is more or less now required in order to use somewhat large packages unless you want to wait an obscene long time for it to complete. Right now, we even start a parallel precompilation on a package load if we notice that the package you are loading is not precompiled. This functionally has typically been implemented in Pkg but with Pkg not being in the sysimage it becomes a bit awkward because we then need to load Pkg from Base. The only real reason this functionality has been implemented in Pkg is that Pkg has some useful features for parsing environments. Moving precompilation to Base has typically been stalled on such an environment parser not existing in Base. However, in https://github.com/JuliaLang/julia/pull/46690 I started implemented code loading on top of a more up front environment parser (instead of the "incremental" one that currently exists in `loading.jl`) and we can retro fit this to be used as the basis of parallel precompilation. At some later point code loading could be implemented on top of it but that is for now considered future work. This PR thus adds the environment parser from the codeloading PR and implementes the parallel precompilation feature from Pkg on top of it (instead of on top of the `EnvCache` in Pkg). Some points to bring up here: - This copy pastes the progress bar implementation in Pkg into here. It is probably a bit excessive to use so we can simplify that significantly. - Parallel precompilation uses the `FileWatching` module to avoid different processes trying to precompile the same package concurrently. Right now, I used grab this from `Base.loaded_modules` relying on it being in the sysimage. - This removes the "suspended" functionality from the Pkg precompilation which does not try to precompile packages if they have "recently" failed which is unclear how useful it is in practice. This also requires the Serialization stdlib and uses data structures defined in Pkg so it is hard to keep when moving this to Base. --------- Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com> 05 March 2024, 01:07:34 UTC
50114d7 Jameson Nash 26 February 2024, 20:49:39 UTC codegen: optimize const fields of mutable objects even more Make this analysis even stronger, using a function from llvm-late-gc-lowering.cpp that implements it more aggressively 04 March 2024, 21:14:31 UTC
ece8814 Jameson Nash 26 February 2024, 20:06:31 UTC codegen: optimize const fields of mutable objects For example, we seek to eliminate the gc frame from this function, as observed here: ```julia julia> code_llvm((BitSet,), raw=true) do x; r = x.bits; GC.safepoint(); @inbounds r[1]; end ; Function Signature: var"#3"(Base.BitSet) ; @ REPL[1]:1 within `#3` define swiftcc i64 @"julia_#3_494"(ptr nonnull swiftself %pgcstack, ptr noundef nonnull align 8 dereferenceable(16) %"x::BitSet") #0 !dbg !5 { top: call void @llvm.dbg.declare(metadata ptr %"x::BitSet", metadata !21, metadata !DIExpression()), !dbg !22 %ptls_field = getelementptr inbounds ptr, ptr %pgcstack, i64 2 %ptls_load = load ptr, ptr %ptls_field, align 8, !tbaa !23 %0 = getelementptr inbounds ptr, ptr %ptls_load, i64 2 %safepoint = load ptr, ptr %0, align 8, !tbaa !27 fence syncscope("singlethread") seq_cst %1 = load volatile i64, ptr %safepoint, align 8, !dbg !22 fence syncscope("singlethread") seq_cst ; ┌ @ Base.jl:49 within `getproperty` %"x::BitSet.bits" = load atomic ptr, ptr %"x::BitSet" unordered, align 8, !dbg !29, !tbaa !27, !alias.scope !33, !noalias !36, !nonnull !11, !dereferenceable !41, !align !42 ; └ ; ┌ @ gcutils.jl:253 within `safepoint` %ptls_load4 = load ptr, ptr %ptls_field, align 8, !dbg !43, !tbaa !23 %2 = getelementptr inbounds ptr, ptr %ptls_load4, i64 2, !dbg !43 %safepoint5 = load ptr, ptr %2, align 8, !dbg !43, !tbaa !27 fence syncscope("singlethread") seq_cst, !dbg !43 %3 = load volatile i64, ptr %safepoint5, align 8, !dbg !43 fence syncscope("singlethread") seq_cst, !dbg !43 ; └ ; ┌ @ essentials.jl:892 within `getindex` %4 = load ptr, ptr %"x::BitSet.bits", align 8, !dbg !46, !tbaa !49, !alias.scope !52, !noalias !53 %5 = load i64, ptr %4, align 8, !dbg !46, !tbaa !54, !alias.scope !57, !noalias !58 ret i64 %5, !dbg !46 ; └ } ``` 04 March 2024, 21:14:31 UTC
f66fd47 Jameson Nash 04 March 2024, 21:14:08 UTC make MethodError for unhandled kwarg more accurate (#53500) Previously it threw this error manually, so it did not have the world info for this lookup and message to be fully accurate. 04 March 2024, 21:14:08 UTC
688ae0a cui fliter 04 March 2024, 18:09:52 UTC remove repetitive code (#53592) 04 March 2024, 18:09:52 UTC
144f58b Shuhei Kadowaki 04 March 2024, 17:58:28 UTC disable irinterp for interpreters with `may_optimize(...)=false` (#53580) As discussed at <https://github.com/JuliaLang/julia/commit/b8a0a3978ccf163ce8fc371a4882547dc1271d53#commitcomment-139076159>, currently external abstract interpreter that configures `may_optimize` to return `false` may end up with the internal error from irinterp since it fundamentally required optimized IR but it currently assumes that all sources from cached `CodeInstance`s are optimized. This commit addresses the issue by incorporating a `may_optimize` check in `concrete_eval_eligible`, which in turn automatically disables irinterp for such interpreters. Although there were earlier discussions suggesting the revival of `codeinfo.inferred::Bool`, this commit does not need it, and I think this approach maintains the current state more cleanly. This should fix the error of `"inference"` benchmarks from BaseBenchmarks.jl. 04 March 2024, 17:58:28 UTC
0311aa4 Michael Goerz 04 March 2024, 16:34:27 UTC Update Documenter to v1.3 for inventory writing (#53571) With the newest Documenter release, the Julia documentation will automatically have an `objects.inv` file. This file allows any other project using Documenter with the [`DocumenterInterLinks`](https://github.com/JuliaDocs/DocumenterInterLinks.jl) plugin (or any project using [Sphinx](https://www.sphinx-doc.org/en/master/)) to link directly into the Julia documentation, e.g., with ```[`Base.sort!`](@extref Julia)```. See also https://github.com/JuliaDocs/Documenter.jl/pull/2424#issuecomment-1960025462 and the following comments 04 March 2024, 16:34:27 UTC
973b4ff Diogo Netto 04 March 2024, 16:16:28 UTC yet more atomics & cache-line fixes on work-stealing queue (#53424) This regression at a large number of GC threads still shows up on a large aarch64 machine (80-core ARM Neoverse N1). ``` bench = "many_refs.jl" (gcthreads, threads) = (1, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 3807 │ 2826 │ 2633 │ 193 │ 960 │ 13 │ 892 │ 74 │ │ median │ 3810 │ 2826 │ 2633 │ 193 │ 961 │ 15 │ 892 │ 74 │ │ maximum │ 3810 │ 2831 │ 2638 │ 193 │ 962 │ 27 │ 892 │ 74 │ │ stdev │ 2 │ 3 │ 3 │ 0 │ 1 │ 7 │ 0 │ 0 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ (gcthreads, threads) = (2, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 2455 │ 1476 │ 1350 │ 126 │ 488 │ 20 │ 892 │ 60 │ │ median │ 2459 │ 1478 │ 1352 │ 126 │ 489 │ 23 │ 892 │ 60 │ │ maximum │ 2465 │ 1479 │ 1352 │ 126 │ 489 │ 23 │ 893 │ 60 │ │ stdev │ 5 │ 1 │ 1 │ 0 │ 1 │ 2 │ 0 │ 0 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ (gcthreads, threads) = (4, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 2173 │ 1194 │ 1115 │ 77 │ 463 │ 18 │ 892 │ 54 │ │ median │ 2187 │ 1194 │ 1116 │ 78 │ 463 │ 19 │ 893 │ 55 │ │ maximum │ 2217 │ 1208 │ 1130 │ 78 │ 463 │ 19 │ 893 │ 55 │ │ stdev │ 22 │ 8 │ 8 │ 1 │ 0 │ 1 │ 0 │ 0 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ (gcthreads, threads) = (8, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 2191 │ 1212 │ 1149 │ 63 │ 539 │ 19 │ 901 │ 55 │ │ median │ 2199 │ 1219 │ 1156 │ 63 │ 540 │ 20 │ 901 │ 55 │ │ maximum │ 2201 │ 1222 │ 1157 │ 65 │ 540 │ 20 │ 901 │ 56 │ │ stdev │ 5 │ 5 │ 4 │ 1 │ 1 │ 1 │ 0 │ 0 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ (gcthreads, threads) = (16, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 3897 │ 2916 │ 2854 │ 60 │ 1423 │ 20 │ 902 │ 75 │ │ median │ 4012 │ 3032 │ 2972 │ 62 │ 1491 │ 21 │ 904 │ 75 │ │ maximum │ 4026 │ 3106 │ 3044 │ 62 │ 1511 │ 22 │ 904 │ 77 │ │ stdev │ 70 │ 96 │ 96 │ 1 │ 46 │ 1 │ 1 │ 1 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ ``` This patch seems to improve performance at 16 GC threads though we still have some negative scaling for this benchmark beyond 8 GC threads (others seem fine). I didn't test whether this is indeed the optimal struct layout for the queue in this benchmark. ``` bench = "many_refs.jl" (gcthreads, threads) = (1, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 3807 │ 2822 │ 2630 │ 193 │ 959 │ 15 │ 892 │ 74 │ │ median │ 3824 │ 2823 │ 2630 │ 193 │ 959 │ 15 │ 892 │ 74 │ │ maximum │ 4307 │ 3194 │ 2974 │ 220 │ 1086 │ 19 │ 892 │ 74 │ │ stdev │ 284 │ 215 │ 199 │ 16 │ 74 │ 2 │ 0 │ 0 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ (gcthreads, threads) = (2, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 2459 │ 1476 │ 1349 │ 126 │ 488 │ 19 │ 892 │ 60 │ │ median │ 2460 │ 1479 │ 1352 │ 127 │ 488 │ 21 │ 893 │ 60 │ │ maximum │ 2770 │ 1661 │ 1526 │ 135 │ 570 │ 22 │ 893 │ 60 │ │ stdev │ 179 │ 106 │ 101 │ 5 │ 47 │ 1 │ 0 │ 0 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ (gcthreads, threads) = (4, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 2215 │ 1233 │ 1155 │ 77 │ 485 │ 20 │ 892 │ 53 │ │ median │ 2320 │ 1248 │ 1171 │ 78 │ 492 │ 21 │ 893 │ 54 │ │ maximum │ 2372 │ 1259 │ 1176 │ 83 │ 493 │ 22 │ 893 │ 56 │ │ stdev │ 80 │ 13 │ 11 │ 3 │ 5 │ 1 │ 1 │ 1 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ (gcthreads, threads) = (8, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 2204 │ 1220 │ 1156 │ 64 │ 544 │ 23 │ 901 │ 53 │ │ median │ 2362 │ 1249 │ 1181 │ 64 │ 553 │ 23 │ 901 │ 53 │ │ maximum │ 2374 │ 1261 │ 1196 │ 68 │ 558 │ 25 │ 901 │ 55 │ │ stdev │ 95 │ 21 │ 20 │ 2 │ 7 │ 1 │ 0 │ 1 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ (gcthreads, threads) = (16, 1) [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback [ Info: Setting GC memory pressure callback ┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐ │ │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │ │ │ ms │ ms │ ms │ ms │ ms │ us │ MB │ % │ ├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤ │ minimum │ 2502 │ 1519 │ 1458 │ 62 │ 721 │ 22 │ 902 │ 58 │ │ median │ 2511 │ 1524 │ 1461 │ 63 │ 728 │ 23 │ 903 │ 61 │ │ maximum │ 2664 │ 1554 │ 1486 │ 68 │ 741 │ 25 │ 905 │ 61 │ │ stdev │ 91 │ 19 │ 16 │ 3 │ 10 │ 1 │ 2 │ 1 │ └─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘ ``` 04 March 2024, 16:16:28 UTC
4d5a20d Dilum Aluthge 04 March 2024, 11:36:24 UTC Docs: Change "Packages that wrap external libraries or programs should be named after those libraries or programs" to "Packages that wrap external libraries or programs can be named after those libraries or programs" (#53567) Before this PR: > Packages that wrap external libraries or programs should be named after those libraries or programs. I think that "should" is a little too strong. After this PR: > Packages that wrap external libraries or programs can be named after those libraries or programs. ## Motivation This might make it a bit easier to convince package authors that they can use a longer more descriptive name for their package, instead of needing to exactly match the name of the underlying software that they are wrapping. Suppose for example that someone is making a Julia package to wrap a piece of software named `HW`. Under the "should be named..." guideline, this would lead the package author to register a Julia package named HW.jl. Personally I'd like to encourage longer and more descriptive names. So, under the "can be named..." guideline, the author won't feel like the Julia package needs to be named HW.jl, and thus they might be more amenable to a longer name such as HelloWorld.jl. 04 March 2024, 11:36:24 UTC
bc2212c Alexander Plavin 04 March 2024, 01:20:49 UTC allow convert from RegexMatch to Dict/NamedTuple (#50988) Added implementation + tests, will add to docs if ok --------- Co-authored-by: Dilum Aluthge <dilum@aluthge.com> Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> 04 March 2024, 01:20:49 UTC
7179050 erich-9 03 March 2024, 03:14:28 UTC Always return a value in 1-d circshift! of abstractarray.jl (#53554) Co-authored-by: Sukera <11753998+Seelengrab@users.noreply.github.com> Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com> 03 March 2024, 03:14:28 UTC
0f902bf Eric Hanson 03 March 2024, 03:14:06 UTC Provide better error hint when `UndefVarError` results from name clashes (#53469) We can detect this since we set the `usingfailed` bit when the clash occurs (to avoid printing the `WARNING` multiple times). In this case, typos or missing imports (the current message) isn't quite as clear as it could be, because in fact the name is probably spelled totally right, it's just that there is a missing explicit import or the name should be qualified. This code will stop working if we change the flags in `Core.Binding`, but the test I added should catch that. However if REPL is supposed to be independent of Base and not depend on internals there, there could be an issue. In that case we should probably add an API to Base to inspect this `usingfailed` bit so we can use it in the REPL. --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: Alex Arslan <ararslan@comcast.net> 03 March 2024, 03:14:06 UTC
e7734ea Abel Soares Siqueira 03 March 2024, 01:23:18 UTC Add a GitHub Actions workflow for automatic validation of the citation metadata file (`CITATION.CFF`) (#44062) Hello! We noticed that your `CITATION.cff` had a small issue and fixed it. In addition to the fix, this Pull Request automates validation of that file using the [cffconvert GitHub Action](https://github.com/marketplace/actions/cffconvert). That way, it's a little bit easier to be robust against future changes to the `CITATION.cff` file. BTW it's perfectly fine if you don't feel like accepting this Pull Request for whatever reason -- we just thought it might be helpful is all. We found your repository using a partially automated workflow; if you have any questions about that, feel free to create an issue over at https://github.com/cffbots/filtering/issues/ On behalf of the cffbots team, @abelsiqueira / @fdiblen / @jspaaks --------- Co-authored-by: Max Horn <max@quendi.de> 03 March 2024, 01:23:18 UTC
a586d3c Mason Protter 03 March 2024, 01:16:51 UTC Clarify docstring for `zero`, `one`, and `oneunit`. (#52107) spurred by a conversation on Slack where someone was thrown off wondering why `zero(Vector{Int})` errors, but `zero(Int)` is fine. --------- Co-authored-by: Sukera <11753998+Seelengrab@users.noreply.github.com> Co-authored-by: Max Horn <max@quendi.de> Co-authored-by: Simon Byrne <simonbyrne@gmail.com> 03 March 2024, 01:16:51 UTC
86f5b21 Jakob Nybo Nissen 03 March 2024, 01:16:23 UTC Make dump print `const` before const fields (#53492) This provides more information to the user when dumping types, and also makes the output of dump slightly more similar to the type definition syntax. EDIT: This has been changed to print: * The kind of type before the type name `abstract type`, `mutable struct`, etc. * `const` only for `const` fields of `mutable struct` New behaviour ``` julia> dump(Float32) primitive type Float32 <: AbstractFloat julia> dump(Signed) abstract type Signed <: Integer julia> dump(Pair{Int, String}) struct Pair{Int64, String} <: Any first::Int64 second::String julia> dump(BitSet) mutable struct BitSet <: AbstractSet{Int64} const bits::Vector{UInt64} offset::Int64 julia> dump(Set) UnionAll var: TypeVar name: Symbol T lb: Union{} ub: abstract type Any body: struct Set{T} <: AbstractSet{T} dict::Dict{T, Nothing} ``` --------- Co-authored-by: Shuhei Kadowaki <aviatesk@gmail.com> 03 March 2024, 01:16:23 UTC
e3b2462 Mateus Araújo 02 March 2024, 19:02:45 UTC fix number of chunks (#53413) The manual claims that `a` is split into `nthreads()` chunks, but this is not true in general. As it was you could get an error, if `length(a) < nthreads()`, or a number of chunks larger than `nthreads()`, if `nthreads()` is smaller than `length(a)` but does not divide it. With `cld`, on the other hand, you always get at most `nthreads()` chunks. 02 March 2024, 19:02:45 UTC
8bf6a07 Ian Butterworth 02 March 2024, 16:49:08 UTC revert "Add @create_log_macro for making custom styled logging macros (#52196)" (#53551) 02 March 2024, 16:49:08 UTC
2b95956 Ian Butterworth 01 March 2024, 23:04:35 UTC use `_readdirx` for `walkdir` (#53545) On a M2 Mac there is some benefit, but assumed to be much greater on slower filesystems. ``` # master julia> @btime collect(walkdir(expanduser("~/Downloads"))); 380.086 ms (310696 allocations: 25.29 MiB) # This PR julia> @btime collect(walkdir(expanduser("~/Downloads"))); 289.747 ms (103300 allocations: 7.50 MiB) ``` The implementations appear to produce the same result ``` julia> collect(walkdir(expanduser("~/Downloads"))) == collect(walkdirx(expanduser("~/Downloads"))) true ``` 01 March 2024, 23:04:35 UTC
188e386 Ian Butterworth 01 March 2024, 23:03:41 UTC use more efficient `_readdirx` for tab completion (#53540) Fixes https://github.com/JuliaLang/julia/issues/53153 01 March 2024, 23:03:41 UTC
c703a17 Lilith Orion Hafner 01 March 2024, 17:58:09 UTC Update package naming guidelines to encourage consideration of the global namespace (#53514) Co-authored-by: Daniel Wennberg <daniel.wennberg@gmail.com> Co-authored-by: Matt Bauman <mbauman@juliahub.com> 01 March 2024, 17:58:09 UTC
ac41e2a Daniel Wennberg 01 March 2024, 15:24:30 UTC Fix `hypot` promotion bug (#53541) Fixes #53505 01 March 2024, 15:24:30 UTC
0918cf1 Keno Fischer 01 March 2024, 06:34:00 UTC Allow sysimage build without the doc system (#53533) The earliest bootstrapping code has a definition of `atdoc` that is just supposed to ignore the doc string and pass the defining code through. This function is then replaced by the actual docsystem once that is available. For testing, I wanted to build the whole system image without the doc system using this boostrap definition. However, this turns out not to be possible, because there's a few doc syntax semantics that do not actually just ignore the doc string. In particular: ``` """ I am a doc for a particular signature """ foo(x::Int, y::Float64) ``` Does not acutally result in a call to `foo`. And similarly ``` """ I am a doc for a global binding """ MyModule.foo ``` Does not require `MyModule.foo` to actually have a value, since it only documents the binding. This PR allows both of those cases in the boostrap version of `atdoc` so that we can bootstrap without the doc system if we wanted to. 01 March 2024, 06:34:00 UTC
136f018 Keno Fischer 01 March 2024, 06:32:36 UTC Allow GlobalRef and module qualified names in macro definitions (#53535) The following is currently an error: ``` julia> module MyMacroModule macro mymacro end end Main.MyMacroModule julia> macro MyMacroModule.mymacro() 1 end ERROR: syntax: invalid macro definition around REPL[2]:1 Stacktrace: [1] top-level scope @ REPL[2]:1 ``` Discussing with Jeff, we didn't think there was any good reason not to allow this, just a missing case in lowering. It's probably not particularly useful (unlike the corresponding case for functions that is used all the time), but it came up in writing a test case for #53515. 01 March 2024, 06:32:36 UTC
95f54c4 Jameson Nash 01 March 2024, 02:38:38 UTC fix InteractiveUtils call in Base.runtests on failure (#53525) Noticed in CI that `Base.runtests(["fail"])` fails here instead of throwing the correct error later, since #53326. 01 March 2024, 02:38:38 UTC
2501e37 Shuhei Kadowaki 01 March 2024, 00:43:00 UTC post-opt analysis: fix conditional successor visitation logic (#53518) Previously `conditional_successors_may_throw` performed post-domination analysis not on the initially specified `bb` (which was given as the argument), but on those BBs being analyzed that were popped from the work-queue at the time. As a result, there were cases where not all conditional successors were visited. fixes #53508 01 March 2024, 00:43:00 UTC
989c4db Ian Butterworth 29 February 2024, 23:04:39 UTC add _readdirx for returning more object info gathered during dir scan (#53377) 29 February 2024, 23:04:39 UTC
fbcc99a Sukera 29 February 2024, 23:04:08 UTC Add documentation about failure cases of trig functions & return types (#50855) 29 February 2024, 23:04:08 UTC
c06662a KronosTheLate 29 February 2024, 18:01:47 UTC Implement and export `isfull` (#53159) This PR implements `isfull(c::Channel)`. It calls `n_avail(c) ≥ c.sz_max` in all cases. The original implementation was inspired by [this comment](https://discourse.julialang.org/t/function-to-check-if-channel-is-full/44795/3?u=thelatekronos), and therefore had a special case for unbuffered channels, which fell back to `isready`. I opted against this behaviour, because it fails to respect that an unbuffered channel is always full, in two important senses: 1) The number of elements available is greater than or equal the capacity 2) A call to `put!` will block With the current implementation, the behaviour is simply understood and summarized in all cases by the start of the docstring: > Determines whether a `Channel` is full, in the sense that calling `put!(c, some_value)` will block. Shoutout to @SamuraiAku for their work in https://github.com/JuliaLang/julia/pull/40720, which helped me a lot on thinking this through, and remembering to change all relevant files. In particular, the detail around how `c.cond_take.waitq` may result in immediate unblocking, which is a really important caveat on a function that may be used to check if `put!`ing will block. However, for buffered channels, `isfull` is extremely close to `putwillblock` from #40720 (just a little better, with >= instead of ==), and for unbuffered channels it does not make much sense to see if `put!`ing will block. This PR is created based on [this](https://github.com/JuliaLang/julia/issues/22863#issuecomment-1921498544) "call to action". Checklist: - [x] Entry in news - [x] Docstring with example - [x] Export function - [x] Mention in manual - [x] Entry in [docs-reference](https://docs.julialang.org/en/v1/base/parallel/) --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com> 29 February 2024, 18:01:47 UTC
962bbf7 Kristoffer Carlsson 29 February 2024, 18:01:22 UTC Introduce -m/--module flag to execute a `main` function in a package (#52103) This aims to bring similar functionality to Julia as the `-m` flag for Python which exists to directly run some function in a package and being able to pass arguments to that function. While in Python, `python -m package args` runs the file `<package>.__main__.py`, the equivalent Julia command (`julia -m Package args`) instead runs `<Package>.main(args)`. The package is assumed to be installed in the environment `julia` is run in. An example usage could be: Add the package: ```julia (@v1.11) pkg> add https://github.com/KristofferC/Rot13.jl Cloning git-repo `https://github.com/KristofferC/Rot13.jl` Updating git-repo `https://github.com/KristofferC/Rot13.jl` Resolving package versions... Updating `~/.julia/environments/v1.11/Project.toml` [43ef800a] + Rot13 v0.1.0 `https://github.com/KristofferC/Rot13.jl#master` Updating `~/.julia/environments/v1.11/Manifest.toml` [43ef800a] + Rot13 v0.1.0 `https://github.com/KristofferC/Rot13.jl#master` ``` And then it can be run (since it has a `main` function) via: ``` ❯ ./julia/julia -m Rot13 "encrypt this for me" "and this as well" rapelcg guvf sbe zr naq guvf nf jryy ``` I'm not sure if `-m/--module` is the best choice but perhaps the association to Python makes it worth it. 29 February 2024, 18:01:22 UTC
e50ca99 Jeff Bezanson 29 February 2024, 15:40:01 UTC fix potential double-free in flisp table implementation (#53519) In this case we would add two finalizers, leading to a double free. Introduced by 5fc4ba91931526a08fc1bf8d3937aac731ee2cc6. However, I believe we never hit this in the julia front end, since it requires making a large pre-initialized table (i.e. with many arguments to `table`) which is later freed. That tends not to happen since initialized tables tend to be global constants. 29 February 2024, 15:40:01 UTC
715c50d Jameson Nash 29 February 2024, 14:32:17 UTC codegen: make gcroots for argument-derived values (#53501) This function might previously refuse to make gc roots for any of the function's arguments (i.e. it potentially assumed everything was in an alloca), which was only valid if we could guarantee that no IPO passes run. This commit aims to make that safe, but deferring such decisions about their source until llvm-late-gc-lowering can make them valid. This should make inlining-safe gc annotations for code_llvm(raw=true, optimize=false, (Some{Int},)) do x; GC.@preserve x GC.safepoint(); end and also better annotations even without inlining for code_llvm(raw=true, optimize=false, (Some{Any},)) do x; GC.@preserve x GC.safepoint(); end 29 February 2024, 14:32:17 UTC
24aaf00 Kristoffer Carlsson 29 February 2024, 14:22:15 UTC add back an alias for `check_top_bit` (#53523) Used in some packages (e.g. rfourquet/BitIntegers.jl) Renamed in https://github.com/JuliaLang/julia/pull/53166 29 February 2024, 14:22:15 UTC
84ae351 DilumAluthgeBot 29 February 2024, 10:15:12 UTC 🤖 [master] Bump the Pkg stdlib from 1f16df404 to 48eea8dbd (#53517) Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: 1f16df404 New commit: 48eea8dbd Julia version: 1.12.0-DEV Pkg version: 1.11.0(Does not match) Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: https://github.com/JuliaLang/Pkg.jl/compare/1f16df404a2fbe8642ea3eecc9f4d7064c400a73...48eea8dbd7b651cdc932b909c1b718bb9c3f94f4 ``` $ git log --oneline 1f16df404..48eea8dbd 48eea8dbd setenv -> addenv (#3819) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com> 29 February 2024, 10:15:12 UTC
77c0672 Stefan Karpinski 28 February 2024, 23:06:12 UTC task splitting: change additive accumulation to multiplicative (#53408) Issue raised [here](https://discourse.julialang.org/t/linear-relationship-between-xoshiro-tasks/110454). Given this definition, look at output values: ```jl using .Threads macro fetch(ex) :(fetch(@spawn($(esc(ex))))) end function taskCorrelatedXoshiros(+ = +) r11, r10 = @fetch (@fetch(rand(UInt64)), rand(UInt64)) r01, r00 = (@fetch(rand(UInt64)), rand(UInt64)) r01 + r10 - (r00 + r11) end ``` Before: ```jl julia> sort!(unique(taskCorrelatedXoshiros() for _ = 1:1000)) 9-element Vector{UInt64}: 0x0000000000000000 0x0000000000000001 0x00000000007fffff 0x0000000000800000 0x0000000000800001 0xffffffffff7fffff 0xffffffffff800000 0xffffffffff800001 0xffffffffffffffff ``` After: ```jl julia> sort!(unique(taskCorrelatedXoshiros() for _ = 1:1000)) 1000-element Vector{UInt64}: 0x000420647a085960 0x0038c5b889b585c6 0x007b29fae8107ff7 0x00e73b9e883ac1c8 ⋮ 0xfe68be9c0dde1e88 0xfeca042354218c35 0xfeeb8203e470c96b 0xfff5dbb8771307b9 julia> sort!(unique(taskCorrelatedXoshiros(*) for _ = 1:1000)) 1000-element Vector{UInt64}: 0x00126f951c1e56dc 0x0025a82477ffac08 0x002dd82c9986457a 0x00a713c4d56a3dbc ⋮ 0xfe2e40a5b345095e 0xfe77b90881967436 0xfea2559be63f1701 0xff88b5b28cefac5f ``` 28 February 2024, 23:06:12 UTC
c80a964 Shuhei Kadowaki 28 February 2024, 22:34:54 UTC update staled `Core.Compiler.Effects` documentation (#53507) 28 February 2024, 22:34:54 UTC
71f68b4 Max Horn 28 February 2024, 05:46:20 UTC Avoid compiler warning about redefining jl_globalref_t (#53499) 28 February 2024, 05:46:20 UTC
c379db7 DilumAluthgeBot 27 February 2024, 22:33:57 UTC 🤖 [master] Bump the Pkg stdlib from 76070d295 to 1f16df404 (#53495) 27 February 2024, 22:33:57 UTC
b18a62d pyfagorass 27 February 2024, 19:54:46 UTC Fix formatting & typo in methods.md (#53486) * Fixed what I suspect is a typo: commonly -> common * Added code quotes to eltype: eltype -> `eltype` Sentence now reads: Instead, common code will dispatch first on the container type, then recurse down to a more specific method based on `eltype`. 27 February 2024, 19:54:46 UTC
2b79326 Dilum Aluthge 27 February 2024, 17:22:16 UTC Move the list of Base's `public` names from `base/exports.jl` to `base/public.jl` (#53487) 27 February 2024, 17:22:16 UTC
c19c68e Nicholas Bauer 27 February 2024, 16:17:15 UTC Add error hint for incorrect stacked indexing (#40934) A common entry level mistake is to try to index a matrix with two sets of brackets, e.g. `a = [1 2; 3 4]; a[1][2] = 5` This will lead to an error that `setindex!()` on the element type of `a` is missing. This PR adds an error hint for the case where a MethodError is raised when `setindex!` is called with a `Number` as the first argument. I considered going broader than numbers, but it seems more likely that this kind of mistake would happen when working with simple number arrays vs. something more advanced. Could also consider if it is possible to do the same for when `getindex()` is called on a `Number`, which emits a BoundsError. Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com> 27 February 2024, 16:17:15 UTC
b3b2736 Jeff Bezanson 27 February 2024, 13:57:49 UTC add IR encoding for EnterNode (#53482) fixes #53248 27 February 2024, 13:57:49 UTC
35cb8a5 Shuhei Kadowaki 27 February 2024, 06:12:46 UTC minor fixes on test/precompile.jl (#53476) These changes are driven-by fixes I found during investigating into a more complex issue related to precompilation with external abs int. 27 February 2024, 06:12:46 UTC
2e9b0bb Ian Butterworth 27 February 2024, 02:42:36 UTC `rm`: move open DLLs to temp dir to allow dir to be deleted (#53456) 27 February 2024, 02:42:36 UTC
98b3f72 Jishnu Bhattacharya 27 February 2024, 01:16:22 UTC Fix boundscheck in unsetindex for SubArrays (#53475) These had been copy-pasted incorrectly, and should throw an error if the indices are out of bounds. 27 February 2024, 01:16:22 UTC
a2be715 Jameson Nash 26 February 2024, 21:08:57 UTC gf: allow method shadowing with exact signatures without deletion (#53415) We already allowed method shadowing for an inexact signature and implicit method deletion by exact signatures, so it was fairly arbitrary to implement it as a deletion for a replacement by an exact signature rather than use the morespecific definition for this. This change should be useful to Mocking libraries, such as Pluto, which previously had a buggier version of this which tried to re-activate or re-define the old methods. There is a bit of code cleanup in here, either of unused features, or of aspects that were broken, or of world_valid computations that were not actually impacting the final result (e.g. when there is a more specific result matches, it does not need to limit the result valid world range because of a less specific result that does not get returned). 26 February 2024, 21:08:57 UTC
7f92880 Jameson Nash 26 February 2024, 21:06:35 UTC add dedicated IO thread (capability only) (#53422) It has been oft-requested that we have a dedicated IO thread. That actually turns out to already be the case of something that exists, except that we hard-code the identity of that thread as being thread 0. This PR replaces all of the places where we hard code that assumption with a variable so that they are more easily searched for in the code. It also adds an internal function (`jl_set_io_loop_tid`) that can be used to transfer ownership of the loop to any (valid) tid. In conjunction with the prior foreign-threads work and foreign-thread pool, this lets us spawn a dedicate IO-management thread with this bit of code: ```julia function make_io_thread() tid = UInt[0] threadwork = @cfunction function(arg::Ptr{Cvoid}) Base.errormonitor(current_task()) # this may not go particularly well if the IO loop is dead, but try anyways @ccall jl_set_io_loop_tid((Threads.threadid() - 1)::Int16)::Cvoid wait() # spin uv_run as long as needed nothing end Cvoid (Ptr{Cvoid},) err = @ccall uv_thread_create(tid::Ptr{UInt}, threadwork::Ptr{Cvoid}, C_NULL::Ptr{Cvoid})::Cint err == 0 || Base.uv_error("uv_thread_create", err) @ccall uv_thread_detach(tid::Ptr{UInt})::Cint err == 0 || Base.uv_error("uv_thread_detach", err) # n.b. this does not wait for the thread to start or to take ownership of the event loop nothing end ``` 26 February 2024, 21:06:35 UTC
189a255 DilumAluthgeBot 26 February 2024, 20:18:44 UTC 🤖 [master] Bump the Distributed stdlib from 41c0106 to 6a07d98 (#53477) Stdlib: Distributed URL: https://github.com/JuliaLang/Distributed.jl Stdlib branch: master Julia branch: master Old commit: 41c0106 New commit: 6a07d98 Julia version: 1.12.0-DEV Distributed version: 1.11.0(Does not match) Bump invoked by: @IanButterworth Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: https://github.com/JuliaLang/Distributed.jl/compare/41c01069533e22a6ce6b794746e4b3aa9f5a25cd...6a07d9853ab7686df7440a47d1b585c6c9f3be35 ``` $ git log --oneline 41c0106..6a07d98 6a07d98 Merge pull request #93 from JuliaLang/ib/guard_rmprocs 41cd14f suppress interrupt trace from SIGTERM test 2b23ae4 guard rmprocs in tests 8c03305 do not call worker_from_id with pid<1 (#92) 25ee836 Add warning about new workers not sharing prior global state (#14) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com> 26 February 2024, 20:18:44 UTC
a796a41 Ian Butterworth 26 February 2024, 19:52:42 UTC add suffix kwarg to `tempname` (#53474) `tempname` checks that the name its returning is not already a file, however if you want that filename to contain other information, like a file extension, that can mean the uniquing isn't complete. This adds `tempname(suffix = "_foo.txt")` to include a suffix in the name and uniquing check. --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com> 26 February 2024, 19:52:42 UTC
4634c74 Alexander Plavin 26 February 2024, 19:17:38 UTC add array `typeinfo` support for NamedTuples (#53465) Closes https://github.com/JuliaLang/julia/issues/53455 26 February 2024, 19:17:38 UTC
3db7323 Kristoffer Carlsson 26 February 2024, 14:07:32 UTC Simplify some tests with `@test ... {broken,skip}=...` (#53470) 26 February 2024, 14:07:32 UTC
3ebba8f Simon Byrne 26 February 2024, 14:06:32 UTC use ScopedValues for MPFR precision and rounding (#51362) Should fix thread safety issues. Actually fixes #27139 26 February 2024, 14:06:32 UTC
b18824a Mosè Giordano 26 February 2024, 08:18:52 UTC Wrap `contrib/check-whitespace.jl` in a function (#53468) 26 February 2024, 08:18:52 UTC
4b47cc4 Eric Hanson 26 February 2024, 07:36:47 UTC Remove stale explicit imports from many stdlibs (#53464) Found via my new https://github.com/ericphanson/ExplicitImports.jl ```julia using ExplicitImports ExplicitImports.inspect_session(; inner=print_stale_explicit_imports) ``` These are not being used in the modules they are being imported into (or in some cases they are being used, but only in a qualified way where the explicit import is unnecessary). It can happen that someone imports a name into a module in order to have it available in that namespace, to then access it from another module (e.g. `TOML.Internals` seems to work like this). I've tried to notice those situations and not remove the imports in cases where I suspect the import is playing such a role, but hopefully CI will figure out if I got it right in all cases. I only looked at stdlibs that happened to be loaded in my Julia session and whose code is in this repo, so there are probably more stale explicit imports out there. 26 February 2024, 07:36:47 UTC
34a5151 Mosè Giordano 26 February 2024, 01:49:17 UTC Use `@test ... skip=...` instead of `@test_skip` 26 February 2024, 01:57:48 UTC
849d551 Mosè Giordano 08 May 2022, 23:48:39 UTC Use `@test ... broken=...` instead of `@test_broken` 26 February 2024, 01:57:48 UTC
90d03b2 Mosè Giordano 26 February 2024, 00:37:13 UTC [LibGit2_jll] Update to v1.7.2 (#53467) Memo to self: * update version number in `stdlib/LibGit2_jll/Project.toml` * update test result in `stdlib/LibGit2_jll/test/runtests.jl` * update version number and commit sha in `deps/libgit2.version` * refresh checksums with `make -f contrib/refresh_checksums.mk -j libgit2` 26 February 2024, 00:37:13 UTC
669cbdc Mosè Giordano 25 February 2024, 22:55:35 UTC [MozillaCACerts_jll] Update to v2023-12-12 (#53466) Memo to self: * update the version in `stdlib/MozillaCACerts_jll/Project.toml` * update `MOZILLA_CACERT_VERSION` in `deps/libgit2.version` * generate new checksums with `make -f contrib/refresh_checksums.mk mozillacert` * manually delete old checksums in `deps/checksums/cacert-<OLD-VERSIONS>` 25 February 2024, 22:55:35 UTC
b8a0a39 Valentin Churavy 25 February 2024, 02:48:37 UTC Prevent tainting native code loading from propagating (#53457) When we use options like code coverage, we can't use the native code present in the cache file since it is not instrumented. PR #52123 introduced the capability of skipping the native code during loading, but created the issue that subsequent packages could have an explicit or implicit dependency on the native code. PR #53439 tainted the current process by setting `use_sysimage_native_code`, but this flag is propagated to subprocesses and lead to a regression in test time. Move this to a process local flag to avoid the regression. In the future we might be able to change the calling convention for cross-image calls to `invoke(ci::CodeInstance, args...)` instead of `ci.fptr(args...)` to handle native code not being present. --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com> 25 February 2024, 02:48:37 UTC
714c6d0 Jeff Bezanson 25 February 2024, 01:26:49 UTC clarify keyword arg method error message (#53460) This is a nice explanatory message, so I think we should make the wording less obscure. 25 February 2024, 01:26:49 UTC
138aba7 Matt Bauman 23 February 2024, 22:04:29 UTC improve `--heap-size-hint` arg handling (#48050) Previously, `--heap-size-hint` would silently ignore many flavors of "bad" input, parsing things like "3PB" as 3 bytes. This change makes it significantly less permissive, erroring unless it can parse a number (still relying on the C `sscanf` `%Lf` format specifier there) with an optional unit (case-insensitive, either with or without the trailing `b`). Also test it. 23 February 2024, 22:04:29 UTC
9839aa3 Jameson Nash 23 February 2024, 21:38:06 UTC free more thread state in jl_delete_thread and GC (#52198) This prevents most memory growth in workloads that start many foreign threads. In the future, we could do even better by moving pages in the heap of an exited thread (and also maybe pooled stacks) elsewhere so they can be reused, and then also free the TLS object itself. 23 February 2024, 21:38:06 UTC
936c8a6 Kristoffer Carlsson 23 February 2024, 20:04:41 UTC make debug messages for relocatable srcfiles into a separate group (#53446) These create a lot of noisy output that is typically not interesting. As an example of the output : ``` ┌ Debug: include() files from /Users/kristoffercarlsson/.julia/compiled/v1.12/Pkg/tUTdb_NNLzf.ji are not relocatable │ srcfiles = │ Set{String} with 27 elements: │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/BinaryPlatforms_compat.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/MiniProgressBars.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/registry_instance.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/Registry.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/maxsum.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Types.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/REPLMode/command_declarations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/versionweights.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Artifacts.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Operations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/API.jl" │ ⋮ └ @ Base loading.jl:3051 ┌ Debug: include() files from /Users/kristoffercarlsson/.julia/compiled/v1.12/Pkg/tUTdb_Qo7WJ.ji are not relocatable │ srcfiles = │ Set{String} with 27 elements: │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/BinaryPlatforms_compat.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/MiniProgressBars.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/registry_instance.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/Registry.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/maxsum.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Types.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/REPLMode/command_declarations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/versionweights.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Artifacts.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Operations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/API.jl" │ ⋮ └ @ Base loading.jl:3051 ┌ Debug: include() files from /Users/kristoffercarlsson/.julia/compiled/v1.12/Pkg/tUTdb_bHWms.ji are not relocatable │ srcfiles = │ Set{String} with 27 elements: │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/BinaryPlatforms_compat.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/MiniProgressBars.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/registry_instance.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/Registry.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/maxsum.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Types.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/REPLMode/command_declarations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/versionweights.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Artifacts.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Operations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/API.jl" │ ⋮ └ @ Base loading.jl:3051 ┌ Debug: include() files from /Users/kristoffercarlsson/.julia/compiled/v1.12/Pkg/tUTdb_ePY5e.ji are not relocatable │ srcfiles = │ Set{String} with 27 elements: │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/BinaryPlatforms_compat.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/MiniProgressBars.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/registry_instance.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/Registry.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/maxsum.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Types.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/REPLMode/command_declarations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/versionweights.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Artifacts.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Operations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/API.jl" │ ⋮ └ @ Base loading.jl:3051 ┌ Debug: include() files from /Users/kristoffercarlsson/.julia/compiled/v1.12/Pkg/tUTdb_s9CWW.ji are not relocatable │ srcfiles = │ Set{String} with 27 elements: │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/BinaryPlatforms_compat.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/MiniProgressBars.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/registry_instance.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Registry/Registry.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/maxsum.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Types.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/REPLMode/command_declarations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Resolve/versionweights.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Artifacts.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/Operations.jl" │ "/Users/kristoffercarlsson/JuliaPkgs/Pkg.jl/src/API.jl" │ ⋮ ``` 23 February 2024, 20:04:41 UTC
ea1a0d2 Jameson Nash 23 February 2024, 19:59:20 UTC when loading code for internal purposes, load stdlib files directly(#53326) This bypasses DEPOT_PATH, LOAD_PATH, and stale checks when loading known stdlib code for known purposes from known locations, specifically to avoid the problem that I cannot fix my tools because I have used my tools to break my tools. This helps avoid the situation that the user can break important Pkg, REPL, Socket or similar features simply because they chose to remove `@stdlib` from their environment. For example, if you make an edit to REPL, then this will trigger recompilation and load the edited version: ``` $ ./julia -e 'using REPL' -iq ┌ Info: Precompiling REPL [3fa0cd96-eef1-5676-8a61-b3b8758bbffb] (cache misses: include_dependency fsize change (2), invalid header (10), mismatched flags (1)) └ @ Base loading.jl:2643 julia> ``` But this will load the version that shipped with Julia, regardless of the state of the cache or the source code (unless you delete the cache files): ``` $ ./julia -iq julia> ``` Fixes #53365 23 February 2024, 19:59:20 UTC
2ebb896 Gabriel Baraldi 23 February 2024, 19:40:57 UTC Audit sequential consistent atomic usage in the codebase (#53440) 23 February 2024, 19:40:57 UTC
6cbed31 Jameson Nash 23 February 2024, 16:16:17 UTC staticdata: fix assert from partially disabled native code (#53439) This should fix the assertion failure that has been plaguing the Pkg tests, as discussed in https://github.com/JuliaLang/julia/pull/52123#issuecomment-1959965395 23 February 2024, 16:16:17 UTC
923fe2d Max Horn 23 February 2024, 08:19:02 UTC Add update mechanism for Terminfo, and common user-alias data (#53285) Now that we take care of terminfo parsing ourselves, having a clear origin and processing method for arriving at our reference terminfo data seems somewhat important. The original form was acquired by re-purposing some pre-processed terminfo data from NCurses (I forget the exact source). I considered adding a separate ingestion/processing script, but it occurred to me that it would make sense to have the method for updating the data file be _in_ the data file, by turning it into a quine. This seems to work rather well, and so long as the NCurses source file format stays the same, updating the terminfo data is now dead simple. While working on the terminfo files, some minor refactors popped up as "probably nice to have". One of which makes the reported number of flags/numbers/strings actually accurate. Lastly, to support the ergonomic use of capability variable names instead of the short (read: uninformative) capname, we now also import the NCurses-recognised extended capabilities, and generate/specify some nice aliases for them. ----- If we separate out the terminfo parser/data into a small stdlib, the state here will be the initial state of the repo. 23 February 2024, 08:19:02 UTC
6e1d062 tecosaur 23 February 2024, 08:16:42 UTC Add annotate! method for AnnotatedIOBuffer (#53284) The annotate! function provides a convenient way of adding annotations to an AnnotatedString/AnnotatedChar without accessing any of the implementation details of the Annotated* types. When AnnotatedIOBuffer was introduced, an appropriate annotations method was added, but annotate! was missed. To correct that, we refactor the current annotate! method for AnnotatedString to a more general helper function _annotate! that operates on the annotation vector itself, and use this new helper method to easily provide an annotate! method for AnnotatedIOBuffer. 23 February 2024, 08:16:42 UTC
fee198b Max Horn 23 February 2024, 07:46:36 UTC Add debug variant of loader_trampolines.o (#53437) This prevents a race condition when building 'julia-cli-debug julia-cli-release' simultaneously (as we do for libjulia_jll, and also generally seems appropriate given what is done for all other source files. Motivated by https://github.com/JuliaPackaging/Yggdrasil/pull/8151 so I'll first see if it works there. Closes #45002. 23 February 2024, 07:46:36 UTC
bf965f3 Peter Simon 23 February 2024, 03:31:51 UTC Fix typos in docstrings for `in` and `∉` (#53443) 23 February 2024, 03:31:51 UTC
37c48e8 N5N3 22 February 2024, 23:06:06 UTC Subtype: skip slow-path in `local_∀_∃_subtype` if inputs contain no ∃ typevar. (#53429) This should be safe as ∀ vars' bounds are frozen in env. If there's no ∃ var, then the current env won't change after `local_∀_∃_subtype`. Thus, the slow path should be equivalent to the fast path if the latter returns 1. Close #53371. 22 February 2024, 23:06:06 UTC
a125bc2 Jeff Bezanson 21 November 2023, 22:55:51 UTC free even more state for exited threads 22 February 2024, 21:01:10 UTC
848ae2c Jeff Bezanson 16 November 2023, 22:24:01 UTC free more thread state in jl_delete_thread and GC 22 February 2024, 20:53:22 UTC
a96726b Gabriel Baraldi 22 February 2024, 17:24:54 UTC Fix synchronization issue on the GC scheduler (#53355) This aims to slightly simplify the synchronization by making `n_threads_marking` the sole memory location of relevance for it, it also removes the fast path, because being protected by the lock is quite important so that the observed gc state arrays are valid. Fixes: #53350 Fixes: #52757 Maybe fixes: #53026 Co-authored-by: Jameson Nash <vtjnash@gmail.com> 22 February 2024, 17:24:54 UTC
ccba6c9 Shuhei Kadowaki 22 February 2024, 11:41:07 UTC make `code_lowered` type stable (#53416) 22 February 2024, 11:41:07 UTC
a1db8da Ian Butterworth 22 February 2024, 09:30:07 UTC protect against PkgId and UUID being imported and losing Base prefix in create_expr_cache (#53387) Fixes https://github.com/JuliaLang/julia/issues/53381 22 February 2024, 09:30:07 UTC
8425b0e Carsten Bauer 21 February 2024, 20:33:54 UTC Fix documentation: thread pool of main thread (#53388) See https://github.com/JuliaLang/julia/issues/53217#issuecomment-1930891907 21 February 2024, 20:33:54 UTC
962d833 Jameson Nash 21 February 2024, 20:18:43 UTC undo breaking change of removing `parent` field from CodeInfo (#53393) This drops the unnecessary breaking change from https://github.com/JuliaLang/julia/pull/53219 by re-adding the optional `parent` field to CodeInfo. A few months ago, I had actually already put together a branch that also fixed Keno's complaints about how it was not set reliably, so I copied that code here also, so that it should get set more reliably whenever a CodeInfo is associated with a MethodInstance (either because it called `retrieve_code_info` to get IR from the Method or `uncompress_ir` to get it from the inference cache). This does not entirely fix Cthulhu's test errors, since I don't see any particular reason to re-introduce the other fields (min_world, max_world, inferred, edges, method_for_inference_limit_heuristics) that got removed or are now set incorrectly, and most errors appear to be instead related to the `Expr(:boundscheck, true/false)` change. However, they could be trivially re-added back as placeholders, if someone encounters a broken package that still needs them. 21 February 2024, 20:18:43 UTC
65f24da Neven Sajko 21 February 2024, 14:54:33 UTC doc: expand the `<:` doc string (#53001) Clear up some things, state some expected properties and limitations, add cross-references, add more examples. Co-authored-by: Jameson Nash <vtjnash@gmail.com> 21 February 2024, 14:54:33 UTC
back to top