Skip to main content

Browse the archive

https://github.com/angular/angular
07 August 2024, 03:31:07 UTC
sort by:
Revision Author Date Message Commit Date
7f77ce1 atscott 09 June 2020, 00:03:59 UTC release: cut the v10.0.0-rc.3 release 09 June 2020, 00:03:59 UTC
a1616ce Ajit Singh 22 April 2020, 03:51:11 UTC docs: add note on publishing libraries in ivy (#36556) Libraries are still build using view engine even after Ivy being the default engine for building angular apps. Added note on why libraries are built using VE and how they will be automatically compiled in Ivy using ngcc making it compatible for both Fixes #35625 PR Close #36556 08 June 2020, 22:05:52 UTC
1c22dff Gerald Lang 22 May 2020, 19:13:25 UTC docs(docs-infra): fix small typo (#37258) The style guide docs had a typo "Alerts and Calllouts". Callouts is spelled with two l's, not three. This PR fixes the typo. PR Close #37258 08 June 2020, 21:42:50 UTC
8d1d6e8 ajitsinghkaler 10 April 2020, 17:10:59 UTC docs: place download section in toh to the top (#36567) this is part of a larger effort to standardise download sections on angular.io This commit partially addresses #35459 PR Close #36567 08 June 2020, 18:41:52 UTC
e7f4aba Ajit Singh 06 June 2020, 03:14:12 UTC docs(service-worker): add staleWhileRevalidate strategy (#37301) There is great workaround for implementing staleWhileRevalidate strategy in service-worker by setting strategy to freshness and timeout to 0u. Documented this in service worker config where all other strategies are documented Fixes #20402 PR Close #37301 08 June 2020, 18:41:20 UTC
fdbe9f5 Andrew Scott 14 May 2020, 16:34:51 UTC refactor(core): assert TNode is not a container when setting attribute on element (#37111) This PR provides a more helpful error than the one currently present: `el.setAttribute is not a function`. It is not valid to have directives with host bindings on `ng-template` or `ng-container` nodes. VE would silently ignore this, while Ivy attempts to set the attribute and throws an error because these are comment nodes and do not have `setAttribute` functionality. It is better to throw a helpful error than to silently ignore this because putting a directive with host binding on an `ng-template` or `ng-container` is most often a mistake. Developers should be made aware that the host binding will have no effect in these cases. Note that an error is already thrown in Ivy, as mentioned above, so this is not a breaking change and can be merged to both master and patch. Resolves #35994 PR Close #37111 08 June 2020, 18:21:05 UTC
8bead6b Keen Yee Liau 06 June 2020, 05:42:35 UTC test(language-service): Remove all markers from test project (#37475) This commit removes all markers from the inline template in `AppComponent` and external template in `TemplateReference`. Test scenarios should be colocated with the test cases themselves. Besides, many existing cases are invalid. For example, if we want to test autocomplete for HTML element, the existing test case is like: ``` <~{cursor} h1> ``` This doesn't make much sense, becasue the language service already sees the `h1` tag in the template. The correct test case should be: ``` <~{cursor ``` IMO, this reflects the real-world use case better. This commit also uncovers a bug in the way HTML entities autocompletion is done. There's an off-by-one error in which a cursor that immediately trails the ampersand character fails to trigger HTML entities autocompletion. PR Close #37475 08 June 2020, 17:25:43 UTC
52dda73 Joey Perrott 06 April 2020, 18:03:40 UTC ci: remove IgorMinar from reviewers list for pullapprove fallback group (#36456) Historically we have had a pullapprove group `fallback` which acted as a catch all for files which did not match any other groups. This group assigned reviews to IgorMinar, however it was not apparent that this group was assigned. This change removes this assignment. This group as active should always coincide with failures of the pullapprove verification script. We continue to have this group as a secondary test ensuring all files in the repo are captured by the pullapprove config. PR Close #36456 08 June 2020, 17:07:45 UTC
31b3888 Pete Bacon Darwin 05 June 2020, 15:38:38 UTC style(ngcc): post-merge review tidy up (#37461) This commit tidies up a few of the code comments from a recent commit to help improve the clarity of the algorithm. PR Close #37461 08 June 2020, 16:32:11 UTC
6f93847 Adrien Vergé 05 June 2020, 09:30:07 UTC fix(service-worker): Don't stay locked in EXISTING_CLIENTS_ONLY if corrupted data (#37453) **Problem** After #31109 and #31865, it's still possible to get locked in state `EXISTING_CLIENTS_ONLY`, without any possibility to get out (even by pushing new updates on the server). More specifically, if control doc `/latest` of `ngsw:/:db:control` once gets a bad value, then the service worker will fail early, and won't be able to overwrite `/latest` with new, valid values (the ones from future updates). For example, once in this state, URL `/ngsw/state` will show: NGSW Debug Info: Driver state: EXISTING_CLIENTS_ONLY (Degraded due to failed initialization: Invariant violated (initialize): latest hash 8b75… has no known manifest Error: Invariant violated (initialize): latest hash 8b75… has no known manifest at Driver.<anonymous> (https://my.app/ngsw-worker.js:2302:27) at Generator.next (<anonymous>) at fulfilled (https://my.app/ngsw-worker.js:175:62)) Latest manifest hash: 8b75… Last update check: 22s971u ... with hash `8b75…` corresponding to no installed version. **Solution** Currently, when such a case happens, the service worker [simply fails with an assertion][1]. Because this failure happens early, and is not handled, the service worker is not able to update `/latest` to new installed app versions. I propose to detect this corrupted case (a `latest` hash that doesn't match any installed version) a few lines above, so that the service worker can correctly call its [already existing cleaning code][2]. [1]: https://github.com/angular/angular/blob/3569fdf/packages/service-worker/worker/src/driver.ts#L559-L563 [2]: https://github.com/angular/angular/blob/3569fdf/packages/service-worker/worker/src/driver.ts#L505-L519 This change successfully fixes the problem described above. Unit test written with the help of George Kalpakas. Thank you! PR Close #37453 08 June 2020, 16:31:35 UTC
776c4af Wagner Maciel 03 June 2020, 23:39:01 UTC fix(dev-infra): await setup in runBenchmark (#37428) * Fix for issue #36986. * Changes runBenchmark into an async function. * Awaits config.setup in runBenchmark. PR Close #37428 08 June 2020, 16:17:35 UTC
536dd64 Greg Magolan 03 June 2020, 22:43:32 UTC build: update to latest stable Chromium 83.0.4103 in both rules_webtesting and puppeteer (#37427) Also added in detailed instructions of the process to determine the URLs corresponding to Chromium version desired PR Close #37427 08 June 2020, 16:16:40 UTC
51d581a Joey Perrott 29 May 2020, 21:03:08 UTC build: upgrade to bazel 3.2.0 and rules_nodejs 1.7.0 (#37358) Upgrade to rely on bazel version 3.2.0 and rules_nodejs 1.7.0. This is part of a routine update as new versions become available. PR Close #37358 08 June 2020, 16:15:50 UTC
75294e7 Igor Minar 05 June 2020, 23:27:53 UTC ci: special case tooling-cli-shared-api review group (#37467) The new tooling-cli-shared-api is used to guard changes to packages/compiler-cli/src/tooling.ts which is a private API sharing channel between Angular FW and CLI. Changes to this file should be rare and explicitly approved by at least two members of the CLI team. PR Close #37467 06 June 2020, 02:23:53 UTC
04bada7 Igor Minar 05 June 2020, 22:10:13 UTC ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467 06 June 2020, 02:23:53 UTC
2349143 Paul Gschwendtner 04 June 2020, 16:55:52 UTC fix(dev-infra): properly determine oauth scopes for git client token (#37462) Resubmit of b2bd38699b0595d0a35b501f20251f8715a9fd1c since 85b6c94cc6d4dd1cfae68fc14575d0efa57574b3 accidentally reverted the fix due to rebasing most likely. PR Close #37462 05 June 2020, 18:04:37 UTC
e9bff5f George Kalpakas 05 June 2020, 17:14:18 UTC fix(elements): fire custom element output events during component initialization (#36161) Previously, event listeners for component output events attached on an Angular custom element before inserting it into the DOM (i.e. before instantiating the underlying component) didn't fire for events emitted during initialization lifecycle hooks, such as `ngAfterContentInit`, `ngAfterViewInit`, `ngOnChanges` (initial call) and `ngOnInit`. The reason was that that `NgElementImpl` [subscribed to events][1] _after_ calling [ngElementStrategy#connect()][2], which is where the [initial change detection][3] takes place (running the initialization lifecycle hooks). This commit fixes this by: 1. Ensuring `ComponentNgElementStrategy#events` is defined and available for subscribing to, even before instantiating the component. 2. Ensuring `NgElementImpl` subscribes to `NgElementStrategy#events` before calling `NgElementStrategy#connect()` (which initializes the component instance). Jira issue: [FW-2010](https://angular-team.atlassian.net/browse/FW-2010) [1]: https://github.com/angular/angular/blob/c0143cb2abdd172de1b95fd1d2c4cfc738640e28/packages/elements/src/create-custom-element.ts#L167-L170 [2]: https://github.com/angular/angular/blob/c0143cb2abdd172de1b95fd1d2c4cfc738640e28/packages/elements/src/create-custom-element.ts#L164 [3]: https://github.com/angular/angular/blob/c0143cb2abdd172de1b95fd1d2c4cfc738640e28/packages/elements/src/component-factory-strategy.ts#L158 Fixes #36141 PR Close #36161 05 June 2020, 17:36:39 UTC
411cb0c George Kalpakas 05 June 2020, 17:14:16 UTC refactor(elements): remove unnecessary non-null assertions and `as any` type-casts (#36161) This commit removes some unnecessary non-null assertions (`!`) and `as any` type-casts from the `elements` package. PR Close #36161 05 June 2020, 17:36:39 UTC
53e1fb3 Joey Perrott 27 May 2020, 22:39:31 UTC refactor(dev-infra): move GitClient to common util (#37318) Moves GitClient from merge script into common utils for unified method of performing git actions throughout the ng-dev toolset. PR Close #37318 05 June 2020, 16:46:40 UTC
2cb3b66 Pete Bacon Darwin 04 June 2020, 11:54:22 UTC fix(ngcc): find decorated constructor params on IIFE wrapped classes (#37436) Now in TS 3.9, classes in ES2015 can be wrapped in an IIFE. This commit ensures that we still find the static properties that contain decorator information, even if they are attached to the adjacent node of the class, rather than the implementation or declaration. Fixes #37330 PR Close #37436 05 June 2020, 16:22:04 UTC
5af3144 George Kalpakas 05 June 2020, 08:03:32 UTC refactor(dev-infra): use the `exec()` helper from `utils/shelljs` whenever possible (#37444) There is an `exec()` helper provided by `utils/shelljs.ts`, which is a wrapper around ShellJS' `exec()` with some default options (currently `silent: true`). The intention is to avoid having to pass these options to every invocation of the `exec()` function. This commit updates all code inside `dev-infra/` to use this helper whenever possible). NOTE: For simplicity, the `utils/shelljs` helper does not support some of the less common call signatures of the original `exec()` helper, so in some cases we still need to use the original. PR Close #37444 05 June 2020, 16:21:18 UTC
e4043cb Amadou Sall 05 June 2020, 09:49:20 UTC docs: fix minor error in the "Structural directives" guide (#37452) The sample code used in this guide uses [class.od]="odd". But, in another portion of the guide, [ngClass]="odd" is mentioned instead. PR Close #37452 05 June 2020, 16:20:43 UTC
fff424a Lars Gyrup Brink Nielsen 02 June 2020, 21:05:39 UTC fix(common): prevent duplicate URL change notifications (#37404) Prevent duplicate notifications from being emitted when multiple URL change listeners are registered using Location#onUrlChange. PR Close #37404 04 June 2020, 23:45:06 UTC
b5d1c8b Igor Minar 04 June 2020, 21:38:53 UTC docs: fix various typos (#37443) This change just fixes various typos and misspellings across several docs. I've included also a fix for an issue surfaced via #37423. Closes #37423 PR Close #37443 04 June 2020, 23:03:55 UTC
d713e33 Joey Perrott 20 May 2020, 23:04:46 UTC style(dev-infra): correct tslint failures in dev-infra directory (#37233) Fixes tslint failures in dev-infra directory as the directory is now part of the tslint enforced files. PR Close #37233 04 June 2020, 19:44:46 UTC
3d327d2 Joey Perrott 20 May 2020, 23:03:55 UTC build: add dev-infra to tslint selected files (#37233) Adds the dev-infra files to the scope of files on which tslint is enforced. This will allow for better code management/conformance. PR Close #37233 04 June 2020, 19:44:46 UTC
077283b Joey Perrott 28 May 2020, 21:57:47 UTC fix(dev-infra): clean up usages within pullapprove tooling (#37338) Clean up pullapprove tooling to use newly created common utils. Additionally, use newly created logging levels rather than verbose flagging. PR Close #37338 04 June 2020, 19:43:45 UTC
9ec25ea Andrew Scott 03 June 2020, 21:46:51 UTC refactor(dev-infra): change required base commit sha (#37424) Update the commit sha to require that PRs have been rebased beyond the one which has new header requirements so we don't get failures after merging PR Close #37424 04 June 2020, 17:44:14 UTC
878cfe6 Paul Gschwendtner 04 June 2020, 16:55:52 UTC fix(dev-infra): properly determine oauth scopes for git client token (#37439) We recently added a better reporting mechanism for oauth tokens in the dev-infra git util. Unfortunately the logic broke as part of addressing PR review feedback. Right now, always the empty promise from `oauthScopes` will be used as `getAuthScopes` considers it as the already-requested API value. This is not the case as the default promise is also truthy. We should just fix this by making the property nullable. PR Close #37439 04 June 2020, 17:42:53 UTC
5f0be3c Joey Perrott 03 June 2020, 19:12:52 UTC feat(dev-infra): Add oauth scope check to ensure necessary permissions for merge tooling (#37421) Adds an assertion that the provided TOKEN has OAuth scope permissions for `repo` as this is required for all merge attempts. On failure, provides detailed error message with remediation steps for the user. PR Close #37421 04 June 2020, 16:35:59 UTC
9e28e14 Paul Gschwendtner 20 May 2020, 09:59:42 UTC fix(dev-infra): ensure ts-node is registered with commonjs as module (#37422) We recently added support for automatic registration of `ts-node` when the dev-infra configuration is loaded. In addition to registering ts-node, we should also ensure that the `commonjs` module is set up. By default, `ts-node` would use ES module imports that are not supported by default in NodeJS. PR Close #37422 04 June 2020, 16:34:33 UTC
954d002 Joey Perrott 20 May 2020, 21:55:58 UTC feat(dev-infra): migrate release tool to use new logging system (#37422) Migrate the release tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
0a48591 Joey Perrott 20 May 2020, 21:52:19 UTC feat(dev-infra): migrate ts-circular-dependencies tool to use new logging system (#37422) Migrate the ts-circular-dependencies tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
d37c723 Joey Perrott 20 May 2020, 21:48:50 UTC feat(dev-infra): migrate merge tool to use new logging system (#37422) Migrate the merge tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
9078ca5 Joey Perrott 20 May 2020, 21:43:48 UTC feat(dev-infra): migrate ng-dev utils to use new logging system (#37422) Migrate the ng-dev utils to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
2be1ef6 Joey Perrott 20 May 2020, 21:41:44 UTC feat(dev-infra): migrate pullapprove tool to use new logging system (#37422) Migrate the pullapprove tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
47c02ef Joey Perrott 20 May 2020, 21:32:04 UTC feat(dev-infra): migrate rebase tool to use new logging system (#37422) Migrate the rebase tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
d7ecfb4 Joey Perrott 20 May 2020, 21:28:27 UTC feat(dev-infra): migrate discover-new-conflicts tool to use new logging system (#37422) Migrate the discover-new-conflicts tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
59abf4a Joey Perrott 20 May 2020, 21:22:29 UTC feat(dev-infra): migrate commit-message tool to use new logging system (#37422) Migrate the commit-message tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
d6e715e Joey Perrott 20 May 2020, 21:19:17 UTC feat(dev-infra): migrate format tool to use new logging system (#37422) Migrate the formatting tool in ng-dev to use new logging system rather than directly calling console.* to create a better experience for users. PR Close #37422 04 June 2020, 16:34:32 UTC
fcfcd10 Joey Perrott 20 May 2020, 21:19:10 UTC feat(dev-infra): add group functions to logging system and remove color param (#37422) Adds .group and .groupEnd functions to each of the logging functions to allow creating groups in the logged output. Additionally removes the color parameter from logging functions, in favor of the color being applied to the string at the call site. PR Close #37422 04 June 2020, 16:34:31 UTC
f3ccd29 Pete Bacon Darwin 04 June 2020, 07:43:05 UTC feat(ngcc): implement a program-based entry-point finder (#37075) This finder is designed to only process entry-points that are reachable by the program defined by a tsconfig.json file. It is triggered by calling `mainNgcc()` with the `findEntryPointsFromTsConfigProgram` option set to true. It is ignored if a `targetEntryPointPath` has been provided as well. It is triggered from the command line by adding the `--use-program-dependencies` option, which is also ignored if the `--target` option has been provided. Using this option can speed up processing in cases where there is a large number of dependencies installed but only a small proportion of the entry-points are actually imported into the application. PR Close #37075 04 June 2020, 16:22:40 UTC
5c0bdae Pete Bacon Darwin 04 June 2020, 07:43:04 UTC fix(ngcc): capture dynamic import expressions as well as declarations (#37075) Previously we only checked for static import declaration statements. This commit also finds import paths from dynamic import expressions. Also this commit should speed up processing: Previously we were parsing the source code contents into a `ts.SourceFile` and then walking the parsed AST to find import paths. Generating an AST is unnecessary work and it is faster and creates less memory pressure to just scan the source code contents with the TypeScript scanner, identifying import paths from the tokens. PR Close #37075 04 June 2020, 16:22:40 UTC
8389025 Pete Bacon Darwin 04 June 2020, 07:43:04 UTC refactor(ngcc): move shared code into `DependencyHostBase` (#37075) The various dependency hosts had a lot of duplicated code. This commit refactors them to move this into the base class. PR Close #37075 04 June 2020, 16:22:40 UTC
c6872c0 Pete Bacon Darwin 04 June 2020, 07:43:04 UTC fix(ngcc): ensure that more dependencies are found by `EsmDependencyHost` (#37075) Previously this host was skipping files if they had imports that spanned multiple lines, or if the import was a dynamic import expression. PR Close #37075 04 June 2020, 16:22:40 UTC
819982e Alan Agius 02 June 2020, 12:19:24 UTC docs: add blank line before header (#37391) Currently, `Formatting your source code` is not being formatted as a header because of a missing empty line. PR Close #37391 04 June 2020, 16:20:26 UTC
f9daa13 Pete Bacon Darwin 03 June 2020, 16:18:46 UTC perf(ngcc): cache parsed tsconfig between runs (#37417) This commit will store a cached copy of the parsed tsconfig that can be reused if the tsconfig path is the same. This will improve the ngcc "noop" case, where there is no processing to do, when the entry-points have already been processed. Previously we were parsing this config every time we checked for entry-points to process, which can take up to seconds in some cases. Resolves #36882 PR Close #37417 04 June 2020, 16:19:38 UTC
6a0d2ed George Kalpakas 03 June 2020, 22:29:33 UTC ci(docs-infra): skip deploying RC version when lexicographically smaller than stable (#37426) The angular.io production deployment script (`deploy-to-firebase.sh`) compares the major version corresponding to the current branch (e.g. `8` for branch `8.1.x`) against the major stable version (e.g. `9` if the current stable version is `9.1.0`). It then uses the result of that comparison to determine whether the current branch corresponds to a newer version than stable (i.e. an RC version) and thus should not be deployed or to an older version and thus may need to be deployed to an archive vX.angular.io project. Previously, the script was using string comparison (`<`) to compare the two major versions. This could produce incorrect results for an RC major version that is numerically greater than the stable but lexicographically smaller. For example, 10 vs 9 (10 is numerically greater but lexicographically smaller than 9). Example of a CI job that incorrectly tried to deploy an RC branch to production: https://circleci.com/gh/angular/angular/726414 This commit fixes it by switching to an integer comparison (i.e. using the `-lt` operator). PR Close #37426 04 June 2020, 16:17:29 UTC
2c1f35e Ayaz Hafiz 14 May 2020, 15:35:38 UTC fix(language-service): Recover from error in analyzing Ng Modules (#37108) In place of failing to return analyzed Ng Modules when the analyzer fails, return the previously-analyzed Ng Modules (which may be empty) and log an error. Closes https://github.com/angular/vscode-ng-language-service/issues/777 PR Close #37108 03 June 2020, 22:56:19 UTC
5345e8d Sonu Kapoor 19 May 2020, 09:32:04 UTC docs: update the stackblitz in the GitHub Issue template (#37219) This commit updates the bug report stackblitz template for opening a new issue based on the current angular release. Closes #37063 PR Close #37219 03 June 2020, 22:55:44 UTC
e35269d Andrew Scott 03 June 2020, 21:50:32 UTC docs: update file header to be correct (#37425) The file header should be Google LLC rather than Google Inc. because it is now an LLC after Alphabet Holdings was formed. PR Close #37425 03 June 2020, 22:31:29 UTC
60a03b7 Alex Rickabaugh 14 May 2020, 18:24:59 UTC refactor(compiler-cli): extract NgCompilerAdapter interface (#37118) `NgCompiler` is the heart of ngtsc and can be used to analyze and compile Angular programs in a variety of environments. Most of these integrations rely on `NgProgram` and the creation of an `NgCompilerHost` in order to create a `ts.Program` with the right shape for `NgCompiler`. However, certain environments (such as the Angular Language Service) have their own mechanisms for creating `ts.Program`s that don't make use of a `ts.CompilerHost`. In such environments, an `NgCompilerHost` does not make sense. This commit breaks the dependency of `NgCompiler` on `NgCompilerHost` and extracts the specific interface of the host on which `NgCompiler` depends into a new interface, `NgCompilerAdapter`. This interface includes methods from `ts.CompilerHost`, the `ExtendedTsCompilerHost`, as well as APIs from `NgCompilerHost`. A consumer such as the language service can implement this API without needing to jump through hoops to create an `NgCompilerHost` implementation that somehow wraps its specific environment. PR Close #37118 03 June 2020, 20:29:45 UTC
305b5a3 Alex Rickabaugh 15 May 2020, 00:52:08 UTC fix(compiler-cli): use ModuleWithProviders type if static eval fails (#37126) When the compiler encounters a function call within an NgModule imports section, it attempts to resolve it to an NgModule-annotated class by looking at the function body and evaluating the statements there. This evaluation can only understand simple functions which have a single return statement as their body. If the function the user writes is more complex than that, the compiler won't be able to understand it and previously the PartialEvaluator would return a "DynamicValue" for that import. With this change, in the event the function body resolution fails the PartialEvaluator will now attempt to use its foreign function resolvers to determine the correct result from the function's type signtaure instead. If the function is annotated with a correct ModuleWithProviders type, the compiler will be able to understand the import without static analysis of the function body. PR Close #37126 03 June 2020, 20:23:16 UTC
bc54936 crisbeto 09 May 2020, 12:33:54 UTC fix(core): infinite loop if injectable using inheritance has a custom decorator (#37022) If we detect that an injectable class is inheriting from another injectable, we generate code that looks something like this: ``` const baseFactory = ɵɵgetInheritedFactory(Child); @Injectable() class Parent {} @Injectable() class Child extends Parent { static ɵfac = (t) => baseFactory(t || Child) } ``` This usually works fine, because the `ɵɵgetInheritedFactory` resolves to the factory of `Parent`, but the logic can break down if the `Child` class has a custom decorator. Custom decorators can return a new class that extends the original once, which means that the `ɵɵgetInheritedFactory` call will now resolve to the factory of the `Child`, causing an infinite loop. These changes fix the issue by changing the inherited factory resolution logic so that it walks up the prototype chain class-by-class, while skipping classes that have the same factory as the class that was passed in. Fixes #35733. PR Close #37022 03 June 2020, 20:16:26 UTC
084b627 Wagner Maciel 08 May 2020, 19:56:39 UTC refactor(dev-infra): small changes and fixes (#36800) Rename bazel workspace from npm_dev_infra to npm_angular_dev_infra_private to make it clear that this package is private to angular. Change driver-utilities module_name to match the new bazel workspace name. Correct a comment by rewording it from "deployed version" to "published version". Fix merge conflicts in tmpl-package.json Make "//packages/bazel/src:esm5.bzl" replacement more generalized so that importing from "//packages/bazel" works. Deleted "dev_infra/*" path from modules/benchmarks tsconfig. Moved //dev-infra/benchmark/browsers to //dev-infra/browsers. PR Close #36800 03 June 2020, 20:12:31 UTC
6755d00 Wagner Maciel 24 April 2020, 20:16:06 UTC revert: "revert: "build(core): use dev-infra's component_benchmark to show PoC (#36434)" (#36798)" (#36800) This reverts commit 90a2796a7e20eda6a6c8afd10c79b36d75640cdf. PR Close #36800 03 June 2020, 20:12:31 UTC
cba1da3 Wagner Maciel 15 May 2020, 17:26:01 UTC revert: "revert: "build(dev-infra): update package.json and :npm_package (#36434)" (#36798)" (#36800) This reverts commit f5ff2068a48f60c747c2936908e848d301f4dba4. PR Close #36800 03 June 2020, 20:12:31 UTC
7be8bb1 Wagner Maciel 24 April 2020, 20:14:28 UTC revert: "revert: "feat(dev-infra): exposed new rule 'component_benchmark' via dev_infra (#36434)" (#36798)" (#36800) This reverts commit ad8c4cdd752d310316e8fc019f21855701c3a950. PR Close #36800 03 June 2020, 20:12:31 UTC
c7c0c1f lazarljubenovic 07 September 2019, 18:13:19 UTC refactor(forms): use a type guard to get rid of casts (#32541) Use an explicit type guard when checking if a given object is of type AbstractControlOptions, instead of a simple function returning a boolean value. This allows us to remove manual type casting when using this function, relying instead on TypeScript to infer correct types. PR Close #32541 03 June 2020, 19:29:26 UTC
3aa4629 Judy Bogart 08 April 2020, 21:08:04 UTC docs: refactor template-driven forms doc as a tutorial (#36732) rework content to meet current documentation standards and conventions, structure as tutorial document type PR Close #36732 03 June 2020, 19:27:28 UTC
2d86dbb mgechev 02 June 2020, 23:22:56 UTC docs: update aio in support for #BlackLivesMatter (#37409) Update angular.io in support for #BlackLivesMatter. The PR updates the styles of the landing page and changes the current survey notification. PR Close #37409 03 June 2020, 18:20:57 UTC
91767ff Joey Perrott 02 June 2020, 17:38:37 UTC ci: temporarily disable Android 10 browser unit tests on Saucelabs (#37399) Disabling Android 10 browser unit tests on Saucelabs due to errors. After remediation from Saucelabs to correct the discovered failures, this change can be reverted to renable the tests on Android 10. Example of failures seen: ``` 02 06 2020 14:03:05.048:INFO [SaucelabsLauncher]: Chrome 10.0 (Android) session at https://saucelabs.com/tests/54f5fb181db644a3b4779187c2309000 02 06 2020 14:03:06.869:INFO [Chrome Mobile 74.0.3729 (Android 0.0.0)]: Disconnected browser returned on socket E-bi0p0NKtghk-HcAAAO with id 85563367. Chrome Mobile 74.0.3729 (Android 0.0.0) ERROR: Error: XHR error loading http://angular-ci.local:9876/base/node_modules/rxjs/internal/operators/zip.js Error loading http://angular-ci.local:9876/base/node_modules/rxjs/internal/operators/zip.js as "../internal/operators/zip" from http://angular-ci.local:9876/base/node_modules/rxjs/operators/index.js Error: XHR error loading http://angular-ci.local:9876/base/node_modules/rxjs/internal/operators/zip.js at error (http://angular-ci.local:9876/base/node_modules/systemjs/dist/system.src.js?1c6a6c12fec50a8db7aeebe8e06e2b70135c0615:1028:16) at XMLHttpRequest.xhr.onreadystatechange [as __zone_symbol__ON_PROPERTYreadystatechange] (http://angular-ci.local:9876/base/node_modules/systemjs/dist/system.src.js?1c6a6c12fec50a8db7aeebe8e06e2b70135c0615:1036:13) at XMLHttpRequest.wrapFn (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:809:43) at ZoneDelegate.invokeTask (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:432:35) at Zone.runTask (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:201:55) at ZoneTask.invokeTask [as invoke] (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:514:38) at invokeTask (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:1722:18) at XMLHttpRequest.globalZoneAwareCallback (http://angular-ci.local:9876/base/dist/bin/packages/zone.js/npm_package/dist/zone.js?942d01da94828e1c75e8527fa8d06f363d6379ce:1748:21) ``` PR Close #37399 02 June 2020, 21:32:34 UTC
078b004 Kara Erickson 01 June 2020, 20:55:45 UTC docs(core): remove v10 mention from @Injectable warning (#37383) In v9, we started showing a console warning when instantiating a token that inherited its @Injectable decorator rather than providing its own. This warning said that the pattern would become an error in v10. However, we have decided to wait until at least v11 to throw in this case, so this commit updates the warning to be less prescriptive about the exact version when the pattern will no longer be supported. PR Close #37383 02 June 2020, 21:30:58 UTC
930d204 Terence D. Honles 22 May 2020, 04:25:00 UTC perf(ngcc): allow immediately reporting a stale lock file (#37250) Currently, if an ngcc process is killed in a manner that it doesn't clean up its lock file (or is killed too quickly) the compiler reports that it is waiting on the PID of a process that doesn't exist, and that it will wait up to a maximum of N seconds. This PR updates the locking code to additionally check if the process exists, and if it does not it will immediately bail out, and print the location of the lock file so a user may clean it up. PR Close #37250 02 June 2020, 21:30:03 UTC
8d82cdf Judy Bogart 04 May 2020, 19:36:48 UTC docs: refactor forms overview (#36919) Reorganize and edit content of existing form overview to conform to current doc standards and styles PR Close #36919 02 June 2020, 21:29:15 UTC
cb6996b Matias Niemelä 02 June 2020, 19:06:52 UTC build: fix integration payload sizes 02 June 2020, 19:06:52 UTC
a4f7740 Markus Ende 27 May 2020, 13:44:47 UTC docs(router): fix a typo in example code (#37309) The code in the example docs used TestBed.configureTestModule instead of TestBed.configureTestingModule. PR Close #37309 01 June 2020, 21:19:46 UTC
ba0faa2 Andrew Scott 18 May 2020, 18:08:23 UTC refactor(core): remove `looseIdentical` in favor of built-in `Object.is` (#37191) Remove `looseIdentical` implementation and instead use the ES2015 `Object.is` in its place. They behave exactly the same way except for `+0`/`-0`. `looseIdentical(+0, -0)` => `true` `Object.is(+0, -0)` => `false` Other than the difference noted above, this is not be a breaking change because: 1. `looseIdentical` is a private API 2. ES2015 is listed as a mandatory polyfill in the [browser support guide](https://angular.io/guide/browser-support#mandatory-polyfills) 3. Also note that `Ivy` already uses `Object.is` in `bindingUpdated`. PR Close #37191 01 June 2020, 21:19:17 UTC
3e68029 Keen Yee Liau 29 May 2020, 16:46:12 UTC test(language-service): disable ivy ls tests on CI (#37348) This commit disables the tests for Ivy version of language service on CI because the compiler APIs are not yet stable, so language service should not assert against its behavipr. PR Close #37348 01 June 2020, 21:18:51 UTC
b4e26b5 Pete Bacon Darwin 30 May 2020, 19:49:44 UTC fix(ngcc): do not inline source-maps for non-inline typings source-maps (#37363) Inline source-maps in typings files can impact IDE performance so ngcc should only add such maps if the original typings file contains inline source-maps. Fixes #37324 PR Close #37363 01 June 2020, 21:18:31 UTC
15cf7fc AleksanderBodurri 01 June 2020, 03:08:32 UTC docs(core): fix typo in decorators.ts relating to the use of Object.defineProperty. (#37369) Previously there was a typo in a comment within the PropDecorator function relating to and justifying the use of Object.defineProperty. This PR clears up the wording that comment PR Close #37369 01 June 2020, 21:18:08 UTC
24ff0eb Andrew Scott 01 June 2020, 17:55:00 UTC docs: fix typo in deprecations (#37379) This PR fixes a typo in the deprecations guide, changing 'dropped support for of Windows 10...' to 'dropped support for Windows 10...' PR Close #37379 01 June 2020, 21:17:44 UTC
cf86f72 Matias Niemelä 01 June 2020, 17:51:58 UTC release: cut the v10.0.0-rc.2 release 01 June 2020, 17:51:58 UTC
61486f1 Joey Perrott 01 June 2020, 15:57:37 UTC build: remove wombot proxy registry from package.jsons for release (#37378) Due to an outage with the proxy we rely on for publishing, we need to temporarily directly publish to NPM using our own angular credentials again. PR Close #37378 01 June 2020, 16:41:19 UTC
d16a7f3 Igor Minar 27 May 2020, 21:09:01 UTC fix(core): reenable decorator downleveling for Angular npm packages (#37317) In #37221 we disabled tsickle passes from transforming the tsc output that is used to publish all Angular framework and components packages (@angular/*). This change however revealed a bug in the ngc that caused __decorate and __metadata calls to still be emitted in the JS code even though we don't depend on them. Additionally it was these calls that caused code in @angular/material packages to fail at runtime due to circular dependency in the emitted decorator code documeted as https://github.com/microsoft/TypeScript/issues/27519. This change partially rolls back #37221 by reenabling the decorator to static fields (static properties) downleveling. This is just a temporary workaround while we are also fixing root cause in `ngc` - tracked as FW-2199. Resolves FW-2198. Related to FW-2196 PR Close #37317 29 May 2020, 22:52:01 UTC
82761ec Keen Yee Liau 28 May 2020, 23:05:43 UTC docs: Mention Bazel builder and schematics in Deprecations section (#37190) This commit adds Bazel builder and schematics to the global list of deprecations in Angular. A link to the migration doc is added. PR Close #37190 29 May 2020, 01:35:41 UTC
235bfa7 Keen Yee Liau 28 May 2020, 22:50:31 UTC docs(bazel): Mention Architect prototype and Slack Channel (#37190) This commit adds a link to the Bazel prototype for orchestrating multiple CLI architects and also adds a link to the #angular channel in the Bazel Slack workspace. PR Close #37190 29 May 2020, 01:35:41 UTC
299ae1b Keen Yee Liau 21 May 2020, 00:50:02 UTC docs: Cleanup Bazel schematics deprecation doc (#37190) This commit improves some wording in the deprecation doc for Bazel builder and schematics in `@angular/bazel` and fixes the formatting. PR Close #37190 29 May 2020, 01:35:41 UTC
80f7522 Keen Yee Liau 21 May 2020, 00:03:38 UTC refactor(bazel): Remove schematics and builder from package.json (#37190) This commit removes the fields for ng-add, schematics and builder from package.json of `@angular/bazel`. PR Close #37190 29 May 2020, 01:35:41 UTC
028921e Keen Yee Liau 21 May 2020, 00:00:44 UTC docs: Add guide/bazel to Service Worker navigationUrls (#37190) This commit adds an exception for "guide/bazel" to the navigationUrls in the Service Worker config. This is needed for redirection to work. PR Close #37190 29 May 2020, 01:35:41 UTC
a4e11bb Keen Yee Liau 19 May 2020, 01:37:14 UTC docs: Redirect /guide/bazel to deprecation doc in Angular repo (#37190) This commit adds a 301 redirect for /guide/bazel on angular.io to the deprecation doc for Angular Bazel schematics in Angular repo. PR Close #37190 29 May 2020, 01:35:41 UTC
a413175 Keen Yee Liau 18 May 2020, 23:23:14 UTC test: remove Bazel schematics integration test (#37190) This commit removes the integration test for schematics in `@angular/bazel` that is used to generate a Bazel builder. The Bazel builder has been deprecated. PR Close #37190 29 May 2020, 01:35:40 UTC
060dcfb Keen Yee Liau 18 May 2020, 22:14:08 UTC ci: Remove aio/content/guide/bazel.md from pullapprove (#37190) This commit removes aio/content/guide/bazel.md from the Bazel list in pullapprove since Bazel builder has been deprecated and the doc has been deleted. PR Close #37190 29 May 2020, 01:35:40 UTC
4be7008 Keen Yee Liau 18 May 2020, 22:10:43 UTC docs: Remove 'Building with Bazel' section (#37190) This commit removes "Building with Bazel" section from angular.io navigation list and Angular CLI landing page. PR Close #37190 29 May 2020, 01:35:40 UTC
4a0d055 Keen Yee Liau 18 May 2020, 21:39:39 UTC refactor(bazel): Remove Schematics for Bazel Builder (#37190) This commit removes `ng-add` and `ng-new` schematics for the Bazel Builder, and update the corresponding BUILD files. PR Close #37190 29 May 2020, 01:35:40 UTC
83ab99c Keen Yee Liau 18 May 2020, 21:33:11 UTC docs: Remove Bazel builder from @angular/bazel (#37190) This commit adds a deprecation doc for Bazel builder in `@angular/bazel` and removes the corresponding guide in angular.io. PR Close #37190 29 May 2020, 01:35:40 UTC
270da1f George Kalpakas 27 May 2020, 13:56:04 UTC build(docs-infra): upgrade cli command docs sources to 14af4e07c (#37310) Updating [angular#10.0.x](https://github.com/angular/angular/tree/10.0.x) from [cli-builds#10.0.x](https://github.com/angular/cli-builds/tree/10.0.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/200a21f8a...14af4e07c): **Modified** - help/generate.json PR Close #37310 28 May 2020, 22:43:44 UTC
6b0e46e JiaLiPassion 18 May 2020, 04:59:55 UTC docs: fix typo in committer.md (#37171) Fix a type of COMMITTER.md, the url of the pullapprove service should be https://docs.pullapprove.com/, now the document has an additional `https` prefix. PR Close #37171 28 May 2020, 22:43:05 UTC
3642707 Joey Perrott 28 May 2020, 20:34:08 UTC build: use static patch value for targetting branches in merge config (#37299) Due to the desired patch branch (10.0.x) being on a semver version that is unreleased as stable (there is no 10.0.0 on latest, it is on next) our logic for determining target patch branches does not work. This change is a workaround to unblock merging in the repo while a longer term answer is discovered. PR Close #37299 28 May 2020, 22:18:20 UTC
0ea76ed Joey Perrott 28 May 2020, 20:32:08 UTC build: migrate ng-dev config to .ng-dev directory (#37299) Migrate to using .ng-dev directory for ng-dev configuration to allow better management of the configuration using multiple files. The intention is to prevent the config file from becoming unruly. PR Close #37299 28 May 2020, 22:18:20 UTC
d493a83 Adam 26 May 2020, 17:49:50 UTC docs(platform-server): fix renderModule usage guidance with Ivy (#37296) Before the introduction of the Ivy renderer, users would compile their applications and use the resulting factories for SSR, since these post-compilation artifacts ensured faster delivery. Thus, using the original module as the rendering entrypoint was considered suboptimal and was discouraged. However, with the introduction of Ivy, this guidance is no longer applicable since these factories are no longer generated. Comparable speed is achieved using the factory-less module renderer, and so we update the guiance in the docs for the method. PR Close #37296 28 May 2020, 20:07:32 UTC
f1721d5 Joey Perrott 27 May 2020, 19:54:11 UTC build: update requiredBaseCommit for patch branch merges (#37316) Updates the requiredBaseCommit for merging to patch branch to the latest commit message validation fix found in the 10.0.x branch. Previously, the patch branch commit used was for the 9.1.x branch. PR Close #37316 28 May 2020, 20:06:08 UTC
5b3fd6a Andrew Scott 27 May 2020, 17:07:06 UTC docs: add IE mobile to deprecated browsers (#37313) Mobile versions of IE should also be deprecated, as the same reasons for deprecating IE 9 and 10 apply. PR Close #37313 27 May 2020, 21:23:18 UTC
6f82918 Joey Perrott 19 May 2020, 19:08:49 UTC build: update license headers to reference Google LLC (#37205) Update the license headers throughout the repository to reference Google LLC rather than Google Inc, for the required license headers. PR Close #37205 26 May 2020, 18:27:01 UTC
27b95ba Joey Perrott 19 May 2020, 19:07:26 UTC build: Update file-header lint rule to Google LLC (#37205) Update the file-header lint rule to properly reference Google LLC rather than Google Inc, for the required headers. PR Close #37205 26 May 2020, 18:27:01 UTC
ef405b1 Joey Perrott 21 May 2020, 18:03:56 UTC build: deprecate old merge script (#37247) Deprecate the old merge script as it no longer correctly chooses the patch branch due to relying on numerical sorting order from git. Git actually provides a lexicographical sorting order. This that 9.0.x will be chosen rather than 10.0.x as it is sorted based the 9 vs 1, rather than 9 vs 10. PR Close #37247 26 May 2020, 18:25:44 UTC
441073b Paul Gschwendtner 20 May 2020, 10:50:18 UTC feat(dev-infra): expose script for determining merge branches (#37217) The components repo and framework repository follow the same patch branch concept. We should be able to share a script for determining these merge branches. Additonally the logic has been improved compared to the old merge script because we no longer consult `git ls-remote` unless really needed. Currently, `git ls-remote` is always consulted, even though not necessarily needed. This can slow down the merge script and the caretaker process when a couple of PRs are merged (personally saw around ~4 seconds per merge). Additionally, the new logic is more strict and will ensure (in most cases) that no wrong patch/minor branch is determined. Previously, the script just used the lexicographically greatest patch branch. This _could_ be wrong when a new patch branch has been created too early, or by accident. PR Close #37217 21 May 2020, 17:38:19 UTC
cfb37b8 Kara Erickson 21 May 2020, 17:00:31 UTC release: cut the v10.0.0-rc.0 release 21 May 2020, 17:00:31 UTC
a1001f2 Igor Minar 20 May 2020, 01:11:37 UTC fix(core): disable tsickle pass when producing APF packages (#37221) As of TypeScript 3.9, the tsc emit is not compatible with Closure Compiler due to https://github.com/microsoft/TypeScript/pull/32011. There is some hope that this will be fixed by a solution like the one proposed in https://github.com/microsoft/TypeScript/issues/38374 but currently it's unclear if / when that will happen. Since the Closure support has been somewhat already broken, and the tsickle pass has been a source of headaches for some time for Angular packages, we are removing it for now while we rethink our strategy to make Angular Closure compatible outside of Google. This change has no effect on our Closure compatibility within Google which work well because all the code is compiled from sources and passed through tsickle. This change only disables the tsickle pass but doesn't remove it. A follow up PR should either remove all the traces of tscikle or re-enable the fixed version. BREAKING CHANGE: Angular npm packages no longer contain jsdoc comments to support Closure Compiler's advanced optimizations The support for Closure compiler in Angular packages has been experimental and broken for quite some time. As of TS3.9 Closure is unusable with the JavaScript emit. Please follow https://github.com/microsoft/TypeScript/issues/38374 for more information and updates. If you used Closure compiler with Angular in the past, you will likely be better off consuming Angular packages built from sources directly rather than consuming the version we publish on npm which is primarily optimized for Webpack/Rollup + Terser build pipeline. As a temporary workaround you might consider using your current build pipeline with Closure flag `--compilation_level=SIMPLE`. This flag will ensure that your build pipeline produces buildable and runnable artifacts, at the cost of increased payload size due to advanced optimizations being disabled. If you were affected by this change, please help us understand your needs by leaving a comment on https://github.com/angular/angular/issues/37234. PR Close #37221 21 May 2020, 16:14:47 UTC
6ca3fb1 Kara Erickson 20 May 2020, 22:46:19 UTC docs: release notes for the v${releaseVersion} release This commit contains the release notes for the 9.1.9 release. They were copy-pasted from the CHANGELOG on the 9.1.x (patch) branch. 20 May 2020, 22:46:19 UTC
back to top