https://github.com/angular/angular

sort by:
Revision Author Date Message Commit Date
9136dbd release: cut the v12.2.1 release (#43117) 11 August 2021, 17:13:33 UTC
4a1d9a7 refactor(compiler-cli): add test for `BananaInBoxCheck` (#42984) Create the test package for extended_template_diagnostics and add a unit test for the `BananaInBoxCheck`. Refs #42966 PR Close #42984 10 August 2021, 22:55:50 UTC
0f8ae8b refactor(compiler-cli): add `BananaInBoxCheck` to the template checks (#42984) Add the implementation of a Template Check that ensures the correct use of two-way binding syntax. Generates a warning when '([foo])="bar"' is found instead of '[(foo)]="bar"'. Refs #42966 PR Close #42984 10 August 2021, 22:55:50 UTC
c42b50c refactor(compiler-cli): visit inputs and outputs for elements and templates (#42984) This commit adds to the exisiting `RecursiveVisitor` and visits inputs and outputs for elements and templates. Refs #42966 PR Close #42984 10 August 2021, 22:55:50 UTC
a3bc29b refactor(compiler-cli): move `getSourceCodeForDiagnostic` to utils (#42984) Export `getSourceCodeForDiagnostic` from `ngtsc/testing` to make it available for other packages. This will help confirm that the source code is correct in other tests. Refs #42966 PR Close #42984 10 August 2021, 22:55:50 UTC
387dcc6 refactor(compiler-cli): move typecheck test utils into its own package (#42984) This commit moves the test utils used in the typechecking tests into its own package. This makes them available to be used in the tests of a different package. Refs #42966 PR Close #42984 10 August 2021, 22:55:50 UTC
029060f refactor(compiler-cli): introduce `getExtendedTemplateDiagnosticsForComponent` function (#42984) Add function to get extended template diagnostics generated by all the template checks. Refs #42966 PR Close #42984 10 August 2021, 22:55:50 UTC
a53d268 refactor(compiler-cli): make `makeTemplateDiagnostic` wrapper error (#42984) specific This commit makes the wrapper function `makeTemplateDiagnostic` take an ErrorCode as a type for the `ts.Diagnostic`s to be generated. Refs #42966 PR Close #42984 10 August 2021, 22:55:50 UTC
21e2b93 refactor(compiler-cli): introduce extended package to typecheck with it's API (#42984) This commit introduces //packages/compiler-cli/src/ngtsc/typecheck/extended as a container for a new phase of diagnostics generation. The API provides an interface for new template checks to implement and generate template diagnostics. Refs #42966 PR Close #42984 10 August 2021, 22:55:50 UTC
92012ec docs: Fix a few typos (#43051) There are small typos in: - aio/content/guide/universal.md - aio/content/guide/upgrade.md - aio/content/guide/workspace-config.md - dev-infra/ng-dev.js - integration/check-dependencies.js Fixes: - Should read `mergeable` rather than `mergable`. - Should read `upgradeable` rather than `upgradable`. - Should read `thresholds` rather than `threshholds`. - Should read `lease` rather than `leage`. - Should read `ignore` rather than `ingore`. - Should read `bootstrapping` rather than `bootstraping`. PR Close #43051 10 August 2021, 18:59:29 UTC
6ca81a7 docs: add angular community meetup and ngxp to community resources (#43103) Invite people to get more involved with Angular's community via these PR Close #43103 10 August 2021, 18:56:22 UTC
0baabcb docs: remove the mention of Stylus (#43013) Stylus is not supported anymore by Angular, so it should be removed from the Angular docs PR Close #43013 10 August 2021, 18:55:35 UTC
dc6cb5a Revert "build(dev-infra): exlude commit message filter from formatting (#43091)" (#43105) This reverts commit 7da3570be85035425417b7568b21285a8a1fd9a5. The reason for the revert is the breakage of the merge tooling (`dev-infra/commit-message-filter.js: No such file or directory`). PR Close #43105 10 August 2021, 18:49:42 UTC
7da3570 build(dev-infra): exlude commit message filter from formatting (#43091) exlude commit-message-filter.js from clang format and tslint PR Close #43091 10 August 2021, 17:44:35 UTC
ec192b2 refactor(core): replace references to goog.LOCALE with goog.getLocale() (#43089) It is necessary in order to distinguish 2 different reasons for referencing the compiled-in locale. 1. Some code just needs to pass the locale value on to logic that actually uses it. 2. Other code uses the locale value to select locale-specific user-visible data and behavior. Code modified by this change is of the first kind and should use `goog.getLocale()` in the future. Note: there are still references to the `goog.LOCALE` in Angular codebase, but they are of second type. PR Close #43089 10 August 2021, 17:35:26 UTC
55fe2c6 build(docs-infra): upgrade cli command docs sources to 7c2d76d9e (#43094) Updating [angular#12.2.x](https://github.com/angular/angular/tree/12.2.x) from [cli-builds#12.2.x](https://github.com/angular/cli-builds/tree/12.2.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/18b20d67b...7c2d76d9e): **Modified** - help/generate.json PR Close #43094 10 August 2021, 17:34:17 UTC
8a3d2aa fix(docs-infra): correctly detect chunk load errors (#43088) It seems that at some point (potentially with the switch to Webpack 5) Webpack started using the full chunk name (instead of just a numeric identifier) in `ChunkLoadError` messages. So the error messages changed from: ``` ChunkLoadError: Loading chunk 2 failed. ``` ...to: ``` ChunkLoadError: Loading chunk src_app_something_some_module_ts failed. ``` This commit updates the regex that is used to detect such errors (in order to print ServiceWorker-related debug info) to correctly recognize the new error message format. PR Close #43088 09 August 2021, 19:25:42 UTC
dd3abdb fix(router): ensure check for match options is compatible with property renaming (#43086) After renaming, 'paths' is not in routerLinkOptions since it's been renamed. PR Close #43086 09 August 2021, 17:26:07 UTC
d93427b docs: fix cli link (#43085) PR Close #43085 09 August 2021, 16:41:41 UTC
032e65c build(docs-infra): update docs examples to Angular v12.1.3 (#42949) This commit updates the docs examples to Angular v12.1.3. In addition to updating the dependencies versions, it also updates the projects' structure and configs to more closely match what a new v12 CLI app would look like. See, also, the [diff][1] between a basic v11.2.11 CLI app and a v12.1.3 one. [1]: https://github.com/cexbrayat/angular-cli-diff/compare/11.2.11..12.1.3 PR Close #42949 09 August 2021, 16:41:01 UTC
ee05a28 docs: fix typo in Compiler Options guide (#42949) PR Close #42949 09 August 2021, 16:41:01 UTC
4371ff9 fix(dev-infra): search since HEAD on the local branch for version tags when creating stamps (#43065) Using `HEAD~100` was errantly left in the snapshot stamping logic. PR Close #43065 06 August 2021, 15:54:22 UTC
a26b0dc ci: stop publishing snapshots to angular/dev-infra-private-builds (#43059) We no longer publish to angular/dev-infra-private-builds as the dev-infra content has been moved to angular/dev-infra. PR Close #43059 05 August 2021, 23:05:03 UTC
30c5b9c docs: fix interval type in the example (#43042) `window.setInterval` returns a `number`, let's fix this example. PR Close #43042 05 August 2021, 22:33:14 UTC
673f7a7 build(docs-infra): upgrade cli command docs sources to 18b20d67b (#43026) Updating [angular#12.2.x](https://github.com/angular/angular/tree/12.2.x) from [cli-builds#12.2.x](https://github.com/angular/cli-builds/tree/12.2.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/a57976b98...18b20d67b): **Modified** - help/e2e.json PR Close #43026 04 August 2021, 19:10:46 UTC
cdc8c7c release: cut the v12.2.0 release (#43047) 04 August 2021, 17:24:49 UTC
bd7f0d8 fix(core): incorrect error reported when trying to re-create view which had an error during creation (#43005) Currently if a view throws an error during creation mode, we mark it as `incompleteFirstPass` so that we can try to recover later. The recovery is only possible inside component views. The problem is that when this was introduced, I forgot to flip the `firstCreatePass` when an error is thrown which meant that calling `renderView` on the same component again is allowed. It will eventually hit an assertion which can be confusing for the end user. This issue only manifests itself when rendering views "manually" through `ViewContainerRef` (e.g. using `NgIf`). These changes flip the `firstCreatePass` back to false on errors so that trying to re-render the same view will throw an error which is consistent to the one that broke the view during creation. Fixes #41383. PR Close #43005 04 August 2021, 15:58:29 UTC
3a9ce61 Revert "refactor(ngcc): remove unused import (#42062)" (#43033) This reverts commit 42265cca1c0088b9623a94cfb4a39e9690e75234. PR Close #43033 03 August 2021, 22:39:00 UTC
ae98b24 Revert "test(compiler-cli): clarify source-map expectations in compliance tests (#42062)" (#43033) This reverts commit 29f9888a985b14cf1025105baa1fd262c751cc10. PR Close #43033 03 August 2021, 22:39:00 UTC
4997a3f Revert "refactor(compiler): remove cyclic dependencies (#42062)" (#43033) This reverts commit 75855196e320022e79202ccaeb9be000da55b9eb. PR Close #43033 03 August 2021, 22:38:59 UTC
6a59e6b Revert "refactor(compiler): support interpolation tokens when lexing markup (#42062)" (#43033) This reverts commit c8a46bfdcd5dac0044c4322a5b3967163056b339. PR Close #43033 03 August 2021, 22:38:59 UTC
6f80c55 Revert "refactor(compiler): share `isQuote()` via `chars.ts` (#42062)" (#43033) This reverts commit 3d3b69ff81c593602b75ee8eec60b36ecc09c767. PR Close #43033 03 August 2021, 22:38:59 UTC
07846e5 Revert "refactor(compiler): support interpolation tokens when lexing attribute values (#42062)" (#43033) This reverts commit c516e252fcb199f2f503db5dc6ce563a299da010. PR Close #43033 03 August 2021, 22:38:59 UTC
f18131f Revert "refactor(compiler): support encoded entity tokens when lexing markup (#42062)" (#43033) This reverts commit 942b24d5ea5d36ad4e53ed435bda35a6ae6876c9. PR Close #43033 03 August 2021, 22:38:59 UTC
f24b94f Revert "refactor(compiler): expose token parts in Text nodes (#42062)" (#43033) This reverts commit 8a54896a91512131fbfb0b3d2f5440aec792cbfd. PR Close #43033 03 August 2021, 22:38:59 UTC
6caafc2 Revert "test(compiler): check `fullStart` source-span (#42062)" (#43033) This reverts commit 973f9b8d1957d5479f5813664d35fd445f38e525. PR Close #43033 03 August 2021, 22:38:59 UTC
f883aae Revert "fix(compiler): include leading whitespace in source-spans of i18n messages (#42062)" (#43033) This reverts commit f08516db09df64c075f273159a15f80c792c96f0. PR Close #43033 03 August 2021, 22:38:59 UTC
2215af2 Revert "refactor(compiler): define interfaces for each lexer token (#42062)" (#43033) This reverts commit 9b3d4f5575bfccfbbfb943dc9689f3915dd63752. PR Close #43033 03 August 2021, 22:38:59 UTC
db4147b Revert "test(compiler): check that the parser supports prematurely terminated interpolations (#42062)" (#43033) This reverts commit 11ebe21d0dc8d82970153007e780800c87a76021. PR Close #43033 03 August 2021, 22:38:59 UTC
2dc6efe Revert "refactor(compiler): use `===` rather than `==` in the ml_parser (#42062)" (#43033) This reverts commit 28b0c45fde59da35a797cbdcceba973dbbb497a4. PR Close #43033 03 August 2021, 22:38:58 UTC
1d307bc Revert "test(compiler): add a test for parsing multiline expressions in attributes (#42062)" (#43033) This reverts commit fe1265158051ec3a90945bbc199af8c271b52842. PR Close #43033 03 August 2021, 22:38:58 UTC
aace1e7 fix(language-service): global autocomplete doesn't work when the user tries to modify the symbol (#42923) When the user tries to trigger suggestions from an interruption, the LS should provide the global completions. For example, `[input]="t¦"`, the `t` can be the `true` or the symbol from the component context. PR Close #42923 03 August 2021, 00:08:30 UTC
fbfec94 docs: amend links in content-projection guide (#43009) PR Close #43009 02 August 2021, 22:36:52 UTC
0e47334 refactor(core): update peerDependencies to allow rxjs7 (#42991) We can't update the framework to rxjs7 until version 13, because it contains breaking changes, but we can allow users to opt into it since all of our code should be compatible. These changes expand the allowed version range of rxjs and add an integration test to verify that we don't get compilation errors. Note that we also have a test that runs the AIO examples against rxjs 7 already (#42660). Fixes #41897. PR Close #42991 02 August 2021, 20:55:01 UTC
e4f62c1 test(compiler): add a test for parsing multiline expressions in attributes (#42062) This tests a scenario that was failing in an internal project. PR Close #42062 02 August 2021, 16:53:18 UTC
ea3a148 refactor(compiler): use `===` rather than `==` in the ml_parser (#42062) This is a simple tidy up commit to move to the more specific `===` comparison operator in the HTML lexer/parser. PR Close #42062 02 August 2021, 16:53:18 UTC
a96f9c9 test(compiler): check that the parser supports prematurely terminated interpolations (#42062) Such interpolations turned up during internal testing at Google, so this commit adds a test to prevent regressions. PR Close #42062 02 August 2021, 16:53:18 UTC
a8c0f4f refactor(compiler): define interfaces for each lexer token (#42062) These token interfaces will make it easier to reason about tokens in the parser and in specs. Previously, it was never clear what items could appear in the `parts` array of a token given a particular `TokenType`. Now, each token interface declares a labelled tuple for the parts, which helps to document the token better. PR Close #42062 02 August 2021, 16:53:18 UTC
11ef03b fix(compiler): include leading whitespace in source-spans of i18n messages (#42062) Previously, the way templates were tokenized meant that we lost information about the location of interpolations if the template contained encoded HTML entities. This meant that the mapping back to the source interpolated strings could be offset incorrectly. Also, the source-span assigned to an i18n message did not include leading whitespace. This confused the output source-mappings so that the first text nodes of the message stopped at the first non-whitespace character. This commit makes use of the previous refactorings, where more fine grain information was provided in text tokens, to enable the parser to identify the location of the interpolations in the original source more accurately. Fixes #41034 PR Close #42062 02 August 2021, 16:53:18 UTC
8e798ef test(compiler): check `fullStart` source-span (#42062) The tests were checking that the source-span of parsed HTML nodes were accurate, but they were not checking the span when it includes the "leading trivia", which are given by the `fullStart` rather than `start` location. PR Close #42062 02 August 2021, 16:53:18 UTC
54f7353 refactor(compiler): expose token parts in Text nodes (#42062) When it was tokenized, text content is split into parts that can include interpolations and encoded entities tokens. To make this information available to downstream processing, this commit adds these tokens to the `Text` AST nodes, with suitable processing. PR Close #42062 02 August 2021, 16:53:18 UTC
61080ea refactor(compiler): support encoded entity tokens when lexing markup (#42062) The lexer now splits encoded entity tokens out from text and attribute value tokens. Previously encoded entities would be decoded and the decoded value would be included as part of the text token of the surrounding text. Now the entities have their own tokens. There are two scenarios: text and attribute values. Previously the contents of `<div>Hello &amp; goodbye</div>` would be a single TEXT token. Now it will be three tokens: ``` TEXT: "Hello " ENCODED_ENTITY: "&", "&amp;" TEXT: " goodbye" ``` Previously the attribute value in `<div title="Hello &amp; goodbye">` would be a single text token. Now it will be three tokens: ``` ATTR_VALUE_TEXT: "Hello " ENCODED_ENTITY: "&", "&amp;" ATTR_VALUE_TEXT: " goodbye" ``` - ENCODED_ENTITY tokens have two parts: "decoded" and "encoded". - ENCODED_ENTITY tokens are always preceded and followed by either TEXT tokens or ATTR_VALUE_TEXT tokens, depending upon the context, even if they represent an empty string. The HTML parser has been modified to recombine these tokens to allow this refactoring to have limited effect in this commit. Further refactorings to use these new tokens will follow in subsequent commits. PR Close #42062 02 August 2021, 16:53:18 UTC
4116d5d refactor(compiler): support interpolation tokens when lexing attribute values (#42062) The lexer now splits interpolation tokens out from attribute value tokens. Previously the attribute value of `<div attr="Hello, {{ name}}">` would be a single token. Now it will be three tokens: ``` ATTR_VALUE_TEXT: "Hello, " ATTR_VALUE_INTERPOLATION: "{{", " name", "}}" ATTR_VALUE_TEXT: "" ``` - ATTR_VALUE_INTERPOLATION tokens have three parts, "start marker", "expression" and "end marker". - ATTR_VALUE_INTERPOLATION tokens are always preceded and followed by TEXT tokens, even if they represent an empty string. The HTML parser has been modified to recombine these tokens to allow this refactoring to have limited effect in this commit. Further refactorings to use these new tokens will follow in subsequent commits. PR Close #42062 02 August 2021, 16:53:18 UTC
5572278 refactor(compiler): share `isQuote()` via `chars.ts` (#42062) This function is general purpose and by moving it into the `chars.ts` file along with similar helpers, it can be reused in the lexer, for instance. PR Close #42062 02 August 2021, 16:53:18 UTC
b442c49 refactor(compiler): support interpolation tokens when lexing markup (#42062) The lexer now splits interpolation tokens out from text tokens. Previously the contents of `<div>Hello, {{ name}}<div>` would be a single text token. Now it will be three tokens: ``` TEXT: "Hello, " INTERPOLATION: "{{", " name", "}}" TEXT: "" ``` - INTERPOLATION tokens have three parts, "start marker", "expression" and "end marker". - INTERPOLATION tokens are always preceded and followed by TEXT tokens, even if they represent an empty string. The HTML parser has been modified to recombine these tokens to allow this refactoring to have limited effect in this commit. Further refactorings to use these new tokens will follow in subsequent commits. PR Close #42062 02 August 2021, 16:53:18 UTC
014763e refactor(compiler): remove cyclic dependencies (#42062) This commit removes 9 cycles in the dependency graph of the compiler code. PR Close #42062 02 August 2021, 16:53:17 UTC
86cfbf8 test(compiler-cli): clarify source-map expectations in compliance tests (#42062) The compliance tests can check source-map segments against expectations encoded into the expectation files. Previously, the encoding of the expected segment was only delimited by whitespace, but this made it difficult to identify segments that started or ended with whitespace. Now these segment expectations are wrapped in double-quotes which makes it easier to read and understand the expectation files. PR Close #42062 02 August 2021, 16:53:17 UTC
3b92b4a refactor(ngcc): remove unused import (#42062) This import is not used in the file, so can be removed. PR Close #42062 02 August 2021, 16:53:17 UTC
dd6e80a refactor(bazel): extract function to patch fileNameToModuleName on host (#42974) This commit extracts the patching operation that adds `fileNameToModuleName` to the Angular compiler's `ts.CompilerHost` into a separate function, so that it can be invoked in other compilation flows besides the one outlined in `ngc-wrapped`. This is primarily needed for the xi18n operation in g3. PR Close #42974 30 July 2021, 16:29:45 UTC
da50b9b refactor(compiler): remove unnecessary escapes (#42990) This commit is part of a larger scale change to eliminate unnecessary escapes in string literals, in advance of enabling stricter checks in `ts_library` rules in g3. PR Close #42990 30 July 2021, 16:28:46 UTC
86e4b3c fix(dev-infra): browser archive rule should handle `.dmg` files (#42992) We recently reworked our browser archive extraction to happen at analysis time for better caching. This resulted in us breaking the extraction of macOS dmg files so that Firefox is currently not usable for local testing on macOS. We implement a similar special logic for `.dmg` files to what has been done within the Bazel webtesting rules. PR Close #42992 30 July 2021, 16:28:08 UTC
3fddcb5 docs: Fix wrongly provided/Injected AnimalService (#42988) In the logical tree example which demonstrate the use of `@SkipSelf` and `@Host`, the provided and injected `AnimalService` are reversed. PR Close #42988 29 July 2021, 22:05:53 UTC
d5cc87d docs: Add josmar-crwdstffng to contributors list. (#42972) Add josmar-crwdstffng to list in contributors.json. Add josephmmartin image file. PR Close #42972 28 July 2021, 22:56:02 UTC
b075721 fix(dev-infra): ensure that building environment stamp fails silently (#42985) Previously when a failure occurred in part of building the environment stamp, the entire process errored. This should instead fail silently providing no value for the stamp. PR Close #42985 28 July 2021, 20:00:09 UTC
3346cb6 release: cut the v12.2.0-rc.0 release (#42983) 28 July 2021, 18:51:31 UTC
b0739c2 docs: release notes for the v12.1.4 release 28 July 2021, 18:45:37 UTC
a2c8933 build: update bazel to v4.0.0-beta.1 (#42967) PR Close #42967 28 July 2021, 17:54:05 UTC
63918d8 docs: include interpolations in the "What is Angular" example (#42702) Affected URL - https://angular.io/guide/what-is-angular#template Fixes #42665 PR Close #42702 28 July 2021, 17:53:32 UTC
7c35ca0 feat(language-service): support autocomplete string literal union types in templates (#42729) The native TS language service has the ability to provide autocompletions for string literal union types. This pr is for Angular to do the same in templates. Fixes https://github.com/angular/vscode-ng-language-service/issues/1096 PR Close #42729 28 July 2021, 17:52:34 UTC
047994b feat(dev-infra): introduce release action for directly branching-off into RC (#42973) Introduces a new release action for cutting a release-action by directly moving the next release-train into the `release-candidate` phase. This allows the Angular team to release minor versions without needing to branch-off first into the feature-freeze phase. For minors this phase can be skipped. Switching into the feature-freeze phase beforehand as a workaround would have allowed for branching-off but has the downside that `target: minor` would no longer point to the branched-off release train (only `target: rc` would work then). PR Close #42973 28 July 2021, 17:50:22 UTC
0d81b00 fix(router): add missing outlet events to RouterOutletContract (#42431) Exposes both activateEvents and deactivateEvents as the original outlet interface did. PR Close #42431 27 July 2021, 23:34:24 UTC
85e93c3 fix(docs-infra): notify `ErrorHandler` of `UnrecoverableState` errors (#42941) With this commit, the `ErrorHandler` is notified of ServiceWorker `UnrecoverableState` errors. The main purpose of this change is gathering info about the occurrence (and frequency) of such errors in Google analytics. PR Close #42941 27 July 2021, 16:23:14 UTC
b1082b7 ci: add atscott to fw-compiler reviewers (#42963) add atscott to fw-compiler reviewers PR Close #42963 27 July 2021, 16:22:49 UTC
b93c42e docs: updated input-output page documentation content (#42964) PR Close #42964 27 July 2021, 16:22:19 UTC
057e577 refactor(compiler-cli): add makeTemplateDiagnostic wrapper (#42937) Add a `makeTemplateDiagnostic` wrapper in the `TemplateTypeChecker`. This requiers less parameters to create template diagnostics, since the `TemplateTypeChecker` can get the templateId and mapping from it's scope with the `ts.ClassDeclartion`. The `TemplateTypeChecker` is often used to determine if a diagnostic should be produced, so it makes sense to have a function in it that helps create them. Refs #42966 PR Close #42937 27 July 2021, 01:00:44 UTC
ed9cfb6 fix(compiler-cli): use correct module resolution context for absolute imports in .d.ts files (#42879) The compiler keeps track of how a declaration has been referenced using absolute module imports and from which path the absolute module should be resolved from. There was a bug in how the .d.ts metadata extraction would incorrectly use the .d.ts file itself as resolution context for symbols that had been imported using a relative module specifier. This could result in module resolution failures. For example, when extracting NgModule metadata from `/node_modules/lib/index.d.ts` that looks like ``` import {LibDirective} from './dir'; @NgModule({ declarations: [LibDirective], exports: [LibDirective], }) export class LibModule {} ``` and `/app.module.ts` that contains ``` import {LibModule} from 'lib'; @NgModule({ imports: [LibModule], }) export class AppModule {} ``` then `AppModule` would have recorded a reference to `LibModule` using the `'lib'` module specifier. When extracting the NgModule metadata from the `/node_modules/lib/index.d.ts` file the relative import into `./dir` should also be assumed to be importable from `'lib'` (according to APF where symbols need to be exported from a single entry-point) so the reference to `LibDirective` should have `'lib'` as absolute module specifier, but it would incorrectly have `/node_modules/lib/index.d.ts` as resolution context path. The latter is incorrect as `'lib'` needs to be resolved from `/app.module.ts` and not from within the library itself. Fixes #42810 PR Close #42879 26 July 2021, 20:17:44 UTC
dbae001 feat(router): ability to provide custom route reuse strategy via DI for `RouterTestingModule` (#42434) For now it's not possible to provide custom route reuse strategy via DI for `RouterTestingModule`, only imperative instantiation. These changes makes it possible to provide custom route reuse strategy via DI. PR Close #42434 26 July 2021, 19:02:42 UTC
72c03a0 build: remove ts-api-guardian from repository (#42735) This commit removes `ts-api-guardian` from the repository. We introduced a new tool for testing API signature that is part of the shared dev-infra package. The TS API guardian package will be deprecated for the public in favor of Microsoft's API extractor that has support for more parts of the syntax, such as alias exports. PR Close #42735 26 July 2021, 19:02:14 UTC
271700c docs: fix the selector in component interaction guide (#42891) The selector for the `CountdownTimerComponent` is `app-countdown-timer` not `countdown-timer`. PR Close #42891 26 July 2021, 18:47:55 UTC
816ba07 build: update dependency eslint-plugin-jsdoc to v36 (#42956) PR Close #42956 26 July 2021, 18:37:15 UTC
05d996d docs: Edits to remove jargon (#42861) PR Close #42861 24 July 2021, 00:12:50 UTC
4b49824 test(router): move computed state restoration tests to own file (#42933) To reduce the enormouse size of the integration.spec.ts file, move tests related to the computed state restoration to their own file. PR Close #42933 23 July 2021, 21:25:06 UTC
9119e1f refactor(router): Ensure computed state restoration works for thrown errors (#42933) When `canceledNavigationResolution='computed'`, the `Router` needs to handle the cases where errors are thrown. Previously, the logic was not updated and would simply do a `replaceState` rather than determining where in the history we should move to restore the page/url from before the failed navigation. PR Close #42933 23 July 2021, 21:25:06 UTC
8fc08c5 ci: update pullapprove config to properly handle global approvals (#42929) Update the config to properly identify a global approval as approved rather than as no file matching based groups being matched. PR Close #42929 23 July 2021, 19:09:26 UTC
a6c256f docs: Add import line to router event example for clarification (#42935) Without the `import {Event} from '@angular/router';`, the filter will not work because the type is understood as the native `Event`. Fixes #42920 PR Close #42935 23 July 2021, 19:06:34 UTC
1f6cc57 build(docs-infra): upgrade cli command docs sources to a57976b98 (#42943) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/18bbd044d...a57976b98): **Modified** - help/generate.json PR Close #42943 23 July 2021, 19:05:56 UTC
648da4f build: update dependency globby to v12 (#42921) PR Close #42921 23 July 2021, 17:37:35 UTC
19da737 build(docs-infra): switch the `example-e2e` script to ESM (#42921) Switch the JS script used for running the docs examples tests from CommonJS to ESM format. This is necessary for upgrading the `globby` dependency to [version 12.0.0][1] in a subsequent commit. [1]: https://github.com/sindresorhus/globby/releases/v12.0.0 PR Close #42921 23 July 2021, 17:37:35 UTC
662addb build(docs-infra): switch the `generate-stackblitz/zips` scripts to ESM (#42921) Switch the JS scripts used for generating StackBlitz projects and zips from CommonJS to ESM format. This is necessary for upgrading the `globby` dependency to [version 12.0.0][1] in a subsequent commit. [1]: https://github.com/sindresorhus/globby/releases/v12.0.0 PR Close #42921 23 July 2021, 17:37:35 UTC
99f8338 feat(dev-infra): include experimental version stamp in env stamps (#42934) Include the determined experimental version for stamping in the env stamps created for release and snapshot builds. PR Close #42934 23 July 2021, 17:37:08 UTC
e462743 refactor(dev-infra): move semver utils into the utils directory (#42917) Move semver into the utils directory rather than as a set of utils specifically for release tooling. While the utils are only currently used in the release tooling, they are not providing a release specific utility and can be used by any subtool of ng-dev. PR Close #42917 22 July 2021, 18:01:17 UTC
d2b1c3e fix(dev-infra): fix creating experimental semver versions to include prerelease chunk (#42917) SemVers created for experimental versions should also include the prerelease chunk (i.e. -next.3). PR Close #42917 22 July 2021, 18:01:17 UTC
69d4ebf Revert "fix(dev-infra): perform actual npm login verification for wombot proxy (#42871)" (#42917) This reverts commit fd92a3e87f08253ac8d20d01bc726c7460bd9ec9. It turns out that wombot proxy will return who is logged in, but does so regardless of if the users token is currently active. Since we cannot rely on `npm whoami` to determine the login state, we revert to our previous state of assuming new login is needed. PR Close #42917 22 July 2021, 18:01:17 UTC
1d9d026 feat(forms): add hasValidators, addValidators, and removeValidators methods (for both sync and async) (#42838) Several new functionalities are possible with this change: the most requested is that callers can now check whether a control has a required validator. Other uses include incrementally changing the validators set without doing an expensive operation to reset all validators. Closes #13461. PR Close #42838 22 July 2021, 16:31:00 UTC
7e9673d ci: fix typo in docs-bug issue template (#42908) "browser specific" should be replaced with "browser-specific" because it's a compound modifier (cf. https://en.wikipedia.org/wiki/Compound_modifier). See #42906 PR Close #42908 22 July 2021, 16:25:39 UTC
5d222f3 docs: fix spacing in code style guide (#42908) Fixes #42906 PR Close #42908 22 July 2021, 16:25:39 UTC
b5f1779 docs: Edits to remove jargon (#42907) PR Close #42907 22 July 2021, 16:24:15 UTC
5fb23ec perf(compiler-cli): skip analysis in incremental builds for files without Angular behavior (#42562) In an incremental rebuild, the compiler attempts to reuse as much analysis data from a prior compilation as possible to avoid doing the analysis work again. For source files without Angular behavior however, no analysis data would be recorded such that the source file had to be reanalyzed each rebuild, even if it has not changed. This commit avoids the analysis of such source files by registering these files as not containing any Angular behavior; allowing subsequent rebuilds to avoid the analysis work. PR Close #42562 21 July 2021, 22:40:38 UTC
a502279 feat(forms): allow minLength/maxLength validator to be bound to `null` (#42565) If the validator is bound to be `null` then no validation occurs and attribute is not added to DOM. For every validator type different PR will be raised as discussed in https://github.com/angular/angular/pull/42378. Closes #42267. PR Close #42565 21 July 2021, 22:35:59 UTC
eefe168 fix(core): correctly handle `null` or `undefined` in `ErrorHandler#handleError()` (#42881) Since `ErrorHandler#handleError()` expects an argument of type `any` it should be able to handle values such as `null` and `undefined`. Previously, it failed to handle these values, because it was trying to access properties on them. This commit fixes it by ensuring no properties are accessed on `null` or `undefined` values. NOTE: This is part of fully addressing #28106. Fixes #21252 PR Close #42881 21 July 2021, 22:35:34 UTC
back to top