Skip to main content

Browse the archive

https://github.com/angular/angular
07 August 2024, 03:31:07 UTC
sort by:
Revision Author Date Message Commit Date
7cb3b78 Dylan Hunn 19 January 2022, 17:30:23 UTC release: cut the v13.1.3 release (#44757) PR Close #44757 19 January 2022, 17:31:48 UTC
3797d10 Ramesh Thiruchelvam 02 December 2021, 00:15:32 UTC refactor(core): make the error messages tree shakable (#44359) Long error messages can be tree-shaken in the production build and replaced with error codes. See: https://github.com/angular/angular/pull/44219#issuecomment-983216374 PR Close #44359 19 January 2022, 01:38:10 UTC
929788d dario-piotrowicz 15 January 2022, 21:07:44 UTC refactor(animations): change errors type from any to string (#44726) errors in the animations code are of type `any` but are consistently used as if there were `string`s, change `any` to `string` to make typing more accurate PR Close #44726 18 January 2022, 23:52:05 UTC
e9bd16a JoostK 16 January 2022, 17:20:01 UTC refactor(compiler): remove directive matching from template compiler (#44731) The directive matching pass that happens during template compilation is redundant, since directive matching has already happened during the resolution phase of ngtsc and only matching declarables are provided to the template compiler. In JIT mode the declarables only become available after the primary template compilation has completed, so there is no need to perform directive matching in both JIT and AOT mode. PR Close #44731 18 January 2022, 22:51:09 UTC
95248a0 JoostK 16 January 2022, 17:11:11 UTC refactor(compiler): store modifiers in a bitmask instead of an array (#44731) This commit slightly reduces memory usage of output AST by storing type and statement modifiers as a bitmask instead of using an array. PR Close #44731 18 January 2022, 22:51:09 UTC
626f3f2 JoostK 14 January 2022, 21:44:57 UTC perf(compiler-cli): reduce analysis work during incremental rebuilds (#44731) This commit reduces the analysis work that needs to happen during an incremental rebuild by properly recording files for which no traits were found in the set of files that have no traits, such that the same file doesn't have to be reanalyzed during subsequent rebuilds. It also excludes shim files from analysis. PR Close #44731 18 January 2022, 22:51:08 UTC
cab81ba Ramesh Thiruchelvam 08 January 2022, 09:18:47 UTC refactor(common): make the error messages tree shakable (#44663) Make Long error messages tree-shakable in the production build with error codes. fixes #40096 PR Close #44663 18 January 2022, 18:31:44 UTC
617610e AnkitSharma-007 07 January 2022, 14:21:11 UTC docs: add Ankit to GDE resources (#44659) PR Close #44659 18 January 2022, 17:25:08 UTC
14eb6c4 Renovate Bot 16 January 2022, 00:16:54 UTC build: update angular (#44728) PR Close #44728 18 January 2022, 17:24:43 UTC
f9ca4d8 JoostK 09 January 2022, 20:23:33 UTC fix(ngcc): support element accesses for export declarations (#44669) Bundlers like Rollup may use an element access expression for an export declaration, which causes ngcc to ignore those export declarations possibly resulting in incomplete processing of packages. Element access syntax may be used when the declared name is not considered as valid JS identifier, but bundlers may be conservative in determining whether an identifier can be used (to emit a property access) and opt for a string literal in an element access instead. The element access syntax introduces a problem for ngcc, where it wouldn't consider such export as class declaration, causing them to be skipped. The ngtsc compiler is implemented with the assumption that all class declarations use a `ts.Identifier` as name, whereas the element access is using a string literal for the declared name. This makes it troublesome for ngcc to support this syntax form in UMD bundles. To work around the problem, this function transforms these access expressions into regular property accesses. The source text is parsed to an AST to allow finding the element accesses in a robust way, after which the affected text ranges are replaced with property accesses in the original source text. Closes #44037 PR Close #44669 15 January 2022, 01:44:00 UTC
af0a152 dario-piotrowicz 16 December 2021, 19:38:30 UTC fix(animations): apply setStyles to only rootTimelines (#44515) during keyframe building only consider the root element's timelines for the style setting, so that the states styles (applied with '*') can be applied correctly resolves #32133 resolves #28654 PR Close #44515 13 January 2022, 20:01:51 UTC
e0bea36 Renovate Bot 13 January 2022, 09:20:16 UTC build: update all non-major dependencies (#44705) PR Close #44705 13 January 2022, 20:01:08 UTC
44ff4fb Alan Agius 13 January 2022, 12:05:34 UTC test: update integration payload size checks golden file (#44440) This updates the size checks for Angular CLI version 13.1.3. The increase in size is due to changes in ESBuild. Before ```js class bS extends Wl { constructor(t, n, r, i) { super(t), (this.component = r); const o = Is(i + "-" + r.id, r.styles, []); n.addStyles(o), (this.contentAttr = "_ngcontent-%COMP%".replace(Gl, i + "-" + r.id)), (this.hostAttr = "_nghost-%COMP%".replace(Gl, i + "-" + r.id)); } applyToHost(t) { super.setAttribute(t, this.hostAttr, ""); } createElement(t, n) { const r = super.createElement(t, n); return super.setAttribute(r, this.contentAttr, ""), r; } } ``` Now ```js class ES extends Wl { constructor(t, n, r, i) { super(t), (this.component = r); const o = Is(i + "-" + r.id, r.styles, []); n.addStyles(o), (this.contentAttr = (function _S(e) { return "_ngcontent-%COMP%".replace(Gl, e); })(i + "-" + r.id)), (this.hostAttr = (function CS(e) { return "_nghost-%COMP%".replace(Gl, e); })(i + "-" + r.id)); } applyToHost(t) { super.setAttribute(t, this.hostAttr, ""); } createElement(t, n) { const r = super.createElement(t, n); return super.setAttribute(r, this.contentAttr, ""), r; } } ``` PR Close #44440 13 January 2022, 18:30:53 UTC
7c49b41 Renovate Bot 13 January 2022, 00:03:41 UTC build: update angular (#44440) PR Close #44440 13 January 2022, 18:30:53 UTC
8234564 Łukasz Holeczek 04 January 2022, 15:28:29 UTC docs: add CoreUI UI Components Library to the resources list (#44613) PR Close #44613 13 January 2022, 18:27:51 UTC
5e4038e Joey Perrott 12 January 2022, 18:39:24 UTC build: update shelljs dependencies to "^0.8.5" (#44697) Update shelljs dependencies to ^0.8.5 to fix a vulnerability reported to shelljs. PR Close #44697 13 January 2022, 18:27:33 UTC
ba5fe3f Daniel Díaz 12 January 2022, 21:10:23 UTC docs: remove unnecessary parenthesis in View Encapsulation file (#44702) PR Close #44702 13 January 2022, 18:27:13 UTC
71449b1 dario-piotrowicz 12 January 2022, 21:37:37 UTC refactor(elements): remove the createCustomEvent function (#44703) the createCustomEvent function's pupose is to create customEvents even on browsers where `CustomEvent` is not a constructor, `CustomEvent` is currently available in all supported browsers (since IE11 support has ended), so remove the function as it is no longer needed PR Close #44703 13 January 2022, 18:26:54 UTC
ec95631 Jessica Janiuk 11 January 2022, 22:39:08 UTC refactor(animations): Remove unnecessary IE specific code (#44686) There were a few places we were still checking for Internet Explorer. This removes the references throughout the animations package. PR Close #44686 12 January 2022, 20:43:23 UTC
74037f1 Andrew Kushnir 10 January 2022, 22:09:41 UTC ci: add golden files for runtime error codes (#44677) Runtime error codes in the Core, Common and Forms packages were not included into the `public-api` group reviews. This commit creates the necessary golden files to keep track of further changes in the runtime codes. This is a followup from https://github.com/angular/angular/pull/44398#issuecomment-1006910976. PR Close #44677 12 January 2022, 20:42:06 UTC
07d97af iRealNirmal 21 December 2021, 09:38:09 UTC refactor(forms): update email validator to inherit abstractValidator (#44545) Modified email validator to inherit abstractValidator. For every validato type different PR will be raised as discussed in #42378. Closes #42267 PR Close #44545 12 January 2022, 20:41:40 UTC
d613571 Dmytro Mezhenskyi 25 November 2021, 15:14:47 UTC docs: add Decoded Frontend YT channel to resources list (#44278) PR Close #44278 12 January 2022, 20:41:17 UTC
d1762c7 Andrew Scott 12 January 2022, 18:47:32 UTC release: cut the v13.1.2 release (#44698) 12 January 2022, 18:47:32 UTC
92784ca wszgrcy 06 January 2022, 15:34:39 UTC docs: add miniprogram cross-platform development resource with resources.json (#44646) PR Close #44646 11 January 2022, 22:04:22 UTC
60fb27f Alex Rickabaugh 10 January 2022, 21:01:47 UTC fix(compiler-cli): properly index <svg> elements (#44678) In the `Element` node of a parsed `<svg>` element, the `name` is recorded as `:svg:svg`. When the Angular Indexer ran over this element, it would attempt to find this name in the template text and fail, as the namespace portion of the name was added automatically at parse time and is of course missing from the original template. This commit changes the indexer to detect these namespaced elements and only search for the tag name. PR Close #44678 11 January 2022, 19:16:19 UTC
59eef29 Alex Rickabaugh 10 January 2022, 20:52:03 UTC fix(compiler): correct spans when parsing bindings with comments (#44678) When parsing a binding with a comment at the end of the expression, the parser previously had logic to offset the parsed spans by the length of the comment. This logic seemed not to serve any useful purpose, and instead resulted in the corruption of the spans. For example, in the expression `{{foo // comment}}`, the parser would map the parsed `foo` `PropertyRead` node at the location of the characters 'ent' from the comment suffix. This commit removes that logic, correcting the parsed spans of such nodes in the presence of comments. Removing this logic does not seem to have caused any tests to fail. PR Close #44678 11 January 2022, 19:16:19 UTC
1e918b6 Alex Rickabaugh 10 January 2022, 20:21:35 UTC fix(compiler-cli): handle property reads of `ThisReceiver` in the indexer (#44678) Previously, the Angular Indexer made an assumption that in any binding to a property of an `ImplicitReceiver`, the property name begins at the start of the binding. This is true for normal reads from `ImplicitReceiver` as the implicit receiver has no representation in the template. However, `ThisReceiver` inherits from `ImplicitReceiver` and _does_ have a template representation. Such a binding looks like `{{this.foo}}`. This commit corrects the logic of the indexer to use the `nameSpan` of the property binding instead of its `sourceSpan` to locate the identifier. PR Close #44678 11 January 2022, 19:16:19 UTC
69b00a0 Doug Parker 04 December 2021, 03:17:30 UTC refactor(compiler-cli): add validation to extended template diagnostics configuration (#44391) Refs #42966. This validates the `tsconfig.json` options for extended template diagnostics. It verifies: * `strictTemplates` must be enabled if `extendedDiagnostics` have any explicit configuration. * `extendedDiagnostics.defaultCategory` must be a valid `DiagnosticCategoryLabel`. * `extendedDiagnostics.checks` keys must all be real diagnostics. * `extendedDiagnostics.checks` values must all be valid `DiagnosticCategoryLabel`s. These include new error codes, each of which prints out the exact property that was the issue and what the available options are to fix them. It does disallow the config: ```json { "angularCompilerOptions": { "strictTemplates": false, "extendedDiagnostics": { "defaultCategory": "suppress" } } } ``` Such a configuration is technically valid and could be executed, but will be rejected by this verification logic. There isn't much reason to ever do this, since users could just drop `extendedDiagnostics` altogether and get the intended effect. This is unlikely to be a significant issue for users, so it is considered invalid for now to keep the implementation simple. PR Close #44391 11 January 2022, 17:33:17 UTC
fb7900b Doug Parker 30 November 2021, 02:47:55 UTC refactor(compiler-cli): add `defaultCategory` option (#44391) Refs #42966. The `defaultCategory` option is used for any extended template diagnostics which do not have any specific category specified for them. It defaults to `warning`, since that is the most common behavior expected for users. This provides an easy way for users to promote all diagnostics to errors or suppress all diagnostics. PR Close #44391 11 January 2022, 17:33:17 UTC
7b38c85 Doug Parker 07 December 2021, 05:35:38 UTC refactor(compiler-cli): use configured diagnostic category when emitting warnings from extended template diagnostics (#44391) Refs #42966. This updates `TemplateContext` to include a new `makeTemplateDiagnostic()` function which automatically uses the correct diagnostic category for that check. This makes sure that each diagnostic is emitted with the correct category. It also implicitly passes some known values like `component` and `code` to make the extended template diagnostics a little simpler. Diagnostics which are suppressed are never instantiated at all, which acts as a slight performance optimization since any emitted diagnostics would be ignored anyways. Unfortunately, diagnostics still have access to `ctx.templateTypeChecker.makeTemplateDiagnostic()` to manually create diagnostics with a different category. Both banana in box and nullish coalescing checks include tests to make sure they respect a manually configured category. This convention should hopefully give a reasonable certainty that new diagnostics will use the correct reporting function, even if that is not strictly enforced. PR Close #44391 11 January 2022, 17:33:16 UTC
7dfa44e Doug Parker 07 December 2021, 05:41:31 UTC refactor(compiler-cli): add initial compiler options definitions for extended template diagnostics (#44391) Refs #42966. This includes a mapping of extended template diagnostics to their associated diagnostic category. It is generated from the list of diagnostic names, so the list should always be implicitly kept up to date. Usage looks like: ```json { "angularCompilerOptions": { "extendedDiagnostics": { "checks": { "invalidBananaInBox": "error", "nullishCoalescingNotNullable": "suppress" } } } } ``` PR Close #44391 11 January 2022, 17:33:16 UTC
f8e7f60 Doug Parker 30 November 2021, 01:11:41 UTC refactor(compiler-cli): add `allDiagnosticFactories` (#44391) Refs #42966. This is a static array of all the 1P extended template diagnostic factories built into the Angular compiler directly. It provides an encapsulated list of all diagnostics rather than requiring users to manually list each one individually. PR Close #44391 11 January 2022, 17:33:16 UTC
a3082fb Doug Parker 07 December 2021, 02:23:21 UTC refactor(compiler-cli): call factories directly from extended template checker (#44391) Refs #42966. This moves extended template check factory invocations into the checker itself, where it can provide a more consistent API contract. Factories are called with compiler options and may return a `TemplateCheck` or `undefined` if the current options do not support that check. This allows `nullishCoalescingNotNullable` to disable itself when `strictNullChecks` is disabled without throwing errors. This gives extended template diagnostics a stronger abstraction model to define their behavior with. PR Close #44391 11 January 2022, 17:33:16 UTC
fe02841 Doug Parker 30 November 2021, 00:48:27 UTC refactor(compiler-cli): add `ExtendedTemplateDiagnosticName` and `TemplateCheckFactory` (#44391) Refs #42966. The enum of extended template diagnostic names allows a global registry of first-party diagnostics with a developer-friendly string name which can be used for configuration. This name is used in the new `TemplateCheckFactory` to bind the name to a particular `ErrorCode` and make both available *before* constructing the actual template check, which is necessary to configure it appropriately. PR Close #44391 11 January 2022, 17:33:16 UTC
08049fa JoostK 11 December 2021, 20:19:32 UTC fix(compiler-cli): enable narrowing of using type guard methods (#44447) The changes in 2028c3933f7fe2961999da475febde5a03bb694d caused method calls to be emitted using additional parenthesis into the TCB, which in turn prevented proper type narrowing when the method acts as a type guard. This commit special-cases method calls from property reads to avoid the additional parenthesis. Fixes #44353 PR Close #44447 10 January 2022, 21:20:06 UTC
c375e5d Patrick Prakash 03 December 2021, 11:17:15 UTC docs: Updated described version number (#44365) Updated a mentioned version to a recent angular version number to cope up with the latest version PR Close #44365 10 January 2022, 19:58:52 UTC
c0a3341 Renovate Bot 10 January 2022, 19:17:09 UTC build: update all non-major dependencies (#44502) PR Close #44502 10 January 2022, 19:55:24 UTC
3512eb6 twerske 06 January 2022, 17:38:54 UTC docs: improve the component styling guide (#44234) PR Close #44234 10 January 2022, 19:53:56 UTC
7f2f992 Kyoz 05 January 2022, 02:51:16 UTC docs: missing whitespace in HostListener example (#44624) PR Close #44624 10 January 2022, 19:53:09 UTC
abc217b Dario Piotrowicz 29 December 2021, 18:59:36 UTC fix(animations): retain triggers values for moved tracked list items (#44578) when reordering a list with animations the list items lose their current triggers values, that is because the reordering of an item is implemented as follows (_note:_ the following implementation has been added in PR #23534) - the item is removed and marked _setForRemoval_ - the item is re-inserted, and the _setForRemoval_ is changed to _setForMove_ - the player set for animating the removal is destroyed when _setForMove_ is detected the above steps allow the element not to be animated and to keep its styling but the triggers values get lost since the removal transition/player has already been initialized, so this change adds a _previousTriggersValues_ map in the _REMOVAL_FLAG_ field in order to restore the triggers values if/when the removal turns out to be a move, changing the above steps to: - the item is removed and marked setForRemoval __and its current triggers values are saved as well__ - the item is re-inserted, and the setForRemoval is changed to setForMove - the player set for animating the removal is destroyed when setForMove is detected __and the trigger values are re-applied in the engine's statesByElement map__ resolves #29526 PR Close #44578 07 January 2022, 22:15:52 UTC
919f8ae Renovate Bot 07 January 2022, 06:08:16 UTC build: update dependency google-closure-compiler to v20220104 (#44655) PR Close #44655 07 January 2022, 19:16:52 UTC
63c8e56 Kristiyan Kostadinov 07 January 2022, 09:31:51 UTC fix(compiler-cli): incorrectly interpreting $any calls with a property read (#44657) This was flagged during the code review of #44580. When generating a type check block, we were interpreting any call to `$any` as an `as any` cast, even if it's part of a `PropertyRead` (e.g. `foo.$any(1)`). This is handled correctly in other parts of the compiler, but it looks like it was missed in the type checker. PR Close #44657 07 January 2022, 18:11:58 UTC
4de2b6d Dario Piotrowicz 27 December 2021, 16:54:27 UTC refactor(docs-infra): remove IE11 code (#44570) since IE11 is no longer a supported browser, remove angular.io code implemented specifically for IE11 support this change reverts the following PRs: - #26059 (slightly) - #28188 (fully) - #32871 (fully) - #41183 (partially) PR Close #44570 07 January 2022, 18:11:36 UTC
964a696 dario-piotrowicz 17 December 2021, 16:12:18 UTC refactor: fix various typos across different packages (#44523) simply fix different unrelated typos present in various packages PR Close #44523 07 January 2022, 18:11:11 UTC
1c8aecb alkavats1 06 January 2022, 19:13:25 UTC docs(common): use <em> instead of <i> in examples (#44648) Updated the html tag format from <i> to <em> in ts file. <em> tag helps to improve the code quality PR Close #44648 07 January 2022, 18:10:47 UTC
1028a4e Doug Parker 06 January 2022, 19:14:52 UTC refactor(compiler-cli): update template typechecking link to latest angular.io version (#44649) This page exists in the most recent angular.io version (v13 currently), so there's no need to link to an old version. The hash also refers to the title section of the page, which isn't necessary and is now dropped. PR Close #44649 07 January 2022, 18:10:19 UTC
d252cff Andrew Kushnir 08 December 2021, 01:51:26 UTC refactor(forms): use shared RuntimeError class (#44398) (#44652) This commit performs some refactoring of the AbstractControl-based classes to employ shared `RuntimeError` class and also updates the code to avoid duplication and improve minification. PR Close #44398 PR Close #44652 07 January 2022, 17:45:06 UTC
2453659 Andrew Kushnir 08 December 2021, 01:37:00 UTC refactor(core): move runtime error code logic (#44398) (#44652) This commit moves some logic to make the location of runtime error codes consistent across packages. Now all error codes are located in `packages/core/src/errors.ts` file. PR Close #44398 PR Close #44652 07 January 2022, 17:45:06 UTC
c4fbd85 Andrew Kushnir 08 December 2021, 01:24:46 UTC refactor(core): make RuntimeError reusable across packages (#44398) (#44652) This commit updates the code around the `RuntimeError` class to make it more reusable between packages (currently it's only usable inside the `core` package). Specifically: - the error formatting logic was updated to handle cases when there is no error message provided - there is no special Set that contains a set of error codes for which we have guides on angular.io. Instead, this is now encoded into the error code itself (making such codes negative integers). Having a separate Set makes it non-tree-shakable, which we want to avoid. This change should allow to employ the `RuntimeError` class in other packages to further standardize this subsystem and make the errors thrown by the framework consistent. As a part of the refactoring, the `common` package code was also updated to follow the same logic as `core`, since the `RuntimeError` class was used there as well. PR Close #44398 PR Close #44652 07 January 2022, 17:45:06 UTC
57d5f95 Andrew Kushnir 07 January 2022, 00:17:23 UTC build: use correct target name (#44651) Dev mode output was switched from ES5 -> ES2015 recently and as a part of those changes, some target names that contained `_es5` postfixes were changes to `_es2015` instead. This commit fixes the issue with one of the recently merged BUILD files that contained the old (`_es5`) postfix. PR Close #44651 07 January 2022, 00:42:22 UTC
2913b4c alkavats1 06 January 2022, 13:55:16 UTC docs(common): url link format updated (#44645) fix the url link format from http to https in BAZEL.md && component-styles.md PR Close #44645 06 January 2022, 23:49:47 UTC
6c15170 Joey Perrott 05 January 2022, 22:37:27 UTC build: update .bazelversion (#44641) Update to the latest version of bazel. PR Close #44641 06 January 2022, 23:49:02 UTC
a26afce JoostK 30 December 2021, 15:49:07 UTC fix(compiler-cli): fix crash during type-checking of library builds (#44587) When building a library, the `rootDir` option is configured to ensure that all source files are present within the entry-point that is being build. This imposes an extra constraint on the reference emit logic, which does not allow emitting a reference into a source file outside of this `rootDir`. During the generation of type-check blocks we used to make a best-effort estimation of whether a type reference can be emitted into the type-check file. This check was relaxed in #42492 to support emitting more syntax forms and type references, but this change did not consider the `rootDir` constraint that is present in library builds. As such, the compiler might conclude that a type reference is eligible for emit into the type-check file, whereas in practice this would cause a failure. This commit changes the best-effort estimation into a "preflight" reference emit that is fully accurate as to whether emitting a type reference is possible. Fixes #43624 PR Close #44587 06 January 2022, 23:44:24 UTC
d13e054 JoostK 29 December 2021, 22:30:53 UTC refactor(compiler-cli): implement `realpath` in `NgtscCompilerHost` (#44587) The `NgtscCompilerHost` is implemented using the `FileSystem` abstraction of the compiler, which is implemented for tests using an in-memory `MockFileSystem`. If the in-memory filesystem contains symlinks, then using `NgtscCompilerHost` would not reflect their resolved real path. Instead, the TypeScript compiler would use its default implementation based on the real filesystem, which is unaware of the in-memory `MockFileSystem` setup. This change does not currently address any issues, but is being fixed as it prevented a reproduction scenario from behaving correctly. PR Close #44587 06 January 2022, 23:44:24 UTC
9b19ba0 JoostK 29 December 2021, 22:20:45 UTC test(compiler-cli): properly support symlinks in `MockFileSystem` (#44587) This commit fixes an issue with symlink handling in `MockFileSystem`, where entries within a symlink would fail to resolve. PR Close #44587 06 January 2022, 23:44:24 UTC
c9eef5e JoostK 29 December 2021, 22:13:07 UTC refactor(compiler-cli): use `absoluteFromSourceFile` to obtain a source file path (#44587) Using `absoluteFromSourceFile` leverages the cache of the resolved absolute path, instead of having to compute it each time. PR Close #44587 06 January 2022, 23:44:24 UTC
3b7fe8b JoostK 29 December 2021, 22:11:18 UTC refactor(compiler-cli): improve DX for reference emit failures (#44587) In certain scenarios, the compiler may have crashed with an `Unable to write a reference` error which would be particularly hard to diagnose. One of the primary reasons for this failure is when the `rootDir` option is configured---typically the case for libraries--- and a source file is imported using a relative import from an external entry-point. This would normally report TS6059 for the invalid relative import, but the crash prevents this error from being surfaced. This commit refactors the reference emit logic to result in an explicit `Failure` state with a reason as to why the failure occurred. This state is then used to report a `FatalDiagnosticException`, preventing a hard crash. Closes #44414 PR Close #44587 06 January 2022, 23:44:24 UTC
5017bf9 Yuchao Wu 03 January 2022, 23:42:00 UTC docs(animations): fix grammar (#44607) Fix grammar issues based on suggestions in issue #44403 Fixes #44403 PR Close #44607 06 January 2022, 18:40:03 UTC
c0d3fbe shejialuo 06 January 2022, 01:48:53 UTC docs(docs-infra): improve the content of attribute directives (#44628) Improve docs "Understanding Angular-Directives-Attribute Directives" In `highlight.directive.1.ts`, add the `private` keyword for `el` property to make it correct and consistent with subsequent examples. For section "Setting the value with user input", add a step to tell the reader change the method `onMouseEnter`, thus more readable. For section "Binding to a second property", delete the aliase for the `Input` property, and changes the name back to `appHighlight` in the code to make it consistent with the whole tutorial. PR Close #44628 06 January 2022, 18:36:46 UTC
7130bff Kristiyan Kostadinov 25 December 2021, 08:22:06 UTC test: clean up more entryComponents usages (#44561) Cleans up some more tests that were using `entryComponents`. PR Close #44561 06 January 2022, 18:36:22 UTC
8b2536e Yousaf Nawaz 05 January 2022, 16:04:47 UTC docs: fix typos in using libraries guide (#44634) correct word typically, typescript and import PR Close #44634 06 January 2022, 00:23:06 UTC
9b9042c Dario Piotrowicz 01 January 2022, 13:11:47 UTC docs(animations): fix links to the AnimationBuilder.build method (#44594) In angular.io links to the AnimationBuilder.build method are broken and do not point to the api docs page, fix such broken links Also apply minor wording and related improvements PR Close #44594 06 January 2022, 00:22:43 UTC
98592b0 alkavats1 05 January 2022, 20:36:10 UTC docs(common): url link format updated (#44638) fix the url link format from http to https in i18-common-locale-id.md file PR Close #44638 05 January 2022, 23:21:11 UTC
7dc6802 Kristiyan Kostadinov 04 January 2022, 20:52:14 UTC test(upgrade): fix flaky tests (#44597) Fixes a couple of tests that have been flaking our test runs. The two tests actually failed consistently when run in isolation, but they passed if at least one test ran before them. My understanding was that they failed, because they were running outside of the `NgZone` which meant that the errors being thrown inside of a `Promise` weren't being flushed. PR Close #44597 05 January 2022, 23:20:43 UTC
6279e0a Paul Gschwendtner 17 December 2021, 18:26:47 UTC ci: temporarily disable components-repo-unit-tests job (#44505) Temporarily disables the components repo unit tests job that breaks due to us changing the devmode output to ES2015 in Angular Bazel. This is a trivial thing to solve in the COMP repo but the job needs to be disabled first, so that the changes can be released. PR Close #44505 05 January 2022, 23:20:21 UTC
d908761 Paul Gschwendtner 17 December 2021, 18:26:09 UTC test: update example di tests to work with es2015 (#44505) * `forwardRef` does not work with ES2015 and TypeScript's decorator downlevel emit. This is a known limitation we work around in Angular applications by either compiling tests with the Angular compiler, or by running a custom decorator downlevel transform (like in the CLI). PR Close #44505 05 January 2022, 23:20:21 UTC
b734ceb Paul Gschwendtner 17 December 2021, 18:25:48 UTC test: update acceptance core tests to work with es2015 (#44505) Updates the acceptance core tests to work with ES2015 devmode output. There were two issues surfacing: * The NodeJS test execution failed because Domino does not handle destructuring syntax properly. This is because `Node.children` is not an iterable. * `forwardRef` does not work with ES2015 and TypeScript's decorator downlevel emit. This is a known limitation we work around in Angular applications by either compiling tests with the Angular compiler, or by running a custom decorator downlevel transform (like in the CLI). PR Close #44505 05 January 2022, 23:20:21 UTC
cefe9f0 Paul Gschwendtner 16 December 2021, 20:23:55 UTC test: update router tests to work with es2015 temporal dead zone (#44505) Update router tests to work with the the es2015 temporal dead zone. Somewhat similar to: https://github.com/angular/angular/issues/30106. PR Close #44505 05 January 2022, 23:20:21 UTC
5fa2c88 Paul Gschwendtner 16 December 2021, 15:32:32 UTC test: update ngtsc specs to work with es2015 output (#44505) Updates the ngtsc specs to work with ES2015 output. PR Close #44505 05 January 2022, 23:20:21 UTC
7b78256 Paul Gschwendtner 16 December 2021, 13:11:53 UTC build: switch devmode output to es2015 (#44505) To make our test output i.e. devmode output more aligned with what we produce in the NPM packages, or to be more aligned with what Angular applications will usually consume, the devmode output is switched from ES5 to ES2015. Additionally various tsconfigs (outside of Bazel) have been updated to match with the other parts of the build. The rules are: ES2015 for test configurations, ES2020 for actual code that will end up being shipped (this includes the IDE-only tsconfigs). PR Close #44505 05 January 2022, 23:20:21 UTC
0daa9bf Andrew Kushnir 15 December 2021, 23:10:33 UTC refactor(forms): make validators code compatible with property renaming (#44500) This commit refactors the code of the base validators class to make it compatible with the property renaming optimization. Currently the code makes an assumption that the field with a specified name (defined as a string) can be found on an object, but with property renaming optimization this is not correct. PR Close #44500 05 January 2022, 18:43:37 UTC
426b6f9 Chris Mancini 05 January 2022, 16:42:24 UTC docs(router): fix code block for IsActiveMatchOptions (#44635) PR Close #44635 05 January 2022, 17:47:08 UTC
6c5d73e Dario Piotrowicz 21 December 2021, 21:24:18 UTC docs(animations): fix filter-animations docregion (#44544) the filter animation example in the complex-animation-sequences guide talks about entering and leaving elements, but the presented html snipped exluded the *ngFor which actually adds and removes the elements, so add the *ngFor section to make the example complete and understandable PR Close #44544 05 January 2022, 17:46:11 UTC
0ac4c0b JoostK 08 December 2021, 21:49:43 UTC refactor(compiler): remove output AST functions (#44411) These functions are not used anymore so they are removed. PR Close #44411 04 January 2022, 23:54:12 UTC
07b8e56 JoostK 08 December 2021, 21:47:36 UTC refactor(compiler): remove class related output AST types (#44411) The Ivy compiler no longer generates classes so this commit removes the supporting output nodes. PR Close #44411 04 January 2022, 23:54:11 UTC
5f78f55 JoostK 08 December 2021, 21:42:12 UTC refactor(compiler): remove type-casting related output AST types (#44411) The Ivy compiler no longer generates code for type-checking purposes using the output AST types. Instead, it uses TypeScript AST nodes and its printer for type-checking. This commit removes the type-related output nodes. PR Close #44411 04 January 2022, 23:54:11 UTC
4688a18 JoostK 08 December 2021, 21:33:57 UTC refactor(compiler): remove some unused output AST types (#44411) This kind of output is no longer emitted into generated code, so the supporting output AST is removed. PR Close #44411 04 January 2022, 23:54:11 UTC
d7faf22 JoostK 08 December 2021, 21:18:31 UTC refactor(compiler): remove unused method from binding parser (#44411) This method is no longer called so is being removed. PR Close #44411 04 January 2022, 23:54:11 UTC
6f70524 JoostK 08 December 2021, 21:17:42 UTC refactor(compiler): make template preparser null-safe (#44411) This commit removes some non-null assertion operations to improve null-safety. PR Close #44411 04 January 2022, 23:54:11 UTC
94f34e0 JoostK 08 December 2021, 21:14:32 UTC refactor(compiler): remove unused `unsupported` function (#44411) This function is no longer used so is being removed. PR Close #44411 04 January 2022, 23:54:11 UTC
db48082 JoostK 08 December 2021, 21:07:52 UTC refactor(compiler): make `keySpan` required in binding parser (#44411) Now that ViewEngine has been removed the `keySpan` property can be made required, as it is always provided in the Ivy compiler PR Close #44411 04 January 2022, 23:54:11 UTC
9ef9b88 JoostK 08 December 2021, 20:55:14 UTC refactor(compiler): cleanup distinction in parse logic (#44411) This removes the special casing of parse-validation logic that was only used by Ivy. PR Close #44411 04 January 2022, 23:54:11 UTC
bbc368c JoostK 08 December 2021, 20:47:58 UTC refactor(compiler): remove `BindingForm` enum (#44411) The Ivy compiler only uses `BindingForm.Expression`, so all other variants are removed. PR Close #44411 04 January 2022, 23:54:11 UTC
5fdc660 JoostK 08 December 2021, 20:44:56 UTC refactor(compiler): cleanup AST fixup of listener instructions (#44411) This commit refactors the generation of listener instructions to no longer fixup the output AST that was designed for ViewEngine. PR Close #44411 04 January 2022, 23:54:11 UTC
4f40266 JoostK 08 December 2021, 18:48:00 UTC refactor(compiler): remove unused assertion function (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:11 UTC
c359381 JoostK 08 December 2021, 18:45:59 UTC refactor(compiler): cleanup unsafe usage of `null` value for ng-content selector (#44411) This commit improves the null-safety of the ng-content selector and updates a comment that turned out to be slightly inaccurate. Closes #38407 PR Close #44411 04 January 2022, 23:54:11 UTC
63c5a18 JoostK 08 December 2021, 18:35:18 UTC refactor(compiler): remove unused code from output logic (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:11 UTC
9103b74 JoostK 08 December 2021, 18:26:36 UTC refactor(compiler): remove unused `AstPath` (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:11 UTC
75f7864 JoostK 01 December 2021, 23:35:54 UTC refactor(compiler): remove unused logic from `ConstantPool` (#44411) The `ConstantPool.getDefinition` method is not being used anymore, so this commit removes anything that is related to this method. PR Close #44411 04 January 2022, 23:54:11 UTC
59cd255 JoostK 08 December 2021, 18:24:36 UTC refactor(compiler): remove unused type declarations (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:10 UTC
9c76560 JoostK 08 December 2021, 18:17:57 UTC refactor(compiler): remove syntax error logic (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:10 UTC
db76891 dario-piotrowicz 15 December 2021, 13:39:15 UTC refactor(animations): add unit test for leaving animated child (#44489) add a new unit test to make sure that leaving elements queried via a parent queried via animateChild are correctly removed note: this tests the fix introduced in PR #44357 PR Close #44489 04 January 2022, 23:53:36 UTC
a6d12ef Andrew Kushnir 04 January 2022, 19:03:43 UTC test: remove newlines to make a test more stable (#44616) One of the tests was not taking into account newlines in the text content of an element, thus failing in some browsers. This commit makes the test more stable by removing newlines and comparing the output after that. PR Close #44616 04 January 2022, 23:53:00 UTC
25aef62 dario-piotrowicz 13 December 2021, 22:46:40 UTC fix(docs-infra): adjust code link styling height (#44376) the height of code links (anchors inside code tags or code tags inside anchors) is inconsistent, fix such issue by also making sure that code links to external resources do not get wrongly styled PR Close #44376 04 January 2022, 20:19:09 UTC
55209e5 dario-piotrowicz 04 December 2021, 13:48:11 UTC docs(animations): add links to `state()` references (#44376) the keyword 'state' is included in the `ignoredWords` set that prevents certain words to be autolinked, this causes the animations' state function not to be automatically linked, so manually link those references to the state api docs PR Close #44376 04 January 2022, 20:19:09 UTC
0be1a82 Abdurrahman Abu-Hijleh 16 December 2021, 21:56:42 UTC docs: fix code sample indentation (#44517) PR Close #44517 04 January 2022, 20:15:55 UTC
d389bb8 AlirezaEbrahimkhani 30 December 2021, 14:25:41 UTC docs: fix ngOnChange description issue (#44582) ngOnChange respond when Angular sets or resets data-bound @input properties and description of the ngOnChanges should be `When an [input](#input) binding value changes` instead of `When an [input](#input)/[output](#output) binding value changes` resolves angular#44559 PR Close #44582 04 January 2022, 20:15:19 UTC
77562f9 huangqing 15 December 2021, 07:16:45 UTC docs: Replace OnInit with AfterViewInit (#44485) `this.adHost` is undefined if loadComponent is called in OnInit. So replace OnInit with AfterViewInit! PR Close #44485 04 January 2022, 20:14:45 UTC
46c6f20 Paul Gschwendtner 15 December 2021, 18:31:20 UTC test: update size goldens to reflect latest CLI devkit update (#44490) Updates the size goldens to the reflect the latest CLI devkit updates. PR Close #44490 04 January 2022, 20:14:15 UTC
4765bf1 Paul Gschwendtner 15 December 2021, 15:34:07 UTC build: update release config to reflect latest ng-dev config changes (#44490) The ng-dev release config changed its release configuration in order to support experimental packages. This commit updates the FW release config to work with the new config signature of ng-dev. All of our peackages are non-experimental, so we do not specify an explicit `experimental` property. PR Close #44490 04 January 2022, 20:14:15 UTC
back to top