Skip to main content

Browse the archive

https://github.com/angular/angular
01 September 2024, 02:13:37 UTC
sort by:
Revision Author Date Message Commit Date
2ea541f Dylan Hunn 20 April 2022, 21:29:50 UTC release: cut the v13.3.4 release (#45702) PR Close #45702 20 April 2022, 21:31:12 UTC
dd7eeb6 Andrew Kushnir 20 April 2022, 04:51:14 UTC fix(docs-infra): avoid internal symbols from being referenced during auto-linking (#45689) This commit adds extra logic to avoid internal and privately exported symbols from being referenced during auto-linking. Currently such symbols can be used for linking, thus resulting in a non-existing link and causing the linking process to fail. PR Close #45689 20 April 2022, 16:11:22 UTC
1d204fc Paul Gschwendtner 20 April 2022, 07:42:27 UTC Revert "test(common): Fix flaky Location test (#45683)" (#45691) This reverts commit 254d6cea9a662dabf74058cc991bdc965db94295. This test has only been introduced in the next branch with https://github.com/angular/angular/pull/44901. The cherry-pick of the flaky test fix does not work in the patch branch due to some other missing changes and the test did not exist in 13.3.x anyway. PR Close #45691 20 April 2022, 15:58:46 UTC
7619c16 Paul Gschwendtner 19 April 2022, 15:48:25 UTC build: preparation for primary branch rename in the Angular repos (#45691) Preparation for the framework repo as outlined our planning document. PR Close #45691 20 April 2022, 15:58:46 UTC
52a564d Mangalraj 15 April 2022, 23:06:51 UTC docs: Update aio/content/guide/setup-local.md (#45644) Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> PR Close #45644 20 April 2022, 03:20:40 UTC
bb7b51b Mangalraj 14 April 2022, 23:52:52 UTC docs: correct the example command to install angular (#45644) PR Close #45644 20 April 2022, 03:20:40 UTC
254d6ce Andrew Scott 19 April 2022, 20:15:06 UTC test(common): Fix flaky Location test (#45683) This test has proven to be flaky. This commit greatly simplifies the test and moves it to a more appropriate location (pun intended). PR Close #45683 20 April 2022, 03:17:56 UTC
1e8fe84 Saurabh Kamble 19 April 2022, 15:16:53 UTC Fix typo (#45680) PR Close #45680 19 April 2022, 16:26:14 UTC
22ef5e0 George Kalpakas 17 April 2022, 09:12:20 UTC docs(common): fix links to locales in i18n guides (#45661) In PR #42230, the locale file generation process was modified so that generated locale files are no longer checked into the repository. Update a few links in the docs that pointed to the previously checked in files to point to other places where the files exist. PR Close #45661 19 April 2022, 16:17:34 UTC
c4e1d45 Jeremy Elbourn 18 April 2022, 16:29:19 UTC build: don't assign jelbourn to most review categories (#45668) Configure pullapprove to not automatically assign jelbourn to most review categories. PR Close #45668 19 April 2022, 16:15:40 UTC
d5a522a Louis Gombert 18 April 2022, 14:59:00 UTC docs: update decorators proposal stage and link in glossary (#45669) PR Close #45669 19 April 2022, 16:14:37 UTC
ed832b4 Andrew Kushnir 18 April 2022, 17:39:41 UTC test: reset counters before running a styling test (#45670) This commit updates one of the styling tests to reset perf counters, making it order-independent and non-flaky (previously the test got random failures depending on whether there are other tests invoked before). PR Close #45670 19 April 2022, 16:14:10 UTC
ebf98c4 Marko Kaznovac 18 April 2022, 09:38:36 UTC docs: use language agnostic mdn urls (#45666) PR Close #45666 18 April 2022, 21:10:17 UTC
ac8c896 Marko Kaznovac 18 April 2022, 09:34:46 UTC docs: fix mdn links (#45666) PR Close #45666 18 April 2022, 21:10:17 UTC
37b3ac7 dario-piotrowicz 06 February 2022, 18:03:25 UTC fix(docs-infra): implement focus trap for aio search results (#45654) currently if a user tries to navigate via keyboard, once the are presented with search results, the search results panel remains present and can potentially hide most of the content on the page, in such case keyboard navigation will be severly hindered and the only option for the user would be to go back to the seach input text and clear its value, fix such inconvenience by looping the focus in the header area close to the search results and the results panel itself note: an alternative implementation using the cdkTrapFocus has been attempted in PR #45194, such alternative implementation presented a number of (minor) drawbacks (including the increase main bundle size due to the inclusion of the A11yModule), so it was agreed to proceed with the manual implementation present in these changes instead. PR Close #45654 18 April 2022, 16:57:53 UTC
b5820b6 dario-piotrowicz 12 April 2022, 20:08:51 UTC fix(docs-infra): fix aio search-results issue with toolbar and notification (#45579) (#45654) use border-top-width instead of padding-top as the strategy for moving the search-results panel down, this fixes the issue of the panel going behind the toolbar (which causes either overlapping text in the home page or the results scrollbar to be hidden behind the toolbar in other pages) PR Close #45579 PR Close #45654 18 April 2022, 16:57:53 UTC
26fe764 dario-piotrowicz 11 April 2022, 19:02:08 UTC fix(docs-infra): amend notification close button aria-label (#45579) (#45654) move the aria-label used inside the close-button to the button itself (since otherwise the button's aria-label overrides the childs) PR Close #45579 PR Close #45654 18 April 2022, 16:57:53 UTC
1564771 dario-piotrowicz 09 April 2022, 19:33:44 UTC feat(docs-infra): add close button to search-results aio panel (#45579) (#45654) add a close button to the search-results aio panel so that the user can conveniently close it via keyboard this complements the focus trap implemented in PR #44989 (more here: https://github.com/angular/angular/pull/44989#issuecomment-1037287678) PR Close #45579 PR Close #45654 18 April 2022, 16:57:53 UTC
989ba8f Andrew Kushnir 15 April 2022, 20:03:10 UTC ci: add more reviewers to the `docs-packaging-and-releasing` group (#45652) Currently that group has just 2 reviewers, but we often update the files that belong to that group during the deprecation period. Adding more people would allow to balance the reviews better. PR Close #45652 18 April 2022, 16:24:59 UTC
9317f51 Kristiyan Kostadinov 16 April 2022, 05:13:37 UTC fix(core): better error message when directive extends a component (#45658) We throw an error when a directive is trying to extend a component, but we don't actually say which class is responsible which can be difficult to track down. These changes add the two class names to the error message. PR Close #45658 18 April 2022, 16:24:24 UTC
d68333e ivanwonder 10 April 2022, 14:46:16 UTC fix(language-service): two-way binding completion should not remove the trailing quote (#45582) We allow the path to contain both the `t.BoundAttribute` and `t.BoundEvent` for two-way bindings but do not want the path to contain both the `t.BoundAttribute` with its children when the position is in the value span because we would then logically create a path that also contains the `PropertyWrite` from the `t.BoundEvent`. This early return condition ensures we target just `t.BoundAttribute` for this case and exclude `t.BoundEvent` children. Fixes https://github.com/angular/vscode-ng-language-service/issues/1626 PR Close #45582 15 April 2022, 20:53:49 UTC
4766817 Andrew Kushnir 15 April 2022, 02:10:43 UTC fix(core): improve multiple components match error (#45645) This commit improves the error message that is thrown at runtime when multiple components match the same element. Now the error message contains names of classes that represent those components. PR Close #45645 15 April 2022, 20:52:20 UTC
575cafc Andrew Kushnir 15 April 2022, 18:20:52 UTC test(core): add a test for multiple named interpolations with the same name (#45651) The test from this commit verifies that i18n logic can handle multiple named interpolations with the same name. PR Close #45651 15 April 2022, 20:51:56 UTC
acbd2e9 Ilya Marchik 14 April 2022, 16:46:41 UTC docs: fix typo (#45637) Replace wrong mention of 'heroService.delete()' with 'heroService.deleteHero()' because 'heroService.delete()' doesn't exist and 'heroService.deleteHero()' should be mentioned instead Resolves #45636 PR Close #45637 14 April 2022, 23:30:05 UTC
a1c7418 Andrew Kushnir 14 April 2022, 20:50:33 UTC docs: move old changelog entries to a separate file (#45639) This commit moves all release notes for everything before v11.0.0 to a separate file, so that the changelog can be rendered correctly via GitHub UI. Closes #45635. PR Close #45639 14 April 2022, 22:01:49 UTC
8d09451 George Kalpakas 14 April 2022, 08:20:29 UTC docs(core): fix typo in View Encapsulation code example (#45629) Fix closing tag name to match opening one (`</hero-detail>` --> `<hero-details>`). PR Close #45629 14 April 2022, 22:00:06 UTC
ec115a3 Andrew Kushnir 04 April 2022, 05:40:57 UTC refactor(core): avoid referencing `PlatformRef` in bootstrap code (#45519) This commit updates an existing bootstrap logic to avoid referencing the `PlatformRef` instance to keep track of the platform status. Instead, we use platform injector, so that the `PlatformRef`can be tree-shaken away in the bootstrap logic for Standalone Components. The motivation for this change is that retaining the `PlatformRef` class also retains NgModule-based bootstrap code, which would not be needed in case of Standalone Components. PR Close #45519 13 April 2022, 22:34:48 UTC
cbfe628 Jessica Janiuk 13 April 2022, 18:27:48 UTC release: cut the v13.3.3 release (#45614) 13 April 2022, 18:27:48 UTC
e50fd9e Kristiyan Kostadinov 09 April 2022, 14:26:47 UTC fix(compiler): avoid errors with extremely long instruction chains (#45574) Our logic for generating code from an AST uses recursion which limits the number of expressions we can nest before we reach the call stack limit. These changes add a limit in order to avoid errors in some cases where the chains become extremely long. Fixes #45564. PR Close #45574 13 April 2022, 16:18:56 UTC
5fe5970 4javier 12 April 2022, 23:23:33 UTC docs: fix grammar (#45455) PR Close #45455 12 April 2022, 23:55:33 UTC
cfb54c6 4javier 12 April 2022, 11:24:53 UTC docs: fix to comply with new codeblock guidelines (#45455) PR Close #45455 12 April 2022, 23:55:33 UTC
1426801 4javier 11 April 2022, 19:32:40 UTC docs: modified as per dylhunn suggestions (#45455) https://github.com/angular/angular/pull/45455#pullrequestreview-925369970 PR Close #45455 12 April 2022, 23:55:32 UTC
db7201f 4javier 26 March 2022, 22:51:34 UTC docs: update template reference variables (#45455) - Specify `NgForm` gets applied by default on `<form>` elements before the long example using it - Move the strange (and questioned in a commented line) snippet about undefined ref vars in a standalone paragraph and clarify its meanings (adding the part about directive just because there was something similar already there) - Extend and modify `*ngFor` example, since in the original that was misleading to think reference variable couldn't be used inside a loop - Remove two lines stating that with `*ngIf` and `*ngFor` the framework cannot know if a template is ever instantiated (can't see how this relate with the page) - Add an explanation of assignment of default `$implicit` value to undefined input variables - Modify template example for template input variable to be a complete ngForOf loop instead of the original poor intelligible truncated one - Replace last generic statements about variable namespaces with a more pragmatic and explanatory one concerning the resolution in case of homonymy PR Close #45455 12 April 2022, 23:55:32 UTC
fc145d0 Andrew Kushnir 02 April 2022, 01:50:13 UTC refactor(core): make ComponentFactoryResolver lazily instantiated in ApplicationRef (#45507) This commit removes the `ComponentFactoryResolver` as a constructor argument of the `ApplicationRef` class. This makes it lazily instantiated + simplifies further refactoring in a context of Standalone Components. PR Close #45507 12 April 2022, 22:29:17 UTC
44b9d89 Andrew Kushnir 02 April 2022, 01:36:12 UTC refactor(core): make platform core providers tree-shakable (#45506) This commit refactors the set of hardcoded platform core providers into tree-shakable providers. In addition to making them tree-shakable, this would also avoid the need to rely on the platform creation logic in an upcoming bootstrap logic for Standalone Components. PR Close #45506 12 April 2022, 22:28:24 UTC
ae1db7a Jason Hendee 12 April 2022, 18:48:39 UTC docs: make tutorial instructions consistent (#45372) When starting this tutorial, it's not clear to the user whether they should add routing right away, Etc. The other tutorials within the routing section do a better job of this. Also.. the suggested name of this sample app clashes with that of a previous tutorial, forcing the user to either delete the previous tutorial files, choose a different name for this tutorial's app, or place this app in a different parent directory. Conflicts: aio/content/guide/router-tutorial-toh.md PR Close #45372 12 April 2022, 22:27:38 UTC
5c9fe8d Dylan Hunn 12 April 2022, 21:43:02 UTC build: only allow renovate to run on Monday nights (#45605) By running renovate once a week, we can consolidate all the updates into a single weekly PR, before each Wednesday release. That will significantly reduce the burden on caretakers, and make patch ports less onerous. PR Close #45605 12 April 2022, 22:26:49 UTC
c49d232 Virginia Dooley 01 April 2022, 23:51:25 UTC docs: new Pipes custom data doc (#45505) PR Close #45505 12 April 2022, 21:29:07 UTC
24212cd Virginia Dooley 10 February 2022, 19:27:06 UTC docs: pipes custom data transform (#45505) PR Close #45505 12 April 2022, 21:29:07 UTC
d5b7c96 4javier 12 April 2022, 21:00:54 UTC docs: fix path typo (#45604) PR Close #45604 12 April 2022, 21:27:49 UTC
ddd822f 4javier 12 April 2022, 20:18:35 UTC docs: fix final code review section codetabs path (#45604) Fix paths for codetabs in final review section messed up by this commit https://github.com/angular/angular/commit/42289f25c69ec7a36d2e3ef424d32f77bc7cd19a They were all pointing to `heroes-search.component` PR Close #45604 12 April 2022, 21:27:49 UTC
d31f4de Michael-Doner 09 April 2022, 17:06:41 UTC docs: add powershell execution policies note (#45576) Fixes #44598 PR Close #45576 12 April 2022, 21:13:59 UTC
5900f0e George Kalpakas 12 April 2022, 09:01:40 UTC docs(docs-infra): add missing period in `aio/README.md` (#45584) PR Close #45584 12 April 2022, 18:40:46 UTC
6189457 Joe Martin (Crowdstaffing) 11 April 2022, 18:32:21 UTC docs: improve markdown (#45590) improve markdown for documentation. Duplicate of #45325 that targets 13.3.x. PR Close #45590 11 April 2022, 22:35:01 UTC
09c5c18 Renovate Bot 09 April 2022, 06:04:31 UTC build: update dependency google-closure-compiler to v20220405 (#45568) PR Close #45568 11 April 2022, 16:26:26 UTC
f09d166 Michal Materowski 09 April 2022, 11:41:26 UTC build: fix typo in package.json file comment (#45569) Change comment in scripts section of package.json PR Close #45569 11 April 2022, 16:14:16 UTC
1b2c67d George Kalpakas 06 April 2022, 16:10:05 UTC test(docs-infra): fix e2e test for `{@example}` dgeni tags (#45551) (#45563) Previously, the `guide/compoent-style` page was used in e2e tests to verify the behavior of `{@example}` dgeni tags. However, this guide has been updated and no longer contains an `{@example}` tag. This commit switches to using a different page (`api/common/NgIf`) that does currently contain an `{@example}` tag. (NOTE: This will also fix the [CI failures][1] in #45501.) [1]: https://circleci.com/gh/angular/angular/1145424 PR Close #45551 PR Close #45563 08 April 2022, 15:55:25 UTC
2144b99 George Kalpakas 06 April 2022, 16:03:35 UTC fix(docs-infra): add `shell` to the list of code-example languages recognized as cli commands (#45551) (#45563) Previously, only `language="sh"` and `language="bash"` would be recognized (and formatted) as cli commands in `<code-example>`. This commit adds `shell` to the list of languages recognized as cli commands. (NOTE: This will fix the [CI failures][1] in #45325.) [1]: https://circleci.com/gh/angular/angular/1145559 PR Close #45551 PR Close #45563 08 April 2022, 15:55:24 UTC
208d819 Cédric Exbrayat 31 March 2022, 08:13:23 UTC refactor(core): validate property (#45528) Simplifies and documents the `validateProperty` function (in a similar fashion that #45492 simplified `validateElementIsKnown`). PR Close #45528 07 April 2022, 22:03:13 UTC
18f98e6 George Kalpakas 06 April 2022, 17:17:00 UTC docs: remove out-of-order `<h3>` elements from footer (#45510) The footer uses `h3` elements out of order, which causes a "Heading elements are not in a sequentially-descending order" a11y error. Replace the `h3` elements with `div` to improve a11y. Fixes #44338 PR Close #45510 07 April 2022, 21:01:58 UTC
dbd6e75 Hossein Mousavi 05 April 2022, 18:33:08 UTC docs(forms): remove the incorrect set value from previous commit (#45533) in the validators documentation, the value for the formControl for both required and requiredTrue validators is an empty string. This is OK for required since it gives us an error. But I think if we set the value of formControl responsible for requiredTrue to something other than an empty string (e.g.: 'some value'), it would demonstrate the difference between required and requiredTrue better. PR Close #45533 07 April 2022, 21:00:26 UTC
6a5ee68 Hossein Mousavi 05 April 2022, 18:26:09 UTC docs(forms): add value to formControl for better demonstration of requiredTrue validator (#45533) in the validators documentation, the value for the formControl for both required and requiredTrue validators is an empty string. This is OK for required since it gives us an error. But I think if we set the value of formControl responsible for requiredTrue to something other than an empty string (e.g.: 'some value'), it would demonstrate the difference between required and requiredTrue better. PR Close #45533 07 April 2022, 21:00:26 UTC
fb5e16e Andrew Kushnir 06 April 2022, 15:47:13 UTC release: cut the v13.3.2 release (#45548) 06 April 2022, 15:47:13 UTC
05121c0 Andrew Kushnir 05 April 2022, 16:07:03 UTC test(animations): update test to use an object instead of a Map (#45531) The code in the patch branch is slightly different from the master branch: the master branch contains some changes where Map are used instead of objects in animations. As a result, one of the tests is failing in patch, since it expects Maps, but receives objects. PR Close #45531 05 April 2022, 17:31:48 UTC
a92bced Christoph Guttandin 23 February 2022, 18:26:22 UTC test(animations): add test for buildAnimationAst() function (#31107) This commit adds a test for the buildAnimationAst() function. PR Close #31107 05 April 2022, 15:41:40 UTC
b46b25c Christoph Guttandin 18 June 2019, 14:50:59 UTC fix(animations): handle structured AnimateTimings (#31107) This commit makes sure structured AnimateTimings are not procesed any further when building the AST. Fixes: #22752 PR Close #31107 05 April 2022, 15:41:40 UTC
fc86fe5 Renovate Bot 02 April 2022, 06:18:01 UTC build: update dependency entities to v4 (#45509) PR Close #45509 04 April 2022, 21:54:17 UTC
9fcc1b7 Cédric Exbrayat 31 March 2022, 07:46:12 UTC refactor(core): validate element is known in JIT mode (#45492) Renames, simplifies and documents the function in charge of validating if an element is known in JIT mode. PR Close #45492 04 April 2022, 16:34:42 UTC
ca7a143 Alan Agius 01 April 2022, 12:02:26 UTC fix(docs-infra): update Angular packages to latest minor version (#45502) This is needed because Angular CLI 13.3 contains fixes that are needed for Stackblitz Node 16 to compile Sass. We also added `copyfiles` in `aio/tools/examples/shared/package.json` as `yarn sync-deps` was failing due to the missing dependency. PR Close #45502 04 April 2022, 16:23:55 UTC
5db99ca piyush132000 31 March 2022, 02:40:24 UTC docs: add animations to readme file (#45488) Updated readme file for adding animations topic in advance topics of Angular PR Close #45488 04 April 2022, 16:17:50 UTC
a3d9c82 mgechev 31 March 2022, 23:43:25 UTC docs: change roadmap updated date (#45500) PR Close #45500 01 April 2022, 20:33:08 UTC
c21b68d mgechev 31 March 2022, 23:41:49 UTC docs: add details about ssr efforts (#45500) PR Close #45500 01 April 2022, 20:33:08 UTC
9c9a525 Dylan Hunn 30 March 2022, 21:20:54 UTC release: cut the v13.3.1 release (#45485) PR Close #45485 30 March 2022, 21:21:53 UTC
7f53c0f JoostK 26 March 2022, 21:51:55 UTC fix(compiler-cli): handle inline type-check blocks in nullish coalescing extended check (#45478) This commit fixes an inconsistency where a type check location for an inline type check block would be interpreted to occur in a type-checking shim instead. This resulted in a missing template mapping, causing a crash due to an unsafe non-null assertion operator. In the prior commit the `TcbLocation` has been extended with an `isShimFile` field that is now being used to look for the template mapping in the correct location. Additionally, the non-null assertion operator is refactored such that a missing template mapping will now ignore the warning instead of crashing the compiler. Fixes #45413 PR Close #45478 30 March 2022, 18:34:41 UTC
3f55567 JoostK 26 March 2022, 21:23:28 UTC refactor(compiler-cli): track whether a `TcbPosition` corresponds with a shim file (#45478) Extends `TcbPosition` with a field that indicates whether the `tcbPath` is a type-checking shim file, or an original source file with an inline type check block. This field is used in an upcoming commit that fixes an inconsistency with how inline type check blocks are incorrectly interpreted as a type-checking shim file instead. PR Close #45478 30 March 2022, 18:34:41 UTC
fa90c74 JoostK 26 March 2022, 21:10:33 UTC refactor(compiler-cli): rename `ShimLocation` to `TcbLocation` (#45478) Inline type check blocks (TCBs) are emitted into the original source file, but node positions would still be represented as a `ShimLocation` with a `shimPath` corresponding with the type-checking shim file. This results in inconsistencies, as the `positionInShimFile` field of `ShimLocation` would not correspond with the `shimPath` of that `ShimLocation`. This commit is a precursor to letting `ShimLocation` also represent the correct location for inline type check blocks, by renaming the interface to `TcbLocation`. A followup commit addresses the actual inconsistency. PR Close #45478 30 March 2022, 18:34:41 UTC
09f8883 JoostK 30 March 2022, 17:43:22 UTC test: update size golden to account for backport conflict (#45480) The backport in #45473 introduced a change in payload sizes that is not met on the 13.3.x branch, this commit corrects this issue. PR Close #45480 30 March 2022, 18:34:10 UTC
7ab7734 AlirezaEbrahimkhani 25 March 2022, 13:11:33 UTC docs: add Angular university website to resources list (#45437) PR Close #45437 30 March 2022, 00:13:09 UTC
5061c4d Willian Corrêa 18 February 2022, 10:15:53 UTC Update aio/content/marketing/resources.json (#45076) Co-authored-by: Alan Agius <alan.agius4@gmail.com> PR Close #45076 30 March 2022, 00:11:55 UTC
3b22121 Willian Corrêa 14 February 2022, 13:15:59 UTC docs: add Rangle's Angular Training book (#45076) PR Close #45076 30 March 2022, 00:11:55 UTC
9c03b63 Andrew Kushnir 29 March 2022, 23:27:15 UTC docs: adding a missing close tag in AIO template (#45474) Commit 6e45777f01373304b9bcfe076ffd5585704444fe introduced a change where 1 closing tag was accidentally removed. This commit adds that tag back. PR Close #45474 29 March 2022, 23:46:24 UTC
6e45777 Dylan Hunn 29 March 2022, 22:30:18 UTC docs: patch port of #45376 (#45473) PR Close #45473 29 March 2022, 22:36:17 UTC
70006da Paul Gschwendtner 29 March 2022, 19:50:26 UTC test: update aio payload size golden to reflect Angular update (#45469) Updates the AIO payload size goldens to reflect the Angular update affecting both the `aio` and `aio_local` build (due to CLI devkit changes affecting both goldens, and the Angular update also affecting the non-local `aio` build / job). Patch-port of 6e1fce529a5ebf6c6e8beb84d22574bfd443bc8c Aside from AIO, the forms integration test size golden also needs to be updated. A zonejs change caused the 500 bytes limit to be exceeded. The change landed in `master` without exceeding, but exceeded in the `13.3.x` branch (unrelated to the Angular update). Manually confirmed by diffing the bundles that this change is the culprit. https://github.com/angular/angular/commit/c08705899f538bd2d26475c94c2832631c16977b PR Close #45469 29 March 2022, 20:13:08 UTC
6353948 Paul Gschwendtner 28 March 2022, 15:05:06 UTC test: update api goldens to reflect api-golden bazel rule change (#45469) The API golden Bazel rule has changed in the shared dev-infra code. Instead of putting golden API reports into the golden folder as per their original location in the NPM package, golden reports are now stored based on the package exports. This makes it more obvious how entry-points are consumable As part of this change, since the API golden rule now consutls the NPM package `exports` field, the `localize/tools` entry-point golden file is now generated. Previously it wasn't generated due to it not having a secondary entry-point `package.json` file. Such package json files should not be needed anymore and will be gone in future APF versions. PR Close #45469 29 March 2022, 20:13:08 UTC
f7c9ac1 Renovate Bot 28 March 2022, 13:20:28 UTC build: update angular (#45469) PR Close #45469 29 March 2022, 20:13:08 UTC
7bbf009 dario-piotrowicz 16 March 2022, 21:51:56 UTC fix(docs-infra): update a11y min-scores (#45209) update (decrease) the value of some of the accessibility MIN_SCORES_PER_PAGE after recent changes PR Close #45209 29 March 2022, 16:23:14 UTC
0b96c37 dario-piotrowicz 16 March 2022, 21:47:16 UTC fix(docs-infra): assign different aria labels to main aio navs (#45209) assign different aria labels to the primary nav and the one used for guides and docs, so that impaired users can more easily distinguish the two PR Close #45209 29 March 2022, 16:23:14 UTC
9a82067 dario-piotrowicz 16 March 2022, 21:44:05 UTC fix(docs-infra): remove redundant main roles (#45209) remove redundant main role as pages should always have a single element with a main role (also remove the role assigne to the main tag as that is implied) PR Close #45209 29 March 2022, 16:23:14 UTC
14cabb0 dario-piotrowicz 16 March 2022, 21:41:07 UTC fix(docs-infra): wrap the main aio mat-toolbar in a header (#45209) wrap the main aio mat-toolbar in a header element to provide better accessibility resolves #16938 (the first point) PR Close #45209 29 March 2022, 16:23:14 UTC
a1d9ce8 dario-piotrowicz 16 March 2022, 21:37:06 UTC fix(docs-infra): remove navigation role to aio-top-menu ul (#45209) currently the navigation ul used in aio-top-menu has a role of navigation, but listitems should be owned by list parents (see more: https://www.w3.org/TR/wai-aria-1.1/#listitem) so wrap the ul in a nav and remove the role="navigation" from the ul element to fix such issue resolves #44562 resolves #16938 (the second point) PR Close #45209 29 March 2022, 16:23:14 UTC
52e036a Andrew Kushnir 26 March 2022, 02:53:19 UTC docs: add image directive to public roadmap (#45448) PR Close #45448 28 March 2022, 17:30:26 UTC
c087058 JiaLiPassion 07 March 2022, 09:24:24 UTC fix(zone.js): should ignore multiple resolve call (#45283) Close #44913 The following case is not handled correctly by `zone.js`. ``` const delayedPromise = new Promise((resolve) => { setTimeout(resolve, 1, 'timeout'); }); new Promise((resolve) => { resolve(delayedPromise); resolve('second call'); }).then(console.log); ``` It should output `timeout`, since the promise is resolved by the 1st resolve, the `second call` should be ignored. So this is a bug that the original implementation not ensure the `resolve` is only called once. PR Close #45283 26 March 2022, 00:31:04 UTC
0c28997 Paul Gschwendtner 25 March 2022, 22:32:26 UTC build: disable payload size uploading within bazel (#45446) Uploading payload size is unreliable from within Bazel. This is because tests might not run for every commit, tests might have been cached from a pull request RBE-build (causing payload uploading to be skipped most of the time as every change comes from a PR) We should disable the uploading as this is a fundamental problem (good thing to note now) that we can solve with better payload size tracking that we want to establish as part of dev-infra. PR Close #45446 25 March 2022, 23:50:10 UTC
0dd532b arturovt 20 March 2022, 18:39:42 UTC fix(zone.js): swallow the error when the element callback is not patchable (#45400) The `patchCallbacks` is used for patching the `document.registerElement` and `customElements.define`. We explicitly wrap the patching code into try-catch since callbacks may be already patched by other web components frameworks (e.g. LWC), and they make those properties non-writable. This means that patching callback will throw an error `cannot assign to read-only property`. See this code as an example: https://github.com/salesforce/lwc/blob/master/packages/@lwc/engine-core/src/framework/base-bridge-element.ts#L180-L186 We don't want to stop the application rendering if we couldn't patch some callback, e.g. `attributeChangedCallback`. PR Close #42546 PR Close #45400 25 March 2022, 23:31:10 UTC
8d7fd91 Paul Gschwendtner 25 March 2022, 20:45:27 UTC ci: make payload size tracking script work with CircleCI and Bazel limitation (#45444) For quite some time now, since we started to use Bazel for integration tests, we relied on some size tracking logic that did not actually fully work under Bazel. It was thought that all the necessary CI push/PR information is available to the Bazel test, but that was not the case. This was now fixed with the recent Rules NodeJS v5 update where I made sure the `env.sh` variables are actually available before we write them to the temporary file for the Bazel-access. This now will unveil an issue because payload size goldens would start being based on their branch name. e.g. the golden key in `13.3.x` should not be `master` but `13.3.x`. This makes more sense than `master` as key, but makes things more cumbersome and ideally we would not store the branch name at all (this is a larger change though -- not worth now since we might refactor this anyway). For now we will update the size tracking logic to always use `master` as golden key (like it worked in the past year(s)) With the environment fix we now (again) start uploading payload size results to Firebase. This did not work by accident either. The uploading logic is reliant on the CircleCI commit range which is not working/reliable in upstream branches. This commit removes this reliance on `COMMIT_RANGE` since it's not strictly necessary and currently breaking renovate PRs. We can re-enable this when we have a solution with CircleCI, or a workaround/resolution logic provided in e.g. `ng-dev ci determine-commit-range`. PR Close #45444 25 March 2022, 21:25:04 UTC
88dbeda Paul Gschwendtner 24 March 2022, 20:04:16 UTC build: shorten partial compilation test case target names for windows (#45443) Shortens the partial compilation test case target names as the paths/ manifest paths in Bazel became too large, exceeding some Windows path length limits. Relevant context/resources: * https://angular-team.slack.com/archives/C02PARQNMC1/p1648137933069659 (internal) * https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd * https://github.com/bazelbuild/rules_nodejs/pull/3215/files#r782271592 PR Close #45443 25 March 2022, 20:45:08 UTC
a15c7e8 Paul Gschwendtner 24 March 2022, 19:23:53 UTC ci: improve stability of windows bazel CI job (#45443) Improves stability of the Windows Bazel CI job by installing Bazelisk globally. Also makes the environment helpers more convenient by evaluating the variable assignments directly, simplifying some Bash logic. PR Close #45443 25 March 2022, 20:45:08 UTC
5ab0ca5 Paul Gschwendtner 24 March 2022, 18:54:58 UTC ci: dedupe top-level yarn install in circleci config (#45443) Dedupes the Yarn run steps, avoiding the need to manually keep this step in sync (e.g. with the timeout -- which is currently missing for the windows job) PR Close #45443 25 March 2022, 20:45:07 UTC
c24ea4b Paul Gschwendtner 24 March 2022, 16:58:38 UTC test: refactor compiler-cli compliance test to work on windows (#45443) Recent changes in `rules_nodejs` caused the test case copy file actions to be transitioned into the `exec` configuration, resulting in much larger file paths. These paths break on Windows with the shell argument limit, and with the path limit, causing errors like: ``` ERROR: C:/users/circleci/ng/packages/compiler-cli/test/compliance/test_cases/BUILD.bazel:9:12: Copying file packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/components_and_directives/value_composition/structural_directives_if_directive_def.js failed: (Exit 1): cmd.exe failed: error executing command cd /d C:/users/circleci/_bazel_circleci/u4uoan2j/execroot/angular SET PATH=C:\Program Files\Git\usr\bin;C:\Program Files\Git\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0 SET RUNFILES_MANIFEST_ONLY=1 cmd.exe /C bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\packages\compiler-cli\test\compliance\test_cases\test_cases--1973427149-cmd.bat The system cannot find the path specified ``` https://app.circleci.com/pipelines/github/angular/angular/44038/workflows/4b530cb2-f232-4e1d-b35a-e6e085151d08/jobs/1140017 PR Close #45443 25 March 2022, 20:45:07 UTC
c3b3b73 Paul Gschwendtner 23 March 2022, 19:40:28 UTC ci: make windows circleci job more robust and use git bash (#45443) It is totally fine, and expected to use Git Bash for running Bazel on Windows. In fact this is the most common setup for Bazel on Windows and it's unrealistic to run without it. This allows us to remove the old/legacy Powershell setup from CI which is also quite flaky sometimes and does not reproduce how Bazel is used on windows-users dev machines. PR Close #45443 25 March 2022, 20:45:07 UTC
b73d5ae Paul Gschwendtner 23 March 2022, 13:42:29 UTC ci: temporarily disable components-repo-unit-tests job for Bazel NodeJS v5 update (#45443) The Angular components repository can only start using Bazel Rules NodeJS v5 when `@angular/bazel` is published with support for it. To work around this cycle we temporarily disable the unit tests job until we migrated the COMP repo as well. PR Close #45443 25 March 2022, 20:45:07 UTC
3f5e685 Paul Gschwendtner 23 March 2022, 13:34:45 UTC refactor: remove unused variables in starlark code to satisfy buildifier (#45443) We updated buildifier and a few warnings became errors now. This commit cleans up the failing unused variable instances, making the linter happy. Additionally for the API extractor BUILD file, the package defaults need to move to satisfy buildifier. PR Close #45443 25 March 2022, 20:45:07 UTC
69e4c98 Paul Gschwendtner 22 March 2022, 19:03:39 UTC build: migrate more usages from `@bazel/typescript` to `@bazel/concatjs` (#45443) As mentioned in previous commits (check them for more details), `@bazel/typescript` no longer contains `ts_library`-specific code, so we no longer need that dependency. PR Close #45443 25 March 2022, 20:45:07 UTC
1eaaa5d Paul Gschwendtner 22 March 2022, 18:08:14 UTC refactor(bazel): update api-extractor to account for `@bazel/typescript` change (#45443) `@bazel/typescript` code moved to `@bazel/concatjs` for the tsc-wrapped code. Note that this code is likely going to be removed anyway soon when we move dts bundling from `ng_module` to `ng_package`. PR Close #45443 25 March 2022, 20:45:07 UTC
97e3b00 Paul Gschwendtner 22 March 2022, 17:30:47 UTC build: add temporary patch to make `tsec` compatible with `rules_nodejs` v5 (#45443) Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until https://github.com/google/tsec/pull/25 is available/released. PR Close #45443 25 March 2022, 20:45:07 UTC
1a149bb Paul Gschwendtner 22 March 2022, 11:06:15 UTC refactor(bazel): update ngc-wrapped to account for `tsc-wrapped` move to `@bazel/concatjs` (#45443) Previously `tsc-wrapped` which is the foundation for `ngc-wrapped`, resided in `@bazel/typescript`. It has been moved to `@bazel/concatjs` in rules_nodejs so we need to account for that as part of our rules_nodejs v5 update. PR Close #45443 25 March 2022, 20:45:07 UTC
29d4b78 Renovate Bot 21 March 2022, 17:09:54 UTC build: update bazel (#45443) Update `@bazel` packages to the latest 5.x version. Some of the changes here are modeled after angular/dev-infra@40c0ac855975ce9586b07af3a36a0bf4e3b58350. Co-Authored-By: George Kalpakas <kalpakas.g@gmail.com> PR Close #45443 25 March 2022, 20:45:06 UTC
2e79d09 Renovate Bot 21 March 2022, 17:09:54 UTC build: update angular to 5a82e60 (#45443) Update the `@angular/dev-infra-private` package to the latest commit. PR Close #45443 25 March 2022, 20:45:06 UTC
dbd6be8 arturovt 16 March 2022, 19:45:36 UTC fix(zone.js): read `Symbol.species` safely (#45369) We must read `Symbol.species` safely because `this` may be anything. For instance, `this` may be an object without a prototype (created through `Object.create(null)`); thus `this.constructor` will be undefined. One of the use cases is SystemJS creating prototype-less objects (modules) via `Object.create(null)`. The SystemJS creates an empty object and copies promise properties into that object (within the `getOrCreateLoad` function). The zone.js then checks if the resolved value has the `then` method and invokes it with the `value` context. Otherwise, this will throw an error: `TypeError: Cannot read properties of undefined (reading 'Symbol(Symbol.species)')`. PR Close #45369 25 March 2022, 01:56:37 UTC
f869b91 khai 18 March 2022, 09:20:35 UTC docs: update for 2022 angular events (#45386) PR Close #45386 24 March 2022, 21:29:50 UTC
back to top