Skip to main content

Browse the archive

https://github.com/angular/angular
07 August 2024, 03:31:07 UTC
sort by:
Revision Author Date Message Commit Date
986e80e Jessica Janiuk 12 May 2022, 22:05:49 UTC release: cut the v13.3.8 release (#45976) 12 May 2022, 22:05:49 UTC
c9c24d1 Joey Perrott 12 May 2022, 20:09:42 UTC build: use clone instead of init for creating the builds commit changes (#45975) Rather than using git init to create an empty repo and then shallow fetch the repo for a specific branch, we shallow clone the repository itself for the branch. This prevents us from running into the issue of Github denying the push because it comes from a shallow branch which does not map back to the repository. PR Close #45975 12 May 2022, 20:31:45 UTC
90e6987 Joey Perrott 12 May 2022, 19:03:13 UTC build: set the default branch of the ephemeral repo for publishing build artifacts to main (#45974) It looks like because the primary branch for our ephemeral repos doesn't match the build repos we are pushing to it causes errors around shallow clones. This attempts to prevent this. PR Close #45974 12 May 2022, 19:39:37 UTC
b4eb9ed Andrew Scott 12 May 2022, 00:45:30 UTC fix(language-service): Prevent TSServer from removing templates from project (#45965) As part of the `updateProjectIfDirty` process and inside `updateNonInferredProjectFiles` TS Server will remove the template files that we added as roots in `readResource`. https://sourcegraph.com/github.com/microsoft/TypeScript@c300fea3250abd7f75920d95a58d9e742ac730ee/-/blob/src/server/editorServices.ts?L2363 The external files are added to the list here so ensuring that the templates are included in the `getExternalFiles` will prevent this from happening https://sourcegraph.com/github.com/microsoft/TypeScript@c300fea3250abd7f75920d95a58d9e742ac730ee/-/blob/src/server/editorServices.ts?L2395:18 PR Close #45965 12 May 2022, 16:25:20 UTC
e223649 George Kalpakas 10 May 2022, 22:04:50 UTC fix(docs-infra): do not detect a running job as failed (#45948) Previously, the preview server would incorrectly identify a running `aio_preview` CI job as failed and therefore skip creating a preview. This happened because it only checked whether the job's status is `success`, failing to account for the fact that the job would have a `running` status. (This bug was accidentally introduced in #45934.) This commit avoids the problem by getting rid of the job status check altogether. This check does not offer any benefit, since the CI job will always be in a `running` state (i.e. neither successfully completed nor failed). PR Close #45948 12 May 2022, 16:02:04 UTC
72c11f3 Andrew Kushnir 11 May 2022, 17:15:36 UTC release: cut the v13.3.7 release 11 May 2022, 17:17:13 UTC
3626464 Ted.chang 29 April 2022, 01:52:53 UTC docs: add NGX-YOUI website to resources list (#45810) PR Close #45810 10 May 2022, 23:03:37 UTC
5ca3bcf Andrew Scott 12 April 2022, 15:56:58 UTC fix(language-service): Add resource files as roots to their associated projects (#45601) When an external template is read, adds the template file to to the project which contains. This is necessary to keep the projects open when navigating away from HTML files. Since a `tsconfig` cannot express including non-TS files, we need another way to indicate the template files are considered part of the project. Note that this does not ensure that the project in question _directly_ contains the component file. That is, the project might just include the component file through the program rather than directly in the `include` glob of the `tsconfig`. This distinction is somewhat important because the TypeScript language service/server prefers projects which _directly_ contain the TS file (see `projectContainsInfoDirectly` in the TS codebase). What this means it that there can possibly be a different project used between the TS and HTML files. For example, in Nx projects, the referenced configs are `tsconfig.app.json` and `tsconfig.editor.json`. `tsconfig.app.json` comes first in the base `tsconfig.json` and contains the entry point of the app. `tsconfig.editor.json` contains the `**.ts` glob of all TS files. This means that `tsconfig.editor.json` will be preferred by the TS server for TS files but the `tsconfig.app.json` will be used for HTML files since it comes first and we cannot effectively express `projectContainsInfoDirectly` for HTML files. We could consider also updating the language server implementation to attempt to select the project to use for the template file based on which project contains its component file directly, using either the internal `project.projectContainsInfoDirectly` or as a workaround, check `project.isRoot(componentTsFile)`. Finally, keeping the projects open is hugely important in the solution style config case like Nx. When a TS file is opened, TypeScript will only retain `tsconfig.editor.json` and not `tsconfig.app.json`. However, if our extension does not also know to select `tsconfig.editor.json`, it will automatically select `tsconfig.app.json` since it is defined first in the `tsconfig.json` file. So we need to teach TS server that we are (1) interested in keeping projects open when there is an HTML file open and (2) optionally attempt to do this _only_ for projects that we know the TS language service will prioritize in TS files (i.e., attempt to only keep `tsconfig.editor.json` open and allow `tsconfig.app.json` to close) and prioritize that project for all requests. fixes https://github.com/angular/vscode-ng-language-service/issues/1623 fixes https://github.com/angular/vscode-ng-language-service/issues/876 PR Close #45601 10 May 2022, 16:36:28 UTC
66c400c mgechev 04 May 2022, 22:56:03 UTC docs: add the change detection guide to the navigation and pullapprove (#45880) PR Close #45880 09 May 2022, 20:56:36 UTC
5e858c7 mgechev 04 May 2022, 22:54:52 UTC docs: add a guide on using OnPush change detection strategy (#45880) Explain how to use OnPush change detection strategy and what are the different edge cases. Looks into several different scenarios and covers the behavior of OnPush for each one of them. PR Close #45880 09 May 2022, 20:56:36 UTC
af009c3 mgechev 04 May 2022, 22:53:23 UTC docs: add a guide on optimizing slow computations (#45880) Add a guide that explains: - How we can slow the change detection down - How to discover slow computations with Angular DevTools - Explain how to fix slow computations PR Close #45880 09 May 2022, 20:56:36 UTC
87e661d mgechev 04 May 2022, 22:51:41 UTC docs: add guide on how to run code outside of NgZone (#45880) Explain the relationship between Angular and Zone.js. Covers how to discover code that triggers change detection more often than we have to run it and explain how to run code outside the Angular zone. PR Close #45880 09 May 2022, 20:56:36 UTC
683895c mgechev 04 May 2022, 22:50:27 UTC docs: add general change detection overview (#45880) Add a few paragraphs with introduction to how change detection works referencing a video for further details. PR Close #45880 09 May 2022, 20:56:36 UTC
73bbee2 JoostK 09 December 2021, 00:11:30 UTC perf(core): allow `checkNoChanges` mode to be tree-shaken in production (#45936) This commit guards all logic that exists for the `checkNoChanges` mode with `ngDevMode` checks such that the logic can be tree-shaken. PR Close #45936 09 May 2022, 20:24:41 UTC
02b99f6 Andrew Kushnir 09 May 2022, 18:58:24 UTC ci: enable the `aio_preview` CircleCI job (#45935) This reverts commit dbc0dababae6a4a8aa9c5e628f93cd8745fd285f, since the fix has landed in https://github.com/angular/angular/commit/c4340970c7a6419eee28804c9b82254dbcf59315. PR Close #45935 09 May 2022, 19:33:34 UTC
40b3cf4 JayMartMedia 07 May 2022, 14:45:55 UTC docs: remove unnecesarry backslash from pipes documentation (#45916) There was an extra backslash in the description of the pipe character. This could be misleading as people could think that the backslash is a pipe character. PR Close #45916 09 May 2022, 19:08:04 UTC
0ec3263 JayMartMedia 07 May 2022, 14:19:47 UTC docs: fix bold text in start-data (#45916) PR Close #45916 09 May 2022, 19:08:04 UTC
c8ed9bc Andrew Kushnir 06 May 2022, 23:59:37 UTC ci: update NgBot to sync internal and external configs (#45915) There was a difference in the set of paths between check/sync scripts internally and externally. This commit aligns both configurations. PR Close #45915 09 May 2022, 18:55:38 UTC
a3ca0f1 Thomas Mair 30 April 2022, 15:50:17 UTC refactor(docs-infra): remove unnecessary types for stemmer dependency (#45831) NOTE: Since version 2.0.0 stemmer includes its own typings (see https://github.com/words/stemmer/commit/cd6fd9a0319bd7f44dc09ed40614fa807fe28535) PR Close #45831 09 May 2022, 18:54:56 UTC
0e87cd9 George Kalpakas 09 May 2022, 16:49:35 UTC fix(docs-infra): handle CircleCI API v2 responses in preview server (#45934) In PR #45349 we switched to using version 2 of the CircleCI API. It turns out that this version of the API (in addition to different URLs) also returns different info from some endpoints, which we have failed to account for. More specifically, the v2 API response for a job does not contain info that we need in [BuildRetriever][1]. As an example, see the API responses for an `aio_preview` run: - [API v1.1][2] - [API v2][3] This commit updates the code to handle API v2 responses. In addition, since the info we need is not present in the job info (as it was with the previous version of the API), we now also retrieve the pipeline info. NOTE: This issue did not manifest earlier, because the preview server code on the VM was not updated to the latest version (that tried to use API v2) due to a different error. This error was fixed with PR #45895, which allowed the preview server to be updated on the VM and uncovered the API v2 incompatibility. [1]: https://github.com/angular/angular/blob/baa3e18812127e7266580f4cd202a4cb3204cbcb/aio/aio-builds-setup/dockerbuild/scripts-js/lib/preview-server/build-retriever.ts#L39-L45 [2]: https://circleci.com/api/v1.1/project/github/angular/angular/1163816 [3]: https://circleci.com/api/v2/project/gh/angular/angular/job/1163816 Fixes #45931 PR Close #45934 09 May 2022, 18:54:10 UTC
5056cfe dario-piotrowicz 04 May 2022, 22:08:42 UTC docs(docs-infra): clarify toh-2 error message (#45878) the second step of the tour of heroes refers to a runtime error which generally isn't presented to new users since it gets caught by the TypeScript compiler's strict mode, clarify such detail so not to confuse readers resolves #45759 PR Close #45878 09 May 2022, 18:23:27 UTC
d4d7bf2 George Kalpakas 30 April 2022, 14:13:36 UTC docs: fix code snippets in TOH (part 5) "Final code review" section (#45830) Fixes #45736 PR Close #45830 09 May 2022, 18:18:20 UTC
e3d7d5c George Kalpakas 29 April 2022, 20:04:13 UTC docs: fix ellipsis in code-snippet in `creating-libraries` guide (#45820) When hard-coding content in a `<code-example>` tag inside an `.md` file, the content is treated as HTML by the Markdown processor and thus any characters with special meaning in HTML have to be encoded (or replaced with HTML entities). However, the content that is embedded into `<code-example>` tags via docregions is treated as text (since it is not parsed by the Markdown processor) and thus should not have encoded characters or HTML entities. PR Close #45820 09 May 2022, 18:08:48 UTC
31c4879 Andrew Kushnir 09 May 2022, 16:35:32 UTC ci: disable `aio_preview` CircleCI job temporarily (#45932) This commit disables the `aio_preview` CircleCI job temporarily, since it's failing after switching to CircleCI API v2. It will be enabled back once the code is updated. More info can be found here: https://github.com/angular/angular/issues/45931 PR Close #45932 09 May 2022, 18:06:53 UTC
6644165 ᚷᛁᛟᚱᚷᛁ ᛒᚨᛚᚨᚲᚻᚨᛞᛉᛖ 06 May 2022, 11:58:54 UTC docs: remove redundant word (#45910) PR Close #45910 06 May 2022, 16:52:20 UTC
1f0ea14 Paul Gschwendtner 06 May 2022, 07:54:49 UTC ci: update github robot config to reflect update in syncing (#45907) The `ng_module` Starlark code is not used internally, just `ngc-wrapped`. PR Close #45907 06 May 2022, 16:51:48 UTC
f9f1f92 dario-piotrowicz 03 May 2022, 21:26:55 UTC docs(docs-infra): improve clarity of toh-pt2 li>button code (#45858) in the tour of heros part 2 guide the addition of a button with spans is slighly unclear, so update the code to make things more clear resolves #45760 PR Close #45858 05 May 2022, 23:58:45 UTC
60ea078 Andrew Kushnir 05 May 2022, 22:20:42 UTC ci: update the list of excluded paths in NgBot config (#45901) This commit aligns the NgBot config that is used to determine whether a presubmit is needed with its internal version. PR Close #45901 05 May 2022, 22:45:49 UTC
c989963 George Kalpakas 05 May 2022, 15:52:03 UTC build(docs-infra): remove unused Docker artifacts when updating the preview server (#45895) Update the `update-preview-server.sh` script that is used to update the PR preview server to also remove unused Docker images and containers after the update. This avoids having unused Docker artifacts grow uncontrolled and fill up the VM disk drive. PR Close #45895 05 May 2022, 21:49:14 UTC
d735ba7 George Kalpakas 05 May 2022, 15:43:50 UTC test(docs-infra): update preview server `serify-setup` tests to match implementation (#45895) Update the mocks used in the `verify-setup` tests of the PR preview server to account for changes made in PR #45349. These tests run to verify that a newly built docker container works as expected before deploying it to the preview server, so having them fail prevents the preview server from updating automatically. NOTE: These tests are currently not run on CI due to complications with running Docker inside Docker. PR Close #45895 05 May 2022, 21:49:14 UTC
719199c Will 保哥 05 May 2022, 17:55:46 UTC docs: fix a markdown syntax error in aio/content/marketing/analytics.md (#45898) PR Close #45898 05 May 2022, 18:50:58 UTC
0928025 Paul Gschwendtner 03 May 2022, 18:34:54 UTC build: clean up references to old `master` branch (#45890) Cleans up all references to the `master` branch we renamed to `main` across Angular. PR Close #45890 05 May 2022, 17:53:13 UTC
e3b657e Dylan Hunn 04 May 2022, 19:55:18 UTC release: cut the v13.3.6 release (#45873) PR Close #45873 04 May 2022, 19:58:55 UTC
f9e0da6 Andrew Kushnir 03 May 2022, 18:02:21 UTC ci: decrease the number of required `public-api` and `size-tracking` reviews (#45855) This commit updates the PullApprove config to decrease the number of required reviews from `public-api` and `size-tracking` group members. PR Close #45855 03 May 2022, 22:48:28 UTC
8007946 George Kalpakas 28 April 2022, 09:54:32 UTC docs(service-worker): fix alert closing tag (#45797) This also allows correctly parsing other tags further below (such as the `@reviewed` tag at the end). PR Close #45797 03 May 2022, 16:27:38 UTC
c00786a Andrew Scott 02 May 2022, 23:12:54 UTC fix(dev-infra): Fix pullapprove by commenting out the empty availability (#45846) Fixes invalid yml caused by https://github.com/angular/angular/commit/509cab9972dc9ee3366649324e0b19ec9277d7f8 PR Close #45846 02 May 2022, 23:33:44 UTC
e7cd87d Pawel Kozlowski 02 May 2022, 17:55:46 UTC ci: mark pkozlowski as availabe for PR reviews (#45842) Change pullapprove configuration to re-include pkozlowski PR Close #45842 02 May 2022, 22:35:36 UTC
e59ed8c Ryan Day 28 April 2022, 16:29:31 UTC build(bazel): change ngc-wrapped to use new bazelOpts.devmode (#45804) bazelOpts.es5Mode is being removed and replaced with devmode. Adding a check for either will allow a smooth migration. PR Close #45804 02 May 2022, 20:10:07 UTC
26c7b5e dario-piotrowicz 30 April 2022, 13:09:01 UTC docs(docs-infra): improve clarity of toh-pt2 click code snippet (#45829) make clearer that the click code snippet present in the tour of heroes part 2 guide is not complete but adding ellipsis at the end of the snippet and also by slightly tweaking the text introducing the snippet resolves #45758 PR Close #45829 02 May 2022, 18:42:12 UTC
ab011b7 dario-piotrowicz 29 April 2022, 20:32:06 UTC fix(docs-infra): fix wrong heading structure in aio resources page (#45822) in the aio resources page there is a main h1 heading and then the next headings used are h3 and h4, thus h2 is being skipped, change such headings so that there is no heading skipping (which is a bad practice and can result to confusing experiences from screen reader users) PR Close #45822 02 May 2022, 16:20:38 UTC
8393925 Paul Gschwendtner 21 April 2022, 13:45:42 UTC build: updates to account for github primary branch rename This is the commit accounting for the Github primary branch rename when we actually perform the update. We have three change phases: Prepare, Direct, Cleanup. This commit is for the `direct` phase. 28 April 2022, 17:24:46 UTC
8cfb53d Andrew Scott 27 April 2022, 18:23:40 UTC release: cut the v13.3.5 release (#45780) 27 April 2022, 18:23:40 UTC
73fda73 dario-piotrowicz 23 April 2022, 21:12:10 UTC docs: empty alt of aio home decorative images (#45740) in the aio home page the sections' decorative images provide an alt texts, which shouldn't actually be present (see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such alt text for a better user experience PR Close #45740 27 April 2022, 16:06:13 UTC
bed3362 dario-piotrowicz 23 April 2022, 21:09:52 UTC docs: use proper sections in aio home (#45740) convert the `div` groups in the aio home page to proper `section`s with a valid heading/title PR Close #45740 27 April 2022, 16:06:13 UTC
b838b4c dario-piotrowicz 23 April 2022, 21:06:18 UTC docs: make sure aio home has a non-ignored h1 (#45740) currently the aio home page presents a single h1 which is ignored by assistive technologies since it has its display set none, so replace it with a new h1 containing the main text of the page instead PR Close #45740 27 April 2022, 16:06:12 UTC
c5a6cff dario-piotrowicz 25 April 2022, 20:57:22 UTC fix(docs-infra): fix alert child margin issue (#45761) replace the generic `*` selector used in the alert styling with `p` (which is what gets generated from the markdown) as the styling adds margins which are not always wanted PR Close #45761 27 April 2022, 16:04:31 UTC
3a645c6 Renovate Bot 26 April 2022, 10:16:36 UTC build: update actions/checkout action to v3.0.2 (#45764) PR Close #45764 26 April 2022, 17:11:43 UTC
63398e0 Joey Perrott 22 April 2022, 15:33:17 UTC fix(bazel): add this_is_bazel marker (#45728) Add marker for noting that this check confirms we are running in a bazel environment. PR Close #45728 22 April 2022, 19:46:24 UTC
81611db George Kalpakas 14 April 2022, 14:10:45 UTC fix(docs-infra): fix placement of "Edit source" button on errors and diagnostics pages (#45634) This commit aligns the layout of errors and extended diagnostics pages more closely with other docs pages to ensure that the "Edit source" button is displayed correctly even when the heading is too long to fit on a single line. For error pages, in particular, this ensures that the button is not obscured by the error video. **Before:** ![error-pages before][1] **After:** ![error-pages after][2] [1]: https://user-images.githubusercontent.com/8604205/163408291-7aebd029-891c-4045-8fa2-a8e2b2b06dab.png [2]: https://user-images.githubusercontent.com/8604205/163408296-40e6df8e-aadc-4a82-978a-ab4d902b6f6e.png PR Close #45634 21 April 2022, 18:07:27 UTC
6f50fd9 Andrew Kushnir 21 April 2022, 06:04:23 UTC fix(docs-infra): include `tslib` into SystemJS config in `upgrade-module` example app (#45706) This commit updates the SystemJS for one of the example apps (the `upgrade-module` one) to include a resolution rule for the `tslib`. This is needed in case `tslib` is referenced from the framework code (for example in case of downleveling of some operators). This makes it consistent with other example app configs. PR Close #45706 21 April 2022, 18:05:39 UTC
2ea541f Dylan Hunn 20 April 2022, 21:29:50 UTC release: cut the v13.3.4 release (#45702) PR Close #45702 20 April 2022, 21:31:12 UTC
dd7eeb6 Andrew Kushnir 20 April 2022, 04:51:14 UTC fix(docs-infra): avoid internal symbols from being referenced during auto-linking (#45689) This commit adds extra logic to avoid internal and privately exported symbols from being referenced during auto-linking. Currently such symbols can be used for linking, thus resulting in a non-existing link and causing the linking process to fail. PR Close #45689 20 April 2022, 16:11:22 UTC
1d204fc Paul Gschwendtner 20 April 2022, 07:42:27 UTC Revert "test(common): Fix flaky Location test (#45683)" (#45691) This reverts commit 254d6cea9a662dabf74058cc991bdc965db94295. This test has only been introduced in the next branch with https://github.com/angular/angular/pull/44901. The cherry-pick of the flaky test fix does not work in the patch branch due to some other missing changes and the test did not exist in 13.3.x anyway. PR Close #45691 20 April 2022, 15:58:46 UTC
7619c16 Paul Gschwendtner 19 April 2022, 15:48:25 UTC build: preparation for primary branch rename in the Angular repos (#45691) Preparation for the framework repo as outlined our planning document. PR Close #45691 20 April 2022, 15:58:46 UTC
52a564d Mangalraj 15 April 2022, 23:06:51 UTC docs: Update aio/content/guide/setup-local.md (#45644) Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> PR Close #45644 20 April 2022, 03:20:40 UTC
bb7b51b Mangalraj 14 April 2022, 23:52:52 UTC docs: correct the example command to install angular (#45644) PR Close #45644 20 April 2022, 03:20:40 UTC
254d6ce Andrew Scott 19 April 2022, 20:15:06 UTC test(common): Fix flaky Location test (#45683) This test has proven to be flaky. This commit greatly simplifies the test and moves it to a more appropriate location (pun intended). PR Close #45683 20 April 2022, 03:17:56 UTC
1e8fe84 Saurabh Kamble 19 April 2022, 15:16:53 UTC Fix typo (#45680) PR Close #45680 19 April 2022, 16:26:14 UTC
22ef5e0 George Kalpakas 17 April 2022, 09:12:20 UTC docs(common): fix links to locales in i18n guides (#45661) In PR #42230, the locale file generation process was modified so that generated locale files are no longer checked into the repository. Update a few links in the docs that pointed to the previously checked in files to point to other places where the files exist. PR Close #45661 19 April 2022, 16:17:34 UTC
c4e1d45 Jeremy Elbourn 18 April 2022, 16:29:19 UTC build: don't assign jelbourn to most review categories (#45668) Configure pullapprove to not automatically assign jelbourn to most review categories. PR Close #45668 19 April 2022, 16:15:40 UTC
d5a522a Louis Gombert 18 April 2022, 14:59:00 UTC docs: update decorators proposal stage and link in glossary (#45669) PR Close #45669 19 April 2022, 16:14:37 UTC
ed832b4 Andrew Kushnir 18 April 2022, 17:39:41 UTC test: reset counters before running a styling test (#45670) This commit updates one of the styling tests to reset perf counters, making it order-independent and non-flaky (previously the test got random failures depending on whether there are other tests invoked before). PR Close #45670 19 April 2022, 16:14:10 UTC
ebf98c4 Marko Kaznovac 18 April 2022, 09:38:36 UTC docs: use language agnostic mdn urls (#45666) PR Close #45666 18 April 2022, 21:10:17 UTC
ac8c896 Marko Kaznovac 18 April 2022, 09:34:46 UTC docs: fix mdn links (#45666) PR Close #45666 18 April 2022, 21:10:17 UTC
37b3ac7 dario-piotrowicz 06 February 2022, 18:03:25 UTC fix(docs-infra): implement focus trap for aio search results (#45654) currently if a user tries to navigate via keyboard, once the are presented with search results, the search results panel remains present and can potentially hide most of the content on the page, in such case keyboard navigation will be severly hindered and the only option for the user would be to go back to the seach input text and clear its value, fix such inconvenience by looping the focus in the header area close to the search results and the results panel itself note: an alternative implementation using the cdkTrapFocus has been attempted in PR #45194, such alternative implementation presented a number of (minor) drawbacks (including the increase main bundle size due to the inclusion of the A11yModule), so it was agreed to proceed with the manual implementation present in these changes instead. PR Close #45654 18 April 2022, 16:57:53 UTC
b5820b6 dario-piotrowicz 12 April 2022, 20:08:51 UTC fix(docs-infra): fix aio search-results issue with toolbar and notification (#45579) (#45654) use border-top-width instead of padding-top as the strategy for moving the search-results panel down, this fixes the issue of the panel going behind the toolbar (which causes either overlapping text in the home page or the results scrollbar to be hidden behind the toolbar in other pages) PR Close #45579 PR Close #45654 18 April 2022, 16:57:53 UTC
26fe764 dario-piotrowicz 11 April 2022, 19:02:08 UTC fix(docs-infra): amend notification close button aria-label (#45579) (#45654) move the aria-label used inside the close-button to the button itself (since otherwise the button's aria-label overrides the childs) PR Close #45579 PR Close #45654 18 April 2022, 16:57:53 UTC
1564771 dario-piotrowicz 09 April 2022, 19:33:44 UTC feat(docs-infra): add close button to search-results aio panel (#45579) (#45654) add a close button to the search-results aio panel so that the user can conveniently close it via keyboard this complements the focus trap implemented in PR #44989 (more here: https://github.com/angular/angular/pull/44989#issuecomment-1037287678) PR Close #45579 PR Close #45654 18 April 2022, 16:57:53 UTC
989ba8f Andrew Kushnir 15 April 2022, 20:03:10 UTC ci: add more reviewers to the `docs-packaging-and-releasing` group (#45652) Currently that group has just 2 reviewers, but we often update the files that belong to that group during the deprecation period. Adding more people would allow to balance the reviews better. PR Close #45652 18 April 2022, 16:24:59 UTC
9317f51 Kristiyan Kostadinov 16 April 2022, 05:13:37 UTC fix(core): better error message when directive extends a component (#45658) We throw an error when a directive is trying to extend a component, but we don't actually say which class is responsible which can be difficult to track down. These changes add the two class names to the error message. PR Close #45658 18 April 2022, 16:24:24 UTC
d68333e ivanwonder 10 April 2022, 14:46:16 UTC fix(language-service): two-way binding completion should not remove the trailing quote (#45582) We allow the path to contain both the `t.BoundAttribute` and `t.BoundEvent` for two-way bindings but do not want the path to contain both the `t.BoundAttribute` with its children when the position is in the value span because we would then logically create a path that also contains the `PropertyWrite` from the `t.BoundEvent`. This early return condition ensures we target just `t.BoundAttribute` for this case and exclude `t.BoundEvent` children. Fixes https://github.com/angular/vscode-ng-language-service/issues/1626 PR Close #45582 15 April 2022, 20:53:49 UTC
4766817 Andrew Kushnir 15 April 2022, 02:10:43 UTC fix(core): improve multiple components match error (#45645) This commit improves the error message that is thrown at runtime when multiple components match the same element. Now the error message contains names of classes that represent those components. PR Close #45645 15 April 2022, 20:52:20 UTC
575cafc Andrew Kushnir 15 April 2022, 18:20:52 UTC test(core): add a test for multiple named interpolations with the same name (#45651) The test from this commit verifies that i18n logic can handle multiple named interpolations with the same name. PR Close #45651 15 April 2022, 20:51:56 UTC
acbd2e9 Ilya Marchik 14 April 2022, 16:46:41 UTC docs: fix typo (#45637) Replace wrong mention of 'heroService.delete()' with 'heroService.deleteHero()' because 'heroService.delete()' doesn't exist and 'heroService.deleteHero()' should be mentioned instead Resolves #45636 PR Close #45637 14 April 2022, 23:30:05 UTC
a1c7418 Andrew Kushnir 14 April 2022, 20:50:33 UTC docs: move old changelog entries to a separate file (#45639) This commit moves all release notes for everything before v11.0.0 to a separate file, so that the changelog can be rendered correctly via GitHub UI. Closes #45635. PR Close #45639 14 April 2022, 22:01:49 UTC
8d09451 George Kalpakas 14 April 2022, 08:20:29 UTC docs(core): fix typo in View Encapsulation code example (#45629) Fix closing tag name to match opening one (`</hero-detail>` --> `<hero-details>`). PR Close #45629 14 April 2022, 22:00:06 UTC
ec115a3 Andrew Kushnir 04 April 2022, 05:40:57 UTC refactor(core): avoid referencing `PlatformRef` in bootstrap code (#45519) This commit updates an existing bootstrap logic to avoid referencing the `PlatformRef` instance to keep track of the platform status. Instead, we use platform injector, so that the `PlatformRef`can be tree-shaken away in the bootstrap logic for Standalone Components. The motivation for this change is that retaining the `PlatformRef` class also retains NgModule-based bootstrap code, which would not be needed in case of Standalone Components. PR Close #45519 13 April 2022, 22:34:48 UTC
cbfe628 Jessica Janiuk 13 April 2022, 18:27:48 UTC release: cut the v13.3.3 release (#45614) 13 April 2022, 18:27:48 UTC
e50fd9e Kristiyan Kostadinov 09 April 2022, 14:26:47 UTC fix(compiler): avoid errors with extremely long instruction chains (#45574) Our logic for generating code from an AST uses recursion which limits the number of expressions we can nest before we reach the call stack limit. These changes add a limit in order to avoid errors in some cases where the chains become extremely long. Fixes #45564. PR Close #45574 13 April 2022, 16:18:56 UTC
5fe5970 4javier 12 April 2022, 23:23:33 UTC docs: fix grammar (#45455) PR Close #45455 12 April 2022, 23:55:33 UTC
cfb54c6 4javier 12 April 2022, 11:24:53 UTC docs: fix to comply with new codeblock guidelines (#45455) PR Close #45455 12 April 2022, 23:55:33 UTC
1426801 4javier 11 April 2022, 19:32:40 UTC docs: modified as per dylhunn suggestions (#45455) https://github.com/angular/angular/pull/45455#pullrequestreview-925369970 PR Close #45455 12 April 2022, 23:55:32 UTC
db7201f 4javier 26 March 2022, 22:51:34 UTC docs: update template reference variables (#45455) - Specify `NgForm` gets applied by default on `<form>` elements before the long example using it - Move the strange (and questioned in a commented line) snippet about undefined ref vars in a standalone paragraph and clarify its meanings (adding the part about directive just because there was something similar already there) - Extend and modify `*ngFor` example, since in the original that was misleading to think reference variable couldn't be used inside a loop - Remove two lines stating that with `*ngIf` and `*ngFor` the framework cannot know if a template is ever instantiated (can't see how this relate with the page) - Add an explanation of assignment of default `$implicit` value to undefined input variables - Modify template example for template input variable to be a complete ngForOf loop instead of the original poor intelligible truncated one - Replace last generic statements about variable namespaces with a more pragmatic and explanatory one concerning the resolution in case of homonymy PR Close #45455 12 April 2022, 23:55:32 UTC
fc145d0 Andrew Kushnir 02 April 2022, 01:50:13 UTC refactor(core): make ComponentFactoryResolver lazily instantiated in ApplicationRef (#45507) This commit removes the `ComponentFactoryResolver` as a constructor argument of the `ApplicationRef` class. This makes it lazily instantiated + simplifies further refactoring in a context of Standalone Components. PR Close #45507 12 April 2022, 22:29:17 UTC
44b9d89 Andrew Kushnir 02 April 2022, 01:36:12 UTC refactor(core): make platform core providers tree-shakable (#45506) This commit refactors the set of hardcoded platform core providers into tree-shakable providers. In addition to making them tree-shakable, this would also avoid the need to rely on the platform creation logic in an upcoming bootstrap logic for Standalone Components. PR Close #45506 12 April 2022, 22:28:24 UTC
ae1db7a Jason Hendee 12 April 2022, 18:48:39 UTC docs: make tutorial instructions consistent (#45372) When starting this tutorial, it's not clear to the user whether they should add routing right away, Etc. The other tutorials within the routing section do a better job of this. Also.. the suggested name of this sample app clashes with that of a previous tutorial, forcing the user to either delete the previous tutorial files, choose a different name for this tutorial's app, or place this app in a different parent directory. Conflicts: aio/content/guide/router-tutorial-toh.md PR Close #45372 12 April 2022, 22:27:38 UTC
5c9fe8d Dylan Hunn 12 April 2022, 21:43:02 UTC build: only allow renovate to run on Monday nights (#45605) By running renovate once a week, we can consolidate all the updates into a single weekly PR, before each Wednesday release. That will significantly reduce the burden on caretakers, and make patch ports less onerous. PR Close #45605 12 April 2022, 22:26:49 UTC
c49d232 Virginia Dooley 01 April 2022, 23:51:25 UTC docs: new Pipes custom data doc (#45505) PR Close #45505 12 April 2022, 21:29:07 UTC
24212cd Virginia Dooley 10 February 2022, 19:27:06 UTC docs: pipes custom data transform (#45505) PR Close #45505 12 April 2022, 21:29:07 UTC
d5b7c96 4javier 12 April 2022, 21:00:54 UTC docs: fix path typo (#45604) PR Close #45604 12 April 2022, 21:27:49 UTC
ddd822f 4javier 12 April 2022, 20:18:35 UTC docs: fix final code review section codetabs path (#45604) Fix paths for codetabs in final review section messed up by this commit https://github.com/angular/angular/commit/42289f25c69ec7a36d2e3ef424d32f77bc7cd19a They were all pointing to `heroes-search.component` PR Close #45604 12 April 2022, 21:27:49 UTC
d31f4de Michael-Doner 09 April 2022, 17:06:41 UTC docs: add powershell execution policies note (#45576) Fixes #44598 PR Close #45576 12 April 2022, 21:13:59 UTC
5900f0e George Kalpakas 12 April 2022, 09:01:40 UTC docs(docs-infra): add missing period in `aio/README.md` (#45584) PR Close #45584 12 April 2022, 18:40:46 UTC
6189457 Joe Martin (Crowdstaffing) 11 April 2022, 18:32:21 UTC docs: improve markdown (#45590) improve markdown for documentation. Duplicate of #45325 that targets 13.3.x. PR Close #45590 11 April 2022, 22:35:01 UTC
09c5c18 Renovate Bot 09 April 2022, 06:04:31 UTC build: update dependency google-closure-compiler to v20220405 (#45568) PR Close #45568 11 April 2022, 16:26:26 UTC
f09d166 Michal Materowski 09 April 2022, 11:41:26 UTC build: fix typo in package.json file comment (#45569) Change comment in scripts section of package.json PR Close #45569 11 April 2022, 16:14:16 UTC
1b2c67d George Kalpakas 06 April 2022, 16:10:05 UTC test(docs-infra): fix e2e test for `{@example}` dgeni tags (#45551) (#45563) Previously, the `guide/compoent-style` page was used in e2e tests to verify the behavior of `{@example}` dgeni tags. However, this guide has been updated and no longer contains an `{@example}` tag. This commit switches to using a different page (`api/common/NgIf`) that does currently contain an `{@example}` tag. (NOTE: This will also fix the [CI failures][1] in #45501.) [1]: https://circleci.com/gh/angular/angular/1145424 PR Close #45551 PR Close #45563 08 April 2022, 15:55:25 UTC
2144b99 George Kalpakas 06 April 2022, 16:03:35 UTC fix(docs-infra): add `shell` to the list of code-example languages recognized as cli commands (#45551) (#45563) Previously, only `language="sh"` and `language="bash"` would be recognized (and formatted) as cli commands in `<code-example>`. This commit adds `shell` to the list of languages recognized as cli commands. (NOTE: This will fix the [CI failures][1] in #45325.) [1]: https://circleci.com/gh/angular/angular/1145559 PR Close #45551 PR Close #45563 08 April 2022, 15:55:24 UTC
208d819 Cédric Exbrayat 31 March 2022, 08:13:23 UTC refactor(core): validate property (#45528) Simplifies and documents the `validateProperty` function (in a similar fashion that #45492 simplified `validateElementIsKnown`). PR Close #45528 07 April 2022, 22:03:13 UTC
18f98e6 George Kalpakas 06 April 2022, 17:17:00 UTC docs: remove out-of-order `<h3>` elements from footer (#45510) The footer uses `h3` elements out of order, which causes a "Heading elements are not in a sequentially-descending order" a11y error. Replace the `h3` elements with `div` to improve a11y. Fixes #44338 PR Close #45510 07 April 2022, 21:01:58 UTC
back to top