Skip to main content

Browse the archive

https://github.com/angular/angular
07 August 2024, 03:31:07 UTC
sort by:
Revision Author Date Message Commit Date
0c36f82 Jessica Janiuk 02 February 2022, 19:39:30 UTC release: cut the v14.0.0-next.1 release (#44951) 02 February 2022, 19:39:30 UTC
38bb2be Jessica Janiuk 02 February 2022, 18:51:13 UTC docs: release notes for the v13.2.1 release (#44950) 02 February 2022, 18:51:13 UTC
c08db20 George Kalpakas 02 February 2022, 08:46:02 UTC build(docs-infra): upgrade cli command docs sources to be7c79b5a (#44942) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/db5e7c82e...be7c79b5a): **Modified** - help/build.json - help/test.json PR Close #44942 02 February 2022, 17:03:32 UTC
cae1e44 Dylan Hunn 01 February 2022, 20:56:00 UTC fix(forms): Update the typed forms migration to use FormArray<T> instead of FormArray<T[]>. (#44933) Previously, `FormArray` accepted an array generic. Now it accepts the element type, so the migration must be update accordingly. PR Close #44933 02 February 2022, 01:58:18 UTC
1b56437 mgechev 02 February 2022, 01:17:39 UTC docs: update the survey expiration date (#44938) Extend with a few more days since the survey is still open. PR Close #44938 02 February 2022, 01:56:40 UTC
d82c957 JoostK 23 January 2022, 21:13:08 UTC fix(compiler-cli): ensure casing of logical paths is preserved (#44798) The logical filesystem would store a cached result based on the canonical path, where the cached value contains the physical path that was originally provided. This meant that other physical paths with an identical canonical path would use a cached result derived from another physical path. This inconsistency is not known to result in actual issues but is primarily being made as a performance improvement, as using the provided physical paths as cache key avoids the need to canonicalize the path if its result is already cached. PR Close #44798 02 February 2022, 00:04:37 UTC
b745b8c JoostK 23 January 2022, 20:59:55 UTC refactor(compiler-cli): use relative imports into dts files as fallback in type-check files (#44798) The generated imports should normally use module specifiers that are valid for use in production code, where arbitrary relative imports into e.g. node_modules are not allowed. For template type-checking code it is however acceptable to use relative imports, as such files are never emitted to JS code. It is desirable to allow a filesystem relative import as fallback if an import would otherwise fail to be generated, as doing so allows fewer situations from needing an inline type constructor. PR Close #44798 02 February 2022, 00:04:37 UTC
6763967 JoostK 10 January 2022, 20:35:17 UTC refactor(compiler): remove ViewEngine identifiers (#44676) This commit removes the leftover `Identifiers` class that was used in the ViewEngine compiler. The remaining usages of the `inlineInterpolate` and `interpolate` instructions were refactored to make use of an `InterpolationExpression` output expression to capture the argument list of an interpolation expression. An attempt was made to refactor this further by converting to the desired interpolation instruction immediately, but some downstream consumers are designed in a way where the argument list itself is needed, e.g. as other arguments need to be prepended/appended. PR Close #44676 02 February 2022, 00:04:13 UTC
fc1c143 markostanimirovic 01 February 2022, 21:34:11 UTC docs(router): use Resolve interface for custom title resolver (#44934) PR Close #44934 02 February 2022, 00:03:31 UTC
03ab705 Andrew Scott 01 February 2022, 23:22:38 UTC build: fix test for useUnknownInCatch (#44935) CI ran before the change to the tsconfig file PR Close #44935 01 February 2022, 23:40:17 UTC
4b4bf05 markostanimirovic 01 February 2022, 21:13:03 UTC docs(router): provide better typing for resolver example (#44932) PR Close #44932 01 February 2022, 22:06:29 UTC
a2cbffc JoostK 31 January 2022, 20:15:42 UTC fix(common): include query parameters for open HTTP requests in `verify` (#44917) When `HttpTestingController.verify` is used to verify that there are not open, unexpected requests it would throw an error with the method and URL of all pending requests, excluding the query parameters. This is confusing, as e.g. `expectOne` matches a URL including its query parameters and `expectOne` does include the query parameters when it reports when no request could be matched. This commit changes the error that is reported by `verify` to include the query parameters. Closes #19974 PR Close #44917 01 February 2022, 21:41:43 UTC
d41dedb JimMorrison723 27 January 2022, 18:56:40 UTC fix(devtools): highlighter should only show the hovered component's name (#44863) The used children property on a HTMLCollection does not contain text elements. Because of this, the highlighter overlay text never got fully cleared. PR Close #44863 01 February 2022, 21:28:09 UTC
2006f53 JimMorrison723 27 January 2022, 20:36:16 UTC docs: update devtools docs, and add to the list of available commit scope list (#44863) PR Close #44863 01 February 2022, 21:28:09 UTC
c89cf63 Andrew Kushnir 25 January 2022, 05:33:17 UTC feat(common): support NgModule as an input to the NgComponentOutlet (#44815) This commit updates the logic of the `NgComponentOutlet` class to allow passing an `NgModule` as an input instead of passing an `NgModule` factory. DEPRECATED: The `ngModuleFactory` input of the `NgComponentOutlet` directive is deprecated in favor of a newly added `ngModule` input. The `ngModule` input accepts references to the NgModule class directly, without the need to resolve module factory first. PR Close #44815 01 February 2022, 20:19:41 UTC
ab003a4 David Shevitz 13 January 2022, 16:14:07 UTC docs: fix incorrect title and tooltip in navigation (#44710) Fixes #44589 In the navigation pane, the title and tooltip for the page, Preparing component for translation, are incorrect. This PR fixes this issue. PR Close #44710 01 February 2022, 19:17:40 UTC
5d7ffd5 Alan 17 January 2022, 02:36:32 UTC docs: correct the demo code of NgZone.run (#44733) `NgZone.run` needs to be within the async closure, not around its registration, refer to: https://github.com/angular/angular/issues/44714 PR Close #44733 01 February 2022, 19:16:16 UTC
9f5edce Arjen 25 January 2022, 18:32:17 UTC docs: explain how `ngsw.json` is generated (#44823) Update aio/content/guide/service-worker-devops.md ngsw.json is the manifest file which is generated at build time ( based on ngsw-config.json ). This explains this a bit clearer. At first, I thought that it was a wrongly named filename. Not is it explicitly described. Co-Authored-By: George Kalpakas <kalpakas.g@gmail.com> PR Close #44823 01 February 2022, 18:26:42 UTC
e0a340e Doug Parker 01 February 2022, 00:33:42 UTC refactor(compiler-cli): remove leftover `_extendedTemplateDiagnostics` flag (#44920) This flag is currently a no-op because extended diagnostics are enabled in production. PR Close #44920 01 February 2022, 18:24:10 UTC
6829fc4 Daniel Díaz 19 January 2022, 00:38:50 UTC docs: add colon before introducing the list of items (#44751) PR Close #44751 01 February 2022, 18:20:47 UTC
fdfcef5 Andrew Scott 07 January 2022, 18:00:40 UTC build: enable useUnknownInCatchVariables (#44679) This unblocks the internal migration to turn the option on in g3. PR Close #44679 01 February 2022, 18:17:29 UTC
bc61cc2 Alan Agius 27 January 2022, 13:12:47 UTC refactor(migrations): remove old migrations (#44857) When using `ng update` users cannot update multiple major versions at the same time. Therefore migrations that are not targeting version 14 cannot be run and therefore we are removing them. PR Close #44857 01 February 2022, 03:52:26 UTC
ed1732c Andrew Kushnir 21 January 2022, 21:02:40 UTC refactor(core): the `RuntimeError` class should support more compact syntax (#44783) This commit refactors the `RuntimeError` class to support a short version of providing error messages: ``` throw new RuntimeError( RuntimeErrorCode.INJECTOR_ALREADY_DESTROYED, ngDevMode && 'Injector has already been destroyed.'); ``` In prod mode, the second argument becomes `false` andn this commit extends the typings to support that. This commit also contains a couple places were the `RuntimeError` class is used to demostrate the compact form. PR Close #44783 01 February 2022, 00:15:56 UTC
db05ae1 JoostK 31 January 2022, 19:11:23 UTC refactor(compiler): remove parsing support for quote expressions (#44915) So-called "Quote expressions" were added in b6ec2387b31ad1f51b95c8fac8f2a60b2de855f6 to support foreign syntax to be used in Angular templates, requiring a custom template transform to convert them somehow during compilation. Support for template transforms was originally implemented in a43ed79ee7d49ec55a0adea9b587ed67780c870c but has since been dropped. Since the compiler is not public API the quote expressions should not have any usages anymore. Removing support for them can improve error reporting for expressions that contain a `:`, e.g. binding to a URL without quotes: ```html <a [href]="http://google.com">Click me</a> ``` Here, `http` would be parsed as foreign "http" quote expression with `//google.com` as value, later reporting the error "Quotes are not supported for evaluation!" because there was no template transform to convert that code. Closes #40398 PR Close #44915 31 January 2022, 23:31:11 UTC
f0cfa00 Dylan Hunn 30 November 2021, 19:46:46 UTC refactor(forms): Move FormControl to an overridden exported constructor. (#44316) (#44806) This implementation change was originally proposed as part of Typed Forms, and will have major consequences for that project as described in the design doc. Submitting it separately will greatly simplify the risk of landing Typed Forms. This change should have no visible impact on normal users of FormControl. See the Typed Forms design doc here: https://docs.google.com/document/d/1cWuBE-oo5WLtwkLFxbNTiaVQGNk8ipgbekZcKBeyxxo. PR Close #44316 PR Close #44806 31 January 2022, 22:48:23 UTC
cec158b JoostK 31 January 2022, 20:46:53 UTC refactor(compiler-cli): remove unused `canonical-path` dependency (#44918) This package is no longer used within `compiler-cli` so is being removed as a dependency. PR Close #44918 31 January 2022, 21:39:53 UTC
5686f68 Andrew Scott 31 January 2022, 17:46:22 UTC fix(core): Add back support for namespace URIs in createElement of dom renderer (#44914) Support for namespace URIs rather than short namespace names was added in https://github.com/angular/angular/commit/2b9cc8503d48173492c29f5a271b61126104fbdb to support how Ivy passed around the namespace URI rather than short name at the time. As a side-effect, this meant that namespace URIs were supported by the default dom renderer as part of the public API (likely unintentionally). It did not, however extend the support to other parts of the system (setAttribute, setAttribute, and the ServerRenderer). In the future we should decide what exactly the semantics for dealing with namespaces should be and make it consistent. fixes #44028 PR Close #44914 31 January 2022, 21:39:29 UTC
9eff890 Andrew Kushnir 31 January 2022, 05:51:27 UTC refactor(core): strict templates type-checking compatibility for perf tests (#44905) This commit updates a type used in the transplanted views perf tests, to make the test compatible with strict template type-checking. Currently, compiling the perf test results in the following TS error: ``` error TS2322: Type 'TemplateRef<{}>' is not assignable to type 'TemplateRef<NgForOfContext<any, any[]>>'. 17 <ng-container *ngFor="let n of views; template: template; trackBy: trackByIndex"></ng-container> ~~~~~~~~ ``` PR Close #44905 31 January 2022, 21:39:04 UTC
889de82 arturovt 29 January 2022, 04:44:34 UTC fix(forms): ensure OnPush ancestors are marked dirty when the promise resolves (#44886) Currently, `ngModel` calls` setValue` after the `resolvedPromise` is resolved. The promise is resolved _after_ the child template executes. The change detection is run but `OnPush` views are not updated because they are not marked as dirty. PR Close #44886 31 January 2022, 21:38:39 UTC
39c614c Andrew Kushnir 25 January 2022, 04:53:03 UTC fix(core): flush delayed scoping queue while setting up TestBed (#44814) Previously, some NgModules that were added to the delayed scoping queue, never got removed from the queue before unit test execution. That resulted in some components (declared in those NgModules) missing their scope (which components/directives/pipes were matched). This commit adds the logic to invoke delayed scoping queue flushing before starting a test to avoid missing/incomplete scopes for Components used in a test. PR Close #44814 31 January 2022, 21:37:53 UTC
6642e3c Andrew Kushnir 31 January 2022, 03:50:11 UTC perf(animations): remove no longer needed CssKeyframes classes (#44903) This commit removes CSS keyframes-based code that was used to support animations in old browsers. With IE11 deprecation, all supported browsers have native WebAnimations support, so the old code can be removed. This results in ~7KB decrease of the animations package bundle size, since most of the code was non-tree-shakable. Closes #44520. PR Close #44903 31 January 2022, 21:36:35 UTC
5e099b5 Lee Robinson 31 January 2022, 04:44:02 UTC docs: Update deployment docs for Vercel (#44904) PR Close #44904 31 January 2022, 21:32:41 UTC
7155e9e Doug Parker 31 January 2022, 20:20:45 UTC build: fix `update_all_goldens.js` to use ESM. (#44916) Attempting to run as is fails because we have `"type": "module"`. `shelljs` is a CommonJS module however, so we need to do a default import and destructure. ``` $ node packages/compiler-cli/test/compliance/update_all_goldens.js const {exec} = require('shelljs'); ^ ReferenceError: require is not defined in ES module scope, you can use import instead This file is being treated as an ES module because it has a '.js' file extension and '/home/douglasparker/Source/ng/packages/compiler-cli/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension. at file:///home/douglasparker/Source/ng/packages/compiler-cli/test/compliance/update_all_goldens.js:11:16 at ModuleJob.run (node:internal/modules/esm/module_job:183:25) at async Loader.import (node:internal/modules/esm/loader:178:24) at async Object.loadESM (node:internal/process/esm_loader:68:5) at async handleMainPromise (node:internal/modules/run_main:63:12) ``` PR Close #44916 31 January 2022, 21:31:11 UTC
4c83395 Renovate Bot 31 January 2022, 19:40:45 UTC build: update all non-major dependencies (#44855) PR Close #44855 31 January 2022, 21:30:10 UTC
53a4a03 Paul Gschwendtner 29 January 2022, 19:30:03 UTC build: bump version for `@angular/benchpress` to v0.3.0 (#44893) Bumps the version for Angular benchpress so that another version shipping with APF v13 and strict ESM can be published. PR Close #44893 31 January 2022, 21:27:08 UTC
950cf18 Paul Gschwendtner 29 January 2022, 19:26:15 UTC build: switch benchpress NPM output to APF with ESM (#44893) Switches the benchpress NPM package to APF with ESM. This is necessary as benchpress relies on framework APF strict ESM packages. CommonJS packages like benchpress currently are not able to import from strict ESM packages without adding a CJS/ESM interop that complicates code unnecessarily. The best way forward is to just switch the benchpress package from CommonJS to the modern ESM output, matching with the Angular ecosystem. PR Close #44893 31 January 2022, 21:27:08 UTC
366e424 JoostK 27 January 2022, 18:59:37 UTC fix(compiler-cli): enable nullish coalescing check only with `strictNullChecks` (#44862) TypeScript configures `strictNullChecks` to be disabled by default, so the nullish coalescing check should follow the same default. The rule actively depends on `strictNullChecks`, as TypeScript doesn't include `null`/`undefined` in its types otherwise so the check wouldn't have a way to differentiate between them. This commit also takes the `strict` flag into account when `strictNullChecks` itself is not configured. PR Close #44862 31 January 2022, 20:31:58 UTC
73c97ae JoostK 27 January 2022, 18:50:38 UTC fix(compiler-cli): accept nullish coalescing operator for any and unknown types (#44862) We should not make assumptions about the any and unknown types; using a nullish coalescing operator is acceptable for those. PR Close #44862 31 January 2022, 20:31:58 UTC
f0d572e Esteban Gehring 26 January 2022, 16:15:45 UTC docs(core): showcase host listener support for specific keys in events (#44833) PR Close #44833 31 January 2022, 20:30:45 UTC
7a81481 Jessica Janiuk 14 December 2021, 23:27:28 UTC perf(animations): Remove generic objects in favor of Maps (#44482) We were using a number of generic objects as if they were maps and relying on delete to remove properties. In order to improve performance, these have been switched to native maps. PR Close #44482 31 January 2022, 20:28:43 UTC
55b1808 Juri Strumpflohner 31 January 2022, 16:15:07 UTC docs: update Nx headline (#44910) PR Close #44910 31 January 2022, 19:46:36 UTC
8d9eb99 Aristeidis Bampakos 31 January 2022, 09:48:45 UTC docs: add code format in content projection guide (#44907) PR Close #44907 31 January 2022, 19:45:47 UTC
3d07d1f George Kalpakas 30 January 2022, 19:23:24 UTC fix(docs-infra): make it possible to see whole notification text on smaller screens (#44900) Previously, when the notification text did not fit on the viewport width, it got truncated and it was not possible to see the whole text. This commit fixes this by making the notification scrollable when the text overflows. PR Close #44900 31 January 2022, 19:44:52 UTC
2320025 George Kalpakas 30 January 2022, 19:07:56 UTC fix(docs-infra): make it easier to interact with notification on smaller screens (#44900) On smaller screens, the action button in `NotificationComponent` is hidden (due to limited horizontal screen "real estate"). Thus, the only way to perform the action is to click on the notification message, which is typically a link. Previously, the link inside the notification did not take up the whole height of the notification bar. As a result, clicking outside the link would dismiss the notification without following the link. This commit makes it easier to interact with the notification (esp. on smaller screens) by ensuring the link covers the whole notification bar (width and height). PR Close #44900 31 January 2022, 19:44:52 UTC
390a653 Renovate Bot 29 January 2022, 12:01:59 UTC build: update dependency d3 to v7 (#44892) PR Close #44892 31 January 2022, 19:43:34 UTC
dea30d4 Renovate Bot 29 January 2022, 09:34:09 UTC build: update dependency @types/send to ^0.17.0 (#44890) PR Close #44890 31 January 2022, 19:40:31 UTC
a8686c6 Renovate Bot 29 January 2022, 09:33:40 UTC build: update dependency @types/chrome to ^0.0.177 (#44889) PR Close #44889 31 January 2022, 19:35:57 UTC
e62f010 George Kalpakas 29 January 2022, 08:46:09 UTC build(docs-infra): upgrade cli command docs sources to db5e7c82e (#44888) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/9ac3df5d1...db5e7c82e): **Modified** - help/build.json - help/e2e.json - help/extract-i18n.json - help/serve.json - help/test.json - help/update.json PR Close #44888 31 January 2022, 19:33:37 UTC
3f0a2d3 JimMorrison723 27 January 2022, 20:36:16 UTC fix(devtools): show date type property value in preview (#44864) Values of Date properties were not shown in the preview. It was formatted to a simple string thus not giving valuable info to the developer. PR Close #44864 31 January 2022, 19:32:47 UTC
b1b4547 Andrew Scott 29 January 2022, 00:53:39 UTC refactor(compiler-cli): Update where and how the indexed errors are exposed (#44884) The initial commit e9124b42d5ac8f570b53a86691aff64d9f6c6ee1 stored the errors rather than throwing but did not store them in a place that was accessible to consumers. Instead, the errors should be added to the IndexedComponent so they can be surfaced where the index results are consumed PR Close #44884 31 January 2022, 18:36:55 UTC
10092f2 Paul Gschwendtner 31 January 2022, 17:13:39 UTC build: fix formatting in zone.js BUILD file (#44912) Fixes formatting in one of the Zone BUILD files. The lint check on the renovate branch did not check formatting as it seems. Needs more investigation as the PR was green. PR Close #44912 31 January 2022, 17:35:45 UTC
0650066 George Kalpakas 30 January 2022, 17:35:40 UTC Revert "fix(docs-infra): content overflow in mobile (#44851)" (#44899) This reverts commit c2e09e09114977fcdc93cd60db57e4c863a12d9a, because it messes up the table layouts on some resolutions/pages. See #44891 for details. Fixes #44891 PR Close #44899 31 January 2022, 17:10:50 UTC
d614a97 Paul Gschwendtner 30 January 2022, 14:34:44 UTC build: update legacy saucelabs bundle generation to account for esbuild update (#44830) Previously with ESBuild 0.14.11, when a file had dynamic requires to builtin NodeJS modules like `url`, the resolution completed successfully regardless of `--platform browser`. This seems to be fixed in ESBuild now. This unveiled some resolution errors with our Saucelabs bundle generation because the framework code sometimes switches dynamically to `require('url')` if `window.URL` is not defined. Previously this just didn't matter, but now the `require('url')` is checked and a module resolution error is reported given `url` not being available in the browser as a builtin module. We fix this by marking the module as external. We will not hit this code path anyway in the browser saucelabs code. Similarly we exclude all platform-server files from the bundle. This is not strictly needed after the `url` module being marked as external, but the issue showed that lots of unnecessary code for the server platform is included. This can be omitted (unfortunately not from the TS compilation without over-complicating things significantly more; experimented with that). PR Close #44830 31 January 2022, 17:00:18 UTC
8817b08 Paul Gschwendtner 30 January 2022, 13:59:57 UTC build: update postinstall patch to account for benchmark macro changes (#44830) Updates the postinstall patch for the benchmark macro rule from dev-infra. We moved the ZoneJS setup to the bundler. This was necessary in order to switch away from the Go-based (windows-incompatible, m1-incompatible) concatjs devserver to a rather basic HTTP server (also provided by dev-infra now). PR Close #44830 31 January 2022, 17:00:18 UTC
23732bf Renovate Bot 30 January 2022, 13:31:54 UTC build: update angular (#44830) PR Close #44830 31 January 2022, 17:00:18 UTC
deb9531 Dylan Hunn 28 January 2022, 18:35:10 UTC fix(forms): Update the typed forms migration schematic to find all files. (#44881) We were breaking out of the loop that walks the source tree due to an incorrect return. PR Close #44881 28 January 2022, 21:59:34 UTC
9229511 Paul Gschwendtner 28 January 2022, 16:12:48 UTC build: bump version for `@angular/benchpress` to v0.2.2 (#44879) Bumps the version for benchpress to v0.2.2 so that a new version is available on NPM with Angular v13 support. This would be needed for dev-infra which exposes tooling for benchmarks relying on the Angular benchpress NPM package. PR Close #44879 28 January 2022, 18:02:26 UTC
c2e09e0 fru2 27 January 2022, 08:32:35 UTC fix(docs-infra): content overflow in mobile (#44851) When reading the docs page on mobile, some page tend to scroll in horizontal direction quite a lot which is unpleasant Fixes #44850 PR Close #44851 28 January 2022, 18:01:47 UTC
a8fca09 Maarten Tibau 27 January 2022, 12:22:42 UTC docs: fix typo in update guide (#44853) PR Close #44853 28 January 2022, 17:37:24 UTC
f490c2d Dylan Hunn 27 January 2022, 02:16:10 UTC feat(forms): support negative indices in FormArray methods. (#44848) This new feature allows negative indices to wrap around from the back, just like ES2021 `Array.at`. In particular, the following methods accept negative indices, and behave like corresponding Array methods: * `FormArray.at(index)`: behaves the same as `Array.at(index)` * `FormArray.insert(index, control)`: behaves the same as `Array.splice(index, 0, control)` * `FormArray.setControl(index, control)`: behaves the same as `Array.splice(index, 1, control)` * `FormArray.removeAt(index, control)`: behaves the same as `Array.splice(index, 1)` Previous work in #44746 and #44631 (by @amitbeck). Issue #44642. Co-authored-by: Amit Beckenstein <amitbeck@gmail.com> PR Close #44848 28 January 2022, 16:58:29 UTC
156fb37 Aristeidis Bampakos 28 January 2022, 09:57:20 UTC docs: fix GitHub broken link in update guide (#44875) PR Close #44875 28 January 2022, 16:08:28 UTC
c577a1d George Kalpakas 26 January 2022, 18:43:35 UTC fix(docs-infra): fix links to CLI commands source code (#44835) Recently, the [CLI repository][1] switched to not prefixing tag names with a `v`. Update the `versionInfo` generated for CLI commands docs, so that the links to the source code (which include the tag name) are correct. Fixes #44822 [1]: https://github.com/angular/angular-cli PR Close #44835 28 January 2022, 16:07:47 UTC
f1a5145 Theodore Brown 16 June 2020, 22:42:57 UTC refactor(forms): remove dead code (#37614) This functionally dead code was originally introduced via pull request were added to verify the fix, and the many comments on that issue after it was closed indicate that it wasn't actually resolved. In fact, setting `selectedIndex` does absolutely nothing here, since the selected index is immediately overridden by setting the `value` property. A working fix (with tests) for the IE/Safari bug is in pull request #23784. Originally this dead code was removed as part of that PR, but @AndrewKushnir recommended creating a separate PR for the cleanup. PR Close #37614 28 January 2022, 16:07:11 UTC
07f827e dario-piotrowicz 19 January 2022, 20:46:01 UTC docs(core): edit and add docs for ng-container (#44762) PR Close #44762 28 January 2022, 15:55:32 UTC
910de8b Andrew Scott 14 June 2021, 20:43:04 UTC feat(router): Add `Route.title` with a configurable `TitleStrategy` (#43307) This commit provides a service, `PageTitleStrategy` for setting the document page title after a successful router navigation. Users can provide custom strategies by extending `TitleStrategy` and adding a provider which overrides it. The strategy takes advantage of the pre-existing `data` and `resolve` concepts in the Router implementation: We can copy the `Route.title` into `data`/`resolve` in a non-breaking way by using a `symbol` as the key. This ensures that we do not have any collisions with pre-existing property names. By using `data` and `resolve`, we do not have to add anything more to the router navigation pipeline to support this feature. resolves #7630 PR Close #43307 27 January 2022, 22:02:33 UTC
c12110f Andrew Kushnir 27 January 2022, 21:25:25 UTC docs: update survey id (#44865) The survey id is used as a key in the local storage to keep the state (don't show the message again). Reusing this survey id will make the message invisible to some users who already have that key in local storage. PR Close #44865 27 January 2022, 21:52:35 UTC
7b7d644 Paul Gschwendtner 27 January 2022, 14:19:14 UTC refactor: fix type checking error with devtools state-serializer spec (#44735) Fixes an error in the satte-serializer spec: ``` devtools/projects/ng-devtools-backend/src/lib/state-serializer/state-serializer.spec.ts:103:60 - error TS2345: Argument of type '{ name: string; children: { name: string; children: { name: number; children: { name: number; children: { name: string; }[]; }[]; }[]; }[]; }[]' is not assignable to parameter of type 'NestedProp[]'. Type '{ name: string; children: { name: string; children: { name: number; children: { name: number; children: { name: string; }[]; }[]; }[]; }[]; }' is not assignable to type 'NestedProp'. Types of property 'children' are incompatible. Type '{ name: string; children: { name: number; children: { name: number; children: { name: string; }[]; }[]; }[]; }[]' is not assignable to type 'NestedProp[]'. Type '{ name: string; children: { name: number; children: { name: number; children: { name: string; }[]; }[]; }[]; }' is not assignable to type 'NestedProp'. Types of property 'children' are incompatible. Type '{ name: number; children: { name: number; children: { name: string; }[]; }[]; }[]' is not assignable to type 'NestedProp[]'. Type '{ name: number; children: { name: number; children: { name: string; }[]; }[]; }' is not assignable to type 'NestedProp'. Types of property 'children' are incompatible. Type '{ name: number; children: { name: string; }[]; }[]' is not assignable to type 'NestedProp[]'. Type '{ name: number; children: { name: string; }[]; }' is not assignable to type 'NestedProp'. Types of property 'children' are incompatible. Type '{ name: string; }[]' is not assignable to type 'NestedProp[]'. Property 'children' is missing in type '{ name: string; }' but required in type 'NestedProp'. 103 const result = deeplySerializeSelectedProperties(dir1, QUERY_1_2); ``` PR Close #44735 27 January 2022, 21:51:28 UTC
a82165e Paul Gschwendtner 26 January 2022, 14:20:00 UTC test(docs-infra): fix type checking errors with new jasmine types (#44735) The jasmine types for `spyObj.calls().all()` seem to be more specific, relying on `ThisType<Fn>` to determine the context/receiver for an invoked spy. This type does not work as expected with class members as it seems. This commit fixes three of these type checking failures by explicitly casting the spy context to the actual class owning the method member. PR Close #44735 27 January 2022, 21:51:28 UTC
362e07b Renovate Bot 26 January 2022, 12:45:35 UTC build: update angular (#44735) PR Close #44735 27 January 2022, 21:51:28 UTC
d12d7f2 Renovate Bot 25 January 2022, 17:37:08 UTC build: lock file maintenance (#44735) PR Close #44735 27 January 2022, 21:51:28 UTC
1312ac1 mgechev 27 January 2022, 18:51:24 UTC docs: enable the survey banner (#44861) PR Close #44861 27 January 2022, 19:43:54 UTC
df50af2 Paul Gschwendtner 26 January 2022, 11:00:28 UTC ci: only build test targets for components repo unit test job (#44832) To speed up the components CI job (avoiding it being a bottleneck in FW), we will stop building everything in `src/...`, but rather only build targets which are needed to run all tests within `src/...`. This notably should avoid unnecessary NPM package building. Arguably that part would also be valuable to have, but we already test the `ng_package` rule in FW itself, plus we run snapshot tests in the components repo as well. PR Close #44832 27 January 2022, 17:22:23 UTC
15df7eb Paul Gschwendtner 26 January 2022, 10:26:08 UTC ci: re-enable components repo unit tests job (#44832) Re-enables the components-repo unit tests job that we previously disabled due to the devmode target change that caused conflicts with `angular/components` patching `ng_module.bzl` of `@angular/bazel`. PR Close #44832 27 January 2022, 17:22:23 UTC
e9124b4 Andrew Scott 24 January 2022, 21:37:52 UTC refactor(compiler-cli): Tolerate source span errors in indexer (#44825) When the indexer encounters a location where the source span doesn't match up with the expected identifier, the current visitor code throws an error. Instead, this change creates an error and moves on to the next template item. This allows the indexer to continue analysis even when there are errors in the source mapping. In addition, it still allows callers to surface those errors in their own way while still providing as much indexed information as possible about a node. PR Close #44825 27 January 2022, 17:20:09 UTC
eb11bcb Renovate Bot 24 January 2022, 09:46:45 UTC build: update dependency globby to v13 (#44801) PR Close #44801 27 January 2022, 17:18:58 UTC
a03f80a Renovate Bot 27 January 2022, 00:09:43 UTC build: update dependency rules_pkg to v0.6.0 (#44818) PR Close #44818 27 January 2022, 01:37:41 UTC
e5e8161 Dylan Hunn 26 January 2022, 17:37:41 UTC Revert "refactor(forms): Temporarily disable the typed forms migration. (#44828) (#44834) This reverts commit 894fa759f1eba6de1960b08d511ce4332a423ae5. In that commit, the migration was completely diabled in order to prevent users from selecting it for the 13.2 release. This revert commit restores the migration to its previous (fully optional) state, in order to continue migration-focused work. PR Close #44834 27 January 2022, 01:36:58 UTC
c020f60 AleksanderBodurri 26 January 2022, 22:26:22 UTC ci: reenable CI checks for commit message validation and rebasing on target branch (#44845) These checks were temporarily disabled in order to support the angular devtools migration to the angular/angular repo. Now that devtools was merged, we can safely enable these checks again. PR Close #44845 26 January 2022, 22:33:47 UTC
8fb3aed AleksanderBodurri 21 January 2022, 18:06:00 UTC docs(devtools): update comment to better reflect what angular version is running in g3. PR Close #43473 26 January 2022, 22:18:32 UTC
f7541e5 AleksanderBodurri 21 January 2022, 18:01:08 UTC refactor(devtools): remove LICENSE file in the devtools directory This file was carried over from the original angular devtools repo. Now that devtools has been merged into angular/angular, this file is no longer necessary, because the root of this repo has its own LICENSE file. 26 January 2022, 21:35:31 UTC
5e9b411 AleksanderBodurri 21 January 2022, 17:59:46 UTC ci: sort devtools pullapprove reviewers in alphabetical order Previously this list was not in any order. This commit puts the reviewer list in alphabetical order to be consistent with how other groups order reviewers 26 January 2022, 21:35:31 UTC
5b7d185 AleksanderBodurri 20 January 2022, 00:56:57 UTC refactor(devtools): disable cypress and remove dependencies Previously we were running Cypress in CI. Since cypress needs to be installed to run these tests, it was decided that we would not run devtools' cypress tests until a decision could be made on an e2e testing solution. This commit removes all package scripts, dependencies, and CI commands that reference cypress. Notably it leaves the actual tests in the devtools directory intact, so that they can be referenced later once a decision is made. 26 January 2022, 21:35:31 UTC
445fbf8 AleksanderBodurri 16 December 2021, 07:00:43 UTC refactor(devtools): bring the angular devtools directory into the root bazel workspace Previously devtools used a nested workspace for its bazel configurations. This meant framework dependencies were consumed via npm. Now devtools is part of the root bazel directory that all other files in this codebase fall under. This allows us to build devtools using local angular packages, removing the need to consume these dependencies with npn. This is useful because we no longer have to update these dependencies with an automated tool like renovate, and our CI tests will always run against the most up to date framework packages. 26 January 2022, 21:35:31 UTC
7ed57f2 AleksanderBodurri 10 December 2021, 22:11:20 UTC refactor(devtools): add override to classes that extend abstract classes in the devtools directory Previously the typescript override keyword was not on these methods. Now that devtools uses the tslint config in angular/angular (because of the no-implicit-override-abstract rule) we need to add these key words explicitly to method overrides. That is what this commit does. 26 January 2022, 21:35:31 UTC
1f70ac2 AleksanderBodurri 10 December 2021, 05:53:20 UTC refactor(devtools): remove rules_sass patch Previously a workaround patch was needed because rules_sass didn't support v4 of rules_nodejs. This commit updates rules_sass to a version that does and removes the patch. 26 January 2022, 21:35:31 UTC
2a1ff17 AleksanderBodurri 10 December 2021, 02:37:01 UTC refactor(devtools): run tslint --fix on devtools codebase This commit runs tslint --fix with the angular/angular tslint configuration on the files inside the devtools codebase. Notably, the file-header rule in `tslint.json` was missing a default attribute. This commit adds that default attribute and sets it to the license header that is present in all files in this repo. After running tslint --fix with this default added, this commit added the license header to all files in the devtools directory. Note for the reviewer: the automatically added license headers were added as comments with the "/*!" prefix. Since we want these comments removed in builds, and the rest of the codebase uses "/**", a simple find and replace was performed on the devtools directory to change these prefixes to "/**". 26 January 2022, 21:35:31 UTC
4943564 AleksanderBodurri 09 December 2021, 08:57:11 UTC ci: change the devtools test executor to test-browser-executor and remove tasks in the test_angular_devtools job that installed test dependencies manually This commit also disables cypress' video recording feature to save time on running Cypress tasks in CI. 26 January 2022, 21:35:30 UTC
6b06fa3 AleksanderBodurri 09 December 2021, 08:41:40 UTC refactor(devtools): make bazel labels follow snake case convention Previously, camel case was used for bazel labels in the devtools directory. This commit changes these labels to snake case except in the case where the label is identical to the directory name that the BUILD file is in. 26 January 2022, 21:35:30 UTC
27a9b9f AleksanderBodurri 09 December 2021, 07:49:55 UTC refactor(devtools): remove inaccurate comment in bazelrc and defaults.bzl Both of these comments were included accidentally after porting over bazel code from angular/angular and angular/components to devtools. They are not relevant to devtools so this commit removes them. 26 January 2022, 21:35:30 UTC
9c13d48 AleksanderBodurri 09 December 2021, 07:37:10 UTC refactor(devtools): clean up some of tooling brought in from angular/components Removes MDC constants and unneeded angular package configs from packages.bzl. Removes partial-compilation-integration from the karma web test tags because we don't perform any of partial compilation integration tests for devtools. 26 January 2022, 21:35:30 UTC
075787b AleksanderBodurri 09 December 2021, 07:34:06 UTC refactor(devtools): remove unneeded tsconfig keyword args for ts_project These keyword args are not needed because `ts_project` and `ng_ts_project` already default to the tsconfig at the root of the devtools directory. This commit removes these key word args from places where tsconfig was used as a keyword arg with the root level tsconfig as the target. 26 January 2022, 21:35:30 UTC
2277f9a AleksanderBodurri 09 December 2021, 06:17:42 UTC refactor(devtools): remove redundant project files Previously angular devtools was in its own repository and so it had some project files related to github workflows, vscode settings, prettier configurations, etc. Now, after devtools has been transfered to angular/angular, these files are redundant, and so this commit removes them. 26 January 2022, 21:35:30 UTC
8b84412 AleksanderBodurri 09 December 2021, 05:44:17 UTC refactor(devtools): run ng-dev format on angular devtools files Formats the entire devtools directory with the ng-dev formatting tool. Previously we relied on prettier, so this commit also remove prettier from devtools' dependencies. 26 January 2022, 21:35:30 UTC
ac387e2 AleksanderBodurri 08 December 2021, 04:50:14 UTC ci: add aleksanderbodurri to angular devtools pullapprove reviewers 26 January 2022, 21:35:30 UTC
3438501 AleksanderBodurri 01 December 2021, 18:49:47 UTC test(devtools): fix some flakey cypress tests Uses `cy.contains` as one command to optimize cypress' retry-ability mechanism Affected tests are in: `property-update.e2e.js` and `view-component-metadata.e2e.js` 26 January 2022, 21:35:30 UTC
50188e5 AleksanderBodurri 01 December 2021, 16:08:25 UTC ci: add angular devtools to the renovate configuration Previously angular devtools was using its own renovate configuration to keep up to date. After transfering to angular/angular, we can use the renovate configuration in angular/angular to update our dependencies. In an end state we would build devtools with local Angular packages. 26 January 2022, 21:35:30 UTC
c24924c AleksanderBodurri 01 December 2021, 06:13:17 UTC build(devtools): use ng-dev stamp tooling to stamp the latest git SHA in devtools Previously, we were using ngx-build-plus with a custom webpack config to determine the git SHA at runtime. Now, after migrating to bazel and transfering to angular/angular, this commit uses ng-dev to stamp the latest git SHA directly in angular devtools' application environment. This commit also removes the old webpack configs. 26 January 2022, 21:35:30 UTC
e5cdd33 AleksanderBodurri 01 December 2021, 04:41:58 UTC ci: add labels to angular devtools ci tasks This commit also cleans up the .bazelrc file in the devtools directory 26 January 2022, 21:35:30 UTC
aab59c1 AleksanderBodurri 01 December 2021, 02:51:06 UTC refactor(devtools): dedupe some bazel tooling brought in from angular/components Some tooling was brought in from angular/components to help with bundling spec files for Karma. This tooling has since been ported over to the dev-infra repo. This commit dedupes the tooling and instead depends on the angular/dev-infra-private repo. 26 January 2022, 21:35:30 UTC
6a659a5 AleksanderBodurri 29 November 2021, 05:22:06 UTC ci: remove bazel cypress tests Previously we were running Cypress with bazel in an effort to save on CI time when devtools dependencies did not change. This commit reverts to running Cypress manually, until we can revisit building devtools with local Angular packages to save CI time. 26 January 2022, 21:35:30 UTC
back to top