https://github.com/angular/angular

sort by:
Revision Author Date Message Commit Date
f0b5e83 build(bazel): change ngc-wrapped to use new bazelOpts.devmode (#45804) bazelOpts.es5Mode is being removed and replaced with devmode. Adding a check for either will allow a smooth migration. PR Close #45804 02 May 2022, 20:10:06 UTC
0eee114 docs: remove css keyframes scoping change from changelog (#45840) remove the css keyframes scpoing change present in the changelog since that commit has actually been reverted PR Close #45840 02 May 2022, 19:00:00 UTC
fde4942 fix(core): throw if standalone components are present in `@NgModule.bootstrap` (#45825) This commit updates the logic to detect a situation when a standalone component is used in the NgModule-based bootstrap (`@NgModule.bootstrap`). Both AOT and JIT compilers are updated to handle this situation. PR Close #45825 02 May 2022, 18:43:17 UTC
9a04ded docs(docs-infra): improve clarity of toh-pt2 click code snippet (#45829) make clearer that the click code snippet present in the tour of heroes part 2 guide is not complete but adding ellipsis at the end of the snippet and also by slightly tweaking the text introducing the snippet resolves #45758 PR Close #45829 02 May 2022, 18:42:12 UTC
e702caf feat(core): allow to throw on unknown elements in tests (#45479) Allows to provide a TestBed option to throw on unknown elements in templates: ```ts getTestBed().initTestEnvironment( BrowserDynamicTestingModule, platformBrowserDynamicTesting(), { errorOnUnknownElements: true } ); ``` The default value of `errorOnUnknownElements` is `false`, so this is not a breaking change. PR Close #45479 02 May 2022, 16:38:13 UTC
6a3ca0e Revert "feat(core): allow to throw on unknown elements in tests (#45479)" (#45839) This reverts commit 6662a97c61f133a14f2d117f71e4d2b8f4a83c32. PR Close #45839 02 May 2022, 16:36:28 UTC
9c2f219 build: update ng-dev with updated clang-format version to fix formatting (#45834) Updates ng-dev to the latest clang-format version which fixes the AMD x64 binaries. PR Close #45834 02 May 2022, 16:28:40 UTC
6662a97 feat(core): allow to throw on unknown elements in tests (#45479) Allows to provide a TestBed option to throw on unknown elements in templates: ```ts getTestBed().initTestEnvironment( BrowserDynamicTestingModule, platformBrowserDynamicTesting(), { errorOnUnknownElements: true } ); ``` The default value of `errorOnUnknownElements` is `false`, so this is not a breaking change. PR Close #45479 02 May 2022, 16:22:34 UTC
8315974 fix(docs-infra): fix wrong heading structure in aio resources page (#45822) in the aio resources page there is a main h1 heading and then the next headings used are h3 and h4, thus h2 is being skipped, change such headings so that there is no heading skipping (which is a bad practice and can result to confusing experiences from screen reader users) PR Close #45822 02 May 2022, 16:20:36 UTC
a88bf20 refactor(compiler-cli): increase minimum version of partial declarations (#45782) In v14, the partial compilation output of components have changed in a way that prevents older versions of Angular to compile the partial declarations correctly. In particular, we used to emit used directives/components in separate arrays called `components` and `directives`, and used pipes in a property called `pipes`: ```js TestComponent.ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "12.0.0", version: "13.3.0", type: TestComponent, selector: "ng-component", ngImport: i0, template: ``, isInline: true, directives: [{ type: i1.SomeDir, selector: "[some-dir]" }], components: [{ type: i1.SomeCmp, selector: "some-cmp" }], pipes: { 'async': i2.AsyncPipe }, }); ``` In the above example, the `version` property indicates which exact compiler version was used to compile the component, but the `minVersion` allows older versions of the compiler/Angular linker to "link" the partial declaration to its final AOT compilation output. In v14, the used directives, components and pipes are now emitted together into a single array under the `dependencies` property: ```js TestComponent.ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "12.0.0", version: "13.3.0", type: TestComponent, selector: "ng-component", ngImport: i0, template: ``, isInline: true, dependencies: [ { kind: "directive", type: i1.SomeDir, selector: "[some-dir]" }, { kind: "component", type: i1.SomeCmp, selector: "some-cmp" }, { kind: "pipe", type: i2.AsyncPipe }, ], }); ``` This change has been made in support of standalone components, but it does mean that older compiler versions can no longer link these partial declarations as desirable as none of the components, directives and pipes would be included in the AOT-compiled code. By increasing the `minVersion` property, we hint to older compiler versions that they are not capable of processing the partial declaration. This allows reporting an error at compile time instead of resulting in runtime failures due to missing components, directives and pipes. PR Close #45782 29 April 2022, 21:19:16 UTC
dff5586 feat(platform-server): implement `renderApplication` function (#45785) This commit adds the `renderApplication` function to bootstrap an Angular app using a root standalone component to support SSR scenarios. PR Close #45785 29 April 2022, 21:18:54 UTC
e1454ae build(common): update CLDR to version 41 (#45714) Update CLDR, which is used to generate the locales files, to version 41. Also, make necessary code changes to account for changes in the CLDR data. Fixes #43301 PR Close #45714 29 April 2022, 16:20:08 UTC
57a9c17 build(common): specify CLDR version to use by `cldr` (#45714) While generating locales, two sets of data (both derived from the [CLDR project][1]) are used: - JSON data with the [`cldrjs` package][2], which is used for most operations. - XML data with the [`cldr` package][3], which is used for generating plural-related data. The JSON data is brought in from the [unicode-org/cldr-json][4] repository. Since we control the version of the repository that we use, we can control the CLDR version that these correspond to. Previously, however, we used the XML data that were bundled with the [`cldr` package[3]. As a result, the two sets of data could correspond to different CLDR versions, resulting in incorrect/inconsistent locales files. This commit addresses the problem by utilizing the `load()` method of the [`cldr` package][3], which allows passing in a custom path to the CLDR XML data (instead of using the bundled data. This way, we can ensure that the data used for all operations correspond to the same CLDR version. Related discussion: #43301 [1]: https://github.com/unicode-org/cldr [2]: https://www.npmjs.com/package/cldrjs [3]: https://www.npmjs.com/package/cldr [4]: https://github.com/unicode-org/cldr-json PR Close #45714 29 April 2022, 16:20:08 UTC
61b6b4f refactor(common): minor refactoring/simplification in `generate-locales-tool` (#45714) Make some minor changes in `generate-locales-tool` to make the code simpler and/or avoid unnecessary work. PR Close #45714 29 April 2022, 16:20:08 UTC
521bfc1 refactor(common): improve `dayPeriods`-related types in `generate-locales-tool` (#45714) Update some TypeScript types in `generate-locales-tool/day-periods.ts` to more closely reflect the actual shapes of the returned objects. Examples of the related raw JSON data for the `en` locale can be seen here: - [dayPeriods][1] - [dayPeriodRules][2] [1]: https://github.com/unicode-org/cldr-json/blob/41.0.0/cldr-json/cldr-dates-full/main/en/ca-gregorian.json#L223-L300 [2]: https://github.com/unicode-org/cldr-json/blob/41.0.0/cldr-json/cldr-core/supplemental/dayPeriods.json#L404-L427 PR Close #45714 29 April 2022, 16:20:08 UTC
0e5e4e2 refactor(common): consistently name tooling related to `closure-locale.ts` (#45714) Previously, some functions/targets related to the generation/verification of the `closure-locale.ts` file included `closure_locales` instead of `closure_locale` in their name, which was inconsistent and confusing. Rename all tooling to use `closure_locale` (which more closely matches the generated file's name). PR Close #45714 29 April 2022, 16:20:08 UTC
29039fc feat(core): support TypeScript 4.7 (#45749) Adds support for TypeScript 4.7. Changes include: * Bumping the TS version as well as some Bazel dependencies to include https://github.com/bazelbuild/rules_nodejs/pull/3420. * Adding a backwards-compatibility layer for calls to `updateTypeParameterDeclaration`. * Making `LView` generic in order to make it easier to type the context based on the usage. Currently the context can be 4 different types which coupled with stricter type checking would required a lot of extra casting all over `core`. * Fixing a bunch of miscellaneous type errors. * Removing assertions of `ReferenceEntry.isDefinition` in a few of the language service tests. The field isn't returned by TS anymore and we weren't using it for anything. * Resolving in error in the language service that was caused by TS attempting to parse HTML files when we try to open them. Previous TS was silently setting them as `ScriptKind.Unknown` and ignoring the errors, but now it throws. I've worked around it by setting them as `ScriptKind.JSX`. PR Close #45749 29 April 2022, 16:19:45 UTC
fcc548a test(core): verify inheritance for standalone components (#45796) This commit verifies that component inheritance works properly for various combinations of standalone and non-stndalone components. PR Close #45796 29 April 2022, 16:19:04 UTC
d4fc12f fix(router): Remove deprecated initialNavigation option (#45729) BREAKING CHANGE: `initialNavigation: 'enabled'` was deprecated in v11 and is replaced by `initialNavigation: 'enabledBlocking'`. PR Close #45729 28 April 2022, 21:40:03 UTC
aba8fb5 build: update ng-dev to latest snapshot build (#45805) Updates ng-dev to the latest snapshot build, with an improvement to the `new-main-branch` command. PR Close #45805 28 April 2022, 18:53:29 UTC
3a60063 build: updates to account for github primary branch rename This is the commit accounting for the Github primary branch rename when we actually perform the update. We have three change phases: Prepare, Direct, Cleanup. This commit is for the `direct` phase. 28 April 2022, 17:17:01 UTC
b596a50 build: update dev-infra to latest snapshot (#45800) Updates dev-infra to the latest snapshot, supporting for the new migrate to main helper command. PR Close #45800 28 April 2022, 17:14:04 UTC
8dda463 refactor(core): do not allow `standalone` flag overrides via TestBed APIs (#45788) This commit adds a check into the TestBed APIs to throw an error if the `standalone` flag is overridden. PR Close #45788 28 April 2022, 16:47:26 UTC
0840ece build: lock file maintenance (#45751) PR Close #45751 28 April 2022, 16:39:06 UTC
a097be9 test(core): verify `importProvidersFrom` work correctly with `ModuleWithProviders` (#45787) This commit adds a test to make sure the NgModule providers are collected correctly by the `importProvidersFrom` function when the `ModuleWithProviders` type is used and some providers are overridden. PR Close #45787 28 April 2022, 16:37:54 UTC
4e413d9 fix(core): support nested arrays of providers in `EnvironmentInjector` (#45789) This commit updates the `EnvironmentInjector` logic to support arrays of providers as an argument(for example, when an injector is created via `createEnvironmentInjector` function). PR Close #45789 28 April 2022, 16:37:18 UTC
2941793 test(core): verify nested array in standalone component imports (#45794) This test verifies that nested arrays are supported in the standalone's component import field. PR Close #45794 28 April 2022, 16:35:45 UTC
14c4979 build(docs-infra): upgrade cli command docs sources to f258be5be (#45795) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/5bd17a256...f258be5be): **Modified** - help/generate.json PR Close #45795 28 April 2022, 16:34:31 UTC
2f5fd41 refactor(core): verify that standalone entities are not declared in NgModule (#45777) This commits adds JiT checks to verify that a standalone component, directive, pipe are not declared in any NgModule. PR Close #45777 27 April 2022, 22:46:10 UTC
aafac72 fix(core): verify standalone component imports in JiT (#45777) This commits adds verifications assuring that items imported into standalone components are one of: - standalone component / directive / pipe; - NgModule; - forwardRef resolving to one of the above. It explicitly disallows modules with providers. PR Close #45777 27 April 2022, 22:46:09 UTC
58e8f4b Revert "fix(compiler): scope css keyframes in emulated view encapsulation (#42608)" (#45786) This reverts commit 4d6a1d672210219328b33f4f96210870563066ee. PR Close #45786 27 April 2022, 22:00:41 UTC
f3eb7d9 fix(core): Ensure the `StandaloneService` is retained after closure minification (#45783) In order to survive closure minification correctly, static properties need to be annotated with @nocollapse. For more history, see https://github.com/angular/angular/pull/28050 PR Close #45783 27 April 2022, 20:05:33 UTC
b9a07d6 release: cut the v14.0.0-next.15 release (#45784) 27 April 2022, 19:01:09 UTC
c589e4d docs: release notes for the v13.3.5 release (#45781) 27 April 2022, 18:50:36 UTC
4d6a1d6 fix(compiler): scope css keyframes in emulated view encapsulation (#42608) Ensure that keyframes rules, defined within components with emulated view encapsulation, are scoped to avoid collisions with keyframes in other components. This is achieved by renaming these keyframes to add a prefix that makes them unique across the application. In order to enable the handling of keyframes names defined as strings the previous strategy of replacing quoted css content with `%QUOTED%` (introduced in commit 7f689a2) has been removed and in its place now only specific characters inside quotes are being replaced with placeholder text (those are `;`, `:` and `,`, more can be added in the future if the need arises). Closes #33885 BREAKING CHANGE: Keyframes names are now prefixed with the component's "scope name". For example, the following keyframes rule in a component definition, whose "scope name" is host-my-cmp: @keyframes foo { ... } will become: @keyframes host-my-cmp_foo { ... } Any TypeScript/JavaScript code which relied on the names of keyframes rules will no longer match. The recommended solutions in this case are to either: - change the component's view encapsulation to the `None` or `ShadowDom` - define keyframes rules in global stylesheets (e.g styles.css) - define keyframes rules programmatically in code. PR Close #42608 27 April 2022, 17:27:17 UTC
3d45484 refactor(compiler-cli): support schemas in standalone components (#45752) This commit adds support for `@Component.schemas` in both JIT and AOT. PR Close #45752 27 April 2022, 17:25:53 UTC
2eb39c0 fix(devtools): inline loading svg (#45762) * inlined loading animation svg instead of using absolute url * removing unused assets folder from the build PR Close #45762 27 April 2022, 16:07:38 UTC
7d8998c docs: empty alt of aio home decorative images (#45740) in the aio home page the sections' decorative images provide an alt texts, which shouldn't actually be present (see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such alt text for a better user experience PR Close #45740 27 April 2022, 16:06:12 UTC
a895da6 docs: use proper sections in aio home (#45740) convert the `div` groups in the aio home page to proper `section`s with a valid heading/title PR Close #45740 27 April 2022, 16:06:12 UTC
d1a9fd5 docs: make sure aio home has a non-ignored h1 (#45740) currently the aio home page presents a single h1 which is ignored by assistive technologies since it has its display set none, so replace it with a new h1 containing the main text of the page instead PR Close #45740 27 April 2022, 16:06:12 UTC
882f595 refactor(core): support `ModuleWithProviders` directly in `importProvidersFrom` (#45722) There were two problems with the `importProvidersFrom` function related to `ModuleWithProviders` values: * The public type did not accept `ModuleWithProviders` values directly. * The implementation of `walkProviderTree` delegates collection of MWP providers to its caller, in order for the ordering of such providers to be correct. However, `importProvidersFrom` was not performing that collection, causing MWP providers passed in at the top level to be dropped. PR Close #45722 27 April 2022, 16:05:51 UTC
3896f57 refactor(core): move ModuleWithProviders type (#45722) This commit moves the ModuleWithProviders type from `metadata` to `di`, avoiding the need for `di` to reference `metadata` (in this particular case). PR Close #45722 27 April 2022, 16:05:51 UTC
39c1681 test(core): add more tests for the standalone components (#45709) Add more tests verifying the following conditions: - discovery of DI providers from exported NgModules - forwardRef in standalone component imports PR Close #45709 27 April 2022, 16:05:33 UTC
f282ca4 fix(docs-infra): fix alert child margin issue (#45761) replace the generic `*` selector used in the alert styling with `p` (which is what gets generated from the markdown) as the styling adds margins which are not always wanted PR Close #45761 27 April 2022, 16:04:30 UTC
71f64f2 docs(upgrade): move import back into docregion in `rollup-config.js` (#45778) This was accidentally broken in #45405. PR Close #45778 27 April 2022, 16:04:09 UTC
2b5c2d6 refactor(core): create a standalone injector during applicationBootstrap (#45766) This commit changes the injectors hiearchy created during applicationBootstrap. From now on a standalone injector (holding all the ambient providers of a standalone component) is create as a child of the application injector. This change alligns injectors hierarchy for bootstrapped and dynamically created standalone components. PR Close #45766 27 April 2022, 16:03:50 UTC
7b367d9 refactor(router): Remove unnecessary setTimeout in UrlTree redirects (#45735) Using `setTimeout` in the Router navigation pipeline creates fragile and unpredictable behavior. Additionally, it creates a new macrotask, which would trigger an unnecessary change detection in the application. This `setTimeout` was added in https://github.com/angular/angular/commit/15e397816f98ec16839c30fd5c1ea01c7444fb84. Both tests added in that commit still pass. Additionally, the comment for _why_ the `setTimeout` was added doesn't really explain how the described bug would occur. There has been a lot of work in the Router since then to stabalize edge case scenarios so it's possible it existed before but doesn't anymore. Removing this `setTimeout` revealed tests that relied on the navigation not completing. For example, the test suite did not have a route which matched the redirect, but the test passed because it ended before the redirect was flushed, so the `Router` never threw an error. Similar situations exist for the other use of `setTimeout` in the Route (the one in the location change listener). There were no other failures in TGP other than incorrectly written tests. BREAKING CHANGE: When a guard returns a `UrlTree`, the router would previously schedule the redirect navigation within a `setTimeout`. This timeout is now removed, which can result in test failures due to incorrectly written tests. Tests which perform navigations should ensure that all timeouts are flushed before making assertions. Tests should ensure they are capable of handling all redirects from the original navigation. PR Close #45735 27 April 2022, 15:56:31 UTC
f1cc4a6 build: update tsec and drop corresponding postinstall patch (#45767) Updates tsec and drops the corresponding postinstall patch that we added when we updated to Bazel v5. See: https://github.com/google/tsec/pull/25 PR Close #45767 26 April 2022, 18:48:34 UTC
9d755fa build: update actions/checkout action to v3.0.2 (#45764) PR Close #45764 26 April 2022, 17:11:43 UTC
284329e refactor(core): delay standalone component scoping in JIT (#45720) This commit moves standalone component scoping into the closures for `directiveDefs` and `pipeDefs` in JIT mode. This is necessary to support recursive standalone components, which necessarily use a `forwardRef` within their import cycle. Previously, the JIT compiler for standalone components attempted immediate `forwardRef` resolution, resulting in infinite recursion. PR Close #45720 26 April 2022, 17:07:41 UTC
4e0784c refactor(compiler-cli): optimize InjectorDef imports generation (#45701) Before standalone, everything that could appear in an NgModule's `imports` was relevant to DI, and needed to be emitted in the `imports` of the generated `InjectorDef` definition. With the introduction of standalone types, NgModule `imports` can now contain components, directives, and pipes which are standalone. Only standalone components need to be included in the `imports` of the generated injector definition - directives and pipes have no effect on DI. Having them present doesn't cause any errors in the runtime (they're filtered out by the injector itself) but it does prevent tree-shaking. With this commit, the generation of `InjectorDef` now filters the `imports` to exclude directives and pipes as much as possible. It's not _always_ possible because an expression in `imports` may pull in both a directive and a `ModuleWithProviders` reference, and we have no way of referencing just the MWP part of that expression. Therefore this is an optimization, not a rule of `InjectorDef` compilation. PR Close #45701 26 April 2022, 17:07:23 UTC
b0379c8 refactor(compiler-cli): NgModule handler resolves `imports` individually (#45701) Previously, the NgModule handler would resolve the `imports` field as one unit, producing an array of `Reference`s. With this refactoring, if `imports` is a literal array, each individual element will be resolved independently. This will allow filtering in the future at the element level, since there will be a separate `ts.Expression` for each individual element. PR Close #45701 26 April 2022, 17:07:23 UTC
18db4ef refactor(compiler-cli): introduce ResolvedModuleWithProviders (#45701) This commit updates the `ForeignFunctionResolver` used by the NgModule handler to resolve `ModuleWithProvider` types. Previously, this resolver returned the NgModule `Reference` directly, but there are two problems with this: * It's not completely accurate, as the expression returned by the MWP call will not return the NgModule at runtime. * We need the ability to distinguish the MWP call itself from an ordinary NgModule reference in future optimizations. PR Close #45701 26 April 2022, 17:07:23 UTC
c614f31 refactor(compiler-cli): rework ForeignFunctionResolvers (#45701) This commit reworks the partial evaluation system's concept of a ForeignFunctionResolver. Previously, resolvers were expected to return a `ts.Expression` which the partial evaluator would continue evaluating, eventually returning a value. This works well for "transparent" foreign functions like `forwardRef`, but for things like `ModuleWithProviders` it breaks down, because the desired resolution value (the NgModule `Reference`) is _not_ the "correct" evaluation of the function call. To support better FFR implementations, this commit refactors the FFR system so that resolvers operate on the `ts.CallExpression` instead, and are given a callback to resolve further expressions if needed. If they cannot resolve a given call expression, they have an `unresolvable` value that they can return to indicate that. PR Close #45701 26 April 2022, 17:07:23 UTC
7992132 test(core): dynamic component creation and standalone injectors hierarchy (#45726) This commits adds more tests around dynamic component creation and environement injectors hierarchy. PR Close #45726 25 April 2022, 22:00:33 UTC
31d7c3b feat(common): add getState method to LocationStrategy interface (#45648) Adds getState to LocationStrategy interface as it suppose to be the place to control all window.location interactions. BREAKING CHANGE: Adds new required class member that any implementors of the LocationStrategy will need to satisfy. Location does not depend on PlatformLocation anymore. PR Close #45648 25 April 2022, 17:41:30 UTC
50004c1 feat(router): Support lazy loading standalone components with `loadComponent` (#45705) Similarly to the symmetry being strengthened between children and loadChildren, a new loadComponent property will be introduced as the asynchronous version of component. This will allow for direct single-component lazy loading: ``` {path: 'lazy/a', loadComponent: () => import('./lazy/a.component').then(m => m.ACmp)}, {path: 'lazy/b', loadComponent: () => import('./lazy/b.component').then(m => m.BCmp)}, ``` This option requires that the component being loaded is standalone and is implemented as a runtime check. Other notes: * Components are not loaded until all guards and resolvers complete. * Loading the component is included in the function passed to the router preloading strategy * `RouteConfigLoadStart` and `RouteConfigLoadEnd` events emit at the start and end of the component loading * `CanLoad` guards _do not_ apply to `loadComponent`. `canActivate` should be used instead, just like you would do if it were simply `component` instead. PR Close #45705 25 April 2022, 16:39:44 UTC
970a3b5 fix(bazel): add this_is_bazel marker (#45728) Add marker for noting that this check confirms we are running in a bazel environment. PR Close #45728 22 April 2022, 19:46:23 UTC
4962a4a feat(router): Allow `loadChildren` to return a `Route` array (#45700) This commit expands the `LoadChildrenCallback` to accept returning `Routes` in addition to the existing `NgModule` type. In addition, it adds a check to ensure these loaded routes all use standalone components. The components must be standalone because if they were not, we would not have the required `NgModule` which the component is declared in. Existing API: ``` {path: 'lazy/route', loadChildren: import('./lazy').then(m => m.LazyModule)} @NgModule({ imports: [ ExtraCmpModule, RouterModule.forChild([ {path: 'extra/route', component: ExtraCmp}, ]), ], }) export class LazyModule {} ``` The new API for lazy loading route configs with standalone components (no NgModule) is to expand `loadChildren` to allow returning simply a `Routes` array. ``` // parent.ts { path: 'parent', loadChildren: () => import('./children').then(m => m.ROUTES), } // children.ts export const ROUTES: Route[] = [ {path: 'child', component: ChildCmp}, ]; ``` Note that this includes minimal documentation updates. We need to include a holistic update to the documentation for standalone components in the future that includes this feature. PR Close #45700 22 April 2022, 16:25:20 UTC
3e46a42 test(core): add integration test apps for the `bootstrapApplication` API (#45674) This commit adds 2 integration apps to verify the `bootstrapApplication` API behavior as well as keep track of the bundle size and retained symbols (tree-shaking). PR Close #45674 22 April 2022, 00:47:54 UTC
5771b18 feat(core): add the `bootstrapApplication` function (#45674) This commit implements the `bootstrapApplication` function that allows bootstrapping an application and pass a standalone component as a root component. PR Close #45674 22 April 2022, 00:47:54 UTC
612d6e0 test: update size golden for hello-world-ivy-compat integration test (#45405) The main bundle fell below the 500b threshold. Likely because the global constant was fixed and is now tree-shakeable. The actual diff in the commit is a little confusing since it makes it seem that polyfills increased as part of this commit. This is not the case but just a side-effect of us accumulating various changes which are not reflected on a per-commit basis in the size golden. The actual sizes in master were: ``` SUCCESS: Commit undefined uncompressed runtime did NOT cross size threshold of 500 bytes or >1% (expected: 1105, actual: 1102). SUCCESS: Commit undefined uncompressed polyfills did NOT cross size threshold of 500 bytes or >1% (expected: 33846, actual: 33957). SUCCESS: Commit undefined uncompressed main did NOT cross size threshold of 500 bytes or >1% (expected: 132392, actual: 131893). ``` Now with this change: ``` SUCCESS: Commit undefined uncompressed runtime did NOT cross size threshold of 500 bytes or >1% (expected: 1105, actual: 1102). SUCCESS: Commit undefined uncompressed polyfills did NOT cross size threshold of 500 bytes or >1% (expected: 33846, actual: 33957). FAIL: Commit undefined uncompressed main fell below expected size by 500 bytes or >1% (expected: 132392, actual: 131883). ``` PR Close #45405 21 April 2022, 18:09:39 UTC
067e4c2 build: update systemjs aio boilerplate to work with APF v13+ `exports` field (#45405) The SystemJS examples were using an outdated version of rollup that did not support export fields. Now with the recent changes where we removed secondary package.json files, the rather old/somewhat outdated SystemJS examples failed bundling since exports were not considered. PR Close #45405 21 April 2022, 18:09:39 UTC
a50e2da fix(localize): ensure transitively loaded compiler code is tree-shakable (#45405) The localize primary entry-point (used at runtime in application code) indirectly loads from the compiler package for computing message ids. The compiler package has a couple of constants which cannot be DCE-ded/ tree-shaken due to side-effect reliance that is detected by Terser. We fix these constants to be three-shakable. Note that another issue technically would be that the compiler package has a side-effect call for `publishFacade` (for JIT), but that invocation is marked as pure by the Angular CLI babel optimization pipeline. So this results is no unused code currently but is risky and should be addressed in the future. PR Close #45405 21 April 2022, 18:09:39 UTC
4c56c45 refactor(localize): init APF entry-point should not duplicate code (#45405) This commit addresses two issues: * The init entry-point currenly access code from another entry-point using relative imports, resulting in code to be duplicated. * The init types are now bundled as part of the ng_package APF rule. There is an API extractor bundling issue with global module augmentations. API extractor does not properly handle module augmentation. We need to disable dts bundling for this entry-point to ensure `$localize` remains globally accessible for users. This is an option in the `ng_package` rule. Note that this worked before because `localize/init` was a `ts_library` that did not have its types bundled. As part of this change, the `MessageId` and `TargetMessage` exports are also made public. The localize exported functions rely on these types but they were not exported. Related to types, an exception is added for three private exports from the primary entry-point so that they will show up in the API golden. These private exports are re-exposed publicly in the init entry-point but no golden would capture them due to the private symbol prefix. One might wonder why the symbols are not guarded in the init golden. The reason is that goldens never inline signatures from cross-entry-points/packages to avoid duplication. Lastly, the i18n integration test golden had to be updated because the polyfills bundle increased slightly. After thorough and time-consuming investigation, this mostly happens due to different mangle identifies being used (the input code changed --> so the mangling determinism) Size before this change: ``` SUCCESS: Commit undefined uncompressed runtime did NOT cross size threshold of 500 bytes or >1% (expected: 929, actual: 926). SUCCESS: Commit undefined uncompressed main did NOT cross size threshold of 500 bytes or >1% (expected: 124544, actual: 124660). SUCCESS: Commit undefined uncompressed polyfills did NOT cross size threshold of 500 bytes or >1% (expected: 34530, actual: 34641). ``` After: ``` SUCCESS: Commit undefined uncompressed runtime did NOT cross size threshold of 500 bytes or >1% (expected: 929, actual: 926). SUCCESS: Commit undefined uncompressed main did NOT cross size threshold of 500 bytes or >1% (expected: 124544, actual: 124650). FAIL: Commit undefined uncompressed polyfills exceeded expected size by 500 bytes or >1% (expected: 34530, actual: 35252). ``` Inspecting/comparing without mangling shows that the new changes would actually result in a bundle reduction (potentially visible with gzip/brotli): ``` ➜ Desktop stat -f%z master-nomangle.js 101357 ➜ Desktop stat -f%z with-changes-nomangle.js 101226 ``` PR Close #45405 21 April 2022, 18:09:39 UTC
7a8a929 refactor: fix duplication in platform-server NPM package (#45405) The platform-server init entry-point imported code from another entry-point using a relative import. This resulted in the code to be bundled into the `init` entry-point as well. This has no breaking impact but resulted in a little code duplication that we should clean up. PR Close #45405 21 April 2022, 18:09:39 UTC
dd0fc0f test: add test for new `types_bundle` rule from Angular bazel package (#45405) Adds a little golden test for the new `types_bundle` rule that ensures the rule works at a general level. This rule will be useful for non-APF ESM packages like the Angular compiler-cli (for which we also want to bundle types to make them compatible with TypeScripts ESM type resolution) PR Close #45405 21 April 2022, 18:09:39 UTC
68597bb feat(bazel): speed up dev-turnaround by bundling types only when packaging (#45405) Speeds up the dev-turnaround by only bundling types when packaging. Currently bundling occurs for all the `ng_module` targets in devmode. This has various positive benefits: * Avoidance of this rather slower operation in development * Makes APF-built packages also handle types for `ts_library` targets consistently. * Allows us to ensure APF entry-points have `d.ts` _always_ bundled (working with ESM module resolution in TypeScript -- currently experimental) * Allows us to remove the secondary `package.json` files from APF (maybe APF v14? - seems low-impact). This would clean-up the APF even more and fix resolution issues (like in Vite) PR Close #45405 21 April 2022, 18:09:39 UTC
3dee3d1 fix(docs-infra): fix placement of "Edit source" button on errors and diagnostics pages (#45634) This commit aligns the layout of errors and extended diagnostics pages more closely with other docs pages to ensure that the "Edit source" button is displayed correctly even when the heading is too long to fit on a single line. For error pages, in particular, this ensures that the button is not obscured by the error video. **Before:** ![error-pages before][1] **After:** ![error-pages after][2] [1]: https://user-images.githubusercontent.com/8604205/163408291-7aebd029-891c-4045-8fa2-a8e2b2b06dab.png [2]: https://user-images.githubusercontent.com/8604205/163408296-40e6df8e-aadc-4a82-978a-ab4d902b6f6e.png PR Close #45634 21 April 2022, 18:07:27 UTC
9292953 fix(docs-infra): include `tslib` into SystemJS config in `upgrade-module` example app (#45706) This commit updates the SystemJS for one of the example apps (the `upgrade-module` one) to include a resolution rule for the `tslib`. This is needed in case `tslib` is referenced from the framework code (for example in case of downleveling of some operators). This makes it consistent with other example app configs. PR Close #45706 21 April 2022, 18:05:37 UTC
9e4c4bc docs(core): add API documentation to standalone-related classes (#45687) This commit adds some internal documentation. PR Close #45687 20 April 2022, 23:01:56 UTC
e162fa3 test(core): add more tests for the standalone injector (#45687) This commit reorganizes the tests around the EnvironmentInjector and its use for standalone injectors, and adds a number of new test cases. PR Close #45687 20 April 2022, 23:01:56 UTC
3616d7e refactor(core): implement standalone injectors (#45687) This commit implements the `StandaloneFeature` which provides for the creation of standalone injectors, for those components which need them. The feature-based implementation ensures the machinery for standalone injectors is properly tree-shakable. PR Close #45687 20 April 2022, 23:01:56 UTC
9f79513 refactor(core): support standalone components in importProvidersFrom (#45687) This commit refactors `importProvidersFrom` to support pulling providers from the dependencies of a standalone component, in addition to NgModules. Tests will be added in a future commit when standalone components can be created without calling private APIs. PR Close #45687 20 April 2022, 23:01:55 UTC
5a10fc4 feat(core): implement standalone directives, components, and pipes (#45687) This commit exposes the `standalone` flag on `@Directive`, `@Component`, and `@Pipe`, effectively making standalone components a part of Angular's public API. As part of this operation, it also implements JIT compilation for standalone types. Standalone types are Angular-decorated types which act as their own "declarations", where they would otherwise be declared in an NgModule. Marking an Angular type as standalone means that it can be used directly in other standalone components and in NgModules, without needing an associated NgModule to depend on it. In the case of a standalone component, template dependencies which would otherwise be specified by an NgModule are instead specified directly on the component itself, via the `imports` field. Other standalone types can be imported, as well as NgModules. PR Close #45687 20 April 2022, 23:01:55 UTC
bb6e11c refactor(compiler-cli): reorganize importProvidersFrom to avoid cycles (#45687) This commit extracts the `importProvidersFrom` function and associated machinery into a separate file, as opposed to being colocated with `R3Injector`. Separating these functions will mitigate potential future circular dependencies as `importProvidersFrom` starts being used in different parts of the codebase. PR Close #45687 20 April 2022, 23:01:55 UTC
dea8c86 feat(router): add ariaCurrentWhenActive input to RouterLinkActive directive (#45167) add the ariaCurrentWhenActive input to the RouterLinkActive directive so that users can easily set the aria-current property to their active router links resolves #35051 PR Close #45167 20 April 2022, 22:14:01 UTC
d8226de release: cut the v14.0.0-next.14 release (#45704) PR Close #45704 20 April 2022, 21:47:03 UTC
f14763e docs: release notes for the v13.3.4 release (#45703) PR Close #45703 20 April 2022, 21:41:58 UTC
1d2f5c1 refactor(router): deprecate no longer needed resolver fields (#45597) DEPRECATED: The `resolver` argument of the `RouterOutletContract.activateWith` function and the `resolver` field of the `OutletContext` class are deprecated. Passing component factory resolvers are no longer needed. The `ComponentFactoryResolver`-related symbols were deprecated in `@angular/core` package since v13. PR Close #45597 20 April 2022, 19:57:37 UTC
f4fd1a8 feat(router): Add `EnvironmentInjector` to `RouterOutlet.activateWith` (#45597) The current API for `activateWith` uses the deprecated `ComponentFactoryResolver`. The replacement for this is to use `EnvironmentInjector`. That is, instead of ``` const factory = componentFactoryResolver.resolveComponentFactory(component); location.createComponent(factory, location.length, injector); ``` the replacement would be ``` location.createComponent( component, {index: location.length, injector, environmentInjector}); ``` PR Close #45597 20 April 2022, 19:57:37 UTC
4e0957a feat(router): Add ability to specify providers on a Route (#45673) Currently, the only way to specify new providers for a `Route` and the children is to create a new `NgModule` with those providers and use the `loadChildren` feature. This is pretty confusing and a wholly indirect way of accomplishing this task. With this commit, developers will be able to specify a list of providers directly on the `Route` itself. These providers will apply the that route and its children. This feature was inspired by the upcoming standalone components feature. This ties in there because, as mentioned before, the prior art for lazy loading configs was to load an `NgModule`. This loaded module contained new route configs _and_ could specify new providers. Separating those two concepts, there should be a way to load _just_ some new routes, but there should also be a way to specify new providers as well (something you could do in the `NgModule` world and now will be able to do in the world without any `NgModule` through this feature). PR Close #45673 20 April 2022, 18:32:07 UTC
ba45428 ci: update payload size golden file (#45699) This commit updates the payload size for the Forms-related test app. The CI started to fail after merging https://github.com/angular/angular/commit/ff3f5a8d12e3243620e311b690a050e26493e539. The payload size increase is most likely accumulated. PR Close #45699 20 April 2022, 17:29:38 UTC
ff3f5a8 fix(forms): Fix a typing bug in FormBuilder. (#45684) Previously, the following code would fail to compile: ``` let form: FormGroup<{email: FormControl<string | null>}>; form = fb.group({ email: ['', Validators.required] }); ``` This is because the compiler was unable to properly infer the inner type of `ControlConfig` arrays in some cases. The same issue applies to `FormArray` as well under certain circumstances. This change cleans up the `FormBuilder` type signatures to always use the explicit Element type, and to catch `ControlConfig` types that might fall through. PR Close #45684 20 April 2022, 16:15:46 UTC
788f587 fix(docs-infra): avoid internal symbols from being referenced during auto-linking (#45689) This commit adds extra logic to avoid internal and privately exported symbols from being referenced during auto-linking. Currently such symbols can be used for linking, thus resulting in a non-existing link and causing the linking process to fail. PR Close #45689 20 April 2022, 16:11:22 UTC
47e5b05 test(http): Add + to encoding test (#45111) Changes the existing test for query parameter encoding to include the + symbol and its expected encoding to %2B. PR Close #45111 20 April 2022, 16:00:19 UTC
76a9a24 fix(http): encode + signs in query params as %2B (angular#11058) (#45111) Servers always decode + as a space, which is undesirable when one actually wants to query for a plus. BREAKING CHANGE: Queries including + will now actually query for + instead of space. Most workarounds involving custom codecs will be unaffected. Possible server-side workarounds will need to be undone. Fixes angular#11058 PR Close #45111 20 April 2022, 16:00:19 UTC
b8d3389 test(compiler-cli): tests for standalone components/directives/pipes (#45672) This commit bundles tests for standalone components that are possible after previous implementation commits. Most new tests are compliance tests, but a test is also included to validate that the template type-checking system can work with standalone components as well. PR Close #45672 20 April 2022, 12:45:57 UTC
d3c0fa3 refactor(compiler-cli): propagate standalone flag in .d.ts metadata (#45672) This commit adds a type field to .d.ts metadata for directives, components, and pipes which carries a boolean literal indicating whether the given type is standalone or not. For backwards compatibility, this flag defaults to `false`. Tests are added to validate that standalone types coming from .d.ts files can be correctly imported into new standalone components. PR Close #45672 20 April 2022, 12:45:57 UTC
80d2cda test: set skipLibCheck on ngcc integration test (#45672) The ngcc integration test is in an awkward state: it's attempting to test that the current ngcc can process @angular/core at v12. We need to make a forwards-incompatible change to the typings of @angular/core, which means that the compiled typings from the current ngcc won't be compatible with core as of v12. To get around this and allow the integration test to have some value, we're disabling library checking for the time being. PR Close #45672 20 April 2022, 12:45:57 UTC
99b3af4 refactor(compiler-cli): emit isStandalone flag in partial declarations (#45672) This commit propagates the `isStandalone` flag for a component, directive, or pipe during partial compilation of a standalone declaration. This flag allows the linker to properly process a standalone declaration that it encounters. PR Close #45672 20 April 2022, 12:45:57 UTC
1244a14 refactor(compiler-cli): move standalone scope computation out of handler (#45672) Standalone component scopes were first implemented in the `ComponentDecoratorHandler` itself, due to an assumption that "standalone" allowed for a localized analysis of the component's dependencies. However, this is not strictly true. Other compiler machinery also needs to understand component scopes, including standalone component scopes. A good example is the template type-checking engine, which uses a `ComponentScopeReader` to build full metadata objects (that is, metadata that considers the entire inheritance chain) for type-checking purposes. Therefore, the `ComponentScopeReader` should be able to give the scope for a standalone component. To achieve this, a new `StandaloneComponentScopeReader` is implemented, and the return type of `ComponentScopeReader.getScopeForComponent` is expanded to express standalone scopes. This cleanly integrates the "standalone" concept into the existing machinery. PR Close #45672 20 April 2022, 12:45:56 UTC
d8086a1 refactor(compiler-cli): emit StandaloneFeature for standalone components (#45672) This commit adds an emit for standalone components of the `StandaloneFeature`, which will support creation of standalone injectors and any other mechanisms necessary for standalone component functionality at runtime. Using a feature allows for standalone functionality to be tree-shaken in applications that aren't using them. PR Close #45672 20 April 2022, 12:45:56 UTC
f9f8ef9 refactor(compiler-cli): emit NgModule dependencies of standalone components (#45672) This commit expands on the unified dependency tracking in the previous commit and adds tracking of NgModule dependencies. These are not used for standard components, but are emitted for standalone components to allow the runtime to roll up providers from those NgModules into standalone injectors. PR Close #45672 20 April 2022, 12:45:56 UTC
9b35787 refactor(compiler-cli): unify tracked template scope dependencies (#45672) Previously, the compiler tracked directives and pipes in template scopes separately. This commit refactors the scope system to unify them into a single data structure, disambiguated by a `kind` field. PR Close #45672 20 April 2022, 12:45:56 UTC
1527e8f refactor(core): change component emit to 'dependencies' (#45672) Previously, the compiler would represent template dependencies of a component in its component definition through separate fields (`directives`, `pipes`). This commit refactors the compiler/runtime interface to use a single field (`dependencies`). The runtime component definition object still has separate `directiveDefs` and `pipeDefs`, which are calculated from the `dependencies` when the definition is evaluated. This change is also reflected in partially compiled declarations. To ensure compatibility with partially compiled code already on NPM, the linker will still honor the old form of declaration (with separate fields). PR Close #45672 20 April 2022, 12:45:56 UTC
046dad1 fix(compiler-cli): fix issue with incremental tracking of APIs for pipes (#45672) `PipeSymbol` contains logic to detect changes in the public API surface of pipes, which includes the pipe name. However, the pipe handler inadvertently uses the pipe class name instead of the actual pipe name to initialize the `PipeSymbol`, which breaks incremental compilation when pipe names change. There is a test which attempts to verify that this logic is working, but the test actually passes for a different reason. The test swaps the names of 2 pipes that are both used in a component, and asserts that the component is re-emitted, theoretically because the public APIs of the pipes is changed. However, the emit order of the references to the pipes depends on the order in which they match in the template, which changes when the names are swapped. This ordering dependency is picked up by the semantic dependency tracking system, and is what actually causes the component to be re-emitted and therefore the pipe test to pass in spite of the bug with name tracking. This commit fixes the `PipeSymbol` initialization to use the correct pipe name. The test is still flawed in that it's sensitive to the ordering of pipe emits, but this ordering is due to change soon as a result of the standalone components work, so this issue will be resolved in a future commit. PR Close #45672 20 April 2022, 12:45:56 UTC
989e840 fix(router): Remove unused string type for ActivatedRoute.component (#45625) BREAKING CHANGE: The type of `component` on `ActivatedRoute` and `ActivatedRouteSnapshot` includes `string`. In reality, this is not the case. The component cannot be anything other than a component class. PR Close #45625 20 April 2022, 03:21:35 UTC
4ad7c2e docs: Update aio/content/guide/setup-local.md (#45644) Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> PR Close #45644 20 April 2022, 03:20:39 UTC
89f9d28 docs: correct the example command to install angular (#45644) PR Close #45644 20 April 2022, 03:20:39 UTC
back to top