Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
9a37a77 Dylan Hunn 06 April 2023, 02:37:01 UTC release: cut the v15.2.6 release 06 April 2023, 02:44:18 UTC
da5f316 Matthieu Riegler 04 April 2023, 09:27:46 UTC refactor(core): Use the nullish coalescing assignment in render3 functions (#49698) The usage of `??=` make the code more clear & concise. PR Close #49698 05 April 2023, 16:45:55 UTC
cad7274 Andrew Scott 03 April 2023, 20:49:45 UTC fix(router): create correct URL relative to path with empty child (#49691) The previous fix for squashing empty children didn't quite work when the existing route had segments. The result would be that the segments from the existing route were dropped from the final URL. PR Close #49691 04 April 2023, 22:05:42 UTC
d9efa1b Guillaume Weghsteen 31 March 2023, 10:09:28 UTC feat(core): change the URL sanitization to only block javascript: URLs (#49659) In modern browsers, the 'javascript:' URL scheme is the only scheme that can execute JavaScript when passed in a navigation URL context (e.g. `a.href` value). Validate URL shemes to only contain characters allowed in the URL specification ([a-zA-Z-+.]), and that are not javascript (case insensitive). This is not a breaking change. The URL sanitization is loosen. PR Close #49659 04 April 2023, 22:01:14 UTC
c26e4be Robin Richtsfeld 04 April 2023, 18:05:42 UTC docs: fix typo (#49704) PR Close #49704 04 April 2023, 22:00:39 UTC
bd82fbe Sandra Limacher 01 April 2023, 20:44:53 UTC docs: fix typo (#49669) PR Close #49669 04 April 2023, 02:18:41 UTC
1d32253 Matthieu Riegler 02 April 2023, 21:50:32 UTC refactor(core): remove unnecessary `reflect-metadata` import. (#49673) The import is not needed for the tests to run. PR Close #49673 04 April 2023, 02:17:03 UTC
6e1b3ad vikram menon 30 March 2023, 22:04:49 UTC docs: fix typo in quick reference (#49655) Change indicatedr5t to indicated PR Close #49655 04 April 2023, 02:13:16 UTC
a6def64 Johnny Gérard 31 March 2023, 19:36:26 UTC docs: fix typo (#49664) PR Close #49664 03 April 2023, 05:10:13 UTC
9b61379 Andrew Scott 23 March 2023, 18:18:20 UTC fix(router): Ensure initial navigation clears current navigation when blocking (#49572) The navigation transition clears the current navigation in the finalize operator of the current navigation Observer. This commit both completes the `bootstrapDone` observable and updates the transition to only take 1 emit from the completed navigation. Either of these changes on their own would fix the issue. The latter is a preventative measure in case a mistake like the former is made again. fixes #49567 PR Close #49572 01 April 2023, 00:04:02 UTC
08979e4 John Manners 20 February 2023, 12:29:14 UTC docs: fix typo in toh-pg6.md (#49141) Line 425. Change burning to burn. PR Close #49141 31 March 2023, 19:00:44 UTC
233f33e Angular Robot 31 March 2023, 00:10:42 UTC build: update scorecard action dependencies (#49609) See associated pull request for more information. PR Close #49609 31 March 2023, 18:49:47 UTC
35f4918 Vinit Neogi 29 March 2023, 12:43:14 UTC docs(core): fix view hierarchy links (#49629) fixes incorrect links to view-hierarchy (currently view-tree) Fixes #49623 PR Close #49629 30 March 2023, 16:39:39 UTC
43e89bd Sarthak Thakkar 29 March 2023, 19:44:25 UTC docs: fixed typo error (#49637) PR Close #49637 30 March 2023, 16:38:43 UTC
07e78bb Matthieu Riegler 29 March 2023, 21:22:32 UTC docs: Update Popup.service example to remove `ComponentFactoryResolver` (#49638) `ComponentFactoryResolver` has been deprecated and can be replaced by `createComponent()`. PR Close #49638 30 March 2023, 16:38:16 UTC
e78a2a4 Andrew Scott 29 March 2023, 19:37:48 UTC release: cut the v15.2.5 release (#49635) 29 March 2023, 19:37:48 UTC
077f6b4 Alan Agius 17 March 2023, 12:15:03 UTC fix(compiler): do not unquote CSS values (#49460) Currently we are unsafely unquoting CSS values which in some cases causes valid values to become invalid and invalid values to become valid. Example: ```html <div style="width:&quot;1px;&quot;"></div> ``` In the above case, `width` has an invalid value of `"1px"`, however the compiler will transform it to `1px` which makes it valid. On the other hand, in the below case ```html <div style="content:&quot;foo&quot;"></div> ``` `content` has a valid value of `"foo"`, but since the compiler unwraps it to `foo` it becomes invalid. For correctness, we should not remove quotes. ```js const div = document.createElement('div'); div.style.width='"1px"'; div.style.content='foo'; div.style.width; // '' div.style.content; // '' div.style.width='1px'; div.style.content='"foo"'; div.style.width; // '1px' div.style.content; // '"foo"' ``` More information about values can be found https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier PR Close #49460 28 March 2023, 18:35:39 UTC
d201fc2 Alan Agius 17 March 2023, 10:53:16 UTC fix(core): set style property value to empty string instead of an invalid value (#49460) Currently when the value of a styling property that has a unit is empty string a invalid value is generated. Example: `[style.width.px] = ""` will generate a value of `"px"`, when instead it should be `""`. This causes browser to reset the value to an empty string. This is however not the case in Domino with changes in https://github.com/angular/domino/commit/bfc9114d1eb5b7591c43a7c6aef6ad50d24e369f. This commit fixes the issues and generate correct values. PR Close #49460 28 March 2023, 18:35:39 UTC
6d6fc12 Matthieu Riegler 26 March 2023, 19:27:49 UTC refactor(core): Remove usage of deprecated `Injector.create()` (#49606) This commit removes all usages of the deprecated `Injector.create` method but does not remove the deprecated signature itself. PR Close #49606 28 March 2023, 17:15:36 UTC
8ed4083 Asaf Malin 23 March 2023, 07:11:20 UTC docs: fixed grammar (#49560) PR Close #49560 28 March 2023, 17:14:45 UTC
4c89a24 Matthieu Riegler 26 March 2023, 14:32:15 UTC refactor(common): add missing `override` to satisfy the linter (#49599) Linter was complaining of missing `override` despite being OK on the CI. this commits add them. PR Close #49599 28 March 2023, 17:12:36 UTC
0fecbab Paul Gschwendtner 25 March 2023, 14:32:08 UTC ci: update pullapprove config to reflect current availability (#49592) Updating PullApprove to reflect current availability. Looks like it cannot be set via UI anymore... PR Close #49592 27 March 2023, 15:43:06 UTC
ca5acad Tano Abeleyra 24 February 2023, 21:42:24 UTC fix(common): invalid ImageKit transformation (#49201) q-auto is an invalid/unsupported transformation and should not be used PR Close #49201 27 March 2023, 15:33:22 UTC
978d37f Andrew Scott 23 March 2023, 17:24:17 UTC fix(router): Ensure Router preloading works with lazy component and static children (#49571) The preloading strategy did not handle a `loadComponent` on a route with a static `children`. It only preloaded children if they were also `loadChildren` or both were not lazy loaded. fixes #49558 PR Close #49571 24 March 2023, 17:41:11 UTC
656a388 Angular Robot 24 March 2023, 13:09:42 UTC build: update actions/checkout digest to 8f4b7f8 (#49577) See associated pull request for more information. PR Close #49577 24 March 2023, 17:27:35 UTC
29c682c Paul Gschwendtner 24 March 2023, 12:21:06 UTC ci: update github.com known host given recent RSA update (#49580) See: https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/ PR Close #49580 24 March 2023, 12:54:11 UTC
3f8e4fb Sid 23 March 2023, 12:31:50 UTC docs: add missing word (#49565) I have added a word to make the sentence more meaningful. PR Close #49565 23 March 2023, 18:44:04 UTC
c3cff35 Kristiyan Kostadinov 22 March 2023, 09:49:32 UTC fix(compiler): handle trailing comma in object literal (#49535) Fixes that the compiler wasn't parsing an object literal with a trailing comma correctly. Fixes #49534. PR Close #49535 23 March 2023, 18:35:45 UTC
a844435 Jan Cabadaj 17 March 2023, 09:43:12 UTC fix(router): fix #49457 outlet activating with old info (#49459) Avoid activating outlet with old info if route was changed before outlet activated PR Close #49459 22 March 2023, 21:41:43 UTC
901353e Andrew Scott 22 March 2023, 20:04:07 UTC release: cut the v15.2.4 release 22 March 2023, 20:15:53 UTC
288156b Kristiyan Kostadinov 22 March 2023, 17:06:40 UTC Revert "fix(migrations): preserve trailing commas in code generated by standalone migration (#49533)" (#49547) This reverts commit bf4d8568341a6ac432059903eb66c3c7509c1b9a. PR Close #49547 22 March 2023, 17:21:27 UTC
bf4d856 Kristiyan Kostadinov 22 March 2023, 08:41:23 UTC fix(migrations): preserve trailing commas in code generated by standalone migration (#49533) This is based on some internal feedback. Adds logic to the standalone migration that attempts to preserve trailing commas when updating existing AST nodes. When creating new ones, it tries to infer whether to generate the trailing comma based on the surrounding code. PR Close #49533 22 March 2023, 15:41:53 UTC
3bb7676 Peter Götz 21 March 2023, 20:44:03 UTC docs: remove ticks in code sample to generate components (#49525) These ticks appear in the actual documentation and when copied verbatim while following the tutorial, running this command in the terminal simply does nothing. PR Close #49525 22 March 2023, 15:02:48 UTC
be2db59 Andrew Scott 20 March 2023, 22:47:24 UTC refactor(router): Remove deprecated loadChildren file (#49504) This file was used while migrations were happening internally. All code is now updated to the callback PR Close #49504 21 March 2023, 21:09:23 UTC
9c57b65 Andrew Scott 20 March 2023, 22:44:19 UTC refactor(router): Update router export location for deprecated interfaces (#49504) Moving these exports to a separate file will allow easier local patches internally. PR Close #49504 21 March 2023, 21:09:22 UTC
b293c6a Andrew Scott 20 March 2023, 20:28:27 UTC refactor(core): Remove VE/Render3 aliases from ViewRef code (#49499) These aliases were used while we needed to maintain compatibility with ViewEngine PR Close #49499 21 March 2023, 21:08:30 UTC
951a347 Alex Rickabaugh 21 March 2023, 18:10:54 UTC test: increase size tracking threshold to 5K / 5% (#49520) This commit increases the threshold of payload size tracking tests from 500 bytes to 5,000 bytes, and from 1% to 5%. This is done to minimize merge conflicts while still catching real regressions. PR Close #49520 21 March 2023, 19:30:05 UTC
b5e68e4 Paul Gschwendtner 21 March 2023, 13:19:29 UTC build: exclude draft PRs from triage queue (#49515) Excludes draft PRs from triage queue. Note that we cannot use `draft:false` as otherwise all issues would be filtered. Rather we need to negate `draft:true` which matches non-draft PRs and normal issues. PR Close #49515 21 March 2023, 15:40:48 UTC
a404587 Angular Robot 21 March 2023, 15:08:29 UTC build: update scorecard action dependencies (#49508) See associated pull request for more information. PR Close #49508 21 March 2023, 15:39:10 UTC
6c9886b Angular Robot 21 March 2023, 07:07:03 UTC build: update cross-repo angular dependencies (#49517) See associated pull request for more information. PR Close #49517 21 March 2023, 14:30:37 UTC
3c75f98 Thomas Pischke 20 March 2023, 17:01:44 UTC docs: remove pipe in exponential backoff (#49494) PR Close #49494 21 March 2023, 06:58:06 UTC
cd5d7b6 Thomas Pischke 20 March 2023, 15:23:13 UTC docs: update deprecated exponential backoff example (#49494) PR Close #49494 21 March 2023, 06:58:06 UTC
97d58ec Aditya Srinivasan 19 March 2023, 23:08:07 UTC docs: fix link ngFor documentation link (#49479) Fix the `ngFor` API link under the "Structural directive shorthand" section PR Close #49479 21 March 2023, 06:56:38 UTC
087f441 Masaoki Kobayashi 31 January 2023, 00:21:23 UTC fix(core): more accurate matching of classes during content projection (#48888) Showing a minimum app to reproduce the bug. 1. Create the app and add angular material. ``` ng new project cd project ng add @angular/material ``` 1. Overwrite the src/app/app.component.html with minimal content. ``` <button mat-button *ngIf="true"><span *ngIf="true" class="{{'a'}}"></span></button> ``` 1. Run the app. The button is not shown because of an exception. ``` main.ts:6 ERROR TypeError: item.toLowerCase is not a function at isCssClassMatching (core.mjs:8726:35) at isNodeMatchingSelector (core.mjs:8814:22) at isNodeMatchingSelectorList (core.mjs:8931:13) at matchingProjectionSlotIndex (core.mjs:14179:13) at Module.ɵɵprojectionDef (core.mjs:14222:49) at MatButton_Template (button.mjs:113:99) at executeTemplate (core.mjs:10534:9) at renderView (core.mjs:10356:13) at renderComponent (core.mjs:11529:5) at renderChildComponents (core.mjs:10216:9) ``` Because isCssClassMatching() function does not take care if the value is not string, while attrs[] may contain AttributeMarker which is actually numbers, item.toLowerCase() throws the exception. Just inserted a check if the item is string. Created a testcase for the original fix. It causes an exception without the fix. fix(core): add a check code to avoid an exception inside isCssClassMatching Showing a minimum app to reproduce the bug. 1. Create the app and add angular material. ``` ng new project cd project ng add @angular/material ``` 1. Add `import { MatButtonModule } from '@angular/material/button'`, and also MatButtonModule inside @NgModule imports in src/app/app.module.ts to use MatButtonModule. 1. Overwrite the src/app/app.component.html with minimal content. ``` <button mat-button *ngIf="true"><span *ngIf="true" class="{{'a'}}"></span></button> ``` 1. Run the app. The button is not shown because of an exception. ``` main.ts:6 ERROR TypeError: item.toLowerCase is not a function at isCssClassMatching (core.mjs:8726:35) at isNodeMatchingSelector (core.mjs:8814:22) at isNodeMatchingSelectorList (core.mjs:8931:13) at matchingProjectionSlotIndex (core.mjs:14179:13) at Module.ɵɵprojectionDef (core.mjs:14222:49) at MatButton_Template (button.mjs:113:99) at executeTemplate (core.mjs:10534:9) at renderView (core.mjs:10356:13) at renderComponent (core.mjs:11529:5) at renderChildComponents (core.mjs:10216:9) ``` Because isCssClassMatching() function does not take care if the value is not string, while attrs[] may contain AttributeMarker which is actually numbers, item.toLowerCase() throws the exception. Just inserted a check if the item is string. PR Close #48888 20 March 2023, 15:07:14 UTC
0f0c0a9 avmaxim 10 March 2023, 15:28:08 UTC docs(docs-infra): improve docs for @angular/localize package. (#49393) This PR adds missing documentation for `@angular/localize` package and fixes a tiny one-word typo in the `README.md` file for `@angular/localize schematic`. Fixes #49219. PR Close #49393 20 March 2023, 12:12:19 UTC
bae6b5c Matthieu Riegler 18 March 2023, 19:06:05 UTC fix(core): Allow `TestBed.configureTestingModule` to work with recursive cycle of standalone components. (#49473) When having a recursive circle of imports on standalone components, `queueTypesFromModulesArrayRecur` triggered a `Maximum call stack size exceeded` error. This commit fixes this. Fixes #49469 PR Close #49473 20 March 2023, 09:02:15 UTC
868dcab Virginia Dooley 16 March 2023, 16:58:23 UTC docs: Send data to server - insert updated links. (#49447) PR Close #49447 20 March 2023, 07:49:21 UTC
8f6cbb6 Matthieu Riegler 14 March 2023, 11:51:45 UTC docs: remove bazel builder section (#49423) PR Close #49423 20 March 2023, 07:48:43 UTC
c807a32 Angular Robot 17 March 2023, 06:05:43 UTC build: update actions/checkout digest to 24cb908 (#49436) See associated pull request for more information. PR Close #49436 17 March 2023, 07:38:16 UTC
2e37e23 Virginia Dooley 16 March 2023, 02:04:18 UTC docs: Optimize server interaction - insert updated link. (#49438) PR Close #49438 17 March 2023, 07:36:59 UTC
bb2753d Virginia Dooley 16 March 2023, 02:48:58 UTC docs: Track and show request progress - insert updated link. (#49439) PR Close #49439 17 March 2023, 07:35:45 UTC
e6736c7 Virginia Dooley 16 March 2023, 16:38:16 UTC docs: Intercept requests - insert updated link. (#49446) PR Close #49446 17 March 2023, 07:34:15 UTC
3d71d9d Alex Rickabaugh 16 March 2023, 19:01:11 UTC release: cut the v15.2.3 release 16 March 2023, 19:08:14 UTC
c981644 Angular Robot 10 March 2023, 13:12:04 UTC build: update actions/cache digest to 940f3d7 (#49377) See associated pull request for more information. PR Close #49377 16 March 2023, 00:27:22 UTC
589e76b Alan Agius 15 March 2023, 09:43:39 UTC test(common): update async pipe tests to fix test errors (#49433) The below error is displayed during some tests ```js ERROR: 'Unhandled Promise rejection:', 'Cannot read properties of null (reading 'markForCheck')', '; Zone:', 'ProxyZone', '; Task:', 'Promise.then', '; Value:', TypeError: Cannot read properties of null (reading 'markForCheck') TypeError: Cannot read properties of null (reading 'markForCheck') at AsyncPipe2._updateLatestValue (http://angular-ci.local:9876/base/dist/legacy-test-bundle.spec.js?49174f830d8743d5c8a9551b77550b859b934291:51947:19) ``` This is caused by the fact that `ref` in `AsyncPipe` is initialized with a value of `null` which causes `_updateLatestValue` to fail since it is not expected to be `null`. This change ensures that a `ref` is always provided and that all subscriptions are disposed off after each test. PR Close #49433 16 March 2023, 00:19:38 UTC
bba3fcb Virginia Dooley 14 March 2023, 22:53:54 UTC docs: Understanding communicating with http - insert updated links. (#49429) PR Close #49429 16 March 2023, 00:18:54 UTC
6f139b4 Angular Robot 14 March 2023, 22:06:43 UTC build: update io_bazel_rules_sass digest to 3d2ad47 (#49428) See associated pull request for more information. PR Close #49428 16 March 2023, 00:11:56 UTC
dfa7f64 Angular Robot 14 March 2023, 22:06:49 UTC build: update github/codeql-action action to v2.2.6 (#49420) See associated pull request for more information. PR Close #49420 16 March 2023, 00:01:01 UTC
5a3d121 Alan Agius 10 March 2023, 15:05:46 UTC test: fix misconfiguration in tests (#49391) Currently, tests are tested twice using "production" like configuration. This commit disabled "optimization" for non production builds. PR Close #49391 15 March 2023, 23:59:51 UTC
e4516c7 Esteban Gehring 13 March 2023, 14:45:21 UTC docs(upgrade): mark lifecycle methods as nodoc (#49416) PR Close #49416 14 March 2023, 16:41:36 UTC
32e98f7 Esteban Gehring 13 March 2023, 14:36:24 UTC docs(common): mark lifecycle methods as nodoc (#49416) PR Close #49416 14 March 2023, 16:41:36 UTC
6c189ed Angular Robot 11 March 2023, 01:32:10 UTC build: update io_bazel_rules_sass digest to aa03944 (#49397) See associated pull request for more information. PR Close #49397 14 March 2023, 16:25:16 UTC
2df92f7 Angular Robot 10 March 2023, 17:04:45 UTC build: update cross-repo angular dependencies (#49410) See associated pull request for more information. PR Close #49410 13 March 2023, 13:50:33 UTC
1535ab9 Virginia Dooley 02 March 2023, 18:04:50 UTC docs: New doc: Understanding communicating with backend services using HTTP (#49294) PR Close #49294 09 March 2023, 17:21:14 UTC
c272665 Virginia Dooley 02 February 2023, 01:17:58 UTC docs: New doc extract from original HTTP doc to be retired. (#48914) PR Close #48914 09 March 2023, 17:19:04 UTC
a44224c Virginia Dooley 09 March 2023, 00:36:14 UTC docs: delete outdated link. (#48909) PR Close #48909 09 March 2023, 17:17:02 UTC
3c71e48 Virginia Dooley 02 March 2023, 19:41:04 UTC docs: delete or revise outdated links. (#48909) PR Close #48909 09 March 2023, 17:17:02 UTC
43dff1f Virginia Dooley 02 February 2023, 00:25:37 UTC docs: New doc extract from original HTTP doc to be retired. (#48909) PR Close #48909 09 March 2023, 17:17:01 UTC
7e23883 Matthieu Riegler 08 March 2023, 10:03:00 UTC refactor(dev-infra): remove obsolete todos (#49362) These todos do not apply anymore, let's remove them. PR Close #49362 08 March 2023, 23:39:56 UTC
7efaf52 Matthieu Riegler 08 March 2023, 10:14:50 UTC docs: Remove `RenderComponentType` from the depreciation list. (#49363) `RenderComponentType` was removed by #33019 PR Close #49363 08 March 2023, 23:39:03 UTC
f099df8 Angular Robot 08 March 2023, 15:03:47 UTC docs: update events (#49366) Generated `events.json` with the latest events retrieved from the Firebase DB. Closes #49355 PR Close #49366 08 March 2023, 21:54:24 UTC
c9e8804 Angular Robot 07 March 2023, 06:07:42 UTC build: update eslint dependencies to v5.54.1 (#49348) See associated pull request for more information. PR Close #49348 08 March 2023, 21:08:34 UTC
2dee505 Alan Agius 07 March 2023, 13:07:34 UTC refactor(core): split `ɵɵdefineDirective` and `ɵɵdefineComponent` (#49350) Before this change `ɵɵdefineDirective` called `ɵɵdefineComponent` under the hood. This is problematic for the consistent component id generation as it could result in hash collisions for certain directives. Directives however do not require an id. This changes moves common definition generation logic into a separate function that is re-used in `ɵɵdefineDirective` and `ɵɵdefineComponent`. PR Close #49350 08 March 2023, 21:07:54 UTC
75d5bfd Jessica Janiuk 08 March 2023, 18:38:46 UTC release: cut the v15.2.2 release 08 March 2023, 18:43:09 UTC
9937508 Paul Gschwendtner 07 March 2023, 10:30:23 UTC refactor(compiler-cli): remove unused class decorator downlevel code (#49351) The decorator downlevel transform is never used for actual class decorators because Angular class decorators rely on immediate execution for JIT. Initially we also supported downleveling of class decorators for View Engine library output, but libraries are shipped using partial compilation output and are not using this transform anymore. The transform is exclusively used for JIT processing, commonly for test files to help ease temporal dead-zone/forward-ref issues. We can remove the class decorator downlevel logic to remove technical debt. PR Close #49351 08 March 2023, 17:59:12 UTC
88a0ff7 Matthieu Riegler 06 March 2023, 21:15:05 UTC docs(docs-infra): Split Error by categories & sort by code. (#49343) * 2 categories : Runtime errors and Compiler Errors. * Numeric sort on error code. PR Close #49343 07 March 2023, 19:18:01 UTC
75b2a26 Sai Kartheek Bommisetty 03 March 2023, 12:30:36 UTC docs: update toh-pt5.md (#49307) PR Close #49307 07 March 2023, 19:17:25 UTC
d0a73b2 Vinit Neogi 07 March 2023, 17:25:25 UTC docs(docs-infra): missing "is" in glossary (#49356) documentation glossary for view hierarchy is missing a "is" to be grammatically correct Fixes #49352 PR Close #49356 07 March 2023, 19:16:42 UTC
e0be553 Matthieu Riegler 06 March 2023, 21:41:50 UTC docs(forms): change error code in filename to match enum value. (#49344) Error code for bad AsyncValidatorFn is 1101 not 1003. PR Close #49344 07 March 2023, 17:38:02 UTC
ffccb8e Matthieu Riegler 27 February 2023, 18:33:12 UTC refactor(animations): handle #24571 todos (#49231) This commit removes the remaining ones in animations code base PR Close #49231 06 March 2023, 18:45:34 UTC
b13e079 Matthieu Riegler 02 March 2023, 19:34:58 UTC refactor(core): Remove `ChangeDetectorStatus` & `isDefaultChangeDetectionStrategy` (#49299) Unused code in core and other packages. They were private exports. PR Close #49299 06 March 2023, 16:57:02 UTC
84f4536 Matthieu Riegler 02 March 2023, 21:48:05 UTC refactor(platform-browser): remove ununsed functions. (#49302) Both `camelCaseToDashCase` and `dashCaseToCamelCase` haven't been used since 2.2.0. PR Close #49302 06 March 2023, 16:56:32 UTC
9801475 Andrew Kushnir 04 March 2023, 03:14:42 UTC refactor(core): rename TNode.tViews to TNode.tView (#49313) Previously (at the early days of Ivy) a TNode used to keep an array of TViews, but the logic was changed since that time, but the `tViews` field remained on TNode interface (+ corresponding typings). This commit renames TNode.tViews to TNode.tView and cleans up typings. PR Close #49313 06 March 2023, 16:56:00 UTC
1822585 Matthieu Riegler 27 February 2023, 18:36:39 UTC refactor(platform-browser): handle #24571 todos (#49232) This commit removes the remaining TODO(issue/24571) in platform-browser code base. PR Close #49232 06 March 2023, 16:54:38 UTC
ac59054 Andrew Scott 02 March 2023, 22:12:03 UTC refactor(migrations): Move ChangeTracker to common utils (#49308) The `ChangeTracker` is generally useful and could be used by a lot of migrations instead of having to rewrite similar boilerplate. PR Close #49308 03 March 2023, 22:03:37 UTC
b90b329 Paul Gschwendtner 03 March 2023, 16:08:09 UTC test: fix router testing example breaking due to non-existent stub (#49293) We recently migrated the testing example to use the router testing harness. There was one instance of the previous non-`TestBed` examples left that still relies on a stub that has already been removed. This example is not used anywhere and we should rather encourage a single pattern of testing. i.e. the harness as per recent changes. This commit removes the broken file. PR Close #49293 03 March 2023, 19:41:36 UTC
4ae753d Paul Gschwendtner 03 March 2023, 15:05:02 UTC build: always preserve symlinks when executing e2e test commands (#49293) Currently, examples with test commands like `ng build` are *never* using the local version of `//packages/compiler-cli`. This is because the CLI is invoked accidentally from within `external/aio_example_deps`. Since the CLI relies on importing the compiler-cli, it will always resolve the dependency from that directory- causing it to be always the version installed via `aio/examples/tools/shared/package.json`. We should never resolve symlinks and escape the e2e sandbox. That way the compiler-cli would be resolved properly and could also become the locally built one, depending on the test mode (i.e. npm or "local"). PR Close #49293 03 March 2023, 19:41:36 UTC
f859de3 Paul Gschwendtner 03 March 2023, 14:18:08 UTC build: ensure chromium is not using sandbox within Bazel sandbox for AIO example e2e tests (#49293) Chromium is launched via Karma from within the Bazel AIO example e2e tests. This breaks depending on the platform and sandbox mechanism used. We should never use Chromium's sandbox on top of Bazel's sandbox invocation. The Angular CLI exposes a browser exactly for this use-case. PR Close #49293 03 March 2023, 19:41:36 UTC
5bb4407 Paul Gschwendtner 03 March 2023, 13:55:27 UTC build: fix AIO local e2e examples picking up incorrect dependencies (#49293) Whenever we run example tests using the local framework packages, the e2e tests will have the local framework packages symlinked in the `node_modules`. This works well in general, but due to NodeJS by default resolving symlinks to the target location, NodeJS will end up looking for transitive dependencies in the `bazel-bin` instead of in the example `node_modules` folder. This means that we end up incorrectly resolving older versions of `@angular/core` that end up existing in the main project dependencies. This causes errors like: ``` Error: ../../home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/bazel-out/k8-fastbuild/bin/packages/common/npm_package/http/testing/index.d.ts:12:21 - error TS2307: Cannot find module '@angular/common/http' or its corresponding type declarations. 12 import * as i1 from '@angular/common/http'; ~~~~~~~~~~~~~~~~~~~~~~ Error: ../../home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/bazel-out/k8-fastbuild/bin/packages/common/npm_package/index.d.ts:1630:18 - error TS2707: Generic type 'ɵɵDirectiveDeclaration' requires between 6 and 8 type arguments. 1630 static ɵdir: i0.ɵɵDirectiveDeclaration<NgClass, "[ngClass]", never, { "klass": "class"; "ngClass": "ngClass"; }, {}, never, never, true, never>; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` We can fix this by properly ensuring that NodeJS does not resolve symlinks, but rather preserves them. In the error above, the e2e tests end up accidentally resolving `@angular/core` v14 that comes from `@angular/benchpress`. Angular Benchpress is installed via `@angular/build-tooling` in the project root. PR Close #49293 03 March 2023, 19:41:36 UTC
5e85c13 Paul Gschwendtner 03 March 2023, 13:33:42 UTC test: fix node and dom types conflict in `practical-observable-usage` example (#49293) This causes the e2e tests to fail. The tests were compiled using a tsconfig with `lib=dom`, but the tests explicitly tried to pull in the Node types. This causes a conflict for e.g. `AbortController` types. PR Close #49293 03 March 2023, 19:41:36 UTC
b23fa5e Paul Gschwendtner 02 March 2023, 16:42:57 UTC build(docs-infra): fix example e2e tests not failing properly in some situations (#49293) The `run-example-e2e` script does not properly fail if configured tests of examples are failing. This happens when a CLI example configures multiple tests in the `example-config`. Due to incorrect usage of promises in combination with reduce, only the last test command had an effect on the overall test conclusion. A similar issue seems to occur with SystemJS Protractor tests. This commit fixes the problem and also cleans up the code a little by switching it to `async/await`. PR Close #49293 03 March 2023, 19:41:36 UTC
05db479 Paul Gschwendtner 02 March 2023, 16:11:07 UTC build: format `run-example-e2e.mjs` with prettier (#49293) Formats the `run-example-e2e.mjs` file with prettier to ease future diffs. PR Close #49293 03 March 2023, 19:41:36 UTC
6b9ec0b Matthieu Riegler 02 March 2023, 18:38:26 UTC refactor(core): Remove ɵivyEnabled (#49296) The unit tests have been updated in #44120, this export is unused now. PR Close #49296 03 March 2023, 19:41:10 UTC
b0a9e67 Matthieu Riegler 03 March 2023, 10:59:27 UTC docs: fix links on untyped forms (#49306) PR Close #49306 03 March 2023, 19:40:00 UTC
f321e65 Matthieu Riegler 02 March 2023, 21:12:59 UTC refactor(common): remove `BrowserPlatformLocation` from private exports. (#49301) `BrowserPlatformLocation` was add to the public API by #48488. PR Close #49301 03 March 2023, 16:39:54 UTC
13e675e Angular Robot 28 February 2023, 03:09:54 UTC build: update all non-major dependencies (#49267) See associated pull request for more information. PR Close #49267 02 March 2023, 22:09:15 UTC
de48c99 Kristiyan Kostadinov 02 March 2023, 13:19:27 UTC refactor(migrations): expose current file in import remapper (#49288) Passes the path of the current file to the import remapper. Useful if we want to generate absolute paths. PR Close #49288 02 March 2023, 21:48:35 UTC
81e32f4 Andrew Scott 28 February 2023, 22:42:06 UTC docs(router): Update component testing to user `RouterTestingHarness` (#48553) This commit updates the documentation on testing the `Router` to use the `RouterTestingHarness` rather than stubs. The stubs described in the previous form of this document actually creates tests which are incapable of catching bugs related to the component's interaction with the `Router`. In addition, managing the stubs is more difficult than using the real `Router` classes. Stubbing something like the `RouterLink` is quite harmful because it neither tests the actual URL being created, nor the end result of the navigation. There have been serveral bug fixes in the Router over the years the would change the outcome of these but would not be caught by tests which create a stub. PR Close #48553 02 March 2023, 21:17:17 UTC
e20b6d9 Paul Gschwendtner 02 March 2023, 13:59:37 UTC build: remove `ts-node` forking bug workaround (#49289) In the past, `ts-node` had a bug that prevented forking processes when used in combination with `--esm`. We contributed a fix upstream to `ts-node` to fix this, and this commit updates to the latest version so that we can simplify our `ng-dev` invocation. https://github.com/TypeStrong/ts-node/commit/32d07e2b2fcbaab97c11e71ee5fc3a79fc20c802 Fixes #46858 PR Close #49289 02 March 2023, 21:16:20 UTC
d42032a Matthieu Riegler 02 March 2023, 18:46:40 UTC refactor(core): Remove `isListLikeIterable` from private export. (#49297) PR #48433 removed the last external usage of `isListLikeIterable`. We can now remove it from the private exports. PR Close #49297 02 March 2023, 20:53:01 UTC
back to top