| f0eeafb | Greg Kroah-Hartman | 14 July 2020, 12:03:44 UTC | Revert "ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb" This reverts commit b5c8896bc14f54e5c4dd5a6e42879f125b8abd2d which is commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream. It is being reverted upstream, just hasn't made it there yet and is causing lots of problems. Reported-by: Hans de Goede <hdegoede@redhat.com> Cc: Qiujun Huang <hqjagain@gmail.com> Cc: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 23 July 2020, 09:46:29 UTC |
| 8a0c16c | Dom Cobley | 23 July 2020, 09:41:38 UTC | Revert "cifs: Fix the target file was deleted when rename failed." This reverts commit 9ffad9263b467efd8f8dc7ae1941a0a655a2bab2. | 23 July 2020, 09:41:38 UTC |
| 0fe13a5 | Phil Elwell | 22 July 2020, 16:59:31 UTC | bcm2835-dma: Advertise the full DMA range Unless the DMA mask is set wider than 32 bits, DMA mapping will use a bounce buffer. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 22 July 2020, 17:01:57 UTC |
| d10760a | Phil Elwell | 22 July 2020, 16:45:24 UTC | ARM: dts: 2711 DMA can address 36 bits Kernels prior to 5.7 only see the first entry in dma-ranges, so make it cover the full addressable range. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 22 July 2020, 17:01:57 UTC |
| deca5e6 | Phil Elwell | 21 July 2020, 16:34:09 UTC | staging: vchiq_arm: children inherit DMA config Although it is no longer necessary for vchiq's children to have a different DMA configuration to the parent, they do still need to explicitly to have their DMA configuration set - to be that of the parent. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 22 July 2020, 10:32:02 UTC |
| c4aa56b | Phil Elwell | 20 July 2020, 08:35:46 UTC | SQUASH: leds: actpwr - delete unused variable Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 21 July 2020, 15:54:45 UTC |
| 1c64f4b | popcornmix | 20 April 2020, 17:00:38 UTC | vc4: Report channel mapping back to userspace This follows logic in hdmi-codec.c to use speaker layout from ELD to choose a suitable speaker mapping based on number of channels requested and signal that in audio infoframe and report this back to userspace. This allows apps like speaker-test and kodi to get the output to the right speakers. Signed-off-by: Dom Cobley <popcornmix@gmail.com> | 20 July 2020, 18:13:25 UTC |
| 9d49ae6 | Phil Elwell | 17 July 2020, 16:56:17 UTC | configs: Add MAXIM_THERMOCOUPLE=m See: https://github.com/raspberrypi/linux/issues/3732 Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 17 July 2020, 17:08:11 UTC |
| 3e92327 | Matt Flax | 16 July 2020, 23:17:36 UTC | Mute bug fix for the Audioinjector.net isolated soundcard. | 17 July 2020, 07:57:11 UTC |
| 91e8721 | Dave Stevenson | 08 May 2020, 21:05:29 UTC | staging: vc04_services: isp: Rework lens shading to take a dmabuf This removes the need for the client to use vcsm at all. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 17 July 2020, 07:42:57 UTC |
| ef834ce | Phil Elwell | 16 July 2020, 17:19:58 UTC | ARM: dts: Select the actpwr LED trigger on Zeroes The new "actpwr" LED trigger guarantees that the combined PWR and ACT LED is on for at least half of every second. Under heavy SD card load it emits a steady 1Hz square wave. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 16 July 2020, 17:22:38 UTC |
| ceb876b | Phil Elwell | 14 July 2020, 12:18:11 UTC | configs: Enable LEDS_TRIGGER_ACTPWR Make the combined mmc0 activity & power trigger available to use. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 16 July 2020, 17:22:29 UTC |
| 1bb88bb | Phil Elwell | 13 July 2020, 09:33:19 UTC | leds: Add the actpwr trigger The actpwr trigger is a meta trigger that cycles between an inverted mmc0 and default-on. It is written in a way that could fairly easily be generalised to support alternative sets of source triggers. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 16 July 2020, 17:22:29 UTC |
| 693a418 | Dave Stevenson | 16 July 2020, 11:02:47 UTC | drm/vc4: Add DRM_MODE_FLAG_DBLCLK support to vc4-fkms 480i and several other modes use DRM_MODE_FLAG_DBLCLK and pixel replication. Add in flags for that so that FKMS can select CEA modes 6 & 7. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 16 July 2020, 13:50:41 UTC |
| 2c8ec3b | Laurent Pinchart | 04 July 2020, 00:04:38 UTC | dt/dtoverlays: imx477: Add parameter to set camera module rotation Add a rotation DT overlay parameter to allow specifying the camera module mounting rotation. Set the default rotation to 180 as the module is typically mounted upside-down. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 93117cb | Laurent Pinchart | 04 July 2020, 00:04:38 UTC | dt/dtoverlays: imx219: Add parameter to set camera module rotation Add a rotation DT overlay parameter to allow specifying the camera module mounting rotation. Set the default rotation to 180 as the module is typically mounted upside-down. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 14431bd | Laurent Pinchart | 04 July 2020, 00:04:38 UTC | dt/dtoverlays: ov5647: Add parameter to set camera module rotation Add a rotation DT overlay parameter to allow specifying the camera module mounting rotation. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 77ac60b | Laurent Pinchart | 03 July 2020, 22:45:08 UTC | media: i2c: imx477: Parse and register properties Parse device properties and register controls for them using the V4L2 fwnode properties helpers. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| bb3aac1 | Jacopo Mondi | 09 May 2020, 09:04:55 UTC | media: i2c: imx219: Parse and register properties Parse device properties and register controls for them using the newly introduced helpers. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Commit ad3a44cbd1b2e1559c6b93e80dc0c9c29632969a upstream Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 0874994 | Laurent Pinchart | 03 July 2020, 22:45:08 UTC | media: i2c: ov5647: Parse and register properties Parse device properties and register controls for them using the V4L2 fwnode properties helpers. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 672dd1b | Jacopo Mondi | 09 May 2020, 09:04:52 UTC | media: v4l2-ctrls: Add helper to register properties Add an helper function to v4l2-ctrls to register controls associated with a device property. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Commit e0a360630debdf12355d9ec9f1417172c3fa6756 upstream Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 5f30e37 | Jacopo Mondi | 09 May 2020, 09:04:49 UTC | media: v4l2-fwnode: Add helper to parse device properties Add an helper function to parse common device properties in the same way as v4l2_fwnode_endpoint_parse() parses common endpoint properties. Parse the 'rotation' and 'orientation' properties from the firmware interface. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Commit 344897ef1d9b33e246b64e255d807ca6c053f349 upstream Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 3ce3fe5 | Jacopo Mondi | 09 May 2020, 09:04:48 UTC | media: v4l2-ctrls: Add camera orientation and rotation Add support for the newly defined V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION read-only controls used to report the camera device mounting position and orientation respectively. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Commit 926645d43fd43622a2b056471a2cf41cc19cbf4c upstream Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| b05c92f | Jacopo Mondi | 09 May 2020, 09:04:47 UTC | media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera control. The newly added read-only control reports the rotation correction to be applied to images before displaying them to the user. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Commit 9926c2248740a632b0629fd8c07d0fc361dc15cc upstream Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 72b78f8 | Jacopo Mondi | 09 May 2020, 09:04:46 UTC | media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION Add documentation for the V4L2_CID_CAMERA_ORIENTATION camera control. The newly added read-only control reports the camera device orientation relative to the usage orientation of the system the camera is installed on. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Commit 9397a83f40183eeafd5c787af2240ed0d6b26daa upstream Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| eaf7a40 | Jacopo Mondi | 09 May 2020, 09:04:45 UTC | media: dt-bindings: video-interface: Replace 'rotation' description Replace the 'rotation' property description by providing a definition relative to the camera sensor pixel array coordinate system and the captured scene. Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Commit 915bd31ce9ed328535e5ecf3ca730c5764ec1a38 upstream Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 9b02379 | Jacopo Mondi | 09 May 2020, 09:04:44 UTC | media: dt-bindings: video-interfaces: Document 'orientation' property Add the 'orientation' device property, used to specify the device mounting position. The property is particularly meaningful for mobile devices with a well defined usage orientation. Reviewed-by: Rob Herring <robh@kernel.org> Acked-by: Tomasz Figa <tfiga@chromium.org> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Commit cabc918e5b877ed547e5b6463f5ea6e3ac4edbb3 upstream Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 16 July 2020, 06:29:55 UTC |
| 7d9a391 | AMuszkat | 14 July 2020, 15:51:03 UTC | correct SND_SOC_DAILINK_DEFS Signed-off-by: AMuszkat <ariel.muszkat@gmail.com> | 14 July 2020, 16:08:04 UTC |
| 95a969f | Naushir Patuck | 11 May 2020, 12:06:27 UTC | dt-bindings: bcm2835-unicam: Update documentation with new clock params Update the documentation to reflect the new "VPU" clock needed by the bcm2835-unicam driver. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> | 13 July 2020, 13:49:42 UTC |
| b69524d | Naushir Patuck | 11 May 2020, 12:02:22 UTC | media: bcm2835: unicam: Set VPU min clock freq to 250Mhz. When streaming with Unicam, the VPU must have a clock frequency of at least 250Mhz. Otherwise, the input fifos could overrun, causing image corruption. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> | 13 July 2020, 13:49:42 UTC |
| ff68b68 | Phil Elwell | 10 July 2020, 15:57:43 UTC | SQUASH: dts: Further simplify firmware clocks All Pi platforms will use the firmware clocks driver, so declare it in the most common place - bcm2835-rpi.dtsi. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:21 UTC |
| a6010b6 | Dom Cobley | 02 July 2020, 18:36:08 UTC | dts: Enable NO_WAIT_RESP for hdmi audio dma Without this set, DVP_CFG_MAI0_CTL indicates occasional DLATE errors when configured to 8 channel 192kHz Signed-off-by: Dom Cobley <popcornmix@gmail.com> | 13 July 2020, 12:27:21 UTC |
| aeea5c6 | Dom Cobley | 30 June 2020, 10:23:49 UTC | vc_hdmi: Set VC4_HDMI_MAI_CONFIG_FORMAT_REVERSE Without this bit set, HDMI_MAI_FORMAT doesn't pick up the format and samplerate from DVP_CFG_MAI0_FMT and you can't get HDMI_HDMI_13_AUDIO_STATUS_1 to indicate HBR mode Signed-off-by: Dom Cobley <popcornmix@gmail.com> | 13 July 2020, 12:27:21 UTC |
| 0cfcc21 | Dom Cobley | 25 June 2020, 17:48:40 UTC | vc4_hdmi: Remove firmware logic for MAI threshold setting This was a workaround for bugs in hardware on earlier Pi models and wasn't totally successful. It makes audio quality worse on a Pi4 at the higher sample rates Signed-off-by: Dom Cobley <popcornmix@gmail.com> | 13 July 2020, 12:27:21 UTC |
| a111479 | Dom Cobley | 10 July 2020, 10:51:16 UTC | drm/vc4: enable HBR MAI format on HBR streams Signed-off-by: Matthias Reichl <hias@horus.com> | 13 July 2020, 12:27:21 UTC |
| b5572cd | Matthias Reichl | 19 March 2020, 19:00:35 UTC | drm/vc4: move setup from hw_params to prepare Configuring HDMI audio registers in prepare allows us to take IEC958 bits into account which are set by the alsa hook after the hw_params call. Signed-off-by: Matthias Reichl <hias@horus.com> | 13 July 2020, 12:27:21 UTC |
| 7c3674f | Matthias Reichl | 17 March 2020, 11:12:22 UTC | drm/vc4: add iec958 controls to vc4_hdmi Although vc4 get an IEC958 formatted stream passed in from userspace the driver needs the info from the channel status bits to properly set up the hardware, eg for HBR passthrough. Add iec958 controls so the channel status bits can be passed in from userspace. Signed-off-by: Matthias Reichl <hias@horus.com> | 13 July 2020, 12:27:21 UTC |
| 6f8cc1b | popcornmix | 10 March 2020, 22:21:15 UTC | vc4_hdmi: Set HDMI_MAI_FMT The hardware uses this for generating the right audio data island packets when using formats other than PCM Signed-off-by: Dom Cobley <popcornmix@gmail.com> | 13 July 2020, 12:27:20 UTC |
| 735475f | Dave Stevenson | 07 July 2020, 15:14:36 UTC | defconfigs: Add the Omnivision OV7251 sensor driver to the defconfigs Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| a40efe4 | Dave Stevenson | 07 July 2020, 15:12:05 UTC | dtoverlays: Create an overlay for the Omnivision OV7251 sensor Adds an overlay for the OV7251 VGA global shutter sensor. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| 1abb95b | Phil Elwell | 09 July 2020, 13:34:34 UTC | configs: Add CAN_EMS_USB=m See: https://github.com/raspberrypi/linux/issues/3716 Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| 377b7d7 | Dave Stevenson | 07 July 2020, 13:52:43 UTC | media: bcm2835-unicam: Ensure type is VIDEO_CAPTURE in [g|s]_selection [g|s]_selection pass in a buffer type that needs to be validated before passing on to the sensor subdev. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| be19264 | Dave Stevenson | 07 July 2020, 13:23:40 UTC | media: bcm2835-unicam: Reinstate V4L2_CAP_READWRITE in the caps v4l2-compliance throws a failure if the device doesn't advertise V4L2_CAP_READWRITE but allows read or write operations. We do support read, so reinstate the flag. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| 2180649 | Dave Stevenson | 07 July 2020, 10:51:26 UTC | media: i2c: imx290: Set the colorspace fields in the format The colorspace fields were left untouched in imx290_set_fmt which lead to a v4l2-compliance failure. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| 7e4b668 | Dave Stevenson | 07 July 2020, 10:23:48 UTC | media: i2c: imx290: Add support for g_selection to report cropping Userspace needs to know the cropping arrangements for each mode, so expose this through g_selection. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| ef6895b | Dave Stevenson | 07 July 2020, 09:31:53 UTC | media: i2c: imx290: Explicitly set v&h blank on mode change __v4l2_ctrl_modify_range only updates the current value should it be invalid within the new range. That can leave modes producing odd frame rates. Explicitly update the HBLANK and VBLANK values so that on mode change we revert to the default frame rate for the mode. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| fd2c293 | Phil Elwell | 08 July 2020, 16:33:06 UTC | ARM: dts: hifiberry-dacplus headphone amp support Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:20 UTC |
| 690f3fc | Joerg Schambacher | 07 July 2020, 13:09:06 UTC | Enhances the DAC+ driver to control the optional headphone amplifier Probes on the I2C bus for TPA6130A2, if successful, it sets DT-parameter 'status' from 'disabled' to 'okay' using change_sets to enable the headphone control. Signed-off-by: Joerg Schambacher joerg@i2audio.com | 13 July 2020, 12:27:20 UTC |
| cbd44b7 | Stefan Wahren | 01 January 2020, 14:01:34 UTC | Bluetooth: hci_bcm: Drive RTS only for BCM43438 commit e601daed271e9eb1b923972a0a1af65f8c7bb77b upstream. The commit 3347a80965b3 ("Bluetooth: hci_bcm: Fix RTS handling during startup") is causing at least a regression for AP6256 on Orange Pi 3. So do the RTS line handing during startup only on the necessary platform. Fixes: 3347a80965b3 ("Bluetooth: hci_bcm: Fix RTS handling during startup") Reported-by: Ondřej Jirman <megous@megous.com> Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> | 13 July 2020, 12:27:19 UTC |
| 8144762 | Abhishek Pandit-Subedi | 26 November 2019, 07:17:32 UTC | Bluetooth: hci_bcm: Support pcm params in dts commit eb762b94111b646b4f116ebfdbfcadbad14e12b3 upstream. BCM chips may require configuration of PCM to operate correctly and there is a vendor specific HCI command to do this. Add support in the hci_bcm driver to parse this from devicetree and configure the chip. Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> | 13 July 2020, 12:27:19 UTC |
| ca925bd | Abhishek Pandit-Subedi | 26 November 2019, 07:17:30 UTC | Bluetooth: btbcm: Support pcm configuration commit 528379902337102b0264fe5343eafb3d6c59fa45 upstream. Add BCM vendor specific command to configure PCM parameters. The new vendor opcode allows us to set the sco routing, the pcm interface rate, and a few other pcm specific options (frame sync, sync mode, and clock mode). See broadcom-bluetooth.txt in Documentation for more information about valid values for those settings. Here is an example trace where this opcode was used to configure a BCM4354: < HCI Command: Vendor (0x3f|0x001c) plen 5 01 02 00 01 01 > HCI Event: Command Complete (0x0e) plen 4 Vendor (0x3f|0x001c) ncmd 1 Status: Success (0x00) We can read back the values as well with ocf 0x001d to confirm the values that were set: $ hcitool cmd 0x3f 0x001d < HCI Command: ogf 0x3f, ocf 0x001d, plen 0 > HCI Event: 0x0e plen 9 01 1D FC 00 01 02 00 01 01 Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> | 13 July 2020, 12:27:19 UTC |
| 21f9685 | Abhishek Pandit-Subedi | 26 November 2019, 07:17:29 UTC | Bluetooth: hci_bcm: Disallow set_baudrate for BCM4354 commit 5d6f391073d5c1c903ac12be72c66b96b2ae93f4 upstream. Without updating the patchram, the BCM4354 does not support a higher operating speed. The normal bcm_setup follows the correct order (init_speed, patchram and then oper_speed) but the serdev driver will set the operating speed before calling the hu->setup function. Thus, for the BCM4354, don't set the operating speed before patchram. Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> | 13 July 2020, 12:27:19 UTC |
| c85745b | Mohammad Rasim | 20 November 2019, 11:02:35 UTC | Bluetooth: btbcm: Add entry for BCM4335A0 UART bluetooth commit 1199ab4c9e1d4cdfbabd70b4aadbc8e72c691f65 upstream. This patch adds the device ID for the BCM4335A0 module (part of the AMPAK AP6335 WIFI/Bluetooth combo) hciconfig output: ``` hci1: Type: Primary Bus: UART BD Address: 43:35:B0:07:1F:AC ACL MTU: 1021:8 SCO MTU: 64:1 UP RUNNING RX bytes:5079 acl:0 sco:0 events:567 errors:0 TX bytes:69065 acl:0 sco:0 commands:567 errors:0 Features: 0xbf 0xfe 0xcf 0xff 0xdf 0xff 0x7b 0x87 Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3 Link policy: RSWITCH SNIFF Link mode: SLAVE ACCEPT Name: 'alarm' Class: 0x000000 Service Classes: Unspecified Device Class: Miscellaneous, HCI Version: 4.0 (0x6) Revision: 0x161 LMP Version: 4.0 (0x6) Subversion: 0x4106 Manufacturer: Broadcom Corporation (15) ``` Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> | 13 July 2020, 12:27:19 UTC |
| bd73be0 | Abhishek Pandit-Subedi | 25 October 2019, 21:54:26 UTC | Bluetooth: hci_bcm: Add compatible string for BCM43540 commit d462af20dbfa1b9b1a831412f32d9d6757b82459 upstream. The BCM43540 chip is a 802.11 a/b/g/n/ac + Bluetooth 4.1 combo module. This patch adds a compatible string match to the serdev driver for the Bluetooth part of the chip. Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> | 13 July 2020, 12:27:19 UTC |
| 81a87b6 | Stefan Wahren | 06 October 2019, 15:28:19 UTC | Bluetooth: hci_bcm: Fix RTS handling during startup commit 3347a80965b38f096b1d6f995c00c9c9e53d4b8b upstream. The RPi 4 uses the hardware handshake lines for CYW43455, but the chip doesn't react to HCI requests during DT probe. The reason is the inproper handling of the RTS line during startup. According to the startup signaling sequence in the CYW43455 datasheet, the hosts RTS line must be driven after BT_REG_ON and BT_HOST_WAKE. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> | 13 July 2020, 12:27:19 UTC |
| ed29f90 | Dave Stevenson | 06 July 2020, 17:45:01 UTC | defconfigs: Add OV9281 to all the Pi defconfigs Adds the driver for use by the dtoverlay. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:19 UTC |
| 0f554bc | Dave Stevenson | 06 July 2020, 16:32:21 UTC | dtoverlay: Add overlay for Omnivision OV9281 image sensor Adds an overlay for the OV9281 mono imaging sensor using 2 CSI-2 data lanes. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:19 UTC |
| 445e291 | Dave Stevenson | 06 July 2020, 16:51:32 UTC | media: i2c: ov9281: Read chip ID via 2 reads Vision Components have made an OV9281 module which blocks reading back the majority of registers to comply with NDAs, and in doing so doesn't allow auto-increment register reading as used when reading the chip ID. Use two reads and manually combine the results. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:19 UTC |
| 93b9105 | Dave Stevenson | 14 April 2020, 15:12:33 UTC | media: i2c: ov9281: Fixup for recent kernel releases, and remove custom code The Rockchip driver was based on a 4.4 kernel, and had several custom Rockchip parts. Update to 5.4 kernel APIs, with the relevant controls required by libcamera, and remove custom Rockchip parts. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:18 UTC |
| 41f6b90 | Dave Stevenson | 14 April 2020, 14:51:50 UTC | media: i2c: ov9281: add enum_frame_interval function for iq tool 2.2 and hal3 Adds the ov9281 parts of the Rockchip patch adding enum_frame_interval to a large number of drivers. Change-Id: I03344cd6cf278dd7c18fce8e97479089ef185a5c Signed-off-by: Zefa Chen <zefa.chen@rock-chips.com> | 13 July 2020, 12:27:18 UTC |
| 371914c | Dave Stevenson | 14 April 2020, 14:47:09 UTC | media: i2c: ov9281: fix mclk issue when probe multiple camera. Takes the ov9281 part only from the Rockchip's patch. Change-Id: I30e833baf2c1bb07d6d87ddb3b00759ab45a90e4 Signed-off-by: Zefa Chen <zefa.chen@rock-chips.com> | 13 July 2020, 12:27:18 UTC |
| 3515a80 | Zefa Chen | 17 May 2019, 10:23:03 UTC | media: i2c: add ov9281 driver. Change-Id: I7b77250bbc56d2f861450cf77271ad15f9b88ab1 Signed-off-by: Zefa Chen <zefa.chen@rock-chips.com> | 13 July 2020, 12:27:18 UTC |
| cd83e6c | Phil Elwell | 07 July 2020, 13:22:25 UTC | configs: Enable CONFIG_BLK_DEV_NVME=m Enable support for NVME SSDs. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:18 UTC |
| a27e1c9 | Phil Elwell | 07 July 2020, 13:08:55 UTC | ARM: dts: Restore the old 2711 scb ranges property The back-ported value breaks PCIe. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:18 UTC |
| 07a29b8 | Phil Elwell | 01 July 2020, 19:28:27 UTC | bcm2835-dma: Add NO_WAIT_RESP flag Use bit 27 of the dreq value (the second cell of the DT DMA descriptor) to request that the WAIT_RESP bit is not set. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:18 UTC |
| a56a992 | Phil Elwell | 07 July 2020, 08:01:54 UTC | ARM: dts: Make bcm2711 dts more like 5.7 The multiple declarations of pixelvalve2 were causing problems for the DT checkers. Aligning the dts files closer to the later kernel versions avoids some repetition and should make maintenance easier. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:18 UTC |
| 9f7c14b | Phil Elwell | 06 July 2020, 16:53:47 UTC | ARM: dts: Copy kernel BT changes to CM4 Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:18 UTC |
| 8ad784c | Phil Elwell | 06 July 2020, 19:04:53 UTC | configs: Regenerate Pi defconfigs Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:18 UTC |
| e57f574 | Phil Elwell | 04 July 2020, 21:19:26 UTC | overlays: rpi-ft5406: Fix boolean parameters An improvement in the automated testing of overlays revealed these invalid boolean parameter declarations. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:18 UTC |
| 0a14d53 | Dave Stevenson | 01 July 2020, 17:28:10 UTC | dtoverlays: Fixup imx219 and imx477 overlays due to parsing failures imx219 overlay failed to detect as CSI2 as it was missing any of the CSI2 properties on the Unicam end of the configuration. Clean up imx477 as well to include all the relevant properties. Fixes: "dt/dtoverlays: Fix up base DT and overlays for updated Unicam driver" Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| d178d70 | Lukas Wunner | 04 February 2020, 14:50:41 UTC | irqchip/bcm2835: Quiesce IRQs left enabled by bootloader [ Upstream commit bd59b343a9c902c522f006e6d71080f4893bbf42 ] Per the spec, the BCM2835's IRQs are all disabled when coming out of power-on reset. Its IRQ driver assumes that's still the case when the kernel boots and does not perform any initialization of the registers. However the Raspberry Pi Foundation's bootloader leaves the USB interrupt enabled when handing over control to the kernel. Quiesce IRQs and the FIQ if they were left enabled and log a message to let users know that they should update the bootloader once a fixed version is released. If the USB interrupt is not quiesced and the USB driver later on claims the FIQ (as it does on the Raspberry Pi Foundation's downstream kernel), interrupt latency for all other peripherals increases and occasional lockups occur. That's because both the FIQ and the normal USB interrupt fire simultaneously: On a multicore Raspberry Pi, if normal interrupts are routed to CPU 0 and the FIQ to CPU 1 (hardcoded in the Foundation's kernel), then a USB interrupt causes CPU 0 to spin in bcm2836_chained_handle_irq() until the FIQ on CPU 1 has cleared it. Other peripherals' interrupts are starved as long. I've seen CPU 0 blocked for up to 2.9 msec. eMMC throughput on a Compute Module 3 irregularly dips to 23.0 MB/s without this commit but remains relatively constant at 23.5 MB/s with this commit. The lockups occur when CPU 0 receives a USB interrupt while holding a lock which CPU 1 is trying to acquire while the FIQ is temporarily disabled on CPU 1. At best users get RCU CPU stall warnings, but most of the time the system just freezes. Fixes: 89214f009c1d ("ARM: bcm2835: add interrupt controller driver") Signed-off-by: Lukas Wunner <lukas@wunner.de> Signed-off-by: Marc Zyngier <maz@kernel.org> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Link: https://lore.kernel.org/r/f97868ba4e9b86ddad71f44ec9d8b3b7d8daa1ea.1582618537.git.lukas@wunner.de | 13 July 2020, 12:27:17 UTC |
| d30032b | Dave Stevenson | 03 July 2020, 15:13:33 UTC | drm/vc4: FKMS: Put includes in alphabetical order, and use <> instead of "" Reorder the includes, and use the system include paths rather than local ones Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| 1479bb2 | Dave Stevenson | 03 July 2020, 15:05:37 UTC | dt: Use rpi-firmware-kms-2711 on 2711 platforms Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| e9cc93a | Dave Stevenson | 03 July 2020, 15:06:55 UTC | drm/vc4: FKMS Block modes with odd horizontal timing values on Pi4 Pi4 HDMI pipeline is 2 pixels/clock and can not produce timings that have odd values for active pixels, front porch, sync width, or back porch. Detect these modes and block them within fkms. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| 8e3b979 | Dave Stevenson | 03 July 2020, 13:11:55 UTC | drm/vc4: Make FKMS max refresh rate a module parameter Some people want to use the high refresh rate modes for 1080p100 and 1080p120, but they're currently filtered out as generally they don't add anything. Make the filter threshold a module parameter so that it can be adjusted. https://github.com/raspberrypi/linux/issues/3677 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| 6f74fd0 | Phil Elwell | 02 July 2020, 14:21:05 UTC | overlays: Fix miniuart-bt "krnbt" parameter Although superficially appealing, an overlay parameter that targets a label in the base DTB is not currently supported. Instead it is necessary to create a fragment targeting the label which is patched by the parameter. Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| 0014a31 | Dave Stevenson | 01 July 2020, 09:57:57 UTC | media: bcm2835-unicam: Add support for unpacked 14bit Bayer formats Now that the 14bit non-packed Bayer formats are defined, add them into the supported formats lookup table. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| 255e824 | Dave Stevenson | 25 June 2020, 17:03:47 UTC | media: bcm2835-unicam: Add support for 14bit mono sources Now that V4L2_PIX_FMT_Y14 and V4L2_PIX_FMT_Y14P are defined, allow passing 14bit mono data through the peripheral. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| e047cfe | Dave Stevenson | 25 June 2020, 16:53:32 UTC | media: bcm2835-unicam: Add support for 12bit mono packed format Now that V4L2_PIX_FMT_Y12P is defined, allow passing raw 12bit mono packed data through the peripheral. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:17 UTC |
| 7f43b25 | Dave Stevenson | 01 July 2020, 09:50:12 UTC | staging: vc04_services: codec: Add support for 14bit Bayer formats Now that the 14bit Bayer formats have been defined within V4L2, add them to the lookup table of V4L2/MMAL formats. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:16 UTC |
| 1be36af | Dave Stevenson | 01 July 2020, 09:38:12 UTC | staging: vc04_services: codec: Add support for mono formats The firmware ISP component now allows for processing of mono images, so add those formats for use by the simple ISP device. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:16 UTC |
| db6842f | Dave Stevenson | 25 June 2020, 16:40:56 UTC | staging: vc04_services: codec: Increase the number of supported formats expected The ISP now supports 47 different input formats, therefore increase the array size for the number expected. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:16 UTC |
| c1acb54 | Dave Stevenson | 06 May 2020, 17:24:34 UTC | staging: vc04_services: isp: Increase the number of supported formats expected The ISP now supports 47 different input formats, therefore increase the array size for the number expected. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:16 UTC |
| aa1d848 | Dave Stevenson | 06 May 2020, 17:11:14 UTC | staging: vc04_services: isp: Add monochrome image formats Adds support for monochrome image formats in the various MIPI packings. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:16 UTC |
| 81e5e4c | Dave Stevenson | 06 May 2020, 17:09:04 UTC | staging: vc04_services: isp: Add support for 14bit Bayer The only thing missing was a set of defines, therefore add them in. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:16 UTC |
| a4c61c6 | Dave Stevenson | 25 June 2020, 16:51:03 UTC | media: Add a pixel format for MIPI packed 14bit luma only. This is the format used by monochrome 14bit image sensors. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:16 UTC |
| d8737b9 | Dave Stevenson | 07 May 2020, 15:59:03 UTC | media: Add a pixel format for MIPI packed 12bit luma only. This is the format used by monochrome 12bit image sensors. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:16 UTC |
| 0c288e7 | Daniel Glöckner | 24 February 2020, 17:52:22 UTC | media: v4l: Add 1X14 14-bit greyscale media bus code definition Commit 573a750813459725c6f6fc4bc5779da1fe03238a upstream. The code is called MEDIA_BUS_FMT_Y14_1X14 and behaves just like MEDIA_BUS_FMT_Y12_1X12 with two more bits. Signed-off-by: Daniel Glöckner <dg@emlix.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 13 July 2020, 12:27:16 UTC |
| 53a6ba3 | Daniel Glöckner | 24 February 2020, 17:52:21 UTC | media: v4l: Add 14-bit raw greyscale pixel format Commit ae9753a04cfc8e41262605875e531b6ea5e3d0ac upstream. The new format is called V4L2_PIX_FMT_Y14. Like V4L2_PIX_FMT_Y10 and V4L2_PIX_FMT_Y12 it is stored in two bytes per pixel but has only two unused bits at the top. Signed-off-by: Daniel Glöckner <dg@emlix.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 13 July 2020, 12:27:16 UTC |
| 0173fa1 | Sakari Ailus | 24 February 2020, 17:52:20 UTC | media: v4l: Add 14-bit raw bayer pixel formats Commit d12127ed0e18192491c2508caae45bb19c2f8fdd upstream. The formats added by this patch are: V4L2_PIX_FMT_SBGGR14 V4L2_PIX_FMT_SGBRG14 V4L2_PIX_FMT_SGRBG14 V4L2_PIX_FMT_SRGGB14 Signed-off-by: Jouni Ukkonen <jouni.ukkonen@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> [dg@emlix.com: rebased onto current media_tree] Signed-off-by: Daniel Glöckner <dg@emlix.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 13 July 2020, 12:27:16 UTC |
| ffdf357 | Phil Elwell | 02 July 2020, 12:53:20 UTC | serial: 8250: bcm2835aux - defer if clock is zero See: https://github.com/raspberrypi/linux/issues/3700 Signed-off-by: Phil Elwell <phil@raspberrypi.com> | 13 July 2020, 12:27:15 UTC |
| 9dca783 | Dave Stevenson | 30 June 2020, 17:04:13 UTC | drm/vc4: Allow interlaced HDMI modes from FKMS. Having checked the firmware handling for interlaced modes, it appears to be possible to support interlaced modes on HDMI without adverse side effects, so do so. https://github.com/raspberrypi/linux/issues/3694 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:15 UTC |
| 74285d5 | Maxim Mikityanskiy | 27 June 2020, 10:08:26 UTC | ARM: dts: Add Bluetooth nodes for Raspberry Pi Add device tree nodes for Bluetooth on supported Raspberry Pi boards. It's disabled by default and can be enabled by `krnbt=on` dtparam. It's an alternative way of configuring Bluetooth, as compared to hciattach or btattach. When the dtparam is enabled, the Bluetooth driver is probed automatically and doesn't require any additional bring-up scripts. Note that Raspberry Pi 3 B rev 1.2 doesn't have the required hardware flow control pins of UART0 connected to the Bluetooth module, so the user should decrease the baudrate by passing `krnbt_baudrate=921600` dtparam to make it more stable. It resembles the behavior of the btuart script from Raspbian. The miniuart-bt overlay was modified to support Bluetooth probing with device tree, too. It's disabled by default and can be enabled by `krnbt=on` parameter of the miniuart-bt overlay. Signed-off-by: Maxim Mikityanskiy <maxtram95@gmail.com> | 13 July 2020, 12:27:15 UTC |
| 4e3cc0c | Maxim Mikityanskiy | 21 June 2020, 15:06:31 UTC | config: Set CONFIG_SERIAL_DEV_CTRL_TTYPORT=y in Raspberry Pi defconfigs The next patch adds a device tree overlay for Bluetooth. The Bluetooth device node is a child of uart0 (pl011). The children of pl011 are not registered as platform devices by of_platform_bus_create, because they fall into `of_device_is_compatible(bus, "arm,primecell")` check. These children are registered by of_serdev_register_devices, called through this chain of calls: - uart_add_one_port (drivers/tty/serial/amba-pl011.c) - tty_port_register_device_attr_serdev - serdev_tty_port_register - serdev_controller_add - of_serdev_register_devices serdev_tty_port_register depends on CONFIG_SERIAL_DEV_CTRL_TTYPORT, which in turn depends on CONFIG_SERIAL_DEV_BUS=y. This patch modifies the defconfigs of Raspberry Pi devices to set these options and allow to bind drivers to subnodes of UART devices that can be added by device tree overlays. Signed-off-by: Maxim Mikityanskiy <maxtram95@gmail.com> | 13 July 2020, 12:27:15 UTC |
| 0511a29 | Naushir Patuck | 19 May 2020, 14:57:23 UTC | uapi: bcm2835-isp: Fixups for bcm2835-isp uapi structures Rename pad_[] to padding[]. struct bcm2835_isp_rational.den is now unsigned. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> | 13 July 2020, 12:27:15 UTC |
| 8e10e3c | Naushir Patuck | 19 May 2020, 14:57:08 UTC | staging: vc04_services: isp: Reorder operations during device probe Register the video node at the end of the probe, swapping order with registering the controls. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> | 13 July 2020, 12:27:15 UTC |
| 8e7febe | Naushir Patuck | 19 May 2020, 14:56:47 UTC | staging: vc04_services: isp: Fixup g/s_selection implementation Add V4L2_SEL_TGT_CROP_DEFAULT and V4L2_SEL_TGT_CROP_BOUND targets. Disable the appropriate ioctls for the meta capture nodes - this now passes v4l2-compliance tests. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> | 13 July 2020, 12:27:15 UTC |
| 952dfa6 | Dom Cobley | 23 June 2020, 17:37:01 UTC | vc4_hdmi: Set HD_CTL_WHOLSMP and HD_CTL_CHALIGN_SET Symptom is random switching of speakers when using multichannel. Repeatedly running speakertest -c8 occasionally starts with channels jumbled. This is fixed with HD_CTL_WHOLSMP. The other bit looks beneficial and apears harmless in testing so I'd suggest adding it too. Documentation says: HD_CTL_WHILSMP_SET Wait for whole sample. When this bit is set MAI transmit will start only when there is at least one whole sample available in the fifo. Documentation says: HD_CTL_CHALIGN_SET Channel Align When Overflow. This bit is used to realign the audio channels in case of an overflow. If this bit is set, after the detection of an overflow, equal amount of dummy words to the missing words will be written to fifo, filling up the broken sample and maintaining alignment. Signed-off-by: Dom Cobley <popcornmix@gmail.com> | 13 July 2020, 12:27:15 UTC |
| 513d656 | Dave Stevenson | 25 June 2020, 17:12:17 UTC | defconfig: Add Sony IMX290 image sensor driver to all Pi defconfigs Adds the mainline IMX290 sensor driver (with extra features) to the default configs. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:15 UTC |
| 183a95e | Dave Stevenson | 19 May 2020, 12:35:17 UTC | dtoverlays: Add an overlay for the Sony IMX290 image sensor Adds an overlay to configure the IMX290 image sensor. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> | 13 July 2020, 12:27:15 UTC |
