Skip to main content

Browse the archive

https://github.com/facebook/rocksdb
17 June 2024, 23:04:45 UTC
sort by:
Revision Author Date Message Commit Date
7fe2470 Yueh-Hsuan Chiang 14 November 2014, 19:19:00 UTC Update HISTORY.md for RocksJava 14 November 2014, 19:23:00 UTC
136b858 Siying Dong 14 November 2014, 18:56:41 UTC Merge pull request #395 from lalinsky/fix-env-test Relax the block count check on deallocation in env_test 14 November 2014, 18:56:41 UTC
94fa542 Igor Canadi 14 November 2014, 18:43:12 UTC Update HISTROY.md for 3.8 release 14 November 2014, 18:43:12 UTC
a177742 sdong 12 November 2014, 21:05:12 UTC Make db_stress built for ROCKSDB_LITE Summary: Make db_stress built for ROCKSDB_LITE. The test doesn't pass tough. It seg fault quickly. But I took a look and it doesn't seem to be related to lite version. Likely to be a bug inside RocksDB. Test Plan: make db_stress Reviewers: yhchiang, rven, ljin, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28797 14 November 2014, 18:20:51 UTC
746cfaa Lukáš Lalinský 14 November 2014, 00:58:05 UTC Relax the block count check on deallocation in env_test It seems that on some FS we get more blocks than we ask for. This is already handled when checking the allocated number of blocks, but after the file is closed it checks for an exact number of blocks, which fails on my machine. I changed the test to add one full page to the size, then calculate the expected number of blocks and check if the actual number of blocks is less or equal to that. 14 November 2014, 00:58:05 UTC
f822129 sdong 13 November 2014, 23:19:57 UTC Add a unit test for behavior when merge operator and compaction filter co-exist. Summary: Add a unit test in db_test to verify the behavior when both of merge operator and compaction filter apply to a key when merging. Test Plan: Run the new test Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28455 13 November 2014, 23:21:12 UTC
4161de9 Yueh-Hsuan Chiang 13 November 2014, 23:21:04 UTC Fix SIGSEGV Summary: As a short-term fix, let's go back to previous way of calculating NeedsCompaction(). SIGSEGV happens because NeedsCompaction() can happen before super_version (and thus MutableCFOptions) is initialized. Test Plan: make check Reviewers: ljin, sdong, rven, yhchiang Reviewed By: yhchiang Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28875 13 November 2014, 23:21:04 UTC
373c665 Hasnain Lakhani 13 November 2014, 22:46:30 UTC Fix broken test in 31b02d. Summary: CorruptionTest for backupable_db_test did not call GarbageCollect() after deleting a corrupt backup, which sometimes lead to test failures as the newly created backup would reuse the same backup ID and files and fail the consistency check. Moved around some of the test logic to ensure that GarbageCollect() is called at the right time. Test Plan: Run backupable_db_test eight times and make sure it passes repeatedly. Also run make check to make sure other tests don't fail. Reviewers: igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28863 13 November 2014, 22:46:30 UTC
772bc97 Igor Canadi 13 November 2014, 21:45:33 UTC No CompactFiles in ROCKSDB_LITE Summary: It adds lots of code. Test Plan: compile for iOS, compile for mac. works. Reviewers: rven, sdong, ljin, yhchiang Reviewed By: yhchiang Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28857 13 November 2014, 21:45:33 UTC
1d1a64f Yueh-Hsuan Chiang 13 November 2014, 21:41:43 UTC Move NeedsCompaction() from VersionStorageInfo to CompactionPicker Summary: Move NeedsCompaction() from VersionStorageInfo to CompactionPicker to allow different compaction strategy to have their own way to determine whether doing compaction is necessary. When compaction style is set to kCompactionStyleNone, then NeedsCompaction() will always return false. Test Plan: export ROCKSDB_TESTS=Compact ./db_test Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28719 13 November 2014, 21:41:43 UTC
cd09801 Igor Canadi 13 November 2014, 21:34:29 UTC Add concurrency to compacting SpatialDB Summary: This will speed up our import times Test Plan: Added simple unit test just to get code coverage Reviewers: sdong, ljin, yhchiang, rven, mohaps Reviewed By: mohaps Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28869 13 November 2014, 21:34:29 UTC
3c92e52 Igor Canadi 13 November 2014, 19:47:54 UTC Fix include 13 November 2014, 19:47:54 UTC
25f2730 Igor Canadi 13 November 2014, 19:39:30 UTC Fix iOS compile with -Wshorten-64-to-32 Summary: So iOS size_t is 32-bit, so we need to static_cast<size_t> any uint64_t :( Test Plan: TARGET_OS=IOS make static_lib Reviewers: dhruba, ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28743 13 November 2014, 19:39:30 UTC
fa50abb sdong 12 November 2014, 22:19:33 UTC Fix bug of reading from empty DB. Summary: I found that db_stress sometimes segfault on my machine. Fix the bug. Test Plan: make all check. Run db_stress Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28803 13 November 2014, 18:42:18 UTC
31b02dc Hasnain Lakhani 13 November 2014, 17:51:41 UTC Improve Backup Engine. Summary: Improve the backup engine by not deleting the corrupted backup when it is detected; instead leaving it to the client to delete the corrupted backup. Also add a BackupEngine::Open() call. Test Plan: Add check to CorruptionTest inside backupable_db_test to check that the corrupt backups are not deleted. The previous version of the code failed this test as backups were deleted, but after the changes in this commit, this test passes. Run make check to ensure that no other tests fail. Reviewers: sdong, benj, sanketh, sumeet, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28521 13 November 2014, 17:51:41 UTC
1033db2 Yueh-Hsuan Chiang 12 November 2014, 20:26:21 UTC Merge pull request #390 from fyrz/RocksJava-Cleanup [RocksJava] Cleanup 12 November 2014, 20:26:21 UTC
9a03da7 Yueh-Hsuan Chiang 12 November 2014, 20:25:15 UTC Merge pull request #375 from fyrz/RocksJava-ColumnFamilyOptions-Extension-3.6 [RocksJava] ColumnFamilyOptions extension 3.6 12 November 2014, 20:25:15 UTC
d50c68e fyrz 08 November 2014, 19:35:35 UTC [RocksJava] JavaDoc cleanup warnings with Java8 Java8 is more restrictive than Java7 with generating JavaDocs. This commit resolves current existing Java8 warnings. 12 November 2014, 19:51:04 UTC
079d942 fyrz 08 November 2014, 18:19:29 UTC [RocksJava] Code-cleanup + Java7 warnings removed 12 November 2014, 19:42:25 UTC
9a255b9 fyrz 12 November 2014, 18:49:13 UTC [RocksJava] Sample and Default value - RocksDB ColumnFamilySample adjusted to C++ sample. - DefaultColumnFamily is available now as constant in RocksDB. 12 November 2014, 18:49:13 UTC
9d2ba21 fyrz 08 November 2014, 17:58:35 UTC [RocksJava] Incorporated review comments 12 November 2014, 18:28:26 UTC
fa9cfc6 fyrz 05 November 2014, 11:50:26 UTC [RocksJava] Integrated Review comments from yhchiang in D28023 12 November 2014, 18:28:25 UTC
75010d2 fyrz 31 October 2014, 22:39:14 UTC [RocksJava] ColumnFamily custom Options API extension ********************* *************************** ******** ************* ******** ******** *********** ******** ******** ********* ******** ************************************* ************************************* ************************************* ****** *** *** ****** ****** *** *** *** ****** ****** *** ****** *************************** ********************* 12 November 2014, 18:28:24 UTC
0345c21 fyrz 28 October 2014, 21:38:08 UTC [RocksJava] Extend Options with ColumnFamilyOptions implementation ColumnFamilyOptions implementation with tests [RocksJava] Extended ColumnFamilyTest Summary: Options Refactoring split part 3 Test Plan: make rocksdbjava make jtest Reviewers: yhchiang, ankgup87 Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D28023 12 November 2014, 18:28:23 UTC
9759495 Yueh-Hsuan Chiang 11 November 2014, 23:22:06 UTC Fixed clang compile error in version_builder_test Summary: Fixed clang compile error in version_builder_test Test Plan: ./version_builder_test Reviewers: igor, sdong Reviewed By: sdong Subscribers: sdong, dhruba Differential Revision: https://reviews.facebook.net/D28731 11 November 2014, 23:22:06 UTC
5811419 Yueh-Hsuan Chiang 11 November 2014, 22:28:18 UTC Fixed GetEstimatedActiveKeys Summary: Fixed a bug in GetEstimatedActiveKeys which does not normalized the sampled information correctly. Add a test in version_builder_test. Test Plan: version_builder_test Reviewers: ljin, igor, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28707 11 November 2014, 22:28:18 UTC
1f621e6 Igor Canadi 11 November 2014, 22:09:10 UTC Fix additional -Wshorten-64-to-32 errros 11 November 2014, 22:09:14 UTC
767777c Igor Canadi 11 November 2014, 21:47:22 UTC Turn on -Wshorten-64-to-32 and fix all the errors Summary: We need to turn on -Wshorten-64-to-32 for mobile. See D1671432 (internal phabricator) for details. This diff turns on the warning flag and fixes all the errors. There were also some interesting errors that I might call bugs, especially in plain table. Going forward, I think it makes sense to have this flag turned on and be very very careful when converting 64-bit to 32-bit variables. Test Plan: compiles Reviewers: ljin, rven, yhchiang, sdong Reviewed By: yhchiang Subscribers: bobbaldwin, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28689 11 November 2014, 21:47:22 UTC
113796c Igor Canadi 11 November 2014, 14:58:47 UTC Fix NewFileNumber() Summary: I mistakenly changed the behavior to ++next_file_number_ instead of next_file_number_++, as it should have been: https://github.com/facebook/rocksdb/blob/344edbb044ff5c08a43e4a6e9344c5c861552c0e/db/version_set.h#L539 Test Plan: none. not sure if this would break anything. It's just different behavior, so I'd rather not risk Reviewers: ljin, rven, yhchiang, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28557 11 November 2014, 14:58:47 UTC
625e162 Yueh-Hsuan Chiang 11 November 2014, 09:11:59 UTC Merge pull request #393 from fyrz/RocksJava-Flush [RocksJava] Memtable flush functionality 11 November 2014, 09:11:59 UTC
fc6fcba fyrz 09 November 2014, 19:09:39 UTC [RocksJava] Flush functionality RocksJava now supports also flush functionality of RocksDB. 11 November 2014, 06:47:38 UTC
8e5547f fyrz 09 November 2014, 19:08:35 UTC [RocksJava] Makefile restructured 11 November 2014, 06:47:38 UTC
26f0a78 Yueh-Hsuan Chiang 11 November 2014, 06:12:11 UTC Merge pull request #363 from adamretter/write_batch-iterate Iterator support for Write Batches 11 November 2014, 06:12:11 UTC
35c8c81 Tomislav Novak 26 September 2014, 21:20:24 UTC Make ForwardIterator::status() more efficient Summary: In D19581 I made `ForwardIterator::status()` check all child iterators, including immutable ones. It's, however, not necessary to do it every time -- it'll suffice to check only when they're used and their status could change. This diff: * introduces `immutable_status_` which is updated by `Seek()` and `Next()` * removes special handling of `kIncomplete` status in those methods Test Plan: * `db_test` * hacked ReadSequential in db_bench.cc to check `status()` in addition to validity: ``` $ ./db_bench -use_existing_db -benchmarks readseq -disable_auto_compactions \ -use_tailing_iterator # without this patch Keys: 16 bytes each Values: 100 bytes each (50 bytes after compression) Entries: 1000000 [...] DB path: [/dev/shm/rocksdbtest/dbbench] readseq : 0.562 micros/op 1778103 ops/sec; 98.4 MB/s $ ./db_bench -use_existing_db -benchmarks readseq -disable_auto_compactions \ -use_tailing_iterator # with the patch readseq : 0.433 micros/op 2311363 ops/sec; 127.8 MB/s ``` Reviewers: igor, sdong, ljin Reviewed By: ljin Subscribers: dhruba, leveldb, march, lovro Differential Revision: https://reviews.facebook.net/D24063 10 November 2014, 23:44:20 UTC
d88568c Igor Canadi 10 November 2014, 22:41:51 UTC Move -Wnon-virtual-dtor to c++ flags 10 November 2014, 22:41:51 UTC
c7ee9c3 Igor Canadi 10 November 2014, 22:39:38 UTC Fix -Wnon-virtual-dtor errors Summary: This breaks mongo+rocks build https://mci.10gen.com/task_log_raw/rocksdb_ubuntu1404_rocksdb_c6e8e3d868660dc66b3bbd438cdc135df6356c5a_14_11_10_21_36_10_compile_ubuntu1404_rocksdb/0?type=T Test Plan: m check + -Wnon-virtual-dtor Reviewers: sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28653 10 November 2014, 22:39:38 UTC
7462521 Igor Canadi 10 November 2014, 21:12:15 UTC Merge pull request #384 from msb-at-yahoo/compaction-filter-2-empty-changed-values CompactionFilterV2: eliminate an often unnecessary allocation. 10 November 2014, 21:12:15 UTC
dd726a5 sdong 10 November 2014, 19:01:28 UTC Bump Version Number to 3.8 Summary: As tittle. Test Plan: Not needed. Reviewers: ljin, igor, yhchiang, rven, fpi Reviewed By: fpi Subscribers: leveldb, fpi, dhruba Differential Revision: https://reviews.facebook.net/D28629 10 November 2014, 20:10:56 UTC
4a3bd2b Igor Canadi 10 November 2014, 19:57:58 UTC Optimize usage of Status in CompactionJob Summary: Based on @ljin feedback Test Plan: compiles Reviewers: ljin, yhchiang, sdong Reviewed By: sdong Subscribers: ljin, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28515 10 November 2014, 19:57:58 UTC
bcdb967 Igor Canadi 09 November 2014, 18:01:50 UTC Fix build 09 November 2014, 18:01:50 UTC
d904fbb Adam Retter 05 November 2014, 18:56:45 UTC Addresed comments from code review https://reviews.facebook.net/D27567 09 November 2014, 16:10:11 UTC
eeb9cf6 Adam Retter 05 November 2014, 16:51:38 UTC Test for WriteBatchHandler 09 November 2014, 16:10:11 UTC
8fb4751 Adam Retter 23 October 2014, 15:19:38 UTC Iterator support for Write Batches 09 November 2014, 16:10:11 UTC
00211f9 Igor Canadi 08 November 2014, 21:01:31 UTC Fix SIGSEGV in db_stresS 08 November 2014, 21:01:31 UTC
a4a2bfd Igor Canadi 08 November 2014, 20:52:30 UTC Merge pull request #391 from Liuchang0812/fixmake remove unused target 08 November 2014, 20:52:30 UTC
8560590 Igor Canadi 08 November 2014, 20:52:18 UTC Merge pull request #389 from Liuchang0812/master fix "make static_lib" error 08 November 2014, 20:52:18 UTC
01a7706 liuchang 08 November 2014, 19:51:40 UTC remove unused target 08 November 2014, 19:51:40 UTC
dc34104 liuchang 08 November 2014, 19:35:36 UTC Merge branch 'fix-example' 08 November 2014, 19:35:36 UTC
e762053 liuchang 08 November 2014, 19:35:10 UTC fix make static_lib error 08 November 2014, 19:35:10 UTC
543df15 Federico Piccinini 08 November 2014, 01:23:58 UTC Expose sst_dump functionality as library call. Summary: Refactor sst_dump to follow the same structure as ldb. Introduce a SSTDump interface. Test Plan: built sst_dump and tried it manually. Reviewers: sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28485 08 November 2014, 01:23:58 UTC
e3d3567 Igor Canadi 07 November 2014, 23:44:12 UTC Get rid of mutex in CompactionJob's state Summary: Based on @sdong's feedback in the diff, we shouldn't keep db_mutex in CompactionJob's state. This diff removes db_mutex from CompactionJob state, by making next_file_number_ atomic. That way we only need to pass the lock to InstallCompactionResults() because of LogAndApply() Test Plan: make check Reviewers: ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: sdong, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28491 07 November 2014, 23:44:12 UTC
344edbb Yueh-Hsuan Chiang 07 November 2014, 23:22:10 UTC Fixed the shadowing in db/compaction.cc and include/rocksdb/db.h Summary: Fixed the shadowing in db/compaction.cc and include/rocksdb/db.h Test Plan: make 07 November 2014, 23:22:10 UTC
b8b3903 Yueh-Hsuan Chiang 07 November 2014, 23:13:01 UTC Fixed compile error in db/db_impl.cc Summary: Fixed compile error in db/db_impl.cc Test Plan: make 07 November 2014, 23:13:01 UTC
b622ba5 Yueh-Hsuan Chiang 07 November 2014, 23:11:36 UTC Fixed compile error in db/flush_job.cc Summary: Fixed compile error in db/flush_job.cc Test Plan: make 07 November 2014, 23:11:36 UTC
642ac9d Yueh-Hsuan Chiang 07 November 2014, 23:08:12 UTC Fixed compile error in db/compaction.cc and db/compaction_picker.cc Summary: Fixed compile error in db/compaction.cc and db/compaction_picker.cc Test Plan: make 07 November 2014, 23:08:12 UTC
68effa0 Igor Canadi 07 November 2014, 23:04:30 UTC Fix -Wshadow for tools Summary: Previously I made `make check` work with -Wshadow, but there are some tools that are not compiled using `make check`. Test Plan: make all Reviewers: yhchiang, rven, ljin, sdong Reviewed By: ljin, sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28497 07 November 2014, 23:04:30 UTC
8447861 Yueh-Hsuan Chiang 07 November 2014, 22:57:51 UTC Fixed -WShadow errors in db/db_test.cc and include/rocksdb/metadata.h Summary: Fixed -WShadow errors in db/db_test.cc and include/rocksdb/metadata.h Test Plan: make 07 November 2014, 22:57:51 UTC
28c82ff Yueh-Hsuan Chiang 07 November 2014, 22:45:18 UTC CompactFiles, EventListener and GetDatabaseMetaData Summary: This diff adds three sets of APIs to RocksDB. = GetColumnFamilyMetaData = * This APIs allow users to obtain the current state of a RocksDB instance on one column family. * See GetColumnFamilyMetaData in include/rocksdb/db.h = EventListener = * A virtual class that allows users to implement a set of call-back functions which will be called when specific events of a RocksDB instance happens. * To register EventListener, simply insert an EventListener to ColumnFamilyOptions::listeners = CompactFiles = * CompactFiles API inputs a set of file numbers and an output level, and RocksDB will try to compact those files into the specified level. = Example = * Example code can be found in example/compact_files_example.cc, which implements a simple external compactor using EventListener, GetColumnFamilyMetaData, and CompactFiles API. Test Plan: listener_test compactor_test example/compact_files_example export ROCKSDB_TESTS=CompactFiles db_test export ROCKSDB_TESTS=MetaData db_test Reviewers: ljin, igor, rven, sdong Reviewed By: sdong Subscribers: MarkCallaghan, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D24705 07 November 2014, 22:45:18 UTC
5c93090 Igor Canadi 07 November 2014, 20:57:08 UTC Turn on -Wshadow Summary: Only one more try, I promise. I talked to Jim and he mentioned that if we include our system includes with -isystem rather than with -I, that signals to the compile that those are system includes and thus no warnings are issued. So I turned our glibc includes into system includes and now we no longer get the warning from there, making us shadow-warning-free! Test Plan: compiles with both clang and gcc Reviewers: sdong, yhchiang, rven, ljin Reviewed By: ljin Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28479 07 November 2014, 20:57:08 UTC
31342c4 Igor Canadi 07 November 2014, 20:41:05 UTC Fix implicit compare 07 November 2014, 20:41:05 UTC
a0f887c Igor Canadi 07 November 2014, 20:07:43 UTC Fix compile 07 November 2014, 20:07:43 UTC
53af5d8 Igor Canadi 07 November 2014, 19:50:34 UTC Redesign pending_outputs_ Summary: Here's a prototype of redesigning pending_outputs_. This way, we don't have to expose pending_outputs_ to other classes (CompactionJob, FlushJob, MemtableList). DBImpl takes care of it. Still have to write some comments, but should be good enough to start the discussion. Test Plan: make check, will also run stress test Reviewers: ljin, sdong, rven, yhchiang Reviewed By: yhchiang Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28353 07 November 2014, 19:50:34 UTC
ec101cd Jonah Cohen 07 November 2014, 01:28:49 UTC Correctly test both compaction styles in CompactionDeletionTriggerReopen Summary: CompactionDeletionTriggerReopen wasn't actually testing universal compaction. Test Plan: db_test Reviewers: sdong, igor Reviewed By: igor Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D28443 07 November 2014, 01:28:49 UTC
8d87467 Yueh-Hsuan Chiang 07 November 2014, 01:07:52 UTC Make PartialCompactionFailure Test more robust again. Summary: Make PartialCompactionFailure Test more robust again by blocking background compaction until we simulate the file creation error. Test Plan: export ROCKSDB_TESTS=PartialCompactionFailure ./db_test Reviewers: sdong, igor, ljin Reviewed By: ljin Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28431 07 November 2014, 01:07:52 UTC
64d302d Lei Jin 07 November 2014, 00:07:07 UTC make DropWritesFlush deterministic Summary: TEST_WaitForFlush should wait until it sees error when parameter is set to true so we don't need to loop and timeout Test Plan: ROCKSDB_TESTS=DropWritesFlush ./db_test Reviewers: sdong, igor Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28419 07 November 2014, 00:07:07 UTC
cd5c092 Igor Canadi 06 November 2014, 22:42:04 UTC Merge pull request #387 from fyrz/RocksJava-WShadow-Fix [RocksJava] -WShadow improvements 06 November 2014, 22:42:04 UTC
c4bf07c fyrz 06 November 2014, 22:12:36 UTC [RocksJava] -WShadow improvements Minor corrections to resolve -WShadow build problems with RocksJava code. 06 November 2014, 22:14:48 UTC
e526b71 Yueh-Hsuan Chiang 06 November 2014, 21:53:02 UTC Make PartialCompactionFailure Test more robust. Summary: Make PartialCompactionFailure Test more robust. Test Plan: export ROCKSDB_TESTS=PartialCompactionFailure ./db_test Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28425 06 November 2014, 21:53:02 UTC
0c2be0d Igor Canadi 06 November 2014, 21:29:17 UTC Turn on -Wshadow for travis 06 November 2014, 21:29:17 UTC
5fd33d2 Igor Canadi 06 November 2014, 20:01:02 UTC Turn off -Wshadow Summary: So glibc is not -Wshadow-safe, so we need to turn it off :( error: ‘int sigaction(int, const sigaction*, sigaction*)’ hides constructor for ‘struct sigaction’ The rest of the changes in this diff is that we include .h files under rocksdb namespace, which is a no-no. Test Plan: compiles now Reviewers: ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28413 06 November 2014, 20:01:02 UTC
9f20395 Igor Canadi 06 November 2014, 19:14:28 UTC Turn -Wshadow back on Summary: It turns out that -Wshadow has different rules for gcc than clang. Previous commit fixed clang. This commits fixes the rest of the warnings for gcc. Test Plan: compiles Reviewers: ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28131 06 November 2014, 19:14:28 UTC
c02338a Lei Jin 06 November 2014, 19:02:30 UTC update HISOTRY.md for new release Summary: as title Test Plan: n/a 06 November 2014, 19:02:30 UTC
367a3f9 sdong 06 November 2014, 18:14:47 UTC Improve DBTest.GroupCommitTest: artificially slowdown log writing to trigger group commit Summary: In order to avoid random failure of DBTest.GroupCommitTest, artificially sleep 100 microseconds in each log writing. Test Plan: Run the test in a machine where valgrind version of the test always fails multiple times and see it always succeed. Reviewers: igor, yhchiang, rven, ljin Reviewed By: ljin Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28401 06 November 2014, 18:48:06 UTC
b52b144 Igor Canadi 06 November 2014, 18:46:20 UTC Merge pull request #386 from EugenePig/java8 suppress JDK8 errors for #385 06 November 2014, 18:46:20 UTC
ac95ae1 sdong 06 November 2014, 02:07:22 UTC Make sure WAL is synced for DB::Write() if write batch is empty Summary: This patch makes it a contract that if an empty write batch is passed to DB::Write() and WriteOptions.sync = true, fsync is called to WAL. Test Plan: A new unit test Reviewers: ljin, rven, yhchiang, igor Reviewed By: igor Subscribers: dhruba, MarkCallaghan, leveldb Differential Revision: https://reviews.facebook.net/D28365 06 November 2014, 17:48:19 UTC
59d5497 Eugene Su 06 November 2014, 08:25:53 UTC suppress JDK8 errors for #385 06 November 2014, 08:25:53 UTC
ea18b94 Shi Feng 29 October 2014, 21:24:34 UTC Add db_bench option --report_file_operations Summary: Add db_bench option --report_file_operations Test Plan: ./db_bench --report_file_operations Observe outputs on # of file operations Reviewers: ljin, MarkCallaghan, sdong Reviewed By: sdong Subscribers: yhchiang, rven, igor, dhruba Differential Revision: https://reviews.facebook.net/D27945 06 November 2014, 02:40:18 UTC
2ea1219 sdong 01 November 2014, 01:36:07 UTC Fix RecordIn and RecordDrop stats Summary: 1. fix possible overflow of the two stats by using uint64_t 2. use a similar source of data to calculate RecordDrop. Previous one is not correct. Test Plan: See outputs of db_bench settings, and the results look reasonable Reviewers: MarkCallaghan, ljin, igor Reviewed By: igor Subscribers: rven, leveldb, yhchiang, dhruba Differential Revision: https://reviews.facebook.net/D28155 05 November 2014, 19:03:34 UTC
e4211d1 Yueh-Hsuan Chiang 05 November 2014, 08:12:20 UTC Apply InfoLogLevel to the logs in util/env_hdfs.cc Summary: Apply InfoLogLevel to the logs in util/env_hdfs.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D28011 05 November 2014, 08:12:20 UTC
76f6c7c maurice barnum 05 November 2014, 05:31:11 UTC CompactionFilterV2: eliminate an often unnecessary allocation. If a compaction filter implementation is simply filtering values, then allocating the "changed values" bitmap is an extra memory allocation that adds no value. Additionally, the compaction implementation has to do marginally more work to calculate the offset into the bitmap (vector<bool> specialization) for each record the filter did not mark for deletion. Explicitly handle the case where compact_->value_changed_buf_ is empty. 05 November 2014, 05:31:11 UTC
29a9161 Lei Jin 05 November 2014, 00:23:45 UTC Note dynamic options in options.h Summary: as title Test Plan: n/a Reviewers: igor, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28287 05 November 2014, 00:23:45 UTC
fd24ae9 Lei Jin 05 November 2014, 00:23:05 UTC SetOptions() to return status and also add it to StackableDB Summary: as title Test Plan: ./db_test Reviewers: sdong, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28269 05 November 2014, 00:23:05 UTC
b126775 Lei Jin 04 November 2014, 23:58:14 UTC fix the asan check Summary: as title Test Plan: ran it Reviewers: yhchiang, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28311 04 November 2014, 23:58:14 UTC
83bf091 sdong 04 November 2014, 22:39:09 UTC Bump verison number to 3.7 Summary: As tittle Test Plan: N/A Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28299 04 November 2014, 22:52:02 UTC
da5daa0 sdong 04 November 2014, 19:33:57 UTC Replace some ASSERT_TRUE() asserts in DBTest.DynamicMemtableOptions and DynamicCompactionOptions with more specific ones Summary: Replace some ASSERT_TRUE() to ASSERT_GT() and ASSERT_LT() so that in case the assert is triggered, the value is printed out. Test Plan: Run the two tests Reviewers: ljin, rven, yhchiang, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28293 04 November 2014, 19:45:03 UTC
b0cda4a sdong 04 November 2014, 19:07:36 UTC DBTest.DynamicMemtableOptions to use single background compaction Summary: Now DBTest.DynamicMemtableOptions sets background compaction to be 4, without actually increasing thread pool size (even before the feature of automatic increasing it). To make sure the behavior stays the same after the automatic thread pool increasing, set it back to 1. Hopefully it can fix the occasional failure of the test. Test Plan: Run the test Reviewers: igor, ljin Reviewed By: ljin Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28281 04 November 2014, 19:14:12 UTC
8810850 Yueh-Hsuan Chiang 04 November 2014, 19:07:11 UTC Apply InfoLogLevel to the logs in db/compaction_job.cc Summary: Apply InfoLogLevel to the logs in db/compaction_job.cc Test Plan: db_test Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: leveldb, MarkCallaghan, dhruba Differential Revision: https://reviews.facebook.net/D28275 04 November 2014, 19:07:11 UTC
71783f6 Yueh-Hsuan Chiang 04 November 2014, 19:05:19 UTC Merge pull request #377 from fyrz/RocksJava-KeyMayExist [RocksJava] KeyMayExist w/o ColumnFamilies 04 November 2014, 19:05:19 UTC
614bbcb Yueh-Hsuan Chiang 04 November 2014, 18:51:59 UTC Merge pull request #374 from fyrz/RocksJava-DBOptions-Extension-3.6 [RocksJava] DBOptions extension 3.6 04 November 2014, 18:51:59 UTC
d8e1196 Yueh-Hsuan Chiang 04 November 2014, 18:34:33 UTC Apply InfoLogLevel to the logs in db/version_set.cc Summary: Apply InfoLogLevel to the logs in db/version_set.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27879 04 November 2014, 18:34:33 UTC
2a019f1 Yueh-Hsuan Chiang 04 November 2014, 18:34:18 UTC Apply InfoLogLevel to the logs in db/wal_manager.cc Summary: Apply InfoLogLevel to the logs in db/wal_manager.cc Test Plan: db_test Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28239 04 November 2014, 18:34:18 UTC
469d474 Yueh-Hsuan Chiang 04 November 2014, 18:28:08 UTC Apply InfoLogLevel to the logs in db/db_impl.cc Summary: Apply InfoLogLevel to the logs in db/db_impl.cc Test Plan: db_test db_bench Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: leveldb, MarkCallaghan, dhruba Differential Revision: https://reviews.facebook.net/D28233 04 November 2014, 18:28:08 UTC
ac6afaf sdong 04 November 2014, 01:45:55 UTC Enforce naming convention of getters in version_set.h Summary: Enforce the accessier naming convention in functions in version_set.h Test Plan: make all check Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28143 04 November 2014, 17:59:05 UTC
09899f0 sdong 03 November 2014, 22:11:33 UTC DB::Open() to automatically increase thread pool size if it is smaller than max number of parallel compactions or flushes Summary: With the patch, thread pool size will be automatically increased if DB's options ask for more parallelism of compactions or flushes. Too many users have been confused by the API. Change it to make it harder for users to make mistakes Test Plan: Add two unit tests to cover the function. Reviewers: yhchiang, rven, igor, MarkCallaghan, ljin Reviewed By: ljin Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27555 04 November 2014, 01:22:34 UTC
636e57b Igor Canadi 03 November 2014, 22:53:00 UTC Fix coverage script 03 November 2014, 22:53:00 UTC
30ca375 Igor Canadi 03 November 2014, 22:00:45 UTC Revamp our build tools Summary: This diff is revamping our build tools: 1) Use third-party2 instead of third-party 2) consolidate clang and gcc scripts together, lots of duplication there 3) remove hdfs libs, we never compile rocksdb with them clang compilation doesn't work yet. It doesn't work in master either. I plan to fix it soon, but I just spent 2 hours trying to make it work and failed. I'll ask experts. Test Plan: compiles with gcc Reviewers: ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28047 03 November 2014, 22:00:45 UTC
051c67f Igor Canadi 03 November 2014, 19:27:50 UTC Merge pull request #378 from baotiao/master add make clean in examples makefile 03 November 2014, 19:27:50 UTC
d0e7e49 Igor Canadi 03 November 2014, 19:27:13 UTC Merge pull request #379 from fyrz/RocksJavaBuildFix [RocksJava] Build fix after options refactoring 03 November 2014, 19:27:13 UTC
94e31ac fyrz 28 October 2014, 21:38:08 UTC [RocksJava] Extend Options with DBOptions implementation [RocksJava] Included DBOptionsTest and refactored OptionsTest Summary: Options refactoring - Split Part2 Test Plan: make rocksdbjava make jtest Reviewers: yhchiang, ankgup87 Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D28017 02 November 2014, 23:13:57 UTC
b060d30 fyrz 02 November 2014, 22:48:40 UTC [RocksJava] Build fix after options refactoring 02 November 2014, 22:48:40 UTC
back to top