Skip to main content

Browse the archive

https://github.com/halide/Halide
19 April 2024, 08:20:39 UTC
sort by:
Revision Author Date Message Commit Date
c84785d Dillon Sharlet 27 January 2021, 04:06:17 UTC Add lowering for bitwise and patterns. 27 January 2021, 04:06:17 UTC
6e3fb56 Steven Johnson 26 January 2021, 04:09:53 UTC FIx intermittent OSX Python crash (#5667) * FIx intermittent OSX Python crash The OSX buildbot has been crashing intermittently on some python tests; debugging showed that in some situations, Introspection's calls to `backtrace()` include bogus addresses (eg 0x08), which cause segfaults when you try to inspect memory near them. The reasons for this aren't entirely clear -- for instance, it only seems to repeat reliably when using the Makefile rather than CMake, and only when doing an 'out-of-tree' build. Rather than try to run this to ground further, this PR just checks for address fields that seem obviously unreasonable (first 256 bytes of address space) and ignore them. * Add -fno-omit-frame-pointer, update sanity check * Update Introspection.cpp 26 January 2021, 04:09:53 UTC
d4c27ca Dillon Sharlet 25 January 2021, 21:51:57 UTC Lower saturating arithmetic without widening (#5662) * Lower saturating arithmetic without widening, and handle it in lower_intrinsic. * clang-format, fix saturating sub * cout -> cerr * trigger buildbots Co-authored-by: Alex Reinking <alex.reinking@gmail.com> Co-authored-by: Steven Johnson <srj@google.com> 25 January 2021, 21:51:57 UTC
38be3e3 aankit-ca 23 January 2021, 01:06:20 UTC Add rounding shift right instructions (#5664) Co-authored-by: Ankit Aggarwal <aankit@quicinc.com> 23 January 2021, 01:06:20 UTC
7cff481 Dillon Sharlet 22 January 2021, 21:18:47 UTC Fix VSX min/max intrinsics. Fixes #5661. (#5663) 22 January 2021, 21:18:47 UTC
6b398a3 Andrew Adams 22 January 2021, 18:23:48 UTC Better codegen for switch-statement-like if-else chains (#5595) Better codegen for switch-statement-like if-else chains And added a test that demonstrates writing a little interpreter in Halide and scheduling it. 22 January 2021, 18:23:48 UTC
8c57a1a Steven Johnson 21 January 2021, 22:07:20 UTC Use linker tools on OSX & Linux to limit exports (#4651) (#5659) * Use linker scripts on OSX & Linux to limit exports * Write script to detect appropriate linker flags. Co-authored-by: Alex Reinking <alex.reinking@gmail.com> 21 January 2021, 22:07:20 UTC
be7a6a3 Alexander Root 21 January 2021, 21:23:43 UTC is_positive_const and is_negative_const broken for (some) casts (#5615) * let signed_const checkers fail for non-widening integral casts Co-authored-by: Steven Johnson <srj@google.com> 21 January 2021, 21:23:43 UTC
0ca0415 Steven Johnson 21 January 2021, 01:59:10 UTC Remove all deprecated methods for Halide 12 (#5656) * Remove all deprecated methods for Halide 12 These were all marked as deprecated in Halide 11 (and probably Halide 10 too); let's go ahead and remove them in Halide 12. * Remove function bodies too 21 January 2021, 01:59:10 UTC
a785b53 Steven Johnson 20 January 2021, 02:25:51 UTC Add Lambda.cpp (#5651) Functions/methods that are part of the Halide public API should (generally) not be inline, to ensure the function instantiation is always in libHalide. 20 January 2021, 02:25:51 UTC
7713b3a Steven Johnson 20 January 2021, 02:25:27 UTC Add Python & PyBind version checking to PyStubImpl.cpp (#5653) It's built separately from the rest of the Python bindings and could get out of sync separately. 20 January 2021, 02:25:27 UTC
57083e4 Andrew Adams 19 January 2021, 17:44:27 UTC Fix cuda warp shuffle issue for narrow types (#5624) * Fix cuda warp shuffle issue for narrow types In the case where no shuffle was necessary, we were upcasting the type to 32-bits needlessly and causing chaos. 19 January 2021, 17:44:27 UTC
8a12c43 Alex Reinking 18 January 2021, 18:53:20 UTC Upgrade pybind11 to 2.6.x (#5644) * Use pybind11 2.6.0, which fixes Python-finding bugs. * Update Generator.cpp * Update Generator.cpp * Update PyHalide.cpp * 2.6.0 -> 2.6.1 Co-authored-by: Steven Johnson <srj@google.com> 18 January 2021, 18:53:20 UTC
42c5182 Alex Reinking 15 January 2021, 19:34:45 UTC Shrink tile size to fit in Mac Mini GPU memory. (#5647) * Shrink tile size to fit in Mac Mini GPU memory. * Fix comment per Shoaib's correction. 15 January 2021, 19:34:45 UTC
bb1ca3c Steven Johnson 14 January 2021, 22:57:28 UTC correctness_vector_math: skip hypot() test for LLVM10 (#5643) 14 January 2021, 22:57:28 UTC
722b93e Steven Johnson 13 January 2021, 20:27:12 UTC Add 11.1 as an acceptable LLVM version (#5640) * Add 11.1 as an acceptable LLVM version Apparently 11.1 was released but our Makefile only allows for 11.0. * Update Makefile 13 January 2021, 20:27:12 UTC
61ca4d2 Steven Johnson 13 January 2021, 20:12:26 UTC Simplify CodeGen_OpenGLCompute_C (#5636) * Simplify CodeGen_OpenGLCompute_C Combines CodeGen_GLSLBase and CodeGen_OpenGLCompute_C into one class, removing unnecessary stuff from the OpenGL support code. 13 January 2021, 20:12:26 UTC
0dfdc0d Alexander Root 13 January 2021, 08:11:56 UTC fix typo on assert in lerp() (#5638) 13 January 2021, 08:11:56 UTC
6620563 Steven Johnson 13 January 2021, 01:06:52 UTC Add TARGET_OPENGLCOMPUTE (#5637) Inadvertently removed code for properly enabling/disabling OGLC in #5626, this restores it properly 13 January 2021, 01:06:52 UTC
4ed4db8 Steven Johnson 12 January 2021, 23:09:16 UTC Remove CodeGen_OpenGL_Dev (#5635) 5626 removed OpenGL support, but didn't remove this no-longer-needed class; removed it here. Moved CodeGen_GLSLBase into CodGen_OpenGLCompute_Dev.cpp (which is now the only subclass), but didn't yet attempt to consolidate them into a single class. 12 January 2021, 23:09:16 UTC
3defb66 Dillon Sharlet 12 January 2021, 23:02:59 UTC Pattern match intrinsics in a target independent lowering pass (#5531) * Simplify intrinsics of broadcasts to broadcasts of intrinsics. * Add pattern matching of intrinsics lowering pass. * Fix broadcast elementwise simplifications for nested broadcasts. * More target independent pattern matching. * Progress on pattern matching for ARM and Hexagon. * broadcasted -> broadcast. * Broken pattern matching. * Fix broken build. * Match without patterns. * Try to match saturating_add. * Pattern matching working for some intrinsics. * x86 simd_op_check passing. * Most x86 and Hexagon patterns working. * Rename subtract -> sub, multiply -> mul. * Add widening_left_shift. * Remove bad simplification. * Fix some missed pattern issues. * Hexagon patterns mostly working. * Fix pmaddwd patterns * Start on ARM intrinsics. * Use shift intrinsics. * Revert formatting of Hexagon intrinsic table * Revert one extra find and replace. * Add table of instructions for ARM. * Add more patterns for rounding_halving_add. * Remove unused unsigned widening subtracts * Add intrinsics test * Remove bogus patterns. * Match lanes in shifts. * Progress on multiply-add Hexagon pattern matching. * Fix multiply-subtracts * Enable constant folding of broadcasted constants. * Fix some widening patterns * Fix double widening lossless casts * Use widen/narrow helpers * All Hexagon and x86 patterns working * Fix return type of widening subtracts. * Fix rounding shift right patterns * WIP simd op check * Add CodeGen_LLVM::Intrinsic and related helpers. * Use call_elementwise_intrinsic for more patterns. * Clean up intrinsics a bit. * Use call_elementwise_intrinsic for x86. * More clean-up and comments. * Add comment * Use call_elementwise_intrinsic for pmaddwd * Remove stray comment. * Move a few more things to overloaded intrinsics * Remove unused runtime functions. * Fix some corner case target flags * ssse... * Run clang-format * Replace introspection test. * Remove x86_avx512 initmod * clang-tidy * Remove x86_avx512 from makefile too * Revert simd_op_check * clang-format off on tables * Fix merge conflicts * Add abs and absd support * Pattern match some absd patterns * Clean up dead logic. * Remove duplicate merge content. * Update Generator.cpp * Update Generator.cpp * Also check one sided saturating add. * Fix requirement for abs_i8x32 * Fix some saturating add/sub patterns. * More ways to express rounding halving add/sub * Add widening_shift_right * Use lower_intrinsic to handle unknown calls. * Use pattern match results. * Fix incorrect patterns * All(?!) ARM shifts working * Remove unused declarations * Don't substitute all lets * Reduce code duplication in tables * Simplify negated shifts. * Handle possible pmaddwd overload resolution failures. * Fix some overflow cases. * Small cleanups. * Review fixes * Fix some broken patterns * Don't hardcode 4 * PatternMatchIntrinsics -> FindIntrinsics * Re-enable uhsub patterns * Add useful simplication to lower_int_uint_mod * Lower unknown intrinsics. * Also check for bitwise_and * Simplify bitwise_and(x, -1). * Add back some necessary simplifications. * Fix incorrect narrowing of widening add/sub. * Fix boneheaded add/sub swap. * Skip finding intrinsics for scalar types. * Add accidentally removed break. * Improve comments. * clang-format, clang-tidy, and other fixes * Try to fix compiler-specific errors, more clang-tidy. * More clang-tidy fixes. * Tweak comments on rounding_shift_left/right. * Move default mulhi_shr and sorted_avg lowering to lower_intrinsics. * Argh clang-format. * Better coverage of shift correctness. * Fix unknown intrinsic visitor. * Add comments to rounding shifts. * Add TODO for C++14 * Use pattern matching for vector reduce. * Simplify pattern matching a little. * Remove stray newline in vectorreduce ops. * Add HL_SIMD_OP_CHECK_FILTER env variable * Fix and refactor vector reduce codegen * clang-format * pmulhrsw doesn't exist until sse3! * Fix incorrect lack of fall-through * Don't lower int/uint division in FindIntrinsics. * Fix missing check of op type. * Don't handle Mod at all. * Programmatically generate split argument intrinsic wrappers. * clang-format * More clang-format * Clean up IRMatch helpers. * Small cleanups/review comments. * Fix boneheaded bug. * Fix addp * Fix float addp * Fix incorrect rounding shift saturation patterns. * Update Hexagon vector reductions. * clang-format * Small cleanups. * clang-tidy * Fix sign of shifts on arm32 * Fix LLVM10 workaround * Work around opaque LLVM failures. * Pattern match dp4a/dp2a * clang-format * Don't try to use shift_right_narrow patterns on invalid shifts. * Don't rely on mul visitor to produce shifts. * Fix arm32 * Address some review comments. * Speculatively fix non-locally-reproducing dot product failures * Fix CUDA dot products. * clang-format * Remove debugging code. * clang-tidy * Put needed check back. * Bring back some tests/patterns. * Renable saturating_add pattern. * Bring back a few more tests. * Fix mixed sign swapped ops case. * Better implementation of handling mixed signs. * Fix some issues. * Avoid ADL fights with common user helper functions. * Don't try to find intrinsics for bool operations. * Remove redundant patterns. * Bring back div/mod lowering. * Update PowerPC to use pattern matched intrinsics. Co-authored-by: Steven Johnson <srj@google.com> 12 January 2021, 23:02:59 UTC
27f55dd Steven Johnson 12 January 2021, 17:55:36 UTC Remove OpenGL support (part 1) (#5626) * Remove OpenGL support (part 1) Fixes #5475 This removes the OpenGL backend (but *not* the OpenGLCompute backend) from public use: - Remove Target::OpenGL - remove DeviceAPI::GLSL - remove Func::glsl() and Func::shader() - remove all OpenGL-specific apps and tests - remove HalideRuntimeOpenGL.h - remove some internal code that is OpenGL-only Note that there is still internal code that needs trimming; since the OpenGLCompute backend uses some of the same code, and some of the same build deps, and some of the same runtime shared-library loading, I tried to err on the side of leaving code/buildrules/etc in place for now, with the plan to clean that up in subsequent PRs. Note also that feature Target::EGL is still present, as I believe it is still useful in conjunction with OpenGLCompute. 12 January 2021, 17:55:36 UTC
9b99acb Dillon Sharlet 11 January 2021, 21:25:36 UTC Clean up includes (#5584) * Remove unused wildcard/type info. * Use std::unique_ptr to avoid sketchy lifetime management. * Clean up includes * Pull some changes from small-cleanups3 * clang-format * Add missing include. * Add missing include. * clang-format. * Fix function type * clang-format * Add missing include Co-authored-by: Steven Johnson <srj@google.com> 11 January 2021, 21:25:36 UTC
cc03c9c Andrew Adams 09 January 2021, 00:28:07 UTC Prototype of multiple scattering update definitions (#5553) Add "gather" and "scatter" intrinsics, which let you write update definitions which store multiple values at once to different computed locations. Useful for doing things like swapping or permuting elements in-place. See comments in IROperator.h for more details. 09 January 2021, 00:28:07 UTC
9c59d94 Alex Reinking 09 January 2021, 00:22:40 UTC Set version to 12.0.0. Fixes #5259 (#5289) 09 January 2021, 00:22:40 UTC
2e5f1e0 xndcn 09 January 2021, 00:06:05 UTC Fix issues in OpenGL backend (#5545) Co-authored-by: Alex Reinking <alex_reinking@berkeley.edu> Co-authored-by: Steven Johnson <srj@google.com> Co-authored-by: Alex Reinking <alex.reinking@gmail.com> 09 January 2021, 00:06:05 UTC
392b53e Steven Johnson 08 January 2021, 23:21:24 UTC Check error results from all egl calls (#5619) * Check error results from all egl calls We were ignoring the result from a couple of calls. * Update opengl_egl_context.cpp * Update Generator.cpp * Update Generator.cpp 08 January 2021, 23:21:24 UTC
2b3aaa8 xndcn 08 January 2021, 19:46:56 UTC Add max threads checking for Metal (#5588) * Add max threads checking for Metal Originally, this checking will be asserted by Metal API Validation in Xcode, otherwise the program will crash or output wrong results. * Disable the max threads checking for Metal in non-debug runtime * Disable error/metal_threads_too_large test for non-OSX target 08 January 2021, 19:46:56 UTC
081f472 xndcn 07 January 2021, 22:49:08 UTC Add CLDoubles feature check for OpenCL double type (#5610) Similar to CLHalf feature check for half type. 07 January 2021, 22:49:08 UTC
46fc56a Steven Johnson 07 January 2021, 18:29:38 UTC Don't allow CUDACapability80 on LLVM10 (#5617) LLVM10 can't handle that version of Cuda; we never noticed till now because we didn't have a buildbot with a GPU that could handle it. Modify the sniffers to cap capability at 75 for LLVM10 builds, and fail with user errors if that capability is explicitly requested. 07 January 2021, 18:29:38 UTC
f38801e Dillon Sharlet 06 January 2021, 17:52:38 UTC Use std::unique_ptr to manage CodeGen classes (#5583) * Remove unused wildcard/type info. * Use std::unique_ptr to avoid sketchy lifetime management. * Pull some changes from small-cleanups3 * Use auto for some loops. * clang-tidy 06 January 2021, 17:52:38 UTC
8063879 prdelgado 05 January 2021, 21:50:53 UTC replaced indentation in line 20 with spaces to show proper error message (#5580) * replaced indentation in line 20 with spaces to show proper error message * added error message detail with alternative solution based on PR feedback 05 January 2021, 21:50:53 UTC
8383cc9 Andrew Adams 28 December 2020, 23:49:45 UTC Delete lane extraction code in vectorization (#5596) 28 December 2020, 23:49:45 UTC
890a519 pkubaj 23 December 2020, 01:15:44 UTC Fix build on FreeBSD/powerpc64 (#5572) * Fix build on FreeBSD/powerpc64 FreeBSD doesn't use getauxval, but elf_aux_info. * Make the conditional only work Linux and FreeBSD * Make the conditional only for FreeBSD and Linux 23 December 2020, 01:15:44 UTC
8a0f4a1 Dillon Sharlet 22 December 2020, 01:54:36 UTC Fix sketchy shadowing that breaks on some compilers. Fixes #5581 (#5587) * Fix sketchy shadowing that breaks on some compilers. Fixes #5581 * Fix another sketchy shadowing. 22 December 2020, 01:54:36 UTC
b22598c Dillon Sharlet 21 December 2020, 22:56:00 UTC Remove unused wildcard/type info. (#5582) 21 December 2020, 22:56:00 UTC
5ac8808 Dillon Sharlet 21 December 2020, 21:54:37 UTC Fix several bugs on Hexagon and some cleanup (#5570) * Fix several bugs on Hexagon. * clang-format actually found a bug 21 December 2020, 21:54:37 UTC
1dbcf19 Steven Johnson 21 December 2020, 17:08:20 UTC Decouple wasm's +bulk-memory from wasm_threads (#5574) * Decouple wasm's +bulk-memory from threads When `wasm_threads` was added, `+bulk-memory` codegen was enabled in conjunction with this feature, due to some inscrutable error which apparently didn't get recorded. From inspection of the spec for bulk-memory, and experimentation with the most recent version of Emscripten (2.0.10), I can't find any reason that this actually needs to be enabled, so I've moved it into its own new feature flag. Also: drive-by fix in Target to format the tables in `get_runtime_compatible_target()` better, and to remove some wasm-related entries from the 'must match' table that didn't actually need to match. * Create .gitignore 21 December 2020, 17:08:20 UTC
ef45c87 Steven Johnson 19 December 2020, 00:45:34 UTC Fix for trunk LLVM (#5576) 19 December 2020, 00:45:34 UTC
83b040d Zalman Stern 17 December 2020, 21:40:16 UTC Add a feature to name cached memoizations and to evict them by name. (#5510) This PR adds an optional ```EvictionKey``` parameter to the ```memoize``` scheduling option. EvictionKeys are user provided labels of up to 64-bits that can be used to request that labeled items in the cache be removed to free up space. Co-authored-by: Steven Johnson <srj@google.com> 17 December 2020, 21:40:16 UTC
590b253 Marcos Slomp 17 December 2020, 19:22:09 UTC D3D12: refactoring of kernel argument constant buffer packing (#5569) * initial setup for Direct3D 12 support for Windows-on-ARM * fixing runtime modules for Windows on ARM 64 * typo * wrapping windows_clock for Windows on ARM support * temporarily disabling windows_clock_[x86/arm] * wip * Set -fshort-wchar on generic Windows runtime target. * removing windows_clock specializations * replacing accidental tabs * addressing code review comments * Hoist fpic in CMakeFile. Mirror CMake changes to Makefile. * Add explanatory comment to Makefile * Add arm64-windows and -windows-d3d12compute targets to correctness_cross_compilation * fixed kernel parameter packing * Run clang-format * handling Bool -- UInt(1), and Int(1) as well just in case * Add previously-failing D3D12 test * Add new test to CMake Co-authored-by: Marcos Slomp <slomp@adobe.com> Co-authored-by: Shoaib Kamil <kamil@adobe.com> Co-authored-by: Shoaib Kamil <shoaibkamil@gmail.com> Co-authored-by: Steven Johnson <srj@google.com> 17 December 2020, 19:22:09 UTC
7fd3a7b Marcos Slomp 16 December 2020, 23:23:50 UTC Windows on ARM64 support (CPU, and also GPU through D3D12) (#5544) * initial setup for Direct3D 12 support for Windows-on-ARM * fixing runtime modules for Windows on ARM 64 * typo * wrapping windows_clock for Windows on ARM support * temporarily disabling windows_clock_[x86/arm] * wip * Set -fshort-wchar on generic Windows runtime target. * removing windows_clock specializations * replacing accidental tabs * addressing code review comments * Hoist fpic in CMakeFile. Mirror CMake changes to Makefile. * Add explanatory comment to Makefile * Add arm64-windows and -windows-d3d12compute targets to correctness_cross_compilation Co-authored-by: Marcos Slomp <slomp@adobe.com> Co-authored-by: Shoaib Kamil <kamil@adobe.com> Co-authored-by: Shoaib Kamil <shoaibkamil@gmail.com> 16 December 2020, 23:23:50 UTC
10a01dd Dillon Sharlet 16 December 2020, 23:08:32 UTC Move CodeGen_Hexagon to internal linkage and don't include it without WITH_HEXAGON (#5567) * Move CodeGen_Hexagon to internal linkage. * Move using out of the #ifdef * clang-tidy 16 December 2020, 23:08:32 UTC
0cfa6db Steven Johnson 16 December 2020, 18:19:52 UTC Fix minor wasm issues (#5566) * Fix minor wasm issues - If wasm_threads is in the target string, be sure to launch the external shell with --experimental-wasm-threads. - All the test/performance tests should detect wasm and explicitly skip * Disable noisy warning in WABT 16 December 2020, 18:19:52 UTC
34d35a3 Dillon Sharlet 16 December 2020, 18:18:36 UTC Add special case for printing broadcast shuffles. (#5565) 16 December 2020, 18:18:36 UTC
94da4f6 cimes-isi 15 December 2020, 22:18:36 UTC autoscheduler: prepend, don't override LD_LIBRARY_PATH in adams2019 test (#5563) 15 December 2020, 22:18:36 UTC
fef82c2 cimes-isi 15 December 2020, 17:57:59 UTC cmake: detect ppc64le arch (#5558) 15 December 2020, 17:57:59 UTC
a0bbf43 Steven Johnson 15 December 2020, 17:57:33 UTC Fix fragile Makefile for apps/onnx (#5540) The protoc usage happened to work when building in the app folder but often failed when building from the toplevel Makefile. Also, drive-by silencing of noise from curl, and drive-by fix of "redundant copy" warning in onnx_converter.cc. 15 December 2020, 17:57:33 UTC
ee2e5df Steven Johnson 15 December 2020, 17:57:00 UTC Upgrade WABT version to 1.0.20 (#5557) 15 December 2020, 17:57:00 UTC
d37b995 Alex Reinking 14 December 2020, 23:04:36 UTC Better document how LLVM_DIR works. (#5560) 14 December 2020, 23:04:36 UTC
9fea59f aankit-ca 14 December 2020, 17:01:27 UTC Bug fix for lossless_cast with minor additions (#5459) * Bug fix for lossless_cast with minor additions The bug can seen for types where lossless_cast type can represent cast->value.type() but not cast->type. For eg: lossless_cast(UInt(16), cast(Int(8), Variable::make(UInt(16), e))) returns (uint16)e which is incorrect. The patch also adds lossless_cast of Mod and Ramp expressions. * Handle Mod for negative numbers in lossless_cast. * Add lossless_cast test for VectorReduce. * Rename check to check_lossless_cast. * clang-format complains * Remove Ramp and Mod from lossless_cast. * Minor changes * Update test/correctness/CMakeLists.txt Co-authored-by: Ankit Aggarwal <aankit@quicinc.com> 14 December 2020, 17:01:27 UTC
ed8f7c2 Dillon Sharlet 14 December 2020, 04:46:38 UTC Hide inaccessible symbols in internal linkage (#5548) * Hide inaccessible symbols in internal linkage. * clang-format * Remove redundant static. 14 December 2020, 04:46:38 UTC
f9153e8 Steven Johnson 13 December 2020, 22:19:38 UTC Mark Target::OpenGL (etc) as deprecated (#5475) (#5551) 13 December 2020, 22:19:38 UTC
4fa78b6 Alexander Root 13 December 2020, 18:34:17 UTC change StrongestExprNodeType for rewriter (#5554) 13 December 2020, 18:34:17 UTC
a0ddabe Volodymyr Kysenko 12 December 2020, 00:16:35 UTC Remove <iostream> from the code generated by CodeGen_C (#5547) 12 December 2020, 00:16:35 UTC
968f6b3 aankit-ca 10 December 2020, 21:32:56 UTC VectorReduce peephole matching for Hexagon (#5424) * CodeGen for VectorReduce for Hexagon * Remove use of MAKE_ID_PAIR. * Fix clang-format errors. * Spelling correction. * Address comments from PR. Use Shuffle::make_concat instead of vcombine. * Remove IROperator changes. * Address comments * Move even-odd shuffling for vrmpy to runtime .ll func * clang-format + hvx_128 changes.ll changes * clang-format * Minor changes * Minor changes * interchange vshuffvdd operand Co-authored-by: Ankit Aggarwal <aankit@quicinc.com> Co-authored-by: Steven Johnson <srj@google.com> 10 December 2020, 21:32:56 UTC
ad414e2 xndcn 10 December 2020, 17:10:50 UTC Add possible simplify to GL(Compute) `pow` function (#5517) OpenGL(Compute) generates `select` IR for `pow(a, b)` function, which can be simplified when `a` or `b` is const. 10 December 2020, 17:10:50 UTC
5e526d4 Zalman Stern 10 December 2020, 09:40:20 UTC Modify memoization code to allow using min/extent/stride of an input. (#5542) Modify memoization code to allow using min/extent/stride of a buffer as part of memoization without wrapping in memoize_tag. This seems reasonable and failure to support this causes tricky to diagnose errors if one uses the extent of an input in an RDom that is then used in a memoized Func. The code pattern here is a bit heuristic in that I can't think of a case where a Var has a buffer but the reference isn't to a *field* of the buffer. If this turns out to be incorrect or to become invalid in the future, the code could be extended to pattern match the variable name. 10 December 2020, 09:40:20 UTC
382c807 Steven Johnson 09 December 2020, 12:06:57 UTC Update images used in apps/ tests (#5538) Some of them weren't the same as the Make equivalents, which meant that the test diverged between the two build systems (sometimes causing failures due to too-large images). 09 December 2020, 12:06:57 UTC
b83de89 Zalman Stern 09 December 2020, 04:25:41 UTC Pathnames may or may not be absolute so loosen comparison to allow for this. (#5535) 09 December 2020, 04:25:41 UTC
873c8f1 Zalman Stern 08 December 2020, 21:39:04 UTC Solve the COMDAT in runtime failing on Mac OS X problem once and for all. (#5532) Solve the COMDAT in runtime failing on Mac OS X problem once and for all by removing Comdat IR annotations in runtime on Mac OS and iOS. 08 December 2020, 21:39:04 UTC
42b1a6e Dillon Sharlet 08 December 2020, 01:11:28 UTC Add overloaded intrinsic mechanism to simplify code generation (#5527) * Add table of instructions for ARM. * Add CodeGen_LLVM::Intrinsic and related helpers. * Use call_elementwise_intrinsic for more patterns. * Clean up intrinsics a bit. * Use call_elementwise_intrinsic for x86. * More clean-up and comments. * Add comment * Use call_elementwise_intrinsic for pmaddwd * Remove stray comment. * Move a few more things to overloaded intrinsics * Remove unused runtime functions. * Fix some corner case target flags * ssse... * Run clang-format * Replace introspection test. * Remove x86_avx512 initmod * clang-tidy * Remove x86_avx512 from makefile too * Revert simd_op_check * clang-format off on tables * Update Generator.cpp * Update Generator.cpp * Fix requirement for abs_i8x32 * Review fixes * Temporarily work around webassembly strangeness. Co-authored-by: Steven Johnson <srj@google.com> 08 December 2020, 01:11:28 UTC
7f70907 Volodymyr Kysenko 07 December 2020, 17:17:14 UTC Combine align and slice for the small vectors in align_loads (#5497) * Combine align and slice for the small vectors in align_loads * Fix format 07 December 2020, 17:17:14 UTC
1800dc2 Volodymyr Kysenko 07 December 2020, 01:45:39 UTC Simplify a slice of slice (#5495) * Simplify a slice of slice * Fix format * Simplify for slice of concats + tests * format * format * New line to improve readability Co-authored-by: Steven Johnson <srj@google.com> 07 December 2020, 01:45:39 UTC
bd53b47 Volodymyr Kysenko 06 December 2020, 20:39:26 UTC Allow creation of IntImm/UIntImm with any number of bits up to 64 (#5441) * Allow creation of IntImm/UIntImm with any number of bits up to 64 * Changes: - check that the number of bits is >= 1 - modify upgrade_* functions - allow printing of type with arbitrary number of bits. * Fix format * next_power_of_two which will end Co-authored-by: Steven Johnson <srj@google.com> 06 December 2020, 20:39:26 UTC
7ea09cd Alex Reinking 06 December 2020, 07:38:56 UTC Point fft JIT tests to Halide binary (#5521) 06 December 2020, 07:38:56 UTC
d325e13 Dillon Sharlet 04 December 2020, 16:38:05 UTC Add simd_op_check tests and a few more patterns (#5519) * Add simd_op_check coverage of some ARM ops we generate. * Remove local filter option. * Fix expected patterns for arm32. 04 December 2020, 16:38:05 UTC
c1885fc Alexander Root 04 December 2020, 00:14:07 UTC Fixes to bounds inference on shift_left (#5477) * Add shift_left fix for signed integers by possibly negative values + regression test * add required condition on shift_left integer fix * add type check to shift_left minimum condition * fix constant folding of shifts with |b| >= type.bits() for types that allow overflow (failes correctness/simplify test) * make regression tests use scoped bindings * change condition in case int24/int48 proposal happens soon * revert changes based on overflow expectations * add more regression tests * clarify comment * add shift_left min handler for b only UB * fix clang-tidy complaint * relax shift_left of non-negative value constraint * pull case outside of unnecessary preconditions * fix clang-format complaint * fix broken precondition * add typecheck to possibly save a can_prove() call * add easy-out type check to precondition * Add descriptive comment to bug fix + add another early-exit precondition Co-authored-by: Steven Johnson <srj@google.com> 04 December 2020, 00:14:07 UTC
28f9aef Alex Reinking 03 December 2020, 22:05:21 UTC Enable commented clang-format option. (#5520) 03 December 2020, 22:05:21 UTC
759b241 Steven Johnson 03 December 2020, 18:04:00 UTC Add version-checking to the clang-tidy and clang-format scripts (#5513) Using the 'wrong' version of the tools will produce results out of sync with our presubmit tests, so add checking to ensure the user has their env set up correctly. 03 December 2020, 18:04:00 UTC
2ddd0b0 Steven Johnson 03 December 2020, 02:10:58 UTC Revert "Make context handling in GPU runtimes more consistent and robust. (#5474)" (#5515) This reverts commit f47c5c99deac86c6d1f16cfcb1743a0e9e79317d. 03 December 2020, 02:10:58 UTC
2c8e3ea Steven Johnson 03 December 2020, 02:08:31 UTC Revert "Fix broken destroy_context() in gpu_multi_context_threaded_aottest.cpp (#5512)" (#5514) This reverts commit 445ed5ee5ba5e23efaabe0b8d6971c0678b5a569. 03 December 2020, 02:08:31 UTC
445ed5e Steven Johnson 03 December 2020, 00:35:48 UTC Fix broken destroy_context() in gpu_multi_context_threaded_aottest.cpp (#5512) 03 December 2020, 00:35:48 UTC
a34d00d Alex Reinking 02 December 2020, 22:44:43 UTC Adding CMake build for FFT (#5508) * Add fft build * Fix properties * Fix generator argument * Add "Success!" message to fft aot test. * Formatting. * Fix target directory for bench_fft 02 December 2020, 22:44:43 UTC
f47c5c9 Zalman Stern 02 December 2020, 22:40:21 UTC Make context handling in GPU runtimes more consistent and robust. (#5474) This PR adds a consistent GPU compiled kernel cache across the Cuda, Direct3D, OpenCL, and Metal runtimes. This cache is robust for kernels being used across multiple contexts and threads as well as using common code via a template. OpenGL and OpenGLCompute are not addressed due to issues in their implementation. There should be no regressions for those runtimes however. Adds tests for many GPU kernels and kernels across contexts and threads. Fixes a bug in CUDA runtime where some error message text in cuda_do_multidimensional_copy was not initialized. Fixes a bug in CUDA runtime where device release code did not run if CUDA libraries are directly linked into the executable. (This would have caused crashes due to the device allocation caching among other issues.) 02 December 2020, 22:40:21 UTC
073b8e4 Alex Reinking 02 December 2020, 22:19:34 UTC Add CMake presets for 3.19+ users (#5506) * add CMakePresets.json and update docs * fix Windows presets * remove NDEBUG from GCC options * fix typo in README 02 December 2020, 22:19:34 UTC
1c0f824 Alex Reinking 02 December 2020, 22:15:23 UTC Restructure apps to be fully external. (#5507) * Restructure apps to be fully external. * drive-by fix default Halide_TARGET * patch up fused apps build * remove doubled line * fixing multiple import for 3.16 * fix naming convention * Add missing #include <cstdio> 02 December 2020, 22:15:23 UTC
329a405 Dillon Sharlet 02 December 2020, 18:29:08 UTC Enable constant folding of broadcasted constants (#5500) * Enable constant folding of broadcasted constants. * Make some scalar constant folding tests vectors. * Remove excessive simplify calls causing infinite recursion. Co-authored-by: Steven Johnson <srj@google.com> 02 December 2020, 18:29:08 UTC
6cc24bb Andrew Adams 01 December 2020, 20:49:09 UTC Fix compile time regression in fft (#5494) * Use equal instead of can_prove equality when examining enclosing scope There can be a lot of things in there, and can_prove is expensive. * Speed up bounds_of_inner_var By only expanding enclosing let stmts if the variable is actually used in the result, and by finding the last usage and then skipping anything earlier (skipping over nested producer nodes) Co-authored-by: Steven Johnson <srj@google.com> 01 December 2020, 20:49:09 UTC
6af4361 Steven Johnson 01 December 2020, 16:58:13 UTC Fixes for trunk LLVM (#5499) 01 December 2020, 16:58:13 UTC
44c9a72 Dillon Sharlet 01 December 2020, 04:32:46 UTC Reduce size of test image (#5496) 01 December 2020, 04:32:46 UTC
1ad6fb8 Dillon Sharlet 01 December 2020, 04:31:39 UTC Fix case where simplifying interleaves might need a slice of the original vector (#5492) * Replace is_negative_negatable_const and associated cruft with lossless_negate. * Don't assume an interleave consumes all of the vectors it is shuffled from. * Add test of slices of interleaves. * Fix formatting * Rephrase logic. 01 December 2020, 04:31:39 UTC
491791d Dillon Sharlet 01 December 2020, 04:31:00 UTC Simplify signed shifts more strongly (#5491) * Simplify signed shifts more strongly. * Simplify after negating b. * Also mutate other possibly simplifying cast. 01 December 2020, 04:31:00 UTC
960f857 Volodymyr Kysenko 30 November 2020, 22:58:10 UTC Fix All value from the ValType table (#5493) 30 November 2020, 22:58:10 UTC
21afdc4 Andrew Adams 30 November 2020, 21:14:56 UTC Align the base when doing strided loads from constant addresses (#5489) When we codegen something like f[ramp(x + 1, 2, 16)], where f is an internal allocation, we subtract the 1, do the dense load f[ramp(x, 1, 32)] and then take the odd lanes of the result. The reason for this is that it's likely that there's an f[ramp(x, 2, 16)] nearby, and aligning down the x+1 to x means we can share the dense loads and just deinterleave. This PR does the same when there's no x, just an odd constant. This means that cases like f[ramp(64, 2, 16)] + f[ramp(65, 2, 16)] now generate much better assembly. In one case I have it speeds up an entire pipeline by 8%, because aligning the loads in this way causes them to all be promoted off the stack into registers. 30 November 2020, 21:14:56 UTC
226b12c Steven Johnson 30 November 2020, 19:12:07 UTC Improve speed of testing apps/ (#5482) * Improve speed of testing apps/ - Skip all app tests that are labeled as 'benchmarks' - Specify `--build-noclean` to avoid unnecessary full rebuilds * Change label 'benchmark' -> 'slow_tests' 30 November 2020, 19:12:07 UTC
16929df Dillon Sharlet 30 November 2020, 18:27:56 UTC Add Type::widen and Type::narrow helpers. (#5478) * Add Type::widen and Type::narrow helpers. * widen -> wide, more uses of wide. * wide back to widen. Co-authored-by: Dillon Sharlet <dsharlet@gmail.com> 30 November 2020, 18:27:56 UTC
78489d0 Dillon Sharlet 30 November 2020, 16:15:16 UTC Small cleanups/fixes (#5479) * Small cleanups/fixes peeled from lower-patterns2. * Fix derp * Fix possibly undefined evaluation order. * Smaller code. * Work around test issue. 30 November 2020, 16:15:16 UTC
49ca720 Dillon Sharlet 30 November 2020, 15:43:18 UTC Replace is_negative_negatable_const and more logic with lossless_negate (#5490) * Replace is_negative_negatable_const and associated cruft with lossless_negate. * Add comment 30 November 2020, 15:43:18 UTC
bfbfacd Dillon Sharlet 27 November 2020, 20:31:02 UTC Revert formatting of Hexagon intrinsic table (#5484) * Revert formatting of Hexagon intrinsic table * Revert one extra find and replace. 27 November 2020, 20:31:02 UTC
f911a89 Dillon Sharlet 26 November 2020, 07:40:25 UTC Add as_intrinsic helper (#5480) * Add as_intrinsic helper. * Rename calls of known intrinsics. * Fix check_sio. 26 November 2020, 07:40:25 UTC
59bbc4d Dillon Sharlet 25 November 2020, 19:36:02 UTC Simplify intrinsics of broadcasts to broadcasts of intrinsics (#5473) * Simplify intrinsics of broadcasts to broadcasts of intrinsics. * Fix broadcast elementwise simplifications for nested broadcasts. * broadcasted -> broadcast. 25 November 2020, 19:36:02 UTC
3cb2adb Steven Johnson 24 November 2020, 21:52:00 UTC Improvements to HalideTraceViz (#5466) - Handle 4D inputs more gracefully - Improve horizontal squishing of long labels 24 November 2020, 21:52:00 UTC
87c9fac Alex Reinking 24 November 2020, 00:32:49 UTC Fail CMake when LLVM_LINK_LLVM_DYLIB conflicts with wasm (#5472) * Fail CMake when LLVM_LINK_LLVM_DYLIB conflicts with wasm * Update error message and add comment. 24 November 2020, 00:32:49 UTC
31e9687 Alexander Root 23 November 2020, 23:01:04 UTC Remove AndConditionOverDomain and fix Interval::everything() uses in Bounds (#5455) * rm AndConditionOverDomain and fix Interval::everything() uses in Bounds * fix clang-tidy complaint * rm unnecessary/irrelevant comment * nit: add line break 23 November 2020, 23:01:04 UTC
7447e51 Andrew Adams 23 November 2020, 18:11:14 UTC Better codegen for ramps with non-const stride (#5463) 23 November 2020, 18:11:14 UTC
7130069 Tian Jin 22 November 2020, 20:54:41 UTC Fix inconsistency between code & documentation. (#5469) 22 November 2020, 20:54:41 UTC
08825b6 Steven Johnson 22 November 2020, 00:21:25 UTC Add optional NAMESPACE arg to `add_halide_library()` (#5467) * Add optional NAMESPACE arg to `add_halide_library()` This is just syntactic sugar for adding the namespace explicitly to the function name, but for code with long namespaces and/or function names this can make for more readable build files. (The Bazel/Blaze build rules offer a similar option and it works well there.) * Update README_cmake.md 22 November 2020, 00:21:25 UTC
6c754cf Emil Melnikov 20 November 2020, 19:53:34 UTC Change "CMAKE_MODULE_PATH" to "CMAKE_PREFIX_PATH" (#5461) I tried to use instructions for a basic CMake project with a locally downloaded copy of Halide, and got the following error: ``` CMake Error at CMakeLists.txt:9 (find_package): By not providing "FindHalide.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "Halide", but CMake did not find one. Could not find a package configuration file provided by "Halide" with any of the following names: HalideConfig.cmake halide-config.cmake Add the installation prefix of "Halide" to CMAKE_PREFIX_PATH or set "Halide_DIR" to a directory containing one of the above files. If "Halide" provides a separate development package or SDK, be sure it has been installed. ``` Changing `CMAKE_MODULE_PATH` to `CMAKE_PREFIX_PATH` worked for me. 20 November 2020, 19:53:34 UTC
c510744 Steven Johnson 20 November 2020, 02:09:08 UTC Allow HL_EXTRA_OUTPUTS as a way to get extra Generator outputs for debugging (#5457) * Allow HL_EXTRA_OUTPUTS as a way to get extra Generator outputs for debugging * Update Generator.cpp 20 November 2020, 02:09:08 UTC
back to top