Skip to main content

Browse the archive

https://github.com/halide/Halide
19 April 2024, 08:20:39 UTC
sort by:
Revision Author Date Message Commit Date
412a0a4 Steven Johnson 08 December 2021, 01:58:10 UTC Minor tweaks to generate_closure_ir() Cherry-picking some minor changes from an otherwise-failed experimental branch: - Condense code in generate_closure_ir() via use of a lambda - Emit the calls to load_typed_struct_member in such a way that they are in ascending order (they currently get emitted in descending order, which is not wrong but is unsatisfying and suboptimal) - Call simplify() on the final Stmt, so that unused calls to load_typed_struct_member get omitted from the IR (presumably LLVM will strip these out later but it can't fail to do so if we don't emit them at all) 08 December 2021, 01:58:10 UTC
2923246 Steven Johnson 06 December 2021, 21:31:50 UTC Update CodeGen_C.cpp 06 December 2021, 21:31:50 UTC
b6ba514 Steven Johnson 06 December 2021, 17:09:28 UTC Minor cleanup of parallel refactor intrinsics (#6465) * Minor cleanup of parallel refactor intrinsics - Renamed `load_struct_member` to `load_typed_struct_member` to make it more clear that it is intended for use only with the results of `make_typed_struct`. - Split `declare_struct_type` into two intrinsics, `define_typed_struct` and `forward_declare_typed_struct`, removing the need for the underdocumented `mode` argument and hopefully making usage clearer - Added / clarified comments for the intrinsics modified above * Update comments * Fix comments 06 December 2021, 17:09:28 UTC
c21e701 Z Stern 03 December 2021, 01:06:23 UTC Switch to PureIntrinsics per review feedback. 03 December 2021, 01:06:23 UTC
a1d267e Steven Johnson 02 December 2021, 21:30:37 UTC use Closure::include 02 December 2021, 21:30:37 UTC
24a6eb2 Steven Johnson 02 December 2021, 21:24:00 UTC Merge branch 'master' into factor_parallel_codegen 02 December 2021, 21:24:00 UTC
392430d Steven Johnson 02 December 2021, 21:23:25 UTC Fix Closure API (#6464) The current API requires calling a Visitor from the Closure ctor, which means we implicitly call virtual methods from the class ctor, which is a no-no for a non-final class (see comments on https://github.com/halide/Halide/pull/6443). 02 December 2021, 21:23:25 UTC
387c58f Steven Johnson 02 December 2021, 19:02:31 UTC Minor hygiene in LowerParallelTasks - normalize local functions to snake_case - put all local functions & classes in anon namespace - move MinThreads visitor to file scope to reduce nestedness of code 02 December 2021, 19:02:31 UTC
25b7b77 Steven Johnson 02 December 2021, 18:49:23 UTC Remove unused `is_const_pointer()` function 02 December 2021, 18:49:23 UTC
0ed461b Steven Johnson 02 December 2021, 18:38:50 UTC Add operator<< for Closure (#6443) * Add operator<< for Closure Moves the ad-hoc implementation our of HostClosure::arguments() for easier debugging usage. Also, drive-by elimination of the body of HostClosure ctor, which was identical to the one inherited from Closure. * Update DeviceArgument.cpp * Add explanatory comment 02 December 2021, 18:38:50 UTC
9af64ae Steven Johnson 02 December 2021, 17:55:04 UTC Sort IntrinsicOp and corresponding names 02 December 2021, 17:55:04 UTC
d180598 Steven Johnson 02 December 2021, 17:46:59 UTC Merge branch 'master' into factor_parallel_codegen 02 December 2021, 17:46:59 UTC
5cf9ae5 Andrew Adams 02 December 2021, 15:04:43 UTC Reduce overhead of sampling profiler by having only one thread do it (#6433) * Reduce overhead of sampling profiler by having only one thread do it * Use const ref * One line per member 02 December 2021, 15:04:43 UTC
479d839 Steven Johnson 02 December 2021, 03:42:04 UTC Add LinkageType::ExternalPlusArgv (#6452) (#6463) Allows us to skip generating metadata for offloaded hexagon funcs, which will never use it. 02 December 2021, 03:42:04 UTC
0faca07 Steven Johnson 02 December 2021, 00:42:34 UTC Fix hvx lock/unlock semantics for PR #6457 (#6462) Fix qurt_hvx_lock issues 02 December 2021, 00:42:34 UTC
f02b1e9 Steven Johnson 01 December 2021, 19:26:03 UTC Merge branch 'master' into factor_parallel_codegen 01 December 2021, 19:26:03 UTC
4877d26 Steven Johnson 01 December 2021, 19:22:00 UTC Tweak Hexagon codegen output to match the pattern in Lower.cpp more accurately (for level 1 vs 2); also prefix the outputs so they are easier to read as Hexagon-specific when debugging (#6461) 01 December 2021, 19:22:00 UTC
7eb9f5f Steven Johnson 30 November 2021, 23:55:26 UTC Add some std::move usage 30 November 2021, 23:55:26 UTC
e02571b Steven Johnson 30 November 2021, 18:10:02 UTC Augment Closure debugging 30 November 2021, 19:29:30 UTC
c0192ff Steven Johnson 30 November 2021, 06:13:44 UTC Re-enable performance_async_gpu for D3D12Compute (#6450) * Re-enable performance_async_gpu for D3D12Compute It's been disabled for ~2 years because of flaky failures (#3586); we should see if the many changes since then have improved things or not. * tickle buildbots 30 November 2021, 06:13:44 UTC
7d2c2c6 Steven Johnson 29 November 2021, 23:33:33 UTC Update parallel_nested_1.cpp 29 November 2021, 23:33:33 UTC
e64651b Steven Johnson 29 November 2021, 22:52:33 UTC Merge branch 'master' into factor_parallel_codegen 29 November 2021, 22:52:33 UTC
5aeea6a Andrew Adams 26 November 2021, 22:32:24 UTC Fixes for c++20 (#6446) Fixes #6445 26 November 2021, 22:32:24 UTC
76c0946 Martijn Courteaux 26 November 2021, 20:03:24 UTC Syntax highlighting for embedded PTX code. (#6447) * Include GPU source kernels in Stmt and StmtHtml file. * Syntax highlighting for embedded PTX code. 26 November 2021, 20:03:24 UTC
3bde22a Martijn Courteaux 24 November 2021, 20:59:37 UTC Include GPU source kernels in Stmt and StmtHtml file. (#6444) 24 November 2021, 20:59:37 UTC
e71bb81 Steven Johnson 23 November 2021, 23:07:45 UTC Merge branch 'factor_parallel_codegen' of https://github.com/halide/Halide into factor_parallel_codegen 23 November 2021, 23:07:45 UTC
2fd4c9f Steven Johnson 23 November 2021, 23:07:36 UTC Attempt to fix parallel offloads for HVX 23 November 2021, 23:07:36 UTC
8b68f85 Andrew Adams 23 November 2021, 21:13:48 UTC Avoid needless gather in fast_integer_divide lowering (#6441) * Avoid needless gather in fast_integer_divide lowering fast_integer_divide did two lookups, one for a multiplier, and one for a shift. It turns out you can just use count leading zeros to compute a workable shift instead of having to do a lookup. This PR speeds up use of fast_integer_divide in cases where the denominator varies across vector lanes by ~70% or so by avoiding one of the two expensive gathers. * Fix slash direction * Pacify clang-tidy * Use portable bit-counting methods * Cleaner initialization of tables 23 November 2021, 21:13:48 UTC
6528ba6 Steven Johnson 23 November 2021, 20:18:13 UTC clang-tidy 23 November 2021, 20:18:13 UTC
b9ac7d6 Steven Johnson 23 November 2021, 19:45:20 UTC Remove unused MayBlock visitor class 23 November 2021, 19:45:20 UTC
df247f9 Steven Johnson 23 November 2021, 19:41:00 UTC Remove no-longer-used Closure code from Codegen_Internal 23 November 2021, 19:41:00 UTC
114d209 Steven Johnson 23 November 2021, 18:48:38 UTC Merge branch 'master' into factor_parallel_codegen 23 November 2021, 18:48:38 UTC
d12fbd1 Steven Johnson 23 November 2021, 17:33:38 UTC Codegen_C: buffer compilation needs to special-case scalar buffers (#6442) The existing code will emit something like `halide_dimension_t foo_buffer_shape[] = {};` for these, which is a zero-length array, which some compilers will (justifiably) say has no effect. We should be able to just use nullptr for the shape in these cases. 23 November 2021, 17:33:38 UTC
59d6da7 Andrew Adams 23 November 2021, 17:25:47 UTC Skip custom cuda context test on older GPUs (#6437) 23 November 2021, 17:25:47 UTC
5733306 Steven Johnson 22 November 2021, 21:30:11 UTC Merge branch 'master' into factor_parallel_codegen 22 November 2021, 21:30:11 UTC
a89041b Steven Johnson 22 November 2021, 21:29:11 UTC Ensure that halide_start_clock() is called before halide_current_time_ns() in hexagon_host.cpp (#6438) This oversight was causing an assert with the -debug feature flag enabled (with presumably-misleading timing results as well) 22 November 2021, 21:29:11 UTC
57d1e05 Steven Johnson 22 November 2021, 19:46:52 UTC Set up SANITIZER_FLAGS and OPTIMIZE for apps/Makefile.inc (#6435) Minor hygiene to make it easy to build AOT apps with TSAN or ASAN. 22 November 2021, 19:46:52 UTC
2239443 Andrew Adams 19 November 2021, 22:56:12 UTC Do target-specific lowering of lerp (#6432) * Do target-specific lowering of lerp Saves instructions on x86. Before #6426 vpaddw %ymm0, %ymm1, %ymm1 vpsrlw $8, %ymm1, %ymm2 vpaddw %ymm2, %ymm1, %ymm1 vpsrlw $8, %ymm1, %ymm1 After #6426 vpsrlw $7, %ymm2, %ymm3 vpand %ymm0, %ymm3, %ymm3 vpsrlw $8, %ymm2, %ymm4 vpaddw %ymm2, %ymm4, %ymm2 vpaddw %ymm3, %ymm2, %ymm2 vpsrlw $7, %ymm2, %ymm3 vpand %ymm0, %ymm3, %ymm3 vpsrlw $8, %ymm2, %ymm2 vpaddw %ymm2, %ymm3, %ymm2 vpand %ymm1, %ymm2, %ymm2 This PR: vpaddw %ymm0, %ymm3, %ymm3 vpmulhuw %ymm1, %ymm3, %ymm3 vpsrlw $7, %ymm3, %ymm3 * Target is a struct 19 November 2021, 22:56:12 UTC
cfd03c9 Steven Johnson 19 November 2021, 17:41:05 UTC Don't remap the function name or the target in the metadata (#6430) The remapping is only intended to be used for output argument(s), not the function name; if you have an output with the same name as the function, you can get the metadata emitted with incorrect information. (And remapping the target string is just silly.) This is almost impossible to do currently, but if you construct a Generator just right, you can make it happen. 19 November 2021, 17:41:05 UTC
c3040cb Volodymyr Kysenko 19 November 2021, 17:10:15 UTC Rewrite integer lerp using intrinsics (#6426) * Rewrite integer lerp using intrinsics * Comment 19 November 2021, 17:10:15 UTC
f49f800 Z Stern 19 November 2021, 08:50:15 UTC Merge branch 'master' into factor_parallel_codegen 19 November 2021, 08:50:15 UTC
5d93f1e Z Stern 19 November 2021, 08:49:17 UTC Comment typo fixes. 19 November 2021, 08:49:17 UTC
0e40edc Ashish Uthama 18 November 2021, 21:27:53 UTC Include LICENSE.txt in package (#6428) Co-authored-by: Ashish Uthama <you@example.com> 18 November 2021, 21:27:53 UTC
36dd10f Steven Johnson 17 November 2021, 23:14:21 UTC Fix Introspection issues (#6424) - DWARF v5 has a slightly different header; this recognizes it so we don't fail immediately - Add support for the line_strp form - Allow for a graceful failure if a debug abbreviation is missing; I've only seen this when compiling for TSAN, and I'm honestly not entirely sure if this is a bug in the DWARF generation for those tools vs a subtle flaw in our parsing, but bailing out early and skipping introspection seems kinder than assert-fail. 17 November 2021, 23:14:21 UTC
00a0715 dsharletg 15 November 2021, 21:33:21 UTC Add hacky fix for losing global variables. 15 November 2021, 21:34:16 UTC
16fa3ce Steven Johnson 12 November 2021, 23:17:53 UTC [hannk] Pacify clang-tidy (#6412) * [hannk] Pacify clang-tidy * One more ASAN fix We must use use_global_gc = false to work properly with the JIT * Revert "One more ASAN fix" This reverts commit 9ed07a70b4a656790236a5ff6966155df823a319. * Rework Op::mutate() to avoid UB 12 November 2021, 23:17:53 UTC
b63f6af Steven Johnson 12 November 2021, 20:56:57 UTC [hannk] Fix lower_tflite_fullyconnected (#6414) Fixed the bounds calculation in lower_tflite_fullyconnected() to preserve the invariants expected, and added a testcase that previously failed. 12 November 2021, 20:56:57 UTC
8c2dd5f Steven Johnson 12 November 2021, 20:34:14 UTC One more ASAN fix (#6413) We must use use_global_gc = false to work properly with the JIT 12 November 2021, 20:34:14 UTC
0153c6b Steven Johnson 12 November 2021, 16:35:37 UTC Revamp Hannk IR (#6379) Refactor Hannk IR and transforms to use a Mutator-based approach 12 November 2021, 16:35:37 UTC
79da2a0 Steven Johnson 12 November 2021, 16:34:30 UTC Fix broken ASAN code (#6408) * Fix broken ASAN code Various changes and merges ended up with us using multiple ASAN passes, which was pretty crashy (we just didn't notice because it isn't tested well enough on our buildbots, but is elsewhere). I think we really only want to use the ModuleAddressSanitizerPass (not the non-Module version), which is what Clang does. * set UseAfterScope = true 12 November 2021, 16:34:30 UTC
02a394d Steven Johnson 12 November 2021, 03:25:52 UTC x86_cpuid_halide must preserve all 64 bits of rbx/rsi (#6409) The existing code attempts to preserve ebx (since the cpuid instruction can trash it), but it only preserves the lower 32 bits; on 64-bit systems, this (amazingly) usually works OK unless you are compiling in (e.g.) ASAN mode, which can subtly change codegen such that the full 32 bits of rbx must be preserved. I'm genuinely astonished this hasn't bitten us before now! 12 November 2021, 03:25:52 UTC
d763406 Volodymyr Kysenko 12 November 2021, 01:30:05 UTC Change implementation of round_f* in CodeGen_C to use nearbyint to match CodeGen_LLVM (#6406) 12 November 2021, 01:30:05 UTC
9ff87ce Steven Johnson 11 November 2021, 18:04:09 UTC _halide_buffer_crop() needs to check for runtime failures (v2) (#6403) * _halide_buffer_crop() needs to check for runtime failures (v2) (Alternate to #6402) We currently assume that _halide_buffer_crop() will never fail. This is a bad assumption, as it can call device_crop(), which can fail due to unexpected runtime errors, or from a backend simply leaving the device_crop field at the default (unimplemented) case (as is currently the case for the OGLC backend). When this happens, the dst buffer was left in an inconsistent, invalid state (which was what led to the crashes fixed by #6401). This change modifies _halide_buffer_crop() to return nullptr in the event of an error, and ensure that all cropped buffers are checked for null at the right point. (This is not optimal, of course, since the specific error returned by device_crop is getting dropped on the floor, but the existence of an error is no longer ignored.) This addresses at least some of the failure issues we are seeing in performance_async_gpu with the OpenGLCompute backend. (Also: drive-by whitespace fix in CodegenC) * Oops 11 November 2021, 18:04:09 UTC
d343e76 Andrew Adams 11 November 2021, 17:06:00 UTC Fix obscure bug in widening let substitution (#6405) Fix obscure bug in widening let substitution 11 November 2021, 17:06:00 UTC
8e34a35 Steven Johnson 09 November 2021, 23:10:40 UTC Remove halide_abort_if_false() usage in runtime/metal (#6398) * Remove halide_abort_if_false() usage in runtime/metal This converts all the usage of `halide_abort_if_false()` in runtime/metal into either an explicit runtime check-and-return-error-code (if the check looks plausible), or `halide_debug_assert()` (if the check seems to be stating an invariant that shouldn't be possible in well-structured code). These changes are admittedly subjective, so feedback is especially welcome. Also, driveby change to sync-common.h to use `halide_debug_assert()` rather than a local equivalent. * nits 09 November 2021, 23:10:40 UTC
4f70271 Steven Johnson 09 November 2021, 22:51:05 UTC Add defensive checks to halide_buffer_copy_already_locked (#6401) Found while debugging crashes with performance_async_gpu for OpenGLCompute: the 'if' tree wasn't robust enough for malformed buffers being passed, and could attempt to deref and use a null src->device_interface or dst->device_interface in some cases. This patch just improves this function to return an error in these cases (rather than crashing); the fact that we are getting malformed buffers passed to us is likely a separate bug. 09 November 2021, 22:51:05 UTC
b189722 Steven Johnson 09 November 2021, 21:35:24 UTC [hannk] Upgrade hannk to use TFLite 2.7.0 by default (#6393) * [hannk] Upgrade hannk to use TFLite 2.7.0 by default * Fix unused-vars warnings 09 November 2021, 21:35:24 UTC
b021f87 Steven Johnson 09 November 2021, 21:25:26 UTC Move PyTorch test into standalone tests (#6397) * Move PyTorch test into standalone tests It doesn't need to be internal. Also simplified to use only public API, updated the expected correctness, and avoided the need to have cuda present on the system to test for cuda output (since we can cross-compile to generate the C++ output anywhere). * fixes * Fix Windows text file endings * Update pytorch.cpp * Update pytorch.cpp 09 November 2021, 21:25:26 UTC
4286c78 Steven Johnson 09 November 2021, 17:13:09 UTC Drop support for LLVM11 (#6396) * Drop support for LLVM11 With Halide 13 released, we should drop support for LLVM11 in Halide trunk, since we only promise to support LLVM trunk + two releases. * Update packaging.yml * Update config.cmake * Update CMakeLists.txt 09 November 2021, 17:13:09 UTC
d3ea755 Steven Johnson 09 November 2021, 17:03:17 UTC Fix OGLC debug builds (#6399) If you try to build and run something with `openglcompute` and `debug`, you may crash with a div-by-zero, because the openglcompute runtime never calls `halide_start_clock()`, and all implementations of `halide_current_time_ns()` assume that it has been called. On (e.g.) OSX, this results in div by zero. This fixes it by inserting the correct call into openglruntime.cpp, and also adding debug-only asserts to all the `halide_current_time_ns()` implementations. (I was tempted to fix this by removing `halide_start_clock()` entirely and just lazily initing the initial value in `halide_current_time_ns()`, but I figured that would likely get pushback...) 09 November 2021, 17:03:17 UTC
d6f1345 Steven Johnson 08 November 2021, 23:13:13 UTC Rename halide_assert -> halide_abort_if_false (#6382) * Rename halide_assert -> HALIDDE_CHECK A crashing bug got mistakenly inserted because a new contributor (reasonably) assumed that the `halide_assert()` macro in our runtime code was like a C `assert()` (i.e., something that would vanish in optimized builds). This is not the case; it is a check that happens in all build modes and always triggers an `abort()` if it fires. We should remove any ambiguity about it, so this proposes to rename it to somethingmore like the Google/Abseil-style CHECK() macro, to make it stand out more. (We may want to do a followup to verify that all of the uses really are unrecoverable errors that aren't better handled by returning an error.) * clang-format * Fix for top-of-tree LLVM * Fix for older versions * HALIDE_CHECK -> halide_abort_if_false * Update runtime_internal.h 08 November 2021, 23:13:13 UTC
1312817 Steven Johnson 08 November 2021, 22:01:29 UTC Clean up CodeGen_LLVM names to match ASAN nomenclature changes (#6395) 08 November 2021, 22:01:29 UTC
6071cf6 Steven Johnson 08 November 2021, 20:13:44 UTC Check results of all runtime function calls (#6389) * Check results of all runtime function calls This cherry-picks just the changes to callsites internal to Halide (and tests) from #6388. (It doesn't attempt to annotate runtime functions to enforce checking the results.) * Update write_debug_image.cpp * Add checks + comment to buffer_copy_aottest * Add comment to gpu_object_lifetime_aottest * Update memory_profiler_mandelbrot_aottest.cpp * Update user_context_insanity_aottest.cpp * Update process.cpp 08 November 2021, 20:13:44 UTC
a798909 Steven Johnson 08 November 2021, 20:13:28 UTC Add halide_debug_assert() macro (#6390) * Add halide_debug_assert() macro Also convert usage of halide_assert()/HALIDE_CHECK() in hashmap.h and gpu_context_common.h to halide_debug_assert(), as all the usages looked to be appropriate for debug-mode only. (Rebased version of #6385, which this replaces) * appease clang-format 08 November 2021, 20:13:28 UTC
c87399c Z Stern 05 November 2021, 03:08:18 UTC Merge branch 'master' into factor_parallel_codegen 05 November 2021, 03:08:18 UTC
656c6b5 Steven Johnson 04 November 2021, 23:00:28 UTC [hannk] Have CMake emit .s, .stmt, .ll files (#6392) 04 November 2021, 23:00:28 UTC
26ccb54 Omar Emara 04 November 2021, 00:35:13 UTC Support vectorized Select in OpenGLCompute backend (#6371) The ternary operator in GLSL does not work with vector types. While the mix function have overloads to boolean vectors, it is only supported in version 4.5, so it is not exactly portable. To work around this, we use the ternary operator on all elements of the vector type. Necessary for #6348. 04 November 2021, 00:35:13 UTC
c005b9f Omar Emara 04 November 2021, 00:32:20 UTC Support vectorization in OpenGLCompute backend (#6348) * Support vectorization in OpenGLCompute backend This patch adds support for vector load and store operations. First, a pass identifies the buffers whose loads and stores are all dense, aligned, and have the same number of lanes. Such buffers are declared with a vector base type and accessed accordingly. Loads and stores that do not satisfy those criteria are implemented as gathers and scatters from buffers whose base type is scalar. Resolves #4976. Partially resolves #1687. * Move buffer name instead of copy (clang-tidy) 04 November 2021, 00:32:20 UTC
657bb03 Steven Johnson 03 November 2021, 23:29:38 UTC Fix for top-of-tree LLVM (#6386) * Fix for top-of-tree LLVM * Fix for older versions 03 November 2021, 23:29:38 UTC
76315a2 Omar Emara 03 November 2021, 22:54:44 UTC Vectorize Ramp in OpenGLCompute backend (#6372) Currently, ramps are generated as a number of independent scalar expressions that are finally gathered into a vector. For instance, indexing in vectorized code is filled with ramps like the following: ``` int _11 = int(1) * int(1); int _12 = _10 + _11; int _13 = int(2) * int(1); int _14 = _10 + _13; int _15 = int(3) * int(1); int _16 = _10 + _15; ivec4 _17 = ivec4(_10, _12, _14, _16); ``` This patch simplifies the generated code using a multiply add expression on a vector containing an arithmetic expression, such that the code is as follows: ``` ivec4 _11 = ivec4(0, 1, 2, 3) * int(1) + _10; ``` This is more performant due to vectorization, more compact, and more readable because the base and the stride are easily identifiable. 03 November 2021, 22:54:44 UTC
2cf3afb Steven Johnson 03 November 2021, 22:47:03 UTC [hannk] Fix MeanOp (#6336) * [hannk] Fix MeanOp The `reducing()` method didn't handle negative values for indices, and didn't reverse the value of the axis as we do elsewhere, so results were incorrect. Also, we now parse and save the value of `keep_dims`, though I can't find evidence that it does much of anything: test cases pass different values for it but none of them fail (even though we ignore it), and at least one reference implementation I see doesn't seem to do anything with it. * Remove keep_dims handling for MeanOp 03 November 2021, 22:47:03 UTC
7ec8d70 Steven Johnson 03 November 2021, 22:19:15 UTC Convert various halide_assert -> static_assert (#6383) The type-size checks in d3d12compute.cpp don't need to be runtime checks. 03 November 2021, 22:19:15 UTC
a227440 Steven Johnson 03 November 2021, 20:55:28 UTC Remove halide_assert() from halide_default_device_wrap_native (#6381) This was inserted in https://github.com/halide/Halide/pull/6310, probably mistakenly, since `halide_assert()` in the Halide runtime is *not* a debug-only assertion). Instead of a controlled runtime failure, we just abort, which is not OK. 03 November 2021, 20:55:28 UTC
415ce0c Alex Reinking 03 November 2021, 20:27:46 UTC Fix empty INSTALL_COMMAND in hannk super-build (#6387) * Fix empty INSTALL_COMMAND in hannk super-build * Fix 3.16 missing command * Fix the fix... 03 November 2021, 20:27:46 UTC
0d6b0f5 Steven Johnson 03 November 2021, 16:18:45 UTC Fix for top-of-tree LLVM (#6380) 03 November 2021, 16:18:45 UTC
ac2673b Alex Reinking 03 November 2021, 00:57:12 UTC Add super-build for cross-compiling HANNK (#6374) * Add super-build for cross-compiling HANNK * Relax CMake version 03 November 2021, 00:57:12 UTC
6070821 Alex Reinking 02 November 2021, 19:42:02 UTC Update README for Halide 13. (#6378) 02 November 2021, 19:42:02 UTC
5b8f473 Volodymyr Kysenko 02 November 2021, 15:36:19 UTC Fix for the crash from #6367 (#6375) * Skip empty boxes * Address the comments 02 November 2021, 15:36:19 UTC
4225eba Alex Reinking 01 November 2021, 23:03:09 UTC Add helper for cross-compiling Halide generators. (#6366) * Add helper for cross-compiling Halide generators. Created a new function, `add_halide_generator`, that helps users write correct cross-compiling builds by establishing the following convention for creating a generator named `TARGET`: 1. Define Halide generators and libraries in the same project 2. Assume two builds: a host build and a cross build. 3. When creating a generator, check to see if we can load a pre-built version of the target. 4. If so, just use it. 5. If not, make sure the full Halide package is loaded and create a target for the generator. a. If `CMAKE_CROSSCOMPILING` is set, then _warn_ the user (the variable is unreliable on macOS) that something seems fishy. b. Create export rules for the generator. It creates a package `PACKAGE_NAME` and appends to its `EXPORT_FILE`. c. Create a custom target also named `PACKAGE_NAME` for building the generators. d. Create an alias `${PACKAGE_NAMESPACE}${TARGET}`. 6. Users are expected to use the alias in conjunction `add_halide_library`. Users can test the existence of `TARGET` to determine whether a pre-built one was loaded (and set additional properties if not). 7. Setting `${PACKAGE_NAME}_ROOT` is enough to load pre-built generators. `PACKAGE_NAME` is `${PROJECT_NAME}-halide_generators` by default. `PACKAGE_NAMESPACE` is `${PROJECT_NAME}::halide_generators::` by default. `EXPORT_FILE` is `${PROJECT_BINARY_DIR}/cmake/${PACKAGE_NAME}-config.cmake` by default. Users are free to avoid the helper if it would not fit their workflow. * Make HANNK use the new add_halide_generator helper 01 November 2021, 23:03:09 UTC
f5ce5f3 Steven Johnson 01 November 2021, 20:40:36 UTC [hannk] Clean up aliasing (v2) (#6364) * wip * [hannk] Clean up aliasing (v2) The code for aliasing tensors was janky. This cleans it up and makes a clear distinction between aliasing done to overlay buffers with crop-and-translate, vs the aliasing done when we reshape tensors. We no longer allow a given tensor to do both of these, and we give preference to Reshape aliasing first. (Cherry-picked from #6321) * Move alias_type into shared ptr 01 November 2021, 20:40:36 UTC
1a1c97f Steven Johnson 01 November 2021, 20:28:50 UTC [hannk] Add support for building/running for wasm (#6361) * [hannk] Allow disabling TFLite+Delegate build in CMake Preparatory work for allowing building of hannk with Emscripten; TFLite (and its dependees) problematic to build in that environment, but this will allow us to build a tflite-parser-only environment. (Note that more work is needed to get this working for wasm, as crosscompiling in CMake is still pretty painful; this work was split out to make subsequent reviews simpler) * [hannk] Add support for building/running for wasm * HANNK_BUILD_TFLITE_DELEGATE -> HANNK_BUILD_TFLITE * Use explicit host build strategy for cross compiling HANNK (#6365) * Ignore local emsdk clone * Fix usage of CMAKE_BUILD_TYPE * Only print the Halide target info once per CMake run * Fix Halide "cmake" target detection for Emscripten * Prefer target_link_options to _link_libraries when applicable * Validate, rather than find, NODE_JS_EXECUTABLE (set by emsdk) * Emscripten already wraps tests with node. * Add dependency on Android logging library. * For cross-compiling, find host tools instead of recursive call. Rather than shelling out via execute_process and potentially guessing the toolchain options wrong, expect to find our host tools (i.e. generators) in a package called "hannk_tools". The package is created by the host build via the CMake export() command. Importing this package in the cross build creates IMPORTED targets with the same names as our generators. We then use these generators rather than creating generators for the target build. * Rework cross-compiling script. * Respond to (easy) reviewer comments. * Add HANNK_AOT_HOST_ONLY option. Use in script. * [hannk] tests should only process .tflite files (#6368) currently, random dotfiles (e.g. .DS_Store on OSX) can creep in, causing bogus failures * Add comment about node wrapping. * Rename hannk_tools to hannk-halide_generators * Add comment about exporting targets. * Bump version to Halide 14.0.0 (#6369) Co-authored-by: Steven Johnson <srj@google.com> Co-authored-by: Alex Reinking <alex_reinking@berkeley.edu> 01 November 2021, 20:28:50 UTC
69d8ef0 Alex Reinking 30 October 2021, 01:33:50 UTC Bump version to Halide 14.0.0 (#6369) 30 October 2021, 01:33:50 UTC
3c52df1 Steven Johnson 29 October 2021, 23:46:50 UTC [hannk] tests should only process .tflite files (#6368) currently, random dotfiles (e.g. .DS_Store on OSX) can creep in, causing bogus failures 29 October 2021, 23:46:50 UTC
541bc37 Steven Johnson 28 October 2021, 21:14:42 UTC [hannk] Allow disabling TFLite+Delegate build in CMake (#6360) * [hannk] Allow disabling TFLite+Delegate build in CMake Preparatory work for allowing building of hannk with Emscripten; TFLite (and its dependees) problematic to build in that environment, but this will allow us to build a tflite-parser-only environment. (Note that more work is needed to get this working for wasm, as crosscompiling in CMake is still pretty painful; this work was split out to make subsequent reviews simpler) * Update hannk_delegate.h * HANNK_BUILD_TFLITE_DELEGATE -> HANNK_BUILD_TFLITE 28 October 2021, 21:14:42 UTC
e10f104 Steven Johnson 28 October 2021, 17:34:27 UTC Update Emscripten settings (#6362) The settings we use to build C++ in wasm were slightly out of date now that we've updated our runtime to Node instead of d8. Also drive-by gitignore fix. 28 October 2021, 17:34:27 UTC
1c7388a Andrew Adams 28 October 2021, 17:25:58 UTC Allow users to use their own cuda contexts and streams in JIT mode (#6345) * Deprecate JIT runtime override methods that take void * * Make it possible to use custom cuda contexts and streams in JIT mode * Clean up comments * Tolerate null handlers in the JITUserContext These can come up if a JITUserContext is passed to something like copy_to_device before getting fully populated by passing it to a call to realize. * Remove reliance on dlsym in test and reuse the runtime's name resolution mechanism instead * Handle case where cuda and cuda-debug runtime modules both exist This change means we'll only ever create one built-in cuda context in this circumstance. * Slight simplification * Improve comments 28 October 2021, 17:25:58 UTC
4f573bf Volodymyr Kysenko 28 October 2021, 02:05:29 UTC Add missing widening_absd patterns (#6359) * Add missing widening_absd patterns * Add a comment 28 October 2021, 02:05:29 UTC
8f1ae2a Steven Johnson 27 October 2021, 20:37:00 UTC Use Node instead of d8 for Wasm AOT testing (#6356) * Use Node instead of d8 for Wasm AOT testing This requires the right version of Node is installed on your system. Since EMSDK often puts a too-old version of Node in the path, allow overriding via an env var. * wip 27 October 2021, 20:37:00 UTC
34534f5 Steven Johnson 27 October 2021, 20:35:39 UTC [hannk] Add missing call to Interpreter::prepare in benchmark app (#6358) 27 October 2021, 20:35:39 UTC
a15ffda Volodymyr Kysenko 27 October 2021, 01:33:39 UTC Add include for size_t in constants.h (#6353) * Add include for size_t in constants.h * Change to int 27 October 2021, 01:33:39 UTC
86cb6c7 Andrew Adams 26 October 2021, 23:12:52 UTC Deprecate JIT runtime override methods that take void * (#6344) * Deprecate JIT runtime override methods that take void * * Clean up comments 26 October 2021, 23:12:52 UTC
6211da9 Andrew Adams 26 October 2021, 23:12:34 UTC Add --help flag to rungenmain, fixing #5323 (#6354) 26 October 2021, 23:12:34 UTC
06a37ca Steven Johnson 26 October 2021, 17:23:23 UTC Add to various OpVisitors to avoid overload warnings for some compilers (#6337) 26 October 2021, 17:23:23 UTC
47fa87f Steven Johnson 26 October 2021, 17:22:49 UTC [hannk] Add a prepare() method for ops and interp (#6338) * [hannk] Add a prepare() method for ops and interp This adds a new method to the Interpreter, and to all ops, which allows the interpreter (and each op) to do any one-time preparation for future executions. Previously this was lumped into either the Interpreter's ctor, or the Ops various other methods, but this has some nice advantages at minimal cost: - Since the new prepare() returns an error value, it allows the Interpreter to do sanity checking at startup and return an error to the caller (rather than simply crashing); this makes using it in some runtime environments less painful. - Ops can use this to prep and cache information for multiple subsequent runs; initially, Conv and DepthwiseConv use this to calculate and cache the alignment requirements they need later on. This is unlikely to be a huge performance hit, but it is likely nonzero, and As an added bonus, this means that e.g. the map_bounds() method is no longer susceptible to runtime failures from Halide bounds queries. * Update interpreter.cpp * Update transforms.cpp * Update transforms.cpp 26 October 2021, 17:22:49 UTC
667836d Steven Johnson 26 October 2021, 17:16:35 UTC Harvest IWYU changes for LLVM, WABT (#6341) A couple of minor hygiene changes, extracted from https://github.com/halide/Halide/pull/6251: - Clean up LLVM_Headers.h to uniformly use <> instead of "" and to alphabetize properly - Clean up WABT includes to reflect what we need more accurately 26 October 2021, 17:16:35 UTC
b34919f Omar Emara 26 October 2021, 17:09:48 UTC Fix wrong type in Ramp CodeGen for OpenGLCompute (#6349) The variable type of the Ramp in OpenGLCompute is assigned the type of the base member of the ramp, which is a scalar, while the ramp is a vector. Instead, we should use the type of the ramp instead to take vectorization into account. Partially resolves #1687. 26 October 2021, 17:09:48 UTC
ab57ab1 Steven Johnson 26 October 2021, 17:07:44 UTC [hannk] augment SoftmaxOp to allow specifying axis (#6351) (basically equivalent to #6335 but for softmax) 26 October 2021, 17:07:44 UTC
50517cb Steven Johnson 26 October 2021, 17:07:00 UTC [hannk] requantize() should never skip the operation (#6350) * [hannk] requantize() should never skip the operation Even if inq == outq, the incoming buffer can contain out-of-range values; we shouldn't try to optimize the op away, since it's cheap. * Update ops.cpp * Update ops.cpp 26 October 2021, 17:07:00 UTC
d6d7bbc Steven Johnson 26 October 2021, 17:05:48 UTC Make halide_type_t and halide_type_of constexpr (#6340) * Make halide_type_t and halide_type_of constexpr This allows us to do a bit more at compile time in some cases; e.g., we can more reliably collapse things like `t == halide_type_t(int, 8)` into `t.as_u32() == literal-integer`, avoiding temporaries. It also makes it tractable to to do a `switch` on a series of `halide_type_t`, since we can now use halide_type_t::as_u32() as a constexpr. There were a number of places that did this in an ad-hoc manner previously; I updated those, and also converted at least one more repeated-if clause into a switch. (TBH, I'm not sure if I'm wild about the syntax, though; it is a bit weedy to scan. Suggestions welcome.) * Ensure there are no uninited vars in constexpr funcs * Update HalideRuntime.h 26 October 2021, 17:05:48 UTC
334e27a Volodymyr Kysenko 26 October 2021, 05:10:41 UTC Specify template parameter of ScopedValue (#6352) 26 October 2021, 05:10:41 UTC
back to top