Skip to main content

Browse the archive

https://github.com/halide/Halide
19 April 2024, 08:20:39 UTC
sort by:
Revision Author Date Message Commit Date
cb0eeea Steven Johnson 09 March 2022, 23:48:28 UTC Fix TSAN-reported data races in profiler shutdown code TSAN reports data races for halide_profiler_pipeline_end() and halide_profiler_shutdown() when reading/writing current_func; we need to acquire the lock. 09 March 2022, 23:48:28 UTC
105f7e5 Steven Johnson 07 March 2022, 20:59:04 UTC Fix const-correctness in C/C++ backend (Issue #6636) (#6638) in the Load handler, we need to emit the cast in the form `TYPE const *` rather than `const TYPE *`, as TYPE could be `void *`, and the const would bind in a way we don't want. 07 March 2022, 20:59:04 UTC
5f37d50 Steven Johnson 07 March 2022, 20:58:12 UTC Convert most remaining Generators to prefer statically-dimensioned Inputs and Output where possible (#6641) This is the same as #6620, except that it omits autoschedulers/adams2019/cost_model_generator.cpp (which is unusually complex and not yet settled as to whether the changes are welcome). Basically an attempt to land the uncontroversial parts. 07 March 2022, 20:58:12 UTC
a55ae55 Alexander Root 06 March 2022, 20:21:32 UTC Clear bounds info on casts when value bounds are undefined (for overflow types) (#6640) 06 March 2022, 20:21:32 UTC
979e204 Karthik Nishanth 06 March 2022, 00:25:10 UTC python_bindings: acquire GIL before printing (#6635) 06 March 2022, 00:25:10 UTC
0b8e263 Steven Johnson 06 March 2022, 00:24:29 UTC Clean up python_binding Makefile (#6634) * Clean up python_binding Makefile Some of the tests with Generator dependencies had deps set up in a weird way that made some downstream work painful. Cleaned up. Also vastly reduced build-time noise. * Update Makefile * Add linker scripts for Python extensions 06 March 2022, 00:24:29 UTC
3827279 Steven Johnson 04 March 2022, 00:49:18 UTC Python Bindings didn't allow for zero-D Funcs, ImageParams, Buffers (#6633) * Python Bindings didn't allow for zero-D Funcs, ImageParams, Buffers There were no overloads or tests for accessing the element of any of these in the zero-D case, and the obvious syntax (`[]`, to mirror C++ `()` in these cases) isn't legal in Python. To support this uncommon-but-necessary case, I'm proposing that we use the syntax `[None]`, which isn't pretty, but is less bad than other options I've considered so far. (Suggestions welcome.) * Use [()] instead of [None] 04 March 2022, 00:49:18 UTC
86728d7 Alexander Root 26 February 2022, 18:56:09 UTC Wild match object is not foldable (#6623) 26 February 2022, 18:56:09 UTC
caa3ad0 Volodymyr Kysenko 24 February 2022, 01:09:55 UTC Avoid double narrowing in widening_add/widening_sub if type is 8-bit (#6629) 24 February 2022, 01:09:55 UTC
b2edbc9 Alexander Root 22 February 2022, 20:09:23 UTC Disallow `Type::narrow()` and `Type::widen()` from producing bitwidths between 1 and 8 bits (#6622) * Disallow Type::narrow() and Type::widen() from producing bitwidths between 1 and 8 bits * Narrowing a 1-bit type should error 22 February 2022, 20:09:23 UTC
a4ed033 Alex Reinking 22 February 2022, 04:31:55 UTC Make IRComparer consider nans to be less than non-nans. (#6626) * Make IRComparer consider nans to be less than non-nans. Fixes #6624 * Fix test * Respond to reviewer comments. * Return -1 instead of +1 22 February 2022, 04:31:55 UTC
16bfa2f Alexander Root 21 February 2022, 18:42:15 UTC remove incorrect docs on widening_add (#6625) 21 February 2022, 18:42:15 UTC
be1269b Andrew Adams 17 February 2022, 21:44:35 UTC Add Stage::unscheduled() 18 February 2022, 22:26:15 UTC
0786dd4 Andrew Adams 02 February 2022, 18:36:57 UTC Fix atomics test 18 February 2022, 22:26:15 UTC
6424aaa Andrew Adams 01 February 2022, 22:24:11 UTC Reenable warning about unscheduled update definitions and fix associated issues in the tests and apps. This is an old warning that stopped triggering because it wasn't tested. We should either remove it, fix the trigger conditions, or perhaps make it an error. This PR fixes the trigger conditions and fixes all instances of the warning in our tests and apps. The warning triggers if you schedule some but not all of the update definitions of a Func. It's to protect against the common error of only scheduling the pure definition of something like a summation. The warning can be suppressed by inserting a call to func.update(idx). 18 February 2022, 22:26:15 UTC
7373eb9 Steven Johnson 17 February 2022, 17:07:46 UTC Move GeneratorContext into a standalone class (#6618) * Move GeneratorContext into a standalone class * Minor Fixes * clang-tidy * Update Generator.cpp * Update Generator.cpp 17 February 2022, 17:07:46 UTC
846592f Steven Johnson 16 February 2022, 22:41:18 UTC Update WABT version to the just-released 1.027 (instead of main) (#6619) * Update WABT version to the just-released 1.027 (instead of main) * tickle buildbots 16 February 2022, 22:41:18 UTC
4ccd0ec Alex Reinking 16 February 2022, 01:25:09 UTC Remove halide_config.cmake from Makefile build. Fixes #6615 (#6616) 16 February 2022, 01:25:09 UTC
f9189dc Steven Johnson 16 February 2022, 01:24:57 UTC Update apps/hannk to use TFLite 2.8.0 (#6617) 16 February 2022, 01:24:57 UTC
3628b67 Steven Johnson 15 February 2022, 00:30:25 UTC Minor Generator cleanup (#6613) 15 February 2022, 00:30:25 UTC
ba86c2e Steven Johnson 15 February 2022, 00:29:13 UTC Unbreak WABT again by using main instead of a commit (#6614) 15 February 2022, 00:29:13 UTC
38032e8 Basile Clement 14 February 2022, 18:43:50 UTC Only commutative reductions can be parallelized (#6609) Because parallelization changes the order of computation within the reduction, parallelizing associative but non-commutative reductions can result in (non-deterministically) incorrect results in the same way `reorder`ing them can. For instance Halide currently accepts the following code, but generates non-deterministic outputs on GPU. On CPU with `.parallel(r.x)`, OpenMP rejects the generated code (correctly) stating that the `#pragma omp atomic` is invalid for the same reasons. ```c++ #include <stdio.h> #include "Halide.h" using namespace Halide; int main(int argc, char **argv) { Halide::Func A("A"), B("B"); Halide::Var i("i"); A(i) = i; B() = -1; Halide::RDom r(0, 1024); B() = A(r.x); A.compute_root(); B.update().atomic().gpu_blocks(r.x); B.compile_jit(get_host_target().with_feature(Target::CUDA)); Halide::Buffer<int32_t> b = B.realize(); printf("%d\n", b()); return 0; } ``` 14 February 2022, 18:43:50 UTC
832efeb Steven Johnson 11 February 2022, 22:46:23 UTC Update WasmExecutor for WABT API changes (#6612) * Update WasmExecutor for WABT API changes The API for WABT has changed in top-of-tree. This fixes the incompatibilities. It also (temporarily) changes to pulling WABT from top-of-tree (rather than a known release) as the most recent labeled release doesn't have these changes. (We'll change back to a fixed WABT release when the next one is released.) * Update CMakeLists.txt 11 February 2022, 22:46:23 UTC
dd32beb Zalman Stern 11 February 2022, 15:53:50 UTC Fixes to support LLVM with opaque pointers. (#6608) Removes uses of LLVM API routines that recover pointed to types from LLVM pointer types as that functionality is going away with opaque pointers. 11 February 2022, 15:53:50 UTC
340f8f2 Andrew Adams 08 February 2022, 21:55:58 UTC Add comment 10 February 2022, 20:21:19 UTC
5993334 Andrew Adams 08 February 2022, 19:43:51 UTC Fix bug in mul_shift_right matching widening_mul handles mixed-signedness args, but mul_shift_right doesn't. We shouldn't map a mixed-signedness widening_mul to a mul_shift_right. 10 February 2022, 20:21:19 UTC
f28c07a Steven Johnson 02 February 2022, 21:52:02 UTC Allow building with LLVM15 (#6603) 02 February 2022, 21:52:02 UTC
1e7040c Steven Johnson 31 January 2022, 21:30:55 UTC Convert Buffer<> usage in python_bindings/ to use static dimensions (#6591) * Various fixes to static-dimensioned Buffer - Buffer needed to make some methods constexpr, and also had a broken return value for `as<>()` - Various templated methods needed to add `int Dims` as a parameter - Generator::add_input() and add_output() needed specializations for static-buffer types - sliced() and embedded() should use the default values for InClassDimStorage - halide_image_io should use a named constant * Convert Buffer<> usage in python_bindings/ to use static dimensions ...where it seems sensible to do so, that is. * Update Generator.h 31 January 2022, 21:30:55 UTC
b9a4cb3 Steven Johnson 31 January 2022, 21:30:40 UTC Convert Buffer<> usage in test/generators to use static dimensions (#6592) * Various fixes to static-dimensioned Buffer - Buffer needed to make some methods constexpr, and also had a broken return value for `as<>()` - Various templated methods needed to add `int Dims` as a parameter - Generator::add_input() and add_output() needed specializations for static-buffer types - sliced() and embedded() should use the default values for InClassDimStorage - halide_image_io should use a named constant * Convert Buffer<> usage in test/generators to use static dimensions ...where it seems sensible to do so, that is. (also test/integration since it's small) * Update Generator.h 31 January 2022, 21:30:40 UTC
d147a68 Steven Johnson 27 January 2022, 20:29:13 UTC Rename BufferDimsUnconstrained -> AnyDims (#6594) Existing name is kinda clunky, this seems terser and cleaner 27 January 2022, 20:29:13 UTC
d27866e Steven Johnson 27 January 2022, 17:46:12 UTC Various fixes to static-dimensioned Buffer (#6589) * Various fixes to static-dimensioned Buffer - Buffer needed to make some methods constexpr, and also had a broken return value for `as<>()` - Various templated methods needed to add `int Dims` as a parameter - Generator::add_input() and add_output() needed specializations for static-buffer types - sliced() and embedded() should use the default values for InClassDimStorage - halide_image_io should use a named constant * Update Generator.h 27 January 2022, 17:46:12 UTC
c450bf4 Michael Gharbi 27 January 2022, 17:27:13 UTC Fixes the Pytorch Wrapper Codegen for CPU-only machines. (#6590) * fixes pytorch op compilation for CPU only machines, adds default user context for auto-scheduled-ops * rm redundant declarations * fix spacing Co-authored-by: Michael Gharbi <mgharbi@adobe.com> 27 January 2022, 17:27:13 UTC
4e33ff4 Steven Johnson 26 January 2022, 23:14:29 UTC Convert apps/ to use static Buffer dims where useful (#6585) * wip * Update metadata_tester_generator.cpp * Update Generator.h * Update Generator.h * DynamicDims -> BufferDimsUnconstrained * Update fft_aot_test.cpp * Update HalideBuffer.h * Update HalideBuffer.h * Fix as<>(), default ctor in HalideBuffer.h - Allow as<> to optionally convert dimensionality as well - The default ctor shouldn't always assume Dims == 0 - make_static_shape_storage() can be more constrained * Add extra template arg to Buffer<>::as<> also * Realization::operator Buffer() needs to know about the extra template parameter too * halide_image_io.h needs some attention * Convert apps/ to use static Buffer dims where useful Convert most of the apps to use static Buffer dimensions where it makes sense. (This uncovered a few glitches in https://github.com/halide/Halide/pull/6574.) 26 January 2022, 23:14:29 UTC
892b558 Steven Johnson 26 January 2022, 21:42:34 UTC Expand optional static-typing for Buffer to include dimensionality (#6574) 26 January 2022, 21:42:34 UTC
91ad522 Steven Johnson 26 January 2022, 17:38:54 UTC Deprecate the Generator::build() method (#6580) * Deprecate the Generator::build() method 26 January 2022, 17:38:54 UTC
3e6d43b Alexander Root 26 January 2022, 17:14:58 UTC make bounds of let visitor use unique_name (#6583) 26 January 2022, 17:14:58 UTC
2008f7c Steven Johnson 25 January 2022, 22:08:50 UTC Fix Win32-specific breakage in top-of-tree LLVM (#6581) (Second attempt at this; first version was landed and rolled back because the LLVM change was rolled back) 25 January 2022, 22:08:50 UTC
5f0da26 Steven Johnson 25 January 2022, 20:47:48 UTC Add support for wasm-simd ops for integer-integer widening (#6567) * Add simd-extend support * Update simd_op_check.cpp * clang-format * Update CodeGen_WebAssembly.cpp 25 January 2022, 20:47:48 UTC
4030a55 Andrew Adams 25 January 2022, 20:21:56 UTC Rename Output to OutputFileType and deprecated Output (#6568) * Rename Output to OutputFile and deprecated Output It would be nice in future if we could promote Generator::Input and Generator::Output to the Halide namespace. For that to happen, we need to rename the enum Output first. This adds a new name for it, and deprecates the old name. * OutputFile -> OutputType Also fix python bindings and use the right deprecation macro * OutputType -> OutputFileType * clang-format * Update python tutorials and tests 25 January 2022, 20:21:56 UTC
eff874a Andrew Adams 20 January 2022, 16:41:42 UTC Remove incorrect not-multiple-of-16 claim 22 January 2022, 22:34:32 UTC
6a63609 Steven Johnson 21 January 2022, 23:20:41 UTC Allow calling scheduling methods on Output<Buffer[]> (#6577) The constness of the inherited operator[] meant you couldn't call scheduling methods on array-of-output-buffer in a Generator. Fixed and added a test case. 21 January 2022, 23:20:41 UTC
f1f5c53 Steven Johnson 21 January 2022, 22:08:43 UTC Fix for top-of-tree LLVM (#6579) 21 January 2022, 22:08:43 UTC
5fba150 Steven Johnson 20 January 2022, 18:04:36 UTC Add `explicit` to a handful of Generator-related ctors. (#6569) * Update Generator.h * Update generators using now-forbidden ctors 20 January 2022, 18:04:36 UTC
1d46a28 Steven Johnson 20 January 2022, 00:27:14 UTC Fix typo in comment in HalideBuffer.h (#6570) 20 January 2022, 00:27:14 UTC
030fe5a Steven Johnson 18 January 2022, 21:23:49 UTC wasm simd cleanup (#6566) - f64x2.convert_low_i32x4_s/u is handled properly by LLVM 14, so remove the TODO stuff and leave the test special-cased for that version (don't bother trying to make it work in LLVM13) - our `float_to_double` glue is only needed for LLVM13, so update comments and ifdefs appropriately 18 January 2022, 21:23:49 UTC
77de08c Masahiro Masuda 18 January 2022, 17:43:25 UTC [APP] Fix `hexagon_benchmarks` build (use two-var prefetch) (#6563) * Fix hexagon_benchmark build (use two-var prefetch) * tweak indent 18 January 2022, 17:43:25 UTC
cf4565b Steven Johnson 17 January 2022, 01:19:27 UTC Revert "Fix for top-of-tree LLVM (#6561)" (#6564) This reverts commit a86e13deb304ae9980f941eff6adf964b013ac60. 17 January 2022, 01:19:27 UTC
1aa68fb Steven Johnson 16 January 2022, 20:58:36 UTC Enable simd_op_check test for wasm i8x16.popcnt (#6562) LLVM does in fact generate this correctly, but only for 8x16 sized vectors 16 January 2022, 20:58:36 UTC
e581669 Andrew Adams 14 January 2022, 17:48:42 UTC Make HALIDE_REGISTER_GENERATOR work with multiple template args (#6556) * Make HALIDE_REGISTER_GENERATOR work with multiple template args * Add missing generator to cmakefile * Can't put parens around this usage * Another attempt at stripping parens from a type Co-authored-by: Steven Johnson <srj@google.com> 14 January 2022, 17:48:42 UTC
a86e13d Steven Johnson 13 January 2022, 23:34:30 UTC Fix for top-of-tree LLVM (#6561) * Fix for top-of-tree LLVM * Update LLVM_Runtime_Linker.cpp 13 January 2022, 23:34:30 UTC
b9e0e72 Steven Johnson 13 January 2022, 04:35:23 UTC Use add_halide_generator() everywhere in apps/ (#6554) * Use add_halide_generator() everywhere in apps/ Existing CMake code uses add_executable + target_link_libraries to create a Generator, but the somewhat-recently-added add_halide_generator() helper is a cleaner way to do this. Move to using it everywhere in apps/ instead. (Note that add_halide_generator()) doesn't yet work for in-tree builds, unfortunately.) * fixes * fully-qualify names * Update CMakeLists.txt * Fully Qualify * LINK_LIBRARIES * make add_halide_library() do some guessing * Update HalideGeneratorHelpers.cmake 13 January 2022, 04:35:23 UTC
b811f09 Steven Johnson 12 January 2022, 02:16:43 UTC Fix deprecation warnings in Python tutorials (#6552) 12 January 2022, 02:16:43 UTC
34cfde3 Steven Johnson 10 January 2022, 19:44:47 UTC Fixes for top-of-tree LLVM (#6546) (#6548) 10 January 2022, 19:44:47 UTC
bc5b557 Andrew Adams 09 January 2022, 02:55:57 UTC Better default lowering of absd (#6545) * Better default lowering of absd This produces 3 instructions on x86, whereas the previous version produced 5. * Switch to an x86-only solution * Fixes * Another fix. Add reference. * typo 09 January 2022, 02:55:57 UTC
4ec870d Dillon Sharlet 07 January 2022, 22:03:34 UTC Fix description of rounding_shift_left/rounding_shift_right (#6549) 07 January 2022, 22:03:34 UTC
b8a711a Andrew Adams 07 January 2022, 18:57:42 UTC Attempted redo of faster noise (#6539) * Make random 2x faster by putting the innermost var last * Improve period of low bits of random noise * Add new rewrite rules for quadratics By pulling constant additions outside of quadratics, we can shave off a few add instructions in the inner loop for random number generation, which uses a quadratic modulo 2^32 I also removed the !overflows predicates, because rules already fail to match if a fold overflows. New rules formally verified. * Make expensive_zero actually always zero * Partially revert new simplifier rules * Enable new rules * Revert test Co-authored-by: Steven Johnson <srj@google.com> 07 January 2022, 18:57:42 UTC
daa5b7c Steven Johnson 06 January 2022, 18:05:15 UTC Convert apps/hannk/Elementwise to use generate() (#6543) It's the only Generator in Halide that uses build() instead of generate() (aside from tests designed specifically to test build()); convert it to keep things nice and consistent. 06 January 2022, 18:05:15 UTC
6f7d5ce Steven Johnson 06 January 2022, 00:12:51 UTC Revert "Make it possible to interpret a wide type as multiple smaller elements (#6506)" (#6541) This reverts commit 1b180a8e93339aac2d19db57d2ef99b67253a0bc. 06 January 2022, 00:12:51 UTC
935c05e Steven Johnson 05 January 2022, 21:46:06 UTC Fix GeneratorOutput_Buffer::set_estimates() (#6540) The existing wrapper wouldn't work for Outputs that have Tuple-valued elemets. 05 January 2022, 21:46:06 UTC
95737be Alex Reinking 05 January 2022, 21:45:18 UTC Update CMake documentation (#6535) * Allow third parties to externally override SOVERSION Debian and other third-party packagers might need or want to patch our sources for a variety of reasons. In those cases, they might also need to override the SOVERSION. See here for a practical example: https://salsa.debian.org/pkg-llvm-team/halide/-/blob/f881de70cd83095053e13047b63f61faf6bc7a36/debian/patches/0006-Fixup-libhalide-version-soversion-for-debian-package.patch * Update CMake documentation. * Fix typo * Add link to ToC 05 January 2022, 21:45:18 UTC
7bb8198 Alex Reinking 05 January 2022, 21:44:36 UTC Allow third parties to externally override SOVERSION (#6534) Debian and other third-party packagers might need or want to patch our sources for a variety of reasons. In those cases, they might also need to override the SOVERSION. See here for a practical example: https://salsa.debian.org/pkg-llvm-team/halide/-/blob/f881de70cd83095053e13047b63f61faf6bc7a36/debian/patches/0006-Fixup-libhalide-version-soversion-for-debian-package.patch 05 January 2022, 21:44:36 UTC
f8459da Steven Johnson 05 January 2022, 19:10:34 UTC Remove unnecessary `std::move` calls (#6537) Compilers with `-Werror` will fail with `error: moving a temporary object prevents copy elision` 05 January 2022, 19:10:34 UTC
50edb64 Steven Johnson 05 January 2022, 19:10:03 UTC Revert "Make random faster by putting the innermost var last (#6504)" (#6538) This reverts commit 00211656fd208c5e6eb28f943dbbe8c65b45622f. 05 January 2022, 19:10:03 UTC
3a4e4c7 Infinoid 04 January 2022, 23:35:51 UTC If cmake built a python module, teach cmake to install the python module. (#6523) 04 January 2022, 23:35:51 UTC
b8eb22d Roman Lebedev 04 January 2022, 21:56:22 UTC Fix Python GIL lock handling (Fixes #6524, Fixes #5631) (#6525) * Fix Python GIL lock handling (Fixes #6524, Fixes #5631) As disscussed in https://github.com/halide/Halide/pull/6523#issuecomment-1003545664 and later in https://github.com/halide/Halide/issues/6524, pybind11 v2.8.1 added some defensive checks that fail for halide, namely in `python_tutorial_lesson_04_debugging_2` and `python_tutorial_lesson_05_scheduling_1`. https://github.com/halide/Halide/issues/6524#issuecomment-1003569810 notes: > * Python calls a Halide-JIT-generated function , which runs with the GIL held. > * Halide runtime spawns worker threads. > * The worker threads try to call pybind11's py::print function to emit traces. > * Pybind11 complains, correctly, that the worker thread doesn't hold the GIL. > > Trying to acquire the GIL hangs, because the main thread is still holding it. I tried teaching the main thread to release the GIL (as suggested in #5631), but I still saw hangs when I tried this. I have tried, and just dropping the lock before calling into halide, or just acquiring it in `halide_python_print` doesn't work, we need to do both. I have verified that the two tests fail without this fix, and pass with it. 04 January 2022, 21:56:22 UTC
bce2ef4 Roman Lebedev 04 January 2022, 21:06:29 UTC Install Python tutorials (#6530) * Install Python tutorials I know we have previously discussed that `TYPE DOC` should be used, but unfortunately i'm not sure that will work here, because doc/tutorial directory is already occupied by C++ tutorials, and i don't think they should be mixed. I'm open to alternative suggestions. 04 January 2022, 21:06:29 UTC
0021165 Andrew Adams 04 January 2022, 16:40:23 UTC Make random faster by putting the innermost var last (#6504) * Make random 2x faster by putting the innermost var last * Improve period of low bits of random noise * Add new rewrite rules for quadratics By pulling constant additions outside of quadratics, we can shave off a few add instructions in the inner loop for random number generation, which uses a quadratic modulo 2^32 I also removed the !overflows predicates, because rules already fail to match if a fold overflows. New rules formally verified. * Make expensive_zero actually always zero 04 January 2022, 16:40:23 UTC
f11d820 Roman Lebedev 04 January 2022, 16:34:58 UTC Implement SanitizerCoverage support (Refs. #6513) (#6517) * Implement SanitizerCoverage support (Refs. #6513) Please refer to https://clang.llvm.org/docs/SanitizerCoverage.html TLDR: `ModuleSanitizerCoveragePass` instruments the IR by inserting calls to callbacks at certain constructs. What the callbacks should do is up to the implementation. They are effectively required for fuzzing to be effective, and are provided by e.g. libfuzzer. One huge caveat is `SanitizerCoverageOptions` which controls which which callbacks should actually be inserted. I just don't know what to do about it. Right now i have hardcoded the set that would have been enabled by `-fsanitize=fuzzer-no-link`, because the alternative, due to halide unflexibility, would be to introduce ~16 suboptions to control each one. * Simplify test * sancov test: avoid potential signedness warnings. * Rename all instances of sancov to sanitizecoverage * Adjust spelling of "SanitizerCoverage" in some places * Actually adjust the feature name in build system for the test * Hopefully fix Makefile build Co-authored-by: Steven Johnson <srj@google.com> 04 January 2022, 16:34:58 UTC
7eb9949 Roman Lebedev 04 January 2022, 16:32:52 UTC [NFC-ish] Finish MSAN handling (#6516) Somehow, initially i missed that there was MSan support, so it might be good to actually mention that we don't need to run any MSan passes here, and that we didn't forget to run them. Secondly, it seems inconsistent not annotate the functions with `Attribute::SanitizeMemory`, like we do for others. I suppose it isn't strictly required, since they are used to actually drive the instrumentation passes, and we don't run MSan pass, but they are also used to disable some LLVM optimizations, and that //might// be important. Or not, but then i suppose there should be a comment about it? Co-authored-by: Steven Johnson <srj@google.com> 04 January 2022, 16:32:52 UTC
5c33902 Andrew Adams 04 January 2022, 16:08:43 UTC free shape storage last (#6511) Some decref-triggered runtime methods need the shape Fixes #6509 Co-authored-by: Steven Johnson <srj@google.com> 04 January 2022, 16:08:43 UTC
0089de9 Andrew Adams 04 January 2022, 16:08:28 UTC Handle mixed-width args to mul-shift-right (#6526) and codegen it to pmulhuw on x86 Co-authored-by: Steven Johnson <srj@google.com> 04 January 2022, 16:08:28 UTC
1b180a8 Andrew Adams 03 January 2022, 23:04:31 UTC Make it possible to interpret a wide type as multiple smaller elements (#6506) * Make it possible to interpret a wide type as multiple smaller elements This is helpful for things like reinterpreting 32-bit packed rgba values as individual components for free. * clang-format 03 January 2022, 23:04:31 UTC
f9ea2d4 Steven Johnson 03 January 2022, 22:12:35 UTC Fix use-after-free bug in SlidingWindow.cpp (#6527) 03 January 2022, 22:12:35 UTC
2651402 Steven Johnson 03 January 2022, 20:45:32 UTC Fix simd-op-check for top-of-tree LLVM (#6529) * Fix simd-op-check for top-of-tree LLVM * Update simd_op_check.cpp 03 January 2022, 20:45:32 UTC
9a530b1 Roman Lebedev 29 December 2021, 22:58:10 UTC Fix weird CMake issue with custom LLVM (#6519) Without this, cmake fails with: ``` CMake Error in dependencies/llvm/CMakeLists.txt: Target "Halide_LLVM" INTERFACE_INCLUDE_DIRECTORIES property contains path: "/repositories/halide/dependencies/llvm/" which is prefixed in the source directory. ``` `LLVM_INCLUDE_DIRS` there is `/repositories/llvm-project/llvm/include;/builddirs/llvm-project/build-Clang13/include`, and `INTERFACE_INCLUDE_DIRECTORIES`'s property beforehand is `` (empty), but after this line it suddenly becomes `/repositories/halide/dependencies/llvm/$<BUILD_INTERFACE:/repositories/llvm-project/llvm/include;/builddirs/llvm-project/build-Clang13/include>`. This is quite obscure. I don't really understand what is going on, but with the patch it builds fine. 29 December 2021, 22:58:10 UTC
6ed65ba Roman Lebedev 29 December 2021, 22:57:41 UTC Mullapudi2016: don't hardcode the list of supported targets (#6520) As discussed in https://github.com/halide/Halide/issues/6518, this is a bit dubious, and e.g. prevents building on RISC-V, because there is no way to not build autoschedulers currently. 29 December 2021, 22:57:41 UTC
1d1f06a Jin Yue 23 December 2021, 15:02:14 UTC Support new warp shuffle intrinsics after CUDA Volta architecture (#6505) * warp shuffle for volta. * Add a warp shuffle test. * Remove TODO because we have HoistWarpShuffles. * Fix test case position. * Pass target to lower_warp_shuffles. * format Co-authored-by: jinyue.jy <jinyue.jy@alibaba-inc.com> 23 December 2021, 15:02:14 UTC
e7f655b Andrew Adams 22 December 2021, 02:41:03 UTC Fix a missing case in clamp_unsafe_accesses (#6508) * Fix a missing case in clamp_unsafe_accesses * Don't check func_value_bounds of images 22 December 2021, 02:41:03 UTC
b0f4681 Roman Lebedev 19 December 2021, 00:59:16 UTC Try to fix riscv64 build (#6503) https://buildd.debian.org/status/fetch.php?pkg=halide&arch=riscv64&ver=13.0.2-1&stamp=1639833165&raw=0 ``` [1283/3260] /usr/bin/clang++-13 -DHALIDE_ENABLE_RTTI -DHALIDE_WITH_EXCEPTIONS -DHalide_EXPORTS -DLLVM_VERSION=130 -DWITH_AARCH64 -DWITH_AMDGPU -DWITH_ARM -DWITH_D3D12 -DWITH_HEXAGON -DWITH_INTROSPECTION -DWITH_METAL -DWITH_MIPS -DWITH_NVPTX -DWITH_OPENCL -DWITH_OPENGLCOMPUTE -DWITH_POWERPC -DWITH_RISCV -DWITH_WEBASSEMBLY -DWITH_X86 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-13/include -g -O3 -DNDEBUG -fPIC -Wall -Wcast-qual -Wignored-qualifiers -Woverloaded-virtual -Winconsistent-missing-destructor-override -Winconsistent-missing-override -Wno-deprecated-declarations -Wno-double-promotion -Wno-float-conversion -Wno-float-equal -Wno-missing-field-initializers -Wno-old-style-cast -Wno-shadow -Wno-sign-conversion -Wno-switch-enum -Wno-undef -Wno-unused-function -Wno-unused-macros -Wno-unused-parameter -Wno-c++98-compat-pedantic -Wno-c++98-compat -Wno-cast-align -Wno-comma -Wno-covered-switch-default -Wno-documentation-unknown-command -Wno-documentation -Wno-exit-time-destructors -Wno-global-constructors -Wno-implicit-float-conversion -Wno-implicit-int-conversion -Wno-implicit-int-float-conversion -Wno-missing-prototypes -Wno-nonportable-system-include-path -Wno-reserved-id-macro -Wno-return-std-move-in-c++11 -Wno-shadow-field-in-constructor -Wno-shadow-field -Wno-shorten-64-to-32 -Wno-undefined-func-template -Wno-unused-member-function -Wno-unused-template -pthread -std=c++17 -MD -MT src/CMakeFiles/Halide.dir/Target.cpp.o -MF src/CMakeFiles/Halide.dir/Target.cpp.o.d -o src/CMakeFiles/Halide.dir/Target.cpp.o -c /<<PKGBUILDDIR>>/src/Target.cpp FAILED: src/CMakeFiles/Halide.dir/Target.cpp.o /usr/bin/clang++-13 -DHALIDE_ENABLE_RTTI -DHALIDE_WITH_EXCEPTIONS -DHalide_EXPORTS -DLLVM_VERSION=130 -DWITH_AARCH64 -DWITH_AMDGPU -DWITH_ARM -DWITH_D3D12 -DWITH_HEXAGON -DWITH_INTROSPECTION -DWITH_METAL -DWITH_MIPS -DWITH_NVPTX -DWITH_OPENCL -DWITH_OPENGLCOMPUTE -DWITH_POWERPC -DWITH_RISCV -DWITH_WEBASSEMBLY -DWITH_X86 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-13/include -g -O3 -DNDEBUG -fPIC -Wall -Wcast-qual -Wignored-qualifiers -Woverloaded-virtual -Winconsistent-missing-destructor-override -Winconsistent-missing-override -Wno-deprecated-declarations -Wno-double-promotion -Wno-float-conversion -Wno-float-equal -Wno-missing-field-initializers -Wno-old-style-cast -Wno-shadow -Wno-sign-conversion -Wno-switch-enum -Wno-undef -Wno-unused-function -Wno-unused-macros -Wno-unused-parameter -Wno-c++98-compat-pedantic -Wno-c++98-compat -Wno-cast-align -Wno-comma -Wno-covered-switch-default -Wno-documentation-unknown-command -Wno-documentation -Wno-exit-time-destructors -Wno-global-constructors -Wno-implicit-float-conversion -Wno-implicit-int-conversion -Wno-implicit-int-float-conversion -Wno-missing-prototypes -Wno-nonportable-system-include-path -Wno-reserved-id-macro -Wno-return-std-move-in-c++11 -Wno-shadow-field-in-constructor -Wno-shadow-field -Wno-shorten-64-to-32 -Wno-undefined-func-template -Wno-unused-member-function -Wno-unused-template -pthread -std=c++17 -MD -MT src/CMakeFiles/Halide.dir/Target.cpp.o -MF src/CMakeFiles/Halide.dir/Target.cpp.o.d -o src/CMakeFiles/Halide.dir/Target.cpp.o -c /<<PKGBUILDDIR>>/src/Target.cpp warning: unknown warning option '-Wno-return-std-move-in-c++11' [-Wunknown-warning-option] /<<PKGBUILDDIR>>/src/Target.cpp:114:5: error: use of undeclared identifier 'cpuid' cpuid(info, 1, 0); ^ /<<PKGBUILDDIR>>/src/Target.cpp:148:9: error: use of undeclared identifier 'cpuid' cpuid(info2, 7, 0); ^ /<<PKGBUILDDIR>>/src/Target.cpp:181:17: error: use of undeclared identifier 'cpuid' cpuid(info3, 7, 1); ^ 1 warning and 3 errors generated. ``` ... which doesn't make sense because that code is supposed to only compile for X86. But that is because RISCV header guard is wrong, https://github.com/riscv-non-isa/riscv-toolchain-conventions says: ``` C/C++ preprocessor definitions * __riscv: defined for any RISC-V target. Older versions of the GCC toolchain defined __riscv__. ``` 19 December 2021, 00:59:16 UTC
1d86751 Steven Johnson 16 December 2021, 19:30:06 UTC Grab Bag of minor cleanups to LowerParallelTasks (#6498) * Grab Bag of minor cleanups to LowerParallelTasks Basically OCD code stuff I noted down when debugging the issues, this restructures the inner loop to avoid calling a local function that has non-obvious side effects (setting just the right slot in the closure args), as well as consolidating via helper functions, hoisting common stuff used in both paths, using std::move where seemingly appropriate, adding some (hopefully correct) comments about arg expectations, and other things that aren't likely to really move the needle in terms of Halide compile speed, but (hopefully) make the code a little bit more understandable after some time away. (There was a todo about "find a better place for generate_closure_ir()"; this PR eliminates it entirely, just inlining it into the caller, which I think is reasonable given thhe number of assumptions the caller has to make in the first place...) * Update LowerParallelTasks.cpp 16 December 2021, 19:30:06 UTC
dffae98 Steven Johnson 16 December 2021, 01:24:59 UTC Update simd_op_check for arm64 upz1 code generation (#6499) (#6500) 16 December 2021, 01:24:59 UTC
084236c Steven Johnson 16 December 2021, 01:24:33 UTC Fix size_t -> int conversion warning (#6501) 16 December 2021, 01:24:33 UTC
45e1809 Steven Johnson 15 December 2021, 20:41:39 UTC Update WABT to 1.0.25 (#6497) * Update WABT to 1.0.25 (cannot land until https://github.com/WebAssembly/wabt/pull/1788 lands) * tickle buildbots 15 December 2021, 20:41:39 UTC
c3ff4d2 Steven Johnson 14 December 2021, 00:32:31 UTC Restore support for using V8 as the Wasm JIT interpreter (#6478) * Support using V8 as the Wasm JIT interpreter This is a partial revert of https://github.com/halide/Halide/pull/5097. It brings back a bunch of the code in WasmExecutor to set up and use V8 to run Wasm code. All of the code is copy-pasted. There are some small cleanups to move common code (like BDMalloc, structs, asserts) to a common area guarded by `if WITH_WABT || WITH_V8`. Enabling V8 requires setting 2 CMake options: - V8_INCLUDE_PATH - V8_LIB_PATH The first is a path to v8 include folder, to find headers, the second is the monolithic v8 library. This is because it's pretty difficult to build v8, and there are various flags you can set. Comments around those options provide some instructions for building v8. By default, we still use the wabt for running Wasm code, but we can use V8 by setting WITH_WABT=OFF WITH_V8=ON. Maybe in the future, with more testing, we can flip this. Right now this requires a locally patched build of V8 due to https://crbug.com/v8/10461, but once that is resolved, the version of V8 that includes the fix will be fine. Also enable a single test, block_transpose, to run on V8, with these results: $ HL_JIT_TARGET=wasm-32-wasmrt-wasm_simd128 \ ./test/performance/performance_block_transpose Dummy Func version: Scalar transpose bandwidth 3.45061e+08 byte/s. Wrapper version: Scalar transpose bandwidth 3.38931e+08 byte/s. Dummy Func version: Transpose vectorized in y bandwidth 6.74143e+08 byte/s. Wrapper version: Transpose vectorized in y bandwidth 3.54331e+08 byte/s. Dummy Func version: Transpose vectorized in x bandwidth 3.50053e+08 byte/s. Wrapper version: Transpose vectorized in x bandwidth 6.73421e+08 byte/s. Success! For comparison, when targeting host: $ ./test/performance/performance_block_transpose Dummy Func version: Scalar transpose bandwidth 1.33689e+09 byte/s. Wrapper version: Scalar transpose bandwidth 1.33583e+09 byte/s. Dummy Func version: Transpose vectorized in y bandwidth 2.20278e+09 byte/s. Wrapper version: Transpose vectorized in y bandwidth 1.45959e+09 byte/s. Dummy Func version: Transpose vectorized in x bandwidth 1.45921e+09 byte/s. Wrapper version: Transpose vectorized in x bandwidth 2.21746e+09 byte/s. Success! For comparison, running with wabt: Dummy Func version: Scalar transpose bandwidth 828715 byte/s. Wrapper version: Scalar transpose bandwidth 826204 byte/s. Dummy Func version: Transpose vectorized in y bandwidth 1.12008e+06 byte/s. Wrapper version: Transpose vectorized in y bandwidth 874958 byte/s. Dummy Func version: Transpose vectorized in x bandwidth 879031 byte/s. Wrapper version: Transpose vectorized in x bandwidth 1.10525e+06 byte/s. Success! * Add instructions to build V8 * Formatting * More documentation * Update README_webassembly.md * Update README_webassembly.md * Update WasmExecutor.cpp * Update WasmExecutor.cpp * Skip tests * Update WasmExecutor.cpp * Skip performance tests * Update WasmExecutor.cpp * Address review comments * 9.8.147 -> 9.8.177 Co-authored-by: Ng Zhi An <zhin@google.com> 14 December 2021, 00:32:31 UTC
46d8ca8 Zalman Stern 14 December 2021, 00:31:45 UTC Move parallel/async lowering from LLVM codegen to a standard Halide IR lowering pass. (#6195) * First cut at factoring parallel task compilation, including closure generating and calling, into a normal IR to IR lowering pass. Includes adding struct handling intrinsics to LLVM and C++ backends. Still a work in progress. * Fix formating that got munged by emacs somehow. * Checkpoint progress. * Small fixes. * Checkpoint progress. * Checkpoint preogress. * Checkpoint progress. * Checkpoint progress. Debugging code will be removed. * Try a fix for make_typed_struct in C++ codegen. * Another attempt to fix C++ codegen. * Another C codegen fix. * Checkpoint progress. * Use make_typed_struct rather than make_struct to construct closure. Ensure all types are carried through exactly the same to both make_struct_type and make_typed_struct. * Checkpoint. * Uniqueify closure names because LLVM was doing that to function names. * Small formatting cleanups. Fixes to call graph checker. Disable tests related to this while Andrew and I figure out how to get it to work across closures. * Get generated C++ to compile via a combination of fixing types and bludgeoning types into submission via subterfuge. * Typo fix to a typo fix. * Restore inadvertently deleted code. * Rename make_struct_type to declare_struct_type. * Add new file to CMake. * Add fixes for Hexagon offload and any passes that might add additional LoweredFunctions in the future. * Add comment with a bit of info for the future.. * Typo fix. * Don't duplicate the closure call to test the error return. Don't declare halide_buffer_t type if there are no buffers in closure. * Use _ucon in C++ code to get rid of constness casting ugliness. * Change resolve_function_name intrinsic to use a Call node to designate the function. This makes generating the C++ declaration in the C++ backend trivial. Few more changes to type handling and naming. * Small C++ backend output formating change. Don't generate For loops with no variable. Update internal test for C++ output. * Add halide_semaphore_acquire_t as a well known type for use inside compiler. * Add handling for halide_semaphore_t allocation. Formating fixes. * Fix type for halide_semaphore_t. * Reapply C++ backend formatting fix. * Add support for calling legacy halide_do_par_for runtime routine in cases where it is valid. * Formatting fixes. * Format and tidy fixes. * Attempt to pass formatting check. * Fix last set of test failures. * Formatting whitespace fixes. * Update comments. * Attempt to fix pointer cast error with some versions of LLVM. * Another attempt at fixing bool compatibility casting. * Another iteration. * Remove likely useless extern argument check logic. * Add hacky fix for losing global variables. * Comment typo fixes. * Remove no-longer-used Closure code from Codegen_Internal * Remove unused MayBlock visitor class * clang-tidy * Attempt to fix parallel offloads for HVX * Update parallel_nested_1.cpp * Augment Closure debugging * Add some std::move usage * Fix hvx lock/unlock semantics for PR #6457 (#6462) Fix qurt_hvx_lock issues * Sort IntrinsicOp and corresponding names * Remove unused `is_const_pointer()` function * Minor hygiene in LowerParallelTasks - normalize local functions to snake_case - put all local functions & classes in anon namespace - move MinThreads visitor to file scope to reduce nestedness of code * use Closure::include * Switch to PureIntrinsics per review feedback. * Minor cleanup of parallel refactor intrinsics (#6465) * Minor cleanup of parallel refactor intrinsics - Renamed `load_struct_member` to `load_typed_struct_member` to make it more clear that it is intended for use only with the results of `make_typed_struct`. - Split `declare_struct_type` into two intrinsics, `define_typed_struct` and `forward_declare_typed_struct`, removing the need for the underdocumented `mode` argument and hopefully making usage clearer - Added / clarified comments for the intrinsics modified above * Update comments * Fix comments * Update CodeGen_C.cpp * Remove 'foo.buffer' from Closure entirely This is a direct adaptation of what #6481 does for the old LLVM-based code, and allows elimination of one use of `get_pointer_or_null()`. PR is meant to be merged into factor_parallel_codegen, not master. * Update LowerParallelTasks.cpp * Keep track of task_parent inside LowerParallelTasks; remove no-longer-needed get_pointer_or_symbol() intrinsic (#6486) * Fix potential issue with additional LoweredFuncs (#6490) I think this is the right fix for this case; that said, I can't find a single instance in any of our test cases that actually triggers this. * factor parallel codegen with fewer intrinsics (#6487) * Rework some of parallel closure lowering to avoid some intrinsics This version relies more heavily on the existing make_struct, and puts function names in the Variable namespace as globals. Co-authored-by: Steven Johnson <srj@google.com> Co-authored-by: dsharletg <dsharlet@google.com> Co-authored-by: Steven Johnson <srj@google.com> Co-authored-by: Andrew Adams <andrew.b.adams@gmail.com> 14 December 2021, 00:31:45 UTC
e23b6f0 Andrew Adams 13 December 2021, 20:00:52 UTC rounding shift rights should use rounding halving add (#6494) * rounding shift rights should use rounding halving add On x86 currently we lower cast<uint8_t>((cast<uint16_t>(x) + 8) / 16) to: cast<uint8_t>(shift_right(widening_add(x, 8), 4)) This compiles to 8 instructions on x86: Widen each half of the input vector, add 8 to each half-vector, shift each half-vector, then narrow each half-vector. First, this should have been a rounding_shift_right. Some patterns were missing in FindIntrinsics. Second, rounding_shift_right had suboptimal codegen in the case where the second arg is a positive const. On archs without a rounding shift right instruction you can further rewrite this to: shift_right(rounding_halving_add(x, 7), 3) which is just two instructions on x86. 13 December 2021, 20:00:52 UTC
11448b2 Steven Johnson 10 December 2021, 19:31:01 UTC Document the usage of llvm::legacy::PassManager (#6491) * Document the usage of llvm::legacy::PassManager There is some confusion about whether this usage is acceptable. TL;DR: it's not just acceptable, it's required for the forseeable future. Add comments to capture this to avoid future such questions. (With great thanks to Alina for pointing me at the relevant LLVM discussion links!) * Add date 10 December 2021, 19:31:01 UTC
7fe1e2c Andrew Adams 10 December 2021, 15:06:30 UTC Let lerp lowering incorporate a final cast. (#6480) * Let lerp lowering incorporate a final cast This lets it save a few instructions on x86 and arm. cast(UInt(16), lerp(some_u8s)) produces the following, before and after this PR Before: x86: vmovdqu (%r15,%r13), %xmm4 vpmovzxbw -2(%r15,%r13), %ymm5 vpxor %xmm0, %xmm4, %xmm6 vpmovzxbw %xmm6, %ymm6 vpmovzxbw -1(%r15,%r13), %ymm7 vpmullw %ymm6, %ymm5, %ymm5 vpmovzxbw %xmm4, %ymm4 vpmullw %ymm4, %ymm7, %ymm4 vpaddw %ymm4, %ymm5, %ymm4 vpaddw %ymm1, %ymm4, %ymm4 vpmulhuw %ymm2, %ymm4, %ymm4 vpsrlw $7, %ymm4, %ymm4 vpand %ymm3, %ymm4, %ymm4 vmovdqu %ymm4, (%rbx,%r13,2) addq $16, %r13 decq %r10 jne .LBB0_10 arm: ldr q0, [x17] ldur q2, [x17, #-1] ldur q1, [x17, #-2] subs x0, x0, #1 // =1 mvn v3.16b, v0.16b umull v4.8h, v2.8b, v0.8b umull2 v0.8h, v2.16b, v0.16b umlal v4.8h, v1.8b, v3.8b umlal2 v0.8h, v1.16b, v3.16b urshr v1.8h, v4.8h, #8 urshr v2.8h, v0.8h, #8 raddhn v1.8b, v1.8h, v4.8h raddhn v0.8b, v2.8h, v0.8h ushll v0.8h, v0.8b, #0 ushll v1.8h, v1.8b, #0 add x17, x17, #16 // =16 stp q1, q0, [x18, #-16] add x18, x18, #32 // =32 b.ne .LBB0_10 After: x86: vpmovzxbw -2(%r15,%r13), %ymm3 vmovdqu (%r15,%r13), %xmm4 vpxor %xmm0, %xmm4, %xmm5 vpmovzxbw %xmm5, %ymm5 vpmullw %ymm5, %ymm3, %ymm3 vpmovzxbw -1(%r15,%r13), %ymm5 vpmovzxbw %xmm4, %ymm4 vpmullw %ymm4, %ymm5, %ymm4 vpaddw %ymm4, %ymm3, %ymm3 vpaddw %ymm1, %ymm3, %ymm3 vpmulhuw %ymm2, %ymm3, %ymm3 vpsrlw $7, %ymm3, %ymm3 vmovdqu %ymm3, (%rbp,%r13,2) addq $16, %r13 decq %r10 jne .LBB0_10 arm: ldr q0, [x17] ldur q2, [x17, #-1] ldur q1, [x17, #-2] subs x0, x0, #1 // =1 mvn v3.16b, v0.16b umull v4.8h, v2.8b, v0.8b umull2 v0.8h, v2.16b, v0.16b umlal v4.8h, v1.8b, v3.8b umlal2 v0.8h, v1.16b, v3.16b ursra v4.8h, v4.8h, #8 ursra v0.8h, v0.8h, #8 urshr v1.8h, v4.8h, #8 urshr v0.8h, v0.8h, #8 add x17, x17, #16 // =16 stp q1, q0, [x18, #-16] add x18, x18, #32 // =32 b.ne .LBB0_10 So on X86 we skip a pointless and instruction, and on ARM we get a rounding add and shift right instead of a rounding narrowing add shift right followed by a widen. * Add test * Fix bug in test * Don't produce out-of-range lerp values 10 December 2021, 15:06:30 UTC
bcfd6af Steven Johnson 09 December 2021, 23:06:05 UTC Fail if no_bounds_query specified for HL_JIT_TARGET (#6489) * Fail if no_bounds_query specified for HL_JIT_TARGET JIT requires the use of bounds_query; disabling it will almost certainly fail in JIT mode, either with a confusing assert message, or a crash (if you also specify no_asserts). This adds a more useful failure message. * Update Target.cpp 09 December 2021, 23:06:05 UTC
59118de Steven Johnson 08 December 2021, 22:12:53 UTC Deal with Printer::scratch (#6469) (#6472) Instead of trying to optimize every Printer instance to use stack (and failing), move the StackPrinter concept into printer.h directly and require opt-in at the point of compilation to use stack instead of malloc. This PR also does a few other drive-by cleanups: - Ensures that all Printer ctors are explicit - Makes some template aliases to make using (e.g.) ErrorPrinter with a custom buffer size slightly cleaner syntax - Have tracing use the `.str()` method, which already deals with MSAN internally - Make all the Printer data members private - Fix some evil code in opencl.cpp that previously used the now-private data members 08 December 2021, 22:12:53 UTC
d089588 Steven Johnson 06 December 2021, 17:02:21 UTC Move null check from Printer to halide_string_to_string() The Printer is (currently) usually inlined into every module, so this check is repeated in multiple chunks of code. Since the goal is to avoid crashing when debugging, let's move it to halide_string_to_string() (which will catch all these, and possibly more) and save some code size. (Further improvements in Printer code size on the way; this change seems worthy of considering separately.) 08 December 2021, 19:11:28 UTC
7199e7d Andrew Adams 08 December 2021, 01:45:10 UTC Try removing optional buffer added to closure 08 December 2021, 18:53:35 UTC
7992369 Andrew Adams 07 December 2021, 16:16:50 UTC Add a fast integer divide that rounds to zero (#6455) * Add a version of fast_integer_divide that rounds towards zero * clang-format * Fix test condition * Clean up debugging code * Add explanatory comment to performance test * Pacify clang tidy 07 December 2021, 16:16:50 UTC
fb305fd Roman Lebedev 07 December 2021, 02:15:18 UTC `apps/linear_algebra/benchmarks/macros.h`: don't forget SSE guard (#6471) This is breaking i386 build: https://buildd.debian.org/status/fetch.php?pkg=halide&arch=i386&ver=13.0.1-3&stamp=1638786518&raw=0 07 December 2021, 02:15:18 UTC
e0df687 Marcos Slomp 06 December 2021, 20:34:44 UTC decommissioning StackPrinter (#6470) 06 December 2021, 20:34:44 UTC
392430d Steven Johnson 02 December 2021, 21:23:25 UTC Fix Closure API (#6464) The current API requires calling a Visitor from the Closure ctor, which means we implicitly call virtual methods from the class ctor, which is a no-no for a non-final class (see comments on https://github.com/halide/Halide/pull/6443). 02 December 2021, 21:23:25 UTC
0ed461b Steven Johnson 02 December 2021, 18:38:50 UTC Add operator<< for Closure (#6443) * Add operator<< for Closure Moves the ad-hoc implementation our of HostClosure::arguments() for easier debugging usage. Also, drive-by elimination of the body of HostClosure ctor, which was identical to the one inherited from Closure. * Update DeviceArgument.cpp * Add explanatory comment 02 December 2021, 18:38:50 UTC
5cf9ae5 Andrew Adams 02 December 2021, 15:04:43 UTC Reduce overhead of sampling profiler by having only one thread do it (#6433) * Reduce overhead of sampling profiler by having only one thread do it * Use const ref * One line per member 02 December 2021, 15:04:43 UTC
479d839 Steven Johnson 02 December 2021, 03:42:04 UTC Add LinkageType::ExternalPlusArgv (#6452) (#6463) Allows us to skip generating metadata for offloaded hexagon funcs, which will never use it. 02 December 2021, 03:42:04 UTC
4877d26 Steven Johnson 01 December 2021, 19:22:00 UTC Tweak Hexagon codegen output to match the pattern in Lower.cpp more accurately (for level 1 vs 2); also prefix the outputs so they are easier to read as Hexagon-specific when debugging (#6461) 01 December 2021, 19:22:00 UTC
back to top