Skip to main content

Browse the archive

https://github.com/halide/Halide
19 April 2024, 08:20:39 UTC
sort by:
Revision Author Date Message Commit Date
6fd452f Steven Johnson 13 January 2023, 23:45:53 UTC (V2) Unify user_context name-and-type everywhere For reasons that aren't clear, we sometimes emitted user_context as `void*` or `Handle()` (most places), but sometimes as `const void *` (Codegen_C). This attempts to unify it to be `const void *` for all user-generated code, to avoid the need for const-cast and also void possibilities of c++ name-mangling linker mismatches in some obscure cases. 13 January 2023, 23:45:53 UTC
0d43318 Steven Johnson 10 January 2023, 19:23:58 UTC Optimize Module::compile() for some edge cases (#7269) * Optimize Module::compile() for some edge cases Avoid redundant `compile_to_buffer()` calls for output requests that can't possibly ever need them. * Avoid mutation 10 January 2023, 19:23:58 UTC
a8d88bb Steven Johnson 10 January 2023, 17:51:38 UTC Use ::aligned_alloc() instead of std::aligned_alloc() in HalideBuffer.h (#7268) 10 January 2023, 17:51:38 UTC
eea7696 Steven Johnson 09 January 2023, 17:58:04 UTC Update README_python.md (#7266) 09 January 2023, 17:58:04 UTC
c070bb8 Alina Sbirlea 06 January 2023, 00:00:34 UTC Update change following LLVM WASM change f841ad30d77eeb4c51663e68efefdb734c7a3d07 (#7264) * Update change following LLVM WASM change https://github.com/llvm/llvm-project/commit/f841ad30d77eeb4c51663e68efefdb734c7a3d07 * Update checks conditional on LLVM version. 06 January 2023, 00:00:34 UTC
4b74049 Andrew Adams 05 January 2023, 21:12:50 UTC Inline into extern function args during bounds inference (#7261) * Inline into extern function args during bounds inference Fixes #7260 * Run CSE once at the end * Actually recursively inline * clang-tidy * trigger buildbots * Make test invariant to the number of times the warning is printed as long as it's at least once Co-authored-by: Steven Johnson <srj@google.com> 05 January 2023, 21:12:50 UTC
04bb986 Steven Johnson 28 December 2022, 17:31:01 UTC Conditional allocations shouldn't fail for size=0 in C++ backend (#7255) (#7256) * Conditional allocations shouldn't fail for size=0 in C++ backend (#7255) Allocations can be conditional; if the condition evaluates to false, we end up calling `halide_malloc(0)` (or `halide_tcm_malloc(0)` in the xtensa branch). Since it's legal via spec for `malloc(0)` to return nullptr, we need to be cautious here: if we are compiling with assertions enabled, *and* have a malloc() (etc) implementation that returns nullptr for alloc(0), we need to skip the assertion check, since we know the result won't be used. Note: a similar check will be inserted in the xtensa branch separately. Note 2: LLVM backend already has this check via Codegen_Posix.cpp * Update CodeGen_C.cpp 28 December 2022, 17:31:01 UTC
ade8b56 Steven Johnson 20 December 2022, 20:05:19 UTC Remove deprecated halide_target_feature_disable_llvm_loop_opt (#7247) * Remove deprecated halide_target_feature_disable_llvm_loop_opt Was deprecated in Halide 15; let's remove in Halide 16 * trigger buildbots * trigger buildbots * Update CodeGen_LLVM.cpp 20 December 2022, 20:05:19 UTC
10345d4 Andrew Adams 16 December 2022, 17:56:08 UTC Explicitly stage strided loads (#7230) * Add a pass to do explicit densification of strided loads * densify more types of strided load * Reorder downsample in local laplacian for slightly better performance * Move allocation padding into the IR. Still WIP. * Simplify concat_bits handling * Use evidence from parent scopes to densify * Disallow padding allocations with custom new expressions * Add test for parent scopes * Remove debugging prints. Avoid nested ramps. * Avoid parent scope loops * Update cmakefiles * Fix for large_buffers * Pad stack allocations too * Restore vld2/3/4 generation on non-Apple ARM chips * Appease clang-format and clang-tidy * Silence clang-tidy * Better comments * Comment improvements * Nuke code that reads out of bounds * Fix stage_strided_loads test * Change strategy for loads from external buffers Some backends don't like non-power-of-two vectors. Do two overlapping half-sized loads and shuffle instead of one funny-sized load. * Add explanatory comment to ARM backend * Fix cpp backend shuffling * Fix missing msan annotations * Magnify heap cost effect in stack_vs_heap performance test * Address review comments * clang-tidy * Fix for when same load node occurs in two different allocate nodes 16 December 2022, 17:56:08 UTC
382f813 Steven Johnson 16 December 2022, 17:54:21 UTC Fix "may be used uninitialized" warnings in Codegen_C::print_scalarized_expr() (#7244) 16 December 2022, 17:54:21 UTC
da6746e Steven Johnson 14 December 2022, 05:29:45 UTC correctness/exception.cpp needs to check HALIDE_WITH_EXCEPTIONS (fixes #7240) (#7241) correctness/exception.cpp needs to check HALIDE_WITH_EXCEPTIONS 14 December 2022, 05:29:45 UTC
1a4a469 Andrew Adams 13 December 2022, 16:11:54 UTC Fix some sources of signed integer overflow in the compiler (#7231) * Fix some sources of signed integer overflow in the compiler Also, use compiler intrinsics when possible to handle overflow, as it generates faster code. * Fix msvc macro * Must use result * Actually perform the requested operation 13 December 2022, 16:11:54 UTC
533e6e5 Steven Johnson 12 December 2022, 20:54:46 UTC Remove rogue string suffix in simd_op_check_arm.cpp (#7227) * Remove rogue string suffix in simd_op_check_arm.cpp Interestingly, it compiles here, but in some compilers it will fail with "unexpected token". * Update simd_op_check_arm.cpp 12 December 2022, 20:54:46 UTC
6ecdcbd Steven Johnson 11 December 2022, 18:05:55 UTC Tighten alignment promises for halide_malloc() (#7222) This makes a couple of changes to the behavior/implementation of `halide_malloc()`: * Currently, halide_malloc must return a pointer aligned to the maximum meaningful alignment for the platform for the purpose of vector loads and stores. This PR also adds the requirement that the memory returned must be legal to access in an integral multple of alignment >= the requested size (in other words: you should be able to do vector load/stores "off the end" without causing any faults). * Currently, the `halide_malloc_alignment()` function is used to determine the default alignment; this cannot be overridden by user code (well, it can be, but the override will have no useful effect). It is intended to be "internal only" but is used in at least one place outside the runtime (apps/hannk). This change removes the call entirely, in favor of a call that is harder to access from outside the runtime and much less likely for end users to attempt to call. (It also changes apps/hannk to stop using it.) 11 December 2022, 18:05:55 UTC
16421a7 Steven Johnson 09 December 2022, 17:21:30 UTC Revise simd_op_check tests to ignore HL_TARGET (#7207) (#7216) * Revise simd_op_check tests to ignore HL_TARGET (#7207) The simd_op_check tests have historically only run using the value of HL_TARGET, which mean that the coverage they had was low (since HL_TARGET is only set to values that are runnable on at least one buildbot). This change completely disconnects these tests from HL_TARGET; instead, each test now tests for a range of targets appropriate to the architecture being tested. On all platforms, they still compile to assembly and verify that the correct instructions are generated; additionally, if the host platform can JIT for the given target, it verifies that the results are as expected. * Update simd_op_check_riscv.cpp * Update simd_op_check_x86.cpp * Update simd_op_check_x86.cpp * Update simd_op_check_arm.cpp * Add more features that must match; re-enable the bfloat instructions * Update simd_op_check_x86.cpp * Update simd_op_check_riscv.cpp * trigger buildbots * Fix simd_op_check_wasm 09 December 2022, 17:21:30 UTC
ba31688 Steven Johnson 09 December 2022, 01:22:54 UTC Increase __clang_major__ check in Float16.h to 16 (#7224) 09 December 2022, 01:22:54 UTC
066559b Steven Johnson 08 December 2022, 23:35:01 UTC Remove check_jit_user_context() from V8 bindings (#7220) Obsolete code from early V8 work, it can trigger inappropriately in some corner-case scenarios. Remove it entirely to avoid false errors. 08 December 2022, 23:35:01 UTC
8fa8221 Steven Johnson 08 December 2022, 04:34:13 UTC Fix bonehead version-checking test in HalideBuffer.h for Apple (#7218) 08 December 2022, 04:34:13 UTC
e8615bb Steven Johnson 08 December 2022, 01:22:38 UTC clang-tidy: add [[maybe-unused]] to the DECLARE_NO_INITMOD stubs. (#7215) 08 December 2022, 01:22:38 UTC
a7fa32e Steven Johnson 07 December 2022, 17:31:01 UTC Use aligned_alloc() as default allocator for HalideBuffer.h on most platforms (#7190) Use aligned_alloc() as default allocator for HalideBuffer.h on most platforms (See also https://github.com/halide/Halide/pull/7189) Modify H::R::Buffer to default to using `aligned_alloc()` instead of `malloc()`, except: - If user code passes a non-null `allocate_fn` or `deallocate_fn`, we always use those (and/or malloc/free) - If the code is compiling under MSVC, never use `aligned_alloc` (Windows doesn't support it) - If HALIDE_RUNTIME_BUFFER_USE_ALIGNED_ALLOC is defined to be 0, never use `aligned_alloc` (this is to allow for usage on e.g. older Android and OSX versions which don't provide `aligned_alloc()` in the stdlib, regardless of C++ versions.) Also, as with #7189, this ensures that the allocated space has the start of the host data as 128-aligned, and also now ensures that the size allocated 128-aligned (rounding up as needed). 07 December 2022, 17:31:01 UTC
8ce1212 Steven Johnson 07 December 2022, 17:29:19 UTC Fix bitrot in PowerPC testing (#7211) * Fix bitrot in PowerPC testing (See #7208) - DataLayout was wrong (and has been for a long time) - simd_op_check_powerpc had errors. Some were easy to fix; the rest I commented out with a TODO since this backend doesn't appear to be in active use. (Want to fix this in preparation for fixing #7207) * Move x86 absd tests to the right place Co-authored-by: Andrew Adams <andrew.b.adams@gmail.com> 07 December 2022, 17:29:19 UTC
35020c5 Zalman Stern 07 December 2022, 07:15:46 UTC Extend LLVM IR type mangling to handle scalars. (#7212) Extend LLVM IR type mangling to handle scalars and use this in vector predication intrinsic codegen. Fixes an error denerating vector predicated strided stores. 07 December 2022, 07:15:46 UTC
d4b4c50 Zalman Stern 07 December 2022, 07:15:10 UTC Add RISC V zvl flag for LLVM version 16 or greater. (#7209) 07 December 2022, 07:15:10 UTC
e0d1e15 Zalman Stern 07 December 2022, 00:58:28 UTC Fix issue with vector predicated comparison and select instructions. (#7205) Fix invalid LLVM IR issues with vector predicated comparison and select instructions. Add start of RISC V simd_op_check test. 07 December 2022, 00:58:28 UTC
59f5412 Zalman Stern 06 December 2022, 22:57:24 UTC Add bridging for clang _Float16 type. (#7201) Add type bridging between Halide::float16_t and _Float16 if the compiler supports the latter. Testing is done using clang specific logic and may need to be extended for other compilers. I chose not to add support for __fp16 and __bf16 right now as __fp16 is less useful in being storage only and __bf16 also only supports a subset of operations and was running into undefined symbols during compilation that did not look promising. Co-authored-by: Steven Johnson <srj@google.com> 06 December 2022, 22:57:24 UTC
90459b0 Steven Johnson 06 December 2022, 00:53:05 UTC Revert "Fix for top-of-tree LLVM" (#7200) Revert "Fix for top-of-tree LLVM (#7194)" This reverts commit a9ea9b565018774e52bb4028cbc91e14cb86959e. 06 December 2022, 00:53:05 UTC
345cf18 Steven Johnson 02 December 2022, 20:48:57 UTC Don't attempt to use makecontext()/swapcontext() on Android (#7196) Despite being 'posixy', it doesn't actually implement these calls. 02 December 2022, 20:48:57 UTC
a9ea9b5 Steven Johnson 02 December 2022, 00:17:48 UTC Fix for top-of-tree LLVM (#7194) 02 December 2022, 00:17:48 UTC
43911f4 Steven Johnson 01 December 2022, 18:20:03 UTC Add a -v flag to generator_main() (#7193) This is a simple thing that just logs the path to all generated file(s) to stdout if `-v=1` is specified. It's intended for people running Generators directly from the commandline, and is intended as a more user-friendly alternative to HL_DEBUG_CODEGEN=1. No makefiles, etc specify it at present, but I anticipate using it in some tooling in the future. Example usage: ``` $ resize_image_bilinear.generator_binary -v 1 -o /tmp -g resize_image_bilinear -n resize_image_bilinear_uint16 -f resize_image_bilinear_uint16 -e assembly,c_header,llvm_assembly,registration,static_library,stmt 'target=arm-64-android' 'input.type=uint16' 'output.type=uint16' Generated file: /tmp/resize_image_bilinear_uint16.s Generated file: /tmp/resize_image_bilinear_uint16.h Generated file: /tmp/resize_image_bilinear_uint16.ll Generated file: /tmp/resize_image_bilinear_uint16.registration.cpp Generated file: /tmp/resize_image_bilinear_uint16.a Generated file: /tmp/resize_image_bilinear_uint16.stmt ``` 01 December 2022, 18:20:03 UTC
5a8c324 Steven Johnson 30 November 2022, 01:44:30 UTC Fix metadata generation for multitarget Generators (#7181) Fix metadata generation for multitarget Generators We had a mechanism in place to ensure that Outputs that got renamed during lowering still emitted the proper names in the metadata... but this didn't work reliably for Multitarget generation. Now it does. 30 November 2022, 01:44:30 UTC
caf4b71 Steven Johnson 29 November 2022, 17:45:49 UTC Disable unreachable-code clang-tidy warnings (#7182) Some configurations of clang-tidy will (correctly) complain that the code inside the `if` clauses here will never be executed, since it ends up as something like `if (strcmp("foo", "foo"))`... but for testing purposes, we want to keep it, for obvious reasons. It's hard to construct a string-compare here as constexpr, so I'm just going to NOLINT it. Also changed the `count_buffers()` check to a static_assert for simplicity. 29 November 2022, 17:45:49 UTC
2cfc315 Steven Johnson 28 November 2022, 22:11:35 UTC Tweak the import paths in Python apps & tests (#7179) * Tweak the import paths in Python apps & tests This change makes it a bit easier for me to transform the import paths when merging into Google: we can't set PYTHONPATH, and calling `sys.path.append()` is frowned upon. This should have no effect on the GitHub repo but will make my life easier downstream. * More tweaks * force builds * Update Generator.cpp 28 November 2022, 22:11:35 UTC
73c61c3 Steven Johnson 28 November 2022, 21:52:51 UTC Add optional "function_info" header output (#7170) Add optional "function_info" header output At first glance, this looks like a subset of what is already provided by the `_metadata()` functionality: describing the argument attributes of an AOT-generated Halide function. However, _metadata() is suboptimal for some use cases: Because it's expressed as ordinary data, we can only process it at runtime; the new fuctionality is expressed as a `constexpr` data structure, meaning we can process it at *compile* time if we so choose. (This is quite useful for producing automatic call wrappers, etc). At first I considered adding this to the normal `.h` file, but moving it into a new file is cleaner in a few ways: - It maintains the 'C-only' nature of the existing .h files (adding this would have imposed a C++17-only section on them) - Splitting into a new file means no existing users are affected by this change at all Note also that this is deliberately not replicating all of the existing `_metadata()` functionality (it's just the argument signature, but no e.g. estimates or default values, etc). This approach means that it is probably more sensible to add several separate constexpr "getters" to this file, rather than trying to mash everything together into one clumsy structure. (With _metadata(), there was an incentive to keep the surface area of the API small, even if that meant combining somewhat-unrelated concerns; there is no such incentive here.) 28 November 2022, 21:52:51 UTC
3ff9e66 Dmitry Kurtaev 28 November 2022, 20:00:58 UTC Use n32:64 in RISC-V data layout (#7175) * Use n32:64 in RISC-V data layout * Remove unused LLVM header 28 November 2022, 20:00:58 UTC
81c79d5 Steven Johnson 28 November 2022, 19:12:11 UTC README_python.md should be installed with other READMEs (#7177) 28 November 2022, 19:12:11 UTC
270c24a Dmitry Kurtaev 18 November 2022, 18:52:51 UTC Migrate from MCJIT to ORC JIT (#7166) * Migrate from MCJIT to ORC JIT 18 November 2022, 18:52:51 UTC
7b0fdf5 Steven Johnson 18 November 2022, 17:08:56 UTC Add fopen() bottleneck to runtime (#7171) * Add fopen() bottleneck to runtime Prefer using `fopen64()` on Linux systems. Also, drive-by sorting of the list of initmods that was supposed to be kept sorted. * fopen_32 -> fopen, fopen_64 -> fopen_lfs 18 November 2022, 17:08:56 UTC
be055a8 Andrew Adams 16 November 2022, 01:02:37 UTC Slightly improve error message for non-integer RDom min/extent (#7151) Improve error message for non-integer RDom min/extent Co-authored-by: Steven Johnson <srj@google.com> 16 November 2022, 01:02:37 UTC
41fe8b3 Zalman Stern 11 November 2022, 03:32:07 UTC Factor simd_op_check into separate files by architecture. (#7163) 11 November 2022, 03:32:07 UTC
9916b4e Steven Johnson 08 November 2022, 16:54:25 UTC Add `bfloat` support to `halide_type_to_string()` (#7154) 08 November 2022, 16:54:25 UTC
58421be Steven Johnson 08 November 2022, 16:54:15 UTC Call cache.clear between internal functions in CG_C (#7155) We didn't call cache.clear() between internal functions in the C backend, so the cache could try to re-use something declared in a previous (internal, closure) function and would fail to compile. Easy fix. (I'm surprised we haven't seen this fail before now.) 08 November 2022, 16:54:15 UTC
c6815b0 Steven Johnson 08 November 2022, 16:53:43 UTC C Backend should call halide_buffer_to_string() (#7156) Just assume that this is present and call it for stringify() on buffers in the C backend. (If it's missing, the user will be expected to provide an implementation, as is usual for runtime with the C backend.) 08 November 2022, 16:53:43 UTC
102c059 Andrew Adams 08 November 2022, 00:38:44 UTC Fix readnone attribute for llvm 16 (#7152) * Fix readnone attribute for llvm 16 The readnone flag was changed to memory(none) when applied to functions. llvm-as dynamically upgrades readnone applied to functions, so our .ll is fine for now, but there were places in the compiler we were manually sticking 'readnone' on a function. Also did a driveby makefile fix to remove some vestigial wasm stuff that was throwing errors with newer versions of llvm-config * Revert formatting changes 08 November 2022, 00:38:44 UTC
8f8edeb Steven Johnson 03 November 2022, 20:37:51 UTC Don't use TF_LITE_KERNEL_LOG in apps/hannk (#7147) TF_LITE_KERNEL_LOG was intended for TFLite Micro but usage leaked out into example code; we should use ReportError instead. 03 November 2022, 20:37:51 UTC
1230042 Steven Johnson 02 November 2022, 00:10:51 UTC Fix Python wheel-building (#7144) Various bits of code rearrangement had invalidated some of the build scripts for Python wheels for our bindings; this fixes that, and also subtracts some other irrelevant stuff that was getting included (e.g. the stub directory). Also updated the "long description" to use README_python.md rather than README.md. 02 November 2022, 00:10:51 UTC
d3e9d85 Steven Johnson 01 November 2022, 22:11:16 UTC Upgrade some Actions in pip.yml (#7141) Needed to avoid deprecation warnings 01 November 2022, 22:11:16 UTC
b676567 Steven Johnson 01 November 2022, 22:10:52 UTC Bump Halide version in main's setup.py to 16 (#7142) 01 November 2022, 22:10:52 UTC
bb7715a Steven Johnson 01 November 2022, 20:13:13 UTC Move Python apps to toplevel of python_bindings -- they don't belong … (#7140) * Move Python apps to toplevel of python_bindings -- they don't belong under test/ * Update CMakeLists.txt 01 November 2022, 20:13:13 UTC
115f67a Steven Johnson 01 November 2022, 16:12:26 UTC Give pip.yml permission to read packages (#7139) 01 November 2022, 16:12:26 UTC
4987365 Steven Johnson 31 October 2022, 22:22:26 UTC Rewrite python_bindings/apps (#7133) * apps * wip * WIP 2 * Fix comments * _GPU_SCHEDULE_ENUM_MAP * Update blur_generator.py * Add hl.funcs, hl.vars, plus formatting tweaks 31 October 2022, 22:22:26 UTC
e6066ac Steven Johnson 31 October 2022, 20:07:41 UTC halide.imageio needs to support arbitrary bufferviews (#7137) * halide.imageio needs to support arbitrary bufferviews As written, the helper code assumed that everything passed in was a numpy array of some sort; this meant that passing hl.Buffer didn't work. Restructured so that we only assume that the objects passed in satisfies the Python buffer protocol, so this should now work very generically. * Update imageio.py * More fixes 31 October 2022, 20:07:41 UTC
5da5dfd Alexander Root 31 October 2022, 18:36:41 UTC [x86] Generate AVX512 fixed-point instructions (#7129) * clean-up abs and saturating_pmulhrs, fix AVX512 saturating_ ops * add test coverage for AVX512 fp ops * generate vpabs on AVX512 * faster AVX2 lowering of saturating_pmulhrs 31 October 2022, 18:36:41 UTC
bad945f Steven Johnson 31 October 2022, 16:57:09 UTC Apply 'Black' formatter to py/test/correctness and py/test/generators (#7135) * Apply 'Black' formatter to py/test/correctness and py/test/generators Trying to regularize all our Python code to a common style. Should be no functional changes here, just autoformatting + a few tweaks. * Update complexpy_generator.py 31 October 2022, 16:57:09 UTC
0c03ff8 Alex 31 October 2022, 16:22:53 UTC GitHub Workflows security hardening (#7136) build: harden pip.yml permissions Signed-off-by: Alex <aleksandrosansan@gmail.com> Signed-off-by: Alex <aleksandrosansan@gmail.com> 31 October 2022, 16:22:53 UTC
bd15cee Alexander Root 29 October 2022, 21:19:47 UTC [WASM] Use rounding_mul_shift_right for q15mulr_sat_s pattern (#7134) Use rounding_mul_shift_right for WASM q15mulr_sat_s pattern 29 October 2022, 21:19:47 UTC
2f1587e Steven Johnson 28 October 2022, 00:18:41 UTC Fix Python buffer handling (#7125) * Fix Python buffer handling In the category of "how did this ever work"... TL;DR: in general, Halide Buffers have the opposite axis ordering from Python/NumPy buffers; in Halide, the most-frequently-varying dimension comes first, while in Python, it comes last. This isn't surprising, though, since Halide's indexing scheme is effectively column-major while NumPy's is row-major. Anyway: what we *should* have done was to reverse the order of dimensions when converting to/from Halide Buffers vs Python buffers; instead, we kept the same order, then jumped thru hoops to rearrange buffers to fit this setup. This PR does the appropriate axis reordering, fixing the apps and tests as needed. It also adds some helper code for image reading and writing; by default, we use `imageio` for this, but imageio ~always wants RGB/RGBA images to be interleaved (vs the planar that Halide prefers). So, I added the `halide.imageio` package, that has wrapper functions to quietly convert to/from planar as needed. Needless to say, this change is likely to break existing code that is using 3d buffers in Halide, but I think it's the right long-term thing to do. Opinions greatly welcomed here. * Update PyBuffer.cpp * -"for better vectorization" * public halide.imageio utilities should copy() buffers * PEP8 * Update imageio.py * Update imageio.py * add 'reverse_axes' options to Buffer conversions (#7127) * add 'reverse_axes' options to Buffer conversions 28 October 2022, 00:18:41 UTC
48345d9 Steven Johnson 27 October 2022, 02:22:38 UTC Add range-checking to Buffer objects in Python (#7128) using () to get or set a Buffer element wasn't being checked at runtime for Python, but it clearly should be, because Python. (Note that in C++ we don't always range-check for these operations -- it's limited to `assert()` checks -- but in Python the expectations are clearly different.) 27 October 2022, 02:22:38 UTC
da87cb2 Zalman Stern 26 October 2022, 22:12:28 UTC RISC V vector predication support intrinsics support (#7119) Turn on vector predication support for RISC V. (First architecture to use this code. Bug fixes included here.) Add architecture specific vector intrinsics support as well. Should not affect anything outside of RISC V. 26 October 2022, 22:12:28 UTC
fd63349 Steven Johnson 25 October 2022, 17:29:07 UTC Require Python 3.8+ in CMake build (#7117) * Require Python 3.8+ in CMake build * Update CMakeLists.txt * Update CMakeLists.txt 25 October 2022, 17:29:07 UTC
9163310 Zalman Stern 25 October 2022, 05:24:32 UTC Add support for generating LLVM vector predication intrinsics. (#7111) Add support for generating llvm.vp.* intrinsics. This is particularly useful for RISC V, but it may be a simpler, better optimized path, for Halide vector operations in general. Add support for a maximum vector size that might be larger than the native vector size. RISC V vector LMUL support is an example of an architecture supporting this. 25 October 2022, 05:24:32 UTC
44102c0 Steven Johnson 24 October 2022, 16:37:40 UTC Add evaluate() and evaluate_may_gpu() to Python bindings (#7108) * Add evaluate() and evaluate_may_gpu() to Python bindings * pacify clang-tidy 24 October 2022, 16:37:40 UTC
5ade1fb Steven Johnson 21 October 2022, 17:26:49 UTC Attempt to fix pip build issues (#7098) 21 October 2022, 17:26:49 UTC
8204b05 Steven Johnson 21 October 2022, 17:17:53 UTC Minor updates to apps/hannk (#7110) * Update hannk to TFLite 2.8.3 * Newer Android NDK use llvm-ar * Avoid 'unscheduled' warning for Elementwise 21 October 2022, 17:17:53 UTC
da22f6f Andrew Adams 20 October 2022, 19:26:46 UTC Fix some dead links to the 'master' branch (#7107) 20 October 2022, 19:26:46 UTC
4f7100b Steven Johnson 20 October 2022, 00:42:58 UTC Fix subtle CMake Install bugs (#7103) * Update CMakeLists.txt * Update CMakeLists.txt 20 October 2022, 00:42:58 UTC
5256aa6 Steven Johnson 18 October 2022, 04:14:26 UTC Remove HALIDE_ALLOW_LEGACY_AUTOSCHEDULER_API (#7096) * Remove HALIDE_ALLOW_GENERATOR_EXTERNAL_CODE * Remove HALIDE_ALLOW_LEGACY_AUTOSCHEDULER_API * clang-format * Update CMakeLists.txt 18 October 2022, 04:14:26 UTC
83ccd8e Steven Johnson 18 October 2022, 04:14:07 UTC Revert "Update pip.yml to use LLVM 15.0.2" (#7099) Revert "Update pip.yml to use LLVM 15.0.2 (#7097)" This reverts commit 26b1f3c938b07e6fc73f34e5af223c0eaf8e909f. 18 October 2022, 04:14:07 UTC
8f210f1 Steven Johnson 17 October 2022, 23:02:40 UTC Remove HALIDE_ALLOW_GENERATOR_EXTERNAL_CODE (#7094) 17 October 2022, 23:02:40 UTC
bb6092b Steven Johnson 17 October 2022, 23:01:13 UTC Remove everything flagged with HALIDE_ATTRIBUTE_DEPRECATED (#7095) 17 October 2022, 23:01:13 UTC
6702d86 Steven Johnson 17 October 2022, 22:52:03 UTC Update Halide main branch to v16 (#7093) * Update Halide main branch to v16 * Drop support for LLVM13 in main Now that release/15.x has branched, main is now Halide 16 and no longer needs to support LLVM13. Update the docs, prune the requirements, eliminate old special cases we don't need anymore. * Revert mistaken changes * Update LLVM_Headers.h 17 October 2022, 22:52:03 UTC
26b1f3c Steven Johnson 17 October 2022, 22:37:48 UTC Update pip.yml to use LLVM 15.0.2 (#7097) Newly released since this script was written 17 October 2022, 22:37:48 UTC
e70b7d9 Volodymyr Kysenko 17 October 2022, 22:07:53 UTC Generate dot() in the Metal backend (#7085) * dot() support for Metal backend) * Restrict dot() to floats 17 October 2022, 22:07:53 UTC
0a04beb Steven Johnson 17 October 2022, 18:31:15 UTC Update README.md (#7091) 17 October 2022, 18:31:15 UTC
eb2e336 Steven Johnson 17 October 2022, 17:11:05 UTC Fix #7076, #7077 (#7080) * Fix issue 7076 * fixes * Fixes * Update ScheduleFunctions.cpp * Update ScheduleFunctions.cpp * Update ScheduleFunctions.cpp 17 October 2022, 17:11:05 UTC
8e2cbe0 Alexander Root 14 October 2022, 18:40:17 UTC [HVX] Fix DistributeShiftsAsMuls (#7083) Fix DistributeShiftsAsMuls 14 October 2022, 18:40:17 UTC
23e22cc Alex Reinking 13 October 2022, 02:04:56 UTC Add pip packaging workflow to GHA (#6938) * Add pip packaging workflow * Try adding steps for Windows/macOS * Add CMake/Ninja to runners. * Use MSVC on Windows * Try caching LLVM build * Split LLVM build into separate job * Fix CI * Fix CI * Debugging * Fix path? * Tar for faster transfer and correct perms * Don't build Halide as Universal 2 * Try using ClangCL on Windows * hack in support for universal2 builds * go back to universal2 * add universal2 to CIBW_ARCHS_MACOS * Update workflow to publish to PyPI * Add package metadata * Last fixup before merge 13 October 2022, 02:04:56 UTC
e85b880 Steven Johnson 06 October 2022, 21:20:44 UTC pacify clang-tidy by removing unused "using" (#7071) 06 October 2022, 21:20:44 UTC
7442ee6 Steven Johnson 06 October 2022, 18:12:37 UTC Autoscheduler test reorg, part 3 (#7067) * Autoscheduler test reorg, part 3 06 October 2022, 18:12:37 UTC
7086c6f Steven Johnson 06 October 2022, 18:11:25 UTC Autoscheduler test reorg, part 2 (#7065) * Autoscheduler test reorg, part 2 Move the Li2018 tests to tests/autoschedulers. Drive-by fix to the Python test. 06 October 2022, 18:11:25 UTC
9de4906 Steven Johnson 06 October 2022, 18:09:38 UTC Autoscheduler test reorg, part 1 (#7064) * Autoscheduler test reorg, part 1 The end goal here is to move the tests for all autoschedulers into `test/autoschedulers/<name>`. This part handles the tests for the Mullapudi2016 autoscheduler: - Moves from test/auto_schedule - Silences a lot of the irrelevant noise that the tests emit to stdout (see also #7063) - Ensure that the tests that run manual-and-auto tests actually check the times for plausibility (where "plausible" means "no worse than the current status quo") 06 October 2022, 18:09:38 UTC
f360427 Steven Johnson 06 October 2022, 17:21:28 UTC Improve MSAN under JIT (#7059) Running JIT code under MSAN is (still) not officially supported, as it can (and does) give false positives; that said, this PR reduces the false positives in some cases. Specifically: (1) if we are building a JIT shared runtime (ie, we are jitting), and we are compiling with MSAN enabled (detected via preprocessor), we should always use the real MSAN stubs, even if the Target::MSan feature has been cleared (because JITModule::make_module() clears it). (2) Target::get_jit_from_environment() should add any detected sanitizer bits to the target sniffed from HL_JIT_TARGET 06 October 2022, 17:21:28 UTC
e3bbafd Steven Johnson 06 October 2022, 17:19:23 UTC Add a terminate_handler to try to report unhandled exceptions (#7038) * Add a terminate_handler to try to report unhandled exceptions * Move terminate handler to an object file, applied to tests * Update terminate_handler.cpp * Update terminate_handler.cpp * Update HalideTestHelpers.cmake 06 October 2022, 17:19:23 UTC
16243da Steve Suzuki 04 October 2022, 21:25:16 UTC Add support for float16 buffer in python extension (#7060) 04 October 2022, 21:25:16 UTC
5822458 Steven Johnson 04 October 2022, 20:24:49 UTC Upgrade wabt to 1.0.30 (#7058) 04 October 2022, 20:24:49 UTC
236521b Steven Johnson 28 September 2022, 16:57:49 UTC Allow redefinition of Generators when in interactive mode (#7053) It's really annoying to be using (e.g.) Colab/Jupyter/etc and get errors about "Generator already defined", so sniff for interactive mode and allow re-registration of the same name in that case. 28 September 2022, 16:57:49 UTC
820ec1f Steven Johnson 27 September 2022, 16:34:12 UTC Don't mutate GeneratorParams in PythonGenerators (#7052) * Don't mutate GeneratorParams in PythonGenerators They are really only ever defined at the class level, so if you mutate the value, you are mutating the default value for all future instances. Subtle bug. * Update _generator_helpers.py * Update _generator_helpers.py 27 September 2022, 16:34:12 UTC
d5a8118 Andrew Adams 26 September 2022, 21:47:13 UTC Make Halide::round behave as documented (#7012) * Clean up some pointless code * Improve comment on Halide::round * Make Halide::round round to even as documented * Explicitly set the rounding mode in the C backend * Use rint on ptx, which is documented to round to even * round to even on win32 * the nvidia libdevice is buggy for doubles See https://reviews.llvm.org/D85236 * Add missing include to C output * Fix rounding in opencl * Don't test opencl with doubles if CLDoubles is not enabled * Work around hexagon issue * Don't try to emit roundeven on wasm * wasm doesn't support float16 * Add vectorizable lowering for round on platforms without roundeven * Use rint on metal for Halide::round * Make round an intrinsic * Constant-fold round in simplifier * d3d12 fix * Bounds of Call::round * Teach the mullapudi cost model about round * Handle PureIntrinsics of const args in bounds * scatter, undef, and require aren't pure * metal doesn't support doubles * More parens * Add missing return * Add vector versions of rint for wasm * Use nearbyint for wasm instead of rint * revert change to mangling * d3d12 doesn't like double input/output buffers * Lower round on arm-32 not-linux * Don't simplify lowering of round-to-nearest-ties-to-even in codegen * Fix infinite loop in round lowering on arm-32-notlinux * Take care to never revisit args in bounds call visitor * Remove defunct comment Co-authored-by: Steven Johnson <srj@google.com> 26 September 2022, 21:47:13 UTC
59353ab Zalman Stern 26 September 2022, 19:37:26 UTC Allow CodeGen_LLVM::codegen_buffer_pointer to support vectors. (#7049) This is useful for scatter/gather in the vector predication intrinsics work. 26 September 2022, 19:37:26 UTC
a817414 Zalman Stern 24 September 2022, 00:16:33 UTC Allow call_intrin to call an LLVM intrinsic with void return type. (#7048) Have ```CodeGen_LLVM::get_vector_type``` return the void type if passed the void type as a scalar base. This makes it possible to call intrinsics returning void via ```CodeGenn_LLVM::call_intrin```. Should be very safe as currently this anything doing this would fail inside the routine. The change breaks the invariant that any thing returned from get_vector_type is a vector type, but propagating void for function return types is a pretty standard behavior and if this was not intended, it will very likely fail just outside this instead of having failed inside the use. I.e. very low chance of spurious errors from this. 24 September 2022, 00:16:33 UTC
6499ad1 Zalman Stern 23 September 2022, 22:58:27 UTC Fix false positive use after free warning. (#7046) Latest clang is giving a use after free warning for printing a pointer value after it is freed. The compiler is not exactly wrong in that a pointer is being passed to something after it is freed, but the something is just printing the pointer's value for debugging purposes. Cast through an intptr_t to avoid the warning. 23 September 2022, 22:58:27 UTC
666b87d Steven Johnson 23 September 2022, 18:15:13 UTC add_requirement() maintenance (#7045) * add_requirement() maintenance This PR started out as a quick fix to add Python bindings for the `add_requirements` methods on Pipeline and Generator (which were missing), but expanded a bit to fix other issues as well: - The implementation of `Generator::add_requirement` was subtly wrong, in that it only worked if you called the method after everything else in your `generate()` method. Now we accumulate requirements and insert them at the end, so you can call the method anywhere. - We had C++ methods that took both an explicit `vector<Expr>` and also a variadic-template version, but the former required a mutable vector... and fixing this to not require that ended up creating ambiguity about which overloaded call to use. Added an ugly enable_if thing to resolve this. (Side note #1: overloading methods to have both templated and non-templated versions with the same name is probably something to avoid in the future.) (Side note #2: we should probably thing more carefully about using variadic templates in our public API in the future; we currently use it pretty heavily, but it tends to be messy and hard to reason about IMHO.) * tidy * remove underscores 23 September 2022, 18:15:13 UTC
7286ec3 Steven Johnson 22 September 2022, 17:07:32 UTC Fix PyExt error handling (#7042) The current PythonExtensionGen code attempts to provide verbose error (exception) messages by overriding halide_error and saving the message in a thread_local. This isn't safe or correct, however, and (in general) is wrong for any Halide code using multiple threads. #6994 proposes ways to mitigate this (and there are experiments in place to implement it), but unless/until those enhancements land, we can't leave the code in its current state. So: - Don't try to save the text at all. - Optionally log the text to stderr. - Just throw an exception with the numeric error code. This is suboptimal, but better than the existing usually-incorrect-message behavior. - Bonus: wrap both the error and print overloads with `PyGILState_Ensure()`, as we are supposed to, to ensure we don't die. 22 September 2022, 17:07:32 UTC
b4b27b2 Steven Johnson 21 September 2022, 23:20:06 UTC Revert "Temporarily disable testing for apps/fft (#7033)" (#7040) Revert "Temporarily disable testing for apps/fft (#7033) (#7035)" This reverts commit 48d56d8066f322e016d60d486613837e3670dd00. 21 September 2022, 23:20:06 UTC
33f6a0f Volodymyr Kysenko 21 September 2022, 22:01:10 UTC Handle widen_right_* intrinsics in bounds inference (#7039) 21 September 2022, 22:01:10 UTC
7ec2a4e Steven Johnson 21 September 2022, 17:20:03 UTC Add stack-size-canary test to apps/fft's CMake file (#7034) * Add stack-size-canary test to apps/fft's CMake file This was apparently meant as a canary for stack size usage, but the necessary setting only happened in the Makefile, not the CMake file. Also, drive-by fix in Makefile to ignore warnings about `-ObjC++` being ignored, which apparently can be the case with current AppleClang configs. * Update CMakeLists.txt 21 September 2022, 17:20:03 UTC
0d02a0b Steven Johnson 21 September 2022, 00:55:56 UTC Fix Wasm BulkMemory Codgen + Minor fixes to apps/HelloWasm (#7026) * Minor fixes to apps/HelloWasm * trigger buildbots * Fix Codegen * Update CMakeLists.txt 21 September 2022, 00:55:56 UTC
7351070 Steven Johnson 20 September 2022, 22:52:26 UTC Codegen_C for user_context (#7031) Codegen_C fixes 20 September 2022, 22:52:26 UTC
ba53b93 Alexander Root 20 September 2022, 22:00:14 UTC Add reinterpret simplifications (#7029) Co-authored-by: Steven Johnson <srj@google.com> 20 September 2022, 22:00:14 UTC
48d56d8 Steven Johnson 20 September 2022, 19:08:29 UTC Temporarily disable testing for apps/fft (#7033) (#7035) Want to avoid reporting this known bug while fix is investigated 20 September 2022, 19:08:29 UTC
36d601f Steven Johnson 19 September 2022, 23:18:19 UTC Don't use `-g` for EMCC (#7025) * Don't use `-g` for EMCC Combining `-g` with other default EMCC flags will now emit warning/error messages regarding binaryen optimization, so, don't use that flag in the default settings. * Update Error.cpp 19 September 2022, 23:18:19 UTC
back to top