| 313a720 | Tom Lane | 21 May 2006, 21:52:58 UTC | Stamp release 8.1.4. | 21 May 2006, 21:52:58 UTC |
| 3f6b5e2 | Tom Lane | 21 May 2006, 21:49:38 UTC | Update release notes for upcoming releases. | 21 May 2006, 21:49:38 UTC |
| dd2a4ce | Tom Lane | 21 May 2006, 20:22:23 UTC | Fix errors in fortuna PRNG reseeding logic that could cause a predictable session key to be selected by pgp_sym_encrypt() in some cases. This only affects non-OpenSSL-using builds. Marko Kreen | 21 May 2006, 20:22:23 UTC |
| 7f615ca | Tom Lane | 21 May 2006, 20:19:44 UTC | Modify libpq's string-escaping routines to be aware of encoding considerations and standard_conforming_strings. The encoding changes are needed for proper escaping in multibyte encodings, as per the SQL-injection vulnerabilities noted in CVE-2006-2313 and CVE-2006-2314. Concurrent fixes are being applied to the server to ensure that it rejects queries that may have been corrupted by attempted SQL injection, but this merely guarantees that unpatched clients will fail rather than allow injection. An actual fix requires changing the client-side code. While at it we have also fixed these routines to understand about standard_conforming_strings, so that the upcoming changeover to SQL-spec string syntax can be somewhat transparent to client code. Since the existing API of PQescapeString and PQescapeBytea provides no way to inform them which settings are in use, these functions are now deprecated in favor of new functions PQescapeStringConn and PQescapeByteaConn. The new functions take the PGconn to which the string will be sent as an additional parameter, and look inside the connection structure to determine what to do. So as to provide some functionality for clients using the old functions, libpq stores the latest encoding and standard_conforming_strings values received from the backend in static variables, and the old functions consult these variables. This will work reliably in clients using only one Postgres connection at a time, or even multiple connections if they all use the same encoding and string syntax settings; which should cover many practical scenarios. Clients that use homebrew escaping methods, such as PHP's addslashes() function or even hardwired regexp substitution, will require extra effort to fix :-(. It is strongly recommended that such code be replaced by use of PQescapeStringConn/PQescapeByteaConn if at all feasible. | 21 May 2006, 20:19:44 UTC |
| 3d4dc1a | Tom Lane | 21 May 2006, 20:11:02 UTC | Add a new GUC parameter backslash_quote, which determines whether the SQL parser will allow "\'" to be used to represent a literal quote mark. The "\'" representation has been deprecated for some time in favor of the SQL-standard representation "''" (two single quote marks), but it has been used often enough that just disallowing it immediately won't do. Hence backslash_quote allows the settings "on", "off", and "safe_encoding", the last meaning to allow "\'" only if client_encoding is a valid server encoding. That is now the default, and the reason is that in encodings such as SJIS that allow 0x5c (ASCII backslash) to be the last byte of a multibyte character, accepting "\'" allows SQL-injection attacks as per CVE-2006-2314 (further details will be published after release). The "on" setting is available for backward compatibility, but it must not be used with clients that are exposed to untrusted input. Thanks to Akio Ishida and Yasuo Ohgaki for identifying this security issue. | 21 May 2006, 20:11:02 UTC |
| 8fe643b | Tom Lane | 21 May 2006, 20:05:50 UTC | Change the backend to reject strings containing invalidly-encoded multibyte characters in all cases. Formerly we mostly just threw warnings for invalid input, and failed to detect it at all if no encoding conversion was required. The tighter check is needed to defend against SQL-injection attacks as per CVE-2006-2313 (further details will be published after release). Embedded zero (null) bytes will be rejected as well. The checks are applied during input to the backend (receipt from client or COPY IN), so it no longer seems necessary to check in textin() and related routines; any string arriving at those functions will already have been validated. Conversion failure reporting (for characters with no equivalent in the destination encoding) has been cleaned up and made consistent while at it. Also, fix a few longstanding errors in little-used encoding conversion routines: win1251_to_iso, win866_to_iso, euc_tw_to_big5, euc_tw_to_mic, mic_to_euc_tw were all broken to varying extents. Patches by Tatsuo Ishii and Tom Lane. Thanks to Akio Ishida and Yasuo Ohgaki for identifying the security issues. | 21 May 2006, 20:05:50 UTC |
| e5ab52b | Alvaro Herrera | 19 May 2006, 15:15:38 UTC | Have autovacuum report its activities to the stat collector. | 19 May 2006, 15:15:38 UTC |
| 3a3622c | Bruce Momjian | 19 May 2006, 04:41:06 UTC | Back out \' change for tsearch2, broke regression tests. | 19 May 2006, 04:41:06 UTC |
| e720382 | Bruce Momjian | 19 May 2006, 03:57:17 UTC | Stamp 8.1.4, except configure/configure.in. | 19 May 2006, 03:57:17 UTC |
| 289f10c | Bruce Momjian | 19 May 2006, 03:50:07 UTC | Update release notes for 8.1.4. | 19 May 2006, 03:50:07 UTC |
| 95d8b6a | Bruce Momjian | 19 May 2006, 03:34:49 UTC | Backpatch FAQs to 8.1.X. | 19 May 2006, 03:34:49 UTC |
| 9a27f72 | Bruce Momjian | 19 May 2006, 02:39:04 UTC | Use SQL standard '' rather than \' in /contrib. Backpatch to 8.1.X. | 19 May 2006, 02:39:04 UTC |
| 1c01a51 | Tom Lane | 18 May 2006, 19:56:56 UTC | Fix choose_bitmap_and() so that partial index predicates are considered when deciding whether a potential additional indexscan is redundant or not. As now coded, any use of a partial index that was already used in a previous AND arm will be rejected as redundant. This might be overly restrictive, but not considering the point at all is definitely bad, as per example in bug #2441 from Arjen van der Meijden. In particular, a clauseless scan of a partial index was *never* considered redundant by the previous coding, and that's surely wrong. Being more flexible would also require some consideration of how not to double-count the index predicate's selectivity. | 18 May 2006, 19:56:56 UTC |
| 59ca5eb | Tom Lane | 18 May 2006, 18:57:37 UTC | When a bitmap indexscan is using a partial index, it is necessary to include the partial index predicate in the scan's "recheck condition". Otherwise, if the scan becomes lossy for lack of bitmap memory, we would fail to enforce that returned rows satisfy the predicate. Noted while studying bug #2441 from Arjen van der Meijden. | 18 May 2006, 18:57:37 UTC |
| 4aec530 | Bruce Momjian | 13 May 2006, 17:11:02 UTC | Update pg_dump version wording. | 13 May 2006, 17:11:02 UTC |
| dfc2fc2 | Bruce Momjian | 13 May 2006, 16:20:21 UTC | Mention version portability of pg_dump. | 13 May 2006, 16:20:21 UTC |
| 17e0486 | Tom Lane | 12 May 2006, 22:44:43 UTC | Fix the sense of the test on DH_check()'s return value. This was preventing custom-generated DH parameters from actually being used by the server. Found by Michael Fuhr. | 12 May 2006, 22:44:43 UTC |
| 988e59f | Tom Lane | 11 May 2006, 21:58:29 UTC | Remove unnecessary .seg/.section directives, per Alan Stange. | 11 May 2006, 21:58:29 UTC |
| ae61246 | Bruce Momjian | 11 May 2006, 19:21:31 UTC | Use SQL standard '' rather than \' for tutorial/sample code. Backpatch to 8.1.X. | 11 May 2006, 19:21:31 UTC |
| 9083bdd | Bruce Momjian | 08 May 2006, 02:18:59 UTC | Build server libpgport with all non-FRONTEND object files. This is to fix a Win32 bug where pipe.c included a file that used FRONTEND, but it wasn't on the server-build list. | 08 May 2006, 02:18:59 UTC |
| 478335a | Tom Lane | 03 May 2006, 00:25:07 UTC | Fix calculation of plan node extParams to account for the possibility that one initPlan sets a parameter for another. This could not (I think) happen before 8.1, but it's possible now because the initPlans generated by MIN/MAX optimization might themselves use initPlans. We attach those initPlans as siblings of the MIN/MAX ones, not children, to avoid duplicate computation when multiple MIN/MAX aggregates are present; so this leads to the case of an initPlan needing the result of a sibling initPlan, which is not possible with ordinary query nesting. Hadn't been noticed because in most contexts having too much stuff listed in extParam is fairly harmless. Fixes "plan should not reference subplan's variable" bug reported by Catalin Pitis. | 03 May 2006, 00:25:07 UTC |
| a3fe5ed | Tom Lane | 02 May 2006, 04:34:24 UTC | Avoid assuming that statistics for a parent relation reflect the properties of the union of its child relations as well. This might have been a good idea when it was originally coded, but it's a fatally bad idea when inheritance is being used for partitioning. It's better to have no stats at all than completely misleading stats. Per report from Mark Liberman. The bug arguably exists all the way back, but I've only patched HEAD and 8.1 because we weren't particularly trying to support partitioning before 8.1. Eventually we ought to look at deriving union statistics instead of just punting, but for now the drop kick looks good. | 02 May 2006, 04:34:24 UTC |
| 0619268 | Tom Lane | 28 April 2006, 20:57:59 UTC | Remove the restriction originally coded into optimize_minmax_aggregates() that MIN/MAX not be converted to use an index if the query WHERE clause contains any volatile functions or subplans. I had originally feared that the conversion might alter the behavior of such a query with respect to a volatile function. Well, so it might, but only in the sense that the function would get evaluated at a subset of the table rows rather than all of them --- and we have never made any such guarantee anyway. (For instance, we don't refuse to use an index for an ordinary non-aggregate query when one of the non-indexable filter conditions contains a volatile function.) The prohibition against subplans was because of worry that that case wasn't adequately tested, which it wasn't, but it turns out to be possible to make 8.1 fail anyway: regression=# select o.ten, (select max(unique2) from tenk1 i where ten = o.ten or ten = (select f1 from int4_tbl limit 1)) from tenk1 o; ERROR: direct correlated subquery unsupported as initplan This is due to bogus code in SS_make_initplan_from_plan (it's an initplan, ergo it can't have any parParams). Having fixed that, we might as well allow subplans as well as initplans. | 28 April 2006, 20:57:59 UTC |
| 96cc134 | Bruce Momjian | 26 April 2006, 23:01:58 UTC | Fix SELECT INTO and CREATE TABLE AS to create tables in the default tablespace, not the base directory. Kris Jurka | 26 April 2006, 23:01:58 UTC |
| abee2cd | Tom Lane | 26 April 2006, 00:35:35 UTC | Revise large-object access routines to avoid running with CurrentMemoryContext set to the large object context ("fscxt"), as this is inevitably a source of transaction-duration memory leaks. Not sure why we'd not noticed it before; maybe people weren't touching a whole lot of LOs in the same transaction before the 8.1 pg_dump changes. Per report from Wayne Conrad. Backpatched as far as 8.1, but the problem doubtless goes all the way back. I'm disinclined to spend the time to try to verify that the older branches would still work if patched, seeing that this code was significantly modified for 8.0 and again for 8.1, and that we don't have any trouble reports before 8.1. (Maybe the leaks were smaller before?) | 26 April 2006, 00:35:35 UTC |
| 4454eea | Tom Lane | 25 April 2006, 16:54:26 UTC | The 8.1 planner removes WHERE quals from the plan when the quals are implied by the predicate of a partial index being used to scan a table. However, this optimization is unsafe in an UPDATE, DELETE, or SELECT FOR UPDATE query, because the quals need to be rechecked by EvalPlanQual if there's an update conflict. Per example from Jean-Samuel Reynaud. | 25 April 2006, 16:54:26 UTC |
| 2c4abf1 | Tom Lane | 24 April 2006, 20:36:41 UTC | Improve our private implementation of cbrt() to give results of the accuracy expected by the regression tests. Per suggestion from Martijn van Oosterhout. | 24 April 2006, 20:36:41 UTC |
| e37c0d2 | Michael Meskes | 24 April 2006, 09:45:44 UTC | Fixed memory leak bugs found by Martijn Oosterhout. | 24 April 2006, 09:45:44 UTC |
| 499ec8c | Bruce Momjian | 24 April 2006, 04:03:42 UTC | Fixes for BCC 5.5 compile of libpq. Backpatch to 8.1.X. Mark Morgan Lloyd | 24 April 2006, 04:03:42 UTC |
| 7f0c971 | Alvaro Herrera | 24 April 2006, 01:40:39 UTC | Don't add a shared dependency on the owner of a composite type in pg_class. We track the owner in pg_type instead, as that is the place where the owner is changed on ALTER TYPE ... OWNER TO. | 24 April 2006, 01:40:39 UTC |
| 21138b5 | Bruce Momjian | 22 April 2006, 03:03:19 UTC | Suggest Win32 users user E'' strings and double backslashes used for patch separators in COPY. Backpatch doubleing backslashes suggestion to 8.1. | 22 April 2006, 03:03:19 UTC |
| bc5ba26 | Tom Lane | 19 April 2006, 16:15:34 UTC | Fix ancient memory leak in PQprintTuples(); our code no longer uses this routine, but perhaps some applications do. Found by Martijn van Oosterhout using Coverity. | 19 April 2006, 16:15:34 UTC |
| 6b46ec2 | Bruce Momjian | 18 April 2006, 12:41:29 UTC | Mention "syntax" error as not logged by log_statement. Backpatch. | 18 April 2006, 12:41:29 UTC |
| 65f1a7a | Bruce Momjian | 18 April 2006, 00:52:41 UTC | Document that errors are not output by log_statement (was they were in 8.0), and add as suggestion to use log_min_error_statement for this purpose. I also fixed the code so the first EXECUTE has it's prepare, rather than the last which is what was in the current code. Also remove "protocol" prefix for SQL EXECUTE output because it is not accurate. Backpatch to 8.1.X. | 18 April 2006, 00:52:41 UTC |
| dd8d1b1 | Bruce Momjian | 15 April 2006, 18:11:48 UTC | Document that pg_dump -d/-D prevents invalid data from canceling the entire table load. | 15 April 2006, 18:11:48 UTC |
| d17c5f0 | Tom Lane | 13 April 2006, 18:01:38 UTC | Fix similar_escape() so that SIMILAR TO works properly for patterns involving alternatives ("|" symbol). The original coding allowed the added ^ and $ constraints to be absorbed into the first and last alternatives, producing a pattern that would match more than it should. Per report from Eric Noriega. I also changed the pattern to add an ARE director ("***:"), ensuring that SIMILAR TO patterns do not change behavior if regex_flavor is changed. This is necessary to make the non-capturing parentheses work, and seems like a good idea on general principles. Back-patched as far as 7.4. 7.3 also has the bug, but a fix seems impractical because that version's regex engine doesn't have non-capturing parens. | 13 April 2006, 18:01:38 UTC |
| 9b83454 | Bruce Momjian | 13 April 2006, 11:42:35 UTC | Update AIX FAQ: At any rate, here's a revision to CVS HEAD to reflect some changes by myself and by Seneca Cunningham for the AIX FAQ. It touches on the following issues: 1. memcpy pointer patch for dynahash.c 2. AIX memory management, which can, for 32 bit cases, bite people quite unexpectedly... Chris Browne | 13 April 2006, 11:42:35 UTC |
| e4b8253 | Tom Lane | 12 April 2006, 22:19:01 UTC | Fix pg_restore -n option to do what the man page says it does. The original coding only worked if one of the selTypes restriction options was also given. Per report from Nick Johnson. | 12 April 2006, 22:19:01 UTC |
| a5884d5 | Bruce Momjian | 11 April 2006, 21:23:28 UTC | Updated Japanese FAQ, version 2. J.Kuwamura | 11 April 2006, 21:23:28 UTC |
| 5052aa2 | Bruce Momjian | 11 April 2006, 21:19:05 UTC | Update Japanese FAQ, backpatch. J.Kuwamura | 11 April 2006, 21:19:05 UTC |
| cc1b59c | Bruce Momjian | 11 April 2006, 21:06:19 UTC | Oops, sysctl, not sysconf, for FreeBSD. | 11 April 2006, 21:06:19 UTC |
| e860973 | Bruce Momjian | 11 April 2006, 19:46:48 UTC | More FreeBSD jail wording improvements. | 11 April 2006, 19:46:48 UTC |
| 493eea6 | Bruce Momjian | 11 April 2006, 19:28:03 UTC | Add documentation about running postmasters in FreeBSD jails (use separate users). | 11 April 2006, 19:28:03 UTC |
| 36d5976 | Bruce Momjian | 11 April 2006, 15:49:04 UTC | There is updated Russian translation of the FAQ in the attachment. Victor Vislobokov | 11 April 2006, 15:49:04 UTC |
| d329913 | Tom Lane | 09 April 2006, 18:18:59 UTC | Revert my best_inner_indexscan patch of yesterday, which turns out to have had a bad side-effect: it stopped finding plans that involved BitmapAnd combinations of indexscans using both join and non-join conditions. Instead, make choose_bitmap_and more aggressive about detecting redundancies between BitmapOr subplans. | 09 April 2006, 18:18:59 UTC |
| 89d75c5 | Tom Lane | 08 April 2006, 21:32:25 UTC | Fix best_inner_indexscan to actually enforce that an "inner indexscan" use at least one join condition as an indexqual. Before bitmap indexscans, this oversight didn't really cost much except for redundantly considering the same join paths twice; but as of 8.1 it could result in silly bitmap scans that would do the same BitmapOr twice and then BitmapAnd these together :-( | 08 April 2006, 21:32:25 UTC |
| cd360f2 | Tom Lane | 07 April 2006, 21:26:42 UTC | Fix pg_dumpall to do something sane when a pre-8.1 installation has identically named user and group: we merge these into a single entity with LOGIN permission. Also, add ORDER BY commands to ensure consistent dump ordering, for ease of comparing outputs from different installations. | 07 April 2006, 21:26:42 UTC |
| a935151 | Andrew Dunstan | 07 April 2006, 17:42:50 UTC | Revert getaddrinfo configure changes until we get a solution that is properly tested on Tru64 - pre recent discussion (or lack thereof) on -hackers. | 07 April 2006, 17:42:50 UTC |
| 23c6f11 | Tom Lane | 07 April 2006, 17:05:47 UTC | Fix make_restrictinfo_from_bitmapqual() to preserve AND/OR flatness of its output, ie, no OR immediately below an OR. Otherwise we get Asserts or wrong answers for cases such as select * from tenk1 a, tenk1 b where (a.ten = b.ten and (a.unique1 = 100 or a.unique1 = 101)) or (a.hundred = b.hundred and a.unique1 = 42); Per report from Rafael Martinez Guerrero. | 07 April 2006, 17:05:47 UTC |
| 69ab90c | Bruce Momjian | 05 April 2006, 22:56:12 UTC | Update AIX FAQ to show readline options more clearly. Backpatch FAQ's to 8.1.X. | 05 April 2006, 22:56:12 UTC |
| 06e4478 | Teodor Sigaev | 03 April 2006, 09:35:35 UTC | Detoast query in g_intbig_consistent and copy query in g_int_consistent. Minor cleanups. | 03 April 2006, 09:35:35 UTC |
| e88d84b | Tom Lane | 02 April 2006, 19:40:02 UTC | Adjust interval-addition test so that it won't fail on DST transition days. Strange that we missed this DST dependence while fixing the others. | 02 April 2006, 19:40:02 UTC |
| 21b54ed | Tom Lane | 30 March 2006, 22:11:59 UTC | Suppress attempts to report dropped tables to the stats collector from a startup or recovery process. Since such a process isn't a real backend, pgstat.c gets confused. This accounts for recent reports of strange "invalid server process ID -1" log messages during crash recovery. There isn't any point in attempting to make the report, since we'll discard stats in such scenarios anyhow. | 30 March 2006, 22:11:59 UTC |
| c119cdc | Tom Lane | 29 March 2006, 15:15:50 UTC | TablespaceCreateDbspace should function normally even on platforms that do not have symlinks (ie, Windows). Although it'll never be called on to do anything useful during normal operation on such a platform, it's still needed to re-create dropped directories during WAL replay. | 29 March 2006, 15:15:50 UTC |
| fdc28fd | Tom Lane | 28 March 2006, 22:01:25 UTC | Disable full_page_writes, because turning it off risks causing crash-recovery failures even when the hardware and OS did nothing wrong. Per recent analysis of a problem report from Alex Bahdushka. For the moment I've just diked out the test of the parameter, rather than removing the GUC infrastructure and documentation, in case we conclude that there's something salvageable there. There seems no chance of it being resurrected in the 8.1 branch though. | 28 March 2006, 22:01:25 UTC |
| 3c3ed28 | Tom Lane | 28 March 2006, 21:17:31 UTC | Repair longstanding error in btree xlog replay: XLogReadBuffer should be passed extend = true whenever we are reading a page we intend to reinitialize completely, even if we think the page "should exist". This is because it might indeed not exist, if the relation got truncated sometime after the current xlog record was made and before the crash we're trying to recover from. These two thinkos appear to explain both of the old bug reports discussed here: http://archives.postgresql.org/pgsql-hackers/2005-05/msg01369.php | 28 March 2006, 21:17:31 UTC |
| df7b5f5 | Tom Lane | 24 March 2006, 23:02:23 UTC | Comments in IndexBuildHeapScan describe the indexing of recently-dead tuples as needed "to keep VACUUM from complaining", but actually there is a more compelling reason to do it: failure to do so violates MVCC semantics. This is because a pre-existing serializable transaction might try to use the index after we finish (re)building it, and it might fail to find tuples it should be able to see. We got this mostly right, but not in the case of partial indexes: the code mistakenly discarded recently-dead tuples for partial indexes. Fix that, and adjust the comments. | 24 March 2006, 23:02:23 UTC |
| db61437 | Tom Lane | 23 March 2006, 04:22:45 UTC | Fix plpgsql to pass only one copy of any given plpgsql variable into a SQL command or expression, rather than one copy for each textual occurrence as it did before. This might result in some small performance improvement, but the compelling reason to do it is that not doing so can result in unexpected grouping failures because the main SQL parser won't see different parameter numbers as equivalent. Add a regression test for the failure case. Per report from Robert Davidson. | 23 March 2006, 04:22:45 UTC |
| a155814 | Tom Lane | 21 March 2006, 19:49:19 UTC | Improve performance of our private version of qsort. Per recent testing, the logic it contained to switch to insertion sort for near-sorted input was in fact a big loss, because it could fairly easily be fooled into applying insertion sort to large subfiles that weren't all that well ordered. Remove that, and instead add a simple check for already-perfectly-sorted input, as per suggestion from Dann Corbit. This adds at worst O(N*lgN) overhead, and usually far less, while sometimes allowing a subfile sort to finish in O(N) time. Preliminary testing says this is an improvement over the basic Bentley & McIlroy code for many nonrandom inputs, and it costs almost nothing when the input is random. | 21 March 2006, 19:49:19 UTC |
| 85fa81f | Michael Meskes | 19 March 2006, 12:29:40 UTC | Fixed bug 2330: Wrong error code in case of a duplicate key | 19 March 2006, 12:29:40 UTC |
| a9f18b9 | Tom Lane | 19 March 2006, 01:19:55 UTC | Adjust join_1.out to match Windows behavior for new mergejoin regression test, per Dave Page and buildfarm. Perhaps we will need a join_2 instead, but for the moment assume that this test tracks the other diffs. | 19 March 2006, 01:19:55 UTC |
| e78be57 | Neil Conway | 18 March 2006, 22:10:11 UTC | The call to DNSServiceRegistrationCreate in postmaster.c does incorrect byte-swapping on the port number which causes the call to fail on Intel Macs. This patch uses htons() instead of htonl() and fixes this bug. Ashley Clark | 18 March 2006, 22:10:11 UTC |
| 8bf221b | Tom Lane | 17 March 2006, 19:38:21 UTC | Fix bug introduced into mergejoin logic by performance improvement patch of 2005-05-13. When we find that a new inner tuple can't possibly match any outer tuple (because it contains a NULL), we can't immediately skip the tuple when we are in NEXTINNER state. Doing so can lead to emitting multiple copies of the tuple in FillInner mode, because we may rescan the tuple after returning to a previous marked tuple. Instead, proceed to NEXTOUTER state the same as we used to do. After we've found that there's no need to return to the marked position, we can go to SKIPINNER_ADVANCE state instead of SKIP_TEST when the inner tuple is unmatchable; this preserves the performance improvement. Per bug report from Bruce. I also made a couple of cosmetic code rearrangements and added a regression test for the problem. | 17 March 2006, 19:38:21 UTC |
| d777a57 | Tom Lane | 10 March 2006, 20:18:25 UTC | Add a CHECK_FOR_INTERRUPTS() in _bt_buildadd(). This fixes problem with not responding to query cancel during the last stage of btree index creation. | 10 March 2006, 20:18:25 UTC |
| effeceb | Tom Lane | 10 March 2006, 15:39:53 UTC | Fix order of linking of libxslt and libxml2, per Dave Page. | 10 March 2006, 15:39:53 UTC |
| 98ab0c9 | Tom Lane | 10 March 2006, 01:51:34 UTC | Add a CHECK_FOR_INTERRUPTS() to the loop in ExecMakeTableFunctionResult. Otherwise you can't cancel queries like select ... from generate_series(1,1000000). | 10 March 2006, 01:51:34 UTC |
| 0a5c6fa | Tom Lane | 08 March 2006, 22:59:17 UTC | Remove somebody's flight of fancy about an UPDATE with ORDER BY and LIMIT. | 08 March 2006, 22:59:17 UTC |
| a0af608 | Bruce Momjian | 06 March 2006, 17:59:42 UTC | * Stephen Frost (sfrost@snowman.net) wrote: > I've now tested this patch at home w/ 8.2HEAD and it seems to fix the > bug. I plan on testing it under 8.1.2 at work tommorow with > mod_auth_krb5, etc, and expect it'll work there. Assuming all goes > well and unless someone objects I'll forward the patch to -patches. > It'd be great to have this fixed as it'll allow us to use Kerberos to > authenticate to phppgadmin and other web-based tools which use > Postgres. While playing with this patch under 8.1.2 at home I discovered a mistake in how I manually applied one of the hunks to fe-auth.c. Basically, the base code had changed and so the patch needed to be modified slightly. This is because the code no longer either has a freeable pointer under 'name' or has 'name' as NULL. The attached patch correctly frees the string from pg_krb5_authname (where it had been strdup'd) if and only if pg_krb5_authname returned a string (as opposed to falling through and having name be set using name = pw->name;). Also added a comment to this effect. Backpatch to 8.1.X. Stephen Frost | 06 March 2006, 17:59:42 UTC |
| a643385 | Bruce Momjian | 05 March 2006, 05:33:19 UTC | Check for "msys" so it doesn't use 'con' by checking for an evironment variable. | 05 March 2006, 05:33:19 UTC |
| 53bbc47 | Tom Lane | 04 March 2006, 19:09:23 UTC | Prevent lazy_space_alloc from making requests that exceed MaxAllocSize, per report from Stefan Kaltenbrunner. | 04 March 2006, 19:09:23 UTC |
| 8ccc7df | Tatsuo Ishii | 04 March 2006, 11:10:44 UTC | Tighten up SJIS byte sequence check. Now we reject invalid SJIS byte sequence such as "0x95 0x27". Patches from Akio Ishida. | 04 March 2006, 11:10:44 UTC |
| cff6806 | Bruce Momjian | 04 March 2006, 04:30:51 UTC | Use DEVTTY as 'con' on Win32 as a replacement for /dev/tty. | 04 March 2006, 04:30:51 UTC |
| e57415c | Bruce Momjian | 03 March 2006, 23:49:21 UTC | Avoid trying to open /dev/tty on Win32. Some Win32 systems have /dev/tty, but it isn't a device file and doesn't work as expected. This fixes a known bug where psql does not prompt for a password on some Win32 systems. Backpatch to 8.1.X. Robert Kinberg | 03 March 2006, 23:49:21 UTC |
| 69c539b | Bruce Momjian | 03 March 2006, 21:52:47 UTC | Update ipcclean to use try 'id' first for root check. | 03 March 2006, 21:52:47 UTC |
| 7a88571 | Bruce Momjian | 03 March 2006, 16:49:30 UTC | In ipcclean, check LOGNAME only if USER is not set. Fixes problem with 'su' on some platforms. | 03 March 2006, 16:49:30 UTC |
| 2c62074 | Bruce Momjian | 03 March 2006, 03:06:17 UTC | Appended is a small documentation patch that adds a note to the CREATE ROLE page, based on what Tom Lane told me here: http://archives.postgresql.org/pgsql-general/2005-11/msg00998.php Joachim Wieland | 03 March 2006, 03:06:17 UTC |
| 69f6980 | Tom Lane | 02 March 2006, 21:49:19 UTC | Fix ancient error in large objects usage example: overwrite() subroutine was opening with INV_READ flag and then writing. Prior to 8.1 the backend did not reject this, but now it does. | 02 March 2006, 21:49:19 UTC |
| 0138fb8 | Tom Lane | 02 March 2006, 21:13:11 UTC | Repair oidvectorrecv and int2vectorrecv, which I broke while changing them to use array_recv :-(. Per report from Tim Kordas. | 02 March 2006, 21:13:11 UTC |
| 5e4bf92 | Bruce Momjian | 02 March 2006, 20:30:33 UTC | Update OS X shared memory documentation for 10.3.9 and later to use /etc/sysctl.conf. Chris Campbell | 02 March 2006, 20:30:33 UTC |
| 3fb582c | Bruce Momjian | 02 March 2006, 19:40:29 UTC | Backpatch to 8.1.X. Already applied to CVS HEAD. --------------------------------------------------------------------------- > True, but they're not being used where you'd expect. This seems to be > something to do with the fact that it's not pg_authid which is being > accessed, but rather the view pg_roles. I looked into this and it seems the problem is that the view doesn't get flattened into the main query because of the has_nullable_targetlist limitation in prepjointree.c. That's triggered because pg_roles has '********'::text AS rolpassword which isn't nullable, meaning it would produce wrong behavior if referenced above the outer join. Ultimately, the reason this is a problem is that the planner deals only in simple Vars while processing joins; it doesn't want to think about expressions. I'm starting to think that it may be time to fix this, because I've run into several related restrictions lately, but it seems like a nontrivial project. In the meantime, reducing the LEFT JOIN to pg_roles to a JOIN as per Peter's suggestion seems like the best short-term workaround. | 02 March 2006, 19:40:29 UTC |
| 006bd45 | Bruce Momjian | 02 March 2006, 19:35:14 UTC | Mark tsearch2 item as Tom's, not Teodor's. | 02 March 2006, 19:35:14 UTC |
| b3c47b1 | Tom Lane | 02 March 2006, 05:34:17 UTC | Fix possible crash at transaction end when a plpgsql function is used and then modified within the same transaction. The code was using a linked list of active PLpgSQL_expr structs, which was OK when it was written because plpgsql never released any parse data structures for the life of the backend. But since Neil fixed plpgsql's memory management, elements of the linked list could be freed, leading to crash when the list is chased. Per report and test case from Kris Jurka. | 02 March 2006, 05:34:17 UTC |
| 15516c5 | Bruce Momjian | 01 March 2006, 22:25:36 UTC | Update FAQ_DEV text file. | 01 March 2006, 22:25:36 UTC |
| 88a4314 | Bruce Momjian | 01 March 2006, 22:23:49 UTC | Update patch generation instructions. Robert Treat | 01 March 2006, 22:23:49 UTC |
| e559dba | Bruce Momjian | 01 March 2006, 20:31:56 UTC | Update Japanese FAQ, backpatched to 8.1.X. | 01 March 2006, 20:31:56 UTC |
| 6853e34 | Bruce Momjian | 01 March 2006, 00:23:33 UTC | Add pg_service.conf documentation for libpq. | 01 March 2006, 00:23:33 UTC |
| 3952eec | Bruce Momjian | 25 February 2006, 04:30:06 UTC | Fix computation of sample table size. | 25 February 2006, 04:30:06 UTC |
| 0328582 | Bruce Momjian | 24 February 2006, 15:00:48 UTC | Backpatch FAQ changes to 8.1.X. | 24 February 2006, 15:00:48 UTC |
| 3982533 | Bruce Momjian | 24 February 2006, 14:03:11 UTC | Mention that the archive history file has the wal start/stop file names. | 24 February 2006, 14:03:11 UTC |
| 400606f | Andrew Dunstan | 24 February 2006, 00:55:27 UTC | make initdb -U username work as advertised; back out bogus patch at rev 1.42 and supply real fix for problem it tried to address. | 24 February 2006, 00:55:27 UTC |
| 05d2a72 | Tom Lane | 23 February 2006, 22:34:07 UTC | Fix vacuumlo to avoid unnecessary use of backslash in search pattern. Per Michael Fuhr. | 23 February 2006, 22:34:07 UTC |
| 6f96c53 | Tom Lane | 21 February 2006, 18:01:41 UTC | Fix old pg_dump oversight: default values for domains really need to be dumped by decompiling the typdefaultbin expression, not just printing the typdefault text which may be out-of-date or assume the wrong schema search path. (It's the same hazard as for adbin vs adsrc in column defaults.) The catalogs.sgml spec for pg_type implies that the correct procedure is to look to typdefaultbin first and consider typdefault only if typdefaultbin is NULL. I made dumping of both domains and base types do that, even though in the current backend code typdefaultbin is always correct for domains and typdefault for base types --- might as well try to future-proof it a little. Per bug report from Alexander Galler. | 21 February 2006, 18:01:41 UTC |
| a386cd7 | Tom Lane | 21 February 2006, 06:07:10 UTC | Adjust probe for getaddrinfo to cope with macro-ized definitions, such as Tru64's. Per previous discussion. | 21 February 2006, 06:07:10 UTC |
| 797deb5 | Neil Conway | 20 February 2006, 20:10:41 UTC | Fix three Python reference leaks in PLy_traceback(). This would result in leaking memory when invoking a PL/Python procedure that raises an exception. Unfortunately this still leaks memory, but at least the largest leak has been plugged. This patch also fixes a reference counting mistake in PLy_modify_tuple() for 8.0, 8.1 and HEAD: we don't actually own a reference to `platt', so we shouldn't Py_DECREF() it. | 20 February 2006, 20:10:41 UTC |
| 3bd549b | Neil Conway | 18 February 2006, 20:48:53 UTC | Patch from Marko Kreen: pgcrypto crypt()/md5 and hmac() leak memory when compiled against OpenSSL as openssl.c digest ->reset will do two DigestInit calls against a context. This happened to work with OpenSSL 0.9.6 but not with 0.9.7+. Reason for the messy code was that I tried to avoid creating wrapper structure to transport algorithm info and tried to use OpenSSL context for it. The fix is to create wrapper structure. It also uses newer digest API to avoid memory allocations on reset with newer OpenSSLs. Thanks to Daniel Blaisdell for reporting it. | 18 February 2006, 20:48:53 UTC |
| 4fc6585 | Tom Lane | 14 February 2006, 17:20:10 UTC | Move btbulkdelete's vacuum_delay_point() call to a place in the loop where we are not holding a buffer content lock; where it was, InterruptHoldoffCount is positive and so we'd not respond to cancel signals as intended. Also add missing vacuum_delay_point() call in btvacuumcleanup. This should fix complaint from Evgeny Gridasov about failure to respond to SIGINT/SIGTERM in a timely fashion (bug #2257). | 14 February 2006, 17:20:10 UTC |
| efaac13 | Tom Lane | 14 February 2006, 16:39:36 UTC | Add some missing vacuum_delay_point calls in GIST vacuuming. | 14 February 2006, 16:39:36 UTC |
| d8882a2 | Tom Lane | 13 February 2006, 16:22:29 UTC | Fix qual_is_pushdown_safe to not try to push down quals involving a whole-row Var referencing the subselect output. While this case could possibly be made to work, it seems not worth expending effort on. Per report from Magnus Naeslund(f). | 13 February 2006, 16:22:29 UTC |
| d72c32a | Tom Lane | 12 February 2006, 22:37:44 UTC | Stamp 8.1.3. | 12 February 2006, 22:37:44 UTC |
| ef434eb | Tom Lane | 12 February 2006, 22:35:36 UTC | Update release notes. | 12 February 2006, 22:35:36 UTC |
