Skip to main content

Browse the archive

https://github.com/postgres/postgres
02 May 2024, 11:03:54 UTC
sort by:
Revision Author Date Message Commit Date
2ff326d Tom Lane 28 August 2017, 21:19:22 UTC Stamp 10beta4. 28 August 2017, 21:19:22 UTC
7dadf7a Tom Lane 28 August 2017, 15:40:47 UTC Doc: adjust release-note credit for parallel pg_restore fix. Discussion: https://postgr.es/m/CAFcNs+pJ6_Ud-zg3vY_Y0mzfESdM34Humt8avKrAKq_H+v18Cg@mail.gmail.com 28 August 2017, 15:40:47 UTC
89f6d58 Peter Eisentraut 28 August 2017, 14:34:14 UTC Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 31ad7831c3018858b662ed1d26a6c3bfe92b4e1f 28 August 2017, 14:50:13 UTC
df44405 Tom Lane 28 August 2017, 14:14:20 UTC Fix over-aggressive sanity check in misc_sanity.sql. Fix thinko in commit 8be8510cf: it's okay to have dbid == 0 in normal (non-pin) entries in pg_shdepend, because global objects such as databases are entered that way. The test would pass so long as it was run in a cluster containing no databases/tablespaces owned by, or granted to, roles other than the bootstrap superuser. That's the expected situation for "make check", but for "make installcheck", not so much. Reported by Ryan Murphy. Discussion: https://postgr.es/m/CAHeEsBc6EQe0mxGBKDXAwJbntgfvoAd5MQC-5362SmC3Tng_6g@mail.gmail.com 28 August 2017, 14:14:47 UTC
5ecd7cc Peter Eisentraut 28 August 2017, 01:29:54 UTC Clarify documentation Discussion: https://www.postgresql.org/message-id/flat/20170618071607.GA16418%40nol.local 28 August 2017, 01:30:59 UTC
947a0cc Tom Lane 27 August 2017, 21:35:04 UTC Release notes for 9.6.5, 9.5.9, 9.4.14, 9.3.19, 9.2.23. 27 August 2017, 21:35:04 UTC
5a62735 Tom Lane 26 August 2017, 20:50:19 UTC Doc: update v10 release notes through today. 26 August 2017, 20:50:19 UTC
145ca36 Peter Eisentraut 26 August 2017, 13:21:46 UTC pg_test_timing: Some NLS fixes The string "% of total" was marked by xgettext to be a c-format, but it is actually not, so mark up the source to prevent that. Compute the column widths of the final display dynamically based on the translated strings, so that translations don't mess up the display accidentally. 26 August 2017, 15:31:07 UTC
3460728 Robert Haas 25 August 2017, 19:07:44 UTC Improve low-level backup documentation. Our documentation hasn't really caught up with the fact that non-exclusive backups can now be taken using pg_start_backup and pg_stop_backup even on standbys. Update, also correcting some errors introduced by 52f8a59dd953c6820baf153e97cf07d31b8ac1d6. Updates to the 9.6 documentation are needed as well, but that will need a separate patch as some things are different on that version. David Steele, reviewed by Robert Haas and Michael Paquier Discussion: http://postgr.es/m/d4d951b9-89c0-6bc1-b6ff-d0b2dd5a8966@pgmasters.net 25 August 2017, 19:20:26 UTC
33043c6 Peter Eisentraut 25 August 2017, 16:02:29 UTC pg_upgrade: Remove more dead code related to 6ce6a61840cc90172ad3da7bf303656132fa5fab Reported-by: Christoph Berg <myon@debian.org> 25 August 2017, 16:25:51 UTC
9c57848 Peter Eisentraut 25 August 2017, 15:49:05 UTC Message translatability fixes 25 August 2017, 16:25:51 UTC
1563b8f Andres Freund 24 August 2017, 22:07:40 UTC Fix harmless thinko in dsa.c. Commit 16be2fd100199bdf284becfcee02c5eb20d8a11d added DSA_ALLOC_HUGE, DSA_ALLOC_ZERO and DSA_ALLOC_NO_OOM which have the same numerical values and meanings as the similarly named MCXT_... macros. In one place we accidentally used MCXT_ALLOC_NO_OOM when DSA_ALLOC_NO_OOM is wanted, so tidy that up. Author: Thomas Munro Discussion: http://postgr.es/m/CAEepm=2AimHxVkkxnMfQvbZMkXy0uKbVa0-D38c5-qwrCm4CMQ@mail.gmail.com Backpatch: 10, where dsa was introduced. 24 August 2017, 22:09:54 UTC
51d0fa8 Stephen Frost 24 August 2017, 20:20:48 UTC psql: Fix \gx when FETCH_COUNT is used Set expanded output when requested through \gx in ExecQueryUsingCursor() (used when FETCH_COUNT is set). Discussion: https://www.postgresql.org/message-id/CB7A53AA-5645-4BDD-AB07-4D22CD9D8FF1%40gmx.net Author: Tobias Bussmann 24 August 2017, 20:20:48 UTC
8a7beca Peter Eisentraut 24 August 2017, 19:29:35 UTC pg_upgrade: Remove dead code Remove code meant for upgrading to a particular version of PostgreSQL 9.0. Since pg_upgrade only supports upgrading to the current major version, this code is no longer useful. 24 August 2017, 19:30:31 UTC
cf98e38 Peter Eisentraut 24 August 2017, 18:04:28 UTC Increase SCRAM salt length The original value 12 was set based on RFC 5802 for SCRAM-SHA-1, but RFC 7677 for SCRAM-SHA-256 uses 16, so use that. (This does not affect the validity of already stored verifiers.) Discussion: https://www.postgresql.org/message-id/flat/12cc9297-7e05-932f-d863-765e5626ead4%402ndquadrant.com 24 August 2017, 18:08:23 UTC
d51b087 Peter Eisentraut 23 August 2017, 18:59:25 UTC Update code comment for temporary replication slots Reported-by: Alvaro Herrera <alvherre@2ndquadrant.com> 23 August 2017, 18:59:55 UTC
da19c32 Peter Eisentraut 23 August 2017, 18:19:35 UTC Fix outdated comment Author: Thomas Munro <thomas.munro@enterprisedb.com> 23 August 2017, 18:20:08 UTC
8bf9469 Peter Eisentraut 23 August 2017, 16:01:43 UTC Tweak some SCRAM error messages and code comments Clarify/correct some error messages, fix up some code comments that confused SASL and SCRAM, and other minor fixes. No changes in functionality. 23 August 2017, 16:29:47 UTC
5e87f7b Peter Eisentraut 23 August 2017, 13:56:38 UTC Fix translation marker This was erroneously removed in 55a70a023c3daefca9bbd68bfbe6862af10ab479. 23 August 2017, 13:57:59 UTC
2ac307b Peter Eisentraut 23 August 2017, 00:32:17 UTC pg_upgrade: Message translatability and style fixes 23 August 2017, 00:33:57 UTC
adce891 Peter Eisentraut 22 August 2017, 23:55:21 UTC doc: Mention identity column feature in section on serial Reported-by: Basil Bourque <basil.bourque@pobox.com> 22 August 2017, 23:56:16 UTC
d34a74d Andres Freund 22 August 2017, 14:46:05 UTC Backpatch introduction of TupleDescAttr(tupdesc, i). 2cd70845240 / c6293249d change the way individual attributes in a TupleDesc are stored / accessed. To reduce the effort of making extensions compatible with postgresql 11, and to ease future backpatching, backpatch introduction of TupleDescAttr() to all releases. Do not backpatch change in storage, as that'd be a breaking change for existing and working extensions. Author: Andres Freund Discussion: https://postgr.es/m/20170820181723.tdswdinzptbcwhrr@alap3.anarazel.de Backpatch: 9.2- 22 August 2017, 14:46:05 UTC
958ffb8 Peter Eisentraut 21 August 2017, 15:22:00 UTC Don't install ICU collation keyword variants Users can still create them themselves. Instead, document Unicode TR 35 collation options for ICU, so users can create all this themselves. Reviewed-by: Peter Geoghegan <pg@bowt.ie> 21 August 2017, 23:21:14 UTC
a79fb8e Peter Eisentraut 21 August 2017, 13:17:06 UTC Expand set of predefined ICU locales Install language+region combinations even if they are not distinct from the language's base locale. This gives better long-term stability of the set of predefined locales and makes the predefined locales less implementation-dependent and more practical for users. Reviewed-by: Peter Geoghegan <pg@bowt.ie> 21 August 2017, 23:21:14 UTC
b8a2549 Noah Misch 21 August 2017, 04:22:18 UTC Inject $(ICU_LIBS) regardless of platform. It appeared in a conditional that excludes AIX, Cygwin and MinGW. Give ICU support a chance to work on those platforms. Back-patch to v10, where ICU support was introduced. 21 August 2017, 04:22:33 UTC
1c3869c Tom Lane 19 August 2017, 17:39:37 UTC Fix possible core dump in parallel restore when using a TOC list. Commit 3eb9a5e7c unintentionally introduced an ordering dependency into restore_toc_entries_prefork(). The existing coding of reduce_dependencies() contains a check to skip moving a TOC entry to the ready_list if it wasn't initially in the pending_list. This used to suffice to prevent reduce_dependencies() from trying to move anything into the ready_list during restore_toc_entries_prefork(), because the pending_list stayed empty throughout that phase; but it no longer does. The problem doesn't manifest unless the TOC has been reordered by SortTocFromFile, which is how I missed it in testing. To fix, just add a test for ready_list == NULL, converting the call with NULL from a poor man's sanity check into an explicit command not to touch TOC items' list membership. Clarify some of the comments around this; in particular, note the primary purpose of the check for pending_list membership, which is to ensure that we can't try to restore the same item twice, in case a TOC list forces it to be restored before its dependency count goes to zero. Per report from Fabrízio de Royes Mello. Back-patch to 9.3, like the previous commit. Discussion: https://postgr.es/m/CAFcNs+pjuv0JL_x4+=71TPUPjdLHOXA4YfT32myj_OrrZb4ohA@mail.gmail.com 19 August 2017, 17:39:52 UTC
7c84acc Peter Eisentraut 19 August 2017, 03:02:28 UTC Fix creation of ICU comments for keyword variants It would create the comment referring to the keyword-less parent locale. This was broken in ddb5fdc068635d003a0d1c303cb109d1cb3ebeb1. 19 August 2017, 03:04:28 UTC
d4b42e5 Robert Haas 18 August 2017, 17:01:05 UTC Fix interaction of triggers, partitioning, and EXPLAIN ANALYZE. Add a new EState member es_leaf_result_relations, so that the trigger code knows about ResultRelInfos created by tuple routing. Also make sure ExplainPrintTriggers knows about partition-related ResultRelInfos. Etsuro Fujita, reviewed by Amit Langote Discussion: http://postgr.es/m/57163e18-8e56-da83-337a-22f2c0008051@lab.ntt.co.jp 18 August 2017, 17:06:25 UTC
9b64474 Tom Lane 17 August 2017, 22:35:14 UTC Temporarily revert test case from a2b70c89ca1a5fcf6181d3c777d82e7b83d2de1b. That code patch was good as far as it went, but the associated test case has exposed fundamental brain damage in the parallel scan mechanism, which is going to take nontrivial work to correct. In the interests of getting the buildfarm back to green so that unrelated work can proceed, let's temporarily remove the test case. 17 August 2017, 22:36:19 UTC
7c0ca29 Robert Haas 17 August 2017, 19:39:17 UTC Don't lock tables in RelationGetPartitionDispatchInfo. Instead, lock them in the caller using find_all_inheritors so that they get locked in the standard order, minimizing deadlock risks. Also in RelationGetPartitionDispatchInfo, avoid opening tables which are not partitioned; there's no need. Amit Langote, reviewed by Ashutosh Bapat and Amit Khandekar Discussion: http://postgr.es/m/91b36fa1-c197-b72f-ca6e-56c593bae68c@lab.ntt.co.jp 17 August 2017, 19:47:29 UTC
de1ca69 Tom Lane 17 August 2017, 17:49:22 UTC Fix ExecReScanGatherMerge. Not surprisingly, since it'd never ever been tested, ExecReScanGatherMerge didn't work. Fix it, and add a regression test case to exercise it. Amit Kapila Discussion: https://postgr.es/m/CAA4eK1JkByysFJNh9M349u_nNjqETuEnY_y1VUc_kJiU0bxtaQ@mail.gmail.com 17 August 2017, 17:49:31 UTC
1d7a479 Tom Lane 17 August 2017, 17:13:47 UTC Further tweaks to compiler flags for PL/Perl on Windows. It now emerges that we can only rely on Perl to tell us we must use -D_USE_32BIT_TIME_T if it's Perl 5.13.4 or later. For older versions, revert to our previous practice of assuming we need that symbol in all 32-bit Windows builds. This is not ideal, but inquiring into which compiler version Perl was built with seems far too fragile. In any case, we had not previously had complaints about these old Perl versions, so let's assume this is Good Enough. (It's still better than the situation ante commit 5a5c2feca, in that at least the effects are confined to PL/Perl rather than the whole PG build.) Back-patch to all supported versions, like 5a5c2feca and predecessors. Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com 17 August 2017, 17:13:56 UTC
ca49d69 Peter Eisentraut 17 August 2017, 15:39:00 UTC doc: Update RFC URLs Consistently use the IETF HTML links instead of a random mix of different sites and formats. Correct one RFC number and fix one broken link. 17 August 2017, 15:47:43 UTC
b469387 Robert Haas 17 August 2017, 15:19:07 UTC Remove bogus line from comment. Spotted by Tom Lane Discussion: http://postgr.es/m/27897.1502901074@sss.pgh.pa.us 17 August 2017, 15:19:37 UTC
28c5655 Peter Eisentraut 17 August 2017, 14:37:12 UTC doc: Fix table column count Author: Erik Rijkers <er@xs4all.nl> 17 August 2017, 14:37:58 UTC
e4892c6 Peter Eisentraut 16 August 2017, 23:46:50 UTC pg_dump: Support using synchronized snapshots on standbys This became possible by commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f. This just makes pg_dump aware of it and updates the documentation. Author: Petr Jelinek <petr.jelinek@2ndquadrant.com> 16 August 2017, 23:49:17 UTC
0c16efc Peter Eisentraut 16 August 2017, 18:44:26 UTC doc: Update URL of DocBook XSL stylesheets Author: Masahiko Sawada <sawada.mshk@gmail.com> 16 August 2017, 18:46:20 UTC
2327690 Peter Eisentraut 16 August 2017, 17:59:40 UTC doc: Add logical replication to comparison matrix Author: Steve Singer <steve@ssinger.info> 16 August 2017, 18:00:12 UTC
a6b174f Michael Meskes 15 August 2017, 14:06:56 UTC Allow continuation lines in ecpg cppline parsing. 16 August 2017, 11:27:21 UTC
226be40 Peter Eisentraut 16 August 2017, 01:05:21 UTC Initialize replication_slot_catalog_xmin in procarray Although not confirmed and probably rare, if the newly allocated memory is not already zero, this could possibly have caused some problems. Also reorder the initializations slightly so they match the order of the struct definition. Author: Wong, Yi Wen <yiwong@amazon.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> 16 August 2017, 01:05:59 UTC
3ea5821 Peter Eisentraut 15 August 2017, 23:27:22 UTC Include foreign tables in information_schema.table_privileges This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin <nicolas.thauvin@dalibo.com> 15 August 2017, 23:30:35 UTC
7502f39 Peter Eisentraut 15 August 2017, 23:10:38 UTC psql: Add tab completion for \pset pager Author: Pavel Stehule <pavel.stehule@gmail.com> 15 August 2017, 23:12:32 UTC
f2f9fcb Alvaro Herrera 15 August 2017, 21:14:07 UTC Simplify autovacuum work-item implementation The initial implementation of autovacuum work-items used a dynamic shared memory area (DSA). However, it's argued that dynamic shared memory is not portable enough, so we cannot rely on it being supported everywhere; at the same time, autovacuum work-items are now a critical part of the server, so it's not acceptable that they don't work in the cases where dynamic shared memory is disabled. Therefore, let's fall back to a simpler implementation of work-items that just uses autovacuum's main shared memory segment for storage. Discussion: https://postgr.es/m/CA+TgmobQVbz4K_+RSmiM9HeRKpy3vS5xnbkL95gSEnWijzprKQ@mail.gmail.com 15 August 2017, 21:14:07 UTC
edbad25 Peter Eisentraut 15 August 2017, 20:20:20 UTC Fix logical replication protocol comparison logic Since we currently only have one protocol, this doesn't make much of a difference other than the error message. Author: Yugo Nagata <nagata@sraoss.co.jp> 15 August 2017, 20:20:20 UTC
0cafc26 Peter Eisentraut 15 August 2017, 19:36:18 UTC doc: Add missing logical replication protocol message Author: Masahiko Sawada <sawada.mshk@gmail.com> 15 August 2017, 19:36:45 UTC
292d9b6 Peter Eisentraut 15 August 2017, 19:13:06 UTC Simplify some code in logical replication launcher Avoid unnecessary locking calls when a subscription is disabled. Author: Yugo Nagata <nagata@sraoss.co.jp> 15 August 2017, 19:14:08 UTC
4e7cd03 Peter Eisentraut 15 August 2017, 18:37:44 UTC doc: Improve PDF bookmarks Also create PDF bookmarks/ToC entries for subsections of reference pages. This was a regression from the previous jadetex-based build. Reported-by: Erik Rijkers <er@xs4all.nl> 15 August 2017, 18:47:03 UTC
870da1e Alvaro Herrera 15 August 2017, 16:35:12 UTC Fix error handling path in autovacuum launcher The original code (since 00e6a16d01) was assuming aborting the transaction in autovacuum launcher was sufficient to release all resources, but in reality the launcher runs quite a lot of code out of any transactions. Re-introduce individual cleanup calls to make abort more robust. Reported-by: Robert Haas Discussion: https://postgr.es/m/CA+TgmobQVbz4K_+RSmiM9HeRKpy3vS5xnbkL95gSEnWijzprKQ@mail.gmail.com 15 August 2017, 16:35:12 UTC
d7ab908 Tom Lane 15 August 2017, 15:07:52 UTC Distinguish wait-for-connection from wait-for-write-ready on Windows. The API for WaitLatch and friends followed the Unix convention in which waiting for a socket connection to complete is identical to waiting for the socket to accept a write. While Windows provides a select(2) emulation that agrees with that, the native WaitForMultipleObjects API treats them as quite different --- and for some bizarre reason, it will report a not-yet-connected socket as write-ready. libpq itself has so far escaped dealing with this because it waits with select(), but in libpqwalreceiver.c we want to wait using WaitLatchOrSocket. The semantics mismatch resulted in replication connection failures on Windows, but only for remote connections (apparently, localhost connections complete immediately, or at least too fast for anyone to have noticed the problem in single-machine testing). To fix, introduce an additional WL_SOCKET_CONNECTED wait flag for WaitLatchOrSocket, which is identical to WL_SOCKET_WRITEABLE on non-Windows, but results in waiting for FD_CONNECT events on Windows. Ideally, we would also distinguish the two conditions in the API for PQconnectPoll(), but changing that API at this point seems infeasible. Instead, cheat by checking for PQstatus() == CONNECTION_STARTED to determine that we're still waiting for the connection to complete. (This is a cheat mainly because CONNECTION_STARTED is documented as an internal state rather than something callers should rely on. Perhaps we ought to change the documentation ... but this patch doesn't.) Per reports from Jobin Augustine and Igor Neyman. Back-patch to v10 where commit 1e8a85009 exposed this longstanding shortcoming. Andres Freund, minor fix and some code review/beautification by me Discussion: https://postgr.es/m/CAHBggj8g2T+ZDcACZ2FmzX9CTxkWjKBsHd6NkYB4i9Ojf6K1Fw@mail.gmail.com 15 August 2017, 15:08:25 UTC
17a2a27 Robert Haas 15 August 2017, 13:16:33 UTC Avoid unnecessary single-child Append nodes. Before commit d3cc37f1d801a6b5cad9bf179274a8, an inheritance parent whose only children were temp tables of other sessions would end up as a simple scan of the parent; but with that commit, we end up with an Append node, per a report from Ashutosh Bapat. Tweak the logic so that we go back to the old way, and update the function header comment for partitioning while we're at it. Ashutosh Bapat, reviewed by Amit Langote and adjusted by me. Discussion: http://postgr.es/m/CAFjFpReWJr1yTkHU=OqiMBmcYCMoSW3VPR39RBuQ_ovwDFBT5Q@mail.gmail.com 15 August 2017, 13:35:32 UTC
2999063 Robert Haas 15 August 2017, 12:06:36 UTC Add missing call to ExecReScanGatherMerge. Amit Kapila Discussion: http://postgr.es/m/CAA4eK1KeQWZOoDmDmGMwuqzPW9JhRS+ditQVFdAfGjNmMZzqMQ@mail.gmail.com 15 August 2017, 12:07:29 UTC
ee5572e Andres Freund 14 August 2017, 22:21:26 UTC Expand coverage of parallel gather merge a bit. Previously paths reaching heap_compare_slots weren't covered. Author: Rushabh Lathia Reviewed-By: Andres Freund Discussion: https://postgr.es/m/CAGPqQf3C+3PBujb+7m=ceWeii4-vBY=XS99LjzrpkpefvzJbFg@mail.gmail.com https://postgr.es/m/27200.1502482851@sss.pgh.pa.us Backpatch: 10, where gather merge was introduced 14 August 2017, 22:27:48 UTC
21d304d Tom Lane 14 August 2017, 21:29:33 UTC Final pgindent + perltidy run for v10. 14 August 2017, 21:29:33 UTC
5b6289c Tom Lane 14 August 2017, 19:43:20 UTC Handle elog(FATAL) during ROLLBACK more robustly. Stress testing by Andreas Seltenreich disclosed longstanding problems that occur if a FATAL exit (e.g. due to receipt of SIGTERM) occurs while we are trying to execute a ROLLBACK of an already-failed transaction. In such a case, xact.c is in TBLOCK_ABORT state, so that AbortOutOfAnyTransaction would skip AbortTransaction and go straight to CleanupTransaction. This led to an assert failure in an assert-enabled build (due to the ROLLBACK's portal still having a cleanup hook) or without assertions, to a FATAL exit complaining about "cannot drop active portal". The latter's not disastrous, perhaps, but it's messy enough to want to improve it. We don't really want to run all of AbortTransaction in this code path. The minimum required to clean up the open portal safely is to do AtAbort_Memory and AtAbort_Portals. It seems like a good idea to do AtAbort_Memory unconditionally, to be entirely sure that we are starting with a safe CurrentMemoryContext. That means that if the main loop in AbortOutOfAnyTransaction does nothing, we need an extra step at the bottom to restore CurrentMemoryContext = TopMemoryContext, which I chose to do by invoking AtCleanup_Memory. This'll result in calling AtCleanup_Memory twice in many of the paths through this function, but that seems harmless and reasonably inexpensive. The original motivation for the assertion in AtCleanup_Portals was that we wanted to be sure that any user-defined code executed as a consequence of the cleanup hook runs during AbortTransaction not CleanupTransaction. That still seems like a valid concern, and now that we've seen one case of the assertion firing --- which means that exactly that would have happened in a production build --- let's replace the Assert with a runtime check. If we see the cleanup hook still set, we'll emit a WARNING and just drop the hook unexecuted. This has been like this a long time, so back-patch to all supported branches. Discussion: https://postgr.es/m/877ey7bmun.fsf@ansel.ydns.eu 14 August 2017, 19:43:20 UTC
7f1bb1d Peter Eisentraut 14 August 2017, 17:53:05 UTC Fix typo Author: Masahiko Sawada <sawada.mshk@gmail.com> 14 August 2017, 17:53:05 UTC
79e5de6 Peter Eisentraut 14 August 2017, 17:42:03 UTC doc: Fix logical replication protocol doc detail Author: Masahiko Sawada <sawada.mshk@gmail.com> Reported-by: Kyle Conroy <kyle@kyleconroy.com> Bug: #14775 14 August 2017, 17:42:03 UTC
5a5c2fe Tom Lane 14 August 2017, 15:48:59 UTC Absorb -D_USE_32BIT_TIME_T switch from Perl, if relevant. Commit 3c163a7fc's original choice to ignore all #define symbols whose names begin with underscore turns out to be too simplistic. On Windows, some Perl installations are built with -D_USE_32BIT_TIME_T, and we must absorb that or we get the wrong result for sizeof(PerlInterpreter). This effectively re-reverts commit ef58b87df, which injected that symbol in a hacky way, making it apply to all of Postgres not just PL/Perl. More significantly, it did so on *all* 32-bit Windows builds, even when the Perl build to be used did not select this option; so that it fails to work properly with some newer Perl builds. By making this change, we would be introducing an ABI break in 32-bit Windows builds; but fortunately we have not used type time_t in any exported Postgres APIs in a long time. So it should be OK, both for PL/Perl itself and for third-party extensions, if an extension library is built with a different _USE_32BIT_TIME_T setting than the core code. Patch by me, based on research by Ashutosh Sharma and Robert Haas. Back-patch to all supported branches, as commit 3c163a7fc was. Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com 14 August 2017, 15:48:59 UTC
ea0ca75 Michael Meskes 14 August 2017, 09:29:34 UTC Changed ecpg parser to allow RETURNING clauses without attached C variables. 14 August 2017, 09:29:34 UTC
004a970 Tom Lane 13 August 2017, 20:15:14 UTC Remove AtEOXact_CatCache(). The sole useful effect of this function, to check that no catcache entries have positive refcounts at transaction end, has really been obsolete since we introduced ResourceOwners in PG 8.1. We reduced the checks to assertions years ago, so that the function was a complete no-op in production builds. There have been previous discussions about removing it entirely, but consensus up to now was that it had some small value as a cross-check for bugs in the ResourceOwner logic. However, it now emerges that it's possible to trigger these assertions if you hit an assert-enabled backend with SIGTERM during a call to SearchCatCacheList, because that function temporarily increases the refcounts of entries it's intending to add to a catcache list construct. In a normal ERROR scenario, the extra refcounts are cleaned up by SearchCatCacheList's PG_CATCH block; but in a FATAL exit we do a transaction abort and exit without ever executing PG_CATCH handlers. There's a case to be made that this is a generic hazard and we should consider restructuring elog(FATAL) handling so that pending PG_CATCH handlers do get run. That's pretty scary though: it could easily create more problems than it solves. Preliminary stress testing by Andreas Seltenreich suggests that there are not many live problems of this ilk, so we rejected that idea. There are more-localized ways to fix the problem; the most principled one would be to use PG_ENSURE_ERROR_CLEANUP instead of plain PG_TRY. But adding cycles to SearchCatCacheList isn't very appealing. We could also weaken the assertions in AtEOXact_CatCache in some more or less ad-hoc way, but that just makes its raison d'etre even less compelling. In the end, the most reasonable solution seems to be to just remove AtEOXact_CatCache altogether, on the grounds that it's not worth trying to fix it. It hasn't found any bugs for us in many years. Per report from Jeevan Chalke. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAM2+6=VEE30YtRQCZX7_sCFsEpoUkFBV1gZazL70fqLn8rcvBA@mail.gmail.com 13 August 2017, 20:15:14 UTC
2336f84 Alvaro Herrera 13 August 2017, 01:36:07 UTC Reword comment for clarity Reported by Masahiko Sawada Discussion: https://postgr.es/m/CAD21AoB+ycZ2z-4Ye=6MfQ_r0aV5r6cvVPw4kOyPdp6bHqQoBQ@mail.gmail.com 13 August 2017, 03:26:35 UTC
e88928c Noah Misch 13 August 2017, 01:19:49 UTC Fix vertical spanning in table "wait_event Description". Michael Paquier Discussion: https://postgr.es/m/CAB7nPqQr3KEQvXeuUNYcm7tDK2Fb9oLUQ8DU0+y0RZEoN_1_gg@mail.gmail.com 13 August 2017, 01:19:49 UTC
3043c1d Tom Lane 12 August 2017, 16:08:54 UTC Simplify fetch-slot-xmins logic in recovery TAP tests. Merge wait_slot_xmins() into get_slot_xmins(). At this point the only place that wasn't doing a wait was the initial-state test, and a wait there seems pretty harmless. Michael Paquier Discussion: https://postgr.es/m/CAB7nPqSp_SLQb2uU7am+sn4V3g1UKv8j3yZU385oAG1cG_BN9Q@mail.gmail.com 12 August 2017, 16:08:54 UTC
d6ecad8 Tom Lane 11 August 2017, 21:39:27 UTC Be more thorough about cleaning out gcov litter. At least on my machine, a run with code coverage enabled produces some ".gcov" files whose names begin with ".". "rm -f *.gcov" fails to match those, so they don't get cleaned up by "make clean". Fix it. 11 August 2017, 21:39:27 UTC
3c8de95 Tom Lane 11 August 2017, 21:27:54 UTC Add regression tests exercising more code paths in nodeLimit.c. Perusal of the code coverage report shows that the existing regression test cases for LIMIT/OFFSET don't exercise the nodeLimit code paths involving backwards scan, empty results, or null values of LIMIT/OFFSET. Improve the coverage. 11 August 2017, 21:28:01 UTC
6efca23 Tom Lane 11 August 2017, 20:52:12 UTC Add regression tests exercising the non-hashed code paths in nodeSetop.c. Perusal of the code coverage report shows that the existing regression test cases for INTERSECT and EXCEPT seemingly all prefer the SETOP_HASHED implementation. Add some test cases in which we force use of the SETOP_SORTED mode. 11 August 2017, 21:28:01 UTC
ee844bb Peter Eisentraut 11 August 2017, 20:40:56 UTC doc: Add example for inet vs cidr difference Reported-by: kes-kes@yandex.ru 11 August 2017, 20:40:56 UTC
fa65c8c Peter Eisentraut 11 August 2017, 20:14:55 UTC doc: Update description of rolreplication column Since PostgreSQL 9.6, rolreplication no longer determines whether a role can run pg_start_backup() and pg_stop_backup(), so remove that. Add that this attribute determines whether a role can create and drop replication slots. Reported-by: Fujii Masao <masao.fujii@gmail.com> 11 August 2017, 20:14:55 UTC
22701a7 Peter Eisentraut 11 August 2017, 19:52:39 UTC doc: Small wording improvement Author: Jeff Janes <jeff.janes@gmail.com> 11 August 2017, 19:52:39 UTC
d4ede66 Peter Eisentraut 11 August 2017, 19:44:10 UTC pg_upgrade: Clarify one message Reported-by: Dennis Björklund <db@zigo.dhs.org> 11 August 2017, 19:44:10 UTC
7968184 Tom Lane 11 August 2017, 19:19:40 UTC Remove pgbench's restriction on placement of -M switch. Previously the -M switch had to appear before any switch that directly or indirectly specified a benchmarking script. This was both confusing and inadequately documented, as per gripe from Tatsuo Ishii. We can remove the restriction at the cost of making an extra pass over the lists of SQL commands, which seems like a cheap price (the string scans themselves likely cost much more). The change is just to not extract parameters from the SQL commands until we have finished parsing the switches and know the final value of -M. Per discussion, we'll treat this as a low-grade bug fix and sneak it into v10, rather than holding it for v11. Tom Lane, reviewed by Tatsuo Ishii and Fabien Coelho Discussion: https://postgr.es/m/20170802.110328.1963639094551443169.t-ishii@sraoss.co.jp Discussion: https://postgr.es/m/10208.1502465077@sss.pgh.pa.us 11 August 2017, 19:19:40 UTC
a1ef920 Peter Eisentraut 07 August 2017, 21:42:47 UTC Remove uses of "slave" in replication contexts This affects mostly code comments, some documentation, and tests. Official APIs already used "standby". 11 August 2017, 02:55:41 UTC
d6391b0 Peter Eisentraut 10 August 2017, 00:34:51 UTC Reject use of ucol_strcollUTF8() before ICU 53 Various bugs can cause crashes, so don't use that function before ICU 53. It will fall back to the code path used for other encodings. Since we now tie the function availability to an ICU version, we don't need the configure test anymore. That also resolves the issue that the test result was previously hardcoded for Windows. researched by Daniel Verite <daniel@manitou-mail.org>, Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/f1438ec6-22aa-4029-9a3b-26f79d330e72%40manitou-mail.org 11 August 2017, 02:14:00 UTC
b83e545 Peter Eisentraut 10 August 2017, 00:28:49 UTC Fix order of ICU_CFLAGS It must be before CPPFLAGS so that an ICU installation in a nonstandard path can take precedence over one in the system path. 11 August 2017, 02:14:00 UTC
bb5d6e8 Robert Haas 10 August 2017, 17:44:30 UTC Improve the error message when creating an empty range partition. The previous message didn't mention the name of the table or the bounds. Put the table name in the primary error message and the bounds in the detail message. Amit Langote, changed slightly by me. Suggestions on the exac phrasing from Tom Lane, David G. Johnston, and Dean Rasheed. Discussion: http://postgr.es/m/CA+Tgmoae6bpwVa-1BMaVcwvCCeOoJ5B9Q9-RHWo-1gJxfPBZ5Q@mail.gmail.com 10 August 2017, 17:46:56 UTC
c1ef4e5 Robert Haas 10 August 2017, 17:22:31 UTC Make some more improvements to parallel query documentation. Many places that mentioned only Gather should also mention Gather Merge, or should be phrased in a more neutral way. Be more clear about the fact that max_parallel_workers_per_gather affects the number of workers the planner may want to use. Fix a typo. Explain how Gather Merge works. Adjust wording around parallel scans to be a bit more clear. Adjust wording around parallel-restricted operations for the fact that uncorrelated subplans are no longer restricted. Patch by me, reviewed by Erik Rijkers Discussion: http://postgr.es/m/CA+TgmoZsTjgVGn=ei5ht-1qGFKy_m1VgB3d8+Rg304hz91N5ww@mail.gmail.com 10 August 2017, 17:22:31 UTC
e694010 Robert Haas 10 August 2017, 17:14:47 UTC Fix typo in comment. Etsuro Fujita Discussion: http://postgr.es/m/5f794b91-67df-1ac6-8a4f-069f8e8e169d@lab.ntt.co.jp 10 August 2017, 17:14:47 UTC
0b7ba3d Robert Haas 10 August 2017, 15:48:42 UTC pgstatindex: Insert some casts to prevent overflow. This could cause hash indexes to report greater than 100% free space. Ashutosh Sharma, reviewed by Amit Kapila Discussion: http://postgr.es/m/CAE9k0PnCKfg-ZK1CwGZJPF1yKcG2A=GUgC3BMdNMzLAXVOo4Eg@mail.gmail.com 10 August 2017, 15:48:42 UTC
ec99dd5 Robert Haas 10 August 2017, 15:20:57 UTC Remove incorrect assertion in clog.c We must advance the oldest XID that can be safely looked up in clog *before* truncating CLOG, and the oldest XID that can't be reused *after* truncating CLOG. This assertion, and the accompanying comment, are confused; remove them. Reported by Neha Sharma. Discussion: http://postgr.es/m/CANiYTQumC3T=UMBMd1Hor=5XWZYuCEQBioL3ug0YtNQCMMT5wQ@mail.gmail.com 10 August 2017, 15:20:57 UTC
749c7c4 Tom Lane 09 August 2017, 21:03:09 UTC Fix handling of container types in find_composite_type_dependencies. find_composite_type_dependencies correctly found columns that are of the specified type, and columns that are of arrays of that type, but not columns that are domains or ranges over the given type, its array type, etc. The most general way to handle this seems to be to assume that any type that is directly dependent on the specified type can be treated as a container type, and processed recursively (allowing us to handle nested cases such as ranges over domains over arrays ...). Since a type's array type already has such a dependency, we can drop the existing special case for the array type. The very similar logic in get_rels_with_domain was likewise a few bricks shy of a load, as it supposed that a directly dependent type could *only* be a sub-domain. This is already wrong for ranges over domains, and it'll someday be wrong for arrays over domains. Add test cases illustrating the problems, and back-patch to all supported branches. Discussion: https://postgr.es/m/15268.1502309024@sss.pgh.pa.us 09 August 2017, 21:03:09 UTC
a76200d Tom Lane 09 August 2017, 16:05:53 UTC Prevent passing down MAKELEVEL/MAKEFLAGS from non-GNU make to GNU make. FreeBSD's make, for one, sets the MAKELEVEL environment variable when invoking commands. In the special Makefile we provide to hand off control from a non-GNU make to GNU make, this causes GNU make to think it is a child make invocation rather than top-level. That interferes with the hack added in commit dcae5facc to cause the temp-install tree to be made only by the top-level invocation of gmake. Unset the variable to prevent that. Likewise unset MAKEFLAGS, which FreeBSD's make also sets, and which could easily confuse gmake. There are no reports of actual trouble from that, but it seems better to be proactive. Back-patch to 9.5 where dcae5facc came in. Thomas Munro, hacked a bit more by me Discussion: https://postgr.es/m/CAEepm=1ueww35AXTkt1A3gyzZUqv5XCzh8RUNvJZAQAW=eOhVw@mail.gmail.com 09 August 2017, 16:05:53 UTC
13f03a0 Peter Eisentraut 08 August 2017, 23:18:16 UTC doc: Add missing pieces to logical replication protocol doc Reported-by: Kyle Conroy <kyle@kyleconroy.com> 08 August 2017, 23:22:23 UTC
9bf4068 Tom Lane 08 August 2017, 23:18:11 UTC Fix datumSerialize infrastructure to not crash on non-varlena data. Commit 1efc7e538 did a poor job of emulating existing logic for touching Datums that might be expanded-object pointers. It didn't check for typlen being -1 first, which meant it could crash on fixed-length pass-by-ref values, and probably on cstring values as well. It also didn't use DatumGetPointer before VARATT_IS_EXTERNAL_EXPANDED, which while currently harmless is not according to documentation nor prevailing style. I also think the lack of any explanation as to why datumSerialize makes these particular nonobvious choices is pretty awful, so fix that. Per report from Jarred Ward. Back-patch to 9.6 where this code came in. Discussion: https://postgr.es/m/6F61E6D2-2F5E-4794-9479-A429BE1CEA4B@simple.com 08 August 2017, 23:18:22 UTC
77d2c00 Alvaro Herrera 08 August 2017, 22:46:16 UTC Reword some unclear comments 08 August 2017, 22:48:01 UTC
f5d54ef Alvaro Herrera 08 August 2017, 22:31:39 UTC Fix typo in comment 08 August 2017, 22:34:25 UTC
4576a69 Tom Lane 08 August 2017, 22:03:30 UTC Fix yet another race condition in recovery/t/001_stream_rep.pl. In commit 5c77690f6, we added polling in front of most of the get_slot_xmins calls in 001_stream_rep.pl, but today's results from buildfarm member nightjar show that at least one more poll loop is needed. Proactively add a poll loop before the next-to-last get_slot_xmins call as well. It may be that there is no race condition there because the standby_2 server is shut down at that point, but I'm quite tired of fighting with this test script. The empirical evidence that it's safe, from the buildfarm, is no stronger than the evidence for the other call that nightjar just proved unsafe. The only remaining get_slot_xmins calls without wait_slot_xmins protection are the first two, which should be OK since nothing has happened at that point. It's tempting to ignore that special case and merge get_slot_xmins and wait_slot_xmins into a single function. I didn't go that far though. Discussion: https://postgr.es/m/18436.1502228036@sss.pgh.pa.us 08 August 2017, 22:03:30 UTC
b2c95a3 Alvaro Herrera 08 August 2017, 20:07:46 UTC Fix replication origin-related race conditions Similar to what was fixed in commit 9915de6c1cb2 for replication slots, but this time it's related to replication origins: DROP SUBSCRIPTION attempts to drop the replication origin, but that fails if the replication worker process hasn't yet marked it unused. This causes failures in the buildfarm: ERROR: could not drop replication origin with OID 1, in use by PID 34069 Like the aforementioned commit, fix by having the process running DROP SUBSCRIPTION sleep until the worker marks the the replication origin struct as free. This uses a condition variable on each replication origin shmem state struct, so that the session trying to drop can sleep and expect to be awakened by the process keeping the origin open. Also fix a SGML markup in the previous commit. Discussion: https://postgr.es/m/20170808001433.rozlseaf4m2wkw3n@alvherre.pgsql 08 August 2017, 20:07:46 UTC
030273b Alvaro Herrera 08 August 2017, 19:37:44 UTC Fix inadequacies in recently added wait events In commit 9915de6c1cb2, we introduced a new wait point for replication slots and incorrectly labelled it as wait event PG_WAIT_LOCK. That's wrong, so invent an appropriate new wait event instead, and document it properly. While at it, fix numerous other problems in the vicinity: - two different walreceiver wait events were being mixed up in a single wait event (which wasn't documented either); split it out so that they can be distinguished, and document the new events properly. - ParallelBitmapPopulate was documented but didn't exist. - ParallelBitmapScan was not documented (I think this should be called "ParallelBitmapScanInit" instead.) - Logical replication wait events weren't documented - various symbols had been added in dartboard order in various places. Put them in alphabetical order instead, as was originally intended. Discussion: https://postgr.es/m/20170808181131.mu4fjepuh5m75cyq@alvherre.pgsql 08 August 2017, 19:37:44 UTC
b4a2eea Noah Misch 08 August 2017, 00:16:21 UTC Disclaim xmltable() support for non-UTF8 databases. The xmltable() implementation mirrors xpath(), including its lack of character encoding awareness. 08 August 2017, 00:16:21 UTC
8d64423 Tom Lane 07 August 2017, 21:08:19 UTC Stamp 10beta3. 07 August 2017, 21:08:19 UTC
8014d2a Tom Lane 07 August 2017, 20:42:18 UTC Skip test for IPC::Run if user is overriding our search for PROVE. The check for IPC::Run we added in commit c254970ad is useful in simple cases, but there are real use-cases where "prove" is coming from a different Perl installation than the "perl" we want to use to build. In such cases asking whether "perl" knows about IPC::Run is irrelevant and can cause an unnecessary configure failure. Hence, if user has specified a value for PROVE, skip the IPC::Run check. Per discussion with Andrew Dunstan. Discussion: https://postgr.es/m/E1dcE5n-0005Sk-UE@gemulon.postgresql.org 07 August 2017, 20:42:18 UTC
cdc47d1 Peter Eisentraut 07 August 2017, 18:30:24 UTC Update SQL features list 07 August 2017, 18:30:24 UTC
f7668b2 Peter Eisentraut 07 August 2017, 17:55:34 UTC Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 1a0b5e655d7871506c2b1c7ba562c2de6b6a55de 07 August 2017, 17:55:34 UTC
a8b37eb Tom Lane 07 August 2017, 15:46:20 UTC Last-minute updates for release notes. Security: CVE-2017-7546, CVE-2017-7547, CVE-2017-7548 07 August 2017, 15:46:56 UTC
fca17a9 Peter Eisentraut 07 August 2017, 14:49:08 UTC Fix local/remote attribute mix-up in logical replication This would lead to failures if local and remote tables have a different column order. The tests previously didn't catch that because they only tested the initial data copy. So add another test that exercises the apply worker. Author: Petr Jelinek <petr.jelinek@2ndquadrant.com> 07 August 2017, 14:49:08 UTC
0e58455 Peter Eisentraut 07 August 2017, 14:28:35 UTC Fix handling of dropped columns in logical replication The relation attribute map was not initialized for dropped columns, leading to errors later on. Author: Petr Jelinek <petr.jelinek@2ndquadrant.com> Reported-by: Scott Milliken <scott@deltaex.com> Bug: #14769 07 August 2017, 14:28:35 UTC
8d98819 Tom Lane 07 August 2017, 14:19:01 UTC Require update permission for the large object written by lo_put(). lo_put() surely should require UPDATE permission, the same as lowrite(), but it failed to check for that, as reported by Chapman Flack. Oversight in commit c50b7c09d; backpatch to 9.4 where that was introduced. Tom Lane and Michael Paquier Security: CVE-2017-7548 07 August 2017, 14:19:19 UTC
e568e1e Noah Misch 07 August 2017, 14:09:28 UTC Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the current user is the subject of a mapping yet has no server privileges. user_mapping_options emits no rows for such a mapping, but pg_user_mappings includes full umoptions. Change pg_user_mappings to show null for umoptions. Back-patch to 9.2, like the above commit. Reviewed by Tom Lane. Reported by Jeff Janes. Security: CVE-2017-7547 07 August 2017, 14:09:28 UTC
bf6b9e9 Heikki Linnakangas 07 August 2017, 14:03:42 UTC Don't allow logging in with empty password. Some authentication methods allowed it, others did not. In the client-side, libpq does not even try to authenticate with an empty password, which makes using empty passwords hazardous: an administrator might think that an account with an empty password cannot be used to log in, because psql doesn't allow it, and not realize that a different client would in fact allow it. To clear that confusion and to be be consistent, disallow empty passwords in all authentication methods. All the authentication methods that used plaintext authentication over the wire, except for BSD authentication, already checked that the password received from the user was not empty. To avoid forgetting it in the future again, move the check to the recv_password_packet function. That only forbids using an empty password with plaintext authentication, however. MD5 and SCRAM need a different fix: * In stable branches, check that the MD5 hash stored for the user does not not correspond to an empty string. This adds some overhead to MD5 authentication, because the server needs to compute an extra MD5 hash, but it is not noticeable in practice. * In HEAD, modify CREATE and ALTER ROLE to clear the password if an empty string, or a password hash that corresponds to an empty string, is specified. The user-visible behavior is the same as in the stable branches, the user cannot log in, but it seems better to stop the empty password from entering the system in the first place. Secondly, it is fairly expensive to check that a SCRAM hash doesn't correspond to an empty string, because computing a SCRAM hash is much more expensive than an MD5 hash by design, so better avoid doing that on every authentication. We could clear the password on CREATE/ALTER ROLE also in stable branches, but we would still need to check at authentication time, because even if we prevent empty passwords from being stored in pg_authid, there might be existing ones there already. Reported by Jeroen van der Ham, Ben de Graaff and Jelte Fennema. Security: CVE-2017-7546 07 August 2017, 14:03:42 UTC
86524f0 Peter Eisentraut 07 August 2017, 13:49:55 UTC Fix function name in code comment Reported-by: Peter Geoghegan <pg@bowt.ie> 07 August 2017, 13:49:55 UTC
ad2ca3c Peter Eisentraut 07 August 2017, 13:40:12 UTC Improve wording of subscription refresh debug messages Reported-by: Yugo Nagata <nagata@sraoss.co.jp> 07 August 2017, 13:40:12 UTC
back to top