https://github.com/ProgVal/Limnoria

sort by:
Revision Author Date Message Commit Date
2293d1c Services: Update to the latest version of the draft/account-registration spec. 15 June 2021, 18:35:55 UTC
67a39a3 Fix joins to many channels (#1473) * Fix joins to many channels If you have enough channels that the 512 byte message limit on the JOIN message is hit then limnoria was losing the channel that put it over the limit and not including it in the next JOIN message. This resulted in losing one channel for every JOIN message that pushed us over 512 bytes. We fix this by generating the JOIN message immediately after resetting the channels list to ensure we include the channel that pushed us over the limit. Then the next time through our JOIN msg construction we'll add subsequent channels without forgetting the one that pushed us over. * Add test for channel join lists This adds a test for the issue that is fixed in the previous commit. We ensure that when JOINs are split over multiple messages we JOIN to all channels that were part of the input list and don't forget any of them. 14 June 2021, 21:15:43 UTC
4b82934 Services: Add @nickserv and @chanserv command, to message services directly This is because the recommended method ('owner ircquote nickserv register mypassword bot@example.com') does not work on charybdis, as Limnoria inserts a colon before the trailing argument and Charybdis' m_alias module does not parse commands using the IRC syntax, so it considers the leading colon to be part of the email address. The alternative would be to change the recommended command to: 'owner ircquote PRIVMSG nickserv :register mypassword bot@example.com' but it is prone to typos, so I think we should avoid it. 14 June 2021, 19:47:36 UTC
c8053da Socket: Silence TLS warning for Tor hidden services. They are already end-to-end encrypted and don't need TLS. 12 June 2021, 19:03:15 UTC
69c948b irclib: fix _getTarget when to= is given and self.private=True 08 June 2021, 19:56:42 UTC
8a52902 irclib: Fix overhead computation by using the real target computation algo 08 June 2021, 19:56:08 UTC
225c249 irclib: Fix crash on SASL authentication failure 05 June 2021, 13:50:05 UTC
ac4083e README: Synchronize description with the website. 05 June 2021, 08:29:21 UTC
aaca81c drivers: Fix log message when the STS policy uses the same port as configured. 02 June 2021, 14:51:09 UTC
a475814 Factoids: Fix NameErrors in HTTP callback. 01 June 2021, 10:16:34 UTC
4caf35f Dunno: Document command substitution 01 June 2021, 08:43:05 UTC
a0b1334 increase the timeout for Fediverse's tests At least in Debian CI they routinely timeout when they run in the busiest server. Signed-off-by: Mattia Rizzolo <mattia@mapreri.org> 01 June 2021, 06:58:56 UTC
43aada5 Store ignored hostmasks in Expiring HostmaskSet to prevent their pattern cache from expiring too soon See e0fdcb67c09b26a79bbb3cbb2244d18149c5b0c2 for the rationale (tl;dr: prevents triggering a degenerate case of the LRU cache when there are over 1000 ignore masks) 30 May 2021, 17:35:05 UTC
698dfc2 httpserver: Hide well-known callback from the index Closes GH-1460. 29 May 2021, 09:44:22 UTC
2e2c243 RSS: Remove flaky test 28 May 2021, 17:37:37 UTC
b8852eb RSS: Fix nondeterministic test failure 28 May 2021, 17:15:56 UTC
758f9be RSS: Catch errors from update_feed(), just in case feedparser should always catch the error, but someone reported it doesn't catch this error on TLS cert issues: ``` Traceback (most recent call last): File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner self.run() File "/usr/lib/python3.8/threading.py", line 870, in run self._target(*self._args, **self._kwargs) File "/home/falso/virtualenv/limnoria/lib/python3.8/site-packages/supybot/plugins/RSS/plugin.py", line 86, in newf f(*args, **kwargs) File "/home/falso/virtualenv/limnoria/lib/python3.8/site-packages/supybot/plugins/RSS/plugin.py", line 351, in update_feeds self.update_feed_if_needed(feed) File "/home/falso/virtualenv/limnoria/lib/python3.8/site-packages/supybot/plugins/RSS/plugin.py", line 337, in update_feed_if_needed self.update_feed(feed) File "/home/falso/virtualenv/limnoria/lib/python3.8/site-packages/supybot/plugins/RSS/plugin.py", line 311, in update_feed d = feedparser.parse(feed.url, etag=feed.etag, File "/home/falso/virtualenv/limnoria/lib/python3.8/site-packages/feedparser/api.py", line 214, in parse data = _open_resource(url_file_stream_or_string, etag, modified, agent, referrer, handlers, request_headers, result) File "/home/falso/virtualenv/limnoria/lib/python3.8/site-packages/feedparser/api.py", line 114, in _open_resource return http.get(url_file_stream_or_string, etag, modified, agent, referrer, handlers, request_headers, result) File "/home/falso/virtualenv/limnoria/lib/python3.8/site-packages/feedparser/http.py", line 158, in get f = opener.open(request) File "/usr/lib/python3.8/urllib/request.py", line 525, in open response = self._open(req, data) File "/usr/lib/python3.8/urllib/request.py", line 542, in _open result = self._call_chain(self.handle_open, protocol, protocol + File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain result = func(*args) File "/usr/lib/python3.8/urllib/request.py", line 1393, in https_open return self.do_open(http.client.HTTPSConnection, req, File "/usr/lib/python3.8/urllib/request.py", line 1354, in do_open r = h.getresponse() File "/usr/lib/python3.8/http/client.py", line 1347, in getresponse response.begin() File "/usr/lib/python3.8/http/client.py", line 307, in begin version, status, reason = self._read_status() File "/usr/lib/python3.8/http/client.py", line 268, in _read_status line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1") File "/usr/lib/python3.8/socket.py", line 669, in readinto return self._sock.recv_into(b) File "/usr/lib/python3.8/ssl.py", line 1241, in recv_into return self.read(nbytes, buffer) File "/usr/lib/python3.8/ssl.py", line 1099, in read return self._sslobj.read(len, buffer) socket.timeout: The read operation timed out ``` So let's catch the error just in case, so it doesn't block all other feeds. 28 May 2021, 16:48:35 UTC
3415cd0 RSS: Add test checking exception from a feed doesn't affect other feeds. 28 May 2021, 16:38:06 UTC
7c68b2c RSS: Fix crash in @rss list 28 May 2021, 15:56:59 UTC
86b1741 Fix nondeterministic test on Python < 3.7. 27 May 2021, 20:36:27 UTC
e0fdcb6 Store IrcUser hostmasks in HostmaskSet to prevent their pattern cache from expiring When the number of hostmasks exceeds 1000 (the hardcoded size of _patternCache and _hostmaskPatternEqualCache), this triggers a pathological case in the LRU caches, that causes all calls to be a cache miss. This means that on every IRC message received, ircdb.checkIgnored triggers a recompilation of *all* user hostmasks, which is very expensive computationally. This commit stores them in their own cache to prevent them from expiring. 27 May 2021, 20:15:52 UTC
a5cd870 irclib: Refactor hostmaskPatternEqual to expose compileHostmaskPattern. This clarifies the code a bit. And I want to store compiled patterns in ircdb.User in a future commit, so they can outlive the LRU cache. 27 May 2021, 19:36:43 UTC
711db72 Socket: Fix crash non-TLS connections when using a SOCKS proxy 26 May 2021, 23:08:33 UTC
3bedc86 Socket: Disable resolution when using a SOCKS proxy 1. Avoids leaking DNS queries 2. necessary for onion services 26 May 2021, 22:08:02 UTC
cca1156 drivers: Log SOCKS proxy on connecting 26 May 2021, 21:43:23 UTC
c3f39fc callbacks, Misc, Relay: Fix when the message prefix is just a nick <user> and <host> are optional in https://datatracker.ietf.org/doc/html/rfc1459#section-2.3.1 Closes GH-1451. 26 May 2021, 15:50:29 UTC
e59e0f6 irclib: Fix target computation It mistakenly used the bot's nick as target when the message is in private, so 'more' after a private message always answered the user did not send a command before (because said command was attributed to the bot) 25 May 2021, 22:30:27 UTC
710d16f Admin: Fix python 3.4 support. 25 May 2021, 17:24:21 UTC
fa3707e src/conf.py: add :port to explanation of networks.X.socksproxy 25 May 2021, 16:58:35 UTC
fd97f78 Admin: Fix @acmd 25 May 2021, 07:22:24 UTC
1455a83 Merge branch 'nopassword' into testing 24 May 2021, 22:12:36 UTC
d913032 ircdb: Fix 'IrcUser.nicks' on non-lowercase network names This dict was filled with IrcString keys, which is hashed as lowercase, so when queried with a non-lowercase string, the key would not be found, and lead to very confusing errors. 24 May 2021, 15:21:57 UTC
742f4f8 Add the option to disable password login. Actually resolves GH-1140, finally. 23 May 2021, 13:33:38 UTC
04facad Move official channel from Freenode to Libera.Chat 22 May 2021, 16:51:54 UTC
14e637f SedRegex: Fix NameError in config setup 22 May 2021, 16:51:35 UTC
fb16e8b Network: Fix IPv6 parsing 22 May 2021, 16:51:22 UTC
7af8918 Channel: Fix Nameerror in @alert. Closes GH-1452 17 May 2021, 16:24:37 UTC
8559ea9 httpserver: Fix pointless tracebacks because doGet does not accept the 'form' argument 17 May 2021, 16:24:21 UTC
db99332 callback: Fix AssertionError when action is given with implicit noLengthCheck 07 May 2021, 18:10:57 UTC
e3fce56 Relay: Don't relay QUIT/NICK if the sender isn't in the relayed channel. 03 May 2021, 18:02:33 UTC
ca369af Relay: Send the right network in the display name (was dest instead of source) 02 May 2021, 16:34:49 UTC
fc2e349 Relay: Implement +draft/display-name specification. https://github.com/ircv3/ircv3-specifications/pull/452 02 May 2021, 15:14:20 UTC
97a7aa3 RSS: Make @remove completely clean up feeds 01 May 2021, 12:29:09 UTC
556bd78 RSS: Default to setting announces per channel+network, instead of just per channel The default behavior was to announce feeds on all channels with the same name, which is rarely what was expected. Instead, this limits it to the current network. 01 May 2021, 11:31:34 UTC
435f8de RSS: Fix bug in @remove that prevented it from fully deleting aliased feeds. 01 May 2021, 11:27:56 UTC
e96633c RSS: Forbid dots in feed names. They confuse the registry 28 April 2021, 18:04:58 UTC
3d21c7c Services: Keep per-network state separate Until now, only `waitingJoins` was stored separately per network, while `channels`, `sentGhost` and `identified` had one common value per plugin instance. Instead of making everything a dictionary indexed by network name like `waitingJoins`, let's bundle all the state together in a class and store *its* instances in such a dictionary. This fixes at least one race condition, for which a test case was added. Even with `noJoinsUntilIdentified` set, the bot would let joins through as long as *any* one network has already finished identifying. 27 April 2021, 17:52:58 UTC
177c202 irclib: Fix crash caused by 4d2efc65ef26f4c49d893a520c36830e600dad56. dynamicScope inspects the stack looking for this variable, so we need to keep it. 24 April 2021, 19:21:57 UTC
8a4e8c2 Services: Reset configured passwords in tests I didn't observe any error with the current set of tests but adding another one that used "services password" caused oen of these tests to fail. Given that tests shouldn't leave traces in global state, let's reset the configured passwords in finally blocks. 24 April 2021, 19:13:53 UTC
151fcf8 Don't throttle when delay is exactly equal If throttle time is set to 0.0 (e.g. in tests) and the reported time since last dequeue is also 0.0 (maybe because the timer resolution is too low), takeMsg would throttle. This would make tests fail because they expect messages immediately. This issue was observed on Windows 10 20H2 with both a mingw-w64 Python v3.8.9 from MSYS2 and several version of official Python v3.x. Confirmed at least as far back as aa98d987a7f4db6e57b5b8489ca714d98c6b8452. Since it's a non-integer comparison, the change shouldn't have any observable effect in normal operation. 24 April 2021, 19:04:42 UTC
dce969e tests: Pass setUp arguments ChannelPluginTestCase#setUp accepts the same parameters as its super-method PluginTestCase#setUp, but it didn't pass the arguments down the line. Now it does. 24 April 2021, 19:03:48 UTC
abac830 Admin: Merge tests with the same name into one 24 April 2021, 19:03:13 UTC
4d2efc6 Remove some unused names 24 April 2021, 19:01:40 UTC
e740953 Fix some typos 24 April 2021, 19:01:07 UTC
fec6959 all plugins: regenerate READMEs 21 April 2021, 22:29:15 UTC
e16c10f supybot-plugin-doc: Recursively document *all* groups Not just groups that are values themselves. 21 April 2021, 22:28:40 UTC
c7d85e7 httpserver, Fediverse: show an error message on 404 18 April 2021, 14:25:37 UTC
a209b73 Fediverse: Remove duplicate documentation 18 April 2021, 13:36:18 UTC
82fbfcf all plugins: regenerate READMEs 17 April 2021, 18:09:33 UTC
b0cdf47 Fediverse: Move Secure Fetch documentation to the 'Usage' section 17 April 2021, 18:08:33 UTC
3c1c4a6 callbacks: Make snarfers' output paginatable with @more by moving the 'smart' reply() method from NestedCommandsIrcProxy to ReplyIrcProxy. There is no reason only commands should have a paginated output and not snarfers defined in PluginRegexp. 16 April 2021, 21:38:44 UTC
24ca278 Reorganize the kwargs of _sendReply I think it's more readable and modular this way 16 April 2021, 21:11:02 UTC
ab3dbcf Fix computation of message overhead in multiline batches. 16 April 2021, 21:09:01 UTC
6b1460e Log loading times for each plugin It makes it easier to debug long startup times. 11 April 2021, 14:35:42 UTC
fd873fa httpserver: Don't serve_forever when documenting 1. it binds the port, which is useless while documenting 2. in some circumstances, it prevents supybot-plugin-doc from exiting (because the server threads are still running) 11 April 2021, 11:24:10 UTC
9869136 src/setup: Add support for ReST readmes by default 11 April 2021, 08:38:05 UTC
cd02444 supybot-plugin-doc: Add labels for all command and config variables So they can be referenced from elsewhere in the doc. 05 April 2021, 22:33:07 UTC
4fc6580 callbacks: Document replySuccess() and error() 05 April 2021, 20:47:44 UTC
f11684a callbacks: Add/improve method docstrings 05 April 2021, 18:34:49 UTC
66ba7cb Plugin: Only show the first paragraph; as the whole help can be very long. 05 April 2021, 15:42:40 UTC
833af36 all plugins: auto-generate READMEs Starting with this commit, there should be no "original" text in READMEs. Instead, the entire text should be in docstrings, and READMEs should be automatically generated from these docstrings. Motivation: * The same help is available both via IRC and in the README (although the README can be more detailed, as only the first paragraph will be shown on IRC) * This will allow auto-generating plugin help on docs.limnoria.net using the same content as the README, as it's sourced from the docstrings Additionally, this converts all READMEs from Markdown to ReST, because the documentation already uses ReST, and other docstrings in the codebase are in ReST for this reason. 05 April 2021, 15:42:31 UTC
76b6c56 supybot-plugin-doc: Fix various edge case issues in the ReST output 05 April 2021, 15:40:57 UTC
113fc74 Relay: Mention other plugins in the README. 05 April 2021, 13:54:13 UTC
21657f3 Aka, Alias: Remove mentions of Alias in the Aka documentation, and explain Alias is deprecated 05 April 2021, 13:00:02 UTC
49eef1c Misc: Make @help mention '@plugin help' when relevant. 05 April 2021, 12:39:41 UTC
9323302 Socket: Recover from socks.GeneralProxyError exceptions. 05 April 2021, 11:41:29 UTC
16fc2ae supybot-plugin-doc: Add option --output-filename It can be used like this to generate README.rst files: ``` supybot-plugin-doc --plugins-dir plugins/ --format rst --output-filename='plugins/$name/README.$format' ``` 05 April 2021, 10:27:33 UTC
524e409 supybot-plugin-doc: Fix bugs with --plugins-dir 05 April 2021, 10:26:47 UTC
6b9de3d supybot-plugin-doc: Add explicit target for each plugin reference It can be useful to reference it from elsewhere in the doc 05 April 2021, 10:26:47 UTC
5b98503 supybot-plugin-doc: Add config option for the page title 05 April 2021, 09:32:09 UTC
a7fb46f supybot-plugin-doc: Update value of supybot.databases Required for Aka, etc. 05 April 2021, 09:31:43 UTC
24f20dc Factoids, Services: Fix crash when imported by supybot-plugin-doc 05 April 2021, 09:30:59 UTC
c28d517 irclib: Copy messages before altering them at all Fixes a bug triggered by Relay when it relays to a network that supports labeled-response and an other that doesn't 02 April 2021, 18:54:21 UTC
b030a7b callbacks: Fix py 3.4 support 01 April 2021, 18:10:17 UTC
d452a70 callbacks: Don't write nick prefixes in the middle of multiline messages. 01 April 2021, 18:10:17 UTC
911f875 PluginDownloader: Change default branch from master to HEAD Many people are renaming their default branches from master to main or something else (I just renamed mine). Using HEAD works no matter what the default branch is named. 01 April 2021, 18:10:17 UTC
a003eff Config: Document network-specific variables in @list output 01 April 2021, 18:10:17 UTC
41c5589 utils.str: Rely only on the documented methods of textwrap.TextWrapper. '_split_chunks()' should be fine, but '_wrap_chunks()' is the only one explicitly documented as overridable, so it's probably safer to use. 01 April 2021, 18:10:17 UTC
91a4083 Misc: Clamp the number of lines returned by @more to the draft/multiline max-lines value, if any. 01 April 2021, 18:10:17 UTC
bbc2e9d irclib: 'lift' message tags to the batch when sending a multiline batch 01 April 2021, 18:10:17 UTC
92399bb drivers: Don't strip all whitespaces before parsing messages. They matter in multiline messages, and there isn't much point to stripping them anyway. 01 April 2021, 18:10:17 UTC
7cb3ae1 Misc: Make @more reply in batches when possible. 01 April 2021, 18:10:17 UTC
bf90a7c callbacks: Make reply() send multiline batches when supybot.reply.mores.instant > 1 01 April 2021, 18:10:17 UTC
d5d2298 irclib: Remove special-casing of the last instant message in _sendReply There is no reason for it to be special; and this special-casing would be annoying when we add support for outgoing multiline batches. 01 April 2021, 18:10:17 UTC
de29218 irclib: Make NestedCommandsIrcProxy._replyOverhead count in bytes instead of chars It was, once again, a bug to count characters, because they might contain multi-byte characters, and truncation happens after the 512th byte. 01 April 2021, 18:10:17 UTC
8a3efe4 irclib: Split _sendReply from NestedCommandsIrcProxy.reply This function was getting uncomfortably big. 01 April 2021, 18:10:17 UTC
5676183 Add tests + fix bugs 01 April 2021, 18:10:17 UTC
99a6a7c raise exceptions instead of logging, so we get a helpful traceback 01 April 2021, 18:10:16 UTC
c7939d3 [wip] typo 01 April 2021, 18:10:16 UTC
26f2d9a [wip] idea for ordering batches in Irc.queue 01 April 2021, 18:10:16 UTC
back to top